[Libreoffice-bugs] [Bug 97354] formula is hidden when conditional format dialogue box is opened
https://bugs.documentfoundation.org/show_bug.cgi?id=97354 --- Comment #9 from l...@royal.net --- Still not fixed, still annoying in Version: 7.1.1.2 / LibreOffice Community Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5 Locale: en-GB (en_GB.UTF-8); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140961] LO Writer: Frames are converted into text box when saving in .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=140961 --- Comment #4 from Telesto --- I don't repro. Navigator shows Frame when exporting to DOCX. Frame does look slightly different compared to ODT. But no clue what the cause of that is Biggest problem, outer border is lacking Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: dc3b64dcbfb0a49c0be65bd8d73ed4e6d3828a21 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140966] Frame changes position after DOCX save
https://bugs.documentfoundation.org/show_bug.cgi?id=140966 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0961 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140961] LO Writer: Frames are converted into text box when saving in .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=140961 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0966 --- Comment #3 from Telesto --- Note: Did find another issue; frame moving to different position: bug 140966 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140966] New: Frame changes position after DOCX save
https://bugs.documentfoundation.org/show_bug.cgi?id=140966 Bug ID: 140966 Summary: Frame changes position after DOCX save Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Frame changes position after DOCX save Steps to Reproduce: 1. Open attachment 170412 2. Save as DOCX 3. File reload Actual Results: Frame moves up (outside page margins) Expected Results: Stays within Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: dc3b64dcbfb0a49c0be65bd8d73ed4e6d3828a21 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140950] Blue screen shows as soon as I try to open LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=140950 --- Comment #3 from Mike Kaganski --- By the way, you have mentioned a *blue screen* (a system STOP error?), but provided a screenshot of a dialog with an error. Please describe which blue screen do you mean, and provide screenshots of it (e.g. taken from screen using a camera), or the error codes shown there. Thanks! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/uitest/calc_tests3/tdf89754.py | 45 --- sc/qa/unit/ucalc.cxx | 15 +++ 2 files changed, 15 insertions(+), 45 deletions(-) New commits: commit d8e1892d7dd3eb5d4724ef32ce7a110a0087d9e1 Author: Xisco Fauli AuthorDate: Thu Mar 11 17:22:19 2021 +0100 Commit: Xisco Fauli CommitDate: Fri Mar 12 08:51:03 2021 +0100 tdf#89754: sc_ucalc: Fix test The original UItest added in 3ba901f050d262cdeccefa5b21b0d32aa7332dc7 < tdf#89754 - don't increment non different consecutive date cells > didn't fail without the fix in place Change-Id: I297f9b3fe713910c1ed40b2de560171911b1ba79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112357 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sc/qa/uitest/calc_tests3/tdf89754.py b/sc/qa/uitest/calc_tests3/tdf89754.py deleted file mode 100644 index 855688c8f45b.. --- a/sc/qa/uitest/calc_tests3/tdf89754.py +++ /dev/null @@ -1,45 +0,0 @@ -# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*- -# -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. -# -from uitest.framework import UITestCase -from uitest.uihelper.common import get_state_as_dict -from uitest.uihelper.calc import enter_text_to_cell -from libreoffice.calc.document import get_cell_by_position -from libreoffice.uno.propertyvalue import mkPropertyValues - -#tdf#89754 - EDITING: 'Autofill - Date' don't increment non different consecutive date cells - -class tdf89754(UITestCase): - -def test_tdf89754_autofill_date(self): -calc_doc = self.ui_test.create_doc_in_start_center("calc") -xCalcDoc = self.xUITest.getTopFocusWindow() -gridwin = xCalcDoc.getChild("grid_window") -document = self.ui_test.get_component() - -#1 - A1: 2012-10-31 and A2: 2012-10-31 -enter_text_to_cell(gridwin, "A1", "2012-10-31") -enter_text_to_cell(gridwin, "A2", "2012-10-31") - -#2 - Select A1:A5 -gridwin.executeAction("SELECT", mkPropertyValues({"RANGE": "A1:A5"})) - -#3 - Edit -> fill -> Series -> Down -self.ui_test.execute_dialog_through_command(".uno:FillSeries") -xDialog = self.xUITest.getTopFocusWindow() -xOK = xDialog.getChild("ok") -self.ui_test.close_dialog_through_button(xOK) - -#4 - Expected: All Cells show the initial date -self.assertEqual(get_cell_by_position(document, 0, 0, 0).getValue(), 41213) -self.assertEqual(get_cell_by_position(document, 0, 0, 1).getValue(), 41213) -self.assertEqual(get_cell_by_position(document, 0, 0, 2).getValue(), 41213) -self.assertEqual(get_cell_by_position(document, 0, 0, 3).getValue(), 41213) -self.assertEqual(get_cell_by_position(document, 0, 0, 4).getValue(), 41213) - -self.ui_test.close_doc() - -# vim: set shiftwidth=4 softtabstop=4 expandtab: diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index 460f85f302c5..b7e89b71fb94 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -4920,6 +4920,21 @@ void Test::testAutoFill() CPPUNIT_ASSERT_EQUAL(aExpected, aFormula); } +// Clear column A for a new test. +clearRange(m_pDoc, ScRange(0,0,0,0,MAXROW,0)); +m_pDoc->SetRowHidden(0, MAXROW, 0, false); // Show all rows. + +m_pDoc->SetString( 0, 100, 0, "2012-10-31" ); +m_pDoc->SetString( 0, 101, 0, "2012-10-31" ); +m_pDoc->Fill( 0, 100, 0, 101, nullptr, aMarkData, 3, FILL_TO_BOTTOM, FILL_AUTO ); + +// tdf#89754, Without the fix in place, this test would have failed with +// - Expected: 2012-10-31 +// - Actual : 2012-11-01 +CPPUNIT_ASSERT_EQUAL( OUString("2012-10-31"), m_pDoc->GetString( 0, 102, 0 ) ); +CPPUNIT_ASSERT_EQUAL( OUString("2012-10-31"), m_pDoc->GetString( 0, 103, 0 ) ); +CPPUNIT_ASSERT_EQUAL( OUString("2012-10-31"), m_pDoc->GetString( 0, 104, 0 ) ); + m_pDoc->DeleteTab(0); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140946] Save image pointing to LibreOfficeDev\4\user\gallery by default
https://bugs.documentfoundation.org/show_bug.cgi?id=140946 --- Comment #4 from Telesto --- (In reply to NISZ LibreOffice Team from comment #3) > Speculation: > using ($username) might help, although I'm unsure about how to set a > Pictures component after it in a platform and locale-independent way. Is it not possible to mimic the save/save as/ file open behaviour (that working properly too) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140384] CHARACTER STYLE: Relative font doesn't work, if style has no parent style
https://bugs.documentfoundation.org/show_bug.cgi?id=140384 --- Comment #6 from p...@rhyme.com.au --- My 0.02c worth: It's not a supicate of bug 101783 because that relates to the parent/child problem in character styles. IMO, based on the above comments, I'd say it's an enhancement based around and undefined behaviour in the standard. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140384] CHARACTER STYLE: Relative font doesn't work, if style has no parent style
https://bugs.documentfoundation.org/show_bug.cgi?id=140384 --- Comment #5 from Dieter --- (In reply to Regina Henschel from comment #4) > No, the standard has no rule for it. So should we treat it as enhancement and change status to NEW, shall we treat it as a duplicate of bug 101783 or is it a WONTFIX, because there is no defined standard in odf-specifications? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140650] And easy the select a collection of shapes for grouping
https://bugs.documentfoundation.org/show_bug.cgi?id=140650 Dieter changed: What|Removed |Added Whiteboard| QA:needsComment| CC||dgp-m...@gmx.de Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Dieter --- I can't confirm it Steps to group all freeforms 1. Select one freeform 2. If pointer changes to an arrow draw a rectangle, that includes all freeforms 3. Move pointer so that it changes from arrow to "line" (don't know the correct english word) 4. Open context menu and group objects Telesto, are you able to reproduce this? = NEEDINFO Perhaps steps could be improved (it's annoying, that deselect all objects, if you open context menu when pointer is an arrow). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/docfld.cxx | 11 +-- sw/source/core/edit/edfld.cxx |1 + 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit e6f7a3bf40f5df3a17ba58c4735d647bfdda71cb Author: Mike Kaganski AuthorDate: Fri Mar 12 07:28:23 2021 +0100 Commit: Mike Kaganski CommitDate: Fri Mar 12 08:32:25 2021 +0100 Use range-based for; mention similar method in comments Change-Id: I2659faf75e88eecccfdb33368393c140563030e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112304 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/sw/source/core/doc/docfld.cxx b/sw/source/core/doc/docfld.cxx index eecfc42fc1ab..58319816050b 100644 --- a/sw/source/core/doc/docfld.cxx +++ b/sw/source/core/doc/docfld.cxx @@ -351,13 +351,12 @@ const SwDBData& SwDoc::GetDBDesc() #if HAVE_FEATURE_DBCONNECTIVITY if(maDBData.sDataSource.isEmpty()) { -const SwFieldTypes::size_type nSize = getIDocumentFieldsAccess().GetFieldTypes()->size(); -for(SwFieldTypes::size_type i = 0; i < nSize && maDBData.sDataSource.isEmpty(); ++i) +// Similar to: SwEditShell::IsAnyDatabaseFieldInDoc +for (const auto& pFieldType : *getIDocumentFieldsAccess().GetFieldTypes()) { -SwFieldType& rFieldType = *((*getIDocumentFieldsAccess().GetFieldTypes())[i]); -SwFieldIds nWhich = rFieldType.Which(); -if(IsUsed(rFieldType)) +if (IsUsed(*pFieldType)) { +SwFieldIds nWhich = pFieldType->Which(); switch(nWhich) { case SwFieldIds::Database: @@ -366,7 +365,7 @@ const SwDBData& SwDoc::GetDBDesc() case SwFieldIds::DbSetNumber: { std::vector vFields; -rFieldType.GatherFields(vFields); +pFieldType->GatherFields(vFields); if(vFields.size()) { if(SwFieldIds::Database == nWhich) diff --git a/sw/source/core/edit/edfld.cxx b/sw/source/core/edit/edfld.cxx index c83f442b7160..2ad8695d46c7 100644 --- a/sw/source/core/edit/edfld.cxx +++ b/sw/source/core/edit/edfld.cxx @@ -385,6 +385,7 @@ void SwEditShell::ChangeAuthorityData(const SwAuthEntry* pNewData) bool SwEditShell::IsAnyDatabaseFieldInDoc()const { +// Similar to: SwDoc::GetDBDesc const SwFieldTypes * pFieldTypes = GetDoc()->getIDocumentFieldsAccess().GetFieldTypes(); for(const auto & pFieldType : *pFieldTypes) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140671] Cannot display or edit bad existing formula in table cell
https://bugs.documentfoundation.org/show_bug.cgi?id=140671 Dieter changed: What|Removed |Added Blocks||122755 CC||dgp-m...@gmx.de --- Comment #2 from Dieter --- (In reply to Ulrich Windl from comment #1) > Another thing I had noticed is that copying formula "mean " gives > wrong results, but copying formula "mean()" gives the correct results. Ulrich, thank you for reporting the bugs, but please don't mix two issues in one report. Please open a new report for the second problem. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122755 [Bug 122755] [META] Formulae in Writer tables bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122755] [META] Formulae in Writer tables bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=122755 Dieter changed: What|Removed |Added Depends on||140671 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140671 [Bug 140671] Cannot display or edit bad existing formula in table cell -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107943] [META] Save bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107943 Bug 107943 depends on bug 119100, which changed state. Bug 119100 Summary: Removing an imported bitmap from a frame does not remove bitmap from .odt file. https://bugs.documentfoundation.org/show_bug.cgi?id=119100 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47148] [META] Image handling problems
https://bugs.documentfoundation.org/show_bug.cgi?id=47148 Bug 47148 depends on bug 119100, which changed state. Bug 119100 Summary: Removing an imported bitmap from a frame does not remove bitmap from .odt file. https://bugs.documentfoundation.org/show_bug.cgi?id=119100 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92796] [ODF] Writer does not remove unused page background image/bitmap
https://bugs.documentfoundation.org/show_bug.cgi?id=92796 Justin L changed: What|Removed |Added CC||martin.van.bo...@gmail.com --- Comment #26 from Justin L --- *** Bug 119100 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119100] Removing an imported bitmap from a frame does not remove bitmap from .odt file.
https://bugs.documentfoundation.org/show_bug.cgi?id=119100 Justin L changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #5 from Justin L --- *** This bug has been marked as a duplicate of bug 92796 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140745] AutoFilter dropdown doesn't show (empty) on top of the list with values
https://bugs.documentfoundation.org/show_bug.cgi?id=140745 --- Comment #8 from Baggeraar --- Note that maybe the same should be the case for '#N/A'. These are the only two 'special' values, I believe. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65205] Print Component fails to recognize 'Tabloid' as 11x17, uses Letter instead
https://bugs.documentfoundation.org/show_bug.cgi?id=65205 --- Comment #51 from Proj --- I experienced the something similar when trying to print an 8.5x13 paper size document. Even after I set the document size to 8.5x13 on the print properties, it shows that it is set to "German Legal Fanfold 8.50in x 13.00in, but when I try to print it goes back to Letter size or when I open "Properties" again. Am I missing a "Save Settings" button or something? I am printing to a network printer (EPSON L1455), it has two cassettes (Cassette 1 is set to Letter size and Cassette 2 is set to 8.5x13). I tried opening the file on Office Word and printing from there, it worked normally. I recently updated to 7.1.1.2 but I don't know if this was a problem in previous versions, I usually save to PDF before printing anything but I was trying to print something out quickly and found this problem. I copy pasted this comment from 115481 because I realized it was possibly a duplicate of this. Version: 7.1.1.2 (x64) / LibreOffice Community Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65205] Print Component fails to recognize 'Tabloid' as 11x17, uses Letter instead
https://bugs.documentfoundation.org/show_bug.cgi?id=65205 Proj changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||5481 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115481] Letter paper size is not what it should be.
https://bugs.documentfoundation.org/show_bug.cgi?id=115481 Proj changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=65 ||205 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Viswaas Prabunathan license statement
All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. -- Viswaas L Prabunathan B.S. Comp Sci & Eng | UC Davis ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 140965] LIBREOFFICE 7.1 program crashes after activating (external) query update
https://bugs.documentfoundation.org/show_bug.cgi?id=140965 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- Please attach test file. Thank you. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138149] Tools...Customize...Toolbars...Category...Macros causes crash
https://bugs.documentfoundation.org/show_bug.cgi?id=138149 tripo...@hotmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #2 from tripo...@hotmail.com --- I got same error. Version: 7.1.1.2 (x64) / LibreOffice Community Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: ja-JP (ja_JP); UI: ja-JP Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115481] Letter paper size is not what it should be.
https://bugs.documentfoundation.org/show_bug.cgi?id=115481 --- Comment #12 from Proj --- I experienced the something similar when trying to print an 8.5x13 paper size document. Even after I set the document size to 8.5x13 on the print properties, it shows that it is set to "German Legal Fanfold 8.50in x 13.00in, but when I try to print it goes back to Letter size or when I open "Properties" again. Am I missing a "Save Settings" button or something? I am printing to a network printer (EPSON L1455), it has two cassettes (Cassette 1 is set to Letter size and Cassette 2 is set to 8.5x13). I tried opening the file on Office Word and printing from there, it worked normally. I recently updated to 7.1.1.2 but I don't know if this was a problem in previous versions, I usually save to PDF before printing anything but I was trying to print something out quickly and found this problem. Version: 7.1.1.2 (x64) / LibreOffice Community Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
S9+ screen only 125.4 usd
Hi,Hi,Samsung screen prices drop down a lot for supply get more in market now,Pls check if you need some stock.S8 plus:USD$125.4, ↓ $4.38S9 plus:USD$125.4, ↓ $6.75S10:USD$204.2, ↓ $1.8S20:USD$184, ↓ $1.6S20 plus:USD$201, ↓ $1.7S20 ultra:USD$232.9, ↓ $3.4Note 9:USD$143.5, ↓ $1.8Note 10:USD$183.9 , ↓ $3.4Note 10 plus:USD$214.3, ↓ $3.4Note 20 ultra:USD$261.6, ↓ $1.7A50/A50s:USD$51.2, ↓ $2.7A40:USD$66.5, ↓ $2.1A30:USD$51.2, ↓ $2.7A20:USD$49.4, ↓ $1.8Big hole back glass sells hot:iPhone SE2--$1.23iPhone 8--$1.25iPhone 8 Plus---$1.25iPhone X-$1.64iPhone XS---$1.64iPhone XR---$1.25iPhone XS MAX$1.64iPhone 11$2.25iPhone 11 Pro---$4.9iPhone 11 Pro MAX-$4.9iPhone 12$4.9iPhone 12 Mini--$4.9iPhone 12 Pro---$11.35iPhone 12 Pro Max-$12.28Thanks & RegardsKelly Elekworld Co.,Ltd.wasap.my/8613760153721Skype: Kelly-Elekworld11 Years Professional supplier for iPhone etc. Parts and Accessories ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 113281] Use default icon theme after uninstalling an extension
https://bugs.documentfoundation.org/show_bug.cgi?id=113281 --- Comment #6 from stevhuk --- QuickPayPortal which is also known as the patient portal is designed and made for patients only to ease their life and save them form a lot of difficulties. You can review your statements or previous payment history through the quickpayportal app. https://quickpayportal.red -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127818] LibreOffice crashes 10-20 seconds after start
https://bugs.documentfoundation.org/show_bug.cgi?id=127818 Astroopd changed: What|Removed |Added URL||https://astroopd.com/best-a ||strologer-punjab/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140671] Cannot display or edit bad existing formula in table cell
https://bugs.documentfoundation.org/show_bug.cgi?id=140671 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140660] Textbox in group with other objects causes wrong dimensions after DOCX export
https://bugs.documentfoundation.org/show_bug.cgi?id=140660 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140256] Cannot use mouse scroll button on selection buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=140256 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136681] Writer, footnotes, numbering per chapter doesn't work.
https://bugs.documentfoundation.org/show_bug.cgi?id=136681 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140256] Cannot use mouse scroll button on selection buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=140256 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136681] Writer, footnotes, numbering per chapter doesn't work.
https://bugs.documentfoundation.org/show_bug.cgi?id=136681 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116222] [META] Edit conditional formatting dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=116222 Bug 116222 depends on bug 134368, which changed state. Bug 134368 Summary: Dialog to edit Conditional Formatting does not preset current conditions https://bugs.documentfoundation.org/show_bug.cgi?id=134368 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134368] Dialog to edit Conditional Formatting does not preset current conditions
https://bugs.documentfoundation.org/show_bug.cgi?id=134368 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134368] Dialog to edit Conditional Formatting does not preset current conditions
https://bugs.documentfoundation.org/show_bug.cgi?id=134368 --- Comment #3 from QA Administrators --- Dear Bernhard Döbler, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136685] The "update all" button that can be added to toolbars does not update the Table of contents
https://bugs.documentfoundation.org/show_bug.cgi?id=136685 --- Comment #6 from QA Administrators --- Dear David W. Snow, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97354] formula is hidden when conditional format dialogue box is opened
https://bugs.documentfoundation.org/show_bug.cgi?id=97354 --- Comment #8 from QA Administrators --- Dear lvm, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90852] TOOLBAR: 'Area Style / Filing' drop down control doesnt update 'Fill Color' drop down
https://bugs.documentfoundation.org/show_bug.cgi?id=90852 --- Comment #6 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73404] Better defaults of ordered point lists (spacing and indention)
https://bugs.documentfoundation.org/show_bug.cgi?id=73404 --- Comment #8 from QA Administrators --- Dear Dave Neary, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123919] Sorting of user-defined document properties uses US-ASCII ordering (it seems)
https://bugs.documentfoundation.org/show_bug.cgi?id=123919 --- Comment #4 from QA Administrators --- Dear Ulrich Windl, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/salvtables.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 21c602913d98ef46b49fc9b6f9071db92a1597c6 Author: Mike Kaganski AuthorDate: Thu Mar 11 15:06:42 2021 +0100 Commit: Mike Kaganski CommitDate: Fri Mar 12 05:08:50 2021 +0100 No need to const_cast here Change-Id: I2ecac05f41b5656714a656fe5289dc21c9f6051a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112300 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx index 64294c4686de..083f571d858b 100644 --- a/vcl/source/app/salvtables.cxx +++ b/vcl/source/app/salvtables.cxx @@ -4144,8 +4144,7 @@ void SalInstanceTreeView::set_clicks_to_toggle(int nToggleBehavior) void SalInstanceTreeView::set_extra_row_indent(const weld::TreeIter& rIter, int nIndentLevel) { -weld::TreeIter& rNonConstIter = const_cast(rIter); -SalInstanceTreeIter& rVclIter = static_cast(rNonConstIter); +const SalInstanceTreeIter& rVclIter = static_cast(rIter); rVclIter.iter->SetExtraIndent(nIndentLevel); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/salvtables.cxx |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) New commits: commit 0ed63ed088d23e48f050c34e49f713281468f6f8 Author: Mike Kaganski AuthorDate: Thu Mar 11 13:39:52 2021 +0100 Commit: Mike Kaganski CommitDate: Fri Mar 12 05:08:20 2021 +0100 Avoid modifying then restoring this const iterator, its copy is trivial Change-Id: I2a129714f726fb2b15f76550f7e2e265205d0112 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112299 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx index 103b7bc4a22c..64294c4686de 100644 --- a/vcl/source/app/salvtables.cxx +++ b/vcl/source/app/salvtables.cxx @@ -4502,12 +4502,8 @@ int SalInstanceTreeView::get_iter_depth(const weld::TreeIter& rIter) const bool SalInstanceTreeView::iter_has_child(const weld::TreeIter& rIter) const { -weld::TreeIter& rNonConstIter = const_cast(rIter); -SalInstanceTreeIter& rVclIter = static_cast(rNonConstIter); -SvTreeListEntry* restore(rVclIter.iter); -bool ret = iter_children(rNonConstIter); -rVclIter.iter = restore; -return ret; +SalInstanceTreeIter aTempCopy(static_cast()); +return iter_children(aTempCopy); } bool SalInstanceTreeView::get_row_expanded(const weld::TreeIter& rIter) const ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 76257] Information and Lines lost when printing serial letters
https://bugs.documentfoundation.org/show_bug.cgi?id=76257 --- Comment #6 from hicktal --- Kroger Express HR is Kroger’s intro store employee portal, used to access paystubs and W-2 forms. Users can set up direct deposit, update personal information and much more. The krogerexpresshr portal is accessible to everyone. And it is the best platform on which exactly Kroger’s work management is carried out with great perfection. https://krogerfeedback.ninja/express-hr/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svx sd/source svx/source
include/svx/svdedtv.hxx|6 +- sd/source/ui/func/futransf.cxx | 13 - svx/source/svdraw/svdedtv1.cxx |8 +++- 3 files changed, 20 insertions(+), 7 deletions(-) New commits: commit 2246b6a2887b90efc712c4479b19609cf9307a3d Author: mert AuthorDate: Thu Mar 4 12:17:27 2021 +0300 Commit: Mert Tumer CommitDate: Fri Mar 12 04:36:28 2021 +0100 Fix wrong position on move when page has margin Change-Id: I9ac2d9914b86210ca2148b44488c2c70cc5870d4 Signed-off-by: mert Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111949 Reviewed-by: Miklos Vajna Tested-by: Jenkins CollaboraOffice Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111929 Tested-by: Jenkins diff --git a/include/svx/svdedtv.hxx b/include/svx/svdedtv.hxx index 916fdaeb186b..eb815b728cb3 100644 --- a/include/svx/svdedtv.hxx +++ b/include/svx/svdedtv.hxx @@ -304,7 +304,11 @@ public: // geometrical attribute (position, size, rotation angle) // A PageOrigin set at a position is taken into account. SfxItemSet GetGeoAttrFromMarked() const; -void SetGeoAttrToMarked(const SfxItemSet& rAttr); +// In LOK, interactive shape movement uses this function +// in that case, margin is not taken into account +// and the final position of the shape becomes incorrect +// However, "Position and Size" dialog and other cases already add the margins. +void SetGeoAttrToMarked(const SfxItemSet& rAttr, bool addPageMargin = false); // Returns NULL if: // - nothing is marked, diff --git a/sd/source/ui/func/futransf.cxx b/sd/source/ui/func/futransf.cxx index fa7398e48b43..6c07e0e70be6 100644 --- a/sd/source/ui/func/futransf.cxx +++ b/sd/source/ui/func/futransf.cxx @@ -28,6 +28,7 @@ #include #include #include +#include #include @@ -48,14 +49,13 @@ rtl::Reference FuTransform::Create( ViewShell* pViewSh, ::sd::Window* pW namespace { -void setUndo(::sd::View* pView, const SfxItemSet* pArgs) +void setUndo(::sd::View* pView, const SfxItemSet* pArgs, bool addPageMargin) { // Undo OUString aString = pView->GetDescriptionOfMarkedObjects() + " " + SdResId(STR_TRANSFORM); pView->BegUndo(aString); - -pView->SetGeoAttrToMarked(*pArgs); +pView->SetGeoAttrToMarked(*pArgs, addPageMargin); pView->SetAttributes(*pArgs); pView->EndUndo(); } @@ -71,7 +71,9 @@ void FuTransform::DoExecute( SfxRequest& rReq ) if (pArgs) { -setUndo(mpView, pArgs); +// If this comes from LOK, that means the shape is moved by mouse +// only then pArgs is pre-set. +setUndo(mpView, pArgs, comphelper::LibreOfficeKit::isActive()); return; } @@ -115,7 +117,8 @@ void FuTransform::DoExecute( SfxRequest& rReq ) if (nResult == RET_OK) { pRequest->Done(*(pDlg->GetOutputItemSet())); -setUndo(mpView, pRequest->GetArgs()); +// Page margin is already calculated at this point. +setUndo(mpView, pRequest->GetArgs(), false); } // deferred until the dialog ends diff --git a/svx/source/svdraw/svdedtv1.cxx b/svx/source/svdraw/svdedtv1.cxx index f2128824b6fa..5b17b8852462 100644 --- a/svx/source/svdraw/svdedtv1.cxx +++ b/svx/source/svdraw/svdedtv1.cxx @@ -1512,7 +1512,7 @@ static Point ImpGetPoint(const tools::Rectangle& rRect, RectPoint eRP) return Point(); // Should not happen! } -void SdrEditView::SetGeoAttrToMarked(const SfxItemSet& rAttr) +void SdrEditView::SetGeoAttrToMarked(const SfxItemSet& rAttr, bool addPageMargin) { const bool bTiledRendering = comphelper::LibreOfficeKit::isActive(); @@ -1520,6 +1520,12 @@ void SdrEditView::SetGeoAttrToMarked(const SfxItemSet& rAttr) if(GetSdrPageView()) { +if (addPageMargin) +{ +SdrPage * pPage = GetSdrPageView()->GetPage(); +Point upperLeft(pPage->GetLeftBorder(), pPage->GetUpperBorder()); +aRect.Move(upperLeft.getX(), upperLeft.getY()); +} GetSdrPageView()->LogicToPagePos(aRect); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140784] The WEBSERVICE function doesn't work on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=140784 himajin100...@gmail.com changed: What|Removed |Added Summary|The SERVICEWEB function |The WEBSERVICE function |doesn't work on macOS |doesn't work on macOS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118541] Undesired font embedded in pdf form created with Libre Office Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=118541 --- Comment #18 from Brenton Chapin --- Very easy for me to reproduce in 7.1.1.2, Lubuntu 18.04. Start Writer, add a Text Box, then Export as PDF. ("Create Form" should already be checked.) That's all. If you use the utility pdffonts on the PDF, you will see that Helvetica is in there. I am not using Helvetica, but it was in there anyway. This is closely related to another problem I'm having. I can't set the font that I want in the Text Box. If you look at Control Properties for the Text Box, under the General tab, the font is "(Default)" whatever that is. Perhaps that default is Helvetica? Changing the font there has no effect on the PDF. The font change works within Writer, but has no effect on the PDF form. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140965] New: LIBREOFFICE 7.1 program crashes after activating (external) query update
https://bugs.documentfoundation.org/show_bug.cgi?id=140965 Bug ID: 140965 Summary: LIBREOFFICE 7.1 program crashes after activating (external) query update Product: LibreOffice Version: 7.1.1.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hawout...@hotmail.com Description: LIBREOFFICE 7.1: After opening a worksheet with manny external webquery's the program crashes at activating the button "koppelingen bijwerken"(allow query update) in the upper yellow area. LIBREOFFICE 7.05 is ok. Steps to Reproduce: 1.Open a worksheet that contains about 10 external webquery's 2.press the button "allow update = bijwerken toestaan" in the upper yellow erea 3. Actual Results: program crashes. A continuing hourglass is running for ever.Program doesnt react at all. Is dead. Expected Results: Update all Webquery's Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: versie 7.1.1. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140964] New: Feature improvement suggestion: selective document recovery
https://bugs.documentfoundation.org/show_bug.cgi?id=140964 Bug ID: 140964 Summary: Feature improvement suggestion: selective document recovery Product: LibreOffice Version: 6.4.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cather...@openmail.cc Description: I had several documents open, one of which had 3 hours of notes typed in. A new document I created caused LO to become unresponsive. So I chose "force quit". When the recovery window appeared, there were several documents listed. I knew which one I didn't want, that had caused the problem. However, there was not actually an option to only discard the data for one file, and recover the rest. That would be a good option to give - ie tick boxes to select which files to recover, maybe default with all ticked. (yes, I lost all my work). Actual Results: n/a Expected Results: n/a Reproducible: Always User Profile Reset: No Additional Info: I did have "autosave every 10 minutes" enabled, but because I chose discard from the recovery menu, I have lost everything - I wasn't aware that would happen. Now I have also ticked "save a backup every time", but I guess that also won't help unless I actually save the file. Lesson learned - never choose "discard" when there are several files on the list. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Contributing to LibreOffice
Hey there! This is Ankur Khandelwal. I am a second-year Computer Engineering student at the International Institute of Information Technology, Bhubaneswar. I would like to be a part of the developer community of LibreOffice. I am sending this mail as a formal introduction as mentioned on the page https://summerofcode.withgoogle.com/organizations/6596812015665152/ My nickname on the #libreoffice-dev IRC channel at freenode.net is Ankur. Thank You. -- Ankur Khandelwal, B519010, Computer Engineering (CE), IIIT Bhubaneswar. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4a4a38d31a287f78d4c7226fe85aafb6e6c6c0ac Author: Rafael Lima AuthorDate: Fri Mar 12 00:25:12 2021 +0100 Commit: Gerrit Code Review CommitDate: Fri Mar 12 00:25:12 2021 +0100 Update git submodules * Update helpcontent2 from branch 'master' to ae361f8f4f70c43d7082dd37c0a3f69bf49fa3e0 - Create SF_Database Help page Change-Id: I4ab158e8089973af24155d3b9d0697734acdf4bb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/112228 Tested-by: Jenkins Tested-by: Jean-Pierre Ledure Reviewed-by: Jean-Pierre Ledure diff --git a/helpcontent2 b/helpcontent2 index 9847ee04682b..ae361f8f4f70 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 9847ee04682b673c20918af6356c0dbf39aa6deb +Subproject commit ae361f8f4f70c43d7082dd37c0a3f69bf49fa3e0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: AllLangHelp_sbasic.mk source/text
AllLangHelp_sbasic.mk|1 source/text/sbasic/shared/03/lib_ScriptForge.xhp |2 source/text/sbasic/shared/03/sf_database.xhp | 324 +++ 3 files changed, 326 insertions(+), 1 deletion(-) New commits: commit ae361f8f4f70c43d7082dd37c0a3f69bf49fa3e0 Author: Rafael Lima AuthorDate: Wed Mar 10 15:46:49 2021 +0100 Commit: Rafael Lima CommitDate: Fri Mar 12 00:25:12 2021 +0100 Create SF_Database Help page Change-Id: I4ab158e8089973af24155d3b9d0697734acdf4bb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/112228 Tested-by: Jenkins Tested-by: Jean-Pierre Ledure Reviewed-by: Jean-Pierre Ledure diff --git a/AllLangHelp_sbasic.mk b/AllLangHelp_sbasic.mk index 90b40453f..65fc41da7 100644 --- a/AllLangHelp_sbasic.mk +++ b/AllLangHelp_sbasic.mk @@ -79,6 +79,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\ helpcontent2/source/text/sbasic/shared/03/lib_ScriptForge \ helpcontent2/source/text/sbasic/shared/03/sf_array \ helpcontent2/source/text/sbasic/shared/03/sf_calc \ +helpcontent2/source/text/sbasic/shared/03/sf_database \ helpcontent2/source/text/sbasic/shared/03/sf_dialog \ helpcontent2/source/text/sbasic/shared/03/sf_dialogcontrol \ helpcontent2/source/text/sbasic/shared/03/sf_dictionary \ diff --git a/source/text/sbasic/shared/03/lib_ScriptForge.xhp b/source/text/sbasic/shared/03/lib_ScriptForge.xhp index 30520ca95..c59831b92 100644 --- a/source/text/sbasic/shared/03/lib_ScriptForge.xhp +++ b/source/text/sbasic/shared/03/lib_ScriptForge.xhp @@ -120,7 +120,7 @@ - Database + diff --git a/source/text/sbasic/shared/03/sf_database.xhp b/source/text/sbasic/shared/03/sf_database.xhp new file mode 100644 index 0..6c137ef47 --- /dev/null +++ b/source/text/sbasic/shared/03/sf_database.xhp @@ -0,0 +1,324 @@ + + + + + + +SFDatabases.Database service +/text/sbasic/shared/03/sf_database.xhp + + + + + + Database service + + + + +SFDatabases.Database service +The Database service provides access to databases either embedded or described in Base documents. This service provides methods to: + + +Get access to data in database tables. + + +Run SELECT queries and perform aggregate functions. + + +Run SQL action statements such as INSERT, UPDATE, DELETE, etc. + + + +TODO: Add reference to the future help page SFDocuments.SF_Form service in the paragraph below +Each instance of the Database service represents a single database and gives access to its tables, queries and data. This service does not provide access to forms or reports in the Base document. +All exchanges between this service and the database are done using SQL only. +SQL statements may be run in direct or indirect mode. In direct mode the statement is transferred to the database engine without any syntax checking or review. +The provided interfaces include simple tables and queries lists, as well as access to database data. +To make SQL statements more readable, you can use optional square brackets to enclose tables, queries and fields instead of using other enclosing characters that may be exclusive to certain Relational Database Management Systems (RDBMS). + +Service invocation + +The code snippet below shows how to access any database with the Database service. + +Dim myDatabase As Object +Set myDatabase = CreateScriptService("SFDatabases.Database", [FileName], [RegistrationName], [ReadOnly], [User, [Password]]) +' ... Run queries, SQL statements, ... +myDatabase.CloseDatabase() + + +FileName: The name of the Base file. Must be expressed using SF_FileSystem.FileNaming notation. +RegistrationName: The name of a registered database. If a file name is provided, this argument should not be used. +Conversely, if a RegistrationName is specified, the FileName parameter should not be defined. +ReadOnly: Determines if the database will be opened as readonly (Default = True). +User, Password: Additional connection parameters to the database server. + +Accessing Databases with the UI Service +It is also possible to access the database associated with a Base document using the ScriptForge.UI service, as shown in the example below: + +Dim myDoc As Object, myDatabase As Object, ui As Object +Set ui = CreateScriptService("UI") +Set myDoc = ui.OpenBaseDocument("myDb.odb") +' User and password are supplied below, if needed +Set myDatabase = myDoc.GetDatabase() +' ... Run queries, SQL statements, ... +myDoc.CloseDocument() + + + +Database Service;Queries +Database Service;Tables + +Properties + + + + Name +
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sc/source
sc/source/core/data/table4.cxx |7 +++ 1 file changed, 7 insertions(+) New commits: commit 1982768ba3db819b84445830ae24e55ecd373d9a Author: Andreas Heinisch AuthorDate: Sat Mar 6 10:38:43 2021 +0100 Commit: Xisco Fauli CommitDate: Fri Mar 12 00:23:17 2021 +0100 tdf#89754 - don't increment non different consecutive date cells Change-Id: I6fedc0fe286ebe8b0110360391e8d3325fc2ca25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112054 Tested-by: Jenkins Reviewed-by: Eike Rathke (cherry picked from commit 3ba901f050d262cdeccefa5b21b0d32aa7332dc7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112295 Reviewed-by: Xisco Fauli diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx index a777aca898ae..ede354eead8c 100644 --- a/sc/source/core/data/table4.cxx +++ b/sc/source/core/data/table4.cxx @@ -587,6 +587,13 @@ void ScTable::FillAnalyse( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2, rInc = nCmpInc; } } +else +{ +// tdf#89754 - don't increment non different consecutive date cells +rCmd = FILL_DATE; +rDateCmd = FILL_DAY; +rInc = 0.0; +} } else// single date -> increment by days { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 134195] REPORTBUILDER: copy paste field between two reports will generate crash after closing LO
https://bugs.documentfoundation.org/show_bug.cgi?id=134195 b. changed: What|Removed |Added CC||newbie...@gmx.de --- Comment #10 from b. --- hello @libre officer, it's not very likely, but may be the patch for (https://bugs.documentfoundation.org//show_bug.cgi?id=116983) does in any way affect your problem, pls. check there and try a fresh version from after 2021-03-04 and report back ... thank you ... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.cxx |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit a0d63ee5df921e5f1ac915ada783fdef0dbbb057 Author: Julien Nabet AuthorDate: Sun Feb 28 22:23:30 2021 +0100 Commit: Thorsten Behrens CommitDate: Thu Mar 11 23:48:55 2021 +0100 tdf#127217: Fix buttons in forms not working in Adobe Reader Regression from 76b5dca9dc0ff60f8f62cbecdee68f8f3b287ceb: author Thorsten Behrens 2019-04-09 02:19:14 +0200 committer Katarina Behrens 2019-07-03 14:48:45 +0200 commit 76b5dca9dc0ff60f8f62cbecdee68f8f3b287ceb (patch) treee778dad33073a228eb61ab62ce5f38e2a26d07ca parent 1e8a9c19a6f7b82c9e0c481aee0c04c0780f4433 (diff) tdf#113448 don't export any font for radio buttons Don't let only color value in m_aDAString since it'll go here: if( !rWidget.m_aDAString.isEmpty() ) { if( !rWidget.m_aDRDict.isEmpty() ) { aLine.append( "/DR<<" ); aLine.append( rWidget.m_aDRDict ); aLine.append( ">>\n" ); } else { aLine.append( "/DR<>>>\n" ); } aLine.append( "/DA" ); appendLiteralStringEncrypt( rWidget.m_aDAString, rWidget.m_nObject, aLine ); aLine.append( "\n" ); if( rWidget.m_nTextStyle & DrawTextFlags::Center ) aLine.append( "/Q 1\n" ); else if( rWidget.m_nTextStyle & DrawTextFlags::Right ) aLine.append( "/Q 2\n" ); } But if we shouldn't have /DR at all since we don't want fonts for radiobutton, it also means we don't want /DA too. Indeed at the end of 12.7.3.3 https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf: The default appearance string (DA) contains any graphics state or text state operators needed to establish the graphics state parameters, such as text size and colour, for displaying the field’s variable text. Only operators that are allowed within text objects shall occur in this string (see Figure 9). At a minimum, the string shall include a Tf (text font) operator along with its two operands, font and size. The specified font value shall match a resource name in the Font entry of the default resource dictionary (referenced from the DR entry of the interactive form dictionary; see Table 218). Change-Id: Ib350495d7fc5a7a4fba88d710614a0f67a0b1553 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111724 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/vcl/source/gdi/pdfwriter_impl.cxx b/vcl/source/gdi/pdfwriter_impl.cxx index 4cf1b8ac5e8f..b81843b459e4 100644 --- a/vcl/source/gdi/pdfwriter_impl.cxx +++ b/vcl/source/gdi/pdfwriter_impl.cxx @@ -4022,9 +4022,6 @@ void PDFWriterImpl::createDefaultRadioButtonAppearance( PDFWidget& rBox, const P pop(); -OStringBuffer aDA( 256 ); -appendNonStrokingColor( replaceColor( rWidget.TextColor, rSettings.GetRadioCheckTextColor() ), aDA ); -rBox.m_aDAString = aDA.makeStringAndClear(); //to encrypt this (el) rBox.m_aMKDict = "/CA"; //after this assignment, to m_aMKDic cannot be added anything @@ -4037,6 +4034,7 @@ void PDFWriterImpl::createDefaultRadioButtonAppearance( PDFWidget& rBox, const P SvMemoryStream* pCheckStream = new SvMemoryStream( 256, 256 ); beginRedirect( pCheckStream, aCheckRect ); +OStringBuffer aDA( 256 ); aDA.append( "/Tx BMC\nq BT\n" ); appendNonStrokingColor( replaceColor( rWidget.TextColor, rSettings.GetRadioCheckTextColor() ), aDA ); aDA.append( ' ' ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140897] Copy Paste
https://bugs.documentfoundation.org/show_bug.cgi?id=140897 b. changed: What|Removed |Added CC||newbie...@gmx.de --- Comment #2 from b. --- hello @Ash, your reports lacks a little in info and precision, pls. look into some other bugs how to report well, it sounds like the well known old copy/paste problem, there have been improvements shortly (https://bugs.documentfoundation.org//show_bug.cgi?id=116983), pls. check there and try a fresh version from after 2021-03-04 and report back ... thank you ... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: xmlsecurity/Module_xmlsecurity.mk
xmlsecurity/Module_xmlsecurity.mk |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 149df1fec6472e30582162e17e04c75aee91d26a Author: Miklos Vajna AuthorDate: Thu Mar 11 17:45:58 2021 +0100 Commit: Miklos Vajna CommitDate: Thu Mar 11 23:26:56 2021 +0100 Turn CppunitTest_xmlsecurity_signing into a subsequentcheck This is one of the most unreliable tests on Windows, probably due to reading the real system cert store, unlike macOS/Linux (which have a per-test NSS template). Give up on running this on Windows / macOS for pre-submit CI to get more reliability instead. Local 'make check' on Windows keeps running this, since it does pass most of the time. The change can be reverted once somebody can figure out how to reliably reproduce this failure on Windows. Change-Id: I50df09bda9c353ce08038dab8d307bbf7738bb5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112358 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/xmlsecurity/Module_xmlsecurity.mk b/xmlsecurity/Module_xmlsecurity.mk index 1ce7364d4ce9..81e74ecf21d3 100644 --- a/xmlsecurity/Module_xmlsecurity.mk +++ b/xmlsecurity/Module_xmlsecurity.mk @@ -18,10 +18,13 @@ $(eval $(call gb_Module_add_targets,xmlsecurity,\ )) $(eval $(call gb_Module_add_slowcheck_targets,xmlsecurity,\ -CppunitTest_xmlsecurity_signing \ CppunitTest_xmlsecurity_pdfsigning \ )) +$(eval $(call gb_Module_add_subsequentcheck_targets,xmlsecurity,\ +CppunitTest_xmlsecurity_signing \ +)) + $(eval $(call gb_Module_add_l10n_targets,xmlsecurity,\ AllLangMoTarget_xsc \ )) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140936] RFE: Writer: Change Selection type icon in Statusbar to labels depending on current type
https://bugs.documentfoundation.org/show_bug.cgi?id=140936 --- Comment #5 from Jim Raykowski --- (In reply to Roman Kuznetsov from comment #4) > > https://gerrit.libreoffice.org/c/core/+/112367 > > Jim, thanks for a nice proposal. I would delete a word "selection" from > labels in statusbar. Let's it will be just words "Standard", "Extending", > "Adding" and "Block" as I wrote in description. With it we save some > horizontal space as want V Stuart Foote Done in patch set 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140963] SVG in Writer leads to huge and slow-rendering PDF export
https://bugs.documentfoundation.org/show_bug.cgi?id=140963 --- Comment #2 from Robert --- Created attachment 170419 --> https://bugs.documentfoundation.org/attachment.cgi?id=170419=edit SVG file used for the PDF export test -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 140936] RFE: Writer: Change Selection type icon in Statusbar to labels depending on current type
https://bugs.documentfoundation.org/show_bug.cgi?id=140936 --- Comment #5 from Jim Raykowski --- (In reply to Roman Kuznetsov from comment #4) > > https://gerrit.libreoffice.org/c/core/+/112367 > > Jim, thanks for a nice proposal. I would delete a word "selection" from > labels in statusbar. Let's it will be just words "Standard", "Extending", > "Adding" and "Block" as I wrote in description. With it we save some > horizontal space as want V Stuart Foote Done in patch set 2 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 140963] SVG in Writer leads to huge and slow-rendering PDF export
https://bugs.documentfoundation.org/show_bug.cgi?id=140963 --- Comment #1 from Robert --- Created attachment 170418 --> https://bugs.documentfoundation.org/attachment.cgi?id=170418=edit Original Writer file that embeds the SVG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140963] New: SVG in Writer leads to huge and slow-rendering PDF export
https://bugs.documentfoundation.org/show_bug.cgi?id=140963 Bug ID: 140963 Summary: SVG in Writer leads to huge and slow-rendering PDF export Product: LibreOffice Version: 7.1.0.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: robert-documentfoundat...@riemann.cc Created attachment 170417 --> https://bugs.documentfoundation.org/attachment.cgi?id=170417=edit Libreoffice PDF export that demonstrates the increase in size and slow performance Dear all, I try to promote within my workplace the use of free software including LibreOffice. I noticed that if I embed an SVG logos of 400 KiB in an otherwise empty ODT and export this to a PDF, than the PDF has 13MB and many PDF readers (if not all) suffer from huge performance issues in rendering the PDF. I have tried the following PDF readers: 1. Okular (KDE Linux) 2. Acrobat Reader (Windows) 3. Firefox (Linux, I can literally see the individually steps of the logo painting) I would instead expect that the PDF is under 1MB and loads as fast as a PDF file stemming from the Inkscape SVG to PDF export. I assume that the SVG logo uses some features (like gradients) that the LibreOffice export does not handle efficiently. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 140936] RFE: Writer: Change Selection type icon in Statusbar to labels depending on current type
https://bugs.documentfoundation.org/show_bug.cgi?id=140936 --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- (In reply to Jim Raykowski from comment #1) > Created attachment 170416 [details] > statusbar section mode control demo > > Pending UX approval: > > https://gerrit.libreoffice.org/c/core/+/112367 Jim, thanks for a nice proposal. I would delete a word "selection" from labels in statusbar. Let's it will be just words "Standard", "Extending", "Adding" and "Block" as I wrote in description. With it we save some horizontal space as want V Stuart Foote -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 140936] RFE: Writer: Change Selection type icon in Statusbar to labels depending on current type
https://bugs.documentfoundation.org/show_bug.cgi?id=140936 --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- (In reply to Jim Raykowski from comment #1) > Created attachment 170416 [details] > statusbar section mode control demo > > Pending UX approval: > > https://gerrit.libreoffice.org/c/core/+/112367 Jim, thanks for a nice proposal. I would delete a word "selection" from labels in statusbar. Let's it will be just words "Standard", "Extending", "Adding" and "Block" as I wrote in description. With it we save some horizontal space as want V Stuart Foote -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140936] RFE: Writer: Change Selection type icon in Statusbar to labels depending on current type
https://bugs.documentfoundation.org/show_bug.cgi?id=140936 --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- In writer we have a free space in statusbar enough. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 140936] RFE: Writer: Change Selection type icon in Statusbar to labels depending on current type
https://bugs.documentfoundation.org/show_bug.cgi?id=140936 --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- In writer we have a free space in statusbar enough. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 140958] PDF/A-2 and PDF/A-3 Exported From LibreOffice Writer is Showing as Adobe PDF Version 1.6, Instead of 1.7
https://bugs.documentfoundation.org/show_bug.cgi?id=140958 Julien Nabet changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | Status|NEW |ASSIGNED --- Comment #4 from Julien Nabet --- I gave a try with https://gerrit.libreoffice.org/c/core/+/112369 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140958] PDF/A-2 and PDF/A-3 Exported From LibreOffice Writer is Showing as Adobe PDF Version 1.6, Instead of 1.7
https://bugs.documentfoundation.org/show_bug.cgi?id=140958 --- Comment #3 from Julien Nabet --- It concerns both PDF/A-2 (which includes PDF/A-2b and PDF/A-2a) and PDF/A-3 (which includes PDF/A-3b and PDF/A-3a) I put "b" version before because it's the basic/minimum requirement of the standard. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140958] PDF/A-2 and PDF/A-3 Exported From LibreOffice Writer is Showing as Adobe PDF Version 1.6, Instead of 1.7
https://bugs.documentfoundation.org/show_bug.cgi?id=140958 Julien Nabet changed: What|Removed |Added Summary|PDF/A-3b Exported From |PDF/A-2 and PDF/A-3 |LibreOffice Writer is |Exported From LibreOffice |Showing as Adobe PDF|Writer is Showing as Adobe |Version 1.6, Instead of 1.7 |PDF Version 1.6, Instead of ||1.7 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140958] PDF/A-3b Exported From LibreOffice Writer is Showing as Adobe PDF Version 1.6, Instead of 1.7
https://bugs.documentfoundation.org/show_bug.cgi?id=140958 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||serval2...@yahoo.fr OS|Windows (All) |All Ever confirmed|0 |1 --- Comment #2 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140936] RFE: Writer: Change Selection type icon in Statusbar to labels depending on current type
https://bugs.documentfoundation.org/show_bug.cgi?id=140936 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- Roman, * Jim as usual hits the request, but is the UI best served by adding textual labeling to the Status bar? The labeling, especially whe translated, is going to suck up a lot of horizontal width on the Status bar--which is always space constrained. The meaning of the current multi-mode selection Icon is functional--but better is concise. And, we can determine mode with mouse-over tool-tip, or change with r-mouse context menu. If we are to make any visual change--we'd be better served with a set of icons for the modes (but difficult to capture iconography for use on the Status bar as these are minimal size icons). All that said, I don't think this is the best way to adjust things. Stuart =-ref-= Help for the modes is here: https://help.libreoffice.org/7.2/en-US/text/shared/02/2005.html?DbPAR=SHARED#bm_id3148668 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 140936] RFE: Writer: Change Selection type icon in Statusbar to labels depending on current type
https://bugs.documentfoundation.org/show_bug.cgi?id=140936 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- Roman, * Jim as usual hits the request, but is the UI best served by adding textual labeling to the Status bar? The labeling, especially whe translated, is going to suck up a lot of horizontal width on the Status bar--which is always space constrained. The meaning of the current multi-mode selection Icon is functional--but better is concise. And, we can determine mode with mouse-over tool-tip, or change with r-mouse context menu. If we are to make any visual change--we'd be better served with a set of icons for the modes (but difficult to capture iconography for use on the Status bar as these are minimal size icons). All that said, I don't think this is the best way to adjust things. Stuart =-ref-= Help for the modes is here: https://help.libreoffice.org/7.2/en-US/text/shared/02/2005.html?DbPAR=SHARED#bm_id3148668 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 140590] Crash in: mergedlo.dll: Using Save-As dialog in Tools>Chapter Numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=140590 --- Comment #12 from Xisco Faulí --- @sdc.bla...@youmail.dk, @timur, since the fix only addresses assert builds, do you still reproducible the crash with a master build containing the fix ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140597] FILEOPEN: DOCX: missing borders in some cells
https://bugs.documentfoundation.org/show_bug.cgi?id=140597 --- Comment #8 from Commit Notification --- László Németh committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/1247f2f3d8f343e0e809a1aec0ce0e20005caafd tdf#140597 DOCX import: fix missing tblPrEx border It will be available in 7.0.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140597] FILEOPEN: DOCX: missing borders in some cells
https://bugs.documentfoundation.org/show_bug.cgi?id=140597 Commit Notification changed: What|Removed |Added Whiteboard|target:7.2.0 target:7.1.2 |target:7.2.0 target:7.1.2 ||target:7.0.6 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf140597.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport5.cxx| 13 + writerfilter/source/dmapper/TableManager.hxx | 11 ++- 3 files changed, 23 insertions(+), 1 deletion(-) New commits: commit 1247f2f3d8f343e0e809a1aec0ce0e20005caafd Author: László Németh AuthorDate: Tue Mar 9 11:11:10 2021 +0100 Commit: Xisco Fauli CommitDate: Thu Mar 11 21:48:59 2021 +0100 tdf#140597 DOCX import: fix missing tblPrEx border of first table cells, caused by the workaround for tdf#138612. Now property set of a new cell is a copy of the table exception property set of the table row, as needed for the import of the table style inheritance. Regression from commit f319d6b543c2367546bc80d138e56ed03731e265 (tdf#138612 DOCX import: fix lost part of split table cell). Change-Id: Iaf6637e757fbfeef7651a4300a7f65a23615f5c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112247 Tested-by: Jenkins Reviewed-by: László Németh (cherry picked from commit 53884e8fe92597e909e4fa5599192783c3d31a56) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112225 Reviewed-by: Xisco Fauli diff --git a/sw/qa/extras/ooxmlexport/data/tdf140597.docx b/sw/qa/extras/ooxmlexport/data/tdf140597.docx new file mode 100644 index ..36db7d9bea2b Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf140597.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx index e6645a0e819f..503d0069a3f7 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx @@ -760,6 +760,19 @@ DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf138612, "tdf138612.docx") assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[6]/w:tc[2]/w:tcPr/w:vMerge", 0); } +DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf140597, "tdf140597.docx") +{ +xmlDocUniquePtr pXmlDocument = parseExport("word/document.xml"); + +// There were missing tblPrEx table exception borders +assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[2]/w:tc[1]/w:tcPr/w:tcBorders/w:top"); +assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[2]/w:tc[1]/w:tcPr/w:tcBorders/w:start"); +assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[3]/w:tc[1]/w:tcPr/w:tcBorders/w:top"); +assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[3]/w:tc[1]/w:tcPr/w:tcBorders/w:start"); +assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[4]/w:tc[1]/w:tcPr/w:tcBorders/w:top"); +assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[4]/w:tc[1]/w:tcPr/w:tcBorders/w:start"); +} + DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf128646, "tdf128646.docx") { // The problem was that not hidden shapes anchored to empty hidden paragraphs were imported as hidden. diff --git a/writerfilter/source/dmapper/TableManager.hxx b/writerfilter/source/dmapper/TableManager.hxx index 5e18becab606..ec064b17ccfc 100644 --- a/writerfilter/source/dmapper/TableManager.hxx +++ b/writerfilter/source/dmapper/TableManager.hxx @@ -114,7 +114,14 @@ class TableManager : public virtual SvRefBase void resetCellProps() { -mpCellProps = getTableExceptionProps(); +// copy tblPrEx table exception properties, if they exist +if (getTableExceptionProps().is()) +{ +mpCellProps = new TablePropertyMap; +mpCellProps->InsertProps(getTableExceptionProps().get()); +} +else +mpCellProps.clear(); } void setCellProps(TablePropertyMapPtr pProps) @@ -149,6 +156,8 @@ class TableManager : public virtual SvRefBase void setTableExceptionProps(TablePropertyMapPtr pProps) { mpTableExceptionProps = pProps; +// set table exception properties of the first cell +resetCellProps(); } const TablePropertyMapPtr& getTableExceptionProps() const ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140960] LibreOffice is not crashing but the system kept on informing me that LibreOffice had crashed
https://bugs.documentfoundation.org/show_bug.cgi?id=140960 Julien Nabet changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- 2 things to try: 1) apply https://wiki.documentfoundation.org/QA/FirstSteps 2) try this: - open terminal/console - export SAL_USE_VCLPLUGIN=gen && soffice then try to reproduce this the pb. The goal is to know if it's kf5/qt5 related. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - include/svx sw/CppunitTest_sw_ooxmlimport2.mk sw/qa
include/svx/unoshprp.hxx |4 ++-- sw/CppunitTest_sw_ooxmlimport2.mk|1 + sw/qa/extras/ooxmlexport/data/tdf133473.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport16.cxx | 21 + 4 files changed, 24 insertions(+), 2 deletions(-) New commits: commit 36538b33413b24241920d8c4d873beb5c671e13f Author: Gülşah Köse AuthorDate: Mon Feb 22 14:44:03 2021 +0300 Commit: Xisco Fauli CommitDate: Thu Mar 11 21:48:44 2021 +0100 tdf#133473 Change SDRATTR_SHADOWSIZEX flag. SDRATTR_SHADOWSIZEX holds a percentage value. So we shouldn't use METRIC_ITEM. Change-Id: I9f1a20d5871f60d2899ef7d525f4cf837b0a9088 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111311 Tested-by: Jenkins Reviewed-by: Gülşah Köse Signed-off-by: Xisco Fauli Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112241 Signed-off-by: Xisco Fauli Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112262 diff --git a/include/svx/unoshprp.hxx b/include/svx/unoshprp.hxx index cf7452e8303a..8cbeff73a134 100644 --- a/include/svx/unoshprp.hxx +++ b/include/svx/unoshprp.hxx @@ -224,8 +224,8 @@ { OUString(UNO_NAME_SHADOWTRANSPARENCE),SDRATTR_SHADOWTRANSPARENCE, ::cppu::UnoType::get(),0, 0}, \ { OUString(UNO_NAME_SHADOWXDIST), SDRATTR_SHADOWXDIST, ::cppu::UnoType::get(),0, 0, PropertyMoreFlags::METRIC_ITEM}, \ { OUString(UNO_NAME_SHADOWYDIST), SDRATTR_SHADOWYDIST, ::cppu::UnoType::get(),0, 0, PropertyMoreFlags::METRIC_ITEM}, \ -{ OUString(UNO_NAME_SHADOWSIZEX), SDRATTR_SHADOWSIZEX, ::cppu::UnoType::get(),0, 0, PropertyMoreFlags::METRIC_ITEM}, \ -{ OUString(UNO_NAME_SHADOWSIZEY), SDRATTR_SHADOWSIZEY, ::cppu::UnoType::get(),0, 0, PropertyMoreFlags::METRIC_ITEM}, +{ OUString(UNO_NAME_SHADOWSIZEX), SDRATTR_SHADOWSIZEX, ::cppu::UnoType::get(),0, 0}, \ +{ OUString(UNO_NAME_SHADOWSIZEY), SDRATTR_SHADOWSIZEY, ::cppu::UnoType::get(),0, 0}, #define LINE_PROPERTIES_DEFAULTS\ { OUString(UNO_NAME_LINECAP), XATTR_LINECAP, ::cppu::UnoType::get(), 0, 0}, \ diff --git a/sw/CppunitTest_sw_ooxmlimport2.mk b/sw/CppunitTest_sw_ooxmlimport2.mk index f47d7e35830b..6df866aebadf 100644 --- a/sw/CppunitTest_sw_ooxmlimport2.mk +++ b/sw/CppunitTest_sw_ooxmlimport2.mk @@ -33,6 +33,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sw_ooxmlimport2, \ tl \ vcl \ svxcore \ +svl\ )) $(eval $(call gb_CppunitTest_use_externals,sw_ooxmlimport2,\ diff --git a/sw/qa/extras/ooxmlexport/data/tdf133473.docx b/sw/qa/extras/ooxmlexport/data/tdf133473.docx new file mode 100644 index ..c351db950231 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf133473.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx index 1e28459cc0b0..71e313d4c545 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx @@ -9,6 +9,11 @@ #include +#include +#include +#include +#include + #include #include #include @@ -86,6 +91,22 @@ DECLARE_OOXMLEXPORT_TEST(testTdf140137, "tdf140137.docx") // Don't throw exception during load } +DECLARE_OOXMLEXPORT_TEST(testTdf133473_shadowSize, "tdf133473.docx") +{ +uno::Reference xShape = getShape(1); + +SdrObject* pObj(GetSdrObjectFromXShape(xShape)); +const SfxItemSet& rSet = pObj->GetMergedItemSet(); +sal_Int32 nSize1 = rSet.Get(SDRATTR_SHADOWSIZEX).GetValue(); + +// Without the accompanying fix in place, this test would have failed with: +// - Expected: 20 +// - Actual : 113386 +// I.e. Shadow size will be smaller than actual. + +CPPUNIT_ASSERT_EQUAL(static_cast(20), nSize1); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140929] Crash in: SwContentNode::GetAttr(SfxItemSet &)
https://bugs.documentfoundation.org/show_bug.cgi?id=140929 Julien Nabet changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO Version|unspecified |7.1.0.3 release OS|All |Windows (All) CC||serval2...@yahoo.fr --- Comment #4 from Julien Nabet --- Please upgrade to 7.1.1 (since 7.1 brand is quite new, you should try to use its last version). Also could you give a try at https://wiki.documentfoundation.org/QA/FirstSteps ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41652] "NO-BREAK SPACE" (U+00A0) interpreted as fixed-width space
https://bugs.documentfoundation.org/show_bug.cgi?id=41652 --- Comment #37 from Maciej Kotliński --- Everybody understand that the compatibility should be preserved. Unfortunately most of texts in Polish, Czech and probably some other languages looks ugly... very ugly. I know that other word processors format these texts in similar ugly way. Could LiberOffice be better then others? Nobodylike to readsuch a justified text. It would be niece to have an option allowing for setting variable width of nonbreakable space in paragraph format settings. The user could decide. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140951] Base crashes as soon as I start an 'Abfrage'
https://bugs.documentfoundation.org/show_bug.cgi?id=140951 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Julien Nabet --- Which type of database do you use? Embedded type (Firebird or HSQLDB), Mysql, MariaDD, Postgresql, ODBC? Do you reproduce this with a brand new odb file with HSQLDB embedded? Since you got LO 64 bits, do you have Java 64 bits too? (Base part is quite dependent on Java) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140936] RFE: Writer: Change Selection type icon in Statusbar to labels depending on current type
https://bugs.documentfoundation.org/show_bug.cgi?id=140936 --- Comment #1 from Jim Raykowski --- Created attachment 170416 --> https://bugs.documentfoundation.org/attachment.cgi?id=170416=edit statusbar section mode control demo Pending UX approval: https://gerrit.libreoffice.org/c/core/+/112367 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 140936] RFE: Writer: Change Selection type icon in Statusbar to labels depending on current type
https://bugs.documentfoundation.org/show_bug.cgi?id=140936 --- Comment #1 from Jim Raykowski --- Created attachment 170416 --> https://bugs.documentfoundation.org/attachment.cgi?id=170416=edit statusbar section mode control demo Pending UX approval: https://gerrit.libreoffice.org/c/core/+/112367 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 140950] Blue screen shows as soon as I try to open LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=140950 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #2 from Julien Nabet --- Could you give a try at https://wiki.documentfoundation.org/QA/FirstSteps ? If you still reproduce this, perhaps you should give a try at brand new 7.1.1? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: xmlsecurity/source
xmlsecurity/source/xmlsec/mscrypt/x509certificate_mscryptimpl.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 4af56d8189012f96d0471d7f50a3e4463516 Author: Stephan Bergmann AuthorDate: Thu Mar 11 09:13:51 2021 +0100 Commit: Stephan Bergmann CommitDate: Thu Mar 11 21:33:25 2021 +0100 Don't use std::ostream operator <<(char16_t const *) deleted in C++20 Building with --with-latest-c++: > C:/lo/core/xmlsecurity/source/xmlsec/mscrypt/x509certificate_mscryptimpl.cxx(664): error C2280: 'std::basic_ostream> ::operator <<>(std::basic_ostream> &,const char16_t *)': attempting to reference a deleted function > C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\1428~1.299\Include\ostream(951): note: see declaration of 'std::operator <<' etc. Change-Id: I70ae201c761fae907e602b6a929e23e3c8e7f692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112318 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/xmlsecurity/source/xmlsec/mscrypt/x509certificate_mscryptimpl.cxx b/xmlsecurity/source/xmlsec/mscrypt/x509certificate_mscryptimpl.cxx index ce65672987c5..b40639f586d8 100644 --- a/xmlsecurity/source/xmlsec/mscrypt/x509certificate_mscryptimpl.cxx +++ b/xmlsecurity/source/xmlsec/mscrypt/x509certificate_mscryptimpl.cxx @@ -661,7 +661,7 @@ static bool EncodeDistinguishedName(std::u16string_view const rName, CERT_NAME_B reinterpret_cast(rName.data()), CERT_X500_NAME_STR, nullptr, nullptr, , )) { -SAL_INFO("xmlsecurity.xmlsec", "CertStrToNameW failed: " << WindowsErrorString(GetLastError()) << "; " << reinterpret_cast(pszError)); +SAL_INFO("xmlsecurity.xmlsec", "CertStrToNameW failed: " << WindowsErrorString(GetLastError()) << "; " << OUString(o3tl::toU(pszError))); return false; } rBlob.pbData = new BYTE[rBlob.cbData]; @@ -669,7 +669,7 @@ static bool EncodeDistinguishedName(std::u16string_view const rName, CERT_NAME_B reinterpret_cast(rName.data()), CERT_X500_NAME_STR, nullptr, rBlob.pbData, , )) { -SAL_INFO("xmlsecurity.xmlsec", "CertStrToNameW failed: " << WindowsErrorString(GetLastError()) << "; " << reinterpret_cast(pszError)); +SAL_INFO("xmlsecurity.xmlsec", "CertStrToNameW failed: " << WindowsErrorString(GetLastError()) << "; " << OUString(o3tl::toU(pszError))); return false; } return true; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/main/ChartController.cxx | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) New commits: commit 2b808bad616a557fabb080b49c5b925d2481b9b5 Author: Caolán McNamara AuthorDate: Thu Mar 11 15:26:21 2021 + Commit: Caolán McNamara CommitDate: Thu Mar 11 21:29:04 2021 +0100 awt::XWindow has setVisible so don't need to fetch VCLXWindow to do that Change-Id: I3da36a5e54276dad483abb263fc15fd9d045ec59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112350 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/chart2/source/controller/main/ChartController.cxx b/chart2/source/controller/main/ChartController.cxx index 3d310d8d8bea..08b8c65c31f7 100644 --- a/chart2/source/controller/main/ChartController.cxx +++ b/chart2/source/controller/main/ChartController.cxx @@ -48,7 +48,9 @@ #include #include +#include +#include #include #include #include @@ -66,7 +68,6 @@ #include #include #include -#include #include #include #include @@ -424,12 +425,9 @@ void SAL_CALL ChartController::attachFrame( //get the window parent from the frame to use as parent for our new window if(xFrame.is()) { -uno::Reference< awt::XWindow > xContainerWindow = xFrame->getContainerWindow(); -VCLXWindow* pParentComponent = comphelper::getUnoTunnelImplementation(xContainerWindow); -assert(pParentComponent); -if (pParentComponent) -pParentComponent->setVisible(true); - +uno::Reference xContainerWindow = xFrame->getContainerWindow(); +if (xContainerWindow) +xContainerWindow->setVisible(true); pParent = VCLUnoHelper::GetWindow( xContainerWindow ); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 97362] Convert Java complex tests to Python
https://bugs.documentfoundation.org/show_bug.cgi?id=97362 --- Comment #39 from Rishant Rokaha --- Hi, I would like to work on this. Can you please elaborate more? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - emfio/inc emfio/source include/vcl vcl/inc vcl/source
emfio/inc/mtftools.hxx| 24 emfio/source/reader/emfreader.cxx |4 emfio/source/reader/mtftools.cxx | 211 +- emfio/source/reader/wmfreader.cxx |3 include/vcl/metaact.hxx |8 + vcl/inc/impfont.hxx |6 - vcl/source/filter/wmf/emfwr.cxx |2 vcl/source/font/font.cxx | 64 ++- 8 files changed, 286 insertions(+), 36 deletions(-) New commits: commit 593e4f5b92619d9d44dc3cb79f8b5088ef8276af Author: Armin Le Grand (Allotropia) AuthorDate: Tue Feb 23 14:24:24 2021 +0100 Commit: Armin Le Grand CommitDate: Thu Mar 11 21:09:05 2021 +0100 tdf#127471 Detect EMF/WMF with wrong FontScale Before correcting our EMF/WMF export to write the Windows- specific data in the case of FontScaling, we wrote these files with wrong FontScaling. This change tries to detect and correct this at import, so that newer versions of the office on all plattforms can again load old, from us but not on Windows written EMF/WMF files. With this change we can read again all new and old EMF/WMF files (see table in task, comment 80). Change-Id: I1a0b0ab5f57c7cd40520401568af05cab4ecb4c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111399 Tested-by: Jenkins Reviewed-by: Armin Le Grand (cherry picked from commit 3d33e4ce3987ea17e73a72e84f7f0df7af8101a6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/11 diff --git a/emfio/inc/mtftools.hxx b/emfio/inc/mtftools.hxx index 70471b66ea21..286442767d3a 100644 --- a/emfio/inc/mtftools.hxx +++ b/emfio/inc/mtftools.hxx @@ -27,6 +27,7 @@ #include #include #include +#include #include "emfiodllapi.h" @@ -259,6 +260,8 @@ namespace emfio #define HUNDREDTH_MILLIMETERS_PER_MILLIINCH 2.54 #define MILLIINCH_PER_TWIPS 1.44 +class MetaFontAction; + // WmfReader == namespace emfio @@ -458,6 +461,24 @@ namespace emfio {} }; +// tdf#127471 implement detection and correction of wrongly scaled +// fonts in own-written, old (before this fix) EMF/WMF files +class ScaledFontDetectCorrectHelper +{ +private: +rtl::Reference maCurrentMetaFontAction; +std::vector maAlternativeFontScales; +std::vector, double>> maPositiveIdentifiedCases; +std::vector, double>> maNegativeIdentifiedCases; + +public: +ScaledFontDetectCorrectHelper(); +void endCurrentMetaFontAction(); +void newCurrentMetaFontAction(rtl::Reference& rNewMetaFontAction); +void evaluateAlternativeFontScale(OUString const & rText, tools::Long nImportedTextLength); +void applyAlternativeFontScale(); +}; + class MtfTools { MtfTools(MtfTools const &) = delete; @@ -521,6 +542,9 @@ namespace emfio sal_uInt32 mnEndPos; std::vector>maBmpSaveList; +// tdf#127471 always try to detect - only used with ScaledText +ScaledFontDetectCorrectHelper maScaledFontHelper; + boolmbNopMode : 1; boolmbFillStyleSelected : 1; boolmbClipNeedsUpdate : 1; diff --git a/emfio/source/reader/emfreader.cxx b/emfio/source/reader/emfreader.cxx index b1d3ae4394da..5dfd2ffbe76c 100644 --- a/emfio/source/reader/emfreader.cxx +++ b/emfio/source/reader/emfreader.cxx @@ -2034,6 +2034,10 @@ namespace emfio } mpInputStream->Seek( nNextPos ); } + +// tdf#127471 +maScaledFontHelper.applyAlternativeFontScale(); + if( !maBmpSaveList.empty() ) ResolveBitmapActions( maBmpSaveList ); diff --git a/emfio/source/reader/mtftools.cxx b/emfio/source/reader/mtftools.cxx index 7a462cc659dd..94ddcd549cec 100644 --- a/emfio/source/reader/mtftools.cxx +++ b/emfio/source/reader/mtftools.cxx @@ -299,6 +299,184 @@ namespace emfio #endif }; +// tdf#127471 +ScaledFontDetectCorrectHelper::ScaledFontDetectCorrectHelper() +: maCurrentMetaFontAction(), +maAlternativeFontScales(), +maPositiveIdentifiedCases(), +maNegativeIdentifiedCases() +{ +} + +void ScaledFontDetectCorrectHelper::endCurrentMetaFontAction() +{ +if(maCurrentMetaFontAction.is() && !maAlternativeFontScales.empty()) +{ +// create average corrected FontScale value and count +// positive/negative hits +sal_uInt32 nPositive(0); +sal_uInt32 nNegative(0); +double fAverage(0.0); + +for(double fPart : maAlternativeFontScales) +{ +if(fPart < 0.0) +{ +nNegative++; +fAverage += -fPart; +} +else +{
[Libreoffice-bugs] [Bug 88940] error 0xc000007b
https://bugs.documentfoundation.org/show_bug.cgi?id=88940 V Stuart Foote changed: What|Removed |Added URL|https://vipcracks.com/avast | |-cleanup-premium-activation | |-code-2021-crack-free-downl | |oad/| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140861] Problem to recover data from an excel file with LibreOffice Calc 6.4.6.2
https://bugs.documentfoundation.org/show_bug.cgi?id=140861 --- Comment #7 from Julien Nabet --- On LO Debian package 7.0.4, I don't reproduce this with gen/kf5/gtk3 renderings. Could you give a try at https://wiki.documentfoundation.org/QA/FirstSteps ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88940] error 0xc000007b
https://bugs.documentfoundation.org/show_bug.cgi?id=88940 vipcracks changed: What|Removed |Added URL||https://vipcracks.com/avast ||-cleanup-premium-activation ||-code-2021-crack-free-downl ||oad/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: drawinglayer/source
drawinglayer/source/primitive2d/controlprimitive2d.cxx | 23 + 1 file changed, 7 insertions(+), 16 deletions(-) New commits: commit 204a70f568cef3d9c685112d1c32f053a91469ca Author: Caolán McNamara AuthorDate: Thu Mar 11 14:30:29 2021 + Commit: Caolán McNamara CommitDate: Thu Mar 11 20:27:26 2021 +0100 use VCLUnoHelper::GetWindow instead of directly using VCLXWindow Change-Id: I886525169834d24b6c060fb4722e1afda23dbc26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112346 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/drawinglayer/source/primitive2d/controlprimitive2d.cxx b/drawinglayer/source/primitive2d/controlprimitive2d.cxx index 3f20baa1351f..7ccc9660c78c 100644 --- a/drawinglayer/source/primitive2d/controlprimitive2d.cxx +++ b/drawinglayer/source/primitive2d/controlprimitive2d.cxx @@ -18,6 +18,7 @@ */ #include +#include #include #include #include @@ -34,7 +35,6 @@ #include #include #include -#include #include #include #include @@ -144,25 +144,16 @@ namespace drawinglayer::primitive2d if(xControl.is()) { -uno::Reference< awt::XWindowPeer > xWindowPeer(xControl->getPeer()); +uno::Reference xWindowPeer(xControl->getPeer()); -if(xWindowPeer.is()) +VclPtr pWindow = VCLUnoHelper::GetWindow(xWindowPeer); +if (pWindow) { -VCLXWindow* pVCLXWindow = comphelper::getUnoTunnelImplementation(xWindowPeer); +pWindow = pWindow->GetParent(); -if(pVCLXWindow) +if(pWindow && MapUnit::Map100thMM == pWindow->GetMapMode().GetMapUnit()) { -VclPtr pWindow = pVCLXWindow->GetWindow(); - -if(pWindow) -{ -pWindow = pWindow->GetParent(); - -if(pWindow && MapUnit::Map100thMM == pWindow->GetMapMode().GetMapUnit()) -{ -bUserIs100thmm = true; -} -} +bUserIs100thmm = true; } } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/fmtools.hxx |2 +- svx/source/form/formcontrolling.cxx |5 +++-- svx/source/inc/formcontroller.hxx |6 +++--- 3 files changed, 7 insertions(+), 6 deletions(-) New commits: commit 76867304b550af5c44c1fd6b82928fb2b69addc7 Author: Caolán McNamara AuthorDate: Thu Mar 11 11:24:32 2021 + Commit: Caolán McNamara CommitDate: Thu Mar 11 20:25:41 2021 +0100 use an explicit parent for error message Change-Id: Idf5a1c6a4313ab58c2bf6ee0ec02a8d003eee83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112335 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/include/svx/fmtools.hxx b/include/svx/fmtools.hxx index b00b33cb0443..97d6fcff0d05 100644 --- a/include/svx/fmtools.hxx +++ b/include/svx/fmtools.hxx @@ -52,7 +52,7 @@ namespace vcl { class Window; } void displayException(const css::sdbc::SQLException&, vcl::Window* _pParent); SVXCORE_DLLPUBLIC void displayException(const css::sdb::SQLContext&, vcl::Window* _pParent); void displayException(const css::sdb::SQLErrorEvent&, vcl::Window* _pParent); -void displayException(const css::uno::Any&, vcl::Window* _pParent = nullptr); +void displayException(const css::uno::Any&, vcl::Window* _pParent); sal_Int32 getElementPos(const css::uno::Reference< css::container::XIndexAccess>& xCont, const css::uno::Reference< css::uno::XInterface>& xElement); diff --git a/svx/source/form/formcontrolling.cxx b/svx/source/form/formcontrolling.cxx index c18a0f6c373b..456e5a88ffbf 100644 --- a/svx/source/form/formcontrolling.cxx +++ b/svx/source/form/formcontrolling.cxx @@ -23,6 +23,7 @@ #include #include #include +#include #include #include @@ -353,9 +354,9 @@ namespace svx // display the error. Prefer the one reported in errorOccurred over the one caught. if ( m_aOperationError.hasValue() ) -displayException( m_aOperationError ); +displayException(m_aOperationError, svxform::FormController::getDialogParentWindow(m_xFormOperations->getController())); else if ( aError.hasValue() ) -displayException( aError ); +displayException(aError, svxform::FormController::getDialogParentWindow(m_xFormOperations->getController())); else OSL_FAIL( "FormControllerHelper::impl_operateForm_nothrow: no success, but no error?" ); diff --git a/svx/source/inc/formcontroller.hxx b/svx/source/inc/formcontroller.hxx index 6ed3ffeb2c4c..c25dd5d808ac 100644 --- a/svx/source/inc/formcontroller.hxx +++ b/svx/source/inc/formcontroller.hxx @@ -197,6 +197,9 @@ namespace svxform public: FormController( const css::uno::Reference< css::uno::XComponentContext > & _rxORB ); +// returns the window which should be used as parent window for dialogs +static vcl::Window* getDialogParentWindow(css::uno::Reference xFormController); + private: virtual ~FormController() override; @@ -507,9 +510,6 @@ namespace svxform bool isLocked() const {return m_bLocked;} bool determineLockState() const; -// returns the window which should be used as parent window for dialogs -static vcl::Window* getDialogParentWindow(css::uno::Reference xFormController); - css::uno::Reference< css::frame::XDispatchProviderInterceptor> createInterceptor(const css::uno::Reference< css::frame::XDispatchProviderInterception>& _xInterception); // create a new interceptor, register it on the given object voiddeleteInterceptor(const css::uno::Reference< css::frame::XDispatchProviderInterception>& _xInterception); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svx/source
svx/source/form/formcontroller.cxx | 17 +++-- svx/source/inc/formcontroller.hxx |4 ++-- 2 files changed, 9 insertions(+), 12 deletions(-) New commits: commit b7bcb17311ea99d1849f87e329add0eff5f6fc75 Author: Caolán McNamara AuthorDate: Thu Mar 11 11:21:24 2021 + Commit: Caolán McNamara CommitDate: Thu Mar 11 20:25:14 2021 +0100 refactor getDialogParentWindow to take an XFormController arg Change-Id: I4c42adfa079babf7d3efbd881293102d6cb526ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112334 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/svx/source/form/formcontroller.cxx b/svx/source/form/formcontroller.cxx index c1ee3954cdc4..15b318e8f8d6 100644 --- a/svx/source/form/formcontroller.cxx +++ b/svx/source/form/formcontroller.cxx @@ -3265,7 +3265,7 @@ void FormController::startFiltering() // create a filter control Reference< XControl > xFilterControl = form::control::FilterControl::createWithFormat( m_xComponentContext, -VCLUnoHelper::GetInterface( getDialogParentWindow() ), +VCLUnoHelper::GetInterface( getDialogParentWindow(this) ), xFormatter, xModel); @@ -3435,7 +3435,6 @@ Sequence< OUString > SAL_CALL FormController::getSupportedModes() return aModes; } - sal_Bool SAL_CALL FormController::supportsMode(const OUString& Mode) { ::osl::MutexGuard aGuard( m_aMutex ); @@ -3445,14 +3444,12 @@ sal_Bool SAL_CALL FormController::supportsMode(const OUString& Mode) return comphelper::findValue(aModes, Mode) != -1; } - -vcl::Window* FormController::getDialogParentWindow() +vcl::Window* FormController::getDialogParentWindow(css::uno::Reference xFormController) { -OSL_ENSURE( !impl_isDisposed_nofail(), "FormController: already disposed!" ); vcl::Window* pParentWindow = nullptr; try { -Reference< XControl > xContainerControl( getContainer(), UNO_QUERY_THROW ); +Reference< XControl > xContainerControl( xFormController->getContainer(), UNO_QUERY_THROW ); Reference< XWindowPeer > xContainerPeer( xContainerControl->getPeer(), UNO_SET_THROW ); pParentWindow = VCLUnoHelper::GetWindow( xContainerPeer ); } @@ -3621,7 +3618,7 @@ sal_Bool SAL_CALL FormController::approveRowChange(const RowChangeEvent& _rEvent { Reference< XControl > xControl( locateControl( xInvalidModel ) ); aGuard.clear(); -displayErrorSetFocus( sInvalidityExplanation, xControl, getDialogParentWindow() ); +displayErrorSetFocus( sInvalidityExplanation, xControl, getDialogParentWindow(this) ); return false; } @@ -3667,7 +3664,7 @@ sal_Bool SAL_CALL FormController::approveRowChange(const RowChangeEvent& _rEvent xControl.set( rColInfo.xFirstGridWithInputRequiredColumn, UNO_QUERY ); aGuard.clear(); -displayErrorSetFocus( sMessage, rColInfo.xFirstControlWithInputRequired, getDialogParentWindow() ); +displayErrorSetFocus( sMessage, rColInfo.xFirstControlWithInputRequired, getDialogParentWindow(this) ); return false; } } @@ -3749,7 +3746,7 @@ void SAL_CALL FormController::errorOccured(const SQLErrorEvent& aEvent) else { aGuard.clear(); -displayException(aEvent, getDialogParentWindow()); +displayException(aEvent, getDialogParentWindow(this)); } } @@ -4121,7 +4118,7 @@ bool FormController::ensureInteractionHandler() m_bAttemptedHandlerCreation = true; m_xInteractionHandler = InteractionHandler::createWithParent(m_xComponentContext, - VCLUnoHelper::GetInterface(getDialogParentWindow())); + VCLUnoHelper::GetInterface(getDialogParentWindow(this))); return m_xInteractionHandler.is(); } diff --git a/svx/source/inc/formcontroller.hxx b/svx/source/inc/formcontroller.hxx index 065852fe9c3a..6ed3ffeb2c4c 100644 --- a/svx/source/inc/formcontroller.hxx +++ b/svx/source/inc/formcontroller.hxx @@ -507,8 +507,8 @@ namespace svxform bool isLocked() const {return m_bLocked;} bool determineLockState() const; -vcl::Window* getDialogParentWindow(); -// returns the window which should be used as parent window for dialogs +// returns the window which should be used as parent window for dialogs +static vcl::Window* getDialogParentWindow(css::uno::Reference xFormController); css::uno::Reference< css::frame::XDispatchProviderInterceptor> createInterceptor(const css::uno::Reference< css::frame::XDispatchProviderInterception>& _xInterception); // create a new interceptor, register it on the given object
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/fmtools.hxx |2 +- svx/source/form/fmvwimp.cxx |7 +-- 2 files changed, 2 insertions(+), 7 deletions(-) New commits: commit 4fa2abb5e013738b0f7780a7eb29acdce24794b8 Author: Caolán McNamara AuthorDate: Thu Mar 11 10:53:08 2021 + Commit: Caolán McNamara CommitDate: Thu Mar 11 20:24:36 2021 +0100 use an explicit parent for error message Change-Id: Ib171ee0e7dc4936552b5a9a5c9d50ae7fd6a54d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112333 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/include/svx/fmtools.hxx b/include/svx/fmtools.hxx index 90eb6d74c49c..b00b33cb0443 100644 --- a/include/svx/fmtools.hxx +++ b/include/svx/fmtools.hxx @@ -51,7 +51,7 @@ namespace vcl { class Window; } // display info about a simple css::sdbc::SQLException void displayException(const css::sdbc::SQLException&, vcl::Window* _pParent); SVXCORE_DLLPUBLIC void displayException(const css::sdb::SQLContext&, vcl::Window* _pParent); -void displayException(const css::sdb::SQLErrorEvent&, vcl::Window* _pParent = nullptr); +void displayException(const css::sdb::SQLErrorEvent&, vcl::Window* _pParent); void displayException(const css::uno::Any&, vcl::Window* _pParent = nullptr); sal_Int32 getElementPos(const css::uno::Reference< css::container::XIndexAccess>& xCont, const css::uno::Reference< css::uno::XInterface>& xElement); diff --git a/svx/source/form/fmvwimp.cxx b/svx/source/form/fmvwimp.cxx index f776d28ab4d7..8a52fbefb118 100644 --- a/svx/source/form/fmvwimp.cxx +++ b/svx/source/form/fmvwimp.cxx @@ -565,7 +565,6 @@ void FmXFormView::removeWindow( const Reference< XControlContainer >& _rxCC ) } } - void FmXFormView::displayAsyncErrorMessage( const SQLErrorEvent& _rEvent ) { DBG_ASSERT( nullptr == m_nErrorMessageEvent, "FmXFormView::displayAsyncErrorMessage: not too fast, please!" ); @@ -575,28 +574,24 @@ void FmXFormView::displayAsyncErrorMessage( const SQLErrorEvent& _rEvent ) m_nErrorMessageEvent = Application::PostUserEvent( LINK( this, FmXFormView, OnDelayedErrorMessage ) ); } - IMPL_LINK_NOARG(FmXFormView, OnDelayedErrorMessage, void*, void) { m_nErrorMessageEvent = nullptr; -displayException( m_aAsyncError ); +displayException(m_aAsyncError, VCLUnoHelper::GetWindow(GetParentWindow())); } - void FmXFormView::onFirstViewActivation( const FmFormModel* _pDocModel ) { if ( _pDocModel && _pDocModel->GetAutoControlFocus() ) m_nAutoFocusEvent = Application::PostUserEvent( LINK( this, FmXFormView, OnAutoFocus ) ); } - void FmXFormView::suspendTabOrderUpdate() { OSL_ENSURE( !m_isTabOrderUpdateSuspended, "FmXFormView::suspendTabOrderUpdate: nesting not allowed!" ); m_isTabOrderUpdateSuspended = true; } - void FmXFormView::resumeTabOrderUpdate() { OSL_ENSURE( m_isTabOrderUpdateSuspended, "FmXFormView::resumeTabOrderUpdate: not suspended!" ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svx/source
svx/source/form/fmvwimp.cxx |9 +++-- svx/source/inc/fmvwimp.hxx |2 ++ 2 files changed, 9 insertions(+), 2 deletions(-) New commits: commit 7946225280bfac1a04d73c69ff3eda8ac8b4e820 Author: Caolán McNamara AuthorDate: Thu Mar 11 10:51:48 2021 + Commit: Caolán McNamara CommitDate: Thu Mar 11 20:24:17 2021 +0100 factor out a FmXFormView::GetParentWindow Change-Id: I35d5de294ac08e1ec6a597835b879dc1f377ef86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112332 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/svx/source/form/fmvwimp.cxx b/svx/source/form/fmvwimp.cxx index 4bc1c96fb13c..f776d28ab4d7 100644 --- a/svx/source/form/fmvwimp.cxx +++ b/svx/source/form/fmvwimp.cxx @@ -1014,6 +1014,12 @@ void FmXFormView::breakCreateFormObject() m_xLastCreatedControlModel.clear(); } +Reference FmXFormView::GetParentWindow() +{ +const vcl::Window* pCurrentWindow = m_pView ? dynamic_cast(m_pView->GetActualOutDev()) : nullptr; +return VCLUnoHelper::GetInterface(const_cast(pCurrentWindow)); +} + IMPL_LINK_NOARG( FmXFormView, OnStartControlWizard, void*, void ) { m_nControlWizardEvent = nullptr; @@ -1051,8 +1057,7 @@ IMPL_LINK_NOARG( FmXFormView, OnStartControlWizard, void*, void ) // build the argument list ::comphelper::NamedValueCollection aWizardArgs; aWizardArgs.put("ObjectModel", m_xLastCreatedControlModel); -const vcl::Window* pCurrentWindow = m_pView ? dynamic_cast(m_pView->GetActualOutDev()) : nullptr; -aWizardArgs.put("ParentWindow", VCLUnoHelper::GetInterface(const_cast(pCurrentWindow))); +aWizardArgs.put("ParentWindow", GetParentWindow()); // create the wizard object Reference< XExecutableDialog > xWizard; diff --git a/svx/source/inc/fmvwimp.hxx b/svx/source/inc/fmvwimp.hxx index 36f1dcda1883..62291ad8b195 100644 --- a/svx/source/inc/fmvwimp.hxx +++ b/svx/source/inc/fmvwimp.hxx @@ -172,6 +172,8 @@ class FmXFormView : public ::cppu::WeakImplHelper< FmFormShell* GetFormShell() const; +css::uno::Reference GetParentWindow(); + protected: FmXFormView( FmFormView* _pView ); virtual ~FmXFormView() override; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140889] Slide menu in Impress is missing most of the commands in the menu
https://bugs.documentfoundation.org/show_bug.cgi?id=140889 Rafael Lima changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rafael.palma.l...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140861] Problem to recover data from an excel file with LibreOffice Calc 6.4.6.2
https://bugs.documentfoundation.org/show_bug.cgi?id=140861 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> --- I open file just easy in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 9d8accf03984a64a4105826e55b221962628eb93 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL and in Version: 7.1.0.3 (x64) / LibreOffice Community Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL So, try install 7.1 version then and check it again -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs