[Libreoffice-commits] core.git: vcl/source
vcl/source/fontsubset/sft.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit b667327463de24715405322e69e1933cf50d25e6 Author: Caolán McNamara AuthorDate: Thu Mar 3 09:13:38 2022 + Commit: Caolán McNamara CommitDate: Thu Mar 3 13:43:34 2022 +0100 ofz: Integer-overflow Change-Id: Ifb3c0e4c9fec5af448bae7efaddac234854fb468 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130906 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/vcl/source/fontsubset/sft.cxx b/vcl/source/fontsubset/sft.cxx index e2ae8a450954..bfdc28f1d79b 100644 --- a/vcl/source/fontsubset/sft.cxx +++ b/vcl/source/fontsubset/sft.cxx @@ -175,8 +175,8 @@ static F16Dot16 fixedMul(F16Dot16 a, F16Dot16 b) int sign; sign = (a & 0x8000) ^ (b & 0x8000); -if (a < 0) a = -a; -if (b < 0) b = -b; +if (a < 0) a = o3tl::saturating_toggle_sign(a); +if (b < 0) b = o3tl::saturating_toggle_sign(b); a1 = a >> 16; b1 = a & 0x;
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - 14 commits - drawinglayer/source hwpfilter/source include/o3tl sc/source sw/qa sw/source vcl/source writerfilter/source
drawinglayer/source/tools/emfphelperdata.cxx | 31 -
hwpfilter/source/drawing.h | 50 +-
hwpfilter/source/hcode.cxx |2
hwpfilter/source/hwpfile.cxx |9
hwpfilter/source/hwpfile.h |2
hwpfilter/source/hwpread.cxx | 20
hwpfilter/source/hwpreader.cxx | 15
include/o3tl/safeint.hxx |8
sc/source/filter/lotus/op.cxx| 11
sw/qa/extras/layout/data/LIBREOFFICE-N4LA0OHZ.rtf| 347 +++
sw/qa/extras/layout/layout.cxx |5
sw/source/core/layout/tabfrm.cxx |1
vcl/source/fontsubset/sft.cxx|2
vcl/source/fontsubset/ttcr.cxx | 36 +
writerfilter/source/dmapper/DomainMapperTableManager.cxx |2
15 files changed, 477 insertions(+), 64 deletions(-)
New commits:
commit 24ee70d29362e15b8bc9d5e4b90afccd7cbe5320
Author: Caolán McNamara
AuthorDate: Tue Mar 1 10:18:51 2022 +
Commit: Michael Stahl
CommitDate: Thu Mar 3 13:38:07 2022 +0100
ofz: don't register style if hbox load failed
Change-Id: I4d9d5d76f0c2385871003720e933ed1926f66c70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130771
Reviewed-by: Michael Stahl
Tested-by: Jenkins
(cherry picked from commit 3ac009bfec614ece98313c6444b4c1183ff14954)
(cherry picked from commit 8abce17e43858d85325f05cb46d0b8d717356919)
diff --git a/hwpfilter/source/hwpread.cxx b/hwpfilter/source/hwpread.cxx
index 906246b2b69c..1ef27f7c243f 100644
--- a/hwpfilter/source/hwpread.cxx
+++ b/hwpfilter/source/hwpread.cxx
@@ -233,7 +233,6 @@ bool TxtBox::Read(HWPFile & hwpf)
hwpf.Read2b(, 1);
hwpf.Read2b(_ch, 1);
hwpf.Read2b(style.margin, 12);
-hwpf.AddFBoxStyle();
hwpf.Read2b(_xs, 1);
hwpf.Read2b(_ys, 1);
hwpf.Read2b(_xs, 1);
@@ -361,7 +360,10 @@ bool TxtBox::Read(HWPFile & hwpf)
else
m_pTable = nullptr;
-return !hwpf.State();
+bSuccess = !hwpf.State();
+if (bSuccess)
+hwpf.AddFBoxStyle();
+return bSuccess;
}
// picture(11)
@@ -482,12 +484,14 @@ bool Picture::Read(HWPFile & hwpf)
style.boxtype = 'G';
else
style.boxtype = 'D';
-hwpf.AddFBoxStyle();
// caption
hwpf.ReadParaList(caption);
-return !hwpf.State();
+bool bSuccess = !hwpf.State();
+if (bSuccess)
+hwpf.AddFBoxStyle();
+return bSuccess;
}
// line(15)
@@ -525,7 +529,6 @@ bool Line::Read(HWPFile & hwpf)
hwpf.Read2b(, 1);
hwpf.Read2b(_ch, 1);
hwpf.Read2b(style.margin, 12);
-hwpf.AddFBoxStyle();
hwpf.Read2b(_xs, 1);
hwpf.Read2b(_ys, 1);
hwpf.Read2b(_xs, 1);
@@ -554,7 +557,10 @@ bool Line::Read(HWPFile & hwpf)
hwpf.Read2b(, 1);
style.xpos = width;
-return !hwpf.State();
+bool bSuccess = !hwpf.State();
+if (bSuccess)
+hwpf.AddFBoxStyle();
+return bSuccess;
}
// hidden(15)
commit db916c9f9dc68b25e01fde68a36156644b23ba1f
Author: Caolán McNamara
AuthorDate: Sun Feb 27 21:17:52 2022 +
Commit: Michael Stahl
CommitDate: Thu Mar 3 13:38:06 2022 +0100
ofz#44991 keep paragraph's that failed to load until import is complete
to avoid dangling references to them
Change-Id: Ic8710f63a8cf6a6a665348c7c84bf0b43f0e2c83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130643
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 4836ac408b04225b66246671e29a54cd0d6703cf)
diff --git a/hwpfilter/source/drawing.h b/hwpfilter/source/drawing.h
index b6ed1971672a..7fa700971414 100644
--- a/hwpfilter/source/drawing.h
+++ b/hwpfilter/source/drawing.h
@@ -316,7 +316,7 @@ static bool LoadCommonHeader(HWPDrawingObject * hdo,
unsigned short * link_info)
return hmem->skipBlock(size - common_size ) != 0;
}
-static std::unique_ptr LoadDrawingObject(void)
+static std::unique_ptr LoadDrawingObject(HWPFile& hwpf)
{
HWPDrawingObject *prev = nullptr;
std::unique_ptr hdo, head;
@@ -355,7 +355,7 @@ static std::unique_ptr
LoadDrawingObject(void)
}
if (link_info & HDOFILE_HAS_CHILD)
{
-hdo->child = LoadDrawingObject();
+hdo->child = LoadDrawingObject(hwpf);
if (hdo->child == nullptr)
{
goto error;
@@ -384,6 +384,11 @@ error:
{
hdo->type = HWPDO_RECT;
}
+if (hdo->property.pPara)
+{
+hwpf.move_to_failed(std::unique_ptr(hdo->property.pPara));
+hdo->property.pPara = nullptr;
+}
HWPDOFunc(hdo.get(), OBJFUNC_FREE, nullptr, 0);
hdo.reset();
@@ -397,7 +402,7 @@ error:
}
-static bool LoadDrawingObjectBlock(Picture * pic)
+static bool LoadDrawingObjectBlock(Picture *
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-4' - 13 commits - drawinglayer/source hwpfilter/source include/o3tl sc/source sw/qa sw/source vcl/source writerfilter/source
drawinglayer/source/tools/emfphelperdata.cxx | 31 -
hwpfilter/source/drawing.h | 13
hwpfilter/source/hcode.cxx |2
hwpfilter/source/hwpfile.cxx |9
hwpfilter/source/hwpfile.h |2
hwpfilter/source/hwpread.cxx | 20
hwpfilter/source/hwpreader.cxx | 15
include/o3tl/safeint.hxx |8
sc/source/filter/lotus/op.cxx| 11
sw/qa/extras/layout/data/LIBREOFFICE-N4LA0OHZ.rtf| 347 +++
sw/qa/extras/layout/layout.cxx |3
sw/source/core/layout/tabfrm.cxx |1
vcl/source/fontsubset/sft.cxx| 12
vcl/source/fontsubset/ttcr.cxx | 36 +
writerfilter/source/dmapper/DomainMapperTableManager.cxx |2
15 files changed, 463 insertions(+), 49 deletions(-)
New commits:
commit 0ac3de55d70629356b412a0aa12a80948f869ec1
Author: Caolán McNamara
AuthorDate: Tue Mar 1 10:18:51 2022 +
Commit: Michael Stahl
CommitDate: Thu Mar 3 13:36:47 2022 +0100
ofz: don't register style if hbox load failed
Change-Id: I4d9d5d76f0c2385871003720e933ed1926f66c70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130771
Reviewed-by: Michael Stahl
Tested-by: Jenkins
(cherry picked from commit 3ac009bfec614ece98313c6444b4c1183ff14954)
(cherry picked from commit 8abce17e43858d85325f05cb46d0b8d717356919)
diff --git a/hwpfilter/source/hwpread.cxx b/hwpfilter/source/hwpread.cxx
index f3a6401260c5..61c427ad836c 100644
--- a/hwpfilter/source/hwpread.cxx
+++ b/hwpfilter/source/hwpread.cxx
@@ -234,7 +234,6 @@ bool TxtBox::Read(HWPFile & hwpf)
hwpf.Read2b(, 1);
hwpf.Read2b(_ch, 1);
hwpf.Read2b(style.margin, 12);
-hwpf.AddFBoxStyle();
hwpf.Read2b(_xs, 1);
hwpf.Read2b(_ys, 1);
hwpf.Read2b(_xs, 1);
@@ -362,7 +361,10 @@ bool TxtBox::Read(HWPFile & hwpf)
else
m_pTable = nullptr;
-return !hwpf.State();
+bSuccess = !hwpf.State();
+if (bSuccess)
+hwpf.AddFBoxStyle();
+return bSuccess;
}
namespace
@@ -509,12 +511,14 @@ bool Picture::Read(HWPFile & hwpf)
style.boxtype = 'G';
else
style.boxtype = 'D';
-hwpf.AddFBoxStyle();
// caption
hwpf.ReadParaList(caption);
-return !hwpf.State();
+bool bSuccess = !hwpf.State();
+if (bSuccess)
+hwpf.AddFBoxStyle();
+return bSuccess;
}
// line(15)
@@ -552,7 +556,6 @@ bool Line::Read(HWPFile & hwpf)
hwpf.Read2b(, 1);
hwpf.Read2b(_ch, 1);
hwpf.Read2b(style.margin, 12);
-hwpf.AddFBoxStyle();
hwpf.Read2b(_xs, 1);
hwpf.Read2b(_ys, 1);
hwpf.Read2b(_xs, 1);
@@ -581,7 +584,10 @@ bool Line::Read(HWPFile & hwpf)
hwpf.Read2b(, 1);
style.xpos = width;
-return !hwpf.State();
+bool bSuccess = !hwpf.State();
+if (bSuccess)
+hwpf.AddFBoxStyle();
+return bSuccess;
}
// hidden(15)
commit e45299a3e98f3fb973ebcce0cd5aec21ffeca424
Author: Caolán McNamara
AuthorDate: Tue Mar 1 09:35:34 2022 +
Commit: Michael Stahl
CommitDate: Thu Mar 3 13:36:47 2022 +0100
ofz: glyph data must be at least 10 bytes long to be useful
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130767
Reviewed-by: Michael Stahl
Tested-by: Jenkins
(cherry picked from commit b228045cf3fb50128fd40a8f26376443ad22f874)
Change-Id: I312c33c598013feced15c6f2dbcc66e493b703e6
diff --git a/vcl/source/fontsubset/ttcr.cxx b/vcl/source/fontsubset/ttcr.cxx
index 44d53ff10a23..e80260160c45 100644
--- a/vcl/source/fontsubset/ttcr.cxx
+++ b/vcl/source/fontsubset/ttcr.cxx
@@ -1251,7 +1251,7 @@ static void ProcessTables(TrueTypeCreator *tt)
/* printf("IDs: %d %d.\n", gd->glyphID, gd->newID); */
-if (gd->nbytes != 0) {
+if (gd->nbytes >= 10) {
z = GetInt16(gd->ptr, 2);
if (z < xMin) xMin = z;
commit a90c75a2ecf8c5521aeb1d6ca79b6bb73541ab6e
Author: Caolán McNamara
AuthorDate: Mon Feb 28 21:12:07 2022 +
Commit: Michael Stahl
CommitDate: Thu Mar 3 13:36:47 2022 +0100
ofz: measure maximum possible contours
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130774
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 26abdb564dad2011a298fc1253279232cb8b59cf)
Change-Id: Ie039abd835fef06514edde12b99e17360f5481a5
diff --git a/vcl/source/fontsubset/sft.cxx b/vcl/source/fontsubset/sft.cxx
index 2d2157f6f675..8a684e472e0a 100644
--- a/vcl/source/fontsubset/sft.cxx
+++ b/vcl/source/fontsubset/sft.cxx
@@ -362,7 +362,13 @@ static int GetSimpleTTOutline(TrueTypeFont const *ttf,
sal_uInt32 glyphID, Contr
if( glyphID >= ttf->nglyphs ) /*- glyph is not
[Libreoffice-bugs] [Bug 93094] Editing - sqlite3 tables read only even when defined with primary key using Xerial jdbc driver
https://bugs.documentfoundation.org/show_bug.cgi?id=93094 --- Comment #32 from Alex Thurgood --- Bug still present in Version: 7.2.5.2 / LibreOffice Community Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5 CPU threads: 8; OS: Mac OS X 12.2.1; UI render: default; VCL: osx Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Calc: threaded using latest Xerial JDBC driver from Maven (3.36.0.3) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-4' - bin/symstore.sh
bin/symstore.sh | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
New commits:
commit c3ca7870a749ef2f63f998d7f9d5570cd6ed0b52
Author: Juergen Funk
AuthorDate: Fri Mar 6 11:43:21 2020 +0100
Commit: Thorsten Behrens
CommitDate: Thu Mar 3 13:25:37 2022 +0100
symstore.sh: add vorbose mode
Change-Id: I01f9827140810080c037108021ca70f2b906b05e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90083
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/bin/symstore.sh b/bin/symstore.sh
index f4b0a5d13943..09ea3576bfe4 100755
--- a/bin/symstore.sh
+++ b/bin/symstore.sh
@@ -31,6 +31,10 @@ sqlite3.dll
ssl3.dll
ssleay32.dll"
+verbose_none()
+{
+do_none=
+}
add_pdb()
{
@@ -45,10 +49,15 @@ add_pdb()
ret=$(find "${INSTDIR}/" -type f -name "*.${extension}" | grep -vF
"$BLACK_LIST")
while IFS= read -r file
do
+${VERBOSE} -n "Found: $file"
# store dll/exe itself (needed for minidumps)
if [ $WITHEXEC == 1 ] ; then
cygpath -w "$file" >> "$list"
+${VERBOSE} " insert"
+else
+${VERBOSE} " "
fi
+
# store pdb file
filename=$(basename "$file" ".${extension}")
pdball+=($(grep -i "/${filename}${pdbext}" <<< ${ALL_PDBS}))
@@ -56,8 +65,12 @@ add_pdb()
cygpath -w "${pdball[0]}" >> "$list"
fi
case ${#pdball[@]} in
-0) ((++stats_notfound)) ;;
-1) ((++stats_found)) ;;
+0) ((++stats_notfound))
+ ${VERBOSE} " PDB not found"
+;;
+1) ((++stats_found))
+ ${VERBOSE} " ${pdball[0]} insert"
+;;
*) ((++stats_morefound))
if [ -z "$(echo $file | grep -F "$MOREPDBS_OKLIST")" ]; then
echo "Error: found duplicate PDBs:"
@@ -65,6 +78,8 @@ add_pdb()
echo " $morepdbs"
done
exit 1
+else
+ ${VERBOSE} " ${pdball[0]} insert (is in more okay
list)"
fi
;;
esac
@@ -98,13 +113,15 @@ SYM_PATH=${WORKDIR}/symstore
COMMENT=""
COMCMD=""
WITHEXEC=1
+VERBOSE=verbose_none
-USAGE="Usage: $0 [-h|-k |-p ]
+USAGE="Usage: $0 [-h|-k |-p |-c
|-n|-v]
-h: this cruft
-c specifies a comment for the transaction
-n do not store exe/dll on the symbole server
-k :keep this number of old symbol versions around
(default: ${MAX_KEEP}. Set to 0 for unlimited)
+ -v verbose mode, output detail report of files
-p : specify full path to symbol store tree
If no path is specified, defaults to ${SYM_PATH}.
"
@@ -117,6 +134,7 @@ do
-p|--path) SYM_PATH="$2"; shift 2;;
-c|--comment) COMCMD="/c"; COMMENT="$2"; shift 2;;
-n|--noexec) WITHEXEC=0; shift ;;
+-v|--verbose) VERBOSE=echo; shift ;;
-h|--help) echo "${USAGE}"; exit 0;;
-*) echo "${USAGE}" >&2; exit 1;;
*) break;;
[Libreoffice-bugs] [Bug 147730] LO Base does not handle compound primary key if one field is empty ("") SQLite3 / ODBC
https://bugs.documentfoundation.org/show_bug.cgi?id=147730 --- Comment #13 from Alex Thurgood --- To avoid any confusion with what I previously wrote about cursors, I've just experimented again with a JDBC connection, and it is "TYPE_FORWARD_ONLY" cursors that are supported by SQLite, whereas Base wants some other kind of cursor (probably scroll insensitive) The ODBC driver must get around this requirement somehow, by telling LO that it supports scroll insensitive cursors (even if SQLite doesn't). The scroll cursor management is one possible reason why you are seeing inconsistent results in the number of records displayed in the resultset. Another possible reason is that the ODBC function code within LO is incapable of handling combined field primary keys having possible NULL values. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147730] LO Base does not handle compound primary key if one field is empty ("") SQLite3 / ODBC
https://bugs.documentfoundation.org/show_bug.cgi?id=147730
--- Comment #12 from PhilipK ---
Thank you both for your input!
I am getting a little out of my depth here. This table is part of a db composed
of ten tables and now containing over 42,000 records. I have been
accessing/augmenting it for over a year now with LO, and the ODBC has worked
perfectly well for me hitherto, apart from this one area.
Incidentally, I have always used SQLIte Studio for table definition, and have
never attempted to create or modify table structures through the LO interface
(because that did seem to be problematic).
For me, I think that the simplest solution will be to put a dummy value ("-")
in those empty fields, which will be slightly annoying but should avoid future
problems if this material eventually gets into the public domain on another
platform with another front end.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147743] LibreOffice ne repond pas
https://bugs.documentfoundation.org/show_bug.cgi?id=147743 --- Comment #1 from GB --- Comment on attachment 178637 --> https://bugs.documentfoundation.org/attachment.cgi?id=178637 explication du bug constaté, LibreOffice presque inutilisable Les détails sont dans la PJ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147743] New: LibreOffice ne repond pas
https://bugs.documentfoundation.org/show_bug.cgi?id=147743 Bug ID: 147743 Summary: LibreOffice ne repond pas Product: LibreOffice Version: 7.3.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gbours...@gmail.com Created attachment 178637 --> https://bugs.documentfoundation.org/attachment.cgi?id=178637=edit explication du bug constaté, LibreOffice presque inutilisable Bonjour, Depuis une semaine, LibreOffice ne répond plus. A chaque lancement, il me demande de récupérer un fichier.odt (voir PJ) Ensuite, il ne répond pas à chaque fois que je veux l'utiliser, if faut une attende de plusieurs secondes pour chaque accès à une fonction dans un onglet. J'ai à chaque ouverture, l'apparition d'un fichier .lock dans le dossier du fichier. Après avoir consulté l'aide sur internet, j'ai appris qu'il pouvait exister des fichier .lock cachés dans AppData. J'en ai trouvé plus d'une centaine. Comme il est indiqué qu'il faut faire attention de ne pas supprimer certains fichiers dans AppData, je ne l'ai pas fait. Je voudrais savoir s'il faut tous les supprimer. Je vous envoie en PJ, le détail de ce qui se passe avec des exemples de fichiers .lock trouvés dans AppData. Merci d'avance de m'indiquer ce que je peux faire. Cordialement, Gérard Bourse France -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - hwpfilter/source
hwpfilter/source/hwpread.cxx | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) New commits: commit 6776bc7ce86bc7e52e6917921c8ac7b420e00aa6 Author: Caolán McNamara AuthorDate: Tue Mar 1 10:18:51 2022 + Commit: Michael Stahl CommitDate: Thu Mar 3 12:52:40 2022 +0100 ofz: don't register style if hbox load failed Change-Id: I4d9d5d76f0c2385871003720e933ed1926f66c70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130771 Reviewed-by: Michael Stahl Tested-by: Jenkins (cherry picked from commit 3ac009bfec614ece98313c6444b4c1183ff14954) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130918 Tested-by: Michael Stahl diff --git a/hwpfilter/source/hwpread.cxx b/hwpfilter/source/hwpread.cxx index f3a6401260c5..61c427ad836c 100644 --- a/hwpfilter/source/hwpread.cxx +++ b/hwpfilter/source/hwpread.cxx @@ -234,7 +234,6 @@ bool TxtBox::Read(HWPFile & hwpf) hwpf.Read2b(, 1); hwpf.Read2b(_ch, 1); hwpf.Read2b(style.margin, 12); -hwpf.AddFBoxStyle(); hwpf.Read2b(_xs, 1); hwpf.Read2b(_ys, 1); hwpf.Read2b(_xs, 1); @@ -362,7 +361,10 @@ bool TxtBox::Read(HWPFile & hwpf) else m_pTable = nullptr; -return !hwpf.State(); +bSuccess = !hwpf.State(); +if (bSuccess) +hwpf.AddFBoxStyle(); +return bSuccess; } namespace @@ -509,12 +511,14 @@ bool Picture::Read(HWPFile & hwpf) style.boxtype = 'G'; else style.boxtype = 'D'; -hwpf.AddFBoxStyle(); // caption hwpf.ReadParaList(caption); -return !hwpf.State(); +bool bSuccess = !hwpf.State(); +if (bSuccess) +hwpf.AddFBoxStyle(); +return bSuccess; } // line(15) @@ -552,7 +556,6 @@ bool Line::Read(HWPFile & hwpf) hwpf.Read2b(, 1); hwpf.Read2b(_ch, 1); hwpf.Read2b(style.margin, 12); -hwpf.AddFBoxStyle(); hwpf.Read2b(_xs, 1); hwpf.Read2b(_ys, 1); hwpf.Read2b(_xs, 1); @@ -581,7 +584,10 @@ bool Line::Read(HWPFile & hwpf) hwpf.Read2b(, 1); style.xpos = width; -return !hwpf.State(); +bool bSuccess = !hwpf.State(); +if (bSuccess) +hwpf.AddFBoxStyle(); +return bSuccess; } // hidden(15)
[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741 Bug 108741 depends on bug 116940, which changed state. Bug 116940 Summary: FILEOPEN PPT: Incorrect position of shapes https://bugs.documentfoundation.org/show_bug.cgi?id=116940 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116940] FILEOPEN PPT: Incorrect position of shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=116940 Gabor Kelemen (allotropia) changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sal/rtl
sal/rtl/strtmpl.hxx | 40 +++-
1 file changed, 23 insertions(+), 17 deletions(-)
New commits:
commit 04af8ac89ecdc98361f52b792ff0ce1c3ccb4517
Author: Mike Kaganski
AuthorDate: Thu Mar 3 10:18:20 2022 +0300
Commit: Mike Kaganski
CommitDate: Thu Mar 3 12:49:11 2022 +0100
Use a more conventional begin() / end() syntax
Also would potentially enable use in std range algorithms
that take different end sentinel type.
Change-Id: Ia75005caa7ce44302fc8612f5717a41d11087622
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130902
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sal/rtl/strtmpl.hxx b/sal/rtl/strtmpl.hxx
index 945aaa54a6e2..7234afd39ec1 100644
--- a/sal/rtl/strtmpl.hxx
+++ b/sal/rtl/strtmpl.hxx
@@ -30,7 +30,6 @@
#include "strimp.hxx"
-#include
#include
#include
#include
@@ -56,8 +55,15 @@ template struct null_terminated
{
assert(pStr);
}
-auto getIter() const { return p; }
-static auto getEndDetector() { return [](C* iter) { return *iter == 0; }; }
+auto begin() const { return p; }
+struct EndDetector
+{
+friend bool operator==(EndDetector, C* iter) { return *iter == 0; }
+friend bool operator==(C* iter, EndDetector) { return *iter == 0; }
+friend bool operator!=(EndDetector, C* iter) { return *iter != 0; }
+friend bool operator!=(C* iter, EndDetector) { return *iter != 0; }
+};
+static auto end() { return EndDetector{}; }
};
template struct with_length
@@ -70,8 +76,8 @@ template struct with_length
{
assert(len >= 0);
}
-auto getIter() const { return p; }
-auto getEndDetector() const { return [pEnd = p + len](C* iter) { return
iter == pEnd; }; }
+auto begin() const { return p; }
+auto end() const { return p + len; }
};
template void Copy(C* _pDest, const C* _pSrc, sal_Int32 _nCount)
@@ -166,17 +172,17 @@ sal_Int32 compare(S1 s1, S2 s2, Compare, Shorten_t
shortenedLength)
{
static_assert(std::is_same_v ||
std::is_same_v);
assert(shortenedLength >= 0);
-auto pStr1 = s1.getIter();
-const auto atEnd1 = s1.getEndDetector();
-auto pStr2 = s2.getIter();
-const auto atEnd2 = s2.getEndDetector();
+auto pStr1 = s1.begin();
+const auto end1 = s1.end();
+auto pStr2 = s2.begin();
+const auto end2 = s2.end();
for (;;)
{
if (shortenedLength == 0)
return 0;
-if (atEnd2(pStr2))
-return atEnd1(pStr1) ? 0 : 1;
-if (atEnd1(pStr1))
+if (pStr2 == end2)
+return pStr1 == end1 ? 0 : 1;
+if (pStr1 == end1)
return -1;
if (const sal_Int32 nRet = Compare::compare(*pStr1, *pStr2))
return nRet;
@@ -753,13 +759,13 @@ template T toInt(S str, sal_Int16
nRadix)
if ( (nRadix < RTL_STR_MIN_RADIX) || (nRadix > RTL_STR_MAX_RADIX) )
nRadix = 10;
-auto pStr = str.getIter();
-const auto atEnd = str.getEndDetector();
+auto pStr = str.begin();
+const auto end = str.end();
/* Skip whitespaces */
-while (!atEnd(pStr) && rtl_ImplIsWhitespace(IMPL_RTL_USTRCODE(*pStr)))
+while (pStr != end && rtl_ImplIsWhitespace(IMPL_RTL_USTRCODE(*pStr)))
pStr++;
-if (atEnd(pStr))
+if (pStr == end)
return 0;
const bool bNeg = HandleSignChar(pStr);
@@ -767,7 +773,7 @@ template T toInt(S str, sal_Int16
nRadix)
assert(nDiv > 0);
std::make_unsigned_t n = 0;
-while (!atEnd(pStr))
+while (pStr != end)
{
sal_Int16 nDigit = rtl_ImplGetDigit(IMPL_RTL_USTRCODE(*pStr), nRadix);
if ( nDigit < 0 )
[Libreoffice-bugs] [Bug 116940] FILEOPEN PPT: Incorrect position of shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=116940 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #9 from Gabor Kelemen (allotropia) --- Created attachment 178636 --> https://bugs.documentfoundation.org/attachment.cgi?id=178636=edit The ppt example file in 7.3 Arrows correctly form a circle in bibisect-linux-7.3 since: https://git.libreoffice.org/core/+/90b925307da4066cd18fcbf31b903e948fa55e82 author Regina HenschelSun Dec 12 14:18:23 2021 +0100 committer Xisco Fauli Wed Dec 15 13:34:51 2021 +0100 tdf#145904,tdf#145956 improve extrusion of custom shapes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82688] ODBC to SQLite3, table Design View does not offer Primary Key
https://bugs.documentfoundation.org/show_bug.cgi?id=82688 Alex Thurgood changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7730 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147730] LO Base does not handle compound primary key if one field is empty ("") SQLite3 / ODBC
https://bugs.documentfoundation.org/show_bug.cgi?id=147730 Alex Thurgood changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=82 ||688 --- Comment #11 from Alex Thurgood --- See also the discussion in bug 82688 about ODBC conformance and the actual support provided by Christian Werner's ODBC driver. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - vcl/source
vcl/source/fontsubset/sft.cxx | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
New commits:
commit 8db43afcfc0aaff7059ae57022b53d492f1c806a
Author: Caolán McNamara
AuthorDate: Wed Mar 2 10:13:53 2022 +
Commit: Caolán McNamara
CommitDate: Thu Mar 3 12:28:13 2022 +0100
ofz: detect endless loop in font processing
Change-Id: I4e6c61d8be15a560f43b5d37d646e7bad9739eb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130779
Reviewed-by: Michael Stahl
Tested-by: Jenkins
diff --git a/vcl/source/fontsubset/sft.cxx b/vcl/source/fontsubset/sft.cxx
index 7ebe3cbe8cc3..124b4f249655 100644
--- a/vcl/source/fontsubset/sft.cxx
+++ b/vcl/source/fontsubset/sft.cxx
@@ -541,9 +541,9 @@ static int GetCompoundTTOutline(AbstractTrueTypeFont *ttf,
sal_uInt32 glyphID, C
if( std::find( glyphlist.begin(), glyphlist.end(), index ) !=
glyphlist.end() )
{
-#if OSL_DEBUG_LEVEL > 1
-SAL_INFO("vcl.fonts", "Endless loop found in a compound glyph.");
+SAL_WARN("vcl.fonts", "Endless loop found in a compound glyph.");
+#if OSL_DEBUG_LEVEL > 1
std::ostringstream oss;
oss << index << " -> [";
for( const auto& rGlyph : glyphlist )
@@ -554,6 +554,7 @@ static int GetCompoundTTOutline(AbstractTrueTypeFont *ttf,
sal_uInt32 glyphID, C
SAL_INFO("vcl.fonts", oss.str());
/**/
#endif
+return 0;
}
glyphlist.push_back( index );
@@ -561,10 +562,8 @@ static int GetCompoundTTOutline(AbstractTrueTypeFont *ttf,
sal_uInt32 glyphID, C
if ((np = GetTTGlyphOutline(ttf, index, , nullptr,
)) == 0)
{
/* XXX that probably indicates a corrupted font */
-#if OSL_DEBUG_LEVEL > 1
SAL_WARN("vcl.fonts", "An empty compound!");
/* assert(!"An empty compound"); */
-#endif
}
if( ! glyphlist.empty() )
@@ -1453,6 +1452,12 @@ int GetTTGlyphComponents(AbstractTrueTypeFont *ttf,
sal_uInt32 glyphID, std::vec
if (nptr <= ptr)
return 0;
+if (std::find(glyphlist.begin(), glyphlist.end(), glyphID) !=
glyphlist.end())
+{
+SAL_WARN("vcl.fonts", "Endless loop found in a compound glyph.");
+return 0;
+}
+
glyphlist.push_back( glyphID );
const sal_uInt32 nMaxGlyphSize = glyflength - nOffset;
[Libreoffice-bugs] [Bug 147727] [UI] Change formatting mark colors
https://bugs.documentfoundation.org/show_bug.cgi?id=147727 Heiko Tietze changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #1 from Heiko Tietze --- Is this a duplicate of bug 58434? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 147727] [UI] Change formatting mark colors
https://bugs.documentfoundation.org/show_bug.cgi?id=147727 Heiko Tietze changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #1 from Heiko Tietze --- Is this a duplicate of bug 58434? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 126352] “Create Style” Dialogue Does not Work Correctly if Opened via Menu or Toolbar: (often/always) shows other styles than the 'own styles', sometimes inactive when it
https://bugs.documentfoundation.org/show_bug.cgi?id=126352 Heiko Tietze changed: What|Removed |Added Keywords|bibisectRequest,| |needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org OS|Linux (All) |All Severity|normal |enhancement -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 126352] “Create Style” Dialogue Does not Work Correctly if Opened via Menu or Toolbar: (often/always) shows other styles than the 'own styles', sometimes inactive when it shoul
https://bugs.documentfoundation.org/show_bug.cgi?id=126352 Heiko Tietze changed: What|Removed |Added Keywords|bibisectRequest,| |needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org OS|Linux (All) |All Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 126352] “Create Style” Dialogue Does not Work Correctly if Opened via Menu or Toolbar: (often/always) shows other styles than the 'own styles', sometimes inactive when it
https://bugs.documentfoundation.org/show_bug.cgi?id=126352 --- Comment #14 from Heiko Tietze --- Created attachment 178635 --> https://bugs.documentfoundation.org/attachment.cgi?id=178635=edit Mockup for New Style with Stylefamily The issue here is that "New Style from Selection" started from the Stylist adds PS, CS, or LS depending on the currently visible tab. Started from the main menu it always adds PS. Solutions: a) The ticket duplicates bug 107120 where the decision was to label the main menu accordingly: ”New Paragraph Style from Selection”. b) The same topic however with a request to add UNO commands is done in bug 106782. c) This ticket suggests to solve the problem by adding a target selection to New Style dialog. Remarks: a) Sounds easy to do in contrast to b) b) It multiplies the UNO commands by the style families, not the best for maintenance and customization c) The style family could be preselected according the active Stylist tab. Don't see an issue for UX and rather the advantage of showing what is possible -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 126352] “Create Style” Dialogue Does not Work Correctly if Opened via Menu or Toolbar: (often/always) shows other styles than the 'own styles', sometimes inactive when it shoul
https://bugs.documentfoundation.org/show_bug.cgi?id=126352 --- Comment #14 from Heiko Tietze --- Created attachment 178635 --> https://bugs.documentfoundation.org/attachment.cgi?id=178635=edit Mockup for New Style with Stylefamily The issue here is that "New Style from Selection" started from the Stylist adds PS, CS, or LS depending on the currently visible tab. Started from the main menu it always adds PS. Solutions: a) The ticket duplicates bug 107120 where the decision was to label the main menu accordingly: ”New Paragraph Style from Selection”. b) The same topic however with a request to add UNO commands is done in bug 106782. c) This ticket suggests to solve the problem by adding a target selection to New Style dialog. Remarks: a) Sounds easy to do in contrast to b) b) It multiplies the UNO commands by the style families, not the best for maintenance and customization c) The style family could be preselected according the active Stylist tab. Don't see an issue for UX and rather the advantage of showing what is possible -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Bug 133092 depends on bug 135413, which changed state. Bug 135413 Summary: CRASH: importing document (gen) https://bugs.documentfoundation.org/show_bug.cgi?id=135413 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135413] CRASH: importing document (gen)
https://bugs.documentfoundation.org/show_bug.cgi?id=135413 Gabor Kelemen (allotropia) changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Gabor Kelemen (allotropia) --- I can no longer reproduce the instant crash in bibisect-linux 7.2 after https://git.libreoffice.org/core/+/943c108071c82541c619ea3071fe97634a7a8bab author Caolán McNamara Mon Nov 23 15:26:22 2020 + committer Caolán McNamara Mon Nov 23 20:57:46 2020 +0100 ofz#27519 only generate bitmap preview when needed Still after this a bit of scrolling, clicking, dialog opening, focus changing could crash Writer with the same error on console. This seems to be also solved in 7.2-bibisect master, but would need more bibisecting to find out the exact commit(s). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147741] Access Denied to. Docx and. Xlsx files edited using Libreoffice 7.3 in Windows 10 pro 64 bit client connected to Windows Server 2016
https://bugs.documentfoundation.org/show_bug.cgi?id=147741 Olivier Hallot changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|UNCONFIRMED |RESOLVED --- Comment #1 from Olivier Hallot --- Hi. Thank you for taking time to report. However the best channel for end-user support is not here but https://ask.libreoffice.org/c/english/5 where a much larger user community is available to help you. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147730] LO Base does not handle compound primary key if one field is empty ("") SQLite3 / ODBC
https://bugs.documentfoundation.org/show_bug.cgi?id=147730 Robert Großkopf changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #10 from Robert Großkopf --- I have tested this: Opened the table and switch to last row. Won't get all rows then, only some of the rows which contain an empty string as combined primary key. Opened a query and let me show the primary keys. If the query isn't editable (only one key) it will show all rows (141). If the query is editable, it will need pressing "last row" two times to switch to a wrong rows count (like 135 or something else). Base will set empty fields to NULL, and this seems to be the problem for the GUI. I would never use such a table for input new data, but you could list this data when switching to direct SQL and it works. You could also use direct SQL (or macros) to input new data. It is a bug to show the wrong number of rows, but I don't know how to handle this without throwing away all the features, which will work with NULL for an empty field. I would prefer to open a table write protected, if a primary key contains an empty string. Tested with OpenSUSE 15.3 64bit rpm Linux and LO 7.3.1.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147730] LO Base does not handle compound primary key if one field is empty ("") SQLite3 / ODBC
https://bugs.documentfoundation.org/show_bug.cgi?id=147730 --- Comment #9 from Alex Thurgood --- (In reply to PhilipK from comment #3) Thansk for the information. > The ODBC driver is sqlite3-odbc-0.93, installed from > http://www.ch-werner.de/sqliteodbc/ No version for Arm, so can't test at the moment. Intel iodbc doesn't work on Apple Arm M1 with current LO releases due to an incorrect DYLD path search (bug 138990). FWIW, in my experience, the sqlite ODBC driver for Mac has always been buggy with regard to LO. I also seem to recall that LO requires correct scroll cursor management in order to display the dataset correctly, and I seem to recall that either sqlite, or the ODBC driver implementation for SQLite, only supported the FORWARD_SCROLL_CURSOR, which isn't enough to provide a fully working implementation. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147742] Assert hit when using UnoControlGrid with screen reader
https://bugs.documentfoundation.org/show_bug.cgi?id=147742 Michael Weghorn changed: What|Removed |Added Blocks||101912 Status|UNCONFIRMED |ASSIGNED CC||m.wegh...@posteo.de Ever confirmed|0 |1 --- Comment #1 from Michael Weghorn --- I ran into this while working on something other a11y-related, plan to fix this along the way. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101912 [Bug 101912] [META] Accessibility (a11y) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101912 Michael Weghorn changed: What|Removed |Added Depends on||147742 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147742 [Bug 147742] Assert hit when using UnoControlGrid with screen reader -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147742] New: Assert hit when using UnoControlGrid with screen reader
https://bugs.documentfoundation.org/show_bug.cgi?id=147742 Bug ID: 147742 Summary: Assert hit when using UnoControlGrid with screen reader Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: m.wegh...@posteo.de Created attachment 178634 --> https://bugs.documentfoundation.org/attachment.cgi?id=178634=edit Sample document Steps to reproduce with a debug build of LO master: 0) decrease macro security to e.g. "Medium", so LO asks whether or not to allow macro executation 1) start Orca screen reader on Linux 2) start LO with the gtk3 VCL plugin 3) open attached document "UnoControlGrid.odt" (originally from https://bz.apache.org/ooo/show_bug.cgi?id=125322 ) 4) click on "Run the macro" Result: LO crashes with an assert: soffice.bin: .../libreoffice/vcl/source/app/dbggui.cxx:35: void ImplDbgTestSolarMutex(): Assertion `ImplGetSVData()->mpDefInst->GetYieldMutex()->IsCurrentThread() && "SolarMutex not owned!"' failed. This is on Debian testing with orca 41.2-1 and Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 5b03e07dd21b56e99d6b6b60edec1ed2f388bfc2 CPU threads: 12; OS: Linux 5.16; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147705] CRASH when pressing compose key
https://bugs.documentfoundation.org/show_bug.cgi?id=147705 Julien Nabet changed: What|Removed |Added Whiteboard|target:7.4.0 target:7.3.2 |target:7.4.0 target:7.3.1 |target:7.2.6|target:7.2.6 --- Comment #10 from Julien Nabet --- (In reply to Michael Weghorn from comment #9) > (In reply to Julien Nabet from comment #8) > > > The fix is contained in LibreOffice 7.2.6 as well. > > > ... > > Sorry, had missed it! Let's update targets. > > Thanks! What I did was to run > > git branch -a --contains de72b5f7dd3893ef0d4655cb7943ac0e8ed3c81d > > and that listed 'remotes/origin/libreoffice-7-2-6', so it's in the 7-2-6 > branch. Thank you for the info, I didn't know this! Since git branch -a --contains cc5583d returns remotes/origin/libreoffice-7-3-1, let's update to 7.3.1 for 7.3 branch. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147719] Calc freezes when resizing Properties pane
https://bugs.documentfoundation.org/show_bug.cgi?id=147719 --- Comment #5 from grolsc...@gmail.com --- > > UI render: Skia/Vulkan; VCL: win > Please test also with Tools-Options-View-Skia disabled. Done. Problem remains. Laptop is has a i7-7500u with integrated Intel HD Graphics 620, if that helps. > > Release for Windows S > "Windows 11 in S mode is a version of Windows 11 that's streamlined for > security and performance, while providing a familiar Windows experience. To > increase security, it allows only apps from the Microsoft Store, and > requires Microsoft Edge for safe browsing." > No idea if it's relevant, never used Store, but please try above first. > Ultimate test would be be to download and try LO master 7.4+ (that installs > separately to your current working LO) but that would require to switch out > of S mode temporarily. So I don't recommend. LibreOffice is not detecting my OS correctly. My OS is just plain "Windows 11 Home" (not running in S Mode) as it was an upgrade from Windows 10 Home. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option
https://bugs.documentfoundation.org/show_bug.cgi?id=147718 Alex Thurgood changed: What|Removed |Added Keywords||bibisectRequest, regression --- Comment #13 from Alex Thurgood --- Testing with Version : 6.4.6.1 Build ID : 985dd72ca280d5c6da2e9f90f7ff9286cafe7ff8 Threads CPU : 8; OS : Mac OS X 10.16; UI Render : par défaut; VCL: osx; Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Calc: threaded I can select the textbox control in Form Design mode, and although I can't delete the control with the mouse and backspace key, if I use the context menu, I can choose "Cut" to remove the control from the document. Seems like a regression to me. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147169] Show complete deleted text on mouse-over (like a tooltip) when using track changes (deletions) in margin
https://bugs.documentfoundation.org/show_bug.cgi?id=147169 Heiko Tietze changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3922 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143050] [META] Track Changes of text formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=143050 Heiko Tietze changed: What|Removed |Added Depends on||143922 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143922 [Bug 143922] UI Indicate change tracked formatting changes in readable format -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137770] [META] Tracked changes in margin
https://bugs.documentfoundation.org/show_bug.cgi?id=137770 Heiko Tietze changed: What|Removed |Added Depends on||143922 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143922 [Bug 143922] UI Indicate change tracked formatting changes in readable format -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147612] FILESAVE PDF Checkbox Z-order not respected when saving with Create form off
https://bugs.documentfoundation.org/show_bug.cgi?id=147612 Thorsten Behrens (allotropia) changed: What|Removed |Added Ever confirmed|0 |1 CC||t...@libreoffice.org Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 Heiko Tietze changed: What|Removed |Added Depends on|143922 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143922 [Bug 143922] UI Indicate change tracked formatting changes in readable format -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143922] UI Indicate change tracked formatting changes in readable format
https://bugs.documentfoundation.org/show_bug.cgi?id=143922 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7169 Blocks|83946 |143050, 137770 --- Comment #9 from Heiko Tietze --- So let's do it. Both, the margin but primarily the comment at the sidebar/dialog should tell what exactly has been changed. It works for deletions but only if the "track deletions in margins" option is checked. Unfortunately I cannot change these comments anymore, all input goes into the following non-deletion change. My take here is to add the action information to the comment and keep it editable. An alternative is to show the details in a tooltip. Similar request in bug 147169. This might be the easier and more flexible yet less obvious solution. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83946 [Bug 83946] [META] Tracking changes issues https://bugs.documentfoundation.org/show_bug.cgi?id=137770 [Bug 137770] [META] Tracked changes in margin https://bugs.documentfoundation.org/show_bug.cgi?id=143050 [Bug 143050] [META] Track Changes of text formatting -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143922] UI Indicate change tracked formatting changes in readable format
https://bugs.documentfoundation.org/show_bug.cgi?id=143922 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7169 Blocks|83946 |143050, 137770 --- Comment #9 from Heiko Tietze --- So let's do it. Both, the margin but primarily the comment at the sidebar/dialog should tell what exactly has been changed. It works for deletions but only if the "track deletions in margins" option is checked. Unfortunately I cannot change these comments anymore, all input goes into the following non-deletion change. My take here is to add the action information to the comment and keep it editable. An alternative is to show the details in a tooltip. Similar request in bug 147169. This might be the easier and more flexible yet less obvious solution. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83946 [Bug 83946] [META] Tracking changes issues https://bugs.documentfoundation.org/show_bug.cgi?id=137770 [Bug 137770] [META] Tracked changes in margin https://bugs.documentfoundation.org/show_bug.cgi?id=143050 [Bug 143050] [META] Track Changes of text formatting -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 141747] CROSS-REFERENCE: Give warning, if you delete a target of a cross-reference
https://bugs.documentfoundation.org/show_bug.cgi?id=141747 --- Comment #8 from Christian Lehmann --- (In reply to Heiko Tietze from comment #7) > The topic was on the agenda of the design meeting. Thanks for the info. > >+ the "Internet" recommends to search for "Reference source not found" What does this mean? Such a search is _not_ possible in an ODT file! >+ if reference and source are far away from each other, the information > might not be helpful; you probably have to clean up the broken reference > somewhere else- and jumping around in the document is unwanted Reference and source are typically far away from each other; this is the whole purpose of a reference. If a reference is broken because the user deleted the target, only the user himself is in a position to fix the resulting error; and he _will_ want to fix it, no matter how far away the reference is. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 141747] CROSS-REFERENCE: Give warning, if you delete a target of a cross-reference
https://bugs.documentfoundation.org/show_bug.cgi?id=141747 --- Comment #8 from Christian Lehmann --- (In reply to Heiko Tietze from comment #7) > The topic was on the agenda of the design meeting. Thanks for the info. > >+ the "Internet" recommends to search for "Reference source not found" What does this mean? Such a search is _not_ possible in an ODT file! >+ if reference and source are far away from each other, the information > might not be helpful; you probably have to clean up the broken reference > somewhere else- and jumping around in the document is unwanted Reference and source are typically far away from each other; this is the whole purpose of a reference. If a reference is broken because the user deleted the target, only the user himself is in a position to fix the resulting error; and he _will_ want to fix it, no matter how far away the reference is. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option
https://bugs.documentfoundation.org/show_bug.cgi?id=147718 --- Comment #12 from Alex Thurgood --- Attempting to load the ODT in Collabora Productivity Version: 21.06.15.1 Build ID: 60a66e4bf6afbf5d4221dab436bb1aca744a7ddf CPU threads: 8; OS: Mac OS X 12.2.1; UI render: default; VCL: osx Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Calc: threaded leads to same cycle of crash, and obligatory restart (despite the error message saying the office process will be automatically restarted, Collabora Office fails to restart, and needs to be restarted manually). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option
https://bugs.documentfoundation.org/show_bug.cgi?id=147718 Alex Thurgood changed: What|Removed |Added OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option
https://bugs.documentfoundation.org/show_bug.cgi?id=147718 --- Comment #11 from Alex Thurgood --- Attempting to open the ODT file in Version: 7.1.8.1 / LibreOffice Community Build ID: e1f30c802c3269a1d052614453f260e49458c82c CPU threads: 8; OS: Mac OS X 10.16; UI render: default; VCL: osx Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Calc: threaded leads to an instant and repeatable cycle of crash / empty recovery dialog. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147705] CRASH when pressing compose key
https://bugs.documentfoundation.org/show_bug.cgi?id=147705 --- Comment #9 from Michael Weghorn --- (In reply to Julien Nabet from comment #8) > > The fix is contained in LibreOffice 7.2.6 as well. > > ... > Sorry, had missed it! Let's update targets. Thanks! What I did was to run git branch -a --contains de72b5f7dd3893ef0d4655cb7943ac0e8ed3c81d and that listed 'remotes/origin/libreoffice-7-2-6', so it's in the 7-2-6 branch. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option
https://bugs.documentfoundation.org/show_bug.cgi?id=147718 --- Comment #10 from Alex Thurgood --- Note that, using a workaround, the textbox control can be deleted via the Form Navigator : Bring up the Form Navigator. Right-mouse button click on TextBox 1 entry in the tree and choose Delete. Also note that no new controls can be added via Form Design toolbar. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141747] CROSS-REFERENCE: Give warning, if you delete a target of a cross-reference
https://bugs.documentfoundation.org/show_bug.cgi?id=141747 Heiko Tietze changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #7 from Heiko Tietze --- The topic was on the agenda of the design meeting. + the "Internet" recommends to search for "Reference source not found" + update is not reliable though + the only acceptable workflow is to immediately show an infobar or any other non-interrupting message and to hide it once the reference is back (eg. after cut/paste) + continuously checking the status might be a performance issue + if reference and source are far away from each other, the information might not be helpful; you probably have to clean up the broken reference somewhere else- and jumping around in the document is unwanted + heavy editing potentially produces a large number of warnings + problem when user not hides the info, or when it comes up too often + double-check whether competitors do show such a warning The decision was to check how competitors deal with the problem. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 141747] CROSS-REFERENCE: Give warning, if you delete a target of a cross-reference
https://bugs.documentfoundation.org/show_bug.cgi?id=141747 Heiko Tietze changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #7 from Heiko Tietze --- The topic was on the agenda of the design meeting. + the "Internet" recommends to search for "Reference source not found" + update is not reliable though + the only acceptable workflow is to immediately show an infobar or any other non-interrupting message and to hide it once the reference is back (eg. after cut/paste) + continuously checking the status might be a performance issue + if reference and source are far away from each other, the information might not be helpful; you probably have to clean up the broken reference somewhere else- and jumping around in the document is unwanted + heavy editing potentially produces a large number of warnings + problem when user not hides the info, or when it comes up too often + double-check whether competitors do show such a warning The decision was to check how competitors deal with the problem. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 147730] LO Base does not handle compound primary key if one field is empty ("") SQLite3 / ODBC
https://bugs.documentfoundation.org/show_bug.cgi?id=147730 --- Comment #8 from PhilipK --- If opened in SQLite Studio, the table shows clearly where there are nulls and where there are blanks. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option
https://bugs.documentfoundation.org/show_bug.cgi?id=147718 Alex Thurgood changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147730] LO Base does not handle compound primary key if one field is empty ("") SQLite3 / ODBC
https://bugs.documentfoundation.org/show_bug.cgi?id=147730 --- Comment #7 from PhilipK --- Created attachment 178633 --> https://bugs.documentfoundation.org/attachment.cgi?id=178633=edit LO front-end (one form) to link to db -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option
https://bugs.documentfoundation.org/show_bug.cgi?id=147718 --- Comment #9 from Alex Thurgood --- When testing with Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: beb6c62e990599d91ac5d9183164c94d269027d3 CPU threads: 8; OS: Mac OS X 10.16; UI render: Skia/Metal; VCL: osx Locale: fr-FR (fr_FR.UTF-8); UI: en-US Calc: threaded there is no hang, and I can enter the text box field and enter some text. However, as reported by the OP, if I enter Form Design mode, and select the field control and try to delete it, I get the error message indicated by the OP. In the Properties dialog of the Writer file when loaded in LO, the security options are not set for the option "Open file read only". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141858] [META] Cross-references dialog issues
https://bugs.documentfoundation.org/show_bug.cgi?id=141858 Bug 141858 depends on bug 146905, which changed state. Bug 146905 Summary: Allow cross-references to bookmarks to show the line number https://bugs.documentfoundation.org/show_bug.cgi?id=146905 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 146905] Allow cross-references to bookmarks to show the line number
https://bugs.documentfoundation.org/show_bug.cgi?id=146905 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WONTFIX --- Comment #6 from Heiko Tietze --- The topic was on the agenda of the design meeting. + unclear use case, references to numbered paragraphs seems enough + never heard about references to line numbers in other office programs + but the request is to _show_ the line number + use case is apparently to link to a particular line + lines are not numbered (the annotation is some kind of decoration) and referencing is tricky; unclear whether line within a current page or the whole document + still, the recommended workflow is to use numbered paragraphs (and keep those short) + (auto) bookmarks per macro might help The recommendation is to not implement line numbers as target. Keep in mind that we have to follow (and steer) the open document format and if such a feature would be implemented it needs to be done in all applications using the format and other formats too. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 146905] Allow cross-references to bookmarks to show the line number
https://bugs.documentfoundation.org/show_bug.cgi?id=146905 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WONTFIX --- Comment #6 from Heiko Tietze --- The topic was on the agenda of the design meeting. + unclear use case, references to numbered paragraphs seems enough + never heard about references to line numbers in other office programs + but the request is to _show_ the line number + use case is apparently to link to a particular line + lines are not numbered (the annotation is some kind of decoration) and referencing is tricky; unclear whether line within a current page or the whole document + still, the recommended workflow is to use numbered paragraphs (and keep those short) + (auto) bookmarks per macro might help The recommendation is to not implement line numbers as target. Keep in mind that we have to follow (and steer) the open document format and if such a feature would be implemented it needs to be done in all applications using the format and other formats too. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147730] LO Base does not handle compound primary key if one field is empty ("") SQLite3 / ODBC
https://bugs.documentfoundation.org/show_bug.cgi?id=147730 --- Comment #6 from PhilipK --- Created attachment 178632 --> https://bugs.documentfoundation.org/attachment.cgi?id=178632=edit SQLite3 database (one table) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147705] CRASH when pressing compose key
https://bugs.documentfoundation.org/show_bug.cgi?id=147705 Julien Nabet changed: What|Removed |Added Whiteboard|target:7.4.0 target:7.3.2 |target:7.4.0 target:7.3.2 |target:7.2.7|target:7.2.6 --- Comment #8 from Julien Nabet --- (In reply to Michael Weghorn from comment #5) > ... > > The fix is contained in LibreOffice 7.2.6 as well. > ... Sorry, had missed it! Let's update targets. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108600] Paragraph format: Inconsistent display in space between paragraphs for area fill
https://bugs.documentfoundation.org/show_bug.cgi?id=108600 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org --- Comment #13 from Heiko Tietze --- The topic was on the agenda of the design meeting. Issue + margin is per definition always transparent + if attributes of one paragraph continue on the next the margin will be filled Solution a) add a property similar to the new "BackgroundFullSize" (c6) b) use the border instead of spacing to continue attributes (works out of the box) Tweaking the clear definition of being transparent is never a good solution whether by comparing the attributes nor using a some option. If we go with b) and there are concerns about the layout of existing documents we could add a compatibility or expert option. While I doubt that many used this exploit intentionally it could have been a way to color the page background, so potentially used often. In this case we could keep the current behavior for past documents and use the correct transparency for new documents only. If we keep the current behavior it requires documentation (easy workaround is to have slightly different colors). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 108600] Paragraph format: Inconsistent display in space between paragraphs for area fill
https://bugs.documentfoundation.org/show_bug.cgi?id=108600 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org --- Comment #13 from Heiko Tietze --- The topic was on the agenda of the design meeting. Issue + margin is per definition always transparent + if attributes of one paragraph continue on the next the margin will be filled Solution a) add a property similar to the new "BackgroundFullSize" (c6) b) use the border instead of spacing to continue attributes (works out of the box) Tweaking the clear definition of being transparent is never a good solution whether by comparing the attributes nor using a some option. If we go with b) and there are concerns about the layout of existing documents we could add a compatibility or expert option. While I doubt that many used this exploit intentionally it could have been a way to color the page background, so potentially used often. In this case we could keep the current behavior for past documents and use the correct transparency for new documents only. If we keep the current behavior it requires documentation (easy workaround is to have slightly different colors). -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Michael Weghorn changed: What|Removed |Added Depends on||147705 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147705 [Bug 147705] CRASH when pressing compose key -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147705] CRASH when pressing compose key
https://bugs.documentfoundation.org/show_bug.cgi?id=147705 Michael Weghorn changed: What|Removed |Added Blocks||102495 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102495 [Bug 102495] [META] KDE VCL backend bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147719] Calc freezes when resizing Properties pane
https://bugs.documentfoundation.org/show_bug.cgi?id=147719 --- Comment #4 from Timur --- (In reply to grolschie from comment #3) > Version: 7.2.5.2 (x86) / LibreOffice Community I don't repro with 7.2.0 with Win7 so not general bug, maybe Win11 or local graphic or that build. > OS: Windows 10.0 Build 22000; Known bug, Windows 11 shows as 10 but Build is relevant. > UI render: Skia/Vulkan; VCL: win Please test also with Tools-Options-View-Skia disabled. > Release for Windows S "Windows 11 in S mode is a version of Windows 11 that's streamlined for security and performance, while providing a familiar Windows experience. To increase security, it allows only apps from the Microsoft Store, and requires Microsoft Edge for safe browsing." No idea if it's relevant, never used Store, but please try above first. Ultimate test would be be to download and try LO master 7.4+ (that installs separately to your current working LO) but that would require to switch out of S mode temporarily. So I don't recommend. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option
https://bugs.documentfoundation.org/show_bug.cgi?id=147718 --- Comment #8 from Alex Thurgood --- The hang occurs as soon as I click on the field to try and select it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option
https://bugs.documentfoundation.org/show_bug.cgi?id=147718 --- Comment #7 from Alex Thurgood --- Created attachment 178631 --> https://bugs.documentfoundation.org/attachment.cgi?id=178631=edit Apple Crash Trace when loading ODT file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option
https://bugs.documentfoundation.org/show_bug.cgi?id=147718 --- Comment #6 from Alex Thurgood --- Attempting to load the ODT uploaded by the original poster causes Version: 7.2.5.2 / LibreOffice Community Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5 CPU threads: 8; OS: Mac OS X 12.2.1; UI render: default; VCL: osx Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Calc: threaded to hang (spinning beachball), requiring forced kill, on macOS Macbook Pro M1 I've attached the trace provided by the Apple Crash Reporter. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147705] CRASH when pressing compose key
https://bugs.documentfoundation.org/show_bug.cgi?id=147705 Julien Nabet changed: What|Removed |Added Whiteboard|target:7.4.0|target:7.4.0 target:7.3.2 ||target:7.2.7 --- Comment #7 from Julien Nabet --- It's also on 7.3 branch (see https://gerrit.libreoffice.org/c/core/+/129547) and 7.2 branch (see https://gerrit.libreoffice.org/c/core/+/129539). I suppose for future 7.3.2 and 7.2.7 (since it's too late for 7.2.6 https://wiki.documentfoundation.org/ReleasePlan/7.2) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147705] CRASH when pressing compose key
https://bugs.documentfoundation.org/show_bug.cgi?id=147705 Julien Nabet changed: What|Removed |Added Whiteboard||target:7.4.0 --- Comment #6 from Julien Nabet --- Thank you Michael for the detailed feedback! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147705] CRASH when pressing compose key
https://bugs.documentfoundation.org/show_bug.cgi?id=147705 Michael Weghorn changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #5 from Michael Weghorn --- This has already been fixed in commit 05b067f05c561b1993deeea84a5700805bc9c3a6 Author: Caolán McNamara Date: Sat Feb 5 20:38:53 2022 + qt5: crash entering ë with french IM which for me with french IM enabled on my keyboard is physically AltGr+[ (crashes here on trying to underline ¨ with a length of 2) then e. Change-Id: Id59bd84af2ab4d8403b11b1a13efb2bbdb608199 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129538 Tested-by: Jenkins Reviewed-by: Caolán McNamara I just double-checked that I can reproduce the crash when I revert the above commit locally. The fix is contained in LibreOffice 7.2.6 as well. I don't know much about how to use that compose key feature, but at least pressing Compose key and then "e" twice results in a character that looks like "e on its head", which is the same as happens with gtk3, so that looks plausible. Please open a separate bug report with a more detailed description if specific compose key features are not working as expected. attachment 178629 shows where the compose key can be configure in systemsettings. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139899] [META] PPTX Table issues
https://bugs.documentfoundation.org/show_bug.cgi?id=139899 Bug 139899 depends on bug 135552, which changed state. Bug 135552 Summary: Filesave PPTX: Merged cells in Impress don't have lower border line when reopen in LO, OK in MSO https://bugs.documentfoundation.org/show_bug.cgi?id=135552 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135552] Filesave PPTX: Merged cells in Impress don't have lower border line when reopen in LO, OK in MSO
https://bugs.documentfoundation.org/show_bug.cgi?id=135552 Gabor Kelemen (allotropia) changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #20 from Gabor Kelemen (allotropia) --- Thanks Gülşah for fixing this! *** This bug has been marked as a duplicate of bug 135843 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107701] [META] Table border bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107701 Bug 107701 depends on bug 135552, which changed state. Bug 135552 Summary: Filesave PPTX: Merged cells in Impress don't have lower border line when reopen in LO, OK in MSO https://bugs.documentfoundation.org/show_bug.cgi?id=135552 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135552] Filesave PPTX: Merged cells in Impress don't have lower border line when reopen in LO, OK in MSO
https://bugs.documentfoundation.org/show_bug.cgi?id=135552 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #19 from Gabor Kelemen (allotropia) --- Created attachment 178630 --> https://bugs.documentfoundation.org/attachment.cgi?id=178630=edit The example file and its pptx version in 7.3 The pptx export of attachment 166402 appears with correct borders around merged cells since: https://git.libreoffice.org/core/+/35b179b88330e1e94980192c598f23661e2757f9 commit 35b179b88330e1e94980192c598f23661e2757f9[log] author Gülşah Köse Wed Jan 05 13:03:14 2022 +0300 committer Xisco Fauli Tue Jan 11 09:56:07 2022 +0100 tdf#135843 Fix the missing border handling -- You are receiving this mail because: You are the assignee for the bug.
Minutes from the UX/design meeting 2022-Mar-02
Present: Hossein, Bogdan, Ruediger, Heiko Comments: Regina, Mike, Cor, Stuart, Harald, Seth Tickets/Topics * Paragraph format: Inconsistent display in space between paragraphs for area fill + https://bugs.documentfoundation.org/show_bug.cgi?id=108600 + margin is (per definition) _always_ transparent (Regina) + if the attributes of one paragraph continue on the next the margin will be filled + perhaps add a property similar to the new "BackgroundFullSize" (Mike) + changing the behavior could break the layout for existing documents + to continue attributes the border can be used instead of spacing (Heiko) => recommend to streamline and always use transparent (perhaps with an expert or compatibility option for legacy documents) * Allow cross-references to bookmarks to show the line number + https://bugs.documentfoundation.org/show_bug.cgi?id=146905 + unclear use case, references to numbered paragraphs seems enough + never heard about references to line numbers in other office programs (Hossein) + the request is to _show_ the line number (Ruediger) + use case is apparently to have a link to a particular line + or technical documents like source code where a particular line is to be referenced (Bogdan) + but source code would be numbered code lines, which is paragraphs (Heiko) + lines are not numbered (the annotation is some decoration) and referencing is difficult; unclear whether line within a page or the document + still, the recommended workflow is to use numbered paragraphs (and keep those short) (Heiko) + (auto) bookmarks per macro might help (Hossein) => WF * CROSS-REFERENCE: Give warning, if you delete a target of a cross-reference + https://bugs.documentfoundation.org/show_bug.cgi?id=141747 + Internet recommends to search for "Reference source not found" + update not reliable though + only acceptable workflow is to immediately show an infobar (or and other non-interrupting) message and hide it once the reference is back (eg. after cut/paste) + this might be a performance issue + if reference and source are far away from each other the information might not be helpful; you pbl. have to clean up the broken reference somewhere else- and jumping around in the document is unwanted (Ruediger) + heavy editing potentially produces a large number of warnings + problem when user not hides the info, or when it comes up too often + double-check whether competitors do show such a warning (Hossein, Bogdan) => decide later * Search and Replace + Regression tdf#117173 caused with this commit DIALOG: Improvements to the Find & Replace dialog. https://git.libreoffice.org/core/commit/beeef9 + The good: It has provided improvements to the "Find and Replace" dialog. + The bad: It created a regression in accessibility + Number of found/replaced items no longer announced by screen reader: NVDA, etc + https://bugs.documentfoundation.org/show_bug.cgi?id=117173 + Possible solutions: 1) Exposing this text to the screen readers 2) Going back to the popup + Popup is useful for announcing important information + It is understood by the screen readers + It is used in MS Word, from Office 97 to Office 2019 + Gerrit submission: tdf#117173 Add popup for # of items found/replaced https://gerrit.libreoffice.org/c/core/+/129649 => discussed, go ahead! * UI Indicate change tracked formatting changes in readable format + https://bugs.documentfoundation.org/show_bug.cgi?id=143922 + what additional info needs to be shown + in case of formatting changes the actual attributes should be shown in the comment likewise done for deletions => do it * “Create Style” Dialogue Does not Work Correctly if Opened via Menu or Toolbar: (often/always) shows other styles than the 'own styles', sometimes inactive when it shouldn't .. + https://bugs.documentfoundation.org/show_bug.cgi?id=126352 + function started from sidebar/stylist creates PS, CS or LS depending on what tab is open and if the selection is a list; + the dialog lists user-defined PS/LS + running from the main menu creates always PS + has been improved by renaming to "New Style From Selection" (Cor) + odd behavior in some workflows (Stuart) + allow users to chose the stylefamily (Harald) + same problem, working only on PS, for new/update/edit, see bug 107120 (Seth) => no further input, just summarize OpenPGP_signature Description: OpenPGP digital signature
[Libreoffice-qa] Minutes from the UX/design meeting 2022-Mar-02
Present: Hossein, Bogdan, Ruediger, Heiko Comments: Regina, Mike, Cor, Stuart, Harald, Seth Tickets/Topics * Paragraph format: Inconsistent display in space between paragraphs for area fill + https://bugs.documentfoundation.org/show_bug.cgi?id=108600 + margin is (per definition) _always_ transparent (Regina) + if the attributes of one paragraph continue on the next the margin will be filled + perhaps add a property similar to the new "BackgroundFullSize" (Mike) + changing the behavior could break the layout for existing documents + to continue attributes the border can be used instead of spacing (Heiko) => recommend to streamline and always use transparent (perhaps with an expert or compatibility option for legacy documents) * Allow cross-references to bookmarks to show the line number + https://bugs.documentfoundation.org/show_bug.cgi?id=146905 + unclear use case, references to numbered paragraphs seems enough + never heard about references to line numbers in other office programs (Hossein) + the request is to _show_ the line number (Ruediger) + use case is apparently to have a link to a particular line + or technical documents like source code where a particular line is to be referenced (Bogdan) + but source code would be numbered code lines, which is paragraphs (Heiko) + lines are not numbered (the annotation is some decoration) and referencing is difficult; unclear whether line within a page or the document + still, the recommended workflow is to use numbered paragraphs (and keep those short) (Heiko) + (auto) bookmarks per macro might help (Hossein) => WF * CROSS-REFERENCE: Give warning, if you delete a target of a cross-reference + https://bugs.documentfoundation.org/show_bug.cgi?id=141747 + Internet recommends to search for "Reference source not found" + update not reliable though + only acceptable workflow is to immediately show an infobar (or and other non-interrupting) message and hide it once the reference is back (eg. after cut/paste) + this might be a performance issue + if reference and source are far away from each other the information might not be helpful; you pbl. have to clean up the broken reference somewhere else- and jumping around in the document is unwanted (Ruediger) + heavy editing potentially produces a large number of warnings + problem when user not hides the info, or when it comes up too often + double-check whether competitors do show such a warning (Hossein, Bogdan) => decide later * Search and Replace + Regression tdf#117173 caused with this commit DIALOG: Improvements to the Find & Replace dialog. https://git.libreoffice.org/core/commit/beeef9 + The good: It has provided improvements to the "Find and Replace" dialog. + The bad: It created a regression in accessibility + Number of found/replaced items no longer announced by screen reader: NVDA, etc + https://bugs.documentfoundation.org/show_bug.cgi?id=117173 + Possible solutions: 1) Exposing this text to the screen readers 2) Going back to the popup + Popup is useful for announcing important information + It is understood by the screen readers + It is used in MS Word, from Office 97 to Office 2019 + Gerrit submission: tdf#117173 Add popup for # of items found/replaced https://gerrit.libreoffice.org/c/core/+/129649 => discussed, go ahead! * UI Indicate change tracked formatting changes in readable format + https://bugs.documentfoundation.org/show_bug.cgi?id=143922 + what additional info needs to be shown + in case of formatting changes the actual attributes should be shown in the comment likewise done for deletions => do it * “Create Style” Dialogue Does not Work Correctly if Opened via Menu or Toolbar: (often/always) shows other styles than the 'own styles', sometimes inactive when it shouldn't .. + https://bugs.documentfoundation.org/show_bug.cgi?id=126352 + function started from sidebar/stylist creates PS, CS or LS depending on what tab is open and if the selection is a list; + the dialog lists user-defined PS/LS + running from the main menu creates always PS + has been improved by renaming to "New Style From Selection" (Cor) + odd behavior in some workflows (Stuart) + allow users to chose the stylefamily (Harald) + same problem, working only on PS, for new/update/edit, see bug 107120 (Seth) => no further input, just summarize OpenPGP_signature Description: OpenPGP digital signature
[Libreoffice-bugs] [Bug 147705] CRASH when pressing compose key
https://bugs.documentfoundation.org/show_bug.cgi?id=147705 --- Comment #4 from Michael Weghorn --- Created attachment 178629 --> https://bugs.documentfoundation.org/attachment.cgi?id=178629=edit Screenshot where compose key can be configured in Plasma systemsettings -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: soltools/mkdepend
soltools/mkdepend/pr.c |1 +
1 file changed, 1 insertion(+)
New commits:
commit 896c097f1fa4bc9d2e5ea87a696c125bb335ecac
Author: Caolán McNamara
AuthorDate: Wed Mar 2 21:24:27 2022 +
Commit: Caolán McNamara
CommitDate: Thu Mar 3 10:15:26 2022 +0100
cid#1500573 silence Untrusted loop bound
Change-Id: Ic932ba264e6e593ac8e5432fa9afd440ff1aa2d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130898
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/soltools/mkdepend/pr.c b/soltools/mkdepend/pr.c
index 2b0825221df6..7911502ed813 100644
--- a/soltools/mkdepend/pr.c
+++ b/soltools/mkdepend/pr.c
@@ -67,6 +67,7 @@ void add_include(struct filepointer *filep, struct inclist
*file, struct inclist
if (!newfile->i_searched) {
newfile->i_searched = TRUE;
content = getfile(newfile->i_file);
+// coverity[tainted_data] - this is a build time tool
find_includes(content, newfile, file_red, 0, failOK, incCollection,
symbols);
freefile(content);
}
[Libreoffice-bugs] [Bug 144585] button popups don't open with KF5 VCL on Wayland
https://bugs.documentfoundation.org/show_bug.cgi?id=144585 --- Comment #18 from giors...@yahoo.it --- Same on Version: 7.3.0.3 / LibreOffice Community Build ID: 30(Build:3) CPU threads: 4; OS: Linux 5.16; UI render: default; VCL: kf5 (cairo+wayland) Locale: es-ES (es_ES.UTF-8); UI: es-ES 7.3.0-7 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115753] FILEOPEN: PPT: Some borders are missing on tables
https://bugs.documentfoundation.org/show_bug.cgi?id=115753 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||gulsah.k...@collabora.com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #14 from Gabor Kelemen (allotropia) --- Thanks Gülşah for fixing this! *** This bug has been marked as a duplicate of bug 135843 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115753] FILEOPEN: PPT: Some borders are missing on tables
https://bugs.documentfoundation.org/show_bug.cgi?id=115753 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #13 from Gabor Kelemen (allotropia) --- Created attachment 178628 --> https://bugs.documentfoundation.org/attachment.cgi?id=178628=edit The first example file in 7.3 bibisect master The borders appear correctly in 7.3 since: https://git.libreoffice.org/core/+/35b179b88330e1e94980192c598f23661e2757f9 commit 35b179b88330e1e94980192c598f23661e2757f9[log] author Gülşah Köse Wed Jan 05 13:03:14 2022 +0300 committer Xisco Fauli Tue Jan 11 09:56:07 2022 +0100 tdf#135843 Fix the missing border handling Also works correctly with the second example file. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svgio/inc svgio/qa svgio/source svl/IwyuFilter_svl.yaml svl/source svtools/inc svtools/IwyuFilter_svtools.yaml svtools/source svx/inc svx/IwyuFilter_svx.yaml svx/qa svx
svgio/inc/svganode.hxx |1 svgio/inc/svgcirclenode.hxx |1 svgio/inc/svgclippathnode.hxx |1 svgio/inc/svgellipsenode.hxx|1 svgio/inc/svggnode.hxx |1 svgio/inc/svggradientnode.hxx |2 - svgio/inc/svgimagenode.hxx |1 svgio/inc/svglinenode.hxx |1 svgio/inc/svgmasknode.hxx |1 svgio/inc/svgnode.hxx |2 - svgio/inc/svgrectnode.hxx |1 svgio/inc/svgstyleattributes.hxx|1 svgio/inc/svgtextnode.hxx |1 svgio/inc/svgusenode.hxx|1 svgio/qa/cppunit/SvgImportTest.cxx |1 svgio/source/svgreader/SvgNumber.cxx|2 - svgio/source/svgreader/svgtools.cxx |1 svgio/source/svguno/xsvgparser.cxx |1 svl/IwyuFilter_svl.yaml |2 + svl/source/config/cjkoptions.cxx|3 -- svl/source/config/itemholder2.cxx |1 svl/source/config/languageoptions.cxx |5 svl/source/crypto/cryptosign.cxx|1 svl/source/fsstor/oinputstreamcontainer.hxx |1 svl/source/fsstor/ostreamcontainer.hxx |1 svl/source/inc/items_helper.hxx |4 --- svl/source/items/itempool.cxx |1 svl/source/items/sitem.cxx |3 -- svl/source/misc/gridprinter.cxx |6 ++-- svl/source/misc/sharedstringpool.cxx|2 - svl/source/numbers/currencytable.cxx|1 svl/source/numbers/supservs.hxx |2 - svtools/IwyuFilter_svtools.yaml |3 ++ svtools/inc/borderline.hrc |1 svtools/inc/langtab.hrc |1 svtools/inc/strings.hxx |2 + svtools/inc/table/defaultinputhandler.hxx |1 svtools/source/brwbox/editbrowsebox2.cxx|1 svtools/source/config/fontsubstconfig.cxx |2 - svtools/source/config/htmlcfg.cxx |3 -- svtools/source/config/itemholder2.cxx |1 svtools/source/config/optionsdrawinglayer.cxx |1 svtools/source/config/printoptions.cxx |3 -- svtools/source/control/asynclink.cxx|3 -- svtools/source/control/ctrltool.cxx |1 svtools/source/control/inettbc.cxx |1 svtools/source/control/toolbarmenu.cxx |1 svtools/source/control/valueimp.hxx |1 svtools/source/control/valueset.cxx |1 svtools/source/dialogs/ServerDetailsControls.hxx|1 svtools/source/filter/DocumentToGraphicRenderer.cxx |1 svtools/source/misc/acceleratorexecute.cxx |1 svtools/source/svhtml/htmlout.cxx |1 svtools/source/svrtf/svparser.cxx |1 svtools/source/table/cellvalueconversion.cxx|1 svtools/source/table/cellvalueconversion.hxx|2 - svx/IwyuFilter_svx.yaml |9 +++ svx/inc/fieldunit.hrc |1 svx/inc/fmstring.hrc|2 + svx/inc/formnavi.hrc|2 + svx/inc/frmsel.hrc |1 svx/inc/numberingtype.hrc |2 + svx/inc/rotationstrings.hrc |2 + svx/inc/samecontent.hrc |2 + svx/inc/sdr/primitive2d/primitivefactory2d.hxx |7 - svx/inc/spacing.hrc |2 + svx/inc/swframeposstrings.hrc |2 + svx/inc/tabwin.hrc |2 + svx/inc/tbxcolorupdate.hxx |1 svx/inc/textchaincursor.hxx |2 + svx/inc/txenctab.hrc|1 svx/qa/unit/customshapes.cxx
[Libreoffice-bugs] [Bug 147233] Treat table formulas like fields
https://bugs.documentfoundation.org/show_bug.cgi?id=147233 Heiko Tietze changed: What|Removed |Added Summary|EDITING: Prevent editing of |Treat table formulas like |calculated text displays|fields Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Severity|normal |enhancement Keywords|needsUXEval |needsDevAdvice --- Comment #11 from Heiko Tietze --- It is possible to insert a formula in plain text, for example F2 > =1+1. The result is a field with the type "inserted formula" and editing is possible only via the fields dialog. I suggest to do the same for table formulas, as requested in this ticket. That means F2 goes into the formula edit mode as today but the calculated result would be a field (with proper shading). Double click on the field probably requires to go into the formula edit mode as the fields dialog has no knowledge of table cells. Consequently we cannot use the field dialog to define the the number format but have to keep it per table cell. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 147233] Treat table formulas like fields
https://bugs.documentfoundation.org/show_bug.cgi?id=147233 Heiko Tietze changed: What|Removed |Added Summary|EDITING: Prevent editing of |Treat table formulas like |calculated text displays|fields Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Severity|normal |enhancement Keywords|needsUXEval |needsDevAdvice --- Comment #11 from Heiko Tietze --- It is possible to insert a formula in plain text, for example F2 > =1+1. The result is a field with the type "inserted formula" and editing is possible only via the fields dialog. I suggest to do the same for table formulas, as requested in this ticket. That means F2 goes into the formula edit mode as today but the calculated result would be a field (with proper shading). Double click on the field probably requires to go into the formula edit mode as the fields dialog has no knowledge of table cells. Consequently we cannot use the field dialog to define the the number format but have to keep it per table cell. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 112440] Change of language module in Writing aids isn't remembered
https://bugs.documentfoundation.org/show_bug.cgi?id=112440 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7268 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113944] [META] Options dialog's Writer settings bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113944 Dieter changed: What|Removed |Added Depends on||147268 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147268 [Bug 147268] Some selected preferences are not remembered when installing a new version -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147268] Some selected preferences are not remembered when installing a new version
https://bugs.documentfoundation.org/show_bug.cgi?id=147268 Dieter changed: What|Removed |Added Blocks||113944, 112139 Whiteboard| QA:needsComment| See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||2440 CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- I've updated LO from 7.3.1.2 to 7.3.1.3 I can confirm it for the following seettings: English Sentence Checking (see also 112440) Keyboad Handling Options => NEW I can't confirm it for the following setting: Grid Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112139 [Bug 112139] [META] Options dialog's Language settings bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=113944 [Bug 113944] [META] Options dialog's Writer settings bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112139] [META] Options dialog's Language settings bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112139 Dieter changed: What|Removed |Added Depends on||147268 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147268 [Bug 147268] Some selected preferences are not remembered when installing a new version -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147436] Certain changes remain in track & changes record even after undo of every change
https://bugs.documentfoundation.org/show_bug.cgi?id=147436 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| --- Comment #4 from Dieter --- I can't confirm it with Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: c856f9bec12d98ed49f01578ded79f16ae7be051 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Additional information There is one trecked change in the attached document. i accepted it, before following steps from screencast in comment 3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147730] LO Base does not handle compound primary key if one field is empty ("") SQLite3 / ODBC
https://bugs.documentfoundation.org/show_bug.cgi?id=147730 Robert Großkopf changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #5 from Robert Großkopf --- I have tried to get such a table in LO GUI. It is impossible to set a field as an empty string. It will be set to NULL. So I created it through Tools → SQL. I could see all rows in table view. The counting of the rows is right here with LO 7.3.1.2 on OpenSUSE 15.3 and the ODBC driver, which is packed for this Linux version. Could you offer an example database for this? -- You are receiving this mail because: You are the assignee for the bug.
