[Libreoffice-ux-advise] [Bug 148394] We need search capability restricted to the Navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148394

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Heiko Tietze  ---


*** This bug has been marked as a duplicate of bug 43511 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 148381] closing the print preview page - with the X, too :)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148381

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #4 from Heiko Tietze  ---
(In reply to sdc.blanco from comment #3)
> ... might be friendly to have Calc appear the same as Writer.

No objection. 

Writer uses in sw/uiconfig/swriter/toolbar/previewobjectbar.xml



And Calc in sc/uiconfig/scalc/toolbar/previewbar.xml



so adding the style might do the trick.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148381] closing the print preview page - with the X, too :)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148381

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #4 from Heiko Tietze  ---
(In reply to sdc.blanco from comment #3)
> ... might be friendly to have Calc appear the same as Writer.

No objection. 

Writer uses in sw/uiconfig/swriter/toolbar/previewobjectbar.xml



And Calc in sc/uiconfig/scalc/toolbar/previewbar.xml



so adding the style might do the trick.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109299] Empty cells are not copied to external application like Notepad (while copied to another spreadsheet)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109299

--- Comment #18 from Larsen  ---
Still a problem in 7.3.2.2 (x64)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 141456] Separate outline browsing and heading browsing in Navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141456

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #9 from Heiko Tietze  ---
(In reply to Mike Kaganski from comment #7)
> what is the intended *use case* for what you propose; what *real-life problem*
> should if solve. For now, what you suggest only tries to solve some
> (possible) terminological confusion, and tries to do that in such a way to
> introduce much greater confusion. 

+1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 141456] Separate outline browsing and heading browsing in Navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141456

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #9 from Heiko Tietze  ---
(In reply to Mike Kaganski from comment #7)
> what is the intended *use case* for what you propose; what *real-life problem*
> should if solve. For now, what you suggest only tries to solve some
> (possible) terminological confusion, and tries to do that in such a way to
> introduce much greater confusion. 

+1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/inc sc/source

[Dennis Francis (via logerrit)]

 sc/inc/scmod.hxx   |2 +-
 sc/source/ui/app/inputhdl.cxx  |   12 +++-
 sc/source/ui/app/scmod.cxx |4 ++--
 sc/source/ui/inc/inputhdl.hxx  |2 +-
 sc/source/ui/view/tabvwsha.cxx |   11 +--
 5 files changed, 24 insertions(+), 7 deletions(-)

New commits:
commit e0175ee821eaff56c4b8e0a1b7afa1cabe0ab593
Author: Dennis Francis 
AuthorDate: Fri Apr 1 14:50:42 2022 +0530
Commit: Michael Meeks 
CommitDate: Wed Apr 6 11:37:38 2022 +0200

lok: avoid validation-dialog yield when saving

Disable error dialog box when about to save in lok mode as this
ultimately invokes SvpSalInstance::DoYield() when we want to save
immediately without committing any erroneous input in possibly a cell
with validation rules. After save is complete the user can continue
editing.

Change-Id: Iffa0766ad594db75f57158986c4e1d2646f71da4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132410
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git a/sc/inc/scmod.hxx b/sc/inc/scmod.hxx
index c139afe9244c..6c0cfbb8b393 100644
--- a/sc/inc/scmod.hxx
+++ b/sc/inc/scmod.hxx
@@ -199,7 +199,7 @@ public:
 boolIsInputMode();  // also for SC_INPUT_TYPE
 voidSetInputMode( ScInputMode eMode, const OUString* 
pInitText = nullptr );
 boolInputKeyEvent( const KeyEvent& rKEvt, bool bStartEdit 
= false );
-SC_DLLPUBLIC void   InputEnterHandler( ScEnterMode nBlockMode = 
ScEnterMode::NORMAL );
+SC_DLLPUBLIC void   InputEnterHandler( ScEnterMode nBlockMode = 
ScEnterMode::NORMAL, bool bBeforeSavingInLOK = false );
 voidInputCancelHandler();
 voidInputSelection( const EditView* pView );
 voidInputChanged( const EditView* pView );
diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index c04e0db4aa86..c459c3438ca9 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -2934,7 +2934,7 @@ static void lcl_SelectionToEnd( EditView* pView )
 }
 }
 
-void ScInputHandler::EnterHandler( ScEnterMode nBlockMode )
+void ScInputHandler::EnterHandler( ScEnterMode nBlockMode, bool 
bBeforeSavingInLOK )
 {
 if (!mbDocumentDisposing && comphelper::LibreOfficeKit::isActive()
 && pActiveViewSh != SfxViewShell::Current())
@@ -3016,6 +3016,16 @@ void ScInputHandler::EnterHandler( ScEnterMode 
nBlockMode )
 }
 }
 
+if (bBeforeSavingInLOK)
+{
+// Invalid entry but not applied to the document model.
+// Exit to complete the "save", leaving the edit view as 
it is
+// for the user to continue after save.
+bInOwnChange = false;
+bInEnterHandler = false;
+return;
+}
+
 vcl::Window* pParent = nullptr;
 if (pActiveViewSh)
 pParent = >GetViewFrame()->GetWindow();
diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index 4163094bd390..d7619d23a156 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -1407,13 +1407,13 @@ bool ScModule::InputKeyEvent( const KeyEvent& rKEvt, 
bool bStartEdit )
 return pHdl && pHdl->KeyInput( rKEvt, bStartEdit );
 }
 
-void ScModule::InputEnterHandler( ScEnterMode nBlockMode )
+void ScModule::InputEnterHandler( ScEnterMode nBlockMode, bool 
bBeforeSavingInLOK )
 {
 if ( !SfxGetpApp()->IsDowning() ) // Not when quitting the program
 {
 ScInputHandler* pHdl = GetInputHdl();
 if (pHdl)
-pHdl->EnterHandler( nBlockMode );
+pHdl->EnterHandler( nBlockMode, bBeforeSavingInLOK );
 }
 }
 
diff --git a/sc/source/ui/inc/inputhdl.hxx b/sc/source/ui/inc/inputhdl.hxx
index ddd3f4f49e8b..a57905d05597 100644
--- a/sc/source/ui/inc/inputhdl.hxx
+++ b/sc/source/ui/inc/inputhdl.hxx
@@ -196,7 +196,7 @@ public:
 voidMergeLanguageAttributes( ScEditEngineDefaulter& 
rDestEngine ) const;
 
 boolKeyInput( const KeyEvent& rKEvt, bool bStartEdit );
-voidEnterHandler( ScEnterMode nBlockMode = ScEnterMode::NORMAL 
);
+voidEnterHandler( ScEnterMode nBlockMode = 
ScEnterMode::NORMAL, bool bBeforeSavingInLOK = false );
 voidCancelHandler();
 voidSetReference( const ScRange& rRef, const ScDocument& rDoc 
);
 voidAddRefEntry();
diff --git a/sc/source/ui/view/tabvwsha.cxx b/sc/source/ui/view/tabvwsha.cxx
index 4a6062fddff5..446854246c89 100644
--- a/sc/source/ui/view/tabvwsha.cxx
+++ b/sc/source/ui/view/tabvwsha.cxx
@@ -759,9 +759,16 @@ void ScTabViewShell::ExecuteSave( SfxRequest& rReq )
 // Finish entering unless 'DontTerminateEdit' is specified, even if a 
formula is being processed
 if (bCommitChanges)
 {
-

[Libreoffice-bugs] [Bug 148051] Mac: Crashings for unkown reasons, despite reset user profile etc.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148051

--- Comment #29 from Alex Thurgood  ---
For me, I often get a crash when context switching, e.g. working on a Writer
document, and I switch application context to Inkscape, or Preview, or
whatever, and then switch back.

If the LO process tries to write to RAM, or some other activity at the very
moment I switch contexts, or switch back, it causes a hang, and sometimes,
immediately crashes.

I also managed to experience crash when working on a Writer document and a Draw
document simultaneously, switching between two neighbouring desktops with the
macOS keyboard shortcuts or the 3-finger swipe. Here again, if the save,
temporary save, save as, refresh or whatever other function the previously
active application window was doing and hadn't completed gets interrupted by
the context switch, it seems that LO either just shuts down (crash), or else
hangs (spinning beachball).

Clearly, it shouldn't be doing this, but what exactly triggers the problem is
really hard to pinpoint.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139605] The content of some math formulas disappear while writing at other location in Writer document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139605

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107237] [META] Notebookbar Tabbed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107237
Bug 107237 depends on bug 145954, which changed state.

Bug 145954 Summary: Unable to access Math menus using Tabbed interface on Kf5
https://bugs.documentfoundation.org/show_bug.cgi?id=145954

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
Bug 102495 depends on bug 145954, which changed state.

Bug 145954 Summary: Unable to access Math menus using Tabbed interface on Kf5
https://bugs.documentfoundation.org/show_bug.cgi?id=145954

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145954] Unable to access Math menus using Tabbed interface on Kf5

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145954

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145954] Unable to access Math menus using Tabbed interface on Kf5

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145954

--- Comment #3 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9c4ef8ce3183e27ca174475cf4a8d15cc0368f60

tdf#145954 Qt unshare QMenubar usage

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/inc vcl/qt5

[Jan-Marek Glogowski (via logerrit)]

 vcl/inc/qt5/QtMenu.hxx |2 +-
 vcl/qt5/QtMenu.cxx |   38 --
 2 files changed, 21 insertions(+), 19 deletions(-)

New commits:
commit 9c4ef8ce3183e27ca174475cf4a8d15cc0368f60
Author: Jan-Marek Glogowski 
AuthorDate: Tue Apr 5 16:49:38 2022 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Wed Apr 6 11:27:35 2022 +0200

tdf#145954 Qt unshare QMenubar usage

The Qt code was sharing the menu bar from the top level frame, but
LO expects independent menu bars per SetFrame calls. So instead of
showing the new bar and then hiding the old one, this was always
show and hiding the same menu bar, resulting in a hidden menu bar.

As a result of unsharing, LO now must check that its menu bar
pointer is still valid for usage. The QMainWindows takes ownership
when a QMenuBar is assigned and destroy old ones.

Change-Id: I2c6b12199a1e17a5d9f88686a4b27b1413beda47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132581
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/inc/qt5/QtMenu.hxx b/vcl/inc/qt5/QtMenu.hxx
index 55275ae6e099..f39be7e8d506 100644
--- a/vcl/inc/qt5/QtMenu.hxx
+++ b/vcl/inc/qt5/QtMenu.hxx
@@ -50,7 +50,6 @@ private:
 // pointer to QMenu owned by the corresponding QtMenuItem or self (-> 
mpOwnedQMenu)
 QMenu* mpQMenu;
 QPushButton* mpCloseButton;
-QMetaObject::Connection maCloseButtonConnection;
 
 void DoFullMenuUpdate(Menu* pMenuBar);
 static void NativeItemText(OUString& rItemText);
@@ -60,6 +59,7 @@ private:
 void ReinitializeActionGroup(unsigned nPos);
 void ResetAllActionGroups();
 void UpdateActionGroupItem(const QtMenuItem* pSalMenuItem);
+bool validateQMenuBar();
 
 public:
 QtMenu(bool bMenuBar);
diff --git a/vcl/qt5/QtMenu.cxx b/vcl/qt5/QtMenu.cxx
index d9279fb9389a..71b81c22ba3e 100644
--- a/vcl/qt5/QtMenu.cxx
+++ b/vcl/qt5/QtMenu.cxx
@@ -59,7 +59,7 @@ void QtMenu::InsertMenuItem(QtMenuItem* pSalMenuItem, 
unsigned nPos)
 if (mbMenuBar)
 {
 // top-level menu
-if (mpQMenuBar)
+if (validateQMenuBar())
 {
 QMenu* pQMenu = new QMenu(toQString(aText), nullptr);
 pSalMenuItem->mpMenu.reset(pQMenu);
@@ -428,20 +428,10 @@ void QtMenu::SetFrame(const SalFrame* pFrame)
 if (!pMainWindow)
 return;
 
-mpQMenuBar = pMainWindow->menuBar();
-if (mpQMenuBar)
-{
-mpQMenuBar->clear();
-QPushButton* pButton
-= 
static_cast(mpQMenuBar->cornerWidget(Qt::TopRightCorner));
-if (pButton && ((mpCloseButton != pButton) || 
!maCloseButtonConnection))
-{
-maCloseButtonConnection
-= connect(pButton, ::clicked, this, 
::slotCloseDocument);
-mpCloseButton = pButton;
-}
-}
+mpQMenuBar = new QMenuBar();
+pMainWindow->setMenuBar(mpQMenuBar);
 
+mpCloseButton = nullptr;
 mpQMenu = nullptr;
 
 DoFullMenuUpdate(mpVCLMenu);
@@ -565,9 +555,22 @@ QtMenu* QtMenu::GetTopLevel()
 return pMenu;
 }
 
+bool QtMenu::validateQMenuBar()
+{
+if (!mpQMenuBar)
+return false;
+assert(mpFrame);
+QtMainWindow* pMainWindow = mpFrame->GetTopLevelWindow();
+assert(pMainWindow);
+const bool bValid = mpQMenuBar == pMainWindow->menuBar();
+if (!bValid)
+mpQMenuBar = nullptr;
+return bValid;
+}
+
 void QtMenu::ShowMenuBar(bool bVisible)
 {
-if (mpQMenuBar)
+if (validateQMenuBar())
 mpQMenuBar->setVisible(bVisible);
 }
 
@@ -643,7 +646,7 @@ void QtMenu::slotCloseDocument()
 
 void QtMenu::ShowCloseButton(bool bShow)
 {
-if (!mpQMenuBar)
+if (!validateQMenuBar())
 return;
 
 QPushButton* pButton = 
static_cast(mpQMenuBar->cornerWidget(Qt::TopRightCorner));
@@ -661,8 +664,7 @@ void QtMenu::ShowCloseButton(bool bShow)
 pButton->setFocusPolicy(Qt::NoFocus);
 pButton->setToolTip(toQString(VclResId(SV_HELPTEXT_CLOSEDOCUMENT)));
 mpQMenuBar->setCornerWidget(pButton, Qt::TopRightCorner);
-maCloseButtonConnection
-= connect(pButton, ::clicked, this, 
::slotCloseDocument);
+connect(pButton, ::clicked, this, 
::slotCloseDocument);
 mpCloseButton = pButton;
 }
 

[Libreoffice-bugs] [Bug 145954] Unable to access Math menus using Tabbed interface on Kf5

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145954

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148381] closing the print preview page - with the X, too :)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148381

--- Comment #3 from sdc.bla...@youmail.dk ---
Note that Print Preview in Calc only shows "X", while Writer shows "X Close
Preview" -- might be friendly to have Calc appear the same as Writer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148381] closing the print preview page - with the X, too :)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148381

--- Comment #3 from sdc.bla...@youmail.dk ---
Note that Print Preview in Calc only shows "X", while Writer shows "X Close
Preview" -- might be friendly to have Calc appear the same as Writer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147797] Changing Slide Master in presentation does not take into account slide layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147797

--- Comment #38 from Cor Nouws  ---
(In reply to Pedro from comment #37)

> I didn't understand... You are condensing submitted bug reports about these
> issues or are you saying that you submitted code to fix the issues?

The first, Pedro.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 139433] Form control that renders and displays the html code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139433

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Heiko Tietze  ---
By using the image form control you can enter the link in the properties
dialog. But LibreOffice is not a HTML editor/viewer and adding those
capabilities affects security. 

There are plenty of other methods to "render image in frame" respectively to
have it as background.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 139433] Form control that renders and displays the html code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139433

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Heiko Tietze  ---
By using the image form control you can enter the link in the properties
dialog. But LibreOffice is not a HTML editor/viewer and adding those
capabilities affects security. 

There are plenty of other methods to "render image in frame" respectively to
have it as background.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - cui/source

[Julien Nabet (via logerrit)]

 cui/source/dialogs/FontFeaturesDialog.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a6b7356fbf49e07428262fa0b510d8d4c03eadd0
Author: Julien Nabet 
AuthorDate: Tue Apr 5 22:10:57 2022 +0200
Commit: Xisco Fauli 
CommitDate: Wed Apr 6 11:19:47 2022 +0200

tdf#148397: Crash on font features dialog opening with EB Garamond

bt:
0  0x7f7ba5ef549c in rtl::str::acquire<_rtl_uString>(_rtl_uString*) 
(pThis=0x0) at sal/rtl/strtmpl.hxx:825
1  0x7f7ba5ef8d45 in rtl_uString_acquire(rtl_uString*) (pThis=0x0) at 
sal/rtl/ustring.cxx:1199
2  0x7f7b485757e3 in rtl::OUString::OUString(_rtl_uString*) 
(this=0x7ffc345a9f20, str=0x0) at include/rtl/ustring.hxx:252
3  0x7f7b485fd1da in 
cui::FontFeaturesDialog::fillGrid(std::__debug::vector > const&) (this=
   0x7ffc345aa538, rFontFeatures=std::__debug::vector of length 43, 
capacity 64 = {...}) at cui/source/dialogs/FontFeaturesDialog.cxx:98
4  0x7f7b485fcc83 in cui::FontFeaturesDialog::initialize() 
(this=0x7ffc345aa538) at cui/source/dialogs/FontFeaturesDialog.cxx:66
5  0x7f7b485fc8b9 in 
cui::FontFeaturesDialog::FontFeaturesDialog(weld::Window*, rtl::OUString 
const&) (this=0x7ffc345aa538, pParent=0x6f2f748, rFontName="EB Garamond 12")
   at cui/source/dialogs/FontFeaturesDialog.cxx:28
6  0x7f7b488f3165 in 
SvxCharNamePage::FontFeatureButtonClicked(weld::Button&) (this=0x6f0a620, 
rButton=...) at cui/source/tabpages/chardlg.cxx:1157

Revealed with 5afdcad4c0e7850b18996c549892b9360cd8973f
Pass context and resource string down to boost::locale separately
because this is often on a hot path, and we can avoid the splitting and
joining of strings like this.

Change-Id: I20b18c8f46014feb453f81d66dd7cb490124efa1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132590
Reviewed-by: Julien Nabet 
Tested-by: Jenkins
(cherry picked from commit ad3d2d1bc7e07f79a26841d89a85e94999a7c8ca)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132600
Reviewed-by: Xisco Fauli 

diff --git a/cui/source/dialogs/FontFeaturesDialog.cxx 
b/cui/source/dialogs/FontFeaturesDialog.cxx
index 4735de194255..d41afa809984 100644
--- a/cui/source/dialogs/FontFeaturesDialog.cxx
+++ b/cui/source/dialogs/FontFeaturesDialog.cxx
@@ -96,7 +96,7 @@ int 
FontFeaturesDialog::fillGrid(std::vector const& rFontFea
 if (rFontFeature.m_aDefinition)
 aDefinition = rFontFeature.m_aDefinition;
 if (!aDefinition)
-aDefinition = { nFontFeatureCode, nullptr };
+aDefinition = { nFontFeatureCode, "" };
 
 m_aFeatureItems.emplace_back(m_xContentGrid.get());
 

[Libreoffice-bugs] [Bug 148408] Pasting a not-so-long section of a webpage takes lots of time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148408

--- Comment #3 from Telesto  ---
I'm not able to reproduce this in this case.. But I'm aware the issue exists..
Except it's rather 'hard' to find an general example

As it is depended on network connection at server/client side. Not the
bandwidth, but more in number of hops and time-outs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148390] Navigator shows hidden tables, but no way to make those visible (if existing)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148390

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED
 CC||david.snow0...@gmail.com

--- Comment #4 from Heiko Tietze  ---
(In reply to Telesto from comment #3)
> Note: content in document is a copy/paste from attachment 179146 [details]

Which is a crash report... In the original document I see table1 renamed to
"templatesettings", table1/2 off by one and table4. The table3/5 are not
accessible there as well.

Closing the ticket as INVALID. Tables cannot be hidden, only paragraphs (this
results in funny issues when applied to the table content) and sections.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146174] ALT no longer usable for hotkeys, goes to dropdown menu now (started in 7.2.3) (gtk3 only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146174

Caolán McNamara  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |FIXED

--- Comment #23 from Caolán McNamara  ---
backports to 7-3 and 7-2 in gerrit

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141584] Bug at Export directly to PDF file, in the Standard bar, when using arab characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141584

--- Comment #6 from Jorge H  ---
I use Xchange PDF viewer. I tryed with Adobe Acrobat and with Mozilla but the
pdf file's view  is the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141584] Bug at Export directly to PDF file, in the Standard bar, when using arab characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141584

--- Comment #5 from Jorge H  ---
Created attachment 179341
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179341=edit
same example file than in first sending, now printed with Libre Office 7.3.2.2

same example file than in first sending, now printed with Libre Office 7.3.2.2
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148407] Need ability to cancel an ongoing paste action

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148407

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||8408

--- Comment #1 from Telesto  ---
Closely related to bug 148408

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148407] Need ability to cancel an ongoing paste action

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148407

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||8408

--- Comment #1 from Telesto  ---
Closely related to bug 148408

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148408] Pasting a not-so-long section of a webpage takes lots of time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148408

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||8407

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148407] Need ability to cancel an ongoing paste action

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148407

Telesto  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148416] FILESAVE XLSX Read-only passwords on XLSX files are not working when using Save as

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148416

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||4996
 CC||libreoff...@nisz.hu,
   ||xiscofa...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148390] Navigator shows hidden tables, but no way to make those visible (if existing)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148390

--- Comment #3 from Telesto  ---
Note: content in document is a copy/paste from attachment 179146

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148416] New: FILESAVE XLSX Read-only passwords on XLSX files are not working when using Save as

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148416

Bug ID: 148416
   Summary: FILESAVE XLSX Read-only passwords on XLSX files are
not working when using Save as
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

This is a follow-up of bug 144996

Steps to reproduce:
1. Open attachment 175647 from bug 144996
2. Edit - Edit Mode
3. Introduce the password
4. Modify the file
5. Save to a new document
6. Close the document and open the new document

-> it's possible to edit the new document without the password

Reproduced in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: bd992ae1228b2f7e556f89f95949da0aeade5b91
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (es_ES.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141389] FORMATTING: Remember and/or indicate the active sheet when managing conditional formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141389

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Heiko Tietze  ---
Duplicate of bug 139649?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 141389] FORMATTING: Remember and/or indicate the active sheet when managing conditional formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141389

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Heiko Tietze  ---
Duplicate of bug 139649?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 121995] Form preview shows content of the form very confused

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121995

--- Comment #6 from Alex Thurgood  ---
Still present in 

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: d925d1ca9e03863650dd3e450331598624f21724
CPU threads: 8; OS: Mac OS X 12.2.1; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded

Robert's suggestion to use the Writer thumbnail creation method is a reasonable
one IMHO.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116221] [META] Manage conditional formatting dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116221

Heiko Tietze  changed:

   What|Removed |Added

 Depends on|101285  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101285
[Bug 101285] Manage Conditional Formatting dialog doesn't remember position,
column sizes, and range selection
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109265] [META] Remember dialog's previous settings issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109265

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||101285


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101285
[Bug 101285] Manage Conditional Formatting dialog doesn't remember position,
column sizes, and range selection
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102019] [META] Dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102019

Heiko Tietze  changed:

   What|Removed |Added

 Depends on|101285  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101285
[Bug 101285] Manage Conditional Formatting dialog doesn't remember position,
column sizes, and range selection
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101285] Manage Conditional Formatting dialog doesn't remember position, column sizes, and range selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101285

Heiko Tietze  changed:

   What|Removed |Added

 Blocks|102019, 116221  |109265
 CC||heiko.tietze@documentfounda
   ||tion.org


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102019
[Bug 102019] [META] Dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109265
[Bug 109265] [META] Remember dialog's previous settings issues
https://bugs.documentfoundation.org/show_bug.cgi?id=116221
[Bug 116221] [META] Manage conditional formatting dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141584] Bug at Export directly to PDF file, in the Standard bar, when using arab characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141584

--- Comment #4 from Jorge H  ---
Thank you very much, Roman, for your attention on this bug.
I notice that many dashes(always at the end of the word) disappear in most
cases using the latest version 7.3.2.2 , but unfortunately some of them still
appear. I send the same file initially sent, printed in PDF format now
according to the latest version.

You can see that the dash have disappeared in the translation of the word
"Desierto" or in the translation of the word "Luna" (page 1, first column)
-thank you very much for the correction and the extraeffort for using Spanish
lenguage-. However it does not disappear at the word "Tsunami" or the word
"Satélite" (page 3, last column).

In addition, I realize that these lines appear preferentially in certain
letters at the end of the text.

Thanks again for the bug's correction in the most cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-6.4-60'

[Andras Timar (via logerrit)]

Tag 'cp-6.4-60' created by Andras Timar  at 
2022-04-06 08:53 +

cp-6.4-60

Changes since cp-6.4-59-13:
---
 0 files changed
---

[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-6.4-60'

[Tor Lillqvist (via logerrit)]

Tag 'cp-6.4-60' created by Andras Timar  at 
2022-04-06 08:53 +

cp-6.4-60

Changes since cp-6.4-48:
Tor Lillqvist (1):
  Add missing mobile-specific Impress German translations

---
 source/de/sd/messages.po |   37 +
 1 file changed, 37 insertions(+)
---

[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-6.4-60'

[Andras Timar (via logerrit)]

Tag 'cp-6.4-60' created by Andras Timar  at 
2022-04-06 08:53 +

cp-6.4-60

Changes since cp-6.4-branch-point-11:
---
 0 files changed
---

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-6.4-60'

[Andras Timar (via logerrit)]

Tag 'cp-6.4-60' created by Andras Timar  at 
2022-04-06 08:53 +

cp-6.4-60

Changes since co-6.4-20:
Andras Timar (1):
  update Danish dictionary

---
 da_DK/README_da_DK.txt |4 
 da_DK/da_DK.aff| 3401 
 da_DK/da_DK.dic|288016 
+++--
 da_DK/description.xml  |9 
 4 files changed, 139245 insertions(+), 152185 deletions(-)
---

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - 7 commits - configure.ac download.lst external/nss external/zlib fpicker/source hwpfilter/source svtools/source vcl/source

[Andras Timar (via logerrit)]

 configure.ac |8 ++--
 download.lst |4 ++--
 external/nss/ExternalProject_nss.mk  |3 ++-
 external/zlib/UnpackedTarball_zlib.mk|4 
 external/zlib/ubsan.patch|   11 ---
 fpicker/source/office/fileview.cxx   |   10 +++---
 hwpfilter/source/hwpread.cxx |1 +
 svtools/source/dialogs/ServerDetailsControls.cxx |2 ++
 vcl/source/outdev/hatch.cxx  |7 +++
 9 files changed, 27 insertions(+), 23 deletions(-)

New commits:
commit 2861fcac6dd80b6e84e6853c2a47fe371b75e3a0
Author: Andras Timar 
AuthorDate: Wed Apr 6 10:52:24 2022 +0200
Commit: Andras Timar 
CommitDate: Wed Apr 6 10:52:24 2022 +0200

Bump version to 6.4-60

Change-Id: I41359b8ea96fef0fc22c8fc5c8b6f461ffaca68a

diff --git a/configure.ac b/configure.ac
index 0095852d7459..c318a619bdbd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[6.4.10.59],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[6.4.10.60],[],[],[https://collaboraoffice.com/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard
commit 13809b9f0f2f985562553bdbd1c1f5a81fb064d8
Author: Michael Stahl 
AuthorDate: Thu Mar 31 20:33:02 2022 +0200
Commit: Andras Timar 
CommitDate: Wed Apr 6 10:49:17 2022 +0200

nss: build with zlib module on WNT

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132367
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 1c748fefc3c5b42e3548a1a7f5017a579982005a)

Change-Id: Ie875b4a8df1697de83a8f22cb1170a49792c47e6

diff --git a/configure.ac b/configure.ac
index a530bc311e67..0095852d7459 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8275,7 +8275,11 @@ else
 SYSTEM_ZLIB=
 BUILD_TYPE="$BUILD_TYPE ZLIB"
 ZLIB_CFLAGS="-I${WORKDIR}/UnpackedTarball/zlib"
-ZLIB_LIBS="-L${WORKDIR}/LinkTarget/StaticLibrary -lzlib"
+if test "$COM" = "MSC"; then
+ZLIB_LIBS="${WORKDIR}/LinkTarget/StaticLibrary/zlib.lib"
+else
+ZLIB_LIBS="-L${WORKDIR}/LinkTarget/StaticLibrary -lzlib"
+fi
 fi
 AC_SUBST(ZLIB_CFLAGS)
 AC_SUBST(ZLIB_LIBS)
diff --git a/external/nss/ExternalProject_nss.mk 
b/external/nss/ExternalProject_nss.mk
index 49726ff224d4..7bcafb581479 100644
--- a/external/nss/ExternalProject_nss.mk
+++ b/external/nss/ExternalProject_nss.mk
@@ -26,9 +26,10 @@ $(call gb_ExternalProject_get_state_target,nss,build): \
MOZ_DEBUG_FLAGS=" " \
OPT_CODE_SIZE=0) \
OS_TARGET=WIN95 \
+   USE_SYSTEM_ZLIB=1 \
$(if $(filter X86_64,$(CPUNAME)),USE_64=1) \
LIB="$(ILIB)" \
-   XCFLAGS="-arch:SSE $(SOLARINC)" \
+   XCFLAGS="-arch:SSE $(SOLARINC) $(ZLIB_CFLAGS)" \
$(MAKE) nss_build_all RC="rc.exe $(SOLARINC)" \
NSINSTALL='$(call 
gb_ExternalExecutable_get_command,python) $(SRCDIR)/external/nss/nsinstall.py' \
NSS_DISABLE_GTESTS=1 \
commit e306f209126ebf3ff6c97dbf15577ffb3de405af
Author: Michael Stahl 
AuthorDate: Thu Mar 31 12:13:23 2022 +0200
Commit: Andras Timar 
CommitDate: Wed Apr 6 10:49:13 2022 +0200

zlib: upgrade to release 1.2.12

Fixes CVE-2018-25032

external/zlib/ubsan.patch: remove, fixed upstream

Change-Id: I2aa9a9008b9cf7efd970c5fff0df7029204204f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132358
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit bfb6c4c65781a610d21409d974227d73f264f41a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132191
Reviewed-by: Thorsten Behrens 
(cherry picked from commit b91ebecaaa1582a7cbeda519eb6097a6a866135f)

diff --git a/download.lst b/download.lst
index d24e8b661a01..3771c13fdfba 100644
--- a/download.lst
+++ b/download.lst
@@ -275,8 +275,8 @@ export WPS_VERSION_MICRO := 10
 export WPS_TARBALL := libwps-0.4.$(WPS_VERSION_MICRO).tar.xz
 export XSLTML_SHA256SUM := 
75823776fb51a9c526af904f1503a7afaaab900fba83eda64f8a41073724c870
 export XSLTML_TARBALL := a7983f859eafb2677d7ff386a023bc40-xsltml_2.1.2.zip
-export ZLIB_SHA256SUM := 
4ff941449631ace0d4d203e3483be9dbc9da454084111f97ea0a2114e19bf066
-export ZLIB_TARBALL := zlib-1.2.11.tar.xz
+export ZLIB_SHA256SUM := 
7db46b8d7726232a621befaab4a1c870f00a90805511c0e0090441dac57def18
+export ZLIB_TARBALL := zlib-1.2.12.tar.xz
 export ZMF_SHA256SUM := 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sfx2/source

[Caolán McNamara (via logerrit)]

 sfx2/source/appl/newhelp.cxx |   17 -
 sfx2/source/appl/newhelp.hxx |1 +
 2 files changed, 17 insertions(+), 1 deletion(-)

New commits:
commit a2b1c7c071cc2bf847a603733b972df23e904ff6
Author: Caolán McNamara 
AuthorDate: Tue Apr 5 16:44:39 2022 +0100
Commit: Michael Stahl 
CommitDate: Wed Apr 6 10:53:03 2022 +0200

Resolves: rhbz#2069486 classic help index entry autocompletes on 
del/backspace

when it shouldn't

Change-Id: I90fa338479e0d5612d7b09f94c45e356ea71f89e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132596
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sfx2/source/appl/newhelp.cxx b/sfx2/source/appl/newhelp.cxx
index ee4e2c32b955..9312a83ccd04 100644
--- a/sfx2/source/appl/newhelp.cxx
+++ b/sfx2/source/appl/newhelp.cxx
@@ -397,6 +397,7 @@ IndexTabPage_Impl::IndexTabPage_Impl(weld::Widget* pParent, 
SfxHelpIndexWindow_I
 , bIsActivated(false)
 , nRowHeight(m_xIndexList->get_height_rows(1))
 , nAllHeight(0)
+, nLastCharCode(0)
 {
 m_xIndexList->set_size_request(m_xIndexList->get_approximate_digit_width() 
* 30, -1);
 
@@ -466,7 +467,19 @@ IMPL_LINK_NOARG(IndexTabPage_Impl, TreeChangeHdl, 
weld::TreeView&, void)
 
 IMPL_LINK_NOARG(IndexTabPage_Impl, EntryChangeHdl, weld::Entry&, void)
 {
-aAutoCompleteIdle.Start();
+switch (nLastCharCode)
+{
+case css::awt::Key::DELETE_WORD_BACKWARD:
+case css::awt::Key::DELETE_WORD_FORWARD:
+case css::awt::Key::DELETE_TO_BEGIN_OF_LINE:
+case css::awt::Key::DELETE_TO_END_OF_LINE:
+case KEY_BACKSPACE:
+case KEY_DELETE:
+break;
+default:
+aAutoCompleteIdle.Start();
+break;
+}
 }
 
 IMPL_LINK(IndexTabPage_Impl, KeyInputHdl, const KeyEvent&, rKEvt, bool)
@@ -531,6 +544,8 @@ IMPL_LINK(IndexTabPage_Impl, KeyInputHdl, const KeyEvent&, 
rKEvt, bool)
 //m_bTreeChange = false;
 return true;
 }
+
+nLastCharCode = nCode;
 return false;
 }
 
diff --git a/sfx2/source/appl/newhelp.hxx b/sfx2/source/appl/newhelp.hxx
index 7d22336ecf83..f26bf93379a9 100644
--- a/sfx2/source/appl/newhelp.hxx
+++ b/sfx2/source/appl/newhelp.hxx
@@ -102,6 +102,7 @@ private:
 boolbIsActivated;
 int nRowHeight;
 int nAllHeight;
+sal_uInt16  nLastCharCode;
 
 voidInitializeIndex();
 voidClearIndex();

[Libreoffice-commits] core.git: emfio/inc emfio/qa emfio/source

[Hossein (via logerrit)]

 emfio/inc/mtftools.hxx |2 +-
 emfio/qa/cppunit/wmf/wmfimporttest.cxx |2 +-
 emfio/source/reader/mtftools.cxx   |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 51431559bda9a81293d502328982452caeeba6c6
Author: Hossein 
AuthorDate: Wed Apr 6 04:41:07 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Apr 6 10:52:50 2022 +0200

Fix type, calculation of FamilyFont PitchAndFamily

This patch fixes problems caused by the cleanup commit
3e7dd04dd8ca1baea4b7918eb7a7080c595c4625 for type and calculation of
FamilyFont and PitchAndFamily enumerations.

FamilyFont enumeration is described in [MS-WMF] v20210625 page 33:

  "In a Font Object, when a FamilyFont value is packed into a byte
  with a PitchFont Enumeration value, the result is a PitchAndFamily
  Object".

Thus, we will use sal_uInt8 as the underlying type for FamilyFont.

The PitchAndFamily is created as shown in [MS-WMF] v20210625 page 96:

[0 1 2 3] 4 5 [6 7]
 Family   0 0 Pitch

The values for FamilyFont enumeration are created according to the
[MS-WMF], and the calculations are changed to use '<< 4' and '>> 4'
instead of applying the same shift to the enumeration values.

Change-Id: I4f6df33ed6405589acf89ba2c9223a571cb510b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132614
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/emfio/inc/mtftools.hxx b/emfio/inc/mtftools.hxx
index cb6e1c7ff243..0290c487c574 100644
--- a/emfio/inc/mtftools.hxx
+++ b/emfio/inc/mtftools.hxx
@@ -275,7 +275,7 @@ namespace emfio
 };
 
 /* [MS-WMF] - v20210625 - pages 33,  */
-enum FamilyFont : sal_uInt32
+enum FamilyFont : sal_uInt8
 {
 FF_DONTCARE   = 0x00,
 FF_ROMAN  = 0x01,
diff --git a/emfio/qa/cppunit/wmf/wmfimporttest.cxx 
b/emfio/qa/cppunit/wmf/wmfimporttest.cxx
index 1ae7416521aa..b8c2218fdec2 100644
--- a/emfio/qa/cppunit/wmf/wmfimporttest.cxx
+++ b/emfio/qa/cppunit/wmf/wmfimporttest.cxx
@@ -336,7 +336,7 @@ void WmfTest::testTdf99402()
 logfontw.lfUnderline = 0;
 logfontw.lfStrikeOut = 0;
 logfontw.lfCharSet = emfio::CharacterSet::OEM_CHARSET;
-logfontw.lfPitchAndFamily = +emfio::FamilyFont::FF_ROMAN | 
+emfio::PitchFont::DEFAULT_PITCH;
+logfontw.lfPitchAndFamily = emfio::FamilyFont::FF_ROMAN << 4 | 
emfio::PitchFont::DEFAULT_PITCH;
 logfontw.alfFaceName = "Symbol";
 
 emfio::WinMtfFontStyle fontStyle(logfontw);
diff --git a/emfio/source/reader/mtftools.cxx b/emfio/source/reader/mtftools.cxx
index b4973f6e51ab..f829788dbd1b 100644
--- a/emfio/source/reader/mtftools.cxx
+++ b/emfio/source/reader/mtftools.cxx
@@ -179,7 +179,7 @@ namespace emfio
 aFont.SetCharSet( eCharSet );
 aFont.SetFamilyName( rFont.alfFaceName );
 FontFamily eFamily;
-switch ( rFont.lfPitchAndFamily & 0xf0 )
+switch ( rFont.lfPitchAndFamily >> 4 & 0x0f )
 {
 case FamilyFont::FF_ROMAN:
 eFamily = FAMILY_ROMAN;

[Libreoffice-commits] core.git: config_host.mk.in configure.ac external/hsqldb

[Stephan Bergmann (via logerrit)]

 config_host.mk.in |1 -
 configure.ac  |   11 ---
 external/hsqldb/UnpackedTarball_hsqldb.mk |6 ++
 3 files changed, 2 insertions(+), 16 deletions(-)

New commits:
commit cedf0b23542a06cd31440dd1deb450d03191a1b9
Author: Stephan Bergmann 
AuthorDate: Wed Apr 6 08:20:14 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Apr 6 10:46:47 2022 +0200

Remove obsolete HSQLDB_USE_JDBC_4_1

...that must always be true ever since 
1b8c61d5ca8e2a7ae7a0bcd189b7a87defecea03
"Bump JDK buildtime requirement to 1.6"

Change-Id: I9432ac9d0a0e2c4999a80b6f144099d0e4dc15bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132616
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/config_host.mk.in b/config_host.mk.in
index c412a0b99895..cc05b3448d0b 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -311,7 +311,6 @@ export HELP_ONLINE=@HELP_ONLINE@
 export HELP_OMINDEX_PAGE=@HELP_OMINDEX_PAGE@
 export HOST_PLATFORM=@HOST_PLATFORM@
 export HSQLDB_JAR=@HSQLDB_JAR@
-export HSQLDB_USE_JDBC_4_1=@HSQLDB_USE_JDBC_4_1@
 export HUNSPELL_CFLAGS=$(gb_SPACE)@HUNSPELL_CFLAGS@
 export HUNSPELL_LIBS=$(gb_SPACE)@HUNSPELL_LIBS@
 export HYPHEN_LIB=$(gb_SPACE)@HYPHEN_LIB@
diff --git a/configure.ac b/configure.ac
index af0c9937d865..1cdd22b0ae66 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5789,7 +5789,6 @@ if test "$cross_compiling" = "yes"; then
 ANT
 ANT_HOME
 ANT_LIB
-HSQLDB_USE_JDBC_4_1
 JAVA_CLASSPATH_NOT_SET
 JAVA_SOURCE_VER
 JAVA_TARGET_VER
@@ -10159,7 +10158,6 @@ dnl 
===
 dnl Check for system hsqldb
 dnl ===
 if test "$with_java" != "no" -a "$cross_compiling" != "yes"; then
-HSQLDB_USE_JDBC_4_1=
 AC_MSG_CHECKING([which hsqldb to use])
 if test "$with_system_hsqldb" = "yes"; then
 AC_MSG_RESULT([external])
@@ -10211,14 +10209,6 @@ if test "$with_java" != "no" -a "$cross_compiling" != 
"yes"; then
 SYSTEM_HSQLDB=
 BUILD_TYPE="$BUILD_TYPE HSQLDB"
 NEED_ANT=TRUE
-AC_MSG_CHECKING([whether hsqldb should be built with JDBC 4.1])
-javanumver=`$JAVAINTERPRETER -version 2>&1 | $AWK -v num=true -f 
$SRC_ROOT/solenv/bin/getcompver.awk`
-if expr "$javanumver" '>=' 00010006 > /dev/null; then
-AC_MSG_RESULT([yes])
-HSQLDB_USE_JDBC_4_1=TRUE
-else
-AC_MSG_RESULT([no])
-fi
 fi
 else
 if test "$with_java" != "no" -a -z "$HSQLDB_JAR"; then
@@ -10227,7 +10217,6 @@ else
 fi
 AC_SUBST(SYSTEM_HSQLDB)
 AC_SUBST(HSQLDB_JAR)
-AC_SUBST([HSQLDB_USE_JDBC_4_1])
 
 dnl ===
 dnl Check for PostgreSQL stuff
diff --git a/external/hsqldb/UnpackedTarball_hsqldb.mk 
b/external/hsqldb/UnpackedTarball_hsqldb.mk
index cbba770f19a0..389572377fa6 100644
--- a/external/hsqldb/UnpackedTarball_hsqldb.mk
+++ b/external/hsqldb/UnpackedTarball_hsqldb.mk
@@ -25,10 +25,8 @@ $(eval $(call gb_UnpackedTarball_add_patches,hsqldb,\
external/hsqldb/patches/fdo36824.patch \
external/hsqldb/patches/limit_as_table_alias.patch \
external/hsqldb/patches/hsqldb-runFinalizersOnExit.patch \
-   $(if $(HSQLDB_USE_JDBC_4_1),\
-   external/hsqldb/patches/jdbc-4.1.patch \
-   external/hsqldb/patches/multipleResultSets.patch \
-   ) \
+   external/hsqldb/patches/jdbc-4.1.patch \
+   external/hsqldb/patches/multipleResultSets.patch \
 ))
 
 # vim: set noet sw=4 ts=4:

[Libreoffice-commits] core.git: solenv/flatpak-manifest.in

[Stephan Bergmann (via logerrit)]

 solenv/flatpak-manifest.in |1 +
 1 file changed, 1 insertion(+)

New commits:
commit fd0aa82a61612b90352b0780e62bb4d4dd0d94f8
Author: Stephan Bergmann 
AuthorDate: Wed Apr 6 08:36:13 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Apr 6 10:45:30 2022 +0200

Sync flatpak-manifest.in with Flathub

...including


"Merge pull request #184 from xlejo/adding-gvfsd:  Adding xdg-run/gvfsd"

Change-Id: I1b700c1e7170e67abf3fb1351be9f8c11cc15f8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132617
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in
index eda5237aa71b..055b76e41bf0 100644
--- a/solenv/flatpak-manifest.in
+++ b/solenv/flatpak-manifest.in
@@ -716,6 +716,7 @@
 "--socket=pulseaudio",
 "--device=dri",
 "--filesystem=xdg-config/gtk-3.0",
+"--filesystem=xdg-run/gvfsd",
 "--filesystem=host",
 "--env=GIO_EXTRA_MODULES=/app/lib/gio/modules",
 "--env=JAVA_HOME=/app/jre",

[Libreoffice-bugs] [Bug 146174] ALT no longer usable for hotkeys, goes to dropdown menu now (started in 7.2.3) (gtk3 only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146174

--- Comment #22 from Commit Notification 
 ---
Vincent Reher committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2703f729e9ea0bbc1f64b04b535a676a2980e1b8

Resolves: tdf#146174 allow shortcut key event handling before menubar

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146174] ALT no longer usable for hotkeys, goes to dropdown menu now (started in 7.2.3) (gtk3 only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146174

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135767] Arrow list in table replaced by numbering at redo

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135767

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org
 Status|NEEDINFO|NEW

--- Comment #3 from Jean-Baptiste Faure  ---
Reproducible for me with Version: 7.3.3.0.0+ / LibreOffice Community
Build ID: 0a34ac386187c5ca328aebc27851c2a2ff38f293
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Ubuntu_20.04_x86-64
Calc: threaded

and
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: ad3d2d1bc7e07f79a26841d89a85e94999a7c8ca
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Ubuntu_20.04_x86-64
Calc: threaded

Set status to NEW.

Best regards.
JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/unx

[Vincent Reher (via logerrit)]

 vcl/unx/gtk3/gtkframe.cxx |   20 ++--
 1 file changed, 14 insertions(+), 6 deletions(-)

New commits:
commit 2703f729e9ea0bbc1f64b04b535a676a2980e1b8
Author: Vincent Reher 
AuthorDate: Tue Apr 5 18:31:45 2022 -0700
Commit: Caolán McNamara 
CommitDate: Wed Apr 6 10:43:27 2022 +0200

Resolves: tdf#146174 allow shortcut key event handling before menubar

Change-Id: Ib0dadafcc66604baf53169cb222a059ee3f97362
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132615
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkframe.cxx b/vcl/unx/gtk3/gtkframe.cxx
index 29d6c00f78d7..35e761ede5fd 100644
--- a/vcl/unx/gtk3/gtkframe.cxx
+++ b/vcl/unx/gtk3/gtkframe.cxx
@@ -3899,12 +3899,6 @@ gboolean GtkSalFrame::signalKey(GtkWidget* pWidget, 
GdkEventKey* pEvent, gpointe
 
 if (GTK_IS_WINDOW(pThis->m_pWindow))
 {
-// tdf#144846 If this is registered as a menubar mnemonic then ensure
-// that any other widget won't be considered as a candidate by taking
-// over the task of launch the menubar menu outself
-if (pThis->HandleMenubarMnemonic(pEvent->state, pEvent->keyval))
-return true;
-
 GtkWidget* pFocusWindow = 
gtk_window_get_focus(GTK_WINDOW(pThis->m_pWindow));
 bFocusInAnotherGtkWidget = pFocusWindow && pFocusWindow != 
GTK_WIDGET(pThis->m_pFixedContainer);
 if (bFocusInAnotherGtkWidget)
@@ -4056,6 +4050,20 @@ gboolean GtkSalFrame::signalKey(GtkWidget* pWidget, 
GdkEventKey* pEvent, gpointe
   
sal_Unicode(gdk_keyval_to_unicode( pEvent->keyval )),
   (pEvent->type == 
GDK_KEY_PRESS),
   false);
+
+// tdf#144846 If this is registered as a menubar mnemonic then ensure
+// that any other widget won't be considered as a candidate by taking
+// over the task of launch the menubar menu outself
+// The code was moved here from its original position at beginning
+// of this function in order to resolve tdf#146174.
+if (!bStopProcessingKey && // module key handler did not process key
+pEvent->type == GDK_KEY_PRESS &&  // module key handler handles 
only GDK_KEY_PRESS
+GTK_IS_WINDOW(pThis->m_pWindow) &&
+pThis->HandleMenubarMnemonic(pEvent->state, pEvent->keyval))
+{
+return true;
+}
+
 if (!aDel.isDeleted())
 {
 pThis->m_nKeyModifiers = ModKeyFlags::NONE;

[Libreoffice-bugs] [Bug 135206] Lots of layout movement deleting part of a text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135206

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org

--- Comment #10 from Jean-Baptiste Faure  ---
> Lots of layout movement deleting part of a text

I do not see how you can expect something else while the layout need to be
updated each time a line is erased, taking into account that the software don't
know when you will release the backspace key.

For me this behavior is not a bug, only a constraint of the wysiwyg feature of
Writer combined with this suboptimal procedure for deleting a long part of text
and the key repetition frequency of the keyboard.

Best regards.
JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/source

[Mike Kaganski (via logerrit)]

 sw/source/ui/dbui/mmoutputtypepage.cxx |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit ac165ad008d820dc102f98569f8bb9b6653b852d
Author: Mike Kaganski 
AuthorDate: Tue Apr 5 10:06:51 2022 +0300
Commit: Michael Stahl 
CommitDate: Wed Apr 6 10:33:14 2022 +0200

tdf#148384: Really leave mail merge results dialog open upon errors

Restructuring mail merge in 5.2 cycle had broken the dialog keeping
open when errors happened during sending. Later, in 2017, in commit
bfaa6e35ff09a0426d2c3c9c36f069fabc0c9489
  Author Alex McMurchy1917 
  Date   Thu Aug 24 14:34:13 2017 +0100
tdf#103919 mailmerge: prevent premature end of emailing

SwSendMailDialog::AllMailsSent was changed in attempt to restore that
expected behavior, but the condition was incorrect:
m_nSendCount == m_nExpectedCount means "all mails processed", not
"everything went without errors".

So fix this by considering the error count when deciding to close the
dialog.

Change-Id: I98d61165803deaf0da985167ba0152e6f50f9246
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132563
Tested-by: Mike Kaganski 
Reviewed-by: Mike Kaganski 
(cherry picked from commit 2d9f12be1530f2532276a2447102ed2f1f0ecb5b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132598
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/source/ui/dbui/mmoutputtypepage.cxx 
b/sw/source/ui/dbui/mmoutputtypepage.cxx
index e8c8e35bc3dc..b0c22b9144cf 100644
--- a/sw/source/ui/dbui/mmoutputtypepage.cxx
+++ b/sw/source/ui/dbui/mmoutputtypepage.cxx
@@ -511,12 +511,15 @@ void SwSendMailDialog::UpdateTransferStatus()
 
 void SwSendMailDialog::AllMailsSent()
 {
-// Leave open if some kind of error occurred
 if (m_nSendCount == m_nExpectedCount)
 {
 m_xStop->set_sensitive(false);
-m_xDialog->hide();
-m_xDialog->response(RET_CANCEL);
+// Leave open if some kind of error occurred
+if (m_nErrorCount == 0)
+{
+m_xDialog->hide();
+m_xDialog->response(RET_CANCEL);
+}
 }
 }
 

[Libreoffice-bugs] [Bug 148415] New: More detailed, better explained loplugin errors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148415

Bug ID: 148415
   Summary: More detailed, better explained loplugin errors
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: framework
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
CC: hoss...@libreoffice.org,
ilmari.lauhakan...@libreoffice.org,
noelgran...@gmail.com, sberg...@redhat.com,
t...@libreoffice.org

This is not about LO, but about the clang plugins used by Jenkins.

In many cases the plugins end up giving error messages on a patch, which may be
difficult to understand for beginner programmers - or even more experienced
ones who do not follow new developments in the clang plugins area.

It came up that it would be better/more educative if ALL these error
messages[1] were all uniformly a bit more explanatory:
- Why is some practice considered "wrong"? This may be dug out of git logs, but
that's  super inconvenient.
- What should I change to do it correctly, possibly with an example.

Adding experienced devs and TDF mentors to CC. It would be beneficial to review
all the plugins and change their error messages to be very descriptive if they
are currently not.

[1] Just for examples from builds on top of the list:
https://gerrit.libreoffice.org/c/core/+/132571 writes:
clang plugin redundantcast did trigger. redundant static_cast from
"SwParaPortion *" to "SwLinePortion *"
- tells why is this bad, but no explanation on what to do (might be seen as
trivial... but that's just an assumption of experienced devs, better to make
sure ;) )

https://gerrit.libreoffice.org/c/core/+/130692 writes:
clang plugin fakebool did trigger. use "true" instead of "sal_True" 
- no explanation why is this bad, but tells what to change

https://gerrit.libreoffice.org/c/core/+/132505 writes:
clang plugin stringviewparam did trigger. replace function parameter of type
"const rtl::OUString &" with "std::u16string_view"
- no explanation why is this bad, but tells what to change

clang plugin simplifyconstruct did trigger. no need to explicitly init an
instance of "::std::unique_ptr" with nullptr, just use
default constructor
- explains why is this bad and what to do instead - excellent!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148413] Non-ASCII image names are encoded wrong when saved as HTML

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148413

--- Comment #3 from Michael Stahl (allotropia)  ---
yeah let's just use UTF-8 to export, i can't imagine why anybody would want
anything else these days

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 98360] [META] CMIS bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98360

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||131461


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=131461
[Bug 131461] Connexion to NextCloud and collaborative editing
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 98360] [META] CMIS bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98360
Bug 98360 depends on bug 131461, which changed state.

Bug 131461 Summary: Connexion to NextCloud and collaborative editing
https://bugs.documentfoundation.org/show_bug.cgi?id=131461

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 131461] Connexion to NextCloud and collaborative editing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131461

Heiko Tietze  changed:

   What|Removed |Added

 Blocks||98360
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Heiko Tietze  ---
You can open/save documents remotely per CMIS (File > Save Remote...). The
dialog allows to configure a wide range of connections including WebDav to
Nextcloud. And of course you may open files on NC with LibreOffice Online. 

Please reopen in case I missed the point.

https://help.libreoffice.org/latest/en-US/text/shared/guide/cmis-remote-files-setup.html
https://help.libreoffice.org/latest/en-US/text/shared/guide/digitalsign_receive.html


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98360
[Bug 98360] [META] CMIS bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 131461] Connexion to NextCloud and collaborative editing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131461

Heiko Tietze  changed:

   What|Removed |Added

 Blocks||98360
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Heiko Tietze  ---
You can open/save documents remotely per CMIS (File > Save Remote...). The
dialog allows to configure a wide range of connections including WebDav to
Nextcloud. And of course you may open files on NC with LibreOffice Online. 

Please reopen in case I missed the point.

https://help.libreoffice.org/latest/en-US/text/shared/guide/cmis-remote-files-setup.html
https://help.libreoffice.org/latest/en-US/text/shared/guide/digitalsign_receive.html


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98360
[Bug 98360] [META] CMIS bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 124297] Libreoffice does not recognize Amazon Corretto Java Runtime

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124297

Xisco Faulí  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147797] Changing Slide Master in presentation does not take into account slide layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147797

--- Comment #37 from Pedro  ---
(In reply to Cor Nouws from comment #36)
> Hi Pedro, *,
> 
> I worked on trying to untangle the various issues around layouts and master
> slides.
> There are only three categories:
> 
> =1= Make slide Layouts editable; allow to create custom slide Layouts
> (see bug 78156)
> 
> =2= Allow to assign Layouts to Master Slides, effectively creating a new
> "Master Slide+Layout combination" for presentations in Impress
> (bug 62332 - this one is a duplicate of that one)
> 
> =3= Make another layout available by default
> Example of that category: [FORMATTING] there is no slide layout 'Comparison'
> available (bug 147289)
> 
> *** This bug has been marked as a duplicate of bug 62332 ***

I didn't understand... You are condensing submitted bug reports about these
issues or are you saying that you submitted code to fix the issues?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148363] FILEOPEN: RTF: Incorrect char color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148363

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Xisco Faulí  ---
Actually this is fixed in master by
https://cgit.freedesktop.org/libreoffice/core/commit/?id=494020efe6d29bc319c3abcd3245425e394674ec
Closing as duplicated of bug 131234

*** This bug has been marked as a duplicate of bug 131234 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123727] PIVOTTABLE Allow use of text columns as Data Fields

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123727

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #4 from Heiko Tietze  ---
I'm still having trouble to follow the use case.

Using something like
 
One  =rand()
One  =rand()
One  =rand()
Two  =rand()
Two  =rand()
Two  =rand()
etc.

works nicely with colA as category in the pivot table. And I cannot wrap my
mind around text as data field: What is the sum of colA?

The request on ask.libreoffice looks rather as if you try to merge two
datasets. There are other methods.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 123727] PIVOTTABLE Allow use of text columns as Data Fields

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123727

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #4 from Heiko Tietze  ---
I'm still having trouble to follow the use case.

Using something like
 
One  =rand()
One  =rand()
One  =rand()
Two  =rand()
Two  =rand()
Two  =rand()
etc.

works nicely with colA as category in the pivot table. And I cannot wrap my
mind around text as data field: What is the sum of colA?

The request on ask.libreoffice looks rather as if you try to merge two
datasets. There are other methods.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148413] Non-ASCII image names are encoded wrong when saved as HTML

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148413

--- Comment #2 from Mike Kaganski  ---
Created attachment 179340
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179340=edit
Screenshot of the related options page.

In comment 1, #2 (officecfg.Office.Common/Filter/HTML/Export/Encoding
configuration) is defined in Options->Load/Save-?HTML Compatibility. The
workaround is to set UTF-8 there manually.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141479] Enable sheet protection when sharing a spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141479

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Heiko Tietze  ---
How do you know if the document is being shared? Do you save remotely? Please
describe your workflow a bit more detailed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 141479] Enable sheet protection when sharing a spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141479

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Heiko Tietze  ---
How do you know if the document is being shared? Do you save remotely? Please
describe your workflow a bit more detailed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148390] Navigator shows hidden tables, but no way to make those visible (if existing)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148390

Heiko Tietze  changed:

   What|Removed |Added

 CC||rayk...@gmail.com

--- Comment #2 from Heiko Tietze  ---
No idea how you achieved this. To my knowledge, the only way to hide a table
(and any other object) is via sections. In the document it rather looks like
remains from a crash or the like- there are also some inaccessible fields, and
deleting all content has no effect on the items.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144585] button popups don't open with KF5 VCL on Wayland

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144585

--- Comment #27 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fbf739198aa7f02975d531521c6525073783c7f1

tdf#144585 Qt fix Wayland LO fake popups

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/inc vcl/qt5

[Jan-Marek Glogowski (via logerrit)]

 vcl/inc/qt5/QtFrame.hxx |1 
 vcl/qt5/QtFrame.cxx |   77 ++--
 vcl/qt5/QtWidget.cxx|8 +---
 3 files changed, 13 insertions(+), 73 deletions(-)

New commits:
commit fbf739198aa7f02975d531521c6525073783c7f1
Author: Jan-Marek Glogowski 
AuthorDate: Mon Apr 4 18:02:28 2022 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Wed Apr 6 09:52:11 2022 +0200

tdf#144585 Qt fix Wayland LO fake popups

So Michael Weghorn was somehow reminded of an abandoned
commit from me ("Qt5 rework parent handling") archived in
https://gerrit.libreoffice.org/c/core/+/73463.

The bug introducing the new QWidget parenting, tdf#145363, was
resolved in a better way by explicitly setting parents for the
modal dialogs, so LO doesn't break Qt anymore. The actual problem
is, that an additional modal dialog needs to be stacked to the
previous modal dialog; no "parallel" modal dialogs are allowed,
which my original fix tried to enforce by reparenting.

Then there is the problem with Qt::Popup's focus grabbing on show,
which breaks LO's editable ComboBox. So LO's popup / FLOAT windows
are mapped to Qt::ToolTip, which are automatically advertised as
tooltips via accessibility. For X11 / xcb, Qt:Window with the
Qt::BypassWindowManagerHint works well enough as an alternative,
but WASM and Wayland don't seem to implement it correctly, so this
just handles popups as Qt::ToolTip on all platforms.

This reverts commit b00a68a8e19370e106cd76258a3c1825f43613ee
("tdf#145363 Qt reparent modal dialogs on show").
In addition the popup widgets are switched back to Qt::ToolTip.

Change-Id: If726771b4e9cc3f639f21cf502b3ec5985873643
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132526
Reviewed-by: Jan-Marek Glogowski 
Reviewed-by: Michael Weghorn 
Tested-by: Jenkins

diff --git a/vcl/inc/qt5/QtFrame.hxx b/vcl/inc/qt5/QtFrame.hxx
index 9aa31504bcd3..c6edaa58304d 100644
--- a/vcl/inc/qt5/QtFrame.hxx
+++ b/vcl/inc/qt5/QtFrame.hxx
@@ -132,7 +132,6 @@ class VCLPLUG_QT_PUBLIC QtFrame : public QObject, public 
SalFrame
 int menuBarOffset() const;
 
 void fixICCCMwindowGroup();
-void modalReparent(bool bVisible);
 
 public:
 QtFrame(QtFrame* pParent, SalFrameStyleFlags nSalFrameStyle, bool 
bUseCairo);
diff --git a/vcl/qt5/QtFrame.cxx b/vcl/qt5/QtFrame.cxx
index 6c2e4757f84a..2e396fa8ce07 100644
--- a/vcl/qt5/QtFrame.cxx
+++ b/vcl/qt5/QtFrame.cxx
@@ -147,15 +147,14 @@ QtFrame::QtFrame(QtFrame* pParent, SalFrameStyleFlags 
nStyle, bool bUseCairo)
 aWinFlags = Qt::Tool | Qt::FramelessWindowHint;
 else if (nStyle & SalFrameStyleFlags::TOOLTIP)
 aWinFlags = Qt::ToolTip;
-// Can't use Qt::Popup, because it grabs the input focus and generates
-// a focus-out event, reaching the combo box. This used to map to
-// Qt::ToolTip, which doesn't feel that correct...
+// Can't use Qt::Popup, because it grabs the input focus and generates 
a focus-out event,
+// instantly auto-closing the LO's editable ComboBox popup.
+// On X11, the alternative Qt::Window | Qt::FramelessWindowHint | 
Qt::BypassWindowManagerHint
+// seems to work well enough, but at least on Wayland and WASM, this 
results in problems.
+// So while using Qt::ToolTip, the popups are wrongly advertised via 
accessibility, at least
+// the GUI seems to work on all platforms... what a mess.
 else if (isPopup())
-#ifdef EMSCRIPTEN
 aWinFlags = Qt::ToolTip | Qt::FramelessWindowHint;
-#else
-aWinFlags = Qt::Window | Qt::FramelessWindowHint | 
Qt::BypassWindowManagerHint;
-#endif
 else if (nStyle & SalFrameStyleFlags::TOOLWINDOW)
 aWinFlags = Qt::Tool;
 // top level windows can't be transient in Qt, so make them dialogs, 
if they have a parent. At least
@@ -170,7 +169,7 @@ QtFrame::QtFrame(QtFrame* pParent, SalFrameStyleFlags 
nStyle, bool bUseCairo)
 if (aWinFlags == Qt::Window)
 {
 m_pTopLevel = new QtMainWindow(*this, aWinFlags);
-m_pQWidget = new QtWidget(*this, aWinFlags);
+m_pQWidget = new QtWidget(*this);
 m_pTopLevel->setCentralWidget(m_pQWidget);
 m_pTopLevel->setFocusProxy(m_pQWidget);
 }
@@ -425,42 +424,6 @@ void QtFrame::DrawMenuBar() { /* not needed */}
 
 void QtFrame::SetExtendedFrameStyle(SalExtStyle /*nExtStyle*/) { /* not needed 
*/}
 
-void QtFrame::modalReparent(bool bVisible)
-{
-#ifndef NDEBUG
-auto* pSalInst(GetQtInstance());
-assert(pSalInst);
-assert(pSalInst->IsMainThread());
-assert(!asChild()->isVisible());
-assert(asChild()->isModal());
-#endif
-
-if (!bVisible)
-{
-QWidget* pNewParent = m_pParent ? m_pParent->asChild() : nullptr;
-if (pNewParent != m_pQWidget->parent())
-m_pQWidget->setParent(pNewParent, 

[Libreoffice-bugs] [Bug 144585] button popups don't open with KF5 VCL on Wayland

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144585

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.2.2|target:7.2.2 target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/inc sw/source

[Miklos Vajna (via logerrit)]

 sw/inc/viscrs.hxx|5 ++
 sw/source/core/crsr/crsrsh.cxx   |2 +
 sw/source/core/crsr/viscrs.cxx   |   78 +++
 sw/source/core/txtnode/ndtxt.cxx |1 
 4 files changed, 86 insertions(+)

New commits:
commit c2999f9f3e0efa04f89055399f2d176c9c95e92d
Author: Miklos Vajna 
AuthorDate: Wed Apr 6 08:40:31 2022 +0200
Commit: Miklos Vajna 
CommitDate: Wed Apr 6 09:49:36 2022 +0200

sw content controls: add overlay to render a border around the text portions

- introduce SwSelPaintRects::HighlightContentControl() to create the
  overlay

- use GetTextAttrAt() to enable this when we're inside a content control
  (not only when the cursor is exactly at the dummy char of the content
  control, which is at the start)

- tested that this works correctly even if the portions inside the
  content control don't have the same height (similar to the selection
  overlay)

Change-Id: I1db51cdb1ddc87c45740cd8677de645dc8906697
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132618
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/inc/viscrs.hxx b/sw/inc/viscrs.hxx
index 6755b548e8a0..2eb2f787fbc7 100644
--- a/sw/inc/viscrs.hxx
+++ b/sw/inc/viscrs.hxx
@@ -84,8 +84,11 @@ class SwSelPaintRects : public SwRects
 
 bool m_bShowTextInputFieldOverlay;
 std::unique_ptr 
m_pTextInputFieldOverlay;
+bool m_bShowContentControlOverlay;
+std::unique_ptr 
m_pContentControlOverlay;
 
 void HighlightInputField();
+void HighlightContentControl();
 
 public:
 SwSelPaintRects( const SwCursorShell& rCSh );
@@ -108,6 +111,8 @@ public:
 m_bShowTextInputFieldOverlay = bShow;
 }
 
+void SetShowContentControlOverlay(const bool bShow) { 
m_bShowContentControlOverlay = bShow; }
+
 const SwCursorShell* GetShell() const { return m_pCursorShell; }
 // check current MapMode of the shell and set possibly the static members.
 // Optional set the parameters pX, pY
diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index eb5caf60a0ab..ebb15bec6107 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -2402,6 +2402,7 @@ void SwCursorShell::ShowCursor()
 
 m_bSVCursorVis = true;
 m_pCurrentCursor->SetShowTextInputFieldOverlay( true );
+m_pCurrentCursor->SetShowContentControlOverlay(true);
 
 if (comphelper::LibreOfficeKit::isActive())
 {
@@ -2422,6 +2423,7 @@ void SwCursorShell::HideCursor()
 // possibly reverse selected areas!!
 CurrShell aCurr( this );
 m_pCurrentCursor->SetShowTextInputFieldOverlay( false );
+m_pCurrentCursor->SetShowContentControlOverlay(false);
 m_pVisibleCursor->Hide();
 
 if (comphelper::LibreOfficeKit::isActive())
diff --git a/sw/source/core/crsr/viscrs.cxx b/sw/source/core/crsr/viscrs.cxx
index 0501162a2a16..d72289bdbb36 100644
--- a/sw/source/core/crsr/viscrs.cxx
+++ b/sw/source/core/crsr/viscrs.cxx
@@ -59,6 +59,7 @@
 #include 
 #include 
 #include 
+#include 
 
 // Here static members are defined. They will get changed on alteration of the
 // MapMode. This is done so that on ShowCursor the same size does not have to 
be
@@ -350,6 +351,7 @@ SwSelPaintRects::SwSelPaintRects( const SwCursorShell& rCSh 
)
 : m_pCursorShell(  )
 #if HAVE_FEATURE_DESKTOP
 , m_bShowTextInputFieldOverlay(true)
+, m_bShowContentControlOverlay(true)
 #endif
 {
 }
@@ -368,6 +370,8 @@ void SwSelPaintRects::swapContent(SwSelPaintRects& rSwap)
 std::swap(m_pCursorOverlay, rSwap.m_pCursorOverlay);
 std::swap(m_bShowTextInputFieldOverlay, 
rSwap.m_bShowTextInputFieldOverlay);
 std::swap(m_pTextInputFieldOverlay, rSwap.m_pTextInputFieldOverlay);
+std::swap(m_bShowContentControlOverlay, 
rSwap.m_bShowContentControlOverlay);
+std::swap(m_pContentControlOverlay, rSwap.m_pContentControlOverlay);
 #endif
 }
 
@@ -376,6 +380,7 @@ void SwSelPaintRects::Hide()
 #if HAVE_FEATURE_DESKTOP
 m_pCursorOverlay.reset();
 m_pTextInputFieldOverlay.reset();
+m_pContentControlOverlay.reset();
 #endif
 
 SwRects::clear();
@@ -466,6 +471,7 @@ void SwSelPaintRects::Show(std::vector* 
pSelectionRectangles)
 }
 
 HighlightInputField();
+HighlightContentControl();
 #endif
 
 // Tiled editing does not expose the draw and writer cursor, it just
@@ -625,6 +631,78 @@ void SwSelPaintRects::HighlightInputField()
 }
 }
 
+void SwSelPaintRects::HighlightContentControl()
+{
+std::vector aContentControlRanges;
+
+if (m_bShowContentControlOverlay)
+{
+const SwPosition* pStart = GetShell()->GetCursor()->Start();
+SwTextNode* pTextNode = pStart->nNode.GetNode().GetTextNode();
+SwTextContentControl* pCurContentControlAtCursor = nullptr;
+if (pTextNode)
+{
+// SwTextNode::PARENT because this way we highlight when the 
cursor is on the right side
+// of the dummy 

[Libreoffice-bugs] [Bug 148393] LibreOffice not launch due to Skia

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148393

--- Comment #4 from fl  ---
Sorry i just try to help LibreOffice.
But i see, i bother, no problem you can close because i have find workaround.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148413] Non-ASCII image names are encoded wrong when saved as HTML

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148413

--- Comment #1 from Mike Kaganski  ---
Relevant:

1. SwHTMLWriter::WriteStream [1], which initializes m_eDestEnc using
SvxHtmlOptions::GetTextEncoding [2];
2. officecfg.Office.Common/Filter/HTML/Export/Encoding configuration value,
which is void by default, and is not editable until commit
7c5ca44c48b05ba73defd48057a82db7dc833e0c [3];
3. Thread encoding, used in SvtSysLocale::GetBestMimeEncoding [4], which is
~always non-UTF-8 on Windows;
4. HtmlWriter::attribute [5], using fixed UTF-8 encoding, and so unsynchronized
with #1;
5. Other places that write strings (like HtmlWriterHelper::applyColor [6],
which is used in Writer's HTML filter), which also use UTF-8 unconditionally.

It seems that the best option would be to use UTF-8 unconditionally in #1, and
just drop (ignore) #2 and #3.

[1]
https://opengrok.libreoffice.org/xref/core/sw/source/filter/html/wrthtml.cxx?r=5de24375#342
[2]
https://opengrok.libreoffice.org/xref/core/svtools/source/config/htmlcfg.cxx?r=96e3a641#93
[3] https://git.libreoffice.org/core/+/7c5ca44c48b05ba73defd48057a82db7dc833e0c
[4]
https://opengrok.libreoffice.org/xref/core/unotools/source/misc/syslocale.cxx?r=55adeb1c#177
[5]
https://opengrok.libreoffice.org/xref/core/svtools/source/svhtml/HtmlWriter.cxx?r=ad1557f5#153
[6]
https://opengrok.libreoffice.org/xref/core/svtools/source/svhtml/htmlout.cxx?r=96e3a641#981

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145803] LibreOffice from 7.2 only opens in Safe Mode, UI render default no Skia on Windows 10 and 11

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145803

Timur  changed:

   What|Removed |Added

 CC||florent.lagoda@univ-rennes2
   ||.fr

--- Comment #14 from Timur  ---
*** Bug 148393 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148393] LibreOffice not launch due to Skia

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148393

Timur  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Timur  ---
You didn't attach a log. 
This is rather poor report for IT pro with many computers on a department.
You didn't say which LO version doesn't work, seen only in Ask as 7.2.6, if you
guess with messed up links. You didn't say initially which OS.
Worse, you seem like not searched for existing bugs.
I mark duplicate.

*** This bug has been marked as a duplicate of bug 145803 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148393] LibreOffice not launch due to Skia

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148393

--- Comment #2 from fl  ---
We are an university and on a room with same model, not happen on all
computers.
Last seen have this :
-Model Dell Optiplex 7060
-Intel UHD Graphic 630 with last driver from Dell
-Windows 10.0.19044

Workaround we have set everywhere on the
%APPDATA%\LibreOffice\4\user\registrymodifications.xcu

false

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138957] Print automatically inserted blank pages should be turned off by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138957

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=81
   ||814

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 81814] UI: Add 'Print automatically inserted blank pages' icon in Print Preview instant toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81814

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||8957

--- Comment #8 from Timur  ---
This is on my personal High priority list.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/qa writerfilter/source

[Vasily Melenchuk (via logerrit)]

 sw/qa/extras/ooxmlexport/data/tdf148361.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport17.cxx   |   16 
 writerfilter/source/dmapper/SdtHelper.cxx|   20 ++--
 writerfilter/source/dmapper/SdtHelper.hxx|3 +++
 4 files changed, 33 insertions(+), 6 deletions(-)

New commits:
commit 2d1bd913d9f896d55c03dd509eb11c81667c5436
Author: Vasily Melenchuk 
AuthorDate: Mon Apr 4 18:05:18 2022 +0300
Commit: Xisco Fauli 
CommitDate: Wed Apr 6 09:34:49 2022 +0200

tdf#148361: docx sdt: cleanup databinding data after inserting

Databinding data is used only for current sdt block. It should
be clean up after usage to avoid impact on next sdt blocks.

Change-Id: I53f47dd655ed027d40eb518784dcae69813e612f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132524
Tested-by: Jenkins
Tested-by: Xisco Fauli 
Reviewed-by: Vasily Melenchuk 
(cherry picked from commit fafadd7aee8c384af210008f693b5007a9f5ea48)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132595
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf148361.docx 
b/sw/qa/extras/ooxmlexport/data/tdf148361.docx
new file mode 100644
index ..ecf9a5f0087c
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf148361.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
index 370989a9d6b7..51f0d9fb9345 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
@@ -143,6 +143,22 @@ DECLARE_OOXMLEXPORT_TEST(testTdf123642_BookmarkAtDocEnd, 
"tdf123642.docx")
 CPPUNIT_ASSERT_EQUAL(OUString("Bookmark1"), getXPath(pXmlDoc, 
"/w:document/w:body/w:p[2]/w:bookmarkStart[1]", "name"));
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf148361, "tdf148361.docx")
+{
+// Refresh fields and ensure cross-reference to numbered para is okay
+uno::Reference xTextFieldsSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xFieldsAccess(xTextFieldsSupplier->getTextFields());
+
+uno::Reference 
xFields(xFieldsAccess->createEnumeration());
+CPPUNIT_ASSERT(xFields->hasMoreElements());
+
+uno::Reference xTextField1(xFields->nextElement(), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString("itadmin"), 
xTextField1->getPresentation(false));
+
+uno::Reference xTextField2(xFields->nextElement(), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString("[Type text]"), 
xTextField2->getPresentation(false));
+}
+
 DECLARE_OOXMLEXPORT_TEST(testTdf142407, "tdf142407.docx")
 {
 uno::Reference xPageStyles = 
getStyles("PageStyles");
diff --git a/writerfilter/source/dmapper/SdtHelper.cxx 
b/writerfilter/source/dmapper/SdtHelper.cxx
index 576d63d430c6..f4b02fab4d02 100644
--- a/writerfilter/source/dmapper/SdtHelper.cxx
+++ b/writerfilter/source/dmapper/SdtHelper.cxx
@@ -264,8 +264,7 @@ void SdtHelper::createDropDownControl()
 }
 
 // clean up
-m_aDropDownItems.clear();
-setControlType(SdtControlType::unknown);
+clear();
 }
 
 void SdtHelper::createPlainTextControl()
@@ -296,8 +295,7 @@ void SdtHelper::createPlainTextControl()
uno::makeAny(getInteropGrabBagAndClear()));
 
 // clean up
-m_aDropDownItems.clear();
-setControlType(SdtControlType::unknown);
+clear();
 }
 
 void SdtHelper::createDateContentControl()
@@ -372,11 +370,11 @@ void SdtHelper::createDateContentControl()
 uno::UNO_QUERY);
 xRefreshable->refresh();
 
-setControlType(SdtControlType::unknown);
-
 // Store all unused sdt parameters from grabbag
 xNameCont->insertByName(UNO_NAME_MISC_OBJ_INTEROPGRABBAG,
 uno::makeAny(getInteropGrabBagAndClear()));
+
+clear();
 }
 
 void SdtHelper::createControlShape(awt::Size aSize,
@@ -423,6 +421,16 @@ bool SdtHelper::containedInInteropGrabBag(const OUString& 
rValueName)
 [](const beans::PropertyValue& i) { return i.Name == 
rValueName; });
 }
 
+void SdtHelper::clear()
+{
+m_aDropDownItems.clear();
+setControlType(SdtControlType::unknown);
+m_sDataBindingPrefixMapping.clear();
+m_sDataBindingXPath.clear();
+m_sDataBindingStoreItemID.clear();
+m_aGrabBag.clear();
+}
+
 } // namespace writerfilter::dmapper
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/SdtHelper.hxx 
b/writerfilter/source/dmapper/SdtHelper.hxx
index e58d73168d79..d9a6115a1251 100644
--- a/writerfilter/source/dmapper/SdtHelper.hxx
+++ b/writerfilter/source/dmapper/SdtHelper.hxx
@@ -102,6 +102,9 @@ class SdtHelper final : public virtual SvRefBase
 
 void loadPropertiesXMLs();
 
+/// Clear all collected attributes for futher reuse
+void clear();
+
 public:
 explicit SdtHelper(DomainMapper_Impl& rDM_Impl,
css::uno::Reference const& 
xContext);

[Libreoffice-bugs] [Bug 144003] EDITING: When full-width character punctuation mark after the half-width character in vertical writing, the full-width character punctuation mark is rotated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144003

JO3EMC  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |8257|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148257] Missing/unexposed ability to explicitly set the "language group" of a piece of text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148257

JO3EMC  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |4003|

--- Comment #9 from JO3EMC  ---
I'm sorry.
In Bug 144003, the automatic recognition of language groups does not seem to be
wrong.
It seemed that the handling of punctuation marks was just strange.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148257] Missing/unexposed ability to explicitly set the "language group" of a piece of text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148257

JO3EMC  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |4003|

--- Comment #9 from JO3EMC  ---
I'm sorry.
In Bug 144003, the automatic recognition of language groups does not seem to be
wrong.
It seemed that the handling of punctuation marks was just strange.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148325] Writer 7.3.2 will only print 1 blank page even if preview shows 3 pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148325

Timur  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Timur  ---
Please attach the document. Did you try to print to PDF and also export to PDF?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148381] closing the print preview page - with the X, too :)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148381

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Heiko Tietze  ---
(In reply to V Stuart Foote from comment #1)
> ...the 'Print Preview' is just a Toolbar, not an app frame
> ...
> Just don't see much need for the work it would require-- or the current
> button suffice.  IMHO => WF

Fully agree. No inconsistency here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148381] closing the print preview page - with the X, too :)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148381

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Heiko Tietze  ---
(In reply to V Stuart Foote from comment #1)
> ...the 'Print Preview' is just a Toolbar, not an app frame
> ...
> Just don't see much need for the work it would require-- or the current
> button suffice.  IMHO => WF

Fully agree. No inconsistency here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 144003] EDITING: When full-width character punctuation mark after the half-width character in vertical writing, the full-width character punctuation mark is rotated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144003

JO3EMC  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||8257

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148257] Missing/unexposed ability to explicitly set the "language group" of a piece of text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148257

JO3EMC  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||4003

--- Comment #8 from JO3EMC  ---
After that, I noticed ...
The Bug 144003 issue in Japanese may be related to this issue.
In vertical writing (RTL), Japanese characters are automatically recognized in
the wrong language group when Western characters are followed by punctuation
marks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148257] Missing/unexposed ability to explicitly set the "language group" of a piece of text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148257

JO3EMC  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||4003

--- Comment #8 from JO3EMC  ---
After that, I noticed ...
The Bug 144003 issue in Japanese may be related to this issue.
In vertical writing (RTL), Japanese characters are automatically recognized in
the wrong language group when Western characters are followed by punctuation
marks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 120255] [META] Base feature enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120255
Bug 120255 depends on bug 140267, which changed state.

Bug 140267 Summary: Improve primary key creation when creating/importing a table
https://bugs.documentfoundation.org/show_bug.cgi?id=140267

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 140267] Improve primary key creation when creating/importing a table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140267

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 140267] Improve primary key creation when creating/importing a table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140267

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148414] "View > Show Whitespace" Does Not Update With Page Size Change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148414

--- Comment #3 from Tex2002ans  ---
Created attachment 179339
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179339=edit
After Step 5+6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148414] "View > Show Whitespace" Does Not Update With Page Size Change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148414

--- Comment #2 from Tex2002ans  ---
Created attachment 179338
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179338=edit
After Step 4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139605] The content of some math formulas disappear while writing at other location in Writer document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139605

--- Comment #8 from Ethan Bentley  ---
That is the manner by which PhD Dissertation Help works! Is it safe to say that
you are looking for specialists, 100 consented, errors free and 100 non-copied
PhD Discussion to help the United region? Why never again article
administrations of PhD Dissertation Help, who give one of the great quality
instructive writing administrations simultaneously as ensuring each
conversation is composed through master and maintained local pens and
validation study through its pukka proof abstracts to convey an errors loosened
and gathered paper.
For more details, visit https://phddissertationhelp.uk

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148414] "View > Show Whitespace" Does Not Update With Page Size Change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148414

--- Comment #1 from Tex2002ans  ---
Created attachment 179337
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179337=edit
Test.Show.Whitespace.Page.Breaks

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148414] New: "View > Show Whitespace" Does Not Update With Page Size Change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148414

Bug ID: 148414
   Summary: "View > Show Whitespace" Does Not Update With Page
Size Change
   Product: LibreOffice
   Version: 7.3.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tex2002ans+libreoff...@gmail.com

Description:
If "View > Show Whitespace" is OFF, changing the page size does not generate
new page breaks.

You have to toggle the option ON/OFF to get updated page breaks.

Steps to Reproduce:
1. Open Attached ODT.
2. View > Show Whitespace (toggle it OFF)
3. Format > Page Style
4. Change Height from 11.00" to 5.00".

Notice new page breaks do not appear.

5. Toggle View > Show Whitespace (ON).
6. Toggle View > Show Whitespace (OFF).

See page breaks are now visible in proper locations.

Actual Results:
After Step 4, nothing changes.

Expected Results:
After Step 4, the new page breaks should appear.

Shouldn't matter whether "Show Whitespace" is ON or OFF initially.

- Step 1 -> OFF, 3, 4, ON, OFF

should be exactly like:

- Step 1 -> 3, 4, OFF


Reproducible: Always


User Profile Reset: No



Additional Info:
I marked the location of page breaks with text:

- There is a forced page break after this.
- Should be final line on page 2.
- Should be final line on page 3.

After Step 6, there should be visible line breaks after each of those lines.

-- 
You are receiving this mail because:
You are the assignee for the bug.