[Libreoffice-bugs] [Bug 149407] Proposal for slight change in position and label of controls in the Position dialog for objects
https://bugs.documentfoundation.org/show_bug.cgi?id=149407 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org --- Comment #16 from Heiko Tietze --- We discussed this topic in the design meeting. Changing "to" to "of" might be good for some but not all scenarios (for instance 'left of the entire page' is not the same as 'to'). It opens a chain of patches and has no clear benefit for understandability. The proposed rearrangement of controls fails or might be inappropriate for other languages than English and also wont make the functionality easier to understand. The recommendation is to leave the dialog as it is (=> WF), but no strong objection if volunteers want to change it (keeping UNCONF therefore). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149407] Proposal for slight change in position and label of controls in the Position dialog for objects
https://bugs.documentfoundation.org/show_bug.cgi?id=149407 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org --- Comment #16 from Heiko Tietze --- We discussed this topic in the design meeting. Changing "to" to "of" might be good for some but not all scenarios (for instance 'left of the entire page' is not the same as 'to'). It opens a chain of patches and has no clear benefit for understandability. The proposed rearrangement of controls fails or might be inappropriate for other languages than English and also wont make the functionality easier to understand. The recommendation is to leave the dialog as it is (=> WF), but no strong objection if volunteers want to change it (keeping UNCONF therefore). -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: editeng/inc editeng/source include/editeng
editeng/inc/AccessibleStringWrap.hxx|2
editeng/inc/editdoc.hxx |4 -
editeng/source/accessibility/AccessibleContextBase.cxx |4 -
editeng/source/accessibility/AccessibleEditableTextPara.cxx |5 +
editeng/source/accessibility/AccessibleImageBullet.cxx |5 +
editeng/source/accessibility/AccessibleImageBullet.hxx |2
editeng/source/accessibility/AccessibleStringWrap.cxx |5 +
editeng/source/editeng/editdoc.cxx |9 +--
editeng/source/editeng/editundo.cxx | 35 ++--
editeng/source/editeng/editundo.hxx | 16 ++---
editeng/source/editeng/eehtml.cxx |5 +
editeng/source/editeng/eehtml.hxx |2
editeng/source/editeng/impedit.hxx |2
editeng/source/editeng/impedit5.cxx |5 +
editeng/source/items/CustomPropertyField.cxx|7 +-
editeng/source/items/flditem.cxx|5 +
editeng/source/items/frmitems.cxx |7 +-
editeng/source/items/textitem.cxx |9 +--
editeng/source/misc/SvXMLAutoCorrectImport.cxx |6 +-
editeng/source/misc/SvXMLAutoCorrectImport.hxx |2
editeng/source/misc/forbiddencharacterstable.cxx|5 +
editeng/source/misc/svxacorr.cxx| 17 +++--
editeng/source/misc/unolingu.cxx|5 +
editeng/source/outliner/overflowingtxt.cxx |5 +
editeng/source/uno/UnoForbiddenCharsTable.cxx |5 +
editeng/source/uno/unofield.cxx |5 +
editeng/source/uno/unonrule.cxx |5 +
editeng/source/xml/xmltxtimp.cxx| 13 ++--
include/editeng/AccessibleContextBase.hxx |2
include/editeng/AccessibleEditableTextPara.hxx |2
include/editeng/CustomPropertyField.hxx |2
include/editeng/UnoForbiddenCharsTable.hxx |2
include/editeng/brushitem.hxx |2
include/editeng/editstat.hxx|5 +
include/editeng/flditem.hxx |2
include/editeng/fontitem.hxx|4 -
include/editeng/forbiddencharacterstable.hxx|2
include/editeng/outliner.hxx|5 +
include/editeng/overflowingtxt.hxx |2
include/editeng/svxacorr.hxx| 13 ++--
include/editeng/swafopt.hxx |3 -
include/editeng/unofield.hxx|2
include/editeng/unolingu.hxx|2
include/editeng/unonrule.hxx|2
44 files changed, 137 insertions(+), 112 deletions(-)
New commits:
commit 91fef4a47563451e0271784a14b471e4815729d1
Author: Noel Grandin
AuthorDate: Wed Jun 8 15:53:34 2022 +0200
Commit: Noel Grandin
CommitDate: Thu Jun 9 07:56:10 2022 +0200
clang-tidy modernize-pass-by-value in editeng
Change-Id: Ibf912c597896a2ac0bf3ba8108f55c5018115bb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135501
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/editeng/inc/AccessibleStringWrap.hxx
b/editeng/inc/AccessibleStringWrap.hxx
index 5281becdde61..f3888fd67d27 100644
--- a/editeng/inc/AccessibleStringWrap.hxx
+++ b/editeng/inc/AccessibleStringWrap.hxx
@@ -35,7 +35,7 @@ class AccessibleStringWrap
{
public:
-AccessibleStringWrap( OutputDevice& rDev, SvxFont& rFont, const OUString&
rText );
+AccessibleStringWrap( OutputDevice& rDev, SvxFont& rFont, OUString aText );
void GetCharacterBounds( sal_Int32 nIndex, tools::Rectangle& rRect );
sal_Int32 GetIndexAtPoint( const Point& rPoint );
diff --git a/editeng/inc/editdoc.hxx b/editeng/inc/editdoc.hxx
index 5242a61a73f0..12532fde7e73 100644
--- a/editeng/inc/editdoc.hxx
+++ b/editeng/inc/editdoc.hxx
@@ -117,7 +117,7 @@ private:
CharAttribsType aPrevCharAttribs;
public:
-ContentAttribsInfo( const SfxItemSet& rParaAttribs );
+ContentAttribsInfo( SfxItemSet aParaAttribs );
const SfxItemSet& GetPrevParaAttribs() const { return
aPrevParaAttribs; }
const CharAttribsType& GetPrevCharAttribs() const { return
aPrevCharAttribs; }
@@ -244,7 +244,7 @@ private:
public:
ContentNode( SfxItemPool& rItemPool );
-ContentNode( const OUString& rStr, const ContentAttribs&
rContentAttribs );
+ContentNode( OUString aStr, ContentAttribs
[Libreoffice-bugs] [Bug 126658] Arrow Style modification workflow is unclear
https://bugs.documentfoundation.org/show_bug.cgi?id=126658 Heiko Tietze changed: What|Removed |Added Depends on|149414 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149414 [Bug 149414] Change submenu label for formatting textboxes and shapes in Calc and Impress -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149414] Change submenu label for formatting textboxes and shapes in Calc and Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=149414 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | Ever confirmed|0 |1 Blocks|126658 | Status|UNCONFIRMED |NEW --- Comment #5 from Heiko Tietze --- We discussed the topic in the design meeting. The need to change this becomes obvious after comparing Insert > OLE Object with Format > Object, which are different functions. The proposed "Text Box and Shape" sounds good. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126658 [Bug 126658] Arrow Style modification workflow is unclear -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149414] Change submenu label for formatting textboxes and shapes in Calc and Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=149414 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | Ever confirmed|0 |1 Blocks|126658 | Status|UNCONFIRMED |NEW --- Comment #5 from Heiko Tietze --- We discussed the topic in the design meeting. The need to change this becomes obvious after comparing Insert > OLE Object with Format > Object, which are different functions. The proposed "Text Box and Shape" sounds good. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126658 [Bug 126658] Arrow Style modification workflow is unclear -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 103428] [META] Properties deck/tab of the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=103428 Heiko Tietze changed: What|Removed |Added Depends on||149411 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149411 [Bug 149411] Improve Columns deck at the sidebar -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149411] Improve Columns deck at the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=149411 Heiko Tietze changed: What|Removed |Added Keywords||difficultyMedium, easyHack, ||skillCpp, topicUI Ever confirmed|0 |1 Severity|minor |enhancement Whiteboard|NeedsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org, ||mentoring@documentfoundatio ||n.org Summary|It's difficult to reach |Improve Columns deck at the |text area properties|sidebar Blocks|100373 |103428 Status|UNCONFIRMED |NEW --- Comment #6 from Heiko Tietze --- Yes, this topic has been discussed in the design meeting. We have a deck "Columns" in the sidebar, which is part of the text attributes. So the recommendation is to rename this deck into "Text" (or "Text Attributes"), add the "Fit height/width" options, and provide full access to the properties via the deck master interaction (top-right button). Some code pointers svx/uiconfig/ui/sidebartextcolumnspanel.ui svx/source/sidebar/textcolumns/TextColumnsPropertyPanel.cxx Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100373 [Bug 100373] [META] Style issues in Draw/Impress https://bugs.documentfoundation.org/show_bug.cgi?id=103428 [Bug 103428] [META] Properties deck/tab of the sidebar -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100373] [META] Style issues in Draw/Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=100373 Heiko Tietze changed: What|Removed |Added Depends on|149411 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149411 [Bug 149411] Improve Columns deck at the sidebar -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149411] Improve Columns deck at the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=149411 Heiko Tietze changed: What|Removed |Added Keywords||difficultyMedium, easyHack, ||skillCpp, topicUI Ever confirmed|0 |1 Severity|minor |enhancement Whiteboard|NeedsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org, ||mentoring@documentfoundatio ||n.org Summary|It's difficult to reach |Improve Columns deck at the |text area properties|sidebar Blocks|100373 |103428 Status|UNCONFIRMED |NEW --- Comment #6 from Heiko Tietze --- Yes, this topic has been discussed in the design meeting. We have a deck "Columns" in the sidebar, which is part of the text attributes. So the recommendation is to rename this deck into "Text" (or "Text Attributes"), add the "Fit height/width" options, and provide full access to the properties via the deck master interaction (top-right button). Some code pointers svx/uiconfig/ui/sidebartextcolumnspanel.ui svx/source/sidebar/textcolumns/TextColumnsPropertyPanel.cxx Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100373 [Bug 100373] [META] Style issues in Draw/Impress https://bugs.documentfoundation.org/show_bug.cgi?id=103428 [Bug 103428] [META] Properties deck/tab of the sidebar -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 149297] EDITING: Text selection in vertical text positioned incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=149297 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| --- Comment #1 from Dieter --- I can't confirm it with Version: 7.3.4.1 (x64) / LibreOffice Community Build ID: 13668373362b52f6e3ebcaaecb031bd59a3ac66b CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Could you please retest with actual version of LO 7.3? => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149294] [UI] Function "Select to End of Word" (.uno:WordRightSel) must be renamed, because it also selects spaces and tabs at the right side of word
https://bugs.documentfoundation.org/show_bug.cgi?id=149294 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Resolution|--- |WONTFIX See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9308 Status|UNCONFIRMED |RESOLVED --- Comment #1 from Dieter --- A fix of bug 149308 will make renaiming superfluous => WONTFIX -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149308] CTRL + SHIFT + right-arrow should not select whitespace after word
https://bugs.documentfoundation.org/show_bug.cgi?id=149308 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9294 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149279] better vertical alignment in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=149279 Dieter changed: What|Removed |Added Whiteboard| QA:needsComment| CC||dgp-m...@gmx.de, ||rayk...@gmail.com --- Comment #1 from Dieter --- I confirm the actual behaviour and I support enhancement request Version: 7.3.4.1 (x64) / LibreOffice Community Build ID: 13668373362b52f6e3ebcaaecb031bd59a3ac66b CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Jim, what do you think about it? Is it feasible? Can we change status to NEW? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149195] Edit Database Link: Impossible to change link of a database with there own registered name.
https://bugs.documentfoundation.org/show_bug.cgi?id=149195 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149297] EDITING: Text selection in vertical text positioned incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=149297 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149294] [UI] Function "Select to End of Word" (.uno:WordRightSel) must be renamed, because it also selects spaces and tabs at the right side of word
https://bugs.documentfoundation.org/show_bug.cgi?id=149294 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149284] LO Base freeze when using a form with macro to enter MySQL data
https://bugs.documentfoundation.org/show_bug.cgi?id=149284 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149279] better vertical alignment in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=149279 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149496] Drag content within formula bar doesn't do anything
https://bugs.documentfoundation.org/show_bug.cgi?id=149496 --- Comment #1 from Aron Budea --- (In reply to Aron Budea from comment #0) > 3. Then after the following commit by Noel (bibisected using repo > bibisect-linux-64-7.2), the change from dragged content isn't propagated to > the cell view while still editing the cell, and is lost after finishing cell > editing. > > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=60d35f767781de4b8f1e7b264b12015f655c647d Since that's a 7.2 backport, let's note its 7.3 original as well: https://cgit.freedesktop.org/libreoffice/core/commit/?id=73c9ef661d9ef6237d3fd3c259fd040a545b44cf -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149495] Regressions from "weld InputBar"
https://bugs.documentfoundation.org/show_bug.cgi?id=149495 Aron Budea changed: What|Removed |Added Alias||Regressions-weld-InputBar -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149496] Drag content within formula bar doesn't do anything
https://bugs.documentfoundation.org/show_bug.cgi?id=149496 Aron Budea changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149495] Regressions from "weld InputBar"
https://bugs.documentfoundation.org/show_bug.cgi?id=149495 Aron Budea changed: What|Removed |Added Depends on||149496 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149496 [Bug 149496] Drag content within formula bar doesn't do anything -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149496] New: Drag content within formula bar doesn't do anything
https://bugs.documentfoundation.org/show_bug.cgi?id=149496 Bug ID: 149496 Summary: Drag content within formula bar doesn't do anything Product: LibreOffice Version: 7.1.0.3 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Keywords: bibisected, bisected, regression Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aron.bu...@gmail.com CC: caol...@redhat.com, noelgran...@gmail.com Blocks: 103182, 149495 Created attachment 180645 --> https://bugs.documentfoundation.org/attachment.cgi?id=180645=edit Sample ODS - Open the attached spreadsheet, - Expand formula bar using the triangle button, - Click into the cell that has several lines of text, select a piece of it, and drag it someplace else within the formula bar. => The dragged content is copied to the new place in the formula bar (instead of being moved), but not in the cell view in the sheet, and leaving cell edit mode discards the change. The issue mostly only concerns gtk3 VCL plugin, dragging is fine with gen VCL plugin, but the discarding problem (3. change below) affects both. This changed in several steps. 1. Until this commit, bibisected using repo bibisect-linux-64-7.1 drag moved the selected text as expected. >From this commit, drag in the formula bar stopped working. https://cgit.freedesktop.org/libreoffice/core/commit/?id=e087e25f05e689091cbf1c4f91b6e93878ac17ec author Caolán McNamara 2020-10-05 14:19:05 +0100 committer Caolán McNamara 2020-10-16 12:54:14 +0200 "weld InputBar" 2. This commit (bibisected using repo bibisect-linux-64-7.2) made drag work, but instead of moving content to its new place, it started copying it. https://cgit.freedesktop.org/libreoffice/core/commit/?id=1320afe376bc52bc64995ba976391ec21db6ccde author Caolán McNamara 2021-04-29 09:49:11 +0100 committer Caolán McNamara 2021-04-30 13:41:08 +0200 "allow dnd into weldeditview" 3. Then after the following commit by Noel (bibisected using repo bibisect-linux-64-7.2), the change from dragged content isn't propagated to the cell view while still editing the cell, and is lost after finishing cell editing. https://cgit.freedesktop.org/libreoffice/core/commit/?id=60d35f767781de4b8f1e7b264b12015f655c647d author Noel Grandin 2021-07-06 18:51:38 +0200 committer Noel Grandin 2021-07-08 11:53:49 +0200 "tdf#132740 don't broadcast if modified status has not changed" There also used to be a crash when closing Calc without leaving cell edit mode after dragging, but that seems to have been fixed between 2. and 3. sometimes, maybe it was bug 141769. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103182 [Bug 103182] [META] GTK3-specific bugs https://bugs.documentfoundation.org/show_bug.cgi?id=149495 [Bug 149495] Regressions from "weld InputBar" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Aron Budea changed: What|Removed |Added Depends on||149496 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149496 [Bug 149496] Drag content within formula bar doesn't do anything -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142368] Hint from AutoInput in formula bar stays on top after switching to another application
https://bugs.documentfoundation.org/show_bug.cgi?id=142368 Aron Budea changed: What|Removed |Added Blocks||149495 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149495 [Bug 149495] Regressions from "weld InputBar" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149495] Regressions from "weld InputBar"
https://bugs.documentfoundation.org/show_bug.cgi?id=149495 Aron Budea changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Depends on||137713, 142368, 144166, ||138047, 145248, 141769, ||140498, 138540, 139857, ||138010, 138157 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=137713 [Bug 137713] crash in debug build editing matrix formula https://bugs.documentfoundation.org/show_bug.cgi?id=138010 [Bug 138010] Borderless Calc's formula bar (kf5 VCL only) https://bugs.documentfoundation.org/show_bug.cgi?id=138047 [Bug 138047] Broken focus in Calc after setting cell formula reference https://bugs.documentfoundation.org/show_bug.cgi?id=138157 [Bug 138157] Upon entering edit mode the second time, another cursor appears in the adjacent cell (gtk3) https://bugs.documentfoundation.org/show_bug.cgi?id=138540 [Bug 138540] It moves Formula's tooltip when you type a formula in Formula bar in Calc https://bugs.documentfoundation.org/show_bug.cgi?id=139857 [Bug 139857] Cannot copy text at Formula Bar with mouse https://bugs.documentfoundation.org/show_bug.cgi?id=140498 [Bug 140498] Primary selection does not work in Calc input line https://bugs.documentfoundation.org/show_bug.cgi?id=141769 [Bug 141769] Crash in: cppu::OInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject const &) https://bugs.documentfoundation.org/show_bug.cgi?id=142368 [Bug 142368] Hint from AutoInput in formula bar stays on top after switching to another application https://bugs.documentfoundation.org/show_bug.cgi?id=144166 [Bug 144166] Pixel (or pixels) missing in the Calc Formula Bar https://bugs.documentfoundation.org/show_bug.cgi?id=145248 [Bug 145248] EDITING CELL contents in the contents/formula bar produces unexpected result -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149495] New: Regressions from "weld InputBar"
https://bugs.documentfoundation.org/show_bug.cgi?id=149495 Bug ID: 149495 Summary: Regressions from "weld InputBar" Product: LibreOffice Version: 7.1.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aron.bu...@gmail.com Since there were a couple of these, let's have a META. https://cgit.freedesktop.org/libreoffice/core/commit/?id=e087e25f05e689091cbf1c4f91b6e93878ac17ec author Caolán McNamara 2020-10-05 14:19:05 +0100 committer Caolán McNamara 2020-10-16 12:54:14 +0200 weld InputBar -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130149] Text using the Cantarell font is not printed or PDF exported in Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=130149 --- Comment #26 from Matt Johnson --- I am able to reproduce this bug on Archlinux with the following configuration: libreoffice 7.2.7-2 cantarel-fonts 1:0.303.1-1 The cantarell fonts package is from Gnome's upstream at https://gitlab.gnome.org/GNOME/cantarell-fonts . The package uses a single installed system font with combined styles at /usr/share/fonts/cantarell/Cantarell-VF.otf If I remove this system font, rebuild the font cache, and then install Cantarell from Google Fonts (https://fonts.google.com/specimen/Cantarell) as a set of 4 .ttf files (for regular, bold, italic, and BoldItalic, libreoffice works correctly and is able to render the PDF. Just installing the google font ttf versions alongside the system otf was not sufficient, and still resulted in broken PDF rendering (text in Cantarell is copy-pastable but not visible in the PDF). Let me know if there's any debug information I can help capture to figure out what's going on here. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149483] Copy/Paste of partial cell contents string with hyperlink in recent versions, string with link appears _twice_
https://bugs.documentfoundation.org/show_bug.cgi?id=149483 --- Comment #2 from Rafael Lima --- Repro with Version: 7.4.0.0.alpha1+ / LibreOffice Community Build ID: 118bafcfd1ce4a26ec9df912197ebd466d1bd497 CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL Also repro in gen and gtk3 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149492] With nothing selected, properties sidebar shows "Slide" section
https://bugs.documentfoundation.org/show_bug.cgi?id=149492 --- Comment #4 from Rafael Lima --- Not repro in Version: 7.4.0.0.alpha1+ / LibreOffice Community Build ID: 118bafcfd1ce4a26ec9df912197ebd466d1bd497 CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL With a clean profile and the code updated from master, I only get the Page section in the Properties sidebar. (In reply to Eyal Rozenberg from comment #2) > I will, but - if a non-clean profile causes the sidebar to display a > property section from another module - that's a bug Unfortunately when changes are made to the sidebar, they're only effective after you get a new profile. I have gone through this in the past with other sidebar changes. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149411] It's difficult to reach text area properties
https://bugs.documentfoundation.org/show_bug.cgi?id=149411 --- Comment #5 from Rafael Lima --- (In reply to Eyal Rozenberg from comment #4) > Are we talking about Impress only, or also Draw? Since the Text dialog is identical both in Draw and Impress, these improvements to the Properties sidebar should be implemented for both applications. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149411] It's difficult to reach text area properties
https://bugs.documentfoundation.org/show_bug.cgi?id=149411 --- Comment #5 from Rafael Lima --- (In reply to Eyal Rozenberg from comment #4) > Are we talking about Impress only, or also Draw? Since the Text dialog is identical both in Draw and Impress, these improvements to the Properties sidebar should be implemented for both applications. -- You are receiving this mail because: You are on the CC list for the bug.
Custom Shape Orientation Guide
Hi all, I have been working with custom shapes for quite a while now. Again and again the questions come up "How is the property actually defined in the file format?", "How is the property realized in core?" or "Where is the property set or converted in core?". I have now tried to collect answers and provide links. https://wiki.documentfoundation.org/Development/Custom_Shape_Orientation_Guide The whole thing reflects my state of knowledge. If you find bugs, please report them (or fix them directly :) ). Also, if you miss something or things are unclear, please let me know. And if you want to add something, just do it. It is a wiki after all. Same holds, when you think the linguistic needs to be improved. Kind regards, Regina
[Libreoffice-bugs] [Bug 149407] Proposal for slight change in position and label of controls in the Position dialog for objects
https://bugs.documentfoundation.org/show_bug.cgi?id=149407 --- Comment #15 from sdc.bla...@youmail.dk --- (In reply to Eyal Rozenberg from comment #14) > You can't "position X from Y". You continue to misunderstand the dialog for this example. Using the actual words of the dialog (as proposed, plus a few words usually dropped in controls), the example says, in grammatical English, to position object X: from (the) left (edge) of (the) entire paragraph area by 0.7cm > I'm trying to explain why I don't see this change as an improvement. Yes, but so far the only reason offered is that the OP does not use the criterion that you have put forward. As a matter of logic, a proposal that does not use your criterion will not be seen as an improvement. If you are not willing to consider other criteria, or consider the proposal in its own terms (e.g., an improvement that can be done here and now, probably within a few hours, easier to explain/document), then there is nothing left to discuss. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149407] Proposal for slight change in position and label of controls in the Position dialog for objects
https://bugs.documentfoundation.org/show_bug.cgi?id=149407 --- Comment #15 from sdc.bla...@youmail.dk --- (In reply to Eyal Rozenberg from comment #14) > You can't "position X from Y". You continue to misunderstand the dialog for this example. Using the actual words of the dialog (as proposed, plus a few words usually dropped in controls), the example says, in grammatical English, to position object X: from (the) left (edge) of (the) entire paragraph area by 0.7cm > I'm trying to explain why I don't see this change as an improvement. Yes, but so far the only reason offered is that the OP does not use the criterion that you have put forward. As a matter of logic, a proposal that does not use your criterion will not be seen as an improvement. If you are not willing to consider other criteria, or consider the proposal in its own terms (e.g., an improvement that can be done here and now, probably within a few hours, easier to explain/document), then there is nothing left to discuss. -- You are receiving this mail because: You are on the CC list for the bug.
Re: Building LibreOffice on Raspberry Pi 4
Hi,
Am 08.06.22 um 19:20 schrieb Hossein Nourikhah:
I was trying to build LibreOffice master on 32 bit armhf Debian 10
(Official Raspbian) on Raspberry Pi 4. I could compile and run
LibreOffice successfully, but some changes were necessary. Here's how:
Your mail prompted me to retry it with current master. Since the alpha
builds fine..
First, some information about the OS:
$ cat /etc/os-release
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/;
SUPPORT_URL="http://www.raspbian.org/RaspbianForums;
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs;
Ugh, old. Why oldstable? And why raspbian in the first place if you use
a rpi4 anyway?
Following with a "real" Debian on a rpi4 (arm64, actually with a armhf
chroot).
This is my build configuration:
$ cat autogen.input
--with-jdk-home=/usr/lib/jvm/java-11-openjdk-armhf
Unneeded. Just works.
--enable-dbgutil
I always build without. Maybe it has to do with it
--without-doxygen
--disable-pdfium
This was the problem with pdfium, so I disabled it:
[CXX]
workdir/UnpackedTarball/pdfium/third_party/base/allocator/partition_allocator/partition_oom.cpp
{standard input}: Assembler messages:
{standard input}:194: Error: selected processor does not support
`yield' in ARM mode
make[1]: *** [/home/pi/Projects/core/solenv/gbuild/LinkTarget.mk:404:
/home/pi/Projects/core/workdir/GenCxxObject/UnpackedTarball/pdfium/third_party/base/allocator/partition_allocator/spin_lock.o]
Error 1
Works here.
(Though on Debian unstable)
Then, I had this problem:
[...]
Or use system-libs ;-)
Other than that, I had to remove 'Executable_regmerge from
registry/Module_registry.mk, as it was causing problem for the build.
For example? Works here, too.
I expect regmerge to get removed soon:
[API CHANGE] Remove deprecated idlc and regmerge from the SDK
https://gerrit.libreoffice.org/c/core/+/122363
For 7.5 at the earliest..
The final problem that I have encountered was that some libraries were
build with a '-lo' suffix, as it was expected:
Again no problem if you use the system libs. all needed stuff exist in
Debian proper.
(The only problem we had was that we need
https://salsa.debian.org/libreoffice-team/libreoffice/libreoffice/-/blob/master/patches/arm-fp-mode.diff
so that bridges compiles but that's probably because our gcc
configuration and thus I didn't upstream that one. I think the error was
similar to your pdfim one though).
Regards,
Rene
[Libreoffice-bugs] [Bug 107139] [META] Breeze icons
https://bugs.documentfoundation.org/show_bug.cgi?id=107139 Rafael Lima changed: What|Removed |Added Depends on||149494 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149494 [Bug 149494] Sidebar hamburger menu not available in Breeze Dark icon theme -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149494] Sidebar hamburger menu not available in Breeze Dark icon theme
https://bugs.documentfoundation.org/show_bug.cgi?id=149494 Rafael Lima changed: What|Removed |Added Blocks||107139 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107139 [Bug 107139] [META] Breeze icons -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149494] New: Sidebar hamburger menu not available in Breeze Dark icon theme
https://bugs.documentfoundation.org/show_bug.cgi?id=149494 Bug ID: 149494 Summary: Sidebar hamburger menu not available in Breeze Dark icon theme Product: LibreOffice Version: 7.3.1.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rafael.palma.l...@gmail.com Created attachment 180644 --> https://bugs.documentfoundation.org/attachment.cgi?id=180644=edit Screenshot showing the icon Open attached image. Using the Breeze Dark icon theme the hamburger menu of the sidebar is not available. The icon is available in Sifr Dark. If you're not using Breeze Dark, change the icon theme to Breeze Dark and restart LO to apply changes. Then notice the icon disappears. System info: Version: 7.4.0.0.alpha1+ / LibreOffice Community Build ID: b2467d6c7af988f8ed4e090ebf9472be6c84fb06 CPU threads: 12; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: starmath/uiconfig
starmath/uiconfig/smath/ui/dockingelements.ui |1 - starmath/uiconfig/smath/ui/sidebarelements_math.ui |1 - 2 files changed, 2 deletions(-) New commits: commit 66b1ebd4ddc7127a923bf81eb569e7f99dd52022 Author: Caolán McNamara AuthorDate: Wed Jun 8 19:48:06 2022 +0100 Commit: Caolán McNamara CommitDate: Wed Jun 8 22:24:51 2022 +0200 gtk: let math GtkIconViews flow to fill available space with icons Change-Id: I25f3433e9404ac1938568607a9a52a50ca8a7892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135513 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/starmath/uiconfig/smath/ui/dockingelements.ui b/starmath/uiconfig/smath/ui/dockingelements.ui index a9f1086204f8..604ffc0630fe 100644 --- a/starmath/uiconfig/smath/ui/dockingelements.ui +++ b/starmath/uiconfig/smath/ui/dockingelements.ui @@ -45,7 +45,6 @@ True True liststore1 -2 0 True diff --git a/starmath/uiconfig/smath/ui/sidebarelements_math.ui b/starmath/uiconfig/smath/ui/sidebarelements_math.ui index e82e6032de22..80bdfda4064b 100644 --- a/starmath/uiconfig/smath/ui/sidebarelements_math.ui +++ b/starmath/uiconfig/smath/ui/sidebarelements_math.ui @@ -75,7 +75,6 @@ True True liststore2 -2 0 True
[Libreoffice-commits] core.git: fpicker/uiconfig
fpicker/uiconfig/ui/explorerfiledialog.ui | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) New commits: commit 50c478fd84e2878b636d766e1d2141ccfa51e2f0 Author: Caolán McNamara AuthorDate: Wed Jun 8 19:44:05 2022 +0100 Commit: Caolán McNamara CommitDate: Wed Jun 8 22:24:37 2022 +0200 GtkIconView uses a different way to link model and view Change-Id: I1ad2734c9f28568433de8b9532cf20da8a27f7cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135512 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/fpicker/uiconfig/ui/explorerfiledialog.ui b/fpicker/uiconfig/ui/explorerfiledialog.ui index 9c673fa49452..852ae4f2782f 100644 --- a/fpicker/uiconfig/ui/explorerfiledialog.ui +++ b/fpicker/uiconfig/ui/explorerfiledialog.ui @@ -444,18 +444,8 @@ True True liststore2 - - - -0 - - - - - -1 - - +0 +1
[Libreoffice-commits] core.git: solenv/sanitizers
solenv/sanitizers/ui/fps.suppr |2 -- 1 file changed, 2 deletions(-) New commits: commit 83c2a61737604e3ad870cb57d921bb38c934fbd4 Author: Caolán McNamara AuthorDate: Wed Jun 8 19:37:48 2022 +0100 Commit: Caolán McNamara CommitDate: Wed Jun 8 22:24:06 2022 +0200 drop two unused suppressions Change-Id: I0bf5bed7fbfb3b46c1c9a48969f492b5745b1fb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135511 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/solenv/sanitizers/ui/fps.suppr b/solenv/sanitizers/ui/fps.suppr index 25be7fbcdf63..f0ddabb4810b 100644 --- a/solenv/sanitizers/ui/fps.suppr +++ b/solenv/sanitizers/ui/fps.suppr @@ -1,6 +1,4 @@ fpicker/uiconfig/ui/breadcrumb.ui://GtkLabel[@id='label'] orphan-label fpicker/uiconfig/ui/explorerfiledialog.ui://GtkCheckButton[@id='link'] button-no-label fpicker/uiconfig/ui/explorerfiledialog.ui://GtkCheckButton[@id='cb_preview'] button-no-label -fpicker/uiconfig/ui/explorerfiledialog.ui://GtkButton[@id='add'] button-no-label -fpicker/uiconfig/ui/explorerfiledialog.ui://GtkButton[@id='del'] button-no-label fpicker/uiconfig/ui/explorerfiledialog.ui://GtkMenuToolButton[@id='up_btn'] button-no-label
[Libreoffice-bugs] [Bug 149492] With nothing selected, properties sidebar shows "Slide" section
https://bugs.documentfoundation.org/show_bug.cgi?id=149492 --- Comment #3 from Eyal Rozenberg --- (In reply to Mike Kaganski from comment #1) > Please try with clean profile. This is most likely a remnant of some older > sidebar configuration, together with the newer configuration. After removing my profile folder and starting LO Draw again, I see the page section _twice_ in the properties bar. Build info: Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: d9b33ed6644203141fdb0776c291425c2bc9f5ac CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-IL (en_IL); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149493] New: Should be able to select visible toolbars in Toolbar context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=149493 Bug ID: 149493 Summary: Should be able to select visible toolbars in Toolbar context menu Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com When we right-click a toolbar, in any LO module, we get a context menu. Some of the context menu controls what buttons are visible on that toolbar. I claim that it is at least as useful, and in fact more so, to be able to control which toolbars are visible, from within that context menu. Reasons: 1. It is at least as likely if not more that a person would want to enable a toolbar than to modify one. The former happens very often (especially since toolbars can get auto-hidden), and the latter rarely. 2. If you have your mouse already on a toolbar searching for something, and you can't find it, an "obvious" choice is to right-click - as opposed to "giving up" on the toolbar for now and going "elsewhere" - into the menus. (3. I think some other apps have this behavior.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149492] With nothing selected, properties sidebar shows "Slide" section
https://bugs.documentfoundation.org/show_bug.cgi?id=149492 --- Comment #2 from Eyal Rozenberg --- (In reply to Mike Kaganski from comment #1) > Please try with clean profile. This is most likely a remnant of some older > sidebar configuration, together with the newer configuration. I will, but - if a non-clean profile causes the sidebar to display a property section from another module - that's a bug. To paraphrase: "If the user profile told you to jump off the roof, would ya?" ... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149492] With nothing selected, properties sidebar shows "Slide" section
https://bugs.documentfoundation.org/show_bug.cgi?id=149492 --- Comment #1 from Mike Kaganski --- Please try with clean profile. This is most likely a remnant of some older sidebar configuration, together with the newer configuration. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149481] Calc 7.3.x crashed when pasting from tsv, but only if I deleted the existing contents
https://bugs.documentfoundation.org/show_bug.cgi?id=149481 omui+libreoff...@pm.me changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from omui+libreoff...@pm.me --- I tried restart in safe mode, but it still crashed. Tried in different Arch boxes, still the same. However, since it couldn't be reproduced by 2 users running ubuntu, it could be related to my environment (xfce / clipboard) or an Arch-related packaging issue. I'll spin up a ubuntu and fedora vm to test and report back. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Bug 42082 depends on bug 67874, which changed state. Bug 67874 Summary: No icon association with MS Office and 3rd party files in Info.plist https://bugs.documentfoundation.org/show_bug.cgi?id=67874 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 67874] No icon association with MS Office and 3rd party files in Info.plist
https://bugs.documentfoundation.org/show_bug.cgi?id=67874 Nazrul deCastelnau changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #18 from Nazrul deCastelnau --- I see an .xls document with an icon that has a spreadsheet background and a bigger XLS lettering in front. Works for me; at least it is not the generic blank document I used to see before. Thanks! Version: 7.3.0.3 / LibreOffice Community Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3 CPU threads: 8; OS: Mac OS X 11.6.6; UI render: Skia/Metal; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149407] Proposal for slight change in position and label of controls in the Position dialog for objects
https://bugs.documentfoundation.org/show_bug.cgi?id=149407 --- Comment #14 from Eyal Rozenberg --- (In reply to sdc.blanco from comment #13) > Unclear to me whether you understand this positioning control because it > needs to have "by" in this case. "Position from left of entire paragraph area by 0.70cm" still no good. > > especially since it's not a valid phrase in English. > Why not? I don't know, I'm not a linguist... it just isn't. The imperative verb "position" can take a direct object and an indirect object with preposition 'at': "position X at Y". You can't "position X from Y". > It does not depend on or presuppose your "sentence-forming" criterion, and > there is no reason why that criterion should be an absolute requirement > for making any easy, but useful, improvement to the existing interface. > (the point of the OP). I'm trying to explain why I don't see this change as an improvement. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149407] Proposal for slight change in position and label of controls in the Position dialog for objects
https://bugs.documentfoundation.org/show_bug.cgi?id=149407 --- Comment #14 from Eyal Rozenberg --- (In reply to sdc.blanco from comment #13) > Unclear to me whether you understand this positioning control because it > needs to have "by" in this case. "Position from left of entire paragraph area by 0.70cm" still no good. > > especially since it's not a valid phrase in English. > Why not? I don't know, I'm not a linguist... it just isn't. The imperative verb "position" can take a direct object and an indirect object with preposition 'at': "position X at Y". You can't "position X from Y". > It does not depend on or presuppose your "sentence-forming" criterion, and > there is no reason why that criterion should be an absolute requirement > for making any easy, but useful, improvement to the existing interface. > (the point of the OP). I'm trying to explain why I don't see this change as an improvement. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 149492] New: With nothing selected, properties sidebar shows "Slide" section
https://bugs.documentfoundation.org/show_bug.cgi?id=149492 Bug ID: 149492 Summary: With nothing selected, properties sidebar shows "Slide" section Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com LO Draw does not have slides. However, if I start Draw (with an empty page), and open the Properties sidebar, I see two sections: "Page", ok, and "Slide" - with mostly the same properties. That should go away. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149411] It's difficult to reach text area properties
https://bugs.documentfoundation.org/show_bug.cgi?id=149411 --- Comment #4 from Eyal Rozenberg --- (In reply to Rafael Lima from comment #3) Are we talking about Impress only, or also Draw? Also, following the design meeting today, it seems like this should be confirmed as NEW. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149411] It's difficult to reach text area properties
https://bugs.documentfoundation.org/show_bug.cgi?id=149411 --- Comment #4 from Eyal Rozenberg --- (In reply to Rafael Lima from comment #3) Are we talking about Impress only, or also Draw? Also, following the design meeting today, it seems like this should be confirmed as NEW. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: toolkit/qa
toolkit/qa/cppunit/a11y/XAccessibleComponentTester.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 19a67603c7a800d3433e9f41143a9b9ed6300b8d Author: Andrea Gelmini AuthorDate: Wed Jun 8 21:05:19 2022 +0200 Commit: Julien Nabet CommitDate: Wed Jun 8 21:18:11 2022 +0200 Fix typo Change-Id: Id5517254be4e108c4aeedbd067f9bf3097f89452 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135515 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/toolkit/qa/cppunit/a11y/XAccessibleComponentTester.cxx b/toolkit/qa/cppunit/a11y/XAccessibleComponentTester.cxx index 13da4a2c765f..5613724786b9 100644 --- a/toolkit/qa/cppunit/a11y/XAccessibleComponentTester.cxx +++ b/toolkit/qa/cppunit/a11y/XAccessibleComponentTester.cxx @@ -214,7 +214,7 @@ void XAccessibleComponentTester::testAccessibleAtPoint() } /** - * @brief Tests reults of XAccessibleComponent::getLocation() + * @brief Tests results of XAccessibleComponent::getLocation() * * Succeeds if the location is the same as location of boundary obtained by * the getBounds() method.
[Libreoffice-commits] core.git: toolkit/qa
toolkit/qa/cppunit/a11y/XAccessibleContextTester.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 33f88380fba0202d03577da80f7370ac8e583fb1 Author: Andrea Gelmini AuthorDate: Wed Jun 8 21:05:24 2022 +0200 Commit: Julien Nabet CommitDate: Wed Jun 8 21:17:44 2022 +0200 Fix typo Change-Id: I278a23c9dc7a20f293e8167ee3c0492679e81f8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135516 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/toolkit/qa/cppunit/a11y/XAccessibleContextTester.cxx b/toolkit/qa/cppunit/a11y/XAccessibleContextTester.cxx index fddd7feab2be..3a7eb70e9dd5 100644 --- a/toolkit/qa/cppunit/a11y/XAccessibleContextTester.cxx +++ b/toolkit/qa/cppunit/a11y/XAccessibleContextTester.cxx @@ -124,7 +124,7 @@ void XAccessibleContextTester::testGetAccessibleRelationSet() } /** - * @breif Get the accessible role of component. + * @brief Get the accessible role of component. * * Checks that the role is a non-negative number. */
[Libreoffice-commits] core.git: include/vcl
include/vcl/WindowPosSize.hxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 16af8e218540dd17f020411c32e809feb68abd78
Author: Andrea Gelmini
AuthorDate: Wed Jun 8 21:05:09 2022 +0200
Commit: Julien Nabet
CommitDate: Wed Jun 8 21:16:33 2022 +0200
Fix typo
Change-Id: I6463eb09c5bac07e6aa8e23b4b5eab06172ab2b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135514
Tested-by: Julien Nabet
Reviewed-by: Julien Nabet
diff --git a/include/vcl/WindowPosSize.hxx b/include/vcl/WindowPosSize.hxx
index c88444c6dd9a..ed52488be33a 100644
--- a/include/vcl/WindowPosSize.hxx
+++ b/include/vcl/WindowPosSize.hxx
@@ -30,7 +30,7 @@ namespace vcl
{
/**
* There are multiple ways to store the two different areas of a vcl::Window.
- * But this representataion is hopefully less error prone from the used types
+ * But this representation is hopefully less error prone from the used types
* and more clear in what values in- or exclude the non-drawable window frame.
*
* There are especially two things to remember:
@@ -120,7 +120,7 @@ public:
setPos(rRect.GetPos());
setSize(rRect.GetSize());
}
-// because tools::Rectangle has the ambigious (Point&, Point&)
constructor, which we don't want here
+// because tools::Rectangle has the ambiguous (Point&, Point&)
constructor, which we don't want here
void setPosSize(const Point& rPos, const Size& rSize) { setPosSize({ rPos,
rSize }); }
};
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/firebird/PreparedStatement.cxx | 35 -
1 file changed, 34 insertions(+), 1 deletion(-)
New commits:
commit a943e7ddd13315b18d7b33cd1b2f852144f54344
Author: Julien Nabet
AuthorDate: Tue Jun 7 22:57:43 2022 +0200
Commit: Julien Nabet
CommitDate: Wed Jun 8 21:13:22 2022 +0200
tdf#149470: Firebird, Clob may need several segments to store a very long
input
Change-Id: I85c7789f46d834d2ae1b251f915382f833bd529d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135480
Reviewed-by: Caolán McNamara
Reviewed-by: Julien Nabet
Tested-by: Jenkins
diff --git a/connectivity/source/drivers/firebird/PreparedStatement.cxx
b/connectivity/source/drivers/firebird/PreparedStatement.cxx
index 9cd9157a7d6d..816c38d5c7e3 100644
--- a/connectivity/source/drivers/firebird/PreparedStatement.cxx
+++ b/connectivity/source/drivers/firebird/PreparedStatement.cxx
@@ -50,6 +50,8 @@ using namespace com::sun::star::util;
IMPLEMENT_SERVICE_INFO(OPreparedStatement,"com.sun.star.sdbcx.firebird.PreparedStatement","com.sun.star.sdbc.PreparedStatement");
+constexpr size_t MAX_SIZE_SEGMENT = 65535; // max value of a segment of CLOB,
if we want more than 65535 bytes, we need more segments
+
OPreparedStatement::OPreparedStatement( Connection* _pConnection,
const OUString& sql)
@@ -661,10 +663,41 @@ void OPreparedStatement::setClob( sal_Int32
nParameterIndex, const OUString& rSt
OString sData = OUStringToOString(
rStr,
RTL_TEXTENCODING_UTF8);
-ISC_STATUS aErr = isc_put_segment( m_statusVector,
+size_t nDataSize = sData.getLength();
+ISC_STATUS aErr = 0;
+// we can't store more than MAX_SIZE_SEGMENT in a segment
+if (nDataSize <= MAX_SIZE_SEGMENT)
+{
+aErr = isc_put_segment( m_statusVector,
,
sData.getLength(),
sData.getStr() );
+}
+else
+{
+// if we need more, let's split the input and first let's calculate
the nb of entire chunks needed
+size_t nNbEntireChunks = nDataSize / MAX_SIZE_SEGMENT;
+for (size_t i = 0; i < nNbEntireChunks; ++i)
+{
+OString strCurrentChunk = sData.copy(i * MAX_SIZE_SEGMENT,
MAX_SIZE_SEGMENT);
+aErr = isc_put_segment( m_statusVector,
+,
+strCurrentChunk.getLength(),
+strCurrentChunk.getStr() );
+if (aErr)
+break;
+}
+size_t nRemainingBytes = nDataSize - (nNbEntireChunks *
MAX_SIZE_SEGMENT);
+if (nRemainingBytes && !aErr)
+{
+// then copy the remaining
+OString strCurrentChunk = sData.copy(nNbEntireChunks *
MAX_SIZE_SEGMENT, nRemainingBytes);
+aErr = isc_put_segment( m_statusVector,
+,
+strCurrentChunk.getLength(),
+strCurrentChunk.getStr() );
+}
+}
// We need to make sure we close the Blob even if there are errors, hence
evaluate
// errors after closing.
[Libreoffice-commits] core.git: sw/source
sw/source/core/undo/undobj.cxx | 12
1 file changed, 8 insertions(+), 4 deletions(-)
New commits:
commit 12acdce71dd6b6af2c52ba8fa3248d3166418543
Author: Michael Stahl
AuthorDate: Wed Jun 8 17:34:32 2022 +0200
Commit: Michael Stahl
CommitDate: Wed Jun 8 21:05:37 2022 +0200
(related: tdf#139514) sw: fix Undo of delete with at-para fly
Nonobviously, there are situations where the anchor node must be
preserved and restored when it's not on the node that is being deleted.
(probably regression from commit 91b2325808a75174f284c48c8b8afc118fad74e4)
Change-Id: I39f09ddb631204c8ad522f9ec7068d235ca94ad2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135509
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/source/core/undo/undobj.cxx b/sw/source/core/undo/undobj.cxx
index 6cde5bed2f6a..c23aeba3ba51 100644
--- a/sw/source/core/undo/undobj.cxx
+++ b/sw/source/core/undo/undobj.cxx
@@ -1003,10 +1003,14 @@ void SwUndoSaveContent::DelContentIndex( const
SwPosition& rMark,
// Moving the anchor?
else if
(!((DelContentType::CheckNoCntnt|DelContentType::ExcludeFlyAtStartEnd)
& nDelContentType) &&
-// at least for calls from SwUndoDelete,
-// this should work - other Undos don't
-// remember the order of the cursor
-(rPoint.nNode.GetIndex() ==
pAPos->nNode.GetIndex())
+// for SwUndoDelete: rPoint is the node that
+// will be Joined - so anchor should be moved
+// off it - but UndoImpl() split will insert
+// new node *before* existing one so a no-op
+// may need to be done here to add it to
+// history for Undo.
+(rPoint.nNode.GetIndex() ==
pAPos->nNode.GetIndex()
+ || pStt->nNode.GetIndex() ==
pAPos->nNode.GetIndex())
// Do not try to move the anchor to a table!
&& rMark.nNode.GetNode().IsTextNode())
{
[Libreoffice-bugs] [Bug 107659] [META] Macro bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107659 Bug 107659 depends on bug 127918, which changed state. Bug 127918 Summary: [META] Basic QA Unit Tests https://bugs.documentfoundation.org/show_bug.cgi?id=127918 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127918] [META] Basic QA Unit Tests
https://bugs.documentfoundation.org/show_bug.cgi?id=127918 Timur changed: What|Removed |Added CC||xiscofa...@libreoffice.org Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Timur --- Seems to me that this is one of unnecessary metas, where more efficient keyword exists. Also, if had pony two resolved bugs. So I close. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135462] LibreOffice 7.0.0.3 does not recognise JRE installation location at startup other than those in /Library/Java/JavaVirtualMachines/
https://bugs.documentfoundation.org/show_bug.cgi?id=135462 Timur changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #40 from Timur --- "Please retest" for original issue, comment 37 suggested to close the issue, so setting Needinfo. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/style/xmlnumfe.cxx | 31 +++
1 file changed, 31 insertions(+)
New commits:
commit 33a8c4bd0e8533ab42894280e7e04c13a47aefa9
Author: Eike Rathke
AuthorDate: Wed Jun 8 17:49:15 2022 +0200
Commit: Eike Rathke
CommitDate: Wed Jun 8 20:49:53 2022 +0200
Related: tdf#149484 Write proper with
Change-Id: I46b7987dde25840ae0b6e5871b14e3806c6e4ac8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135508
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx
index 52b286dd50a9..82ed552dcbca 100644
--- a/xmloff/source/style/xmlnumfe.cxx
+++ b/xmloff/source/style/xmlnumfe.cxx
@@ -1254,6 +1254,37 @@ void SvXMLNumFmtExport::ExportPart_Impl( const
SvNumberformat& rFormat, sal_uInt
WriteBooleanElement_Impl();
bAnyContent = true;
}
+else if (eType == XML_BOOLEAN_STYLE)
+{
+// may contain only and
+// elements.
+sal_uInt16 nPos = 0;
+bool bEnd = false;
+while (!bEnd)
+{
+const short nElemType = rFormat.GetNumForType( nPart, nPos );
+switch (nElemType)
+{
+case 0:
+bEnd = true;// end of format reached
+if (bHasText && sTextContent.isEmpty())
+bHasText = false; // don't write trailing empty
text
+break;
+case NF_SYMBOLTYPE_STRING:
+{
+const OUString* pElemStr = rFormat.GetNumForString(
nPart, nPos );
+if (pElemStr)
+AddToTextElement_Impl( *pElemStr );
+}
+break;
+case NF_KEY_BOOLEAN:
+WriteBooleanElement_Impl();
+bAnyContent = true;
+break;
+}
+++nPos;
+}
+}
else
{
// first loop to collect attributes
Re: Apparent bug in Writer word wrapping
On 08.06.2022 21:19, dep wrote: Writer splits words and starts new line, in the middle of the word, without hypenation. Hyphenation is turned off everywhere I have found that this can be done (not exactly intuitive, is it). Problem is illustrated in the attached partial screenshot. Most likely, your text is attributed as using a language that allows splitting between any characters. E.g., selecting any text and setting its character language as 'ja' (Japanese) gives what is shown on your screenshot. This is not a bug, and you need to set the correct language to the text. -- Best regards, Mike Kaganski
Minutes from the UX/design meeting 2022-Jun-08
Present: Cor, Heiko Comments: Rafael, Seth, Eyal Tickets/Topics * When clicking an Insert-shape button, focus is wrong + https://bugs.documentfoundation.org/show_bug.cgi?id=149341 + the toolbar "insert shapes" command remains active while you can draw multiple shapes in Writer; and escape cancels this + once drawing the shape is finished, the tool should no longer be selected in the sidebar, and return to selection mode by pressing Esc (Rafael) => sounds good (Cor) * Make the selection behavior when double-clicking a word a user preference + https://bugs.documentfoundation.org/show_bug.cgi?id=149254 + include the trailing space on double-click (and insert back in case of overtyping)? + keyboard use with ctrl+shift+left/right includes the space and we should do the same for the mouse (Cor) + if so, have an option for it + nope => do it * Proposal for slight change in position and label of controls in the Position dialog for objects + https://bugs.documentfoundation.org/show_bug.cgi?id=149407 + a) "From left" of "Paragraph area" by "0.70cm" (Seth) + to => of makes sense (Cor) + "to" does not fit always, eg. with "left of entire page" (Heiko) + change wont improve the understandability (Cor) + b) Align "Paragraph area" to "From left" with offset "0.70cm" (Eyal) + unclear how it works in other languages and can of worms (Cor) => recommend to not change (WF) but no string objection if someone volunteers; better do smaller steps * Change submenu label for formatting textboxes and shapes in Calc and Impress + https://bugs.documentfoundation.org/show_bug.cgi?id=149414 + intention to not use the generic "object" and consistency across modules; alternative make a pseudo .uno for Calc (Seth) + any objection to change "Object and Shape" -> "Text Box and Shape" + Insert > OLE Object (but in fact Insert > Shape) barely combines with Format > Object & Shape + Text Box and Shape sounds much better => do it for all modules * It's difficult to reach text area properties + https://bugs.documentfoundation.org/show_bug.cgi?id=149411 + does the command Format > Object and Shape > Text Attributes... need a more prominent position? + somehow misplaced in the main menu but expect it to be in the sidebar (Eyal) + Fit width/height might be worth to add to the "Columns" deck (renaming needed) and we could add the deck's generic property action (Heiko) + New label could be "Text" (Cor) or "Text Attributes" (Heiko) => do it OpenPGP_signature Description: OpenPGP digital signature
[Libreoffice-qa] Minutes from the UX/design meeting 2022-Jun-08
Present: Cor, Heiko Comments: Rafael, Seth, Eyal Tickets/Topics * When clicking an Insert-shape button, focus is wrong + https://bugs.documentfoundation.org/show_bug.cgi?id=149341 + the toolbar "insert shapes" command remains active while you can draw multiple shapes in Writer; and escape cancels this + once drawing the shape is finished, the tool should no longer be selected in the sidebar, and return to selection mode by pressing Esc (Rafael) => sounds good (Cor) * Make the selection behavior when double-clicking a word a user preference + https://bugs.documentfoundation.org/show_bug.cgi?id=149254 + include the trailing space on double-click (and insert back in case of overtyping)? + keyboard use with ctrl+shift+left/right includes the space and we should do the same for the mouse (Cor) + if so, have an option for it + nope => do it * Proposal for slight change in position and label of controls in the Position dialog for objects + https://bugs.documentfoundation.org/show_bug.cgi?id=149407 + a) "From left" of "Paragraph area" by "0.70cm" (Seth) + to => of makes sense (Cor) + "to" does not fit always, eg. with "left of entire page" (Heiko) + change wont improve the understandability (Cor) + b) Align "Paragraph area" to "From left" with offset "0.70cm" (Eyal) + unclear how it works in other languages and can of worms (Cor) => recommend to not change (WF) but no string objection if someone volunteers; better do smaller steps * Change submenu label for formatting textboxes and shapes in Calc and Impress + https://bugs.documentfoundation.org/show_bug.cgi?id=149414 + intention to not use the generic "object" and consistency across modules; alternative make a pseudo .uno for Calc (Seth) + any objection to change "Object and Shape" -> "Text Box and Shape" + Insert > OLE Object (but in fact Insert > Shape) barely combines with Format > Object & Shape + Text Box and Shape sounds much better => do it for all modules * It's difficult to reach text area properties + https://bugs.documentfoundation.org/show_bug.cgi?id=149411 + does the command Format > Object and Shape > Text Attributes... need a more prominent position? + somehow misplaced in the main menu but expect it to be in the sidebar (Eyal) + Fit width/height might be worth to add to the "Columns" deck (renaming needed) and we could add the deck's generic property action (Heiko) + New label could be "Text" (Cor) or "Text Attributes" (Heiko) => do it OpenPGP_signature Description: OpenPGP digital signature
[Libreoffice-commits] core.git: sw/source sw/uiconfig
sw/source/ui/frmdlg/frmpage.cxx |2
sw/source/uibase/inc/frmpage.hxx |1
sw/uiconfig/swriter/ui/frmaddpage.ui | 422 ++-
3 files changed, 232 insertions(+), 193 deletions(-)
New commits:
commit 755e0cd60d4634111911469b752485da678988e1
Author: Heiko Tietze
AuthorDate: Wed Jun 8 14:08:37 2022 +0200
Commit: Heiko Tietze
CommitDate: Wed Jun 8 20:35:43 2022 +0200
Resolves tdf#149010 - MInor UI fixes
* Next/Previous controls placed in an extra frame
* This frame becomes hidden in case of picture and objects
(next/prev is only possible for frames)
Change-Id: Iab7042b72efa7857c5405a8c345ba03d6b975519
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135494
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sw/source/ui/frmdlg/frmpage.cxx b/sw/source/ui/frmdlg/frmpage.cxx
index 35db7c25135a..83cf98f49195 100644
--- a/sw/source/ui/frmdlg/frmpage.cxx
+++ b/sw/source/ui/frmdlg/frmpage.cxx
@@ -2793,6 +2793,7 @@ SwFrameAddPage::SwFrameAddPage(weld::Container* pPage,
weld::DialogController* p
, m_xAltNameED(m_xBuilder->weld_entry("altname"))
, m_xDescriptionFT(m_xBuilder->weld_label("description_label"))
, m_xDescriptionED(m_xBuilder->weld_text_view("description"))
+, m_xSequenceFrame(m_xBuilder->weld_widget("frmSequence"))
, m_xPrevFT(m_xBuilder->weld_label("prev_label"))
, m_xPrevLB(m_xBuilder->weld_combo_box("prev"))
, m_xNextFT(m_xBuilder->weld_label("next_label"))
@@ -2840,6 +2841,7 @@ void SwFrameAddPage::Reset(const SfxItemSet *rSet )
}
if (m_sDlgType == "PictureDialog" || m_sDlgType == "ObjectDialog")
{
+m_xSequenceFrame->hide();
m_xEditInReadonlyCB->hide();
if (m_bHtmlMode)
{
diff --git a/sw/source/uibase/inc/frmpage.hxx b/sw/source/uibase/inc/frmpage.hxx
index 8211dc7b350b..1e01a6fa100d 100644
--- a/sw/source/uibase/inc/frmpage.hxx
+++ b/sw/source/uibase/inc/frmpage.hxx
@@ -280,6 +280,7 @@ class SwFrameAddPage final : public SfxTabPage
std::unique_ptr m_xAltNameED;
std::unique_ptr m_xDescriptionFT;
std::unique_ptr m_xDescriptionED;
+std::unique_ptr m_xSequenceFrame;
std::unique_ptr m_xPrevFT;
std::unique_ptr m_xPrevLB;
std::unique_ptr m_xNextFT;
diff --git a/sw/uiconfig/swriter/ui/frmaddpage.ui
b/sw/uiconfig/swriter/ui/frmaddpage.ui
index f306f7d1c223..dd949a5b69cf 100644
--- a/sw/uiconfig/swriter/ui/frmaddpage.ui
+++ b/sw/uiconfig/swriter/ui/frmaddpage.ui
@@ -1,5 +1,5 @@
-
+
@@ -9,40 +9,40 @@
-
+
True
-False
+False
True
-6
-12
-24
+6
+12
+24
True
-False
+False
True
True
-0
-none
+0
+none
-
+
True
-False
-True
-True
-6
-12
+False
12
6
+True
+True
+6
+12
True
-True
+True
True
-True
-50
+True
+50
True
@@ -51,17 +51,17 @@
-1
-0
+1
+0
True
-True
+True
True
-True
-50
+True
+50
True
@@ -70,28 +70,28 @@
-1
-1
+1
+1
True
-False
+False
_Name:
-True
-name
+True
+name
0
-0
-0
+0
+0
True
-False
+False
Text _Alternative:
Give a short description for
users who do not see this object.
True
@@ -99,82 +99,14 @@
0
-0
-1
-
-
-
-
-True
-False
-True
-
- None
-
-
-
-Displays the frame
that comes before the current frame in a linked
[Libreoffice-bugs] [Bug 103270] [META] Image/Picture dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103270 Bug 103270 depends on bug 149010, which changed state. Bug 149010 Summary: "Previous Link" and "Next Link" should only appear on Frames Options tab https://bugs.documentfoundation.org/show_bug.cgi?id=149010 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96355] All-in-one Textbox/Shape/Object properties dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=96355 Bug 96355 depends on bug 149010, which changed state. Bug 149010 Summary: "Previous Link" and "Next Link" should only appear on Frames Options tab https://bugs.documentfoundation.org/show_bug.cgi?id=149010 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/qa sw/source
sw/inc/IDocumentContentOperations.hxx | 12 +++-
sw/inc/editsh.hxx |4 -
sw/qa/extras/uiwriter/uiwriter3.cxx |6 +-
sw/qa/uitest/writer_tests7/tdf137802.py |2
sw/source/core/doc/DocumentContentOperationsManager.cxx | 46
sw/source/core/docnode/ndsect.cxx |2
sw/source/core/docnode/ndtbl.cxx|2
sw/source/core/edit/autofmt.cxx |4 -
sw/source/core/edit/eddel.cxx |9 +--
sw/source/core/edit/edglbldc.cxx|2
sw/source/core/edit/editsh.cxx |4 -
sw/source/core/frmedt/fecopy.cxx|2
sw/source/core/frmedt/fetab.cxx |4 -
sw/source/core/inc/DocumentContentOperationsManager.hxx | 10 +--
sw/source/core/inc/UndoDelete.hxx |3 +
sw/source/core/layout/atrfrm.cxx|2
sw/source/core/undo/undel.cxx | 21 +--
sw/source/core/undo/unins.cxx |2
sw/source/core/undo/unredln.cxx |4 -
sw/source/core/undo/untbl.cxx | 14 ++--
sw/source/uibase/dochdl/swdtflvr.cxx|2
sw/source/uibase/docvw/edtwin.cxx |2
sw/source/uibase/lingu/hhcwrp.cxx |4 -
sw/source/uibase/ribbar/inputwin.cxx|4 -
sw/source/uibase/utlui/content.cxx |2
sw/source/uibase/wrtsh/delete.cxx | 28 -
sw/source/uibase/wrtsh/select.cxx |4 -
27 files changed, 119 insertions(+), 82 deletions(-)
New commits:
commit 85376a02348810812d515ee72140dbf56f2b6040
Author: Michael Stahl
AuthorDate: Tue Jun 7 19:01:24 2022 +0200
Commit: Michael Stahl
CommitDate: Wed Jun 8 20:31:40 2022 +0200
tdf#133957 sw: don't delete flys on Backspace/Delete keys
Also fixes: tdf#134007 tdf#138835 tdf#139514
When a character is deleted via the keyboard by Backspace or Delete key,
an artificial selection is created in SwWrtShell::DelLeft()/DelRight().
Ideally this should not delete flys that may be anchored to the
paragraphs, but unfortunately this may happen if there are only 2 empty
paragraphs in the section, because then the artificial selection cannot
be distinguished by the SwDoc implementation from a selection from
Ctrl+A (Select All), which *should* delete the flys.
So introduce a new flag that needs to be passed down multiple layers so
that SwUndoDelete can use it to determine if flys should be deleted, and
translating it to a flag that had been introduced to preserve flys in
ReplaceRange() previously.
There are a couple more callers that look like they want to "replace"
some text, so guess a bit at where to set this new flag.
(note: of course fly anchored *as char* must be deleted via keys.)
(regression from commit e75dd1fc992f168f24d66595265a978071cdd277)
Change-Id: Ib4467476b12a12aefbbcb74ab9802f9318cf9aa0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135476
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/inc/IDocumentContentOperations.hxx
b/sw/inc/IDocumentContentOperations.hxx
index c9445ebc9281..bac97d685927 100644
--- a/sw/inc/IDocumentContentOperations.hxx
+++ b/sw/inc/IDocumentContentOperations.hxx
@@ -82,6 +82,16 @@ namespace o3tl
template<> struct typed_flags : is_typed_flags {};
}
+enum class SwDeleteFlags
+{
+Default = 0,
+ArtificialSelection = (1<<0), ///< keyboard delete, artificial selection,
avoid deleting flys
+};
+namespace o3tl
+{
+template<> struct typed_flags :
is_typed_flags {};
+}
+
/** Text operation/manipulation interface
*/
class IDocumentContentOperations
@@ -139,7 +149,7 @@ public:
/** complete delete of a given PaM
*/
-virtual bool DeleteAndJoin( SwPaM& ) = 0;
+virtual bool DeleteAndJoin(SwPaM&, SwDeleteFlags flags =
SwDeleteFlags::Default) = 0;
virtual bool MoveRange(SwPaM&, SwPosition&, SwMoveFlags) = 0;
diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx
index db21658c..67c18d798a12 100644
--- a/sw/inc/editsh.hxx
+++ b/sw/inc/editsh.hxx
@@ -150,7 +150,7 @@ class SW_DLLPUBLIC SwEditShell : public SwCursorShell
that will be used by GetGraphic() and GetGraphicSize(). */
SAL_DLLPRIVATE SwGrfNode *GetGrfNode_() const ;
-SAL_DLLPRIVATE void DeleteSel( SwPaM& rPam, bool* pUndo = nullptr );
+SAL_DLLPRIVATE void DeleteSel(SwPaM& rPam, bool isArtificialSelection,
bool* pUndo = nullptr);
SAL_DLLPRIVATE void SetSectionAttr_( SwSectionFormat& rSectFormat, const
SfxItemSet& rSet );
@@ -172,7 +172,7 @@ public:
/**
[Libreoffice-bugs] [Bug 87740] [META] Anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87740 Bug 87740 depends on bug 134007, which changed state. Bug 134007 Summary: EDITING: Image anchored to paragraph gets removed when removing the paragraph https://bugs.documentfoundation.org/show_bug.cgi?id=134007 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134007] EDITING: Image anchored to paragraph gets removed when removing the paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=134007 Michael Stahl (allotropia) changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | --- Comment #6 from Michael Stahl (allotropia) --- fixed on master -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Bug 103100 depends on bug 138835, which changed state. Bug 138835 Summary: Image in table anchored to paragraph/character deleted when deleting the last character below (but not in older versions) https://bugs.documentfoundation.org/show_bug.cgi?id=138835 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103152 Bug 103152 depends on bug 138835, which changed state. Bug 138835 Summary: Image in table anchored to paragraph/character deleted when deleting the last character below (but not in older versions) https://bugs.documentfoundation.org/show_bug.cgi?id=138835 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138835] Image in table anchored to paragraph/character deleted when deleting the last character below (but not in older versions)
https://bugs.documentfoundation.org/show_bug.cgi?id=138835 Michael Stahl (allotropia) changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | --- Comment #5 from Michael Stahl (allotropia) --- fixed on master -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 87740] [META] Anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87740 Bug 87740 depends on bug 133957, which changed state. Bug 133957 Summary: Deleting a paragraph with backspace deletes the image (instead of moving up) https://bugs.documentfoundation.org/show_bug.cgi?id=133957 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133957] Deleting a paragraph with backspace deletes the image (instead of moving up)
https://bugs.documentfoundation.org/show_bug.cgi?id=133957 Michael Stahl (allotropia) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #17 from Michael Stahl (allotropia) --- (In reply to Telesto from comment #0) > Description: > Deleting a paragraph with backspace deletes the image (instead of moving up) > > Steps to Reproduce: > 1. Open the attached file > 2. Click on the second line > 3. Press backspace -> Image gone > 4. Undo > 5. Go to the top paragraph & press delete.. image gone > > Actual Results: > Image gone > > Expected Results: > Moved up, not deleted by backspace this is fixed now on master: keyboard backspace/delete shouldn't delete at-char/at-paragraph anchored objects (but should delete *as-char* objects of course). (In reply to R. Green from comment #3) > Created attachment 161991 [details] > Writer doc. showing an issue withthe behaviour of paragraph-anchored imaghes > > A similar problem: > > 1. Open the attached file. The image has been anchored to a blank paragraph. > 2. Place the cursor at the start of the paragraph (where the image is > anchored). Now add the text "abc" (for example). > 3. Use the arrow keys to move the cursor before the "a". Use Shift + arrow, > one press at a time. > > EXPECTED RESULT: When all three letters have been selected, the image should > NOT be selected. > ACTUAL RESULT: When all three letters are selected, the image is > automatically selected as well. > > This is clearly anomalous because the image was able to exist on its own in > the paragraph prior to the addition of the letters, whereas once the letters > are added the image will be automatically deleted with the text. > > The user might expect that if ONLY the text is deleted, then the image, or > frame, should remain. > > Reminds me of the problem in Bug 131331 (If you select paragraph in the > header, selection includes a frame, that is anchored to that paragraph). still disagree with this - an explicit selection should also delete anchored objects. this was always the case with objects anchored in fully selected paragraphs and now it happens if they are anchored in paragraph at start/end of selection too. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139514] Delete one of both paragraph below a text frame deletes the text frame
https://bugs.documentfoundation.org/show_bug.cgi?id=139514 Michael Stahl (allotropia) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | Status|NEW |RESOLVED Summary|Delete one of both |Delete one of both |paragraph below a table |paragraph below a text |deletes the table |frame deletes the text ||frame Blocks|103100 | Resolution|--- |FIXED --- Comment #6 from Michael Stahl (allotropia) --- the description is a duplicate of bug 133957; there is another issue with the fix for that where the Undo puts the anchor on the wrong paragraph, that will be fixed in a subsequent commit. incidentally table is a red herring, they're in text frames and that's what's getting deleted. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Michael Stahl (allotropia) changed: What|Removed |Added Depends on|139514 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139514 [Bug 139514] Delete one of both paragraph below a text frame deletes the text frame -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/style/xmlnumfi.cxx | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
New commits:
commit 025231224b8b076e280235cd2b943addd2fb0755
Author: Eike Rathke
AuthorDate: Wed Jun 8 17:47:19 2022 +0200
Commit: Eike Rathke
CommitDate: Wed Jun 8 20:15:44 2022 +0200
Resolves: tdf#149484 Read and handle in
Change-Id: I1be5f2be908eb88aa4ef7436ea7c09f35b076acf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135507
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx
index e5e9a25828fa..46ee44b3080f 100644
--- a/xmloff/source/style/xmlnumfi.cxx
+++ b/xmloff/source/style/xmlnumfi.cxx
@@ -497,8 +497,11 @@ static bool lcl_ValidChar( sal_Unicode cChar, const
SvXMLNumFormatContext& rPare
}
// see ImpSvNumberformatScan::Next_Symbol
+
+// All format types except BOOLEAN may contain minus sign or delimiter.
if ( cChar == '-' )
-return true; // all format types may content minus sign or delimiter
+return nFormatType != SvXMLStylesTokens::BOOLEAN_STYLE;
+
if ( ( cChar == ' ' ||
cChar == '/' ||
cChar == '.' ||
@@ -528,11 +531,13 @@ static void lcl_EnquoteIfNecessary( OUStringBuffer&
rContent, const SvXMLNumForm
{
bool bQuote = true;
sal_Int32 nLength = rContent.getLength();
+const SvXMLStylesTokens nFormatType = rParent.GetType();
-if ((nLength == 1 && lcl_ValidChar( rContent[0], rParent)) ||
-(nLength == 2 &&
- ((rContent[0] == ' ' && rContent[1] == '-') ||
- (rContent[1] == ' ' && lcl_ValidChar( rContent[0], rParent)
+if (nFormatType != SvXMLStylesTokens::BOOLEAN_STYLE &&
+((nLength == 1 && lcl_ValidChar( rContent[0], rParent)) ||
+ (nLength == 2 &&
+ ((rContent[0] == ' ' && rContent[1] == '-') ||
+ (rContent[1] == ' ' && lcl_ValidChar( rContent[0], rParent))
{
// Don't quote single separator characters like space or percent,
// or separator characters followed by space (used in date formats).
@@ -541,7 +546,7 @@ static void lcl_EnquoteIfNecessary( OUStringBuffer&
rContent, const SvXMLNumForm
// the difference of quotes.
bQuote = false;
}
-else if ( rParent.GetType() == SvXMLStylesTokens::PERCENTAGE_STYLE &&
nLength > 1 )
+else if ( nFormatType == SvXMLStylesTokens::PERCENTAGE_STYLE && nLength >
1 )
{
// the percent character in percentage styles must be left out of
quoting
// (one occurrence is enough even if there are several percent
characters in the string)
@@ -907,7 +912,7 @@ void SvXMLNumFmtElementContext::endFastElement(sal_Int32 )
}
break;
case SvXMLStyleTokens::Boolean:
-// ignored - only default boolean format is supported
+rParent.AddNfKeyword( NF_KEY_BOOLEAN );
break;
case SvXMLStyleTokens::Day:
@@ -1535,9 +1540,8 @@ sal_Int32
SvXMLNumFormatContext::CreateAndInsert(SvNumberFormatter* pFormatter)
nIndex = pFormatter->GetFormatIndex( NF_NUMBER_SYSTEM, nFormatLang
);
}
-// boolean is always the builtin boolean format
-// (no other boolean formats are implemented)
-if ( nType == SvXMLStylesTokens::BOOLEAN_STYLE )
+if ( nType == SvXMLStylesTokens::BOOLEAN_STYLE && !bHasExtraText &&
+aMyConditions.empty() && sFormat.toChar() != '[' )
nIndex = pFormatter->GetFormatIndex( NF_BOOLEAN, nFormatLang );
// check for default date formats
[Libreoffice-commits] core.git: include/svl svl/source
include/svl/zformat.hxx|4
svl/source/numbers/zformat.cxx | 28 +++-
2 files changed, 31 insertions(+), 1 deletion(-)
New commits:
commit 2932dc7aa0c1239d39e060e6b7627317f1305549
Author: Eike Rathke
AuthorDate: Wed Jun 8 17:43:13 2022 +0200
Commit: Eike Rathke
CommitDate: Wed Jun 8 20:15:19 2022 +0200
Related: tdf#149484 Display BOOLEAN literal string text additions
Change-Id: Ifbaf0b18178091c3a340a7c4bc66f78397aadc18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135506
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/include/svl/zformat.hxx b/include/svl/zformat.hxx
index cd04f96ac8a1..ae57f5c868ed 100644
--- a/include/svl/zformat.hxx
+++ b/include/svl/zformat.hxx
@@ -696,6 +696,10 @@ private:
SVL_DLLPRIVATE static void ImpAppendEraG( OUStringBuffer& OutStringBuffer,
const CalendarWrapper& rCal,
sal_Int16 nNatNum );
+SVL_DLLPRIVATE bool ImpGetLogicalOutput( double fNumber,
+ sal_uInt16 nIx,
+ OUStringBuffer& OutString );
+
SVL_DLLPRIVATE bool ImpGetNumberOutput( double fNumber,
sal_uInt16 nIx,
OUStringBuffer& OutString );
diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx
index dd5b9fe00429..a4756f4982b1 100644
--- a/svl/source/numbers/zformat.cxx
+++ b/svl/source/numbers/zformat.cxx
@@ -2449,7 +2449,7 @@ bool SvNumberformat::GetOutputString(double fNumber,
bool bRes = false;
OutString.clear();
*ppColor = nullptr; // No color change
-if (eType & SvNumFormatType::LOGICAL)
+if (eType & SvNumFormatType::LOGICAL && sFormatstring ==
rScan.GetKeywords()[NF_KEY_BOOLEAN])
{
if (fNumber)
{
@@ -2615,6 +2615,9 @@ bool SvNumberformat::GetOutputString(double fNumber,
case SvNumFormatType::CURRENCY:
bRes |= ImpGetNumberOutput(fNumber, nIx, sBuff);
break;
+case SvNumFormatType::LOGICAL:
+bRes |= ImpGetLogicalOutput(fNumber, nIx, sBuff);
+break;
case SvNumFormatType::FRACTION:
bRes |= ImpGetFractionOutput(fNumber, nIx, sBuff);
break;
@@ -4287,6 +4290,29 @@ bool SvNumberformat::ImpGetDateTimeOutput(double fNumber,
return bRes;
}
+bool SvNumberformat::ImpGetLogicalOutput(double fNumber,
+ sal_uInt16 nIx,
+ OUStringBuffer& sStr)
+{
+bool bRes = false;
+const ImpSvNumberformatInfo& rInfo = NumFor[nIx].Info();
+const sal_uInt16 nCnt = NumFor[nIx].GetCount();
+for (sal_uInt16 j = 0; j < nCnt; ++j)
+{
+switch (rInfo.nTypeArray[j])
+{
+case NF_KEY_BOOLEAN:
+sStr.append( fNumber ? rScan.GetTrueString() :
rScan.GetFalseString());
+break;
+case NF_SYMBOLTYPE_STRING:
+sStr.append( rInfo.sStrArray[j]);
+break;
+}
+}
+impTransliterate(sStr, NumFor[nIx].GetNatNum());
+return bRes;
+}
+
bool SvNumberformat::ImpGetNumberOutput(double fNumber,
sal_uInt16 nIx,
OUStringBuffer& sStr)
Google Drive iIntegration
I am trying to understand what libraries or code is used to integrate my Google Online account, Google Drive folders, in the File Open menu of Writer. I am using Ubuntu 22.04 LTS Desktop version. I am unclear on why some apps show the Network shares like OWriter, while others like VScode do not. Is this configuration issue or an underlying lack of feature inclusion in VS Code? Thanks
[no subject]
All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license.
Re: Review for initial a11y C++ test conversion
Le 08/06/2022 à 14:54, Caolán McNamara a écrit : On Thu, 2022-05-19 at 18:26 +0200, Colomban Wendling wrote: Hello everyone, I'm looking for someone to review https://gerrit.libreoffice.org/c/core/+/133844. merged now Thanks to everyone giving advice and reviewing, much appreciated. I also just published an initial version of potentially useful info I gathered during the process for this first step at https://wiki.documentfoundation.org/Development/Accessibility_Unit_Tests, in the hope it would help anyone else interested in porting similar tests to CppUnit -- or writing new ones. This will all be expanded as I go along and work on subsequent a11y test areas. Regards, Colomban
Building LibreOffice on Raspberry Pi 4
Hello,
I was trying to build LibreOffice master on 32 bit armhf Debian 10
(Official Raspbian) on Raspberry Pi 4. I could compile and run
LibreOffice successfully, but some changes were necessary. Here's how:
First, some information about the OS:
$ cat /etc/os-release
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/;
SUPPORT_URL="http://www.raspbian.org/RaspbianForums;
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs;
This is my build configuration:
$ cat autogen.input
--with-jdk-home=/usr/lib/jvm/java-11-openjdk-armhf
--enable-dbgutil
--without-doxygen
--disable-pdfium
This was the problem with pdfium, so I disabled it:
[CXX]
workdir/UnpackedTarball/pdfium/third_party/base/allocator/partition_allocator/partition_oom.cpp
{standard input}: Assembler messages:
{standard input}:194: Error: selected processor does not support `yield'
in ARM mode
make[1]: *** [/home/pi/Projects/core/solenv/gbuild/LinkTarget.mk:404:
/home/pi/Projects/core/workdir/GenCxxObject/UnpackedTarball/pdfium/third_party/base/allocator/partition_allocator/spin_lock.o]
Error 1
Then, I had this problem:
cd . && /bin/bash
/home/pi/Projects/libo/core/workdir/UnpackedTarball/hunspell/missing
automake-1.15 --gnu
configure.ac:11: error: version mismatch. This is Automake 1.15.1,
configure.ac:11: but the definition used by this AM_INIT_AUTOMAKE
configure.ac:11: comes from Automake 1.15. You should recreate
configure.ac:11: aclocal.m4 with aclocal and run automake again.
WARNING: 'automake-1.15' is probably too old.
You should only need it if you modified 'Makefile.am' or
'configure.ac' or m4 files included by 'configure.ac'.
The 'automake' program is part of the GNU Automake package:
It also requires GNU Autoconf, GNU m4 and Perl in order to run:
[Libreoffice-bugs] [Bug 149455] [LOCALHELP] Update Formatting Aids Option Help page with image anchoring option
https://bugs.documentfoundation.org/show_bug.cgi?id=149455 Gabriele Ponzo changed: What|Removed |Added CC||gpo...@gmail.com --- Comment #1 from Gabriele Ponzo --- I can confirm the bug on this version: Version: 7.3.3.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: it-IT (it_IT.UTF-8); UI: en-GB Ubuntu package version: 1:7.3.3~rc2-0ubuntu0.20.04.1~lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Bug 42082 depends on bug 138192, which changed state. Bug 138192 Summary: Provide arm64 or x86-64/arm64 Universal Binary builds for macOS on Apple Silicon https://bugs.documentfoundation.org/show_bug.cgi?id=138192 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138192] Provide arm64 or x86-64/arm64 Universal Binary builds for macOS on Apple Silicon
https://bugs.documentfoundation.org/show_bug.cgi?id=138192 Sierk Bornemann changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: external/libtiff
external/libtiff/ExternalProject_libtiff.mk |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 98cfc7db5ed352b2ddb9a547c7f88abb83264cef Author: Jan-Marek Glogowski AuthorDate: Wed Jun 8 17:44:56 2022 +0200 Commit: Jan-Marek Glogowski CommitDate: Wed Jun 8 18:53:32 2022 +0200 libtiff WASM: add Emscripten flags to fix NEH build Change-Id: I3ea1ca064cdddee1bea6b5816f63f0e4a93217de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135505 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/external/libtiff/ExternalProject_libtiff.mk b/external/libtiff/ExternalProject_libtiff.mk index 04af18322541..e318126dcfe0 100644 --- a/external/libtiff/ExternalProject_libtiff.mk +++ b/external/libtiff/ExternalProject_libtiff.mk @@ -50,7 +50,7 @@ $(call gb_ExternalProject_get_state_target,libtiff,build) : --with-pic \ --without-x \ $(if $(verbose),--disable-silent-rules,--enable-silent-rules) \ - CFLAGS="$(CFLAGS) $(call gb_ExternalProject_get_build_flags,libtiff)" \ + CFLAGS="$(CFLAGS) $(call gb_ExternalProject_get_build_flags,libtiff) $(gb_EMSCRIPTEN_CFLAGS)" \ $(if $(SYSTEM_ZLIB),,--with-zlib-include-dir="$(call gb_UnpackedTarball_get_dir,zlib)") \ $(if $(SYSTEM_ZLIB),,--with-zlib-lib-dir="$(gb_StaticLibrary_WORKDIR)") \ $(if $(SYSTEM_LIBJPEG),,--with-jpeg-include-dir="$(call gb_UnpackedTarball_get_dir,libjpeg-turbo)") \ @@ -59,8 +59,8 @@ $(call gb_ExternalProject_get_state_target,libtiff,build) : $(if $(SYSTEM_LIBWEBP),,$(if $(filter WNT,$(OS_FOR_BUILD)),\ --with-webp-lib-dir="$(call gb_UnpackedTarball_get_dir,libwebp)/output/lib/libwebp$(if $(MSVC_USE_DEBUG_RUNTIME),_debug)$(gb_StaticLibrary_PLAINEXT)", \ --with-webp-lib-dir="$(call gb_UnpackedTarball_get_dir,libwebp)/src/.libs")) \ - CPPFLAGS="$(CPPFLAGS) $(BOOST_CPPFLAGS)" \ - LDFLAGS="$(call gb_ExternalProject_get_link_flags,libtiff)" \ + CPPFLAGS="$(CPPFLAGS) $(BOOST_CPPFLAGS) $(gb_EMSCRIPTEN_CPPFLAGS)" \ + LDFLAGS="$(call gb_ExternalProject_get_link_flags,libtiff) $(gb_EMSCRIPTEN_LDFLAGS)" \ ac_cv_lib_z_inflateEnd=yes \ ac_cv_lib_jpeg_jpeg_read_scanlines=yes \ ac_cv_lib_webp_WebPDecode=yes \
[Libreoffice-bugs] [Bug 149111] Crash when attempting to add MP4 file to Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=149111 Suthagar changed: What|Removed |Added CC||johnsuthagar...@gmail.com --- Comment #2 from Suthagar --- Created attachment 180642 --> https://bugs.documentfoundation.org/attachment.cgi?id=180642=edit in impress a video inserted but it looks music icon and also it is not working Version: 7.4.0.0.alpha1+ / LibreOffice Community Build ID: f2d2334b032780d97f7a95aacb8283008e91c529 CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Calc: threaded OS : Linux mint 20.3 : 5.4.0-117-generic Steps to Reproduce: 1.Open the Libreoffice impress 2.Add 2 more slides 3.insert the video 4.Look the video icon Actual result:- Its look like music icon and it is not playable. Expected Result:- It should be look like video icon.it should play -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: compilerplugins/clang fpicker/source framework/source include/tools include/vcl reportdesign/source sfx2/source solenv/clang-format sw/source vcl/headless vcl/inc vcl/o
compilerplugins/clang/unusedenumconstants.untouched.results |4 compilerplugins/clang/unusedenumconstants.writeonly.results |2 fpicker/source/office/RemoteFilesDialog.cxx |2 fpicker/source/office/iodlg.cxx |2 framework/source/helper/persistentwindowstate.cxx |2 include/tools/gen.hxx |8 include/vcl/WindowPosSize.hxx | 137 include/vcl/syswin.hxx |6 include/vcl/vclenum.hxx | 39 - include/vcl/weld.hxx|3 include/vcl/windowstate.hxx | 98 ++- include/vcl/wrkwin.hxx |2 reportdesign/source/ui/dlg/Formula.cxx |2 reportdesign/source/ui/report/DesignView.cxx|4 reportdesign/source/ui/report/ReportController.cxx |2 sfx2/source/appl/childwin.cxx |8 sfx2/source/dialog/basedlgs.cxx |4 sfx2/source/dialog/recfloat.cxx |9 solenv/clang-format/excludelist |1 sw/source/ui/misc/bookmark.cxx |3 sw/source/uibase/envelp/syncbtn.cxx |9 vcl/headless/svpframe.cxx | 76 +- vcl/inc/headless/svpframe.hxx |4 vcl/inc/osx/salframe.h |4 vcl/inc/qt5/QtFrame.hxx |4 vcl/inc/salframe.hxx| 12 vcl/inc/salgeom.hxx | 101 ++- vcl/inc/salvtables.hxx |2 vcl/inc/salwtype.hxx| 21 vcl/inc/unx/gtk/gtkframe.hxx|6 vcl/inc/unx/salframe.h |4 vcl/inc/win/salframe.h |8 vcl/inc/window.h|4 vcl/osx/salframe.cxx| 183 ++--- vcl/osx/salframeview.mm | 34 - vcl/osx/salgdiutils.cxx |4 vcl/osx/salmenu.cxx |8 vcl/osx/salnativewidgets.cxx|4 vcl/qt5/QtFrame.cxx | 92 +- vcl/qt5/QtMainWindow.cxx|3 vcl/qt5/QtWidget.cxx|7 vcl/quartz/AquaGraphicsBackend.cxx |2 vcl/source/app/salvtables.cxx |2 vcl/source/gdi/salgdilayout.cxx |4 vcl/source/window/dockwin.cxx | 22 vcl/source/window/event.cxx |4 vcl/source/window/menu.cxx |2 vcl/source/window/printdlg.cxx |2 vcl/source/window/syswin.cxx| 337 +- vcl/source/window/window.cxx| 46 - vcl/source/window/winproc.cxx |4 vcl/source/window/wrkwin.cxx| 31 vcl/unx/generic/app/wmadaptor.cxx | 87 +- vcl/unx/generic/gdi/gdiimpl.cxx |4 vcl/unx/generic/window/salframe.cxx | 378 +--- vcl/unx/gtk3/gtkframe.cxx | 204 ++ vcl/unx/gtk3/gtkinst.cxx| 57 - vcl/unx/gtk3/gtksalmenu.cxx |4 vcl/win/gdi/gdiimpl.cxx |4 vcl/win/window/salframe.cxx | 145 ++-- 60 files changed, 1139 insertions(+), 1128 deletions(-) New commits: commit ea5a0918c8c32309821ab239c4b95f4d6a3b5c12 Author: Jan-Marek Glogowski AuthorDate: Thu Jun 2 22:42:20 2022 +0200 Commit: Jan-Marek Glogowski CommitDate: Wed Jun 8 18:17:17 2022 +0200 VCL add vcl::WindowPosSize abstract class ... and use it to remove a duplicate and simplify code. Should mostly be a refactoring, which was mainly done by some larger sed calls, except for the new API calls, which helped shrinking some LOC. All data is also now private. Originally two of the "replaced" "classes" had unsigned width and height and one had signed. Noel pointed out, that during calculations, the value might get negative temporarly, so this now settles with signed
[Libreoffice-bugs] [Bug 149075] Windows 10 Skia: Writer closes after startup
https://bugs.documentfoundation.org/show_bug.cgi?id=149075 Luboš Luňák changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #15 from Luboš Luňák --- Can you please use https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg to provide a backtrace for the crash? If the only information about the problem is "it crashes" there's not much that can be done about it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148624] Crash in: GrVkPipelineState::setAndBindInputAttachment(GrVkGpu *,gr_sp
https://bugs.documentfoundation.org/show_bug.cgi?id=148624 Luboš Luňák changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED --- Comment #3 from Luboš Luňák --- https://bugs.chromium.org/p/skia/issues/detail?id=13402 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149491] New: Find & Replace replaces too many characters
https://bugs.documentfoundation.org/show_bug.cgi?id=149491 Bug ID: 149491 Summary: Find & Replace replaces too many characters Product: LibreOffice Version: Inherited From OOo Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreoff...@bielefeldundbuss.de Created attachment 180641 --> https://bugs.documentfoundation.org/attachment.cgi?id=180641=edit Sample Document Steps how to reproduce with Server Installation of Version: 7.4.0.0.alpha0+ (x64) Build ID b871abad383583f02eb49c7e49aeae01f6941072 CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE | Calc: CL | Auto Colibre Theme | Newly created User Profile: 0. Open attached sample document 1. Menu ˋFind → Replaceˊ » Dialog opens 3. Check "Reglar Expressions" 4. Type serch string "^r" (without Quotations Marks), leave Replace string empty 5. [Find all] » all first "r" of a paragraph will be highlighted 6. [Replace all] » Expected: only leading "r" of paragraph will be deleted » Actual: all "r" will be deleted and it does not matter whether you replace forward or backward 10. Close without saving and reopen 0. Open attached sample document 11. Menu ˋFind → Replaceˊ » Dialog opens 13. Check "Regular Expressions" 14. Type search string "r$" (without Quotations Marks), leave Replace string empty 15. [Find all] » all first "r" of a paragraph will be highlighted 16. [Replace all] » Expected: only "r" at end of paragraph (= end of line) will be deleted » Actual: as expected and it does not matter whether you replace forward or backward Additional info: - a) That's a strange difference between 'delete all first "r"' and 'delete all last "r"'. I think it's a bug, not a feature. b) Additional research shows a possible reason: If you replace one by one you see that the highlighting will stay at the old place as long as there is a paragraph leading "r". Only when there is nor more "r" in the line (and so also no leading "r" highlighting jumps to next line b1) You might argue that that is intended. I can follow with some tummy ache b2) 'Replace Backwards' changes the behavior, after having replaced highlighting jumps to line before. but continuing highlighting will go around and around as long as no more "r" has survived But: c) Proceeding as (b) for r$ paragraph terminating "r" shows a different behavior in details, but the result will be the same no "r" will survive if you press [Replace] often enough. d) I did not test all details, but difference between (6) and (16) has been inherited from OOo My concern: --- Different behavior in 6: deletes all "r" and 16: only deletes all LAST "r" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149425] EDITING: Business Cards
https://bugs.documentfoundation.org/show_bug.cgi?id=149425 Pierre Fortin changed: What|Removed |Added Attachment #180639|Test in frame 2 |Text in frame 2 description|| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149425] EDITING: Business Cards
https://bugs.documentfoundation.org/show_bug.cgi?id=149425 --- Comment #19 from Pierre Fortin --- Created attachment 180640 --> https://bugs.documentfoundation.org/attachment.cgi?id=180640=edit Business card file used for screenshots Here's the file I'm working with; hopefully you can reproduce with it... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149425] EDITING: Business Cards
https://bugs.documentfoundation.org/show_bug.cgi?id=149425 --- Comment #18 from Pierre Fortin --- Created attachment 180639 --> https://bugs.documentfoundation.org/attachment.cgi?id=180639=edit Test in frame 2 Selected text in frame 2. Hit left arrow and "Lastname" was unselected and cursor moves left/right with left/right arrows. Re-selected "Lastname" and hit: Alt+up_arrow 5 times Alt+left_arrow 5 times and frame moves. Other than the Master Frame (#1), all other frames are normally locked in position, except for this case. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa sw/source writerfilter/qa writerfilter/source
sw/qa/extras/rtfexport/rtfexport3.cxx | 58
++
sw/qa/filter/ww8/ww8.cxx |2
sw/source/filter/ww8/rtfattributeoutput.cxx | 46
++-
sw/source/filter/ww8/rtfattributeoutput.hxx |3
writerfilter/qa/cppunittests/rtftok/data/negative-page-border.rtf |7 +
writerfilter/qa/cppunittests/rtftok/rtfdispatchvalue.cxx | 30 +
writerfilter/source/rtftok/rtfdispatchvalue.cxx | 13 ++
7 files changed, 148 insertions(+), 11 deletions(-)
New commits:
commit d4123356c61db269651e950a0a2cc93e6d801c90
Author: Miklos Vajna
AuthorDate: Wed Jun 8 17:05:42 2022 +0200
Commit: Miklos Vajna
CommitDate: Wed Jun 8 17:46:58 2022 +0200
RTF filter: allow measuring page borders from the edge of the page
This is similar to commit 51942eafdb4439559b6d59f3becd4afab45277f0 (DOC
import: allow negative page border distances, 2022-06-08), except here
we map \pgbrdropt's 5th bit to the "from page edge" bool, and then the
rest of the import works already after the DOCX fixes.
Similarly, the export has to map the "from page edge" bool to \pgbrdropt
and has to call into editeng::BorderDistancesToWord(), but the rest of
the process works after the DOCX fixes.
Change-Id: Ic88f1ab17ac169025c38790ffa895748df0a76c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135502
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/qa/extras/rtfexport/rtfexport3.cxx
b/sw/qa/extras/rtfexport/rtfexport3.cxx
index 665682c7532c..bd8a1c8dc795 100644
--- a/sw/qa/extras/rtfexport/rtfexport3.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport3.cxx
@@ -22,6 +22,12 @@
#include
#include
+#include
+#include
+#include
+#include
+#include
+
using namespace css;
class Test : public SwModelTestBase
@@ -434,6 +440,58 @@ CPPUNIT_TEST_FIXTURE(Test, testRtlGutter)
verify();
}
+CPPUNIT_TEST_FIXTURE(Test, testNegativePageBorder)
+{
+{
+// Given a document with a top margin and a border which has more
spacing than the margin on
+// its 2nd page:
+createSwDoc();
+SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
+SwDocShell* pDocShell = pTextDoc->GetDocShell();
+SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
+pWrtShell->Insert("first");
+pWrtShell->SplitNode();
+pWrtShell->Insert("second");
+SwPageDesc* pDesc = pWrtShell->FindPageDescByName("Left Page", true);
+SwPaM aPaM(*pWrtShell->GetCursor()->GetPoint());
+SwFormatPageDesc aFormatPageDesc(pDesc);
+
pDocShell->GetDoc()->getIDocumentContentOperations().InsertPoolItem(aPaM,
aFormatPageDesc);
+uno::Reference xPageStyle(
+getStyles("PageStyles")->getByName("Left Page"), uno::UNO_QUERY);
+xPageStyle->setPropertyValue("TopMargin",
uno::Any(static_cast(501)));
+table::BorderLine2 aBorder;
+aBorder.LineWidth = 159;
+aBorder.OuterLineWidth = 159;
+xPageStyle->setPropertyValue("TopBorder", uno::Any(aBorder));
+sal_Int32 nTopBorderDistance = -646;
+xPageStyle->setPropertyValue("TopBorderDistance",
uno::Any(nTopBorderDistance));
+pDocShell->GetDoc()->dumpAsXml();
+}
+
+// When saving that document to RTF:
+reload(mpFilter, "negative-page-border.rtf");
+
+// Then make sure that the border distance is negative, so the first line
of body text appears
+// on top of the page border:
+SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
+SwDocShell* pDocShell = pTextDoc->GetDocShell();
+SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
+pWrtShell->Down(/*bSelect=*/false);
+OUString aPageStyle = pWrtShell->GetCurPageStyle();
+uno::Reference
xPageStyle(getStyles("PageStyles")->getByName(aPageStyle),
+ uno::UNO_QUERY);
+auto nTopMargin =
xPageStyle->getPropertyValue("TopMargin").get();
+CPPUNIT_ASSERT_EQUAL(static_cast(501), nTopMargin);
+auto aTopBorder =
xPageStyle->getPropertyValue("TopBorder").get();
+CPPUNIT_ASSERT_EQUAL(static_cast(159), aTopBorder.LineWidth);
+auto nTopBorderDistance =
xPageStyle->getPropertyValue("TopBorderDistance").get();
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: -646
+// - Actual : 0
+// i.e. the border negative distance was lost.
+CPPUNIT_ASSERT_EQUAL(static_cast(-646), nTopBorderDistance);
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/qa/filter/ww8/ww8.cxx b/sw/qa/filter/ww8/ww8.cxx
index eb735b16a746..7ccb1299769e 100644
--- a/sw/qa/filter/ww8/ww8.cxx
+++ b/sw/qa/filter/ww8/ww8.cxx
@@ -26,7 +26,7 @@ class Test : public SwModelTestBase
{
};
-CPPUNIT_TEST_FIXTURE(Test, testSwAttrSet)
[Libreoffice-bugs] [Bug 149490] New: multiple copies of Table Properties dialog can be opened from Table toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=149490 Bug ID: 149490 Summary: multiple copies of Table Properties dialog can be opened from Table toolbar Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk 1. Make table, place cursor in a cell, find or open Table toolbar. 2. Click "Properties" icon (at right end of toolbar) multiple times. Actual: Table Properties dialog appears each time the icon is clicked. Expected: Only one dialog is opened; additional clicks return to the open dialog. Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: bbec710bd25fc5da27636cde73fe4ab23c76904f CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
