[Libreoffice] (no subject)

2010-11-20 Thread Sebastian Spaeth
Hi all, here some nice stats. Summary, is that we lost 34,000 lines of code since we started to code on LO... I used SLOCCount by David A. Wheeler to check our project size. At the time of the fork ie the LIBREOFFICE_CREATE tag our clone directory was this big: Total Physical Source Lines of

Re: [Libreoffice] [Patch][EasyHacks] Replace ScfRef with boost::shared_ptr in calc filter code

2010-11-20 Thread Nigel Hawkins
On Fri, 2010-11-19 at 20:31 -0500, Kohei Yoshida wrote: Great work! I've applied all your patches and committed as a single commit. I hope that's okay. Not a problem. I generally commit locally in very small chunks and then format-patch generates one patch per commit. I can squash them

Re: [Libreoffice] [PUSHED] RTL easy hack against bridges/

2010-11-20 Thread David Tardon
On Fri, Nov 19, 2010 at 10:11:49AM -0500, Kevin Hunter wrote: Hullo List, A simple one against but test cases, but, as I said in the commit message, they were in my (grep) road! Kevin Pushed. D. ___ LibreOffice mailing list

[Libreoffice] [PATCH] remove the bogus comments lying around

2010-11-20 Thread Gabriel Monnerat
Hello, Here's a patch to remove some bogus comments. -- Gabriel M. Monnerat remove_bogus_comments.patch.tar Description: Unix tar archive ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] newish to git: howto recover from bad merge?

2010-11-20 Thread Wols Lists
On 19/11/10 08:11, Kevin Hunter wrote: Hullo List, It must be something simple, but I'm having a devil of a time recovering from a bad merge. Given my transcript below, how do I recover? It usually happens after I've committed a change to my local repository, that I then sent in as a

Re: [Libreoffice] Location of SfxPoolItem.Type() method

2010-11-20 Thread Mattias Johnsson
On 21 November 2010 01:04, Miklos Vajna vmik...@frugalware.org wrote: On Sun, Nov 21, 2010 at 12:21:08AM +1100, Mattias Johnsson m.t.johns...@gmail.com wrote: int SfxPoolItem::operator==( const SfxPoolItem rCmp ) const {     DBG_CHKTHIS(SfxPoolItem, 0);     return rCmp.Type() == Type(); }

Re: [Libreoffice] [PUSHED] RTL goodness against filters/

2010-11-20 Thread Kevin Hunter
At 2:22am -0500 Sat, 20 Nov 2010, David Tardon wrote: On Fri, Nov 19, 2010 at 03:04:52PM -0500, Kevin Hunter wrote: Some more RTL goodness against filters/. I corrected two obviously wrong changes: Thank you for checking those. I caught three of those, but missed those two. For the

Re: [Libreoffice] Issues Wiki

2010-11-20 Thread Gioele Barabucci
Júlio Hoffimann 20/11/2010 02:17: There is a issues wiki for LibreOffice? A place where users can report bugs, talk about new features, etc. We need some inspiration to contribute. :-) There is a bug and enhancement tracker hosted at freedesktop.org. You can file issues and ask for new

Re: [Libreoffice] newish to git: howto recover from bad merge?

2010-11-20 Thread Kevin Hunter
At 9:16am -0500 Sat, 20 Nov 2010, Wols Lists wrote: Firstly, I'm slightly surprised no-one suggested merely reverting your patch. But I'm guessing all you want to do is get rid of your patch and replace it with the official one - so just dropping your version should do what you want? This

Re: [Libreoffice] Issues Wiki

2010-11-20 Thread Júlio Hoffimann
Thanks Gioele, but i'm looking for something like this http://code.google.com/p/gaosp/issues/list Would be helpful if some wiki exists. http://code.google.com/p/gaosp/issues/listJúlio. 2010/11/20 Gioele Barabucci gio...@svario.it Júlio Hoffimann 20/11/2010 02:17: There is a issues wiki for

Re: [Libreoffice] Issues Wiki

2010-11-20 Thread Gioele Barabucci
Júlio Hoffimann 20/11/2010 17:06: Thanks Gioele, but i'm looking for something like this http://code.google.com/p/gaosp/issues/list Would be helpful if some wiki exists. The list of open bugs and enhancement requests is available at

Re: [Libreoffice] question about memory leak detected by cppcheck

2010-11-20 Thread Caolán McNamara
On Sat, 2010-11-20 at 08:37 +0100, Julien Nabet wrote: SfxAllEnumValue_Impl *pVal = new SfxAllEnumValue_Impl; ... const SfxAllEnumValue_Impl *pTemp = pVal; ... pValues-Insert( pTemp, nPos ); And cppcheck says : Checking

[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/drivers

2010-11-20 Thread Caolán McNamara
On Fri, 2010-11-19 at 22:53 +0100, Julien Nabet wrote: Hello, Here's patch for the last changes to do that I've seen in libs-core/connectivity/drivers -(::rtl::OUString::createFromAscii( i18n(Address Book) )); +(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( i18n(Address

[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core

2010-11-20 Thread Caolán McNamara
On Fri, 2010-11-19 at 23:23 +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core Looks good, top part was duplicate of previous patch. So pushed the extra bits. Thanks for this. When I see an empty sting being created, e.g. OUString::createFromAscii() best to just replace it with

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/fpicker

2010-11-20 Thread Julien Nabet
Hello, Here's a patch for libs-core/fpicker Julien. (LGPLv3+ / MPL) libs_core_fpicker.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/fpicker

2010-11-20 Thread Caolán McNamara
On Sat, 2010-11-20 at 17:50 +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core/fpicker Looks all good. Thanks for this. I did leave out the changes inside the VISTAFILEDIALOG_CHECKED_COMCALL macro. as its inside a define where the parameter is passed into it, so it can't be

Re: [Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/drivers

2010-11-20 Thread Caolán McNamara
On Sun, 2010-11-21 at 02:36 +0900, Takeshi Abe wrote: Both versions of i18n return a QString. Thanks. Yeah, and with an operator to convert to const char*, not a candidate for RTL_CONSTASCII_USTRINGPARAM then. The check I have in the rostrings branch would catch that when integrated once I

[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/embeddedobj

2010-11-20 Thread Caolán McNamara
On Sat, 2010-11-20 at 13:47 +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core/embeddedobj Thanks for this. Pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[Libreoffice] [PATCH] binfilter/ : #if 0 removals

2010-11-20 Thread Kevin Hunter
Hullo List, Some #if 0 removals in binfilter. Cheers, Kevin if0_removals.txz Description: application/xz-compressed-tar ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] feature/rip-build-repo - branch for removal of the need of the 'build' repo

2010-11-20 Thread Norbert Thiebaud
On Thu, Nov 18, 2010 at 10:18 PM, Jan Holesovsky ke...@suse.cz wrote: Hi, In case you are interested to try to build without the 'build' repo (the rawbuild/ way), you can try to get the feature/rip-build-repo branch which I hope is going to become the 'official' way of building soon ;-) btw,

Re: [Libreoffice] LibreOffice Beta 3

2010-11-20 Thread NoOp
On 11/19/2010 04:34 PM, Kevin Hunter wrote: At 6:54pm -0500 Fri, 19 Nov 2010, David Burleigh wrote: I am running LibreOffice Beta 3 under Ubuntu 10.10 (64-bit) and it seems to gradually bog down with use, so that I have to exit and restart it several times a day. It gets so that cursor

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/framework

2010-11-20 Thread Julien Nabet
Hello, Here's a patch for libs-core/framework Julien. (LGPLv3+ / MPL) diff --git a/framework/source/jobs/jobdata.cxx b/framework/source/jobs/jobdata.cxx index 55cda74..09b2165 100644 --- a/framework/source/jobs/jobdata.cxx +++ b/framework/source/jobs/jobdata.cxx @@ -182,7 +182,7 @@ void