Re: [Libreoffice] [PATCH] Fix configure check for BerkleyDB where db_create is macro
if we use that simol it might break other versions of db. On (2011-01-10 10:16), Gökçen Eraslan wrote: > Perşembe 06 Ocak 2011 günü (saat 20:03:28) Petr Mladek şunlar?? yazm??şt??: > > Hi, > > > > this fixed the problem described in the attached mail. > > > > Gökçen, Robert, could you please test it and sign it out for > > libreoffice-3-3 branch? > > > > No, I only have __db185_open_4008 symbol in libdb.so, here is the result: > > checking for db-5.1/db.h... no > checking for db5.1/db.h... no > checking for db-5.0/db.h... no > checking for db5.0/db.h... no > checking for db-5/db.h... no > checking for db5/db.h... no > checking for db-4.8/db.h... no > checking for db4.8/db.h... no > checking for db-4.7/db.h... no > checking for db4.7/db.h... no > checking for db-4/db.h... no > checking for db4/db.h... no > checking for db/db.h... no > checking db.h usability... yes > checking db.h presence... yes > checking for db.h... yes > checking whether db is at least 4.1... yes > checking for dbopen in -ldb... no > checking for __db185_open in -ldb... no > checking for dbopen in -ldb-5.1... no > checking for __db185_open in -ldb-5.1... no > checking for dbopen in -ldb5.1... no > checking for __db185_open in -ldb5.1... no > checking for dbopen in -ldb-5.0... no > checking for __db185_open in -ldb-5.0... no > checking for dbopen in -ldb5.0... no > checking for __db185_open in -ldb5.0... no > checking for dbopen in -ldb-5... no > checking for __db185_open in -ldb-5... no > checking for dbopen in -ldb5... no > checking for __db185_open in -ldb5... no > checking for dbopen in -ldb-4.8... no > checking for __db185_open in -ldb-4.8... no > checking for dbopen in -ldb4.8... no > checking for __db185_open in -ldb4.8... no > checking for dbopen in -ldb-4.7... no > checking for __db185_open in -ldb-4.7... no > checking for dbopen in -ldb4.7... no > checking for __db185_open in -ldb4.7... no > checking for dbopen in -ldb-4... no > checking for __db185_open in -ldb-4... no > checking for dbopen in -ldb4... no > checking for __db185_open in -ldb4... no > configure: error: db not installed or functional > > > Here is the symbols in libdb.so file containing open keyword: > > $ nm -D -C /usr/lib/libdb.so |grep open > > 00036a10 T __bam_open_4008 > 00025ea0 T __db185_open_4008 > 000eb1d0 T __db_get_open_flags_4008 > 000cb740 T __db_master_open_4008 > 00105000 T __db_mi_open_4008 > 000fbc40 T __db_ndbm_open_4008 > 000eb290 T __db_open_4008 > 000e52b0 T __db_open_pp_4008 > 00133150 T __db_openflags_4008 > 00105f90 T __db_tmp_open_4008 > 000ffc90 T __dbreg_do_open_4008 > 00106bb0 T __env_get_open_flags_4008 > 00107200 T __env_open_4008 > 00107450 T __env_open_pp_4008 > 00107a60 T __env_openfiles_4008 > 0006a040 T __ham_open_4008 > 000bf240 T __lock_open_4008 > 001180f0 T __log_open_4008 > 00127d90 T __memp_fopen_4008 > 00128d90 T __memp_fopen_pp_4008 > 00129fa0 T __memp_get_mp_max_openfd_4008 > 0012d780 T __memp_open_4008 > 0012a130 T __memp_set_mp_max_openfd_4008 > 000c2d30 T __mutex_open_4008 > 001350d0 T __os_open_4008 > 001342f0 T __os_openhandle_4008 > 00137cd0 T __partition_open_4008 > 000820c0 T __qam_open_4008 > 00040340 T __ram_open_4008 > 0009c650 T __rep_open_4008 > 000ab600 T __repmgr_open_4008 > 00146840 T __txn_open_4008 > 00145c50 T __txn_openfiles_4008 > 00134ec0 T db_env_set_func_open_4008 > U fopen > U open > U opendir > > > ... > > > > > Best Regards, > > Petr > > -- > Gökçen Eraslan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix configure check for BerkleyDB where db_create is macro
Perşembe 06 Ocak 2011 günü (saat 20:03:28) Petr Mladek şunları yazmıştı: > Hi, > > this fixed the problem described in the attached mail. > > Gökçen, Robert, could you please test it and sign it out for > libreoffice-3-3 branch? > No, I only have __db185_open_4008 symbol in libdb.so, here is the result: checking for db-5.1/db.h... no checking for db5.1/db.h... no checking for db-5.0/db.h... no checking for db5.0/db.h... no checking for db-5/db.h... no checking for db5/db.h... no checking for db-4.8/db.h... no checking for db4.8/db.h... no checking for db-4.7/db.h... no checking for db4.7/db.h... no checking for db-4/db.h... no checking for db4/db.h... no checking for db/db.h... no checking db.h usability... yes checking db.h presence... yes checking for db.h... yes checking whether db is at least 4.1... yes checking for dbopen in -ldb... no checking for __db185_open in -ldb... no checking for dbopen in -ldb-5.1... no checking for __db185_open in -ldb-5.1... no checking for dbopen in -ldb5.1... no checking for __db185_open in -ldb5.1... no checking for dbopen in -ldb-5.0... no checking for __db185_open in -ldb-5.0... no checking for dbopen in -ldb5.0... no checking for __db185_open in -ldb5.0... no checking for dbopen in -ldb-5... no checking for __db185_open in -ldb-5... no checking for dbopen in -ldb5... no checking for __db185_open in -ldb5... no checking for dbopen in -ldb-4.8... no checking for __db185_open in -ldb-4.8... no checking for dbopen in -ldb4.8... no checking for __db185_open in -ldb4.8... no checking for dbopen in -ldb-4.7... no checking for __db185_open in -ldb-4.7... no checking for dbopen in -ldb4.7... no checking for __db185_open in -ldb4.7... no checking for dbopen in -ldb-4... no checking for __db185_open in -ldb-4... no checking for dbopen in -ldb4... no checking for __db185_open in -ldb4... no configure: error: db not installed or functional Here is the symbols in libdb.so file containing open keyword: $ nm -D -C /usr/lib/libdb.so |grep open 00036a10 T __bam_open_4008 00025ea0 T __db185_open_4008 000eb1d0 T __db_get_open_flags_4008 000cb740 T __db_master_open_4008 00105000 T __db_mi_open_4008 000fbc40 T __db_ndbm_open_4008 000eb290 T __db_open_4008 000e52b0 T __db_open_pp_4008 00133150 T __db_openflags_4008 00105f90 T __db_tmp_open_4008 000ffc90 T __dbreg_do_open_4008 00106bb0 T __env_get_open_flags_4008 00107200 T __env_open_4008 00107450 T __env_open_pp_4008 00107a60 T __env_openfiles_4008 0006a040 T __ham_open_4008 000bf240 T __lock_open_4008 001180f0 T __log_open_4008 00127d90 T __memp_fopen_4008 00128d90 T __memp_fopen_pp_4008 00129fa0 T __memp_get_mp_max_openfd_4008 0012d780 T __memp_open_4008 0012a130 T __memp_set_mp_max_openfd_4008 000c2d30 T __mutex_open_4008 001350d0 T __os_open_4008 001342f0 T __os_openhandle_4008 00137cd0 T __partition_open_4008 000820c0 T __qam_open_4008 00040340 T __ram_open_4008 0009c650 T __rep_open_4008 000ab600 T __repmgr_open_4008 00146840 T __txn_open_4008 00145c50 T __txn_openfiles_4008 00134ec0 T db_env_set_func_open_4008 U fopen U open U opendir ... > > Best Regards, > Petr -- Gökçen Eraslan signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] segfault in libqa_unit.so test
On Fri, Jan 07, 2011 at 09:52:31AM +, Caolán McNamara wrote: > On Fri, 2011-01-07 at 03:21 +0100, Thomas Klausner wrote: > > Is that the end of the build? > > Yup, good news. > > > (Where did the nice graphics go? ;) ) > > > > Thank you! How do we continue with this? > > Well, make dev-install and see if it runs :-) > > The _exit is of course a temporary hack, but it tests the theory that > your crashes were related to post-main problems, probably some global > object dtor problems of some kind. So we really need to isolate that > better, e.g. removing the _exit hack and tweak solenv/inc/settings.mk > > - CPPUNITTESTER=$(AUGMENT_LIBRARY_PATH_LOCAL) $(GDBCPPUNITTRACE) > $(SOLARBINDIR)/cppunittester > + CPPUNITTESTER=$(AUGMENT_LIBRARY_PATH_LOCAL) $(GDBCPPUNITTRACE) gdb > --args $(SOLARBINDIR)/cppunittester Actually, no tweaking is necessary, as it is already in place :) Just use dmake debugcppunit=t > > and re-run build in whatever module was originally crashing and get a > backtrace to see if we can get a hint as to what the crasher might be. > > C. > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] some changes for better performance, writer.
On Mon, Jan 10, 2011 at 06:32:40AM +0100, David Tardon wrote: > On Tue, Jan 10, 2006 at 08:09:17PM -0300, Kayo Hamid wrote: > > diff --git a/sw/source/core/access/acccell.cxx > > b/sw/source/core/access/acccell.cxx > > index dbd1b51..2479c5c 100644 > > --- a/sw/source/core/access/acccell.cxx > > +++ b/sw/source/core/access/acccell.cxx > > @@ -121,7 +121,7 @@ SwAccessibleCell::SwAccessibleCell( SwAccessibleMap > > *pInitMap, > > sal_Bool SwAccessibleCell::_InvalidateMyCursorPos() > > { > > sal_Bool bNew = IsSelected(); > > -sal_Bool bOld; > > +sal_Bool bOld = sal_False; > > { > > osl::MutexGuard aGuard( aMutex ); > > bOld = bIsSelected; > This is good, but not necessary, because bOld is always initialized later. > Anyway, if it has any impact on performance, it's negative, because > there must be at least one instruction more (to store the initialization > value into the variable). > > > @@ -349,7 +349,7 @@ sal_Bool SwAccessibleCell::setCurrentValue( const > > uno::Any& aNumber ) > > SolarMutexGuard aGuard; > > CHECK_FOR_DEFUNC( XAccessibleValue ); > > > > -double fValue = 0; > > +const double fValue = 0; > > sal_Bool bValid = (aNumber >>= fValue); > > if( bValid ) > > { > This is absolutely wrong, because fValue is changed just a line lower (by > >>=, which is uno::Any extraction operator). > > > diff --git a/sw/source/core/access/acccontext.cxx > > b/sw/source/core/access/acccontext.cxx > > index 127820f..978dcad 100644 > > --- a/sw/source/core/access/acccontext.cxx > > +++ b/sw/source/core/access/acccontext.cxx > > @@ -507,7 +507,7 @@ void SwAccessibleContext::FireVisibleDataEvent() > > } > > > > void SwAccessibleContext::FireStateChangedEvent( sal_Int16 nState, > > - sal_Bool bNewState ) > > + const sal_Bool bNewState ) > > { > > AccessibleEventObject aEvent; > > > This is good, but why not mark nState const as well? It is not changed > anywhere in the function... Anyway, there is absolutely _no_ performance > gain in it. > > > -void FireStateChangedEvent( sal_Int16 nState, sal_Bool bNewState ); > > +void FireStateChangedEvent( sal_Int16 nState, const sal_Bool > bNewState ); > This is superfluous, because these two signatures are equal (well, not > all compilers understand it correctly, e.g., the Sun C++ compiler). > Anyway, do not let me discourage you :) May I suggest that you look at http://wiki.documentfoundation.org/Development/Easy_Hacks ? There should be enough interesting things to try there. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] some changes for better performance, writer.
On Tue, Jan 10, 2006 at 08:09:17PM -0300, Kayo Hamid wrote: > diff --git a/sw/source/core/access/acccell.cxx > b/sw/source/core/access/acccell.cxx > index dbd1b51..2479c5c 100644 > --- a/sw/source/core/access/acccell.cxx > +++ b/sw/source/core/access/acccell.cxx > @@ -121,7 +121,7 @@ SwAccessibleCell::SwAccessibleCell( SwAccessibleMap > *pInitMap, > sal_Bool SwAccessibleCell::_InvalidateMyCursorPos() > { > sal_Bool bNew = IsSelected(); > -sal_Bool bOld; > +sal_Bool bOld = sal_False; > { > osl::MutexGuard aGuard( aMutex ); > bOld = bIsSelected; This is good, but not necessary, because bOld is always initialized later. Anyway, if it has any impact on performance, it's negative, because there must be at least one instruction more (to store the initialization value into the variable). > @@ -349,7 +349,7 @@ sal_Bool SwAccessibleCell::setCurrentValue( const > uno::Any& aNumber ) > SolarMutexGuard aGuard; > CHECK_FOR_DEFUNC( XAccessibleValue ); > > -double fValue = 0; > +const double fValue = 0; > sal_Bool bValid = (aNumber >>= fValue); > if( bValid ) > { This is absolutely wrong, because fValue is changed just a line lower (by >>=, which is uno::Any extraction operator). > diff --git a/sw/source/core/access/acccontext.cxx > b/sw/source/core/access/acccontext.cxx > index 127820f..978dcad 100644 > --- a/sw/source/core/access/acccontext.cxx > +++ b/sw/source/core/access/acccontext.cxx > @@ -507,7 +507,7 @@ void SwAccessibleContext::FireVisibleDataEvent() > } > > void SwAccessibleContext::FireStateChangedEvent( sal_Int16 nState, > - sal_Bool bNewState ) > + const sal_Bool bNewState ) > { > AccessibleEventObject aEvent; > This is good, but why not mark nState const as well? It is not changed anywhere in the function... Anyway, there is absolutely _no_ performance gain in it. > -void FireStateChangedEvent( sal_Int16 nState, sal_Bool bNewState ); > +void FireStateChangedEvent( sal_Int16 nState, const sal_Bool bNewState ); This is superfluous, because these two signatures are equal (well, not all compilers understand it correctly, e.g., the Sun C++ compiler). D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] cppcheck changes at writer
Sending for review. revol_ diff --git a/sw/source/core/docnode/ndsect.cxx b/sw/source/core/docnode/ndsect.cxx index a7168c2..f93fe95 100644 --- a/sw/source/core/docnode/ndsect.cxx +++ b/sw/source/core/docnode/ndsect.cxx @@ -387,6 +387,7 @@ SwDoc::InsertSwSection(SwPaM const& rRange, SwSectionData & rNewData, } SetModified(); +delete pFmt; return &pNewSectNode->GetSection(); } diff --git a/sw/source/filter/ww8/wrtw8sty.cxx b/sw/source/filter/ww8/wrtw8sty.cxx index 2593340..77d31da 100644 --- a/sw/source/filter/ww8/wrtw8sty.cxx +++ b/sw/source/filter/ww8/wrtw8sty.cxx @@ -2012,13 +2012,13 @@ bool WW8_WrPlcSubDoc::WriteGenericTxt( WW8Export& rWrt, BYTE nTTyp, // --> OD 2008-08-07 #156757# { SwNodeIndex aContentIdx = *pNdIdx; -aContentIdx++; +++aContentIdx; if ( aContentIdx.GetNode().IsTableNode() ) { bool bContainsOnlyTables = true; do { aContentIdx = *(aContentIdx.GetNode().EndOfSectionNode()); -aContentIdx++; +++aContentIdx; if ( !aContentIdx.GetNode().IsTableNode() && aContentIdx.GetIndex() != pNdIdx->GetNode().EndOfSectionIndex() ) { diff --git a/sw/source/ui/config/uinums.cxx b/sw/source/ui/config/uinums.cxx index 5ecb106..7025df8 100644 --- a/sw/source/ui/config/uinums.cxx +++ b/sw/source/ui/config/uinums.cxx @@ -336,7 +336,6 @@ SwNumRulesWithName::_SwNumFmtGlobal::_SwNumFmtGlobal( SvStream& rStream, { USHORT nUS; sal_Char cChar; -short nShort; BOOL bFlag; String sStr; @@ -367,6 +366,7 @@ SwNumRulesWithName::_SwNumFmtGlobal::_SwNumFmtGlobal( SvStream& rStream, } else // alter StartWert war ein Byte { +short nShort; rStream >> nUS;aFmt.SetStart( nUS ); rStream.ReadByteString(sStr, eEncoding); aFmt.SetPrefix( sStr ); diff --git a/sw/source/ui/envelp/envfmt.cxx b/sw/source/ui/envelp/envfmt.cxx index 827961a..d69e6ae 100644 --- a/sw/source/ui/envelp/envfmt.cxx +++ b/sw/source/ui/envelp/envfmt.cxx @@ -278,6 +278,7 @@ IMPL_LINK( SwEnvFmtPage, EditHdl, MenuButton *, pButton ) pCollSet->Put(aOutputSet); } delete pDlg; +delete pCollSet; } break; @@ -333,6 +334,7 @@ IMPL_LINK( SwEnvFmtPage, EditHdl, MenuButton *, pButton ) } } delete pDlg; +delete pCollSet; } break; } ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] some cppcheck cleaning in sw + replacement of -exec by xargs
On Sun, 2011-01-09 at 22:25 +0100, Julien wrote: > Hello, > > Here is a patch for some cppcheck cleaning in sw > Compiling was ok Looks reasonable to me, pushed, thanks for these > + 1 -exec replaced by xargs ditto. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Changed String to OUString in funcdesc.hxx
On Sun, 2011-01-09 at 20:37 +0100, Soeren Moeller wrote: > And here another patch for sc/inc/funcdesc.hxx and related source > files, ... >(using casts when forced to use String originally because of ResId). Kohei will probably want to have a look at these, but as an aside, how about adding something like static rtl::OUString toString(const ResId&) to the tools resid.hxx ResId class and hide the nasty convert cast kludge in the impl of that, which could be tucked away in the old tools/source/strucvt.cxx for now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] fix nsplugin to say LibreOffice; supress message unless debug on
On Sun, Jan 09, 2011 at 09:24:51PM +, Caolán McNamara wrote: > On Sun, 2011-01-09 at 20:55 +0100, Rene Engelhard wrote: > > OK for libreoffice-3-3? > > yeah, go for it IMO. k, pushed. Grüße/Regards, René ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] fix nsplugin to say LibreOffice; supress message unless debug on
On Sun, 2011-01-09 at 20:55 +0100, Rene Engelhard wrote: > OK for libreoffice-3-3? yeah, go for it IMO. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] some cppcheck cleaning in sw + replacement of -exec by xargs
Hello, Here is a patch for some cppcheck cleaning in sw Compiling was ok + 1 -exec replaced by xargs Julien (LGPLv3+ / MPL) commit 8bce9aee2348d6d34f190b2409390010b9a88e79 Author: Julien Nabet Date: Sun Jan 9 22:19:39 2011 +0100 Some cppcheck cleaning diff --git a/sw/source/core/access/accpara.cxx b/sw/source/core/access/accpara.cxx index 8a1a24e..f3c2c16 100644 --- a/sw/source/core/access/accpara.cxx +++ b/sw/source/core/access/accpara.cxx @@ -2188,7 +2188,7 @@ sal_Bool SwAccessibleParagraph::setAttributes( { xPortion->setPropertyValues( aNames, aValues ); } -catch( UnknownPropertyException e ) +catch( UnknownPropertyException &e ) { // error handling through return code! bRet = sal_False; diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx index d4eaaa2..ed33bc8 100644 --- a/sw/source/core/doc/docbm.cxx +++ b/sw/source/core/doc/docbm.cxx @@ -1493,10 +1493,10 @@ void _RestoreCntntIdx(SwDoc* pDoc, case 0x0800: case 0x0801: { -USHORT nCnt = 0; SwCrsrShell* pShell = pDoc->GetEditShell(); if( pShell ) { +USHORT nCnt = 0; FOREACHSHELL_START( pShell ) SwPaM *_pStkCrsr = PCURSH->GetStkCrsr(); if( _pStkCrsr ) @@ -1653,10 +1653,10 @@ void _RestoreCntntIdx(SvULongs& rSaveArr, case 0x0800: case 0x0801: { -USHORT nCnt = 0; SwCrsrShell* pShell = pDoc->GetEditShell(); if( pShell ) { +USHORT nCnt = 0; FOREACHSHELL_START( pShell ) SwPaM *_pStkCrsr = PCURSH->GetStkCrsr(); if( _pStkCrsr ) diff --git a/sw/source/core/doc/doccomp.cxx b/sw/source/core/doc/doccomp.cxx index aaf61ab..1100fe6 100644 --- a/sw/source/core/doc/doccomp.cxx +++ b/sw/source/core/doc/doccomp.cxx @@ -695,7 +695,6 @@ ULONG Compare::CompareSequence::CheckDiag( ULONG nStt1, ULONG nEnd1, for (c = 1;; ++c) { long d;/* Active diagonal. */ -long big_snake = 0; /* Extend the top-down search by an edit step in each diagonal. */ fmin > dmin ? pFDiag[--fmin - 1] = -1 : ++fmin; @@ -713,8 +712,6 @@ ULONG Compare::CompareSequence::CheckDiag( ULONG nStt1, ULONG nEnd1, while( ULONG(x) < nEnd1 && ULONG(y) < nEnd2 && rMoved1.GetIndex( x ) == rMoved2.GetIndex( y )) ++x, ++y; -if (x - oldx > 20) -big_snake = 1; pFDiag[d] = x; if( odd && bmin <= d && d <= bmax && pBDiag[d] <= pFDiag[d] ) { @@ -739,8 +736,6 @@ ULONG Compare::CompareSequence::CheckDiag( ULONG nStt1, ULONG nEnd1, while( ULONG(x) > nStt1 && ULONG(y) > nStt2 && rMoved1.GetIndex( x - 1 ) == rMoved2.GetIndex( y - 1 )) --x, --y; -if (oldx - x > 20) -big_snake = 1; pBDiag[d] = x; if (!odd && fmin <= d && d <= fmax && pBDiag[d] <= pFDiag[d]) { diff --git a/sw/source/core/doc/docredln.cxx b/sw/source/core/doc/docredln.cxx index 0ebd260..fe203fe 100644 --- a/sw/source/core/doc/docredln.cxx +++ b/sw/source/core/doc/docredln.cxx @@ -2999,11 +2999,11 @@ void SwRedlineExtraData_Format::Reject( SwPaM& rPam ) const int SwRedlineExtraData_Format::operator == ( const SwRedlineExtraData& rCmp ) const { int nRet = 1; -USHORT n = 0, nEnd = aWhichIds.Count(); +USHORT nEnd = aWhichIds.Count(); if( nEnd != ((SwRedlineExtraData_Format&)rCmp).aWhichIds.Count() ) nRet = 0; else -for( ; n < nEnd; ++n ) +for(USHORT n=0 ; n < nEnd; ++n ) if( ((SwRedlineExtraData_Format&)rCmp).aWhichIds[n] != aWhichIds[n]) { nRet = 0; @@ -3012,8 +3012,6 @@ int SwRedlineExtraData_Format::operator == ( const SwRedlineExtraData& rCmp ) co return nRet; } -/* */ - SwRedlineData::SwRedlineData( RedlineType_t eT, USHORT nAut ) : pNext( 0 ), pExtraData( 0 ), eType( eT ), nAuthor( nAut ), nSeqNo( 0 ) { @@ -3066,8 +3064,6 @@ String SwRedlineData::GetDescr() const return aResult; } -/* */ - SwRedline::SwRedline(RedlineType_t eTyp, const SwPaM& rPam ) : SwPaM( *rPam.GetMark(), *rPam.GetPoint() ), pRedlineData( new SwRedlineData( eTyp, GetDoc()->GetRedlineAuthor() ) ), diff --git a/sw/source/core/layout/fly.cxx b/sw/source/core/layout/fly.cxx index 7543804..ffd4b9c 100644 --- a/sw/source/core/layout/fly.cxx +++ b/sw/source/core/layout/fly.cxx @@ -2712,8 +2712,6 @@ BOOL SwFlyFrm::GetContour( PolyPolygon& rContour, const MapMode aDispMap( MAP_TWIP ); const MapMode
[Libreoffice] [PUSHED] Re: [PATCH] cppcheck cleaning in sc
On Sun, 2011-01-09 at 16:21 +0100, Julien Nabet wrote: > Hello, > > Here is a patch for some cppcheck cleaning in sc > Compiling was ok Looks good, so pushed. Thanks for this. I did decide afterwards to remove two of the methods that cppcheck said could be "const" seeing as they were actually empty and nothing called them. > PS : when cppcheck indicates that a boolean is not initialized, what is > recommended to choose ? true, false or it depends on the context ? Do you have an example, it *might* be a false positive because it might be an overloaded operator that cppcheck doesn't know about, e.g. sal_Bool bFoo; if (aAny >>= bFoo) { //use foo only if Any::operator>>= filled in bFoo successfully //cppcheck might think bFoo is used initialized } but in the general case sal_False is probably the right value. i.e. in the above case I'd do sal_Bool bFoo(sal_False); anyway even if it is a false positive. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Quasi-patch: Cursor vs Scroll
On Sat, 2011-01-08 at 23:50 +, Andy Hearn wrote: > The cursor, when on a post-it note, now can go out of view when Joe > User scrolls, and is correctly brought back into 'focus' if the user > types something. > > But however, this patch shouldn't be pushed at all - I suspect that > the hack which I've just removed probably breaks something somewhere. > > Even though I've bashed away at the Comments/Post-It Notes, and Writer > in general; there appear to be no ill effects. I've tried to > understand the necessity for this hack in the first place to no > avail. Lets ask, max, do you remember the code in the postits that the attached patch affects, can you remember what the problem was that needed fixing ? C. >From 5d237e53a3574dcef1f30ecf747ec6f7333cf829 Mon Sep 17 00:00:00 2001 From: Andrew W Hearn Date: Sat, 8 Jan 2011 23:26:13 + Subject: [PATCH] Removed suspect hack. Cursor on post-it now scrolls out of view. Previously, when the user scrolls when the cursor is within a post-it note, the main view judders, refusing to let the cursor go out of view. The removed lines appears to have been a hack to retain focus of a post-it note containing the cursor. --- sw/source/ui/docvw/PostItMgr.cxx | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/sw/source/ui/docvw/PostItMgr.cxx b/sw/source/ui/docvw/PostItMgr.cxx index e06d558..2d599c6 100644 --- a/sw/source/ui/docvw/PostItMgr.cxx +++ b/sw/source/ui/docvw/PostItMgr.cxx @@ -719,16 +719,6 @@ void SwPostItMgr::LayoutPostIts() OSL_ENSURE(mPages[n]->bScrollbar,"SwPostItMgr::LayoutByPage(): note overlaps, but bScrollbar is not true"); } } - -// do some magic so we really see the focused note -for(SwSidebarWin_iterator i = aVisiblePostItList.begin(); i!= aVisiblePostItList.end() ; i++) -{ -if ((*i)->HasChildPathFocus()) -{ -MakeVisible((*i),n+1); -break; -} -} } else { -- 1.7.0.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] calling web services
Am 07.01.11 23:24, schrieb Dan Corneanu: > Hi, > supposing I would venture in writing a content provider implemented in > C++ , to make a CMIS repository accessible to libreoffice, > what library should I use for accessing the web services on the server? > > Best regards, > Dan. Hi, I'm not aware of any web service stack currently incorporated into OOo or LibO. If you want to implement a CMIS client yourself, you might want to have a look at Apache Axis/C++ (http://ws.apache.org/axis/cpp/index.html). Apache also has a CMIS Server implementation with accompanying clients in incubation (http://incubator.apache.org/chemistry/opencmis.html). If your implenentation language requirement isn't C++ but "not Java", there also seems to be a pyhton client available (http://incubator.apache.org/chemistry/cmislib.html), which might be usable, too, depending on what exactly you want to do with that CMIS content provider. Personally, I'd be interested in what you want to achieve functionally with the CMIS content provider, i.e. what CMIS features you want to support (and how). I guess most content repositories that support CMIS now might also still export some WebDAV service, which should be supported by LibO out of the box. Cheers, Peter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Removed unnecessary comments
On Sat, 2011-01-08 at 23:52 +0100, Christina Roßmanith wrote: > Hi, > > instead of translating comments, this time I removed lot's of comments like Looks good, all pushed, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Translated comments from German to English
On Sat, 2011-01-08 at 23:14 +0100, Christina Roßmanith wrote: > Hi, > > I started with a fresh clone this evening and reapplied my changes. So > this patch is meant for pushing :-) Seems to be a duplicate of the earlier ones which I already pushed, so I think these are up to date now. Thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] FOSDEM 2011, Proposed Talk: "Kicking off the LibreOffice Design Team"
Hi Christoph, Christoph Noack wrote on 2011-01-09 02.51: During the last days, I got the impression that it might be helpful to share some ideas how a future collaboration with the LibreOffice Design Team could look like. And, to know what you consider to be helpful when we talk about UX and Visual Design ... Rather late (sorry!), I've added a proposal for a talk at the FOSDEM: "Kicking off the LibreOffice Design Team" [1]. To make this a bit more joyful, I'd like to hear whether you have questions, comments, remarks or requests ... anything you'd like to know related to "User Experience" and "Visual Identity Design" topics and organization. If possible, I'll try to address this within the talk. Even if you do not attend the FOSDEM ... the material will be made available. So please go ahead and add your thoughts to the following wiki page ... in a sentence, or two :-) http://wiki.documentfoundation.org/User:ChristophNoack/Temporary_Work_Space thanks a lot for the initiative! We need to hand in at least a close-to-final program by tomorrow, January 10th, so if you indeed intend to give a talk, let us know. Best is to send directly to i...@documentfoundation.org, where most likely Michael or I will pick it up. :) Information on the CfP is available at http://wiki.documentfoundation.org/Marketing/Events/Fosdem2011 Thanks a lot! (And sorry for the brief reply, currently digging through hundreds of unread e-mails...) Florian -- Florian Effenberger Steering Committee and Founding Member of The Document Foundation Tel: +49 8341 99660880 | Mobile: +49 151 14424108 Skype: floeff | Twitter/Identi.ca: @floeff ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Remove unused code and fix typos
On Sun, 2011-01-09 at 02:06 +0900, Takeshi Abe wrote: > Hi, > > Here is a bunch of cleanup on base. Looks good to me, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Replacing tools/color.hxx with new type
On Sat, 2011-01-08 at 17:29 +0100, Soeren Moeller wrote: > - Is this strategy: "writing new type, adding casts to old type, > replacing occurrences, removing old type" appropriate? Well, whatever works I guess, personally I prefer a big-bang approach. i.e. remove the class in one fell sweep. Deprecated things just don't go away in practice :-) Moving stuff into "binfilter" rather than rewriting that particular beast is always acceptable as an edge-case though. > - tools/Color uses ResId, do I understand correctly, that it is a way > of storing/retrieving objects from memory/storage, and is it > deprecated (it seems only to be implemented in tools)? The ResId should be the resource id assigned to something in the .res files (built from .src files) which describe things like dialogs and so forth. So I suspect its used to set the colour of parts of the UI. e.g. find . -name "*.src" -exec grep Color {} /dev/null \; I'm not sure however what's the goal of replacing "Color", seems a fairly reasonable class if its types are simply updated to use sal_Foo ones instead of old-school ones. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Remove commented code
On Sat, 2011-01-08 at 14:26 +0100, Anders Jonsson wrote: > These three patches remove large blocks of commented code in sdk, > components and libs-gui respectively. All code has been commented out at > least since 2005. Looks perfectly reasonable to me, especially the comment which suggests the chunk commented out since 1997. Thanks for this, pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Reducing chmod spawning by replacing exec by xargs
On Sat, 2011-01-08 at 14:08 +0100, Julien Nabet wrote: > PS : the 2 sendings with my yahoo.fr address seemed not having worked. They showed up eventually, all pushed now, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Reducing chmod spawning by replacing exec by xargs
On Sat, 2011-01-08 at 02:09 +0100, Julien Nabet wrote: > Hello, > > I used xargs instead of -exec to reduce chmod spawning. Seems reasonable, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] Again cppcheck cleanliness
On Sat, 2011-01-08 at 08:46 +0100, Julien Nabet wrote: > I don't understand too the part about hiding something from cppcheck, > wouldn't it be better to declare a new bug to cppcheck tracker ? Quite possibly > But perhaps I misunderstood something I reckon we really should be calling cppcheck with sufficient -I info that it can find the headers included by the files its checking so it can find the macros used inside those files, that would improve the results we're getting. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Translations of comments in writer/sw/inc
On Sat, 2011-01-08 at 02:53 +0100, Christoph wrote: > some more translations. Looks reasonable to me, pushed, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Transl. German comments in sw/inc/IDocumentFieldsAccess.hxx
On Sat, 2011-01-08 at 00:21 +0100, Christoph wrote: > Only one comment in this file. Seems reasonable to me, pushed. Thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=31865 --- Comment #58 from tester8 2011-01-09 12:13:11 PST --- Nominate Bug 32052 - hat, vector and tilde doesn't appear. With this bug LibreOffice is unusable for physicist and some other scientists. It is regression to OO 3.2. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Splitting up source/header files for clarity
Hi I have been working with sc/inc/funcdesc.hxx, and this header defines four closely related classes, but all the implementation of these classes is in sc/source/core/data/global.cxx together with the implementation of a number of other classes. This makes it confusing to find the implementations and check these classes separately, so it would be nice to have these implementations in their own file/files. This is even suggested by a comment in sc/inc/funcdesc.hxx which sounds, as if the header earlier was part of some huge file too. Moving these implementations to own files raises some questions: - Is it best to make one file for each class, or keep them together and make one funcdesc.cxx (containing four classes)? - Should the license header for the new file(s) be a copy of the license header from global.cxx (as the code is copied out), or the new Libo header? - Is it enough to add the new file(s) to sc/source/core/data/makefile.mk for building, or have they to be added somewhere else too? Any comments are appreciated Best Regards Sören Möller ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=31865 tester8 changed: What|Removed |Added Depends on||32052 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] fix nsplugin to say LibreOffice; supress message unless debug on
Hi, see the attached patch, the Mozilla plugin still says "OpenOffice path" (yes, even without .org!) when invoked. Should be changed, And I think we shouldn't show this at all unless someone wants to debug this so I added #idef OSL_DEBUG_LEVEL > 0 around it. OK for libreoffice-3-3? Grüße/Regards, René -- .''`. René Engelhard -- Debian GNU/Linux Developer : :' : http://www.debian.org | http://people.debian.org/~rene/ `. `' r...@debian.org | GnuPG-Key ID: D03E3E70 `- Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70 >From e8f9818af738d9f8eba923070fe3b933ab101f2c Mon Sep 17 00:00:00 2001 From: Rene Engelhard Date: Sun, 9 Jan 2011 20:45:46 +0100 Subject: [PATCH] fix nsplugin for LibreOffice name - OpenOffice path -> LibreOffice path - only split "LibreOffice path [...] out with OSL_DEBUG_LEVEL > 0 --- extensions/source/nsplugin/source/so_env.cxx | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/extensions/source/nsplugin/source/so_env.cxx b/extensions/source/nsplugin/source/so_env.cxx index 2dd4f8f..8f8e436 100644 --- a/extensions/source/nsplugin/source/so_env.cxx +++ b/extensions/source/nsplugin/source/so_env.cxx @@ -205,7 +205,9 @@ int nspluginOOoModuleHook (void** aResult) strcpy (realFileName, libFileName); } -fprintf (stderr, "OpenOffice path before fixup is '%s'\n", realFileName); +#if OSL_DEBUG_LEVEL > 0 +fprintf (stderr, "LibreOffice path before fixup is '%s'\n", realFileName); +#endif if (realFileName[0] != '/') { /* a relative sym-link and we need to get an absolute path */ @@ -224,8 +226,10 @@ int nspluginOOoModuleHook (void** aResult) *aResult = realFileName; -fprintf (stderr, "OpenOffice path is '%s'\n", realFileName); - +#if OSL_DEBUG_LEVEL > 0 +fprintf (stderr, "LibreOffice path is '%s'\n", realFileName); +#endif + return 0; } #endif -- 1.7.2.3 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] libreoffice.org
Hello, I have seen a new design at libreoffice.org and it's looks very good, congrats! But it seems miss set a blank background. revol_ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Changed String to OUString in funcdesc.hxx
And here another patch for sc/inc/funcdesc.hxx and related source files, changing even more occurrences of (deprecated) String to OUString. I also changed the uses of these variables/functions to use OUString instead (using casts when forced to use String originally because of ResId). Please review and apply Regards Sören Möller (LGPLv3+ / MPL) From a2ff17423179900f4d0fa28243a91bca67cdbc52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B6ren=20M=C3=B6ller?= Date: Sun, 9 Jan 2011 20:30:43 +0100 Subject: [PATCH] Changed String to OUString in funcdesc.hxx I have changed variables and functions in sc/inc/funcdesc.hxx to use OUString instead of deprecated String, and I have also changed all uses of these variables/functions to use OUString --- sc/inc/funcdesc.hxx |7 ++-- sc/source/core/data/global.cxx| 64 +--- sc/source/ui/app/inputhdl.cxx |2 +- sc/source/ui/formdlg/dwfunctr.cxx |2 +- 4 files changed, 35 insertions(+), 40 deletions(-) diff --git a/sc/inc/funcdesc.hxx b/sc/inc/funcdesc.hxx index c07dda0..edc50df 100644 --- a/sc/inc/funcdesc.hxx +++ b/sc/inc/funcdesc.hxx @@ -57,6 +57,7 @@ public: parameters only one element is added to the end of the sequence. */ virtual void fillVisibleArgumentMapping(::std::vector& _rArguments) const ; virtual void initArgumentInfo() const; +/** Returns the full function signature: "FUNCTIONNAME( parameter list )". */ virtual ::rtl::OUString getSignature() const ; virtual long getHelpId() const ; @@ -81,9 +82,7 @@ public: voidClear(); /** Returns a semicolon separated list of all parameter names. */ -String GetParamList() const; -/** Returns the full function signature: "FUNCTIONNAME( parameter list )". */ -String GetSignature() const; +::rtl::OUString GetParamList() const; @@ -158,7 +157,7 @@ public: ScFunctionMgr(); virtual ~ScFunctionMgr(); -static String GetCategoryName(sal_uInt32 _nCategoryNumber ); +static ::rtl::OUString GetCategoryName(sal_uInt32 _nCategoryNumber ); const ScFuncDesc* Get( const String& rFName ) const; const ScFuncDesc* Get( USHORT nFIndex ) const; diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx index e46a3e6..b3de8ba 100644 --- a/sc/source/core/data/global.cxx +++ b/sc/source/core/data/global.cxx @@ -1457,11 +1457,11 @@ void ScFuncDesc::Clear() // -String ScFuncDesc::GetParamList() const +::rtl::OUString ScFuncDesc::GetParamList() const { const String& sep = ScCompiler::GetNativeSymbol(ocSep); -String aSig; +::rtl::OUString aSig; if ( nArgCount > 0 ) { @@ -1476,19 +1476,19 @@ String ScFuncDesc::GetParamList() const else { nLastAdded = i; -aSig += (String)*(ppDefArgNames[i]); +aSig += *(ppDefArgNames[i]); if ( i != nArgCount-1 ) { -aSig.Append(sep); -aSig.AppendAscii(RTL_CONSTASCII_STRINGPARAM( " " )); +aSig += ::rtl::OUString(sep); +aSig += ::rtl::OUString::createFromAscii( " " ); } } } // If only suppressed parameters follow the last added parameter, // remove one "; " if (nLastSuppressed < nArgCount && nLastAdded < nLastSuppressed && -aSig.Len() >= 2) -aSig.Erase( aSig.Len() - 2 ); +aSig.getLength() >= 2) +aSig = aSig.copy(0,aSig.getLength() - 2); } else { @@ -1497,23 +1497,23 @@ String ScFuncDesc::GetParamList() const { if (!pDefArgFlags[nArg].bSuppress) { -aSig += (String)*(ppDefArgNames[nArg]); -aSig.Append(sep); -aSig.AppendAscii(RTL_CONSTASCII_STRINGPARAM( " " )); +aSig += *(ppDefArgNames[nArg]); +aSig += ::rtl::OUString(sep); +aSig += ::rtl::OUString::createFromAscii( " " ); } } /* NOTE: Currently there are no suppressed var args parameters. If * there were, we'd have to cope with it here and above for the fix * parameters. For now parameters are always added, so no special * treatment of a trailing "; " necessary. */ -aSig += (String)*(ppDefArgNames[nFix]); -aSig += '1'; -aSig.Append(sep); -aSig.AppendAscii(RTL_CONSTASCII_STRINGPARAM( " " )); -aSig += (String)*(ppDefArgNames[nFix]); -aSig += '2'; -aSig.Append(sep); -a
[Libreoffice] [PATCH] Changed String to OUString in ScFuncDesc
Hi Please review and apply if appropriate this patch: I have replaced four public (deprecated) String variables of ScFuncDesc in sc/inc/funcdesc.hxx by OUString and changed all uses of these variables to use OUString instead. Most places by using relevant methods for OUString, and a few places (where a String is retrieved using a ResId), by casting the String to an OUString. funcdesc.hxx and its implementation in global.cxx still contain other uses of deprecated datatypes, but I hope to change these in a later patch. Regards Sören Möller (LGPLv3+ / MPL) From d8c5ec79dff93bbc3c101e64bd59907527ee193f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B6ren=20M=C3=B6ller?= Date: Sun, 9 Jan 2011 18:12:47 +0100 Subject: [PATCH] Changed String to OUString in public variables of ScFuncDesc I have changed four public variables of ScFuncDesc in sc/inc/funcdesc.hxx from deprecated String to OUString and corrected all uses of these variables --- sc/inc/appluno.hxx|1 + sc/inc/funcdesc.hxx | 22 ++-- sc/source/core/data/global.cxx| 72 ++-- sc/source/core/tool/addincol.cxx | 16 sc/source/ui/formdlg/dwfunctr.cxx |2 +- sc/source/ui/unoobj/appluno.cxx | 21 +-- 6 files changed, 67 insertions(+), 67 deletions(-) diff --git a/sc/inc/appluno.hxx b/sc/inc/appluno.hxx index 681dd8d..f8d82cd 100644 --- a/sc/inc/appluno.hxx +++ b/sc/inc/appluno.hxx @@ -38,6 +38,7 @@ #include #include #include +#include class ScFunctionDescriptionObj; diff --git a/sc/inc/funcdesc.hxx b/sc/inc/funcdesc.hxx index 3640bfc..c07dda0 100644 --- a/sc/inc/funcdesc.hxx +++ b/sc/inc/funcdesc.hxx @@ -93,17 +93,17 @@ public: suppressed). */ USHORT GetSuppressedArgCount() const; -String *pFuncName; // Function name -String *pFuncDesc; // Description of function -String **ppDefArgNames; // Parameter name(s) -String **ppDefArgDescs; // Description(s) of parameter(s) -ParameterFlags *pDefArgFlags; // Flags for each parameter -USHORT nFIndex;// Unique function index -USHORT nCategory; // Function category -USHORT nArgCount; // All parameter count, suppressed and unsuppressed -USHORT nHelpId;// HelpID of function -bool bIncomplete :1; // Incomplete argument info (set for add-in info from configuration) -bool bHasSuppressedArgs :1; // Whether there is any suppressed parameter. +::rtl::OUString *pFuncName; // Function name +::rtl::OUString *pFuncDesc; // Description of function +::rtl::OUString **ppDefArgNames; // Parameter name(s) +::rtl::OUString **ppDefArgDescs; // Description(s) of parameter(s) +ParameterFlags *pDefArgFlags; // Flags for each parameter +USHORTnFIndex;// Unique function index +USHORTnCategory; // Function category +USHORTnArgCount; // All parameter count, suppressed and unsuppressed +USHORTnHelpId;// HelpID of function +bool bIncomplete :1; // Incomplete argument info (set for add-in info from configuration) +bool bHasSuppressedArgs :1; // Whether there is any suppressed parameter. }; // diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx index 93550a9..e46a3e6 100644 --- a/sc/source/core/data/global.cxx +++ b/sc/source/core/data/global.cxx @@ -1168,17 +1168,17 @@ ScFuncRes::ScFuncRes( ResId &aRes, ScFuncDesc* pDesc, bool & rbSuppressed ) } } -pDesc->pFuncName = new String( ScCompiler::GetNativeSymbol( static_cast( aRes.GetId(; -pDesc->pFuncDesc = new String(ScResId(1)); +pDesc->pFuncName = new ::rtl::OUString( ScCompiler::GetNativeSymbol( static_cast( aRes.GetId(; +pDesc->pFuncDesc = (::rtl::OUString*)(new String(ScResId(1))); if (nArgs) { -pDesc->ppDefArgNames = new String*[nArgs]; -pDesc->ppDefArgDescs = new String*[nArgs]; +pDesc->ppDefArgNames = new ::rtl::OUString*[nArgs]; +pDesc->ppDefArgDescs = new ::rtl::OUString*[nArgs]; for (USHORT i = 0; i < nArgs; i++) { -pDesc->ppDefArgNames[i] = new String(ScResId(2*(i+1) )); -pDesc->ppDefArgDescs[i] = new String(ScResId(2*(i+1)+1)); +pDesc->ppDefArgNames[i] = (::rtl::OUString*)(new String(ScResId(2*(i+1) ))); +pDesc->ppDefArgDescs[i] = (::rtl::OUString*)(new String(ScResId(2*(i+1)+1))); } } @@ -1250,7 +1250,7 @@ ScFunctionList::ScFunctionList() :
Re: [Libreoffice] Linux distros and LibO packaging
Hi, On Sun, Jan 09, 2011 at 05:39:31PM +0100, Rene Engelhard wrote: > On Sun, Jan 09, 2011 at 04:40:06PM +0100, Jonathan Aquilina wrote: > > Not trying to hijack the thread here but what is Ubuntu doing about > > LO i know its supposed to be part of their next release instead of > > OOo, but normally they get packages from upstream Debian, is someone > > working on getting it in Debian? > > It is already since long. FTR, history is here: http://packages.qa.debian.org/libr/libreoffice.html Grüße/Regards, René -- .''`. René Engelhard -- Debian GNU/Linux Developer : :' : http://www.debian.org | http://people.debian.org/~rene/ `. `' r...@debian.org | GnuPG-Key ID: D03E3E70 `- Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Linux distros and LibO packaging
On Sun, Jan 09, 2011 at 04:40:06PM +0100, Jonathan Aquilina wrote: > Not trying to hijack the thread here but what is Ubuntu doing about > LO i know its supposed to be part of their next release instead of > OOo, but normally they get packages from upstream Debian, is someone > working on getting it in Debian? It is already since long. Ask the Ubuntu people why they can't merge... Grüße/Regards, René -- .''`. René Engelhard -- Debian GNU/Linux Developer : :' : http://www.debian.org | http://people.debian.org/~rene/ `. `' r...@debian.org | GnuPG-Key ID: D03E3E70 `- Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Formula cursor : bug or feature ?
> Hi Jean, > > On Wed, 2010-12-29 at 21:11 +0100, Jean-Baptiste Faure wrote: >> Jonas wrote: >>> Assuming someone cares to implement it... and you're are welcome to >>> step up to the plate :) > .. >> I strongly disagree : it is you who must not to destroy what is working >> very well. > Jean - this sort of adjective "destroy", is a shame to apply to some > wonderful work that will really help millions to edit formulae in a more > simple and effective way - for which we should be extremely grateful to > Jonas. It distresses me to see developers criticised for introducing > some minor bug or regression along with a huge improvement: which this > work is (even if you don't appreciate the added function) :-) Ok, maybe my word "destroy" was too strong, I should have written "break". Sorry for that, but writing in English is not so easy for me. I was afraid to return 15 years back and loose one of the main advantages of OOo/LibO for my professional use. That said I think it is very important to not forget, if we need to have new developers, that developers need to be supported by advanced users who probably are the main evangelists of LibO. So it is very important that these advanced users are not discouraged by code changes that break their usual practice, even maybe their professional use of LibO. Programming is difficult and a great game too, but we (I am programmer too but not (yet ?) in this area) must keep in mind that, behind the software, there is end-users who do not play with it. To be positive, I suggest that we have a list of experimental functions which are currently under development. And it would be more user friendly if we had a configuration tab where we could activate or deactivate separately each experimental feature. Last thing, if I agree that specification constraints in OOo are too cumbersome, I think we should have, at least, a bug report (enhancement) for each new feature which describe what this new feature will do and what changes to the existing features are planned. By announcing these new features on the dev list, everybody who is interested in the development of LibO will be aware of planned new features and experienced users will be able to help the developers with the point of view of end-users. Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Linux distros and LibO packaging
Not trying to hijack the thread here but what is Ubuntu doing about LO i know its supposed to be part of their next release instead of OOo, but normally they get packages from upstream Debian, is someone working on getting it in Debian? On 01/09/2011 04:11 PM, Jean-Baptiste Faure wrote: Hi all, I think that we should have a webpage where Linux distributions who are packaging LibO, could list what changes they made compared to the "official" build by TDF. I see two main advantages : - for users and helpers : they will know easier if a problem comes from LibO or from packaging - for QA : it will be easier to know if a test done, for example on a version from Ubuntu PPA, may be consider as valid or not for LibO from a general point of view. Last but not least, that will increase transparency : we will know what we are talking about when we will talk about LibreOffice. ;-) So, is it a good idea to ask the Linux distributions to publish the changes they made to the official build ? Best regards JBF ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] cppcheck cleaning in sc
Hello, Here is a patch for some cppcheck cleaning in sc Compiling was ok Julien PS : when cppcheck indicates that a boolean is not initialized, what is recommended to choose ? true, false or it depends on the context ? (LGPLv3+ / MPL) commit dd245b64fb571acffb4dc580d0f6098a0cf5037b Author: Julien Nabet Date: Sun Jan 9 16:11:17 2011 +0100 some cppcheckcleaning diff --git a/sc/source/core/data/attarray.cxx b/sc/source/core/data/attarray.cxx index e18921c..574ab1f 100644 --- a/sc/source/core/data/attarray.cxx +++ b/sc/source/core/data/attarray.cxx @@ -234,14 +234,14 @@ BOOL ScAttrArray::Concat(SCSIZE nPos) BOOL ScAttrArray::Search( SCROW nRow, SCSIZE& nIndex ) const { -long nLo = 0; long nHi = static_cast(nCount) - 1; -long nStartRow = 0; -long nEndRow = 0; long i = 0; BOOL bFound = (nCount == 1); if (pData) { +long nLo = 0; +long nStartRow = 0; +long nEndRow = 0; while ( !bFound && nLo <= nHi ) { i = (nLo + nHi) / 2; diff --git a/sc/source/core/tool/chartlis.cxx b/sc/source/core/tool/chartlis.cxx index bfb3d57..095fdbd 100644 --- a/sc/source/core/tool/chartlis.cxx +++ b/sc/source/core/tool/chartlis.cxx @@ -336,7 +336,6 @@ public: endListening(aRange); } } - private: void startListening(const ScRange& rRange) { @@ -353,7 +352,6 @@ private: else mpDoc->EndListeningArea(rRange, &mrParent); } - private: ScDocument* mpDoc; ScChartListener& mrParent; diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx index 1c890b5..f88d332 100644 --- a/sc/source/core/tool/interpr1.cxx +++ b/sc/source/core/tool/interpr1.cxx @@ -4206,7 +4206,6 @@ static void lcl_GetLastMatch( SCSIZE& rIndex, const VectorMatrixAccessor& rMat, void ScInterpreter::ScMatch() { RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, "sc", "er", "ScInterpreter::ScMatch" ); -ScMatrixRef pMatSrc = NULL; BYTE nParamCount = GetByte(); if ( MustHaveParamCount( nParamCount, 2, 3 ) ) @@ -4222,6 +4221,7 @@ void ScInterpreter::ScMatch() SCCOL nCol2 = 0; SCROW nRow2 = 0; SCTAB nTab2 = 0; +ScMatrixRef pMatSrc = NULL; switch (GetStackType()) { diff --git a/sc/source/ui/dbgui/scuiimoptdlg.cxx b/sc/source/ui/dbgui/scuiimoptdlg.cxx index d187301..f3edeaa 100644 --- a/sc/source/ui/dbgui/scuiimoptdlg.cxx +++ b/sc/source/ui/dbgui/scuiimoptdlg.cxx @@ -69,10 +69,10 @@ private: USHORT ScDelimiterTable::GetCode( const String& rDel ) const { sal_Unicode nCode = 0; -xub_StrLen i = 0; if ( nCount >= 2 ) { +xub_StrLen i = 0; while ( i= 2 ) { +xub_StrLen i = 0; while ( igetPropertyValue( CHART_NAME ) >>= sName; } -catch( uno::Exception e ) // swallow exceptions +catch( uno::Exception &e ) // swallow exceptions { } return sName; diff --git a/sc/source/ui/vba/vbachart.hxx b/sc/source/ui/vba/vbachart.hxx index 3602baa..45210a1 100644 --- a/sc/source/ui/vba/vbachart.hxx +++ b/sc/source/ui/vba/vbachart.hxx @@ -69,12 +69,12 @@ friend class ScVbaAxis; bool hasMarkers() throw ( css::script::BasicErrorException ); sal_Int32 getMarkerType(sal_Int32 _nWithMarkers, sal_Int32 _nWithoutMarkers) throw ( css::script::BasicErrorException ); void assignDiagramAttributes(); -void setDefaultSeriesDescriptionLabels(){} +void setDefaultSeriesDescriptionLabels() const {} public: ScVbaChart( const css::uno::Reference< ov::XHelperInterface >& _xParent, const css::uno::Reference< css::uno::XComponentContext >& _xContext, const css::uno::Reference< css::lang::XComponent >& _xChartComponent, const css::uno::Reference< css::table::XTableChart >& _xTableChart ); // Non-interface -css::uno::Reference< css::beans::XPropertySet > xDiagramPropertySet() { return mxDiagramPropertySet; } +css::uno::Reference< css::beans::XPropertySet > xDiagramPropertySet() const { return mxDiagramPropertySet; } bool isSeriesIndexValid(sal_Int32 _seriesindex) throw( css::script::BasicErrorException ); bool areIndicesValid(sal_Int32 _seriesindex, sal_Int32 _valindex) throw ( css::script::BasicErrorException ); void setSeriesName(sal_Int32 _index, rtl::OUString _sname) throw ( css::script::BasicErrorException ); diff --git a/sc/source/ui/vba/vbaformatconditions.hxx b/sc/source/ui/vba/vbaformatconditions.hxx index e51ca23..4193332 100644 --- a/sc/source/ui/vba/vbaformatconditions.hxx +++ b/sc/source/ui/vba/vbaformatconditions.hxx @@ -50,7 +50,7 @@ public: rtl::OUString getA1Formula(const css::uno::Any& _aFormula) throw ( css::script::BasicErrorException ); rtl::OUString getStyleName(); void removeFormatCondition( const rtl::OUString& _sStyleName, sal_Bool _bRemoveStyle) throw ( css::
[Libreoffice] Linux distros and LibO packaging
Hi all, I think that we should have a webpage where Linux distributions who are packaging LibO, could list what changes they made compared to the "official" build by TDF. I see two main advantages : - for users and helpers : they will know easier if a problem comes from LibO or from packaging - for QA : it will be easier to know if a test done, for example on a version from Ubuntu PPA, may be consider as valid or not for LibO from a general point of view. Last but not least, that will increase transparency : we will know what we are talking about when we will talk about LibreOffice. ;-) So, is it a good idea to ask the Linux distributions to publish the changes they made to the official build ? Best regards JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH 1/2] Translated comments from German to English
On Fri, 2011-01-07 at 21:30 +0100, Christina Roßmanith wrote: > The 2nd patch just removes some white spaces and leftover conflict > markers. I hope the two patches together are fine... I fiddled these patches a bit to apply and remove the lines that just changed whitespace and some other cleanups to just isolate the translations themselves. Pushed the results of this, thanks for your efforts. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Strange sorting of top level menu
Le 06/01/2011 19:33, leif a écrit : > When I see the Startcenter I see the Insert to the most right position > and not as expected between View and Tools. This occurs only when the > start center is visible. When I start or open a document the position is > correct. > > Screendump: > http://picasaweb.google.com/lh/photo/LroFAuzV1Wmj04_1mY8cIQ?feat=directlink > > Using Ubuntu Linux. I just changed from manual installation to > http://ppa.launchpad.net/libreoffice/ppa/ubuntu . I'm not sure that the > problem was before. > > Tomorrow I will check with my computer at work if it occurs consequent. Hi Leif, Have you tried with a clean personal profile ? I do not reproduce on my Ubuntu 10.04 x86_64 with the same PPA. Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Bug 32790 fixed - please review
On Sat, 2011-01-08 at 18:26 -0500, Kohei Yoshida wrote: > Hi there, > > I've just fixed and attached a patch to > > https://bugs.freedesktop.org/show_bug.cgi?id=32790 > > intended for 3.3. I would appreciate it if someone who is experienced > in the writer mail merge code to review and approve this. Looks sane to me, pushed this to 3-3. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Regression in PDF-Export: background color of a hatching not exported
Hi, a user gave me a hint on our de-users-list about a posible regression in LO (OOo) 3.3.0 to OOo 3.2.1. I made some tests and can confirm a regression. The background color of a hatching is not exported anymore. I created an issue for it and sent a notice to the releases-list of OOo. http://de.openoffice.org/issues/show_bug.cgi?id=116371 I don't think we need a duplicate of this issue in our bugtracker, did we? Regards, Andreas -- ## Developer LibreOffice ## Freie Office-Suite für Linux, Mac, Windows ## http://LibreOffice.org ## Support the Document Foundation (http://documentfoundation.org) ## Meine Seite: http://www.amantke.de ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice