[Libreoffice] Review needed - wikihelp always English
Hi, Can you please review the patch in the following bug, and push to libreoffice-3-3? https://bugs.freedesktop.org/show_bug.cgi?id=33258 It fixes a 3.3.1 blocker. Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remove old Word 6.0/95 save as support
Hi Bryan, On Wed, 2011-02-02 at 00:06 -0500, Bryan Quigley wrote: I'd like to get opinions (and preferably consensus) on removing old Microsoft formats save as support, specifically: Word 6.0 Word 95 Excel 5.0 Excel 95 I would be all for it too... it's even an easy hack you could achieve. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
On 01/02/11 22:15, Tor Lillqvist wrote: I am sure some people could be annoyed also by being reminded that there are languages spoken in their country that they perhaps consider leftovers from invaders and not real language of their country. Or the other way around, people feeling they belong to an oppressed linguistic minority would complain if a dictionary of their language isn't installed even if they choose all dictionaries for your country. Mmmm. Good point. Surely we want to avoid stepping into such a minefield. Whatever we do it's going to be a minefield. After all how do we classify dictionaries? But as far as I'm aware, dictionaries are coded like en_US, en_GB, es_ES, es_AR sort of thing. The best thing would be to offer all dictionaries where the country code matches. And if there are problems like you suggest, then there are two obvious replies: If the complaint is but my language (eg ga_GB for gaelic) isn't there, the response is well, add it then. And if the complaint is but this language (eg ur_FJ for Fijian urdu) is offensive / shouldn't be there, then the answer is LO is a Free Software project. You are trying to deny other people their freedom to speak their own language. I know that might not go down well, but it's a very good Free response, and should be accepted by anybody who understands our philosophy. (What we do if the complaint is but there are too many minor languages, I don't know! :-) That's the clutter thing again) Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remove old Word 6.0/95 save as support
2011/2/2 Cedric Bosdonnat cedric.bosdonnat@free.fr: Hi Bryan, On Wed, 2011-02-02 at 00:06 -0500, Bryan Quigley wrote: I'd like to get opinions (and preferably consensus) on removing old Microsoft formats save as support, specifically: Word 6.0 Word 95 Excel 5.0 Excel 95 I would be all for it too... it's even an easy hack you could achieve. Excel 5.0 format is still in use for data exchange in Hungarian organizations. I helped to work-around http://qa.openoffice.org/issues/show_bug.cgi?id=32785 a few months ago. Please keep old Excel formats for a while. IMHO old Word formats are obsolete. Cheers, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
Le 02/02/2011 10:53, Wols Lists a écrit : On 01/02/11 22:15, Tor Lillqvist wrote: I am sure some people could be annoyed also by being reminded that there are languages spoken in their country that they perhaps consider leftovers from invaders and not real language of their country. Or the other way around, people feeling they belong to an oppressed linguistic minority would complain if a dictionary of their language isn't installed even if they choose all dictionaries for your country. Mmmm. Good point. Surely we want to avoid stepping into such a minefield. Whatever we do it's going to be a minefield. That is a reason why I suggest to leave the user make its own choice among the available dictionaries (only one, all, whatever he want). The issue is: how to code an installer which does that clearly and with lightness? So I restate one of my questions : what is the tool used to code the installer ? Best regards. -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
That is a reason why I suggest to leave the user make its own choice among the available dictionaries (only one, all, whatever he want). Which is exactly what the user can do in a custom installation. So I restate one of my questions : what is the tool used to code the installer ? A bunch of source data files in scp2 (used on all platforms), a pile of Perl run from solenv/bin/make_installer.pl, a number of template .idt files for Windows Installer, which are then mangled by the Perl code and produces stuff fed to Windows Installer tools like msidb, ending up with a .msi file, one or several .cab files, and optionally a number of .mst files. Then there is a setup.exe which is plain C++ code which is a small program that just runs msiexec on the .msi file, telling it which installer UI localisation to use. And finally all this can optionally be wrapped by NSIS into a single executable file installer like the ones that we offer. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
If I may contribute with my 2cents why not use the best ideas already on the field? The perfect installer IMHO should start with a simple box to select the language used by the installer itself (where the detected locale is suggested) An example is the first screen for the FLOSS Abiword http://www.abisource.com/ http://nabble.documentfoundation.org/file/n2404563/Select_language.png This variable (user confirmed) can be used from this step forward in the installer dialogs and inclusively to select the language of the GNU agreement and obviously for selecting the GUI and dictionaries to be installed. But better yet on the next step use the best solution already provided also by Abiword The components are selected according to the type of install but the user can see what is selected and add/remove any component on the same screen (please notice that all the text in this installation step is already displayed in the language selected on the first step, I just switched to English for this example) http://nabble.documentfoundation.org/file/n2404563/components.png Finally the cherry on the top of the cake: in addition to the included dictionaries (English is included as default but others can probably be added) you have an option to download other dictionaries during installation (although you can also add them on the fly at any time after installation) http://nabble.documentfoundation.org/file/n2404563/dictionaries.png I think this is the best installer possible. -- View this message in context: http://nabble.documentfoundation.org/MS-Windows-about-dictionaries-installation-tp2382566p2404563.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
On Wed, Feb 2, 2011 at 12:10 PM, plino pedl...@gmail.com wrote: If I may contribute with my 2cents why not use the best ideas already on the field? The perfect installer IMHO should start with a simple box to select the language used by the installer itself (where the detected locale is suggested) An example is the first screen for the FLOSS Abiword http://www.abisource.com/ http://nabble.documentfoundation.org/file/n2404563/Select_language.png This variable (user confirmed) can be used from this step forward in the installer dialogs and inclusively to select the language of the GNU agreement and obviously for selecting the GUI and dictionaries to be installed. But better yet on the next step use the best solution already provided also by Abiword The components are selected according to the type of install but the user can see what is selected and add/remove any component on the same screen (please notice that all the text in this installation step is already displayed in the language selected on the first step, I just switched to English for this example) http://nabble.documentfoundation.org/file/n2404563/components.png Finally the cherry on the top of the cake: in addition to the included dictionaries (English is included as default but others can probably be added) you have an option to download other dictionaries during installation (although you can also add them on the fly at any time after installation) http://nabble.documentfoundation.org/file/n2404563/dictionaries.png I think this is the best installer possible. LibreOffice is distributed in a CD-ROM in places where is no internet connection (yes, they still exist) so it's good if the diccionaries are not downloaded but are bundled in the installer. -- Jesús Corrius je...@softcatala.org Document Foundation founding member Skype: jcorrius | Twitter: @jcorrius ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
On 02/02/11 11:22, Jesús Corrius wrote: Finally the cherry on the top of the cake: in addition to the included dictionaries (English is included as default but others can probably be added) you have an option to download other dictionaries during installation (although you can also add them on the fly at any time after installation) http://nabble.documentfoundation.org/file/n2404563/dictionaries.png I think this is the best installer possible. LibreOffice is distributed in a CD-ROM in places where is no internet connection (yes, they still exist) so it's good if the diccionaries are not downloaded but are bundled in the installer. Bit more work, but can we provide two installers? Installer (a) is a tiny download that then pulls everything it needs from the net. Installer (b) is a kitchen sink installer that contains everything. I've built a couple of SuSE systems recently, and they use that principle - a net install CD that's a couple of hundred meg, or an offline install that's a full 4.7Gb DVD. That way we satisfy both camps, and also nobody gets any nasty surprises - as always it's the principle of least shock... Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
Jesús, obviously a CD/DVD installer should include everything. This is a suggestion for a downloadable installer where size matters :) -- View this message in context: http://nabble.documentfoundation.org/MS-Windows-about-dictionaries-installation-tp2382566p2404670.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] solenv/inc/settings.mk overwrites CDEFS
Thanks, didn't see that. I fixed it that way. -Thomas On 02/02/2011 12:48 AM, Norbert Thiebaud wrote: On Tue, Feb 1, 2011 at 5:05 PM, Thomas Arnhold tho...@arnhold.org wrote: Hi, I just found out, that settings.mk resets all CDEFS which were defined in some makefiles. For example: sc/source/ui/vba/makefile.mk defines: CDEFS+=-DVBA_OOBUILD_HACK But some lines later settings.mk is included (which is solenv/inc/settings.mk) .INCLUDE : settings.mk In this file CDEFS is reset. So VBA_OOBUILD_HACK doesn't get defined for sc/source/ui/vba. Is this intended or a bug? based on the other 2 uses of VBA_OOBUILD_HACK, I'd imagine that the CDEF should be _after_ the include setting.mk Norbert -Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)
in moz\zipped I found some info on the openoffice.org wiki. The next hurdle seems to be getting the MS SDK. I'm d/l the win7 version as its smaller and hopefully okay but it is looking like it will take all night. I might have this working in a couple of weeks at this rate. Also, I noticed some oddities. checking size of long... 0!! config kept picking up /usr/bin/csc.exe which seems to be some kind of scheme interpreter. I just pulled in all the cygwin dev tools so I guess I ended up with it. I renamed the file something else and it is now picking up the DotNet version. It also appears that when using VCExpress that ATL and COM is out so some features will go missing, presumably. Regards Steven Butler ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)
On 2011-02-02 at 13:56, tlillqv...@novell.com wrote: checking size of long... 0!! Equally fun is the one that follows immediately: checking whether byte ordering is bigendian... yes The result of that test must not be really used anywhere either. I will remove it, too. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remove old Word 6.0/95 save as support
On Wed, 2011-02-02 at 06:30 +0100, Jean-Baptiste Faure wrote: So, Does anyone still need to save in an extremely old version of Word or Excel? Or can we get rid of it? I agree : for very old closed formats, LibO should have only import filters. Removing save support for MSWord 6/'95 disturbs me somewhat, being able to save as that old .doc format is handy for me to perturb MSOffice to flush out problems in those binary formats. Maybe I'm just emotionally attached to it to see it removed. I take the point about people saving as 6/95 because they want a something that will definitely work in MSOffice, what about just rearranging the save format list so that it appears way down at the bottom or something. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)
No chance it's used to support writing some of the binary file formats out uniformly across different endians? Nope. OOo/LibreOffice has its own stuff for all such things, since very long times. The configure script is a relatively late addition to OOo/LibreOffice. Anyway, I noticed that SIZEOF_LONG and WORDS_BIGENDIAN are checked in set_soenv.in to for some rare platforms (MIPS, PowerPC, S390x), so I will not remove them from configure.in. I will just bypass the failing tests on Windows, and hardcode the correct values (even if not needed as such on Windows). --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: unit tests and DT_RPATH/DT_RUNPATH ?
On Wed, 2011-01-26 at 16:52 +, Caolán McNamara wrote: That's not quite what we want. So, the attached sets DT_RUNPATH which does what we want, i.e. LD_LIBRARY_PATH override the rpath in that case. Anyone see anything that could go wrong with doing this :-) ? Re-read How to Write Shared libraries and pushed this now seeing as it looks like I'm right. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Review needed - wikihelp always English
Jan Holesovsky wrote: Can you please review the patch in the following bug, and push to libreoffice-3-3? https://bugs.freedesktop.org/show_bug.cgi?id=33258 It fixes a 3.3.1 blocker. Looks good, done. -- Thorsten pgpvbkeMtvk3e.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] remove unused declaration - an unlikely fix for armel segfault in regcomp
On 28/01/11 15:19, Michael Meeks wrote: Perhaps I'll gather enough courage to annoy all the legacy uni-processor Intel guys in a bit, and put that in-line in a header for the GCC cases [ if this works out nicely on OSX that is ] Not quite sure what you mean by legacy Intel, but if you're referring to all single-processor CPUs, they still power most of the budget brand new laptops! I was looking (for family) for new laptops, and dual-core was not the norm at christmas for the budget end. Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=32894 Bug 32894 depends on bug 33258, which changed state. Bug 33258 Summary: regardless of UI language always en wikihelp is launched https://bugs.freedesktop.org/show_bug.cgi?id=33258 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] SVG export filter improvements
KUROSAWA, Takeshi wrote:
Here are some patches to improve SVG export filter.
Hi Takeshi,
wow, this is great work! I have only one comment (and a suggestion,
see below):
0003: Make filter export linear and axial gradients as SVG linearGradients.
Use SVG's native gradient instead of polygon fallback.
With this patch, gradient steps of linear and axial gradient are ignored.
In other words, linear and axial gradients are always exported as
smooth gradients.
However, as far as I know, the manual steps function is for printing.
So I suppose ignoring gradient steps is safe.
Nope, this is still in use, especially in legacy binary documents
(soon to be axed I guess), and more importantly, for all those svm
metafiles. Could you keep both code paths - i.e. falling back to the
old code, should there be a step count (with 0 meaning smooth
gradient, and maybe you can even cut off at something like 100 or so
steps)?
I have not yet applied the patches, to not interfere with potential
rework on your side.
A bit orthogonal to this great improvement, let me point you to
https://github.com/knobo/OOo-svg-Export.git - this is an early stage
of a slightly different attempt, using the new drawing layer
primitives (that contain more high-level geometry information, like
stroking etc.). I attach two changes I had lying around locally -
maybe you're also interested in looking into that.
Additionally (though not sure it's of help here, as it's designed
for high-level ODF-style gradients) - there's
basegfx/inc/basegfx/tools/gradienttools.hxx, that encapsulates most
of the pain involved in converting gradient types.
To support native gradients, I need to calculate a bounding box of a gradient.
Currently it is done in OutputDevice::ImplDrawLinearGradient and
OutputDevice::ImplDrawComplexGradient.
So I moved that to Gradient class (0002 patch) to use it in filter code.
This is fine.
0004: Make filter export transparencies as SVG masks.
SVG export filter supports only solid transparency of solid fill (i.e.
color) until now.
The patch extends support to support solid and gradient transparency
of all fill styles.
# Some SVG viewers including WebKit don't support mask yet :-(.
I'd take that route anyway.
Cheers,
-- Thorsten
From 95ebed72916aeded24043bb7189d97c6c9031946 Mon Sep 17 00:00:00 2001
From: Thorsten Behrens tbehr...@novell.com
Date: Tue, 16 Nov 2010 22:59:51 +0100
Subject: [PATCH 1/2] Write header, more compile fixes
---
exports.map|9 ++
makefile.mk| 68 +++
svgexport2.cxx | 88 +---
svgexport2.hxx |6 ++--
4 files changed, 138 insertions(+), 33 deletions(-)
create mode 100644 exports.map
create mode 100644 makefile.mk
diff --git a/exports.map b/exports.map
new file mode 100644
index 000..532415a
--- /dev/null
+++ b/exports.map
@@ -0,0 +1,9 @@
+UDK_3_0_0 {
+global:
+component_getImplementationEnvironment;
+component_getFactory;
+component_writeInfo;
+
+local:
+*;
+};
diff --git a/makefile.mk b/makefile.mk
new file mode 100644
index 000..f0a23fa
--- /dev/null
+++ b/makefile.mk
@@ -0,0 +1,68 @@
+#*
+#
+# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+#
+# Copyright 2000, 2010 Oracle and/or its affiliates.
+#
+# OpenOffice.org - a multi-platform office productivity suite
+#
+# This file is part of OpenOffice.org.
+#
+# OpenOffice.org is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License version 3
+# only, as published by the Free Software Foundation.
+#
+# OpenOffice.org is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU Lesser General Public License version 3 for more details
+# (a copy is included in the LICENSE file that accompanied this code).
+#
+# You should have received a copy of the GNU Lesser General Public License
+# version 3 along with OpenOffice.org. If not, see
+# http://www.openoffice.org/license.html
+# for a copy of the LGPLv3 License.
+#
+#*
+
+PRJ=..$/..
+
+PRJNAME=filter
+TARGET=svgexport
+ENABLE_EXCEPTIONS=TRUE
+VISIBILITY_HIDDEN=TRUE
+
+# --- Settings --
+
+.INCLUDE : settings.mk
+.INCLUDE : libs.mk
+
+# --- Types -
+
+SLOFILES= $(SLO)$/svgexport2.obj
+
+# --- Library ---
+
+SHL1TARGET=$(TARGET)$(DLLPOSTFIX)
+
+SHL1STDLIBS=\
+$(BASEGFXLIB) \
+$(UNOTOOLSLIB) \
+$(TOOLSLIB) \
+ $(DRAWINGLAYERLIB) \
+$(COMPHELPERLIB) \
+$(CPPUHELPERLIB) \
+$(CPPULIB) \
+$(SALLIB)
+
+SHL1DEPN=
Re: [Libreoffice] Remove old Word 6.0/95 save as support
At 12:06am -0500 Wed, 02 Feb 2011, Bryan Quigley wrote: [ Should we remove export capabilities to old file formats? ] The usability problem I've seen is that users: * want to save in MS Word format, but don't know what version to use * the pick 6.0 or 95 thinking many different things (lower number means it will work with more computers?) * since this is there only copy of the file, they lose all tables and more I think you've made a good point. However, I don't think removing the Save As support should be decided from a usability perspective, as I can envision certain workflows that require interaction between older versions of MS Word. I think the longer-term and better solution is to rework the logic such that it's not a binary decision of Lose info? or save in ODF format? See below ... We currently have the same This document may contain formatting or content that can not be saved in... message for if you are saving to Word 97/2000/XP (very good at saving) or Word 6.0 (very bad at saving). This message and associated logic needs updating. Specifically, my user's understanding is that if the file is not to be saved as an ODF file (odt, ods, od, etc.), then LO shows that warning. This binary thinking is indicative of a younger project, and I submit that this is one area in which LO could show more prudence and maturity. Instead -- and I don't know how possible this currently is -- I think we should introspect the document and compare against the chosen file format's capabilities to list specific features that will be lost. - You are attempting to save this document to a Word 6.0 format. Word 6.0 does not support this feature that this document uses: * Tables If you save in this file format, the parts of this document using this feature will be lost. [ Lose document pieces ] [ Choose alternate format ] - Showing specifically what would be lost would be much more helpful, only bugs the user when appropriate, and does not wrongly presume in the button text that ODF format is the only format capable. I also do not think customizing this text to make it more specific will help. Users have become trained by the interface to ignore this message (this is a different usability issue, NOT a user issue). I do not agree unless updating the text is all that is on the table. Specifically, if all the features in use that are supported by the file format, then we should not display that dialog. Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=32894 --- Comment #15 from Jesus Corrius je...@softcatala.org 2011-02-02 06:34:01 PST --- I'd like to nominate bug 33785 as a blocker. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remove old Word 6.0/95 save as support
On Wed, 2011-02-02 at 09:14 -0500, Kevin Hunter wrote: Instead -- and I don't know how possible this currently is -- I think we should introspect the document and compare against the chosen file format's capabilities to list specific features that will be lost. Hard to do, there *is* some ultra-basic and probably abandoned logging stuff which could be converted to that, e.g. sw::log::Tracer, but it would be a lot of effort to categorize and organize the filters to give correct and useful results. And in a lot of cases actually implementing the missing bits would be easier than logging the failure :-) in the cases where the problem is not inherent in the capabilities of the output/input format. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Utility to scan for some faults in Thesaurus files
Steve Butler wrote: The l10n guys said they needed this utility in git as their list does not allow attachments. I will leave it up to your wisdom as to where to put it. Hi Steve, nice, good work here - put that into solenv/bin/th_check.pl (inside the bootstrap repo). Cheers, -- Thorsten pgpgNolRh6b4S.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remove old Word 6.0/95 save as support
Hi, My question is what we will win if we remove. Personally I prefer to keep support for such formats. KAMI 2011-02-02 10:18 keltezéssel, Cedric Bosdonnat írta: Hi Bryan, On Wed, 2011-02-02 at 00:06 -0500, Bryan Quigley wrote: I'd like to get opinions (and preferably consensus) on removing old Microsoft formats save as support, specifically: Word 6.0 Word 95 Excel 5.0 Excel 95 I would be all for it too... it's even an easy hack you could achieve. Regards, signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] leak per frame, mac input request.
On Tue, 2011-02-01 at 10:59 -0600, Norbert Thiebaud wrote: Yes there is somethng special on Mac: there is one menu bar only and it is at the top of the display. it has a little apple icon as first menu, then a menu that is named with the name of the application. in that later menu you should find the About item and the Preference Item. I pushed the changes I wanted to make to this thing, could you check that it still works now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [REVIEW] remove old icon themes ...
Michael Meeks wrote: It works out ok. Pushed to -3-3 then. -- Thorsten pgpFuKCCtySwD.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] development summary: year 2011, week 4
Petr Mladek píše v Po 31. 01. 2011 v 19:41 +0100: Hi, this time a brief summary of what happened during the 4th week in 2011 on LibreOffice repositories and the living branches: + master:hot LO-3.4 development + libreoffice-3-3: fixes for next LO-3.3.x bug fix release[*] There are two logs for each branch: + bugfixes-branch-year-week.txt lists all commits that reference a proper bug id from a variety of trackers, i.e. #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla + commit-log-branch-year-week.txt lists all relevant commits on the actual source repositories [*] the logs for the libreoffice-3-3-0 branch are not attached because they are empty; I am sure that there will be more life this week as the LO-3.3.1 release is getting close Ah, there were commits in the libreoffice-3-3-0 branch last week. Please, find them attached. I checked libreoffice-3-3-0 branch by mistake on Monday. I am sorry for the confusion. Best Regards, Petr + bootstrap + wrong line break with ( (fdo#31271) [Caolán McNamara] + extras + start using technical.dic instead of oracle.dic (fdo#31798) [Kalman Szalai - KAMI] + libs-core + fix KDE3 library search order (fdo#32797) [Luboš Luňák] + start using technical.dic instead of oracle.dic (fdo#31798) [Kalman Szalai - KAMI] + help + oOo - LibO on Getting Support page (fdo#33249) [Andras Timar] + ure + manipulate also the C runtime's environment (fdo#33355) [Tor Lillqvist] + l10n + s/OpenOffice/OpenDocument/ in zh-TW desktop UI (fdo#33745) [Andras Timar] + libs-extern-sys + wrong line break with ( (fdo#31271) [Caolán McNamara] + libs-gui + fix KDE3 library search order (fdo#32797) [Luboš Luňák] + fix for (fdo#32561) [Caolán McNamara] + wrong line break with ( (fdo#31271) [Caolán McNamara] + components + fix window focus for langpack installation on Mac fdo# 33056 [Alexander Thurgood] + revert Initial LibO mimetype icon design [Thorsten Behrens] + filters + use PYTHON as passed through by set_soenv.in. [Thomas Klausner] + use double instead of float [Fridrich Štrba] + bootstrap + pass thru PYTHON, found by configure. [Thomas Klausner] + upgrade libwpd to 0.9.1 [Fridrich Štrba] + wrong line break with ( (fdo#31271) [Caolán McNamara] + extras + start using technical.dic instead of oracle.dic (fdo#31798) [Kalman Szalai - KAMI] + writer + translations need more space on word count dialog [Andras Timar] + libs-core + fix KDE3 library search order (fdo#32797) [Luboš Luňák] + start using technical.dic instead of oracle.dic (fdo#31798) [Kalman Szalai - KAMI] + help + oOo - LibO on Getting Support page (fdo#33249) [Andras Timar] + ure + manipulate also the C runtime's environment (fdo#33355) [Tor Lillqvist] + libs-extern + upgrade libwpd to 0.9.1 [Fridrich Štrba] + l10n + s/OpenOffice/OpenDocument/ in zh-TW desktop UI (fdo#33745) [Andras Timar] + calc + remove unused declaration [Jani Monoses] + build + don't repeat oneself [Fridrich Štrba] + fix a typo [Fridrich Štrba] + make ./download work with the git over http too [Fridrich Štrba] + make CC/CXX configurable again (there's a gcc-4.0 incompat on mac) [Thorsten Behrens] + libs-extern-sys + wrong line break with ( (fdo#31271) [Caolán McNamara] + libs-gui + fix KDE3 library search order (fdo#32797) [Luboš Luňák] + fix for (fdo#32561) [Caolán McNamara] + fix wrong collation for Catalan language [Jesús Corrius] + wrong line break with ( (fdo#31271) [Caolán McNamara] ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remove old Word 6.0/95 save as support
At 12:06am -0500 Wed, 02 Feb 2011, Bryan Quigley wrote: I believe the old binary StarOffice file save as support is going away soon as well. Perhaps tangentially (or not at all related), does anyone know if any of the plugins rely on particular file format export capabilities? Specifically, I just read this from three days ago, and noted a reference to the StarBasic engine and Anaphraseus: http://user.services.openoffice.org/en/forum/viewtopic.php?t=37918 I don't use many extensions, but I understand that they're a core part of many users' workflows. Is StarBasic engine a different beast from the various StarOffice export/import filters? Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] avoid ambiguous else
Hi,
On building calc, I found a warning suggesting an ambiguous else.
The attached patch is under LGPLv3+/MPL.
Cheers,
-- Takeshi Abe
From 5f9df0274b47fbf81bf2dc3789dd5e8719360549 Mon Sep 17 00:00:00 2001
From: Takeshi Abe t...@fixedpoint.jp
Date: Thu, 3 Feb 2011 03:13:53 +0900
Subject: [PATCH] avoid ambiguous else
---
sc/source/ui/miscdlgs/acredlin.cxx |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/sc/source/ui/miscdlgs/acredlin.cxx b/sc/source/ui/miscdlgs/acredlin.cxx
index ceba5b4..27b1150 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -343,10 +343,10 @@ BOOL ScAcceptChgDlg::IsValidAction(const ScChangeAction* pScChangeAction)
aComment.EraseAllChars('\n');
if(eType==SC_CAT_CONTENT)
-if(!pScChangeAction-IsDialogParent())
-pScChangeAction-GetDescription( aDesc, pDoc, TRUE);
-else
-pScChangeAction-GetDescription( aDesc, pDoc,!pScChangeAction-IsMasterDelete());
+{
+BOOL bTest = !pScChangeAction-IsDialogParent() || !pScChangeAction-IsMasterDelete();
+pScChangeAction-GetDescription( aDesc, pDoc, bTest );
+}
if(aDesc.Len()0)
{
--
1.7.2.3
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Reworking build.pl: What to do with the --html and --interactive parameters
On 28.01.2011 22:53, Christian Lohmaier wrote:
Hi Michael, *,
On Fri, Jan 28, 2011 at 4:21 PM, Michael Meeksmichael.me...@novell.com wrote:
On Fri, 2011-01-28 at 15:29 +0100, Christian Lohmaier wrote:
No, please don't --html in combination with --dontgraboutput is
usefull for parallel builds to have the output not interwoven.
(or add that feature with other means.
So - the requirement is that we log each build's output to somewhere,
as well as the console, so it can be got without being mangled up with
other stuff ?
Having it at the console is important for tinderbox/buildbot use. the
html switch controls the order it is being printed, not ABBBAAAB, but
- that it generates a html status page is just a side-effect
in this usecase.
Could we just drop that in the module's build directory ?
Wenn you kill the file in the module's build directory, you kill the
html page's show the log feature, as the individual module's log is
loaded by the master html-page.
build --html will create both the status-html (the progress bar as
well as putting the module's log intolocaloutput/misc/log (IIRC).
So it does that already. Or might be that I misundertsand completely.
I don't have strong feelings about having the actual html page or not.
When I started building, I used it quite a bit, but now I do automated
builds, so I don't sit and wait man, when it is finished :-)
ciao
Christian
Hi Christian
I made a deeper analysis of the build.pl. --html activates verbose mode
of dmake and deliver and --dontgraboutput calls a cat of a
generated log file. This seems to be the functionality you need. I've
now introduced a new parameter called --verbose which substitutes the
functionality of --html --dontgraboutput.
Could you please test --verbose in your environment to see if it works
as expected (after this patch is pushed :-). If the tests are
successful, I will remove all the unneeded parts. For backward
compatibility I will link the out-dated parameters to the new --verbose
param.
Thanks,
Michael
From cdaf7eb4ae71ca46320caf738e0cd634499bceee Mon Sep 17 00:00:00 2001
From: Michael Koch m...@gmx.ch
Date: Wed, 2 Feb 2011 18:53:37 +0100
Subject: [PATCH] Added --verbose param
--verbose substitutes the needed functionality of
--html --dontgraboutput. The unneeded parts will be removed in
a second step.
---
solenv/bin/build.pl | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/solenv/bin/build.pl b/solenv/bin/build.pl
index fc841eb..f9ece6c 100755
--- a/solenv/bin/build.pl
+++ b/solenv/bin/build.pl
@@ -206,6 +206,8 @@
my $zenity_in = '';
my $zenity_out = '';
my $zenity_err = '';
+my $verbose = 0;
+
### main ###
get_options();
@@ -251,7 +253,7 @@
provide_consistency() if (defined $ENV{CWS_WORK_STAMP} defined($ENV{COMMON_ENV_TOOLS}));
$deliver_command = $ENV{DELIVER};
-$deliver_command .= ' -verbose' if ($html);
+$deliver_command .= ' -verbose' if ($html || $verbose);
$deliver_command .= ' '. $dlv_switch if ($dlv_switch);
$ENV{mk_tmp}++;
%prj_platform = ();
@@ -1124,7 +1126,7 @@ sub get_commands {
while ($arg = pop(@dmake_args)) {
$dmake .= ' '.$arg;
};
-$dmake .= ' verbose=true' if ($html);
+$dmake .= ' verbose=true' if ($html || $verbose);
};
#
@@ -1401,7 +1403,7 @@ sub print_error {
sub usage {
print STDERR \nbuild\n;
-print STDERR Syntax:build[--all|-a[:prj_name]]|[--from|-f prj_name1[:prj_name2] [prj_name3 [...]]]|[--since|-c prj_name] [--with_branches prj_name1[:prj_name2] [--skip prj_name1[:prj_name2] [prj_name3 [...]] [prj_name3 [...]|-b]|[--prepare|-p][:platform] [--deliver|-d [--dlv_switch deliver_switch]]] [-P processes|--server [--setenvstring \string\] [--client_timeout MIN] [--port port1[:port2:...:portN]]] [--show|-s] [--help|-h] [--file|-F] [--ignore|-i] [--version|-V] [--mode|-m OOo[,SO[,EXT]] [--html [--html_path html_file_path] [--dontgraboutput]] [--pre_job=pre_job_sring] [--job=job_string|-j] [--post_job=post_job_sring] [--stoponerror] [--genconf [--removeall|--clear|--remove|--add [module1,module2[,...,moduleN [--exclude_branch_from prj_name1[:prj_name2] [prj_name3 [...]]] [--interactive]\n;
+print STDERR Syntax:build[--all|-a[:prj_name]]|[--from|-f prj_name1[:prj_name2] [prj_name3 [...]]]|[--since|-c prj_name] [--with_branches prj_name1[:prj_name2] [--skip prj_name1[:prj_name2] [prj_name3 [...]] [prj_name3 [...]|-b]|[--prepare|-p][:platform] [--deliver|-d [--dlv_switch deliver_switch]]] [-P processes|--server [--setenvstring \string\] [--client_timeout MIN] [--port port1[:port2:...:portN]]] [--show|-s] [--help|-h] [--file|-F] [--ignore|-i] [--version|-V] [--mode|-m OOo[,SO[,EXT]] [--html [--html_path html_file_path] [--dontgraboutput]] [--pre_job=pre_job_sring] [--job=job_string|-j] [--post_job=post_job_sring] [--stoponerror] [--genconf [--removeall|--clear|--remove|--add
Re: [Libreoffice] [PATCH] Reworking build.pl: What to do with the --html and --interactive parameters
Sorry, I noticed a mistake in my last patch. Here is the amended version.
Michael
On 02.02.2011 19:23, Michael Koch wrote:
On 28.01.2011 22:53, Christian Lohmaier wrote:
Hi Michael, *,
On Fri, Jan 28, 2011 at 4:21 PM, Michael
Meeksmichael.me...@novell.com wrote:
On Fri, 2011-01-28 at 15:29 +0100, Christian Lohmaier wrote:
No, please don't --html in combination with --dontgraboutput is
usefull for parallel builds to have the output not interwoven.
(or add that feature with other means.
So - the requirement is that we log each build's output to somewhere,
as well as the console, so it can be got without being mangled up with
other stuff ?
Having it at the console is important for tinderbox/buildbot use. the
html switch controls the order it is being printed, not ABBBAAAB, but
- that it generates a html status page is just a side-effect
in this usecase.
Could we just drop that in the module's build directory ?
Wenn you kill the file in the module's build directory, you kill the
html page's show the log feature, as the individual module's log is
loaded by the master html-page.
build --html will create both the status-html (the progress bar as
well as putting the module's log intolocaloutput/misc/log (IIRC).
So it does that already. Or might be that I misundertsand completely.
I don't have strong feelings about having the actual html page or not.
When I started building, I used it quite a bit, but now I do automated
builds, so I don't sit and wait man, when it is finished :-)
ciao
Christian
Hi Christian
I made a deeper analysis of the build.pl. --html activates verbose mode
of dmake and deliver and --dontgraboutput calls a cat of a
generated log file. This seems to be the functionality you need. I've
now introduced a new parameter called --verbose which substitutes the
functionality of --html --dontgraboutput.
Could you please test --verbose in your environment to see if it works
as expected (after this patch is pushed :-). If the tests are
successful, I will remove all the unneeded parts. For backward
compatibility I will link the out-dated parameters to the new --verbose
param.
Thanks,
Michael
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
From 02fd61215b52adea74867c6b123bffe3de978bf2 Mon Sep 17 00:00:00 2001
From: Michael Koch m...@gmx.ch
Date: Wed, 2 Feb 2011 18:53:37 +0100
Subject: [PATCH] Added --verbose param
--verbose substitutes the needed functionality of
--html --dontgraboutput. The unneeded parts will be removed in
a second step.
---
solenv/bin/build.pl | 14 +-
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/solenv/bin/build.pl b/solenv/bin/build.pl
index fc841eb..71f01d7 100755
--- a/solenv/bin/build.pl
+++ b/solenv/bin/build.pl
@@ -206,6 +206,8 @@
my $zenity_in = '';
my $zenity_out = '';
my $zenity_err = '';
+my $verbose = 0;
+
### main ###
get_options();
@@ -251,7 +253,7 @@
provide_consistency() if (defined $ENV{CWS_WORK_STAMP} defined($ENV{COMMON_ENV_TOOLS}));
$deliver_command = $ENV{DELIVER};
-$deliver_command .= ' -verbose' if ($html);
+$deliver_command .= ' -verbose' if ($html || $verbose);
$deliver_command .= ' '. $dlv_switch if ($dlv_switch);
$ENV{mk_tmp}++;
%prj_platform = ();
@@ -1124,7 +1126,7 @@ sub get_commands {
while ($arg = pop(@dmake_args)) {
$dmake .= ' '.$arg;
};
-$dmake .= ' verbose=true' if ($html);
+$dmake .= ' verbose=true' if ($html || $verbose);
};
#
@@ -1401,7 +1403,7 @@ sub print_error {
sub usage {
print STDERR \nbuild\n;
-print STDERR Syntax:build[--all|-a[:prj_name]]|[--from|-f prj_name1[:prj_name2] [prj_name3 [...]]]|[--since|-c prj_name] [--with_branches prj_name1[:prj_name2] [--skip prj_name1[:prj_name2] [prj_name3 [...]] [prj_name3 [...]|-b]|[--prepare|-p][:platform] [--deliver|-d [--dlv_switch deliver_switch]]] [-P processes|--server [--setenvstring \string\] [--client_timeout MIN] [--port port1[:port2:...:portN]]] [--show|-s] [--help|-h] [--file|-F] [--ignore|-i] [--version|-V] [--mode|-m OOo[,SO[,EXT]] [--html [--html_path html_file_path] [--dontgraboutput]] [--pre_job=pre_job_sring] [--job=job_string|-j] [--post_job=post_job_sring] [--stoponerror] [--genconf [--removeall|--clear|--remove|--add [module1,module2[,...,moduleN [--exclude_branch_from prj_name1[:prj_name2] [prj_name3 [...]]] [--interactive]\n;
+print STDERR Syntax:build[--all|-a[:prj_name]]|[--from|-f prj_name1[:prj_name2] [prj_name3 [...]]]|[--since|-c prj_name] [--with_branches prj_name1[:prj_name2] [--skip prj_name1[:prj_name2] [prj_name3 [...]] [prj_name3 [...]|-b]|[--prepare|-p][:platform] [--deliver|-d [--dlv_switch deliver_switch]]] [-P processes|--server [--setenvstring \string\] [--client_timeout MIN] [--port port1[:port2:...:portN]]] [--show|-s] [--help|-h] [--file|-F]
Re: [Libreoffice] Remove old Word 6.0/95 save as support
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2011 05:06 AM, Bryan Quigley wrote: I'd like to get opinions (and preferably consensus) on removing old Microsoft formats save as support, specifically: Word 6.0 Word 95 Excel 5.0 Excel 95 One of the virtues of OOo, and LibO, was the number of file formats that it can read from, and write to. Can that code be rewritten to Export As? Alternatively, can that code be rewritten as a user-installable extension? IOW, retain the ability of LibO to read/write those file formats. If the only way to have that functionality is thru an extension, then so be it. (Those file formats can join DAISY, Braille, and umpteen other file formats that LibO can either read from, or write to, only by using a user-installed extension.) jonathon -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNSaY6AAoJEERA7YuLpVrVeooIANtYAk2XYbm+KBaFcQSzXH/8 AAfRiJr2xo+kUFjcXL4CybBS5m5MqGJ7GQ0FSpcGOIu8SrU00elDtzkeyaVi+unI mAXm7cGVduTIgNKVAC5tDtqTvg/KYEi5XvCtQFzbTASUYySQ9trIXouMSKlBQCPJ KQbpfu5Ubbv3zCE3l1ypaCcxMb20UA3ctsQqknbnqAFhtvw6J93hUaGFwRZ0YAq9 oscROH5j4AGNgo79jGZFZgFwMnbPK9YPAGh6yE5mSiIjWqJaU6gOhlKZpmu7ZFEh GAR7/XjyRSK6PBrL7l5TAm7ZZm9G+fVuSagAkYvevJmFqknjB+o0pM0JqQQasQU= =S8fU -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Add support for DragonFly in configure.in
On 31/01/11 11:46, Francois Tigeot wrote: Sure. http://www.libreoffice.org/get-involved/developers/ says LO is licensed under both LGPLv3 and GPL. Shouldn't it be LGPLv3 and MPL ? Where? I've just taken a look (since I wrote a fair chunk of that). It says LibreOffice is LGPL3. It has to be, because it contains an awfully large amount of code (from OpenOffice) that is only available to us under the LGPL. It also says the project is using a dual LGPL/MPL licence, so all the code we have added is dual-licenced. We can't say LibreOffice is MPL, because large chunks of it aren't. Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Add support for DragonFly in configure.in
On 02/02/11 19:07, Wols Lists wrote: It also says the project is using a dual LGPL/MPL licence, so all the code we have added is dual-licenced. Oops - hit send and then realise Michael had already corrected it :-( Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remove old Word 6.0/95 save as support
I think jonathon-4's suggestion is brilliant! Keep the currently used formats in the Save As (sorted please!) dialog and old cryptic formats in a Export to option. This way no formats are lost but functionality is increased. -- View this message in context: http://nabble.documentfoundation.org/Remove-old-Word-6-0-95-save-as-support-tp2403218p2408005.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [libreoffice-l10n] Re: Utility to scan for some faults in Thesaurus files
Andras Timar wrote: The l10n guys said they needed this utility in git as their list does not allow attachments. I will leave it up to your wisdom as to where to put it. Pushed, many thanks. http://cgit.freedesktop.org/libreoffice/libs-extern-sys/commit/?id=89fc507a0e278381ad012b5be9a964cb0e22c0e7 Ah crap, missed this mail - put it into solenv/bin, too, will clean that up momentarily - meanwhile, added unit tests to all dictionary subdirs that have thesauri files (commented out for the handful of broken .dat files), so going forward, errors detected by th_check.pl will break the build. :) If someone fixes one of the offending .dat files, please remind one of the committers to enable the test, so it's not gonna break again. Thanks, -- Thorsten pgp8RWVDExDsK.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] avoid ambiguous else
On Thu, 2011-02-03 at 03:20 +0900, Takeshi Abe wrote: Hi, On building calc, I found a warning suggesting an ambiguous else. The attached patch is under LGPLv3+/MPL. Hmm... But your patch may change the intention of that code block based on how the lines are indented. Here is the code we have r Cheers, -- Takeshi Abe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] avoid ambiguous else
On Thu, 2011-02-03 at 03:20 +0900, Takeshi Abe wrote: Hi, On building calc, I found a warning suggesting an ambiguous else. The attached patch is under LGPLv3+/MPL. Hmm... But your patch may change the intention of that code block based on how the lines are indented. Here is the code we have right now if(eType==SC_CAT_CONTENT) if(!pScChangeAction-IsDialogParent()) pScChangeAction-GetDescription( aDesc, pDoc, TRUE); else pScChangeAction-GetDescription( aDesc, pDoc,!pScChangeAction-IsMasterDelete()); which makes me think the the else block is supposed to get executed when eType != SC_CAT_CONTENT I have no idea how the compiler parses that block of code as it is indeed ambiguous. But I'm more in favor of interpreting it based on the indent levels than how the compiler might be parsing it. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Use generic base64 encoder
KUROSAWA, Takeshi wrote: SVG export filter has own Base64 encoder in FastString class. But we have several more generic Base64 encoders in the code tree. e.g. [snip] Brilliant, excellent work - pushed! -- Thorsten pgp2VEyJ5lIGA.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] remove unused declaration - an unlikely fix for armel segfault in regcomp
On Wed, 2011-02-02 at 13:44 +, Wols Lists wrote: Not quite sure what you mean by legacy Intel, but if you're referring to all single-processor CPUs, they still power most of the budget brand new laptops! Surely those guys are hyper-threaded by now ? at least the Atom (which is cheap as chips [sic] ;-) is. I was looking (for family) for new laptops, and dual-core was not the norm at christmas for the budget end. ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Convert tools/list.hxx usage to std::list
On Tue, 2011-02-01 at 13:57 -0500, Jonathan Callen wrote: The attached patch replaces usage of LinkList (declared as DECLARE_LIST(LinkList, Link*) with std::listLink. I used listLink instead of listLink* because 1) the elements of the list were only ever used from within the .cxx file declaring the list itself and 2) each element was already allocated on addition and deallocated on removal, so I just made that more explicit by letting std::list handle it. Looks good. Pushed. BTW, I will not push your 2nd patch that replaces some of the iterator loops with BOOST_FOREACH. As we talked about this on IRC, I don't like the idea of replacing one macro with another, even if the documentation page claims this to be a good-behaving macro. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] remove unused declaration - an unlikely fix for armel segfault in regcomp
At 3:31pm -0500 Wed, 02 Feb 2011, Michael Meeks wrote: On Wed, 2011-02-02 at 13:44 +, Wols Lists wrote: Not quite sure what you mean by legacy Intel, but if you're referring to all single-processor CPUs, they still power most of the budget brand new laptops! Surely those guys are hyper-threaded by now ? at least the Atom (which is cheap as chips [sic] ;-) is. I recognize this comment was in gest, but thought I'd chime in with a tidbit. I believe that Intel removed HTT after the Pentium 4 chip. Of note, as well, is that hyperthreading (HTT) is not as universal an upgrade as true multi-core chips. In fact, the general practice in the High Performance Computing (HPC) community is to turn off hyperthreading because it degrades performance for most workloads. A further note is that there is some skepticism as to the security of HTT, in terms of side-channel monitoring of in-core process data. Actually, now that I just wrote the above, I seem to recall a discussion of HTT technology in the Nehalem chip. When I have time, I might research that ... Cheers, Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] minutes of tech steering call ...
Attending: Andras, Thorsten, Norbert, Kendy, Caolan, Kohei, Petr, Bjorn + Bjorn introduction welcome + 3.3.0 round-up / post-mortem + overall release went very well + positive surprise by lack of issues + no overly negative QA result + wiki help + web services should be treated as software + not fully there by RC, it doesn't ship + still an overly manual build / up-load process + merge things into 3.3.1 ... + new icons AA: + announce a new deadline for RC1 (Thorsten) + move to artists checking in and exporting icons themselves + web help directed English (Kendy) AA: + Kohei's writer useless in Japan bug pair (Caolan to swap) + Thorsten - collecting pending svg/pdf patches for review + Caolan/David - list of trivial pieces + Andras - lots of l10n improvements ... + already cherry picked + many translations pending for 3.3.1 RC1 AA: + ping translators to be done for 3.3.1 soon (Andras) AA: + WMF rendering crasher - make it a blocker (Michael) + review blockers ( currently seven open ) + move mail merge issues to 3.3.2 + punt template issue to 3.3.2 * RC1 due for tagging - Monday 7th heads (Andras) + 3.4 / cherry picking / merging plans (Norbert) + dev300 imported - 425 CWS' + typical conflicts with modelines + include guards re-work a problem + only few whitespace problems + hids, gnumake, etc. re-work an issue + overall 5000 conflicts, varies per repo + conservative premerge works well * do merge in separate repos + merge into a feature branch AA: + create separate staging repositories (Michael) * continue building pre-merges (Norbert, Michael) + postponing Norbert's new gnumake features until dev300 merge. AA: + create integration/dev300 branch (Norbert) + nightly snapshots + status of public availability etc. AA: + need public links / DNS domain love (Thorsten) + FOSDEM update (Kendy) + hoodies - for devs + booth guys + T-shirts - for sale + stickers for laptops + beds for everyone inc. volunteers; sorted by Thorsten. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=32894 Michael Meeks michael.me...@novell.com changed: What|Removed |Added Depends on||33785 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Move/hide old Word 6.0/95 save as support ...
Hi Bryan / all, On Wed, 2011-02-02 at 00:06 -0500, Bryan Quigley wrote: I'd like to get opinions (and preferably consensus) on removing old Microsoft formats save as support, specifically: It seems that the consensus (or at least, this is what I propose), is that this is indeed a good idea. IMHO we should also add to your list the bus-load of random, and the old (pre-ODF) .sx* formats as too[1]. It seems we should keep the code to do this, it can be useful, but hide them from users in some way. Either by adapting the 'Export' code to do this, or adding some further filtering in the file or options dialog to show/hide these extra filters. The usability problem I've seen is that users ... Agreed :-) it would make (as Cedric says) a great easy hack I hope. Adding it to the wiki there (with a few code pointers) would be far more effective than filing a bug. Thanks, Michael. [1] - the weirdo StarOffice binary formats go anyway for export in 3.4 -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Removed unused functions in calc 2
Hi,
Please find attached second patch (made available under LGPLv3+/MPL) removing
unused functions in calc (based on call-catcher list).
Patch has been rebased with origin/master and compiled before submission.
Regards,
Alfonso
From cb18b2e862d65c6d578c61b2a7c036f2102cae5c Mon Sep 17 00:00:00 2001
From: Alfonso Eusebio alfonso_euse...@yahoo.co.uk
Date: Wed, 2 Feb 2011 18:24:01 +
Subject: [PATCH] Removed unused functions from calc 2
Removed some more unused functions from calc as identified
by call-catcher.
---
sc/inc/document.hxx |3 -
sc/inc/dptabsrc.hxx |4 -
sc/inc/externalrefmgr.hxx|2 -
sc/inc/segmenttree.hxx |2 -
sc/source/core/data/documen3.cxx | 10 ---
sc/source/core/data/document.cxx | 14
sc/source/core/data/dptabsrc.cxx | 23 --
sc/source/core/data/segmenttree.cxx | 20 +
sc/source/ui/docshell/externalrefmgr.cxx | 11 ---
sc/source/ui/vba/vbachart.cxx| 120 --
sc/source/ui/vba/vbachart.hxx|9 --
sc/source/ui/vba/vbachartobject.cxx | 54 -
sc/source/ui/vba/vbachartobject.hxx | 12 ---
13 files changed, 5 insertions(+), 279 deletions(-)
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 26d7707..02d27c3 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1311,7 +1311,6 @@ public:
SC_DLLPUBLIC void ShowCol(SCCOL nCol, SCTAB nTab, BOOL bShow);
SC_DLLPUBLIC void ShowRow(SCROW nRow, SCTAB nTab, BOOL bShow);
SC_DLLPUBLIC void ShowRows(SCROW nRow1, SCROW nRow2, SCTAB nTab, BOOL bShow);
-SC_DLLPUBLIC void SetColFlags( SCCOL nCol, SCTAB nTab, BYTE nNewFlags );
SC_DLLPUBLIC void SetRowFlags( SCROW nRow, SCTAB nTab, BYTE nNewFlags );
SC_DLLPUBLIC void SetRowFlags( SCROW nStartRow, SCROW nEndRow, SCTAB nTab, BYTE nNewFlags );
@@ -1347,7 +1346,6 @@ public:
boolHasFilteredRows(SCROW nStartRow, SCROW nEndRow, SCTAB nTab);
boolColFiltered(SCCOL nCol, SCTAB nTab, SCCOL* pFirstCol = NULL, SCCOL* pLastCol = NULL);
SC_DLLPUBLIC void SetRowFiltered(SCROW nStartRow, SCROW nEndRow, SCTAB nTab, bool bFiltered);
-SC_DLLPUBLIC void SetColFiltered(SCCOL nStartCol, SCCOL nEndCol, SCTAB nTab, bool bFiltered);
SCROW FirstNonFilteredRow(SCROW nStartRow, SCROW nEndRow, SCTAB nTab);
SCROW LastNonFilteredRow(SCROW nStartRow, SCROW nEndRow, SCTAB nTab);
SCROW CountNonFilteredRows(SCROW nStartRow, SCROW nEndRow, SCTAB nTab);
@@ -1456,7 +1454,6 @@ public:
void Sort( SCTAB nTab, const ScSortParam rSortParam, BOOL bKeepQuery );
SCSIZE Query( SCTAB nTab, const ScQueryParam rQueryParam, BOOL bKeepSub );
-BOOL ValidQuery( SCROW nRow, SCTAB nTab, const ScQueryParam rQueryParam, BOOL* pSpecial = NULL );
SC_DLLPUBLIC BOOL CreateQueryParam( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2,
SCTAB nTab, ScQueryParam rQueryParam );
void GetUpperCellString(SCCOL nCol, SCROW nRow, SCTAB nTab, String rStr);
diff --git a/sc/inc/dptabsrc.hxx b/sc/inc/dptabsrc.hxx
index 4ca3050..4f7defe 100644
--- a/sc/inc/dptabsrc.hxx
+++ b/sc/inc/dptabsrc.hxx
@@ -164,7 +164,6 @@ public:
ScDPTableData* GetData() { return pData; }
const ScDPTableData* GetData() const { return pData; }
-voidSetGrandTotalName(const ::rtl::OUString rName);
const ::rtl::OUString* GetGrandTotalName() const;
USHORT GetOrientation(long nColumn);
@@ -182,7 +181,6 @@ public:
USHORT GetDataLayoutOrientation();
BOOL IsDateDimension(long nDim);
-UINT32 GetNumberFormat(long nDim);
BOOL SubTotalAllowed(long nColumn); //! move to ScDPResultData
@@ -442,8 +440,6 @@ public:
const ScDPItemData GetSelectedData();
const ::com::sun::star::sheet::DataPilotFieldReference GetReferenceValue() const;
-
-BOOL IsVisible( const ScDPItemData rData );
};
class ScDPHierarchies : public cppu::WeakImplHelper2
diff --git a/sc/inc/externalrefmgr.hxx b/sc/inc/externalrefmgr.hxx
index 1a6..478fb51 100644
--- a/sc/inc/externalrefmgr.hxx
+++ b/sc/inc/externalrefmgr.hxx
@@ -180,7 +180,6 @@ public:
/// Returns the half-open range of used columns in the specified row. Returns [0,0) if row is empty.
SC_DLLPUBLIC ::std::pair SCCOL, SCCOL getColRange( SCROW nRow ) const;
void getAllNumberFormats(::std::vectorsal_uInt32 rNumFmts) const;
-const ScRangeList getCachedRanges() const;
bool isRangeCached(SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2) const;
void setCachedCell(SCCOL nCol, SCROW nRow);
@@ -299,7 +298,6 @@ private:
bool mbAllReferenced;
Re: [Libreoffice] [PATCH] avoid ambiguous else
Oh, I think this was a mistake o mine. I removed the brackets, didn't
really thought, that the else statement could be associated with the
inner if. I attached the patch to bring the brackets back.
-Thomas
On 02/02/2011 08:38 PM, Kohei Yoshida wrote:
On Thu, 2011-02-03 at 03:20 +0900, Takeshi Abe wrote:
Hi,
On building calc, I found a warning suggesting an ambiguous else.
The attached patch is under LGPLv3+/MPL.
Hmm... But your patch may change the intention of that code block based
on how the lines are indented.
Here is the code we have right now
if(eType==SC_CAT_CONTENT)
if(!pScChangeAction-IsDialogParent())
pScChangeAction-GetDescription( aDesc, pDoc, TRUE);
else
pScChangeAction-GetDescription( aDesc,
pDoc,!pScChangeAction-IsMasterDelete());
which makes me think the the else block is supposed to get executed when
eType != SC_CAT_CONTENT
I have no idea how the compiler parses that block of code as it is
indeed ambiguous. But I'm more in favor of interpreting it based on the
indent levels than how the compiler might be parsing it.
Kohei
From 088714d49235976ff04a0ac0f8f37e32120810b6 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Wed, 2 Feb 2011 23:26:47 +0100
Subject: [PATCH] Use brackets, to be safe.
---
sc/source/ui/miscdlgs/acredlin.cxx |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sc/source/ui/miscdlgs/acredlin.cxx
b/sc/source/ui/miscdlgs/acredlin.cxx
index ceba5b4..d4ea8de 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -343,8 +343,10 @@ BOOL ScAcceptChgDlg::IsValidAction(const ScChangeAction*
pScChangeAction)
aComment.EraseAllChars('\n');
if(eType==SC_CAT_CONTENT)
+{
if(!pScChangeAction-IsDialogParent())
pScChangeAction-GetDescription( aDesc, pDoc, TRUE);
+}
else
pScChangeAction-GetDescription( aDesc,
pDoc,!pScChangeAction-IsMasterDelete());
--
1.7.3.5
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] avoid ambiguous else
On Wed, 2011-02-02 at 23:27 +0100, Thomas Arnhold wrote: Oh, I think this was a mistake o mine. I removed the brackets, didn't really thought, that the else statement could be associated with the inner if. I attached the patch to bring the brackets back. No worries I'd already put the fix in before you sent your patch. :-) Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] avoid ambiguous else
Thanks ;) On 02/02/2011 11:44 PM, Kohei Yoshida wrote: On Wed, 2011-02-02 at 23:27 +0100, Thomas Arnhold wrote: Oh, I think this was a mistake o mine. I removed the brackets, didn't really thought, that the else statement could be associated with the inner if. I attached the patch to bring the brackets back. No worries I'd already put the fix in before you sent your patch. :-) Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Breaking in hunspell (Re: Missing vcl resource. This indicates that files vital to localization are missing. You might have a corrupt installation.)
Hi, I'm getting a failure in hunspell, so I ran the remedial steps following the option module clean There is a warning saying makefile is ignoring the datadir setting. Here's the whole nine metres: Argos:hunspell dfdumaresq$ rm -Rf /Users/dfdumaresq/git/libo/hunspell/unxmacxi.pro # optional module 'clean' Argos:hunspell dfdumaresq$ cd .. Argos:libo dfdumaresq$ source ./MacOSXX86Env.Set.sh Argos:libo dfdumaresq$ cd hunspell Argos:hunspell dfdumaresq$ build build -- version: 275224 = Building module hunspell = Entering /Users/dfdumaresq/git/libo/hunspell mkout -- version: 1.8 if [ -f ./unxmacxi.pro/misc/build/hunspell-1.2.9.exists ] ; then mv ./unxmacxi.pro/misc/build/hunspell-1.2.9 ./unxmacxi.pro/misc/build/hunspell-1.2.9_removeme ; fi make writeable... patching file hunspell-1.2.9/config.h patching file hunspell-1.2.9/src/tools/hunspell.cxx patching file hunspell-1.2.9/src/hunspell/hunspell.cxx patching file hunspell-1.2.9/tests/test.sh patching file hunspell-1.2.9/src/hunspell/affixmgr.cxx mkdir: ./unxmacxi.pro/misc/build/hunspell-1.2.9/: File exists checking build system type... i686-apple-darwin10.6.0 checking host system type... i686-apple-darwin10.6.0 checking target system type... i686-apple-darwin10.6.0 checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /usr/local/bin/gmkdir -p checking for gawk... no checking for mawk... no checking for nawk... no checking for awk... awk checking whether make sets $(MAKE)... yes checking for C++ compiler default output file name... a.out checking whether the C++ compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C++ compiler... yes checking whether ccache g++-4.0 accepts -g... yes checking for style of include used by make... GNU checking dependency style of ccache g++-4.0... gcc3 checking for gcc... ccache gcc-4.0 checking whether we are using the GNU C compiler... yes checking whether ccache gcc-4.0 accepts -g... yes checking for ccache gcc-4.0 option to accept ISO C89... none needed checking dependency style of ccache gcc-4.0... gcc3 checking for a sed that does not truncate output... /usr/bin/sed checking for grep that handles long lines and -e... /usr/bin/grep checking for egrep... /usr/bin/grep -E checking for fgrep... /usr/bin/grep -F checking for ld used by ccache gcc-4.0... /usr/libexec/gcc/i686-apple-darwin10/4.0.1/ld checking if the linker (/usr/libexec/gcc/i686-apple-darwin10/4.0.1/ld) is GNU ld... no checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm checking the name lister (/usr/bin/nm) interface... BSD nm checking whether ln -s works... yes checking the maximum length of command line arguments... 196608 checking whether the shell understands some XSI constructs... yes checking whether the shell understands +=... yes checking for /usr/libexec/gcc/i686-apple-darwin10/4.0.1/ld option to reload object files... -r checking for objdump... no checking how to recognize dependent libraries... pass_all checking for ar... ar checking for strip... strip checking for ranlib... ranlib checking command to parse /usr/bin/nm output from ccache gcc-4.0 object... ok checking for dsymutil... dsymutil checking for nmedit... nmedit checking for lipo... lipo checking for otool... otool checking for otool64... no checking for -single_module linker flag... yes checking for -exported_symbols_list linker flag... yes checking how to run the C preprocessor... ccache gcc-4.0 -E checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unistd.h... yes checking for dlfcn.h... yes checking whether we are using the GNU C++ compiler... (cached) yes checking whether ccache g++-4.0 accepts -g... (cached) yes checking dependency style of ccache g++-4.0... (cached) gcc3 checking how to run the C++ preprocessor... ccache g++-4.0 -E checking for objdir... .libs checking if ccache gcc-4.0 supports -fno-rtti -fno-exceptions... no checking for ccache gcc-4.0 option to produce PIC... -fno-common -DPIC checking if ccache gcc-4.0 PIC flag -fno-common -DPIC works... yes checking if ccache gcc-4.0 static flag -static works... no checking if ccache gcc-4.0 supports -c -o file.o... yes checking if ccache gcc-4.0 supports -c -o file.o... (cached) yes checking whether the ccache gcc-4.0 linker (/usr/libexec/gcc/i686-apple-darwin10/4.0.1/ld) supports shared libraries... yes checking dynamic linker characteristics... darwin10.6.0 dyld checking how to hardcode library paths into programs... immediate checking whether stripping libraries is possible... yes checking if libtool supports
[Libreoffice] Recording changes: Deleted lines 'misbehaving'.
All, Here's another issue affecting collaborative authors. (FWIW: I'm on master branch, pulled today, around 1900GMT) SW: when an author deletes an existing body of text whilst 'Record Changes' is running, the strike-through'ed text soon disintegrates, leaving swathes of meaningless long lines. And, if the deleted sentence continues to an end of a paragraph, the entire text plus strike-through disappears, leaving a small vertical bar at the LHS as the remaining indicator. Reproducing: 1. New odt. Fill a page of text, say four or five paragraphs. 2. Start recording changes (enable 'Show' changes too). 3. Delete, I use highlight + del key, a number of words, sentences, and at least the last sentence of a paragraph. 4. Watch the strike-throughs while hovering mouse cursor over them - the bubble 'erases' text. Sometimes the text disappear on their 'own accord' after a while. 5. Hit Ctrl-S. Some strike-thoughs disappear completely. Also, loading a .doc with recorded changes on MSWord shows same behaviour for deleted text. Inserted text appear to be unaffected. This behaviour cannot be replicated on OOo, nor MSWord. Is anyone already aware of this, or is working on/with Recording Changes? If not, then I want to dive in. Cheers Andy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Fwd: [PATCH] new De-Java-ised flat XML export]
Hi Peter, On 2011-02-02 at 22:08 +0100, Jan Holesovsky wrote: I hope you don't mind that I am forwarding your great work to the mailing list - so that others can see what is going on :-) I am just integrating that, fixing few minor things there (we should not do 'use namespace' in the headers); but looks great overall! I hope I'll be able to push later tonight. I've reviewed your patches, and have them building in my local tree. I'll do few tests tomorrow, and push :-) Wrt. the 'using namespace', I fixed those only in the sax header, but left the private headers (like LibXSLTTransformer.hxx) as they are. I also named your implementation of odfflatxml to OdfFlatXml.cxx, and removed a bit more in scp2. Please have a look at the git history when I push this, I hope I did not break your intentions too much ;-) Thank you a lot, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Removed unused functions in calc 2
On Wed, 2011-02-02 at 21:49 +, Alfonso Eusebio wrote: Hi, Please find attached second patch (made available under LGPLv3+/MPL) removing unused functions in calc (based on call-catcher list). Patch has been rebased with origin/master and compiled before submission. Thanks. Applied. Some of those methods were mine, and I'm surprised how they got unused over time. I skipped segmenttree.hxx and segmenttree.cxx however; since those methods you removed tend to get added, removed, added, ... quite frequently. I plan to re-work the API of those classes probably during the 3.4 cycle, so it's okay to skip those files for now. Regards, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Portable LibreOffice OS X released
Thanks to yours previous support I've released Portable LibreOffice OS X. http://www.freesmug.org/portableapps:libreoffice It open LibreOffice with a shell script using -env:UserInstallation=file:///... wrapped in a application bundle. Just a little issue when first time I type some text JREproperties write a Portable file in the same folder of Portable LibreOffice.app with this content: ?xml version=1.0 encoding=UTF-8? !--This is a generated file. Do not alter this file!-- java xmlns=http://openoffice.org/2004/java/framework/1.0; xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; enabled xsi:nil=true/ userClassPath xsi:nil=true/ vmParameters xsi:nil=true/ jreLocations xsi:nil=true/ javaInfo xsi:nil=false vendorUpdate=2006-05-02 autoSelect=true vendorApple Inc./vendor locationfile:///System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home/location version1.6.0_22/version features0/features requirements0/requirements vendorData660069006C0065003A002F002F002F00530079007300740065006D002F004C006900620072006100720079002F004A006100760061002F004A006100760061005600690072007400750061006C004D0061006300680069006E00650073002F0031002E0036002E0030002E006A0064006B002F0043006F006E00740065006E00740073002F0048006F006D0065002F002E002E002F002E002E002F002E002E002F002E002E002F002E002E002F004600720061006D00650077006F0072006B0073002F004A0061007600610056004D002E006600720061006D00650077006F0072006B002F004A0061007600610056004D00/vendorData /javaInfo /java ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)
Hurray, I have finally got past bootstrap phase and I'm leaving it build in the background today while I'm at work. I had a number of small issues that I had to resolve, including being unable to execute some of the installers that were downloaded. A chmod 755 src/*.exe src/*.EXE seemed to resolve that, but a couple of other issues too. I will send an update tonight if all goes well. Regards, Steven Butler ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)
Sorry Tor - forgot to reply-all and sent only to you previously... resending to the list. On 3 February 2011 10:35, Steven Butler sebut...@gmail.com wrote: I will send an update tonight if all goes well. It seems to have failed building VCL - there is an error stating f268: Error: The image(s) check ... could not be found. (my elision as different PC) Could this have something to do with removing icons that was done recently? I may have to wait till tonight and try to update the git checkout(s) to see if that helps. I also had errors building in a number of other subprojects that I'll need to look into tonight. Regards, Steven Butler ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Fwd: [PATCH] new De-Java-ised flat XML export]
Hi, Peter,
+/*
+ * FLABridge provides some obscure attribute mangling to wordml2000
import/export filters.
+ * In the long run, you might want to replace this with an XSLT
extension function.
+ */
+class FLABridge : public WeakImplHelper1 DocumentHandlerAdapter
+{
FLA is a way to avoid doing heavy arithmetic computations of attribute
values directly in XSLT; instead, the arithmetic expression is emitted
to output as FLA expression and suffix '.value' is added to the name of
the attribute, so it can be recognised and evaluated by the FLABridge
(where the suffix is removed again). It is mainly used in
filter/source/xslt/import/wordml/wordml2ooo_props.xsl, but at a few
other places too.
So much for theory. In practice, the syntax of FLA is so horrible that
XLST is the essence of clarity in comparison .-) E.g., look at the
following snippet from
filter/source/xslt/import/wordml/wordml2ooo_props.xsl and description of
the FLA syntax in filter/source/xsltfilter/fla.cxx and tell what the
expression in 'select' does .-)
xsl:attribute name=fo:margin-top.value
xsl:value-of
select=concat('(.(twips2cm(?[',name(w:hdr),'](?(=($0[',w:pgMa
r/@w:top,'])($1(|[',w:pgMar/@w:header,'][720])))($1)($0))[',w:pgMar/@w:top,']))
[cm])')/
/xsl:attribute
IMHO all these FLA computations should be rewritten to XSLT and the
FLABridge abolished. Maybe you'd want to attempt that? :-)
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
