Re: [Libreoffice] [REVIEW] fix for #36915 and #36916
I mentioned the wrong bug, the patch fixes the above On 11/05/11 21:46, Noel Power wrote: Hi, Please have a find a fix for https://bugs.freedesktop.org/show_bug.cgi?id=35139 here https://bugs.freedesktop.org/attachment.cgi?id=46611 I'd like to apply that to libreoffice 3.4 thanks Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] DLL rebasing on Windows: WTF?
I asked about this on the OOo dev list, and here is an informative reply from Michael Stahl: Carsten did something in OOo 3.3 to improve startup performance. my vague memory of what he found out: on NT6 (Vista or newer) the OS does aggressive caching and cold start is very fast. on NT5 (XP, WS2003) the OS does not do much caching, the DLLs are demand-paged, and the result is that if you have a hard disk it will seek a lot and cold start will be slow. now there is a trick to force NT5 to not demand-page the DLLs: if their base addresses overlap, the runtime linker is forced to relocate them, and in order to do that, it reads in the entire DLL at once, without seeks. the CPU overhead of relocating is negligible compared with the seeking. so on NT5 you are better off with overlapping base addresses, and the thingy that runs after installation is supposed to do this. _but_ this makes sense only on a single user system (desktop). on a multi-user server the relocated DLLs cannot be shared in memory, and on a multi-user server OOo will probably be loaded in memory anyway by another user. So I guess we should keep stuff as is then in postprocess and in the custom action. Perhaps add a check to the installer custom action to do the rebasing back to overlapping addresses only on XP or older. That should speed up installation on Vista and newer a bit. On Vista and newer the base addresses in the DLL will normally be ignored anyway, due to address space layout randomization. (But on Vista and newer, thanks to some new implementation tricks, the thus required relocation won't cause much slowdown, they say.) The rebaseoo.exe and rebasegui.exe files we can stop shipping in my opinion, and remove their sources from git. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fix for #36915 and #36916
please see updated patch Noel diff --git scripting/util/provider/beanshell/makefile.mk scripting/util/provider/beanshell/makefile.mk index cbb0c40..1f70fcb 100755 --- scripting/util/provider/beanshell/makefile.mk +++ scripting/util/provider/beanshell/makefile.mk @@ -36,6 +36,7 @@ EXTENSIONNAME:=ScriptProviderForBeanShell EXTENSION_ZIPNAME:=script-provider-for-beanshell COMPONENT_JARFILES=$(EXTENSIONDIR)$/$(EXTENSIONNAME).jar +EXTENSION_PACKDEPS=$(SOLARBINDIR)$/bsh.jar .IF $(ENABLE_SCRIPTING_BEANSHELL) != YES @all: @@ -46,6 +47,12 @@ COMPONENT_JARFILES=$(EXTENSIONDIR)$/$(EXTENSIONNAME).jar .INCLUDE : target.mk .INCLUDE : extension_post.mk +ALLTAR : $(EXTENSIONDIR)$/bsh.jar + +$(EXTENSIONDIR)$/bsh.jar : $(SOLARBINDIR)$/bsh.jar +@@-$(MKDIRHIER) $(@:d) +$(COMMAND_ECHO)$(COPY) $ $@ + .ELSE .INCLUDE : target.mk diff --git scripting/util/provider/javascript/manifest.xml scripting/util/provider/javascript/manifest.xml index 4c61747..d052ad8 100755 --- scripting/util/provider/javascript/manifest.xml +++ scripting/util/provider/javascript/manifest.xml @@ -3,8 +3,5 @@ manifest:manifest xmlns:manifest=http://openoffice.org/2001/manifest; manifest:file-entry manifest:media-type=application/vnd.sun.star.uno-component;type=java -manifest:full-path=js.jar/ - manifest:file-entry -manifest:media-type=application/vnd.sun.star.uno-component;type=java manifest:full-path=ScriptProviderForJavaScript.jar/ /manifest:manifest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fix for crasher fdo#37103
Looks inoffensive. Cherry-picked with signoff F. On Wed, 2011-05-11 at 13:58 +0100, Noel Power wrote: Hi All, please see https://bugs.freedesktop.org/show_bug.cgi?id=37103 and if someone could review and cherry-pick the patch http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=17e8ee1d7b9b4464af73657679df7b0bbdffa028 from master, that would be great thanks, Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix for fdo#36667 for 3.4
Pushed to master and cherry-picked with -s to libreoffice-3-4 F. On Wed, 2011-05-11 at 17:36 +0200, Cedric Bosdonnat wrote: Attached is a patch fixing the sw table formulas update in 3.4. Could someone review and sign it off? It's a partial revert from http://cgit.freedesktop.org/libreoffice/writer/commit/?id=2b9726405495529d64e7ab8537ea30119f607d1e The test in the if, was actually setting pNewVal... which was never set and causing troubles in some (potentially loads of) cases. Thanks, ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] fix for #36915 and #36916
Hi Noel, On Thu, 2011-05-12 at 10:40 +0100, Noel Power wrote: please see updated patch As told you on IRC, it's ok for me. I just signed it off and pushed it. -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36915, which changed state. Bug 36915 Summary: Beanshell scripts don't work https://bugs.freedesktop.org/show_bug.cgi?id=36915 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36667, which changed state. Bug 36667 Summary: Calculating in Text Documents: update broken https://bugs.freedesktop.org/show_bug.cgi?id=36667 What|Old Value |New Value Resolution||FIXED Status|ASSIGNED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Extension integration and other fixes
Signed off and cherry-picked F. On Wed, 2011-05-11 at 20:46 +0200, KAMI911 KAMI911 wrote: Hi Friends of LibreOffice, Can you please review and cherry-pick few of my fixes from master to 3-4? Fix Ligthproof extension integration http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=85d90f6c1de12d03d1d9099286a21934851cefcb Fix SUN Template extension configure, download, handling http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=2385f20b3f335d489572f7e3855e5d7123645f21 Fix space and tab jam in my last commit http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=c48be6e85768c35d7f8cec92d97bf6f237b3537e When downloading extensions to src, cut is provided with wrong option switches http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=ed19187707feedc319114c2ac345ef3021c92bcc Fix oooblogger extension download mechanism http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=62e5006410b2a96e9c998b0a0fd283b3eb0c1b71 AC_SUBST also OOOBLOGGER_EXTENSION_PACK as set_soenv.in uses it http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=b2aa08bbf1a2edaa7953e637033dde7823cc5618 And if it possible please apply this too: Add OxygenOffice related settings http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=56d20379014c8ae9f058479076e0551e712e23e9 Thank you in advance! Cheers, KAMI ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: Review request: http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=d559d4fce17a08cda40d7fcddeb18cbe7d332489
As of our discussion on IRC, this makes sense. Signed off and cherry-picked F On Thu, 2011-05-12 at 04:18 -0600, Tor Lillqvist wrote: Please review and cherry-pick to libreoffice-3-4. I have verified that it doesn't break the installer. The two files in question are not needed; we have no idea in what situation they are supposed to be run by the user and/or sysadmin. And rebasegui.exe (which just displays some information) doesn't even work as intended. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36679, which changed state. Bug 36679 Summary: Virus detected on installation https://bugs.freedesktop.org/show_bug.cgi?id=36679 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Review request: http://pastebin.com/bgVxQKug
OK to apply to the branch? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] fix for bullets saving to odp and possibly more issues
Hi, please review my patch for fdo#37017. It sets version info so that we don't hit workarounds for versions = 3.4.x. I would like to put on 3-4 branch. Cheers Radek commit ab328ba55be3b7249d1a55a939182ffd2034c3aa Author: Radek Doulik r...@novell.com Date: Wed May 11 17:48:21 2011 +0200 change the version info so that we are not identified at runtime as 3.0.x - fixes https://bugs.freedesktop.org/show_bug.cgi?id=37017 diff --git a/solenv/inc/minor.mk b/solenv/inc/minor.mk index e33ce16..dfd0189 100644 --- a/solenv/inc/minor.mk +++ b/solenv/inc/minor.mk @@ -1,5 +1,5 @@ -RSCVERSION=300 -RSCREVISION=300m103(Build:1) +RSCVERSION=340 +RSCREVISION=340m1(Build:1) BUILD=1 -LAST_MINOR=m103 -SOURCEVERSION=DEV300 +LAST_MINOR=m1 +SOURCEVERSION=OOO340 -- Radek Doulík r...@novell.com Novell, Inc. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] LibreOffice 3.4 Release Notes
At the last marketing team confcall I offered to help coordinate completing the release notes of the upcoming 3.4 version and then distilling the information into a version more suitable for our website accompanied with photos of some or many of these changes. Could we, all, please take a close look at the information on the Release Notes 3.4 wiki page[1] to make sure that the information is complete and correct? This will help greatly in easing the task of creating a more suitable page for the website. We just have to make sure that all the details are there and that we have not missed anything major in the list. We are hoping to have a website page showing the new/changes/corrections of this iteration and another page with the 3.3 version where reviewers/users/members will be able to compare. Feel free to update the wiki page or leave me a note on this thread. Thanks for your help. Marc [1] http://wiki.documentfoundation.org/ReleaseNotes/3.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||36510 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||36703 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] add control (like button) inside custom XToolPanel
Hi everyone, I'm trying to develop a small gui in an XToolPanel. I've read and followed example about xToolPanel in c++ and convert it to java code with success, now I've my green panel displayed. What I'm doing now is to add some control inside (like button). I can add controls but they are all stacked on the top left edge of the panel, all on the same place. I think that it must miss a container with some layout or fixed position but the only container I've found in documentation and example is unoControlDialog. With this, my button are correctly placed but in a modal dialog and not in my panel. I'm lost, I cannot see what's the way I should use. Could send me a simple piece of code to add correctly a button inside a XToolPanel ? The panel code can be read at http://pastebin.com/QfFx8TKQ. Regards, Ludovic SMADJA -- ludovic ludovic.sma...@jalios.com JALIOS SA RD ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fix for fdo#35543
Hi Peter, On 2011-05-07 at 13:47 +0200, Peter Jentsch wrote: I commited a fix for fdo#35543 (FILEOPEN: hangs when trying to open SpreadsheetML). The fix is actually more of a workaround than a real fix, because it simply adds a timeout with the ability to retry or abort an ongoing load request to the xsltfilter module. I tested the fix on master but would be glad if someone would take a look at it and see if there's anything stupid going on there. Very nice, thanks for that! :-) I'd maybe argue if 60 seconds is enough; but as you explained in the bug, due to the other bottlenecks it is not fit to import any larger sheets anyway - so looks fine to me. Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] fix for fdo#36524
Hi all,
Could anyone review and sign-off this patch in 3.4 branch? The change
from sal_True to sal_False was pretty complex to find out, but I just
reverted it to the value it had in 3.3 sources.
Thanks,
--
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr
From 358cc16b785709185f9da7898e5f309dd07b1908 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Bosdonnat?= cedric.bosdonnat@free.fr
Date: Thu, 12 May 2011 17:08:32 +0200
Subject: [PATCH] fdo#36524: Fixed remaining SwSectionFrm after deleting TOX
false transformed to true restored the SwSectionFrm after deleting it.
---
sw/source/core/layout/sectfrm.cxx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sw/source/core/layout/sectfrm.cxx b/sw/source/core/layout/sectfrm.cxx
index 9868d2c..2eff305 100644
--- a/sw/source/core/layout/sectfrm.cxx
+++ b/sw/source/core/layout/sectfrm.cxx
@@ -2444,7 +2444,7 @@ void SwSectionFrm::SwClientNotify( const SwModify rMod, const SfxHint rHint )
const SfxSimpleHint* pSimpleHint = dynamic_castconst SfxSimpleHint*(rHint);
if ( pSimpleHint pSimpleHint-GetId() == SFX_HINT_DYING rMod == GetRegisteredIn() )
{
-SwSectionFrm::MoveCntntAndDelete( this, sal_True );
+SwSectionFrm::MoveCntntAndDelete( this, sal_False );
}
}
--
1.7.3.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] Review request: http://pastebin.com/bgVxQKug
On Thu, 2011-05-12 at 06:17 -0600, Tor Lillqvist wrote: OK to apply to the branch? Ok for me. Pushed. -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW][PUSHED] fix for bullets saving to odp and possibly more issues
Radek Doulík píše v Čt 12. 05. 2011 v 15:20 +0200: Hi, please review my patch for fdo#37017. It sets version info so that we don't hit workarounds for versions = 3.4.x. I would like to put on 3-4 branch. It seems to be the right solution as discussed on irc = cherry-picked into libreoffice-3-4 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37017, which changed state. Bug 37017 Summary: Bullets in presentation not saved https://bugs.freedesktop.org/show_bug.cgi?id=37017 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37015, which changed state. Bug 37015 Summary: Scripting other than Basic unavailable https://bugs.freedesktop.org/show_bug.cgi?id=37015 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] Remove compiler warning etc.
Please review the attached patch to suppress warning with MSVC compiler. Thanks. Kohei 0001-Let-s-not-change-the-signature-of-UNO-call-prefer-st.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [GSOC][PATCH] Multiline inputbar
Hello There,
I'm posting here the git diff of the work I've done till now.
@Kohei Since I do not want to disturb my master branch I'm here
pasting the diff only. Please create a feature branch and apply it, so
that I can clone that branch and commit on that.
diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx
index a293c22..8019fee 100644
--- a/sc/source/ui/app/inputwin.cxx
+++ b/sc/source/ui/app/inputwin.cxx
@@ -31,6 +31,8 @@
#include algorithm
+#includestdio.h
+
#include scitems.hxx
#include editeng/eeitem.hxx
@@ -137,10 +139,11 @@ ScInputWindow::ScInputWindow( Window* pParent,
SfxBindings* pBind ) :
// mit WB_CLIPCHILDREN, sonst Flicker
ToolBox ( pParent,
WinBits(WB_BORDER|WB_3DLOOK|WB_CLIPCHILDREN) ),
aWndPos ( this ),
+// maScrollBar ( this, WB_VERT | WB_DRAG ),
aTextWindow ( this ),
pInputHdl ( NULL ),
pBindings ( pBind ),
-aTextOk( ScResId( SCSTR_QHELP_BTNOK ) ),
// nicht immer
neu aus Resource
+aTextOk( ScResId( SCSTR_QHELP_BTNOK ) ),
// not always
new from Resource
aTextCancel( ScResId( SCSTR_QHELP_BTNCANCEL ) ),
aTextSum ( ScResId( SCSTR_QHELP_BTNSUM ) ),
aTextEqual ( ScResId( SCSTR_QHELP_BTNEQUAL ) ),
@@ -161,7 +164,7 @@ ScInputWindow::ScInputWindow( Window* pParent,
SfxBindings* pBind ) :
}
DBG_ASSERT( pViewSh, no view shell for input window );
-// Positionsfenster, 3 Buttons, Eingabefenster
+// Position window, 3 buttons, input window
InsertWindow( 1, aWndPos, 0,
0 );
InsertSeparator (
1 );
InsertItem ( SID_INPUT_FUNCTION, IMAGE( SID_INPUT_FUNCTION ), 0, 2 );
@@ -169,12 +172,21 @@ ScInputWindow::ScInputWindow( Window* pParent,
SfxBindings* pBind ) :
InsertItem ( SID_INPUT_EQUAL, IMAGE( SID_INPUT_EQUAL ), 0,4 );
InsertSeparator (
5 );
InsertWindow( 7, aTextWindow, 0, 6 );
+// InsertWindow( 8, maScrollBar, 0, 8 );
aWndPos .SetQuickHelpText( ScResId( SCSTR_QHELP_POSWND ) );
aWndPos.SetHelpId ( HID_INSWIN_POS );
aTextWindow.SetQuickHelpText( ScResId( SCSTR_QHELP_INPUTWND ) );
aTextWindow.SetHelpId ( HID_INSWIN_INPUT );
+/*
+maScrollBar.SetPageSize( 1 );
+maScrollBar.SetVisibleSize( 1 );
+maScrollBar.SetLineSize( 1 );
+maScrollBar.SetRange( Range( 0, 1 ) );
+maScrollBar.SetThumbPos( 10 );
+*/
+
// kein SetHelpText, die Hilfetexte kommen aus der Hilfe
SetItemText ( SID_INPUT_FUNCTION, ScResId( SCSTR_QHELP_BTNCALC ) );
@@ -189,6 +201,7 @@ ScInputWindow::ScInputWindow( Window* pParent,
SfxBindings* pBind ) :
SetHelpId( HID_SC_INPUTWIN ); // fuer die ganze Eingabezeile
aWndPos.Show();
+// maScrollBar .Show();
aTextWindow.Show();
pInputHdl = SC_MOD()-GetInputHdl( pViewSh, false );// use
own handler even if ref-handler is set
@@ -489,7 +502,11 @@ void ScInputWindow::Resize()
long nLeft = aTextWindow.GetPosPixel().X();
Size aSize = aTextWindow.GetSizePixel();
-aSize.Width() = Max( ((long)(nWidth - nLeft - 5)), (long)0 );
+aSize.Width() = Max( ((long)(nWidth - nLeft - 40)), (long)0 );
+
+printf(Inside ScInputWindow:Resize()\n);
+printf(nWidth %ld nLeft %ld aSize.Width%ld \n,nWidth, nLeft,
aSize.Width());
+
aTextWindow.SetSizePixel( aSize );
aTextWindow.Invalidate();
}
@@ -534,10 +551,15 @@ void ScInputWindow::SetPosString( const String rStr )
void ScInputWindow::SetTextString( const String rString )
{
+int i = rString.Len();
if (rString.Len() = 32767)
+{
aTextWindow.SetTextString(rString);
+printf(%d ScInputWnd:SetTextString(), if \n,i);
+}
else
{
+printf(%d ScInputWnd:SetTextString(), else \n,i);
String aNew = rString;
aNew.Erase(32767);
aTextWindow.SetTextString(aNew);
@@ -705,7 +727,7 @@ void ScInputWindow::DataChanged( const
DataChangedEvent rDCEvt )
}
//
-// Eingabefenster
+// Input Window
//
ScTextWnd::ScTextWnd( Window* pParent )
@@ -779,6 +801,8 @@ void ScTextWnd::Paint( const Rectangle rRec )
// LayoutMode isn't changed as long as ModifyRTLDefaults
doesn't include SvxFrameDirectionItem
}
+
[Libreoffice] [REVIEW] Proper initialization and copying of union matrix value.
I'd like to commit the attached patch to the 3.4 branch. This was discovered by the unit test which failed when an empty matrix element didn't have a value of 0.0. As it turned out, I was initializing the higher 4 bytes via 32-bit pointer but the lower 4 bytes were left un-initialized, which caused the double value to become non-zero. Apparently this doesn't happen when building a 64-bit build. Thanks, Kohei 0001-Properly-initialize-and-copy-fVal.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSOC][PATCH] Multiline inputbar
On Fri, 2011-05-13 at 03:53 +0530, Anurag Jain wrote: Hello There, I'm posting here the git diff of the work I've done till now. @Kohei Since I do not want to disturb my master branch I'm here pasting the diff only. Please create a feature branch and apply it, so that I can clone that branch and commit on that. Could you re-send that patch as an attachment? I'm having hard time applying that diff output because the mail client wrapped many lines that basically screwed up the patch format. Thanks, Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [ANN] Preview builds of 3.4 Beta 5 available
Cor Nouws wrote: * For the release notes: pls inform about parallel installation. Is there a page at the DOcument foundation wiki? Or only the older OOo one? If the latter, I can cp to TDF wiki... Hi Cor, please do - release notes are going here: http://wiki.documentfoundation.org/Releases/3.4/beta5 Cheers, -- Thorsten pgpKElc77KTMU.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36957, which changed state. Bug 36957 Summary: EDITING: Insert TOC – Edit – Writer crashes https://bugs.freedesktop.org/show_bug.cgi?id=36957 What|Old Value |New Value Resolution||FIXED Status|REOPENED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] DECLARE_LIST removal fallout, was: Review request: [PUSHED] http://pastebin.com/bgVxQKug
This has now been pushed. (Commit: http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4id=746fff15ad34616635e09125f6d0656da39a05ad ) But in general, this bug, and I guess similar ones Michael was investigating recently, brings up a serious question: How broken might the code actually be after all the DECLARE_LIST removal Easy Hacks completed without testing? Do we now have lots of crashers caused by misuse of iterators etc in various seldom invoked code paths? Time will tell, I am sure. Maybe we should ask each person who did one or several of those DECLARE_LIST removals to try to find out how to exercise the affected code paths? Would that be a good follow-up Easy Hack? After all, now we have pre-built code out that contains the removals, so it is easier to test when you don't need to build the beast yourself. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
