Re: [Libreoffice] [PATCH] Implement new rule for xref to numbered paragraphs

[Cedric Bosdonnat]

Hello Troy,

On Tue, 2011-07-12 at 19:15 +1000, Troy Rollo wrote:
 On Tuesday 12 July 2011, Caolán McNamara wrote:
  This looks good, however what does it do :-) Set sane leading/trailing
  text/space defaults for a new list numbering level based on the previous
  one ?
 
 Implements the rules discussed in 
 http://lists.freedesktop.org/archives/libreoffice/2011-April/010660.html
 
 (I was busy with study commitments between then and early July - catching up 
 now on all the other things I was neglecting then).

I just checked your patch: looks good to me. I pushed it, but changed
the commit message to mention fdo#33960 in it.

Thanks for your patch, and feel free to continue on the xrefs hacking...
there are quite some problems with them ;)

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH][PUSHED]Fix 33898 - import/export xrefs to numbered paras

[Cedric Bosdonnat]

Hi Troy,

Your patch looks good to me, but it seems the bug number is wrong in the
title: isn't it fdo#33960? I pushed your patch to master, but I'm
wondering if you have some sample documents to help us test it more
intensively...

Thanks for your patch!

On Mon, 2011-07-18 at 00:54 +1000, Troy Rollo wrote:
 ---
  sw/source/filter/rtf/rtffld.cxx  |   50 -
  sw/source/filter/ww8/ww8atr.cxx  |   12 +++
  sw/source/filter/ww8/ww8par5.cxx |   63 +++--
  3 files changed, 65 insertions(+), 60 deletions(-)
 
 diff --git a/sw/source/filter/rtf/rtffld.cxx b/sw/source/filter/rtf/rtffld.cxx
 index f5d9058..ccac5f1 100644
 --- a/sw/source/filter/rtf/rtffld.cxx
 +++ b/sw/source/filter/rtf/rtffld.cxx
 @@ -813,8 +813,7 @@ int SwRTFParser::MakeFieldInst( String rFieldStr )
  case RTFFLD_REF:
  {
  String sOrigBkmName;
 -bool bChapterNr = false;
 -bool bAboveBelow = false;
 +REFERENCEMARK eFormat = REF_CONTENT;
  
  RtfFieldSwitch aRFS( aSaveStr );
  while( !aRFS.IsAtEnd() )
 @@ -828,42 +827,35 @@ int SwRTFParser::MakeFieldInst( String rFieldStr )
  sOrigBkmName = sParam;
  break;
  
 +/* References to numbers in Word could be either to a 
 numbered
 +paragraph or to a chapter number. However Word does not 
 seem to
 +have the capability we do, of refering to the chapter 
 number some
 +other bookmark is in. As a result, cross-references to 
 chapter
 +numbers in a word document will be cross-references to a 
 numbered
 +paragraph, being the chapter heading paragraph. As it 
 happens, our
 +cross-references to numbered paragraphs will do the 
 right thing
 +when the target is a numbered chapter heading, so there 
 is no need
 +for us to use the REF_CHAPTER bookmark format on import.
 +*/
  case 'n':
 +eFormat = REF_NUMBER_NO_CONTEXT;
 +break;
  case 'r':
 +eFormat = REF_NUMBER;
 +break;
  case 'w':
 -bChapterNr = true; // activate flag 'Chapter Number'
 +eFormat = REF_NUMBER_FULL_CONTEXT;
  break;
  
  case 'p':
 -bAboveBelow = true;
 +eFormat = REF_UPDOWN;
  break;
  }
  }
 -if (!bAboveBelow || bChapterNr)
 -{
 -if (bChapterNr)
 -{
 -SwGetRefField aFld(
 -(SwGetRefFieldType*)pDoc-GetSysFldType( 
 RES_GETREFFLD ),
 -sOrigBkmName,REF_BOOKMARK,0,REF_CHAPTER);
 -pDoc-InsertPoolItem( *pPam, SwFmtFld( aFld ), 0 );
 -}
 -else
 -{
 -SwGetRefField aFld(
 -(SwGetRefFieldType*)pDoc-GetSysFldType( 
 RES_GETREFFLD ),
 -sOrigBkmName,REF_BOOKMARK,0,REF_CONTENT);
 -pDoc-InsertPoolItem( *pPam, SwFmtFld( aFld ), 0 );
 -}
 -}
 -
 -if( bAboveBelow )
 -{
 -SwGetRefField aFld( (SwGetRefFieldType*)
 -pDoc-GetSysFldType( RES_GETREFFLD ), sOrigBkmName, 
 REF_BOOKMARK, 0,
 -REF_UPDOWN );
 -pDoc-InsertPoolItem(*pPam, SwFmtFld(aFld), 0);
 -}
 +SwGetRefField aFld(
 +(SwGetRefFieldType*)pDoc-GetSysFldType( RES_GETREFFLD ),
 +sOrigBkmName,REF_BOOKMARK,0,eFormat);
 +pDoc-InsertPoolItem( *pPam, SwFmtFld( aFld ), 0 );
  }
  break;
  
 diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
 index 0ea9201..1464e42 100644
 --- a/sw/source/filter/ww8/ww8atr.cxx
 +++ b/sw/source/filter/ww8/ww8atr.cxx
 @@ -2831,6 +2831,18 @@ void AttributeOutputBase::TextField( const SwFmtFld 
 rField )
  sStr = FieldString(eFld);
  sStr += GetExport().GetBookmarkName(nSubType,
  rRFld.GetSetRefName(), 0);
 +switch (pFld-GetFormat())
 +{
 +case REF_NUMBER:
 +sStr.APPEND_CONST_ASC( \\r);
 +break;
 +case REF_NUMBER_NO_CONTEXT:
 +sStr.APPEND_CONST_ASC( \\n);
 +break;
 +case REF_NUMBER_FULL_CONTEXT:
 +sStr.APPEND_CONST_ASC( \\w);
 +   

[Libreoffice] [GSoc] pencil down dates and next master build

[Cedric Bosdonnat]

Hi all,

Here are the next dates to keep in mind:
 * Recommended pencil down: Aug. 15th
 * Hard pencil down: Aug. 22th

The final evaluation will take place between Aug. 22th and Aug. 26th.

We would like to start a build with all your work the week before the
firm pencil down date. Make sure that you integrated your code in master
early next week.

All work that isn't going to master should land into a LibreOffice git
repo in a way or the other... concerned students and mentors should
check the available possibilities for this.

I hope you enjoyed your summer hacking with us and will stay in the
LibreOffice hackers' great family.

Regards,
-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] ccache support

[Jan Holesovsky]

Hi Norbert, Lubos,

On 2011-08-08 at 11:33 +0200, Lubos Lunak wrote:

  I've pushed
  http://cgit.freedesktop.org/libreoffice/core/commit/?id=57cf026739a3d707378
 ca38f59518b018fccca8f
 
  This try to automatically use ccache when present, unless CC= or CXX=
  was specified by the user or --disable-ccache was passed to autogen
  This also detect if CC or CXX is already an alias for ccache, in which
  case ccache is not prefixed to CC and/or CXX
 
  I disagree with this change, as it does not improve anything for anybody. 

Well, I am not that happy about using ccache by default either ;-)  It
collides with the icecream support, and while it would be possible to
combine ccache and icecream [1], it is generally something that will
save you just very little with big enough icecream farm.

For now I've changed it so that when there is --enable-icecream, the
ccache is disabled, unless explicitly enabled; but it is quite
inconsistent:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d865fed229035440eccb8a89aa3f44f64e0f696c

Regards,
Kendy

[1] http://en.opensuse.org/Icecream#How_to_combine_icecream_with_ccache


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Java debugging

[Cedric Bosdonnat]

Hi Gabor,

On Tue, 2011-08-09 at 20:32 +0200, Jenei Gábor wrote:
 Could someone help me? I would like to fix a bug with LO Base wizards,
 I found the java source of the wizard,and even I got how to debug it
 from OpenOffice instructions: here and here Eclipse runs well, it
 stops at my breakpoint, and even I can see som variables, actually all
 the global and static variables, but local variables are not shown,and
 even if I directly enter the name eclipse can't resolve it. Does any
 of you have experiences with java components debugging? It would be
 nice to use it from Eclipse. 

Well, it seems you found my page for this ;)

I never had any problem with seeing the local variables there... sounds
weird. Have you build the Java code with debug symbols? I don't know
anything about what code you're debugging and how it is build... but
that may be a problem.

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Problem with dev-install on windows

[Jan Holesovsky]

Hi Dmitry,

On 2011-08-10 at 12:39 +0400, Dmitry. A. Ashkadov wrote:

  make dev-install is not really working on Windows. I tried to get it 
  to do something useful some time ago, but haven't finished that. 

 Is it impossible to develop LO on Windows?

Oh, I'm not saying such at thing, it is of course possible :-)

Just make dev-install is not working there; instead you need to create
an install set, and use that; and in case of changes, copy the files
around.  The dev-install that is possible on Linux makes the development
more convenient by using links to the build tree, so every time you
compile in the build tree, the dev-install'd tree immediately uses the
newly built stuff.

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Opengrok and onegit

[Jan Holesovsky]

On 2011-08-10 at 10:30 +0200, Cedric Bosdonnat wrote:

 It was just me being too slow to migrate it just when coming back from
 vacations. It's not indexing core, binfilter, help and translations

s/not/now/ right? ;-)

 repos since yesterday evening (Europe time).

K.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Opengrok and onegit

[Jonathan Aquilina]

Kendy shouldnt opengrok still be indexing the old build system for those 
building 3.4.x ?


On 8/10/11 11:35 AM, Jan Holesovsky wrote:

On 2011-08-10 at 10:30 +0200, Cedric Bosdonnat wrote:


It was just me being too slow to migrate it just when coming back from
vacations. It's not indexing core, binfilter, help and translations

s/not/now/ right? ;-)


repos since yesterday evening (Europe time).

K.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Problem with dev-install on windows

[Dmitry. A. Ashkadov]

10.08.2011 13:32, Jan Holesovsky пишет:

Hi Dmitry,

On 2011-08-10 at 12:39 +0400, Dmitry. A. Ashkadov wrote:


make dev-install is not really working on Windows. I tried to get it
to do something useful some time ago, but haven't finished that.

Is it impossible to develop LO on Windows?

Oh, I'm not saying such at thing, it is of course possible :-)

Just make dev-install is not working there; instead you need to create
an install set, and use that; and in case of changes, copy the files
around.  The dev-install that is possible on Linux makes the development
more convenient by using links to the build tree, so every time you
compile in the build tree, the dev-install'd tree immediately uses the
newly built stuff.

Regards,
Kendy



I don't know how to create a such install set. I found in 
«instsetoo_native» module executable file «setup.exe». It may be used to 
install office. But this way is inconvenient. Everytime I must install 
and then uninstall LO from system. It takes long time. Is it possible to 
install office to local directory in the same way that OOo uses with 
variable LOCALINSTALLDIR?


Is it possible to use native links on Windows to make «make dev-install» 
possible?


--
Best Regards,
Dmitry

attachment: dmitry_ashkadov.vcf___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Use STL find in SvxNumberFormatShell

[Maciej Rumianowski]

Hi,

My patch got lost on mailing list, so I am attaching it now against
actual master.

Discussion was here
http://lists.freedesktop.org/archives/libreoffice/2011-August/016218.html

Best Regards,
Maciej
From 63ca5f6af27123f821446e39eaa4b152652eec7f Mon Sep 17 00:00:00 2001
From: Maciej Rumianowski maciej.rumianow...@gmail.com
Date: Tue, 9 Aug 2011 01:15:16 +0200
Subject: [PATCH] Use STL find() in SvxNumberFormatShell

With SvULongs replaced by std::vector std::find can be used in IsRemoved_Impl IsAdded_Impl
---
 svx/inc/svx/numfmtsh.hxx  |9 --
 svx/source/items/numfmtsh.cxx |   63 +++--
 2 files changed, 29 insertions(+), 43 deletions(-)

diff --git a/svx/inc/svx/numfmtsh.hxx b/svx/inc/svx/numfmtsh.hxx
index 5217e29..c29f71d 100644
--- a/svx/inc/svx/numfmtsh.hxx
+++ b/svx/inc/svx/numfmtsh.hxx
@@ -256,9 +256,12 @@ private:
 SVX_DLLPRIVATE shortFillEListWithSysCurrencys( SvStrings rList,short nSelPos);
 SVX_DLLPRIVATE shortFillEListWithUserCurrencys( SvStrings rList,short nSelPos);
 
-SVX_DLLPRIVATE shortFillEListWithUsD_Impl( SvStrings rList, sal_uInt16 nPrivCat, short Pos );
-SVX_DLLPRIVATE bool IsRemoved_Impl( sal_uInt32 nKey );
-SVX_DLLPRIVATE bool IsAdded_Impl( sal_uInt32 nKey );
+SVX_DLLPRIVATE short   FillEListWithUsD_Impl( SvStrings rList, sal_uInt16 nPrivCat, short Pos );
+SVX_DLLPRIVATE ::std::vectorsal_uInt32::iterator GetRemoved_Impl( size_t nKey );
+SVX_DLLPRIVATE boolIsRemoved_Impl( size_t nKey );
+SVX_DLLPRIVATE ::std::vectorsal_uInt32::iterator GetAdded_Impl( size_t nKey );
+SVX_DLLPRIVATE boolIsAdded_Impl( size_t nKey );
+
 SVX_DLLPRIVATE void GetPreviewString_Impl( String rString,
Color* rpColor );
 SVX_DLLPRIVATE void PosToCategory_Impl( sal_uInt16 nPos, short rCategory );
diff --git a/svx/source/items/numfmtsh.cxx b/svx/source/items/numfmtsh.cxx
index b06042b..c759768 100644
--- a/svx/source/items/numfmtsh.cxx
+++ b/svx/source/items/numfmtsh.cxx
@@ -255,20 +255,9 @@ bool SvxNumberFormatShell::AddFormat( String rFormat,  xub_StrLen rErrPos,
 
 if ( nAddKey != NUMBERFORMAT_ENTRY_NOT_FOUND ) // bereits vorhanden?
 {
-if ( IsRemoved_Impl( nAddKey ) )
+::std::vectorsal_uInt32::iterator nAt = GetRemoved_Impl( nAddKey );
+if ( nAt != aDelList.end() )
 {
-boolbFound  = false;
-std::vectorsal_uInt32::iterator nAt = aDelList.begin();
-
-for (std::vectorsal_uInt32::iterator it(aDelList.begin()); !bFound  it != aDelList.end(); ++it )
-{
-if ( *it == nAddKey )
-{
-bFound  = true;
-nAt = it;
-}
-}
-DBG_ASSERT( bFound, Key not found );
 aDelList.erase( nAt );
 bInserted = true;
 }
@@ -340,22 +329,10 @@ bool SvxNumberFormatShell::RemoveFormat( const String  rFormat,
 {
 aDelList.push_back( nDelKey );
 
-if ( IsAdded_Impl( nDelKey ) )
+::std::vectorsal_uInt32::iterator nAt = GetAdded_Impl( nDelKey );
+if( nAt != aAddList.end() )
 {
-bool bFound = false;
-std::vectorsal_uInt32::iterator nAt = aAddList.begin();
-
-for ( std::vectorsal_uInt32::iterator it(aAddList.begin()); !bFound  it != aAddList.end(); ++it )
-{
-if ( *it == nDelKey )
-{
-bFound = true;
-nAt = it;
-}
-}
-DBG_ASSERT( bFound, Key not found );
-if( bFound )
-aAddList.erase( nAt );
+aAddList.erase( nAt );
 }
 
 nCurCategory=pFormatter-GetType(nDelKey);
@@ -1178,24 +1155,30 @@ void SvxNumberFormatShell::GetPreviewString_Impl( String rString, Color* rpCol
 
 // ---
 
-bool SvxNumberFormatShell::IsRemoved_Impl( sal_uInt32 nKey )
+::std::vectorsal_uInt32::iterator SvxNumberFormatShell::GetRemoved_Impl( size_t nKey )
 {
-bool bFound = false;
-for (std::vectorsal_uInt32::const_iterator it(aDelList.begin()); !bFound  it != aDelList.end(); ++it )
-if ( *it == nKey )
-bFound = true;
-return bFound;
+return ::std::find(aDelList.begin(), aDelList.end(), nKey);
 }
 
 // ---
 
-bool SvxNumberFormatShell::IsAdded_Impl( sal_uInt32 nKey )
+bool SvxNumberFormatShell::IsRemoved_Impl( size_t nKey )
+{
+return GetRemoved_Impl( nKey ) != aDelList.end();
+}
+
+// ---
+

Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

[Lubos Lunak]

On Tuesday 09 of August 2011, Stephan Bergmann wrote:
 On Aug 9, 2011, at 5:15 PM, Lubos Lunak wrote:
  namespace lostd // or just no namespace at all, any other 'list' class is
  unlikely
  {
  template ... 
  class list : public ::std::list ... 
  {
  ...
  int size() const { return ::std::list ... ::size(); } // plus possibly
  checks here, but somehow doubt there are many cases, if any, where one
  would have a list with more than 2E9 items
  ...
  };
 
  This class is technically still also std::list, so it should be a drop-in
  replacement for all cases. And IMO a much nicer solution than
  people randomly adding casts all over the codebase.

 Technically, lostd::list is no longer a container, as it violates the
 requirement that the return type of size() is size_type.  (And if you
 redefine size_type as int, as you should do anyway in the above sketch, it
 violates the requirement that size_type is an unsigned integral type.) 

 Do you realize that as long as the list does not contain 2E9 items, which it 
does not, this does not matter at all?

 Really, I would not try to outsmart the specification---even if the
 specification is far from beautiful.

 Right, doing things properly, for whatever definition of 'properly', is more 
important than anything else. That's how OOo has always been developed and 
that's why we now have a clean, easy to understand and elegant codebase. Oh, 
wait.

 From my experience, I consider the problem of randomly added casts as not
 that severe, anyway.  The best fix for the code in question would probably
 be if indexing types like the type of nEntry were std::size_t to begin
 with.

 You can never do without signed types, so as long as there's a single 
unsigned type, there always will be mixing.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Opengrok and onegit

[Cedric Bosdonnat]

On Wed, 2011-08-10 at 11:35 +0200, Jan Holesovsky wrote:
 On 2011-08-10 at 10:30 +0200, Cedric Bosdonnat wrote:
 
  It was just me being too slow to migrate it just when coming back from
  vacations. It's not indexing core, binfilter, help and translations
 
 s/not/now/ right? ;-)

Oops, indeed, now has to be read here :)

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEWED] comments translation

[Cedric Bosdonnat]

Hi Christina,

On Sat, 2011-07-09 at 21:46 +0200, Chr. Rossmanith wrote:
 following you find the comments I've promised...

Thanks for your review, I just made the changes and pushed the whole lot
to master branch.

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Bug 35673 depends on bug 39159, which changed state.

Bug 39159 Summary: PRINTING: Switching radio buttons Selection - All Crashes
https://bugs.freedesktop.org/show_bug.cgi?id=39159

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Resolution||FIXED
 Status|ASSIGNED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Suggestion and patch for Confirmation of save format dialog

[Kevin Hunter]

At 5:09am -0400 Tue, 09 Aug 2011, Caolán Mcnamara wrote:

I think the whole existing dialog was a complete fail. Never liked
the wording Keep, seeing as the dialog also appears on first save
of a new file, i.e. new document-save as .doc, and you get Keep MS
format, which feels odd to me. Use/Save might be better.

Maybe put Save as 'X' anyway into the current keep button, with
save in 'Y' instead as the alternative save as ODF. I know I
typically skip all explanatory text and go right to the buttons, only
reading the text if I need to.


Having brought this up before, maybe 6 months ago or so, I'm aware that 
this would be a time consuming task and that there's not a lot of 
enthusiasm to do it, but man it would be useful to have a some sort of 
document instrospection so that we could say /exactly/ what would be 
lost in a non-ODF format.


On the other hand, I think it was you, Caolán who pointed out it might 
just be easier to implement those bits ...


Sigh.  Would that I had the wherewithal and time to do it rather than be 
a noisy bystander.


Cheers,

Kevin

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] fdo#39159 selection and writer print dialog preview crash

[Caolán McNamara]

A most-annoying bug: https://bugs.freedesktop.org/show_bug.cgi?id=39159
My plausible fix.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=cd690d2e72be410058376c416a40ff5d918fb0f7
that I'm proposing for cherry-picking back to 3-4.

I'm not delighted by this as a solution, I'm rather a hater of the
writer nest of views and shells, but I think it will do the job.
Definitely stops the crash, worst case scenario if I'm wrong is that
some selection-related print scenario might toggle some current view
options like show field codes off or something of that nature.

As an aside our own fedora abrt crash capturer has a constant small
trickle of OpenOffice.org as well as LibreOffice related crashes coming
from writer print with this relatively new renderer, so its apparently
an inherited set of problems.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Suggestion and patch for Confirmation of save format dialog

[Caolán McNamara]

On Tue, 2011-08-09 at 21:23 +0200, Christoph Noack wrote:
 That said, the most helpful thing (but most difficult) ist to tell
 people what will be missing exactly in terms of content, features or
 formatting when exporting documents.

Hard, there was a filter tracer project long ago to attempt to record
for semi-debugging purposes things which couldn't be exported to the
destination format, but it's not great :-( Most critically while it
could detect some things, it doesn't/didn't detect all of them. Plenty
of work required, its a good idea to have it if we could do it. That'd
be the MSFilterTracer stuff in sw/source/filter/ww8 and similar ones
elsewhere.

We should probably not let the great be the enemy of the good and either
drop the dialog entirely? or make it a big easier to read in the
short-term, e.g. by Friday :-)

C.

p.s.
I see the MSFilterTracer logging has gone stale anyway, e.g. 

if (!pWDop-fNoLeading)
maTracer.Log(sw::log::eExtraLeading); 
rDoc.set(IDocumentSettingAccess::ADD_EXT_LEADING, !pWDop-fNoLeading);

we seem to be logging that we can't support extra leading as a compatibility
option at the same time we set the since-implemented extra leading
compatibility option :-)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] fix for fdo#37319: don't write invalid references to odf files

[Eike Rathke]

Hi,

On Wednesday, 2011-08-10 01:30:06 -0400, Kohei Yoshida wrote:

 $Sheet1.$A$1+$#REF!.$A$2
 
 When you save this document at this point, what gets saved is
 
 table:expression=[$Sheet1.$A$1]+[$#REF!.$A$2]
 
 The bug reported in fdo#37391 says that as of ODF 1.2 you must write
 
 table:expression=[$Sheet1.$A$1]+[#REF!]
 
 when one of sheet, column and row gets invalidated.
 
 Since this expression is generated directly from ScCompiler, it's likely
 affecting other areas where the formula expressions are generated from
 ScCompiler on export.  And the right fix probably needs to be made
 inside the formula compiler code too.

Indeed, the right place for this would be in
ConventionOOO_A1::MakeRefStrImpl() if bODF==true and any of the ref
parts IsTabDeleted()/IsColDeleted()/IsRowDeleted() is true.

For loading, ScCompiler::IsPredetectedReference() looks like it already
accepts a single #REF! string.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpPYYtEYPRwW.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Does anyone use 'source_config' files for build.pl ???

[Eike Rathke]

Hi Tor,

On Tuesday, 2011-08-09 22:03:46 -0600, Tor Lillqvist wrote:

 deliver.pl also contains a fair amount of whatI assume is Hamburg-only
 -related code. For instance the common_build and COMMON_DEST things.
 Or what?

Those common things are the common output directories if you build for
different platforms, where the UI resource files are placed as they are
(so far were?) not platform dependent.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgp9U8S5tZqew.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Java debugging

[Cedric Bosdonnat]

Hello Gabor,

On Wed, 2011-08-10 at 12:43 +0200, Jenei Gábor wrote:
 First of all thanks for your useful documents, and I am trying to debug 
 the wizards of LibreOffice Base, exactly I am interested about 
 SQLQueryComposer.java(or something similar) at wizards/com/sun/star/db I 
 added to the source paths this directory, so Eclipse recognises that my 
 source code is from there, thus it shows me the code where it stoped. I 
 suspect also some problem about this. I did make -sr debug=true 
 dbglevel=2 for the whole directory, I don't know if it is enough, for 
 C++ code it was enough with gdb. So, could you help me?

I had a look at what happens when building java bits with debug=t... and
the -g option was missing there. I just pushed a patch to add the -g
option to javac when building with debuglevel  0.

Try with that now and it should be fine.

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Use STL find in SvxNumberFormatShell

[Eike Rathke]

Hi Maciej,

On Wednesday, 2011-08-10 12:02:23 +0200, Maciej Rumianowski wrote:

 My patch got lost on mailing list, so I am attaching it now against
 actual master.

Fine! Pushed to master
http://cgit.freedesktop.org/libreoffice/core/commit/?id=45fdd31fb986214f1086fe548d99139204b7a460

Thanks
  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpdo1Mqyawy0.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] .vimrc to compile source from within Vim

[Eike Rathke]

Hi Bjoern,

On Wednesday, 2011-08-10 00:05:40 +0200, Bjoern Michaelsen wrote:

  Hmm.. actually make continues to build if there there are more sources
  to compile, even if the target was given. How to make it stop after
  the specified target?
 
 does make gb_FULLDEPS= (setting gb_FULLDEPS to empty) help?

No, then the compiler complains about each and every included header
file being missing. Apparently that affects also the include path.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpNhvxd0TiH1.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] build error in tail_build

[Cor Nouws]

Norbert Thiebaud wrote (09-08-11 19:43)

On Tue, Aug 9, 2011 at 12:25 PM, Cor Nouwsoo...@nouenoff.nl  wrote:



git complains that libo exists and is not empty.


that is probably because libo was the name of the bootstrap you
already have... you need to chose another name than libo (core ? )


Yes of course that was the reason.


Hence my question:
any smart way to
  - get rid of the old master repro +
  - conserve the (sharing) libreoffice 3-4-0 clone


Stupid question I though myself later on.


I'm not sure how you are set-up, but no, you cannot 'share' master and
libreoffice-3-4 because they live on different repositories (different
as completely different, nothing in common)


Set up a new repro and with some small barriers, build was successful.

Now up to the next...


--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] communicating bugs found in build form master

[Cor Nouws]

Hi *,

So now and then I (try to) build from master and just do some work in 
the office.
It is however rather irregular, and often I do not have much free time 
to spent.


A.  If I find an issue, is it OK if I mail this list or just ping on IRC?
Just to prevent adding bugs that are already noticed (not in bugzilla) 
and maybe even fixed in master after I udated?


e.g. I wrote https://bugs.freedesktop.org/show_bug.cgi?id=39979
but can on the other hand hardly imagine that it hasn't been tracked 
already..


B. Do we already have a QA mail list?

Thanks,

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

[Astron]

Hi,

      * the (possible) length of the button text, and ...
      * the stacked button layout (which is never used in LibO that way)
 will eat up the improved understandability of your change.

I agree with this.



 So, what do we have to fill the buttons when exporting (if we want to
 get back the usual layout)? I assume there are:
      * the file format description Microsoft Word 97/2000/XP/2003
        format
      * the file format extension .doc

I think the obvious solution is to use the file extension for the
buttons and highlight the name of the file format in the warning by
making it bold etc. Like this:

===
This document may contain formatting or content that cannot be saved in
*Microsoft Word 97/200/XP/2003* (DOC) file format.
Do you want to keep this file format for this document?

Use the ODx format to make sure all formatting and content is saved correctly.

[Keep DOC Format] [Save in ODx Format]

[x] Ask when not saving as ODF
===

(ODx should be replaced by each application's specific OpenDocument format.)

Advantages:
* no new strings necessary for the application names (like Microsoft
Word) (I only guess here)
* the word keep is mentioned in the question as well as on the
button (not sure it sounds good in the question, though – please
advise)
* the file format is bold and on a new line → very visible
* using ODx avoids a tautology (OD_F_ file _format_)
* all file endings are explicitly mentioned both in the warning and on
the buttons
* and some of the things Christoph's proposal already improved upon
(like removing latest)

Disadvantages:
* DOC Format is probably not as easily understandable as Microsoft
Word Format

Regards,

Astron.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] communicating bugs found in build form master

[Caolán McNamara]

On Wed, 2011-08-10 at 15:44 +0200, Cor Nouws wrote:
 e.g. I wrote https://bugs.freedesktop.org/show_bug.cgi?id=39979
 but can on the other hand hardly imagine that it hasn't been tracked 
 already..

I think its worth recording the build-id in help:about anyway when
logging master bugs. In the case it doesn't get looked at for a while
it should help identify the earliest commit id before which the error
was introduced in the case of regressions.

In this specific case the missing paste is my own brown-bag moment which
I noticed earlier today.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] communicating bugs found in build form master

[Kohei Yoshida]

Hi Cor,

On Wed, 2011-08-10 at 15:44 +0200, Cor Nouws wrote:

 A.  If I find an issue, is it OK if I mail this list or just ping on IRC?
 Just to prevent adding bugs that are already noticed (not in bugzilla) 
 and maybe even fixed in master after I udated?

So, I'm not a big fan of cluttering bugzilla with bugs in master
*unless* the bug stays there for weeks and you already know who to
assign to (to have the bug report serve as a reminder for that person to
fix later).  But I'm not strongly against this.  Also, sometimes we
notice that something is broken on master and fix it immediately in a
few days.

The better thing to do is to narrow down the commits that may have
broken it if you know the last commit that worked.  If you are willing,
you could even take advantage of git bisect to achieve this, in theory.

 e.g. I wrote https://bugs.freedesktop.org/show_bug.cgi?id=39979
 but can on the other hand hardly imagine that it hasn't been tracked 
 already..

I saw Miklos and Caolan discussing something like this today on IRC.
Not sure if it's the same thing or not.

 B. Do we already have a QA mail list?

Yes.  libreoffice...@lists.freedesktop.org.

HTH,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] communicating bugs found in build form master

[Rainer Bielefeld]

Cor Nouws schrieb:


A. If I find an issue, is it OK if I mail this list or just ping on IRC?
Just to prevent adding bugs that are already noticed (not in bugzilla)
and maybe even fixed in master after I udated?


Hi

currently I believe Bugzilla is the best way. If we run into problems we 
can decide newly.




B. Do we already have a QA mail list?



Rats, it seems I forgot you ...

On http://wiki.documentfoundation.org/QA#How_to_participate you find 
the link where you can subscribe, I will add it to the normal list 
overview, soon.


Kind regards

Rainer
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH][PUSHED] Bug 39167

[Cedric Bosdonnat]

Hello Gabor,

On Fri, 2011-07-29 at 12:09 +0200, Jenei Gábor wrote:
 Here is a patch for the above mentioned bug, for me it resolved the
 issue on 3.5 main version in english, unfortunatelly I couldn't have it
 done in other national versions. Please review it, and put it into the
 main version if it's ok.

Don't worry about the other versions, they'll see that there was a
string change. BTW there are a few things that were missing:
  * You should have checked the corresponding cxx files: there were some
positions recalculations due to some other row: I fixed it to keep the
whole positioning clean.
  * The help should be changed according to what you changed there.

I pushed your changes with some adjustments to the core repository and
I'll hack the help too.

Many thanks for your patch: keep providing good ones like this ;)

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

[Stephan Bergmann]

On Aug 10, 2011, at 12:31 PM, Lubos Lunak wrote:
 On Tuesday 09 of August 2011, Stephan Bergmann wrote:
 Technically, lostd::list is no longer a container, as it violates the
 requirement that the return type of size() is size_type.  (And if you
 redefine size_type as int, as you should do anyway in the above sketch, it
 violates the requirement that size_type is an unsigned integral type.) 
 
 Do you realize that as long as the list does not contain 2E9 items, which it 
 does not, this does not matter at all?

That's not my point.  My point is that such an IMO hacky solution that tries to 
outsmart the language is probably not worth it.  (Imagine a compiler that emits 
a warning if a class that does not meet the container requirements is used with 
one of the standard algorithms…)

 Really, I would not try to outsmart the specification---even if the
 specification is far from beautiful.
 
 Right, doing things properly, for whatever definition of 'properly', is more 
 important than anything else. That's how OOo has always been developed and 
 that's why we now have a clean, easy to understand and elegant codebase. Oh, 
 wait.

I hope my post did not come across as demanding a sarcastic reply.

 From my experience, I consider the problem of randomly added casts as not
 that severe, anyway.  The best fix for the code in question would probably
 be if indexing types like the type of nEntry were std::size_t to begin
 with.
 
 You can never do without signed types, so as long as there's a single 
 unsigned type, there always will be mixing.

Yes, we appear to agree that there is some mixing.  I just argued that I do not 
consider the (infrequent) mixing a problem worth a more hacky and less 
straightforward solution than inserting an explicit cast.  (And that if there 
is high-frequency mixing then probably something else is bad about the code, 
and fixing that root cause will also remove the high-frequency mixing.)

-Stephan

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] mail-merge fixes for 3-4

[Noel Power]

On 04/08/11 16:10, Caolán McNamara wrote:

http://cgit.freedesktop.org/libreoffice/libs-extern-sys/commit/?id=491dab7d62dc42a13d56fe82cc33c2fb312ee30f
http://cgit.freedesktop.org/libreoffice/ure/commit/?id=b9f4c91d97aacc5d311c17e43f5cfe408de572dc
http://cgit.freedesktop.org/libreoffice/writer/commit/?id=64842a9788227a5a18241ddfb5f0f679f09a007c


pushed to 3.4

Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] fdo#39159 selection and writer print dialog preview crash

[Noel Power]

On 10/08/11 12:07, Caolán McNamara wrote:

A most-annoying bug: https://bugs.freedesktop.org/show_bug.cgi?id=39159
My plausible fix.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=cd690d2e72be410058376c416a40ff5d918fb0f7
that I'm proposing for cherry-picking back to 3-4.


pushed to 3.4

Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Where did Setup.xcu go?

[Knut Olav Bøhmer]

2011/8/10 Knut Olav Bøhmer boh...@gmail.com:
 Hi,

 Why does not LibreOffice have any Setup.xcu?

 And how can I set up LibreOffice to listens for uno connections? (like
 we did with openoffice and ooSetupConnectionURL in Setup.xcu)

I'm refering to how to do this in LibreOffice:
http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/ProUNO/Starting_OpenOffice.org_in_Listening_Mode

Best regards.
-- 
Knut Olav Bøhmer
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Where did Setup.xcu go?

[Stephan Bergmann]

On Aug 10, 2011, at 4:23 PM, Knut Olav Bøhmer wrote:
 Why does not LibreOffice have any Setup.xcu?

For performance reasons, it (like all the other xcu files, too) got folded into 
a single large main.xcd.  (Beware, very long lines.  You may want to pipe it 
through an XML pretty printer if you want to edit it manually.)

-Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] fix soltools build with svn gcc

[Tom Tromey]

I tried building LibreOffice with svn trunk gcc.

It dies in soltools with:

Compiling: soltools/giparser/gi_list.cxx
In file included from ../inc/gi_list.hxx:33:0,
 from 
/home/tromey/Space/LibreOffice/bootstrap/soltools/giparser/gi_list.cxx:33:
../inc/st_list.hxx: In instantiation of 'DynamicListXY 
DynamicListXY::operator=(const DynamicListXY) [with XY = GenericInfo]':
/home/tromey/Space/LibreOffice/bootstrap/soltools/giparser/gi_list.cxx:59:25:   
required from here
../inc/st_list.hxx:298:10: error: 'push_back' was not declared in this scope, 
and no declarations were found by argument-dependent lookup at the point of 
instantiation [-fpermissive]
../inc/st_list.hxx:298:10: note: declarations in dependent base 
'ST_ListGenericInfo*' are not found by unqualified lookup
../inc/st_list.hxx:298:10: note: use 'this-push_back' instead
../inc/st_list.hxx: In instantiation of 'void DynamicListXY::Insert(unsigned 
int, XY* const) [with XY = GenericInfo]':
/home/tromey/Space/LibreOffice/bootstrap/soltools/giparser/gi_list.cxx:234:1:   
required from here
../inc/st_list.hxx:311:5: error: 'checkSize' was not declared in this scope, 
and no declarations were found by argument-dependent lookup at the point of 
instantiation [-fpermissive]
../inc/st_list.hxx:311:5: note: declarations in dependent base 
'ST_ListGenericInfo*' are not found by unqualified lookup
../inc/st_list.hxx:311:5: note: use 'this-checkSize' instead


The appended patch fixes this problem by adding 'this-' qualifiers.

This is contributed under the LGPLv3+/MPL.

Tom

diff --git a/soltools/inc/st_list.hxx b/soltools/inc/st_list.hxx
index 51f0a32..69b6943 100644
--- a/soltools/inc/st_list.hxx
+++ b/soltools/inc/st_list.hxx
@@ -295,7 +295,7 @@ DynamicListXY::operator=( const DynamicListXY  i_rList 
)
   it != i_rList.end();
   ++it )
 {
- push_back( new XY(*(*it)) );
+ this-push_back( new XY(*(*it)) );
 }
 return *this;
 }
@@ -308,7 +308,7 @@ DynamicListXY::Insert(unsigned pos, XY * const  elem_)
 if ( pos  this-len )
   return;
 
-checkSize(DynamicListXY::len+2);
+this-checkSize(DynamicListXY::len+2);
 memmove( DynamicListXY::inhalt+pos+1, DynamicListXY::inhalt+pos, 
(DynamicListXY::len-pos) * sizeof(XY*) );
 this-inhalt[pos] = elem_;
 this-len++;
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] cherrypicked to 3.4

[Noel Power]

Hi Caolán

took the liberty of cherry-picking
http://cgit.freedesktop.org/libreoffice/ure/commit/?h=libreoffice-3-4id=342601dbbcd571dd72ad4a1d67ff6f6d20b47134
to 3.4

Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

[Regina Henschel]

I wrote accidentally only to Astron. Here now to the list too. In 
addition find Astrons answer below.


Hi Astron,

Astron schrieb:

Hi,



===
This document may contain formatting or content that cannot be saved in
*Microsoft Word 97/200/XP/2003* (DOC) file format.
Do you want to keep this file format for this document?

Use the ODx format to make sure all formatting and content is saved correctly.

[Keep DOC Format] [Save in ODx Format]

[x] Ask when not saving as ODF
===

(ODx should be replaced by each application's specific OpenDocument format.)

Advantages:
* no new strings necessary for the application names (like Microsoft
Word) (I only guess here)
* the word keep is mentioned in the question as well as on the
button (not sure it sounds good in the question, though – please
advise)


The word keep is the reason for the current misunderstanding in the 
dialog. It should be changed. Reasoning: The dialog comes up, if you are 
working on a document, which is in ODF- Format and  you will save it in 
an alien format. So for the user keep means keep the current ODF-Format.


My proposal:
===
This document may contain formatting or content that cannot be saved in
 *Microsoft Word 97/200/XP/2003* (DOC) file format.

Use the ODx format to make sure all formatting and content is saved 
correctly.


[Save in DOC Format] [Save in ODx Format]

[x] Ask when not saving as ODF
===

The question Do you want to keep this file format for this document? 
is not necessary at all, because the buttons do not have Yes/No, but say 
directly what they do.


So the buttons are understandable without reading the text above it. But 
if an user wonders, why the dialog comes up, he can read the explanation.


If it is not possible to put 'DOC' (or the another special alien 
formats) into the button, then the neutral Text Save in Alien Format 
can be used.


Kind regards
Regina

==
Answer I got:

Hi, Regina, I think you've accidentally replied to me only (this list
has the feature [other people's words, not mine] that you don't
automatically reply to the list). It's probably best if you re-send it
to the list.

Here's a bit of feedback:
* I think the whole idea was to avoid being unspecific in the buttons,
so Save in Alien Format is IMHO not good (and also sounds technical)
* I am not an absolute UI expert (merely an interested user), but I
think it is obligatory to have a question in confirmation alerts,
although e.g. Gnome HIG (I am GNOME user, so I always refer to this
HIG) doesn't explicitly mention a question, it is present in all (two)
examples [1].
* You are right that keep might not be the best fitting word in many
cases this dialogue is used (but I didn't see save as a better
replacement (read on)). However, the user still affirms a choice, so I
don't know for sure.
* I am unsure if using the same verb for both buttons makes them too
interchangeable (although of course the file format should be the
important thing)

(Please feel free to copy my feedback into your mail to the list.)

Regards,
Astron.

[1] 
http://developer.gnome.org/hig-book/stable/windows-alert.html.en#alerts-confirmation



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] fix xml2cmp build with svn gcc

[Tom Tromey]

I tried building LibreOffice with svn trunk gcc.

It dies in xml2cmp with:

Compiling: xml2cmp/source/xcd/xmlelem.cxx
In file included from ./xmlelem.hxx:38:0,
 from 
/home/tromey/Space/LibreOffice/bootstrap/clone/ure/xml2cmp/source/xcd/xmlelem.cxx:30:
./../support/list.hxx: In instantiation of 'void 
DynamicListXY::insert(unsigned int, XY* const) [with XY = XmlElement]':
/home/tromey/Space/LibreOffice/bootstrap/clone/ure/xml2cmp/source/xcd/xmlelem.cxx:263:1:
   required from here
./../support/list.hxx:229:5: error: 'checkSize' was not declared in this scope, 
and no declarations were found by argument-dependent lookup at the point of 
instantiation [-fpermissive]
./../support/list.hxx:229:5: note: declarations in dependent base 
'ListXmlElement*' are not found by unqualified lookup
./../support/list.hxx:229:5: note: use 'this-checkSize' instead
dmake:  Error code 1, while making '../../unxlngx6.pro/obj/xmlelem.obj'


The appended patch fixes this problem by adding a 'this-' qualifier.

This is contributed under the LGPLv3+/MPL.

Tom

diff --git a/xml2cmp/source/support/list.hxx b/xml2cmp/source/support/list.hxx
index 6de123e..e4e5361 100644
--- a/xml2cmp/source/support/list.hxx
+++ b/xml2cmp/source/support/list.hxx
@@ -226,7 +226,7 @@ DynamicListXY::insert(unsigned pos, XY * const  elem_)
 if ( pos  this-len )
   return;
 
-checkSize(this-len+2);
+this-checkSize(this-len+2);
 memmove(this-inhalt[pos+1], this-inhalt[pos], (this-len-pos) * 
sizeof(XY*) );
 this-inhalt[pos] = elem_;
 this-len++;
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Bug 39168

[Noel Power]

Hi Jenei
On 08/08/11 11:06, Jenei Gábor wrote:

Hello,

I would like to inform everyone that I attached my purposed patch that 
fixes the bug 39168 in our bug report page, since it causes an already 
mentioned problem in the overwriting dialog's popup I don't consider 
it as something stable, 

[...]

 Here I also attach the purposed patch and I am waiting for your reviews.
well I have to admit I am not familiar with this hybrid/pdf thing, not 
sure if it really is a good or bad thing, personally I really don't like 
the double extension thing, but anyway I just have some general comments 
on the patch


sfx2/source/dialog/filedlghelper.cxx


the first hunk in this patch is confusing, it changes the prevailing style of 
positioning for '{'  '}' if there is no good reason to do that then it is 
better not to make such a change

the second hunk that changes the logic of FileDialogHelper::GetPath is a little 
worrying ( 'cause I guess this is used by many clients ), why was this 
necessary and how does it change the existing behaviour?

sfx2/source/doc/guisaveas.cxx
=

2nd hunk is just whitespace change and again it's quite noisy to review

- in 'sal_Bool ModelData_Impl::OutputFileDialog'

+if(bAddStream==sal_True)
the equality check isn't really necessary
if((bAddStream)
just reads better for me,

- please don't change the prevailing style for '{' / '}'

- using a map to store and retrieve the desired extension based on the 
filtername would be neater and less cluttered that then the it/then construct 
used in the patch.
 


what's really uncomfortable is ( from a quick apply  try of the patch ) is the 
fact that the file name you are saving to is sort-of hijacked under the hood. e.g. 
the file dialogs indicate one thing ( save with.pdf extension ) but do something 
else ( save with a .odt.pdf extension ).
Using a new filter type would seem a more natural solution e.g. a filter type 
that you could select in the 'save-as' dialog that would save the pdf in the 
required hybrid format and would indicate the ( imo horrible dual extension ) 
The same filter type would be preselected ( if hybrid was selected in the pdf 
export options dialog ) and shown file dialog raised by the export button. But 
then again I only have a very passing familiarity with stuff, maybe someone 
else might have more constructive advice

Noel


Noel




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] fix cosv build

[Tom Tromey]

I tried building LibreOffice with svn trunk gcc; though in this case the
bug seems to be a fairly generic include order problem.

The build dies in cosv with:

Compiling: cosv/source/strings/string.cxx
In file included from ../../inc/cosv/string.hxx:33:0,
 from ../../inc/cosv/csv_precomp.h:39,
 from ../inc/precomp.h:32,
 from 
/home/tromey/Space/LibreOffice/bootstrap/clone/sdk/cosv/source/strings/string.cxx:29:
../../inc/cosv/stringdata.hxx: In instantiation of 
'csv::StringDataCHAR::StringData(const CHAR*, 
csv::StringDataCHAR::size_type) [with CHAR = char, 
csv::StringDataCHAR::size_type = long unsigned int]':
/home/tromey/Space/LibreOffice/bootstrap/clone/sdk/cosv/source/strings/string.cxx:75:17:
   required from here
../../inc/cosv/stringdata.hxx:105:5: error: 'memcpy' was not declared in this 
scope, and no declarations were found by argument-dependent lookup at the point 
of instantiation [-fpermissive]
/usr/include/string.h:44:14: note: 'void* memcpy(void*, const void*, size_t)' 
declared here, later in the translation unit
dmake:  Error code 1, while making '../../unxlngx6.pro/obj/string.obj'


string.hxx includes string.h, which declares memcpy, after
cosv/stringdata.hxx.  Moving string.h earlier fixes the problem.

This is contributed under the LGPLv3+/MPL.

Tom

diff --git a/cosv/inc/cosv/string.hxx b/cosv/inc/cosv/string.hxx
index 08b1220..8f249f9 100644
--- a/cosv/inc/cosv/string.hxx
+++ b/cosv/inc/cosv/string.hxx
@@ -30,9 +30,9 @@
 #define COSV_STRING_HXX
 
 // USED SERVICES
+#include string.h
 #include cosv/stringdata.hxx
 #include cosv/str_types.hxx
-#include string.h
 #include cosv/csv_ostream.hxx
 #include vector
 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Bug 39168

[Jenei Gábor]

Hello Noel,

Well, I just like more if{ linefeedcodelinefeed } form even is 
code is just one line long, but you are right, it still works(and maybe 
also nicer to leave it) without { and } As for the other comments, 
probably you're right that it's not the best solution, I just haven't 
understood fully all the objects, as to be honest because of the lot of 
classes this part of code needs a quite big effort to be modified, as 
you must understand all the objects before,which can be timeconfusing. 
But I absoloutly agree, that this is not the nicest solution, that's why 
I just signed it as purposed and not as final patch. Even because it 
keeps a quite annoying problem, that the overwrite dialog in saving will 
pop up wrong. So I don't either think that this patch can be pushed in 
this form. I just pushed it if someone wants to mind with it. By the way 
if you say I should correct it, and send it again, I'll do provided that 
someone is really going to push it afterwards, I just interrupted this 
job because of the debates about the bug. Some members even doubted if 
it should be fixed, so why should I mind about something needless then? 
Finally I have to mention that I cannot work on it at the moment, as I 
am busy with another bug about Base's querywizard. But as soon as I am 
done I could mind with this issue again taking into the consideration 
your requests.


Gabor

2011. 08. 10. 18:25 keltezéssel, Noel Power írta:

Hi Jenei
On 08/08/11 11:06, Jenei Gábor wrote:

Hello,

I would like to inform everyone that I attached my purposed patch 
that fixes the bug 39168 in our bug report page, since it causes an 
already mentioned problem in the overwriting dialog's popup I don't 
consider it as something stable, 

[...]
 Here I also attach the purposed patch and I am waiting for your 
reviews.
well I have to admit I am not familiar with this hybrid/pdf thing, not 
sure if it really is a good or bad thing, personally I really don't 
like the double extension thing, but anyway I just have some general 
comments on the patch


sfx2/source/dialog/filedlghelper.cxx


the first hunk in this patch is confusing, it changes the prevailing 
style of positioning for '{'  '}' if there is no good reason to do 
that then it is better not to make such a change


the second hunk that changes the logic of FileDialogHelper::GetPath is 
a little worrying ( 'cause I guess this is used by many clients ), why 
was this necessary and how does it change the existing behaviour?


sfx2/source/doc/guisaveas.cxx
=

2nd hunk is just whitespace change and again it's quite noisy to review

- in 'sal_Bool ModelData_Impl::OutputFileDialog'

+if(bAddStream==sal_True)
the equality check isn't really necessary
if((bAddStream)
just reads better for me,

- please don't change the prevailing style for '{' / '}'

- using a map to store and retrieve the desired extension based on the 
filtername would be neater and less cluttered that then the it/then 
construct used in the patch.



what's really uncomfortable is ( from a quick apply  try of the patch 
) is the fact that the file name you are saving to is sort-of hijacked 
under the hood. e.g. the file dialogs indicate one thing ( save 
with.pdf extension ) but do something else ( save with a .odt.pdf 
extension ).
Using a new filter type would seem a more natural solution e.g. a 
filter type that you could select in the 'save-as' dialog that would 
save the pdf in the required hybrid format and would indicate the ( 
imo horrible dual extension ) The same filter type would be 
preselected ( if hybrid was selected in the pdf export options dialog 
) and shown file dialog raised by the export button. But then again I 
only have a very passing familiarity with stuff, maybe someone else 
might have more constructive advice


Noel


Noel




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] http://libreoffice.boldandbusted.com/ cppcheck report jobs stalled... no longer! :)

[someone]

Hi again *,

After a long hiatus, this service is back on the air. I swapped out the
bad RAM for some good RAM, and hooray, we've got a fresh cppcheck report
at http://libreoffice.boldandbusted.com/ . I also hacked in sortable.js
for clickable, sortable column headings.

My hope is that this is useful to you! There were discussions (with
Julien and others) debating using either git master or released
versions of cppcheck, but since this machine is stable now, I'll keep
cppcheck on released versions (e.g. 1.49) until something really
annoying pops up in the report that should be eliminated. I'm still on
the hunt for some kind of easy script which makes a usable diff of HTML
pages, to be used to highlight new or removed cppcheck findings with
each run. If anyone has ideas in this vein, I'd love to hear them. :)

I see the excellent Tinderbox work is going strong. If my report isn't
really useful anymore due to work elsewhere, please let me know. Time
moves on, and perhaps this kind of thing is no longer useful or wanted.
If you have suggestions to make it easier or more useful, and they're
not too hard/expensive, I'll do what I can to make it better.

Anyway, Viva Libreoffice! :)

Cheers,

Jesse Adelman
ilikelinux Consulting/Bold and Busted LLC
http://www.ilikelinux.com/ http://www.boldandbusted.com/
Brisbane, CA

P.S. FYI, the reports seem to take a bit longer to run - 8 hours or so.

On 03/28/11 14:10, some...@boldandbusted.com wrote:
 Hi *. Sorry to say that it appears a hardware problem (bad RAM) has put
 a stop to cppcheck's 5 hour report runs that get pushed to
 http://libreoffice.boldandbusted.com/ . I'm RMA-ing the RAM today, and
 hopefully we'll see the replacements in a few weeks, if not sooner.
 
 Sorry for not writing sooner. The current report will stay available
 (the machine which does cppcheck runs is separate from the web server
 which presents the results). I hope it is still valuable as a reference
 until this problem is repaired.
 
 I'll write again to the list when I have an update for you on major
 changes to the status of this service.
 
 Cheers,
 
 Jesse Adelman
 ilikelinux Consulting/Bold and Busted LLC
 Brisbane, CA
 http://www.ilikelinux.com/
 http://www.boldandbusted.com/
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] sax build -vs- svn gcc

[Tom Tromey]

I tried building LibreOffice with svn trunk gcc.

It dies in sax with:

In file included from 
/home/tromey/Space/LibreOffice/bootstrap/sax/source/tools/fastserializer.cxx:33:0:
/home/tromey/Space/LibreOffice/bootstrap/solver/350/unxlngx6.pro/inc/comphelper/sequenceasvector.hxx:
 In instantiation of ‘void 
comphelper::SequenceAsVectorTElementType::operator(const 
com::sun::star::uno::SequenceT) [with TElementType = int]’:
/home/tromey/Space/LibreOffice/bootstrap/solver/350/unxlngx6.pro/inc/comphelper/sequenceasvector.hxx:111:13:
   required from 
‘comphelper::SequenceAsVectorTElementType::SequenceAsVector(const 
com::sun::star::uno::SequenceT) [with TElementType = int]’
/home/tromey/Space/LibreOffice/bootstrap/sax/source/tools/fastserializer.cxx:468:55:
   required from here
/home/tromey/Space/LibreOffice/bootstrap/solver/350/unxlngx6.pro/inc/comphelper/sequenceasvector.hxx:150:17:
 error: ‘push_back’ was not declared in this scope, and no declarations were 
found by argument-dependent lookup at the point of instantiation [-fpermissive]
/home/tromey/Space/LibreOffice/bootstrap/solver/350/unxlngx6.pro/inc/comphelper/sequenceasvector.hxx:150:17:
 note: declarations in dependent base ‘std::vectorint, std::allocatorint ’ 
are not found by unqualified lookup
/home/tromey/Space/LibreOffice/bootstrap/solver/350/unxlngx6.pro/inc/comphelper/sequenceasvector.hxx:150:17:
 note: use ‘this-push_back’ instead


The appended patch fixes this problem by adding a 'this-' qualifier.

This is contributed under the LGPLv3+/MPL.

Tom

diff --git a/o3tl/inc/o3tl/vector_pool.hxx b/o3tl/inc/o3tl/vector_pool.hxx
index 6ef4e96..28299f0 100644
--- a/o3tl/inc/o3tl/vector_pool.hxx
+++ b/o3tl/inc/o3tl/vector_pool.hxx
@@ -65,7 +65,7 @@ namespace o3tl
 }
 else
 {
-push_back(value_type(rCopy));
+this-push_back(value_type(rCopy));
 return this-size()-1;
 }
 }
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH][PUSHED] Consistent paragraph border handling for HTML export

[Cedric Bosdonnat]

On Wed, 2011-08-03 at 18:46 +0300, Harri Pitkänen wrote:
 Attached patches remove the special case where border settings tab disappears 
 from paragraph settings dialog when Writer is in HTML editor mode and HTML 
 3.2 is selected as format option for HTML export. The second patch enables 
 exporting the borders in this mode as well.
 
 Although CSS styles were not in use when HTML 3.2 was standardized I think 
 these days it is reasonable to export the styles anyway.

Sorry for the delay, I just came back from vacation and had to catch up
all the things that happened during that time ;)

Your patches are fine for me and I pushed them to master branch.
However, they make me think that HTML 3.2 export is probably not a
useful option anymore... is there still a browser that can't handle any
more recent version of HTML? I'ld be in favor of dropping that option
completely or at least update it to something like HTML 4.

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] http://libreoffice.boldandbusted.com/ cppcheck report jobs stalled

[julien2412]

Excellent ! Even if I would have preferred a git version, it's great to see
this report updated again. Cppcheck is a really good tool to detect
problems.

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/http-libreoffice-boldandbusted-com-cppcheck-report-jobs-stalled-tp2745270p3243534.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH][PUSHED] Consistent paragraph border handling for HTML export

[Harri Pitkänen]

On Wednesday 10 August 2011, Cedric Bosdonnat wrote:
 Your patches are fine for me and I pushed them to master branch.
 However, they make me think that HTML 3.2 export is probably not a
 useful option anymore... is there still a browser that can't handle any
 more recent version of HTML?

I don't think there is, at least among the major browsers released within past 
five years or so.

 I'ld be in favor of dropping that option
 completely or at least update it to something like HTML 4.

My ultimate goal is to reach a point where we could drop all browser specific 
or legacy HTML formats and just have one HTML export format that works in all 
browsers (or at least in those that 99 % of people use). Or if it turns out to 
be impossible, just have the smallest set of variants that are needed in the 
real world. With luck something based on HTML 4, CSS 2.1 and some subset of 
CSS 3 might work pretty much everywhere. If not, then options like HTML 4, 
HTML 5 and HTML 5 + LibreOffice specific extensions could be used in place 
of the current selection.

The reason why I chose to approach this problem by making single features more 
consistent is that this way the risk of accidentally removing or breaking some 
useful features seems lower. That said, I don't see much risk in dropping the 
3.2 export since any of the other export formats should render at least as 
well in old and new browsers. I could write a patch to do just that unless 
there are objections.

Harri
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Suggestion: openSUSE Linux 12.1/LibreOffice: Add function: Remove Formatting of Gmail

[Genix Info]

openSUSE Linux 12.1/LibreOffice: Add function: Remove Formatting of Gmail


More details:

https://features.opensuse.org/312719
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Make dev-install without running smoketests

[Thomas Arnhold]

On 08/04/2011 01:56 PM, Caolán McNamara wrote:

For this one at least, the assert itself was bogus for the empty
paragraph case, fixed with

http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=ba6440349db1bd688c08369dd2b30f5dd012d339


Nice! Works fine!

Thomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] sax build -vs- svn gcc

[Tom Tromey]

 Tom == Tom Tromey tro...@redhat.com writes:

Tom I tried building LibreOffice with svn trunk gcc.
Tom It dies in sax with:
[...]
Tom The appended patch fixes this problem by adding a 'this-' qualifier.

Oops, I appended the wrong patch to this message.  Here is the correct
patch.

I am not really sure where this file comes from.  From what I can tell
it isn't in git.

Tom


--- sequenceasvector.hxx.~1~2011-08-10 08:25:19.179720480 -0600
+++ sequenceasvector.hxx2011-08-10 11:48:05.404703517 -0600
@@ -147,7 +147,7 @@
 const TElementType* pSource = lSource.getConstArray();
 
 for (sal_Int32 i=0; ic; ++i)
-push_back(pSource[i]);
+this-push_back(pSource[i]);
 }
 
 //---
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use By property

[Olivier Hallot]

HI Caolán

I had to add this patch to prevent the table boudaries crash issue that
raised when one use the By property for GoLeftSel and GoRightSel.

The test case is (GoLeftSel)

sub Main
rem --
rem define variables
dim document   as object
dim dispatcher as object
rem --
rem get access to the document
document   = ThisComponent.CurrentController.Frame
dispatcher = createUnoService(com.sun.star.frame.DispatchHelper)

rem --
dim args1(0) as new com.sun.star.beans.PropertyValue
args1(0).Name = ToPoint
args1(0).Value = $E$7

dispatcher.executeDispatch(document, .uno:GoToCell, , 0, args1())

rem --
dim args2(0) as new com.sun.star.beans.PropertyValue
args2(0).Name = By
args2(0).Value = 10

dispatcher.executeDispatch(document, .uno:GoLeftSel, , 0, args2())

end sub



2011/7/29 Caolán McNamara caol...@redhat.com

 On Fri, 2011-07-29 at 06:30 -0300, Olivier Hallot wrote:
  Here is a patch to allow GoUpSel, GoDownSel, GoLeftsel,GoRightSel to
  receive By property

 Looks good.

  a test file appended as well. Run Main macro to test patch
 
  I left
  SID_CURSORBLKDOWN_SEL
  SID_CURSORBLKUP_SEL
  SID_CURSORBLKLEFT_SEL
  SID_CURSORBLKRIGHT_SEL
 
  untouched because repetitions makes no sense to them AFAIK

 I see that the pre-existing ::ExecuteCursor doesn't make a distinction
 for the Block selections, it just repeats them the same as non block. So
 I adjusted your patch to include them as well to be consistent between
 moving, and selecting. (hopefully I haven't cocked this up, Kohei, et.
 al. can double check it for me I guess)

 Pushed as calc:2a6f95014f3f8be561b4b67e9274a3cc24e2d08f (to master, so
 not in 3-4 stream), thanks for this.

 C.




-- 
Olivier Hallot
Founder and Steering Commitee Member
The Document Foundation
From 32baedfd2b769a6994768353cbdbbc1de0a262ee Mon Sep 17 00:00:00 2001
From: Olivier Hallot olivier.hal...@documentfoundation.org
Date: Wed, 10 Aug 2011 17:54:59 -0300
Subject: [PATCH] Fix boundaries overflow for Go/Up/Down/Left/Right/Sel with By property

This patch fixes a crash that occurs in GoLeftSel when the By property
forces a negative column index and GoRightSel forces a column beyond
MAXCOL.

For the sake of consistency I put the same logic on GoDownSel and
GoUpSel, but the crash did no showed up in these cases.
---
 sc/source/ui/view/tabview2.cxx |4 
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/sc/source/ui/view/tabview2.cxx b/sc/source/ui/view/tabview2.cxx
index 0ad18a4..00cdaf2 100644
--- a/sc/source/ui/view/tabview2.cxx
+++ b/sc/source/ui/view/tabview2.cxx
@@ -93,6 +93,7 @@ void moveCursorByProtRule(
 if (!isCellQualified(pDoc, rCol+1, rRow, nTab, bSelectLocked, bSelectUnlocked))
 break;
 ++rCol;
+if (rCol + 1  MAXCOL) break;
 }
 }
 }
@@ -106,6 +107,7 @@ void moveCursorByProtRule(
 if (!isCellQualified(pDoc, rCol-1, rRow, nTab, bSelectLocked, bSelectUnlocked))
 break;
 --rCol;
+if (rCol  1) break;
 }
 }
 }
@@ -119,6 +121,7 @@ void moveCursorByProtRule(
 if (!isCellQualified(pDoc, rCol, rRow+1, nTab, bSelectLocked, bSelectUnlocked))
 break;
 ++rRow;
+if (rRow + 1  MAXROW) break;
 }
 }
 }
@@ -132,6 +135,7 @@ void moveCursorByProtRule(
 if (!isCellQualified(pDoc, rCol, rRow-1, nTab, bSelectLocked, bSelectUnlocked))
 break;
 --rRow;
+if (rRow  1) break;
 }
 }
 }
-- 
1.7.3.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Throwing exception in destructor

[julien2412]

Hello,

cppcheck has detected 1 Throwing exception in destructor line 88 of
core/bridges/test/java_uno/acquire/testacquire.cxx
(sorry I mentionned 2 locations on IRC cause I forgot about the new git repo
: it was in core and old ure repo)
Could it be replaced by just a log (which function should be used for this
kind of case ?) or something since a throw in destructor should be avoided ?

Julien

--
View this message in context: 
http://nabble.documentfoundation.org/Throwing-exception-in-destructor-tp3243968p3243968.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use By property

[Kohei Yoshida]

Hi Olivier,

Good catch for this.

On Wed, 2011-08-10 at 18:06 -0300, Olivier Hallot wrote:

 I had to add this patch to prevent the table boudaries crash issue
 that raised when one use the By property for GoLeftSel and GoRightSel.

I would put the boundary check before incrementing and decrementing the
column / row position, to be consistent with the previous if statement
which checks the next position before moving the position, not after.

So, attached is my proposed change.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
diff --git a/sc/source/ui/view/tabview2.cxx b/sc/source/ui/view/tabview2.cxx
index 0ad18a4..995d6b5 100644
--- a/sc/source/ui/view/tabview2.cxx
+++ b/sc/source/ui/view/tabview2.cxx
@@ -92,6 +92,8 @@ void moveCursorByProtRule(
 {
 if (!isCellQualified(pDoc, rCol+1, rRow, nTab, bSelectLocked, bSelectUnlocked))
 break;
+if (rCol+1  MAXCOL)
+break;
 ++rCol;
 }
 }
@@ -105,6 +107,8 @@ void moveCursorByProtRule(
 {
 if (!isCellQualified(pDoc, rCol-1, rRow, nTab, bSelectLocked, bSelectUnlocked))
 break;
+if (rCol-1  0)
+break;
 --rCol;
 }
 }
@@ -118,6 +122,8 @@ void moveCursorByProtRule(
 {
 if (!isCellQualified(pDoc, rCol, rRow+1, nTab, bSelectLocked, bSelectUnlocked))
 break;
+if (rRow+1  MAXROW)
+break;
 ++rRow;
 }
 }
@@ -131,6 +137,8 @@ void moveCursorByProtRule(
 {
 if (!isCellQualified(pDoc, rCol, rRow-1, nTab, bSelectLocked, bSelectUnlocked))
 break;
+if (rRow-1  0)
+break;
 --rRow;
 }
 }
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] XML pretty printer (was: Where did Setup.xcu go?)

[Eike Rathke]

Hi,

On Wednesday, 2011-08-10 17:48:14 +0200, Stephan Bergmann wrote:

 For performance reasons, it (like all the other xcu files, too) got
 folded into a single large main.xcd.  (Beware, very long lines.  You
 may want to pipe it through an XML pretty printer if you want to edit
 it manually.)

For which I always recommend xmlpp,
http://software.decisionsoft.com/tools.html

Works also nicely for inspecting ODF files, my viewodf wrapper:

#!/bin/sh
if [ ! -f $1 ]; then
echo Usage: $0 ODF-file
exit 1
fi
unzip -p $1 content.xml styles.xml settings.xml | xmlpp.pl | vim -


Similar for OOXML spreadsheet files:

#!/bin/sh
if [ ! -f $1 ]; then
echo Usage: $0 MOOXML-file
exit 1
fi
unzip -p $1 'xl/workbook.xml' 'xl/worksheets/*.xml' 'xl/styles.xml' | 
xmlpp.pl | vim -


  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpkl1KpPbYqV.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Series of fixes and migration to One Git for contrib/dev-tools/ubuntu-jenkins

[Henrik Jensen]

Patches licensed under LGPLv3+/MPL 1.1 ( or what ever Bjoern Michaelsen prefers 
:-) )


A series of 7 suggested patches to fix some bugs and migrate to One Git in 
Bjoern Michaelsen 
Jenkins Continuous Integration Serversetup found in 
contrib/dev-tools/ubuntu-jenkins

Patch descriptions:
---
0001-Bugfix-Prevent-redundant-tarfile-downloads.patch

Bugfix: Prevent redundant tarfile downloads.

'./download' sources 'Env.Host.sh', not 'LinuxX86-64Env.Set.sh',so we must add
'set_tarfile_location.sh' to 'Env.Host.sh' after first './autogen.sh' run.
I speculate if this is an artifact of the cloning from the master and 
down-branching
to 3-4 !!!? - Maybe ./download should be called after the second autogen.sh 
though I
can't yet see through the consequences of that?

---
0002-Bugfix-x86-processor-architecture-agnostic.patch

Bugfix: x86 processor architecture agnostic.

Checks if 2nd. run of 'autogen.sh' has generated 'LinuxX86Env.Set.sh' or
'LinuxX86-64Env.Set.sh' and use the appropriate one.

---
0003-Bugfix-Using-the-new-Env.Host.sh-in-libreoffice-mast.patch

Bugfix: Using the new 'Env.Host.sh' in libreoffice-master instead of hardcoding 
'LinuxX86-64Env.Set.sh'

---
0004-Bugfix-libreoffice-master-job-needs-a-make-before-ma.patch

Bugfix: 'libreoffice-master' job needs a 'make' before 'make dev-install'

'dev-install' has dependencies to the 'all' target but it's not reflected in the
lo-root makefile.

---
0005-Migrate-to-One-Git-keep-possibility-for-3-4-build.patch

Migrate to One Git, keep possibility for 3-4 build.

- Cloning from 'repo-mirror/core.git' for 'libreoffice-master'.
- Cloning from 'repo-mirror-pre-one-git/bootstrap.git' for 'libreoffice-3-4'.
- Adding a 'repo-mirror-pre-one-git' to still support the 'libreoffice-3-4' job
- Disable cron schedule for the new (old) 'repo-mirror-pre-one-git'.

Adding 2 repo-mirrors to support both the new master and the 'libreoffice-3-4'
seems a bit unnecessary, but as I understand from asking on #libreoffice-dev
the new one-git master can't be used to checkout libreoffice.3.4.
Also tried a './g checkout libreoffice-3-4' on the new one-git repo
Output: error: pathspec 'libreoffice-3-4' did not match any file(s) known to 
git.

A solution might be to only mirror the old locked remote master gits and 
locally use
the onegit.sh conversion script located in
'anongit.freedesktop.org/libreoffice/contrib/dev-tools/onegit' to create a new
copy and then 'git fetch --all --tags' to update it to the newest?

---
0006-Using-the-JENKINS_HOME-variable.patch

Using the ${JENKINS_HOME} variable

Using the ${JENKINS_HOME} variable instead of hardcoding to the '~/.jenkins' 
path
This commit sets up an easier transition to a more generalized install procedure
see: https://wiki.jenkins-ci.org/display/JENKINS/Winstone
and https://wiki.jenkins-ci.org/display/JENKINS/Administering+Jenkins
for the ${JENKINS_HOME} variable

---
0007-Install-Jenkins-in-current-dir-instead-of-.jenkins.patch

Install Jenkins in current dir in stead of ~/.jenkins

Let Jenkins be installed in current dir instead of force to '~/.jenkins'
'setup-ubuntu-jenkins.sh' now creates a 'start-lo-jenkins.sh' with the 
appropriate startup arguments

---

TODO:
- Add the ccache lines to './autogen.sh' command line instead of concatenating 
to 'XEnv.Set.sh/Env.Host.sh'
- Let installer choose between installing Jenkins default dir ('~/.jenkins') or 
current dir.



--Henrik Jensen
(HenrikJ on #libreoffice-dev)From f82ffb467f01f23adc1a6afc348790108d8b6ada Mon Sep 17 00:00:00 2001
From: Henrik Jensen hrikjsenvagt...@yahoo.dk
Date: Wed, 10 Aug 2011 20:40:08 +0200
Subject: [PATCH 1/7] Bugfix: Prevent redundant tarfile downloads.

'./download' sources 'Env.Host.sh', not 'LinuxX86-64Env.Set.sh',so we must add
'set_tarfile_location.sh' to 'Env.Host.sh' after first './autogen.sh' run.
I speculate if this is an artifact of the cloning from the master and down-branching
to 3-4 !!!? - Maybe ./download should be called after the second autogen.sh though I
can't yet see through the consequences of that?
---
 ubuntu-jenkins/jobs/libreoffice-3-4/config.xml |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ubuntu-jenkins/jobs/libreoffice-3-4/config.xml 

Re: [Libreoffice] communicating bugs found in build form master

[Cor Nouws]

Hi Kohei,

Kohei Yoshida wrote (10-08-11 16:21)

On Wed, 2011-08-10 at 15:44 +0200, Cor Nouws wrote:


A.  If I find an issue, is it OK if I mail this list or just ping on IRC?
Just to prevent adding bugs that are already noticed (not in bugzilla)
and maybe even fixed in master after I udated?


So, I'm not a big fan of cluttering bugzilla with bugs in master
*unless* the bug stays there for weeks and you already know who to
assign to (to have the bug report serve as a reminder for that person to
fix later).


Since my irregular presence here/work with master builds, that is hard 
to achieve...



But I'm not strongly against this.


Ah, glad to read that ;-)


Also, sometimes we notice that something is broken on master and
fix it immediately in a few days.


Yes, so maybe it is better if I just drop my finding on IRC, and only if 
no one recognises it, make an issue.



The better thing to do is to narrow down the commits that may have
broken it if you know the last commit that worked.  If you are willing,
you could even take advantage of git bisect to achieve this, in theory.


git bisect  ... Thanks for the tip. I hope others taka advantage, for 
me it sounds as something for later.



e.g. I wrote https://bugs.freedesktop.org/show_bug.cgi?id=39979
but can on the other hand hardly imagine that it hasn't been tracked
already..


I saw Miklos and Caolan discussing something like this today on IRC.
Not sure if it's the same thing or not.


Indeed, was that.

Thanks for your help :-)
Cor


--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] communicating bugs found in build form master

[Cor Nouws]

Hi Rainer,

Rainer Bielefeld wrote (10-08-11 16:23)

A. If I find an issue, is it OK if I mail this list or just ping on IRC?
Just to prevent adding bugs that are already noticed (not in bugzilla)
and maybe even fixed in master after I udated?


currently I believe Bugzilla is the best way. If we run into problems we
can decide newly.


Yes, with the note I made in my mail to Kohei: I can just do a quick 
check on IRC



B. Do we already have a QA mail list?


Rats, it seems I forgot you ...


Or I missed an announcement / mail ..


On http://wiki.documentfoundation.org/QA#How_to_participate you find
the link where you can subscribe, I will add it to the normal list
overview, soon.


Thanks, hope we get is working :-\

Cheers,

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Series of fixes and migration to One Git for contrib/dev-tools/ubuntu-jenkins

[Norbert Thiebaud]

On Wed, Aug 10, 2011 at 4:56 PM, Henrik Jensen hrikjsenvagt...@yahoo.dk wrote:
 Patches licensed under LGPLv3+/MPL 1.1 ( or what ever Bjoern Michaelsen 
 prefers :-) )
 TODO:
 - Add the ccache lines to './autogen.sh' command line instead of 
 concatenating to 'XEnv.Set.sh/Env.Host.sh'

ccache is now (on master) automatically used if present in PATH, so
there should not be any need for special ccache lines to autogen.sh
anymore

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Bug 35673 depends on bug 37030, which changed state.

Bug 37030 Summary: Crash when Copy/Paste as GDI metafile selected cell range 
from CALC to WRITER
https://bugs.freedesktop.org/show_bug.cgi?id=37030

   What|Old Value   |New Value

 Resolution||DUPLICATE
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use By property

[Eike Rathke]

Hi Kohei,

On Wednesday, 2011-08-10 17:25:38 -0400, Kohei Yoshida wrote:

 On Wed, 2011-08-10 at 18:06 -0300, Olivier Hallot wrote:
  I had to add this patch to prevent the table boudaries crash issue
  that raised when one use the By property for GoLeftSel and GoRightSel.
 
 I would put the boundary check before incrementing and decrementing the
 column / row position, to be consistent with the previous if statement
 which checks the next position before moving the position, not after.
 
 So, attached is my proposed change.

Well, here's what I would do instead ;-)

The check should be done before the calls to isCellQualified(), surely
calling that with rCol/rRow out of bounds doesn't make much sense and at
best would return false anyway, hopefully. That immediately leads to the
new conditions can be moved one more up into the for loop conditions,
which shows that it is the same condition as the surrounding if block
that can be removed then, and for negative nMovX/nMovY the loop variable
be reversed, leaving only code of the attached solution. All untested.

Even the remaining if blocks checking for nMovX/nMovY/0/0 could be
removed now as the loops care for that, but may serve better
readability. Actually no runtime improvement would result from that, au
contraire, as there would be still the assignment and check of the loop
variable in addition.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
diff --git a/sc/source/ui/view/tabview2.cxx b/sc/source/ui/view/tabview2.cxx
--- a/sc/source/ui/view/tabview2.cxx
+++ b/sc/source/ui/view/tabview2.cxx
@@ -86,53 +86,39 @@ void moveCursorByProtRule(
 
 if (nMovX  0)
 {
-if (rCol  MAXCOL)
+for (SCCOL i = 0; i  nMovX  rCol  MAXCOL; ++i)
 {
-for (SCCOL i = 0; i  nMovX; ++i)
-{
-if (!isCellQualified(pDoc, rCol+1, rRow, nTab, bSelectLocked, 
bSelectUnlocked))
-break;
-++rCol;
-}
+if (!isCellQualified(pDoc, rCol+1, rRow, nTab, bSelectLocked, 
bSelectUnlocked))
+break;
+++rCol;
 }
 }
 else if (nMovX  0)
 {
-if (rCol  0)
+for (SCCOL i = 0; i  nMovX  rCol  0; --i)
 {
-nMovX = -nMovX;
-for (SCCOL i = 0; i  nMovX; ++i)
-{
-if (!isCellQualified(pDoc, rCol-1, rRow, nTab, bSelectLocked, 
bSelectUnlocked))
-break;
---rCol;
-}
+if (!isCellQualified(pDoc, rCol-1, rRow, nTab, bSelectLocked, 
bSelectUnlocked))
+break;
+--rCol;
 }
 }
 
 if (nMovY  0)
 {
-if (rRow  MAXROW)
+for (SCROW i = 0; i  nMovY  rRow  MAXROW; ++i)
 {
-for (SCROW i = 0; i  nMovY; ++i)
-{
-if (!isCellQualified(pDoc, rCol, rRow+1, nTab, bSelectLocked, 
bSelectUnlocked))
-break;
-++rRow;
-}
+if (!isCellQualified(pDoc, rCol, rRow+1, nTab, bSelectLocked, 
bSelectUnlocked))
+break;
+++rRow;
 }
 }
 else if (nMovY  0)
 {
-if (rRow  0)
+for (SCROW i = 0; i  nMovY  rRow  0; --i)
 {
-nMovY = -nMovY;
-for (SCROW i = 0; i  nMovY; ++i)
-{
-if (!isCellQualified(pDoc, rCol, rRow-1, nTab, bSelectLocked, 
bSelectUnlocked))
-break;
---rRow;
-}
+if (!isCellQualified(pDoc, rCol, rRow-1, nTab, bSelectLocked, 
bSelectUnlocked))
+break;
+--rRow;
 }
 }
 }


pgpfYYn7dOM16.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Remove --server mode from build.pl

[Jordan Ayers]

Dropping the --server switch and supporting code, as part of
fdo#39747.  I didn't see any problems running autogen / make / make
dev-install after this.  (Ubuntu 11.04 build env.)

There were some other dead function in there from before, but I'll
send a separate patch since they were unrelated to the --server
switch.

LGPLv3+/MPL

Jordan Ayers
From 5626f1468f646d118d51b8c3ac1f6bfb1e2a2b35 Mon Sep 17 00:00:00 2001
From: Jordan Ayers jordan.ay...@gmail.com
Date: Wed, 10 Aug 2011 08:17:55 -0500
Subject: [PATCH] Remove --server mode and supporting code from build.pl.

---
 bootstrap.1|2 -
 set_soenv.in   |4 +-
 solenv/bin/build.pl|  290 +-
 solenv/bin/build_client.pl |  436 
 4 files changed, 6 insertions(+), 726 deletions(-)
 delete mode 100755 solenv/bin/build_client.pl

diff --git a/bootstrap.1 b/bootstrap.1
index 069b995..19a9d1e 100755
--- a/bootstrap.1
+++ b/bootstrap.1
@@ -11,7 +11,6 @@ fi
 unalias mkout
 unalias deliver
 unalias build
-unalias build_client
 unalias zipdep
 
 # executables are *.exe for WNT. This variable is necessary since Cygwin 1.5.x
@@ -71,7 +70,6 @@ fi
 #make sure build.pl is executable 
 
 chmod +x $SRC_ROOT/solenv/bin/build.pl
-chmod +x $SRC_ROOT/solenv/bin/build_client.pl
 chmod +x $SRC_ROOT/solenv/bin/zipdep.pl
 chmod +x $SRC_ROOT/solenv/bin/gccinstlib.pl
 
diff --git a/set_soenv.in b/set_soenv.in
index 729241c..1a9539d 100755
--- a/set_soenv.in
+++ b/set_soenv.in
@@ -89,7 +89,7 @@ my ( $oldPATH, $SRC_ROOT, $SO_HOME, $JAVA_HOME, $JDK, $JAVAFLAGS, $OOO_SHELL,
 # IId. Declaring the aliases.
 #---
 #
-my ( $dmake, $build, $build_client, $mkout, $deliver, $zipdep );
+my ( $dmake, $build, $mkout, $deliver, $zipdep );
 #
 
 #-
@@ -1455,7 +1455,6 @@ else
 	$mkout   = 'perl $SOLARENV/bin/mkout.pl';
 	$deliver = 'perl $SOLARENV/bin/deliver.pl';
 	$build   = 'perl $SOLARENV/bin/build.pl';
-	$build_client= 'perl $SOLARENV/bin/build_client.pl';
 	$zipdep  = 'perl $SOLARENV/bin/zipdep.pl';
 
 #
@@ -2106,7 +2105,6 @@ ToFile( Don't set aliases when bootstrapping, $empty, c );
 ToFile( alias mkout,   $mkout, a );
 ToFile( alias deliver, $deliver,   a );
 ToFile( alias build,   $build, a );
-ToFile( alias build_client,$build_client,  a );
 ToFile( alias zipdep,  $zipdep,a );
 
 # on Solaris, MacOSX and FreeBSD, set GNUCOPY and GNUPATCH
diff --git a/solenv/bin/build.pl b/solenv/bin/build.pl
index cc53a5d..fdf316b 100755
--- a/solenv/bin/build.pl
+++ b/solenv/bin/build.pl
@@ -159,20 +159,12 @@
 my $stop_build_on_error = 0; # for multiprocessing mode: do not build further module if there is an error
 my $interactive = 0; # for interactive mode... (for testing purpose enabled by default)
 my $parent_process = 1;
-my $server_mode = 0;
-my $setenv_string = ''; # string for configuration of the client environment
-my $ports_string = ''; # string with possible ports for server
 my @server_ports = ();
 my $html_port = 0;
-my $server_socket_obj = undef; # socket object for server
 my $html_socket_obj = undef; # socket object for server
-my %clients_jobs = ();
-my %clients_times = ();
 my $client_timeout = 0; # time for client to build (in sec)...
 # The longest time period after that
 # the server considered as an error/client crash
-my %lost_client_jobs = (); # hash containing lost jobs
-my %job_jobdir = (); # hash containing job-dir pairs
 my $reschedule_queue = 0;
 my %module_build_queue = ();
 my %reversed_dependencies = ();
@@ -688,9 +680,6 @@ sub build_all {
 build_multiprocessing();
 return;
 };
-if ($server_mode) {
-run_server();
-};
 while ($prj = pick_prj_to_build(\%global_deps_hash)) {
 if (!defined $dead_parents{$prj}) {
 if (scalar keys %broken_build) {
@@ -719,11 +708,7 @@ sub build_all {
 my $info_hash = $html_info{$initial_module};
 $$info_hash{DIRS} = check_deps_hash(\%local_deps_hash, $initial_module);
 $module_by_hash{\%local_deps_hash} = $initial_module;
-if ($server_mode) {
-run_server();
-} else {
-build_dependent(\%local_deps_hash);
-};
+build_dependent(\%local_deps_hash);
 };
 };
 
@@ -1283,7 +1268,7 @@ sub find_indep_prj {
 $all_dependent = 1;
 handle_dead_children(0) if ($processes_to_run);
 my $children = children_number();
-return '' if (!$server_mode  $children  ($children = $processes_to_run));
+return '' if ($children  ($children = $processes_to_run));
 $dependencies = shift;
 if (scalar keys %$dependencies) {
 

Re: [Libreoffice] [PATCH][PUSHED] Remove --server mode from build.pl

[Norbert Thiebaud]

On Wed, Aug 10, 2011 at 8:04 PM, Jordan Ayers jordan.ay...@gmail.com wrote:
    Dropping the --server switch and supporting code, as part of
 fdo#39747.  I didn't see any problems running autogen / make / make
 dev-install after this.  (Ubuntu 11.04 build env.)

    There were some other dead function in there from before, but I'll
 send a separate patch since they were unrelated to the --server
 switch.

Nice,

I have applied it, with some conflict resolutions since the patch was
conflicting with another patch I pushed earlier...

Thanks

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] fix xml2cmp build with svn gcc

[Norbert Thiebaud]

On Wed, Aug 10, 2011 at 11:20 AM, Tom Tromey tro...@redhat.com wrote:
 I tried building LibreOffice with svn trunk gcc.

 It dies in xml2cmp with:

 Compiling: xml2cmp/source/xcd/xmlelem.cxx
 In file included from ./xmlelem.hxx:38:0,
                 from 
 /home/tromey/Space/LibreOffice/bootstrap/clone/ure/xml2cmp/source/xcd/xmlelem.cxx:30:
 ./../support/list.hxx: In instantiation of 'void 
 DynamicListXY::insert(unsigned int, XY* const) [with XY = XmlElement]':
 /home/tromey/Space/LibreOffice/bootstrap/clone/ure/xml2cmp/source/xcd/xmlelem.cxx:263:1:
    required from here
 ./../support/list.hxx:229:5: error: 'checkSize' was not declared in this 
 scope, and no declarations were found by argument-dependent lookup at the 
 point of instantiation [-fpermissive]
 ./../support/list.hxx:229:5: note: declarations in dependent base 
 'ListXmlElement*' are not found by unqualified lookup
 ./../support/list.hxx:229:5: note: use 'this-checkSize' instead
 dmake:  Error code 1, while making '../../unxlngx6.pro/obj/xmlelem.obj'


 The appended patch fixes this problem by adding a 'this-' qualifier.

Two remarks

1/ Are we sure that this behavior will be seen in a _released_ gcc ?
(not a rhetorical question, I'm a bit weary of chasing gcc trunk that
closely)

2/ I am not well equipped to apply in-lined patch like that (I use
gmail as main mailbox for this dev-list... so it is cut-and-paste with
horror stories about line wrapping and all)
could you use git format-patch to generate patches and attach them
(git format-patch as the added benefit that I don't have to type
--author=Your Name you@email -m a nice commit message that _I_
would have to come up with but instead cat your_git_formated_patch
| git am

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use By property

[Kohei Yoshida]

Hi Eike,

On Thu, 2011-08-11 at 02:18 +0200, Eike Rathke wrote:

 Well, here's what I would do instead ;-)

Aha!  Indeed that's the cleanest way to fix this. :-)

I took the liberty to push your patch to the 3-3 and 3-4 branches with
my sign-off.  I'll push to master once my master build finishes there.

Thanks a lot,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

[Josh Heidenreich]

Hi All,

I have made some additional changes to the dialog. I am considering
these changes stage 1 of the process.

Screenshot:
http://thejosh.info/libreoffice/export_format_v2.png

I have attached a patch also.

Josh
From 8cea17536d1be944db3e74711e2e0d92594a2d43 Mon Sep 17 00:00:00 2001
From: Josh Heidenreich josh.sickm...@gmail.com
Date: Thu, 11 Aug 2011 12:25:48 +0930
Subject: [PATCH] Changed the alien save dialog to contain the format name on the button

This is stage one of a number of changes to improve this dialog.
---
 sfx2/source/dialog/alienwarn.cxx |7 ++-
 sfx2/source/dialog/alienwarn.hrc |2 +-
 sfx2/source/dialog/alienwarn.src |6 +++---
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/sfx2/source/dialog/alienwarn.cxx b/sfx2/source/dialog/alienwarn.cxx
index 6e2dd84..c9e95bd 100644
--- a/sfx2/source/dialog/alienwarn.cxx
+++ b/sfx2/source/dialog/alienwarn.cxx
@@ -59,11 +59,16 @@ SfxAlienWarningDialog::SfxAlienWarningDialog( Window* pParent, const String _rF
 // set questionmark image
 m_aQueryImage.SetImage( QueryBox::GetStandardImage() );
 
-// replace formatname
+// replace formatname (text)
 String sInfoText = m_aInfoText.GetText();
 sInfoText.SearchAndReplaceAll( DEFINE_CONST_UNICODE(%FORMATNAME), _rFormatName );
 m_aInfoText.SetText( sInfoText );
 
+// replace formatname (button)
+sInfoText = m_aKeepCurrentBtn.GetText();
+sInfoText.SearchAndReplaceAll( DEFINE_CONST_UNICODE(%FORMATNAME), _rFormatName );
+m_aKeepCurrentBtn.SetText( sInfoText );
+
 // load value of warning on checkbox from save options
 m_aWarningOnBox.Check( SvtSaveOptions().IsWarnAlienFormat() == sal_True );
 
diff --git a/sfx2/source/dialog/alienwarn.hrc b/sfx2/source/dialog/alienwarn.hrc
index e3a23dc..9183daf 100755
--- a/sfx2/source/dialog/alienwarn.hrc
+++ b/sfx2/source/dialog/alienwarn.hrc
@@ -42,7 +42,7 @@
 // - general metrics -
 
 #define SYMBOL_EDGE 20
-#define DIALOG_WIDTH220
+#define DIALOG_WIDTH270
 #define INFO_TEXT_LINES 11
 
 #define AW_COL_1(RSC_SP_DLG_INNERBORDER_LEFT)
diff --git a/sfx2/source/dialog/alienwarn.src b/sfx2/source/dialog/alienwarn.src
index ae07b28..f4f77b4 100644
--- a/sfx2/source/dialog/alienwarn.src
+++ b/sfx2/source/dialog/alienwarn.src
@@ -52,20 +52,20 @@ ModalDialog RID_DLG_ALIEN_WARNING
 NoLabel = TRUE;
 Wordbreak = TRUE;
 Text [ en-US-old ] = This document may contain formatting or content that cannot be saved in the %FORMATNAME file format. Do you want to save the document in this format anyway?\n\n- Click 'Yes' to save in %FORMATNAME file format.\n- Click 'No' to use the latest OpenDocument file format and be sure all formatting and content is saved correctly.;
-Text [ en-US ] = This document may contain formatting or content that cannot be saved in the %FORMATNAME file format. Do you want to save the document in this format anyway?\n\nUse the latest ODF file format and be sure all formatting and content is saved correctly.;
+Text [ en-US ] = This document may contain formatting or content that cannot be saved in the currently selected file format \%FORMATNAME\.\n\nUse the default ODF file format to be sure that the document is saved correctly.;
 };
 OKButton PB_NO
 {
 Pos = MAP_APPFONT( AW_COL_2, AW_ROW_2 );
 Size = MAP_APPFONT( RSC_CD_PUSHBUTTON_WIDTH, RSC_CD_PUSHBUTTON_HEIGHT );
 DefButton = TRUE ;
-Text [ en-US ] = ~Keep Current Format;
+Text [ en-US ] = ~Use %FORMATNAME Format;
 };
 CancelButton PB_YES
 {
 Pos = MAP_APPFONT( AW_COL_3, AW_ROW_2 );
 Size = MAP_APPFONT( RSC_CD_PUSHBUTTON_WIDTH, RSC_CD_PUSHBUTTON_HEIGHT );
-Text [ en-US ] = ~Save in ODF Format;
+Text [ en-US ] = Use Default ~ODF Format;
 };
 HelpButton PB_MOREINFO
 {
-- 
1.7.0.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use By property

[Kohei Yoshida]

On Wed, 2011-08-10 at 22:07 -0400, Kohei Yoshida wrote:
 I'll push to master once my master build finishes there.

Now pushed to master as well.

-- 
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice