Re: [Libreoffice] [Libreoffice-commits] .: i18npool/inc i18npool/Library_localedata_euro.mk i18npool/source svtools/source
Hi Eike, Thanks for the explanation and the correction. I misinterpreted the meaning. Best regards, Juan Pablo El 06/09/2011 2:22, Eike Rathke escribió: Hi Juan, On Monday, 2011-09-05 23:03:04 +0200, Juan Pablo Martínez Cortés wrote: Yes, they were intentional. At least, I copied the way it was done in other languages of Spain, see for instance http://www.it46.se/localegen/locale/1207308973_es_ES.xml . The generated data files are not always a reference, they are not reviewed and seldomly updated with corrected versions. For what's available in LibO see http://cgit.freedesktop.org/libreoffice/core/tree/i18npool/source/localedata/data/es_ES.xml I guess the reason of changing the type is that in Spanish, as well as in other languages of Spain, the double quotation marks “ ” are the most widely used, and the single ones ‘ ’ are much less used. That's a misconception. Quotation(Start|End) define single quotes, DoubleQuotation(Start|End) define double quotes. They are used in replacements for ' and when activated under Tools - AutoCorrect Options - Localized Options The es_ES.xml also defines Time100SecSeparator identical to DecimalSeparator ',' comma. I'll change that accordingly for an_ES. Eike ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] cannot build with ATL, cannot build without
Hi Regina I'm using Visual Studio 2008 Express Edition and my configure parameters are: $ ./configure --without-junit --with-ant-home=/cygdrive/c/Components/apache-ant-1.8.0/ --disable-mozilla --disable-activex-component Thanks, Noel. Regina Henschel wrote: Hi Noel, Noel Grandin schrieb: Hi I'm trying to build LibreOffice on Windows7. Which Visual Studio do you use? At the moment, I'm stuck on an ATL problem. I've tried disabling atl (--disable-atl), but that doesn't help because stuff in /extensions/source/ole still tries to include atlbase.h I've tried using the Windows Server 2003 R2 SDK, but then I get an error from configure about a legacy SDK. Please post all of your parameters for autogen. Kind regards Regina Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Autogen.sh demands Mozilla build tooling although building Mozilla is disabled
Hi Norbert Could you update the wiki http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies with the new location of the mozilla prebuilt binaries? Thanks, Noel Grandin Norbert Thiebaud wrote: On Mon, Sep 5, 2011 at 5:16 PM, Regina Henschel rb.hensc...@t-online.de wrote: Hi Norbert, Norbert Thiebaud schrieb: On Mon, Sep 5, 2011 at 4:48 PM, Regina Henschelrb.hensc...@t-online.de wrote: Hi all, I then follow http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies and load the zips from http://tools.openoffice.org/moz_prebuild/OOo3.2 (shouldn't the binaries copied to another place. OpenOffice.org services can vanish at any time.) they are here: http://dev-www.libreoffice.org/mozilla/ No, there is only Linux and Mac but not Windows. They are there now :-) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Autogen.sh demands Mozilla build tooling although building Mozilla is disabled
Hi, What about to provide the link in configure? Or even better to do the download process automatically. May I put it to the master? KAMI On 09/06/2011 09:11 AM, Noel Grandin wrote: Hi Norbert Could you update the wiki http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies with the new location of the mozilla prebuilt binaries? Thanks, Noel Grandin Norbert Thiebaud wrote: On Mon, Sep 5, 2011 at 5:16 PM, Regina Henschelrb.hensc...@t-online.de wrote: Hi Norbert, Norbert Thiebaud schrieb: On Mon, Sep 5, 2011 at 4:48 PM, Regina Henschelrb.hensc...@t-online.de wrote: Hi all, I then follow http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies and load the zips fromhttp://tools.openoffice.org/moz_prebuild/OOo3.2 (shouldn't the binaries copied to another place. OpenOffice.org services can vanish at any time.) they are here: http://dev-www.libreoffice.org/mozilla/ No, there is only Linux and Mac but not Windows. They are there now :-) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Watch out for 64 bit errors
Hi everyone, I saw this article in a security mailing list, and I thought it was relevant for all the LO devs too, as our code needs to work both on 32 and 64 bits :) http://software.intel.com/en-us/articles/collection-of-examples-of-64-bit-errors-in-real-programs/ Sadly, the code samples are for Windoze, but I see a lot of tricky things to keep in mind. Regards, -- Marc-André Laverdière Software Security Scientist Innovation Labs, Tata Consultancy Services Hyderabad, India ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Honor --disable-strip in gbuild.
Unlike the old dmake build system, solenv/gbuild/platform/unxgcc.mk sets -Wl,--strip-all depending on --enable-symbols only, and ignores --disable-strip altogether. Attached patch fixes that. (To avoid confusion: I recently switched my git email address, but my contributions are still under the license documented at http://lists.freedesktop.org/archives/libreoffice/2011-August/017383.html.) -Stephan From 5b1199602807152777b149cc3c30105c2064baa5 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann sberg...@redhat.com Date: Tue, 6 Sep 2011 09:39:07 +0200 Subject: [PATCH] Honor --disable-strip in gbuild. --- solenv/gbuild/gbuild.mk |6 ++ solenv/gbuild/platform/unxgcc.mk |8 +--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk index 48bebeb..329eefa 100644 --- a/solenv/gbuild/gbuild.mk +++ b/solenv/gbuild/gbuild.mk @@ -87,6 +87,12 @@ else gb_SYMBOL := $(false) endif +ifeq ($(strip $(DISABLE_STRIP)$(disable_strip)),) +gb_STRIP := $(true) +else +gb_STRIP := $(false) +endif + gb_DEBUGLEVEL := 0 ifneq ($(strip $(DEBUG)$(debug)),) gb_DEBUGLEVEL := 1 diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk index 4234c71..5c71bd4 100644 --- a/solenv/gbuild/platform/unxgcc.mk +++ b/solenv/gbuild/platform/unxgcc.mk @@ -163,9 +163,11 @@ gb_LinkTarget_LDFLAGS += \ endif ifneq ($(gb_SYMBOL),$(true)) -gb_LinkTarget_LDFLAGS += \ - -Wl,--strip-all \ - +ifeq ($(gb_STRIP),$(true)) +gb_LinkTarget_LDFLAGS += -Wl,--strip-all +else +gb_LinkTarget_LDFLAGS += -Wl,--strip-debug +endif endif ifneq ($(gb_DEBUGLEVEL),0) -- 1.7.6 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Honor --disable-strip in gbuild.
On Tue, Sep 6, 2011 at 2:51 AM, Stephan Bergmann sberg...@redhat.com wrote: Unlike the old dmake build system, solenv/gbuild/platform/unxgcc.mk sets -Wl,--strip-all depending on --enable-symbols only, and ignores --disable-strip altogether. Attached patch fixes that. doesn't that also apply to macosx.mk ? Norbert (To avoid confusion: I recently switched my git email address, but my contributions are still under the license documented at http://lists.freedesktop.org/archives/libreoffice/2011-August/017383.html.) congrat on the new email address :-) -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Fwd: [PATCH] Honor --disable-strip in gbuild.
Damn the gmail interface! I demand reply-to-list :) @Stephan: sorry for doublemail :) -- Přeposlaná zpráva -- Od: Tomáš Chvátal tomas.chva...@gmail.com Datum: 6. září 2011 10:00 Předmět: Re: [Libreoffice] [PATCH] Honor --disable-strip in gbuild. Komu: Stephan Bergmann sberg...@redhat.com Nice, I was planning to look to this later as it poped QA warning on Gentoo :) Signed-off: tchva...@novell.com :) Also please backport it to 3.4 branch. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Länkerbjudande
Hej, Lt mig presentera mig sjlv, mitt namn r Peter Karlsson och jag arbetar som SEO manager. I samband ett uppdrag fr en av mina kunder fann jag http://www.libreoffice.org/ och jag vill drfr bertta lite om vad jag kan erbjuda dig. I min portfolio har jag mnga hemsidor som p daglig basis fr personlig tillsyn och som matchar http://www.libreoffice.org/ betrffande mne och kvalitet. Jag vill att bde din sida och min kunds hemsida skall f mer trafik, synlighet och bli hgre rankad i skmotorerna. Om du r intresserad och vill ha mer information om mitt erbjudande skickar jag dig gladeligen alla ndvndig detaljer. Jag ser fram emot ditt svar. Peter Karlsson pe...@websidahjalp.com websidahjalp.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Honor --disable-strip in gbuild.
On 09/06/2011 09:58 AM, Norbert Thiebaud wrote: On Tue, Sep 6, 2011 at 2:51 AM, Stephan Bergmannsberg...@redhat.com wrote: Unlike the old dmake build system, solenv/gbuild/platform/unxgcc.mk sets -Wl,--strip-all depending on --enable-symbols only, and ignores --disable-strip altogether. Attached patch fixes that. doesn't that also apply to macosx.mk ? Only if gbuild would strip on Mac OS X (which it does not, and which is another issue). -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||39313 --- Comment #8 from Petr Mladek pmla...@suse.cz 2011-09-06 01:15:56 PDT --- (In reply to comment #7) nominate Bug 39313 - XTableRows.removeByIndex and also symply remove Row / Column crashes Libo It is a core function = accepted -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] cannot build with ATL, cannot build without
On Tue, 2011-09-06 at 08:51 +0200, Noel Grandin wrote: Hi Regina I'm using Visual Studio 2008 Express Edition and my configure parameters are: $ ./configure --without-junit --with-ant-home=/cygdrive/c/Components/apache-ant-1.8.0/ --disable-mozilla --disable-activex-component Firstly, perhaps you need --disable-activex and not --disable-activex-component when building with vc2008 You said in some other mail that you had --disable-atl as well but also a build error in extensions/source/ole if you look at extensions/source/ole/makefile.mk it has... .IF $(GUI) == WNT $(DISABLE_ATL)== stuff to build .ENDIF so lets see what your DISABLE_ATL env variable is, i.e. grep DISABLE_ATL ./Env.Host.sh should state DISABLE=ATL=TRUE if the --disable-atl flag to configure was set and worked as its supposed to C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument.
Found a regression from a recent Disable fake VBA events for the
old-style form controls commit that causes the forms/qa/unoapi check to
fail. Attached patch fixes it.
-Stephan
From 9bea29af5a3fd86031e28bb8b4ca3f445f3eca96 Mon Sep 17 00:00:00 2001
From: Stephan Bergmann sberg...@redhat.com
Date: Tue, 6 Sep 2011 10:58:50 +0200
Subject: [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for
null argument.
Regression introduced with 4fae740db79d4e7cc97440e2bab8d1ef612d9b51;
caused forms/qa/unoapi check to fail.
---
forms/source/misc/InterfaceContainer.cxx | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/forms/source/misc/InterfaceContainer.cxx
b/forms/source/misc/InterfaceContainer.cxx
index af24414..ff5b9c7 100644
--- a/forms/source/misc/InterfaceContainer.cxx
+++ b/forms/source/misc/InterfaceContainer.cxx
@@ -827,14 +827,6 @@ void OInterfaceContainer::implInsert(sal_Int32 _nIndex,
const Reference XProper
sal_Bool _bEvents, ElementDescription* _pApprovalResult, sal_Bool _bFire )
throw( IllegalArgumentException )
{
const bool bHandleEvents = _bEvents m_xEventAttacher.is();
-bool bHandleVbaEvents = false;
-try
-{
-_rxElement-getPropertyValue(rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(GenerateVbaEvents) ) ) = bHandleVbaEvents;
-}
-catch( const Exception )
-{
-}
// SYNCHRONIZED -
::osl::ClearableMutexGuard aGuard( m_rMutex );
@@ -890,6 +882,14 @@ void OInterfaceContainer::implInsert(sal_Int32 _nIndex,
const Reference XProper
// - SYNCHRONIZED
// insert faked VBA events?
+bool bHandleVbaEvents = false;
+try
+{
+_rxElement-getPropertyValue(rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(GenerateVbaEvents) ) ) = bHandleVbaEvents;
+}
+catch( const Exception )
+{
+}
if ( bHandleVbaEvents )
{
Reference XEventAttacherManager xMgr (
pElementMetaData-xInterface, UNO_QUERY );
--
1.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] planned DOWNTIME of e-mail, mailing lists, downloads, rsync, wiki, QAtrack and planet
Hello, as the LibreOffice project grows, we have to add some extra hardware to cope with the number of downloads and website access. ;-) In order to add two SSD disks for improving mirroring speed to one of our server, there will be a planned DOWNTIME today, September 6th, at 1900 UTC for about 15-20 minutes This will affect our e-mail, mailing lists, downloads, rsync, wiki, QAtrack and the planet. All other services like the web sites or the help wiki will not be affected. Thanks for your understanding, and sorry for any inconvenience this may cause, Florian -- Florian Effenberger flo...@documentfoundation.org Steering Committee and Founding Member of The Document Foundation Tel: +49 8341 99660880 | Mobile: +49 151 14424108 Skype: floeff | Twitter/Identi.ca: @floeff ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED][PATCH] Honor --disable-strip in gbuild.
On Tue, 2011-09-06 at 09:51 +0200, Stephan Bergmann wrote: Unlike the old dmake build system, solenv/gbuild/platform/unxgcc.mk sets -Wl,--strip-all depending on --enable-symbols only, and ignores --disable-strip altogether. Attached patch fixes that. Pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] cannot build with ATL, cannot build without
Hi Caolán Thanks, that was the magic sauce. My new configure command line is $ ./configure --without-junit --with-ant-home=/cygdrive/c/Components/apache-ant-1.8.0/ --disable-mozilla --disable-activex --disable-atl And the build is now making it's way past the extensions folder. Could someone perhaps update the http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies wiki page? Thanks for all the help, this is a great team! Regards, Noel Grandin Caolán McNamara wrote: On Tue, 2011-09-06 at 08:51 +0200, Noel Grandin wrote: Hi Regina I'm using Visual Studio 2008 Express Edition and my configure parameters are: $ ./configure --without-junit --with-ant-home=/cygdrive/c/Components/apache-ant-1.8.0/ --disable-mozilla --disable-activex-component Firstly, perhaps you need --disable-activex and not --disable-activex-component when building with vc2008 You said in some other mail that you had --disable-atl as well but also a build error in extensions/source/ole if you look at extensions/source/ole/makefile.mk it has... .IF $(GUI) == WNT $(DISABLE_ATL)== stuff to build .ENDIF so lets see what your DISABLE_ATL env variable is, i.e. grep DISABLE_ATL ./Env.Host.sh should state DISABLE=ATL=TRUE if the --disable-atl flag to configure was set and worked as its supposed to C. Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument.
On Tue, 2011-09-06 at 11:07 +0200, Stephan Bergmann wrote: Found a regression from a recent Disable fake VBA events for the old-style form controls commit that causes the forms/qa/unoapi check to fail. Attached patch fixes it. pushed, this is part of getting the subsequent tests working again, right ? I think Bjoern might have a list of bugs for those somewhere FWIW. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED][PATCH] cppcheck scope
On Thu, 2011-09-01 at 23:28 +0200, Kenneth Venken wrote: This patch should fix the cppcheck style warnings for grfmgr.cxx: Pushed, thanks for this. C. (p.s. clarified off-list LGPLv3+/MPLv1.1) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument.
On Tue, 06 Sep 2011 11:00:26 +0100 Caolán McNamara caol...@redhat.com wrote: On Tue, 2011-09-06 at 11:07 +0200, Stephan Bergmann wrote: Found a regression from a recent Disable fake VBA events for the old-style form controls commit that causes the forms/qa/unoapi check to fail. Attached patch fixes it. pushed, this is part of getting the subsequent tests working again, right ? I think Bjoern might have a list of bugs for those somewhere FWIW. Yes, there is: https://bugs.freedesktop.org/buglist.cgi?status_whiteboard_type=anywordssubstrquery_format=advancedstatus_whiteboard=unoapitest%20complextestbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENED (whiteboard keywords: unoapitest, complextest) all should be blocking: https://bugs.freedesktop.org/show_bug.cgi?id=35690 Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument.
Hi Stephan, On 06/09/11 10:07, Stephan Bergmann wrote: Found a regression from a recent Disable fake VBA events for the old-style form controls commit that causes the forms/qa/unoapi check to fail. Attached patch fixes it. -Stephan thanks for fixing, ( I see Caolán pushed ) btw what exactly was null /me just doesn't see where/why moving the getPropertyValue makes a difference. thanks for cc'ing me 'cause at the moment due to some problems I don't understand it appears I am not getting any libreoffice-dev mails at all :-/ Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument.
On 09/06/2011 12:25 PM, Noel Power wrote: Hi Stephan, On 06/09/11 10:07, Stephan Bergmann wrote: Found a regression from a recent Disable fake VBA events for the old-style form controls commit that causes the forms/qa/unoapi check to fail. Attached patch fixes it. -Stephan thanks for fixing, ( I see Caolán pushed ) btw what exactly was null /me just doesn't see where/why moving the getPropertyValue makes a difference. The unoapi tests call insertByIndex with a null interface, approveNewElement called from OInterfaceContainer::implInsert checks for null and throws an exception, but your modification accessed _rxElement before it got passed to approveNewElement. -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] python is now also required for windows build
Hi I note that filters/source/svg runs a python script, which means that python needs to be installed from cygwin in order to do a build on windows. http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies should probably be updated. Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] python is now also required for windows build
On Tue, 2011-09-06 at 13:22 +0200, Noel Grandin wrote: Hi I note that filters/source/svg runs a python script, which means that python needs to be installed from cygwin in order to do a build on windows. I hacked it earlier to use our internal python on windows, should work again out-of-the-box. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2
Hi
Wonderful, great stuff - I have to apologize, the many whitespace
changes in the calc part of the patch are because of my substandard
mentoring - cleaned-up version of the first patch attached.
I was in the belief that we shall use spaces instead of tabs.
Corrected patches attached.
--
RN
From 9536eed6be175243f9e55f5715d1fb784a6f5f4f Mon Sep 17 00:00:00 2001
From: Wolfgang Pechlaner l...@pechlaner.at
Date: Sun, 4 Sep 2011 14:40:25 +0200
Subject: [PATCH] BITxxx functions for ODF 1.2
---
sc/inc/helpids.h |5 +
sc/qa/unit/ucalc.cxx |5 +
sc/source/core/inc/interpre.hxx |5 +
sc/source/core/tool/interpr1.cxx | 101
sc/source/core/tool/interpr4.cxx |5 +
sc/source/ui/src/scfuncs.src | 156 ++
sc/util/hidother.src |5 +
7 files changed, 282 insertions(+), 0 deletions(-)
diff --git a/sc/inc/helpids.h b/sc/inc/helpids.h
index c80dd1b..b04aa77 100644
--- a/sc/inc/helpids.h
+++ b/sc/inc/helpids.h
@@ -692,3 +692,8 @@
#define HID_FUNC_UNICODESC_HID_FUNC_UNICODE
#define HID_FUNC_UNICHARSC_HID_FUNC_UNICHAR
#define HID_FUNC_NUMBERVALUESC_HID_FUNC_NUMBERVALUE
+#define HID_FUNC_BITAND SC_HID_FUNC_BITAND
+#define HID_FUNC_BITOR SC_HID_FUNC_BITOR
+#define HID_FUNC_BITXOR SC_HID_FUNC_BITXOR
+#define HID_FUNC_BITLSHIFT SC_HID_FUNC_BITLSHIFT
+#define HID_FUNC_BITRSHIFT SC_HID_FUNC_BITRSHIFT
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 7430a60..533fbe2 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -1742,6 +1742,11 @@ void Test::testFunctionLists()
const char* aLogical[] = {
AND,
+BITAND,
+BITLSHIFT,
+BITOR,
+BITRSHIFT,
+BITXOR,
FALSE,
IF,
NOT,
diff --git a/sc/source/core/inc/interpre.hxx b/sc/source/core/inc/interpre.hxx
index 27027d5..50881d6 100644
--- a/sc/source/core/inc/interpre.hxx
+++ b/sc/source/core/inc/interpre.hxx
@@ -412,6 +412,11 @@ void ScAnd();
void ScOr();
void ScNot();
void ScNeg();
+void ScBitAnd();
+void ScBitOr();
+void ScBitXor();
+void ScBitRshift();
+void ScBitLshift();
void ScPercentSign();
void ScIntersect();
void ScRangeFunc();
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index f581ac7..3921e0e 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -1391,6 +1391,107 @@ void ScInterpreter::ScNeg()
}
+void ScInterpreter::ScBitAnd()
+{
+RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, sc, er, ScInterpreter::ScBitAnd );
+
+if ( !MustHaveParamCount( GetByte(), 2 ) )
+ return;
+
+ double num1, num2;
+ num1 = GetDouble();
+ num2 = GetDouble();
+ if ((num1 281474976710655) or (num1 0) or
+ (num2 281474976710655) or (num2 0)) {
+PushIllegalArgument();
+ }
+
+ PushDouble ((sal_uInt64) num1 (sal_uInt64) num2);
+}
+
+
+void ScInterpreter::ScBitOr()
+{
+RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, sc, er, ScInterpreter::ScBitOr );
+
+ if ( !MustHaveParamCount( GetByte(), 2 ) )
+ return;
+
+double num1, num2;
+num1 = GetDouble();
+num2 = GetDouble();
+if ((num1 281474976710655) or (num1 0) or
+(num2 281474976710655) or (num2 0)) {
+ PushIllegalArgument();
+}
+
+PushDouble ((sal_uInt64) num1 | (sal_uInt64) num2);
+}
+
+
+void ScInterpreter::ScBitXor()
+{
+RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, sc, er, ScInterpreter::ScBitXor );
+
+if ( !MustHaveParamCount( GetByte(), 2 ) )
+ return;
+
+double num1, num2;
+num1 = GetDouble();
+num2 = GetDouble();
+if ((num1 281474976710655) or (num1 0) or
+(num2 281474976710655) or (num2 0)) {
+ PushIllegalArgument();
+}
+
+PushDouble ((sal_uInt64) num1 ^ (sal_uInt64) num2);
+}
+
+
+void ScInterpreter::ScBitLshift()
+{
+RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, sc, er, ScInterpreter::ScBitLshift );
+
+if ( !MustHaveParamCount( GetByte(), 2 ) )
+ return;
+
+sal_uInt64 erg;
+sal_Int32 ishift = GetDouble();
+double num = GetDouble();
+if ((num 281474976710655) or (num 0)) {
+PushIllegalArgument();
+}
+if (ishift 0) {
+ erg = (sal_uInt64) num -ishift;
+} else {
+ erg = (sal_uInt64) num ishift;
+}
+PushDouble (erg);
+}
+
+void ScInterpreter::ScBitRshift()
+{
+RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, sc, er, ScInterpreter::ScBitRshift );
+
+if ( !MustHaveParamCount( GetByte(), 2 ) )
+ return;
+sal_uInt64 erg;
+sal_Int32 ishift = GetDouble();
+double num = GetDouble();
+if ((num 281474976710655)
Re: [Libreoffice] python is now also required for windows build
Thanks, build progressing again. --- Noel Grandin Caolán McNamara wrote: On Tue, 2011-09-06 at 13:22 +0200, Noel Grandin wrote: Hi I note that filters/source/svg runs a python script, which means that python needs to be installed from cygwin in order to do a build on windows. I hacked it earlier to use our internal python on windows, should work again out-of-the-box. C. Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 32861, which changed state. Bug 32861 Summary: Impress hangs part way through slide show https://bugs.freedesktop.org/show_bug.cgi?id=32861 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW-3-4] Fix for hang in slideshow
Hi, could someone please review cherry-pick for 3-4 this fix: http://cgit.freedesktop.org/libreoffice/core/commit/?id=044c534b2deb985052e7977bba3290c5d2c3ad77 Thanks, -- Thorsten pgp2s2bIebMGl.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on||40449 --- Comment #9 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-09-06 07:52:19 PDT --- Nominate Bug 40449 - SPELLCHECK does not recognize text language, WRITER without any spell check - unimaginable! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2
Hello all, On Tue, Sep 6, 2011 at 20:08, Niko Rönkkö niko.ron...@wippies.fi wrote: Hi Wonderful, great stuff - I have to apologize, the many whitespace changes in the calc part of the patch are because of my substandard mentoring - cleaned-up version of the first patch attached. I was in the belief that we shall use spaces instead of tabs. Corrected patches attached. And please s/interger/integer ;) Also, it seems that you haven't check the range of ishift yet, whether it is between -48 and 48 (from your description), or it isn't necessary? I don't have knowledge on this. My last nitpick, what about the strings capitalization? Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] python is now also required for windows build
Caolan McNamara wrote: I hacked it earlier to use our internal python on windows, should work again out-of-the-box. Not that having a working python would be a bad thing - though if that script is the only reason it's required, we should switch it to perl ... Cheers, -- Thorsten pgpH30SiDWPhb.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] SID_DOC_MODIFIED, booleans/strings/whatever it feels like
After much digging around, I've come to the conclusion that at some time in the past the SID_DOC_MODIFIED property could be basically anything, especially a string, e.g. * to indicate a modified doc. Then probably there was some clean up to give it a Boolean modified/unmodified state, with most things unified behind SvxModifyControl::RegisterControl There was one probably unconverted remnant in basctl where a String of * means modified and means unmodified. Which triggered a sad state of asserts and dodgy casts which I've now fixed. What remains is one non Boolean SID_DOC_MODIFIED in sw of SfxStringItem( SID_DOC_MODIFIED, ' ' ) I wonder if ' ' attempts to indicate a modified document, or an unmodified document ? I'm guessing a hold-over from a character-based interface where ' ' overwrites a '*' and it might indicate an unmodified document. It happens after a sw's Save, which would fit with that. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Patch for MarkManager
Hi Björn,
today I managed to improve the patch again. The patch now speeds up
our mailmerge-Szenario enormously and seems to eliminate the
exponential waste of cpu-cycles. Would you please have a look at it?
here some measurings:
MailMerge-Time (in ms) without patch for 10, 50, 100, 150 datasets:
2793, 11821, 28608, 64395
MailMerge-Time (in ms) with first patch for 10, 50, 100, 150 datasets:
2561, 11044, 26226, 55812
MailMerge-Time (in ms) with this patch for 10, 50, 100, 150 datasets:
1838, 7357, 14413, 21558
2011/9/6 Christoph Lutz chrl...@googlemail.com:
2011/9/5 Bjoern Michaelsen bjoern.michael...@gmail.com:
On Sun, 4 Sep 2011 15:05:32 +0200
Christoph Lutz chrlutz-gM/ye1e23mwn+bqq9rb...@public.gmane.org wrote:
this is a patch we wrote during the libreoffice hackfest 2011 for
sw/source/core/inc/MarkManager.hxx and sw/source/core/doc/docbm.cxx
which improves speed of mailmerge. Bjoern already knows details so he
might be the one to review the patch... The patch could be applied
under the lgpl.
Patch looks good, Just to clarify before pushing, is it contributed
under:
MPL 1.1 / GPLv3+ / LGPLv3+
as per http://wiki.documentfoundation.org/License_Policy ?
That's OK!
Best,
Christoph
diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx
index b88de10..8eb3dd0 100644
--- a/sw/source/core/doc/docbm.cxx
+++ b/sw/source/core/doc/docbm.cxx
@@ -386,6 +386,7 @@ namespace sw { namespace mark
pMarkBase-SetName(getUniqueMarkName(pMarkBase-GetName()));
// register mark
+m_aMarkNamesSet.insert(pMarkBase-GetName());
lcl_InsertMarkSorted(m_vMarks, pMark);
switch(eType)
{
@@ -480,8 +481,10 @@ namespace sw { namespace mark
- Mark is not in my doc.);
if(io_pMark-GetName() == rNewName)
return true;
-if(findMark(rNewName) != getMarksEnd())
+if(hasMark(rNewName))
return false;
+ m_aMarkNamesSet.erase(dynamic_cast ::sw::mark::MarkBase* (io_pMark)-GetName());
+ m_aMarkNamesSet.insert(rNewName);
dynamic_cast ::sw::mark::MarkBase* (io_pMark)-SetName(rNewName);
return true;
}
@@ -733,6 +736,7 @@ namespace sw { namespace mark
//it anymore.
pMark_t xHoldPastErase = *aI;
m_vMarks.erase(aI);
+m_aMarkNamesSet.erase(ppMark-get()-GetName());
}
void MarkManager::deleteMark(const IMark* const pMark)
@@ -766,6 +770,7 @@ namespace sw { namespace mark
{
m_vFieldmarks.clear();
m_vBookmarks.clear();
+m_aMarkNamesSet.clear();
#if OSL_DEBUG_LEVEL 1
for(iterator_t pBkmk = m_vMarks.begin();
pBkmk != m_vMarks.end();
@@ -827,14 +832,25 @@ namespace sw { namespace mark
OSL_ENSURE(rName.getLength(),
MarkManager::getUniqueMarkName(..)
- a name should be proposed);
-if(findMark(rName) == getMarksEnd()) return rName;
+if(!hasMark(rName)) return rName;
::rtl::OUStringBuffer sBuf;
::rtl::OUString sTmp;
-for(sal_Int32 nCnt = 1; nCnt SAL_MAX_INT32; nCnt++)
+
+// try the name rNameXXX (where XXX is a number starting from 1) unless there is
+// a unused name. Due to performance-reasons (especially in mailmerge-Szenarios) there
+// is a map m_aMarkBasenameMapUniqueOffset which holds the next possible offset (XXX) for
+// rName (so there is no need to test for nCnt-values smaller than the offset).
+sal_Int32 nCnt = 1;
+MarkBasenameMapUniqueOffset::iterator aIter = m_aMarkBasenameMapUniqueOffset.find(rName);
+if(aIter != m_aMarkBasenameMapUniqueOffset.end()) nCnt = aIter-second;
+while(nCnt SAL_MAX_INT32)
{
sTmp = sBuf.append(rName).append(nCnt).makeStringAndClear();
-if(findMark(sTmp) == getMarksEnd()) break;
+nCnt++;
+if(!hasMark(sTmp)) break;
}
+m_aMarkBasenameMapUniqueOffset[rName] = nCnt;
+
return sTmp;
}
@@ -845,6 +861,11 @@ namespace sw { namespace mark
sort(m_vFieldmarks.begin(), m_vFieldmarks.end(), lcl_MarkOrderingByStart);
}
+bool MarkManager::hasMark(const ::rtl::OUString rName) const
+{
+return (m_aMarkNamesSet.find(rName) != m_aMarkNamesSet.end());
+}
+
}} // namespace ::sw::mark
diff --git a/sw/source/core/inc/MarkManager.hxx b/sw/source/core/inc/MarkManager.hxx
index 415b8e7..be3a1f2 100644
--- a/sw/source/core/inc/MarkManager.hxx
+++ b/sw/source/core/inc/MarkManager.hxx
@@ -31,9 +31,14 @@
#include IMark.hxx
#include IDocumentMarkAccess.hxx
+#include boost/unordered_set.hpp
+#include boost/unordered_map.hpp
namespace sw { namespace mark
{
+
+typedef boost::unordered_maprtl::OUString, sal_Int32, rtl::OUStringHash MarkBasenameMapUniqueOffset;
+
class MarkManager
: private ::boost::noncopyable
, virtual public IDocumentMarkAccess
@@ -72,6 +77,7 @@ namespace sw {
Re: [Libreoffice] python is now also required for windows build
On Tue, 06 Sep 2011 16:54:13 +0200, Thorsten Behrens t...@documentfoundation.org wrote: Caolan McNamara wrote: I hacked it earlier to use our internal python on windows, should work again out-of-the-box. Not that having a working python would be a bad thing - though if that script is the only reason it's required, we should switch it to perl ... I agree from my side, I implemented it in Python because I have no Perl knowledge at all. Cheers, -- Marco -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] minutes of tech. steering call ...
Hi Cor, On Tue, 2011-09-06 at 07:16 +0200, Cor Nouws wrote: So thanks for putting this at the agenda. (But of course note that it is not stated fully correct.) As you have seen, I posted some overview on the subject to the list two days ago I didn't see that, any chance of a re-send; if you give enough details no doubt we can discuss it ourselves, though that is less satisfying of course. I'll be glad to join a talk about this. Only problem: needs to be somewhere: .. - For the weeks towards mid October about the same schedule. By mid-October we can meet at the LibreOffice conference perhaps ? :-) ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] map files: how to update? [was: cppu::OPropertySetHelper ABI backwards compatibility]
On Mon, Sep 05, 2011 at 09:57:30AM +0200, Stephan Bergmann wrote: - For the question of which symbols for OPropertySetHelper2 to list in the various map files, see http://udk.openoffice.org/common/man/apicppclasses.html (you probably need access to builds on the various platforms to find out the correct mangled names). gcc3.map in the latest patch (sent this morning): - Do not export the thunks (_ZThn), not needed externally. They are exported for just about every other class in that file; that is then also a historical error? -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Returned mail: see transcript for details
(#
¾´9ìÕ?m
b8¥£FÚWÝþàfÙêëE#Û·¨_§?65Çx¨TéU2jüdϧ~úðj(³5TcCgyÊGý¶qЩX
¸
â¶|l®6}¹øüZeöR%}ds
×Ë$âö
2âÎëâVv6³3´Ï%ºÝ½õ[g-ï4\-3Ù,®üp{-îAØh]ïYÓ;«Õü%Ư£¨¨zÕ`Èëü¬}NsLRm0§Ù5|é£ÂhÁæùïæýIýhJËÏ»i¢äKîn¼×Û*¦¨íÄ[¬Ð2fÚ*©·.*ãó¡Y¼Þ
M-59MS2»/cfÅn4g.áûûë
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] TF_POOLABLE in SfxItemPool
Hi there, While looking into SfxItemPool, trying to understand how this thing works, I've noticed that it has #ifdef TF_POOLABLE stuff all over the place. Is there any reason why we need to have this, or is it okay to just pick one variant and remove the other? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Patch for MarkManager
On Tue, 6 Sep 2011 17:36:18 +0200 Christoph Lutz chrl...@googlemail.com wrote: today I managed to improve the patch again. The patch now speeds up our mailmerge-Szenario enormously and seems to eliminate the exponential waste of cpu-cycles. Would you please have a look at it? here some measurings: MailMerge-Time (in ms) without patch for 10, 50, 100, 150 datasets: 2793, 11821, 28608, 64395 MailMerge-Time (in ms) with first patch for 10, 50, 100, 150 datasets: 2561, 11044, 26226, 55812 MailMerge-Time (in ms) with this patch for 10, 50, 100, 150 datasets: 1838, 7357, 14413, 21558 Wow, great win! Pushed as: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e024f616934bb78fba8c8101264806d507068d7e with some minor tuning: - formatting (whitespace mostly) - constness Could you maybe try, if a pragmatic: m_aMarkBasenameMapUniqueOffset.clear(); at: http://cgit.freedesktop.org/libreoffice/core/tree/sw/source/core/doc/docbm.cxx?id=e024f616934bb78fba8c8101264806d507068d7e#n491 and http://cgit.freedesktop.org/libreoffice/core/tree/sw/source/core/doc/docbm.cxx?id=e024f616934bb78fba8c8101264806d507068d7e#n743 kills the performance gain? If not, that would prevent the behavior change in for example the scenario: - Create Mark - Copy Mark - Copy Mark - Delete First Copied Mark - Copy Mark Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] map files: how to update? [was: cppu::OPropertySetHelper ABI backwards compatibility]
On 09/06/2011 06:39 PM, Lionel Elie Mamane wrote: On Mon, Sep 05, 2011 at 09:57:30AM +0200, Stephan Bergmann wrote: - For the question of which symbols for OPropertySetHelper2 to list in the various map files, see http://udk.openoffice.org/common/man/apicppclasses.html (you probably need access to builds on the various platforms to find out the correct mangled names). gcc3.map in the latest patch (sent this morning): - Do not export the thunks (_ZThn), not needed externally. They are exported for just about every other class in that file; that is then also a historical error? Noticed that too. Yes, either historical error or due to something being inline that should not be. -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] fix for fdo#33960 cross reference to a list number, dot bug makes sw/qa/complex/writer fail
At least with recent git trunk builds, make subsequentcheck fails in sw with
1) checkCrossReferences(complex.writer.CheckCrossReferences)
org.junit.ComparisonFailure: set reference field format doesn't result in correct field
result expected: 1[.] but was: 1[]
at org.junit.Assert.assertEquals(Assert.java:123)
at
complex.writer.CheckCrossReferences.checkField(CheckCrossReferences.java:120)
at
complex.writer.CheckCrossReferences.checkCrossReferences(CheckCrossReferences.java:176)
This appears to be caused by the fix for
https://bugs.freedesktop.org/show_bug.cgi?id=33960 cross reference to
a list number, dot bug, which removes the trailing . from
SwNumRule::MakeRefNumString.
The question is, is the below patch (which makes that subsequentcheck
failure go away) right in adapting the failing test to the new code, or
does this failure actually uncover unwanted side effects of the new code
(I'm esp. unsure about changing A. 1. to A 1)?
diff --git a/sw/qa/complex/writer/CheckCrossReferences.java
b/sw/qa/complex/writer/CheckCrossReferences.j
index cc7fcb1..597a14f 100644
--- a/sw/qa/complex/writer/CheckCrossReferences.java
+++ b/sw/qa/complex/writer/CheckCrossReferences.java
@@ -145,9 +145,9 @@ public class CheckCrossReferences {
final String FldResult1 = *i*;
final String FldResult2 = +b+*i*;
final String FldResult3 = -1-+b+*i*;
-final String FldResult4 = 1.;
-final String FldResult5 = 1.;
-final String FldResult6 = A. 1.;
+final String FldResult4 = 1;
+final String FldResult5 = 1;
+final String FldResult6 = A 1;
// variables for current field
com.sun.star.text.XTextField xField = null;
-Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSOC] how to call python code from the menu
Hello, I've tried to follow your steps but placing the code in wizards/com/sun/star/wizards/fax/CallWizard.py. So far I haven't been able to build it successfully. It complains and says: ERROR: File not found: CallWizard.py I attach a file with the changes I've done. Greetings 2011/8/17 Caolán McNamara caol...@redhat.com On Wed, 2011-08-17 at 09:06 +0100, Caolán McNamara wrote: I imagine that if you basically opengrok for mailmerge.py and mailmerge.component and follow the same pattern for your one that it'll get you a lot closer. Seeing as this is a bit tricky to get up and running, attached is a rough-and-ready patch to turn wizards-letter into hello world in python. i.e. a) add a hello_world.component (which gets run through the usual xslt script via the local makefile.mk to tweak it to give the right location where the .py will finally get installed) that describes a hello_world.py component. The .component has the implementation name, e.g. org.openoffice.comp.pyuno.demo.HelloWorld in it and the services it implements, e.g. com.sun.star.task.Job b) I added a hello_world.py that implements that, see its g_ImplementationHelper.addImplementation for the matching implementation name and services c) add that hello_world.component to postprocess where it will be basically added as an entry into the services.rdb in the final install sets install/program/services.rdb (which is an xml file these days. That should end up having component loader=com.sun.star.loader.Python uri=vnd.openoffice.pymodule:hello_worldimplementation name=org.openoffice.comp.pyuno.demo.HelloWorldservice name=com.sun.star.task.Job//implementation/component/components in it). d) change the wizards-letter line in officecfg to call it e) modify scp2 to install it f) I haven't a clue what the entry in instsetoo_native does anymore, I think I used to know :-) hope this helps. C. From ac490d5f468ad36041ecd03e2761481be281c56a Mon Sep 17 00:00:00 2001 From: Xisco Fauli aniste...@gmail.com Date: Tue, 6 Sep 2011 19:39:20 +0200 Subject: [PATCH] call callwizard --- .../registry/data/org/openoffice/Office/Common.xcu |2 +- postprocess/packcomponents/makefile.mk |2 +- scp2/source/ooo/file_ooo.scp | 12 ++ scp2/source/ooo/module_hidden_ooo.scp |1 + scripting/prj/d.lst|1 + wizards/com/sun/star/wizards/fax/CallWizard.py | 175 wizards/com/sun/star/wizards/fax/fax.component |6 +- wizards/com/sun/star/wizards/fax/makefile.mk |8 +- 8 files changed, 56 insertions(+), 151 deletions(-) diff --git a/officecfg/registry/data/org/openoffice/Office/Common.xcu b/officecfg/registry/data/org/openoffice/Office/Common.xcu index 998ab38..85d4480 100644 --- a/officecfg/registry/data/org/openoffice/Office/Common.xcu +++ b/officecfg/registry/data/org/openoffice/Office/Common.xcu @@ -400,7 +400,7 @@ /node node oor:name=m1 oor:op=replace install:module=writer prop oor:name=URL oor:type=xs:string - value service:com.sun.star.wizards.fax.CallWizard?start/value + value service:com.sun.star.wizards.fax.CallWizard?insert/value /prop prop oor:name=Title value xml:lang=en-US~Fax.../value diff --git a/postprocess/packcomponents/makefile.mk b/postprocess/packcomponents/makefile.mk index addc3a2..ff264c8 100644 --- a/postprocess/packcomponents/makefile.mk +++ b/postprocess/packcomponents/makefile.mk @@ -364,7 +364,7 @@ my_components += evoab my_components += component/avmedia/source/gstreamer/avmediagstreamer .END -my_ooo_components = mailmerge +my_ooo_components = mailmerge component/wizards/com/sun/star/wizards/fax/fax .INCLUDE: target.mk diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp index e77bdcf..3bc1eee 100644 --- a/scp2/source/ooo/file_ooo.scp +++ b/scp2/source/ooo/file_ooo.scp @@ -471,6 +471,18 @@ STD_JAR_FILE( gid_File_Jar_Saxon, saxon9 ) #endif #endif +#ifndef AIX +#ifndef DISABLE_PYUNO +File gid_File_PyFax +TXT_FILE_BODY; +Dir = gid_Dir_Program; +Name = CallWizard.py; +Styles = (PACKED); +End +#endif +#endif + + #ifndef SYSTEM_LIBTEXTCAT_DATA // fingerprint files (lm) diff --git a/scp2/source/ooo/module_hidden_ooo.scp b/scp2/source/ooo/module_hidden_ooo.scp index 9dd3ab1..287e277 100644 --- a/scp2/source/ooo/module_hidden_ooo.scp +++ b/scp2/source/ooo/module_hidden_ooo.scp @@ -139,6 +139,7 @@ Module gid_Module_Root_Files_3 gid_File_Jar_Table, gid_File_Jar_Letter, gid_File_Jar_Form, + gid_File_PyFax, gid_File_Jar_Agenda, gid_File_Jar_Web, gid_File_Jar_Query, diff --git a/scripting/prj/d.lst b/scripting/prj/d.lst index f1caf45..5deedbe 100644 --- a/scripting/prj/d.lst +++ b/scripting/prj/d.lst @@ -16,6 +16,7 @@ mkdir: %_DEST%\bin\pyuno ..\%__SRC%\lib\lib*static*.dylib %_DEST%\lib\lib*static*.dylib ..\%__SRC%\misc\mailmerge.component
Re: [Libreoffice] fix for fdo#33960 cross reference to a list number, dot bug makes sw/qa/complex/writer fail
The question is, is the below patch (which makes that subsequentcheck failure go away) right in adapting the failing test to the new code, or does this failure actually uncover unwanted side effects of the new code (I'm esp. unsure about changing A. 1. to A 1)? The approach is too simple. The first problem is that the level separator is not necessarily a . (and is configurable at each level in other word processors). Also, while it is understandable in the case described it is not necessarily the desired always especially for lists with multiple levels. When in the configuration options of a list there should be a toggle for whether to remove the final list level separation suffix in references. I don't see removing internal separators (or level prefix) and I can see that sometime a user might not want the trailing suffix removed. Neil Leathers ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] fix for fdo#33960 cross reference to a list number, dot bug makes sw/qa/complex/writer fail
On Tue, 6 Sep 2011 15:27:07 -0300 Neil Leathers neil.r.leath...@gmail.com wrote: The approach is too simple. The first problem is that the level separator is not necessarily a . (and is configurable at each level in other word processors). Its allowed for the test to assume an default config -- as it always tests a default config. Also, while it is understandable in the case described it is not necessarily the desired always especially for lists with multiple levels. When in the configuration options of a list there should be a toggle for whether to remove the final list level separation suffix in references. I don't see removing internal separators (or level prefix) and I can see that sometime a user might not want the trailing suffix removed. Thats besides the point I think. Stephans question was: The behaviour of the numbering changed. Was that intended or is it an unintended change? The best candidate to answer that question of cause is the author of the change that caused the different behavior (cc'ing author and commiter). Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] undo/redo inserting cells in merged cells with shadows result in strange behavior
Hello, this patch removes some code that resulted in strange behavior with merged areas and shadows. The code extended the merged area by one column/row which resulted in strange behavior with undo/redo. It seems that the code was an old hack for the ui part that is no longer needed. Regards, Markus From 9957ff62a8caec17f033cdfbed3a96d3232a31e1 Mon Sep 17 00:00:00 2001 From: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue, 6 Sep 2011 21:31:00 +0200 Subject: [PATCH] don't extend the merged area by one for shadows --- sc/inc/attarray.hxx |2 +- sc/inc/column.hxx |2 +- sc/inc/document.hxx |6 +++--- sc/inc/table.hxx |2 +- sc/source/core/data/attarray.cxx | 15 +-- sc/source/core/data/column.cxx|4 ++-- sc/source/core/data/documen9.cxx |2 +- sc/source/core/data/document.cxx | 12 ++-- sc/source/core/data/table2.cxx|4 ++-- sc/source/ui/docshell/docfunc.cxx | 10 +- sc/source/ui/undo/undoblk.cxx |2 +- sc/source/ui/view/printfun.cxx|2 +- sc/source/ui/view/viewdata.cxx|2 +- sc/source/ui/view/viewfun3.cxx|2 +- 14 files changed, 27 insertions(+), 40 deletions(-) diff --git a/sc/inc/attarray.hxx b/sc/inc/attarray.hxx index dcf58aa..678fb70 100644 --- a/sc/inc/attarray.hxx +++ b/sc/inc/attarray.hxx @@ -161,7 +161,7 @@ public: boolHasAttrib( SCROW nRow1, SCROW nRow2, sal_uInt16 nMask ) const; sal_Bool ExtendMerge( SCCOL nThisCol, SCROW nStartRow, SCROW nEndRow, SCCOL rPaintCol, SCROW rPaintRow, -sal_Bool bRefresh, sal_Bool bAttrs ); +sal_Bool bRefresh ); sal_Bool RemoveAreaMerge( SCROW nStartRow, SCROW nEndRow ); void FindStyleSheet( const SfxStyleSheetBase* pStyleSheet, ScFlatBoolRowSegments rUsedRows, bool bReset ); diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx index dcd7b64..d4a60af 100644 --- a/sc/inc/column.hxx +++ b/sc/inc/column.hxx @@ -156,7 +156,7 @@ public: boolHasAttribSelection( const ScMarkData rMark, sal_uInt16 nMask ) const; boolExtendMerge( SCCOL nThisCol, SCROW nStartRow, SCROW nEndRow, SCCOL rPaintCol, SCROW rPaintRow, -bool bRefresh, bool bAttrs ); +bool bRefresh ); bool IsEmptyVisData(bool bNotes) const; // without Broadcaster bool IsEmptyData() const; diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index 4c7202b..1f17f4f 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -811,11 +811,11 @@ public: sal_BoolExtendMergeSel( SCCOL nStartCol, SCROW nStartRow, SCCOL rEndCol, SCROW rEndRow, const ScMarkData rMark, -sal_Bool bRefresh = false, sal_Bool bAttrs = false ); +sal_Bool bRefresh = false ); sal_Bool ExtendMerge( SCCOL nStartCol, SCROW nStartRow, SCCOL rEndCol, SCROW rEndRow, SCTAB nTab, -sal_Bool bRefresh = false, sal_Bool bAttrs = false ); -sal_Bool ExtendMerge( ScRange rRange, sal_Bool bRefresh = false, sal_Bool bAttrs = false ); +sal_Bool bRefresh = false ); +sal_Bool ExtendMerge( ScRange rRange, sal_Bool bRefresh = false ); sal_Bool ExtendTotalMerge( ScRange rRange ); SC_DLLPUBLIC sal_Bool ExtendOverlapped( SCCOL rStartCol, SCROW rStartRow, SCCOL nEndCol, SCROW nEndRow, SCTAB nTab ); diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx index 36bd138..7b47cd0 100644 --- a/sc/inc/table.hxx +++ b/sc/inc/table.hxx @@ -516,7 +516,7 @@ public: boolHasAttribSelection( const ScMarkData rMark, sal_uInt16 nMask ) const; boolExtendMerge( SCCOL nStartCol, SCROW nStartRow, SCCOL rEndCol, SCROW rEndRow, -sal_Bool bRefresh, sal_Bool bAttrs ); +sal_Bool bRefresh ); const SfxPoolItem* GetAttr( SCCOL nCol, SCROW nRow, sal_uInt16 nWhich ) const; const ScPatternAttr* GetPattern( SCCOL nCol, SCROW nRow ) const; const ScPatternAttr*GetMostUsedPattern( SCCOL nCol, SCROW nStartRow, SCROW nEndRow ) const; diff --git a/sc/source/core/data/attarray.cxx b/sc/source/core/data/attarray.cxx index 6741093..5366845 100644 --- a/sc/source/core/data/attarray.cxx +++ b/sc/source/core/data/attarray.cxx @@ -1349,7 +1349,7 @@ bool ScAttrArray::HasAttrib( SCROW nRow1, SCROW nRow2, sal_uInt16 nMask ) const // Area around any given summaries expand and adapt any MergeFlag (bRefresh) sal_Bool ScAttrArray::ExtendMerge( SCCOL nThisCol, SCROW nStartRow, SCROW nEndRow, SCCOL rPaintCol, SCROW rPaintRow,
Re: [Libreoffice] cppcheck git version
On 09/06/11 13:03, serval2...@yahoo.fr wrote: Hello Jesse, Would it be possible before each cppcheck run to add this in the script : - cd cppcheck repo - git pull -r - make clean make ? The goal is obviously to run the last git version each time. The time of these few steps would be quite little in comparison with the cppcheck run. Julien. (Let's keep this sort of thing on-list, please. :) ) I'll consider it. I'm using Gentoo (which has a git-versioned ebuild for cppecheck), so I would run an update on that and therefore still have it be a managed process. I'll have to make it so that I can revert, however, given a broken build of cppcheck (that compiled, but might not work runtime). I also manually patch the simple htmlreport script included with cppcheck, and I'll need to automate that as well. So, it's on the wishlist. :) Cheers, Jesse -- Jesse Adelman Senior Systems Shepherd ilikelinux Consulting/Bold and Busted, LLC http://ilikelinux.com/ http://boldandbusted.com/ Brisbane, CA Tel: (415) 656-4480 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] minutes of tech. steering call ...
Michael Meeks wrote (06-09-11 17:56) As you have seen, I posted some overview on the subject to the list two days ago I didn't see that, (no wonder, it was a Sunday evening ;-) ) any chance of a re-send; if you give enough details no doubt we can discuss it ourselves, though that is less satisfying of course. Obvious. I'll resend it. I'll be glad to join a talk about this. Only problem: needs to be somewhere: .. - For the weeks towards mid October about the same schedule. By mid-October we can meet at the LibreOffice conference perhaps ? :-) I'll try to. But it is too late for a fair look at the question. (As explained before more then once: if the discussion leads to the conclusion that a bit earlier start with beta release is wise, it is not fair to say that only few weeks before that time. Devs will be disturbed!) Cheers, -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] 3.5 release from QA to point-zero
[resend of my post from 2011-09-04, 20:38 UTC with one little change] Hi *, Some time ago there was a discussion about the release for 3.5. The sub-optimal situation with the release of 3.4.0, was food for the discussion on the 3.5 release. Quite a lengthy and interesting discussion at that time (1) I promised to get back on this issue. Goal: take a clear look at what influences the development and QA of 3.5.0, in order to make sure that we do not have the problems as with 3.4.0. I do not want discuss this because I would be convinced that it is necessary to change the planned release-schedule (2) - I am not even making that suggestion. Anyway, not now ;-) I just want to feel a bit comfortable with what we are going to do. So it is good to make a clear picture of the situation, of the items involved. I will make a list (not pretending that it is comprehensive) below. However, of course it is very unlikely that such an effort can lead to some solid scientific prediction (anyway, not before the event ;-) ), it thus serves to get the information and feeling right. Which in itself is important enough. And it might lead to the conclusion that more time between freeze and first RC is needed. Which can be found in either direction of course, and of which an earlier freeze will definitely be preferred. If.. So, items that come to my mind: - number and severity of changes on code how many difficult/basic stuff are touched in these months? We know that when so much is changed, for sure many nasty hidden older bugs will surface.. - How much time can one annoying bug ask? Two day, two weeks? (many bugs show that is can be very time consuming) - what is the progress in the weak spots in our attention? Base e.g. - what can we expect for new large code chunks in the coming months or integration of some older CWS'es - the increase in the number of people available for testing - how many people start working/testing with master/nightly builds? - how many issues see we from there? - and how fast are those solved? - development in the quality and the use of tools for testing - is attention in testing well spread over Windows / Linux / MacOS ? - are there other releases/tasks that need attention during that time ? - how many people are available for beta-RC testing and fixing bugs ? e.g. the time of the year (Christmas, Western New year) - can we attract many people for beta-testing (prize for the top-5 (clear, useful) issue submitting testers ?) = = [ Shudder ... would one ever dare to plan any release again after this listing ? :-p ] What did I forget? Maybe some can have a major impact consider? Is it a useful approach to think a bit more in detail about these items? Also on the discussion we had before, there was a simple and sound idea from Norbert (3), worth to consider (expand the time between Beta/RC / release on Thursday / QA still need to use Daily Build) Thanks for your feedback, Cor 1) starting here: http://lists.freedesktop.org/archives/libreoffice/2011-June/014201.html 2) http://wiki.documentfoundation.org/ReleasePlan#3.5_release 3) http://lists.freedesktop.org/archives/libreoffice/2011-June/014293.html -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Curso de Qualificação Neo Natal / Pediátrico e Adulto - Escola Politécnica de Enfermagem - Anna Nery
O email do seu cliente não pode ler esta mensagem. Para ver online por favor clique aqui:http://mktpremium.com.br/mkt/display.php?M=439570C=0b8585030d065b2bc8b18863858cb331S=63L=36N=27 Para deixar de receber nossas novidades clique http://mktpremium.com.br/mkt/unsubscribe.php?M=439570C=0b8585030d065b2bc8b18863858cb331L=36N=63 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] fix for fdo#33960 cross reference to a list number, dot bug makes sw/qa/complex/writer fail
On Wednesday 07 September 2011, Stephan Bergmann wrote: final String FldResult1 = *i*; final String FldResult2 = +b+*i*; final String FldResult3 = -1-+b+*i*; -final String FldResult4 = 1.; -final String FldResult5 = 1.; -final String FldResult6 = A. 1.; +final String FldResult4 = 1; +final String FldResult5 = 1; +final String FldResult6 = A 1; The last one should be A.1 rather than A 1. The second last should be 1 rather than 1. The ule implemented was actually somewhat more complex than the simple rule described in the bug report. signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] config.parms vs autogen.lastrun
Hi, Both autogen.lastrun and config.parms seem to have the same purpose, to store the ./configure command line. We should only need one, but I'm not sure which one would be better to get rid of. Suggestions? Thanks, Peter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] config.parms vs autogen.lastrun
On Tue, Sep 6, 2011 at 4:39 PM, Peter Foley pefol...@verizon.net wrote: Hi, Both autogen.lastrun and config.parms seem to have the same purpose, to store the ./configure command line. Not quite. autogen.last run save the command line given to autgogen.sh. that is _before_ substitution of things like -with-config=foo for instance. furthermore the content of config.parms has changed over time... at one point not that long ago it was not containing anything remotely close to autogen.lastrun for instance on my Mac, which has autoconf 2.61 $ cat config.parms /usr/local/share/config.site /usr/local/etc/config.site We should only need one, but I'm not sure which one would be better to get rid of. Suggestions? you cannot get rid of config.parms, since that would require patching autoconf you cannot get rid of autogen.lastrun, because it contain what we really need in all cases... Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] build system patches
On Tue, Sep 6, 2011 at 5:32 PM, Peter Foley pefol...@verizon.net wrote: Hi, Here are some patches for various problems I encountered while building libreoffice. 0002... From 913ba23fd2552436c7c48e83fd1d6ec7de6c2e96 Mon Sep 17 00:00:00 2001 From: Peter Foley pefol...@verizon.net Date: Mon, 5 Sep 2011 21:39:22 -0400 Subject: [PATCH 2/7] /usr/local/lib If /usr/local/lib doesn't exist the Mozilla build fails. This patch fixes the build failure. Is that an observed behavior or a speculated one ? I mean: 1/ why on earth would our build ever try to create or even install something in /usr/loca/bin when building an external lib. if we do, then the fix is to stop that madness, not encourage it :-) 2/ if /usr/local/bin does not exist mkdir -p is not going to succeed anymore than $(MKDIR), unless you run make as root or have g+w or o+w authorization on /usr, both of which are a really, really bad idea. Norbert --- moz/seamonkey-source-1.1.14.patch | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/moz/seamonkey-source-1.1.14.patch b/moz/seamonkey-source-1.1.14.patch index db62e8b..07d8500 100644 --- a/moz/seamonkey-source-1.1.14.patch +++ b/moz/seamonkey-source-1.1.14.patch @@ -6352,3 +6352,14 @@ +PROCESS_MAP_FILE = grep -v ';-' $ | \ +sed -e 's,;+,,' -e 's; DATA ;;' -e 's,;;,,' -e 's,;.*,;,' $@ + +--- misc/mozilla/directory/c-sdk/ldap/libraries/liblber/Makefile.in 2011-09-05 19:36:54.506893237 -0400 misc/build/mozilla/directory/c-sdk/ldap/libraries/liblber/Makefile.in 2011-09-05 19:37:12.267893237 -0400 +@@ -82,7 +82,7 @@ + export::$(OBJDEST) $(LIBDIR) $(OBJS) $(LIBLBER) + + $(LIBDIR): +- $(MKDIR) $(LIBDIR) ++ mkdir -p $(LIBDIR) + + $(LIBLBER): $(OBJS) $(LIBDIR) + @echo === making $(LIBLBER) -- 1.7.6.1 Thanks, Peter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] build system patches
On Tue, 6 Sep 2011, Norbert Thiebaud wrote: On Tue, Sep 6, 2011 at 5:32 PM, Peter Foley pefol...@verizon.net wrote: Hi, Here are some patches for various problems I encountered while building libreoffice. 0002... From 913ba23fd2552436c7c48e83fd1d6ec7de6c2e96 Mon Sep 17 00:00:00 2001 From: Peter Foley pefol...@verizon.net Date: Mon, 5 Sep 2011 21:39:22 -0400 Subject: [PATCH 2/7] /usr/local/lib If /usr/local/lib doesn't exist the Mozilla build fails. This patch fixes the build failure. Is that an observed behavior or a speculated one ? Observed. I've atached the relevent logfile. I mean: 1/ why on earth would our build ever try to create or even install something in /usr/loca/bin when building an external lib. if we do, then the fix is to stop that madness, not encourage it :-) Yeah, I'll try to come up with a better fix then this admittedly somewhat hacky one. 2/ if /usr/local/bin does not exist mkdir -p is not going to succeed anymore than $(MKDIR), unless you run make as root or have g+w or o+w authorization on /usr, both of which are a really, really bad idea. I'm actually building libreoffice in a chroot but I agree that a better fix is probably necessary. Feel free to drop this patch for now and I'll try to come up with a better solution. Thanks, Peter mozlog Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] config.parms vs autogen.lastrun
On Tue, Sep 6, 2011 at 7:20 PM, Peter Foley pefol...@verizon.net wrote: On Tue, 6 Sep 2011, Norbert Thiebaud wrote: On Tue, Sep 6, 2011 at 4:39 PM, Peter Foley pefol...@verizon.net wrote: Hi, Both autogen.lastrun and config.parms seem to have the same purpose, to store the ./configure command line. Not quite. autogen.last run save the command line given to autgogen.sh. that is _before_ substitution of things like -with-config=foo for instance. furthermore the content of config.parms has changed over time... at one point not that long ago it was not containing anything remotely close to autogen.lastrun for instance on my Mac, which has autoconf 2.61 $ cat config.parms /usr/local/share/config.site /usr/local/etc/config.site We should only need one, but I'm not sure which one would be better to get rid of. Suggestions? you cannot get rid of config.parms, since that would require patching autoconf config.parms is created by this snippet in configure.in: echo $@ config.parms So it wouldn't actualy require patching autoconf to remove. ok then, sure that line does not serve a purpose that I can see. I'm puzzled by the output I see on MacOS though ? how does echo $@ end up as /usr/local/share/config.site /usr/local/etc/config.site ? oh well bottom line. autogen.lastrun is the one to keep :-) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] build system patches
On Tue, Sep 6, 2011 at 5:32 PM, Peter Foley pefol...@verizon.net wrote: Hi, Here are some patches for various problems I encountered while building libreoffice. 0001-libcrnf.a is that a consequence of http://cgit.freedesktop.org/libreoffice/core/commit/?id=291b85778669b4e4e276faab22add9d0e80046df ? (I'm trying to figure out why this problem shows up all the sudden.. ) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Partial PUSH] [PATCH] build system patches
On Tue, Sep 6, 2011 at 5:32 PM, Peter Foley pefol...@verizon.net wrote: Hi, Here are some patches for various problems I encountered while building libreoffice. so, I've pushed 0003 and 0005 so far. Thanks. I'm not sure I understand the rational (what problem does it 'fixes' what are the gains ?) for 0004 nor fully grasp the consequence... the prefix/exec_prefix hack does nothing to re-assure me that I understand what is going on... maybe someone smarter than me can review and push... I try to avoid pushing stuff I don't understand :-) 0002 we already discussed... skipped for now 0001 wating for confirmation that it is indeed a fallback from kendy's dep-optimization wrt to moz and nss. but sound pretty harmless so I prolly will push it 0006-0007 I'm waiting for feed back from cloph to make sure that upping the requirement for autoconf is not going to be a problem on PPC MacOSX 10.4 (pretty old tool-chain) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] config.parms vs autogen.lastrun
On Tue, 6 Sep 2011, Norbert Thiebaud wrote: On Tue, Sep 6, 2011 at 4:39 PM, Peter Foley pefol...@verizon.net wrote: Hi, Both autogen.lastrun and config.parms seem to have the same purpose, to store the ./configure command line. Not quite. autogen.last run save the command line given to autgogen.sh. that is _before_ substitution of things like -with-config=foo for instance. furthermore the content of config.parms has changed over time... at one point not that long ago it was not containing anything remotely close to autogen.lastrun for instance on my Mac, which has autoconf 2.61 $ cat config.parms /usr/local/share/config.site /usr/local/etc/config.site We should only need one, but I'm not sure which one would be better to get rid of. Suggestions? you cannot get rid of config.parms, since that would require patching autoconf config.parms is created by this snippet in configure.in: echo $@ config.parms So it wouldn't actualy require patching autoconf to remove. Thanks, Peter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] build system patches
On Tue, Sep 6, 2011 at 5:32 PM, Peter Foley pefol...@verizon.net wrote: Hi, Here are some patches for various problems I encountered while building libreoffice. BTW, can you make a statement to the list about your patches being MPL 1.1/LGPLV3+ ? or point me to the appropriate post if you've already done so and even better reference that post here: http://wiki.documentfoundation.org/Development/Developers (there are few 'license' links there for example of what I mean by license statement... ) Thanks Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Returned mail: see transcript for details
The original message was received at Wed, 7 Sep 2011 12:04:46 +0700 from lists.freedesktop.org [210.14.5.204] - The following addresses had permanent fatal errors - libreoffice@lists.freedesktop.org - Transcript of the session follows - ... while talking to lists.freedesktop.org.: 554 5.0.0 Service unavailable; [194.21.201.18] blocked using bl.spamcop.net Session aborted ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] build system patches
On Tue, Sep 06, 2011 at 07:27:38PM -0500, Norbert Thiebaud wrote:
On Tue, Sep 6, 2011 at 5:32 PM, Peter Foley pefol...@verizon.net wrote:
Here are some patches for various problems I encountered while
building libreoffice.
From 913ba23fd2552436c7c48e83fd1d6ec7de6c2e96 Mon Sep 17 00:00:00 2001
From: Peter Foley pefol...@verizon.net
Date: Mon, 5 Sep 2011 21:39:22 -0400
Subject: [PATCH 2/7] /usr/local/lib
If /usr/local/lib doesn't exist the Mozilla build fails.
This patch fixes the build failure.
Is that an observed behavior or a speculated one ?
I get the same problem (or a very similar one), and reported it as fdo
bug #39852.
I've been working around it with:
source Host.Env.sh
unset LIBDIR
cd moz
build
I mean:
1/ why on earth would our build ever try to create or even install
something in /usr/loca/bin when building an external lib. if we do,
then the fix is to stop that madness, not encourage it :-)
More precisely, it tries to create ${LIBDIR}; by default, that is
/usr/local/lib, but if one passed --prefix and/org --libdir to
autogen.sh, then it is another directory.
Since my workaround works, my guess is that the moz build system
contains something to the effect of
LIBDIR ?= /something/internal/to/the/moz/build/tree
or
ifndef LIBDIR
LIBDIR = /something/internal/to/the/moz/build/tree
endif
and so the LIBDIR from the LO build system interferes with that.
Or maybe if LIBDIR is not set, it just silently does not try to create
it.
2/ if /usr/local/bin does not exist mkdir -p is not going to succeed
anymore than $(MKDIR), unless you run make as root or have g+w or o+w
authorization on /usr, both of which are a really, really bad idea.
From the error message I get (see the bugzilla), the $(MKDIR) variable
is not set...
--
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
