[Libreoffice-commits] .: solenv/gbuild

2011-10-10 Thread Bjoern Michaelsen
 solenv/gbuild/CustomTarget.mk |4 ++--
 solenv/gbuild/LinkTarget.mk   |4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 04e1536d4e77242a47afa5c573add7ab619e6762
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date:   Mon Oct 10 11:13:07 2011 +0200

fixing error handling for generated files again

diff --git a/solenv/gbuild/CustomTarget.mk b/solenv/gbuild/CustomTarget.mk
index 19279a4..20cd29a 100644
--- a/solenv/gbuild/CustomTarget.mk
+++ b/solenv/gbuild/CustomTarget.mk
@@ -59,8 +59,8 @@ $(if $(filter $(2),$(gb_CustomTarget_REPOSITORYNAMES)),,\
 gb_CustomTarget_REPO_$(1) := $(2)
 $(call gb_CustomTarget_get_target,$(1)) : \
   $(call gb_CustomTarget__get_makefile,$($(2)),$(1))
-$(call gb_CustomTarget_get_workdir,$(1))/% : \
-  $(call gb_CustomTarget_get_target,$(1))
+$(call gb_CustomTarget_get_workdir,$(1))/% : $(call 
gb_CustomTarget_get_target,$(1))
+   test -f $@ || (echo Missing file $@ which should have been generated 
from CustomTarget $(1), but was not.  false)
 endef
 
 
diff --git a/solenv/gbuild/LinkTarget.mk b/solenv/gbuild/LinkTarget.mk
index dea4aaa..49dd076 100644
--- a/solenv/gbuild/LinkTarget.mk
+++ b/solenv/gbuild/LinkTarget.mk
@@ -197,7 +197,7 @@ gb_GenCObject_get_source = $(WORKDIR)/$(1).c
 #  gb_CObject__command
 
 $(call gb_GenCObject_get_target,%) : $(call gb_GenCObject_get_source,%)
-   $(if $(wildcard $),,$(eval $(call gb_Output_error,No such source file 
$)))
+   test -f $ || (echo Missing generated source file $  false)
$(call gb_CObject__command,$@,$*,$,$(call 
gb_GenCObject_get_dep_target,$*))
 
 ifeq ($(gb_FULLDEPS),$(true))
@@ -216,7 +216,7 @@ gb_GenCxxObject_get_source = $(WORKDIR)/$(1).cxx
 #  gb_CxxObject__command
 
 $(call gb_GenCxxObject_get_target,%) : $(call gb_GenCxxObject_get_source,%)
-   $(if $(wildcard $),,$(eval $(call gb_Output_error,No such source file 
$)))
+   test -f $ || (echo Missing generated source file $  false)
$(call gb_CxxObject__command,$@,$*,$,$(call 
gb_GenCxxObject_get_dep_target,$*))
 
 ifeq ($(gb_FULLDEPS),$(true))
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: 11 commits - extensions/source sc/source sd/source sw/source

2011-10-10 Thread Tor Lillqvist
 extensions/source/bibliography/datman.cxx |2 +-
 extensions/source/nsplugin/source/so_main.cxx |2 ++
 extensions/source/ole/oleobjw.cxx |3 +--
 extensions/source/ole/oleobjw.hxx |   15 ---
 sc/source/filter/excel/xeescher.cxx   |2 --
 sc/source/ui/vba/vbaapplication.cxx   |2 --
 sd/source/core/drawdoc.cxx|2 +-
 sd/source/filter/eppt/epptbase.hxx|2 +-
 sd/source/filter/eppt/text.hxx|4 ++--
 sw/source/core/crsr/crsrsh.cxx|2 +-
 10 files changed, 13 insertions(+), 23 deletions(-)

New commits:
commit a62e3205030d17a402255c9a84d0f484c18d25a9
Author: Tor Lillqvist tlillqv...@suse.com
Date:   Mon Oct 10 12:47:30 2011 +0300

WaE: unsafe mix of type 'bool' and type 'sal_Bool' in operation

diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index 8a8cd4e..f402e02 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -679,7 +679,7 @@ int SwCrsrShell::SetCrsr( const Point rLPt, sal_Bool 
bOnlyText, bool bBlock )
 
 // Toggle the Header/Footer mode if needed
 bool bInHeaderFooter = pFrm  ( pFrm-IsHeaderFrm() || 
pFrm-IsFooterFrm() );
-if ( bInHeaderFooter ^ IsHeaderFooterEdit() )
+if ( bInHeaderFooter ^ (bool) IsHeaderFooterEdit() )
 ToggleHeaderFooterEdit();
 
 if( pBlockCrsr  bBlock )
commit 2a0a3a15b985258f678c97890527216fdda8eead
Author: Tor Lillqvist tlillqv...@suse.com
Date:   Mon Oct 10 12:46:39 2011 +0300

WaE: inconsistent dll linkage

diff --git a/sc/source/ui/vba/vbaapplication.cxx 
b/sc/source/ui/vba/vbaapplication.cxx
index 371c70b..d1102b7 100644
--- a/sc/source/ui/vba/vbaapplication.cxx
+++ b/sc/source/ui/vba/vbaapplication.cxx
@@ -137,8 +137,6 @@ using ::rtl::OUString;
 #define FILE_PATH_SEPERATOR \\
 #endif
 
-uno::Any sbxToUnoValue( SbxVariable* pVar );
-
 class ActiveWorkbook : public ScVbaWorkbook
 {
 protected:
commit 76fd28341d36b55af448be2703a405d5095bafbd
Author: Tor Lillqvist tlillqv...@suse.com
Date:   Mon Oct 10 12:45:10 2011 +0300

WaE: unreachable code

diff --git a/sc/source/filter/excel/xeescher.cxx 
b/sc/source/filter/excel/xeescher.cxx
index e466614..2a290c3 100644
--- a/sc/source/filter/excel/xeescher.cxx
+++ b/sc/source/filter/excel/xeescher.cxx
@@ -136,7 +136,6 @@ static const char *ToHorizAlign( SdrTextHorzAdjust eAdjust )
 default:
 return left;
 }
-return unknown;
 }
 
 static const char *ToVertAlign( SdrTextVertAdjust eAdjust )
@@ -153,7 +152,6 @@ static const char *ToVertAlign( SdrTextVertAdjust eAdjust )
 default:
 return top;
 }
-return unknown;
 }
 
 static void lcl_WriteAnchorVertex( sax_fastparser::FSHelperPtr rComments, 
Rectangle aRect )
commit b76d47d9ad25fd5c6bc1c4499d000a2ea85079a3
Author: Noel Power noel.po...@novell.com
Date:   Mon Oct 10 12:43:19 2011 +0300

So just drop the duplicate XInvocation base class then

diff --git a/extensions/source/ole/oleobjw.cxx 
b/extensions/source/ole/oleobjw.cxx
index 1820fdd..275c6a8 100644
--- a/extensions/source/ole/oleobjw.cxx
+++ b/extensions/source/ole/oleobjw.cxx
@@ -166,7 +166,7 @@ Any IUnknownWrapper_Impl::queryInterface(const Type t)
 // properties. Note: Currently the basic runtime doesn't call put 
properties directly, it should... after all the basic runtime should know 
whether it is calling a put or get property.
 // For the moment for ease of merging we will let the XDirectInvoke and 
XAuthomationInvocation interfaces stay side by side ( and for the momemnt at 
least I would prefer the basic
 // runtime to call XAutomationInvocation instead of XDirectInvoke
-return WeakImplHelper8XInvocation, XBridgeSupplier2,
+return WeakImplHelper7XBridgeSupplier2,
 XInitialization, XAutomationObject, XDefaultProperty, XDefaultMethod, 
XDirectInvocation, XAutomationInvocation ::queryInterface(t);
 }
 
diff --git a/extensions/source/ole/oleobjw.hxx 
b/extensions/source/ole/oleobjw.hxx
index 5e7769a..bbbf08d 100644
--- a/extensions/source/ole/oleobjw.hxx
+++ b/extensions/source/ole/oleobjw.hxx
@@ -41,15 +41,9 @@
 #include boost/unordered_map.hpp
 #include tools/postsys.h
 
-#ifdef _MSC_VER
-#pragma warning (push,1)
-// warning C4584: 
'cppu::WeakImplHelper8Ifc1,Ifc2,Ifc3,Ifc4,Ifc5,Ifc6,Ifc7,Ifc8' : base-class 
'com::sun::star::script::XInvocation' is already a base-class of 
'com::sun::star::script::XAutomationInvocation'
-#pragma warning (disable:4584)
-#endif
-
 #include cppuhelper/implbase3.hxx
 #include cppuhelper/implbase4.hxx
-#include cppuhelper/implbase8.hxx
+#include cppuhelper/implbase7.hxx
 
 #include com/sun/star/lang/XInitialization.hpp
 #include com/sun/star/bridge/oleautomation/XAutomationObject.hpp
@@ -82,7 +76,7 @@ typedef boost::unordered_multimapOUString, unsigned int, 
hashOUString_Impl, equ
 // This class wraps an IDispatch and maps XInvocation calls to IDispatch calls 
on the 

[Libreoffice-commits] .: Branch 'feature/gtk3' - basebmp/source

2011-10-10 Thread Michael Meeks
 basebmp/source/bitmapdevice.cxx |   16 
 1 file changed, 16 insertions(+)

New commits:
commit 055db78e0a93cb36096002770dc4700daeef56b9
Author: Michael Meeks michael.me...@suse.com
Date:   Sat Oct 8 15:37:32 2011 +0100

basebmp: B2IRange::isEmpty is surprisingly, unhelpfully lame - workaround

diff --git a/basebmp/source/bitmapdevice.cxx b/basebmp/source/bitmapdevice.cxx
index a483197..f7f139b 100644
--- a/basebmp/source/bitmapdevice.cxx
+++ b/basebmp/source/bitmapdevice.cxx
@@ -1343,6 +1343,10 @@ namespace
 if( aLocalSourceArea.isEmpty() )
 return false;
 
+// isEmpty is not what we want I think ...
+if( aLocalSourceArea.getWidth() = 0 || aLocalSourceArea.getHeight() 
= 0 )
+return false;
+
 // calc relative new source area points (relative to orig
 // source area)
 const ::basegfx::B2IVector aUpperLeftOffset(
@@ -1359,6 +1363,10 @@ namespace
 if( aLocalDestArea.isEmpty() )
 return false;
 
+// isEmpty is not what we want I think ...
+if( aLocalDestArea.getWidth() = 0 || aLocalDestArea.getHeight() = 0 )
+return false;
+
 // calc relative new dest area points (relative to orig
 // source area)
 const ::basegfx::B2IVector aDestUpperLeftOffset(
@@ -1398,6 +1406,10 @@ namespace
 if( aLocalSourceArea.isEmpty() )
 return false;
 
+ // sadly isEmpty is not what we want I think ...
+if( aLocalSourceArea.getWidth() = 0 || aLocalSourceArea.getHeight() 
= 0 )
+return false;
+
 // calc relative new source area points (relative to orig
 // source area)
 const ::basegfx::B2IVector aUpperLeftOffset(
@@ -1416,6 +1428,10 @@ namespace
 if( aLocalDestArea.isEmpty() )
 return false;
 
+// isEmpty is not what we want I think ...
+if( aLocalDestArea.getWidth() = 0 || aLocalDestArea.getHeight() = 0 )
+return false;
+
 // calc relative new dest area points (relative to orig
 // source area)
 const ::basegfx::B2IVector aDestUpperLeftOffset(
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: solenv/gbuild solenv/inc

2011-10-10 Thread Fridrich Strba
 solenv/gbuild/platform/unxgcc.mk   |1 +
 solenv/gbuild/platform/winmingw.mk |1 +
 solenv/inc/unxgcc.mk   |3 ++-
 solenv/inc/wntgcci.mk  |1 +
 4 files changed, 5 insertions(+), 1 deletion(-)

New commits:
commit eb09adaa9a2accbdc3531bb96447c8e7fbb9f8a9
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Mon Oct 10 12:52:10 2011 +0200

Warn if declaration follows statement in C-files

diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk
index 0379d7c..7ee4217 100644
--- a/solenv/gbuild/platform/unxgcc.mk
+++ b/solenv/gbuild/platform/unxgcc.mk
@@ -69,6 +69,7 @@ gb_COMPILERDEFS := \
 
 gb_CFLAGS := \
-Wall \
+   -Wdeclaration-after-statement \
-Wendif-labels \
-Wextra \
-Wshadow \
diff --git a/solenv/gbuild/platform/winmingw.mk 
b/solenv/gbuild/platform/winmingw.mk
index a1a8233..6d438ff 100644
--- a/solenv/gbuild/platform/winmingw.mk
+++ b/solenv/gbuild/platform/winmingw.mk
@@ -71,6 +71,7 @@ gb_RCFLAGS := \
 
 gb_CFLAGS := \
-Wall \
+   -Wdeclaration-after-statement \
-Wendif-labels \
-Wextra \
-fmessage-length=0 \
diff --git a/solenv/inc/unxgcc.mk b/solenv/inc/unxgcc.mk
index 45f6901..2e6d66b 100644
--- a/solenv/inc/unxgcc.mk
+++ b/solenv/inc/unxgcc.mk
@@ -135,7 +135,8 @@ CFLAGSOUTOBJ=-o
 # -Wshadow does not work for C with nested uses of pthread_cleanup_push:
 CFLAGSWARNCC=-Wall -Wextra -Wendif-labels
 CFLAGSWARNCXX=$(CFLAGSWARNCC) -Wshadow -Wno-ctor-dtor-privacy \
--Wno-non-virtual-dtor -Woverloaded-virtual
+-Wno-non-virtual-dtor
+CFLAGSWARNCC+=-Wdeclaration-after-statement
 CFLAGSWALLCC=$(CFLAGSWARNCC)
 CFLAGSWALLCXX=$(CFLAGSWARNCXX)
 CFLAGSWERRCC=-Werror -DLIBO_WERROR
diff --git a/solenv/inc/wntgcci.mk b/solenv/inc/wntgcci.mk
index f62c96a..5fe8bbd 100644
--- a/solenv/inc/wntgcci.mk
+++ b/solenv/inc/wntgcci.mk
@@ -82,6 +82,7 @@ CDEFS+=-D_DLL
 CFLAGSWARNCC=-Wall -Wextra -Wendif-labels
 CFLAGSWARNCXX=$(CFLAGSWARNCC) -Wshadow -Wno-ctor-dtor-privacy \
 -Wno-non-virtual-dtor
+CFLAGSWARNCC+=-Wdeclaration-after-statement
 CFLAGSWALLCC=$(CFLAGSWARNCC)
 CFLAGSWALLCXX=$(CFLAGSWARNCXX)
 CFLAGSWERRCC=-Werror -DLIBO_WERROR
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: 2 commits - sw/source

2011-10-10 Thread Cédric Bosdonnat
 sw/source/ui/docvw/PageBreakWin.cxx |  121 
 sw/source/ui/inc/PageBreakWin.hxx   |3 
 2 files changed, 100 insertions(+), 24 deletions(-)

New commits:
commit 4c03a2497c97568c244cd14767e840d200fbc440
Author: Cédric Bosdonnat cedric.bosdon...@free.fr
Date:   Mon Oct 10 12:50:02 2011 +0200

Page Break: Fix page break deletion when changing page style

diff --git a/sw/source/ui/docvw/PageBreakWin.cxx 
b/sw/source/ui/docvw/PageBreakWin.cxx
index 8a185d6..31fe8a3 100644
--- a/sw/source/ui/docvw/PageBreakWin.cxx
+++ b/sw/source/ui/docvw/PageBreakWin.cxx
@@ -34,6 +34,7 @@
 #include DashedLine.hxx
 #include doc.hxx
 #include edtwin.hxx
+#include fmtpdsc.hxx
 #include IDocumentUndoRedo.hxx
 #include PageBreakWin.hxx
 #include pagefrm.hxx
@@ -308,13 +309,21 @@ void SwPageBreakWin::Select( )
 if ( pBodyFrm )
 {
 SwCntntFrm *pCnt = const_cast SwCntntFrm* ( 
pBodyFrm-ContainsCntnt() );
-sal_uInt16 nWhich = 
pCnt-GetAttrSet()-GetPool()-GetWhich( SID_ATTR_PARA_PAGEBREAK );
+//sal_uInt16 nWhich = 
pCnt-GetAttrSet()-GetPool()-GetWhich( SID_ATTR_PARA_PAGEBREAK );
 SwCntntNode* pNd = pCnt-GetNode();
 
 pNd-GetDoc()-GetIDocumentUndoRedo( ).StartUndo( 
UNDO_UI_DELETE_PAGE_BREAK, NULL );
-SvxFmtBreakItem aNoBreakItem( SVX_BREAK_NONE, nWhich );
+
+SfxItemSet aSet( 
GetEditWin()-GetView().GetWrtShell().GetAttrPool(),
+RES_PAGEDESC, RES_PAGEDESC,
+RES_BREAK, RES_BREAK,
+NULL );
+aSet.Put( SvxFmtBreakItem( SVX_BREAK_NONE, RES_BREAK ) );
+aSet.Put( SwFmtPageDesc( NULL ) );
+
 SwPaM aPaM( *pNd );
-pNd-GetDoc()-InsertPoolItem( aPaM, aNoBreakItem, 
nsSetAttrMode::SETATTR_DEFAULT );
+pNd-GetDoc()-InsertItemSet( aPaM, aSet, 
nsSetAttrMode::SETATTR_DEFAULT );
+
 pNd-GetDoc()-GetIDocumentUndoRedo( ).EndUndo( 
UNDO_UI_DELETE_PAGE_BREAK, NULL );
 }
 }
commit 61ae8caa020c76f3095ec91801c460a018872fae
Author: Cédric Bosdonnat cedric.bosdon...@free.fr
Date:   Mon Oct 10 10:50:01 2011 +0200

Page Break: show the button on the right for book mode view

diff --git a/sw/source/ui/docvw/PageBreakWin.cxx 
b/sw/source/ui/docvw/PageBreakWin.cxx
index 2caa8cc..8a185d6 100644
--- a/sw/source/ui/docvw/PageBreakWin.cxx
+++ b/sw/source/ui/docvw/PageBreakWin.cxx
@@ -44,6 +44,7 @@
 #include wrtsh.hxx
 
 #include basegfx/color/bcolortools.hxx
+#include basegfx/matrix/b2dhommatrixtools.hxx
 #include basegfx/polygon/b2dpolygon.hxx
 #include basegfx/polygon/b2dpolygontools.hxx
 #include basegfx/range/b2drectangle.hxx
@@ -65,7 +66,7 @@ using namespace drawinglayer::primitive2d;
 
 namespace
 {
-B2DPolygon lcl_CreatePolygon( B2DRectangle aBounds )
+B2DPolygon lcl_CreatePolygon( B2DRectangle aBounds, bool bShowOnRight )
 {
 B2DPolygon aRetval;
 const double nRadius = 1;
@@ -140,6 +141,14 @@ namespace
 }
 
 aRetval.setClosed( true );
+
+if ( bShowOnRight )
+{
+B2DHomMatrix bRotMatrix = createRotateAroundPoint(
+aBounds.getCenterX(), aBounds.getCenterY(), M_PI );
+aRetval.transform( bRotMatrix );
+}
+
 return aRetval;
 }
 }
@@ -190,10 +199,12 @@ void SwPageBreakWin::Paint( const Rectangle )
 aOtherColor = rSettings.GetDialogColor( ).getBColor();
 }
 
+bool bShowOnRight = ShowOnRight( );
+
 Primitive2DSequence aSeq( 2 );
 B2DRectangle aBRect( double( aRect.Left() ), double( aRect.Top( ) ),
double( aRect.Right() ), double( aRect.Bottom( ) ) );
-B2DPolygon aPolygon = lcl_CreatePolygon( aBRect );
+B2DPolygon aPolygon = lcl_CreatePolygon( aBRect, bShowOnRight );
 
 // Create the polygon primitives
 aSeq[0] = Primitive2DReference( new PolyPolygonColorPrimitive2D(
@@ -213,7 +224,9 @@ void SwPageBreakWin::Paint( const Rectangle )
 double nTop = double( aRect.getHeight() ) / 2.0;
 double nBottom = nTop + 4.0;
 double nLeft = aRect.getWidth( ) - ARROW_WIDTH - 6.0;
-double nRight = aRect.getWidth( ) - ARROW_WIDTH + 2.0;
+if ( bShowOnRight )
+nLeft = ARROW_WIDTH - 2.0;
+double nRight = nLeft + 8.0;
 
 B2DPolygon aTriangle;
 aTriangle.append( B2DPoint( nLeft, nTop ) );
@@ -234,7 +247,10 @@ void SwPageBreakWin::Paint( const Rectangle )
 
 // Paint the picture
 Image aImg( SW_RES( IMG_PAGE_BREAK ) );
-DrawImage( Point( 3, 1 ), aImg );
+long nImgOfstX = 3;
+if ( bShowOnRight )
+nImgOfstX = aRect.Right() - aImg.GetSizePixel().Width() - 3;
+DrawImage( Point( nImgOfstX, 1 ), aImg );
 }
 
 void SwPageBreakWin::Select( )
@@ -306,33 +322,81 @@ void 

[Libreoffice-commits] .: Branch 'feature/gtk3' - 2 commits - vcl/generic vcl/headless vcl/inc

2011-10-10 Thread Michael Meeks
 vcl/generic/print/genprnpsp.cxx |2 +-
 vcl/headless/svpgdi.cxx |8 
 vcl/inc/vcl/sysdata.hxx |1 +
 3 files changed, 6 insertions(+), 5 deletions(-)

New commits:
commit 047e770ede15b26191533027082feedb33adfbda
Author: Michael Meeks michael.me...@suse.com
Date:   Mon Oct 10 11:55:14 2011 +0100

generic: overcome Mac specific build errors

diff --git a/vcl/generic/print/genprnpsp.cxx b/vcl/generic/print/genprnpsp.cxx
index 9e5e2c6..cdae650 100644
--- a/vcl/generic/print/genprnpsp.cxx
+++ b/vcl/generic/print/genprnpsp.cxx
@@ -109,7 +109,7 @@ static String getPdfDir( const PrinterInfo rInfo )
 
 static void getPaLib()
 {
-#if defined( UNX )
+#if defined( UNX )  !( defined( QUARTZ ) || defined( IOS ) )
 if( ! driverLib )
 {
 OUString aLibName( RTL_CONSTASCII_USTRINGPARAM( _XSALSET_LIBNAME ) );
diff --git a/vcl/inc/vcl/sysdata.hxx b/vcl/inc/vcl/sysdata.hxx
index 2e00618..b97e854 100644
--- a/vcl/inc/vcl/sysdata.hxx
+++ b/vcl/inc/vcl/sysdata.hxx
@@ -147,6 +147,7 @@ struct SystemGraphicsData
 : nSize( sizeof( SystemGraphicsData ) )
 #if defined( WNT )
 , hDC( 0 )
+#elif defined( QUARTZ ) || defined( IOS )
 #elif defined( UNX )
 , pDisplay( NULL )
 , hDrawable( 0 )
commit 63649f11fa31fc5262a2abf0916b71cb50a200a8
Author: Michael Meeks michael.me...@suse.com
Date:   Mon Oct 10 11:25:42 2011 +0100

headless: add required clip map reset for simpler clipping cases

diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 3609bd9..e44240d 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -270,11 +270,10 @@ SvpSalGraphics::ClipUndoHandle 
SvpSalGraphics::ensureClipFor( const basegfx::B2I
 bool SvpSalGraphics::setClipRegion( const Region i_rClip )
 {
 m_aClipRegion = i_rClip;
+m_aClipMap.reset();
 if( i_rClip.IsEmpty() )
-{
-m_aClipMap.reset();
 m_bClipSetup = true;
-}
+
 else if( i_rClip.GetRectCount() == 1 )
 {
 m_aClipMap.reset();
@@ -285,6 +284,7 @@ bool SvpSalGraphics::setClipRegion( const Region i_rClip )
 }
 else
 m_bClipSetup = false;
+
 return true;
 }
 
@@ -555,7 +555,7 @@ void SvpSalGraphics::copyBits( const SalTwoRect* pPosAry,
 }
 
 void SvpSalGraphics::drawBitmap( const SalTwoRect* pPosAry,
-const SalBitmap rSalBitmap )
+ const SalBitmap rSalBitmap )
 {
 const SvpSalBitmap rSrc = static_castconst SvpSalBitmap(rSalBitmap);
 B2IRange aSrcRect( pPosAry-mnSrcX, pPosAry-mnSrcY,
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: binfilter/bf_sd binfilter/bf_svx binfilter/inc

2011-10-10 Thread Joseph Powers
 binfilter/bf_sd/source/ui/view/sd_frmview.cxx   |1 
 binfilter/bf_svx/source/svdraw/svx_svddrgv.cxx  |   43 -
 binfilter/bf_svx/source/svdraw/svx_svdlayer.cxx |4 
 binfilter/bf_svx/source/svdraw/svx_svdmark.cxx  |   19 --
 binfilter/bf_svx/source/svdraw/svx_svdmrkv.cxx  |2 
 binfilter/inc/bf_svx/svddrgv.hxx|  204 
 binfilter/inc/bf_svx/svdxcgv.hxx|5 
 7 files changed, 4 insertions(+), 274 deletions(-)

New commits:
commit 184b91bc311b5d518215c106b0590bcc84b71ccf
Author: Joseph Powers jpower...@cox.net
Date:   Mon Oct 10 08:05:11 2011 -0700

Cleanup class SdrDragView a little

diff --git a/binfilter/bf_sd/source/ui/view/sd_frmview.cxx 
b/binfilter/bf_sd/source/ui/view/sd_frmview.cxx
index 1220694..516897e 100644
--- a/binfilter/bf_sd/source/ui/view/sd_frmview.cxx
+++ b/binfilter/bf_sd/source/ui/view/sd_frmview.cxx
@@ -296,7 +296,6 @@ void FrameView::Update(SdOptions* pOptions)
 
 SetGridCoarse( Size( pOptions-GetFldDrawX(), pOptions-GetFldDrawY() 
) );
 SetGridFine( Size( pOptions-GetFldDivisionX(), 
pOptions-GetFldDivisionY() ) );
-//  SetSnapGrid( Size( pOptions-GetFldSnapX(), pOptions-GetFldSnapY() ) 
);
 Fraction aFractX(pOptions-GetFldDrawX(), pOptions-GetFldDrawX() / ( 
pOptions-GetFldDivisionX() ? pOptions-GetFldDivisionX() : 1 ));
 Fraction aFractY(pOptions-GetFldDrawY(), pOptions-GetFldDrawY() / ( 
pOptions-GetFldDivisionY() ? pOptions-GetFldDivisionY() : 1 ));
 SetSnapGridWidth(aFractX, aFractY);
diff --git a/binfilter/bf_svx/source/svdraw/svx_svddrgv.cxx 
b/binfilter/bf_svx/source/svdraw/svx_svddrgv.cxx
index bba22a1..d774bb6 100644
--- a/binfilter/bf_svx/source/svdraw/svx_svddrgv.cxx
+++ b/binfilter/bf_svx/source/svdraw/svx_svddrgv.cxx
@@ -32,69 +32,31 @@
 
 namespace binfilter {
 
-#define XOR_DRAG_PEN   PEN_DOT
-
 /*N*/ void SdrDragView::ImpClearVars()
 /*N*/ {
-/*N*/   bFramDrag=FALSE;
 /*N*/   eDragMode=SDRDRAG_MOVE;
-/*N*/   bDragLimit=FALSE;
 /*N*/   bMarkedHitMovesAlways=FALSE;
-/*N*/   eDragHdl=HDL_MOVE;
-/*N*/   pDragHdl=NULL;
-/*N*/   bDragHdl=FALSE;
-/*N*/   bDragSpecial=FALSE;
-/*N*/   pDragBla=NULL;
 /*N*/   bDragStripes=FALSE;
 /*N*/   bNoDragHdl=TRUE;
 /*N*/   bMirrRefDragObj=TRUE;
 /*N*/   bSolidDragging=FALSE;
-/*N*/   bSolidDrgNow=FALSE;
-/*N*/   bSolidDrgChk=FALSE;
 /*N*/   bDragWithCopy=FALSE;
-/*N*/   pInsPointUndo=NULL;
-/*N*/   bInsAfter=FALSE;
-/*N*/   bInsGluePoint=FALSE;
-/*N*/   bInsObjPointMode=FALSE;
-/*N*/   bInsGluePointMode=FALSE;
-/*N*/   nDragXorPolyLimit=100;
-/*N*/   nDragXorPointLimit=500;
 /*N*/   bNoDragXorPolys=FALSE;
-/*N*/   bAutoVertexCon=TRUE;
-/*N*/   bAutoCornerCon=FALSE;
-/*N*/   bRubberEdgeDragging=TRUE;
-/*N*/   nRubberEdgeDraggingLimit=100;
-/*N*/   bDetailedEdgeDragging=TRUE;
-/*N*/   nDetailedEdgeDraggingLimit=10;
-/*N*/   bResizeAtCenter=FALSE;
-/*N*/   bCrookAtCenter=FALSE;
-/*N*/   bMouseHideWhileDraggingPoints=FALSE;
-/*N*/ }
-
-/*N*/ void SdrDragView::ImpMakeDragAttr()
-/*N*/ {
-/*N*/   ImpDelDragAttr();
 /*N*/ }
 
 /*N*/ SdrDragView::SdrDragView(SdrModel* pModel1, OutputDevice* pOut):
 /*N*/   SdrExchangeView(pModel1,pOut)
 /*N*/ {
 /*N*/   ImpClearVars();
-/*N*/   ImpMakeDragAttr();
 /*N*/ }
 
 /*N*/ SdrDragView::~SdrDragView()
 /*N*/ {
-/*N*/   ImpDelDragAttr();
-/*N*/ }
-
-/*N*/ void SdrDragView::ImpDelDragAttr()
-/*N*/ {
 /*N*/ }
 
 /*N*/ BOOL SdrDragView::IsAction() const
 /*N*/ {
-/*N*/   return SdrExchangeView::IsAction() || pDragBla!=NULL;
+/*N*/   return SdrExchangeView::IsAction();
 /*N*/ }
 
 /*N*/ void SdrDragView::BrkAction()
@@ -118,8 +80,7 @@ namespace binfilter {
 
 /*N*/ void SdrDragView::SetDragStripes(BOOL bOn)
 /*N*/ {
-/*N*/   if ( !(pDragBla!=NULL  aDragStat.IsShown() ) )
-/*N*/   bDragStripes=bOn;
+/*N*/   bDragStripes=bOn;
 /*N*/ }
 
 

diff --git a/binfilter/bf_svx/source/svdraw/svx_svdlayer.cxx 
b/binfilter/bf_svx/source/svdraw/svx_svdlayer.cxx
index c706ae6..a2952d0 100644
--- a/binfilter/bf_svx/source/svdraw/svx_svdlayer.cxx
+++ b/binfilter/bf_svx/source/svdraw/svx_svdlayer.cxx
@@ -146,10 +146,6 @@ namespace binfilter {
 /*N*/   {
 /*N*/   // Das Standardlayerflag kam direkt nach der Betalieferung dazu
 /*N*/   rIn  rLayer.nType;
-/*N*/
-/*N*/   if(rLayer.nType == 1)
-/*N*/   {DBG_BF_ASSERT(0, STRIP);
-/*N*/   }
 /*N*/   }
 /*N*/
 /*N*/   if(aHead.GetVersion() = 12)
diff --git a/binfilter/bf_svx/source/svdraw/svx_svdmark.cxx 
b/binfilter/bf_svx/source/svdraw/svx_svdmark.cxx
index 23e2deb..4aae881 100644
--- a/binfilter/bf_svx/source/svdraw/svx_svdmark.cxx
+++ b/binfilter/bf_svx/source/svdraw/svx_svdmark.cxx
@@ -33,29 +33,10 @@ namespace binfilter {
 
 

 
-
-
-
-
-
-
-

[Libreoffice-commits] .: 3 commits - binfilter/bf_svx binfilter/bf_xmloff binfilter/inc

2011-10-10 Thread Caolán McNamara
 binfilter/bf_svx/source/svdraw/svx_svdhdl.cxx   |   10 -
 binfilter/bf_svx/source/svdraw/svx_svdvmark.cxx |   17 
 binfilter/bf_xmloff/source/forms/layerexport.hxx|1 
 binfilter/bf_xmloff/source/forms/xmloff_layerexport.cxx |4 +++
 binfilter/inc/bf_svx/svdhdl.hxx |2 -
 binfilter/inc/bf_svx/svdvmark.hxx   |7 --
 6 files changed, 5 insertions(+), 36 deletions(-)

New commits:
commit 2a11056a9a4e33d39c15184f54d47b0886d45308
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 10 16:25:24 2011 +0100

callcatcher: freshly unused code

diff --git a/binfilter/bf_svx/source/svdraw/svx_svdvmark.cxx 
b/binfilter/bf_svx/source/svdraw/svx_svdvmark.cxx
index e37e6b7..ecd5f10 100644
--- a/binfilter/bf_svx/source/svdraw/svx_svdvmark.cxx
+++ b/binfilter/bf_svx/source/svdraw/svx_svdvmark.cxx
@@ -87,15 +87,6 @@ namespace binfilter {
 /*N*/   if (pXPolyPoly!=NULL) { delete pXPolyPoly; pXPolyPoly=NULL; }
 /*N*/ }
 
-/*N*/ void SdrViewUserMarker::Show()
-/*N*/ {DBG_BF_ASSERT(0, STRIP);
-/*N*/ }
-
-/*N*/ void SdrViewUserMarker::Hide()
-/*N*/ {DBG_BF_ASSERT(0, STRIP);
-/*N*/ }
-
-
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/binfilter/inc/bf_svx/svdvmark.hxx 
b/binfilter/inc/bf_svx/svdvmark.hxx
index e211863..a535b2a 100644
--- a/binfilter/inc/bf_svx/svdvmark.hxx
+++ b/binfilter/inc/bf_svx/svdvmark.hxx
@@ -150,8 +150,6 @@ public:
 bool IsAnimateBackward() const { return bAnimateBwd; }
 bool IsAnimateToggle() const { return bAnimateToggle; }
 
-void Show();
-void Hide();
 bool IsVisible() const { return bVisible; }
 
 bool HasPointer() const { return bHasPointer; }
commit 6d2ec30dd9063e3876428444c27a9e683d7f8925
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 10 14:41:14 2011 +0100

callcatcher: newly unused methods

diff --git a/binfilter/bf_svx/source/svdraw/svx_svdhdl.cxx 
b/binfilter/bf_svx/source/svdraw/svx_svdhdl.cxx
index d12fc2f..30b1cf2 100644
--- a/binfilter/bf_svx/source/svdraw/svx_svdhdl.cxx
+++ b/binfilter/bf_svx/source/svdraw/svx_svdhdl.cxx
@@ -47,16 +47,6 @@ SdrHdl::~SdrHdl() {}
 /*N*/ };
 
 
-
-
-/*N*/ SdrHdl* SdrHdlList::GetFocusHdl() const
-/*N*/ {
-/*N*/   if (pImpl-mnFocusIndex != CONTAINER_ENTRY_NOTFOUND  
pImpl-mnFocusIndex  GetHdlCount())
-/*?*/   return GetHdl(pImpl-mnFocusIndex);
-/*N*/   else
-/*?*/   return 0L;
-/*N*/ }
-
 /*N*/ SdrHdlList::SdrHdlList(SdrMarkView* pV)
 /*N*/ : pImpl(new ImplHdlListData(pV))
 /*N*/ , aList(1024,32,32)
diff --git a/binfilter/bf_svx/source/svdraw/svx_svdvmark.cxx 
b/binfilter/bf_svx/source/svdraw/svx_svdvmark.cxx
index 5eec928..e37e6b7 100644
--- a/binfilter/bf_svx/source/svdraw/svx_svdvmark.cxx
+++ b/binfilter/bf_svx/source/svdraw/svx_svdvmark.cxx
@@ -87,14 +87,6 @@ namespace binfilter {
 /*N*/   if (pXPolyPoly!=NULL) { delete pXPolyPoly; pXPolyPoly=NULL; }
 /*N*/ }
 
-/*N*/ void SdrViewUserMarker::SetLineWidth(USHORT nWdt)
-/*N*/ {
-/*N*/   bool bVis=bVisible;
-/*N*/   if (bVis) Hide();
-/*N*/   nLineWdt=nWdt;
-/*N*/   if (bVis) Show();
-/*N*/ }
-
 /*N*/ void SdrViewUserMarker::Show()
 /*N*/ {DBG_BF_ASSERT(0, STRIP);
 /*N*/ }
diff --git a/binfilter/inc/bf_svx/svdhdl.hxx b/binfilter/inc/bf_svx/svdhdl.hxx
index 48d9d5c..1121c0c 100644
--- a/binfilter/inc/bf_svx/svdhdl.hxx
+++ b/binfilter/inc/bf_svx/svdhdl.hxx
@@ -178,8 +178,6 @@ public:
 ~SdrHdlList();
 void Clear();
 
-SdrHdl* GetFocusHdl() const;
-
 // Access to View
 SdrMarkView* GetView() const;
 
diff --git a/binfilter/inc/bf_svx/svdvmark.hxx 
b/binfilter/inc/bf_svx/svdvmark.hxx
index 0accacb..e211863 100644
--- a/binfilter/inc/bf_svx/svdvmark.hxx
+++ b/binfilter/inc/bf_svx/svdvmark.hxx
@@ -115,11 +115,6 @@ public:
 void SetOutputDevice(OutputDevice* pOut) { pForcedOutDev=pOut; }
 OutputDevice* GetOutputDevice() const { return pForcedOutDev; }
 
-// Der Marker kann durchaus auch in einen andere View gesteckt werden.
-// (Beim Destruieren der View wird die View am Marker automatisch auf NULL 
gesetzt.)
-
-void SetLineWidth(USHORT nWdt);
-
 void SetAnimateDelay(USHORT nTime) { nAnimateDelay=(nTime+25)/50; }
 void SetAnimateSpeed(USHORT nTime) { nAnimateSpeed=(nTime+25)/50; if 
(nAnimateSpeed0) nAnimateSpeed--; }
 void SetAnimateCount(USHORT nAnz) { nAnimateAnz=nAnz; }
commit c4c8d1453c8a84a23ed6fd4540e3817b6d432ab4
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 10 13:46:03 2011 +0100

WaE: mirror in fix here

diff --git a/binfilter/bf_xmloff/source/forms/layerexport.hxx 
b/binfilter/bf_xmloff/source/forms/layerexport.hxx
index b6547e6..9f33c37 100644
--- a/binfilter/bf_xmloff/source/forms/layerexport.hxx
+++ b/binfilter/bf_xmloff/source/forms/layerexport.hxx
@@ -118,6 +118,7 @@ namespace xmloff
 
 public:
 OFormLayerXMLExport_Impl(SvXMLExport 

[Libreoffice-commits] .: 2 commits - vcl/unx

2011-10-10 Thread Caolán McNamara
 vcl/unx/gtk/app/gtkdata.cxx |   25 -
 1 file changed, 16 insertions(+), 9 deletions(-)

New commits:
commit 76a0e6ee30cb7610bc0eb1d536476fc801f3a3bf
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 10 17:09:12 2011 +0100

grab monitors on start also

diff --git a/vcl/unx/gtk/app/gtkdata.cxx b/vcl/unx/gtk/app/gtkdata.cxx
index 4e10809..904d22a 100644
--- a/vcl/unx/gtk/app/gtkdata.cxx
+++ b/vcl/unx/gtk/app/gtkdata.cxx
@@ -783,6 +783,9 @@ void GtkXLib::Init()
 GdkScreen *pScreen = gdk_display_get_screen( pGdkDisp, n );
 if( pScreen )
 {
+m_pGtkSalDisplay-screenSizeChanged(pScreen);
+m_pGtkSalDisplay-monitorsChanged(pScreen);
+
 g_signal_connect( G_OBJECT(pScreen), size-changed, 
G_CALLBACK(signalScreenSizeChanged), m_pGtkSalDisplay );
 if( ! gtk_check_version( 2, 14, 0 ) ) // monitors-changed came in 
with 2.14, avoid an assertion
 g_signal_connect( G_OBJECT(pScreen), monitors-changed, 
G_CALLBACK(signalMonitorsChanged), m_pGtkSalDisplay );
commit 1f88a2a00dfdcc29e805d23c1a88a82b69d59d24
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 10 17:08:37 2011 +0100

fix the fallback logic

diff --git a/vcl/unx/gtk/app/gtkdata.cxx b/vcl/unx/gtk/app/gtkdata.cxx
index 4cb161a..4e10809 100644
--- a/vcl/unx/gtk/app/gtkdata.cxx
+++ b/vcl/unx/gtk/app/gtkdata.cxx
@@ -259,20 +259,24 @@ int GtkSalDisplay::GetDefaultMonitorNumber() const
 (screen_get_primary_monitor)osl_getAsciiFunctionSymbol( 
GetSalData()-m_pPlugin, gdk_screen_get_primary_monitor );
 if (sym_gdk_screen_get_primary_monitor)
 n = sym_gdk_screen_get_primary_monitor( pScreen );
-#if GTK_CHECK_VERSION(2,14,0)
-//gdk_screen_get_primary_monitor unavailable, take the first laptop monitor
-//as the default
-gint nMonitors = gdk_screen_get_n_monitors(pScreen);
-for (gint i = 0; i  nMonitors; ++i)
+else
 {
-if (g_ascii_strncasecmp (gdk_screen_get_monitor_plug_name(pScreen, i), 
LVDS, 4) == 0) {
-OSL_ASSERT( size_t(i)  m_aXineramaScreenIndexMap.size() );
-return (size_t(i)  m_aXineramaScreenIndexMap.size()) ? 
m_aXineramaScreenIndexMap[i] : 0;
+#if GTK_CHECK_VERSION(2,14,0)
+//gdk_screen_get_primary_monitor unavailable, take the first laptop 
monitor
+//as the default
+gint nMonitors = gdk_screen_get_n_monitors(pScreen);
+for (gint i = 0; i  nMonitors; ++i)
+{
+if (g_ascii_strncasecmp (gdk_screen_get_monitor_plug_name(pScreen, 
i), LVDS, 4) == 0)
+{
+n = i;
+break;
+}
 }
 }
 #endif
-return 0;
 #endif
+
 if( n = 0  size_t(n)  m_aXineramaScreenIndexMap.size() )
 n = m_aXineramaScreenIndexMap[n];
 return n;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: autodoc/inc autodoc/source

2011-10-10 Thread Kevin Hunter
 autodoc/inc/ary_i/ci_text2.hxx   |2 +-
 autodoc/source/ary_i/kernel/ci_text2.cxx |   12 
 2 files changed, 1 insertion(+), 13 deletions(-)

New commits:
commit 60f108553552eba8441589c47294f252e4ace1e5
Author: Kevin Hunter hunt...@earlham.edu
Date:   Mon Oct 10 13:58:25 2011 -0400

Simplify logic to use std::vector's .empty()

No need to muck about with iterators, adding a loop, and 2 function
calls to test for empty: it's a std::vector under the hood, so use
.empty(), and inline it.

diff --git a/autodoc/inc/ary_i/ci_text2.hxx b/autodoc/inc/ary_i/ci_text2.hxx
index 8e1c202..eef1d63 100644
--- a/autodoc/inc/ary_i/ci_text2.hxx
+++ b/autodoc/inc/ary_i/ci_text2.hxx
@@ -72,7 +72,7 @@ class DocuTex2
 DYN DocuToken  let_drToken );
 
 const TokenListTokens() const  { return aTokens; }
-boolIsEmpty() const;
+boolIsEmpty() const { return aTokens.empty(); }
 const String   TextOfFirstToken() const;
 
 String Access_TextOfFirstToken();
diff --git a/autodoc/source/ary_i/kernel/ci_text2.cxx 
b/autodoc/source/ary_i/kernel/ci_text2.cxx
index 00a5a7e..dea062f 100644
--- a/autodoc/source/ary_i/kernel/ci_text2.cxx
+++ b/autodoc/source/ary_i/kernel/ci_text2.cxx
@@ -77,18 +77,6 @@ DocuTex2::AddToken( DYN DocuToken  let_drToken )
 aTokens.push_back(let_drToken);
 }
 
-bool
-DocuTex2::IsEmpty() const
-{
-for ( ary::inf::DocuTex2::TokenList::const_iterator
-iter = aTokens.begin();
-  iter != aTokens.end();
-)
-{
-return false;
-}
-return true;
-}
 
 using csi::dsapi::DT_TextToken;
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: solenv/inc

2011-10-10 Thread Fridrich Strba
 solenv/inc/wntgcci.mk |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 2e267c98bd001929fb922f565b65d92365a8d390
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Mon Oct 10 22:27:40 2011 +0200

Clone Caolán's work for wntgcci.mk too

diff --git a/solenv/inc/wntgcci.mk b/solenv/inc/wntgcci.mk
index 5fe8bbd..3831c85 100644
--- a/solenv/inc/wntgcci.mk
+++ b/solenv/inc/wntgcci.mk
@@ -79,10 +79,10 @@ CDEFS+=-D_DLL
 .ENDIF
 
 # -Wshadow does not work for C with nested uses of pthread_cleanup_push:
-CFLAGSWARNCC=-Wall -Wextra -Wendif-labels
-CFLAGSWARNCXX=$(CFLAGSWARNCC) -Wshadow -Wno-ctor-dtor-privacy \
+CFLAGSWARNBOTH=-Wall -Wextra -Wendif-labels
+CFLAGSWARNCC=$(CFLAGSWARNBOTH) -Wdeclaration-after-statement
+CFLAGSWARNCXX=$(CFLAGSWARNBOTH) -Wshadow -Wno-ctor-dtor-privacy \
 -Wno-non-virtual-dtor
-CFLAGSWARNCC+=-Wdeclaration-after-statement
 CFLAGSWALLCC=$(CFLAGSWARNCC)
 CFLAGSWALLCXX=$(CFLAGSWARNCXX)
 CFLAGSWERRCC=-Werror -DLIBO_WERROR
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: unusedcode.easy writerfilter/inc writerfilter/source

2011-10-10 Thread Caolán McNamara
 unusedcode.easy   |4 
 writerfilter/inc/resourcemodel/XPathLogger.hxx|4 
 writerfilter/source/resourcemodel/XPathLogger.cxx |4 
 3 files changed, 8 insertions(+), 4 deletions(-)

New commits:
commit 0123fc6d03412704ac8512339d949773b22b9cce
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 10 22:34:26 2011 +0100

these can go behind DEBUG_CONTEXT_HANDLER

diff --git a/unusedcode.easy b/unusedcode.easy
index 310d070..c025a98 100644
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -2858,7 +2858,3 @@ writerfilter::TagLogger::chars(rtl::OUString const)
 writerfilter::TagLogger::endElement()
 writerfilter::TagLogger::startElement(std::basic_stringchar, 
std::char_traitschar, std::allocatorchar  const)
 writerfilter::TagLogger::~TagLogger()
-writerfilter::XPathLogger::XPathLogger()
-writerfilter::XPathLogger::endElement()
-writerfilter::XPathLogger::getXPath() const
-writerfilter::XPathLogger::startElement(std::basic_stringchar, 
std::char_traitschar, std::allocatorchar )
diff --git a/writerfilter/inc/resourcemodel/XPathLogger.hxx 
b/writerfilter/inc/resourcemodel/XPathLogger.hxx
index d5e97a2..584ed35 100644
--- a/writerfilter/inc/resourcemodel/XPathLogger.hxx
+++ b/writerfilter/inc/resourcemodel/XPathLogger.hxx
@@ -28,6 +28,8 @@
 #ifndef INCLUDED_XPATH_LOGGER_HXX
 #define INCLUDED_XPATH_LOGGER_HXX
 
+#ifdef DEBUG_CONTEXT_HANDLER
+
 #include stack
 #include string
 #include vector
@@ -62,4 +64,6 @@ public:
 void endElement();
 };
 }
+
+#endif
 #endif // INCLUDED_XPATH_LOGGER_HXX
diff --git a/writerfilter/source/resourcemodel/XPathLogger.cxx 
b/writerfilter/source/resourcemodel/XPathLogger.cxx
index aad6847..b9381e3 100644
--- a/writerfilter/source/resourcemodel/XPathLogger.cxx
+++ b/writerfilter/source/resourcemodel/XPathLogger.cxx
@@ -29,6 +29,8 @@
 #include stdio.h
 #include resourcemodel/XPathLogger.hxx
 
+#ifdef DEBUG_CONTEXT_HANDLER
+
 namespace writerfilter
 {
 XPathLogger::XPathLogger()
@@ -89,4 +91,6 @@ void XPathLogger::endElement()
 
 } // namespace writerfilter
 
+#endif
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: [Libreoffice] Declarations after statements

2011-10-10 Thread Michael Meeks

On Sat, 2011-10-08 at 16:05 +0200, Fridrich Strba wrote:
 I cannot ask people to build on Windows, but could we add for those gcc 
 cases simply -Wdeclaration-after-statement warning, so people at least 
 see what is happening and so that tinderboxes whose turnaround is faster 
 then those of windows might alert early?

Oooh ! :-) that sounds really useful. Lets commit it and see what
happens. Are there any other warnings we can turn on on Linux that will
help the long suffering Windows guys ?

Thanks,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] RFC: Idea for fuzz-testing filters

2011-10-10 Thread Marc-André Laverdière
Hello everyone,

I have been struggling along the way and eventually put together this
small starting point... What do you think about it?

Marc-André Laverdière
Software Security Scientist
Innovation Labs, Tata Consultancy Services
Hyderabad, India

On 10/07/2011 01:38 PM, Michael Meeks wrote:
 
 On Fri, 2011-10-07 at 10:53 +0530, Marc-André Laverdière wrote:
 I'm not thrilled with the idea of so much process creation and overhead
 (think Valgrind) for running a somewhat short test over and over again.
 
   Certainly; the linking / bootstrapping overhead is rather substantial
 in comparison with loading a reasonably small document - at least from
 valgrind's perspective. Clearly passing a dozen documents to each
 command-line can help with that though.
 
   HTH,
 
   Michael.
 
/*
 * Version: MPL 1.1 / GPLv3+ / LGPLv3+
 *
 * The contents of this file are subject to the Mozilla Public License Version
 * 1.1 (the License); you may not use this file except in compliance with
 * the License or as specified alternatively below. You may obtain a copy of
 * the License at http://www.mozilla.org/MPL/
 *
 * Software distributed under the License is distributed on an AS IS basis,
 * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
 * for the specific language governing rights and limitations under the
 * License.
 *
 * Major Contributor(s):
 * [ Copyright (C) 2011 Tata Consultancy Services, Ltd. Marc-André Laverdière 
marc-an...@atc.tcs.com (initial developer) ]
 *
 * All Rights Reserved.
 *
 * For minor contributions see the git repository.
 *
 * Alternatively, the contents of this file may be used under the terms of
 * either the GNU General Public License Version 3 or later (the GPLv3+), or
 * the GNU Lesser General Public License Version 3 or later (the LGPLv3+),
 * in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
 * instead of those above.
 */

#include unistd.h
#include stdio.h
#include string
#include iomanip
#include iostream
#include sstream
#include boost/format.hpp
#include boost/program_options.hpp
#include boost/filesystem.hpp
#include boost/filesystem/fstream.hpp

using namespace std;
using namespace boost::program_options;
using namespace boost::filesystem;
using namespace boost::filesystem3;
using namespace boost;

//constants
const string SEEDS_SUBFOLDER = data;
const string RESULTS_SUBFOLDER = results;
const string VALGRIND_COMMAND = valgrind --tool=memcheck;

const string OPTION_HELP = help;
const string OPTION_PROGRAM = program;
const string OPTION_DIR = dir;

const string TERMINATOR = ***^^^FILE_OVER@@@;

const unsigned char PATTERNS[] = {0xFF, 0xEF};

FILE * startProcess(string command, string directory)
{
stringstream concatenator;
concatenator  VALGRIND_COMMAND command directory;
return popen(concatenator.str().c_str(), r);
}

string readProgramOutput(FILE * pipe, string currentbuffer)
{
char buffer[128];
string result = ;
while(!feof(pipe)) {
if(fgets(buffer, 128, pipe) != NULL)
{
string sBuffer = string(buffer);
size_t terminatorLocation = sBuffer.find_last_of(TERMINATOR);
if (terminatorLocation  sBuffer.npos)
{ //we have a match
//do something
result += sBuffer.substr(0,terminatorLocation);
break;
}
else
result += sBuffer;
}
}

return result;
}

bool ensureDirectoryExists(const string name)
{

path folder(RESULTS_SUBFOLDER);
if (!exists(folder))
{
create_directory(folder);
}
else if (!is_directory(folder))
{
cerr  Error:name   is not a directory  endl;
return false;
}

return true;
}

string createBuggerFileName(string  base, uintmax_t offset, unsigned char 
pattern)
{
stringstream concatenator;
concatenator  base  -  dec  offset  -pattern- 
hex  setiosflags (ios_base::showbase | ios_base::uppercase)  
static_castunsigned int(pattern);
return concatenator.str();
}

string getRandomFileName()
{
boost::filesystem3::ifstream in(/dev/random);
stringstream concatenator;
concatenator hex;
for (int i = 0; i  10; i++)
concatenator  in.get();
}

int main(int argc, const char * argv[])
{
options_description desc(Expected arguments:);
desc.add_options()
(OPTION_HELP.c_str(), Shows the help message)
(OPTION_PROGRAM.c_str(), valuevectorstring (), Program to run 
under Valgrind)
(OPTION_DIR.c_str(), valuevectorstring (), Directory to contain 
fuzzed files to test);
//Read the arguments
variables_map arguments;
store(parse_command_line(argc, argv, desc), arguments);


if (arguments.count(OPTION_PROGRAM)  arguments.count(OPTION_DIR))
{
string program = arguments[OPTION_PROGRAM].asvectorstring ()[0];
string dir = arguments[OPTION_DIR].asvector string ()[0];

Re: [Libreoffice] RFC: Idea for fuzz-testing filters

2011-10-10 Thread Michael Meeks
Hi Marc,

On Mon, 2011-10-10 at 15:08 +0530, Marc-André Laverdière wrote:
 I have been struggling along the way and eventually put together this
 small starting point... What do you think about it?

Looks fun :-) I guess it is necessary to have a separate remote-control
process if we want to catch the memcheck output, that's a shame - but
unavoidable I guess.

Regards,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] segfault in sc

2011-10-10 Thread Michael Meeks

On Sun, 2011-10-09 at 22:46 -0700, julien2412 wrote:
 Thank you Markus for having put the bt that I gave you in pastebin.

:-)

 Marc-Andre, when I read the Markus message this morning, I thought exactly
 the same thing, so here it is :
 http://pastebin.com/gTHqax6r

Interesting trace:

Error: ContentBroker::initialize - already initialized! From
File 
/home/maryline/compile-libreoffice/libo/ucbhelper/source/client/contentbroker.cxx
 at Line 186

Looks as though we're not calling test's bootstrapfilter's tearDown
method which should de-initialize that nicely. Or at least, we're trying
to bootstrap that twice somehow- it'd be good to trace that I suppose.
We should also (prolly) add a static int counter to test/
bootstrapfixture to ensure we do in fact teardown as well as setUp.

Secondly Julien - your build is with debug=true - that can change
behaviour, but of course we should chase down those changed behaviours
and try to work out which is causing the grief [ almost certainly one of
the warnings ].

Otherwise - it's fairly hard to see what is going on here. In order to
get a 0x6 pointer and not crash or valgrind warning inside:

SfxObjectShellArr_Impl SfxApplication::GetObjectShells_Impl() const
{
return *pAppData_Impl-pObjShells;
}

which is not in-line; we must have a valid (global) pApp, -and- a valid
pApp-pAppData_Impl - since pObjShells is at some substantial offset
inside there. So - pObjShells must be NULL in error cf.
sfx2/source/inc/appdata.hxx.

As Markus says it's hard for that to happen, unless the:

sfx2/source/appl/appinit.cxx's
bool SfxApplication::Initialize_Impl()

has caught an exception and not completed.

Julien - it'd be wonderful (if you could) to build sfx2 from clean with
debug=true, put a breakpoint at: appinit.cxx:231 (say) run to there,
then [ from there ! ], do break __cxa_throw, and continue until we get
an exception, the post some exception traces from there.

Is that do-able ? And of course, I suspect we should have a
try { } catch () { fail_really_hard_even_in_non_debug_mode(); } in that
constructor,

Thanks ;-)

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Depends on||38908

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] libreoffice sdk 3.4 and SWT Linux issue

2011-10-10 Thread Michael Meeks
Hi Othman,

On Sun, 2011-10-09 at 06:34 -0700, othman wrote:
 I wrote a Java libreoffice addon using netbeans openoffice plugin and
 libreoffice 3.4.this addon launches a SWT window when i click a libreoffice
 toolbar button. this works fine in windows 7 with libreoffice sdk 3.4

Great :-)

 however for Linux (opensuse 11.4) i face a strange problem . when i close
 the SWT window the whole Libreoffice ( v 3.4)  application freezes and
 becomes unresponsive and i have to kill the libreoffice process each time. 

Hah - so some tangled shutdown ordering problem / deadlock I suppose.

 i checked the trace log in my IDE debugger and no problem is reported. this
 wasn't happening when i was using libreoffice sdk version 3.3 but when i
 upgraded to libreoffice sdk 3.4 for linux this annoying problem happens and
 i have no clue what's wrong. 

Can you attach to the soffice.bin process with gdb, and do a:

thread apply all backtrace

and attach the output here ? :-) [ of course if you have debuginfo
packages installed that's really helpful too ].

Thanks,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] [PUSHED] .: stoc/source

2011-10-10 Thread Kevin Hunter

At 3:11am -0400 Wed, 05 Oct 2011, Kevin Hunter wrote:

At 2:58am -0400 Wed, 05 Oct 2011, Stephan Bergmann wrote:

(I assume you already stated somewhere what license your
contributions are under, even though that's not explicitly listed at
http://wiki.documentfoundation.org/Development/Developers.)


Heh, yeah, awhile ago. Had a whole discussion with the Meeks. :-)

http://lists.freedesktop.org/archives/libreoffice/2010-October/001178.html

In short: LGPLv3.


Having talked with Michael out of band, I'm now convinced of the 
viability and need for 3+ and MPL.  Please accept my patches to the 
LibreOffice project, both prior and yet to come, as LGPLv3+/MPL1.1.


Kevin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [PATCH] hyphenation fixes

2011-10-10 Thread Németh László
Hi,

I have attached new patches for the Hyphen library and Hungarian
hyphenation patterns, and the old one for English dictionaries and the
test file from my previous letter.

I have found and fixed a new hyphenation problem at the hyphen
character. OpenOffice.org/LibreOffice can hyphenate the words with
hyphens and en-dashes without explicite hyphenation patterns. From
OpenOffice.org 3.3, the hyphenator gets the hyphens, too (related to a
spell check fix). This is useful to set bigger hyphenation distances
from the hyphens, but the implicite hyphenation of hyphens and the
hyphenation by Hyphen library have a conflict, and often LibreOffice
missed the hyphenation at hyphens, depending from the position of the
compound word in the line. The new Hyphen uses the following implicite
hyphenation settings to fix this problem for all languages:

1-1/=,1,1
NEXTLEVEL

So the hyphenation is enabled at hyphens by also the Hyphen library,
removing the original hyphen (using only the automatic hyphen added by
LibreOffice). Unfortunatelly, this method is not suitable for
en-dashes (eg. in Hungarian texts), but at least, with the new Hyphen
LibreOffice doesn't hyphenate the en-dash with a plus hyphen (–-).

PS.: The new Hyphen 2.8.3:
https://sourceforge.net/projects/hunspell/files/Hyphen/2.8/

Regards,
Laci
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] ODBC handles, a quibble

2011-10-10 Thread Terrence Enger
On Sun, 2011-10-09 at 15:09 +0200, Lionel Elie Mamane wrote:

 Just ignore the function that diff reports :) (Or send a patch to GNU
 diffutils so that it recognises C++ syntax ;-) )

Thank you for your reassurance that I am not hallucinating.

All-in-all, I guess my attention is better applied closer to 
LibreOffice itself.

Terry.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] ODBC handles, a quibble

2011-10-10 Thread Terrence Enger
On Sun, 2011-10-09 at 15:27 +0200, Lionel Elie Mamane wrote:

 I did not read *all* of it, but it seems the ODBC documentation
 contains no such madness. So my guess is that the Microsoft
 implementation of SQL-CLI that is ODBC defines that handles cross
 compilation units. IMHO the other implementations of ODBC better
 follow that, or I'm not sure it is worth supporting them in
 LibreOffice.

Not worth supporting:  That is a nice, polite way of putting it.

If we knew what drivers or driver managers violate the common 
expectation, it might well be worthwhile to warn against using them.  
But I can think of no better way to find them than to wait for 
complaints about something not working.  It all sounds quite unlikely.

 
 And on a nitpicking level, ODBC has a relationship to ISO/IEC
 9075-3:1995, not 9075-3:2006 :) But indeed I guess that 9075-3:1995
 contains the same language.

Yes, the 1995 version has exactly the same sentence.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] QA session at LibreOffice conference

2011-10-10 Thread Cor Nouws

Hi Michael, Rainer,

Doing some preparations for Paris, I see there is a discrepancy between 
the program on the website and the one in the spreadsheet, that can be 
downloaded.


The website mentions Michael to do the QA session on Friday morning.
The spreadsheet mentions me.
I did not apply - I remember that Michael suggested the possibility.
It's not that I feel not capable to hold a talk/session. However, I have 
not prepared anything and have hardly been able to do any QA work for 
the past 5+ weeks. And usually it also are ad hoc contributions that I make.


So talking about Improving the Development / QA cycle ... I feel I do 
not have enough real knowledge.
I can ask the same questions of course, as done on the list: present the 
same view, insight in factors that play a role in the process.
However for many of those factors/areas I lack enough detailed knowledge 
to give some solid ground to a discussion, IMO, other then if then else 
then.
If people are glad with some general overview and points at the QA and 
the dev side that need consideration and at best some harmonisation 
(apart from the extra hands that are welcome of course) ... well, OK. 
But then Rainer would be at least as good as me for that?


So what do you think?

Cheers,


--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [RFC] make binfilter depend on tail_build

2011-10-10 Thread Peter Foley

Hi,

I'd like to propose making binfilter depend on tail_build.
Because binfilter is legacy code and it's 11316 lines worth of dmake 
makefiles are highly unlikly to be converted to gbuild, the only way that 
binfilters's dependencies ( basic vcl xmlscript connectivity framework 
svtools offapi libxslt ) and all of their dependencies could get added to 
tail_build would be for binfilter to depend on tail_build. 
Because binfilter is already built right before tail_build this change 
shouldn't cause any problems.

Comments?

Peter
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] segfault in sc

2011-10-10 Thread Julien Nabet

Le 10/10/2011 13:27, Michael Meeks a écrit :

On Sun, 2011-10-09 at 22:46 -0700, julien2412 wrote:
...
Secondly Julien - your build is with debug=true - that can change
behaviour, but of course we should chase down those changed behaviours
and try to work out which is causing the grief [ almost certainly one of
the warnings ].

In fact, I used make debug=true for the test but it was useless since I 
compile the whole repo in debug (my autogen.lastrun includes these lines :

--enable-debug
--enable-dbgutil
--enable-symbols
)


Otherwise - it's fairly hard to see what is going on here. In order to
get a 0x6 pointer and not crash or valgrind warning inside:

SfxObjectShellArr_Impl  SfxApplication::GetObjectShells_Impl() const
{
 return *pAppData_Impl-pObjShells;
}

which is not in-line; we must have a valid (global) pApp, -and- a valid
pApp-pAppData_Impl - since pObjShells is at some substantial offset
inside there. So - pObjShells must be NULL in error cf.
sfx2/source/inc/appdata.hxx.

As Markus says it's hard for that to happen, unless the:

sfx2/source/appl/appinit.cxx's
bool SfxApplication::Initialize_Impl()

has caught an exception and not completed.

Julien - it'd be wonderful (if you could) to build sfx2 from clean with
debug=true, put a breakpoint at: appinit.cxx:231 (say) run to there,
then [ from there ! ], do break __cxa_throw, and continue until we get
an exception, the post some exception traces from there.
I put a break on appinit.cxx:231 + break __cxa_throw, I pasted a first 
part here :

http://pastebin.com/NAX6AUrJ

then a second part here :
http://pastebin.com/BBepMkcY

If you need more info with different break or something, don't hesitate 
to tell me.
Precision : to quickly do this test, I haven't git updated my repo 
today. (I'm going to do it now)

Is that do-able ? And of course, I suspect we should have a
try { } catch () { fail_really_hard_even_in_non_debug_mode(); } in that
constructor,
For the moment I haven't put the try catch. Tell me if it's still useful 
and what's the best fail_really_hard (without breaking hardware :-) )

Thanks ;-)

Thank YOU for having given me some support on this :-)

Michael.

Julien.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] troubles with merging libraries

2011-10-10 Thread Matúš Kukan
Hi there,

I just realized (although it's quite basic thing... I was never
thinking more about details of this merging thing)
that we can't merge anything what we would want.

For example we have libraries linking chain:
svx - drawninglayer - cppcanvas - canvastools
In list of always used libs (when using writer, calc... ) is svx and
canvastools so we'd like to merge them but we can't because we'd get
linking dependency cycle.

So what is the best strategy now ? Try to merge as much as possible ?
Or carefully choose each one?

Maybe it's better to merge more.. but I'm not sure about this.

Matúš
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Use system python 2.6 on MacOS

2011-10-10 Thread Aaron Richiger

Dear list!

I'm using libreoffice 3.4.3, which comes with python 2.3 on MacOS. But I 
need my 'normal' python 2.6 of the system because I have to import some 
new or other modules (subprocess, PySide, etc.) in my macros which are 
not supported with python 2.3!


Does anybody have any idea how to solve this and get rid of 2.3 but get 
2.6 working therefor?



Thanks a lot for your ideas or experiences!

Aaron

--
Aaron Richiger
Rosentalstr. 11
8400 Winterthur

079 613 71 78

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Declarations after statements

2011-10-10 Thread Pierre-André Jacquod

Hello,


Declarations after statements are possible only in C99. And MSVC does
not support C99 (refrain from bitching here, please).


sorry Tor, I was not enthusiasm, just systematic and from *xes world.
... and I am - almost - too young to know there was a C89 before...

If time allows, I will try during the dark winter days to compile with 
this strange outdated software called , kind of a black power as I 
heard, MSVC 2010 :-)


regards
Pierre-André
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] troubles with merging libraries

2011-10-10 Thread Michael Meeks
Hi Matus,

On Mon, 2011-10-10 at 20:22 +0200, Matúš Kukan wrote:
 I just realized (although it's quite basic thing... I was never
 thinking more about details of this merging thing)
 that we can't merge anything what we would want.

Sure - we have to merge sets of inter-dependent libraries.

 For example we have libraries linking chain:
 svx - drawninglayer - cppcanvas - canvastools
 In list of always used libs (when using writer, calc... ) is svx and
 canvastools so we'd like to merge them but we can't because we'd get
 linking dependency cycle.

Yep - we have to chuck them all into one big library. Luckily - since
they all depend on each other - we would have them all linked into core
anyway: so we can only win doing that.

 So what is the best strategy now ? Try to merge as much as possible ?
 Or carefully choose each one?

Well - I guess we should draw a line around some big chunk including
svx (a big beast), and link it all together: clearly we'd need to ensure
the UNO factory functions are disambiguated.

 Maybe it's better to merge more.. but I'm not sure about this.

The ultimate aim is to merge as much as possible to give the link-time
optimiser the best view of everything I think ...

Thanks !

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] QA session at LibreOffice conference

2011-10-10 Thread Cor Nouws

Hi Michael,

Michael Meeks wrote (10-10-11 22:15)


Looks like you're in charge :-) and/or you had a great list of
questions.


:-)


This is your chance to discuss this, you've been concerned about it for
a while, and we havn't managed to get to it. I'd really like to
understand your concerns in detail, and perhaps others have similar /
diverging views. I'm sure it is valuable.


OK, if you (too) see it like this, then we take it as the opportunity 
for better understanding and exchanging ideas and details and such.
I'll prepare myself for at least a good introduction on the topic for 
the session.


Cheers,

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] segfault in sc

2011-10-10 Thread Julien Nabet

Le 10/10/2011 21:56, Michael Meeks a écrit :

Hi Julien,

On Mon, 2011-10-10 at 20:01 +0200, Julien Nabet wrote:

In fact, I used make debug=true for the test but it was useless since I
compile the whole repo in debug (my autogen.lastrun includes these lines :

Nice :-) well that means we get wonderful debugging symbols with string
dumping  all.


I put a break on appinit.cxx:231 + break __cxa_throw, I pasted a first
part here :
http://pastebin.com/NAX6AUrJ

then a second part here :
http://pastebin.com/BBepMkcY

These are beautiful :-)


If you need more info with different break or something, don't hesitate
to tell me.

It'd be really nice to try to step through the constructor with 'n' 'n'
'n' to see where it bombs out, if you can, or ...

Here what I did :
- cd sc
- export GDBCPPUNITTRACE=gdb --args
- make -sr
- break app.cxx:309
- run
- break __cxa_throw
and here the result :
http://pastebin.com/HgZWbgx1



Thanks !

Michael.

Julien.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Declarations after statements

2011-10-10 Thread Dennis E. Hamilton
It would seem that, unless C-unique incompatibilities with C++ are involved, 
compiling as C++,
even though only C constructs are used, does the job in VC++.  One can still 
force C
calling conventions but that might take more work if C Language header files 
have not been 
adjusted to work properly with either of C/C++. 

-Original Message-
From: libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org 
[mailto:libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org] On 
Behalf Of Pierre-André Jacquod
Sent: Monday, October 10, 2011 12:06
To: Tor Lillqvist; LibreOffice List
Subject: Re: [Libreoffice] Declarations after statements

Hello,

 Declarations after statements are possible only in C99. And MSVC does
 not support C99 (refrain from bitching here, please).

sorry Tor, I was not enthusiasm, just systematic and from *xes world.
... and I am - almost - too young to know there was a C89 before...

If time allows, I will try during the dark winter days to compile with 
this strange outdated software called , kind of a black power as I 
heard, MSVC 2010 :-)

regards
Pierre-André
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


smime.p7s
Description: S/MIME cryptographic signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] segfault in sc

2011-10-10 Thread Markus Mohrhard
Hello Julien,

2011/10/10 Julien Nabet serval2...@yahoo.fr:
 Le 10/10/2011 21:56, Michael Meeks a écrit :

 Hi Julien,

 On Mon, 2011-10-10 at 20:01 +0200, Julien Nabet wrote:

 In fact, I used make debug=true for the test but it was useless since I
 compile the whole repo in debug (my autogen.lastrun includes these lines
 :

        Nice :-) well that means we get wonderful debugging symbols with
 string
 dumping  all.

 I put a break on appinit.cxx:231 + break __cxa_throw, I pasted a first
 part here :
 http://pastebin.com/NAX6AUrJ

 then a second part here :
 http://pastebin.com/BBepMkcY

        These are beautiful :-)

 If you need more info with different break or something, don't hesitate
 to tell me.

        It'd be really nice to try to step through the constructor with 'n'
 'n'
 'n' to see where it bombs out, if you can, or ...

 Here what I did :
 - cd sc
 - export GDBCPPUNITTRACE=gdb --args
 - make -sr
 - break app.cxx:309
 - run
 - break __cxa_throw
 and here the result :
 http://pastebin.com/HgZWbgx1

You did all right, you are just suffering from this incrdibly complicated test.
You suffer now from the fact thata lot of things that would be an
error in a normal libreoffice start are by design in this unit test. I
still hope that either Michael or me can reproduce that with one of
our builds because it might be one of these hidden and annoying
mistakes I made by writing some parts.

At the moment I think that Michael's point with setUp/tearDown is
perhaps the real problem. The 0x6 for the pointer in your valgrind
output looks a bit like a destructed object which pointer is later
reused. But well it would not be the first time that I'm searching in
this test for an error that is only a lifetime problem or a missing
line.

Feel free to play a bit with the unit test. I'm going to look if I can
reproduce it at my laptop(after the conference I have time for aVM
test) otherwise I'll disable the test for the conference time so that
as long as nobody has time to fix it, it does not break the build just
for a mistake in our test design.

Thanks again for your great help here.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] QA session at LibreOffice conference

2011-10-10 Thread Rainer Bielefeld

Hi,

I will no be there and am not involved into any preparations, so I do 
not know what we are talking about. Unfortunately this and next week my 
job only will leave few time for LibO activity.



[...] And usually it also are ad hoc contributions that I
make.


As we all - more or less, and I believe that's a problem we have. 
Whether a bug will reach the fixing process is rather by pure chance, 
not the result of a reliable process.



So talking about Improving the Development / QA cycle ... I feel I do
not have enough real knowledge.


Me too, I've just started to think about that. Currently I know from my 
statistics

http://wiki.documentfoundation.org/User:RBd/Workbench#Compare_Bugzilla_Activity_LibO_.3C-.3E_OOo
that approximately 80 Bugzilla bugs per day have any changes. The 
average is that approximately 6 bugs will be terminated by a fix, being 
recognized as duplicate or something else.

15 per day are new reports, see following weekly statistic
https://bugs.freedesktop.org/report.cgi?y_axis_field=cumulate=0z_axis_field=format=barx_axis_field=versionx_labels_vertical=1query_format=report-graphshort_desc_type=allwordssubstrshort_desc=product=LibreOfficelongdesc_type=allwordssubstrlongdesc=bug_file_loc_type=allwordssubstrbug_file_loc=status_whiteboard_type=allwordssubstrstatus_whiteboard=keywords_type=allwordskeywords=resolution=FIXEDresolution=WONTFIXresolution=DUPLICATEresolution=WORKSFORMEresolution=MOVEDresolution=NOTABUGresolution=NOTOURBUGresolution=---emailassigned_to1=1emailtype1=substringemail1=emailassigned_to2=1emailreporter2=1emailqa_contact2=1emailcc2=1emailtype2=substringemail2=bugidtype=includebug_id=chfieldfrom=-7dchfieldto=-0dchfield=[Bug+creation]chfieldvalue=action=wrapfield0-0-0=nooptype0-0-0=noopvalue0-0-0=
but what exactly is the other activity, is that methodical or 
accidently, is there a possibility to organize the process more efficient?


I'm thinking about that and hope that we can discuss that soon in a 
group of users with significant QA / Bug confirming activity. 
Preparations are on the way (with very small steps).



But then Rainer would be at least as good as me for that?


I'll be absent, sigh ...

Hope you will have some interesting days,

cheers

Rainer
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] db test VM (was: automated testing of Base)

2011-10-10 Thread Michael Meeks

On Mon, 2011-10-10 at 12:36 +0200, Petr Mladek wrote:
 Is is supposed for testing of the openSUSE LO packages or
 the plain LO build?

The plain build I suggest.

 Is the testing automatic or manual?

Automatic via openQA (which is awesome but well hidden ;-)

 Also I wonder where to report bugs. I would prefer
 https://bugs.freedesktop.org/ if the bugs are in the plain
 build as well.

Sounds reasonable to me.

 One possibility would be to use night builds from the plain build.

Yep; I guess we could prolly openQA script their download / 
install.

Thanks !

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


[Libreoffice-bugs] [Bug 41599] contrib: Add available dictionary for language Pāli

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41599

--- Comment #8 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2011-10-10 01:43:52 PDT ---
 However, the many transliterations listed in comment 6 cannot be supported
 correctly until LibreOffice adopts BCP47 standard. For the time being I can 
 add
 language 'pli'. 

I think that's the thing we should do now, and wehn we have a new situation, we
will find a new solution.

 I think it would be better to create an extension from this dictionary and not
 to add it to default LibreOffice install.

András:
Yes, I agree. We rugently need a working dictionary repository, the current
solution with link to ooo-planet is a mess.do you know any plans? I will also
ask on webs...@global.libreoffice.org

@Jean-Francois Romang
Did you call your languages in comment 6 pli intended or accidently? Why not
Pāli? or do I understand something wrong?

If you have problems to create a working .oxt you should ask on mailing lists.
But I believe your .zip should also work, I will check with next available WIN
dev-build wiht Language

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 37024] UI: WEB-View for Form layout no longer available

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37024

Noel Power nopo...@novell.com changed:

   What|Removed |Added

 AssignedTo|nopo...@novell.com  |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #11 from Noel Power nopo...@novell.com 2011-10-10 01:44:43 PDT ---
(In reply to comment #10)
[...]
 @Noel:
 I saw you active in some UI bugs looking similar to me.
 Please feel free to reassign (or reset Assignee to default) if it’s not your
 area or if provided information is not sufficient. Please set Status to
 ASSIGNED if you accept this Bug.
well I don't really know anything about form and/or odb layout stuff. For the
toolbar entries isn't this a separate problem that deserves it's own issue ( or
perhaps I misunderstood the descriptions above )

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41599] contrib: Add available dictionary for language Pāli

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41599

--- Comment #9 from Jean-Francois Romang jeanfrancois.rom...@gmail.com 
2011-10-10 01:52:31 PDT ---
(In reply to comment #8)
  However, the many transliterations listed in comment 6 cannot be supported
  correctly until LibreOffice adopts BCP47 standard. For the time being I can 
  add
  language 'pli'. 
 
 I think that's the thing we should do now, and wehn we have a new situation, 
 we
 will find a new solution.
 
  I think it would be better to create an extension from this dictionary and 
  not
  to add it to default LibreOffice install.
 
 András:
 Yes, I agree. We rugently need a working dictionary repository, the current
 solution with link to ooo-planet is a mess.do you know any plans? I will also
 ask on webs...@global.libreoffice.org
 
 @Jean-Francois Romang
 Did you call your languages in comment 6 pli intended or accidently? Why not
 Pāli? or do I understand something wrong?
 
 If you have problems to create a working .oxt you should ask on mailing lists.
 But I believe your .zip should also work, I will check with next available WIN
 dev-build wiht Language

I called the language 'pli' because it seems to be the ISO 639-3 code ; the
correct human readable name soulh be  'Pāli'.

Thanks for checking !

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41489] FILEOPEN: Incorrect display of .xls spreadsheets

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41489

--- Comment #4 from Ivan nomad.the.corovan...@gmail.com 2011-10-10 02:26:24 
PDT ---
Um, anyone?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 37987] FORMATTING EDITING Calc Conditional Formatting - Incorrect cell references after line or column insertions

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37987

Dnk1287 dnk1...@yahoo.com changed:

   What|Removed |Added

Version|LibO 3.3.2 release  |LibO 3.4.3 release
 OS/Version|Linux (All) |Windows (All)

--- Comment #1 from Dnk1287 dnk1...@yahoo.com 2011-10-10 02:58:06 PDT ---
I confirm behaviour witj LO 3.4.3 (release) and Windows O/S.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41642] New: Impress crash due to stack exhaustion

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41642

   Summary: Impress crash due to stack exhaustion
   Product: LibreOffice
   Version: LibO 3.4.3 release
  Platform: All
OS/Version: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: Libreoffice
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: huzai...@redhat.com
CC: caol...@redhat.com


Created an attachment (id=52167)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=52167)
crasher slidedeck

Found this bug during my fuzzing. gdb suggests stack exhaustion here, could not
see any traces of memory corruption, but i could be wrong :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 38807] [EasyHack] Get rid of duplicated VBA related import functiona

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38807

Noel Power nopo...@novell.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #1 from Noel Power nopo...@novell.com 2011-10-10 03:00:37 PDT ---
wasn't really an easy hack and in the end the confusion of having the 2 filter
implementations was too much for me so this is now fixed on master

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41643] New: EDITING: No simple way to remove links

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41643

   Summary: EDITING: No simple way to remove links
   Product: LibreOffice
   Version: LibO 3.4.3 release
  Platform: Other
OS/Version: All
Status: NEW
  Severity: enhancement
  Priority: medium
 Component: Writer
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: paolobe...@gmail.com


Suppose you have a text like a web page, which has many hyperlinks in it, and
you paste it in your document: the hyperlink remain in the text.

In order to remove them you can either:
- select all the text, put a global hyperlink, and remove it
- go to every hyperlinked text and remove the hyperlink from it

You have no way to remove all the hyperlinks.

A remove button in the format - character - link tab would do the work and
make the user happy!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 34016] Keyboard not working with ibus when using KDE4 integration

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=34016

Lubos Lunak l.lu...@suse.cz changed:

   What|Removed |Added

 AssignedTo|libreoffice-b...@lists.free |l.lu...@suse.cz
   |desktop.org |

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 39784] After upgrade to KDE 4.7 all tooltips in LibreOffice are black on black and illegible (theme regression)

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39784

Lubos Lunak l.lu...@suse.cz changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE

--- Comment #3 from Lubos Lunak l.lu...@suse.cz 2011-10-10 03:24:53 PDT ---


*** This bug has been marked as a duplicate of bug 40461 ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 39781] Tooltips in the kde4 frontend are rendered incorrectly

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39781

Lubos Lunak l.lu...@suse.cz changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE

--- Comment #1 from Lubos Lunak l.lu...@suse.cz 2011-10-10 03:27:58 PDT ---


*** This bug has been marked as a duplicate of bug 40461 ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 38985] Scrollbar issues in KDE with two scroll buttons at one end

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38985

Lubos Lunak l.lu...@suse.cz changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #1 from Lubos Lunak l.lu...@suse.cz 2011-10-10 03:33:42 PDT ---
This has already been fixed in a newer version.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 30966] Slideshow with 3D OpenGL Transitions froze Impress

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=30966

--- Comment #5 from Mateusz quest...@o2.pl 2011-10-10 08:55:52 PDT ---
(In reply to comment #4)
 @Mateusz
 Still a problem for you?

Yes but now all effect from ogl-trans extension doesn't work. 

Just doesn't see any effect, at all! I push play or slide show and nothing
happens.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 30966] Slideshow with 3D OpenGL Transitions froze Impress

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=30966

--- Comment #6 from Mateusz quest...@o2.pl 2011-10-10 08:57:09 PDT ---
(In reply to comment #4)
 @Mateusz
 Still a problem for you?

Yes but now all effect from ogl-trans extension doesn't work. 

Just doesn't see any effect, at all! I push play or slide show and nothing
happens.

I have LibreOffice 3.4.3, OOO340m1 (Build:302) and Ubuntu 10.04 LTS.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 37987] FORMATTING EDITING Calc Conditional Formatting - Incorrect cell references after line or column insertions

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37987

Christopher M. Penalver christopher.penal...@gmx.com changed:

   What|Removed |Added

Version|LibO 3.4.3 release  |LibO 3.3.2 release
 OS/Version|Windows (All)   |All

--- Comment #2 from Christopher M. Penalver christopher.penal...@gmx.com 
2011-10-10 09:04:08 PDT ---
Dnk1287, please do not toggle the version. For more details please see
http://wiki.documentfoundation.org/BugReport_Details#Version

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41646] Contextual spell-checking menu doesn't show accept or reject options for changes

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41646

Christopher M. Penalver christopher.penal...@gmx.com changed:

   What|Removed |Added

 CC||christopher.penal...@gmx.co
   ||m
   See Also||https://launchpad.net/bugs/
   ||871603

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41657] New: Inserting Powerpoint file into LibreOffice Impress CRASHES every time FILEOPEN

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41657

   Summary: Inserting Powerpoint file into LibreOffice Impress
CRASHES every time FILEOPEN
   Product: LibreOffice
   Version: LibO 3.4.3 release
  Platform: x86-64 (AMD64)
OS/Version: Mac OS X (All)
Status: NEW
  Severity: critical
  Priority: medium
 Component: Presentation
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: vossma...@yahoo.com


Steps to reproduce:

1. Open libreOffice Impress file
2. Insert-File...
3. Select Powerpoint file
4. Crash

Have not tested on other systems.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41657] Inserting Powerpoint file into LibreOffice Impress CRASHES every time FILEOPEN

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41657

--- Comment #1 from Vossman vossma...@yahoo.com 2011-10-10 09:58:42 PDT ---
Created an attachment (id=52187)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=52187)
presentation test file, insert into this

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41657] Inserting Powerpoint file into LibreOffice Impress CRASHES every time FILEOPEN

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41657

--- Comment #2 from Vossman vossma...@yahoo.com 2011-10-10 09:59:14 PDT ---
Created an attachment (id=52188)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=52188)
powerpoint file to insert into presentation file

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 37121] libreoffice repeatedly freezes after resuming laptop from sleep

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37121

--- Comment #2 from cory dodt freedesk...@s.goonmill.org 2011-10-10 11:34:56 
PDT ---
(In reply to comment #1)
 Just thought I'd post that I cannot find a good workaround. I did find a *bad*
 workaround, which is to let the power management daemon just kill off 
 soffice. 
 
 The reason this is better than the current bug is that the current bug has the
 potential to completely hang the system if you fail to kill soffice quickly.
 It's horrible, but I haven't found anything else that works. (One poster in 
 the
 original launchpad bug suggested using compiz -replace in a pm.d script, but
 that did not work for me.)
 
 Bad workaround
 --
 Create a file:
 sudo touch /etc/pm.d/sleep.d/20_kill_soffice
 sudo chmod +x /etc/pm.d/sleep.d/20_kill_soffice
 
 Add these contents:
 
 #!/bin/bash
 
 PATH=/sbin:/usr/sbin:/bin:/usr/bin
 
 SELF=kill-soffice
 COMMAND=
 
 # pm-action(8) - action suspend method
 #
 # On suspend|hibernate, kill soffice due to compiz-related hang:
 # 
 https://bugs.launchpad.net/ubuntu/+source/nvidia-graphics-drivers-180/+bug/185600
  
 
 case ${1} in
 hibernate)
 ;;
 resume|thaw)
 # hope soffice's recovery function works.
 pkill -f soffice.bin
 ;;
 esac

Line breaks got a little messed up - you will have to delete the line where I
mention the bug URL, as that was supposed to be a comment.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41642] Impress crash due to stack exhaustion

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41642

--- Comment #2 from Caolán McNamara caol...@redhat.com 2011-10-10 12:55:31 
PDT ---
looks like a loop in the structured storage loader, seen this sort of thing
before, typically because it the chain *is* actually looped.

Some loop detection probably required

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41661] New: Image misplaced in PDF export

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41661

   Summary: Image misplaced in PDF export
   Product: LibreOffice
   Version: LibO 3.4.3 release
  Platform: x86 (IA32)
OS/Version: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: Writer
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: bal...@balintreczey.hu


Created an attachment (id=52197)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=52197)
Original document

When exporting the attached document the 3rd image gets misplaced.
It is at the expected location upon printing to a file.

I use 1:3.4.3-3~bpo60+1 on Debian Squeeze.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41661] Image misplaced in PDF export

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41661

--- Comment #2 from Réczey Bálint bal...@balintreczey.hu 2011-10-10 13:44:37 
PDT ---
Created an attachment (id=52199)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=52199)
Printed PDF

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 31746] Text boxes of background DRAWING object in particular documents not visible

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31746

--- Comment #10 from mhonline mh...@gmx.net 2011-10-10 19:09:39 PDT ---
@Rainer

no idea.
And that file is crashing LO 3.4.3 too, when you hit discard changes

As the file-structur is really different in new and old ODF, I am quite sure it
is the process doing the transformation to the new object-order. (the idea, but
I am no coder) 

m.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41667] New: EDITING: Calc crashes when modifying a named range

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41667

   Summary: EDITING: Calc crashes when modifying a named range
   Product: LibreOffice
   Version: LibO 3.4.3 release
  Platform: Other
OS/Version: All
Status: UNCONFIRMED
 Status Whiteboard: BSA
  Severity: normal
  Priority: medium
 Component: Spreadsheet
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: jo...@jorgee.net


Steps to reproduce:
1. Create a new spreadsheet file, type any value on cell A1
2. Insert  Names  Define 
3. Define a range named 'Test01', assigned to cell '$Sheet1.$A$1'
4. Insert  Names  Define
5. Select name range 'Test01', click 'Modify' button (behavior doesn't change
whether the range is actually modified or left as is).

Current behavior:
LibreOffice closes immediately.

Expected behavior:
Named range 'Test01' is assigned new range.

Platform (if different than the browser): 
Ubuntu 11.04 Natty Narwhal  
Browser: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20100101 Firefox/7.0.1

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41667] EDITING: Calc crashes when modifying a named range

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41667

--- Comment #1 from Jorge E. Gómez jo...@jorgee.net 2011-10-10 19:39:55 PDT 
---
Forgot to mention: deleting the named range works as expected; it's just
modifying it that crashes Calc.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 31743] grouped drawing-objects are not protected against editing

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31743

--- Comment #4 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2011-10-10 22:04:22 PDT ---
@mhonline:
What question has been unintelligible - exact reproduction instructions or
requested additional information? 

I am pretty sure that you simply have checked menu 'Tools - Options - Draw -
General - Text objects -  Allow quick editing'. Please check!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41667] EDITING: Calc crashes when modifying a named range

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41667

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution||DUPLICATE
 CC||LibreOffice@bielefeldundbus
   ||s.de

--- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2011-10-10 22:10:43 PDT ---
This one seems to be a DUP of Bug 40909 - CRASH when updating defined name's
range (EDITING)

@reporter:
Please feel free to reopen this Bug if you find evidence that we have an
independent issue here.

*** This bug has been marked as a duplicate of bug 40909 ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 40909] CRASH when updating defined name's range (EDITING)

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40909

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 CC||jo...@jorgee.net

--- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2011-10-10 22:10:43 PDT ---
*** Bug 41667 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 40780] Sound fails to play on custom animation

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40780

Christopher M. Penalver christopher.penal...@gmx.com changed:

   What|Removed |Added

Version|unspecified |LibO 3.3.2 release
 CC||christopher.penal...@gmx.co
   ||m
   See Also||https://launchpad.net/bugs/
   ||823155

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41370] EDITING: DOuble CApital COrrection don't work

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41370

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME

--- Comment #7 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2011-10-10 22:51:24 PDT ---
@Wirawan Purwanto: Still missing info

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41354] VIEWING: OOo graphics in LO

2011-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41354

--- Comment #4 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2011-10-10 22:56:33 PDT ---
My mistake, wanted to write NOT reproducible] with LibreOffice 3.4.3

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs