Re: [Libreoffice] [Libreoffice-qa] New Windows tinderbox: Windows 2008R2

[Rainer Bielefeld]

Michael Meeks schrieb:


I believe we switched our packaging format from NSIS .exe's to the
new .msi installs that you see now.



Hi,

the problem simply might be missing manual. We have a "how to" on 
 for 
doing a server installation with "setup.exe", and as soon as we have a 
description how to get the same result with the .msi the problem has 
been solved.


Kind regards

Rainer

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] I need some advice to fix fdo#40363

[Jean-Baptiste Faure]

Hi Regina, Kohei,

Le 28/11/2011 22:00, Regina Henschel a écrit :
> Hi Kohei,
> 
> Kohei Yoshida schrieb:
> [..]
>>
>> My conclusion?  No idea what advice I should give you to get it fixed
>> just yet.  Maybe someone else knows the work that Oracle has done to the
>> chart2 module after 3.3&  give us some background?
> 
> From the release notes [1] I guess, that it is the feature to have date
> category axis [2]. That would be CWS chart46 from Ingrid Halama around
> 2010-11-30.

There is several modifications by Ingrid Halana mentioned in git logs
but it is not clear for me if they are integrated in LibO 3.3.x or not.

> 
> [1] http://development.openoffice.org/releases/DEV300m106_snapshot.html
> [2] https://issues.apache.org/ooo/show_bug.cgi?id=25706

Very interesting infos.

Thank you.
Best regards.
JBF

-- 
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] I need some advice to fix fdo#40363

[Jean-Baptiste Faure]

Hi Eike,

Le 29/11/2011 00:35, Eike Rathke a écrit :
> Hi Jean-Baptiste,
> 
> On Monday, 2011-11-28 13:43:51 +0100, Jean-Baptiste Faure wrote:
> 
>> The bug described in fdo#40363 may occur if you make a typo when type
>> some dates in Calc.
> 
> Thanks for investigating, I'll dig into that.

Thank you.
> 
>> If I modify Date::IsValid so that only dates strictly between 1582-10-05
>> and 1582-10-15 are not valid, then the chart wizard works without problem.
> 
> Interesting.. but probably similar problems arise when the date would go
> negative. Or earlier..

In this case, when the year reach 0 it stay there. If I read well with
my little C++ knowledge (really, I am learning C++) Date operator --
does nothing if the day number is not > 1.

Best regards.
JBF
-- 
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 32826, which changed state.

Bug 32826 Summary: Printing in Preview mode causes all sheets to be printed
https://bugs.freedesktop.org/show_bug.cgi?id=32826

   What|Old Value   |New Value

 Resolution||FIXED
 Status|ASSIGNED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] git: backporting/cherry-picking a patch across different repositories

[Lionel Elie Mamane]

On Mon, Nov 28, 2011 at 11:46:44PM +0100, Eike Rathke Dwrote:
> On Monday, 2011-11-28 10:39:25 +0100, Lionel Elie Mamane wrote:

>> ~/src/libreoffice/libreoffice-3.4/clone/filters$ ( cd 
>> ~/src/libreoffice/core/; git format-patch --stdout 
>> b645f9195f4da3014e001fb27b8a117d89c8f389^1..b645f9195f4da3014e001fb27b8a117d89c8f389
>>  ) | git am -s

> Just a hint: with format-patch option -1 you don't need to specify the
> commit twice to form a range, so

> ~/src/libreoffice/libreoffice-3.4/clone/filters$ ( cd 
> ~/src/libreoffice/core/; git format-patch --stdout -1 
> b645f9195f4da3014e001fb27b8a117d89c8f389 ) | git am -s

Ah, thanks, that's indeed more practical to type.

Also, I've just lived on another backport that the patch failed to
apply because of tabs vs spaces... In that case:

git am --abort
Repeat the command adding the --ignore-space-change option to the "git
am" call.

-- 
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Removing uses of OUString::setCharAt

[August Sodora]

Thanks! I've attached another one that should leave only a few more
uses to clean up, mostly with macos-related code. I didn't push this
myself because I really wanted to make sure all the bounds checking is
correct.

August Sodora
aug...@gmail.com
(201) 280-8138



On Mon, Nov 28, 2011 at 12:30 PM, August Sodora  wrote:
>> looks good, pushed now - except for the svl/source/misc/lngmisc.cxx
>> snippet which was based on older code it seems, dropped that part
>> entirely.
>
> Yeah, sorry about that part. I decided it was worth it to write some
> tests for those functions and use that as the basis for cleaning it
> up.
>
> August Sodora
> aug...@gmail.com
> (201) 280-8138
>
>
>
> On Mon, Nov 28, 2011 at 9:01 AM, Thorsten Behrens
>  wrote:
>> August Sodora wrote:
>>> Tonight I tried to remove some uses of setCharAt so that it can
>>> eventually be removed, and I ran across a few cases that I would like
>>> to get another pair of eyes on. Especially in one particular case, I
>>> added a guard to make sure that the index was within range and I want
>>> to make sure that it is necessary or if something more involved is
>>> required. The patch is attached, and I remembered to add [PATCH] to
>>> the subject this time :)
>>>
>> Hi August,
>>
>> looks good, pushed now - except for the svl/source/misc/lngmisc.cxx
>> snippet which was based on older code it seems, dropped that part
>> entirely.
>>
>> Thanks a lot, looking forward for more! :)
>>
>> -- Thorsten
>>
>
From ffa6923cf3e58ca55a907b902684509170d8f6ab Mon Sep 17 00:00:00 2001
From: August Sodora 
Date: Mon, 28 Nov 2011 21:44:30 -0500
Subject: [PATCH] Remove uses of charAt

---
 basegfx/source/polygon/b2dsvgpolypolygon.cxx   |4 +-
 chart2/source/tools/TitleHelper.cxx|2 +-
 chart2/source/view/main/ShapeFactory.cxx   |3 +-
 connectivity/source/parse/sqlnode.cxx  |   12 
 dbaccess/source/filter/xml/xmlExport.cxx   |4 +-
 oox/source/xls/worksheetbuffer.cxx |2 +-
 registry/source/keyimpl.cxx|2 +-
 sal/rtl/source/uri.cxx |2 +-
 .../ui/Accessibility/AccessibleCsvControl.cxx  |6 ++--
 scaddins/source/datefunc/datefunc.cxx  |2 +-
 sdext/source/pdfimport/tree/writertreevisiting.cxx |7 +++--
 svl/source/misc/urihelper.cxx  |2 +-
 tools/source/fsys/urlobj.cxx   |   13 -
 vcl/unx/x11/x11sys.cxx |4 +-
 xmloff/source/style/xmlnumfi.cxx   |   26 ++--
 15 files changed, 45 insertions(+), 46 deletions(-)

diff --git a/basegfx/source/polygon/b2dsvgpolypolygon.cxx b/basegfx/source/polygon/b2dsvgpolypolygon.cxx
index 931c344..7a34219 100644
--- a/basegfx/source/polygon/b2dsvgpolypolygon.cxx
+++ b/basegfx/source/polygon/b2dsvgpolypolygon.cxx
@@ -190,9 +190,9 @@ namespace basegfx
 fValue -= fOldValue;
 
 const sal_Int32 aLen( rStr.getLength() );
-if(aLen)
+if(aLen > 0)
 {
-if( lcl_isOnNumberChar(rStr.charAt(aLen - 1), false) &&
+if( lcl_isOnNumberChar(rStr[aLen - 1], false) &&
 fValue >= 0.0 )
 {
 rStr.append( sal_Unicode(' ') );
diff --git a/chart2/source/tools/TitleHelper.cxx b/chart2/source/tools/TitleHelper.cxx
index e78bce5..aa8e6af 100644
--- a/chart2/source/tools/TitleHelper.cxx
+++ b/chart2/source/tools/TitleHelper.cxx
@@ -285,7 +285,7 @@ void TitleHelper::setCompleteString( const rtl::OUString& rNewText
 sal_Int32 nLen = rNewText.getLength();
 for( sal_Int32 nPos = 0; nPos < nLen; ++nPos )
 {
-sal_Unicode aChar = aSource.charAt( nPos );
+sal_Unicode aChar = aSource[nPos];
 if( aChar != '\n' )
 {
 aUnstackedStr.append( aChar );
diff --git a/chart2/source/view/main/ShapeFactory.cxx b/chart2/source/view/main/ShapeFactory.cxx
index d2f1c6e..0af3918 100644
--- a/chart2/source/view/main/ShapeFactory.cxx
+++ b/chart2/source/view/main/ShapeFactory.cxx
@@ -2245,7 +2245,6 @@ rtl::OUString ShapeFactory::getStackedString( const rtl::OUString& rString, bool
 return rString;
 
 rtl::OUStringBuffer aStackStr;
-rtl::OUStringBuffer aSource(rString);
 
 //add a newline after each letter
 //as we do not no letters here add a newline after each char
@@ -2253,7 +2252,7 @@ rtl::OUString ShapeFactory::getStackedString( const rtl::OUString& rString, bool
 {
 if( nPosSrc )
 aStackStr.append( sal_Unicode('\r') );
-aStackStr.append( aSource.charAt( nPosSrc ) );
+aStackStr.append(rString[nPosSrc]);
 }
 return aStackStr.makeStringAndClear();
 }
diff --git a/connectivity/source/parse/sqlnode.cxx b/connectivity/source/parse/sqlnode.cxx
index 5571bb6..dfc3796 100644
---

Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list

[Olivier Hallot]

(I forgot to attach the patch)

--
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812

>From 1ad41faf91e8c82b812b0135cca3374eae9e8db6 Mon Sep 17 00:00:00 2001
From: Olivier Hallot 
Date: Mon, 28 Nov 2011 22:35:31 -0200
Subject: [PATCH] Fix for fdo39748, part II

Code clenup
Improvement on extension list box size calculation
---
 desktop/source/deployment/gui/dp_gui.hrc |1 -
 desktop/source/deployment/gui/dp_gui_dialog2.cxx |   12 ++--
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/desktop/source/deployment/gui/dp_gui.hrc b/desktop/source/deployment/gui/dp_gui.hrc
index 0419e63..744cd21 100644
--- a/desktop/source/deployment/gui/dp_gui.hrc
+++ b/desktop/source/deployment/gui/dp_gui.hrc
@@ -48,7 +48,6 @@
 #define RID_EM_FT_GET_EXTENSIONS   20
 #define RID_EM_FT_PROGRESS 21
 #define RID_EM_FT_MSG  22
-#define RID_EM_BTN_SELECT  23
 
 // local RIDs:
 #define PB_LICENSE_DOWN 50
diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.cxx b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
index fe92e19..23430b7 100644
--- a/desktop/source/deployment/gui/dp_gui_dialog2.cxx
+++ b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
@@ -1221,6 +1221,8 @@ void ExtMgrDialog::Resize()
 aDivSize.Width() = aTotalSize.Width() - aFTTypeOfExtSize.Width() - RSC_SP_DLG_INNERBORDER_LEFT - RSC_SP_DLG_INNERBORDER_RIGHT;
 m_aDivider2.SetPosSizePixel( aPos , aDivSize );
 
+
+
 aPos.X() = aTotalSize.Width() - RSC_SP_DLG_INNERBORDER_RIGHT - aBtnSize.Width();
 m_aCancelBtn.SetPosPixel( Point( aPos.X(), aPos.Y() - ((aBtnSize.Height()-aFTSize.Height())/2) ) );
 
@@ -1256,12 +1258,11 @@ void ExtMgrDialog::Resize()
 m_aProgressText.SetPosSizePixel( aPos, aFTSize );
 
 Size aSize( aTotalSize.Width() - RSC_SP_DLG_INNERBORDER_LEFT - RSC_SP_DLG_INNERBORDER_RIGHT,
-aTotalSize.Height() - 3.3*aBtnSize.Height() - LINE_SIZE -
-RSC_SP_DLG_INNERBORDER_TOP - 3*RSC_SP_DLG_INNERBORDER_BOTTOM );
-
-m_pExtensionBox->SetSizePixel( aSize );
-
+aTotalSize.Height() - aBtnSize.Height() - LINE_SIZE - aFTSize.Height()
+- aCBSize.Height() - aFTTypeOfExtSize.Height()
+- RSC_SP_DLG_INNERBORDER_TOP - 5*RSC_SP_DLG_INNERBORDER_BOTTOM );
 
+m_pExtensionBox->SetSizePixel(aSize );
 
 }
 //--
@@ -1653,7 +1654,6 @@ void UpdateRequiredDialog::Resize()
 Size aDivSize( aTotalSize.Width(), LINE_SIZE );
 aPos = Point( 0, aPos.Y() - LINE_SIZE - RSC_SP_DLG_INNERBORDER_BOTTOM );
 m_aDivider.SetPosSizePixel( aPos, aDivSize );
-aPos = Point( 0, 5 );
 
 // Calc fixed text size
 aPos = Point( RSC_SP_DLG_INNERBORDER_LEFT, RSC_SP_DLG_INNERBORDER_TOP );
-- 
1.7.5.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list

[Olivier Hallot]

Hi Michael

Em 28-11-2011 18:18, Michael Meeks escreveu:



Some post-commit I missed (I don't know how to fix a patch):

in /desktop/source/deployment/gui/dp_gui.hrc, please drop the line

+#define RID_EM_BTN_SELECT  23

in /desktop/source/deployment/gui/dp_gui_dialog2.cxx, please drop the line

+aPos = Point( 0, 5 );

Any chance you could knock up a new patch to do that ? also it might be
good if:

+IMPL_LINK( ExtMgrDialog, HandleExtTypeCbx, void*, EMPTYARG )

returns 0 instead of 1 - it seems the value is ignored anyway, and 0
might be more ignoreable when read ? :-)


Well I did what other event handlers did a couple of lines above and 
below... They return 1. Do I need to change all of them?




Of course, the UX guys may have some advice :-) I wonder if (perhaps)
there is just a little bit too much grey space between the bottom of the
list box, and the "Types of extensions" widget (?) They might also have
some advice on the defaults - should we show built-in extension by
default (eg.) ?


OK, back to the math notepad for a better listbox size calculation. 
Tested with fontsize 13 and 10. Patch attached


About the defaults, I set it to be the same as the previous extension 
manager dialog.




Anyhow - it looks great; no doubt we should add this to:

http://wiki.documentfoundation.org/ReleaseNotes/3.5

With suitable credits etc.&  close the bug.


Will do.
Kind Regards

--
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Fix for dialog Manage Breakpoints crash

[Eike Rathke]

Hi Niklas,

On Monday, 2011-11-28 12:27:16 +0100, Niklas Johansson wrote:

> In worst case it makes the program crash. This fix, stores
> the values. I'm not that experienced with C++ so could someone have
> a second look at this there might very well be a "cleaner" way of
> writing it.

Good find!

I think I would do it slightly different, the patch fixes the symptom
correctly by allocating new objects, but the underlying cause to me
seems that the original intention was to transfer the pointers (hence
the method's name) but that somehow got mangled with the transition from
old List to ::std::vector


> --- a/basctl/source/basicide/bastypes.cxx
> +++ b/basctl/source/basicide/bastypes.cxx
> @@ -288,7 +288,7 @@ void BreakPointList::transfer(BreakPointList & rList)
>  {
>  reset();
>  for (size_t i = 0; i < rList.size(); ++i)
> -maBreakPoints.push_back( rList.at( i ) );
> +maBreakPoints.push_back( new BreakPoint(*rList.at( i )) );
>  rList.reset();
>  }

Instead of creating copies I'd do

-  rList.reset();
+  rList.clear();

Please check if that fixes the problem.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpffxBcuhXLL.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] I need some advice to fix fdo#40363

[Eike Rathke]

Hi Jean-Baptiste,

On Monday, 2011-11-28 13:43:51 +0100, Jean-Baptiste Faure wrote:

> The bug described in fdo#40363 may occur if you make a typo when type
> some dates in Calc.

Thanks for investigating, I'll dig into that.

> If I modify Date::IsValid so that only dates strictly between 1582-10-05
> and 1582-10-15 are not valid, then the chart wizard works without problem.

Interesting.. but probably similar problems arise when the date would go
negative. Or earlier..

> I do not understand why every dates before 1582-10-15 should not be
> valid when only dates from 1582-10-05 to 1582-10-14 do not exist due to
> the switch from julian calendar to gregorian calendar.

Well, the Date class was never declared to work with dates earlier than
when the Gregorian calendar sprang into existence ;-)

> Now, my question is what to do? Is it a good idea to modify
> Date::IsValid in tdate.cxx without knowing why it works in LibO 3.3 ?

I don't think so. More promising probably would be to switch to a real
calendar.. I may take a stab at that.  But first investigate how Chart
and Calc interface there.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgp7j56TwqjML.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] numbers auto format as date

[Eike Rathke]

Hi Lior,

On Sunday, 2011-11-27 11:32:47 +0200, Lior Kaplan wrote:

> I'd like to inquire about a group of related bugs which are all due to
> calc's auto format of numbers to date, which in some cases also changes the
> number itself. Do we target these for the 3.5 life time ?

No, but I'm about to target it for master / next release (3.6)

Thanks for the list of pointers, at least one of them was of my old
reminder list ;-)  search for NF-DATE in (A)OOo tracker.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgp6fPbng4mN3.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Cherry pick a commit for fdo 43263

[Eike Rathke]

Hi Lionel,

On Monday, 2011-11-28 10:39:25 +0100, Lionel Elie Mamane wrote:

> ~/src/libreoffice/libreoffice-3.4/clone/filters$ ( cd 
> ~/src/libreoffice/core/; git format-patch --stdout 
> b645f9195f4da3014e001fb27b8a117d89c8f389^1..b645f9195f4da3014e001fb27b8a117d89c8f389
>  ) | git am -s

Just a hint: with format-patch option -1 you don't need to specify the
commit twice to form a range, so

~/src/libreoffice/libreoffice-3.4/clone/filters$ ( cd ~/src/libreoffice/core/; 
git format-patch --stdout -1 b645f9195f4da3014e001fb27b8a117d89c8f389 ) | git 
am -s

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpoPTpcG8JAI.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] libreoffice sdk 3.4 and SWT Linux issue

[othman]

Sorry for being late to reply to this thread. but this is an important bug
that needs to be fixed.
I'm not sure how to attach the soffice.bin process with gdb?  in fact i run
my OO addon from netbeans IDE. is there a way i can have netbeans OO plugin
to output debug info in output console of netbeans.

I really need help fixing this frustrating bug! it took me now a month and
yet couldn't figure out what's the problem.

--
View this message in context: 
http://nabble.documentfoundation.org/libreoffice-sdk-3-4-and-SWT-Linux-issue-tp3407355p3543639.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

[Eike Rathke]

Hi Pierre-André,

On Sunday, 2011-11-27 20:23:33 +0100, Pierre-André Jacquod wrote:

> >I wouldn't say it's wrong unless I checked the original intention behind
> >that code when GetDataArea() is called with bIncludeOld=false, maybe
> >it's just the call in ExtendDataArea() that should pass true instead?
> 
> Done, you're right.
> Finally, changed the call of the flags and documented the flags' meaning.
> If you could cherry-pick 88611e702a18d2 for 3.4.5, would be nice.

Now you also changed bOnlyDown=false to bOnlyDown=true, which leads to
not include newly appended columns of an area. Why?


> >>Further some tests have shown me that the behaviour
> >>(regarding area) is not the same, depending if the filter is
> >>activated with Data->Filter->AutoFilter or Standard filter. I fear
> >>some parts will need to be quite overhauled.
> >
> >And the difference exactly is ...?
> 
> Visually: the standard filter adapts and shows the selected area at
> activation of the filter, the auto-filter does not reflect the fact
> that it will take into account a wider area. This area extension
> happens only when the drop-down button is activated and the list of
> possible value is calculated...  and the area extended.

Probably because people want a selection within an auto-filtered area to
stay active and nevertheless filter for new values. Reselecting the
entire data area in that moment isn't a good user-experience.


> Out of subject: from a user perspective, I am not convinced from te
> fact that the filter is allowed to change an area that has been
> user-defined. No problem to auto-extend an area if auto-determined.
> But if a user takes the time to do the area, this should be "holly".
> But this point belongs to the user-interface list I guess...

Grounded speculation: if user adds a column or row immediately adjacent
to a data area it is usually related to the already existing data and
she wants that to be included, maybe even doesn't know that earlier the
filter was setup using a selection.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpNyoc15PpTQ.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Orion Poplawski  changed:

   What|Removed |Added

 Depends on||42958

--- Comment #236 from Orion Poplawski  2011-11-28 14:13:05 
UTC ---
Nominate bug 42958 3.3 -> 3.4 regression with xls formatting

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] I need some advice to fix fdo#40363

[Regina Henschel]

Hi Kohei,

Kohei Yoshida schrieb:

On Mon, 2011-11-28 at 21:56 +0100, Regina Henschel wrote:

Hi Kohei,

Kohei Yoshida schrieb:
[..]


My conclusion?  No idea what advice I should give you to get it fixed
just yet.  Maybe someone else knows the work that Oracle has done to the
chart2 module after 3.3&   give us some background?


   From the release notes [1] I guess, that it is the feature to have date
category axis [2]. That would be CWS chart46 from Ingrid Halama around
2010-11-30.

[1] http://development.openoffice.org/releases/DEV300m106_snapshot.html
[2] https://issues.apache.org/ooo/show_bug.cgi?id=25706


Thanks for the info.

So, they've added a date axis which is new post-3.3.

Which also means we need to devise a new fix for this i.e. no need to
look back into the 3.3 code base, which didn't have that feature.



This feature was first in DEV300m99 and it has this bug from the 
beginning. So it is nothing, that LibreOffice has introduced.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Assertions and Logging

[Michael Stahl]

On 28/11/11 14:43, Caolán McNamara wrote:
> On Mon, 2011-11-28 at 12:51 +0100, Michael Stahl wrote:
>> finally, i have deployed our new aborting assertions for some definitely
>> wrong cases in SwIndex:
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d2a6999fc320843e4db0c99d961414416a8451c
> 
> And I have abort on make subsequentcheck in writer on getting the anchor
> for an embeddedobj, i.e. sw.SwXTextEmbeddedObject test
> 
> Here's what I see...
> 
> in __GI___assert_fail (assertion=0x7fffdbf615b8 "m_pIndexReg ==
> rIndex.m_pIndexReg", 
> file=0x7fffdbf61278
> "/home/caolan/LibreOffice/core/sw/source/core/bastyp/index.cxx",
> line=382, function=
> 0x7fffdbf616a0 "bool SwIndex::operator<(const SwIndex&) const") at
> assert.c:105
> 
> Digging, I see the m_pIndexReg is zero-ed out at...
> 
> SwFmtAnchor::SetAnchor (this=0x7fffdd1ac6a0, pPos=0x7fffdd1ac958)
> at /home/caolan/LibreOffice/core/sw/source/core/layout/atrfrm.cxx:1508
> 
> fuller logs attached.
> 
> The zeroing out code is...
> 
> void SwFmtAnchor::SetAnchor( const SwPosition *pPos )
> {
> delete pCntntAnchor;
> pCntntAnchor = pPos ? new SwPosition( *pPos ) : 0;
> //AM Absatz gebundene Flys sollten nie in den Absatz
> hineinzeigen.
> if (pCntntAnchor &&
> ((FLY_AT_PARA == nAnchorId) || (FLY_AT_FLY == nAnchorId)))
> {
> pCntntAnchor->nContent.Assign( 0, 0 );
> }
> }

that actually looks like a legitimate use case to me, the anchor
position points at the text node but not into it...

> So we are a FLY_AT_PARA anchor, so the SwIndex m_pIndexReg is set to 0
> from the first arg, comment is in German, but I guess the jist of it is 
> "paragraph anchors shouldn't point into a specific location in the
> paragraph", which seems plausible.

yes

> Later on though when we want to find the anchor we end up comparing
> SwIndex'es and the assert fires, so how do we fix this ?
> 
> a) Tweak the SwIndex::operator to allow NULL m_pIndexReg when m_nIndex
> is 0 and sort them before non-NULL m_pIndexReg ?

SwIndex can't tell if this is legit or not.

> b) Do that in SwPosition::operator< instead ?.

that looks like the least ugly option to me :)

> c) Not null out the m_pIndexReg in the first place in SetCntntAnchor,
> and just set it to the 0th element

hmm... but it may be moved by e.g. SwIndexReg::Update and cause trouble

> d) custom compare in lcl_MarkOrderingByStart, lcl_Lower etc ?

perhaps there are other places in the code that want to compare these?

tests in sw run for me with this, please try it out:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=59e298823019093ee788104c2e95cb0c7b145d05

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] errors in idl files

[Michael Stahl]

On 24/11/11 14:16, Tomas Hlavaty wrote:
>> heh, i fixed that a lot on Monday, after discovering that a lot of its
>> files were not listed in the makefile at all; please git pull and try
>> again :)
> 
> Ah, sorry I didn't have the most recent repo.
> 
> However, after pulling, it is still not possible to resolve the
> following includes (udkapi/ and offapi/):
>#include  

this was mentioned in offapi/com/sun/star/awt/MaxChildrenException.idl
which is a remnant from the dialog layout attempt and i have removed it

>#include  
>#include 
>#include 
>#include 
>#include 
>#include 
>#include "com/sun/star/chart2/LegendSymbolStyle.idl"
>#include 
>#include 

git grep cannot find these except in the reference type-RDB blob

>#include 
>#include 
>#include 
>#include 
>#include 

these were mentioned in offapi/com/sun/star/drawing/modules.idl,
the interfaces were removed so i have removed the references from
modules.idl.

>#include 
>#include 
>#include 

git grep cannot find these

> Thank you,
> 
> Tomas


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Setting up a non-intrusive build cluster

[Jan Holesovsky]

Hi Marc-André,

On 2011-11-21 at 11:50 +, Michael Meeks wrote:

> > The expected candidate is, of course, icecream. So, more
> > pragmatically, is there any way we could set it up so that the
> > icecream daemon either shuts down or stops taking jobs when a user
> > logs in, and have it get back to life when no users are logged in.
> > This would have to include remote logins on SSH too.
> 
>   icecream currently runs at a very low CPU priority;

Not only that, IIRC it limits its memory so that it does not get the
computer swapping.  Also, it checks the load of the build slaves, and
sends the jobs to those with smallest load.

So, if at all possible, I'd ask the people to allow you to turn it on,
and hack it for this explicit switching off only when they complain ;-)
[and even in that case, I'd first monitor the complainers with 'top', if
it is really icecream ;-)]

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] I need some advice to fix fdo#40363

[Kohei Yoshida]

On Mon, 2011-11-28 at 21:56 +0100, Regina Henschel wrote:
> Hi Kohei,
> 
> Kohei Yoshida schrieb:
> [..]
> >
> > My conclusion?  No idea what advice I should give you to get it fixed
> > just yet.  Maybe someone else knows the work that Oracle has done to the
> > chart2 module after 3.3&  give us some background?
> 
>  From the release notes [1] I guess, that it is the feature to have date 
> category axis [2]. That would be CWS chart46 from Ingrid Halama around 
> 2010-11-30.
> 
> [1] http://development.openoffice.org/releases/DEV300m106_snapshot.html
> [2] https://issues.apache.org/ooo/show_bug.cgi?id=25706

Thanks for the info.

So, they've added a date axis which is new post-3.3.

Which also means we need to devise a new fix for this i.e. no need to
look back into the 3.3 code base, which didn't have that feature.

Hmm...

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] I need some advice to fix fdo#40363

[Regina Henschel]

Hi Kohei,

Kohei Yoshida schrieb:
[..]


My conclusion?  No idea what advice I should give you to get it fixed
just yet.  Maybe someone else knows the work that Oracle has done to the
chart2 module after 3.3&  give us some background?


From the release notes [1] I guess, that it is the feature to have date 
category axis [2]. That would be CWS chart46 from Ingrid Halama around 
2010-11-30.


[1] http://development.openoffice.org/releases/DEV300m106_snapshot.html
[2] https://issues.apache.org/ooo/show_bug.cgi?id=25706

Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] GTK warnings on console when launching LO built from master

[Alexander Thurgood]

Le 28/11/11 14:55, Michael Meeks a écrit :

Hi Michael,


>   Sounds like a generic gtk+ file-selector bug I guess. Do you get it
> when using gedit ?
> 

Will have to wait til I'm back in front of my Linux box I'm afraid, but
will report back later in the week.


Alex

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] I need some advice to fix fdo#40363

[Kohei Yoshida]

On Mon, 2011-11-28 at 13:43 +0100, Jean-Baptiste Faure wrote:
> 
> Now, my question is what to do? Is it a good idea to modify
> Date::IsValid in tdate.cxx without knowing why it works in LibO 3.3 ? 

I can sense that you already know the answer to this question. :-)  But
I wouldn't modify IsValid() without first checking why the same thing
worked in the 3.3 code base.  Perhaps the 3.3 chart2 code didn't even
call IsValid()?  I'm just guessing that, but that's the sort of stuff we
would need to find out in order to come up with how to fix this.

Now, I know that building the 3.3 branch is not as easy as building
master, due to the split repo that it still uses & it lacks many nice
features that we've added to our build system over the years.

So, if you are willing to build and investigate why it worked in 3.3,
great, and you would be more than welcome to do it.  If not, then just
leave it for now until we find someone (could be me) willing to look
into it.

Anyway... While I was writing this, I just decided to check the 3.3 code
and see what it did back then.  In the 3.3 code base, chart2 doesn't
even have DateHelper.cxx file.  Looks like chart's date handling has
changed quite a lot since 3.3...  In fact, in 3.3 chart2 doesn't seem to
do anything date-specific; must be something that Oracle worked on
post-3.3 to handle dates better, which in turn came caused this problem
as a result...

My conclusion?  No idea what advice I should give you to get it fixed
just yet.  Maybe someone else knows the work that Oracle has done to the
chart2 module after 3.3 & give us some background?

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] final and override

[Stephan Bergmann]

On 11/28/2011 08:10 PM, Pierre-André Jacquod wrote:

but since it seems that MSCV (according the same wiki) supports it /
will support it, why not just wait a bit and then use it directly,
setting a minimal compiler version ? This would allow a "cleaner" code,
not having to take into account "before implementation" status. (would
also be valid for other major features ) Most probably a too harsh
approach ?


We need to support rather old GCC version on Mac OS X.

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Fwd: About Mozilla's final/override macros]

[Michael Meeks]

Hi Jeff,

Thanks for the gory details :-) much appreciated; having said all that
the idea of having 'virtual' at the beginning of a method, and 'final'
at the end is (to me) pretty fugly but ... some great advice here.

Thanks ! :-)

Michael.

 Forwarded Message 
From: Jeff Walden 
To: michael.me...@suse.com
Subject: About Mozilla's final/override macros
Date: Mon, 28 Nov 2011 09:42:00 -0800

Via WordPress stats-webbug magic I see the final/override macros I added
to Mozilla are being discussed.  A few details worth noting (feel free
to forward this to the list if you want):

GCC 4.7 (unreleased) and Clang 3 (unreleased, but on its nth RC) support
final/override.  They require -std=c++0x or -std=gnu++0x to use
final/override without warning -- except that GCC also added a |__final|
extension, with the same use/semantics as |final|, which works
warning-free without -std=c++0x.  (Beats me why they did this for |
final| but not |override|.)  -Wno-c++0x-extensions disables the Clang
warning; I know no equivalent for GCC.  I doubt you have people using
unreleased GCC for fun, but given the small but substantial Mozilla
developer base compiling with Clang trunk, I'd bet you have at least a
few people compiling LibreOffice with it.

MSVC supports final/override since the 2005 (!) release, but spelling it
|sealed| rather than |final| for now (C# bleed-over).  Given that your
Windows build instructions talk about MSVC 2008, you probably have a
decent base of developers (and nightly build machines?) who'd test
final/override macros in your cross-platform code.

The static-analysis plugin was originally GCC-only but is now ported to
LLVM/Clang.  final/override validation only occurred in a special
static-analysis build, not a normal developer or nightly build.
Static-analysis builds haven't happened recently, and in fact our
final-class annotations were flat-out wrong as a result!  Clearly
compiler- and language-implemented analyses are much more trustworthy,
reliable, and less expensive in developer time (for projects, not for
the compilers) than user-driven analyses.  Plus they happen in regular
builds on developers' machines.  I personally don't see the benefit to
making our plugins check final/override annotations, but it could
happen.

The __attribute__() we used for final/override must appear in a position
different from the C++11 position.  If you want both C++11 support *and*
static-analysis validation without requiring GCC 4.7 or Clang 3, you'd
need two macros, or one wrapping the entire declaration.

   #define OVERRIDE_METHOD(decl)  __attribute__(...) decl override
   class Foo
   {
 OVERRIDE_METHOD(virtual void foo());
   };

I dunno about you, but I would call this much worse "hideous ugliness"
than just appending OVERRIDE or whatever after the declaration, and
giving up on plugin-based validation until distro releases including GCC
4.7 saves you.

Anyway, hope that helps.

Jeff


-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] Fix Kashida justification when there is no Kashida glyph

[Khaled Hosny]

Hi Thorsten,

On Mon, Nov 28, 2011 at 11:57:04AM +0100, Thorsten Behrens wrote:
> Khaled Hosny wrote:
> > This patch removes the "reasonable default" value of mnMinKashida which
> > makes no sense at all; either the font have a Kashida glyph and
> > mnMinKashida is set to its width or it doesn't and mnMinKashida is kept
> > 0.
> > 
> Hi Khaled,
> 
> nice one, pushed - by any chance, do you have a small test document
> that demonstrates the problem, e.g. with a common font that lacks
> kashida support? Such that going forward, we don't break this again.

It is really an edge case and I don't think there are fonts with Arabic
coverage lacking Kashida, however I'm developing a font where I trick
LibreOffice not to do Kashida justification by having a zero width
Kashida glyphs (The font is pretty complex with many contextual forms
and Kashida justification as implemented in LibreOffice, or other
application for that matter, is guaranteed to always produce bad
result). Anyway, the font can be obtained from here[1], and I'm
attaching a test file that shows this issue.

[1] https://sourceforge.net/projects/amiri/files/

Regards,
 Khaled


lo_no_kashida.odt
Description: application/vnd.oasis.opendocument.text
<><>

signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] New Windows tinderbox: Windows 2008R2

[Michael Meeks]

Hi Rainer,

On Mon, 2011-11-28 at 19:15 +0100, Rainer Bielefeld wrote:
> something I can't use; how can I create a parallel installation with 
> "master~2011-11-28_12.06.44_libodev35.msi"? I do not know.

Surely you can run it ? is it not possible to select a different
installation directory with it ? Presumably with msiexec we could even
script the install to some magic directory.

> What I need are reliable win builds 1 per day as we had on 
> Windows_2008R2/, that can be used for 3.5 pre release tests in an 
> effective way, and IMHO manpower should be concentrated on providing 
> builds here.

I believe we switched our packaging format from NSIS .exe's to the
new .msi installs that you see now. It'd be great to better understand
the problem with .msis - since this is our planned future exclusive
packaging format.

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 41883] MinGW port Most Annoying Bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=41883

Rainer Bielefeld  changed:

   What|Removed |Added

 Depends on||43315

--- Comment #10 from Rainer Bielefeld  
2011-11-28 10:38:24 PST ---
Nominate "Bug 43315 - MinGW: No User interface at all in applications". Build
can not be used.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] New Windows tinderbox: Windows 2008R2

[Rainer Bielefeld]

Jan Holesovsky schrieb:

Hi,

I've retired the "Windows XP SP3"


Hi,

thank you for providing WIN tinderboxes.

Unfortunately currently the situation is a little worrying. We have very 
few WII Master testers (pls see reporter-table):
, 
and we should try to waste as few as many time as possible. For me it's 
annoying to have to check every day various folders whether we have new 
builds. currently I mostly search in vain, and sometimes I find 
something I can't use; how can I create a parallel installation with 
"master~2011-11-28_12.06.44_libodev35.msi"? I do not know. And what 
might be the difference to builds from older "MinGW_cross-compilation"? 
Those "portable" builds would have been very useful, if they would have 
had a better quality.


What I need are reliable win builds 1 per day as we had on 
Windows_2008R2/, that can be used for 3.5 pre release tests in an 
effective way, and IMHO manpower should be concentrated on providing 
builds here.


Everything else might have some value, but from QA point of view we have 
to do a cost/benefit calculation.


Kind regards

Rainer
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] final and override

[Pierre-André Jacquod]

Hello,


However, given that override and final will only make it into GCC 4.7
(according to ), it


according to gcc.gnu.org too..

but since it seems that MSCV (according the same wiki) supports it / 
will support it, why not just wait a bit and then use it directly, 
setting a minimal compiler version ? This would allow a "cleaner" code, 
not having to take into account "before implementation" status. (would 
also be valid for other major features ) Most probably a too harsh 
approach ?

regards
Pierre-André

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] fdo#42924: needs help with "tablehead" xml parsing

[Jan Holesovsky]

Hi Korrawit,

On 2011-11-23 at 23:56 +0700, Korrawit Pruegsanusak wrote:

> Following https://bugs.freedesktop.org/show_bug.cgi?id=42924,
> this is an unfinished patch to check whether  is empty.
> Hope I was on the right way :)

I'm terribly sorry I am answering this late :-(  Thank you for the ping
on the IRC - unfortunately you were gone when I returned...

> Anyway, as commented in the code, how can I detect whether that row is
> "tablehead" or not? Currently I just set role = tablecontent.
> See 
> http://cgit.freedesktop.org/libreoffice/help/tree/helpcontent2/source/text/scalc/01/04060107.xhp#n219
> as an example.
> The first tablecell (line 221-222) is empty.
> Next 3 are with 
> If I take an approach like in the patch, the first one won't be
> "tablehead", and formatting will be a bit incorrect.
> But IMHO the xml parser can't get back to parsed element, right?
> So, suggestions are appreciated.

That it is true, it cannot; but still we in fact have 2 passes in the
wikiconv2.py - 1) when it parses the xml, and builds the internal
representation, and 2) when it outputs the wiki page.

So in fact, you could check the parent of the cell (ie. row) later, in
get_all(), you have all the information there.  If it is the first row,
and if there are any cells that are using tablehead style, you could use
that style for all I think.

To get a brief idea what I mean with the check in get_all(), please have
a look at the ListItem:

http://cgit.freedesktop.org/libreoffice/help/tree/helpcontent2/to-wiki/wikiconv2.py#n547

[where it checks "if self.parent.startwith > 0:"]

> Or, will we take another approach by fixing the help file instead?
> (bugzilla comment 2 by Andras)

I think fixing the parser will be easier, and actually more fun :-)  To
test your change, I recommend you to do one output without your change,
then one with your change, diff -pur over those 2 directories, and check
the result...

Sorry again for my late response :-(

All the best,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] LoadComponentFromUrl misuse lead to crash

[Laurent Godard]

Hi

here is a summary of the bug i encounter, present in all LibO versions
(master, 344, 322), but safe in OOo321

inside a macro, i launch a stardesktop.loadComponentFromUrl(firstArg, ...).

if firstArg is an URL, starting with file://, no problem
if firstArg is a path, /the/path/to/my/file, LibO crashes

yes, firstArg has to be an URL, it is specified. But LibO should throw
an IllegalArgumentException as OOo does. Never good that LibO crashes

when i say it crashes, it starts loading. but then enters a loop when
progress bar ends; using gdb, i have a lot of the same cycle calls
(given at the of the mail)

Examining the code, i see no URL check (but may have missed something,
high probability)

http://opengrok.libreoffice.org/xref/core/framework/source/services/desktop.cxx#657

http://opengrok.libreoffice.org/xref/core/framework/source/loadenv/loadenv.cxx#164
http://opengrok.libreoffice.org/xref/core/framework/source/loadenv/loadenv.cxx#180

http://opengrok.libreoffice.org/xref/core/framework/source/loadenv/loadenv.cxx#239
http://opengrok.libreoffice.org/xref/core/framework/source/loadenv/loadenv.cxx#281

I propose to add a check of validity of sURl somewhere and throw
illegalArgument
The most easy i see would be in
http://opengrok.libreoffice.org/xref/core/framework/source/services/desktop.cxx#657

any other better place in your opinion ?
may be in
http://opengrok.libreoffice.org/xref/core/framework/source/loadenv/loadenv.cxx#classifyContent
???

do we have any tool that can check if an URL is valid ? (taking various
protocols into account like in
http://opengrok.libreoffice.org/xref/core/framework/source/loadenv/loadenv.cxx#631

any guidelines welcome so that i can propose a patch

Laurent

'

gdb bt

#0  0xb7b52af4 in typelib_static_type_getByTypeClass () from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/../ure-link/lib/libuno_cppu.so.3
#1  0xb7afe90b in
cppu::OWeakObject::queryInterface(com::sun::star::uno::Type const&) ()
   from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/../ure-link/lib/libuno_cppuhelpergcc3.so.3
#2  0xb7af7975 in cppu::WeakImplHelper_query(com::sun::star::uno::Type
const&, cppu::class_data*, void*, cppu::OWeakObject*) ()
   from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/../ure-link/lib/libuno_cppuhelpergcc3.so.3
#3  0xb79a3bd2 in ?? () from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/libsfxlo.so
#4  0xb7995d8d in SfxBaseModel::queryInterface(com::sun::star::uno::Type
const&) () from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/libsfxlo.so
#5  0xae0b5c43 in ScModelObj::queryInterface(com::sun::star::uno::Type
const&) ()
   from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/../program/libsclo.so
#6  0xb68f1794 in ?? () from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/libfwelo.so
#7  0xb69080fb in ?? () from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/libfwelo.so
#8  0xb6906eef in
framework::TitleHelper::impl_updateTitleForModel(com::sun::star::uno::Reference
const&) ()
   from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/libfwelo.so
#9  0xb69076d8 in framework::TitleHelper::impl_updateTitle() () from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/libfwelo.so
#10 0xb69079be in framework::TitleHelper::getTitle() () from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/libfwelo.so
#11 0xb799ff10 in SfxBaseModel::getTitle() () from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/libsfxlo.so
#12 0xb69073cb in
framework::TitleHelper::impl_updateTitleForController(com::sun::star::uno::Reference
const&) ()
   from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/libfwelo.so
#13 0xb69076ec in framework::TitleHelper::impl_updateTitle() () from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/libfwelo.so
#14 0xb690791a in
framework::TitleHelper::titleChanged(com::sun::star::frame::TitleChangedEvent
const&) ()
   from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/libfwelo.so
#15 0xb690598a in framework::TitleHelper::impl_sendTitleChangedEvent()
() from
/home/lgodard/projets/libreoffice/build/git/master/libo/solver/unxlngi6.pro/installation/opt/program/libfwelo.so
#16 0xb690714c in
framework::TitleHelper::impl_updateTitleForModel(com::sun::star::uno::Reference
const&) ()
   from

Re: [Libreoffice] minutes of tech. steering call ...

[Michael Stahl]

On 25/11/11 15:13, Bjoern Michaelsen wrote:
> On Fri, Nov 25, 2011 at 11:20:50AM +0100, Michael Stahl wrote:
>>   DISPLAY=:42 ./soffice "--accept=pipe,name=$USER;urp;" --norestore
>> --nologo -env:UserInstallation=file:///tmp/xyz
> instead of that monster you cant now run:
> 
> make debugrun
> 
> on Linux(*), which ...
> 
>> then attach gdb to soffice.bin
> 
>  will do that too.
> 
>> then run subsequenttests e.g.
>>
>>   make subsequentcheck OOO_TEST_SOFFICE="connect:pipe,name=$USER"
> 
> Instead of that you can now:
> 
> make subsequentcheck gb_JunitTest_DEBUGRUN=T
> 
> And have one shell running gdb and the other running the test.

thanks a lot, that's a lot simpler and should finally make
subsequenttests so easy to debug that even mmeeks can do it  ;)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] [REVIEW-3-4] fdo#39950 report builder segfault during copy/paste

[Lionel Elie Mamane]

Attached patch is a backport of commit
538190e0ea142d0a7da244809c66241379d4d91b
in master by Caolán McNamara.
The only change wrt to master is in whitespace in context lines (tabs
vs spaces...)

It fixes fdo#39950, "most annoying" and severity "critical": when
copy/pasting (or drag'n dropping across section boundaries) a control
in report builder, LibreOffice segfaults.

I've tested this patch on libreoffice-3-4 (and on master).

Please apply to libreoffice-3-4.

-- 
Lionel
>From 28db081efcf00d14f4ae8c8b7e156af7521030f6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= 
Date: Fri, 25 Nov 2011 20:16:36 +
Subject: [PATCH] Resolves: fdo#39950 fix dnd crash from default assignment
 operators

Signed-off-by: Lionel Elie Mamane 
---
 reportdesign/inc/RptObject.hxx |4 ++
 reportdesign/source/core/sdr/RptObject.cxx |   58 ++--
 2 files changed, 41 insertions(+), 21 deletions(-)

diff --git a/reportdesign/inc/RptObject.hxx b/reportdesign/inc/RptObject.hxx
index d58950b..e24d51f 100644
--- a/reportdesign/inc/RptObject.hxx
+++ b/reportdesign/inc/RptObject.hxx
@@ -224,6 +224,8 @@ public:
 virtual OOle2Obj* Clone() const;
 virtual void initializeOle();
 
+OOle2Obj& operator=(const OOle2Obj& rObj);
+
 void initializeChart( const ::com::sun::star::uno::Reference< ::com::sun::star::frame::XModel>& _xModel);
 };
 
@@ -275,6 +277,8 @@ public:
 virtual sal_uInt32 GetObjInventor() const;
 virtual OUnoObject* Clone() const;
 
+OUnoObject& operator=(const OUnoObject& rObj);
+
 private:
 voidimpl_setReportComponent_nothrow();
 voidimpl_initializeModel_nothrow();
diff --git a/reportdesign/source/core/sdr/RptObject.cxx b/reportdesign/source/core/sdr/RptObject.cxx
index 1f6a01a..80d56cb 100644
--- a/reportdesign/source/core/sdr/RptObject.cxx
+++ b/reportdesign/source/core/sdr/RptObject.cxx
@@ -941,18 +941,24 @@ uno::Reference< uno::XInterface > OUnoObject::getUnoShape()
 {
 return OObjectBase::getUnoShapeOf( *this );
 }
-// -
+
+OUnoObject& OUnoObject::operator=(const OUnoObject& rObj)
+{
+if( this == &rObj )
+return *this;
+SdrUnoObj::operator=(rObj);
+
+Reference xSource(const_cast(rObj).getUnoShape(), uno::UNO_QUERY);
+Reference xDest(getUnoShape(), uno::UNO_QUERY);
+if ( xSource.is() && xDest.is() )
+comphelper::copyProperties(xSource.get(), xDest.get());
+
+return *this;
+}
+
 OUnoObject* OUnoObject::Clone() const
 {
-OUnoObject* pClone = CloneHelper< OUnoObject >();
-if ( pClone )
-{
-Reference xSource(const_cast(this)->getUnoShape(),uno::UNO_QUERY);
-Reference xDest(pClone->getUnoShape(),uno::UNO_QUERY);
-if ( xSource.is() && xDest.is() )
-comphelper::copyProperties(xSource.get(),xDest.get());
-}
-return pClone;
+return CloneHelper< OUnoObject >();
 }
 //
 // OOle2Obj
@@ -1128,22 +1134,32 @@ uno::Reference< chart2::data::XDatabaseDataProvider > lcl_getDataProvider(const
 }
 return xSource;
 }
-// -
-// Clone() soll eine komplette Kopie des Objektes erzeugen.
-OOle2Obj* OOle2Obj::Clone() const
+
+OOle2Obj& OOle2Obj::operator=(const OOle2Obj& rObj)
 {
-OOle2Obj* pObj = CloneHelper< OOle2Obj >();
-OReportModel* pRptModel = static_cast(GetModel());
-svt::EmbeddedObjectRef::TryRunningState( pObj->GetObjRef() );
-pObj->impl_createDataProvider_nothrow(pRptModel->getReportDefinition().get());
+if( this == &rObj )
+return *this;
+SdrOle2Obj::operator=(rObj);
 
-uno::Reference< chart2::data::XDatabaseDataProvider > xSource( lcl_getDataProvider(GetObjRef()) );
-uno::Reference< chart2::data::XDatabaseDataProvider > xDest( lcl_getDataProvider(pObj->GetObjRef()) );
+OReportModel* pRptModel = static_cast(rObj.GetModel());
+svt::EmbeddedObjectRef::TryRunningState( GetObjRef() );
+impl_createDataProvider_nothrow(pRptModel->getReportDefinition().get());
+
+uno::Reference< chart2::data::XDatabaseDataProvider > xSource( lcl_getDataProvider(rObj.GetObjRef()) );
+uno::Reference< chart2::data::XDatabaseDataProvider > xDest( lcl_getDataProvider(GetObjRef()) );
 if ( xSource.is() && xDest.is() )
 comphelper::copyProperties(xSource.get(),xDest.get());
 
-pObj->initializeChart(pRptModel->getReportDefinition().get());
-return pObj;
+initializeChart(pRptModel->getReportDefinition().get());
+
+return *this;
+}
+
+// -
+// Clone() soll eine komplette Kopie des Objektes erzeugen.
+OOle2Obj* OOle2Obj::Clone() const
+{
+return CloneHelper< OOle2Obj >();
 }
 // -
 void OOle2Obj::i

Re: [Libreoffice] WaE on vcl because of qt4 module

[Lubos Lunak]

On Friday 25 of November 2011, julien2412 wrote:
> Hello,
>
> By compiling vcl module (Debian testing x86-32, WaE, debug and symbols
> enabled), I've got this :
> In file included from /usr/include/qt4/QtCore/qdatastream.h:45:0,
>  from /usr/include/qt4/QtCore/qpair.h:45,
>  from /usr/include/qt4/QtCore/qhash.h:49,
>  from
> /home/maryline/compile-libreoffice/libo/vcl/unx/kde4/KDEXLib.hxx:35,
>  from
> /home/maryline/compile-libreoffice/libo/vcl/unx/kde4/KDEData.cxx:31:
> /usr/include/qt4/QtCore/qscopedpointer.h: In static member function ‘static
> void QScopedPointerDeleter::cleanup(T*)’:
> /usr/include/qt4/QtCore/qscopedpointer.h:55:5: error: declaration of
> ‘pointer’ shadows a global declaration [-Werror=shadow]

 A really helpful error message from gcc. The argument of the Qt function 
shadows an unknown global declaration and gcc does not feel like saying where 
it is. As long as you don't compile the file with just -E and find in the 
preprocessed source where the global 'pointer' comes from, this is just 
guessing, but I think it's rather good guessing that Qt is innocent here and 
the problem is wherever the global 'pointer' is. I do not see any 
global 'pointer' indentifier in vcl, so presumably something pollutes the 
global namespace and that is what should get fixed.

 As for the Qt bugreport you've made, please close it. First of all, nobody 
will fix it simply because it's most probably invalid and definitely 
unhelpful (do you realize that you are asking Qt developers to rename a 
function argument to something that does not clash with anything in the whole 
of LibreOffice and everything it uses?). Moreover, in Qt-based land -Whadow 
is (AFAICT) usually considered a nuisance rather than help (and this shows 
why), so I expect nobody will even seriously look at it anyway, for a reason.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] ru-RU genitive case month names (was: [libreoffice-l10n] [ANNOUNCE] added possessive genitive case month names, HEADS UP localizers ; -))

[Eike Rathke]

Hi Serg,

On Monday, 2011-11-28 13:45:11 +0400, Serg Bormant wrote:

> Here is Russian GenitiveMonths patch.

Thanks, pushed to master
http://cgit.freedesktop.org/libreoffice/core/commit/?id=c01ce861aced958302087117a5c5019d420b9d52

> Cc-ed to e-mail.

Only received in personal mail, list strips attachments.

As this apparently was your first contribution to the actual code base,
could you please give us a blanket license agreement that this and your
further contributions are under LGPLv3+ and MPL 1.1

Thanks again

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpnPCaLaIIMM.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] EuroOffice Barcode

[Jan Holesovsky]

Hi Tibor,

On 2011-11-23 at 10:29 +0100, Brenner Tibor wrote:

> I'm Tibor Brenner from MultiRcio Ltd. We are the developer team of 
> EuroOffice software package and extensions. I've written to András Tímár 
> from your team about a request with our Barcode extension, and he 
> suggested to use your mailing list.

Terribly sorry for the late answer :-(  I'm the one who initially did
the wikihelp, please feel free to explicitly CC: me on anything
regarding the http://help.libreoffice.org functionality.

> Since LibreOffice has an online help system, when somebody installs our 
> Barcode extension, he won't have its help page. So, we would like to ask 
> your help to built in our help files into your online help system. I can 
> upload our extension to your extensions webpage, as it's an absolutely 
> free one for everyone. In this case you will have all help files, or I 
> can send you the whole extension, if it's a better way.

This is a very good point; so far there is no explicit functionality to
handle extensions when the online help is used.  Maybe it might be as
easy as handling the extensions explicitly, ie. to use their (bundled)
help when the extension help is requested.  How does the page URL look
like when the barcode extension help is issued, please?

Maybe tweaking the impl_hasHelpInstalled() from
sfx2/source/appl/sfxhelp.cxx:659 could do the trick?

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED-3-4] [REVIEW-3-4] fdo#32347 reenable ADO URL helper UI

[Thorsten Behrens]

Lionel Elie Mamane wrote:
> Attached patch is a partial backport of my commit
> 538190e0ea142d0a7da244809c66241379d4d91b in master.
> 
> It reenables the ADO URL helper UI on MS Windows, which makes it
> *much* easier to connect to ADO databases. It is a regression compared
> to any version compiled with Windows XP SDK, i.e. OO.org.
>
Thanks, pushed to -3-4 - seeing green win32 tbox builds
post-Nov-23rd, this appears sane.

Cheers,

-- Thorsten


pgpqLh22an3J5.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Hide function pointers

[Stephan Bergmann]

On 11/28/2011 04:28 PM, Daisuke Nishino wrote:

I thought I don't need to write the statement once I have posted the above.
Should I edit the wiki page, or do I need to write it in every posts?


It suffices if you posted it once (I just did not bother to search the 
mail archives, only looked at the wiki page).  Please just add yourself 
to the wiki page; that would make future patch handling as easy as possible.


Thanks,
Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Hide function pointers

[Daisuke Nishino]

On Mon, Nov 28, 2011 at 6:42 PM, Stephan Bergmann wrote:

> On 11/27/2011 08:57 AM, Daisuke Nishino wrote:
>
>> Exposing functioin pointers to outside is not a good practice I think.
>> This patch encapsulates them.
>> Also, since fnLeaveSelect is called from only one location, I eliminated
>> the indirection.
>>
>
> Great, thanks.  Pushed (I simplified the "this->*this->" calls by removing
> the redundant second "this->").
>
>
Thanks!


> I do not find your license statement at <
> http://wiki.documentfoundation.org/Development/Developers>, can you add
> it there (I assume you contribute under LGPLv3+/MPL 1.1+)?
>

Ah, I posted the license statement on Nov 25:

On Fri, Nov 25, 2011 at 2:10 AM, Daisuke Nishino wrote:

>
> Lisence:
> All my past and future contributions (including this one) to LibreOffice
> are under LGPLv3+/MPL until further notice.
>

I thought I don't need to write the statement once I have posted the above.
Should I edit the wiki page, or do I need to write it in every posts?
p.s. I noticed a typo now :(

Thanks,

-- 
Daisuke Nishino
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] PostgreSQL-SDBC in LO: build system help

[Michael Meeks]

On Mon, 2011-11-28 at 14:23 +0100, Alex Thurgood wrote:
> > However, I have no idea how you would enter the strings for a remote db
> > instance, in particular, the parameter separators.
...
> OK, I seem to have figured it out from re-reading libpq documentation. 
> The URL field accepts connection strings of pair KEYWORD=VALUE, so one 
> can enter :
> 
> host=10.0.0.1 dbname=mydb

Gosh - it sounds like an horrific user experience :-)

Presumably in the star-treck future, having a per-backend UI with
key/value pairs specified that can be presented pleasantly with
descriptions, widgets etc. filled out would be rather nicer.

Perhaps an easy hack ;-)

ATB,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] Removing uses of OUString::setCharAt

[Thorsten Behrens]

August Sodora wrote:
> Tonight I tried to remove some uses of setCharAt so that it can
> eventually be removed, and I ran across a few cases that I would like
> to get another pair of eyes on. Especially in one particular case, I
> added a guard to make sure that the index was within range and I want
> to make sure that it is necessary or if something more involved is
> required. The patch is attached, and I remembered to add [PATCH] to
> the subject this time :)
> 
Hi August,

looks good, pushed now - except for the svl/source/misc/lngmisc.cxx
snippet which was based on older code it seems, dropped that part
entirely.

Thanks a lot, looking forward for more! :)

-- Thorsten


pgpZWJULoOeIT.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] GTK warnings on console when launching LO built from master

[Michael Meeks]

Hi Alex,

On Mon, 2011-11-28 at 14:35 +0100, Alex Thurgood wrote:
> When testing my (more or less) daily build of LO master, I keep getting 
> these warning messages on the console, whenever the app is in the 
> process of creating a new file (during the 'Save' operation :

Sounds like a generic gtk+ file-selector bug I guess. Do you get it
when using gedit ?

> Gtk-WARNING **: Unable to retrieve the file info for 
> `file:///home/alex/Documents/IPGALORE/BDD/testdbpq': Error stating file 
> '/home/alex/Documents/IPGALORE/BDD/testdbpq': No such file or directory

Failing that; whack a breakpoint in g_logv, and get a trace (with debug
symbols from vcl/). Can you confirm it does not occur in 3.4 ?

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Assertions and Logging

[Caolán McNamara]

On Mon, 2011-11-28 at 12:51 +0100, Michael Stahl wrote:
> finally, i have deployed our new aborting assertions for some definitely
> wrong cases in SwIndex:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d2a6999fc320843e4db0c99d961414416a8451c

And I have abort on make subsequentcheck in writer on getting the anchor
for an embeddedobj, i.e. sw.SwXTextEmbeddedObject test

Here's what I see...

in __GI___assert_fail (assertion=0x7fffdbf615b8 "m_pIndexReg ==
rIndex.m_pIndexReg", 
file=0x7fffdbf61278
"/home/caolan/LibreOffice/core/sw/source/core/bastyp/index.cxx",
line=382, function=
0x7fffdbf616a0 "bool SwIndex::operator<(const SwIndex&) const") at
assert.c:105

Digging, I see the m_pIndexReg is zero-ed out at...

SwFmtAnchor::SetAnchor (this=0x7fffdd1ac6a0, pPos=0x7fffdd1ac958)
at /home/caolan/LibreOffice/core/sw/source/core/layout/atrfrm.cxx:1508

fuller logs attached.

The zeroing out code is...

void SwFmtAnchor::SetAnchor( const SwPosition *pPos )
{
delete pCntntAnchor;
pCntntAnchor = pPos ? new SwPosition( *pPos ) : 0;
//AM Absatz gebundene Flys sollten nie in den Absatz
hineinzeigen.
if (pCntntAnchor &&
((FLY_AT_PARA == nAnchorId) || (FLY_AT_FLY == nAnchorId)))
{
pCntntAnchor->nContent.Assign( 0, 0 );
}
}

So we are a FLY_AT_PARA anchor, so the SwIndex m_pIndexReg is set to 0
from the first arg, comment is in German, but I guess the jist of it is 
"paragraph anchors shouldn't point into a specific location in the
paragraph", which seems plausible.

Later on though when we want to find the anchor we end up comparing
SwIndex'es and the assert fires, so how do we fix this ?

a) Tweak the SwIndex::operator to allow NULL m_pIndexReg when m_nIndex
is 0 and sort them before non-NULL m_pIndexReg ?
b) Do that in SwPosition::operator< instead ?.
c) Not null out the m_pIndexReg in the first place in SetCntntAnchor,
and just set it to the 0th element
d) custom compare in lcl_MarkOrderingByStart, lcl_Lower etc ?

C.
#3  0x003a6782dd02 in __GI___assert_fail (assertion=0x7fffdbf615b8 "m_pIndexReg == rIndex.m_pIndexReg", 
file=0x7fffdbf61278 "/home/caolan/LibreOffice/core/sw/source/core/bastyp/index.cxx", line=382, function=
0x7fffdbf616a0 "bool SwIndex::operator<(const SwIndex&) const") at assert.c:105
#4  0x7fffdb47e265 in SwIndex::operator< (this=0x22547b8, rIndex=...)
at /home/caolan/LibreOffice/core/sw/source/core/bastyp/index.cxx:382
#5  0x7fffdb4d1126 in SwPosition::operator< (this=0x22547a0, rPos=SwPosition (node 12, offset 0))
at /home/caolan/LibreOffice/core/sw/source/core/crsr/pam.cxx:111
#6  0x7fffdb524933 in (anonymous namespace)::lcl_MarkOrderingByStart (rpFirst=..., rpSecond=...)
at /home/caolan/LibreOffice/core/sw/source/core/doc/docbm.cxx:82
#7  0x7fffdb530ef2 in __gnu_debug::__check_partitioned_lower<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator*, std::__cxx1998::vector, std::allocator > > >, std::__debug::vector, std::allocator > > >, boost::shared_ptr, bool (*)(boost::shared_ptr const&, boost::shared_ptr const&)> (__first=..., __last=..., __value=
..., __pred=
0x7fffdb5248de <(anonymous namespace)::lcl_MarkOrderingByStart(IDocumentMarkAccess::pMark_t const&, IDocumentMarkAccess::pMark_t const&)>)
at /usr/lib/gcc/x86_64-redhat-linux/4.6.1/../../../../include/c++/4.6.1/debug/functions.h:362
#8  0x7fffdb52e128 in std::lower_bound<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator*, std::__cxx1998::vector, std::allocator > > >, std::__debug::vector, std::allocator > > >, boost::shared_ptr, bool (*)(boost::shared_ptr const&, boost::shared_ptr const&)> (__first=..., __last=..., __val=..., __comp=
0x7fffdb5248de <(anonymous namespace)::lcl_MarkOrderingByStart(IDocumentMarkAccess::pMark_t const&, IDocumentMarkAccess::pMark_t const&)>)
at /usr/lib/gcc/x86_64-redhat-linux/4.6.1/../../../../include/c++/4.6.1/bits/stl_algo.h:2406
#9  0x7fffdb524a14 in (anonymous namespace)::lcl_InsertMarkSorted (io_vMarks=..., pMark=...)
at /home/caolan/LibreOffice/core/sw/source/core/doc/docbm.cxx:100
#10 0x7fffdb526a7f in sw::mark::MarkManager::makeMark (this=0x1d15740, rPaM=SwPaM = {...}, rName="", eType=
IDocumentMarkAccess::UNO_BOOKMARK) at /home/caolan/LibreOffice/core/sw/source/core/doc/docbm.cxx:392
#11 0x7fffdbabf80d in SwXTextRange::SetPositions (this=0x23c0730, rPam=SwPaM = {...})
at /home/caolan/LibreOffice/core/sw/source/core/unocore/unoobj2.cxx:867
#12 0x7fffdbabf2c6 in SwXTextRange::SwXTextRange (this=0x23c0730, rPam=SwPaM = {...}, xParent=..., eRange=
SwXTextRange::RANGE_IN_TEXT) at /home/caolan/LibreOffice/core/sw/source/core/unocore/unoobj2.cxx:828
#13 0x7fffdbac0c7e in SwXTextRange::CreateXTextRange (rDoc=..., rPos=SwPosition (node 12, offset 0), pMark=
0x0) at /home/caolan/LibreOffice/core/sw/source/core/unocore/unoobj2.cxx:1202
#14 0x7fffdba8e6fc in SwXFrame::getAnchor (this=0x222cf70)
at /home/caolan/LibreOffice/core/sw/sou

Re: [Libreoffice] final and override

[Stephan Bergmann]

On 11/28/2011 01:27 PM, Michael Meeks wrote:

Sure - which is why we'd do that for old compiler versions only


...where it would still result in undefined behaviour, technically (note 
the "nitpick," was meant somewhat tongue-in-cheek).



finalbool methodFoo();
virtual  char methodBaz();
override int  methodBaa();


(Note that final and override go at the end of the declaration.)

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] GTK warnings on console when launching LO built from master

[Alex Thurgood]

Hi all,

When testing my (more or less) daily build of LO master, I keep getting 
these warning messages on the console, whenever the app is in the 
process of creating a new file (during the 'Save' operation :


Gtk-WARNING **: Unable to retrieve the file info for 
`file:///home/alex/Documents/IPGALORE/BDD/testdbpq': Error stating file 
'/home/alex/Documents/IPGALORE/BDD/testdbpq': No such file or directory



Alex


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Eclipse: Libre Office integration help

[Cedric Bosdonnat]

Hi,

On Mon, 2011-11-28 at 16:51 +0530, deenadayalan k wrote:
> Thanks for pointing to references (URL's).

By the way I answered on the mailing-list, it's just because I don't
want to hold such an interesting discussion privately. Please reply to
the mailing-list too: this is archived and could help people coming with
the same question later. I won't even answer to your next private email.

> <
> You can also find some similar code in OOEclipse:
> http://cgit.freedesktop.org/libreoffice/contrib/ooeclipse/tree/core/source/org/openoffice/ide/eclipse/core/office
> >
>  
> How can i download the above ../tree/core/source/..? using git?

Sure it's a git repository.

> This seems to a eclipse plugin
> http://cgit.freedesktop.org/libreoffice/contrib/ooeclipse/tree/core but in 
> this folder hierarchy, 'office' is a folder at 
> ../source/org/openoffice/ide/eclipse/core/office, is this good enough to open 
> a 'open office' in my own Eclipse RCP application or should i need to 
> download 
> http://cgit.freedesktop.org/libreoffice/contrib/ooeclipse/tree/core/source?

The whole thing is not even intended to open a document from within
Eclipse. As I said, this is not the code I refer to in the links I gave
you... but another example of how to bootstrap LibreOffice from an
Eclipse plugin. That code is simply getting useful data from the
LibreOffice installation to help developing LibreOffice extensions.

> To integrate the 'open office' in my own RCP application, should i
> need to install the open office in my computer or i could download the
> required *.jar files and then i can create eclipse 'reference
> library' (as another plugin) that can be referenced by the actual RCP
> application (which opens the excel in open office).

I never liked the embed-the-jars-in-the-plugin attitude and that's why I
never re-used Ubion's code. To be more independent from the installed
version, you should use the installed Jars.

Just to be clear: I don't want to dive again in that mess and haven't
done it for years. The best I can do now for you is to give you the
links and some code pointers to help you, but that's now done. I won't
do the work for you even though I did it once!

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 41883] MinGW port Most Annoying Bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=41883

Petr Mladek  changed:

   What|Removed |Added

 Depends on||43246

--- Comment #9 from Petr Mladek  2011-11-28 05:24:06 PST ---
(In reply to comment #5)
> Nominate "Bug 43246 - MinGW FILEOPEN FILESAVE: General Error message"

Makes sense => added

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] PostgreSQL-SDBC in LO: build system help

[Alex Thurgood]

Le 28/11/2011 11:47, Alexander Thurgood a écrit :

Hi all,


However, I have no idea how you would enter the strings for a remote db
instance, in particular, the parameter separators. Trawling around the
net and in the postgres documentation didn't get me any further, because
any of the strings I tried failed miserably with either a failed host
lookup, or else a message saying that I needed to add ='' after my colon
separators.

Could you fill me in please on the string sequence required ?




OK, I seem to have figured it out from re-reading libpq documentation. 
The URL field accepts connection strings of pair KEYWORD=VALUE, so one 
can enter :


host=10.0.0.1 dbname=mydb

and then move on to the user/pwd field and connection test (I imagine 
that one could enter the usr/pwd combo in the URL field too, but I 
haven't tried that yet. I will try and write something up about this in 
the next few days unless someone beats me to it.


Alex

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Fix for fdo39748 Easy hack: Cleanup extensions list

[Olivier Hallot]

Hi

Please find attached a patch for FDO 39748, Easy Hack Cleanup Extension 
list.


Some post-commit I missed (I don't know how to fix a patch):

in /desktop/source/deployment/gui/dp_gui.hrc, please drop the line

+#define RID_EM_BTN_SELECT  23

in /desktop/source/deployment/gui/dp_gui_dialog2.cxx, please drop the line

+aPos = Point( 0, 5 );

Thank you

--
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812

>From 54d9ab52456ce8392c41152b156d761e6c65ef1f Mon Sep 17 00:00:00 2001
From: Olivier Hallot 
Date: Mon, 28 Nov 2011 10:54:55 -0200
Subject: [PATCH] Fix for bug fdo39748, Easy-hack Cleanup extension list.

This patch introduces 3 new check box in the extension manager GUI to allow selection of extension type to display: bundled, shared or user. Dialog is automatically updated upon toggling checkbox.

On toggling each checkbox, the extension list is recreated from scratch and packages are added to the list depending on the checkmark state. Initial state is all checks marked.
---
 desktop/source/deployment/gui/dp_gui.hrc   |5 +
 desktop/source/deployment/gui/dp_gui_dialog2.cxx   |   84 ++--
 desktop/source/deployment/gui/dp_gui_dialog2.hxx   |6 ++
 desktop/source/deployment/gui/dp_gui_dialog2.src   |   33 +++-
 .../source/deployment/gui/dp_gui_extlistbox.cxx|1 -
 desktop/source/deployment/gui/dp_gui_theextmgr.cxx |1 -
 desktop/source/deployment/gui/dp_gui_theextmgr.hxx |3 +-
 7 files changed, 121 insertions(+), 12 deletions(-)

diff --git a/desktop/source/deployment/gui/dp_gui.hrc b/desktop/source/deployment/gui/dp_gui.hrc
index 4924051..0419e63 100644
--- a/desktop/source/deployment/gui/dp_gui.hrc
+++ b/desktop/source/deployment/gui/dp_gui.hrc
@@ -41,9 +41,14 @@
 #define RID_EM_BTN_CHECK_UPDATES   13
 #define RID_EM_BTN_OPTIONS 14
 #define RID_EM_BTN_CANCEL  15
+#define RID_EM_FT_TYPE_EXTENSIONS  16
+#define RID_EM_CBX_BUNDLED 17
+#define RID_EM_CBX_SHARED  18
+#define RID_EM_CBX_USER19
 #define RID_EM_FT_GET_EXTENSIONS   20
 #define RID_EM_FT_PROGRESS 21
 #define RID_EM_FT_MSG  22
+#define RID_EM_BTN_SELECT  23
 
 // local RIDs:
 #define PB_LICENSE_DOWN 50
diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.cxx b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
index 2301eff..fe92e19 100644
--- a/desktop/source/deployment/gui/dp_gui_dialog2.cxx
+++ b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
@@ -26,7 +26,6 @@
  *
  /
 
-
 #include "dp_gui.hrc"
 #include "svtools/controldims.hrc"
 #include "svtools/svtools.hrc"
@@ -98,6 +97,10 @@ namespace dp_gui {
 #define PROGRESS_WIDTH  60
 #define PROGRESS_HEIGHT 14
 
+#define USER_PACKAGE_MANAGEROUSTR("user")
+#define SHARED_PACKAGE_MANAGER  OUSTR("shared")
+#define BUNDLED_PACKAGE_MANAGER OUSTR("bundled")
+
 //--
 struct StrAllFiles : public rtl::StaticWithInit< OUString, StrAllFiles >
 {
@@ -588,7 +591,7 @@ String DialogHelper::getResourceString( sal_uInt16 id )
 //--
 bool DialogHelper::IsSharedPkgMgr( const uno::Reference< deployment::XPackage > &xPackage )
 {
-if ( xPackage->getRepositoryName().equals( OUSTR("shared") ) )
+if ( xPackage->getRepositoryName().equals( SHARED_PACKAGE_MANAGER ) )
 return true;
 else
 return false;
@@ -705,6 +708,11 @@ ExtMgrDialog::ExtMgrDialog( Window *pParent, TheExtensionManager *pManager ) :
 m_aCloseBtn( this,  getResId( RID_EM_BTN_CLOSE ) ),
 m_aHelpBtn( this,   getResId( RID_EM_BTN_HELP ) ),
 m_aDivider( this ),
+m_aDivider2(this),
+m_aTypeOfExtTxt( this , getResId( RID_EM_FT_TYPE_EXTENSIONS ) ),
+m_aBundledCbx(this, getResId (RID_EM_CBX_BUNDLED)),
+m_aSharedCbx(this,  getResId (RID_EM_CBX_SHARED)),
+m_aUserCbx (this,   getResId (RID_EM_CBX_USER)),
 m_aGetExtensions( this, getResId( RID_EM_FT_GET_EXTENSIONS ) ),
 m_aProgressText( this,  getResId( RID_EM_FT_PROGRESS ) ),
 m_aProgressBar( this,   WB_BORDER + WB_3DLOOK ),
@@ -732,6 +740,10 @@ ExtMgrDialog::ExtMgrDialog( Window *pParent, TheExtensionManager *pManager ) :
 m_aGetExtensions.SetClickHdl( LINK( this, ExtMgrDialog, HandleHyperlink ) );
 m_aCancelBtn.SetClickHdl( LINK( this, ExtMgrDialog, HandleCancelBtn ) );
 
+m_aBundledCbx.SetClickHdl( LINK( this, ExtMgrDialog, HandleExtTypeCbx ) );
+m_aSharedCbx.SetClickHdl( LINK( this, ExtMgrDialog, HandleExtTypeCbx ) );
+m_aUserCbx.SetClickHdl( LINK( this, ExtMgrDialog, HandleEx

Re: [Libreoffice] Possible little code simplification

[Michael Stahl]

On 25/11/11 19:05, Ivan Timofeev wrote:
> Hello Michael,
> 
> 2011/11/25 Michael Stahl :
>> On 24/11/11 19:07, Ivan Timofeev wrote:
>>> [...]
>>> What do you think about changing the code so that pSortedObjs will be
>>> alive every time? We will be able to return a reference to pSortedObjs
>>> in GetSortedObjs() instead of a pointer and remove the mentioned
>>> checks (there are a lot of such checks). I could do this. :-)
>>
>> the writer core and layout code is highly optimized, especially for
>> 16-bit windows where memory is scarce :)
> 
> Well, another possible memory optimization is to merge
> SwSortedObjsImpl into SwSortedObjs. What is the reason to use the
> "pImpl" pattern here?

usually pImpl is a good idea because it is the only way to get actual
encapsulation in C++; but in this case it definitely looks overdone to me...

it really does not make any sense to have a separate header and cxx file
for the impl class, that should all be moved into swsortedobjs.cxx.

hmmm... am not sure about the question "should it have a pImpl at all",
currently the impl only contains a vector, but on the other hand,
perhaps somebody will add other members later... i don't have a strong
opinion in this case :)

>> i guess for SwPageFrm it doesn't matter at all if the SwSortedObj always
>> exists.
>>
>>> Same problem with the field 'SwSortedObjs* pDrawObjs' in the class SwFrm.
>>
>> since this is the base class of all frames there will be a couple more
>> instances of it, and most of these probably won't use pDrawObjs; would
>> be interesting to know how much memory this would uses for a large
>> document...
> 
> Ok, there are many SwFrms in a big doc... We don't want to throw away
> memory. But we would use a shared between the SwFrm instances static
> variable for an empty list ("null object"), and return it in
> GetDrawObjects when our SwSortedObjs is dead. What do you think about
> it?

for this case i don't like it, because this null object would be
mutable: it would be possible that somebody mis-uses this to get the
pDrawObjs, receiving the static instance, and then adding an element,
which is obviously bogus.

so the explicit null checks look like the lesser evil :)

what perhaps could be investigated is whether the pDrawObjs really has
to be a member of SwFrm, perhaps it could be moved to some sub-class
that is less often used... but note i am not familiar with the layout
code so that is just a guess.

> 
> Kind Regards,
> Ivan

regards,
 michael

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 41883] MinGW port Most Annoying Bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=41883

Lionel Elie Mamane  changed:

   What|Removed |Added

 Depends on||43298

--- Comment #8 from Lionel Elie Mamane  2011-11-28 04:50:55 
UTC ---
Nominate bug 43298 "cannot open MS Access (.mdb) files"

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] I need some advice to fix fdo#40363

[Jean-Baptiste Faure]

Hi all,

The bug described in fdo#40363 may occur if you make a typo when type
some dates in Calc. For example 1011-11-28 instead of 2011-11-28. In
such a case, chart2 loops infinitely in master and LibO 3.4.
The loop occurs in GetDateSomeYearsAway method in DateHelper.cxx :
http://opengrok.libreoffice.org/xref/core/chart2/source/view/axes/DateHelper.cxx#81

The problem is that the chart wizard want compute tick marks. If a date
is far before 1582-10-15 then GetDateSomeYearsAway() is called for
another year before 1582-10-15. This methods goes in the past by steps
of one day until it finds a valid date. The problem is that the validity
of the date is defined by IsValid() in tdate.cxx :
http://opengrok.libreoffice.org/xref/core/tools/source/datetime/tdate.cxx#321
For this method every dates before 1582-10-15 are not valid...

If I modify Date::IsValid so that only dates strictly between 1582-10-05
and 1582-10-15 are not valid, then the chart wizard works without problem.

I do not understand why every dates before 1582-10-15 should not be
valid when only dates from 1582-10-05 to 1582-10-14 do not exist due to
the switch from julian calendar to gregorian calendar.

What is very annoying for me is that the chart wizard works well with
the same data in LibO 3.3 (precisely LibO 3.3.2 from Ubuntu PPA for
Ubuntu 10.04 x86_64) and I was not able to find any modification of the
file tdate.cxx (git log -p tdate.cxx) that I can relate to this problem.
In other words, AFAIK, actual code of Date::IsValid was already there in
LibO 3.3.

Now, my question is what to do? Is it a good idea to modify
Date::IsValid in tdate.cxx without knowing why it works in LibO 3.3 ?

Best regards.
JBF
-- 
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] final and override

[Michael Meeks]

On Mon, 2011-11-28 at 11:42 +0100, Stephan Bergmann wrote:
> On 11/28/2011 11:25 AM, Michael Meeks wrote:
> > On the other hand; I'd (personally) prefer to use some defines to
> > create the 'override' and 'final' keywords (as they will be in future).
> > Defining them to 'virtual' or even empty would do, if they are not
> > present in the compiler. cf. glib's provision of a stock 'inline'.
...
> One nitpick:  While it would keep the code surely more readable, it 
> would make it less standard.  For one, override and final are 
> technically not keywords in C++11, so a correct program that used them 
> as identifiers would be broken if we defined them to be empty (for a 
> compiler not yet supporting them).

Sure - but I suspect the instance count of that is really low in our
nFinal aOverride world; a quick:

git grep final | grep \.[ch]xx
git grep override | grep \.[ch]xx

Shows almost no problems here. 

>   For another, if override and final /were/ keywords, defining them in
> any way would result in undefined behaviour.

Sure - which is why we'd do that for old compiler versions only; that
is what glib does for 'inline' - quite successfully. The main downside
to this might be the odd error messages when someone does:

bool final = false;

;-) but - apparently people don't do that. Either way, I know which I
prefer:

finalbool methodFoo();
virtual  char methodBaz();
override int  methodBaa();
vs.
SAL_FINALbool methodFoo()
virtual  char methodBaz();
SAL_OVERRIDE int  methodBaa()

But, since there is (as yet) no patch, it's hardly worth discussing.

;-)

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] windows nss build failure (master)

[Jonathan Aquilina]

  
  
On 11/28/11 1:17 PM, Noel Power wrote:
On
  28/11/11 11:46, Andras Timar wrote:
  
  
  [...]
  
  --with-mozilla-build=/cygdrive/c/mozilla-build/


For me it is

--with-mozilla-build=c:/mozilla-build


Give it a try, because your build system does not find
nsinstall.exe

and it is possible, that this is the root cause.


  
  unfortunately that wasn't it, I will try and get to the bottom of
  it :-/
  
  
  Noel
  
  ___
  
  LibreOffice mailing list
  
  LibreOffice@lists.freedesktop.org
  
  http://lists.freedesktop.org/mailman/listinfo/libreoffice
  

I am not sure but I remember seeing an email thread about mozilla
decoupling not sure if that might be related to this issue on
windows.


  

  Regards
  Jonathan Aquilina

 
Get a signature like this.
   Click
  here.    


  

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] windows nss build failure (master)

[Noel Power]

On 28/11/11 11:46, Andras Timar wrote:

[...]

--with-mozilla-build=/cygdrive/c/mozilla-build/

For me it is
--with-mozilla-build=c:/mozilla-build

Give it a try, because your build system does not find nsinstall.exe
and it is possible, that this is the root cause.


unfortunately that wasn't it, I will try and get to the bottom of it :-/

Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Assertions and Logging

[Michael Stahl]

[somehow this mail got eaten somewhere, so i'll send it again...]

On 22/11/11 13:15, Bjoern Michaelsen wrote:
> Hi Michael, Stephan, all,
> 
> On Tue, Nov 22, 2011 at 12:46:52PM +0100, Michael Stahl wrote:
>> one requirement i would have on conditional compilation is that, whether
>> --disable-dbgutil or --enable-dbgutil, objects built with debug=t
>> (resulting in OSL_DEBUG_LEVEL being set to non-zero) should always be
>> binary compatible with objects built without debug=t.
>>
>> this makes e.g. tracking down bugs introduced by mis-optimisation much
>> easier; i think we are in agreement on this point.
> 
> Full agreement here.
> 
>> i think i've seen members of SwDoc being added with:
>>  #if OSL_DEBUG_LEVEL > 1
>>  #if OSL_DEBUG_LEVEL > 0
>> this kind of thing always struck me as wrong: it should be DBG_UTIL,
>> will try to clean that up a bit...
> 
> A bit of digging in gits history shows that to be a blunt removal commit of
> DBG_UTIL in sw in 2010. I cant make any sense of it, as it completly broke non
> DBG_UTIL debug builds for no gain. Can anyone enlighten me on this?

have fixed this now with:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=279a176397623ea83e98fac5a7f4132325b42594

so in sw at least we should have ABI compatible objects now.

also, noticed that in a lot of places debug checks and OSL_ENSUREs were
behind #if OSL_DEBUG_LEVEL > 1, which is not true for either
--enable-debug or --enable-dbgutil, so most developers would not get
these; have tried to fix that up as well by checking > 0 instead.

finally, i have deployed our new aborting assertions for some definitely
wrong cases in SwIndex:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d2a6999fc320843e4db0c99d961414416a8451c

in summary, debug builds of "sw" should be a lot more useful now :)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Fix for dialog Manage Breakpoints crash

[Niklas Johansson]

 I started out trying to fix fdo 42778 and noticed that my initial 
description of the problem was a bit to narrow. It wasn't just the pass 
count that wasn't stored correctly but the breakpoints all together. In 
worst case it makes the program crash. This fix, stores the values. I'm 
not that experienced with C++ so could someone have a second look at 
this there might very well be a "cleaner" way of writing it.


After building it with the fix, Manage Breakpoints works almost as 
expected on my machine.
If you set the pass count to 1 it stops at the first 2 stops at the 
second. 1 should pass one and stop the second time. I'll try to fix this 
in another patch though.


--
Niklas Johansson

>From b8a0ad0320fb0e36276afae1e861b5da189153b6 Mon Sep 17 00:00:00 2001
From: Niklas Johansson 
Date: Mon, 28 Nov 2011 11:40:30 +0100
Subject: [PATCH] Fixes BreakPointManager

Earlier when pressing ok in the breakpoint manager the breakpoints
wasn't getting stored. The pointer address was stored but the
breakpoint object was destroyed, leaving you with random values.
---
 basctl/source/basicide/bastypes.cxx |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/basctl/source/basicide/bastypes.cxx 
b/basctl/source/basicide/bastypes.cxx
index 10310ec..058e6ba 100644
--- a/basctl/source/basicide/bastypes.cxx
+++ b/basctl/source/basicide/bastypes.cxx
@@ -288,7 +288,7 @@ void BreakPointList::transfer(BreakPointList & rList)
 {
 reset();
 for (size_t i = 0; i < rList.size(); ++i)
-maBreakPoints.push_back( rList.at( i ) );
+maBreakPoints.push_back( new BreakPoint(*rList.at( i )) );
 rList.reset();
 }
 
-- 
1.7.5.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Petr Mladek  changed:

   What|Removed |Added

 Depends on||43266

--- Comment #235 from Petr Mladek  2011-11-28 03:01:49 UTC ---
Nominate bug 43266: Another problem to start 3.4.4 on 64-bit Windows

Hmm, we screwed up something on 64-bit Windows systems.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] Fix Kashida justification when there is no Kashida glyph

[Thorsten Behrens]

Khaled Hosny wrote:
> This patch removes the "reasonable default" value of mnMinKashida which
> makes no sense at all; either the font have a Kashida glyph and
> mnMinKashida is set to its width or it doesn't and mnMinKashida is kept
> 0.
> 
Hi Khaled,

nice one, pushed - by any chance, do you have a small test document
that demonstrates the problem, e.g. with a common font that lacks
kashida support? Such that going forward, we don't break this again.

Cheers,

-- Thorsten


pgpaTxGIlMAp5.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] PostgreSQL-SDBC in LO: build system help

[Alexander Thurgood]

Le 28/11/11 10:32, Lionel Elie Mamane a écrit :

Hi Lionel,

I want to write up some help about the driver because I thought that
while we were waiting for the connector to be integrated, I'd put it up
as an extension on the extensions site. However, to do that, I need to
write up a little mini-help with the string connection info.


I managed to get the driver to work on my Linux 32bit installation under
Ubuntu 11.10, but it took me quite a while to establish the connection
with the required connstr parameters.


As it turns out, for a locally running pg instance, all the user has to
enter is the dbname in the URL field, so something like :

dbname='mydb'

The wizard then goes on to ask for User/PWD combo and allow you to test.

However, I have no idea how you would enter the strings for a remote db
instance, in particular, the parameter separators. Trawling around the
net and in the postgres documentation didn't get me any further, because
any of the strings I tried failed miserably with either a failed host
lookup, or else a message saying that I needed to add ='' after my colon
separators.

Could you fill me in please on the string sequence required ?

TIA,


Alex

PS : I haven't managed to build the connector on Mac OSX yet, because
configure keeps saying it can't find pq_config. I tried setting the env
var manually from the terminal, but it still refuses to see it, so I'll
end up having to edit my bash/plist file to get the path in.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] final and override

[Stephan Bergmann]

On 11/28/2011 11:25 AM, Michael Meeks wrote:

On the other hand; I'd (personally) prefer to use some defines to
create the 'override' and 'final' keywords (as they will be in future).
Defining them to 'virtual' or even empty would do, if they are not
present in the compiler. cf. glib's provision of a stock 'inline'.

That should help reduce code thrash, and hideous ugliness ;-) keeping
us closer to more readable, standard C++.


One nitpick:  While it would keep the code surely more readable, it 
would make it less standard.  For one, override and final are 
technically not keywords in C++11, so a correct program that used them 
as identifiers would be broken if we defined them to be empty (for a 
compiler not yet supporting them).  For another, if override and final 
/were/ keywords, defining them in any way would result in undefined 
behaviour.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] windows nss build failure (master)

[Noel Power]

Am I missing some magic incantation ? haven't built on windows forever, 
the build fails with nss, it just refuses to build for me ( attached is 
build log and autogen.lastrun ) There are some errors in the config from 
nss to do with phtreads but not sure if this is normal or not, or if 
this is the cause why 'make' thinks there is nothing to build ? Any 
ideas/suggestions welcome ( oh btw this is VS 2008 ( not express ) )


thanks,
Noel
=
(1/1) Building module nss
Entering /cygdrive/g/master/core/nss

if [ -f ./wntmsci12.pro/misc/build/nss-3.12.8.exists ] ; then mv ./wntmsci12.pro/misc/build/nss-3.12.8 ./wntmsci12.pro/misc/build/nss-3.12.8_removeme ; fi
make writeable...
patching file nss-3.12.8/mozilla/nsprpub/config/rules.mk
patching file nss-3.12.8/mozilla/nsprpub/configure
Hunk #1 succeeded at 4070 with fuzz 2 (offset 170 lines).
patching file nss-3.12.8/mozilla/security/coreconf/Darwin.mk
patching file nss-3.12.8/mozilla/security/coreconf/Linux.mk
Hunk #2 succeeded at 154 with fuzz 1 (offset 4 lines).
Hunk #3 succeeded at 182 with fuzz 2 (offset 21 lines).
patching file nss-3.12.8/mozilla/security/coreconf/SunOS5.mk
patching file nss-3.12.8/mozilla/security/coreconf/arch.mk
patching file nss-3.12.8/mozilla/security/coreconf/rules.mk
patching file nss-3.12.8/mozilla/security/nss/cmd/platlibs.mk
patching file nss-3.12.8/mozilla/security/nss/cmd/shlibsign/Makefile
patching file nss-3.12.8/mozilla/nsprpub/configure
Hunk #1 succeeded at 3146 with fuzz 1 (offset 173 lines).
Hunk #2 succeeded at 3276 (offset 173 lines).
patching file nss-3.12.8/mozilla/nsprpub/configure.in
Hunk #1 succeeded at 968 (offset 137 lines).
Hunk #2 succeeded at 1009 (offset 137 lines).
patching file nss-3.12.8/mozilla/nsprpub/pr/src/Makefile.in
patching file nss-3.12.8/mozilla/security/coreconf/AIX.mk
patching file nss-3.12.8/mozilla/security/nss/cmd/platlibs.mk
Hunk #1 succeeded at 171 (offset -2 lines).
Hunk #2 succeeded at 221 (offset -2 lines).
patching file nss-3.12.8/mozilla/security/nss/cmd/shlibsign/mangle/Makefile
patching file nss-3.12.8/mozilla/security/nss/cmd/shlibsign/Makefile
patching file nss-3.12.8/mozilla/security/nss/nss-config.in
patching file nss-3.12.8/mozilla/security/coreconf/arch.mk
creating cache ./config.cache
checking host system type... i686-pc-cygwin
checking target system type... i686-pc-cygwin
checking build system type... i686-pc-cygwin
checking for cl... /cygdrive/e/PROGRA~1/MICROS~1.0/VC/bin/cl.exe
checking for whoami... /usr/bin/whoami
checking for gcc... (cached) /cygdrive/e/PROGRA~1/MICROS~1.0/VC/bin/cl.exe
checking whether the C compiler (/cygdrive/e/PROGRA~1/MICROS~1.0/VC/bin/cl.exe  ) works... yes
checking whether the C compiler (/cygdrive/e/PROGRA~1/MICROS~1.0/VC/bin/cl.exe  ) is a cross-compiler... no
checking whether we are using GNU C... no
checking whether /cygdrive/e/PROGRA~1/MICROS~1.0/VC/bin/cl.exe accepts -g... no
checking how to run the C preprocessor... /lib/cpp
checking for ranlib... ranlib
checking for as... /usr/bin/as
checking for ar... /usr/bin/ar
checking for ld... /usr/bin/ld
checking for strip... /usr/bin/strip
checking for windres... /usr/bin/windres
checking for gcc -pipe support... no
checking whether C compiler supports -fprofile-generate... yes
checking for perl5... C:/cygwin/bin/perl
checking for dlopen in -ldl... no
checking for lchown... no
checking for strerror... yes
checking for pthread_create in -lpthreads... dummy.c
dummy.c(2) : fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory
no
checking for pthread_create in -lpthread... dummy.c
dummy.c(2) : fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory
no
checking for pthread_create in -lc_r... dummy.c
dummy.c(2) : fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory
no
checking for pthread_create in -lc... dummy.c
dummy.c(2) : fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory
no
updating cache ./config.cache
creating ./config.status
creating Makefile
creating config/Makefile
creating config/autoconf.mk
creating config/nsprincl.mk
creating config/nsprincl.sh
creating config/nspr-config
creating lib/Makefile
creating lib/ds/Makefile
creating lib/libc/Makefile
creating lib/libc/include/Makefile
creating lib/libc/src/Makefile
creating lib/tests/Makefile
creating pkg/Makefile
creating pkg/linux/Makefile
creating pkg/solaris/Makefile
creating pkg/solaris/SUNWpr/Makefile
creating pkg/solaris/SUNWprd/Makefile
creating pr/Makefile
creating pr/include/Makefile
creating pr/include/md/Makefile
creating pr/include/obsolete/Makefile
creating pr/include/private/Makefile
creating pr/src/Makefile
creating pr/src/io/Makefile
creating pr/src/linking/Makefile
creating pr/src/malloc/Makefile
creating pr/src/md/Makefile
creating pr/src/md/windows/Makefile
creating pr/src/memory/Makefile
creating pr/src/misc/Makefile
creating pr/src/threads/Makefile
creating pr/tests/Makefile
creating pr/tests/dl

Re: [Libreoffice] Tinderbox failure, last success: 2011-11-18 20:05:29

[Caolán McNamara]

On Mon, 2011-11-28 at 11:09 +0100, Jan Holesovsky wrote:
> And the winner is... Miklos!  Thank you for the fix, changing
> onmouseover to onclick for the Close button did it.  Looking forward to
> meeting you at the conference (or earlier) to keep my promise :-)

Yah, *crowd cheers*. 

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] Add genitive and partitive month names for fi_FI locale

[Thorsten Behrens]

Harri Pitkänen wrote:
> Add genitive and partitive month names and remove hardcoded case
> suffixes from predefined date formats. One format incorrectly
> had case suffixes added to abbreviated month names.
>
Sweet, pushed as-is. Many thanks!!
 
-- Thorsten


pgpHJ5V2IdTMH.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] final and override

[Michael Meeks]

On Mon, 2011-11-28 at 09:03 +0100, Stephan Bergmann wrote:
> VOS_NAMESPACE etc. stuff, e.g.), we will likely need macros for new 
> features that can be enabled for compilers that already understand them, 
> without breaking the code for legacy compilers.

I believe the Mozilla guys augment this stuff by having an LLVM plugin
that does the validation of the keywords on top of the compiler. That
seems like a sensible approach to me.

On the other hand; I'd (personally) prefer to use some defines to
create the 'override' and 'final' keywords (as they will be in future).
Defining them to 'virtual' or even empty would do, if they are not
present in the compiler. cf. glib's provision of a stock 'inline'.

That should help reduce code thrash, and hideous ugliness ;-) keeping
us closer to more readable, standard C++.

HTH,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Translation of German comments in /svx/source/svdraw

[Thorsten Behrens]

Stefan Knorr (Astron) wrote:
> The above patch and all of my possible future contributions is/are
> made available under the LGPLv3+/MPL.
>
Hi Astron,

really nice big cleanup, thanks for that - pushed with a few tiny
edits.

Would you want to add a line for yourself to
http://wiki.documentfoundation.org/Development/Developers, and link
your license statement email from there?

Cheers,

-- Thorsten


pgpUPERfNdlM9.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Tinderbox failure, last success: 2011-11-18 20:05:29

[Jan Holesovsky]

Hi Miklos,

On 2011-11-22 at 00:56 +0100, Jan Holesovsky wrote:

[...on the Tinderbox status page...]
> Unfortunately the JavaScript the page uses
> sometimes makes the window disappear before you reach the choice; in
> that case it helps to move the mouse cursor around that window, and
> enter it from a different direction.  [No kidding - if anybody of you
> knows how to fix this annoying behavior, I'll buy you a beer at the next
> LibreOffice conference.]

And the winner is... Miklos!  Thank you for the fix, changing
onmouseover to onclick for the Close button did it.  Looking forward to
meeting you at the conference (or earlier) to keep my promise :-)

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [libreoffice-l10n] [ANNOUNCE] added possessive genitive case month names, HEADS UP localizers ; -)

[Serg Bormant]

Hi Eike, all

Here is Russian GenitiveMonths patch.
Cc-ed to e-mail.

-- 
wbr, sb


ru_RU.GenitiveMonths.diff.gz
Description: GNU Zip compressed data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Hide function pointers

[Stephan Bergmann]

On 11/27/2011 08:57 AM, Daisuke Nishino wrote:

Exposing functioin pointers to outside is not a good practice I think.
This patch encapsulates them.
Also, since fnLeaveSelect is called from only one location, I eliminated
the indirection.


Great, thanks.  Pushed (I simplified the "this->*this->" calls by 
removing the redundant second "this->").


I do not find your license statement at 
, can you add 
it there (I assume you contribute under LGPLv3+/MPL 1.1+)?


Thanks,
Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Eclipse: Libre Office integration help

[Michael Meeks]

Hi there,

On Sun, 2011-11-27 at 17:29 +0530, deenadayalan k wrote:
> Can anybody provide some information on how to integrate libre Office
> SDK source (LGPL license) in my own Eclipse RCP application? 

Can you ask a more specific question ? is it about license compliance ?
or about integrating these together into something that works or ... ?

If it is license compliance; I suggest you ship and offer the source
code for the URE / LibreOffice SDK with your application.

HTH,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Cherry pick a commit for fdo 43263

[Lionel Elie Mamane]

On Sat, Nov 26, 2011 at 12:26:16PM -0800, julien2412 wrote:

> As I explained on the comment
> https://bugs.freedesktop.org/show_bug.cgi?id=43263#c1,
> the commit b645f9195f4da3014e001fb27b8a117d89c8f389 could be cherry picked
> on 3.4 branch to fix the crash.

Did that.

> PS : I don't know how to cherry pick but if someone could explain me
> or show me a link, I'd be glad to learn :-)

Normally, with git, it would be pretty easy:

git cherry-pick b645f9195f4da3014e001fb27b8a117d89c8f389

But it is made more complicated by the fact that libreoffice-3-4 and
master are in different git repositories. So I did:

~/src/libreoffice/libreoffice-3.4/clone/filters$ ( cd ~/src/libreoffice/core/; 
git format-patch --stdout 
b645f9195f4da3014e001fb27b8a117d89c8f389^1..b645f9195f4da3014e001fb27b8a117d89c8f389
 ) | git am -s

Maybe a bit more clear like that:

 cd /libo3-4/clone/FOO
 CHERRYPICK_ID=b645f9195f4da3014e001fb27b8a117d89c8f389
 LIBO_CORE_DIR=~/src/libreoffice/core/
 ( cd  "${LIBO_CORE_DIR}"; git format-patch --stdout ${CHERRYPICK_ID}^1.. 
${CHERRYPICK_ID} ) \
   git am -s

-- 
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] PostgreSQL-SDBC in LO: build system help

[Lionel Elie Mamane]

On Thu, Nov 17, 2011 at 01:35:25AM +0100, Fridrich Strba wrote:
> On 16/11/11 23:22, Lionel Elie Mamane wrote:
>> *** Necessary before pushing to master ***

>>  - Add an option --enable-ext-postgresql-sdbc, similar to
>>--enable-ext-mysql-connector, and if that option is not given don't
>>build postgresql-sdbc

> I can give you a hand with this next week. Is it enough?

That's done with the kind help of Norbert Thiebaud. The code is now in
master, but:

>>  - General review of
>>connectivity/source/drivers/postgresql/makefile.mk
>>  - The .oxt file is created in ${OUTDIR}/lib; that's probably not that
>>good a choice. MySQL driver seems to do it ${OUTDIR}/bin, shall
>>PostgreSQL driver do the same?
>>  - The build system currently "just" creates a .oxt file; should
>>probably be changed to take into account
>>"--with-extension-integration".

> Will help with this too,

My I kindly remind you of this? We are already missing the beta0
deadline, I'd like not to miss the 3.5 features deadline. Thanks in
advance!

> not sure about the internal postgresql though.

Yeah, keeping it as external is OK; after all, we do that for the
MySQL C client library, too.

-- 
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Eclipse: Libre Office integration help

[Cedric Bosdonnat]

Hello,

On Sun, 2011-11-27 at 17:29 +0530, deenadayalan k wrote:
> Can anybody provide some information on how to integrate libre Office
> SDK source (LGPL license) in my own Eclipse RCP application? 

You asked me the same question privately and I see no reason to answer
it privately. I worked on that years ago for Nuxeo, but I fear the code
is no longer available.

Here are some blog posts I wrote at that time who could help you:
http://blogs.nuxeo.com/dev/2006/06/openoffice-org-editor-in-eclipse-first-version.html
http://blogs.nuxeo.com/dev/2006/06/embedding-ooo-and-msoffice-in-eclipse-part-3.html

The main problem is that you need to setup the proper classpath at
runtime as each Eclipse plugin has its own classpath and you don't know
for sure the path to LO jars on the machine.

You can also find some similar code in OOEclipse:
http://cgit.freedesktop.org/libreoffice/contrib/ooeclipse/tree/core/source/org/openoffice/ide/eclipse/core/office

I hope this could help you.

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Leftovers

[Lionel Elie Mamane]

.On Sun, Nov 27, 2011 at 03:15:31AM -0800, Tom wrote:

> Just a normal bug-report but with "[wish-list]" added into the
> subject-line should be ok?

Use the second method (not the assistant), see section "Reporting a
bug in few steps" at
http://wiki.documentfoundation.org/BugReport#Reporting_a_bug_in_few_Steps

Then put "enhancement" for the field "severity".

-- 
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] windows make dev-install, was build break in smoketestoo_native : LibO_*_install-arc_en-US.zip: No such file or directory

[Stephan Bergmann]

On 11/25/2011 09:48 PM, Tor Lillqvist wrote:

Hmm, this is windows. I'm not altogether sure that the
"make dev-install" suggestion makes sense for windows ?


I don't think it does, no.


In principle, given that "make dev-install" essentially just builds 
smoketestoo_native to get a working installation in solver (as a side 
effect), and smoketest should work on Windows (at least it used to for 
OOo), this should not fail to work on Windows.


One difference (in OOo) has always been that smoketestoo_native put the 
installation not under solver, but in some temp path (and removed it 
again after running the smoketest).  This was to take care of the 
problem with long pathnames on Windows (with the assumption that the 
paths into the temp directory would be shorter than those into solver).


So even if smoketestoo_native were not broken on Windows (it at least 
looks so from the OP), building smoketestoo_native would not have the 
desired side effect of leaving a working installation in solver.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] final and override

[Stephan Bergmann]

On 11/27/2011 08:58 PM, Noel Grandin wrote:

I see the Mozilla project is adding MOZ_FINAL and MOZ_OVERRIDE macros
to help control method overriding in their codebase

http://whereswalden.com/2011/11/16/introducing-moz_override-to-annotate-virtual-functions-which-override-base-class-virtual-functions/
http://whereswalden.com/2011/11/26/introducing-moz_final-prevent-inheriting-from-a-class-or-prevent-overriding-a-virtual-function/

Would such things be useful additions to the LibreOffice codebase?


In principle, yes.  Like happened with features of the old C++ Standard 
that only made it slowly into the various compilers (the infamous 
VOS_NAMESPACE etc. stuff, e.g.), we will likely need macros for new 
features that can be enabled for compilers that already understand them, 
without breaking the code for legacy compilers.


However, given that override and final will only make it into GCC 4.7 
(according to ), it 
might still be a bit early to address them.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice