[Libreoffice-commits] .: sc/source
sc/source/core/data/document.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 32dc82b9d456ed92ba946611239349ab0e424e2a Author: David Tardon dtar...@redhat.com Date: Thu Mar 15 09:43:26 2012 +0100 fdo#47311 don't crash when pasting into more than 1 sheet diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx index 2a5c751..60ba818 100644 --- a/sc/source/core/data/document.cxx +++ b/sc/source/core/data/document.cxx @@ -2277,7 +2277,7 @@ void ScDocument::CopyBlockFromClip( SCCOL nCol1, SCROW nRow1, while ( i + nFollow nTabEnd rMark.GetTableSelect( i + nFollow + 1 ) nClipTab + nFollow MAXTAB - rClipTabs[nClipTab + nFollow + 1] ) + rClipTabs[(nClipTab + nFollow + 1) % static_castSCTAB(rClipTabs.size())] ) ++nFollow; if ( pCBFCP-pClipDoc-GetClipParam().mbCutMode ) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configmgr/source
configmgr/source/components.cxx | 40 +++-
1 file changed, 31 insertions(+), 9 deletions(-)
New commits:
commit 84ecea9655267afc266b79059baa4512a285b1f2
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Mar 15 09:34:56 2012 +0100
fdo#42961 Don't let env vars interfere with internal bootstrap vars
diff --git a/configmgr/source/components.cxx b/configmgr/source/components.cxx
index 0e1c7e4..6f18508 100644
--- a/configmgr/source/components.cxx
+++ b/configmgr/source/components.cxx
@@ -53,6 +53,7 @@
#include rtl/oustringostreaminserter.hxx
#include rtl/ref.hxx
#include rtl/string.h
+#include rtl/ustrbuf.hxx
#include rtl/ustring.h
#include rtl/ustring.hxx
#include rtl/instance.hxx
@@ -827,17 +828,38 @@ void Components::parseXcsXcuLayer(int layer,
rtl::OUString const url) {
void Components::parseXcsXcuIniLayer(
int layer, rtl::OUString const url, bool recordAdditions)
{
-//TODO: rtl::Bootstrap::getFrom first trie[s] to retrieve the value via
the
-// global function
+// Check if ini file exists (otherwise .override would still read global
+// SCHEMA/DATA variables, which could interfere with unrelated environment
+// variables):
rtl::Bootstrap ini(url);
-rtl::OUString urls;
-if (ini.getFrom(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(SCHEMA)),
urls))
+if (ini.getHandle() != 0)
{
-parseFileList(layer, parseXcsFile, urls, ini, false);
-}
-if (ini.getFrom(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(DATA)), urls))
-{
-parseFileList(layer + 1, parseXcuFile, urls, ini, recordAdditions);
+rtl::OUStringBuffer prefix(${.override:);
+for (sal_Int32 i = 0; i != url.getLength(); ++i) {
+sal_Unicode c = url[i];
+switch (c) {
+case '$':
+case ':':
+case '\\':
+prefix.append('\\');
+// fall through
+default:
+prefix.append(c);
+}
+}
+prefix.append(':');
+rtl::OUString urls(prefix.toString() + rtl::OUString(SCHEMA}));
+rtl::Bootstrap::expandMacros(urls);
+if (!urls.isEmpty())
+{
+parseFileList(layer, parseXcsFile, urls, ini, false);
+}
+urls = prefix.makeStringAndClear() + rtl::OUString(DATA});
+rtl::Bootstrap::expandMacros(urls);
+if (!urls.isEmpty())
+{
+parseFileList(layer + 1, parseXcuFile, urls, ini,
recordAdditions);
+}
}
}
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: fpicker/source
fpicker/source/win32/filepicker/FPentry.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit d5e83535a5ab32dc0730e6edab116855875bfa74 Author: David Tardon dtar...@redhat.com Date: Thu Mar 15 10:28:07 2012 +0100 error: 'XFolderPicker' was not declared in this scope diff --git a/fpicker/source/win32/filepicker/FPentry.cxx b/fpicker/source/win32/filepicker/FPentry.cxx index 0242171..3c1e0c0 100644 --- a/fpicker/source/win32/filepicker/FPentry.cxx +++ b/fpicker/source/win32/filepicker/FPentry.cxx @@ -59,6 +59,7 @@ using namespace ::com::sun::star::registry ; using namespace ::cppu ; using ::com::sun::star::ui::dialogs::XFilePicker; using ::com::sun::star::ui::dialogs::XFilePicker2; +using ::com::sun::star::ui::dialogs::XFolderPicker; // // ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: fpicker/Library_fps.mk fpicker/source
fpicker/Library_fps.mk |1
fpicker/source/win32/folderpicker/Fopentry.cxx | 102 -
2 files changed, 103 deletions(-)
New commits:
commit f04e6b0e965e3a4301e705fb41a15c5560765b5b
Author: Michael Stahl mst...@redhat.com
Date: Thu Mar 15 10:28:33 2012 +0100
fdo#47246: fpicker: merge fop into fps: remove Fopentry.cxx
Forgot that in 095528351c3c916ef3c79f7275113ec628b4d473.
diff --git a/fpicker/Library_fps.mk b/fpicker/Library_fps.mk
index e70bdf4..986b167 100644
--- a/fpicker/Library_fps.mk
+++ b/fpicker/Library_fps.mk
@@ -94,7 +94,6 @@ $(eval $(call gb_Library_add_exception_objects,fps,\
fpicker/source/win32/filepicker/VistaFilePickerImpl \
fpicker/source/win32/filepicker/WinFileOpenImpl \
fpicker/source/win32/folderpicker/FolderPicker \
- fpicker/source/win32/folderpicker/Fopentry \
fpicker/source/win32/folderpicker/MtaFop \
fpicker/source/win32/folderpicker/WinFOPImpl \
fpicker/source/win32/misc/AutoBuffer \
diff --git a/fpicker/source/win32/folderpicker/Fopentry.cxx
b/fpicker/source/win32/folderpicker/Fopentry.cxx
deleted file mode 100644
index e90ea62..000
--- a/fpicker/source/win32/folderpicker/Fopentry.cxx
+++ /dev/null
@@ -1,102 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- *
- * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
- *
- * Copyright 2000, 2010 Oracle and/or its affiliates.
- *
- * OpenOffice.org - a multi-platform office productivity suite
- *
- * This file is part of OpenOffice.org.
- *
- * OpenOffice.org is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License version 3
- * only, as published by the Free Software Foundation.
- *
- * OpenOffice.org is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Lesser General Public License version 3 for more details
- * (a copy is included in the LICENSE file that accompanied this code).
- *
- * You should have received a copy of the GNU Lesser General Public License
- * version 3 along with OpenOffice.org. If not, see
- * http://www.openoffice.org/license.html
- * for a copy of the LGPLv3 License.
- *
- /
-
-
-//---
-// includes of other projects
-//---
-#include cppuhelper/factory.hxx
-#include com/sun/star/container/XSet.hpp
-#include osl/diagnose.h
-
-#include FolderPicker.hxx
-
-#include FOPServiceInfo.hxx
-#include WinFOPImpl.hxx
-
-//---
-// namespace directives
-//---
-
-using namespace ::rtl ;
-using namespace ::com::sun::star::uno ;
-using namespace ::com::sun::star::container ;
-using namespace ::com::sun::star::lang ;
-using namespace ::com::sun::star::registry ;
-using namespace ::cppu ;
-using com::sun::star::ui::dialogs::XFolderPicker;
-
-
-namespace
-{
-
-//---
-//
-//---
-
-Reference XInterface SAL_CALL createInstance( const Reference
XMultiServiceFactory rServiceManager )
-{
-return Reference XInterface ( static_cast XFolderPicker* ( new
CFolderPicker( rServiceManager ) ) );
-}
-}
-
-extern C
-{
-
-//--
-// component_getFactory
-// returns a factory to create XFilePicker-Services
-//--
-
-SAL_DLLPUBLIC_EXPORT void* SAL_CALL component_getFactory( const sal_Char*
pImplName, uno_Interface* pSrvManager, uno_Interface* )
-{
-void* pRet = 0;
-
-if ( pSrvManager ( 0 == rtl_str_compare( pImplName,
FOLDER_PICKER_IMPL_NAME ) ) )
-{
-Sequence OUString aSNS( 1 );
-aSNS.getArray( )[0] = OUString( RTL_CONSTASCII_USTRINGPARAM(
FOLDER_PICKER_SERVICE_NAME ) );
-
-Reference XSingleServiceFactory xFactory ( createSingleFactory(
-reinterpret_cast XMultiServiceFactory* ( pSrvManager ),
-OUString::createFromAscii( pImplName ),
-createInstance,
-aSNS ) );
-if ( xFactory.is() )
-{
-xFactory-acquire();
-pRet = xFactory.get();
-}
-}
-
-return pRet;
-}
-
-} // extern C
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - configmgr/source
configmgr/source/components.cxx | 40 +++-
1 file changed, 31 insertions(+), 9 deletions(-)
New commits:
commit 4f78696117ebe4f729880b5d9bfc2f5817b73543
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Mar 15 09:34:56 2012 +0100
fdo#42961 Don't let env vars interfere with internal bootstrap vars
Signed-off-by: Michael Meeks michael.me...@suse.com
diff --git a/configmgr/source/components.cxx b/configmgr/source/components.cxx
index 48d555e..a341d84 100644
--- a/configmgr/source/components.cxx
+++ b/configmgr/source/components.cxx
@@ -54,6 +54,7 @@
#include rtl/oustringostreaminserter.hxx
#include rtl/ref.hxx
#include rtl/string.h
+#include rtl/ustrbuf.hxx
#include rtl/ustring.h
#include rtl/ustring.hxx
#include rtl/instance.hxx
@@ -838,17 +839,38 @@ void Components::parseXcsXcuLayer(int layer,
rtl::OUString const url) {
void Components::parseXcsXcuIniLayer(
int layer, rtl::OUString const url, bool recordAdditions)
{
-//TODO: rtl::Bootstrap::getFrom first trie[s] to retrieve the value via
the
-// global function
+// Check if ini file exists (otherwise .override would still read global
+// SCHEMA/DATA variables, which could interfere with unrelated environment
+// variables):
rtl::Bootstrap ini(url);
-rtl::OUString urls;
-if (ini.getFrom(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(SCHEMA)),
urls))
+if (ini.getHandle() != 0)
{
-parseFileList(layer, parseXcsFile, urls, ini, false);
-}
-if (ini.getFrom(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(DATA)), urls))
-{
-parseFileList(layer + 1, parseXcuFile, urls, ini, recordAdditions);
+rtl::OUStringBuffer prefix(${.override:);
+for (sal_Int32 i = 0; i != url.getLength(); ++i) {
+sal_Unicode c = url[i];
+switch (c) {
+case '$':
+case ':':
+case '\\':
+prefix.append('\\');
+// fall through
+default:
+prefix.append(c);
+}
+}
+prefix.append(':');
+rtl::OUString urls(prefix.toString() + rtl::OUString(SCHEMA}));
+rtl::Bootstrap::expandMacros(urls);
+if (!urls.isEmpty())
+{
+parseFileList(layer, parseXcsFile, urls, ini, false);
+}
+urls = prefix.makeStringAndClear() + rtl::OUString(DATA});
+rtl::Bootstrap::expandMacros(urls);
+if (!urls.isEmpty())
+{
+parseFileList(layer + 1, parseXcuFile, urls, ini,
recordAdditions);
+}
}
}
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: solenv/gbuild solenv/inc
solenv/gbuild/platform/WNT_INTEL_MSC.mk |1 + solenv/inc/wntmsc.mk|4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) New commits: commit 370b3b6232a0851d68bb894c2b8ee71b9504384b Author: Lubos Lunak ke...@suse.cz Date: Thu Mar 15 11:45:08 2012 +0100 disable msvc warning 4265 (non-virtual dtor) msvc2008 now prints out a lot of warnings, probably a result of the recent -Wnon-virtual-dtor changes where msvc does not understand the protected dtor actually makes the code to be ok diff --git a/solenv/gbuild/platform/WNT_INTEL_MSC.mk b/solenv/gbuild/platform/WNT_INTEL_MSC.mk index 6902642..ab7728e 100644 --- a/solenv/gbuild/platform/WNT_INTEL_MSC.mk +++ b/solenv/gbuild/platform/WNT_INTEL_MSC.mk @@ -147,6 +147,7 @@ gb_CXXFLAGS := \ -wd4245 \ -wd4250 \ -wd4251 \ + -wd4265 \ -wd4275 \ -wd4290 \ -wd4294 \ diff --git a/solenv/inc/wntmsc.mk b/solenv/inc/wntmsc.mk index f7b2dbe..afafe38 100644 --- a/solenv/inc/wntmsc.mk +++ b/solenv/inc/wntmsc.mk @@ -173,6 +173,8 @@ CFLAGSOUTOBJ=-Fo # (http://msdn2.microsoft.com/en-us/library/074af4b6.aspx) # - warning C4180: qualifier applied to function type has no meaning; ignored # (frequently seen with a recent boost) +# - warning C4265: 'identifier' : class has virtual functions, but destructor is not +# virtual # For C, certain warnings from system headers (stdlib.h etc.) have to be # disabled globally (for C++, this is not necessary, as the system headers are # wrapped by STLport): @@ -184,7 +186,7 @@ CFLAGSWARNCXX=-Wall -wd4061 -wd4127 -wd4191 -wd4217 -wd4242 -wd4244 -wd4245 -wd4 -wd4290 -wd4294 -wd4355 -wd4511 -wd4512 -wd4514 -wd4555 -wd4611 -wd4625 -wd4626 \ -wd4640 -wd4675 -wd4686 -wd4706 -wd4710 -wd4711 -wd4786 -wd4800 -wd4820 -wd4503 -wd4619 \ -wd4365 -wd4668 -wd4738 -wd4826 -wd4350 -wd4505 -wd4692 -wd4189 -wd4005 \ --wd4180 +-wd4180 -wd4265 CFLAGSWARNCC=$(CFLAGSWARNCXX) -wd4255 CFLAGSWALLCC=$(CFLAGSWARNCC) CFLAGSWALLCXX=$(CFLAGSWARNCXX) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: solenv/gbuild solenv/inc
solenv/gbuild/platform/unxgcc.mk |4 solenv/inc/unxgcc.mk |4 2 files changed, 8 insertions(+) New commits: commit cc9a10185749210825fe6970ea4b103eb78e329e Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Thu Mar 15 10:30:39 2012 +0100 clang doesn't have a problem with -Wnon-virtual-dtor Even if some older version possibly does, I doubt anybody would realistically use it. diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk index 1565d1c..9c2b405 100644 --- a/solenv/gbuild/platform/unxgcc.mk +++ b/solenv/gbuild/platform/unxgcc.mk @@ -65,6 +65,7 @@ gb_CXXFLAGS := \ -Wsign-promo \ -Woverloaded-virtual \ +ifneq ($(COM_GCC_IS_CLANG),TRUE) # Only GCC 4.6 has a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7302 # -Wnon-virtual-dtor should't complain of protected dtor and supports #pragma # GCC diagnostic push/pop required e.g. in cppuhelper/propertysetmixin.hxx to @@ -75,6 +76,9 @@ gb_CXXFLAGS += -Wno-non-virtual-dtor else gb_CXXFLAGS += -Wnon-virtual-dtor endif +else +gb_CXXFLAGS += -Wnon-virtual-dtor +endif ifeq ($(HAVE_GCC_VISIBILITY_FEATURE),TRUE) gb_COMPILERDEFS += \ diff --git a/solenv/inc/unxgcc.mk b/solenv/inc/unxgcc.mk index 5ef9f98..4f9ebee 100644 --- a/solenv/inc/unxgcc.mk +++ b/solenv/inc/unxgcc.mk @@ -148,6 +148,7 @@ CFLAGSWALLCC=$(CFLAGSWARNCC) CFLAGSWALLCXX=$(CFLAGSWARNCXX) CFLAGSWERRCC=-Werror -DLIBO_WERROR +.IF $(COM_GCC_IS_CLANG) != TRUE # Only GCC 4.6 has a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7302 # -Wnon-virtual-dtor should't complain of protected dtor and supports #pragma # GCC diagnostic push/pop required e.g. in cppuhelper/propertysetmixin.hxx to @@ -158,6 +159,9 @@ CFLAGSWARNCXX += -Wno-non-virtual-dtor .ELSE CFLAGSWARNCXX += -Wnon-virtual-dtor .END +.ELSE +CFLAGSWARNCXX += -Wnon-virtual-dtor +.END COMPILER_WARN_ERRORS=TRUE ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: vcl/source
vcl/source/gdi/print3.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 504aead0573befc744a00b8b1d68e3ebbaca8c47
Author: David Tardon dtar...@redhat.com
Date: Thu Mar 15 14:15:09 2012 +0100
Revert fix setting of paper tray from print dialog (fdo#43932)
This reverts commit 6d4cca9c22c52b5a7742adc47ebf1a2930e29764.
diff --git a/vcl/source/gdi/print3.cxx b/vcl/source/gdi/print3.cxx
index 817e6d5..4824203 100644
--- a/vcl/source/gdi/print3.cxx
+++ b/vcl/source/gdi/print3.cxx
@@ -773,7 +773,7 @@ PrinterController::PageSize
vcl::ImplPrinterControllerData::modifyJobSetup( cons
PrinterController::PageSize aPageSize;
aPageSize.aSize = mpPrinter-GetPaperSize();
awt::Size aSetSize, aIsSize;
-sal_Int32 nPaperBin = (mnFixedPaperBin != -1) ? mnFixedPaperBin :
mnDefaultPaperBin;
+sal_Int32 nPaperBin = mnDefaultPaperBin;
for( sal_Int32 nProperty = 0, nPropertyCount = i_rProps.getLength();
nProperty nPropertyCount; ++nProperty )
{
if( i_rProps[ nProperty ].Name.equalsAsciiL(
RTL_CONSTASCII_STRINGPARAM( PreferredPageSize ) ) )
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.in
configure.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c5489e31b625e08fa2427108d5e710aba4468a27 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Wed Mar 14 14:34:22 2012 +0100 need to be afraid of empty quoted strings as test arguments At least 07a841bc1acde95229ece2a0da4e2a70be5df624 says so. diff --git a/configure.in b/configure.in index e0bc4dd..f71014d 100644 --- a/configure.in +++ b/configure.in @@ -79,7 +79,7 @@ AC_SUBST(x_Cygwin) cat /dev/null warn -if test $EUID = 0 -a `uname -o 2/dev/null` = Cygwin; then +if test z$EUID = z0 -a `uname -o 2/dev/null` = Cygwin; then AC_MSG_ERROR([You must build LibreOffice as a normal user - not using an administrative account]) fi ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'update' - check.php
check.php | 19 ++-
1 file changed, 6 insertions(+), 13 deletions(-)
New commits:
commit bd668c3fff2668667d29e063cc1da50d39f981a0
Author: Jan Holesovsky ke...@suse.cz
Date: Thu Mar 15 14:28:49 2012 +0100
3.5.1 RC2 is Final, update everything earlier to that.
diff --git a/check.php b/check.php
index 3622bf8..a5157a3 100644
--- a/check.php
+++ b/check.php
@@ -101,13 +101,12 @@ $update_versions = array(
'e40af8c-10029e3-615e522-88673a2-727f724' = 'LO-3.5', # 3.5.0 Beta3
'b6c8ba5-8c0b455-0b5e650-d7f0dd3-b100c87' = 'LO-3.5', # 3.5.0 RC1
'e371a95-bf68a13-5a1aa2b-d3c1ae9-b938258' = 'LO-3.5', # 3.5.0 RC2
-# To be uncommented when 3.5.1 Final is out
-#'7e68ba2-a744ebf-1f241b7-c506db1-7d53735' = 'LO-3.5', # 3.5.0 RC3 /
Final
+'7e68ba2-a744ebf-1f241b7-c506db1-7d53735' = 'LO-3.5', # 3.5.0 RC3 / Final
# 3.5.1 versions
-'45a2874-aa8c38d-dff3b9c-def3dbd-62463c8' = 'LO-3.5-pre', # 3.5.1 RC1
+'45a2874-aa8c38d-dff3b9c-def3dbd-62463c8' = 'LO-3.5', # 3.5.1 RC1
# To be uncommented when 3.5.2 Final is out
-#'dc9775d-05ecbee-0851ad3-1586698-727bf66' = 'LO-3.5', # 3.5.1 RC2
+#'dc9775d-05ecbee-0851ad3-1586698-727bf66' = 'LO-3.5', # 3.5.1 RC2 /
Final
);
# Descriptions of the target versions
@@ -115,17 +114,11 @@ $update_versions = array(
# 'gitid' is the content of program/versionrc:buildid of the newest version
# 'id' is what is going to be shown in the update information dialog
$update_map = array(
-'LO-3.5' = array('gitid' =
'7e68ba2-a744ebf-1f241b7-c506db1-7d53735',
- 'id' = 'LibreOffice 3.5.0',
- 'version' = '3.5.0',
+'LO-3.5' = array('gitid' =
'dc9775d-05ecbee-0851ad3-1586698-727bf66',
+ 'id' = 'LibreOffice 3.5.1',
+ 'version' = '3.5.1',
'update_type' = 'text/html',
'update_src' = 'http://www.libreoffice.org/download/'),
-# To be deleted when 3.5.1 is Final
-'LO-3.5-pre' = array('gitid' =
'dc9775d-05ecbee-0851ad3-1586698-727bf66',
- 'id' = 'LibreOffice 3.5.1 RC2',
- 'version' = '3.5.1 RC2',
- 'update_type' = 'text/html',
- 'update_src' =
'http://www.libreoffice.org/download/pre-releases/'),
# To be uncommented when 3.5.2 RC2 is out, to get updates from 3.5.2 RC1
#'LO-3.5-pre' = array('gitid' = '',
# 'id' = 'LibreOffice 3.5.2 RC2',
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - configure.in sw/Module_sw.mk
configure.in|6 --
sw/Module_sw.mk |4 ++--
2 files changed, 6 insertions(+), 4 deletions(-)
New commits:
commit b1c472c7021ebb85afdc5c4afd0e0fcd74ab15d9
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Thu Mar 15 16:04:12 2012 +0100
do not leave temporary files after a configure check
diff --git a/configure.in b/configure.in
index f71014d..72b45b9 100644
--- a/configure.in
+++ b/configure.in
@@ -4495,13 +4495,15 @@ struct S2: S1int { virtual ~S2(); };
struct S3: S2 { virtual ~S3(); }; S3::~S3() {}
_ACEOF
gccvisinlineshiddenok=yes
-if ! $CXX $CXXFLAGS $CPPFLAGS -shared -fPIC
-fvisibility-inlines-hidden conftestlib1.cc -o lib1.so /dev/null 2/dev/null;
then
+if ! $CXX $CXXFLAGS $CPPFLAGS -shared -fPIC
-fvisibility-inlines-hidden conftestlib1.cc -o libconftest1.so /dev/null
2/dev/null; then
gccvisinlineshiddenok=no
else
-if ! $CXX $CXXFLAGS $CPPFLAGS -shared -fPIC
-fvisibility-inlines-hidden conftestlib2.cc -L. -l1 -Wl,-z,defs -o lib2.so
/dev/null 2/dev/null; then
+if ! $CXX $CXXFLAGS $CPPFLAGS -shared -fPIC
-fvisibility-inlines-hidden conftestlib2.cc -L. -lconftest1 -Wl,-z,defs -o
libconftest2.so /dev/null 2/dev/null; then
gccvisinlineshiddenok=no
fi
fi
+
+rm -f libconftest1.so libconftest2.so
AC_MSG_RESULT([$gccvisinlineshiddenok])
if test $gccvisinlineshiddenok = no; then
commit 2db82ffc1bdd5865e51932930bb5c4688e2de8a3
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Thu Mar 15 16:00:02 2012 +0100
these writer unittests surely are slow
diff --git a/sw/Module_sw.mk b/sw/Module_sw.mk
index 6ecc588..8cf4f39 100644
--- a/sw/Module_sw.mk
+++ b/sw/Module_sw.mk
@@ -48,12 +48,12 @@ $(eval $(call gb_Module_add_targets,sw,\
endif
$(eval $(call gb_Module_add_check_targets,sw,\
-CppunitTest_sw_filters_test \
-CppunitTest_sw_macros_test \
CppunitTest_sw_swdoc_test \
))
$(eval $(call gb_Module_add_slowcheck_targets,sw,\
+CppunitTest_sw_filters_test \
+CppunitTest_sw_macros_test \
CppunitTest_sw_subsequent_rtftok \
))
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - configmgr/source
configmgr/source/components.cxx | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
New commits:
commit 90e2949099586e98619561dc781cc4deb8fc1ef0
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Mar 15 16:38:40 2012 +0100
Adapt prev 4f78696117ebe4f729880b5d9bfc2f5817b73543 to 3.5 rtl::OUString
diff --git a/configmgr/source/components.cxx b/configmgr/source/components.cxx
index a341d84..80741ae 100644
--- a/configmgr/source/components.cxx
+++ b/configmgr/source/components.cxx
@@ -845,7 +845,8 @@ void Components::parseXcsXcuIniLayer(
rtl::Bootstrap ini(url);
if (ini.getHandle() != 0)
{
-rtl::OUStringBuffer prefix(${.override:);
+rtl::OUStringBuffer prefix;
+prefix.appendAscii(RTL_CONSTASCII_STRINGPARAM(${.override:));
for (sal_Int32 i = 0; i != url.getLength(); ++i) {
sal_Unicode c = url[i];
switch (c) {
@@ -859,13 +860,16 @@ void Components::parseXcsXcuIniLayer(
}
}
prefix.append(':');
-rtl::OUString urls(prefix.toString() + rtl::OUString(SCHEMA}));
+rtl::OUString urls(
+prefix.toString()
++ rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(SCHEMA})));
rtl::Bootstrap::expandMacros(urls);
if (!urls.isEmpty())
{
parseFileList(layer, parseXcsFile, urls, ini, false);
}
-urls = prefix.makeStringAndClear() + rtl::OUString(DATA});
+urls = prefix.makeStringAndClear()
++ rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(DATA}));
rtl::Bootstrap::expandMacros(urls);
if (!urls.isEmpty())
{
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/filter/html/htmlpars.cxx |3 ++-
sc/source/filter/inc/eeparser.hxx |8 +---
sc/source/filter/rtf/eeimpars.cxx | 28
3 files changed, 23 insertions(+), 16 deletions(-)
New commits:
commit 96328945afe8f920df41741931163ba56b7b2820
Author: Noel Grandin n...@peralex.com
Date: Wed Mar 14 14:00:35 2012 +0200
Convert tools/table.hxx to std::map in ScEEParser class in SC module
diff --git a/sc/source/filter/html/htmlpars.cxx
b/sc/source/filter/html/htmlpars.cxx
index 323e1a2..b9f9fb8 100644
--- a/sc/source/filter/html/htmlpars.cxx
+++ b/sc/source/filter/html/htmlpars.cxx
@@ -58,6 +58,7 @@
#include vcl/svapp.hxx
#include tools/urlobj.hxx
#include tools/tenccvt.hxx
+#include tools/table.hxx
#include htmlpars.hxx
#include global.hxx
@@ -331,7 +332,7 @@ sal_uLong ScHTMLLayoutParser::Read( SvStream rStream,
const String rBaseURL )
{
aSize.Width() = *pOff - nOff;
aSize = pDefaultDev-PixelToLogic( aSize, MapMode( MAP_TWIP ) );
-pColWidths-Insert( j-1, (void*)aSize.Width() );
+maColWidths[ j-1 ] = aSize.Width();
nOff = *pOff;
}
return nErr;
diff --git a/sc/source/filter/inc/eeparser.hxx
b/sc/source/filter/inc/eeparser.hxx
index dc1daf1..9c272d0 100644
--- a/sc/source/filter/inc/eeparser.hxx
+++ b/sc/source/filter/inc/eeparser.hxx
@@ -32,7 +32,6 @@
#include tools/string.hxx
#include tools/gen.hxx
#include vcl/graph.hxx
-#include tools/table.hxx
#include svl/itemset.hxx
#include editeng/editdata.hxx
#include address.hxx
@@ -108,6 +107,8 @@ struct ScEEParseEntry
class EditEngine;
+typedef std::mapSCCOL, sal_uInt16 ColWidthsMap;
+
class ScEEParser
{
protected:
@@ -116,7 +117,7 @@ protected:
SfxItemPool*pDocPool;
::std::vector ScEEParseEntry* maList;
ScEEParseEntry* pActEntry;
-Table* pColWidths;
+ColWidthsMapmaColWidths;
int nLastToken;
SCCOL nColCnt;
SCROW nRowCnt;
@@ -131,7 +132,8 @@ public:
virtual sal_uLong Read( SvStream, const String rBaseURL ) = 0;
-Table* GetColWidths() const { return pColWidths; }
+const ColWidthsMap GetColWidths() const { return maColWidths; }
+ColWidthsMap GetColWidths() { return maColWidths; }
voidGetDimensions( SCCOL nCols, SCROW nRows ) const
{ nCols = nColMax; nRows = nRowMax; }
diff --git a/sc/source/filter/rtf/eeimpars.cxx
b/sc/source/filter/rtf/eeimpars.cxx
index 2fb0484..d34e135 100644
--- a/sc/source/filter/rtf/eeimpars.cxx
+++ b/sc/source/filter/rtf/eeimpars.cxx
@@ -52,6 +52,7 @@
#include unotools/syslocale.hxx
#include unotools/charclass.hxx
#include comphelper/string.hxx
+#include tools/table.hxx
#include eeimport.hxx
#include global.hxx
@@ -431,14 +432,17 @@ void ScEEImport::WriteToDocument( sal_Bool bSizeColsRows,
double nOutputFactor,
if ( bSizeColsRows )
{
// Spaltenbreiten
-Table* pColWidths = mpParser-GetColWidths();
-if ( pColWidths-Count() )
+ColWidthsMap rColWidths = mpParser-GetColWidths();
+if ( !rColWidths.empty() )
{
nProgress = 0;
pProgress-SetState( nProgress, nEndCol - nStartCol + 1 );
for ( SCCOL nCol = nStartCol; nCol = nEndCol; nCol++ )
{
-sal_uInt16 nWidth = (sal_uInt16)(sal_uLong) pColWidths-Get(
nCol );
+sal_uInt16 nWidth = 0;
+ColWidthsMap::const_iterator it = rColWidths.find( nCol );
+if ( it != rColWidths.end() )
+nWidth = it-second;
if ( nWidth )
mpDoc-SetColWidth( nCol, nTab, nWidth );
pProgress-SetState( ++nProgress );
@@ -513,20 +517,22 @@ sal_Bool ScEEImport::GraphicSize( SCCOL nCol, SCROW nRow,
SCTAB /*nTab*/, ScEEPa
nDir = pI-nDir;
}
// Spaltenbreiten
-Table* pColWidths = mpParser-GetColWidths();
-long nThisWidth = (long) pColWidths-Get( nCol );
+ColWidthsMap rColWidths = mpParser-GetColWidths();
+long nThisWidth = 0;
+ColWidthsMap::const_iterator it = rColWidths.find( nCol );
+if ( it != rColWidths.end() )
+nThisWidth = it-second;
long nColWidths = nThisWidth;
SCCOL nColSpanCol = nCol + pE-nColOverlap;
for ( SCCOL nC = nCol + 1; nC nColSpanCol; nC++ )
{
-nColWidths += (long) pColWidths-Get( nC );
+ColWidthsMap::const_iterator it2 = rColWidths.find( nC );
+if ( it2 != rColWidths.end() )
+nColWidths += it2-second;
}
if ( nWidth nColWidths )
{ // Differenz nur in der ersten Spalte eintragen
-if ( nThisWidth )
-pColWidths-Replace( nCol, (void*)(nWidth - nColWidths +
nThisWidth) );
-else
-pColWidths-Insert( nCol, (void*)(nWidth - nColWidths) );
+
[Libreoffice-commits] .: dtrans/source
dtrans/source/win32/misc/ImplHelper.cxx | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
New commits:
commit 66d532fca4cf9504a53bbe0c8a584d1144fc8e0f
Author: Caolán McNamara caol...@redhat.com
Date: Thu Mar 15 13:28:18 2012 +
can't use auto_ptr with an array, wrong delete vs new[]
diff --git a/dtrans/source/win32/misc/ImplHelper.cxx
b/dtrans/source/win32/misc/ImplHelper.cxx
index 5243aac..04c850e 100644
--- a/dtrans/source/win32/misc/ImplHelper.cxx
+++ b/dtrans/source/win32/misc/ImplHelper.cxx
@@ -46,6 +46,8 @@
#include sehandler.hxx
#endif
+#include vector
+
//
// defines
//
@@ -133,15 +135,12 @@ OUString SAL_CALL getWinCPFromLocaleId( LCID lcid, LCTYPE
lctype )
OSL_ASSERT( len 0 );
-std::auto_ptr sal_Unicode lpwchBuff( new sal_Unicode[len] );
+std::vector sal_Unicode lpwchBuff(len);
-if ( NULL != lpwchBuff.get( ) )
-{
-len = MultiByteToWideChar(
-CP_ACP, 0, buff, -1, reinterpret_castLPWSTR(lpwchBuff.get(
)), len );
+len = MultiByteToWideChar(
+CP_ACP, 0, buff, -1, reinterpret_castLPWSTR(lpwchBuff[0]), len
);
-winCP = OUString( lpwchBuff.get( ), (len - 1) );
-}
+winCP = OUString( lpwchBuff[0], (len - 1) );
}
return winCP;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: binfilter/bf_sw binfilter/inc
binfilter/bf_sw/source/filter/inc/wrt_fn.hxx |5
binfilter/bf_sw/source/filter/writer/sw_writer.cxx | 128 -
binfilter/bf_sw/source/filter/writer/sw_wrt_fn.cxx | 61 --
binfilter/inc/bf_sw/shellio.hxx| 28
4 files changed, 222 deletions(-)
New commits:
commit 49d3d392b740bd90bacf73036b6dae454d8fa5c8
Author: Caolán McNamara caol...@redhat.com
Date: Thu Mar 15 16:25:46 2012 +
callcatcher: now safely remove the actually unused parts
diff --git a/binfilter/bf_sw/source/filter/inc/wrt_fn.hxx
b/binfilter/bf_sw/source/filter/inc/wrt_fn.hxx
index f0fd707..58aef01 100644
--- a/binfilter/bf_sw/source/filter/inc/wrt_fn.hxx
+++ b/binfilter/bf_sw/source/filter/inc/wrt_fn.hxx
@@ -46,11 +46,6 @@ class Writer;
typedef Writer (*FnAttrOut)( Writer, const SfxPoolItem );
typedef FnAttrOut SwAttrFnTab[ POOLATTR_END - POOLATTR_BEGIN ];
-Writer Out( const SwAttrFnTab, const SfxPoolItem, Writer );
-Writer Out_SfxItemSet( const SwAttrFnTab, Writer, const SfxItemSet,
- BOOL bDeep, BOOL bTstForDefault = TRUE );
-
-
/* Funktionspointer auf die Node-Write-Funktionen */
enum RES_NODE
diff --git a/binfilter/bf_sw/source/filter/writer/sw_writer.cxx
b/binfilter/bf_sw/source/filter/writer/sw_writer.cxx
index 0dcc3be..53069ed 100644
--- a/binfilter/bf_sw/source/filter/writer/sw_writer.cxx
+++ b/binfilter/bf_sw/source/filter/writer/sw_writer.cxx
@@ -53,10 +53,6 @@
#include swerror.h
namespace binfilter {
-// Stringbuffer fuer die umgewandelten Zahlen
-static sal_Char aNToABuf[] = 0;
-#define NTOABUFLEN (sizeof(aNToABuf))
-
/*N*/ DECLARE_TABLE( SwBookmarkNodeTable, SvPtrarr* )
/*N*/ struct Writer_Impl
@@ -166,28 +162,6 @@ static sal_Char aNToABuf[] = 0;
/*?*/ return TRUE;
/*N*/ }
-// suche die naechste Bookmark-Position aus der Bookmark-Tabelle
-
- SwPaM* Writer::NewSwPaM( SwDoc rDoc, ULONG nStartIdx, ULONG nEndIdx ) const
- {
-SwNodes* pNds = rDoc.GetNodes();
-
-SwNodeIndex aStt( *pNds, nStartIdx );
-SwCntntNode* pCNode = aStt.GetNode().GetCntntNode();
-if( !pCNode 0 == ( pCNode = pNds-GoNext( aStt )) )
-OSL_ENSURE( !this, An StartPos kein ContentNode mehr );
-
-SwPaM* pNew = new SwPaM( aStt );
-pNew-SetMark();
-aStt = nEndIdx;
-if( 0 == (pCNode = aStt.GetNode().GetCntntNode())
-0 == (pCNode = pNds-GoPrevious( aStt )) )
-OSL_ENSURE( !this, An StartPos kein ContentNode mehr );
-pCNode-MakeEndIndex( pNew-GetPoint()-nContent );
-pNew-GetPoint()-nNode = aStt;
-return pNew;
- }
-
// Stream-spezifisches
/*N*/ #ifdef DBG_UTIL
/*N*/ SvStream Writer::Strm()
@@ -198,53 +172,6 @@ static sal_Char aNToABuf[] = 0;
/*N*/ #endif
-SvStream Writer::OutHex( SvStream rStrm, ULONG nHex, BYTE nLen )
-{ // in einen Stream aus
-// Pointer an das Bufferende setzen
-sal_Char* pStr = aNToABuf + (NTOABUFLEN-1);
-for( BYTE n = 0; n nLen; ++n )
-{
-*(--pStr) = (sal_Char)(nHex 0xf ) + 48;
-if( *pStr '9' )
-*pStr += 39;
-nHex = 4;
-}
-return rStrm pStr;
-}
-
-SvStream Writer::OutLong( SvStream rStrm, long nVal )
-{
-// Pointer an das Bufferende setzen
-sal_Char* pStr = aNToABuf + (NTOABUFLEN-1);
-
-int bNeg = nVal 0;
-if( bNeg )
-nVal = -nVal;
-
-do {
-*(--pStr) = (sal_Char)(nVal % 10 ) + 48;
-nVal /= 10;
-} while( nVal );
-
-// Ist Zahl negativ, dann noch -
-if( bNeg )
-*(--pStr) = '-';
-
-return rStrm pStr;
-}
-
-SvStream Writer::OutULong( SvStream rStrm, ULONG nVal )
-{
-// Pointer an das Bufferende setzen
-sal_Char* pStr = aNToABuf + (NTOABUFLEN-1);
-
-do {
-*(--pStr) = (sal_Char)(nVal % 10 ) + 48;
-nVal /= 10;
-} while ( nVal );
-return rStrm pStr;
-}
-
/*N*/ ULONG Writer::Write( SwPaM rPaM, SvStream rStrm )
/*N*/ {
/*N*/ pStrm = rStrm;
@@ -263,61 +190,6 @@ SvStream Writer::OutULong( SvStream rStrm, ULONG nVal )
/*N*/ return nRet;
/*N*/ }
-/*N*/ void Writer::PutNumFmtFontsInAttrPool()
-/*N*/ {
-/*N*/ if( !pImpl )
-/*?*/ pImpl = new Writer_Impl;
-/*N*/
-/*N*/ // dann gibt es noch in den NumRules ein paar Fonts
-/*N*/ // Diese in den Pool putten. Haben sie danach einen RefCount 1
-/*N*/ // kann es wieder entfernt werden - ist schon im Pool
-/*N*/ SfxItemPool rPool = pDoc-GetAttrPool();
-/*N*/ const SwNumRuleTbl rListTbl = pDoc-GetNumRuleTbl();
-/*N*/ const SwNumRule* pRule;
-/*N*/ const SwNumFmt* pFmt;
-/*N*/ const Font *pFont, *pDefFont = SwNumRule::GetDefBulletFont();
-/*N*/ BOOL bCheck = FALSE;
-/*N*/
-/*N*/ for( USHORT nGet = rListTbl.Count(); nGet; )
-/*N*/ if( pDoc-IsUsed( *(pRule = rListTbl[ --nGet ] )))
-/*?*/ for( BYTE nLvl = 0; nLvl MAXLEVEL; ++nLvl )
-/*?*/ if( SVX_NUM_CHAR_SPECIAL == (pFmt =
[Libreoffice-commits] .: dbaccess/source
dbaccess/source/ui/querydesign/QueryDesignView.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 80c235510aeb19d4df6a07be7499e70122313bbf
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Thu Mar 15 11:22:32 2012 +0100
fdo#46843 look for order by clause as fifth child of select_statement
Since commit 33b9b857ea6cb5a6f731de68f58e532242c43d30 (dba34c: #i20306#
support for window function and limit fetch first, ... added), order by is the
fifth child. It was the fourth one before.
diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
index 397cedb..267c7a9 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
@@ -2319,9 +2319,9 @@ namespace
const ::connectivity::OSQLParseNode* pParseRoot )
{
SqlParseError eErrorCode = eOk;
-if (!pParseRoot-getChild(3)-getChild(4)-isLeaf())
+if (!pParseRoot-getChild(3)-getChild(5)-isLeaf())
{
-::connectivity::OSQLParseNode* pNode =
pParseRoot-getChild(3)-getChild(4)-getChild(2);
+::connectivity::OSQLParseNode* pNode =
pParseRoot-getChild(3)-getChild(5)-getChild(2);
::connectivity::OSQLParseNode* pParamRef = NULL;
OQueryController rController =
static_castOQueryController(_pView-getController());
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: dbaccess/source
dbaccess/source/ui/querydesign/QueryDesignView.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 08ba87c55858335094c24ca4e610a13da10c
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Thu Mar 15 18:54:17 2012 +0100
fixup: use introduced preprocessor constant instead of hardcoded constant
diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
index 267c7a9..12b5b29 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
@@ -2319,9 +2319,9 @@ namespace
const ::connectivity::OSQLParseNode* pParseRoot )
{
SqlParseError eErrorCode = eOk;
-if (!pParseRoot-getChild(3)-getChild(5)-isLeaf())
+if (!pParseRoot-getChild(3)-getChild(ORDER_BY_CHILD_POS)-isLeaf())
{
-::connectivity::OSQLParseNode* pNode =
pParseRoot-getChild(3)-getChild(5)-getChild(2);
+::connectivity::OSQLParseNode* pNode =
pParseRoot-getChild(3)-getChild(ORDER_BY_CHILD_POS)-getChild(2);
::connectivity::OSQLParseNode* pParamRef = NULL;
OQueryController rController =
static_castOQueryController(_pView-getController());
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 6 commits - sc/inc sc/source
sc/inc/dpcache.hxx |9
sc/inc/dpitemdata.hxx |2
sc/source/core/data/dpcache.cxx| 401 +
sc/source/core/data/dpdimsave.cxx | 12 -
sc/source/core/data/dpitemdata.cxx | 11 +
5 files changed, 254 insertions(+), 181 deletions(-)
New commits:
commit 20d55ad66f0f94c9f6a583b5406a39717c1c6d46
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu Mar 15 15:39:51 2012 -0400
Consolidated file-local functions.
diff --git a/sc/source/core/data/dpcache.cxx b/sc/source/core/data/dpcache.cxx
index 140885e..08b0d25 100644
--- a/sc/source/core/data/dpcache.cxx
+++ b/sc/source/core/data/dpcache.cxx
@@ -62,89 +62,6 @@ using ::com::sun::star::uno::Reference;
using ::com::sun::star::uno::UNO_QUERY;
using ::com::sun::star::uno::UNO_QUERY_THROW;
-namespace {
-
-void getItemValue(
-ScDPItemData rData, const Referencesdbc::XRow xRow, sal_Int32 nType,
-long nCol, const Date rNullDate, short rNumType)
-{
-rNumType = NUMBERFORMAT_NUMBER;
-try
-{
-double fValue = 0.0;
-switch (nType)
-{
-case sdbc::DataType::BIT:
-case sdbc::DataType::BOOLEAN:
-{
-rNumType = NUMBERFORMAT_LOGICAL;
-fValue = xRow-getBoolean(nCol) ? 1 : 0;
-rData.SetValue(fValue);
-break;
-}
-case sdbc::DataType::TINYINT:
-case sdbc::DataType::SMALLINT:
-case sdbc::DataType::INTEGER:
-case sdbc::DataType::BIGINT:
-case sdbc::DataType::FLOAT:
-case sdbc::DataType::REAL:
-case sdbc::DataType::DOUBLE:
-case sdbc::DataType::NUMERIC:
-case sdbc::DataType::DECIMAL:
-{
-//! do the conversion here?
-fValue = xRow-getDouble(nCol);
-rData.SetValue(fValue);
-break;
-}
-case sdbc::DataType::DATE:
-{
-rNumType = NUMBERFORMAT_DATE;
-
-util::Date aDate = xRow-getDate(nCol);
-fValue = Date(aDate.Day, aDate.Month, aDate.Year) - rNullDate;
-rData.SetValue(fValue);
-break;
-}
-case sdbc::DataType::TIME:
-{
-rNumType = NUMBERFORMAT_TIME;
-
-util::Time aTime = xRow-getTime(nCol);
-fValue = ( aTime.Hours * 3600 + aTime.Minutes * 60 +
- aTime.Seconds + aTime.HundredthSeconds / 100.0 ) /
D_TIMEFACTOR;
-rData.SetValue(fValue);
-break;
-}
-case sdbc::DataType::TIMESTAMP:
-{
-rNumType = NUMBERFORMAT_DATETIME;
-
-util::DateTime aStamp = xRow-getTimestamp(nCol);
-fValue = ( Date( aStamp.Day, aStamp.Month, aStamp.Year ) -
rNullDate ) +
- ( aStamp.Hours * 3600 + aStamp.Minutes * 60 +
- aStamp.Seconds + aStamp.HundredthSeconds / 100.0 )
/ D_TIMEFACTOR;
-rData.SetValue(fValue);
-break;
-}
-case sdbc::DataType::CHAR:
-case sdbc::DataType::VARCHAR:
-case sdbc::DataType::LONGVARCHAR:
-case sdbc::DataType::SQLNULL:
-case sdbc::DataType::BINARY:
-case sdbc::DataType::VARBINARY:
-case sdbc::DataType::LONGVARBINARY:
-default:
-rData.SetString(xRow-getString(nCol));
-}
-}
-catch (uno::Exception)
-{
-}
-}
-
-}
-
ScDPCache::GroupItems::GroupItems() {}
ScDPCache::GroupItems::GroupItems(const ScDPNumGroupInfo rInfo) :
@@ -282,6 +199,85 @@ void initFromCell(ScDocument* pDoc, SCCOL nCol, SCROW
nRow, SCTAB nTab, ScDPItem
}
}
+void getItemValue(
+ScDPItemData rData, const Referencesdbc::XRow xRow, sal_Int32 nType,
+long nCol, const Date rNullDate, short rNumType)
+{
+rNumType = NUMBERFORMAT_NUMBER;
+try
+{
+double fValue = 0.0;
+switch (nType)
+{
+case sdbc::DataType::BIT:
+case sdbc::DataType::BOOLEAN:
+{
+rNumType = NUMBERFORMAT_LOGICAL;
+fValue = xRow-getBoolean(nCol) ? 1 : 0;
+rData.SetValue(fValue);
+break;
+}
+case sdbc::DataType::TINYINT:
+case sdbc::DataType::SMALLINT:
+case sdbc::DataType::INTEGER:
+case sdbc::DataType::BIGINT:
+case sdbc::DataType::FLOAT:
+case sdbc::DataType::REAL:
+case sdbc::DataType::DOUBLE:
+case sdbc::DataType::NUMERIC:
+case sdbc::DataType::DECIMAL:
+{
+//! do the conversion here?
+fValue = xRow-getDouble(nCol);
+rData.SetValue(fValue);
+
[Libreoffice-commits] .: oox/source
oox/source/ole/vbamodule.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 1bd695d3ddcbce48899a70130b5e948c48541d17
Author: Noel Power noel.po...@novell.com
Date: Thu Mar 15 19:50:11 2012 +
fix mishandling of 'End Sub' is there is a trailing comment fod#46889
diff --git a/oox/source/ole/vbamodule.cxx b/oox/source/ole/vbamodule.cxx
index 9f0e5ff..d5c1db3 100644
--- a/oox/source/ole/vbamodule.cxx
+++ b/oox/source/ole/vbamodule.cxx
@@ -313,7 +313,7 @@ OUString VbaModule::readSourceCode( StorageBase rVbaStrg,
const Reference XNam
procInfo.nPos = aSourceCode.getLength();
}
}
-else if ( mbExecutable aCodeLine.trim().equalsAsciiL(
RTL_CONSTASCII_STRINGPARAM(End Sub)) )
+else if ( mbExecutable aCodeLine.trim().matchAsciiL(
RTL_CONSTASCII_STRINGPARAM(End Sub)) )
{
// un-matched End Sub
if ( !procInfo.bInProcedure )
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/ui/app/inputhdl.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e3b1592165d0513e90e28dfee92bc9db032fa221 Author: Noel Power noel.po...@novell.com Date: Thu Mar 15 20:10:12 2012 + fix to update inputbar when setting a range for a formula fdo#46809 diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx index 29a40c5..7232ad3 100644 --- a/sc/source/ui/app/inputhdl.cxx +++ b/sc/source/ui/app/inputhdl.cxx @@ -1811,7 +1811,7 @@ void ScInputHandler::UpdateActiveView() else pTableView = NULL; -if (pInputWin pInputWin-IsInputActive()) +if (pInputWin eMode == SC_INPUT_TOP ) pTopView = pInputWin-GetEditView(); else pTopView = NULL; ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - sc/source
sc/source/core/data/cell.cxx |6 +++---
sc/source/ui/inc/namepast.hxx |1 +
sc/source/ui/namedlg/namepast.cxx |5 ++---
3 files changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 2118ec3630fe12ff2a663c94421780870f264e83
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Thu Mar 15 22:22:10 2012 +0100
update the relatice refs after the absolute refs, fdo#47285
The algoithm for updating absolute refs needs to calculate the old
position based on the information before any updates to the RefData
diff --git a/sc/source/core/data/cell.cxx b/sc/source/core/data/cell.cxx
index 6d5baaf..f191c5d 100644
--- a/sc/source/core/data/cell.cxx
+++ b/sc/source/core/data/cell.cxx
@@ -788,9 +788,6 @@ ScFormulaCell::ScFormulaCell( const ScFormulaCell rCell,
ScDocument rDoc, cons
{
pCode = rCell.pCode-Clone();
-if ( nCloneFlags SC_CLONECELL_ADJUST3DREL )
-pCode-ReadjustRelative3DReferences( rCell.aPos, aPos );
-
// evtl. Fehler zuruecksetzen und neu kompilieren
// nicht im Clipboard - da muss das Fehlerflag erhalten bleiben
// Spezialfall Laenge=0: als Fehlerzelle erzeugt, dann auch Fehler
behalten
@@ -827,6 +824,9 @@ ScFormulaCell::ScFormulaCell( const ScFormulaCell rCell,
ScDocument rDoc, cons
pCode-AdjustAbsoluteRefs( rCell.pDocument, rCell.aPos, aPos );
}
+if ( nCloneFlags SC_CLONECELL_ADJUST3DREL )
+pCode-ReadjustRelative3DReferences( rCell.aPos, aPos );
+
if( !bCompile )
{ // Name references with references and ColRowNames
pCode-Reset();
commit bd43abc94d30332d06fad7964bd01dc5f70c22e7
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Thu Mar 15 15:57:54 2012 +0100
ScNameMgrTable takes a reference, fdo#47307
diff --git a/sc/source/ui/inc/namepast.hxx b/sc/source/ui/inc/namepast.hxx
index b2abb45..77e3712 100644
--- a/sc/source/ui/inc/namepast.hxx
+++ b/sc/source/ui/inc/namepast.hxx
@@ -57,6 +57,7 @@ private:
ScRangeManagerTable* mpTable;
std::vectorrtl::OUString maSelectedNames;
+boost::ptr_maprtl::OUString, ScRangeName maRangeMap;
public:
ScNamePasteDlg( Window * pParent, ScDocShell* pShell, bool bInsList=true );
diff --git a/sc/source/ui/namedlg/namepast.cxx
b/sc/source/ui/namedlg/namepast.cxx
index 68a406f..8b4f78b 100644
--- a/sc/source/ui/namedlg/namepast.cxx
+++ b/sc/source/ui/namedlg/namepast.cxx
@@ -54,18 +54,17 @@ ScNamePasteDlg::ScNamePasteDlg( Window * pParent,
ScDocShell* pShell, bool )
{
ScDocument* pDoc = pShell-GetDocument();
std::maprtl::OUString, ScRangeName* aCopyMap;
-boost::ptr_maprtl::OUString, ScRangeName aRangeMap;
pDoc-GetRangeNameMap(aCopyMap);
std::maprtl::OUString, ScRangeName*::iterator itr = aCopyMap.begin(),
itrEnd = aCopyMap.end();
for (; itr != itrEnd; ++itr)
{
rtl::OUString aTemp(itr-first);
-aRangeMap.insert(aTemp, new ScRangeName(*itr-second));
+maRangeMap.insert(aTemp, new ScRangeName(*itr-second));
}
ScViewData* pViewData = pShell-GetViewData();
ScAddress aPos(pViewData-GetCurX(), pViewData-GetCurY(),
pViewData-GetTabNo());
-mpTable = new ScRangeManagerTable(maCtrl, aRangeMap, aPos);
+mpTable = new ScRangeManagerTable(maCtrl, maRangeMap, aPos);
maBtnPaste.SetClickHdl( LINK( this, ScNamePasteDlg, ButtonHdl) );
maBtnPasteAll.SetClickHdl( LINK( this, ScNamePasteDlg, ButtonHdl));
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/ui/view/prevwsh.cxx |7 ++- sc/source/ui/view/printfun.cxx |7 ++- sc/source/ui/view/tabvwsh4.cxx |8 +++- 3 files changed, 19 insertions(+), 3 deletions(-) New commits: commit 010560f553ee361ccda4bd14f1ee6b3f18250847 Author: Szabolcs Dezsi dezsisz...@hotmail.com Date: Thu Mar 15 15:23:17 2012 +0100 i#84393 Fix title field in header, footer According to help Title should be the Title property of the document, not the file name without extension. If that property is missing, we fall back to file name without extension. diff --git a/sc/source/ui/view/prevwsh.cxx b/sc/source/ui/view/prevwsh.cxx index ccb10ee..85dd306 100644 --- a/sc/source/ui/view/prevwsh.cxx +++ b/sc/source/ui/view/prevwsh.cxx @@ -77,6 +77,7 @@ #include basegfx/tools/zoomtools.hxx #include svx/zoom_def.hxx +#include com/sun/star/document/XDocumentProperties.hpp #include sc.hrc #include scabstdlg.hxx @@ -844,7 +845,11 @@ void ScPreviewShell::FillFieldData( ScHeaderFieldData rData ) pDoc-GetName(nTab, aTmp); rData.aTabName = aTmp; -rData.aTitle= pDocShell-GetTitle(); +if( pDocShell-getDocProperties()-getTitle().getLength() != 0 ) +rData.aTitle = pDocShell-getDocProperties()-getTitle(); +else +rData.aTitle = pDocShell-GetTitle(); + const INetURLObject rURLObj = pDocShell-GetMedium()-GetURLObject(); rData.aLongDocName = rURLObj.GetMainURL( INetURLObject::DECODE_UNAMBIGUOUS ); if ( rData.aLongDocName.Len() ) diff --git a/sc/source/ui/view/printfun.cxx b/sc/source/ui/view/printfun.cxx index 01f1b5b..9d82ba5 100644 --- a/sc/source/ui/view/printfun.cxx +++ b/sc/source/ui/view/printfun.cxx @@ -83,6 +83,7 @@ #include vcl/lineinfo.hxx #include boost/scoped_ptr.hpp +#include com/sun/star/document/XDocumentProperties.hpp #define ZOOM_MIN10 @@ -1037,7 +1038,11 @@ void ScPrintFunc::InitParam( const ScPrintOptions* pOptions ) SetDateTime( Date( Date::SYSTEM ), Time( Time::SYSTEM ) ); -aFieldData.aTitle = pDocShell-GetTitle(); +if( pDocShell-getDocProperties()-getTitle().getLength() != 0 ) +aFieldData.aTitle = pDocShell-getDocProperties()-getTitle(); +else +aFieldData.aTitle = pDocShell-GetTitle(); + const INetURLObject rURLObj = pDocShell-GetMedium()-GetURLObject(); aFieldData.aLongDocName = rURLObj.GetMainURL( INetURLObject::DECODE_UNAMBIGUOUS ); if ( aFieldData.aLongDocName.Len() ) diff --git a/sc/source/ui/view/tabvwsh4.cxx b/sc/source/ui/view/tabvwsh4.cxx index cf93d15..35c2c54 100644 --- a/sc/source/ui/view/tabvwsh4.cxx +++ b/sc/source/ui/view/tabvwsh4.cxx @@ -97,6 +97,8 @@ #include markdata.hxx #include preview.hxx +#include com/sun/star/document/XDocumentProperties.hpp + void ActivateOlk( ScViewData* pViewData ); void DeActivateOlk( ScViewData* pViewData ); @@ -1824,7 +1826,11 @@ void ScTabViewShell::FillFieldData( ScHeaderFieldData rData ) pDoc-GetName(nTab, aTmp); rData.aTabName = aTmp; -rData.aTitle= pDocShell-GetTitle(); +if( pDocShell-getDocProperties()-getTitle().getLength() != 0 ) +rData.aTitle = pDocShell-getDocProperties()-getTitle(); +else +rData.aTitle = pDocShell-GetTitle(); + const INetURLObject rURLObj = pDocShell-GetMedium()-GetURLObject(); rData.aLongDocName = rURLObj.GetMainURL( INetURLObject::DECODE_UNAMBIGUOUS ); if ( rData.aLongDocName.Len() ) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: desktop/Executable_sbase.mk desktop/Executable_scalc.mk desktop/Executable_sdraw.mk desktop/Executable_simpress.mk desktop/Executable_smath.mk desktop/Executable_sweb.mk deskt
desktop/Executable_sbase.mk|7 +-- desktop/Executable_scalc.mk|7 +-- desktop/Executable_sdraw.mk|7 +-- desktop/Executable_simpress.mk |7 +-- desktop/Executable_smath.mk|7 +-- desktop/Executable_sweb.mk |7 +-- desktop/Executable_swriter.mk |7 +-- 7 files changed, 35 insertions(+), 14 deletions(-) New commits: commit 45504f9ba8de2a4372193910b2cb9405f1ea896a Author: Matúš Kukan matus.ku...@gmail.com Date: Fri Mar 16 01:16:34 2012 +0100 fix windows build No idea if this is proper fix or it needs to be done otherwise. diff --git a/desktop/Executable_sbase.mk b/desktop/Executable_sbase.mk index f3caf5b..098f8c2 100644 --- a/desktop/Executable_sbase.mk +++ b/desktop/Executable_sbase.mk @@ -37,10 +37,13 @@ $(eval $(call gb_Executable_add_linked_libs,sbase,\ $(gb_STDLIBS) \ )) -$(eval $(call gb_Executable_add_linked_static_libs,sbase,\ -winlauncher \ +$(eval $(call gb_Executable_add_libs,sbase,\ +$(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) \ )) +$(call gb_Executable_get_target,sbase) : \ +$(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) + $(eval $(call gb_Executable_add_noexception_objects,sbase,\ desktop/win32/source/applauncher/sbase \ )) diff --git a/desktop/Executable_scalc.mk b/desktop/Executable_scalc.mk index 3c9990b..290e880 100644 --- a/desktop/Executable_scalc.mk +++ b/desktop/Executable_scalc.mk @@ -37,10 +37,13 @@ $(eval $(call gb_Executable_add_linked_libs,scalc,\ $(gb_STDLIBS) \ )) -$(eval $(call gb_Executable_add_linked_static_libs,scalc,\ -winlauncher \ +$(eval $(call gb_Executable_add_libs,scalc,\ +$(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) \ )) +$(call gb_Executable_get_target,scalc) : \ +$(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) + $(eval $(call gb_Executable_add_noexception_objects,scalc,\ desktop/win32/source/applauncher/scalc \ )) diff --git a/desktop/Executable_sdraw.mk b/desktop/Executable_sdraw.mk index dcea97d..2e57495 100644 --- a/desktop/Executable_sdraw.mk +++ b/desktop/Executable_sdraw.mk @@ -37,10 +37,13 @@ $(eval $(call gb_Executable_add_linked_libs,sdraw,\ $(gb_STDLIBS) \ )) -$(eval $(call gb_Executable_add_linked_static_libs,sdraw,\ -winlauncher \ +$(eval $(call gb_Executable_add_libs,sdraw,\ +$(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) \ )) +$(call gb_Executable_get_target,sdraw) : \ +$(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) + $(eval $(call gb_Executable_add_noexception_objects,sdraw,\ desktop/win32/source/applauncher/sdraw \ )) diff --git a/desktop/Executable_simpress.mk b/desktop/Executable_simpress.mk index ab0cbc0..926ad57 100644 --- a/desktop/Executable_simpress.mk +++ b/desktop/Executable_simpress.mk @@ -37,10 +37,13 @@ $(eval $(call gb_Executable_add_linked_libs,simpress,\ $(gb_STDLIBS) \ )) -$(eval $(call gb_Executable_add_linked_static_libs,simpress,\ -winlauncher \ +$(eval $(call gb_Executable_add_libs,simpress,\ +$(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) \ )) +$(call gb_Executable_get_target,simpress) : \ +$(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) + $(eval $(call gb_Executable_add_noexception_objects,simpress,\ desktop/win32/source/applauncher/simpress \ )) diff --git a/desktop/Executable_smath.mk b/desktop/Executable_smath.mk index fe1607b..ed1b460 100644 --- a/desktop/Executable_smath.mk +++ b/desktop/Executable_smath.mk @@ -37,10 +37,13 @@ $(eval $(call gb_Executable_add_linked_libs,smath,\ $(gb_STDLIBS) \ )) -$(eval $(call gb_Executable_add_linked_static_libs,smath,\ -winlauncher \ +$(eval $(call gb_Executable_add_libs,smath,\ +$(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) \ )) +$(call gb_Executable_get_target,smath) : \ +$(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) + $(eval $(call gb_Executable_add_noexception_objects,smath,\ desktop/win32/source/applauncher/smath \ )) diff --git a/desktop/Executable_sweb.mk b/desktop/Executable_sweb.mk index a8810b1..858bc7a 100644 --- a/desktop/Executable_sweb.mk +++ b/desktop/Executable_sweb.mk @@ -37,10 +37,13 @@ $(eval $(call gb_Executable_add_linked_libs,sweb,\ $(gb_STDLIBS) \ )) -$(eval $(call gb_Executable_add_linked_static_libs,sweb,\ -winlauncher \ +$(eval $(call gb_Executable_add_libs,sweb,\ +$(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) \ )) +$(call gb_Executable_get_target,sweb) : \ +$(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) + $(eval $(call gb_Executable_add_noexception_objects,sweb,\ desktop/win32/source/applauncher/sweb \ )) diff --git a/desktop/Executable_swriter.mk
[Libreoffice-commits] .: nss/makefile.mk nss/nss-string-concat.patch
nss/makefile.mk |2 +-
nss/nss-string-concat.patch | 11 +++
2 files changed, 12 insertions(+), 1 deletion(-)
New commits:
commit dbf3b4ab772a398ba397ea763deb6003adaf0586
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Fri Mar 16 02:00:23 2012 +0100
foobar - foo bar
diff --git a/nss/makefile.mk b/nss/makefile.mk
index c75684a..4323887 100644
--- a/nss/makefile.mk
+++ b/nss/makefile.mk
@@ -48,7 +48,7 @@ VER_PATCH=8
TARFILE_NAME=nss-$(VER_MAJOR).$(VER_MINOR).$(VER_PATCH)-with-nspr-4.8.6
TARFILE_MD5=71474203939fafbe271e1263e61d083e
TARFILE_ROOTDIR=nss-$(VER_MAJOR).$(VER_MINOR).$(VER_PATCH)
-PATCH_FILES=nss.patch nss.aix.patch nss-config.patch nss-linux3.patch
nss-clang_os_Linux_x86_s_comments.patch
+PATCH_FILES=nss.patch nss.aix.patch nss-config.patch nss-linux3.patch
nss-clang_os_Linux_x86_s_comments.patch nss-string-concat.patch
.IF $(OS)==MACOSX
PATCH_FILES+=nss_macosx.patch
diff --git a/nss/nss-string-concat.patch b/nss/nss-string-concat.patch
new file mode 100644
index 000..68f9c4b
--- /dev/null
+++ b/nss/nss-string-concat.patch
@@ -0,0 +1,11 @@
+--- misc/build/nss-3.12.8/mozilla/security/nss/lib/softoken/secmodt.h.sav
2008-12-17 22:39:05.0 +0100
misc/build/nss-3.12.8/mozilla/security/nss/lib/softoken/secmodt.h
2012-03-16 01:56:47.881621915 +0100
+@@ -338,7 +338,7 @@ typedef PRUint32 PK11AttrFlags;
+ #define SECMOD_SLOT_FLAGS
slotFlags=[RSA,DSA,DH,RC2,RC4,DES,RANDOM,SHA1,MD5,MD2,SSL,TLS,AES,Camellia,SEED,SHA256,SHA512]
+
+ #define SECMOD_MAKE_NSS_FLAGS(fips,slot) \
+-Flags=internal,criticalfips slotparams=(#slot={SECMOD_SLOT_FLAGS})
++Flags=internal,critical fips slotparams=( #slot ={ SECMOD_SLOT_FLAGS
})
+
+ #define SECMOD_INT_NAME NSS Internal PKCS #11 Module
+ #define SECMOD_INT_FLAGS SECMOD_MAKE_NSS_FLAGS(,1)
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - sc/inc sc/source
sc/inc/dpcache.hxx | 16
sc/source/core/data/dpcache.cxx | 31 ++-
2 files changed, 6 insertions(+), 41 deletions(-)
New commits:
commit 0c1a63b1fbbd9540a724f6918675a5559b19c156
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu Mar 15 20:30:52 2012 -0400
No need to trim capacity any more; it's allocated to the exact size.
diff --git a/sc/source/core/data/dpcache.cxx b/sc/source/core/data/dpcache.cxx
index 4c93501..928e511 100644
--- a/sc/source/core/data/dpcache.cxx
+++ b/sc/source/core/data/dpcache.cxx
@@ -756,12 +756,6 @@ public:
void ScDPCache::PostInit()
{
maEmptyRows.build_tree();
-FieldsType::iterator it = maFields.begin(), itEnd = maFields.end();
-for (; it != itEnd; ++it)
-{
-// Trim excess capacity.
-ItemsType(it-maItems).swap(it-maItems);
-}
}
void ScDPCache::Clear()
commit 9e19cf80c080929c914dc0bfa069f22c8526c3b0
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu Mar 15 20:23:10 2012 -0400
We don't need these extra order index array; items are already sorted.
This shaves off extra 5MB of memory with my test document.
diff --git a/sc/inc/dpcache.hxx b/sc/inc/dpcache.hxx
index 6566979..1e26688 100644
--- a/sc/inc/dpcache.hxx
+++ b/sc/inc/dpcache.hxx
@@ -80,7 +80,10 @@ public:
*/
boost::scoped_ptrGroupItems mpGroup;
-ItemsType maItems; /// Unique values in the field.
+/**
+ * Unique values in the field, stored in ascending order.
+ */
+ItemsType maItems;
/**
* Original source data represented as indices to the unique value
@@ -89,17 +92,6 @@ public:
*/
IndexArrayType maData;
-/**
- * Ascending order of field items.
- */
-IndexArrayType maGlobalOrder;
-
-/**
- * Ranks of each unique data represented by their index. It's a
- * reverse mapping of item index to global order index.
- */
-mutable IndexArrayType maIndexOrder;
-
sal_uLong mnNumFormat;
Field();
diff --git a/sc/source/core/data/dpcache.cxx b/sc/source/core/data/dpcache.cxx
index 08b0d25..4c93501 100644
--- a/sc/source/core/data/dpcache.cxx
+++ b/sc/source/core/data/dpcache.cxx
@@ -376,12 +376,6 @@ void processBuckets(std::vectorBucket aBuckets,
ScDPCache::Field rField)
size_t nLen = distance(itBeg, itUniqueEnd);
rField.maItems.reserve(nLen);
std::for_each(itBeg, itUniqueEnd, PushBackValue(rField.maItems));
-
-// The items are actually already sorted. So, just insert a sequence
-// of integers from 0 and up.
-rField.maGlobalOrder.reserve(nLen);
-for (size_t i = 0; i nLen; ++i)
-rField.maGlobalOrder.push_back(i);
}
}
@@ -1120,24 +1114,9 @@ void ScDPCache::ClearGroupFields()
std::for_each(maFields.begin(), maFields.end(), ClearGroupItems());
}
-SCROW ScDPCache::GetOrder(long nDim, SCROW nIndex) const
+SCROW ScDPCache::GetOrder(long /*nDim*/, SCROW nIndex) const
{
-OSL_ENSURE( nDim =0 nDim mnColumnCount,
ScDPTableDataCache::GetOrder : out of bound );
-
-const Field rField = maFields[nDim];
-if (rField.maIndexOrder.size() != rField.maGlobalOrder.size())
-{ //not inited
-SCROW nRow = 0;
-rField.maIndexOrder.resize(rField.maGlobalOrder.size(), 0);
-for (size_t i = 0, n = rField.maGlobalOrder.size(); i n; ++i)
-{
-nRow = rField.maGlobalOrder[i];
-rField.maIndexOrder[nRow] = i;
-}
-}
-
-OSL_ENSURE(nIndex = 0 sal::static_int_castsal_uInt32(nIndex)
rField.maIndexOrder.size() , ScDPTableDataCache::GetOrder);
-return rField.maIndexOrder[nIndex];
+return nIndex;
}
ScDocument* ScDPCache::GetDoc() const
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: filter/source
filter/source/graphicfilter/icgm/bitmap.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 3297ce2aa13efc6029983b716cec20ed7befda56
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Fri Mar 16 03:24:22 2012 +0100
0x8001 can't fit into (signed) long
As far as I can say, this value and all those negative values
are actually not valid in CGM anyway, but since I do not know
the code, I'm leaving them in, they shouldn't break anything.
diff --git a/filter/source/graphicfilter/icgm/bitmap.cxx
b/filter/source/graphicfilter/icgm/bitmap.cxx
index d614443..bc84135 100644
--- a/filter/source/graphicfilter/icgm/bitmap.cxx
+++ b/filter/source/graphicfilter/icgm/bitmap.cxx
@@ -256,7 +256,7 @@ sal_Bool CGMBitmap::ImplGetDimensions( CGMBitmapDescriptor
rDesc )
rDesc.mnScanSize = 0;
switch( rDesc.mnLocalColorPrecision )
{
-case 0x8001 : // monochrome ( bit =
0-backgroundcolor )
+case long(0x8001) : // monochrome ( bit =
0-backgroundcolor )
case 0 :// bit =
1-fillcolor
rDesc.mnDstBitsPerPixel = 1;
break;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: -Wno-non-virtual-dtor
On 03/13/2012 02:24 PM, Stephan Bergmann wrote: [1] There might be a way around that after all, adding a non-virtual, protected destructor to the C++ classes representing UNO interfaces. Will look into that. [2] http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7302 -Wnon-virtual-dtor should't complain of protected dtor apparently solves the problem for cppuhelper/propertysetmixin.hxx that originally caused problems. Seems to be available at least in the Fedora-16 GCC 4.6.2. (And -Wall appears to no longer automatically enable -Wnon-virtual-dtor.) Maybe all this allows us to re-enable -Wnon-virtual-dtor after all; will look into that. FTR, done this now as http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e67c03dc0225fc66343546b14e902b9d238b1a3 Enable -Wnon-virtual-dtor for GCC 4.6 and http://cgit.freedesktop.org/libreoffice/binfilter/commit/?id=c599fdba10c210ecf3f94119cb1138f3846320df Adapted to -Wnon-virtual-dtor enabled for GCC 4.6. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: build breakage on latest master on Windows
On 03/14/2012 03:16 PM, Noel Grandin wrote: Compiling using Visual Studio 2008. I'm seeing this error - any ideas? /cygdrive/c/LibreOffice/libo/canvas/Library_gdipluscanvas.mk:77: *** fdo#47246: canvas/source/directx/dx_bitmap is linked in by Library/idirectx9canvas.lib Library/igdipluscanvas.lib. Stop. dmake: Error code 2, while making 'all' Look up https://bugs.freedesktop.org/show_bug.cgi?id=47246 EasyHack: Remove the duplicate linked objects in gbuild that is referenced in the error message. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: build breakage on latest master on Windows
h, clever. Thanks. On 2012-03-15 09:20, Stephan Bergmann wrote: On 03/14/2012 03:16 PM, Noel Grandin wrote: Compiling using Visual Studio 2008. I'm seeing this error - any ideas? /cygdrive/c/LibreOffice/libo/canvas/Library_gdipluscanvas.mk:77: *** fdo#47246: canvas/source/directx/dx_bitmap is linked in by Library/idirectx9canvas.lib Library/igdipluscanvas.lib. Stop. dmake: Error code 2, while making 'all' Look up https://bugs.freedesktop.org/show_bug.cgi?id=47246 EasyHack: Remove the duplicate linked objects in gbuild that is referenced in the error message. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] fdo#42961 Don't let env vars interfere with internal bootstrap vars
Please consider the below fix for
https://bugs.freedesktop.org/show_bug.cgi?id=42961 Setting $DATA
causes LibreOffice to crash for inclusion in libreoffice-3-5. Not sure
it is worth it including it in libreoffice-3-4 (the bug should be in at
least since OOo 3.3).
Stephan
On 03/15/2012 09:48 AM, Stephan Bergmann wrote:
commit 84ecea9655267afc266b79059baa4512a285b1f2
Author: Stephan Bergmannsberg...@redhat.com
Date: Thu Mar 15 09:34:56 2012 +0100
fdo#42961 Don't let env vars interfere with internal bootstrap vars
diff --git a/configmgr/source/components.cxx b/configmgr/source/components.cxx
index 0e1c7e4..6f18508 100644
--- a/configmgr/source/components.cxx
+++ b/configmgr/source/components.cxx
@@ -53,6 +53,7 @@
#include rtl/oustringostreaminserter.hxx
#include rtl/ref.hxx
#include rtl/string.h
+#include rtl/ustrbuf.hxx
#include rtl/ustring.h
#include rtl/ustring.hxx
#include rtl/instance.hxx
@@ -827,17 +828,38 @@ void Components::parseXcsXcuLayer(int layer, rtl::OUString
const url) {
void Components::parseXcsXcuIniLayer(
int layer, rtl::OUString const url, bool recordAdditions)
{
-//TODO: rtl::Bootstrap::getFrom first trie[s] to retrieve the value via
the
-// global function
+// Check if ini file exists (otherwise .override would still read global
+// SCHEMA/DATA variables, which could interfere with unrelated environment
+// variables):
rtl::Bootstrap ini(url);
-rtl::OUString urls;
-if (ini.getFrom(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(SCHEMA)),
urls))
+if (ini.getHandle() != 0)
{
-parseFileList(layer,parseXcsFile, urls, ini, false);
-}
-if (ini.getFrom(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(DATA)), urls))
-{
-parseFileList(layer + 1,parseXcuFile, urls, ini, recordAdditions);
+rtl::OUStringBuffer prefix(${.override:);
+for (sal_Int32 i = 0; i != url.getLength(); ++i) {
+sal_Unicode c = url[i];
+switch (c) {
+case '$':
+case ':':
+case '\\':
+prefix.append('\\');
+// fall through
+default:
+prefix.append(c);
+}
+}
+prefix.append(':');
+rtl::OUString urls(prefix.toString() + rtl::OUString(SCHEMA}));
+rtl::Bootstrap::expandMacros(urls);
+if (!urls.isEmpty())
+{
+parseFileList(layer,parseXcsFile, urls, ini, false);
+}
+urls = prefix.makeStringAndClear() + rtl::OUString(DATA});
+rtl::Bootstrap::expandMacros(urls);
+if (!urls.isEmpty())
+{
+parseFileList(layer + 1,parseXcuFile, urls, ini, recordAdditions);
+}
}
}
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] [ANN] LibreOffice 3.4.6 RC2 test builds available
Bjoern Michaelsen píše v St 14. 03. 2012 v 18:38 +0100: While being open to further concrete proposals for improvement, I dont think there is a fundamental flaw with the release concept itself. The quality of 3.5.0 and and 3.5.1 show that the number of regressions in 3.4 were a one-time outlier. We have to make sure it does not happen again, but I see no general flaw with our release model. We need to be sure to detect and pinpoint regressions earlier and more precise than in 3.4 -- and we have that with unittests, subsequenttests, onegit and bibisect -- all means that we were still missing in the 3.4 series. Those were the parts that needed changing and they are changed already. It doesnt end there though: With gerrit and the currently ongoing efforts in QA in addition to the tools named above, we are getting even better early warning and enable ourselves to quickly and confidently fix regressions. I agreed with everything that was said by Bjoern. I just want to add that we need to be realistic: 1. Every software contains bugs and regressions. See Every non trivial program has at least one bug at http://www.murphys-laws.com/murphy/murphy-computer.html 2. IMHO, nobody is able to fix all regressions because any fix potentially creates another regression. 3. Some regressions are not easy to fix because the new code is completely different. We always need to consider the seriousness of the regressions and the cost of the fix. 4. IMHO, we could not maintain too old code by volunteers. It is frustrating and very expensive. The code is evolving. People forget the old structures and functions, so they need to investigate a lot of stuff when they did into the history. Also the testing is expensive unless you do trivial changes and you are sure that it does not break anything. In the real word, it is done only by a company if a customers pays for it. 5. We need 3.4.6 because 3.5 is too young and we still might miss some regressions and nasty bugs. We review the fixes when backporting, so 3.4.6 should not need extensive testing. Some basic tests should be enough. You said that 3.4.6 would have been more or less useless for many users because of the regressions. I do not think so. LO-3.4 is being used by many users, so it is usable. Some users are conservative and do not want to risk 3.5 too early. 3.4.6 brings some very useful fixes for these people. We might change our mind and provide 3.4.7 if people report too many serious bugs in 3.5 and it takes longer time to make it usable. On the other hand, it seems that 3.5 is going to be better that 3.4. I do not see any reason to spend more time on this historic 3.4 code line right now. As described by Bjoern, we do a lot to improve the code, tools, and processes. LO-3.5 seems to be better than 3.4, so we seems to go the right direction. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW-3-5] fdo#42961 Don't let env vars interfere with internal bootstrap vars
Just out of interest, could you explain a bit more verbosely what is going on, what is this .override thing? (Or point to some webpage documenting it...) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED-3-5] fdo#42961 Don't let env vars interfere with internal bootstrap vars
On Thu, 2012-03-15 at 09:53 +0100, Stephan Bergmann wrote: Please consider the below fix for https://bugs.freedesktop.org/show_bug.cgi?id=42961 Setting $DATA causes LibreOffice to crash for inclusion in libreoffice-3-5. Not sure it is worth it including it in libreoffice-3-4 (the bug should be in at least since OOo 3.3). Gosh; this URL construction is a rather cumbersome and unreadable way of doing it - if (ini.getFrom(SCHEMA, RTL_BOOTSTRAP_NO_ENVIRONMENT)) ONO ? :-) Could we not move to that ? or at least plan that for LibreOffice4 :-) Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] [ANN] LibreOffice 3.4.6 RC2 test builds available
On Wed, 14 Mar 2012, Rainer Bielefeld wrote: Fridrich Strba schrieb: for 3.4.6 RC2, we're now uploading builds to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, we had exactly 0 reports for 3.4.6 RC1, and I doubt that anybody will do systematic tests with RC2 (I won't do either). I do systematic tests on every RC release, albeit very specific to my use-cases (python, UNO, filters/conversions) and with a limited set of documents. The fact that these releases can easily co-exist using RPM packages is priceless ! So it's hard to quantify what 0 reports means, no regressions or no user-testing ? We still have 45 unfixed regressions compared to 3.3, Lifecycle of 3.4 will end with 3.4.6(?), so this version is more or less useless for most (or at least very many) 3.3 or 3.4 users. Who would want to test a car when he knows that still 1 tire is flat and never will be repaired? Although 3 tires have been repaired, that car will be completely useless forever. It's my belief that we will have to rethink our release concept. Please excuse me that I can't tell anything more enthusiastic. If you want to improve a situation, the hard truth is better than a soft lie ;-) I wondered myself whether the split between 3.4, 3.5 and 3.6 is sustainable in the long run. At some point the cost of splitting the userbase is more expensive than the gains from fast release cycles. I would expect at that point we would more likely have a slower release cycle with a longer acceptance phase for QA/testing/regression fixing and less releases. -- -- dag wieers, d...@wieers.com, http://dag.wieers.com/ -- dagit linux solutions, i...@dagit.net, http://dagit.net/ [Any errors in spelling, tact or fact are transmission errors] ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Mac OSX 3.5.x - no access to postgres db with native connector
Hi all, There is currently this confirmed bug : https://bugs.freedesktop.org/show_bug.cgi?id=46439 in which it is impossible to use the official Mac binaries provided for download to connect to a running instance of a postgres server with the provided native connector. I have tested this also with 3.5.1 RC2, still no dice. However, the connection works for me when I build myself from master, so I am wondering whether the problem lies in a build switch hiccough on the buildbot for the official release ? Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #228 from Alex Thurgood ipla...@yahoo.co.uk 2012-03-15 03:53:52 PDT --- Nominating 46439 as blocker - can not access postgres db with official 3.5 builds on Mac and native postgres driver - works on build from master !! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Depends on||46439 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #229 from Alex Thurgood ipla...@yahoo.co.uk 2012-03-15 04:06:46 PDT --- (In reply to comment #228) Nominating 46439 as blocker - can not access postgres db with official 3.5 builds on Mac and native postgres driver - works on build from master !! Oh well, too late apparently !! Just seen the announcement for 3.5.1. Alex -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] export to xls warning ; work in SwEditShell::GetPaMTxtFmtColl
Hello
0001-add-SCWARN_EXPORT_MAXTAB-and-SCWARN_EXPORT_MAXCOL.patch
Add warning in the xls export filter in order to display different
messages when the number of column, row or tab are too high.
0002-rewrite-and-comment-SwEditShell-GetPaMTxtFmtColl.patch
comment, doxygen description, and rewrite of
SwEditShell::GetPaMTxtFmtColl and SwEditShell::GetCurTxtFmtColl.
Doesn't change the behavior of the functions.
0003-getMaxLookup-in-SwEditShell-GetPaMTxtFmtColl.patch
Handle getMaxLookup in SwEditShell::GetPaMTxtFmtColl.
getMaxLookup become the maximum number of nodes to inspect.
The function stop when it has inspect getMaxLookup nodes instead of
stopping (approximately) when it as to inspect more than getMaxLookup
nodes.
0004-SwEditShell-use-of-the-STL-swap-function.patch
Us of the swap STL function in the file sw/source/core/edit/edattr.cxx
Feel free to comment my code !
Regards
--
Maxime de Roucy
Groupe LINAGORA - OSSA
80 rue Roque de Fillol
92800 PUTEAUX
Tel. : 0 810 251 251
From 17a07d3c910a812f2dd0537d3a1e454ae9f06881 Mon Sep 17 00:00:00 2001
From: Maxime de Roucy mdero...@linagora.com
Date: Thu, 8 Mar 2012 14:49:58 +0100
Subject: [PATCH 1/4] add SCWARN_EXPORT_MAXTAB and SCWARN_EXPORT_MAXCOL
Create separate warnings when the maximum number of row, columns or
sheets is reach in the export filter to xls forma.
---
sc/inc/scerrors.hxx |4 +++-
sc/source/filter/excel/expop2.cxx |7 +--
sc/source/ui/src/scerrors.src |8
3 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/sc/inc/scerrors.hxx b/sc/inc/scerrors.hxx
index 735f7ba..fc6b9cb 100644
--- a/sc/inc/scerrors.hxx
+++ b/sc/inc/scerrors.hxx
@@ -68,7 +68,9 @@
#define SCWARN_EXPORT_NONCONVERTIBLE_CHARS ( 1 | ERRCODE_CLASS_EXPORT | ERRCODE_WARNING_MASK | ERRCODE_AREA_SC )
#define SCWARN_EXPORT_ASCII ( 2 | ERRCODE_CLASS_EXPORT | ERRCODE_WARNING_MASK | ERRCODE_AREA_SC )
#define SCWARN_EXPORT_MAXROW( 3 | ERRCODE_CLASS_EXPORT | ERRCODE_WARNING_MASK | ERRCODE_AREA_SC )
-#define SCWARN_EXPORT_DATALOST ( 4 | ERRCODE_CLASS_EXPORT | ERRCODE_WARNING_MASK | ERRCODE_AREA_SC )
+#define SCWARN_EXPORT_MAXCOL( 4 | ERRCODE_CLASS_EXPORT | ERRCODE_WARNING_MASK | ERRCODE_AREA_SC )
+#define SCWARN_EXPORT_MAXTAB( 5 | ERRCODE_CLASS_EXPORT | ERRCODE_WARNING_MASK | ERRCODE_AREA_SC )
+#define SCWARN_EXPORT_DATALOST ( 6 | ERRCODE_CLASS_EXPORT | ERRCODE_WARNING_MASK | ERRCODE_AREA_SC )
// ERRCODE_CLASS_GENERAL
#define SCWARN_CORE_HARD_RECALC ( 1 | ERRCODE_CLASS_GENERAL | ERRCODE_WARNING_MASK | ERRCODE_AREA_SC )
diff --git a/sc/source/filter/excel/expop2.cxx b/sc/source/filter/excel/expop2.cxx
index a8a4ce1..ab31d97 100644
--- a/sc/source/filter/excel/expop2.cxx
+++ b/sc/source/filter/excel/expop2.cxx
@@ -124,10 +124,13 @@ FltError ExportBiff5::Write()
sfx2::SaveOlePropertySet(xDocProps, xRootStrg );
}
-//! TODO: separate warnings for columns and sheets
const XclExpAddressConverter rAddrConv = GetAddressConverter();
-if( rAddrConv.IsColTruncated() || rAddrConv.IsRowTruncated() || rAddrConv.IsTabTruncated() )
+if( rAddrConv.IsRowTruncated() )
return SCWARN_EXPORT_MAXROW;
+if( rAddrConv.IsColTruncated() )
+return SCWARN_EXPORT_MAXCOL;
+if( rAddrConv.IsTabTruncated() )
+return SCWARN_EXPORT_MAXTAB;
return eERR_OK;
}
diff --git a/sc/source/ui/src/scerrors.src b/sc/source/ui/src/scerrors.src
index 2a2e2ad..f77dcf0 100644
--- a/sc/source/ui/src/scerrors.src
+++ b/sc/source/ui/src/scerrors.src
@@ -150,6 +150,14 @@ Resource RID_ERRHDLSC
{
Text [ en-US ] = The document contains more rows than supported in the selected format.\nAdditional rows were not saved. ;
};
+String SCWARN_EXPORT_MAXCOL ERRCODE_RES_MASK
+{
+Text [ en-US ] = The document contains more columns than supported in the selected format.\nAdditional columns were not saved. ;
+};
+String SCWARN_EXPORT_MAXTAB ERRCODE_RES_MASK
+{
+Text [ en-US ] = The document contains more sheets than supported in the selected format.\nAdditional sheets were not saved. ;
+};
String SCWARN_IMPORT_INFOLOST ERRCODE_RES_MASK
{
Text [ en-US ] = The document contains information not recognized by this program version.\nResaving the document will delete this information! ;
--
1.7.9.4
From 31b7640f7137964916062e64fca18869a18f5118 Mon Sep 17 00:00:00 2001
From: Maxime de Roucy mdero...@linagora.com
Date: Tue, 13 Mar 2012 16:20:59 +0100
Subject: [PATCH 2/4] rewrite and comment SwEditShell::GetPaMTxtFmtColl
Classe SwEditShell.
Add some doxygen description for GetCurTxtFmtColl and GetPaMTxtFmtColl.
Rewrite of GetPaMTxtFmtColl in order to comment and simplify the code.
---
sw/inc/editsh.hxx | 18 ++
sw/source/core/edit/edattr.cxx | 38 --
2 files changed, 38 insertions(+), 18 deletions(-)
diff --git
[PATCH] Convert SV_DECL_VARARR_SORT, SV_IMPL_VARARR and SV_IMPL_VARARR_SORT with std::set/deque/vector
Hi
I converted the SV to std::set/vector/deque in sw component.
Could you please push this path?
This and later contributions is licensed under MPL 1.1 / GPL v3+ / LGPL v3+.
Best Regards
Bartosz
From 661b72c0cf13abd9276866766715bd6c22d5706b Mon Sep 17 00:00:00 2001
From: Bartosz Kosiorek gan...@poczta.onet.pl
Date: Thu, 15 Mar 2012 07:26:54 +0100
Subject: [PATCH 3/3] Convert SVARRAY SORT into STL set
---
sw/source/core/doc/docdraw.cxx|3 --
sw/source/core/doc/docedt.cxx |9 ++---
sw/source/core/docnode/ndcopy.cxx | 56 ++--
sw/source/core/inc/mvsave.hxx |5 +--
4 files changed, 34 insertions(+), 39 deletions(-)
diff --git a/sw/source/core/doc/docdraw.cxx b/sw/source/core/doc/docdraw.cxx
index 2d5671c..cbff064 100644
--- a/sw/source/core/doc/docdraw.cxx
+++ b/sw/source/core/doc/docdraw.cxx
@@ -76,9 +76,6 @@
using namespace ::com::sun::star;
using namespace ::com::sun::star::linguistic2;
-
-SV_IMPL_VARARR_SORT( _ZSortFlys, _ZSortFly )
-
/*
|*
|* SwDoc::GroupSelection / SwDoc::UnGroupSelection
diff --git a/sw/source/core/doc/docedt.cxx b/sw/source/core/doc/docedt.cxx
index 26a2ad8..6c73ba1 100644
--- a/sw/source/core/doc/docedt.cxx
+++ b/sw/source/core/doc/docedt.cxx
@@ -163,7 +163,6 @@ struct _SaveRedline
SV_DECL_PTRARR_DEL( _SaveRedlines, _SaveRedline*, 0 )
-SV_IMPL_VARARR( _SaveFlyArr, _SaveFly )
SV_IMPL_PTRARR( _SaveRedlines, _SaveRedline* )
bool lcl_MayOverwrite( const SwTxtNode *pNode, const xub_StrLen nPos )
@@ -191,7 +190,7 @@ void _RestFlyInRange( _SaveFlyArr rArr, const SwNodeIndex rSttIdx,
const SwNodeIndex* pInsertPos )
{
SwPosition aPos( rSttIdx );
-for( sal_uInt16 n = 0; n rArr.Count(); ++n )
+for( size_t n = 0; n rArr.size(); ++n )
{
// create new anchor
_SaveFly rSave = rArr[n];
@@ -234,7 +233,7 @@ void _SaveFlyInRange( const SwNodeRange rRg, _SaveFlyArr rArr )
{
_SaveFly aSave( pAPos-nNode.GetIndex() - rRg.aStart.GetIndex(),
pFmt, sal_False );
-rArr.Insert( aSave, rArr.Count());
+rArr.push_back( aSave );
pFmt-DelFrms();
rFmts.Remove( n--, 1 );
}
@@ -295,7 +294,7 @@ void _SaveFlyInRange( const SwPaM rPam, const SwNodeIndex rInsPos,
{
_SaveFly aSave( pAPos-nNode.GetIndex() - rSttNdIdx.GetIndex(),
pFmt, bInsPos );
-rArr.Insert( aSave, rArr.Count());
+rArr.push_back( aSave );
pFmt-DelFrms();
rFmts.Remove( n--, 1 );
}
@@ -1188,7 +1187,7 @@ bool SwDoc::MoveNodeRange( SwNodeRange rRange, SwNodeIndex rPos,
}
// move the Flys to the new position
-if( aSaveFlyArr.Count() )
+if( !aSaveFlyArr.empty() )
_RestFlyInRange( aSaveFlyArr, aIdx, NULL );
// Add the Bookmarks back to the Document
diff --git a/sw/source/core/docnode/ndcopy.cxx b/sw/source/core/docnode/ndcopy.cxx
index 2461505..978bfee 100644
--- a/sw/source/core/docnode/ndcopy.cxx
+++ b/sw/source/core/docnode/ndcopy.cxx
@@ -53,6 +53,8 @@
#include pagedesc.hxx
#include poolfmt.hxx
#include SwNodeNum.hxx
+#include set
+#include vector
#ifdef DBG_UTIL
#define CHECK_TABLE(t) (t).CheckConsistency();
@@ -328,7 +330,7 @@ sal_Bool lcl_CopyTblLine( const SwTableLine* rpLine, void* pPara );
sal_Bool lcl_CopyTblBox( const SwTableBox* rpBox, void* pPara )
{
-_CopyTable* pCT = (_CopyTable*)pPara;
+_CopyTable* pCT = reinterpret_cast _CopyTable* (pPara);
SwTableBoxFmt* pBoxFmt = (SwTableBoxFmt*)rpBox-GetFrmFmt();
pCT-rMapArr.ForEach( lcl_SrchNew, pBoxFmt );
@@ -392,7 +394,7 @@ sal_Bool lcl_CopyTblBox( const SwTableBox* rpBox, void* pPara )
sal_Bool lcl_CopyTblLine( const SwTableLine* rpLine, void* pPara )
{
-_CopyTable* pCT = (_CopyTable*)pPara;
+_CopyTable* pCT = reinterpret_cast _CopyTable* (pPara);
SwTableLineFmt* pLineFmt = (SwTableLineFmt*)rpLine-GetFrmFmt();
pCT-rMapArr.ForEach( lcl_SrchNew, pLineFmt );
if( pLineFmt == rpLine-GetFrmFmt() ) // ein neues anlegen ??
@@ -1403,7 +1405,7 @@ void SwDoc::CopyFlyInFlyImpl( const SwNodeRange rRg,
//die Ordnungsnummer (wird nur im DrawModel verwaltet)
//beibehalten.
SwDoc *const pDest = rStartIdx.GetNode().GetDoc();
-_ZSortFlys aArr;
+::std::set _ZSortFly aSet;
sal_uInt16 nArrLen = GetSpzFrmFmts()-Count();
for ( sal_uInt16 n = 0; n nArrLen; ++n )
@@ -1467,22 +1469,20 @@ void SwDoc::CopyFlyInFlyImpl( const SwNodeRange rRg,
}
}
if( bAdd )
-aArr.Insert( _ZSortFly( pFmt, pAnchor, nArrLen + aArr.Count() ));
+aSet.insert( _ZSortFly( pFmt, pAnchor, nArrLen + aSet.size() ));
}
}
//Alle kopierten (also die neu
[PUSHED 3-5] fdo#45521 most-annoying .sdw bug
Hi there, On Wed, 2012-03-14 at 14:31 +, Caolán McNamara wrote: some problems with .sdw documents, turns out that the binfilter import depends on being able to use the ascii text exporter to generate plain-text forms of some entries. Pushed to -3-5, thanks ! :-) Goes against the grain to add back those huge empty comments at the end of it though ;-) ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] remove unused code (oox, sd)
Hi there,
remove some unused code in oox and sd.
Regards,
Petr
From 2cc831282d53c3a14dd10fc8cb190f1d15df3354 Mon Sep 17 00:00:00 2001
From: Petr Vorel petr.vo...@gmail.com
Date: Thu, 15 Mar 2012 11:40:15 +0100
Subject: [PATCH] remove unused code (oox, sd)
---
oox/inc/oox/helper/attributelist.hxx |6 --
oox/inc/oox/helper/containerhelper.hxx | 16
oox/inc/oox/helper/graphichelper.hxx |2 --
oox/source/helper/attributelist.cxx | 10 --
oox/source/helper/containerhelper.cxx| 18 --
oox/source/helper/graphichelper.cxx |5 -
sd/source/filter/eppt/epptooxml.hxx |1 -
sd/source/filter/eppt/pptx-epptooxml.cxx | 10 --
unusedcode.easy |5 -
9 files changed, 0 insertions(+), 73 deletions(-)
diff --git a/oox/inc/oox/helper/attributelist.hxx b/oox/inc/oox/helper/attributelist.hxx
index d0a0600..c60c6f8 100644
--- a/oox/inc/oox/helper/attributelist.hxx
+++ b/oox/inc/oox/helper/attributelist.hxx
@@ -66,12 +66,6 @@ public:
/** Returns the 32-bit signed integer value from the passed string (hexadecimal). */
static sal_Int32decodeIntegerHex( const ::rtl::OUString rValue );
-
-/** Returns the 32-bit unsigned integer value from the passed string (hexadecimal). */
-static sal_uInt32 decodeUnsignedHex( const ::rtl::OUString rValue );
-
-/** Returns the 64-bit signed integer value from the passed string (hexadecimal). */
-static sal_Int64decodeHyperHex( const ::rtl::OUString rValue );
};
//
diff --git a/oox/inc/oox/helper/containerhelper.hxx b/oox/inc/oox/helper/containerhelper.hxx
index 5c9dc88..eef9429 100644
--- a/oox/inc/oox/helper/containerhelper.hxx
+++ b/oox/inc/oox/helper/containerhelper.hxx
@@ -173,22 +173,6 @@ public:
static ::com::sun::star::uno::Reference ::com::sun::star::container::XIndexContainer
createIndexContainer( const ::com::sun::star::uno::Reference ::com::sun::star::uno::XComponentContext rxContext );
-/** Inserts an object into an indexed container.
-
-@param rxIndexContainer com.sun.star.container.XIndexContainer
-interface of the indexed container.
-
-@param nIndex Insertion index for the object.
-
-@param rObject The object to be inserted.
-
-@return True = object successfully inserted.
- */
-static bool insertByIndex(
-const ::com::sun::star::uno::Reference ::com::sun::star::container::XIndexContainer rxIndexContainer,
-sal_Int32 nIndex,
-const ::com::sun::star::uno::Any rObject );
-
// com.sun.star.container.XNameContainer --
/** Creates a new name container object from scratch. */
diff --git a/oox/inc/oox/helper/graphichelper.hxx b/oox/inc/oox/helper/graphichelper.hxx
index d3507fa..9881200 100644
--- a/oox/inc/oox/helper/graphichelper.hxx
+++ b/oox/inc/oox/helper/graphichelper.hxx
@@ -93,8 +93,6 @@ public:
sal_Int32 convertScreenPixelXToHmm( double fPixelX ) const;
/** Converts the passed value from vertical screen pixels to 1/100 mm. */
sal_Int32 convertScreenPixelYToHmm( double fPixelY ) const;
-/** Converts the passed point from screen pixels to 1/100 mm. */
-::com::sun::star::awt::Point convertScreenPixelToHmm( const ::com::sun::star::awt::Point rPixel ) const;
/** Converts the passed size from screen pixels to 1/100 mm. */
::com::sun::star::awt::Size convertScreenPixelToHmm( const ::com::sun::star::awt::Size rPixel ) const;
diff --git a/oox/source/helper/attributelist.cxx b/oox/source/helper/attributelist.cxx
index 33f4ed5..f1d114d 100644
--- a/oox/source/helper/attributelist.cxx
+++ b/oox/source/helper/attributelist.cxx
@@ -122,16 +122,6 @@ sal_Int32 AttributeConversion::decodeIntegerHex( const OUString rValue )
return rValue.toInt32( 16 );
}
-sal_uInt32 AttributeConversion::decodeUnsignedHex( const OUString rValue )
-{
-return getLimitedValue sal_uInt32, sal_Int64 ( rValue.toInt64( 16 ), 0, SAL_MAX_UINT32 );
-}
-
-sal_Int64 AttributeConversion::decodeHyperHex( const OUString rValue )
-{
-return rValue.toInt64( 16 );
-}
-
//
AttributeList::AttributeList( const Reference XFastAttributeList rxAttribs ) :
diff --git a/oox/source/helper/containerhelper.cxx b/oox/source/helper/containerhelper.cxx
index 23bad22..a19e9b4 100644
--- a/oox/source/helper/containerhelper.cxx
+++ b/oox/source/helper/containerhelper.cxx
@@ -119,24 +119,6 @@ Reference XIndexContainer ContainerHelper::createIndexContainer( const Refere
return xContainer;
}
-bool ContainerHelper::insertByIndex(
-const Reference XIndexContainer rxIndexContainer,
-sal_Int32
Re: Solaris linker version map annoyances (was: Re: LibreOffice / openIndiana ...)
ok, the problem (isolated by Michael) is in the xmlreader ... I have tried compiling with gcc compilers from a different package maintainer (although strangely still 4.6.2), but the issue appears to stay the same. system supplied g++: sal@salmon190-241:~$ /usr/gcc/4.6/bin/g++ -v Using built-in specs. COLLECT_GCC=/usr/gcc/4.6/bin/g++ COLLECT_LTO_WRAPPER=/usr/gcc/4.6/lib/gcc/i386-pc-solaris2.11/4.6.2/lto-wrapper Target: i386-pc-solaris2.11 Configured with: ../gcc-4.6.2/configure --prefix=/usr/gcc/4.6 --libdir=/usr/gcc/4.6/lib --libexecdir=/usr/gcc/4.6/lib --mandir=/usr/gcc/4.6/share/man --infodir=/usr/gcc/4.6/info --with-build-time-tools=/usr/sfw --with-as=/usr/sfw/bin/gas --with-gnu-as --with-ld=/usr/bin/ld --without-gnu-ld --enable-languages=c,c++,fortran,objc --enable-shared --disable-static --enable-decimal-float --with-gmp=/usr/gnu --with-mpfr=/usr/gnu --with-mpc=/usr/gnu --with-libiconv-prefix=/usr/gnu -enable-nls Thread model: posix gcc version 4.6.2 (GCC) OpenCSW supplied g++: sal@salmon190-241:~$ /opt/csw/bin/g++ -v Reading specs from /opt/csw/lib/gcc/i386-pc-solaris2.10/4.6.2/specs COLLECT_GCC=/opt/csw/bin/g++ COLLECT_LTO_WRAPPER=/opt/csw/libexec/gcc/i386-pc-solaris2.10/4.6.2/lto-wrapper Target: i386-pc-solaris2.10 Configured with: /home/maciej/src/opencsw/pkg/gcc4/trunk/work/solaris10-i386/build-isa-pentium_pro/gcc-4.6.2/configure --program-suffix=-4.6 --prefix=/opt/csw --exec_prefix=/opt/csw --bindir=/opt/csw/bin --sbindir=/opt/csw/sbin --libexecdir=/opt/csw/libexec --datadir=/opt/csw/share --sysconfdir=/etc/opt/csw --sharedstatedir=/opt/csw/share --localstatedir=/var/opt/csw --libdir=/opt/csw/lib --infodir=/opt/csw/share/info --includedir=/opt/csw/include --mandir=/opt/csw/share/man --with-gnu-as --with-as=/opt/csw/bin/gas --without-gnu-ld --with-ld=/usr/ccs/bin/ld --enable-nls --with-included-gettext --with-libiconv-prefix=/opt/csw --with-x --with-mpfr=/opt/csw --with-gmp=/opt/csw --with-ppl=/opt/csw --with-cloog=/opt/csw --enable-cloog-backend=isl --enable-java-awt=xlib --enable-libada --enable-libssp --enable-objc-gc --enable-threads=posix --enable-languages=ada,c,c++,fortran,java,objc --with-system-zlib=/opt/csw Thread model: posix gcc version 4.6.2 (GCC) both are linked to the Sun supplied ld linker ... there are issues in the private block of xmlreader.hxx where the state_ global variable seemed to be forgotten between procedure calls in xmlreader.cxx I played with the order of everything in the private block till I found that placing stack_ above all the other variables caused it to keep state (with different exceptions being reported in i18npool, to do with end_ and pos_) After looking further I found that moving ElementStack elements_; to the end appears to keep all variables alive, but I'm now getting a core dump every time I run saxparser. tail of truss output: 11477/1:write(2, 0\n, 2) = 2 11477/1:Incurred fault #6, FLTBOUNDS %pc = 0xFEC8F35C 11477/1: siginfo: SIGSEGV SEGV_ACCERR addr=0xFEC999EE 11477/1:Received signal #11, SIGSEGV [default] 11477/1: siginfo: SIGSEGV SEGV_ACCERR addr=0xFEC999EE gnu debug of the core file: #0 0xfec79bac in rtl_uString_release (pThis=0x29) at /home/sal/LibreOffice/libo/sal/rtl/source/strtmpl.cxx:75 75 pTempStr++; I'm well and truly out of my depth with this now. anyone got any pointers for me to have a look at? Jon On 6 March 2012 14:24, Jonathan Adams t12nsloo...@gmail.com wrote: Also I had to undo a revision in the latest git to get it to compile: 587 git diff a1410ef073d2117cb2a3c9d9a4e9ecff7d911344 90491a073c5b5faee782ad5eab63276fda2342e6 /tmp/mkdir-p.diff 591 patch -Rbp1 /tmp/mkdir-p.diff a change made in the mkdir -p which helps on cygwin, unfortunately it now mkdirs files instead of touching them causing a very early death to my compilation. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Regressions in Open Source projects ...
Hi Michael, all I'm looking at another few Windows specific bugs that are of interest. Particularly with the new drmemory tool and Jesus' windows / debug builds - we should be able to progress here quickly. It'd be wonderful if we could get these traces for Windows specific bugs. I'm quite curious to test that on a 100% reproducible crash as soon as I find some time ;) Clearly that is true of some hypothetical user, for whom some serious regression blocks them from updating. It is not so hypothetical. I had to keep a Portable LibreOffice 3.3.4 copy around just to be able to open documents that included equations. And yes I know it was a docx only bug but I do need to exchange manuscript revisions with my co-authors and I haven't been able to convince them to drop Microsoft Office 2007... So this is a real life example for a single specific bug, as I'm sure there are many others ;) There is however an easy solution for them - pay to have their (apparently un-interesting to the community) bugs fixed: then they can have their regression-free release, supported indefinately and everyone is happy :-) This sounds like a pitch for users to switch to SUSE LibreOffice :P BTW the code optimizations under Windows are fantastic ;) But SUSE released version 3.4.2 while TDF is already at 3.5.1. Doesn't that show a little about the importance of stability? ;) As a straw-man (and I don't think anyone suggests this) - suggesting that we never ship until there are zero regressions would not meet this goal: we typically find regressions only after we ship. I'm not sure I understand the straw-man concept but no one in QA is advocating not to ship until zarro boogs are found... But we (at least I am) are asking to give higher priority to fixing regressions and crashers (even if they happen to only ONE user as long as it is reproducible) than to adding new features. This doesn't mean AT ALL to stop adding features. Just to change priorities ;) As a general conclusion I think we are all doing the best given the limited human resources and the scarcity of our most valuable resource: time! It is because we do CARE about this project that we complain about the short testing times AND the regressions ;) Regards, Pedro ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Regressions in Open Source projects ...
On 2012-03-15 14:31, Pedro Lino wrote: As a general conclusion I think we are all doing the best given the limited human resources and the scarcity of our most valuable resource: time! It is because we do CARE about this project that we complain about the short testing times AND the regressions ;) The problem is that open-source developers cannot be motivated to work 80% on bugs and 20% on features. If you need more reliability, then yes, perhaps SUSE LibreOffice is the right thing for you. That is the beauty of open-source, of course, you have choices :-) Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Regressions in Open Source projects ...
On 15.03.2012 16:55, Noel Grandin wrote: The problem is that open-source developers cannot be motivated to work 80% on bugs and 20% on features. Perhaps, if you mean the whole team. But note that there are some lunatic guys like me, who are interested in bug-fixing ~completely. ;) Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Regressions in Open Source projects ...
On Thu, Mar 15, 2012 at 02:55:30PM +0200, Noel Grandin wrote: The problem is that open-source developers cannot be motivated to work 80% on bugs and 20% on features. I dont think that is correct in absolute. I bet there are people out there too, who like to work on bugfixing. Actually I am pretty certain, we already have a few in the project, but we can use more. It is just a question of motivation. ;) Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW: 3-5, 3-4][CANCELLED] fdo#43932 setting paper tray from print dialog
On Wed, Mar 14, 2012 at 06:19:13PM +0400, Ivan Timofeev wrote: In my patch I used mpImplData-mpPrinter-GetPaperBin() in printFilteredPage to control what tray is currently used, and that showed right trays. So I am confused. %-) Hi, I am too, apparently. I am hereby cancelling this request pending further investigation. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Regressions in Open Source projects ...
On Thu, Mar 15, 2012 at 7:31 AM, Pedro Lino pedl...@gmail.com wrote: I'm not sure I understand the straw-man concept Since that is a common rhetorical tools: A straw man is a component of an argument and is an informal fallacy based on misrepresentation of an opponent's position. To attack a straw man is to create the illusion of having refuted a proposition by replacing it with a superficially similar yet unequivalent proposition (the straw man), and refuting it, without ever having actually refuted the original position. http://en.wikipedia.org/wiki/Straw_man Here the straw-man is to replace 'regression should be a high priority' with 'we should not ship unless the regression counter is 0' ... which incidentally is exactly what you explain after saying 'I'm not sure I understand the straw-man concept' .. so, in fact, you did understand, you just did not know there is a name for it. :-) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#84393: Title field displays wrongly in header/footer
Hi all! I made a patch for this (https://issues.apache.org/ooo/show_bug.cgi?id=84393). It was present in LO too. I hope I did everything right. Just let me know if something is incorrect. Szabolcs From 448af7eaa397bfe2f940c49798667fce99127a16 Mon Sep 17 00:00:00 2001 From: Szabolcs Dezsi dezsisz...@hotmail.com Date: Thu, 15 Mar 2012 15:23:17 +0100 Subject: [PATCH] Fix title field in header, footer --- sc/source/ui/view/prevwsh.cxx |7 ++- sc/source/ui/view/printfun.cxx |7 ++- sc/source/ui/view/tabvwsh4.cxx |8 +++- 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/sc/source/ui/view/prevwsh.cxx b/sc/source/ui/view/prevwsh.cxx index 9dbe51f..ad3aa70 100644 --- a/sc/source/ui/view/prevwsh.cxx +++ b/sc/source/ui/view/prevwsh.cxx @@ -77,6 +77,7 @@ #include basegfx/tools/zoomtools.hxx #include svx/zoom_def.hxx +#include com/sun/star/document/XDocumentProperties.hpp #include sc.hrc #include scabstdlg.hxx @@ -841,7 +842,11 @@ void ScPreviewShell::FillFieldData( ScHeaderFieldData rData ) pDoc-GetName(nTab, aTmp); rData.aTabName = aTmp; -rData.aTitle= pDocShell-GetTitle(); +if( pDocShell-getDocProperties()-getTitle().getLength() != 0 ) +rData.aTitle = pDocShell-getDocProperties()-getTitle(); +else +rData.aTitle = pDocShell-GetTitle(); + const INetURLObject rURLObj = pDocShell-GetMedium()-GetURLObject(); rData.aLongDocName = rURLObj.GetMainURL( INetURLObject::DECODE_UNAMBIGUOUS ); if ( rData.aLongDocName.Len() ) diff --git a/sc/source/ui/view/printfun.cxx b/sc/source/ui/view/printfun.cxx index 01f1b5b..9d82ba5 100644 --- a/sc/source/ui/view/printfun.cxx +++ b/sc/source/ui/view/printfun.cxx @@ -83,6 +83,7 @@ #include vcl/lineinfo.hxx #include boost/scoped_ptr.hpp +#include com/sun/star/document/XDocumentProperties.hpp #define ZOOM_MIN10 @@ -1037,7 +1038,11 @@ void ScPrintFunc::InitParam( const ScPrintOptions* pOptions ) SetDateTime( Date( Date::SYSTEM ), Time( Time::SYSTEM ) ); -aFieldData.aTitle = pDocShell-GetTitle(); +if( pDocShell-getDocProperties()-getTitle().getLength() != 0 ) +aFieldData.aTitle = pDocShell-getDocProperties()-getTitle(); +else +aFieldData.aTitle = pDocShell-GetTitle(); + const INetURLObject rURLObj = pDocShell-GetMedium()-GetURLObject(); aFieldData.aLongDocName = rURLObj.GetMainURL( INetURLObject::DECODE_UNAMBIGUOUS ); if ( aFieldData.aLongDocName.Len() ) diff --git a/sc/source/ui/view/tabvwsh4.cxx b/sc/source/ui/view/tabvwsh4.cxx index cf93d15..35c2c54 100644 --- a/sc/source/ui/view/tabvwsh4.cxx +++ b/sc/source/ui/view/tabvwsh4.cxx @@ -97,6 +97,8 @@ #include markdata.hxx #include preview.hxx +#include com/sun/star/document/XDocumentProperties.hpp + void ActivateOlk( ScViewData* pViewData ); void DeActivateOlk( ScViewData* pViewData ); @@ -1824,7 +1826,11 @@ void ScTabViewShell::FillFieldData( ScHeaderFieldData rData ) pDoc-GetName(nTab, aTmp); rData.aTabName = aTmp; -rData.aTitle= pDocShell-GetTitle(); +if( pDocShell-getDocProperties()-getTitle().getLength() != 0 ) +rData.aTitle = pDocShell-getDocProperties()-getTitle(); +else +rData.aTitle = pDocShell-GetTitle(); + const INetURLObject rURLObj = pDocShell-GetMedium()-GetURLObject(); rData.aLongDocName = rURLObj.GetMainURL( INetURLObject::DECODE_UNAMBIGUOUS ); if ( rData.aLongDocName.Len() ) -- 1.7.7 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#84393: Title field displays wrongly in header/footer
Hello Dézsi, 2012/3/15 Dézsi Szabolcs dezsisz...@hotmail.com: I made a patch for this (https://issues.apache.org/ooo/show_bug.cgi?id=84393). It was present in LO too. Thanks for the patch :-) I didn't look at the code yet, but please apologize my nitpicking: the openoffice bugzilla is referred as i#84393 And, could you please also mention the bug number in the subject of commit message too? Thanks again. Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Licensing of my contribs
As per request by Michael M: All of my past contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license, including the go-oo code. Julian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#84393: Title field displays wrongly in header/footer
Hi *, 2012/3/15 Korrawit Pruegsanusak detective.conan.1...@gmail.com: 2012/3/15 Dézsi Szabolcs dezsisz...@hotmail.com: I made a patch for this (https://issues.apache.org/ooo/show_bug.cgi?id=84393). It was present in LO too. I didn't look at the code yet, but please apologize my nitpicking: the openoffice bugzilla is referred as i#84393 Well, there was no reference to the bug in the patch, and of course full URLs are appreciate here. But to correct your nitpicking: the traditional way to refer to the OOo bugtracker was #i1234 [cl@esprimo lo-core]$ git log | grep '#i[1-9]' |wc -l 258646 [cl@esprimo lo-core]$ git log | grep 'i#[1-9]' |wc -l 1026 But I agree with: And, could you please also mention the bug number in the subject of commit message too? Thanks again. Yes, when a concrete bug is fixed, it should be mentioned in the commitlog. ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 46439, which changed state. Bug 46439 Summary: PostgreSQL-SDBC can't connect on OS X (3.5.0 RC3) https://bugs.freedesktop.org/show_bug.cgi?id=46439 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED-3-5] fdo#42961 Don't let env vars interfere with internal bootstrap vars
On 03/15/2012 04:09 PM, Jean-Baptiste Faure wrote:
Le 15/03/2012 11:04, Michael Meeks a écrit :
It seems this commit make LO 3.5 build fail in configmgr. After a make
clean, I get the following error messages :
Compiling: configmgr/source/components.cxx
/home/jbf/LibO/lo35/configmgr/source/components.cxx: In member function
‘void configmgr::Components::parseXcsXcuIniLayer(int, const
rtl::OUString, bool)’:
/home/jbf/LibO/lo35/configmgr/source/components.cxx:848:50: erreur:
invalid conversion from ‘const char*’ to ‘sal_Int32 {aka int}’
[-fpermissive]
Ah, sure, the master commit would have needed tweaking when
cherry-picked into -3-5. Fixed now as
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=90e2949099586e98619561dc781cc4deb8fc1ef0
Adapt prev 4f78696117ebe4f729880b5d9bfc2f5817b73543 to 3.5 rtl::OUString.
Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#84393: Title field displays wrongly in header/footer
Hello Christian, On Thu, Mar 15, 2012 at 22:28, Christian Lohmaier lohmaier+libreoff...@googlemail.com wrote: But to correct your nitpicking: the traditional way to refer to the OOo bugtracker was #i1234 [snip] Ah, sorry for this :( Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#84393: Title field displays wrongly in header/footer
On 15/03/12 16:28, Christian Lohmaier wrote:
2012/3/15 Korrawit Pruegsanusak detective.conan.1...@gmail.com:
But to correct your nitpicking: the traditional way to refer to the
OOo bugtracker was #i1234
[cl@esprimo lo-core]$ git log | grep '#i[1-9]' |wc -l
258646
[cl@esprimo lo-core]$ git log | grep 'i#[1-9]' |wc -l
1026
yes, it used to be #i1234# in OOo times, but that was changed to i#1234
due to git's limitations in editing commit messages ('#' at beginning of
line is a comment).
But I agree with:
And, could you please also mention the bug number in the subject of
commit message too? Thanks again.
Yes, when a concrete bug is fixed, it should be mentioned in the commitlog.
+1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #230 from sasha.libreoff...@gmail.com 2012-03-15 08:58:18 PDT --- Regression since 3.3.4 in Writer: wrapping text around object becomes or seen wrong after use Page Preview Bug 45376 - [FORMATTING] Incorrect text wrapping around drawing shapes -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 sasha.libreoff...@gmail.com changed: What|Removed |Added Depends on||45376 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH][PUSHED] remove unused code (oox, sd)
Hi Petr, On Thu, 2012-03-15 at 12:45 +0100, Petr Vorel wrote: remove some unused code in oox and sd. Thanks for your patch! I just pushed it to master branch. Keep sending good patches like this one ;) -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] export to xls warning ; work in SwEditShell::GetPaMTxtFmtColl
Hello Maxime, On Tue, 2012-03-13 at 17:52 +0100, Maxime de Roucy wrote: Feel free to comment my code ! Many thanks for your 4 patches. I fixed a few typos (or frenglish words) and pushed them to master. Feel free to provide more patches like these. -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] format clipboard
Hi Maxime, On Wed, 2012-03-14 at 16:50 +0100, Maxime de Roucy wrote: Here is some new patchs on the format clipboard. The first just add some comment in the formatclipboard.hxx file. The second one depend on modifications I made in the previous patch 0001-add-GetCurParAttr-and-GetPaMParAttr-in-SwEditShell.patch which is itself dependant of the patch 0004-SwEditShell-use-of-the-STL-swap-function.patch which is waiting for moderator approval to be published in the mailing list. I pushed the first patch to the master branch... but there is something weird in the second patch. Why did you remove the case where nSelectionType is a table selection? I'll push the second patch once that question is clarified. -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] export to xls warning ; work in SwEditShell::GetPaMTxtFmtColl
oops, forgot to update the subject On Thu, 2012-03-15 at 17:02 +0100, Cedric Bosdonnat wrote: Hello Maxime, On Tue, 2012-03-13 at 17:52 +0100, Maxime de Roucy wrote: Feel free to comment my code ! Many thanks for your 4 patches. I fixed a few typos (or frenglish words) and pushed them to master. Feel free to provide more patches like these. -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] convert tools/table.hxx to std::map in ScEEParser class in SC module
Hi Noel, pushed, thank you! Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW-3-5] fdo#42961 Don't let env vars interfere with internal bootstrap vars
On Thu, 2012-03-15 at 11:42 +0200, Tor Lillqvist wrote:
Just out of interest, could you explain a bit more verbosely what is
going on, what is this .override thing? (Or point to some webpage
documenting it...)
The bootstrap stuff is (to put it mildly) horribly over-engineered and
not that readable; it does a ton of variable substitution, and it can
read other ini files and substitute variables from them recursively.
Some of those eg. ORIGIN are related to the location of the ini file
itself, and then there are other syntaxes laid on top of that to
interpret each variable:
eg.
UNO_SERVICES=${ORIGIN}/../share/misc/services.rdb
?file:///etc/opt/ure/services.rdb ?${SYSUSERHOME}/.ure/services.rdb
${URE_MORE_SERVICES}
One consequence of this is 10 interlinked *rc files (on Linux, or .ini
IIRC on Windows) eg.
TMP_EXTENSIONS=${$BRAND_BASE_DIR/program/bootstraprc:UserInstallation}/user/extensions/tmp
Which - I assume loads that rc file and hooks the 'UserInstallation'
key out of it.
In addition to override, there seems to be a .link thing in there as
well.
IMHO we would benefit from a -much- simpler set of (perhaps two)
LibreOffice + UNO bootstrap files, with fewer features and a simpler
syntax.
But - of course, that's just me :-)
It's quite a powerful system anyhow,
HTH,
Michael.
--
michael.me...@suse.com , Pseudo Engineer, itinerant idiot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Mac OSX 3.5.x - no access to postgres db with native connector
On Thu, 2012-03-15 at 11:35 +0100, Alexander Thurgood wrote: There is currently this confirmed bug : https://bugs.freedesktop.org/show_bug.cgi?id=46439 Looks like Norbert has a fix for the configure options for LibreOffice 3.5.2 :-) Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Mac OSX 3.5.x - no access to postgres db with native connector
I just saw the thread, ace job !! Kudos to all ! Le 15/03/12 17:51, Michael Meeks a écrit : On Thu, 2012-03-15 at 11:35 +0100, Alexander Thurgood wrote: There is currently this confirmed bug : https://bugs.freedesktop.org/show_bug.cgi?id=46439 Looks like Norbert has a fix for the configure options for LibreOffice 3.5.2 :-) Thanks ! Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Regressions in Open Source projects ...
Pedro Lino píše v Čt 15. 03. 2012 v 12:31 +: But SUSE released version 3.4.2 while TDF is already at 3.5.1. Doesn't that show a little about the importance of stability? ;) We have had 3.4.4 in the LibreOffice:Stable project for a long time. I have just pushed there 3.4.5 which actually have all fixes from 3.4.6. We still do not have 3.5 packages for openSUSE because I spend most of my time on upstream release. I need few days to get working packages for this bigger update and I have only few hours every week. To be honest, I am surprised how good 3.5 is. I expected that people would prefer 3.4.6 over 3.5.1 and did not set my priorities well. Please, do not take this that we do not take care about openSUSE/SUSE users. We do a lot of things for them. It is only about my packaging work and about that I underestimated the demand for 3.5. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Regressions in Open Source projects ...
Hi Petr, all Please, do not take this that we do not take care about openSUSE/SUSE users. We do a lot of things for them. It is only about my packaging work and about that I underestimated the demand for 3.5. Actually I was talking about SUSE LibreOffice for Windows (which is apparently a one-off unsupported release created for the Intel AppUp store) :) Regards, Pedro ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] [REVIEW:3-5] fdo#46843 graphical query editor loses sorting order
Attached patch fixes fdo#46843, namely that the graphical query editor
loses the query's sorting order. (most annoying, severity critical)
Culprit:
commit 33b9b857ea6cb5a6f731de68f58e532242c43d30
Author: Ocke Janssen [oj] ocke.jans...@oracle.com
Date: Tue Jan 4 13:12:33 2011 +0100
dba34c: #i20306# support for window function and limit fetch first, ...
added
Which pushed the order by clause from fourth to fifth position in
table_exp rule of connectivity/source/parse/sqlbison.y
Please apply to libreoffice-3-5.
--
Lionel
From 80c235510aeb19d4df6a07be7499e70122313bbf Mon Sep 17 00:00:00 2001
From: Lionel Elie Mamane lio...@mamane.lu
Date: Thu, 15 Mar 2012 11:22:32 +0100
Subject: [PATCH] fdo#46843 look for order by clause as fifth child of
select_statement
Since commit 33b9b857ea6cb5a6f731de68f58e532242c43d30 (dba34c: #i20306# support for window function and limit fetch first, ... added), order by is the fifth child. It was the fourth one before.
---
dbaccess/source/ui/querydesign/QueryDesignView.cxx |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
index 397cedb..267c7a9 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
@@ -2319,10 +2319,9 @@ namespace
const ::connectivity::OSQLParseNode* pParseRoot )
{
SqlParseError eErrorCode = eOk;
-if (!pParseRoot-getChild(3)-getChild(4)-isLeaf())
+if (!pParseRoot-getChild(3)-getChild(ORDER_BY_CHILD_POS)-isLeaf())
{
-::connectivity::OSQLParseNode* pNode = pParseRoot-getChild(3)-getChild(4)-getChild(2);
+::connectivity::OSQLParseNode* pNode = pParseRoot-getChild(3)-getChild(ORDER_BY_CHILD_POS)-getChild(2);
::connectivity::OSQLParseNode* pParamRef = NULL;
OQueryController rController = static_castOQueryController(_pView-getController());
--
1.7.7.3
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
minutes of ESC call 2012-03-15 1500 UTC
Hi, here are the minutes for todays ESC call: attendees: Norbert, Eike, Rainer(?, seems to have dropped from the call), Kendy, Petr, Stephan, Lionell, Markus, Cedric, Caolan, Bjoern * Completed Action Items + Add GSOC tasks to the wiki: + fwd. Eike Svante's multi-user proposal (Thorsten) + layout / toolkit conversion task (Caolan) + bunch of ideas / slide-show re-work etc. (Thorsten) + take updated ESC composition to the board (Thorsten) * Pending Action Items + [still pending] extract 64bit build hardware from firewall (Kendy / Admins) + rename VCL API to make it GetBeamerFoo fix (Michael) + [ongoing] respond in the gerrit bug fdo#44498 with some rational (Bjoern) + Add GSOC tasks to the wiki: https://wiki.documentfoundation.org/Development/Gsoc/Ideas + [ongoing, ETA today] multi-user / telepathy / co-editing (Eike) + add graphical conditional formatting task (Kohei) + better template translation (Andras) + [ongoing?] post results of exception analysis shortly (Michael) + [ongoing?] cost and usefulness of exceptions proposal (Michael) * Action Items review + gerrit call minutes, please have a look (Bjoern) http://nabble.documentfoundation.org/minutes-of-gerrit-documentfoundation-org-call-2012-03-01-tc3813352.html * Release Engineering update (Petr) + 3.5.1 is out today, looking good + 3.5.2 code freeze on Monday + please provide patches RSN + reviewers greatly appreciated + 3.4.6 status + test build are available + on track for ~Wednesday + last 3.4 micro, it fits nicely that 3.5 is already in great shape * GSOC update (Cedric) + tomorrow candidates will learn about possible projects + please prettify task (code pointers etc.) + now is the time to get students involved + EasyHacks do _not_ have to be completed yet, but by application time + help possible students to get up to speed with build and EasyHacks * QA update (Rainer) + Rainer seems to have dropped from the call + still a short discussion on regressions and release plan + little optimism wrt to release plan changes being relevant to improve the regression situation, but open to concret proposals + there are three kinds of bugs: (Bjoern) + regression + bugs since the beginning of time + feature request + ... and bugs in new features (Lionell) + the last one is one we should have a closer look at + as for regressions, we should care about having them weighted by severity (Petr) = realistic data hygiene in bugzilla + first QA last Friday, please have a look at the minutes (Bjoern) http://nabble.documentfoundation.org/minutes-of-LibreOffice-QA-call-2012-03-09-15-00-UTC-tc3813349.html * ad-hoc topic: git submodules for non-core repos (Norbert) + sounds good to use a preexisting solution instead of homegrown tooling (Thorsten) + alternative: handle other repos like external libs/tarballs (like libwp*) + external lib solutions exist (oo.lst and friends) and is tested + binfilter is still updated quite regulary and would likely hurt by this (Stephan) + load/mirroring/latency issues with regular tarball updates (Petr) + so we really want submodules for binfilter and ext-lib for the rest, but without the duplicated work? (Bjoern) + another possibility would be to teach ./download to use git archive directly + still might cause quite some extra load + introduces explict git dependency in ./download, might or might not be an issue for packagers (Bjoern) * summer time, when will be the next call? (Norbert) + call is set in UTC and does not change without explicit notice (Bjoern) AA: + announce very loudly if the call changes slot in UTC timezone (Michael) + 17:00 local might be preferable to quite a few (Eike) AA: + is that 1700 CET or CEST? (1600UTC or 1500UTC) corrections and additions welcome. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call 2012-03-15 1500 UTC
On Thu, 2012-03-15 at 19:07 +0100, Bjoern Michaelsen wrote: + add graphical conditional formatting task (Kohei) This is already done as of last week. Please take this off the list. Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: development summary: year 2012, week 10
Hi, On Thu, Mar 15, 2012 at 05:24:14PM +0100, Petr Mladek wrote: this time a brief summary of what happened during the 10th week in 2012 on LibreOffice repositories and the living branches: I understand these mails were kind of useful when we still had a multi repository setup, but since onegit, I have the creeping suspicion they do not provide much added value. Since the dev-list is already very high volume, I propose to stop sending them at least to this list. Opinions? Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Regressions in Open Source projects ...
On Thu, Mar 15, 2012 at 05:04:44PM +0400, Ivan Timofeev wrote: Perhaps, if you mean the whole team. But note that there are some lunatic guys like me, who are interested in bug-fixing ~completely. ;) Take a good look at the last slide of: http://wiki.documentfoundation.org/Special:FilePath/TenReasonsContribute.odp We need lunatics like you ;) Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call 2012-03-15 1500 UTC
On Thu, Mar 15, 2012 at 02:24:51PM -0400, Kohei Yoshida wrote: On Thu, 2012-03-15 at 19:07 +0100, Bjoern Michaelsen wrote: + add graphical conditional formatting task (Kohei) This is already done as of last week. Please take this off the list. Sorry, was discussed accordingly, only slipped through for the minutes. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call 2012-03-15 1500 UTC
On Thu, 2012-03-15 at 19:51 +0100, Bjoern Michaelsen wrote: On Thu, Mar 15, 2012 at 02:24:51PM -0400, Kohei Yoshida wrote: On Thu, 2012-03-15 at 19:07 +0100, Bjoern Michaelsen wrote: + add graphical conditional formatting task (Kohei) This is already done as of last week. Please take this off the list. Sorry, was discussed accordingly, only slipped through for the minutes. Ah, no problem. :-) Best, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Regressions in Open Source projects ...
On 15.03.2012 20:23, Michael Meeks wrote: On Thu, 2012-03-15 at 17:04 +0400, Ivan Timofeev wrote: Perhaps, if you mean the whole team. But note that there are some lunatic guys like me, who are interested in bug-fixing ~completely. ;) Yep - you're a star ! :-) *timid smile* not a big one, but I am not alone on this stellar sky, certainly! Moreover, sky is infinite, everyone can find his place and shed light... :) Thanks Ivan ! Thanks to all guys delving into the bugzilla! Keep up your fantastic work! Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Regressions in Open Source projects ...
Pedro Lino píše v Čt 15. 03. 2012 v 17:40 +: Hi Petr, all Please, do not take this that we do not take care about openSUSE/SUSE users. We do a lot of things for them. It is only about my packaging work and about that I underestimated the demand for 3.5. Actually I was talking about SUSE LibreOffice for Windows (which is apparently a one-off unsupported release created for the Intel AppUp store) :) Ah this one. To be honest, I was not involved into this release because I work mostly on our Linux products. I am not sure how complicated is the process to get a software there. I guess that it is more complex that uploading on servers that are under control of the document foundation. So, I would expect a delay. :-) Also I am not familiar with this store and I am not sure what people are using it. Note that we clearly state that .0 release is for enthusiasts. More conservative users should wait for a later bugfix release. I guess that the App store is for more conservative users, so I would not expect .0 release there ;-) Heh, 3.5.0 was quite good in the end. Thank you and many other people for all the great work. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Volker Merschmann merschm...@gmail.com changed: What|Removed |Added Depends on||46509 --- Comment #231 from Volker Merschmann merschm...@gmail.com 2012-03-15 13:28:57 PDT --- Adding #46509 as the functionality of wiki export is completely broken -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
LibreOffice / openIndiana ...
Hello, As per the start of the thread by Michael, I too would like not to start form scratch and then try to assist with the port of LibreOffice, his initial comment: I was thrilled to read of your efforts trying to get LibreOffice going on OpenIndiana; it'd be great to get any patches you have back into the code As to Michael's comment about a preferred compiler: I'd suggest trying to build with gcc/g++ and fixing that I agree and would like to help work towards this choice for purely selfish reasons although I have SunPro availible I myself want to use gcc/g++ port since all illumos based operating systems (openindiana, smartos, illumian) will soon move to gcc/g++ as the primary compiler for the common kernel (illumos). Looking forward to someone sharing any notes or even untested patch sets. Cheers jon DOT strabala AT quantumsi DOT com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Can't compile from source, i18npool project segfaults with parallel build
I'm trying to build LibreOffce 3.5 and 3.5.1 from source, but build always failed with i18npool project. I'm using parallel build. Same build script compiles 3.4.5 and older versions. Tested with x86 and x86_64 machine. GCC 4.5.2. Making with -j1 in i18npool wokks, but automatic building whole suite with -j1 takes very long time. Can anybody confirm this? What additional information is needed? -- Без гнева и пристрастий. Без Windows и глюков. wbr, Eugene Mikhaylov ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] [ANN] LibreOffice 3.4.6 RC2 test builds available
Bjoern Michaelsen píše v St 14. 03. 2012 v 18:38 +0100: While being open to further concrete proposals for improvement, I dont think there is a fundamental flaw with the release concept itself. The quality of 3.5.0 and and 3.5.1 show that the number of regressions in 3.4 were a one-time outlier. We have to make sure it does not happen again, but I see no general flaw with our release model. We need to be sure to detect and pinpoint regressions earlier and more precise than in 3.4 -- and we have that with unittests, subsequenttests, onegit and bibisect -- all means that we were still missing in the 3.4 series. Those were the parts that needed changing and they are changed already. It doesnt end there though: With gerrit and the currently ongoing efforts in QA in addition to the tools named above, we are getting even better early warning and enable ourselves to quickly and confidently fix regressions. I agreed with everything that was said by Bjoern. I just want to add that we need to be realistic: 1. Every software contains bugs and regressions. See Every non trivial program has at least one bug at http://www.murphys-laws.com/murphy/murphy-computer.html 2. IMHO, nobody is able to fix all regressions because any fix potentially creates another regression. 3. Some regressions are not easy to fix because the new code is completely different. We always need to consider the seriousness of the regressions and the cost of the fix. 4. IMHO, we could not maintain too old code by volunteers. It is frustrating and very expensive. The code is evolving. People forget the old structures and functions, so they need to investigate a lot of stuff when they did into the history. Also the testing is expensive unless you do trivial changes and you are sure that it does not break anything. In the real word, it is done only by a company if a customers pays for it. 5. We need 3.4.6 because 3.5 is too young and we still might miss some regressions and nasty bugs. We review the fixes when backporting, so 3.4.6 should not need extensive testing. Some basic tests should be enough. You said that 3.4.6 would have been more or less useless for many users because of the regressions. I do not think so. LO-3.4 is being used by many users, so it is usable. Some users are conservative and do not want to risk 3.5 too early. 3.4.6 brings some very useful fixes for these people. We might change our mind and provide 3.4.7 if people report too many serious bugs in 3.5 and it takes longer time to make it usable. On the other hand, it seems that 3.5 is going to be better that 3.4. I do not see any reason to spend more time on this historic 3.4 code line right now. As described by Bjoern, we do a lot to improve the code, tools, and processes. LO-3.5 seems to be better than 3.4, so we seems to go the right direction. Best Regards, Petr ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [ANN] LibreOffice 3.4.6 RC2 test builds available
On Wed, 14 Mar 2012, Rainer Bielefeld wrote: Fridrich Strba schrieb: for 3.4.6 RC2, we're now uploading builds to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, we had exactly 0 reports for 3.4.6 RC1, and I doubt that anybody will do systematic tests with RC2 (I won't do either). I do systematic tests on every RC release, albeit very specific to my use-cases (python, UNO, filters/conversions) and with a limited set of documents. The fact that these releases can easily co-exist using RPM packages is priceless ! So it's hard to quantify what 0 reports means, no regressions or no user-testing ? We still have 45 unfixed regressions compared to 3.3, Lifecycle of 3.4 will end with 3.4.6(?), so this version is more or less useless for most (or at least very many) 3.3 or 3.4 users. Who would want to test a car when he knows that still 1 tire is flat and never will be repaired? Although 3 tires have been repaired, that car will be completely useless forever. It's my belief that we will have to rethink our release concept. Please excuse me that I can't tell anything more enthusiastic. If you want to improve a situation, the hard truth is better than a soft lie ;-) I wondered myself whether the split between 3.4, 3.5 and 3.6 is sustainable in the long run. At some point the cost of splitting the userbase is more expensive than the gains from fast release cycles. I would expect at that point we would more likely have a slower release cycle with a longer acceptance phase for QA/testing/regression fixing and less releases. -- -- dag wieers, d...@wieers.com, http://dag.wieers.com/ -- dagit linux solutions, i...@dagit.net, http://dagit.net/ [Any errors in spelling, tact or fact are transmission errors] ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [ANN] LibreOffice 3.4.6 RC2 test builds available
Dag Wieers schrieb: So it's hard to quantify what 0 reports means, no regressions or no user-testing ? https://bugs.freedesktop.org/buglist.cgi?query_format=advancedversion=LibO%203.4.6%20RC1product=LibreOffice CU Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Regressions in Open Source projects ...
Hi Michael, all I'm looking at another few Windows specific bugs that are of interest. Particularly with the new drmemory tool and Jesus' windows / debug builds - we should be able to progress here quickly. It'd be wonderful if we could get these traces for Windows specific bugs. I'm quite curious to test that on a 100% reproducible crash as soon as I find some time ;) Clearly that is true of some hypothetical user, for whom some serious regression blocks them from updating. It is not so hypothetical. I had to keep a Portable LibreOffice 3.3.4 copy around just to be able to open documents that included equations. And yes I know it was a docx only bug but I do need to exchange manuscript revisions with my co-authors and I haven't been able to convince them to drop Microsoft Office 2007... So this is a real life example for a single specific bug, as I'm sure there are many others ;) There is however an easy solution for them - pay to have their (apparently un-interesting to the community) bugs fixed: then they can have their regression-free release, supported indefinately and everyone is happy :-) This sounds like a pitch for users to switch to SUSE LibreOffice :P BTW the code optimizations under Windows are fantastic ;) But SUSE released version 3.4.2 while TDF is already at 3.5.1. Doesn't that show a little about the importance of stability? ;) As a straw-man (and I don't think anyone suggests this) - suggesting that we never ship until there are zero regressions would not meet this goal: we typically find regressions only after we ship. I'm not sure I understand the straw-man concept but no one in QA is advocating not to ship until zarro boogs are found... But we (at least I am) are asking to give higher priority to fixing regressions and crashers (even if they happen to only ONE user as long as it is reproducible) than to adding new features. This doesn't mean AT ALL to stop adding features. Just to change priorities ;) As a general conclusion I think we are all doing the best given the limited human resources and the scarcity of our most valuable resource: time! It is because we do CARE about this project that we complain about the short testing times AND the regressions ;) Regards, Pedro ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Regressions in Open Source projects ...
On 2012-03-15 14:31, Pedro Lino wrote: As a general conclusion I think we are all doing the best given the limited human resources and the scarcity of our most valuable resource: time! It is because we do CARE about this project that we complain about the short testing times AND the regressions ;) The problem is that open-source developers cannot be motivated to work 80% on bugs and 20% on features. If you need more reliability, then yes, perhaps SUSE LibreOffice is the right thing for you. That is the beauty of open-source, of course, you have choices :-) Disclaimer: http://www.peralex.com/disclaimer.html ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Regressions in Open Source projects ...
On Thu, 2012-03-15 at 17:04 +0400, Ivan Timofeev wrote: Perhaps, if you mean the whole team. But note that there are some lunatic guys like me, who are interested in bug-fixing ~completely. ;) Yep - you're a star ! :-) Thanks Ivan ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Regressions in Open Source projects ...
Pedro Lino píše v Čt 15. 03. 2012 v 12:31 +: But SUSE released version 3.4.2 while TDF is already at 3.5.1. Doesn't that show a little about the importance of stability? ;) We have had 3.4.4 in the LibreOffice:Stable project for a long time. I have just pushed there 3.4.5 which actually have all fixes from 3.4.6. We still do not have 3.5 packages for openSUSE because I spend most of my time on upstream release. I need few days to get working packages for this bigger update and I have only few hours every week. To be honest, I am surprised how good 3.5 is. I expected that people would prefer 3.4.6 over 3.5.1 and did not set my priorities well. Please, do not take this that we do not take care about openSUSE/SUSE users. We do a lot of things for them. It is only about my packaging work and about that I underestimated the demand for 3.5. Best Regards, Petr ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Regressions in Open Source projects ...
Hi Petr, all Please, do not take this that we do not take care about openSUSE/SUSE users. We do a lot of things for them. It is only about my packaging work and about that I underestimated the demand for 3.5. Actually I was talking about SUSE LibreOffice for Windows (which is apparently a one-off unsupported release created for the Intel AppUp store) :) Regards, Pedro ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] 3.5.1 Online Update testing
Hi Kendy, all Please, is here anybody who can check whether the 3.5.1 Online Update is working? How to test: - install 3.5.1 _RC1_ (for Windows, or other) - trigger Online Update from the Help menu - expe22Neo4j Community Discussions - [Neo4j] Database left in locked state when an exception is thrown during upgrimage/png, image/webp, image/jpeg, image/gif, image/x-xbitmap, */*;q=0.1 Accept-Language: en-GB,en;q=0.9 Accept-Encoding: gzip, deflate Referer: http://data.disneyduniya.in/Sheena-Confirms-For-Another-Season-of-Best-of-Luck-Nikki-td3403218.html Cookie: __utma=135888548.1005679711.13 -- View this message in context: http://nabble.documentfoundation.org/Libreoffice-qa-3-5-1-Online-Update-testing-tp3806470p3829520.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Regressions in Open Source projects ...
On Thu, Mar 15, 2012 at 05:04:44PM +0400, Ivan Timofeev wrote: Perhaps, if you mean the whole team. But note that there are some lunatic guys like me, who are interested in bug-fixing ~completely. ;) Take a good look at the last slide of: http://wiki.documentfoundation.org/Special:FilePath/TenReasonsContribute.odp We need lunatics like you ;) Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Regressions in Open Source projects ...
On 15.03.2012 20:23, Michael Meeks wrote: On Thu, 2012-03-15 at 17:04 +0400, Ivan Timofeev wrote: Perhaps, if you mean the whole team. But note that there are some lunatic guys like me, who are interested in bug-fixing ~completely. ;) Yep - you're a star ! :-) *timid smile* not a big one, but I am not alone on this stellar sky, certainly! Moreover, sky is infinite, everyone can find his place and shed light... :) Thanks Ivan ! Thanks to all guys delving into the bugzilla! Keep up your fantastic work! Ivan ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Regressions in Open Source projects ...
Pedro Lino píše v Čt 15. 03. 2012 v 17:40 +: Hi Petr, all Please, do not take this that we do not take care about openSUSE/SUSE users. We do a lot of things for them. It is only about my packaging work and about that I underestimated the demand for 3.5. Actually I was talking about SUSE LibreOffice for Windows (which is apparently a one-off unsupported release created for the Intel AppUp store) :) Ah this one. To be honest, I was not involved into this release because I work mostly on our Linux products. I am not sure how complicated is the process to get a software there. I guess that it is more complex that uploading on servers that are under control of the document foundation. So, I would expect a delay. :-) Also I am not familiar with this store and I am not sure what people are using it. Note that we clearly state that .0 release is for enthusiasts. More conservative users should wait for a later bugfix release. I guess that the App store is for more conservative users, so I would not expect .0 release there ;-) Heh, 3.5.0 was quite good in the end. Thank you and many other people for all the great work. Best Regards, Petr ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 33543] General error when opening .docx
https://bugs.freedesktop.org/show_bug.cgi?id=33543 --- Comment #8 from Peter Schmitt klauspeter.schm...@gmx.de 2012-03-14 23:44:54 PDT --- Created attachment 58469 -- https://bugs.freedesktop.org/attachment.cgi?id=58469 example which crashes in LibO3.5.0-WRITER on Win7pro-64bit -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33543] General error when opening .docx
https://bugs.freedesktop.org/show_bug.cgi?id=33543 Peter Schmitt klauspeter.schm...@gmx.de changed: What|Removed |Added Status|NEEDINFO|NEW CC||klauspeter.schm...@gmx.de Version|LibO 3.3.0 release |LibO 3.5.0 Release --- Comment #9 from Peter Schmitt klauspeter.schm...@gmx.de 2012-03-14 23:47:55 PDT --- I can confirm crashing when opening attached example docx: Hintergrund_Fluticasonfuroat_StandFebr2010.docx in WRITER LibO 3.5.0 on Windows 7 Pro 64 bit. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44445] VIEWING UI screen jump to other position when zooming in/out
https://bugs.freedesktop.org/show_bug.cgi?id=5 --- Comment #5 from Winfried Donkers o...@dci-electronics.nl 2012-03-15 00:03:57 PDT --- (In reply to comment #4) ... I can't see significant differences compared to 3.3.0 and Oo 3.1.1, do you agree with Version 3.3.0Beta2 - OOo heritage? Not sure if you (Rainer) mean me with 'you' in previous comment, but I agree - haven't changed the version, nor set the status to confirmed, I leave that to you (Rainer). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47334] New: LibreOffice Calc crashes when deleting a row
https://bugs.freedesktop.org/show_bug.cgi?id=47334 Bug #: 47334 Summary: LibreOffice Calc crashes when deleting a row Classification: Unclassified Product: LibreOffice Version: LibO 3.5.0 Release Platform: x86-64 (AMD64) OS/Version: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: lucm...@hotmail.com Created attachment 58472 -- https://bugs.freedesktop.org/attachment.cgi?id=58472 The file which makes Calc crash when removing a line Version: LibreOffice 3.5.0rc3 Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735 - Open the file attached (Compta-modèle.ods) - Select the sheet Journal - Select the row 3 - Right-click and select Delete Rows LibreOffice Calc crashes with the following message: Due to an unexpected error, LibreOffice crashed. All the files you were working on will now be saved. The next time LibreOffice is launched, your files will be recovered automatically. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44445] VIEWING UI screen jump to other position when zooming in/out
https://bugs.freedesktop.org/show_bug.cgi?id=5 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||cedric.bosdonnat.ooo@free.f ||r Version|LibO 3.4.4 release |LibO 3.3.0 Beta2 --- Comment #6 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-03-15 00:11:34 PDT --- Not sure if you (Rainer) mean me with 'you' You all ;-) Modify Version due to latest results and comments @Cédric: Please set Status to ASSIGNED and add yourself to Assigned To if you accept this Bug -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47335] New: [EDITING] Autocorrect for list numbering doesn't work with all numbering formats
https://bugs.freedesktop.org/show_bug.cgi?id=47335 Bug #: 47335 Summary: [EDITING] Autocorrect for list numbering doesn't work with all numbering formats Classification: Unclassified Product: LibreOffice Version: unspecified Platform: All OS/Version: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: pkt...@gmail.com E.g., 1. blablaenter becomes 1. blabla 2. but a. blablaenter doesn't become a. blabla b. Similar with almost all other numbering styles, they are seemingly not available for autocorrect. See also: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/833296 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43800] Add comment shortcut, Writer, local keyboard setting, results with special character
https://bugs.freedesktop.org/show_bug.cgi?id=43800 Winfried Donkers o...@dci-electronics.nl changed: What|Removed |Added CC||o...@dci-electronics.nl Summary|Add comment shortcut, |Add comment shortcut, |Writer, Polish, results |Writer, local keyboard |with Polish letter Ć |setting, results with ||special character --- Comment #1 from Winfried Donkers o...@dci-electronics.nl 2012-03-15 00:38:28 PDT --- version 3.5.0 on Windows with US keyboard and Dutch key-definition produces © when pressing Ctrl-Alt-C and no comment is inserted. I think this shortcut is not ideal for Windows O/S. (have changed the summary as the bug is not confined to Polish keyboard settings) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
