Re: [HELP] fdo#51239 how to debug "it is slow"

2012-07-19 Thread Noel Grandin
On 2012-07-19 14:38, Lionel Elie Mamane wrote: For example, to minimise the number of Java calls from C++ , maybe we could, when we retrieve a whole row through JDBC, doing this from Java code instead of from C++ code: for (i=0; i < row->getNumberOfColumns; ++i) cacheEntry[i]=row->getColumn

[Libreoffice-commits] .: sc/source

2012-07-19 Thread Julien Nabet
sc/source/ui/collab/contacts.cxx |2 +- sc/source/ui/collab/sendfunc.cxx |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit b37bcdded66ae82c5677fe60d8347b87281f3fa2 Author: Julien Nabet Date: Fri Jul 20 08:34:42 2012 +0200 Prefer prefix ++/-- operators f

Re: [PATCH] cleaning before = assignment lotuswordpro/source/filter/xfilter/xfparastyle.cxx

2012-07-19 Thread David Tardon
Hi, On Thu, Jul 19, 2012 at 02:03:39PM -0700, julien2412 wrote: > Thank you David for the hint! > I re read the "An in-depth explanation" part of > http://stackoverflow.com/questions/3279543/what-is-the-copy-and-swap-idiom/3279550#3279550, > it's great ! I understood when and above all how the mem

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-19 Thread Andrew Douglas Pitonyak
On 07/19/2012 11:58 AM, Markus Mohrhard wrote: Hey Eike, Kohei, 2012/7/19 Kohei Yoshida : On 07/19/2012 10:29 AM, Eike Rathke wrote: Hi, Please review and cherry-pick to 3-6 and 3-6-0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a that resol

[Libreoffice-commits] Changes to 'feature/gsoc-calc-perf2'

2012-07-19 Thread Kohei Yoshida
New branch 'feature/gsoc-calc-perf2' available with the following commits: commit eb00ef223ff39a8baebe7cefd7e37a2b013f9da3 Author: Daniel Bankston Date: Sat Jul 14 00:53:07 2012 -0500 Revert "Fix for ods matrix import performance" This reverts commit cb14c160489254298eb03f7406107e0

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - 0 commits -

2012-07-19 Thread Kohei Yoshida
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - sc/qa sc/source

2012-07-19 Thread Daniel Bankston
sc/qa/unit/data/contentCSV/matrix2.csv |1 + sc/qa/unit/data/ods/matrix.ods |binary sc/qa/unit/subsequent_filters-test.cxx | 11 ++- sc/source/filter/xml/xmlcelli.cxx | 24 +++- 4 files changed, 30 insertions(+), 6 deletions(-) New commits: commit

Re: Revert of hrc cleanup

2012-07-19 Thread Caolán McNamara
On Thu, 2012-07-19 at 23:05 +0200, Michael Stahl wrote: > since probably there's no good reason why loading resources may fail, > perhaps it would be a good idea to turn this one into an assert() that > aborts, so developers pay attention. Yeah, thought about doing this myself. Where I often see

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 51772, which changed state. Bug 51772 Summary: general I/O error when opening a RTF file https://bugs.freedesktop.org/show_bug.cgi?id=51772 What|Old Value |New Value -

[Libreoffice-commits] .: 2 commits - writerfilter/source

2012-07-19 Thread Caolán McNamara
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 135 ++ 1 file changed, 65 insertions(+), 70 deletions(-) New commits: commit 218ec3b0cadc5fa505cd8a39a53f2c5729d92265 Author: Caolán McNamara Date: Thu Jul 19 23:40:06 2012 +0100 catch consistently by const referen

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - 2 commits - sc/qa sc/source

2012-07-19 Thread Daniel Bankston
sc/qa/unit/data/contentCSV/matrix2.csv |1 + sc/qa/unit/data/ods/matrix.ods |binary sc/qa/unit/subsequent_filters-test.cxx | 11 ++- sc/source/filter/xml/xmlcelli.cxx | 24 +++- 4 files changed, 30 insertions(+), 6 deletions(-) New commits: commit

[Libreoffice-commits] .: basctl/source

2012-07-19 Thread Takeshi Abe
basctl/source/basicide/basicbox.cxx | 16 - basctl/source/basicide/basicbox.hxx |4 +- basctl/source/basicide/baside2.cxx | 50 +++ basctl/source/basicide/baside2.hxx | 38 +++ basctl/source/basicide/baside2b.cxx | 58 ++

Re: Gerrit for users without OpenId account -- was Re: gerrit via email

2012-07-19 Thread Terrence Enger
Thank you, David. This sounds neat. When (if?) I have another patch to submit, I shall check back to see if it is place. Terry. On Thu, 2012-07-19 at 23:02 +0200, David Ostrovsky wrote: about how it will be possible to use gerrit at the command line, authenticating by a shared key rather th

Re: Revert of hrc cleanup

2012-07-19 Thread Michael Stahl
On 19/07/12 21:29, Eike Rathke wrote: > Hi Thomas, > > On Wednesday, 2012-07-18 21:33:26 +0200, Thomas Arnhold wrote: >> Is there any way to get a real checkup what string and definitions >> are in use at all?! If not it would be safer to revert all of this >> cleanup. Even if that's very sad...

Re: [PATCH] cleaning before = assignment lotuswordpro/source/filter/xfilter/xfparastyle.cxx

2012-07-19 Thread julien2412
Thank you David for the hint! I re read the "An in-depth explanation" part of http://stackoverflow.com/questions/3279543/what-is-the-copy-and-swap-idiom/3279550#3279550, it's great ! I understood when and above all how the memory is cleaned. About your multidimalgorithm, what would be the problem

Gerrit for users without OpenId account -- was Re: gerrit via email

2012-07-19 Thread David Ostrovsky
Hi, On 19.07.2012 15:56, Terrence Enger wrote: Meanwhile, I note that Lionel asked me (back when our discussion was at the is-this-a-bug stage) to name him as reviewer when submitting the patch to gerrit. I hope the email facility will let people do that kind of thing. nice joke ;-) Or do you

tdf-infra IRC channel

2012-07-19 Thread Florian Effenberger
Hello, sorry for the crossposting, but I think that everyone in the Cc list might be interested. ;-) We have just set-up a channel called #tdf-infra. It's a public IRC channel at FreeNode, for anyone involved in website, wiki, mailing lists, gerrit and the like. In contrast to the private

[Libreoffice-commits] .: sc/source

2012-07-19 Thread Kohei Yoshida
sc/source/core/tool/scmatrix.cxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit 15929afc1a0da30ece4b193f4d2cf327886eb440 Author: Kohei Yoshida Date: Thu Jul 19 16:14:07 2012 -0400 Revert "Let's see if stripping the const here will fix the clang build..."

Re: [PUSHED 3-6 3-6-0] fdo#55241 updating of indexes is broken

2012-07-19 Thread Eike Rathke
Hi, On Thursday, 2012-07-19 20:13:49 +0200, Michael Stahl wrote: > On 19/07/12 14:52, Lubos Lunak wrote: > > On Thursday 19 of July 2012, David Tardon wrote: > >> On Thu, Jul 19, 2012 at 02:36:48PM +0200, Lubos Lunak wrote: > >>> On Thursday 19 of July 2012, David Tardon wrote: > > comm

[Libreoffice-commits] .: Branch 'libreoffice-3-6-0' - sw/source

2012-07-19 Thread Eike Rathke
sw/source/core/fields/authfld.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit a2267b5d7acc41cea094fe3b86d124540205446a Author: David Tardon Date: Thu Jul 19 14:00:55 2012 +0200 fdo#52241 remove just one entry Change-Id: Ida7920c3196105f7f8aab

[Libreoffice-commits] .: sc/source

2012-07-19 Thread Kohei Yoshida
sc/source/core/tool/scmatrix.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 52022b5f82385b28687bf46424d0d24be1964a4a Author: Kohei Yoshida Date: Thu Jul 19 15:49:44 2012 -0400 Let's see if stripping the const here will fix the clang build...

Re: Revert of hrc cleanup

2012-07-19 Thread Eike Rathke
Hi Thomas, On Wednesday, 2012-07-18 21:33:26 +0200, Thomas Arnhold wrote: > But that there are strings in use, which are never referenced in the > source or at compile time (so that the compiler would complain) is > some kind of strange. Or do I just not understand this?! Some values are used as

Re: Replacing ScMatrix's backend

2012-07-19 Thread Kohei Yoshida
On 07/16/2012 08:33 PM, Kohei Yoshida wrote: FYI, I'm working on replacing the backend implementation of ScMatrix to using a new container to achieve better performance. I won't go into the details (since that would be boring), but just to say that I'll be modifying heavily the implementation o

Re: git branch audit ...

2012-07-19 Thread Lionel Elie Mamane
On Thu, Jul 19, 2012 at 08:17:35PM +0200, Matúš Kukan wrote: > On 18 July 2012 21:09, Lionel Elie Mamane wrote: >> On Wed, Jul 18, 2012 at 05:51:44PM +0100, Michael Meeks wrote: >>> origin/features/base-preview >> Mine. Regularly updated. > I think you are re-creating it each time ? Yeah, be

[Libreoffice-commits] .: Branch 'feature/gbuild_extensions' - 0 commits -

2012-07-19 Thread Matus Kukan
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: git branch audit ...

2012-07-19 Thread Matúš Kukan
On 18 July 2012 21:09, Lionel Elie Mamane wrote: > On Wed, Jul 18, 2012 at 05:51:44PM +0100, Michael Meeks wrote: >> origin/features/base-preview > > Mine. Regularly updated. I think you are re-creating it each time ? Maybe you could fix typo and rename it next time when re-basing to feature/ba

Re: [REVIEW: 3-6 3-6-0] fdo#55241 updating of indexes is broken

2012-07-19 Thread Michael Stahl
On 19/07/12 14:52, Lubos Lunak wrote: > On Thursday 19 of July 2012, David Tardon wrote: >> On Thu, Jul 19, 2012 at 02:36:48PM +0200, Lubos Lunak wrote: >>> On Thursday 19 of July 2012, David Tardon wrote: Hi all, commit 859018061956b1937c7be3809a9858cbd610fa9c fixes yet another STL

Re: mdds to be updated to 0.6.0

2012-07-19 Thread Kohei Yoshida
On 07/19/2012 11:13 AM, Kohei Yoshida wrote: I'll let you guys know when the work finishes. Done. Pushed to master. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freede

[Libreoffice-commits] .: mdds/makefile.mk mdds/mdds_0.5.3.patch mdds/mdds_0.6.0.patch ooo.lst.in

2012-07-19 Thread Kohei Yoshida
mdds/makefile.mk |6 ++-- mdds/mdds_0.5.3.patch | 62 -- mdds/mdds_0.6.0.patch | 54 +++ ooo.lst.in|2 - 4 files changed, 58 insertions(+), 66 deletions(-) New commits: commit e5e5

[GSOC-UPDATE](19.07) Impress Remote

2012-07-19 Thread Andrzej J. R. Hunt
Hi everyone, I made some good progress today: - Finally found and fixed the cause of segfaults in the Transmitter (thanks to Valgrind). - Fixed some problems with the Listener lifecycle. - Fixed the listening loop in the Server to properly exit when the connection is closed. - Fixed listener

[REVIEW-3-6-0] updated tango artwork ...

2012-07-19 Thread Michael Meeks
Hi there, I just reviewed and merged Astron's nice artwork update to -3-6-0 - it all looks good to me, though the sendmail icon is a tad cute :-) It'd be great to get another 2x sign-offs so we can get that into 3.6.0: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreo

Re: minutes of ESC call ...

2012-07-19 Thread Bjoern Michaelsen
Hi, On Thu, Jul 19, 2012 at 04:50:28PM +0100, Michael Meeks wrote: > * gerrit update (Bjoern) > + syadmin team for gerrit have an alias: > ger...@otrs.documentfoundation.org > please use sparingly for agreed issues or > service outages. > + OTRS being deplo

[Libreoffice-commits] .: Branch 'feature/tubes' - 0 commits -

2012-07-19 Thread Eike Rathke
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/remote' - 2 commits - android/sdremote sd/Library_sd.mk sd/source

2012-07-19 Thread Andrzej J.R. Hunt
android/sdremote/src/org/libreoffice/impressremote/TestClient.java |2 sd/Library_sd.mk |1 sd/source/ui/inc/Server.hxx|2 sd/source/ui/remotecontrol/Listener.cxx|

[Libreoffice-commits] .: Branch 'feature/tubes2' - 0 commits -

2012-07-19 Thread Eike Rathke
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/unitymenus' - framework/source vcl/inc vcl/source

2012-07-19 Thread Antonio Fernandez
framework/source/uielement/menubarmanager.cxx |5 +++ framework/source/uielement/menubarwrapper.cxx |4 +++ vcl/inc/vcl/menu.hxx |4 +++ vcl/source/window/menu.cxx| 33 ++ 4 files changed, 45 insertions(+), 1 deleti

[REVIEW 3-6, 3-6-0] resolved fdo#52205 do not force all text cells in CSV import

2012-07-19 Thread Eike Rathke
Hi, Please review and cherry-pick to 3-6 and 3-6-0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7dbc768a71ccfb567e3b2979e57d0d1318977cf that fixes https://bugs.freedesktop.org/show_bug.cgi?id=52205 Thanks Eike -- LibreOffice Calc developer. Number formatter stricken i18n transposi

Re: C++11 in LibreOffice

2012-07-19 Thread Yi Ding
+1 on considering startup performance/memory usage. It looks like with Office 13 Microsoft has done more work in getting Office to startup faster (no benchmarks, just anecdotal experience). +1 on the ability to do some kind of cross-compiling solution in parallel. +1 on gigabyte spreadsheets of

[Libreoffice-commits] .: sc/source

2012-07-19 Thread Eike Rathke
sc/source/ui/docshell/impex.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b7dbc768a71ccfb567e3b2979e57d0d1318977cf Author: Eike Rathke Date: Thu Jul 19 18:10:49 2012 +0200 resolved fdo#52205 do not force all text cells in CSV import Do not set S

Re: [HELP] fdo#51239 how to debug "it is slow"

2012-07-19 Thread Lionel Elie Mamane
On Thu, Jul 19, 2012 at 05:03:32PM +0100, Michael Meeks wrote: > On Thu, 2012-07-19 at 15:47 +0200, Lionel Elie Mamane wrote: >> I'm fond of my trampoline idea, but 't would have to be done in a >> clean way; not sure yet how. > Heh ;-) I'm still holding my breath for the end-of-problem Fir

Re: minutes of ESC call ...

2012-07-19 Thread Caolán McNamara
On Thu, 2012-07-19 at 16:50 +0100, Michael Meeks wrote: > AI: + review updated license / dos (Caolan, Bjoern) Looked ok to me, I then miscounted the reviews and pushed this to 3-6-0 (*shrug*) C. ___ LibreOffice mailing list LibreOffice@lists.freedesk

Re: minutes of ESC call ...

2012-07-19 Thread Noel Grandin
On Thu, Jul 19, 2012 at 5:50 PM, Michael Meeks wrote: > > * 4.0 - when to call it that ? (Kendy) > + http://wiki.documentfoundation.org/Development/LibreOffice4 > + too much to do in one six-month section IMNSHO, most of the stuff on that page can be accomplished i

Re: minutes of ESC call ...

2012-07-19 Thread David Tardon
Hi, On Thu, Jul 19, 2012 at 04:50:28PM +0100, Michael Meeks wrote: > * cppunit / build issues (Stephan/Moggi/Michael) > + indifferent about --disable-xmlsec > + only intended for iOS / Android currently, should > not be used on Linux. > + configure

[PUSHED-3-6-0] Branding & Splash screen fix

2012-07-19 Thread Michael Meeks
On Tue, 2012-07-17 at 17:12 +0200, Thorsten Behrens wrote: > Stefan Knorr (Astron) wrote: > > Edited subject accordingly. Please review for 3.6.0. Thanks! > > This has my approval for 3-6-0. Thanks a lot Astron for fixing this! As agreed in the ESC, I gave it a last review & pushed it :-)

[Libreoffice-commits] .: Branch 'libreoffice-3-6-0' - 2 commits - icon-themes/galaxy instsetoo_native/util

2012-07-19 Thread Michael Meeks
icon-themes/galaxy/brand/flat_logo.svg | 103 icon-themes/galaxy/brand/intro.png |binary icon-themes/galaxy/brand/shell/backing_left.png |binary icon-themes/galaxy/brand/shell/backing_rtl_left.png |binary icon-themes/galaxy/brand_dev/intro

Change in core[libreoffice-3-6]: fdo#52066 fix RTF import of rectangle shape without text in ...

2012-07-19 Thread Gerrit
>From Miklos Vajna : Miklos Vajna has abandoned this change. Change subject: fdo#52066 fix RTF import of rectangle shape without text in it .. Patch Set 1: Abandoned 17:56 <@llunak> vmiklos: I have backported your https://ger

Re: [HELP] fdo#51239 how to debug "it is slow"

2012-07-19 Thread Stephan Bergmann
On 07/19/2012 06:03 PM, Michael Meeks wrote: On Thu, 2012-07-19 at 15:47 +0200, Lionel Elie Mamane wrote: I'm fond of my trampoline idea, but 't would have to be done in a clean way; not sure yet how. Heh ;-) I'm still holding my breath for the end-of-problem Firebird solution myself .

Re: [HELP] fdo#51239 how to debug "it is slow"

2012-07-19 Thread Michael Meeks
On Thu, 2012-07-19 at 15:47 +0200, Lionel Elie Mamane wrote: > I'm fond of my trampoline idea, but 't would have to be done in a > clean way; not sure yet how. Heh ;-) I'm still holding my breath for the end-of-problem Firebird solution myself ... I wonder if there are some silli

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 3 commits - sw/source writerfilter/source

2012-07-19 Thread Lubos Lunak
sw/source/filter/ww8/rtfattributeoutput.cxx | 10 -- sw/source/filter/ww8/rtfattributeoutput.hxx |5 + sw/source/filter/ww8/rtfexport.cxx|4 +++- writerfilter/source/dmapper/DomainMapper_Impl.cxx |3 ++- writerfilter/source/rtftok/rtfdocumentim

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-19 Thread Markus Mohrhard
Hey Eike, Kohei, 2012/7/19 Kohei Yoshida : > On 07/19/2012 10:29 AM, Eike Rathke wrote: >> >> Hi, >> >> Please review and cherry-pick to 3-6 and 3-6-0 >> >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a >> that resolves https://bugs.freedesktop.or

Re: [Libreoffice-qa] minutes of ESC call ...

2012-07-19 Thread Norbert Thiebaud
On Thu, Jul 19, 2012 at 10:50 AM, Michael Meeks wrote: > * Pending Action Items > + notify all committers when we have a nice simple, minimal > statement of what is required for gerrit written (Bjoern) Done ___ LibreOffice mailing list

minutes of ESC call ...

2012-07-19 Thread Michael Meeks
* Present: Norbert, Stephan, Eike, David T, Lionel, Markus, Kendy, Bjoern, Caolan, Andras, Michael M, Fridrich, Michael S, Rainer, Astron, Tibbylickle * Completed Action Items + fix CC-By-SA licensing requirements (Andras) + Mango icons - in gerrit pending r

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - writerfilter/source

2012-07-19 Thread Lubos Lunak
writerfilter/source/rtftok/rtfdocumentimpl.cxx |4 +++- writerfilter/source/rtftok/rtfdocumentimpl.hxx |2 +- writerfilter/source/rtftok/rtfsdrimport.cxx| 10 ++ 3 files changed, 10 insertions(+), 6 deletions(-) New commits: commit 0c1de6d3d6320f91770967d1b23c8dd57d168fe7 Au

Re: C++11 in LibreOffice

2012-07-19 Thread Michael Meeks
On Thu, 2012-07-19 at 16:04 +0200, Michael Stahl wrote: > i'm saying it doesn't benefit from the "sophisticated" optimizations that > vendor compilers like SunStudio or Intel do that speed up your BLAS > stuff with gigabytes of floating point arrays by X times because office > suites don't contain

mdds to be updated to 0.6.0

2012-07-19 Thread Kohei Yoshida
Hi folks, Just FYI that I'll be working to update mdds to 0.6.0 today (on master). This means that, if you pull and do an incremental build sometime today, it may fail in mdds if the timing is bad. If it does, please re-run configure and do a clean build again. I'll let you guys know when

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-19 Thread Kohei Yoshida
On 07/19/2012 10:29 AM, Eike Rathke wrote: Hi, Please review and cherry-pick to 3-6 and 3-6-0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a that resolves https://bugs.freedesktop.org/show_bug.cgi?id=50345 to accept empty string and strings conta

[REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-19 Thread Eike Rathke
Hi, Please review and cherry-pick to 3-6 and 3-6-0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a that resolves https://bugs.freedesktop.org/show_bug.cgi?id=50345 to accept empty string and strings containing only blanks as an argument converted to

[Libreoffice-commits] .: xmloff/source

2012-07-19 Thread Radek Doulík
xmloff/source/draw/shapeexport4.cxx | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) New commits: commit 6928759a89fdc29391e85cf31f48ef6ac5ee6fa1 Author: Radek Doulik Date: Thu Jul 19 16:06:52 2012 +0200 odf: export old path without unsupported commands in d

Re: C++11 in LibreOffice

2012-07-19 Thread Michael Stahl
On 19/07/12 14:59, Kohei Yoshida wrote: > On Thu, Jul 19, 2012 at 7:45 AM, Michael Stahl wrote: > >> i don't believe an office suite will benefit all that much from >> sophisticated compiler optimizations; > > It's certainly your opinion. But I tend think that, any binary > generated from a comp

Re: C++11 in LibreOffice

2012-07-19 Thread Kohei Yoshida
On 07/19/2012 09:49 AM, Bjoern Michaelsen wrote: On Thu, Jul 19, 2012 at 08:59:34AM -0400, Kohei Yoshida wrote: On Thu, Jul 19, 2012 at 7:45 AM, Michael Stahl wrote: i don't believe an office suite will benefit all that much from sophisticated compiler optimizations; It's certainly your opi

Re: gerrit via email

2012-07-19 Thread Terrence Enger
On Thu, 2012-07-19 at 14:25 +0200, Bjoern Michaelsen wrote: > Hi Terrence, > > On Thu, Jul 19, 2012 at 07:51:58AM -0400, Terrence Enger wrote: [Snip an explanation that I was trying to use a feature that is not implemented yet.] That's okay by me. [Snip lots more.] > Anyway: One step after the

Re: C++11 in LibreOffice

2012-07-19 Thread Bjoern Michaelsen
On Thu, Jul 19, 2012 at 08:59:34AM -0400, Kohei Yoshida wrote: > On Thu, Jul 19, 2012 at 7:45 AM, Michael Stahl wrote: > > > i don't believe an office suite will benefit all that much from > > sophisticated compiler optimizations; > > It's certainly your opinion. But I tend think that, any binar

Re: [HELP] fdo#51239 how to debug "it is slow"

2012-07-19 Thread Lionel Elie Mamane
On Thu, Jul 19, 2012 at 02:53:35PM +0200, Stephan Bergmann wrote: > On 07/19/2012 02:38 PM, Lionel Elie Mamane wrote: >> On Thu, Jul 19, 2012 at 02:12:30PM +0200, Stephan Bergmann wrote: >>> On 07/18/2012 10:06 AM, Lionel Elie Mamane wrote: >>> I noticed that there are truckloads of calls to >>> m

Re: git branch audit ...

2012-07-19 Thread Norbert Thiebaud
On Wed, Jul 18, 2012 at 11:51 AM, Michael Meeks wrote: > origin/feature/accfixes2 acc2 cws... not to be merged any time soon... but still keeping it around would not hurt > origin/feature/coretext I've been doing some coretext support work in there.. but I have merged most of it I think...

Re: What is bibisect? And what is it doing in my office?

2012-07-19 Thread Michael Stahl
On 19/07/12 14:50, Norbert Thiebaud wrote: > On Thu, Jul 19, 2012 at 4:14 AM, Stephan Bergmann wrote: >> "make dev-install" works well on Mac anyway, or what am I missing? > > It does indeed... I got thrown-off by the ominous "FIXME: linkoo > currently does not work on Mac OS X" message at the

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Michael Meeks changed: What|Removed |Added Depends on||51772, 51252 --- Comment #46 from Michae

[Libreoffice-commits] .: sw/qa sw/source

2012-07-19 Thread Caolán McNamara
sw/qa/core/swdoc-test.cxx | 37 - sw/source/core/txtnode/txtedt.cxx |5 + 2 files changed, 41 insertions(+), 1 deletion(-) New commits: commit 3442913accc4e44c3a1ac69a990edee15117948e Author: Caolán McNamara Date: Thu Jul 19 13:50:21 2012

Re: C++11 in LibreOffice

2012-07-19 Thread Kohei Yoshida
On Thu, Jul 19, 2012 at 7:45 AM, Michael Stahl wrote: > i don't believe an office suite will benefit all that much from > sophisticated compiler optimizations; It's certainly your opinion. But I tend think that, any binary generated from a compiler could use the benefit of compiler optimization.

Re: [HELP] fdo#51239 how to debug "it is slow"

2012-07-19 Thread Stephan Bergmann
On 07/19/2012 02:38 PM, Lionel Elie Mamane wrote: On Thu, Jul 19, 2012 at 02:12:30PM +0200, Stephan Bergmann wrote: On 07/18/2012 10:06 AM, Lionel Elie Mamane wrote: The issue *originally* reported in fdo#51239, which has been bumped to fdo#52170: in LibreOffice 3.5.2, much slower than "before"

Re: [REVIEW: 3-6 3-6-0] fdo#55241 updating of indexes is broken

2012-07-19 Thread Lubos Lunak
On Thursday 19 of July 2012, David Tardon wrote: > On Thu, Jul 19, 2012 at 02:36:48PM +0200, Lubos Lunak wrote: > > On Thursday 19 of July 2012, David Tardon wrote: > > > Hi all, > > > > > > commit 859018061956b1937c7be3809a9858cbd610fa9c fixes yet another STL > > > conversion bug > > > > +1 > > >

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2012-07-19 Thread Lubos Lunak
sw/source/core/fields/authfld.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit 48d61f4ad1eb4f8a031e65c3fcbebc5023d600e9 Author: David Tardon Date: Thu Jul 19 14:00:55 2012 +0200 fdo#52241 remove just one entry Change-Id: Ida7920c3196105f7f8aab

Re: What is bibisect? And what is it doing in my office?

2012-07-19 Thread Norbert Thiebaud
On Thu, Jul 19, 2012 at 4:14 AM, Stephan Bergmann wrote: > On 07/19/2012 11:09 AM, Norbert Thiebaud wrote: >> >> On Thu, Jul 19, 2012 at 4:02 AM, Michael Stahl wrote: >>> >>> on Windows with MSVC make dev-install has been working for several >>> _days_ now on master (though it is quite slow), and

Re: [REVIEW: 3-6 3-6-0] fdo#55241 updating of indexes is broken

2012-07-19 Thread David Tardon
On Thu, Jul 19, 2012 at 02:36:48PM +0200, Lubos Lunak wrote: > On Thursday 19 of July 2012, David Tardon wrote: > > Hi all, > > > > commit 859018061956b1937c7be3809a9858cbd610fa9c fixes yet another STL > > conversion bug > > +1 > > But I have no idea to which branch you have already committed t

[Libreoffice-commits] .: oowintool

2012-07-19 Thread Norbert Thiebaud
oowintool | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) New commits: commit 238eba337cedda17a9ed1ce7e91755c66446195a Author: Norbert Thiebaud Date: Thu Jul 19 07:38:31 2012 -0500 make the vc2010 redist optional Change-Id: Ib81f168fa65d7a4affb15c

Re: [HELP] fdo#51239 how to debug "it is slow"

2012-07-19 Thread Lionel Elie Mamane
On Thu, Jul 19, 2012 at 02:12:30PM +0200, Stephan Bergmann wrote: > On 07/18/2012 10:06 AM, Lionel Elie Mamane wrote: >> The issue *originally* reported in fdo#51239, which has been bumped to >> fdo#52170: in LibreOffice 3.5.2, much slower than "before", on >> GNU/Linux, but NOT on Windows. Unknow

Re: [REVIEW: 3-6-0] fdo#55241 updating of indexes is broken

2012-07-19 Thread Lubos Lunak
On Thursday 19 of July 2012, David Tardon wrote: > Hi all, > > commit 859018061956b1937c7be3809a9858cbd610fa9c fixes yet another STL > conversion bug +1 But I have no idea to which branch you have already committed this (git branch --contains doesn't list anything), so I haven't done anything

Re: [ONGERRIT] leaked ODBC statement handles

2012-07-19 Thread Michael Meeks
On Thu, 2012-07-19 at 07:18 -0400, Terrence Enger wrote: > Again, thank you for all the help you have given me along the way to > this small code contribution. Hey ! this really helps - it's really great to have people tackling bugs - there are really plenty to go around :-) Than

Re: gerrit via email

2012-07-19 Thread Bjoern Michaelsen
Hi Terrence, On Thu, Jul 19, 2012 at 07:51:58AM -0400, Terrence Enger wrote: > Despite checking the open patches on gerrit occasionally thereafter, I > never caught it showing my patch. Lionel Elie Mamane has already > applied the patch, but he may have worked from my email rather than > gerrit.

[REVIEW: 3-6-0] fdo#55241 updating of indexes is broken

2012-07-19 Thread David Tardon
Hi all, commit 859018061956b1937c7be3809a9858cbd610fa9c fixes yet another STL conversion bug (no offense meant, Noel--your work is much appreciated). As a side note: I have to admire the ingenuity of authors of the TOX implementation in Writer, whose glorious idea to define virtual operator== and

Re: [HELP] fdo#51239 how to debug "it is slow"

2012-07-19 Thread Stephan Bergmann
On 07/18/2012 10:06 AM, Lionel Elie Mamane wrote: The issue *originally* reported in fdo#51239, which has been bumped to fdo#52170: in LibreOffice 3.5.2, much slower than "before", on GNU/Linux, but NOT on Windows. Unknown on Mac. Not entirely clear what "before" it is. *This* issue *could* be JV

[Libreoffice-commits] .: sw/source

2012-07-19 Thread David Tardon
sw/source/core/fields/authfld.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit 859018061956b1937c7be3809a9858cbd610fa9c Author: David Tardon Date: Thu Jul 19 14:00:55 2012 +0200 fdo#52241 remove just one entry Change-Id: Ida7920c3196105f7f8aab

gerrit via email

2012-07-19 Thread Terrence Enger
Not being registered with gerrit (because I lack OpenId), I recently tried to submit a patch via email. Despite checking the open patches on gerrit occasionally thereafter, I never caught it showing my patch. Lionel Elie Ma

Re: C++11 in LibreOffice

2012-07-19 Thread Michael Stahl
On 17/07/12 21:21, Kohei Yoshida wrote: > On 07/17/2012 05:11 AM, Lubos Lunak wrote: >> So, as long as we require to build LO with MSVC, we can revisit the >> question >> of hard-depending on C++11 in, uhm, let's be optimistic and say 3 years. IOW, >> we can probably get there faster by ditching

Re: Why does svtools::EditBrowseBox::IsCursorMoveAllowed paint?

2012-07-19 Thread Michael Meeks
Hi Lionel, On Wed, 2012-07-18 at 19:48 +0200, Lionel Elie Mamane wrote: > Has anybody any clue why svtools::EditBrowseBox::IsCursorMoveAllowed > needs to call rWindow.Paint()? It causes some pretty stupid behaviour > in base, namely: Nope - it looks rather crazy to me. As a general rule -

Re: [ONGERRIT] leaked ODBC statement handles

2012-07-19 Thread Terrence Enger
On Thu, 2012-07-19 at 12:43 +0200, Lionel Elie Mamane wrote: > On Wed, Jul 18, 2012 at 03:09:55PM -0400, Terrence Enger wrote: > > Patch attached. I think it as we discussed. > > Thanks. Applied & pushed to master. > > I split your patch into three commits: > > - avoid freeing the NULL handle

[Libreoffice-commits] .: Branch 'feature/remote' - sd/source

2012-07-19 Thread Andrzej J.R. Hunt
sd/source/ui/inc/Server.hxx|1 sd/source/ui/remotecontrol/Listener.cxx| 43 ++--- sd/source/ui/remotecontrol/Listener.hxx|7 ++- sd/source/ui/remotecontrol/Server.cxx | 12 +++--- sd/source/ui/remotecontrol/Transmitter.cxx | 57 --

Re: [PUSHED:3-5] broken build

2012-07-19 Thread Stephan Bergmann
On 07/19/2012 12:59 PM, Lionel Elie Mamane wrote: Recent commit to libreoffice-3-5 breaks the build, because of API difference between OUString and String. Patch attached. Please apply. Already seen pushed as 37d4c94d5e2dc0541ee31a0b660425d81a766f8a. Stephan __

[REVIEW:3-5] broken build

2012-07-19 Thread Lionel Elie Mamane
Hi, Recent commit to libreoffice-3-5 breaks the build, because of API difference between OUString and String. Patch attached. Please apply. -- Lionel >From b9cc9f9dbfc2af7ec1f9c971c345860e11c57c98 Mon Sep 17 00:00:00 2001 From: Lionel Elie Mamane Date: Thu, 19 Jul 2012 12:56:39 +0200 Subject:

Re: git branch audit ...

2012-07-19 Thread Markus Mohrhard
Hey, > origin/feature/cell-format-data-bar > origin/feature/cell-notes both obsolete now. > origin/feature/chart_errorbars Have to look at that one again. > origin/feature/gsoc_test_improvements > origin/feature/gsoc_test_improvements2 > origin/feature/gsoc_test_improvements3 Art

[Libreoffice-commits] .: configure.in

2012-07-19 Thread Stephan Bergmann
configure.in |3 +++ 1 file changed, 3 insertions(+) New commits: commit 85b35ac289f661f64c145deaf419f61f5d4c Author: Stephan Bergmann Date: Thu Jul 19 12:43:58 2012 +0200 Detect failing Clang with GCC 4.7 headers and --std=gnu++0x scenarios Change-Id: I6caa48a428ac7fef23

Re: [ONGERRIT] leaked ODBC statement handles

2012-07-19 Thread Lionel Elie Mamane
On Wed, Jul 18, 2012 at 03:09:55PM -0400, Terrence Enger wrote: > Patch attached. I think it as we discussed. Thanks. Applied & pushed to master. I split your patch into three commits: - avoid freeing the NULL handle - ODBMetaDataRS ctor: abort if statement handle allocation failed - stop

[PATCH] Change in core[libreoffice-3-5]: fdo#38056: ODF import: fix page style attributes:

2012-07-19 Thread Gerrit
>From Michael Stahl : Michael Stahl has uploaded a new change for review. Change subject: fdo#38056: ODF import: fix page style attributes: .. fdo#38056: ODF import: fix page style attributes: PageMasterImportPropMapper: in the

[PATCH] Change in core[libreoffice-3-6]: fdo#38056: ODF import: fix page style attributes:

2012-07-19 Thread Gerrit
>From Michael Stahl : Michael Stahl has uploaded a new change for review. Change subject: fdo#38056: ODF import: fix page style attributes: .. fdo#38056: ODF import: fix page style attributes: PageMasterImportPropMapper: in the

Re: git branch audit ...

2012-07-19 Thread Caolán McNamara
On Wed, 2012-07-18 at 17:51 +0100, Michael Meeks wrote: > origin/feature/cmclayouttrans A work in progress, to munge translating .ui files into our localization mechanism. Extraction of translatables done, re-insertion still a to-do :-) C. ___ Libre

[Libreoffice-commits] .: xmloff/source

2012-07-19 Thread Michael Stahl
xmloff/source/style/PageMasterImportPropMapper.cxx | 51 + 1 file changed, 51 insertions(+) New commits: commit 7f9928bfa561ccb6ed4e2baacc7d6960bc1ce231 Author: Michael Stahl Date: Thu Jul 19 12:12:14 2012 +0200 fdo#38056: ODF import: fix page style attributes:

Re: LibreOffice & OWA

2012-07-19 Thread Jacqueline Rahemipour
Hi, Am 19.06.2012 13:17, schrieb Michael Meeks: On Tue, 2012-06-19 at 11:26 +0200, Italo Vignoli wrote: (...) So - we need to try to reduce those differences incrementally, starting with just re-zipping the LibreOffice document: is there a container problem ? if not, then re-orderin

[Libreoffice-commits] .: drawinglayer/source

2012-07-19 Thread Stephan Bergmann
drawinglayer/source/dumper/EnhancedShapeDumper.cxx |6 +++--- drawinglayer/source/dumper/XShapeDumper.cxx| 14 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) New commits: commit 042686d3ead3ed9aa1e70460c25d471c380b177b Author: Stephan Bergmann Date: Thu Jul 19

Re: git branch audit ...

2012-07-19 Thread Stefan Knorr (Astron)
Hi Michael, all, these two branches can probably go too: origin/feature/line-numbers-in-basicIDE – merged some time before 3.5 origin/feature/masterpages – merged into 3.6 I am not 100% sure about this one, but I think it's merged too: origin/feature/cell-format-data-bar – Markus's colour scal

Re: Patching our gerrit instance [was Re: [ANN] Please use Gerrit from now on for Patch Review]

2012-07-19 Thread Bjoern Michaelsen
Hi, On Wed, Jul 18, 2012 at 07:11:53PM +0200, Jan Holesovsky wrote: > Luckily, the Qt guys apparently had the same problem, and > have a solution (the entire diff on one page, without abandoning the > inline commenting): > > http://qt.gitorious.org/qtqa/gerrit/commit/737400d1bad4fa8bfd39cb326636a

[Libreoffice-commits] .: 3 commits - connectivity/source

2012-07-19 Thread Lionel Elie Mamane
connectivity/source/drivers/odbcbase/OConnection.cxx|3 + connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx | 22 ++ connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx |3 - 3 files changed, 9 insertions(+), 19 deletions(-) New

  1   2   >