[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sysui/desktop
sysui/desktop/menus/base.desktop|1 + sysui/desktop/menus/calc.desktop|1 + sysui/desktop/menus/draw.desktop|1 + sysui/desktop/menus/impress.desktop |1 + sysui/desktop/menus/math.desktop|1 + sysui/desktop/menus/writer.desktop |1 + 6 files changed, 6 insertions(+) New commits: commit 90524e0f8c6c7a8e6e5e8c0bc48afc2025336e63 Author: Marco Biscaro marcobiscaro2...@gmail.com Date: Sun Aug 26 21:32:41 2012 -0300 fdo#47157 adding Keywords to .desktop files Adding Keywords to .desktop files, following the suggestions in https://bugs.freedesktop.org/show_bug.cgi?id=47157#c0 Change-Id: Ic2a1428aaa12bc31b0af8488d166f78d5a970a1d Reviewed-on: https://gerrit.libreoffice.org/490 Reviewed-by: Björn Michaelsen bjoern.michael...@canonical.com Tested-by: Björn Michaelsen bjoern.michael...@canonical.com (cherry picked from commit 9d844ce3f8e411bfb4237372b1a6d4aec21a0a65) Signed-off-by: David Tardon dtar...@redhat.com diff --git a/sysui/desktop/menus/base.desktop b/sysui/desktop/menus/base.desktop index 72cf467..578e5c7 100755 --- a/sysui/desktop/menus/base.desktop +++ b/sysui/desktop/menus/base.desktop @@ -9,6 +9,7 @@ MimeType=application/vnd.oasis.opendocument.database;application/vnd.sun.xml.bas Name=%PRODUCTNAME Base GenericName=Database Development Comment=Manage databases, create queries and reports to track and manage your information by using Base. +Keywords=Data;SQL; InitialPreference=5 X-Ayatana-Desktop-Shortcuts=X-New [X-New Shortcut Group] diff --git a/sysui/desktop/menus/calc.desktop b/sysui/desktop/menus/calc.desktop index e9f3250..638b9e2 100755 --- a/sysui/desktop/menus/calc.desktop +++ b/sysui/desktop/menus/calc.desktop @@ -9,6 +9,7 @@ MimeType=application/vnd.oasis.opendocument.spreadsheet;application/vnd.oasis.op Name=%PRODUCTNAME Calc GenericName=Spreadsheet Comment=Perform calculations, analyze information and manage lists in spreadsheets by using Calc. +Keywords=Accounting;Stats;Chart;ods;xls;xlsx; InitialPreference=5 X-Ayatana-Desktop-Shortcuts=X-New [X-New Shortcut Group] diff --git a/sysui/desktop/menus/draw.desktop b/sysui/desktop/menus/draw.desktop index 9511fd5..6d92845 100755 --- a/sysui/desktop/menus/draw.desktop +++ b/sysui/desktop/menus/draw.desktop @@ -9,6 +9,7 @@ MimeType=application/vnd.oasis.opendocument.graphics;application/vnd.oasis.opend Name=%PRODUCTNAME Draw GenericName=Drawing Program Comment=Create and edit drawings, flow charts, and logos by using Draw. +Keywords=Vector;Schema;Diagram;odg; InitialPreference=5 X-Ayatana-Desktop-Shortcuts=X-New [X-New Shortcut Group] diff --git a/sysui/desktop/menus/impress.desktop b/sysui/desktop/menus/impress.desktop index 2fb8650..d8ca703 100755 --- a/sysui/desktop/menus/impress.desktop +++ b/sysui/desktop/menus/impress.desktop @@ -9,6 +9,7 @@ MimeType=application/vnd.oasis.opendocument.presentation;application/vnd.oasis.o Name=%PRODUCTNAME Impress GenericName=Presentation Comment=Create and edit presentations for slideshows, meeting and Web pages by using Impress. +Keywords=Slideshow;odp;ppt;pptx; InitialPreference=5 X-Ayatana-Desktop-Shortcuts=X-New [X-New Shortcut Group] diff --git a/sysui/desktop/menus/math.desktop b/sysui/desktop/menus/math.desktop index 867711d..4381a49 100755 --- a/sysui/desktop/menus/math.desktop +++ b/sysui/desktop/menus/math.desktop @@ -10,6 +10,7 @@ MimeType=application/vnd.oasis.opendocument.formula;application/vnd.sun.xml.math Name=%PRODUCTNAME Math GenericName=Formula Editor Comment=Create and edit scientific formulas and equations by using Math. +Keywords=Equation; InitialPreference=5 X-Ayatana-Desktop-Shortcuts=X-New [X-New Shortcut Group] diff --git a/sysui/desktop/menus/writer.desktop b/sysui/desktop/menus/writer.desktop index 888b382..f76ac4e 100755 --- a/sysui/desktop/menus/writer.desktop +++ b/sysui/desktop/menus/writer.desktop @@ -9,6 +9,7 @@ MimeType=application/vnd.oasis.opendocument.text;application/vnd.oasis.opendocum Name=%PRODUCTNAME Writer GenericName=Word Processor Comment=Create and edit text and graphics in letters, reports, documents and Web pages by using Writer. +Keywords=Text;Letter;CV;odt;doc;docx; InitialPreference=5 X-Ayatana-Desktop-Shortcuts=X-New [X-New Shortcut Group] ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 54157] LibreOffice 3.7 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on||56460 --- Comment #20 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Add Bug 56460 - CRASH when closing specific .odg files, many Drawings affected! -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Where do I find debug builds for Windows of Master/3.7?
I want to assist Lionel with bug 53030, but to do that I need a debug (daily) build for Windows. The bug is about freeze of Base with MS Access databases (and other ADO connections, I believe). Where can I download these builds? Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/qa
sc/qa/unit/data/xls/pass/EDB-22330-1.xls |binary 1 file changed New commits: commit 33781373bd4da103492f7a6c1f5482e60d58f108 Author: Caolán McNamara caol...@redhat.com Date: Wed Oct 31 23:12:40 2012 + add test for EBD-22330 Change-Id: Ifd59198a2d09e26377267c8b509c5340d83240e3 diff --git a/sc/qa/unit/data/xls/pass/EDB-22330-1.xls b/sc/qa/unit/data/xls/pass/EDB-22330-1.xls new file mode 100644 index 000..a10c24d Binary files /dev/null and b/sc/qa/unit/data/xls/pass/EDB-22330-1.xls differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: no functional TinderBox for master/3-7 full Windows builds
On 11/01/2012 02:30 AM, V Stuart Foote wrote: For me, the install is now detecting the Java JRE 1.7. But it seems a little off as it builds the list of detected JRE new each time Tools - Options panel is opened and the Java options panel is touched. Does anyone know if that is correct action—I would think once built it would remain static unless an add call gets made. Also, the “Use a Java runtime environment” check box is on by default on first launch of Tools - Options - Advanced – Java options. I would expect it to be off until specifically checked—I had not enabled Assistive Technologie on the install screen and the extensions aren’t in the build, so what would require the JRE be set to on? I think both these behaviors (rebuilding the list of Javas, and Java enabled by default) are normal. The Tools - Options - Accessibility – Miscellaneous options check-box for “Support Assistive technology tools (program restart requied)” can be checked but it does not seem to be being fully processed—because on subsequent launches of Tools - Options - Accessibility it opens as unchecked and there is no entry made in the registry. Just for comparison, a recent Windows build of mine (but with MSVC 2008 Express, not MSVC 2010) to fix fdo#53474 (Fix Windows Java Accessibility Bridge) did exhibit working accessibility. So it must be either due to MSVC 2010 or due to the specific build. One idea is that --with-java-target-version=1.5 might help if the JDK used during the build is newer than the JRE that shall be used at runtime (but which should not be the case here, as you write it is now detecting the Java JRE 1.7). Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: How to test .idl files?
On 10/31/2012 08:26 PM, Ricardo Montania wrote: About fdo#46808. How can I test .idl files? Full compilation? Full compilation of course is always the best way to test /any/ change. Short of that, checking whether a modification to .idl files in udkapi and/or offapi is at least syntactically correct can be done with make udkapi offapi. If you want to work on https://bugs.freedesktop.org/show_bug.cgi?id=46808 Adapt UNO services to new-style please note that Noel Grandin is currently working on that one, so you might want to coordinate. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Filipino / Tagalog language version
Gentlemen, ladies, we are a small software house located in the Philippines. As stern followers and users of LibreOffice (now v 3.6.2) we always were surprised that there is no Filipino / Tagalog language version available. Could you inform us whether someone is working on this translation already, of, if not, how we could get involved in doing it for you? We have a team of translators (also for Spanish) and would love to do our part to further the reach of LibreOffice. With best regards Peter Rathgeber mobile: +63 9292865522 (Philippines) +60 1115749736 (Malaysia) email: prathge...@gmail.com prathge...@ikonasoftwareinc.com rpe...@ikonasoftware.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments and improve some Germish
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/955 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/955/1 Translate German comments and improve some Germish Change-Id: If733d06e2213af824884e49bd3414df1c23cb157 --- M svtools/inc/svtools/treelist.hxx M svtools/inc/svtools/treelistbox.hxx 2 files changed, 104 insertions(+), 115 deletions(-) -- To view, visit https://gerrit.libreoffice.org/955 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If733d06e2213af824884e49bd3414df1c23cb157 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 54157] LibreOffice 3.7 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Timur gti...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=37361, ||https://bugs.freedesktop.or ||g/show_bug.cgi?id=6 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Timur gti...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=54157 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Timur gti...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=54157 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Timur gti...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=37361 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Hide the rulers in Writer by default for a cleaner look
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/956 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/956/1 Hide the rulers in Writer by default for a cleaner look This is consistent with Impress. Might need to be discussed with ux-advise Change-Id: Icbe719207410d952c76d96c84450fd5a5831ea15 --- M officecfg/registry/schema/org/openoffice/Office/Writer.xcs 1 file changed, 1 insertion(+), 1 deletion(-) -- To view, visit https://gerrit.libreoffice.org/956 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icbe719207410d952c76d96c84450fd5a5831ea15 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Timur gti...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=6 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
debug symbols creation is broken?
Hi, trying to debug Stuart's accessibility issues i am trying to turn on the debug symbols (VC2010) ang getting this: http://pastebin.com/PZs5T3Er [...] C:\workspace\LO-Win2008-VC2010\workdir\wntmsci13.pro\LinkTarget\Library\ijvmfwk.lib.pdb is wrong path. the compile lines contain -Fd$W/LinkTarget/pdb/Library/ijvmfwk.lib.pdb [...] Evidently: the directory $W/LinkTarget/pdb/Library exists but is empty. @Michael can it be related to your recent AUXTARGETS change? Thanks David ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: no functional TinderBox for master/3-7 full Windows builds
On 01/11/12 00:18, David Ostrovsky wrote: On 31.10.2012 16:26, V Stuart Foote wrote: Thanks David! So, I gave the Win2008 VC10 0build a go, but it seems like java support may not be in your build either. Or at least Tools - Options - Advanced - Java Options is not detecting the installed JRE. so, reproduced and fixed it: messed around with build. Sorry for that. Here is the new master version with working java integration (compiled against jdk 1.7): https://ci.idaia.de/job/LO-Win2008-VC2010/ I tested it on two different systems: with pre installed jre 1.7 = detected with pre installed jre 1.6 only = not detected, after installation of jre 1.7 the new jre was detected. Is it a known issue here? i could imagine that this is the inverse of ths bug: https://bugs.freedesktop.org/show_bug.cgi?id=50584 so perhaps (since you build with MSVC2010) the installation set does not include the MSVC2008 runtime, and loading the jvm.dll from JRE 6 fails because that requires the MSVC2008 runtime and the JRE does not install it properly. so you could test if it suddenly starts working after installing MSVC2008 runtime redistributable from microsoft.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: no functional TinderBox for master/3-7 full Windows builds
On 01/11/12 02:30, V Stuart Foote wrote: For me, the install is now detecting the Java JRE 1.7. But it seems a little off as it builds the list of detected JRE new each time Tools - Options panel is opened and the Java options panel is touched. Does anyone know if that is correct action—I would think once built it would remain static unless an add call gets made. Also, the “Use a Java runtime environment” check box is on by default on first launch of Tools - Options - Advanced – Java options. I would expect it to be off until specifically checked—I had not enabled Assistive Technologie on the install screen and the extensions aren’t in the build, so what would require the JRE be set to on? the JRE support definitely defaults to on on Linux, and likely all platforms, because some parts of LO, for example the default Base backend driver, require a JRE. The Tools - Options - Accessibility – Miscellaneous options check-box for “Support Assistive technology tools (program restart requied)” can be checked but it does not seem to be being fully processed—because on subsequent launches of Tools - Options - Accessibility it opens as unchecked and there is no entry made in the registry. that sounds like a bug, or perhaps another build problem :) David, can you reproduce that? item oor:path=/org.openoffice.VCL/Settings/org.openoffice.VCL:ConfigurableSettings['Accessibility']prop oor:name=EnableATToolSupport oor:op=fuse oor:type=xs:stringvaluetrue/value/prop/item ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Filipino / Tagalog language version
Hi, On Thu, Nov 1, 2012 at 9:37 AM, Peter Rathgeber prathge...@gmail.com wrote: [Filipino / Tagalog language version] Could you inform us whether someone is working on this translation already, of, if not, how we could get involved in doing it for you? We're using pootle to manage the translations - it is at https://translations.documentfoundation.org/ and doesn't list Filipino/Tagalog, so there doesn't exist a translation yet. We have a team of translators (also for Spanish) and would love to do our part to further the reach of LibreOffice. You're more than welcome to do so. The process is: create an account at the https://translations.documentfoundation.org site and then send a mail to the l...@global.libreoffice.org mailinglist and ask for the language to be setup and for granting you the corresponding edit permissions for the language. (you can either edit the translation online in the pootle webinterface, or download po or xliff files for offline translation) http://wiki.documentfoundation.org/Translating_LibreOffice also contains some additional details. HTH, ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Filipino / Tagalog language version
Hi Peter and welcome, On 01/11/2012 09:37, Peter Rathgeber wrote: Gentlemen, ladies, we are a small software house located in the Philippines. As stern followers and users of LibreOffice (now v 3.6.2) we always were surprised that there is no Filipino / Tagalog language version available. Could you inform us whether someone is working on this translation already, of, if not, how we could get involved in doing it for you? It seems that nobody is working on the localization in Filipino/Tagalog. We are using Pootle to translate/store our work : https://translations.documentfoundation.org/ We have a team of translators (also for Spanish) and would love to do our part to further the reach of LibreOffice. Please, subscribe to our localization list : l...@global.libreoffice.org (+subscribe to subscribe to it) and ask for your language to be added on Pootle. You'll find all the instruction on how to proceed here : http://wiki.documentfoundation.org/LibreOffice_Localization_Guide but don't hesitate to ask your questions on the list, we are here to help you :) Kind regards Sophie With best regards Peter Rathgeber mobile: +63 9292865522 (Philippines) +60 1115749736 (Malaysia) email: prathge...@gmail.com prathge...@ikonasoftwareinc.com rpe...@ikonasoftware.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Sophie Gautier sophie.gaut...@documentfoundation.org Tel:+33683901545 Membership Certification Committee Member - Co-founder The Document Foundation ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
About shapeexport.cxx in xmloff
Hi,
On xmloff/source/draw/shapeexport.cxx, line 711 seems quite weird:
704 XMLTokenEnum eDisplayToken = XML_TOKEN_INVALID;
705 const unsigned short nDisplay = (bVisible ? 2 : 0) |
(bPrintable ? 1 : 0);
706 switch( nDisplay )
707 {
708 case 0: eDisplayToken = XML_NONE; break;
709 case 1: eDisplayToken = XML_PRINTER; break;
710 case 2: eDisplayToken = XML_SCREEN; break;
711 // case 3: eDisplayToken = XML_ALWAYS break; this is the
default
712 }
Why shouldn't we uncomment case 3?
nDisplay could be equalled to 3 and eDisplayToken is
XML_TOKEN_INVALID by default
An idea?
Julien
--
View this message in context:
http://nabble.documentfoundation.org/About-shapeexport-cxx-in-xmloff-tp4016286.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: CPPUNIT road map, recent changes etc.
On Tue, 2012-10-30 at 22:29 +, John McCabe wrote: Just found this fork but a bit disappointed with the lack of information on the wiki. Is there a road map? What are the changes between 1.12.1 and the latest release? Has documentation been updated? Help updating the wiki would be lovely :-) and/or do you have any fixes / improvements / patches you want to see in cppunit ? either way Markus is maintaining that currently - but has a huge amount of good work on his plate, so help appreciated (I suspect) :-) All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: len() string function in calc - basic/64k limit code pointers
Hi there,
On Wed, 2012-10-31 at 08:16 +0100, post wrote:
I have a special request regarding spreadsheet functions.
Ah - so, this list is really for reviewing patches, discussing quirks
of the code, and helping people develop fixes.
When importing a string larger than 64k the len() function reports zero
length.
Right - so there are tons of 64bit string limits around the code -
we're slowly removing them.
Can the next version of Libreoffice handle strings larger than 64K in
calc? Or do the cell in calc have a string limit of 64k built in?
The features of the next version are limited only by what people are
prepared to hack on :-) would you like some code pointers to get
involved in fixing this ? Encouragingly the ScStringCell has an
rtl::OUString embedded in it, so (quite possibly) there is just some
binding / truncation problem inside basic itself.
If you see basic/source/runtime/methods.cxx and look for:
RTLFUNC(Len)
{
(void)pBasic;
(void)bWrite;
if ( rPar.Count() != 2 )
StarBASIC::Error( SbERR_BAD_ARGUMENT );
else
{
const String rStr = rPar.Get(1)-GetString();
rPar.Get(0)-PutLong( (sal_Int32)rStr.Len() );
}
}
You can see that the problematic 'String' type is used (which truncates
to 64k lengths). I suspect you'd want to poke at:
basic/inc/basic/sbxvar.hxx
particularly the SbxValue and it's implementation inside:
basic/source/sbx/sbxvalue.cxx
To use rtl::OUString instead of String - that shouldn't be too hard,
it's easy to convert between the two for compatibility as you push the
perimiter of that wider.
Patches most welcome,
HTH !
Michael.
--
michael.me...@suse.com , Pseudo Engineer, itinerant idiot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: len() string function in calc - basic/64k limit code pointers
On Thu, Nov 1, 2012 at 5:40 AM, Michael Meeks michael.me...@suse.com wrote:
RTLFUNC(Len)
{
(void)pBasic;
(void)bWrite;
if ( rPar.Count() != 2 )
StarBASIC::Error( SbERR_BAD_ARGUMENT );
else
{
const String rStr = rPar.Get(1)-GetString();
rPar.Get(0)-PutLong( (sal_Int32)rStr.Len() );
}
}
You can see that the problematic 'String' type is used (which
truncates
to 64k lengths). I suspect you'd want to poke at:
basic/inc/basic/sbxvar.hxx
particularly the SbxValue and it's implementation inside:
basic/source/sbx/sbxvalue.cxx
To use rtl::OUString instead of String - that shouldn't be too hard,
it's easy to convert between the two for compatibility as you push the
perimiter of that wider.
FYI... I have a feature branch to convert String to OUString in
basic... (among other places)
I've been working on it last week while 'offline' so it is not pushed
yet.. but I should be able to push it for review soon.
Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: len() string function in calc - basic/64k limit code pointers
On 01/11/12 10:40, Michael Meeks wrote: You can see that the problematic 'String' type is used (which truncates to 64k lengths). I suspect you'd want to poke at: basic/inc/basic/sbxvar.hxx particularly the SbxValue and it's implementation inside: basic/source/sbx/sbxvalue.cxx To use rtl::OUString instead of String - that shouldn't be too hard, it's easy to convert between the two for compatibility as you push the perimiter of that wider. Patches most welcome, HTH ! Michael. I believe Norbert has already nearly completed transitioning basic to use OUString internally Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/rb7' - vcl/Library_vcl.mk
vcl/Library_vcl.mk |2 ++ 1 file changed, 2 insertions(+) New commits: commit c2cc2d6f0ab9ceeeda9c60c878275aab2dd48f03 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Thu Nov 1 12:30:51 2012 +0100 Add two missing files into the makefile Change-Id: Ibc891ec4d21356e3836bd2fe9f6e355d893a275c diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk index 469aa5e..8178683 100644 --- a/vcl/Library_vcl.mk +++ b/vcl/Library_vcl.mk @@ -219,6 +219,8 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\ vcl/source/gdi/print \ vcl/source/gdi/regband \ vcl/source/gdi/region \ +vcl/source/gdi/rendergraphic \ +vcl/source/gdi/rendergraphicrasterizer \ vcl/source/gdi/salgdilayout \ vcl/source/gdi/sallayout \ vcl/source/gdi/salmisc \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/rb7' - vcl/inc vcl/Library_vcl.mk vcl/source
vcl/Library_vcl.mk |1
vcl/inc/vcl/metaact.hxx| 39 +
vcl/inc/vcl/outdev.hxx |4 ++
vcl/source/gdi/metaact.cxx | 81 +
vcl/source/gdi/outdev6.cxx | 24 +
5 files changed, 149 insertions(+)
New commits:
commit d13d231730d895156e83ee626122ffacf79ec3ae
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date: Thu Nov 1 13:11:21 2012 +0100
Fix vcl build with svgread.cxx file
Change-Id: I74252483d6423c581901a00372c5ef0578fa515f
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 8178683..51e4c3a 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -226,6 +226,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
vcl/source/gdi/salmisc \
vcl/source/gdi/salnativewidgets-none \
vcl/source/gdi/svgdata \
+vcl/source/gdi/svgread \
vcl/source/gdi/temporaryfonts \
vcl/source/gdi/textlayout \
vcl/source/gdi/virdev \
diff --git a/vcl/inc/vcl/metaact.hxx b/vcl/inc/vcl/metaact.hxx
index e52d184..ae9d343 100644
--- a/vcl/inc/vcl/metaact.hxx
+++ b/vcl/inc/vcl/metaact.hxx
@@ -34,6 +34,7 @@
#include vcl/gdimtf.hxx
#include vcl/gfxlink.hxx
#include vcl/lineinfo.hxx
+#include vcl/rendergraphic.hxx
class SvStream;
@@ -94,6 +95,7 @@ class SvStream;
#define META_LAYOUTMODE_ACTION (149)
#define META_TEXTLANGUAGE_ACTION(150)
#define META_OVERLINECOLOR_ACTION (151)
+#define META_RENDERGRAPHIC_ACTION (152)
#define META_COMMENT_ACTION (512)
@@ -1540,6 +1542,43 @@ public:
LanguageTypeGetTextLanguage() const { return meTextLanguage; }
};
+// ---
+// - MetaRenderGraphicAction -
+// ---
+
+class VCL_DLLPUBLIC MetaRenderGraphicAction : public MetaAction
+{
+private:
+
+::vcl::RenderGraphicmaRenderGraphic;
+Point maPoint;
+SizemaSize;
+double mfRotateAngle;
+double mfShearAngleX;
+double mfShearAngleY;
+
+virtual sal_BoolCompare( const MetaAction ) const;
+
+public:
+DECL_META_ACTION( RenderGraphic,
META_RENDERGRAPHIC_ACTION )
+
+MetaRenderGraphicAction( const Point rPoint,
const Size rSize,
+ const
vcl::RenderGraphic rRenderData,
+ double fRotateAngle =
0.0,
+ double fShearAngleX =
0.0,
+ double fShearAngleY =
0.0 );
+
+virtual voidMove( long nHorzMove, long nVertMove );
+virtual voidScale( double fScaleX, double fScaleY );
+
+const ::vcl::RenderGraphic GetRenderGraphic() const { return
maRenderGraphic; }
+const PointGetPoint() const { return maPoint; }
+const Size GetSize() const { return maSize; }
+double GetRotateAngle() const { return mfRotateAngle;
}
+double GetShearAngleX() const { return mfShearAngleX;
}
+double GetShearAngleY() const { return mfShearAngleY;
}
+};
+
#endif // _SV_METAACT_HXX
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/vcl/outdev.hxx b/vcl/inc/vcl/outdev.hxx
index 90bfd06..df9840a 100644
--- a/vcl/inc/vcl/outdev.hxx
+++ b/vcl/inc/vcl/outdev.hxx
@@ -28,6 +28,7 @@
#include tools/color.hxx
#include vcl/font.hxx
#include vcl/region.hxx
+#include vcl/rendergraphic.hxx
#include vcl/mapmod.hxx
#include vcl/wall.hxx
#include vcl/settings.hxx
@@ -798,6 +799,9 @@ public:
boolDrawEPS( const Point rPt, const Size rSz,
const GfxLink rGfxLink, GDIMetaFile* pSubst
= NULL );
+voidDrawRenderGraphic( const Point rPt, const Size rSz,
+ const ::vcl::RenderGraphic
rRenderGraphic );
+
Color GetPixel( const Point rPt ) const;
Bitmap GetBitmap( const Point rSrcPt, const Size rSize )
const;
diff --git a/vcl/source/gdi/metaact.cxx b/vcl/source/gdi/metaact.cxx
index b1bc2bc..58e528d 100644
--- a/vcl/source/gdi/metaact.cxx
+++ b/vcl/source/gdi/metaact.cxx
@@ -212,6 +212,7 @@ MetaAction* MetaAction::ReadMetaAction( SvStream rIStm,
ImplMetaReadData* pData
case( META_COMMENT_ACTION ): pAction = new MetaCommentAction; break;
case( META_LAYOUTMODE_ACTION ): pAction = new MetaLayoutModeAction;
break;
case( META_TEXTLANGUAGE_ACTION ): pAction = new
MetaTextLanguageAction; break;
+case( META_RENDERGRAPHIC_ACTION ): pAction = new
MetaRenderGraphicAction; break;
default:
{
@@ -4258,4
[Libreoffice-commits] .: Branch 'feature/rb7' - vcl/Package_inc.mk
vcl/Package_inc.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 4008931b90d5db9d9a909ea5275c95b4e80f27a3 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Thu Nov 1 13:37:30 2012 +0100 Missing include delivery Change-Id: I788c26dc95b35dc06e4e3317c3f6ec63c5e9facf diff --git a/vcl/Package_inc.mk b/vcl/Package_inc.mk index 1a59d08..0686bd3 100644 --- a/vcl/Package_inc.mk +++ b/vcl/Package_inc.mk @@ -121,6 +121,7 @@ $(eval $(call gb_Package_add_file,vcl_inc,inc/vcl/ptrstyle.hxx,vcl/ptrstyle.hxx) $(eval $(call gb_Package_add_file,vcl_inc,inc/vcl/quickselectionengine.hxx,vcl/quickselectionengine.hxx)) $(eval $(call gb_Package_add_file,vcl_inc,inc/vcl/regband.hxx,vcl/regband.hxx)) $(eval $(call gb_Package_add_file,vcl_inc,inc/vcl/region.hxx,vcl/region.hxx)) +$(eval $(call gb_Package_add_file,vcl_inc,inc/vcl/rendergraphic.hxx,vcl/rendergraphic.hxx)) $(eval $(call gb_Package_add_file,vcl_inc,inc/vcl/salbtype.hxx,vcl/salbtype.hxx)) $(eval $(call gb_Package_add_file,vcl_inc,inc/vcl/salctype.hxx,vcl/salctype.hxx)) $(eval $(call gb_Package_add_file,vcl_inc,inc/vcl/salgtype.hxx,vcl/salgtype.hxx)) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] ::rtl::OUString - OUString in basic
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/957 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/957/1 ::rtl::OUString - OUString in basic Change-Id: I9df082b774b7ce208aa3b2decf5a576752a74fa2 --- M basic/inc/basic/basmgr.hxx M basic/inc/basic/modsizeexceeded.hxx M basic/inc/basic/sbdef.hxx M basic/inc/basic/sbmod.hxx M basic/inc/basic/sbobjmod.hxx M basic/inc/basic/sbstar.hxx M basic/inc/basic/sbstdobj.hxx M basic/inc/basic/sbuno.hxx M basic/inc/basic/sbx.hxx M basic/inc/basic/sbxcore.hxx M basic/inc/basic/sbxfac.hxx M basic/inc/basic/sbxobj.hxx 12 files changed, 33 insertions(+), 33 deletions(-) -- To view, visit https://gerrit.libreoffice.org/957 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9df082b774b7ce208aa3b2decf5a576752a74fa2 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: nss/makefile.mk
nss/makefile.mk |9 - 1 file changed, 8 insertions(+), 1 deletion(-) New commits: commit 57fb462cea757a2757aee8fba3144e68839fcaff Author: Tor Lillqvist tlillqv...@suse.com Date: Thu Nov 1 14:46:34 2012 +0200 Don't let NSS use the MSVC debugging runtime in an --enable-debug build In an MSVC build, not exporting BUILD_OPT to the Mozilla build machinery causes the produced DLLs to use the debug CRT. The exact mechanism is a bit of a mystery, and I didn't feel like spending too much time trying to understand it. Using the debug CRT is confusing and wrong. Nothing in LO otherwise uses it. It also makes testing a build much harder for me at least, as I do that in a fairly pristine virtual machine with no MSVC debugging runtime available. (The normal CRT is bundled in the LO installer.) Change-Id: I27f774d92a3986d40162c870202bc94aa7c6 diff --git a/nss/makefile.mk b/nss/makefile.mk index db9767a..ec0dacd 100644 --- a/nss/makefile.mk +++ b/nss/makefile.mk @@ -62,7 +62,14 @@ PATCH_FILES=nss.patch nss.aix.patch nss-config.patch \ PATCH_FILES+=nss_macosx.patch .ENDIF # $(OS)==MACOSX -.IF $(debug) != +# For a MSVC build, not exporting BUILD_OPT causes the produced DLLs +# to use the debug CRT. (The exact mechanism that causes this to +# happen is a bit of a mystery...) That is confusing and wrong, as +# nothing in LO otherwise uses that. It also makes testing a build +# much harder for me at least, as I do that in a fairly pristine +# virtual machine with no MSVC debugging runtime available. (The +# normal CRT is bundled in the LO installer.) +.IF $(debug) != $(OS)$(COM) != WNTMSC .ELSE BUILD_OPT=1 .EXPORT: BUILD_OPT ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: debug symbols creation is broken?
On 01/11/12 10:14, David Ostrovsky wrote: Hi, trying to debug Stuart's accessibility issues i am trying to turn on the debug symbols (VC2010) ang getting this: http://pastebin.com/PZs5T3Er [...] C:\workspace\LO-Win2008-VC2010\workdir\wntmsci13.pro\LinkTarget\Library\ijvmfwk.lib.pdb is wrong path. the compile lines contain -Fd$W/LinkTarget/pdb/Library/ijvmfwk.lib.pdb [...] Evidently: the directory $W/LinkTarget/pdb/Library exists but is empty. @Michael can it be related to your recent AUXTARGETS change? hmm... i don't think so but havent actually tried to revert that... there are apparently 2 pdb files for every LinkTarget: 1. workdir/*/LinkTarget/pdb/isot.lib.pdb this is passed to the CXX invocation as -Fd so the compiler writes the debug info into that (apparently there must be some synchronization there so that multiple cl.exe don't step on each others toes) 2. workdir/*/LinkTarget/Library/sotlo.pdb this is written by the linker, and apparently uses the first pdb file as input with just -Fd...foo.pdb and without the special flag to produce debug info cl.exe will not write to the .pdb file and it will not exist. so what (i thought at first) happens here is that you have compiled the library first without debug, so you don't get any pdb file, and then you don't clean any object file and build with debug=t then the linker will complain that there is no pdb file to read. actually that was a nice theory but i don't get a warning in that case (MSVC 2008); apparently the .o files remember if they are build with debug or not? i can however reproduce that if i manually delete the isot.lib.pdb and then re-link without re-compiling. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[HELP] Base Windows-specific issues (Hackfest?)
Hi, There are a few Windows-specific issues and/or ideas in Base. As I don't have a Windows build / development machine / experience using a debugger / ..., I'm wondering whether a LibO-on-Windows developer would be willing to collaborate on these. During the Hackfest (Münich November 2012) would be a good opportunity, for example. Most pressing: ADO broken - cannot open MS Access files regression wrt 3.5 1 dupe https://bugs.freedesktop.org/show_bug.cgi?id=53070 Other stuff (bugs): Crash when ODBC-connecting to IBM DB2 (there is a gratis version of DB2 to run for tests) https://bugs.freedesktop.org/show_bug.cgi?id=45675 The MinGW build freezes instead of showing an error message on incorrect ADO URL https://bugs.freedesktop.org/show_bug.cgi?id=43298 Connecting to Lotus Notes (through ODBC) is broken *again* Not sure if there is a gratis version of Lotus Notes to install for tests Other stuff (enhancements): UI to set workgroup (System DB) when opening MS Access (.mdb) files https://bugs.freedesktop.org/show_bug.cgi?id=43227 -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 3 commits - filter/qa hwpfilter/qa lotuswordpro/qa sc/qa sd/qa sot/qa svl/inc svl/source svtools/qa sw/CppunitTest_sw_filters_test.mk sw/qa sw/source unotest/inc unotest/sourc
filter/qa/cppunit/filters-pict-test.cxx|7 -
filter/qa/cppunit/filters-tga-test.cxx |7 -
filter/qa/cppunit/filters-tiff-test.cxx|7 -
hwpfilter/qa/cppunit/test_hwpfilter.cxx|9 +
lotuswordpro/qa/cppunit/test_lotuswordpro.cxx |6 -
sc/qa/unit/filters-test.cxx| 43 ---
sc/qa/unit/subsequent_export-test.cxx |2
sc/qa/unit/subsequent_filters-test.cxx | 117 +++--
sd/qa/unit/filters-test.cxx| 11 +
sd/qa/unit/regression-test.cxx | 11 +
sot/qa/cppunit/test_sot.cxx|9 -
svl/inc/svl/ctypeitm.hxx |6 -
svl/inc/svl/stritem.hxx|2
svl/source/items/ctypeitm.cxx | 12 +-
svtools/qa/cppunit/filters-test.cxx|7 -
sw/CppunitTest_sw_filters_test.mk |2
sw/qa/core/data/odt/pass/CVE-2012-4233-1.odt |binary
sw/qa/core/filters-test.cxx| 24 +++-
sw/source/core/layout/laycache.cxx | 19 +--
sw/source/filter/xml/swxml.cxx |8 -
unotest/inc/unotest/filters-test.hxx | 19 ++-
unotest/source/cpp/filters-test.cxx| 34 --
writerfilter/qa/cppunittests/rtftok/testrtftok.cxx |9 +
23 files changed, 258 insertions(+), 113 deletions(-)
New commits:
commit c2913591d895666c7b8019e3307355511a7a5f95
Author: Caolán McNamara caol...@redhat.com
Date: Thu Nov 1 13:12:21 2012 +
rework filters test to squeeze through extra flags
that are needed to load .odt, .sxw etc files, and
add a regression test for CVE-2012-4233
Change-Id: Ie178725ded3d76942030d12f23074de519cf62de
diff --git a/filter/qa/cppunit/filters-pict-test.cxx
b/filter/qa/cppunit/filters-pict-test.cxx
index 69228f3..9e5a296 100644
--- a/filter/qa/cppunit/filters-pict-test.cxx
+++ b/filter/qa/cppunit/filters-pict-test.cxx
@@ -34,7 +34,9 @@ class PictFilterTest
public:
PictFilterTest() : BootstrapFixture(true, false) {}
-virtual bool load(const rtl::OUString , const rtl::OUString rURL, const
rtl::OUString );
+virtual bool load(const rtl::OUString ,
+const rtl::OUString rURL, const rtl::OUString ,
+unsigned int, unsigned int, unsigned int);
/**
* Ensure CVEs remain unbroken
@@ -47,7 +49,8 @@ public:
};
bool PictFilterTest::load(const rtl::OUString ,
-const rtl::OUString rURL, const rtl::OUString )
+const rtl::OUString rURL, const rtl::OUString ,
+unsigned int, unsigned int, unsigned int)
{
SvFileStream aFileStream(rURL, STREAM_READ);
Graphic aGraphic;
diff --git a/filter/qa/cppunit/filters-tga-test.cxx
b/filter/qa/cppunit/filters-tga-test.cxx
index c0eba97..9edcf62 100644
--- a/filter/qa/cppunit/filters-tga-test.cxx
+++ b/filter/qa/cppunit/filters-tga-test.cxx
@@ -54,7 +54,9 @@ class TgaFilterTest
public:
TgaFilterTest() : BootstrapFixture(true, false) {}
-virtual bool load(const rtl::OUString , const rtl::OUString rURL, const
rtl::OUString );
+virtual bool load(const rtl::OUString ,
+const rtl::OUString rURL, const rtl::OUString ,
+unsigned int, unsigned int, unsigned int);
/**
* Ensure CVEs remain unbroken
@@ -67,7 +69,8 @@ public:
};
bool TgaFilterTest::load(const rtl::OUString ,
-const rtl::OUString rURL, const rtl::OUString )
+const rtl::OUString rURL, const rtl::OUString ,
+unsigned int, unsigned int, unsigned int)
{
SvFileStream aFileStream(rURL, STREAM_READ);
Graphic aGraphic;
diff --git a/filter/qa/cppunit/filters-tiff-test.cxx
b/filter/qa/cppunit/filters-tiff-test.cxx
index 942ad16..b967393 100644
--- a/filter/qa/cppunit/filters-tiff-test.cxx
+++ b/filter/qa/cppunit/filters-tiff-test.cxx
@@ -54,7 +54,9 @@ class TiffFilterTest
public:
TiffFilterTest() : BootstrapFixture(true, false) {}
-virtual bool load(const rtl::OUString , const rtl::OUString rURL, const
rtl::OUString );
+virtual bool load(const rtl::OUString ,
+const rtl::OUString rURL, const rtl::OUString ,
+unsigned int, unsigned int, unsigned int);
/**
* Ensure CVEs remain unbroken
@@ -67,7 +69,8 @@ public:
};
bool TiffFilterTest::load(const rtl::OUString ,
-const rtl::OUString rURL, const rtl::OUString )
+const rtl::OUString rURL, const rtl::OUString ,
+unsigned int, unsigned int, unsigned int)
{
SvFileStream aFileStream(rURL, STREAM_READ);
Graphic aGraphic;
diff --git a/hwpfilter/qa/cppunit/test_hwpfilter.cxx
b/hwpfilter/qa/cppunit/test_hwpfilter.cxx
index 18b6ebf..88a09a0 100644
--- a/hwpfilter/qa/cppunit/test_hwpfilter.cxx
+++ b/hwpfilter/qa/cppunit/test_hwpfilter.cxx
@@ -45,7 +45,11 @@ namespace
{
public:
virtual void setUp();
-virtual bool load(const rtl::OUString , const
[Libreoffice-commits] .: sd/CppunitTest_sd_filters_test.mk sd/qa sd/source
sd/CppunitTest_sd_filters_test.mk|1 + sd/qa/unit/data/odg/pass/CVE-2012-4233-2.odg |binary sd/qa/unit/filters-test.cxx |4 sd/source/filter/xml/sdxmlwrp.cxx|6 +++--- 4 files changed, 8 insertions(+), 3 deletions(-) New commits: commit a6e4a84197aa7a658e2ffb76c0326016dda76d8b Author: Caolán McNamara caol...@redhat.com Date: Thu Nov 1 14:00:40 2012 + add .odg regression load test Change-Id: I5f7dc2a389c020a90b8087aefc90c054a809ef25 diff --git a/sd/CppunitTest_sd_filters_test.mk b/sd/CppunitTest_sd_filters_test.mk index 4440c1d..132980a 100644 --- a/sd/CppunitTest_sd_filters_test.mk +++ b/sd/CppunitTest_sd_filters_test.mk @@ -114,6 +114,7 @@ $(eval $(call gb_CppunitTest_use_components,sd_filters_test,\ unotools/util/utl \ unoxml/source/rdf/unordf \ unoxml/source/service/unoxml \ +xmloff/util/xo \ )) $(eval $(call gb_CppunitTest_use_configuration,sd_filters_test)) diff --git a/sd/qa/unit/data/odg/fail/.gitignore b/sd/qa/unit/data/odg/fail/.gitignore new file mode 100644 index 000..e69de29 diff --git a/sd/qa/unit/data/odg/indeterminate/.gitignore b/sd/qa/unit/data/odg/indeterminate/.gitignore new file mode 100644 index 000..e69de29 diff --git a/sd/qa/unit/data/odg/pass/.gitignore b/sd/qa/unit/data/odg/pass/.gitignore new file mode 100644 index 000..e69de29 diff --git a/sd/qa/unit/data/odg/pass/CVE-2012-4233-2.odg b/sd/qa/unit/data/odg/pass/CVE-2012-4233-2.odg new file mode 100644 index 000..321bd9c Binary files /dev/null and b/sd/qa/unit/data/odg/pass/CVE-2012-4233-2.odg differ diff --git a/sd/qa/unit/filters-test.cxx b/sd/qa/unit/filters-test.cxx index f274c2c..a834686 100644 --- a/sd/qa/unit/filters-test.cxx +++ b/sd/qa/unit/filters-test.cxx @@ -205,6 +205,10 @@ void SdFiltersTest::testCVEs() testDir(rtl::OUString(MS PowerPoint 97), getURLFromSrc(/sd/qa/unit/data/ppt/), rtl::OUString(sdfilt)); + +testDir(rtl::OUString(draw8), +getURLFromSrc(/sd/qa/unit/data/odg/), +rtl::OUString(sdfilt)); #endif } diff --git a/sd/source/filter/xml/sdxmlwrp.cxx b/sd/source/filter/xml/sdxmlwrp.cxx index fb8598e..1dc3543 100644 --- a/sd/source/filter/xml/sdxmlwrp.cxx +++ b/sd/source/filter/xml/sdxmlwrp.cxx @@ -234,11 +234,11 @@ sal_Int32 ReadThroughComponent( RTL_LOGFILE_CONTEXT_TRACE( aLog, parser created ); // get filter +OUString aFilterName(OUString::createFromAscii(pFilterName)); Reference xml::sax::XDocumentHandler xFilter( -rFactory-createInstanceWithArguments( -OUString::createFromAscii(pFilterName), rFilterArguments), +rFactory-createInstanceWithArguments(aFilterName, rFilterArguments), UNO_QUERY ); -DBG_ASSERT( xFilter.is(), Can't instantiate filter component. ); +SAL_WARN_IF(!xFilter.is(), sd, Can't instantiate filter component: aFilterName); if( !xFilter.is() ) return SD_XML_READERROR; RTL_LOGFILE_CONTEXT_TRACE1( aLog, %s created, pFilterName ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
::rtl::OUString - OUString in basic
Ricardo Montania has abandoned this change. Change subject: ::rtl::OUString - OUString in basic .. Patch Set 1: Abandoned No problem.. I'll work in another module :) -- To view, visit https://gerrit.libreoffice.org/957 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I9df082b774b7ce208aa3b2decf5a576752a74fa2 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/qa sd/qa
sc/qa/unit/data/xls/fail/CVE-2012-4233-4.xls |binary sd/qa/unit/data/ppt/pass/CVE-2012-4233-3.ppt |binary 2 files changed New commits: commit cd11b9f2c1bd3e3c3f9e4dc8788bf487c8c421cb Author: Caolán McNamara caol...@redhat.com Date: Thu Nov 1 14:07:28 2012 + another some more regression tests Change-Id: Ic13269fcf55b4e51a8124da6d2de75fb5bec23e0 diff --git a/sc/qa/unit/data/xls/fail/CVE-2012-4233-4.xls b/sc/qa/unit/data/xls/fail/CVE-2012-4233-4.xls new file mode 100644 index 000..7f8f89c Binary files /dev/null and b/sc/qa/unit/data/xls/fail/CVE-2012-4233-4.xls differ diff --git a/sd/qa/unit/data/ppt/pass/CVE-2012-4233-3.ppt b/sd/qa/unit/data/ppt/pass/CVE-2012-4233-3.ppt new file mode 100644 index 000..625c116 Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/CVE-2012-4233-3.ppt differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: formula/inc formula/source unusedcode.easy
formula/inc/formula/tokenarray.hxx |1 -
formula/source/core/api/token.cxx |6 --
unusedcode.easy|2 --
3 files changed, 9 deletions(-)
New commits:
commit 4e0b79b546f16abce81b0f22b16664c66bd2a146
Author: Marcos Paulo de Souza marcos.souza@gmail.com
Date: Wed Oct 31 00:51:55 2012 -0200
Remove unused method in formula module
Change-Id: I67259c5a3894be406b2d38900368a3f8aac86921
Signed-off-by: Marcos Paulo de Souza marcos.souza@gmail.com
diff --git a/formula/inc/formula/tokenarray.hxx
b/formula/inc/formula/tokenarray.hxx
index 1f4299c..e9041ac 100644
--- a/formula/inc/formula/tokenarray.hxx
+++ b/formula/inc/formula/tokenarray.hxx
@@ -246,7 +246,6 @@ public:
FormulaTokenIterator( const FormulaTokenArray );
~FormulaTokenIterator();
voidReset();
-const FormulaToken* First();
const FormulaToken* Next();
const FormulaToken* PeekNextOperator();
boolIsEndOfPath() const;/// if a jump or subroutine path is done
diff --git a/formula/source/core/api/token.cxx
b/formula/source/core/api/token.cxx
index c18ca4f..d187073 100644
--- a/formula/source/core/api/token.cxx
+++ b/formula/source/core/api/token.cxx
@@ -1234,12 +1234,6 @@ void FormulaTokenIterator::Reset()
pCur-nPC = -1;
}
-const FormulaToken* FormulaTokenIterator::First()
-{
-Reset();
-return Next();
-}
-
const FormulaToken* FormulaTokenIterator::Next()
{
const FormulaToken* t = GetNonEndOfPathToken( ++pCur-nPC );
diff --git a/unusedcode.easy b/unusedcode.easy
index 5b6270b..a6b5cd7 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -9,7 +9,6 @@ ScVbaFormatooo::vba::excel::XStyle::getAddIndent()
ScVbaFormatooo::vba::excel::XStyle::setAddIndent(com::sun::star::uno::Any
const)
ScVbaFormatooo::vba::excel::XStyle::setNumberFormat(com::sun::star::lang::Locale,
rtl::OUString const)
SvTreeEntryList::front()
-SvxAutoCorrect::DeleteText(String const, unsigned short)
TextEngine::GetLeftMargin() const
ThumbnailViewItemAcc::FireAccessibleEvent(short, com::sun::star::uno::Any
const, com::sun::star::uno::Any const)
VirtualDevice::SetOutputSizePixelScaleOffsetAndBuffer(Size const, Fraction
const, Point const, boost::shared_arrayunsigned char const)
@@ -86,7 +85,6 @@ connectivity::mozab::MQueryHelper::next()
connectivity::sdbcx::OGroup::OGroup(rtl::OUString const, unsigned char)
connectivity::sdbcx::OGroup::OGroup(unsigned char)
dbtools::getConnection(rtl::OUString const, rtl::OUString const,
rtl::OUString const,
com::sun::star::uno::Referencecom::sun::star::uno::XComponentContext const)
-formula::FormulaTokenIterator::First()
framework::OReadMenuDocumentHandler::getServiceFactory()
jfw_plugin::VendorBase::createInstance()
oox::drawingml::TextListStyle::dump() const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Remove unused method in formula module
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/946 -- To view, visit https://gerrit.libreoffice.org/946 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67259c5a3894be406b2d38900368a3f8aac86921 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza marcos.souza@gmail.com Gerrit-Reviewer: Caolán McNamara caol...@redhat.com Gerrit-Reviewer: Marcos Souza marcos.souza@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sd/uiconfig sw/uiconfig
sd/uiconfig/sdraw/menubar/menubar.xml |1 - sw/uiconfig/swriter/menubar/menubar.xml |1 - 2 files changed, 2 deletions(-) New commits: commit 5bc36d13dfa5e3a386f24446c3f794d24863e1d2 Author: Julien Nabet serval2...@yahoo.fr Date: Thu Nov 1 15:27:46 2012 +0100 Revert cf0453d94b1af305ee385e9e2522bcc5e589530e After having talked about on IRC with Michael Meeks, it seems UX team prefers that way. In brief, it was on purpose. Thank you Michael for your time Change-Id: Ib99425a212ac5463b0465e1e755e2537bb4d51b8 diff --git a/sd/uiconfig/sdraw/menubar/menubar.xml b/sd/uiconfig/sdraw/menubar/menubar.xml index e23ff0c..cd9b093 100644 --- a/sd/uiconfig/sdraw/menubar/menubar.xml +++ b/sd/uiconfig/sdraw/menubar/menubar.xml @@ -238,7 +238,6 @@ menu:menuseparator/ menu:menuitem menu:id=.uno:Gallery/ menu:menuitem menu:id=.uno:BmpMask/ - menu:menuitem menu:id=.uno:AVMediaPlayer/ menu:menuseparator/ menu:menu menu:id=.uno:MacrosMenu menu:menupopup diff --git a/sw/uiconfig/swriter/menubar/menubar.xml b/sw/uiconfig/swriter/menubar/menubar.xml index 3e7a0f0..b1c5ac7 100644 --- a/sw/uiconfig/swriter/menubar/menubar.xml +++ b/sw/uiconfig/swriter/menubar/menubar.xml @@ -422,7 +422,6 @@ menu:menuitem menu:id=.uno:FootnoteDialog/ menu:menuseparator/ menu:menuitem menu:id=.uno:Gallery/ - menu:menuitem menu:id=.uno:AVMediaPlayer/ menu:menuseparator/ menu:menuitem menu:id=.uno:BibliographyComponent/ menu:menuseparator/ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: no functional TinderBox for master/3-7 full Windows builds
On 01.11.2012 10:38, Michael Stahl wrote: The Tools - Options - Accessibility – Miscellaneous options check-box for “Support Assistive technology tools (program restart requied)” can be checked but it does not seem to be being fully processed—because on subsequent launches of Tools - Options - Accessibility it opens as unchecked and there is no entry made in the registry. that sounds like a bug, or perhaps another build problem:) David, can you reproduce that? Yes, is reproducable here. I will try to debug this later, if i can create debug symbols. Regards David ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: vcl/source
vcl/source/gdi/outdev3.cxx |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit e217fc455208a1f83bad0af06b9cf96bca3b254e Author: Caolán McNamara caol...@redhat.com Date: Thu Nov 1 15:37:56 2012 + Resolves: fdo#54466 right-aligned label text slightly clipped on right aae8a0c8ea27a1a6451c28d66de1ee7f0f0323ef with rather unhelpful #99188# enlarge textrect to get rid of rounding problems comment appears to be the root. Lets assume that commit is necessary and just adjust alternatively for right align Change-Id: I0b60c12199226ca757596c034599b81c1a4db433 diff --git a/vcl/source/gdi/outdev3.cxx b/vcl/source/gdi/outdev3.cxx index f1994bf..5e1dc9e 100644 --- a/vcl/source/gdi/outdev3.cxx +++ b/vcl/source/gdi/outdev3.cxx @@ -6940,7 +6940,11 @@ Rectangle OutputDevice::GetTextRect( const Rectangle rRect, else aRect.Bottom() = aRect.Top()+(nTextHeight*nLines)-1; -aRect.Right()++; // #99188# get rid of rounding problems when using this rect later +// #99188# get rid of rounding problems when using this rect later +if (nStyle TEXT_DRAW_RIGHT) +aRect.Left()--; +else +aRect.Right()++; return aRect; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: no functional TinderBox for master/3-7 full Windows builds
Hold on! I knew this seemed familiar, happened the last time I had occasion to load a LOdev build. See fdo#39833 https://bugs.freedesktop.org/show_bug.cgi?id=39833#c11 comment 11 from Andras. When I get a moment I'll load the LOdev with WRITE_REGISTRY=1 and see if that fixes the current build of master. Andras, do you have any other insights to add on the JRE version and MSVC 2008/2010 runtimes affecting David's MSVC 2010 builds? Stuart -- View this message in context: http://nabble.documentfoundation.org/no-functional-TinderBox-for-master-3-7-full-Windows-builds-tp4016034p4016338.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: vcl/headless
vcl/headless/svpinst.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 002f8b272bc343477c649c648c5ceb2ccf0fba89 Author: Riccardo Magliocchetti riccardo.magliocche...@gmail.com Date: Thu Nov 1 16:56:04 2012 +0100 vcl/headless: [HACK] workaround solarMutexx splat with headless mode Apply mmeeks temporary solution until a proper fix is found. With the patch applied unoconv testsuite runs fine. mmeeks analysis of the problem: It looks really interesting :-) it's hard to tell (from valgrind) where the threads were pre-empted [ actually logging that might be quite a nice feature to add to for valgrind ;-], but there is already the SolarMutex guard to try to stop this from happening. I append the odd trace with some thoughts. It is -possible- that we never get around to taking the solar mutex in the first instance in 'main' - such that by the time we come to release and re-take it in vcl/headless/svpinst.cxx: void SvpSalInstance::Yield( bool bWait, bool bHandleAllCurrentEvents ) the count is zero - could you add some fprintf debugging to check that - just dump nAcquireCount ==28574== Thread 1: ==28574== Invalid read of size 8 ==28574==at 0x739C702: SfxStateCache::SetState_Impl(unsigned short, SfxPoolItem const*, unsigned char) (statcach.cxx:454) ==28574==by 0x738042E: SfxBindings::UpdateControllers_Impl(SfxInterface const*, SfxFoundCache_Impl const*, SfxPoolItem const*, unsigned short) (bindings.cxx:1500) ==28574==by 0x7383C5B: SfxBindings::Update_Impl(SfxStateCache*) (bindings.cxx:437) ==28574==by 0x7383FD7: SfxBindings::NextJob_Impl(Timer*) (bindings.cxx:1646) ==28574==by 0x92BF4AD: Timer::ImplTimerCallbackProc() (timer.cxx:142) The YieldMutex -should- be held at this point excluding this other thread (?). ==28574==by 0x95D152D: SvpSalInstance::CheckTimeout(bool) (saltimer.hxx:57) ==28574==by 0x95D17D7: SvpSalInstance::Yield(bool, bool) (svpinst.cxx:288) ==28574==by 0x92B4530: Application::Yield(bool) (svapp.cxx:434) ==28574==by 0x92B45E6: Application::Execute() (svapp.cxx:413) ==28574==by 0x50AED58: desktop::Desktop::Main() (app.cxx:1711) ==28574==by 0x92BDFB8: ImplSVMain() (svmain.cxx:173) ==28574==by 0x92BE8E4: SVMain() (svmain.cxx:210) ==28574==by 0x50E1CF4: soffice_main (sofficemain.cxx:83) ==28574==by 0x40069A: main (main.c:25) ==28574== Address 0x1466bdc8 is 56 bytes inside a block of size 72 free'd ==28574==at 0x4C27FF2: operator delete(void*) (vg_replace_malloc.c:387) ==28574==by 0x737F479: SfxBindings::DeleteControllers_Impl() (bindings.cxx:325) ==28574==by 0x7380572: SfxBindings::~SfxBindings() (bindings.cxx:264) ==28574==by 0x7380718: SfxBindings::~SfxBindings() (bindings.cxx:275) ==28574==by 0x758B91E: SfxFrame::DoClose_Impl() (frame.cxx:178) ==28574==by 0x75AAFC1: SfxBaseController::dispose() (sfxbasecontroller.cxx:1041) sfx2/source/view/sfxbasecontroller.cxx: This method has a live: SolarMutexGuard aGuard; ==28574==by 0x16B8E785: framework::Frame::setComponent(com::sun::star::uno::Referencecom::sun::star::awt::XWindow const, com::sun::star::uno::Referencecom::sun::star::frame::XController const) (frame.cxx:1380) ==28574==by 0x16B8E1CF: framework::Frame::close(unsigned char) (frame.cxx:1633) ==28574==by 0x758BE87: SfxFrame::DoClose() (frame.cxx:140) ==28574==by 0x797F51C: SfxBroadcaster::Broadcast(SfxHint const) (brdcst.cxx:49) ==28574==by 0x7511211: SfxModelListener_Impl::notifyClosing(com::sun::star::lang::EventObject const) (objxtor.cxx:173) ==28574==by 0x7534972: SfxBaseModel::close(unsigned char) (sfxbasemodel.cxx:1491) ==28574==by 0x1E776909: SwXTextDocument::close(unsigned char) (unotxdoc.cxx:578) ==28574==by 0x7537FB0: SfxBaseModel::dispose() (sfxbasemodel.cxx:788) ==28574==by 0x1211D6E7: gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, unsigned int, double*, unsigned int) (callvirtualmethod.cxx:128) ==28574==by 0x12120FEE: cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) (uno2cpp.cxx:246) ==28574==by 0x12121ACD: bridges::cpp_uno::shared::unoInterfaceProxyDispatch(_uno_Interface*, _typelib_TypeDescription const*, void*, void**, _uno_Any**) (uno2cpp.cxx:440) ==28574==by 0x15D5CE5E: binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::vectorbinaryurp::BinaryAny, std::allocatorbinaryurp::BinaryAny *) const (incomingrequest.cxx:251) ==28574==
Re: [Libreoffice-qa] want to contribute
Hi Rizwan! Am 31.10.2012 um 19:06 schrieb Michael Meeks michael.me...@suse.com: Hi Rizwan, It'd be great to have you involved with LibreOffice :-) On Wed, 2012-10-31 at 01:23 +0530, Rizwan Alam wrote: I want to contribute to libreoffice how ever i do not have experience. I am a bit confused. I was thinking about doing testing can any one help me out. Hmm... IMHO The next thing (skipped) are dev - topics... As from the QA part the thing below is important... To get started, you may use tis queries according to your OS... http://pastehtml.com/view/calh0sflu.html [...] it's very useful to do bug triage: http://wiki.documentfoundation.org/BugTriage Checking confirming bugs moving them to the 'NEW' state, or marking them as duplicates. Help much appreciated ! All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ Enjoy the time with LibO :) If you have any questions, ask :) Florian R. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Where do I find debug builds for Windows of Master/3.7?
On 01.11.2012 09:00, Winfried Donkers wrote: I want to assist Lionel with bug 53030, but to do that I need a debug (daily) build for Windows. The bug is about freeze of Base with MS Access databases (and other ADO connections, I believe). Where can I download these builds? The bad news is that you can't download it but the good news is you can build it yourself ;-) That's pretty straightforward: 1. Create a VM and install prerequisites (http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies) 2. Compile LO with debug symbols and start it 3. Start VC++, attach debugger to the LO process and set breakpoints Regards David ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/source
sw/source/core/docnode/node2lay.cxx | 99 ++--
1 file changed, 51 insertions(+), 48 deletions(-)
New commits:
commit c1cc17bcc96b188d313a89bc31c64d6187aa60ce
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date: Thu Nov 1 00:05:15 2012 +0100
Translate German comments
Change-Id: I8cf27a705332c6e7ea62474c78d59911406d378e
Reviewed-on: https://gerrit.libreoffice.org/954
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/sw/source/core/docnode/node2lay.cxx
b/sw/source/core/docnode/node2lay.cxx
index 5af266b..0690e72 100644
--- a/sw/source/core/docnode/node2lay.cxx
+++ b/sw/source/core/docnode/node2lay.cxx
@@ -41,25 +41,25 @@
#include section.hxx
#include node2lay.hxx
-/* --
- * Die SwNode2LayImpl-Klasse erledigt die eigentliche Arbeit,
- * die SwNode2Layout-Klasse ist nur die der Oefffentlichkeit bekannte
Schnittstelle
- * --*/
+/**
+ * The SwNode2LayImpl class does the actual work, the SwNode2Layout class is
+ * just the public interface.
+ */
class SwNode2LayImpl
{
SwIteratorSwFrm,SwModify* pIter;
SwModify* pMod;
-std::vectorSwFrm** pUpperFrms;// Zum Einsammeln der Upper
-sal_uLong nIndex;// Der Index des einzufuegenden Nodes
-sal_Bool bMaster: 1; // sal_True = nur Master , sal_False = nur
Frames ohne Follow
-sal_Bool bInit : 1; // Ist am SwClient bereits ein First()-Aufruf
erfolgt?
+std::vectorSwFrm** pUpperFrms; // To collect the Upper
+sal_uLong nIndex;// The Index of the to-be-inserted Nodes
+sal_Bool bMaster: 1; // sal_True = only Master, sal_False = only
Frames without Follow
+sal_Bool bInit : 1; // Did we already call First() at SwClient?
public:
SwNode2LayImpl( const SwNode rNode, sal_uLong nIdx, sal_Bool bSearch );
~SwNode2LayImpl() { delete pIter; delete pUpperFrms; }
-SwFrm* NextFrm(); // liefert den naechsten sinnvollen Frame
+SwFrm* NextFrm(); // Returns the next useful Frame
SwLayoutFrm* UpperFrm( SwFrm* rpFrm, const SwNode rNode );
-void SaveUpperFrms(); // Speichert (und lockt ggf.) die pUpper
-// Fuegt unter jeden pUpper des Arrays einen Frame ein.
+void SaveUpperFrms(); // Saves (and locks if needed) the pUpper
+// Inserts a Frame under every pUpper of the array
void RestoreUpperFrms( SwNodes rNds, sal_uLong nStt, sal_uLong nEnd );
SwFrm* GetFrm( const Point* pDocPos = 0,
@@ -67,15 +67,15 @@ public:
const sal_Bool bCalcFrm = sal_True ) const;
};
-/* --
- * Hauptaufgabe des Ctor: Das richtige SwModify zu ermitteln,
- * ueber das iteriert wird.
- * Uebergibt man bSearch == sal_True, so wird der naechste Cntnt- oder
TableNode
- * gesucht, der Frames besitzt ( zum Einsammeln der pUpper ), ansonsten wird
- * erwartet, das rNode bereits auf einem solchen Cntnt- oder TableNode sitzt,
- * vor oder hinter den eingefuegt werden soll.
- * --*/
-
+/**
+ * The main purpose of this ctor is to find the right SwModify to iterate over.
+ *
+ * @param bSearch sal_True: find the next Content or TableNode which contains
+ * Frames (to collect the pUpper).
+ * Else we assume that rNode points already to such a
+ * Content or TableNode.
+ * We insert before or after it.
+ */
SwNode* GoNextWithFrm(const SwNodes rNodes, SwNodeIndex *pIdx)
{
if( pIdx-GetIndex() = rNodes.Count() - 1 )
@@ -147,14 +147,14 @@ SwNode2LayImpl::SwNode2LayImpl( const SwNode rNode,
sal_uLong nIdx, sal_Bool bS
const SwNode* pNd;
if( bSearch || rNode.IsSectionNode() )
{
-// Suche den naechsten Cntnt/TblNode, der einen Frame besitzt,
-// damit wir uns vor/hinter ihn haengen koennen
+// Find the next Cntnt/TableNode that contains a Frame, so that we can
add
+// ourselves before/after it
if( !bSearch rNode.GetIndex() nIndex )
{
SwNodeIndex aTmp( *rNode.EndOfSectionNode(), +1 );
pNd = GoPreviousWithFrm( aTmp );
if( !bSearch pNd rNode.GetIndex() pNd-GetIndex() )
-pNd = NULL; // Nicht ueber den Bereich hinausschiessen
+pNd = NULL; // Do not go over the limits
bMaster = sal_False;
}
else
@@ -163,7 +163,7 @@ SwNode2LayImpl::SwNode2LayImpl( const SwNode rNode,
sal_uLong nIdx, sal_Bool bS
pNd = GoNextWithFrm( rNode.GetNodes(), aTmp );
bMaster = sal_True;
if( !bSearch pNd rNode.EndOfSectionIndex() pNd-GetIndex()
)
-pNd = NULL; // Nicht ueber den Bereich hinausschiessen
+pNd = NULL; // Do not go over the limits
}
}
[Libreoffice-commits] .: sw/source
sw/source/core/docnode/node2lay.cxx | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 3a1d4f029374086023bb908625bd2a5973e0b062
Author: Michael Stahl mst...@redhat.com
Date: Thu Nov 1 18:01:44 2012 +0100
tweak comment translation
Change-Id: I729612b2ffeea9c3c64f8f0c0c2313f48b965270
diff --git a/sw/source/core/docnode/node2lay.cxx
b/sw/source/core/docnode/node2lay.cxx
index 0690e72..013b478 100644
--- a/sw/source/core/docnode/node2lay.cxx
+++ b/sw/source/core/docnode/node2lay.cxx
@@ -201,7 +201,7 @@ SwNode2LayImpl::SwNode2LayImpl( const SwNode rNode,
sal_uLong nIdx, sal_Bool bS
*
* If the Frame is located in a SectionFrm, we check to see whether the
* SectionFrame is the suitable return value (instead of the Frame itself).
- * This is the case if the to-be-inserted Node is outside of the Area.
+ * This is the case if the to-be-inserted Node is outside of the Section.
*/
SwFrm* SwNode2LayImpl::NextFrm()
{
@@ -234,8 +234,8 @@ SwFrm* SwNode2LayImpl::NextFrm()
{
SwSectionFrm* pSct = pRet-FindSctFrm();
// ATTENTION: If we are in a Footnote, from a Layout point of
view
-// it could be located in an Area with columns, although it
should be
-// outside of it when looking at the Nodes.
+// it could be located in a Section with columns, although it
+// should be outside of it when looking at the Nodes.
// Thus, when dealing with Footnotes, we need to check whether
the
// SectionFrm is also located within the Footnote and not
outside of it.
if( !pRet-IsInFtn() || pSct-IsInFtn() )
@@ -243,9 +243,9 @@ SwFrm* SwNode2LayImpl::NextFrm()
OSL_ENSURE( pSct pSct-GetSection(), Where's my
section? );
SwSectionNode* pNd =
pSct-GetSection()-GetFmt()-GetSectionNode();
OSL_ENSURE( pNd, Lost SectionNode );
-// If the received Frame is located within an Area Frame
that does
-// not encompass the ExitNode, we return with the
SectionFrm, else
-// we return with the Cntnt/TabFrm
+// If the result Frame is located within a Section Frame
+// whose Section does not contain the Node, we return with
+// the SectionFrm, else we return with the Cntnt/TabFrm
if( bMaster )
{
if( pNd-GetIndex() = nIndex )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: oovbaapi/ooo oovbaapi/UnoApi_oovbaapi.mk
oovbaapi/UnoApi_oovbaapi.mk |2 +
oovbaapi/ooo/vba/adodb/DataTypeEnum.idl | 44 ++
oovbaapi/ooo/vba/adodb/ParameterDirectionEnum.idl |9
3 files changed, 55 insertions(+)
New commits:
commit 40a772d8746023c0a055d0a417610b3f3b9c034e
Author: Noel Power noel.po...@suse.com
Date: Wed Oct 31 16:59:10 2012 +
add some new ado constants bnc#787452
Change-Id: I1079cf87d223fc03e8cef53f69fa76ea4386c9b8
diff --git a/oovbaapi/UnoApi_oovbaapi.mk b/oovbaapi/UnoApi_oovbaapi.mk
index 3cd11a8..031766b 100644
--- a/oovbaapi/UnoApi_oovbaapi.mk
+++ b/oovbaapi/UnoApi_oovbaapi.mk
@@ -174,6 +174,7 @@ $(eval $(call
gb_UnoApi_add_idlfiles,oovbaapi,oovbaapi/ooo/vba/adodb,\
CursorLocationEnum \
CursorOptionEnum \
CursorTypeEnum \
+DataTypeEnum \
ErrorValueEnum \
EventReasonEnum \
EventStatusEnum \
@@ -184,6 +185,7 @@ $(eval $(call
gb_UnoApi_add_idlfiles,oovbaapi,oovbaapi/ooo/vba/adodb,\
MarshalOptionsEnum \
ObjectStateEnum \
ParameterAttributesEnum \
+ParameterDirectionEnum \
PersistFormatEnum \
PositionEnum \
PropertyAttributesEnum \
diff --git a/oovbaapi/ooo/vba/adodb/DataTypeEnum.idl
b/oovbaapi/ooo/vba/adodb/DataTypeEnum.idl
new file mode 100644
index 000..83741a5
--- /dev/null
+++ b/oovbaapi/ooo/vba/adodb/DataTypeEnum.idl
@@ -0,0 +1,44 @@
+module ooo { module vba { module adodb {
+constants DataTypeEnum {
+const long adArray = 8192;
+const long adBigInt = 20;
+const long adBinary = 128;
+const long adBoolean = 11;
+const long adBSTR = 8;
+const long adChapter = 136;
+const long adChar = 129;
+const long adCurrency = 6;
+const long adDate = 7;
+const long adDBDate = 133;
+const long adDBTime = 134;
+const long adDBTimeStamp = 135;
+const long adDecimal = 14;
+const long adDouble = 5;
+const long adEmpty = 0;
+const long adError = 10;
+const long adFileTime = 64;
+const long adGUID = 72;
+const long adIDispatch = 9;
+const long adInteger = 3;
+const long adIUnknown = 13;
+const long adLongVarBinary = 205;
+const long adLongVarChar = 201;
+const long adLongVarWChar = 203;
+const long adNumeric = 131;
+const long adPropVariant = 138;
+const long adSingle = 4;
+const long adSmallInt = 2;
+const long adTinyInt = 16;
+const long adUnsignedBigInt = 21;
+const long adUnsignedInt = 19;
+const long adUnsignedSmallInt = 18;
+const long adUnsignedTinyInt = 17;
+const long adUserDefined = 132;
+const long adVarBinary = 204 ;
+const long adVarChar = 200;
+const long adVariant = 12;
+const long adVarNumeric = 139;
+const long adVarWChar = 202;
+const long adWChar = 130;
+};
+}; }; };
diff --git a/oovbaapi/ooo/vba/adodb/ParameterDirectionEnum.idl
b/oovbaapi/ooo/vba/adodb/ParameterDirectionEnum.idl
new file mode 100644
index 000..2950921
--- /dev/null
+++ b/oovbaapi/ooo/vba/adodb/ParameterDirectionEnum.idl
@@ -0,0 +1,9 @@
+module ooo { module vba { module adodb {
+constants ParameterDirectionEnum {
+const long adParamInput = 1;
+const long adParamInputOutput = 3;
+const long adParamOutput = 2;
+const long adParamReturnValue = 4;
+const long adParamUnknown = 0;
+};
+}; }; };
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] Better way to initialize SwNode
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/960 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/960/1 Better way to initialize SwNode Change-Id: I6bc397d9ecd44975ebfa58014c6fe7cd470e4ada --- M sw/source/core/docnode/node.cxx 1 file changed, 23 insertions(+), 27 deletions(-) -- To view, visit https://gerrit.libreoffice.org/960 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6bc397d9ecd44975ebfa58014c6fe7cd470e4ada Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: svtools/inc
svtools/inc/svtools/treelist.hxx| 35 +++---
svtools/inc/svtools/treelistbox.hxx | 188 +---
2 files changed, 106 insertions(+), 117 deletions(-)
New commits:
commit e269e30a8bcbbe254e2819ac16ef8681fee0dbf5
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date: Thu Nov 1 09:52:46 2012 +0100
Translate German comments and improve some Germish
Change-Id: If733d06e2213af824884e49bd3414df1c23cb157
Reviewed-on: https://gerrit.libreoffice.org/955
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/svtools/inc/svtools/treelist.hxx b/svtools/inc/svtools/treelist.hxx
index 1473dff..467dda9 100644
--- a/svtools/inc/svtools/treelist.hxx
+++ b/svtools/inc/svtools/treelist.hxx
@@ -52,7 +52,7 @@
#define LISTACTION_RESORTED 10
#define LISTACTION_CLEARED 11
-// Entryflags, die an der View haengen
+// Entryflags that are attached to the View
#define SVLISTENTRYFLAG_SELECTED0x0001
#define SVLISTENTRYFLAG_EXPANDED0x0002
#define SVLISTENTRYFLAG_FOCUSED 0x0004
@@ -120,8 +120,8 @@ public:
enum SvSortMode { SortAscending, SortDescending, SortNone };
-// Rueckgabewerte Sortlink:
-// siehe International::Compare( pLeft, pRight )
+// For the return values of Sortlink:
+// See International::Compare( pLeft, pRight )
// ( Compare(a,b) == b.Compare(a) == strcmp(a,b) )
struct SvSortData
{
@@ -165,7 +165,7 @@ class SVT_DLLPUBLIC SvTreeList
SvTreeListEntry*LastSelected( const SvListView*) const;
sal_BoolSelect( SvListView*,SvTreeListEntry* pEntry, sal_Bool
bSelect=sal_True );
-voidSelectAll( SvListView*,sal_Bool bSelect ); // ruft
nicht Select-Hdl
+voidSelectAll( SvListView*,sal_Bool bSelect ); // Does not
call Select Handler
sal_uLong GetChildSelectionCount( const
SvListView*,SvTreeListEntry* pParent ) const;
voidExpand( SvListView*,SvTreeListEntry* pParent );
@@ -182,7 +182,7 @@ class SVT_DLLPUBLIC SvTreeList
*/
SVT_DLLPRIVATE void SetListPositions( SvTreeListEntries rEntries );
-// rPos wird bei SortModeNone nicht geaendert
+// rPos is not changed for SortModeNone
SVT_DLLPRIVATE void GetInsertionPos(
SvTreeListEntry* pEntry,
SvTreeListEntry* pParent,
@@ -217,7 +217,7 @@ public:
sal_uLong nPos=0
);
-// informiert alle Listener
+// Notify all Listeners
voidInvalidateEntry( SvTreeListEntry* );
sal_uLong GetEntryCount() const { return nEntryCount; }
@@ -237,10 +237,10 @@ public:
voidInsertTree( SvTreeListEntry* pTree, SvTreeListEntry*
pTargetParent, sal_uLong nListPos );
-// Entries muessen im gleichen Model stehen!
+// Entries need to be in the same Model!
voidMove( SvTreeListEntry* pSource, SvTreeListEntry*
pTarget );
-// erzeugt ggf. Child-List
+// Creates ChildList if needed
sal_uLong Move( SvTreeListEntry* pSource, SvTreeListEntry*
pTargetParent, sal_uLong nListPos);
voidCopy( SvTreeListEntry* pSource, SvTreeListEntry*
pTarget );
sal_uLong Copy( SvTreeListEntry* pSource, SvTreeListEntry*
pTargetParent, sal_uLong nListPos);
@@ -275,12 +275,11 @@ public:
sal_uInt16 GetDepth( const SvTreeListEntry* pEntry ) const;
bool IsAtRootDepth( const SvTreeListEntry* pEntry ) const;
-// das Model ruft zum Clonen von Entries den Clone-Link auf,
-// damit man sich nicht vom Model ableiten muss, wenn man
-// sich von SvTreeListEntry ableitet.
-// Deklaration des Clone-Handlers:
+// The Model calls the Clone Link to clone Entries.
+// Thus we do not need to derive from the Model if we derive from
SvTreeListEntry.
+// Declaration of the Clone Handler:
// DECL_LINK(CloneHdl,SvTreeListEntry*);
-// der Handler muss einen SvTreeListEntry* zurueckgeben
+// The Handler needs to return a SvTreeListEntry*
SvTreeListEntry*Clone( SvTreeListEntry* pEntry, sal_uLong
nCloneCount ) const;
voidSetCloneLink( const Link rLink )
{ aCloneLink=rLink; }
@@ -288,8 +287,8 @@ public:
const Link GetCloneLink() const
{ return aCloneLink; }
-virtual SvTreeListEntry*CloneEntry( SvTreeListEntry* pSource ) const;
// ruft den Clone-Link
-virtual SvTreeListEntry*CreateEntry() const; // zum 'new'en von Entries
+virtual SvTreeListEntry*CloneEntry( SvTreeListEntry* pSource ) const;
// Calls the Clone Link
+virtual SvTreeListEntry*CreateEntry() const; // To create Entries
sal_uInt16 GetRefCount() const { return nRefCount; }
voidSetRefCount( sal_uInt16 nRef ) { nRefCount = nRef; }
@@ -329,7 +328,7 @@ protected:
[PUSHED] Translate German comments
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/954 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/954 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cf27a705332c6e7ea62474c78d59911406d378e Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com Gerrit-Reviewer: Michael Stahl mst...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove commented code from dtrans
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/962 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/962/1 Remove commented code from dtrans Change-Id: I1ef4abb5b561107df257279708f619a1715e72c2 --- M dtrans/source/win32/dtobj/FmtFilter.cxx 1 file changed, 0 insertions(+), 110 deletions(-) -- To view, visit https://gerrit.libreoffice.org/962 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1ef4abb5b561107df257279708f619a1715e72c2 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Use memcpy instead of rtl_copyMemory in ucb
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/961 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/961/1 Use memcpy instead of rtl_copyMemory in ucb Change-Id: I1bdb02c6d607a10fee03d3044bad20cb811e9939 --- M ucb/source/ucp/webdav/SerfInputStream.cxx M ucb/source/ucp/webdav/SerfSession.cxx 2 files changed, 4 insertions(+), 4 deletions(-) -- To view, visit https://gerrit.libreoffice.org/961 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1bdb02c6d607a10fee03d3044bad20cb811e9939 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/source
sw/source/core/docnode/node.cxx | 46 ++--
1 file changed, 21 insertions(+), 25 deletions(-)
New commits:
commit 6f79559e1f91b4738f5227651eb1c6c23a14cd19
Author: Arnaud Versini arnaud.vers...@gmail.com
Date: Thu Nov 1 17:42:28 2012 +0100
Better way to initialize SwNode
Change-Id: I6bc397d9ecd44975ebfa58014c6fe7cd470e4ada
Reviewed-on: https://gerrit.libreoffice.org/960
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/sw/source/core/docnode/node.cxx b/sw/source/core/docnode/node.cxx
index 2da1706..98afd80 100644
--- a/sw/source/core/docnode/node.cxx
+++ b/sw/source/core/docnode/node.cxx
@@ -305,17 +305,20 @@ long SwNode::s_nSerial = 0;
#endif
SwNode::SwNode( const SwNodeIndex rWhere, const sal_uInt8 nNdType )
-: nNodeType( nNdType ), pStartOfSection( 0 )
+: nNodeType( nNdType )
+, nAFmtNumLvl( 0 )
+, bSetNumLSpace( false )
+, bIgnoreDontExpand( false)
+, pStartOfSection( 0 )
+#ifdef DBG_UTIL
+, m_nSerial( s_nSerial++)
+#endif
{
-bSetNumLSpace = bIgnoreDontExpand = false;
-nAFmtNumLvl = 0;
-
-SwNodes rNodes = (SwNodes)rWhere.GetNodes();
-SwNode* pInsNd = this; // The MAC cannot insert anything!
+SwNodes rNodes = const_castSwNodes (rWhere.GetNodes());
if( rWhere.GetIndex() )
{
SwNode* pNd = rNodes[ rWhere.GetIndex() -1 ];
-rNodes.InsertNode( pInsNd, rWhere );
+rNodes.InsertNode( this, rWhere );
if( 0 == ( pStartOfSection = pNd-GetStartNode()) )
{
pStartOfSection = pNd-pStartOfSection;
@@ -328,27 +331,25 @@ SwNode::SwNode( const SwNodeIndex rWhere, const
sal_uInt8 nNdType )
}
else
{
-rNodes.InsertNode( pInsNd, rWhere );
+rNodes.InsertNode( this, rWhere );
pStartOfSection = (SwStartNode*)this;
}
-
-#ifdef DBG_UTIL
-m_nSerial = s_nSerial;
-s_nSerial++;
-#endif
}
SwNode::SwNode( SwNodes rNodes, sal_uLong nPos, const sal_uInt8 nNdType )
-: nNodeType( nNdType ), pStartOfSection( 0 )
+: nNodeType( nNdType )
+, nAFmtNumLvl( 0 )
+, bSetNumLSpace( false )
+, bIgnoreDontExpand( false)
+, pStartOfSection( 0 )
+#ifdef DBG_UTIL
+,m_nSerial( s_nSerial++)
+#endif
{
-bSetNumLSpace = bIgnoreDontExpand = false;
-nAFmtNumLvl = 0;
-
-SwNode* pInsNd = this; // The MAC cannot insert anything!
if( nPos )
{
SwNode* pNd = rNodes[ nPos - 1 ];
-rNodes.InsertNode( pInsNd, nPos );
+rNodes.InsertNode( this, nPos );
if( 0 == ( pStartOfSection = pNd-GetStartNode()) )
{
pStartOfSection = pNd-pStartOfSection;
@@ -361,14 +362,9 @@ SwNode::SwNode( SwNodes rNodes, sal_uLong nPos, const
sal_uInt8 nNdType )
}
else
{
-rNodes.InsertNode( pInsNd, nPos );
+rNodes.InsertNode( this, nPos );
pStartOfSection = (SwStartNode*)this;
}
-
-#ifdef DBG_UTIL
-m_nSerial = s_nSerial;
-s_nSerial++;
-#endif
}
SwNode::~SwNode()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sw/inc sw/source
sw/inc/node.hxx | 10 +-
sw/source/core/docnode/node.cxx |6 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
New commits:
commit a4ec5de5ed537604ef0229990dc449821ad13a4f
Author: Michael Stahl mst...@redhat.com
Date: Thu Nov 1 18:46:02 2012 +0100
SwNode: reorder that to avoid -Werror=reorder
Change-Id: Ic58a5503dc6b7991c8804feef05b814d1055bfb9
diff --git a/sw/inc/node.hxx b/sw/inc/node.hxx
index 003d7b6..35ba3f2 100644
--- a/sw/inc/node.hxx
+++ b/sw/inc/node.hxx
@@ -91,11 +91,6 @@ class SW_DLLPUBLIC SwNode
{
friend class SwNodes;
-#ifdef DBG_UTIL
-static long s_nSerial;
-long m_nSerial;
-#endif
-
sal_uInt8 nNodeType;
/// For text nodes: level of auto format. Was put here because we had
still free bits.
@@ -103,6 +98,11 @@ class SW_DLLPUBLIC SwNode
bool bSetNumLSpace : 1; /// For numbering: TRUE: set indent.
bool bIgnoreDontExpand : 1; /// for Text Attributes - ignore the flag
+#ifdef DBG_UTIL
+static long s_nSerial;
+long m_nSerial;
+#endif
+
protected:
SwStartNode* pStartOfSection;
diff --git a/sw/source/core/docnode/node.cxx b/sw/source/core/docnode/node.cxx
index 98afd80..eea21de 100644
--- a/sw/source/core/docnode/node.cxx
+++ b/sw/source/core/docnode/node.cxx
@@ -309,10 +309,10 @@ SwNode::SwNode( const SwNodeIndex rWhere, const
sal_uInt8 nNdType )
, nAFmtNumLvl( 0 )
, bSetNumLSpace( false )
, bIgnoreDontExpand( false)
-, pStartOfSection( 0 )
#ifdef DBG_UTIL
, m_nSerial( s_nSerial++)
#endif
+, pStartOfSection( 0 )
{
SwNodes rNodes = const_castSwNodes (rWhere.GetNodes());
if( rWhere.GetIndex() )
@@ -341,10 +341,10 @@ SwNode::SwNode( SwNodes rNodes, sal_uLong nPos, const
sal_uInt8 nNdType )
, nAFmtNumLvl( 0 )
, bSetNumLSpace( false )
, bIgnoreDontExpand( false)
-, pStartOfSection( 0 )
#ifdef DBG_UTIL
-,m_nSerial( s_nSerial++)
+, m_nSerial( s_nSerial++)
#endif
+, pStartOfSection( 0 )
{
if( nPos )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.ac
configure.ac |3 +++ 1 file changed, 3 insertions(+) New commits: commit f3c09cc3c41e7ec1faf9dfef269a99a8ef7d5838 Author: Riccardo Magliocchetti riccardo.magliocche...@gmail.com Date: Thu Nov 1 18:48:53 2012 +0100 configure: don't accept -enable-headless where it won't work Don't even try to build --enable-headless where GUIBASE would not be unx. Change-Id: I6e5a6d3071317171f42c0b1336502cec50ba72fa diff --git a/configure.ac b/configure.ac index b420286..e1598e7 100644 --- a/configure.ac +++ b/configure.ac @@ -3945,6 +3945,9 @@ solaris*) esac if test $enable_headless = yes; then +if test $GUIBASE != unx; then +AC_MSG_ERROR([$host_os operating system is not suitable to build LibreOffice with --enable-headless]) +fi GUIBASE=headless fi ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Translate German comments and improve some Germish
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/955 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/955 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If733d06e2213af824884e49bd3414df1c23cb157 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com Gerrit-Reviewer: Michael Stahl mst...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Better way to initialize SwNode
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/960 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/960 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bc397d9ecd44975ebfa58014c6fe7cd470e4ada Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: no functional TinderBox for master/3-7 full Windows builds
Rats, working with David O's VC 2010 build of LOdev master, no improvement using the WRITE_REGISTRY=1 during installtion, nor with manually setting a SAL_ACCESSIBILITY_ENABLED environment variable. The Use Assistive Tools checkbox still won't hold its state. Stuart -- View this message in context: http://nabble.documentfoundation.org/no-functional-TinderBox-for-master-3-7-full-Windows-builds-tp4016034p4016373.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo# UniString replacement
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/964 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/964/1 fdo# UniString replacement Change-Id: Idf630c7e4627894f5edd68be0dc2588b90d7a930 --- M cui/source/dialogs/cuifmsearch.cxx M cui/source/factory/dlgfact.cxx M cui/source/factory/dlgfact.hxx M cui/source/inc/cuifmsearch.hxx M svx/inc/svx/svxdlg.hxx 5 files changed, 5 insertions(+), 5 deletions(-) -- To view, visit https://gerrit.libreoffice.org/964 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idf630c7e4627894f5edd68be0dc2588b90d7a930 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
fdo# UniString replacement
Ricardo Montania has abandoned this change. Change subject: fdo# UniString replacement .. Patch Set 1: Abandoned Wrong description -- To view, visit https://gerrit.libreoffice.org/964 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Idf630c7e4627894f5edd68be0dc2588b90d7a930 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#38838 UniString replacement
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/965 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/965/1 fdo#38838 UniString replacement Change-Id: I1323b2caf395c10b34e7467284402c0e3082f6a7 --- M cui/source/dialogs/cuifmsearch.cxx M cui/source/factory/dlgfact.cxx M cui/source/factory/dlgfact.hxx M cui/source/inc/cuifmsearch.hxx M svx/inc/svx/svxdlg.hxx 5 files changed, 5 insertions(+), 5 deletions(-) -- To view, visit https://gerrit.libreoffice.org/965 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1323b2caf395c10b34e7467284402c0e3082f6a7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#46807: Add LRM before the Shekel sign, forcing it to app...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/967 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/967/1 fdo#46807: Add LRM before the Shekel sign, forcing it to appear left of numbers Change-Id: I40a762bf03a15f241fc80279bb61be9a2710d2f0 --- M i18npool/source/localedata/data/he_IL.xml 1 file changed, 2 insertions(+), 2 deletions(-) -- To view, visit https://gerrit.libreoffice.org/967 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I40a762bf03a15f241fc80279bb61be9a2710d2f0 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Lior Kaplan kaplanl...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Change in core[master]: Consolidate ₪ appearances to a CURRENCY template
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/966 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/966/1 Consolidate ₪ appearances to a CURRENCY template Change-Id: Ibde3ac38e27e5abb42aa5d538762a3a5a7401f2b --- M i18npool/source/localedata/data/he_IL.xml 1 file changed, 6 insertions(+), 6 deletions(-) -- To view, visit https://gerrit.libreoffice.org/966 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibde3ac38e27e5abb42aa5d538762a3a5a7401f2b Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Lior Kaplan kaplanl...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
GTK theming: oxygen-gtk support broken
Hello, Some time after my commits, which enabled almost fully correct oxygen-gtk support (latest commit was on Jul 8 2012), this support was broken. See screenshots at [1], [2], [3] and [4] for details. Those who hacked on GTK theming support since Jul 8 2012, please have a look at this. If you think it's oxygen-gtk which should be fixed, not libreoffice, please report the particular problems to https://bugs.kde.org (product=Oxygen, component=gtk2-engine). I'll be happy to improve things on oxygen-gtk side. Thanks, Ruslan [1] Edit field and combo button sizes mismatch: http://i.imgur.com/lnvfS.png [2] Background gradient not rendered: http://i.imgur.com/lRPLY.png [3] Text line entry clips text to the left too much http://i.imgur.com/sV10D.png [4] Menu expansion arrows are clipped at top: http://i.imgur.com/Gn67Z.png ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 3 commits - sc/inc sc/qa sc/source
sc/inc/column.hxx | 11 ---
sc/inc/document.hxx |3 ---
sc/inc/table.hxx|4
sc/qa/unit/ucalc.cxx|7 +++
sc/source/core/data/column.cxx | 15 ---
sc/source/core/data/column3.cxx |3 ---
sc/source/core/data/documen3.cxx| 12
sc/source/core/data/document.cxx| 16
sc/source/core/data/table1.cxx | 11 +++
sc/source/core/data/table2.cxx | 35 ---
sc/source/core/data/table3.cxx | 12
sc/source/core/data/table6.cxx |5 -
sc/source/filter/excel/colrowst.cxx |5 -
sc/source/ui/docshell/dbdocimp.cxx |1 -
sc/source/ui/docshell/docfunc.cxx |8
sc/source/ui/docshell/docsh.cxx | 10 --
sc/source/ui/docshell/docsh8.cxx|3 ---
sc/source/ui/docshell/impex.cxx |2 --
sc/source/ui/docshell/olinefun.cxx | 15 +++
sc/source/ui/undo/undoblk.cxx | 16
sc/source/ui/unoobj/cellsuno.cxx|6 --
21 files changed, 37 insertions(+), 163 deletions(-)
New commits:
commit 52faa1f933f07ac93752dffdc1a35620029252e3
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu Nov 1 16:28:57 2012 -0400
Explicitly call these methods to init / update note positions.
Since we don't use inc / dec recalc level, we need to do this.
Change-Id: Ia99b4dbfceefd1ed951a61374250c5c61e39a62a
diff --git a/sc/source/ui/docshell/docfunc.cxx
b/sc/source/ui/docshell/docfunc.cxx
index 1882593..e77f4ca 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -1499,6 +1499,8 @@ sal_Bool ScDocFunc::InsertCells( const ScRange rRange,
const ScMarkData* pTabMa
itr = aMark.begin();
for (; itr != itrEnd nTabCount; ++itr)
{
+pDoc-InitializeNoteCaptions(*itr);
+
i = *itr;
if( pDoc-HasAttrib( nMergeTestStartX, nMergeTestStartY, i,
nMergeTestEndX, nMergeTestEndY, i, HASATTR_MERGED | HASATTR_OVERLAPPED ) )
{
@@ -1721,6 +1723,8 @@ sal_Bool ScDocFunc::InsertCells( const ScRange rRange,
const ScMarkData* pTabMa
for (; itr != itrEnd *itr nTabCount; ++itr)
{
i = *itr;
+pDoc-SetDrawPageSize(i);
+
if (bNeedRefresh)
pDoc-ExtendMerge( nMergeTestStartX, nMergeTestStartY,
nMergeTestEndX, nMergeTestEndY, i, sal_True );
else
@@ -1904,6 +1908,8 @@ sal_Bool ScDocFunc::DeleteCells( const ScRange rRange,
const ScMarkData* pTabMa
itr = aMark.begin();
for (; itr != itrEnd *itr nTabCount; ++itr)
{
+pDoc-InitializeNoteCaptions(*itr);
+
SCTAB i = *itr;
if ( pDoc-HasAttrib( nUndoStartX, nUndoStartY, i, nMergeTestEndX,
nMergeTestEndY, i, HASATTR_MERGED | HASATTR_OVERLAPPED ))
{
@@ -2227,6 +2233,8 @@ sal_Bool ScDocFunc::DeleteCells( const ScRange rRange,
const ScMarkData* pTabMa
itr = aMark.begin(), itrEnd = aMark.end();
for (; itr != itrEnd *itr nTabCount; ++itr)
{
+pDoc-SetDrawPageSize(*itr);
+
if ( eCmd == DEL_DELCOLS || eCmd == DEL_DELROWS )
pDoc-UpdatePageBreaks( *itr );
diff --git a/sc/source/ui/undo/undoblk.cxx b/sc/source/ui/undo/undoblk.cxx
index 3fe71b1..754aed1 100644
--- a/sc/source/ui/undo/undoblk.cxx
+++ b/sc/source/ui/undo/undoblk.cxx
@@ -284,6 +284,10 @@ void ScUndoInsertCells::Undo()
BeginUndo();
DoChange( sal_True );
EndUndo();
+
+ScDocument* pDoc = pDocShell-GetDocument();
+for (SCTAB i = 0; i nCount; ++i)
+pDoc-SetDrawPageSize(pTabs[i]);
}
void ScUndoInsertCells::Redo()
@@ -295,6 +299,10 @@ void ScUndoInsertCells::Redo()
if ( pPasteUndo )
pPasteUndo-Redo(); // redo paste last
+
+ScDocument* pDoc = pDocShell-GetDocument();
+for (SCTAB i = 0; i nCount; ++i)
+pDoc-SetDrawPageSize(pTabs[i]);
}
void ScUndoInsertCells::Repeat(SfxRepeatTarget rTarget)
@@ -519,6 +527,10 @@ void ScUndoDeleteCells::Undo()
pViewShell-MarkRange( ScRange(aEffRange.aStart.Col(),
aEffRange.aStart.Row(), pTabs[i], aEffRange.aEnd.Col(), aEffRange.aEnd.Row(),
pTabs[i]+pScenarios[i]) );
}
}
+
+ScDocument* pDoc = pDocShell-GetDocument();
+for (SCTAB i = 0; i nCount; ++i)
+pDoc-SetDrawPageSize(pTabs[i]);
}
void ScUndoDeleteCells::Redo()
@@ -532,6 +544,10 @@ void ScUndoDeleteCells::Redo()
ScTabViewShell* pViewShell = ScTabViewShell::GetActiveViewShell();
if (pViewShell)
pViewShell-DoneBlockMode();// current way
+
+ScDocument* pDoc = pDocShell-GetDocument();
+for (SCTAB i = 0; i nCount; ++i)
+pDoc-SetDrawPageSize(pTabs[i]);
}
void ScUndoDeleteCells::Repeat(SfxRepeatTarget rTarget)
commit b10833d4db6046f2d32ea44a60cb19a626d80447
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu
Re: converting Windows libraries (does librsvg work?)
Hi Regina, * On 31 October 2012 14:01, Regina Henschel rb.hensc...@t-online.de wrote: Hi Matúš, Matúš Kukan schrieb: Hi, [..] It's nice that librsvg has been converted, but does it also work ? (I can't test it) For example in 'about' dialog you should see nice background, but without librsvg nothing (I've tested this on Linux) (btw: the code is in vcl/source/components/rasterizer_rsvg.cxx ) Would I need to do something? With my build on WinXP I get the default Windows background in the 'About' dialog. Thanks for trying, You probably still have built-by-dmake librsvg around somewhere. I finally got to my Windows VM, downloaded .msi from http://dev-builds.libreoffice.org/daily/W2008R2@16-minimal_build/master/current/ And indeed, there was no background image in about dialog. After copying librsvg from older build, it's fixed. All the best, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: About shapeexport.cxx in xmloff
On Thu, 2012-11-01 at 02:51 -0700, julien2412 wrote:
Why shouldn't we uncomment case 3?
nDisplay could be equalled to 3 and eDisplayToken is
XML_TOKEN_INVALID by default
XMLTokenEnum eDisplayToken = XML_TOKEN_INVALID;
...
switch( (bVisible 1) | bPrintable )
{
case 0: eDisplayToken = XML_NONE; break;
case 1: eDisplayToken = XML_PRINTER; break;
case 2: eDisplayToken = XML_SCREEN; break;
// case 3: eDisplayToken = XML_ALWAYS break; this is the default
}
...
if( eDisplayToken != XML_TOKEN_INVALID )
mrExport.AddAttribute(XML_NAMESPACE_DRAW_EXT, XML_DISPLAY,
eDisplayToken );
The idea just seems to be that the default behaviour for that tag is
that if no xml-display attribute is set, then the importer is to act as
if xml-always was present. So its a little size optimization to not
export the attribute if it equals the default value.
For clarity, if you wanted, you could change the initial
XMLTokenEnum eDisplayToken = XML_TOKEN_INVALID;
to
XMLTokenEnum eDisplayToken = XML_ALWAYS;
and change
if( eDisplayToken != XML_TOKEN_INVALID )
to
if( eDisplayToken != XML_ALWAYS )
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: CPPUNIT road map, recent changes etc.
On 01/11/2012 10:17, Michael Meeks wrote: On Tue, 2012-10-30 at 22:29 +, John McCabe wrote: Just found this fork but a bit disappointed with the lack of information on the wiki. Is there a road map? What are the changes between 1.12.1 and the latest release? Has documentation been updated? Help updating the wiki would be lovely :-) I'll have a think about it :-) and/or do you have any fixes / improvements / patches you want to see in cppunit ? either way Markus is maintaining that currently - but has a huge amount of good work on his plate, so help appreciated (I suspect) :-) I'm only just getting to the point where, hopefully, I'll be able to use CppUnit in more depth so I don't really have anything to contribute at the moment. We'll see how it goes though! Thanks for your reply. John ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Fix copypaste in test
The patch is attached. -- Att, Marcos Paulo de Souza Acadêmico de Ciencia da Computação - FURB - SC Github: https://github.com/marcosps/ Uma vida sem desafios é uma vida sem razão A life without challenges, is a non reason life 0001-Fix-copy-paste-in-test.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/qa
sw/qa/core/filters-test.cxx |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit 1219bcb0c4f1dd1753c8bb63baf957f878971b70
Author: Caolán McNamara caol...@redhat.com
Date: Thu Nov 1 23:25:51 2012 +
WaE: MacOSX, clipboard id just has to be non-zero
Change-Id: If4edbe6fdb56e4b8fd8545404267dea7009a8c7a
diff --git a/sw/qa/core/filters-test.cxx b/sw/qa/core/filters-test.cxx
index 46a1af6..ed2e3ef 100644
--- a/sw/qa/core/filters-test.cxx
+++ b/sw/qa/core/filters-test.cxx
@@ -104,19 +104,21 @@ bool SwFiltersTest::load(const rtl::OUString rFilter,
const rtl::OUString rURL
return bLoaded;
}
+#define isstorage 1
+
void SwFiltersTest::testCVEs()
{
testDir(rtl::OUString(Staroffice XML (Writer)),
getURLFromSrc(/sw/qa/core/data/xml/),
rtl::OUString(FILTER_XML),
SFX_FILTER_IMPORT | SFX_FILTER_OWN | SFX_FILTER_DEFAULT,
--1, SOFFICE_FILEFORMAT_CURRENT);
+isstorage, SOFFICE_FILEFORMAT_CURRENT);
testDir(rtl::OUString(writer8),
getURLFromSrc(/sw/qa/core/data/odt/),
rtl::OUString(FILTER_XML),
SFX_FILTER_IMPORT | SFX_FILTER_OWN | SFX_FILTER_DEFAULT,
--1, SOFFICE_FILEFORMAT_CURRENT);
+isstorage, SOFFICE_FILEFORMAT_CURRENT);
testDir(rtl::OUString(MS Word 97),
getURLFromSrc(/sw/qa/core/data/ww8/),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 5 commits - sc/source
sc/source/core/data/column.cxx | 122 +++--
1 file changed, 57 insertions(+), 65 deletions(-)
New commits:
commit 157b804ba1dad4b857bd723c454ab907b623a980
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu Nov 1 20:16:15 2012 -0400
Add comments to make it easier to follow this non-obvious code.
Change-Id: Ib3d3e5b57799c22916845899839ddcc9a81e9b98
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 1321cd2..5debdd1 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -1484,6 +1484,7 @@ void ScColumn::MoveTo(SCROW nStartRow, SCROW nEndRow,
ScColumn rCol)
SCSIZE i;
Search( nStartRow, i); // i points to start row or position thereafter
SCSIZE nStartPos = i;
+// First, copy the cell instances to the new column.
for ( ; i maItems.size() maItems[i].nRow = nEndRow; ++i)
{
SCROW nRow = maItems[i].nRow;
@@ -1531,15 +1532,16 @@ void ScColumn::MoveTo(SCROW nStartRow, SCROW nEndRow,
ScColumn rCol)
nStartPos = (*it).first;
nStopPos = (*it).second;
for (i=nStartPos; inStopPos; ++i)
-maItems[i].pCell = pNoteCell;
+maItems[i].pCell = pNoteCell; // Assign the dumpy cell
instance to all slots.
for (i=nStartPos; inStopPos; ++i)
{
rAddress.SetRow( maItems[i].nRow );
pDocument-AreaBroadcast( aHint );
}
+// Erase the slots containing pointers to the dummy cell instance.
maItems.erase(maItems.begin() + nStartPos, maItems.begin() +
nStopPos);
}
-pNoteCell-Delete();
+pNoteCell-Delete(); // Delete the dummy cell instance.
}
}
commit f978013f9b8d5256aa029a3572d905bebb55c5f4
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu Nov 1 20:11:22 2012 -0400
Remove the correct range, or else maItems would end up with invalid pointer.
nStopPos is non-inclusive, and STL's erase() method also expects a
non-inclusive end position (like any other STL methods do). It's wrong
to -1 here which would end up not erasing the last element containing
a pointer to the deleted cell instance.
Change-Id: Ia3ef4469b50695038836ff7b9b48172256032786
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 14e01f7..1321cd2 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -1537,7 +1537,7 @@ void ScColumn::MoveTo(SCROW nStartRow, SCROW nEndRow,
ScColumn rCol)
rAddress.SetRow( maItems[i].nRow );
pDocument-AreaBroadcast( aHint );
}
-maItems.erase(maItems.begin() + nStartPos, maItems.begin() +
nStopPos - 1);
+maItems.erase(maItems.begin() + nStartPos, maItems.begin() +
nStopPos);
}
pNoteCell-Delete();
}
commit 1c2ef32a78e1b59a7cb49218d78cf5abc70c8518
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu Nov 1 20:03:06 2012 -0400
Now this bConsecutive flag makes no sense.
Treat as if this flag is always false.
Change-Id: Ie1364ac54f95263aa316bf81f631e607843934d5
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index b1f81af..14e01f7 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -1481,7 +1481,6 @@ void ScColumn::MoveTo(SCROW nStartRow, SCROW nEndRow,
ScColumn rCol)
return;
::std::vectorSCROW aRows;
-bool bConsecutive = true;
SCSIZE i;
Search( nStartRow, i); // i points to start row or position thereafter
SCSIZE nStartPos = i;
@@ -1498,9 +1497,6 @@ void ScColumn::MoveTo(SCROW nStartRow, SCROW nEndRow,
ScColumn rCol)
typedef ::std::pairSCSIZE,SCSIZE PosPair;
typedef ::std::vectorPosPair EntryPosPairs;
EntryPosPairs aEntries;
-if (bConsecutive)
-aEntries.push_back( PosPair(nStartPos, nStopPos));
-else
{
bool bFirst = true;
nStopPos = 0;
commit 79979dd23104bf35aaa18bc3e80449fe5537499c
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu Nov 1 18:52:24 2012 -0400
This if statement is never true.
SCROW nRow = maItems[i].nRow;
and nRow will never be modified afterwards. So
if (nRow != maItems[i].nRow)
is never true.
Change-Id: I4f867a704d50138aee8c5e7f37464880470098c2
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 657..b1f81af 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -1490,11 +1490,6 @@ void ScColumn::MoveTo(SCROW nStartRow, SCROW nEndRow,
ScColumn rCol)
SCROW nRow = maItems[i].nRow;
aRows.push_back( nRow);
rCol.Insert( nRow, maItems[i].pCell);
-if (nRow != maItems[i].nRow)
-{ // Listener inserted
-
[Libreoffice-commits] .: boost/boost.6397.warnings.patch
boost/boost.6397.warnings.patch | 34 ++
1 file changed, 34 insertions(+)
New commits:
commit 069e4f80333b5d4027d91d334bc8dae6f5a68533
Author: Caolán McNamara caol...@redhat.com
Date: Thu Nov 1 23:26:43 2012 +
WaE: extra clang warnings
Change-Id: I69b105c39f67372331910b6957214d62e1f3818c
diff --git a/boost/boost.6397.warnings.patch b/boost/boost.6397.warnings.patch
index 380dfbc..c544d54 100644
--- a/boost/boost.6397.warnings.patch
+++ b/boost/boost.6397.warnings.patch
@@ -336,3 +336,37 @@
std::transform(new_array.index_base_list_.begin(),
new_array.index_base_list_.end(),
+--- misc/boost_1_44_0/boost/random/mersenne_twister.hpp
misc/build/boost_1_44_0/boost/random/mersenne_twister.hpp
+@@ -195,16 +195,16 @@
+ }
+ #endif
+
+- friend bool operator==(const mersenne_twister x, const mersenne_twister y)
++ friend bool operator==(const mersenne_twister x_, const mersenne_twister
y_)
+ {
+ for(int j = 0; j state_size; ++j)
+- if(x.compute(j) != y.compute(j))
++ if(x_.compute(j) != y_.compute(j))
+ return false;
+ return true;
+ }
+
+- friend bool operator!=(const mersenne_twister x, const mersenne_twister y)
+- { return !(x == y); }
++ friend bool operator!=(const mersenne_twister x_, const mersenne_twister
y_)
++ { return !(x_ == y_); }
+ #else
+ // Use a member function; Streamable concept not supported.
+ bool operator==(const mersenne_twister rhs) const
+--- misc/boost_1_44_0/boost/uuid/uuid_io.hpp
misc/build/boost_1_44_0/boost/uuid/uuid_io.hpp
+@@ -59,7 +59,7 @@
+ }
+
+ if (flags std::ios_base::left) {
+-for (std::streamsize i=uuid_width; iwidth; i++) {
++for (std::streamsize s=uuid_width; swidth; ++s) {
+ os fill;
+ }
+ }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[REVIEW 3-6] Fix for Calc crasher
Hi there, I'd like the attached patch pushed to the 3-6 branch. Without this patch, doing the following 1. Create a new Calc document. 2. Type some stuff into Cell D5. 3. Move the cursor to Cell C5. 4. Ctrl-+ to launch the Insert Cells dialog. Select Shift cell right and hit OK. 5. Ctrl-Z to undo. Would crash Calc right away. I'm actually surprised this has not been reported in bugzilla yet. Or perhaps it's there but never confirmed? I don't know which is the case. I just happened to have noticed this while testing Calc for something else. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc From 7f576562cb94fba2690298bb16c0b85d1de41f21 Mon Sep 17 00:00:00 2001 From: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu, 1 Nov 2012 20:36:25 -0400 Subject: [PATCH] Remove the correct range, or else maItems would end up with invalid pointer. nStopPos is non-inclusive, and STL's erase() method also expects a non-inclusive end position (like any other STL methods do). It's wrong to -1 here which would end up not erasing the last element containing a pointer to the deleted cell instance. Change-Id: Ic09ab4a6bb03d0f56bb854a91bf93a99be867116 --- sc/source/core/data/column.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx index eebb17a..79bf31f 100644 --- a/sc/source/core/data/column.cxx +++ b/sc/source/core/data/column.cxx @@ -1555,7 +1555,7 @@ void ScColumn::MoveTo(SCROW nStartRow, SCROW nEndRow, ScColumn rCol) rAddress.SetRow( maItems[i].nRow ); pDocument-AreaBroadcast( aHint ); } -maItems.erase(maItems.begin() + nStartPos, maItems.begin() + nStopPos - 1); +maItems.erase(maItems.begin() + nStartPos, maItems.begin() + nStopPos); } pNoteCell-Delete(); } -- 1.8.0 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/qa
sc/qa/unit/ucalc.cxx | 24
1 file changed, 24 insertions(+)
New commits:
commit 86b1ccc71cd8bc38599576ce6acab9cfab4d9231
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu Nov 1 21:47:16 2012 -0400
New unit test for shifting cells.
Change-Id: Ic004490ffaf1da5cdb43f0a1336437eb312813bf
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 247a75f..7c2c1af 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -228,6 +228,7 @@ public:
void testFindAreaPosColRight();
void testSort();
void testSortWithFormulaRefs();
+void testShiftCells();
void testDeleteRow();
void testDeleteCol();
@@ -281,6 +282,7 @@ public:
CPPUNIT_TEST(testFindAreaPosColRight);
CPPUNIT_TEST(testSort);
CPPUNIT_TEST(testSortWithFormulaRefs);
+CPPUNIT_TEST(testShiftCells);
CPPUNIT_TEST(testDeleteRow);
CPPUNIT_TEST(testDeleteCol);
CPPUNIT_TEST_SUITE_END();
@@ -5199,6 +5201,28 @@ void Test::testSort()
pDoc-DeleteTab(0);
}
+void Test::testShiftCells()
+{
+m_pDoc-InsertTab(0, foo);
+
+OUString aTestVal(Some Text);
+
+// Text into cell E5.
+m_pDoc-SetString(4, 3, 0, aTestVal);
+
+// Insert cell at D5. This should shift the string cell to right.
+m_pDoc-InsertCol(3, 0, 3, 0, 3, 1);
+OUString aStr = m_pDoc-GetString(5, 3, 0);
+CPPUNIT_ASSERT_MESSAGE(We should have a string cell here., aStr ==
aTestVal);
+
+// Delete cell D5, to shift the text cell back into D5.
+m_pDoc-DeleteCol(3, 0, 3, 0, 3, 1);
+aStr = m_pDoc-GetString(4, 3, 0);
+CPPUNIT_ASSERT_MESSAGE(We should have a string cell here., aStr ==
aTestVal);
+
+m_pDoc-DeleteTab(0);
+}
+
void Test::testDeleteRow()
{
ScDocument* pDoc = m_xDocShRef-GetDocument();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] Bugzilla administration info - New version 3.6.3.3
Today new Version 3.6.3.2 release has been added. BSA has also been updated Note: 3.6.3.2 rc was changed to 3.6.3.2 release because of release notes stating they are identical Regards, Joel -- *Joel Madero* LibO QA Volunteer jmadero@gmail.com ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] want to contribute
Hi Rizwan! Am 31.10.2012 um 19:06 schrieb Michael Meeks michael.me...@suse.com: Hi Rizwan, It'd be great to have you involved with LibreOffice :-) On Wed, 2012-10-31 at 01:23 +0530, Rizwan Alam wrote: I want to contribute to libreoffice how ever i do not have experience. I am a bit confused. I was thinking about doing testing can any one help me out. Hmm... IMHO The next thing (skipped) are dev - topics... As from the QA part the thing below is important... To get started, you may use tis queries according to your OS... http://pastehtml.com/view/calh0sflu.html [...] it's very useful to do bug triage: http://wiki.documentfoundation.org/BugTriage Checking confirming bugs moving them to the 'NEW' state, or marking them as duplicates. Help much appreciated ! All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ Enjoy the time with LibO :) If you have any questions, ask :) Florian R. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Bugzilla administration info - New version 3.6.3.3
On Thu, 01 Nov 2012 17:01:11 +0100, Joel Madero jmadero@gmail.com wrote: Today new Version 3.6.3.2 release has been added. BSA has also been updated Note: 3.6.3.2 rc was changed to 3.6.3.2 release because of release notes stating they are identical Regards, Joel so, if 3.6.3.2 rc is identical to 3.6.3.2 final, who is 3.6.3.3? ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Online update testing
Am 04.10.2012 16:35, schrieb klaus-jürgen weghorn ol: Hi, Am 16.08.2012 15:53, schrieb Jan Holesovsky: Hi Klaus-Juergen, all, I'd like to ask you test the online update a bit. I had to do some larger changes in order to be able to update the 3.5 line to 3.5.6, so now it explicitly preselects 3.5.6 for you, when you try to update from an older version. The 3.6 update (from the previous RC's, for example) should lead you to the generic download page. Please let me know should you find any trouble :-) my 3.6.2.1 is up to date. Shouldn't be so. And again, 3.6.3.1 is up to date. -- Grüße k-j ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] 3.7 bug hunt party ?
Hi all, Having some experience with this, I'm willing to try to help organising something like a BHP again. Starting from 'scratch' three goals come to my mind: a - hunting bugs in 3.7 b - introducing people in submitting and triage of bugs c - introducing people in (release) testing wrt b and c: when we target for a BHP somewhere half December, would that be fine for people working on the bug submission assistant and Moztrap ? Best, Cor -- - Cor - http://nl.libreoffice.org - www.librelex.org ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 56595] FILESAVE: ToC links broken in xhtml export - hrefs start with bogus './'
https://bugs.freedesktop.org/show_bug.cgi?id=56595 --- Comment #2 from callow.m...@artspark.co.jp --- This happens in files created by File Export XHTML. A file created by File Save As HTML does not have this problem. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56611] FILESAVE: No warning message if result file format has any limitations in rows or columns (xlsx - xls)
https://bugs.freedesktop.org/show_bug.cgi?id=56611 --- Comment #1 from Timon kaktebyaviru...@gmail.com --- We see only standart message that is shown in almost all cases when not saving in ODF format - This document may contain formatting of content that cannot be saved in the currently selected file format Microsoft Excel 97/2000/XP/2003. Use the default ODF file format to be sure that the document is saved correctly. And no a word, that some of content would be missed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39179] FileOpen: Writer takes very long to open a docx file
https://bugs.freedesktop.org/show_bug.cgi?id=39179 --- Comment #18 from Julien Nabet serval2...@yahoo.fr --- Created attachment 69376 -- https://bugs.freedesktop.org/attachment.cgi?id=69376action=edit some bts at random I attached some bts taken at random -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54082] FILESAVE: Calc corrupting some XLS files on save
https://bugs.freedesktop.org/show_bug.cgi?id=54082 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de --- Comment #9 from Julien Nabet serval2...@yahoo.fr --- Rainer: oups, forgot to put you on cc whereas I had a question for your comment5. https://bugs.freedesktop.org/show_bug.cgi?id=54082#c5 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56583] Impress crashes when presentation starts (dual-head, no Xinerama)
https://bugs.freedesktop.org/show_bug.cgi?id=56583
Julien Nabet serval2...@yahoo.fr changed:
What|Removed |Added
CC||caol...@redhat.com
--- Comment #6 from Julien Nabet serval2...@yahoo.fr ---
Caolán: I know it hasn't been reproduced but does his bt can be helpful?
I only found that gdk_x11_window_set_user_timewas called only in
vcl/unx/gtk/window/gtkframe.cxx
817 static void lcl_set_user_time( GtkWindow* i_pWindow, guint32 i_nTime )
818 {
819 #if !GTK_CHECK_VERSION(3,0,0)
820 if( bGetSetUserTimeFn )
821 {
822 bGetSetUserTimeFn = false;
823 p_gdk_x11_window_set_user_time =
(setUserTimeFn)osl_getAsciiFunctionSymbol( GetSalData()-m_pPlugin,
gdk_x11_window_set_user_time );
824 }
and this function must be called by the function GtkSalFrame::Show in this same
file.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53883] Fileopen: Cannot open Microsoft (DOC, XLS, PPT) Files 6, 85 MB
https://bugs.freedesktop.org/show_bug.cgi?id=53883 --- Comment #10 from andis.lazd...@gmail.com --- Hi! The problem is somehow solved in 3.6.3.2 release. At least, when I'm opening problematic presentation files using File - Open, they are opened normally. In previous releases this approach also didn't work. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56316] EDITING: CONDITIONAL FORMATTING not included in copy-paste cell
https://bugs.freedesktop.org/show_bug.cgi?id=56316
Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
CC||er...@redhat.com,
||kohei.yosh...@suse.de,
||LibreOffice@bielefeldundbus
||s.de,
||markus.mohrhard@googlemail.
||com
Ever confirmed|0 |1
--- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
Because it seems there is not much interest in this bug, I confirm this one
because bug is [Reproducible] with Server Installation of LibreOffice
3.6.4.0+ English UI/ German Locale [Build-ID: be49b70],{tinderbox: Win-x86@9
pull time 2012-10-31 08:03:29} on German WIN7 Home Premium (64bit),
User-Profile 3.6.4 dailies
I think we can't ship a 3.6.3 with this known bug.
@Spreadsheet Team:
Please set Status to ASSIGNED and add yourself to Assigned To if you accept
this Bug.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56549] CONFIGURATION: Format → Autocorrect → Apply (and Edit Changes) crashes Writer
https://bugs.freedesktop.org/show_bug.cgi?id=56549 --- Comment #5 from Julien Nabet serval2...@yahoo.fr --- (In reply to comment #4) Created attachment 69335 [details] Compressed video showing the crash Oops, wrong video. See the attachment. When I try to open the video with Totem, it's upside-down (+ mirrored?) Meanwhile did you test with a brand new LO profile (see http://wiki.documentfoundation.org/UserProfile) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56596] FILESAVE: huge excesses of white space in xhtml export due to 'padding: 100%' in some CSS s...
https://bugs.freedesktop.org/show_bug.cgi?id=56596 --- Comment #4 from callow.m...@artspark.co.jp --- Created attachment 69377 -- https://bugs.freedesktop.org/attachment.cgi?id=69377action=edit 2 page .odt whose export has the bad padding Here is a short document. When exported, the .html file shows the bug. Look at the Code_* styles, for example. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56598] FILESAVE: no whitespace between subsection numbers and titles in XHTML export
https://bugs.freedesktop.org/show_bug.cgi?id=56598 --- Comment #1 from callow.m...@artspark.co.jp --- Created attachment 69378 -- https://bugs.freedesktop.org/attachment.cgi?id=69378action=edit 2 page .odt whose export shows the lack of spacing This export of this attachment shows both this bug and bug 56596 (hence its name). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56598] FILESAVE: no whitespace between subsection numbers and titles in XHTML export
https://bugs.freedesktop.org/show_bug.cgi?id=56598 --- Comment #2 from callow.m...@artspark.co.jp --- Oh! Use File Export XHTML. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42709] Animated GIFs not displaying correctly.
https://bugs.freedesktop.org/show_bug.cgi?id=42709 --- Comment #48 from Julien Nabet serval2...@yahoo.fr --- Thank you Andis for your screen copy demonstration (and your patience :-)). On pc Debian x86-64 with master sources updated yesterday, I reproduced the problem. The notes are animated but color is completely lost Badfully, I've got no specific logs on console giving some hints :-( -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56460] CRASH when closing specific .odg files
https://bugs.freedesktop.org/show_bug.cgi?id=56460
Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:
What|Removed |Added
OS|Linux (All) |All
Status|UNCONFIRMED |NEW
CC||r...@novell.com
Summary|: Crash when closing|CRASH when closing specific
|specific odg file |.odg files
Keywords||regression
Ever confirmed|0 |1
--- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
More or less [Reproducible with parallel installation of Master LOdev
3.7.0.0.alpha0+ - ENGLISH UI / German Locale [Build ID: af8098)]
{tinderbox: @16, pull time 2012-10-31 23:08:18} on German WIN7 Home Premium
(64bit) with separate User Profile for Master Branch.
I open a new WRITER document from LibO Start Center, open sample.odg from
Attachment 65473 using LibO File Open dialog, close without having edited using
menu 'File - Exit' or Window top right Close-X button. Sometimes no crash,
sometimes crash when close, sometimes crash when reopen form 'Recent Documents'
The Crash is not limited to that document, I will attach another one what also
shows the crash. Not all my Drawings crash, but I vound several additional ones
showing the CRASH problem.
@Radek:
Please set Status to ASSIGNED and add yourself to Assigned To if you accept
this Bug or forward the Bug if it's not your turf
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54157] LibreOffice 3.7 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on||56460 --- Comment #20 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Add Bug 56460 - CRASH when closing specific .odg files, many Drawings affected! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56460] CRASH when closing specific .odg files
https://bugs.freedesktop.org/show_bug.cgi?id=56460 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Blocks||54157 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56460] CRASH when closing specific .odg files
https://bugs.freedesktop.org/show_bug.cgi?id=56460 --- Comment #4 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Created attachment 69380 -- https://bugs.freedesktop.org/attachment.cgi?id=69380action=edit Additional Sample Document Currently I do no know what in the Drawings causes the crash. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49859] FORMATTING, UI: numbering alignment or indentation is not applied in Impress
https://bugs.freedesktop.org/show_bug.cgi?id=49859 --- Comment #7 from Winfried Donkers o...@dci-electronics.nl --- (In reply to comment #6) @Stephan: Ok, I will create a new bug for my problem. Trying to avoid duplicate bugs sometimes leads to polltion such as this ;) Given that the bug is still open: what is withholding the status resolved/fixed? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40863] Impress 3.4/3.5 prints polygons as rectangles and ovals as polygons
https://bugs.freedesktop.org/show_bug.cgi?id=40863 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|NEW |NEEDINFO CC||serval2...@yahoo.fr --- Comment #12 from Julien Nabet serval2...@yahoo.fr --- On Vista with 3.6.2.2 version, I made a test with pdfcreator and had same result of 3.3.4 so it seems ok. Could anybody give a try to 3.6.2? Even if the problem is reproduced with 3.5.7, there shouldn't be 3.5.8 (except if important fixes like crashes), so I don't know if it worths to test 3.5.7 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56630] New: FORMATTING, UI:numbering/bullets do not indent
https://bugs.freedesktop.org/show_bug.cgi?id=56630 Priority: medium Bug ID: 56630 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FORMATTING, UI:numbering/bullets do not indent Severity: normal Classification: Unclassified OS: All Reporter: o...@dci-electronics.nl Hardware: Other Status: NEW Version: 3.5.7.2 release Component: Presentation Product: LibreOffice in a slide: -press button 'bullets ON' -enter multiple lines; these are marked with a bullet -the buttons promote/demote left/right are disabled -pressing Alt+Shift+Left/Right produces irregular results, depending whether Align Right/centerd/etc. is active. Problem still exists in 3.6.3.2RC -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56630] FORMATTING, UI:numbering/bullets do not indent
https://bugs.freedesktop.org/show_bug.cgi?id=56630 Winfried Donkers o...@dci-electronics.nl changed: What|Removed |Added Blocks||48799 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48799] [Task] Formatting and UI for Bullets and Numbering broken
https://bugs.freedesktop.org/show_bug.cgi?id=48799 Winfried Donkers o...@dci-electronics.nl changed: What|Removed |Added Depends on||56630 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
