Re: Addin exceptions in SvStream
On Fri, Jan 04, 2013 at 01:45:11PM +0530, Marc-André Laverdière marcandre.laverdi...@gmail.com wrote: /usr/include/clang/Basic/LLVM.h:20:10: fatal error: 'llvm/Support/Casting.h' file not found Do you have llvm-devel (or equivalent) installed? signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - unotools/source vcl/source
unotools/source/misc/fontcvt.cxx | 100 +--
vcl/source/gdi/outdev3.cxx | 13 +
2 files changed, 108 insertions(+), 5 deletions(-)
New commits:
commit 11cc324da0e0008bca10ac19aca274cfec54ec2f
Author: Caolán McNamara caol...@redhat.com
Date: Tue Dec 18 16:06:03 2012 +
Related: fdo#50284 apple's modern symbol font is unicode encoded
So codepoints that are from the legacy range need to be converted to their
unicode equivalents even in the presence of an installed symbol font on
MacOSX.
This should work out ok if input codepoints that exist in the apple symbol
unicode are used, they should be left untouched by this conversion.
Change-Id: Ia9996e2d9bf632c86c8d26832d77c7c662cf1076
Reviewed-on: https://gerrit.libreoffice.org/1403
Reviewed-by: Miklos Vajna vmik...@suse.cz
Tested-by: Miklos Vajna vmik...@suse.cz
diff --git a/unotools/source/misc/fontcvt.cxx b/unotools/source/misc/fontcvt.cxx
index 3ab6913..47ee96e 100644
--- a/unotools/source/misc/fontcvt.cxx
+++ b/unotools/source/misc/fontcvt.cxx
@@ -806,6 +806,79 @@ static const sal_Unicode aMTExtraTab[224] =
0, 0, 0, 0
};
+static const sal_Unicode aAdobeSymbolToAppleSymbolTab[224] =
+{
+// F020
+0x0020,0x0021,0x2200,0x0023,
+0x2203,0x0025,0x0026,0x220D,
+0x0028,0x0029,0x2217,0x002B,
+0x002C,0x2212,0x002E,0x002F,
+// F030
+0x0030,0x0031,0x0032,0x0033,
+0x0034,0x0035,0x0036,0x0037,
+0x0038,0x0039,0x003A,0x003B,
+0x003C,0x003D,0x003E,0x003F,
+// F040
+0x2245,0x0391,0x0392,0x03A7,
+0x0394,0x0395,0x03A6,0x0393,
+0x0397,0x0399,0x03D1,0x039A,
+0x039B,0x039C,0x039D,0x039F,
+// F050
+0x03A0,0x0398,0x03A1,0x03A3,
+0x03A4,0x03A5,0x03C2,0x03A9,
+0x039E,0x03A8,0x0396,0x005B,
+0x2234,0x005D,0x22A5,0x005F,
+// F060
+0xF8E5,0x03B1,0x03B2,0x03C7,
+0x03B4,0x03B5,0x03C6,0x03B3,
+0x03B7,0x03B9,0x03D5,0x03BA,
+0x03BB,0x03BC,0x03BD,0x03BF,
+// F070
+0x03C0,0x03B8,0x03C1,0x03C3,
+0x03C4,0x03C5,0x03D6,0x03C9,
+0x03BE,0x03C8,0x03B6,0x007B,
+0x007C,0x007D,0x223C,0x007F,
+// F080
+0x0080,0x0081,0x0082,0x0083,
+0x0084,0x0085,0x0086,0x0087,
+0x0088,0x0089,0x008A,0x008B,
+0x008C,0x008D,0x008E,0x008F,
+// F090
+0x0090,0x0091,0x0092,0x0093,
+0x0094,0x0095,0x0096,0x0097,
+0x0098,0x0099,0x009A,0x009B,
+0x009C,0x009D,0x009E,0x009F,
+// F0a0
+0x20AC,0x03D2,0x2032,0x2264,
+0x2044,0x221E,0x0192,0x2663,
+0x2666,0x2665,0x2660,0x2194,
+0x2190,0x2191,0x2192,0x2193,
+// F0b0
+0x00B0,0x00B1,0x2033,0x2065,
+0x00D7,0x221D,0x2202,0x2022,
+0x00F7,0x2260,0x2261,0x2248,
+0x2026,0x23D0,0x23AF,0x21B5,
+// F0c0
+0x2135,0x2111,0x211C,0x2118,
+0x2297,0x2295,0x2205,0x2229,
+0x222A,0x2283,0x2287,0x2284,
+0x2282,0x2286,0x2208,0x2209,
+// F0d0
+0x2220,0x2207,0x00AE,0x00A9,
+0x2122,0x220F,0x221A,0x22C5,
+0x00AC,0x2227,0x2228,0x21D4,
+0x21D0,0x21D1,0x21D2,0x21D3,
+// F0e0
+0x25CA,0x3008,0x00AE,0x00A9,
+0x2122,0x2211,0x239B,0x239C,
+0x239D,0x23A1,0x23A2,0x23A3,
+0x23A7,0x23A8,0x23A9,0x23AA,
+// F0f0
+0xF8FF,0x3009,0x222B,0x2320,
+0x23AE,0x2321,0x239E,0x239F,
+0x23A0,0x23A4,0x23A5,0x23A6,
+0x23AB,0x23AC,0x23AD,0x00FF
+};
//===
@@ -1411,7 +1484,7 @@ void ConvertChar::RecodeString( String rStr, xub_StrLen
nIndex, xub_StrLen nLen
struct RecodeTable { const char* pOrgName; ConvertChar aCvt;};
-static RecodeTable aRecodeTable[] =
+static RecodeTable aStarSymbolRecodeTable[] =
{
// the first two entries must be StarMath and StarBats; do not reorder!
// reason: fgrep for FONTTOSUBSFONT_ONLYOLDSOSYMBOLFONTS
@@ -1435,6 +1508,10 @@ static RecodeTable aRecodeTable[] =
{mtextra, {aMTExtraTab, StarSymbol, NULL}}
};
+static RecodeTable aAppleSymbolRecodeTable[] = {
+{symbol, {aAdobeSymbolToAppleSymbolTab,
[PUSHED] Change in core[libreoffice-3-6]: Related: fdo#50284 apple's modern symbol font is unicode enc...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1403 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1403 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9996e2d9bf632c86c8d26832d77c7c662cf1076 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Caolán McNamara caol...@redhat.com Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - toolkit/inc
toolkit/inc/toolkit/controls/controlmodelcontainerbase.hxx |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
New commits:
commit 1cb77e94960d77b1d9cc9f06afa77cbe5920f282
Author: Noel Power noel.po...@suse.com
Date: Thu Dec 20 17:28:53 2012 +
fix dialog language support mess fdo#42978
during some rework ( not sure if it was me or not ) we try to register
ControlContainerBase on construction as a XModifyListener ( but it's not ).
Patch
make ControlContainerBase implement XModifyListener now. iirc the code in
question
was moved from UnoDialogControl at some stage and it appears some balls were
dropped :-)
Change-Id: Ifc7084bd7260ceb06334117582facb95bafb6fed
Reviewed-on: https://gerrit.libreoffice.org/1535
Reviewed-by: Miklos Vajna vmik...@suse.cz
Tested-by: Miklos Vajna vmik...@suse.cz
diff --git a/toolkit/inc/toolkit/controls/controlmodelcontainerbase.hxx
b/toolkit/inc/toolkit/controls/controlmodelcontainerbase.hxx
index d307c2a..3edf817 100644
--- a/toolkit/inc/toolkit/controls/controlmodelcontainerbase.hxx
+++ b/toolkit/inc/toolkit/controls/controlmodelcontainerbase.hxx
@@ -38,7 +38,7 @@
#include com/sun/star/beans/XPropertyChangeListener.hpp
#include com/sun/star/resource/XStringResourceResolver.hpp
#include cppuhelper/implbase8.hxx
-#include cppuhelper/implbase2.hxx
+#include cppuhelper/implbase3.hxx
#include toolkit/helper/listenermultiplexer.hxx
#include toolkit/controls/unocontrolmodel.hxx
#include toolkit/controls/unocontrolcontainer.hxx
@@ -216,9 +216,10 @@ class ResourceListener :public
::com::sun::star::util::XModifyListener,
bool
m_bListening;
};
-typedef ::cppu::AggImplInheritanceHelper2UnoControlContainer
+typedef ::cppu::AggImplInheritanceHelper3UnoControlContainer
, ::com::sun::star::container::XContainerListener
, ::com::sun::star::util::XChangesListener
+, ::com::sun::star::util::XModifyListener
ContainerControl_IBase;
class ControlContainerBase : public ContainerControl_IBase
@@ -259,6 +260,10 @@ public:
// ::com::sun::star::awt::XControl
sal_Bool SAL_CALL setModel( const ::com::sun::star::uno::Reference
::com::sun::star::awt::XControlModel Model )
throw(::com::sun::star::uno::RuntimeException);
void SAL_CALL setDesignMode( sal_Bool bOn )
throw(::com::sun::star::uno::RuntimeException);
+// XModifyListener
+// Using a dummy/no-op implementation here, not sure if every container
control needs
+// to implement this, certainly Dialog does, lets see about others
+virtual void SAL_CALL modified( const ::com::sun::star::lang::EventObject
) throw (::com::sun::star::uno::RuntimeException) {}
protected:
virtual void ImplModelPropertiesChanged( const
::com::sun::star::uno::Sequence ::com::sun::star::beans::PropertyChangeEvent
rEvents ) throw(::com::sun::star::uno::RuntimeException);
virtual void removingControl( const ::com::sun::star::uno::Reference
::com::sun::star::awt::XControl _rxControl );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Change in core[libreoffice-3-6]: fix dialog language support mess fdo#42978
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1535 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1535 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc7084bd7260ceb06334117582facb95bafb6fed Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Noel Power noel.po...@suse.com Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sfx2/source
sfx2/source/view/viewprn.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 0dbb66fb59205507824534b7130fab1cf2db3eae Author: Noel Power noel.po...@suse.com Date: Thu Jan 3 14:54:19 2013 + post OnPrint event ( application document ) when printing starts fdo#58269 this event used to get posted, somehow it seems it got dropped somewhere along the line ( looks like the printer and printer monitor code got reworked ) Conflicts: sfx2/inc/sfx2/sfx.hrc Change-Id: Ib75ee9e7ecd41614275033d2be2a351785326e24 Reviewed-on: https://gerrit.libreoffice.org/1536 Reviewed-by: Miklos Vajna vmik...@suse.cz Tested-by: Miklos Vajna vmik...@suse.cz diff --git a/sfx2/source/view/viewprn.cxx b/sfx2/source/view/viewprn.cxx index a8c19a2..d3a0818 100644 --- a/sfx2/source/view/viewprn.cxx +++ b/sfx2/source/view/viewprn.cxx @@ -326,6 +326,7 @@ void SfxPrinterController::jobStarted() now.Get100Sec(), now.GetSec(), now.GetMin(), now.GetHour(), now.GetDay(), now.GetMonth(), now.GetYear() ) ); +SFX_APP()-NotifyEvent( SfxEventHint(SFX_EVENT_PRINTDOC, GlobalEventConfig::GetEventName( STR_EVENT_PRINTDOC ), mpObjectShell ) ); // FIXME: how to get all print options incl. AdditionalOptions easily? uno::Sequence beans::PropertyValue aOpts; mpObjectShell-Broadcast( SfxPrintingHint( view::PrintableState_JOB_STARTED, aOpts ) ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Change in core[libreoffice-3-6]: post OnPrint event ( application document ) when printing ...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1536 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1536 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib75ee9e7ecd41614275033d2be2a351785326e24 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Noel Power noel.po...@suse.com Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: oox/source
oox/source/ppt/animationspersist.cxx|1 -
oox/source/ppt/animationtypes.cxx |4 ++--
oox/source/ppt/animationtypes.hxx |4 ++--
oox/source/ppt/animvariantcontext.cxx |1 -
oox/source/ppt/backgroundproperties.cxx |1 -
oox/source/ppt/commonbehaviorcontext.cxx|4 +---
oox/source/ppt/commonbehaviorcontext.hxx|6 +++---
oox/source/ppt/commontimenodecontext.cxx|1 -
oox/source/ppt/customshowlistcontext.cxx|2 +-
oox/source/ppt/dgmimport.cxx|1 -
oox/source/ppt/dgmlayout.cxx|1 -
oox/source/ppt/extdrawingfragmenthandler.cxx|1 -
oox/source/ppt/layoutfragmenthandler.cxx|1 -
oox/source/ppt/pptfilterhelpers.cxx |5 -
oox/source/ppt/pptfilterhelpers.hxx |2 +-
oox/source/ppt/pptgraphicshapecontext.cxx |1 -
oox/source/ppt/pptimport.cxx|1 -
oox/source/ppt/pptshape.cxx | 17 -
oox/source/ppt/pptshapecontext.cxx |3 +--
oox/source/ppt/pptshapegroupcontext.cxx |1 -
oox/source/ppt/pptshapepropertiescontext.cxx|1 -
oox/source/ppt/presentationfragmenthandler.cxx | 11 +--
oox/source/ppt/slidefragmenthandler.cxx |5 ++---
oox/source/ppt/slidemastertextstylescontext.cxx |1 -
oox/source/ppt/slidepersist.cxx | 18 +-
oox/source/ppt/slidetimingcontext.cxx |1 -
oox/source/ppt/slidetransition.cxx |1 -
oox/source/ppt/slidetransitioncontext.cxx |1 -
oox/source/ppt/soundactioncontext.cxx | 12
oox/source/ppt/timeanimvaluecontext.cxx |4 ++--
oox/source/ppt/timenode.cxx |2 --
oox/source/ppt/timenodelistcontext.cxx |6 ++
oox/source/ppt/timetargetelementcontext.cxx |2 --
33 files changed, 39 insertions(+), 84 deletions(-)
New commits:
commit 812ee7a6dc29b55acfbeaa1a43e632adbaf72e6b
Author: José Guilherme Vanz guilherme@gmail.com
Date: Mon Dec 31 00:48:04 2012 -0200
Removal rtl and string cleanup
This commit removes ::rtl:: prefixes and string cleanup in oox
Change-Id: I434462635392c750e2359f9d656d5e1885f2a0dc
Signed-off-by: Jose Guilherme Vanz guilherme@gmail.com
Reviewed-on: https://gerrit.libreoffice.org/1520
Reviewed-by: LOH KOK HOE huahsi...@gmail.com
Reviewed-by: Miklos Vajna vmik...@suse.cz
Tested-by: Miklos Vajna vmik...@suse.cz
diff --git a/oox/source/ppt/animationspersist.cxx
b/oox/source/ppt/animationspersist.cxx
index bf2a53a..74a9208 100644
--- a/oox/source/ppt/animationspersist.cxx
+++ b/oox/source/ppt/animationspersist.cxx
@@ -28,7 +28,6 @@
#include oox/drawingml/shape.hxx
-using rtl::OUString;
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::presentation;
using namespace ::com::sun::star::drawing;
diff --git a/oox/source/ppt/animationtypes.cxx
b/oox/source/ppt/animationtypes.cxx
index a79b0d6..a6ba788 100644
--- a/oox/source/ppt/animationtypes.cxx
+++ b/oox/source/ppt/animationtypes.cxx
@@ -31,7 +31,7 @@ using namespace ::com::sun::star::xml::sax;
namespace oox { namespace ppt {
// ST_TLTime
-Any GetTime( const ::rtl::OUString val )
+Any GetTime( const OUString val )
{
Any aDuration;
if( val.compareToAscii( indefinite ) == 0 )
@@ -47,7 +47,7 @@ Any GetTime( const ::rtl::OUString val )
// ST_TLTimeAnimateValueTime
-Any GetTimeAnimateValueTime( const ::rtl::OUString val )
+Any GetTimeAnimateValueTime( const OUString val )
{
Any aPercent;
if( val.compareToAscii( indefinite ) == 0 )
diff --git a/oox/source/ppt/animationtypes.hxx
b/oox/source/ppt/animationtypes.hxx
index 7e0b358..ab26abe 100644
--- a/oox/source/ppt/animationtypes.hxx
+++ b/oox/source/ppt/animationtypes.hxx
@@ -30,9 +30,9 @@
namespace oox { namespace ppt {
// ST_TLTime
-::com::sun::star::uno::Any GetTime( const ::rtl::OUString val );
+::com::sun::star::uno::Any GetTime( const OUString val );
// ST_TLTimeAnimateValueTime
-::com::sun::star::uno::Any GetTimeAnimateValueTime( const ::rtl::OUString
val );
+::com::sun::star::uno::Any GetTimeAnimateValueTime( const OUString val );
} }
diff --git a/oox/source/ppt/animvariantcontext.cxx
b/oox/source/ppt/animvariantcontext.cxx
index 8439d9d..51ff3a4 100644
--- a/oox/source/ppt/animvariantcontext.cxx
+++ b/oox/source/ppt/animvariantcontext.cxx
@@ -32,7 +32,6 @@
#include oox/drawingml/colorchoicecontext.hxx
#include pptfilterhelpers.hxx
-using ::rtl::OUString;
using namespace ::oox::core;
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::xml::sax;
diff --git a/oox/source/ppt/backgroundproperties.cxx
b/oox/source/ppt/backgroundproperties.cxx
index f38545c..b28512d 100644
--- a/oox/source/ppt/backgroundproperties.cxx
+++
[PUSHED] Removal rtl and string cleanup
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1520 Approvals: Miklos Vajna: Verified; Looks good to me, approved LOH KOK HOE: Looks good to me, but someone else must approve -- To view, visit https://gerrit.libreoffice.org/1520 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I434462635392c750e2359f9d656d5e1885f2a0dc Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: José Guilherme Vanz guilherme@gmail.com Gerrit-Reviewer: LOH KOK HOE huahsi...@gmail.com Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Error building with clang
Hi,
I am building with clang. I ran make clean and even wiped my ccache cache.
I run into this problem:
/home/marc-andre/lo/core/solver/unxlngx6.pro/inc/external/boost/uuid/seed_rng.hpp:143:61:
note: override this message by inserting an explicit cast
unsigned int rn[] = { std::rand(), std::rand(), std::rand() };
My system: Linux Mint 14 64 bit.
Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0)
Target: x86_64-pc-linux-gnu
Thread model: posix
ccache version 3.1.7
Note that when I build with --with-system-boost, I do not get this
error. The system version is 1.49.0.1
I am guessing that we are using a somewhat older version of boost.
So: a) can anyone duplicate this? b) which version of boost should we
upgrade to?
Marc-André LAVERDIÈRE
Perseverance must finish its work so that you may be mature and complete,
not lacking anything. -James 1:4
http://asimplediscipleslife.blogspot.com/
mlaverd.theunixplace.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Error building with clang
Hi Marc-André, On Fri, Jan 04, 2013 at 03:16:46PM +0530, Marc-André Laverdière marcandre.laverdi...@gmail.com wrote: Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0) https://wiki.documentfoundation.org/Development/Building_LibreOffice_with_Clang#Setup Says that 3.1 is needed, 3.0 may not work. HTH, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: editeng/source
editeng/source/editeng/editeng.src |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit d39f1fb508128c23c39c24e04b20a2f56c03cb5e
Author: Samuel Mehrbrodt s.mehrbr...@gmail.com
Date: Fri Jan 4 00:55:23 2013 +0100
Spellcheck menu: Rename 'Add' to 'Add to Dictionary'
Change-Id: I601bf1fc34f3e4cccef02d1d4a5ecd1959007cf7
Reviewed-on: https://gerrit.libreoffice.org/1539
Reviewed-by: Miklos Vajna vmik...@suse.cz
Tested-by: Miklos Vajna vmik...@suse.cz
diff --git a/editeng/source/editeng/editeng.src
b/editeng/source/editeng/editeng.src
index 2bea4aa..655861b 100644
--- a/editeng/source/editeng/editeng.src
+++ b/editeng/source/editeng/editeng.src
@@ -82,13 +82,13 @@ Menu RID_MENU_SPELL
SubMenu = Menu
{
};
-Text [ en-US ] = ~Add ;
+Text [ en-US ] = ~Add to Dictionary ;
};
MenuItem
{
Identifier = MN_INSERT_SINGLE ;
HelpId = HID_EDITENG_SPELLER_ADDWORD;
-Text [ en-US ] = ~Add ;
+Text [ en-US ] = ~Add to Dictionary ;
};
MenuItem
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Spellcheck menu: Rename 'Add' to 'Add to Dictionary'
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1539 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1539 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I601bf1fc34f3e4cccef02d1d4a5ecd1959007cf7 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/source
sw/source/ui/lingu/olmenu.src |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 645f17ba755a677f649313ddc95749a4aee2770e
Author: Miklos Vajna vmik...@suse.cz
Date: Fri Jan 4 10:54:54 2013 +0100
sw: Add - Add to dictionary in olmenu as well
As done for editeng in d39f1fb508128c23c39c24e04b20a2f56c03cb5e
diff --git a/sw/source/ui/lingu/olmenu.src b/sw/source/ui/lingu/olmenu.src
index ae0897f..29f0f23 100644
--- a/sw/source/ui/lingu/olmenu.src
+++ b/sw/source/ui/lingu/olmenu.src
@@ -40,13 +40,13 @@ Menu MN_SPELL_POPUP
SubMenu = Menu
{
};
-Text [ en-US ] = ~Add ;
+Text [ en-US ] = ~Add to dictionary ;
};
MenuItem
{
Identifier = MN_ADD_TO_DIC_SINGLE ;
HelpID = HID_LINGU_ADD_WORD ;
-Text [ en-US ] = ~Add ;
+Text [ en-US ] = ~Add to dictionary ;
};
MenuItem
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Error building with clang
On Friday 04 of January 2013, Marc-André Laverdière wrote:
Hi,
I am building with clang. I ran make clean and even wiped my ccache cache.
I run into this problem:
/home/marc-andre/lo/core/solver/unxlngx6.pro/inc/external/boost/uuid/seed_r
ng.hpp:143:61: note: override this message by inserting an explicit cast
unsigned int rn[] = { std::rand(), std::rand(), std::rand() };
Read again what the message says. This message is a hint how to fix the
problem, the error message precedes it.
Note that when I build with --with-system-boost, I do not get this
error. The system version is 1.49.0.1
I am guessing that we are using a somewhat older version of boost.
So: a) can anyone duplicate this? b) which version of boost should we
upgrade to?
Use whichever one works for you. I'll have a look at the internal copy.
--
Lubos Lunak
l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: why are we catching std::bad_alloc ?
On 04/01/13 08:53, Noel Grandin wrote: Why are we catching std::bad_alloc all over the place? git grep 'catch.*bad_alloc' | wc -l 68 Surely we should just let it crash? Or have a single handler for the whole process that at least attempts to provide some debugging data? At the moment, most of them just log something and then continues, which strikes me as counter-productive. there are 2 reasons why a std::alloc might be thrown that should be distinguished: 1. the box simply doesn't have enough RAM for the task (or alternatively the implementation is wasteful of memory), and some ordinary allocation fails; this is actually unlikely to happen in practice on some platforms like Linux that overcommit memory by default 2. there is a single enormous allocation (gigabytes) which is caused by reading some file; e.g. easy to do with a huge image in the first case, we'll just crash at some point anyway (and with overcommit in the OS we won't even be notified when there is _really_ no more memory, the kernel just kills the process), so there isn't a good reason to handle it. but the second case is usually caused by malicious input files that want to trigger some failure condition, and in that case it makes sense to handle the bad_alloc, abort the file import and continue. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] Spellcheck menu: Rename 'Add' to 'Add to Dictionary'
Thanks! Can this be pushed to 4.0 also? Samuel Am 04.01.2013 10:54, schrieb Miklos Vajna (via Code Review): Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1539 Approvals: Miklos Vajna: Verified; Looks good to me, approved ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: why are we catching std::bad_alloc ?
On 01/04/2013 08:53 AM, Noel Grandin wrote: Why are we catching std::bad_alloc all over the place? git grep 'catch.*bad_alloc' | wc -l 68 Surely we should just let it crash? Or have a single handler for the whole process that at least attempts to provide some debugging data? I agree that no memory is a kind of thing that could not allow to take proper reactions (in which case the whole system would be unusable), but when possible I think that an error message of any kind (together with debugging data) would at least make the user feel that the developers and the program are trying their best to offer a good and safe experience and careful data handling, making her more willing to provide useful information to fix the problem. If a program just crash, a possible user reaction could be why should I use it?. This is especially true if there are alternatives. Cheers Matteo At the moment, most of them just log something and then continues, which strikes me as counter-productive. Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Addin exceptions in SvStream
On 30/12/12 15:41, Marc-André Laverdière wrote: @Lubos. I started writing a plug-in. I have a problem with compiling, however. It somehow doesn't find the headers on my system. This is the autogen.sh I use (I tried with and without --includedir, and --includedir=/usr/) ./autogen.sh CC=clang CXX=clang++ --includedir=/usr/include/ --enable-compiler-plugins I get this in the output: checking clang/AST/RecursiveASTVisitor.h usability... no checking clang/AST/RecursiveASTVisitor.h presence... no checking for clang/AST/RecursiveASTVisitor.h... no configure: error: Cannot find Clang headers to build compiler plugins. Yet... $ ls /usr/include/clang/AST/RecursiveASTVisitor.h /usr/include/clang/AST/RecursiveASTVisitor.h I am on Linux Mint 14. Any clue what is going on? IIRC it needs llvm headers that *buntu puts in /usr/lib eg. /usr/lib/llvm-3.0/include Didn't know how I should patch the configure file tho ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - README.solver Repository.mk sdext/Library_minimizer.mk unusedcode.easy
sdext/Library_minimizer.mk |5 + 1 file changed, 5 insertions(+) New commits: commit 2f3749efd781c2095a5782eee1b070bc3dc0fcc0 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Fri Jan 4 11:28:06 2013 +0100 remove executable bit Change-Id: I41a0633cc6ebe2db8ad662132d727fb2ec3282ab diff --git a/README.solver b/README.solver old mode 100755 new mode 100644 diff --git a/Repository.mk b/Repository.mk old mode 100755 new mode 100644 diff --git a/unusedcode.easy b/unusedcode.easy old mode 100755 new mode 100644 commit bba8b65fdc5f19908794b338376ede3e3ea24463 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Fri Jan 4 11:24:29 2013 +0100 SunPresentationMinimizer uses uno interfaces Change-Id: I186af92084de6a7eee27d742d0377da09936473f diff --git a/sdext/Library_minimizer.mk b/sdext/Library_minimizer.mk index e5b4518..03fb85b 100644 --- a/sdext/Library_minimizer.mk +++ b/sdext/Library_minimizer.mk @@ -35,6 +35,11 @@ $(eval $(call gb_Library_use_externals,SunPresentationMinimizer,\ $(eval $(call gb_Library_use_sdk_api,SunPresentationMinimizer)) +$(eval $(call gb_Library_use_api,SunPresentationMinimizer,\ +offapi \ +udkapi \ +)) + $(eval $(call gb_Library_use_libraries,SunPresentationMinimizer,\ cppu \ cppuhelper \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Crash during Traditional Chinese - Simplified Chinese conversion
Hi Michael, On 01/03/2013 10:52 PM, Michael Stahl wrote: On 03/01/13 19:26, Matteo Casalin wrote: Hi all, I've been lately struggling with crash in conversion from Traditional to Simplified Chinese in Writer. After some debugging, I tracked the problem to access to released memory, but I don't know ho to proceed to solve the issue since it involves a deeper knowledge than I have about Writer internal structure. I really would appreciate if anybody could give me any hint on this. Here are the details: The conversion is handled by editeng::HangulHanjaConversion class, which is used as a base class for SwHHCWrapper (and is also derived in a parallel manner also in editeng itself). Without digging into details (the flow is quite convoluted), the problem arises in SwTxtNode::Convert (sw/source/core/txtnode/txtedt.cxx) as follow: * line 1074: instantiate a SwLanguageIterator object, which builds a list of pointers to non-copiable SwTxtAttr; * line : call SetLanguageAndFont, which destroys the original SwTxtAttr items which the iterator still points to; * line 1117: access the now deleted iterator items. so SwTxtNode::SetLanguageAndFont calls InsertItemSet, with a SvxFontItem, which will result in a RES_TXTATR_AUTOFMT hint... which may be combined (in SwpHints::MergePortions) with an existing RES_TXTATR_AUTOFMT that is adjacent to the insertion range (aCurPaM), provided that the item set on the adjacent hint contains the same attributes as the one on the insertion range. SwTxtNode::Convert appears clearly wrong to me in modifying the hints of a text node while iterating over them. (it is possible that this used to work in 2005 or earlier; i don't know if equal text hints were combined before the introduction of AUTOFMT, as i wasn't around back then). perhaps the insertion could be delayed until after the loop? Thanks for the detailed reply - unluckily I have no skills in Writer and its internals yet, so I do not understand the implications of the AUTOFMT attribute. By looking at the code, my understanding of what needs to be done in order to postpone the insertion is: * iterate over attributes in order to find the portion with the desired language, without inserting new properties; * save the information about that portion; * if necessary, re-iterate over the attributes with SetLanguageAndFont * return the previously saved information; This could be done only if properties that are inserted do not influence the search of the language in the first iterations or corrupt the saved information. Could this work? I really would like to fix the bug, but fear to break something else. Thanks again! Cheers Matteo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] Spellcheck menu: Rename 'Add' to 'Add to Dictionary'
Hi Samuel, first, thanks a lot for the nice improvement. Well, I would prefer to leave it in master. The dialog is not resizeable in LO-4.0 and the new string is much longer. There is a risk that it would not fit the dialog in some localizations. We are far from string freeze and too close to the hard UI and string freeze. I think that it is not worth the risk. Thanks for understanding. I am looking forward to see more improvements from you :-) Best Regards, Petr Samuel Mehrbrodt píše v Pá 04. 01. 2013 v 12:00 +0100: Thanks! Can this be pushed to 4.0 also? Samuel Am 04.01.2013 10:54, schrieb Miklos Vajna (via Code Review): Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1539 Approvals: Miklos Vajna: Verified; Looks good to me, approved ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 3 commits - sw/qa writerfilter/source
sw/qa/extras/ooxmlimport/data/n793262.docx |binary
sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 18 +++
writerfilter/source/dmapper/CellMarginHandler.cxx |6 -
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 17 --
writerfilter/source/dmapper/TablePropertiesHandler.cxx | 20 +
5 files changed, 58 insertions(+), 3 deletions(-)
New commits:
commit 1cec392ef50699cc0f310823e4e5fdbb9b272f0f
Author: Miklos Vajna vmik...@suse.cz
Date: Fri Jan 4 14:37:10 2013 +0100
n#793262 testcase
diff --git a/sw/qa/extras/ooxmlimport/data/n793262.docx
b/sw/qa/extras/ooxmlimport/data/n793262.docx
new file mode 100755
index 000..7f2d2e0
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/n793262.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 3b7a658..813b653 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -111,6 +111,7 @@ public:
void testN780645();
void testFineTableDash();
void testN792778();
+void testN793262();
CPPUNIT_TEST_SUITE(Test);
#if !defined(MACOSX) !defined(WNT)
@@ -174,6 +175,7 @@ void Test::run()
{n780645.docx, Test::testN780645},
{tableborder-finedash.docx, Test::testFineTableDash},
{n792778.docx, Test::testN792778},
+{n793262.docx, Test::testN793262},
};
header();
for (unsigned int i = 0; i SAL_N_ELEMENTS(aMethods); ++i)
@@ -1096,6 +1098,22 @@ void Test::testN792778()
xInnerShape.set(xInnerGroupShape-getByIndex(0), uno::UNO_QUERY);
CPPUNIT_ASSERT_EQUAL(sal_Int32(11684), xInnerShape-getPosition().Y);
}
+
+void Test::testN793262()
+{
+uno::Referencecontainer::XEnumerationAccess xHeaderText = getProperty
uno::Referencecontainer::XEnumerationAccess
(getStyles(PageStyles)-getByName(DEFAULT_STYLE), HeaderText);
+uno::Referencecontainer::XEnumeration
xHeaderParagraphs(xHeaderText-createEnumeration());
+xHeaderParagraphs-nextElement();
+// Font size of the last empty paragraph in the header was ignored, this
was 11.
+CPPUNIT_ASSERT_EQUAL(16.f,
getPropertyfloat(xHeaderParagraphs-nextElement(), CharHeight));
+
+uno::Referencetext::XTextTablesSupplier xTablesSupplier(mxComponent,
uno::UNO_QUERY);
+uno::Referencecontainer::XIndexAccess
xTables(xTablesSupplier-getTextTables(), uno::UNO_QUERY);
+uno::Referencetext::XTextTable xTable(xTables-getByIndex(0),
uno::UNO_QUERY);
+// Cell margins as direct formatting were ignored, this was 0.
+CPPUNIT_ASSERT_EQUAL(sal_Int32(76),
getPropertysal_Int32(xTable-getCellByName(A1), TopBorderDistance));
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(Test);
CPPUNIT_PLUGIN_IMPLEMENT();
commit 60ec497e0e91354a616978be531d15d3efa3f559
Author: Miklos Vajna vmik...@suse.cz
Date: Fri Jan 4 12:56:40 2013 +0100
n#793262 DOCX: import w:tcMar inside w:tc
These were ignored previously, and in case they contained some margins,
the resulting table was potentially smaller than necessary.
diff --git a/writerfilter/source/dmapper/CellMarginHandler.cxx
b/writerfilter/source/dmapper/CellMarginHandler.cxx
index 6ee219e..6119831 100644
--- a/writerfilter/source/dmapper/CellMarginHandler.cxx
+++ b/writerfilter/source/dmapper/CellMarginHandler.cxx
@@ -75,6 +75,7 @@ void CellMarginHandler::lcl_sprm(Sprm rSprm)
switch( rSprm.getId() )
{
case NS_ooxml::LN_CT_TblCellMar_top:
+case NS_ooxml::LN_CT_TcMar_top:
m_nTopMargin = m_nValue;
m_bTopMarginValid = true;
break;
@@ -91,10 +92,12 @@ void CellMarginHandler::lcl_sprm(Sprm rSprm)
}
break;
case NS_ooxml::LN_CT_TblCellMar_left:
+case NS_ooxml::LN_CT_TcMar_left:
m_nLeftMargin = m_nValue;
m_bLeftMarginValid = true;
break;
case NS_ooxml::LN_CT_TblCellMar_bottom:
+case NS_ooxml::LN_CT_TcMar_bottom:
m_nBottomMargin = m_nValue;
m_bBottomMarginValid = true;
break;
@@ -111,11 +114,12 @@ void CellMarginHandler::lcl_sprm(Sprm rSprm)
}
break;
case NS_ooxml::LN_CT_TblCellMar_right:
+case NS_ooxml::LN_CT_TcMar_right:
m_nRightMargin = m_nValue;
m_bRightMarginValid = true;
break;
default:
-OSL_FAIL( unknown attribute);
+OSL_FAIL( unknown sprm);
}
}
m_nValue = 0;
diff --git a/writerfilter/source/dmapper/TablePropertiesHandler.cxx
b/writerfilter/source/dmapper/TablePropertiesHandler.cxx
index 17e1a84..b1d560c 100644
--- a/writerfilter/source/dmapper/TablePropertiesHandler.cxx
+++ b/writerfilter/source/dmapper/TablePropertiesHandler.cxx
@@ -170,6 +170,26 @@ namespace dmapper {
Re: Crash during Traditional Chinese - Simplified Chinese conversion
On 01/04/2013 01:07 PM, Matteo Casalin wrote: Hi Michael, On 01/03/2013 10:52 PM, Michael Stahl wrote: On 03/01/13 19:26, Matteo Casalin wrote: Hi all, I've been lately struggling with crash in conversion from Traditional to Simplified Chinese in Writer. After some debugging, I tracked the problem to access to released memory, but I don't know ho to proceed to solve the issue since it involves a deeper knowledge than I have about Writer internal structure. I really would appreciate if anybody could give me any hint on this. Here are the details: The conversion is handled by editeng::HangulHanjaConversion class, which is used as a base class for SwHHCWrapper (and is also derived in a parallel manner also in editeng itself). Without digging into details (the flow is quite convoluted), the problem arises in SwTxtNode::Convert (sw/source/core/txtnode/txtedt.cxx) as follow: * line 1074: instantiate a SwLanguageIterator object, which builds a list of pointers to non-copiable SwTxtAttr; * line : call SetLanguageAndFont, which destroys the original SwTxtAttr items which the iterator still points to; * line 1117: access the now deleted iterator items. so SwTxtNode::SetLanguageAndFont calls InsertItemSet, with a SvxFontItem, which will result in a RES_TXTATR_AUTOFMT hint... which may be combined (in SwpHints::MergePortions) with an existing RES_TXTATR_AUTOFMT that is adjacent to the insertion range (aCurPaM), provided that the item set on the adjacent hint contains the same attributes as the one on the insertion range. SwTxtNode::Convert appears clearly wrong to me in modifying the hints of a text node while iterating over them. (it is possible that this used to work in 2005 or earlier; i don't know if equal text hints were combined before the introduction of AUTOFMT, as i wasn't around back then). perhaps the insertion could be delayed until after the loop? Thanks for the detailed reply - unluckily I have no skills in Writer and its internals yet, so I do not understand the implications of the AUTOFMT attribute. By looking at the code, my understanding of what needs to be done in order to postpone the insertion is: * iterate over attributes in order to find the portion with the desired language, without inserting new properties; * save the information about that portion; * if necessary, re-iterate over the attributes with SetLanguageAndFont Obviously, this would not work since we will get the same issue on the second loop. Instead we can push PaM information (on which to SetFontAndLanguage) in a queue and then iterate on it after the main loop is completed. I'll start working on a patch and see what happens with the Chinese document I have available. If that works, I'll submit the patch to gerrit, hoping that someone could also apply broader tests on the results (I don't have any knowledge of Chinese). * return the previously saved information; This could be done only if properties that are inserted do not influence the search of the language in the first iterations or corrupt the saved information. Could this work? I really would like to fix the bug, but fear to break something else. Thanks again! Cheers Matteo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Doing massive source changes
Hello, I have a patch that is 32M big and I rather wonder when to commit it. The patch specifically is string rtl:: prefix removal. These changes regularly show up in gerrit patches for review, but I think we have somewhat better EasyHacks for new developers than rather mindless searchreplace, and it's somewhat annoying to review such diffs as well. So instead I've done the change over the entire codebase where possible. The problem is, the change is so extensive that it touches pretty much everything (9117 files changed, 92833 insertions(+), 95662 deletions(-)). Given that we branched 4-0 a short time back, this will probably mean backporting will often need adjusting. So the options I see: - wait until before 4-1 branch-off (or do not do such a big change at all) - this would mean there still would be these changes done in small bits by other people (including the gerrit review overhead) - push now, only to master - this would mean more likely conflicts when backporting changes - push now, including to 4-0 - I can successfully do a full build, including make check, and I've avoided public API modules (sal, salhelper, cppu, cppuhelper, odk - any others?), so this hopefully should be safe, but most of the changes have been done using sed, so there may be something that I've missed Does somebody have a preference? I consider the last one to be the best option. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Better wording for Spellcheck buttons/context menu
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1541
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/1541/1
Better wording for Spellcheck buttons/context menu
Change-Id: Iddf82427c17a1caf72897e7af7592052c8e4fa71
---
M cui/uiconfig/ui/spellingdialog.ui
M sw/source/ui/lingu/olmenu.src
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cui/uiconfig/ui/spellingdialog.ui
b/cui/uiconfig/ui/spellingdialog.ui
index 26bfdfe..155f01e 100644
--- a/cui/uiconfig/ui/spellingdialog.ui
+++ b/cui/uiconfig/ui/spellingdialog.ui
@@ -164,7 +164,7 @@
/child
child
object class=GtkButton id=change
-property name=label translatable=yes_Change/property
+property name=label translatable=yes_Correct/property
property name=visibleTrue/property
property name=can_focusTrue/property
property name=receives_defaultTrue/property
@@ -180,7 +180,7 @@
/child
child
object class=GtkButton id=changeall
-property name=label translatable=yesChange
A_ll/property
+property name=label translatable=yesCorrect
A_ll/property
property name=visibleTrue/property
property name=can_focusTrue/property
property name=receives_defaultTrue/property
@@ -196,7 +196,7 @@
/child
child
object class=GtkButton id=autocorrect
-property name=label
translatable=yesAutoCor_rect/property
+property name=label translatable=yesAlwa_ys
correct/property
property name=visibleTrue/property
property name=can_focusTrue/property
property name=receives_defaultTrue/property
@@ -212,7 +212,7 @@
/child
child
object class=GtkCheckButton id=checkgrammar
-property name=label translatable=yesCheck
_grammar/property
+property name=label translatable=yesCheck
_Grammar/property
property name=visibleTrue/property
property name=can_focusTrue/property
property name=receives_defaultFalse/property
diff --git a/sw/source/ui/lingu/olmenu.src b/sw/source/ui/lingu/olmenu.src
index ae0897f..360692a 100644
--- a/sw/source/ui/lingu/olmenu.src
+++ b/sw/source/ui/lingu/olmenu.src
@@ -55,7 +55,7 @@
SubMenu = Menu
{
};
-Text [ en-US ] = AutoCorrect ;
+Text [ en-US ] = Always correct to ;
};
MenuItem
{
--
To view, visit https://gerrit.libreoffice.org/1541
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddf82427c17a1caf72897e7af7592052c8e4fa71
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 4 commits - compilerplugins/clang compilerplugins/Makefile-clang.mk config/config_clang.h.in configure.ac
compilerplugins/Makefile-clang.mk |1
compilerplugins/clang/lclstaticfix.cxx|4
compilerplugins/clang/plugin.cxx | 110 +++---
compilerplugins/clang/plugin.hxx | 28 +
compilerplugins/clang/postfixincrementfix.cxx |3
compilerplugins/clang/removeforwardstringdecl.cxx | 76 +++
compilerplugins/clang/removeforwardstringdecl.hxx | 34 ++
config/config_clang.h.in |3
configure.ac |3
9 files changed, 241 insertions(+), 21 deletions(-)
New commits:
commit d5ea81b87b8a19b23007691c8b14e6787ecb0290
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Thu Jan 3 22:57:46 2013 +0100
handle case of SRCDIR == BUILDDIR
Change-Id: I9daea65dc28ab13776a7c4319e5d5811515fe160
diff --git a/compilerplugins/clang/plugin.cxx b/compilerplugins/clang/plugin.cxx
index 348386f..d6bc910 100644
--- a/compilerplugins/clang/plugin.cxx
+++ b/compilerplugins/clang/plugin.cxx
@@ -253,7 +253,7 @@ class PluginHandler
else if( strncmp( e-getName(), WORKDIR, strlen( WORKDIR )) ==
0 )
diag.Report( diag.getCustomDiagID(
DiagnosticsEngine::Warning,
modified source in workdir/ : %0 [loplugin] ))
e-getName();
-else if( strncmp( e-getName(), BUILDDIR, strlen( BUILDDIR ))
== 0 )
+else if( strcmp( SRCDIR, BUILDDIR ) != 0 strncmp(
e-getName(), BUILDDIR, strlen( BUILDDIR )) == 0 )
diag.Report( diag.getCustomDiagID(
DiagnosticsEngine::Warning,
modified source in build dir : %0 [loplugin] ))
e-getName();
else if( strncmp( e-getName(), SRCDIR, strlen( SRCDIR )) == 0
)
commit 258aca9924d9e47737d750356d45227126dcf6a7
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Thu Jan 3 20:23:51 2013 +0100
rewriter plugin for removing forward rtl string declarations
Change-Id: I12bf38985ae62756973c05aacf762ae3c405ac9b
diff --git a/compilerplugins/Makefile-clang.mk
b/compilerplugins/Makefile-clang.mk
index 6031fe1..e652e44 100644
--- a/compilerplugins/Makefile-clang.mk
+++ b/compilerplugins/Makefile-clang.mk
@@ -14,6 +14,7 @@ CLANGSRC= \
bodynotinblock.cxx \
lclstaticfix.cxx \
postfixincrementfix.cxx \
+removeforwardstringdecl.cxx \
sallogareas.cxx \
unusedvariablecheck.cxx \
diff --git a/compilerplugins/clang/plugin.cxx b/compilerplugins/clang/plugin.cxx
index 22bac0c..348386f 100644
--- a/compilerplugins/clang/plugin.cxx
+++ b/compilerplugins/clang/plugin.cxx
@@ -22,6 +22,7 @@
#include bodynotinblock.hxx
#include lclstaticfix.hxx
#include postfixincrementfix.hxx
+#include removeforwardstringdecl.hxx
#include sallogareas.hxx
#include unusedvariablecheck.hxx
@@ -192,6 +193,7 @@ class PluginHandler
, bodyNotInBlock( context )
, lclStaticFix( context, rewriter )
, postfixIncrementFix( context, rewriter )
+, removeForwardStringDecl( context, rewriter )
, salLogAreas( context )
, unusedVariableCheck( context )
{
@@ -204,6 +206,8 @@ class PluginHandler
lclStaticFix.run();
else if( isArg( postfixincrementfix ))
postfixIncrementFix.run();
+else if( isArg( removeforwardstringdecl ))
+removeForwardStringDecl.run();
else if( args.empty())
{
bodyNotInBlock.run();
@@ -292,6 +296,7 @@ class PluginHandler
BodyNotInBlock bodyNotInBlock;
LclStaticFix lclStaticFix;
PostfixIncrementFix postfixIncrementFix;
+RemoveForwardStringDecl removeForwardStringDecl;
SalLogAreas salLogAreas;
UnusedVariableCheck unusedVariableCheck;
};
diff --git a/compilerplugins/clang/removeforwardstringdecl.cxx
b/compilerplugins/clang/removeforwardstringdecl.cxx
new file mode 100644
index 000..45891d5
--- /dev/null
+++ b/compilerplugins/clang/removeforwardstringdecl.cxx
@@ -0,0 +1,76 @@
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * Based on LLVM/Clang.
+ *
+ * This file is distributed under the University of Illinois Open Source
+ * License. See LICENSE.TXT for details.
+ *
+ */
+
+#include removeforwardstringdecl.hxx
+
+#include clang/AST/ASTContext.h
+#include clang/Basic/SourceManager.h
+
+/*
+This is a rewriter.
+
+Remove all forward declarations of rtl strings. I.e. 'namespace rtl { class
OUString; }' etc.
+*/
+
+namespace loplugin
+{
+
+RemoveForwardStringDecl::RemoveForwardStringDecl( ASTContext context,
Rewriter rewriter )
+: RewritePlugin( context, rewriter )
+{
+}
+
+void RemoveForwardStringDecl::run()
+{
+TraverseDecl( context.getTranslationUnitDecl());
+}
+
+bool RemoveForwardStringDecl::VisitNamespaceDecl( NamespaceDecl* declaration )
+{
+if( ignoreLocation(
[PATCH] Change 'Add' to 'Add to Dictionary' in the Dialog also
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1542 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/1542/1 Change 'Add' to 'Add to Dictionary' in the Dialog also Change-Id: I4bcf53239f001ed2d6ea08a743257ed0d6428752 --- M cui/uiconfig/ui/spellingdialog.ui 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/cui/uiconfig/ui/spellingdialog.ui b/cui/uiconfig/ui/spellingdialog.ui index 155f01e..165fff7 100644 --- a/cui/uiconfig/ui/spellingdialog.ui +++ b/cui/uiconfig/ui/spellingdialog.ui @@ -18,6 +18,7 @@ child object class=GtkButton id=help property name=labelgtk-help/property +property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=receives_defaultTrue/property @@ -33,6 +34,7 @@ child object class=GtkButton id=options property name=label translatable=yesO_ptions.../property +property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=receives_defaultTrue/property @@ -47,6 +49,7 @@ child object class=GtkButton id=undo property name=label translatable=yes_Undo/property +property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=receives_defaultTrue/property @@ -61,6 +64,7 @@ child object class=GtkButton id=close property name=labelgtk-close/property +property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=can_defaultTrue/property @@ -120,6 +124,7 @@ child object class=GtkButton id=ignore property name=label translatable=yes_Ignore Once/property +property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=receives_defaultTrue/property @@ -165,6 +170,7 @@ child object class=GtkButton id=change property name=label translatable=yes_Correct/property +property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=receives_defaultTrue/property @@ -181,6 +187,7 @@ child object class=GtkButton id=changeall property name=label translatable=yesCorrect A_ll/property +property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=receives_defaultTrue/property @@ -197,6 +204,7 @@ child object class=GtkButton id=autocorrect property name=label translatable=yesAlwa_ys correct/property +property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=receives_defaultTrue/property @@ -213,6 +221,7 @@ child object class=GtkCheckButton id=checkgrammar property name=label translatable=yesCheck _Grammar/property +property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=receives_defaultFalse/property @@ -230,6 +239,7 @@ child object class=GtkButton id=ignoreall property name=label translatable=yesI_gnore All/property +property name=use_action_appearanceFalse/property property name=can_focusTrue/property property name=receives_defaultTrue/property property name=no_show_allTrue/property @@ -246,6 +256,7 @@ child object class=GtkButton id=ignorerule property name=label translatable=yesI_gnore Rule/property +property name=use_action_appearanceFalse/property property name=can_focusTrue/property property name=receives_defaultTrue/property property name=no_show_allTrue/property @@ -292,6 +303,7 @@ child object class=GtkLinkButton
Re: Doing massive source changes
Hi, I would recommend going with the last option, when i looked on the reviews it is pretty mindless search and replace so the only issue is to make sure the replace script wont bork stuff. Cheers Tom 2013/1/4 Lubos Lunak l.lu...@suse.cz: Hello, I have a patch that is 32M big and I rather wonder when to commit it. The patch specifically is string rtl:: prefix removal. These changes regularly show up in gerrit patches for review, but I think we have somewhat better EasyHacks for new developers than rather mindless searchreplace, and it's somewhat annoying to review such diffs as well. So instead I've done the change over the entire codebase where possible. The problem is, the change is so extensive that it touches pretty much everything (9117 files changed, 92833 insertions(+), 95662 deletions(-)). Given that we branched 4-0 a short time back, this will probably mean backporting will often need adjusting. So the options I see: - wait until before 4-1 branch-off (or do not do such a big change at all) - this would mean there still would be these changes done in small bits by other people (including the gerrit review overhead) - push now, only to master - this would mean more likely conflicts when backporting changes - push now, including to 4-0 - I can successfully do a full build, including make check, and I've avoided public API modules (sal, salhelper, cppu, cppuhelper, odk - any others?), so this hopefully should be safe, but most of the changes have been done using sed, so there may be something that I've missed Does somebody have a preference? I consider the last one to be the best option. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 4 commits - sc/inc sc/source
sc/inc/dpglobal.hxx |2
sc/inc/dptabres.hxx | 87 +-
sc/inc/dptabsrc.hxx | 14 -
sc/source/core/data/dptabres.cxx | 200 +++-
sc/source/core/data/dptabsrc.cxx | 325 ---
5 files changed, 319 insertions(+), 309 deletions(-)
New commits:
commit b53d03f4c970f13f9849c01f1d0b6ad42185148d
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Jan 4 02:31:26 2013 -0500
Remove the last use of SC_DP_MAX_FIELDS.
Now the pivot table core no longer uses static array for result data
storage.
Change-Id: I70a44011e2c12a1739c0507b1723c21a4808758c
diff --git a/sc/inc/dpglobal.hxx b/sc/inc/dpglobal.hxx
index 4096a57..fe94b32 100644
--- a/sc/inc/dpglobal.hxx
+++ b/sc/inc/dpglobal.hxx
@@ -20,8 +20,6 @@
#ifndef _SC_DPGLOBAL_HXX
#define _SC_DPGLOBAL_HXX
-#define SC_DP_MAX_FIELDS 256
-
#define PIVOT_MAXFUNC 11
#define PIVOT_FUNC_NONE 0x
#define PIVOT_FUNC_SUM 0x0001
diff --git a/sc/inc/dptabsrc.hxx b/sc/inc/dptabsrc.hxx
index 11888dd..1aefebc 100644
--- a/sc/inc/dptabsrc.hxx
+++ b/sc/inc/dptabsrc.hxx
@@ -98,14 +98,12 @@ private:
ScDPTableData* pData; // data source (ScDPObject
manages its life time)
ScDPDimensions* pDimensions;// api objects
// settings:
-longnColDims[SC_DP_MAX_FIELDS];
-longnRowDims[SC_DP_MAX_FIELDS];
-longnDataDims[SC_DP_MAX_FIELDS];
-longnPageDims[SC_DP_MAX_FIELDS];
-longnColDimCount;
-longnRowDimCount;
-longnDataDimCount;
-longnPageDimCount;
+
+std::vectorlong maColDims;
+std::vectorlong maRowDims;
+std::vectorlong maDataDims;
+std::vectorlong maPageDims;
+
boolbColumnGrand;
boolbRowGrand;
boolbIgnoreEmptyRows;
diff --git a/sc/source/core/data/dptabsrc.cxx b/sc/source/core/data/dptabsrc.cxx
index 6b46671..87800c3 100644
--- a/sc/source/core/data/dptabsrc.cxx
+++ b/sc/source/core/data/dptabsrc.cxx
@@ -109,10 +109,6 @@ static void lcl_SetBoolInAny( uno::Any rAny, sal_Bool
bValue )
ScDPSource::ScDPSource( ScDPTableData* pD ) :
pData( pD ),
pDimensions( NULL ),
-nColDimCount( 0 ),
-nRowDimCount( 0 ),
-nDataDimCount( 0 ),
-nPageDimCount( 0 ),
bColumnGrand( true ), // default is true
bRowGrand( true ),
bIgnoreEmptyRows( false ),
@@ -152,33 +148,32 @@ const ::rtl::OUString* ScDPSource::GetGrandTotalName()
const
sal_uInt16 ScDPSource::GetOrientation(long nColumn)
{
-long i;
-for (i=0; inColDimCount; i++)
-if (nColDims[i] == nColumn)
-return sheet::DataPilotFieldOrientation_COLUMN;
-for (i=0; inRowDimCount; i++)
-if (nRowDims[i] == nColumn)
-return sheet::DataPilotFieldOrientation_ROW;
-for (i=0; inDataDimCount; i++)
-if (nDataDims[i] == nColumn)
-return sheet::DataPilotFieldOrientation_DATA;
-for (i=0; inPageDimCount; i++)
-if (nPageDims[i] == nColumn)
-return sheet::DataPilotFieldOrientation_PAGE;
+if (std::find(maColDims.begin(), maColDims.end(), nColumn) !=
maColDims.end())
+return sheet::DataPilotFieldOrientation_COLUMN;
+
+if (std::find(maRowDims.begin(), maRowDims.end(), nColumn) !=
maRowDims.end())
+return sheet::DataPilotFieldOrientation_ROW;
+
+if (std::find(maDataDims.begin(), maDataDims.end(), nColumn) !=
maDataDims.end())
+return sheet::DataPilotFieldOrientation_DATA;
+
+if (std::find(maPageDims.begin(), maPageDims.end(), nColumn) !=
maPageDims.end())
+return sheet::DataPilotFieldOrientation_PAGE;
+
return sheet::DataPilotFieldOrientation_HIDDEN;
}
long ScDPSource::GetDataDimensionCount()
{
-return nDataDimCount;
+return maDataDims.size();
}
ScDPDimension* ScDPSource::GetDataDimension(long nIndex)
{
-if (nIndex 0 || nIndex = nDataDimCount)
+if (nIndex 0 || static_castsize_t(nIndex) = maDataDims.size())
return NULL;
-long nDimIndex = nDataDims[nIndex];
+long nDimIndex = maDataDims[nIndex];
return GetDimensionsObject()-getByIndex(nDimIndex);
}
@@ -193,92 +188,107 @@ rtl::OUString ScDPSource::GetDataDimName(long nIndex)
long ScDPSource::GetPosition(long nColumn)
{
-long i;
-for (i=0; inColDimCount; i++)
-if (nColDims[i] == nColumn)
-return i;
-for (i=0; inRowDimCount; i++)
-if (nRowDims[i] == nColumn)
-return i;
-for (i=0; inDataDimCount; i++)
-if (nDataDims[i] == nColumn)
-return i;
-for (i=0; inPageDimCount; i++)
-if (nPageDims[i] == nColumn)
-return i;
+
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 4 commits - sc/inc sc/source
sc/inc/dpglobal.hxx |2
sc/inc/dptabres.hxx | 87 +-
sc/inc/dptabsrc.hxx | 14 -
sc/source/core/data/dptabres.cxx | 200 +++-
sc/source/core/data/dptabsrc.cxx | 325 ---
5 files changed, 319 insertions(+), 309 deletions(-)
New commits:
commit 744c4a4f4eb2555d3a0c1aba9fa74209a8f1942d
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Jan 4 02:31:26 2013 -0500
Remove the last use of SC_DP_MAX_FIELDS.
Now the pivot table core no longer uses static array for result data
storage.
Change-Id: I70a44011e2c12a1739c0507b1723c21a4808758c
diff --git a/sc/inc/dpglobal.hxx b/sc/inc/dpglobal.hxx
index 4096a57..fe94b32 100644
--- a/sc/inc/dpglobal.hxx
+++ b/sc/inc/dpglobal.hxx
@@ -20,8 +20,6 @@
#ifndef _SC_DPGLOBAL_HXX
#define _SC_DPGLOBAL_HXX
-#define SC_DP_MAX_FIELDS 256
-
#define PIVOT_MAXFUNC 11
#define PIVOT_FUNC_NONE 0x
#define PIVOT_FUNC_SUM 0x0001
diff --git a/sc/inc/dptabsrc.hxx b/sc/inc/dptabsrc.hxx
index 11888dd..1aefebc 100644
--- a/sc/inc/dptabsrc.hxx
+++ b/sc/inc/dptabsrc.hxx
@@ -98,14 +98,12 @@ private:
ScDPTableData* pData; // data source (ScDPObject
manages its life time)
ScDPDimensions* pDimensions;// api objects
// settings:
-longnColDims[SC_DP_MAX_FIELDS];
-longnRowDims[SC_DP_MAX_FIELDS];
-longnDataDims[SC_DP_MAX_FIELDS];
-longnPageDims[SC_DP_MAX_FIELDS];
-longnColDimCount;
-longnRowDimCount;
-longnDataDimCount;
-longnPageDimCount;
+
+std::vectorlong maColDims;
+std::vectorlong maRowDims;
+std::vectorlong maDataDims;
+std::vectorlong maPageDims;
+
boolbColumnGrand;
boolbRowGrand;
boolbIgnoreEmptyRows;
diff --git a/sc/source/core/data/dptabsrc.cxx b/sc/source/core/data/dptabsrc.cxx
index 60f493f..56aa2c7 100644
--- a/sc/source/core/data/dptabsrc.cxx
+++ b/sc/source/core/data/dptabsrc.cxx
@@ -109,10 +109,6 @@ static void lcl_SetBoolInAny( uno::Any rAny, sal_Bool
bValue )
ScDPSource::ScDPSource( ScDPTableData* pD ) :
pData( pD ),
pDimensions( NULL ),
-nColDimCount( 0 ),
-nRowDimCount( 0 ),
-nDataDimCount( 0 ),
-nPageDimCount( 0 ),
bColumnGrand( true ), // default is true
bRowGrand( true ),
bIgnoreEmptyRows( false ),
@@ -152,33 +148,32 @@ const ::rtl::OUString* ScDPSource::GetGrandTotalName()
const
sal_uInt16 ScDPSource::GetOrientation(long nColumn)
{
-long i;
-for (i=0; inColDimCount; i++)
-if (nColDims[i] == nColumn)
-return sheet::DataPilotFieldOrientation_COLUMN;
-for (i=0; inRowDimCount; i++)
-if (nRowDims[i] == nColumn)
-return sheet::DataPilotFieldOrientation_ROW;
-for (i=0; inDataDimCount; i++)
-if (nDataDims[i] == nColumn)
-return sheet::DataPilotFieldOrientation_DATA;
-for (i=0; inPageDimCount; i++)
-if (nPageDims[i] == nColumn)
-return sheet::DataPilotFieldOrientation_PAGE;
+if (std::find(maColDims.begin(), maColDims.end(), nColumn) !=
maColDims.end())
+return sheet::DataPilotFieldOrientation_COLUMN;
+
+if (std::find(maRowDims.begin(), maRowDims.end(), nColumn) !=
maRowDims.end())
+return sheet::DataPilotFieldOrientation_ROW;
+
+if (std::find(maDataDims.begin(), maDataDims.end(), nColumn) !=
maDataDims.end())
+return sheet::DataPilotFieldOrientation_DATA;
+
+if (std::find(maPageDims.begin(), maPageDims.end(), nColumn) !=
maPageDims.end())
+return sheet::DataPilotFieldOrientation_PAGE;
+
return sheet::DataPilotFieldOrientation_HIDDEN;
}
long ScDPSource::GetDataDimensionCount()
{
-return nDataDimCount;
+return maDataDims.size();
}
ScDPDimension* ScDPSource::GetDataDimension(long nIndex)
{
-if (nIndex 0 || nIndex = nDataDimCount)
+if (nIndex 0 || static_castsize_t(nIndex) = maDataDims.size())
return NULL;
-long nDimIndex = nDataDims[nIndex];
+long nDimIndex = maDataDims[nIndex];
return GetDimensionsObject()-getByIndex(nDimIndex);
}
@@ -193,92 +188,107 @@ rtl::OUString ScDPSource::GetDataDimName(long nIndex)
long ScDPSource::GetPosition(long nColumn)
{
-long i;
-for (i=0; inColDimCount; i++)
-if (nColDims[i] == nColumn)
-return i;
-for (i=0; inRowDimCount; i++)
-if (nRowDims[i] == nColumn)
-return i;
-for (i=0; inDataDimCount; i++)
-if (nDataDims[i] == nColumn)
-return i;
-for (i=0; inPageDimCount; i++)
-if (nPageDims[i] == nColumn)
-return i;
+
Re: Doing massive source changes
Just a simple contributor and C++ beginner of course but I agree for the last solution. About building, it could be interesting to have the maximum of elements enabled in autogen.lastrun (all the extensions + dbgutil). Also, perhaps you won't be able to build on all env (Linux, Win, MacOs...) so we'll got to check master and 4.0 Tinderboxes and fix quickly if red (hopefully it's just quick and easy fix) However, again the last solution you proposed seems the best. Julien -- View this message in context: http://nabble.documentfoundation.org/Doing-massive-source-changes-tp4027231p4027239.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
fdo#40465 fix to maintain focus whilst zooming
Winfried Donkers has abandoned this change. Change subject: fdo#40465 fix to maintain focus whilst zooming .. Patch Set 1: Abandoned I finally managed to upload a Patch Set 2 to gerrit 1278, so this one (1533) can be closed. -- To view, visit https://gerrit.libreoffice.org/1533 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3fab5d62d8f479a5efe242693d2fbe33375206f8 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl Gerrit-Reviewer: Winfried Donkers o...@dci-electronics.nl ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Doing massive source changes
Hi, On 01/04/2013 03:12 PM, Lubos Lunak wrote: Hello, I have a patch that is 32M big and I rather wonder when to commit it. The patch specifically is string rtl:: prefix removal. These changes regularly show up in gerrit patches for review, but I think we have somewhat better EasyHacks for new developers than rather mindless searchreplace, and it's somewhat annoying to review such diffs as well. So instead I've done the change over the entire codebase where possible. Also, I've seen that some patches on Gerrit that still introduce that rtl:: (or ::rtl::) prefix - I can't really say if in code that actually requires them or not, but I seem to recall mixed notation in some of them. Is there any way to filter those out in order to avoid future actions on this? The problem is, the change is so extensive that it touches pretty much everything (9117 files changed, 92833 insertions(+), 95662 deletions(-)). Given that we branched 4-0 a short time back, this will probably mean backporting will often need adjusting. So the options I see: - wait until before 4-1 branch-off (or do not do such a big change at all) - this would mean there still would be these changes done in small bits by other people (including the gerrit review overhead) - push now, only to master - this would mean more likely conflicts when backporting changes - push now, including to 4-0 - I can successfully do a full build, including make check, and I've avoided public API modules (sal, salhelper, cppu, cppuhelper, odk - any others?), so this hopefully should be safe, but most of the changes have been done using sed, so there may be something that I've missed Does somebody have a preference? I consider the last one to be the best option. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/source
sw/source/filter/ww8/ww8par.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit d115f128f645ebccc9f5c0a8e1bf6223c286
Author: Miklos Vajna vmik...@suse.cz
Date: Fri Jan 4 16:31:47 2013 +0100
sw: forgot to adapt this
diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index 268ed91..58970eb 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -145,7 +145,7 @@ bool BasicProjImportHelper::import( const uno::Reference
io::XInputStream rx
try
{
oox::ole::OleStorage root( mxCtx, rxIn, false );
-oox::StorageRef vbaStg = root.openSubStorage( CREATE_OUSTRING(
Macros ), false );
+oox::StorageRef vbaStg = root.openSubStorage( Macros , false );
if ( vbaStg.get() )
{
oox::ole::VbaProject aVbaPrj( mxCtx, mrDocShell.GetModel(),
rtl::OUString(Writer) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] fdo#50415: Add Catalan translations of keyboard shortcuts
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1543
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/1543/1
fdo#50415: Add Catalan translations of keyboard shortcuts
Change-Id: Ieeab5b84674d26e4d29324614641813d8b65c517
---
M vcl/unx/generic/app/keysymnames.cxx
1 file changed, 31 insertions(+), 0 deletions(-)
diff --git a/vcl/unx/generic/app/keysymnames.cxx
b/vcl/unx/generic/app/keysymnames.cxx
index 69aee0d..05c37d4 100644
--- a/vcl/unx/generic/app/keysymnames.cxx
+++ b/vcl/unx/generic/app/keysymnames.cxx
@@ -341,8 +341,39 @@
{ SunXK_Cut, Lõika },
};
+static const struct KeysymNameReplacement aImplReplacements_Catalan[] =
+{
+{ XK_Shift_L, Maj },
+{ XK_Shift_R, Maj },
+{ XK_Page_Up, Re Pàg },
+{ XK_Page_Down, Av Pàg },
+{ XK_End, Fi },
+{ XK_Home, Inici },
+{ XK_Delete, Supr },
+{ XK_Escape, Esc },
+{ XK_Right, Dreta },
+{ XK_Left, Esquerra },
+{ XK_Up, Amunt },
+{ XK_Down, Avall },
+{ XK_BackSpace, Retrocés },
+{ XK_Return, Retorn },
+{ XK_space, Espai },
+{ XK_KP_Enter, Retorn },
+{ SunXK_Stop, Atura },
+{ SunXK_Again, Repeteix },
+{ SunXK_Props, Props },
+{ SunXK_Undo, Desfés },
+{ SunXK_Front, Davant },
+{ SunXK_Copy, Còpia },
+{ SunXK_Open, Obre },
+{ SunXK_Paste, Enganxa },
+{ SunXK_Find, Cerca },
+{ SunXK_Cut, Retalla },
+};
+
static const struct KeyboardReplacements aKeyboards[] =
{
+{ ca, aImplReplacements_Catalan,
SAL_N_ELEMENTS(aImplReplacements_Catalan) },
{ de, aImplReplacements_German,
SAL_N_ELEMENTS(aImplReplacements_German) },
{ es, aImplReplacements_Spanish,
SAL_N_ELEMENTS(aImplReplacements_Spanish) },
{ et, aImplReplacements_Estonian,
SAL_N_ELEMENTS(aImplReplacements_Estonian) },
--
To view, visit https://gerrit.libreoffice.org/1543
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieeab5b84674d26e4d29324614641813d8b65c517
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Jesús Corrius jcorr...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Change in core[libreoffice-4-0]: fdo#50415: Add Catalan translations of keyboard shortcuts
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1544
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/1544/1
fdo#50415: Add Catalan translations of keyboard shortcuts
Change-Id: Ieeab5b84674d26e4d29324614641813d8b65c517
---
M vcl/unx/generic/app/keysymnames.cxx
1 file changed, 31 insertions(+), 0 deletions(-)
diff --git a/vcl/unx/generic/app/keysymnames.cxx
b/vcl/unx/generic/app/keysymnames.cxx
index 69aee0d..05c37d4 100644
--- a/vcl/unx/generic/app/keysymnames.cxx
+++ b/vcl/unx/generic/app/keysymnames.cxx
@@ -341,8 +341,39 @@
{ SunXK_Cut, Lõika },
};
+static const struct KeysymNameReplacement aImplReplacements_Catalan[] =
+{
+{ XK_Shift_L, Maj },
+{ XK_Shift_R, Maj },
+{ XK_Page_Up, Re Pàg },
+{ XK_Page_Down, Av Pàg },
+{ XK_End, Fi },
+{ XK_Home, Inici },
+{ XK_Delete, Supr },
+{ XK_Escape, Esc },
+{ XK_Right, Dreta },
+{ XK_Left, Esquerra },
+{ XK_Up, Amunt },
+{ XK_Down, Avall },
+{ XK_BackSpace, Retrocés },
+{ XK_Return, Retorn },
+{ XK_space, Espai },
+{ XK_KP_Enter, Retorn },
+{ SunXK_Stop, Atura },
+{ SunXK_Again, Repeteix },
+{ SunXK_Props, Props },
+{ SunXK_Undo, Desfés },
+{ SunXK_Front, Davant },
+{ SunXK_Copy, Còpia },
+{ SunXK_Open, Obre },
+{ SunXK_Paste, Enganxa },
+{ SunXK_Find, Cerca },
+{ SunXK_Cut, Retalla },
+};
+
static const struct KeyboardReplacements aKeyboards[] =
{
+{ ca, aImplReplacements_Catalan,
SAL_N_ELEMENTS(aImplReplacements_Catalan) },
{ de, aImplReplacements_German,
SAL_N_ELEMENTS(aImplReplacements_German) },
{ es, aImplReplacements_Spanish,
SAL_N_ELEMENTS(aImplReplacements_Spanish) },
{ et, aImplReplacements_Estonian,
SAL_N_ELEMENTS(aImplReplacements_Estonian) },
--
To view, visit https://gerrit.libreoffice.org/1544
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieeab5b84674d26e4d29324614641813d8b65c517
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Jesús Corrius jcorr...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - writerfilter/source
writerfilter/source/dmapper/CellMarginHandler.cxx |6 -
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 17 --
writerfilter/source/dmapper/TablePropertiesHandler.cxx | 20 +
3 files changed, 40 insertions(+), 3 deletions(-)
New commits:
commit 1505a56f5a0d0ed0e3a8571ff89a15aaed180a32
Author: Miklos Vajna vmik...@suse.cz
Date: Fri Jan 4 12:56:40 2013 +0100
n#793262 DOCX: import w:tcMar inside w:tc
These were ignored previously, and in case they contained some margins,
the resulting table was potentially smaller than necessary.
(cherry picked from commit 60ec497e0e91354a616978be531d15d3efa3f559)
diff --git a/writerfilter/source/dmapper/CellMarginHandler.cxx
b/writerfilter/source/dmapper/CellMarginHandler.cxx
index 6ee219e..6119831 100644
--- a/writerfilter/source/dmapper/CellMarginHandler.cxx
+++ b/writerfilter/source/dmapper/CellMarginHandler.cxx
@@ -75,6 +75,7 @@ void CellMarginHandler::lcl_sprm(Sprm rSprm)
switch( rSprm.getId() )
{
case NS_ooxml::LN_CT_TblCellMar_top:
+case NS_ooxml::LN_CT_TcMar_top:
m_nTopMargin = m_nValue;
m_bTopMarginValid = true;
break;
@@ -91,10 +92,12 @@ void CellMarginHandler::lcl_sprm(Sprm rSprm)
}
break;
case NS_ooxml::LN_CT_TblCellMar_left:
+case NS_ooxml::LN_CT_TcMar_left:
m_nLeftMargin = m_nValue;
m_bLeftMarginValid = true;
break;
case NS_ooxml::LN_CT_TblCellMar_bottom:
+case NS_ooxml::LN_CT_TcMar_bottom:
m_nBottomMargin = m_nValue;
m_bBottomMarginValid = true;
break;
@@ -111,11 +114,12 @@ void CellMarginHandler::lcl_sprm(Sprm rSprm)
}
break;
case NS_ooxml::LN_CT_TblCellMar_right:
+case NS_ooxml::LN_CT_TcMar_right:
m_nRightMargin = m_nValue;
m_bRightMarginValid = true;
break;
default:
-OSL_FAIL( unknown attribute);
+OSL_FAIL( unknown sprm);
}
}
m_nValue = 0;
diff --git a/writerfilter/source/dmapper/TablePropertiesHandler.cxx
b/writerfilter/source/dmapper/TablePropertiesHandler.cxx
index 17e1a84..b1d560c 100644
--- a/writerfilter/source/dmapper/TablePropertiesHandler.cxx
+++ b/writerfilter/source/dmapper/TablePropertiesHandler.cxx
@@ -170,6 +170,26 @@ namespace dmapper {
}
}
break;
+case NS_ooxml::LN_CT_TcPrBase_tcMar:
+{
+writerfilter::ReferenceProperties::Pointer_t pProperties
= rSprm.getProps();
+if (pProperties.get())
+{
+CellMarginHandlerPtr pCellMarginHandler(new
CellMarginHandler);
+pProperties-resolve(*pCellMarginHandler);
+TablePropertyMapPtr pCellProperties(new
TablePropertyMap);
+if (pCellMarginHandler-m_bTopMarginValid)
+pCellProperties-Insert(PROP_TOP_BORDER_DISTANCE,
false, uno::makeAny(pCellMarginHandler-m_nTopMargin));
+if (pCellMarginHandler-m_bLeftMarginValid)
+pCellProperties-Insert(PROP_LEFT_BORDER_DISTANCE,
false, uno::makeAny(pCellMarginHandler-m_nLeftMargin));
+if (pCellMarginHandler-m_bBottomMarginValid)
+
pCellProperties-Insert(PROP_BOTTOM_BORDER_DISTANCE, false,
uno::makeAny(pCellMarginHandler-m_nBottomMargin));
+if (pCellMarginHandler-m_bRightMarginValid)
+
pCellProperties-Insert(PROP_RIGHT_BORDER_DISTANCE, false,
uno::makeAny(pCellMarginHandler-m_nRightMargin));
+cellProps(pCellProperties);
+}
+}
+break;
case NS_ooxml::LN_CT_TblPrBase_shd:
{
writerfilter::ReferenceProperties::Pointer_t pProperties =
rSprm.getProps();
commit a23fc47fccb907dc7a3197982ea541834f5d8fd7
Author: Miklos Vajna vmik...@suse.cz
Date: Thu Jan 3 16:40:29 2013 +0100
n#793262 fix DOCX import of last empty header/footer para char props
At the end of the header/footer import, the last empty paragraph was
removed. In case the last but one paragraph was empty, but had character
properties (e.g. a custom font size), the removal changed these, and
used the character properties of the last paragraph instead.
Simply dispose the last paragraph, this way character properties are
always kept.
(cherry picked from commit e8b661dd0aed9b35104e910acbb814748a2c3af0)
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 9381f73..ef16af5 100644
---
Re: Addin exceptions in SvStream
Aaah, that is what was missing. I would've expected that to be installed with the clang development packages as a dependency. Thanks! Marc-André LAVERDIÈRE Perseverance must finish its work so that you may be mature and complete, not lacking anything. -James 1:4 http://asimplediscipleslife.blogspot.com/ mlaverd.theunixplace.com On Fri, Jan 4, 2013 at 1:54 PM, Miklos Vajna vmik...@suse.cz wrote: On Fri, Jan 04, 2013 at 01:45:11PM +0530, Marc-André Laverdière marcandre.laverdi...@gmail.com wrote: /usr/include/clang/Basic/LLVM.h:20:10: fatal error: 'llvm/Support/Casting.h' file not found Do you have llvm-devel (or equivalent) installed? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: vcl/unx
vcl/unx/generic/app/keysymnames.cxx | 31 +++
1 file changed, 31 insertions(+)
New commits:
commit 5dcb323352b175bfdcd994c4941433df98ffd4dd
Author: Jesús Corrius jcorr...@gmail.com
Date: Fri Jan 4 16:17:23 2013 +0100
fdo#50415: Add Catalan translations of keyboard shortcuts
Change-Id: Ieeab5b84674d26e4d29324614641813d8b65c517
Reviewed-on: https://gerrit.libreoffice.org/1543
Reviewed-by: Tor Lillqvist t...@iki.fi
Tested-by: Tor Lillqvist t...@iki.fi
diff --git a/vcl/unx/generic/app/keysymnames.cxx
b/vcl/unx/generic/app/keysymnames.cxx
index 69aee0d..05c37d4 100644
--- a/vcl/unx/generic/app/keysymnames.cxx
+++ b/vcl/unx/generic/app/keysymnames.cxx
@@ -341,8 +341,39 @@ namespace vcl_sal {
{ SunXK_Cut, Lõika },
};
+static const struct KeysymNameReplacement aImplReplacements_Catalan[] =
+{
+{ XK_Shift_L, Maj },
+{ XK_Shift_R, Maj },
+{ XK_Page_Up, Re PÃ g },
+{ XK_Page_Down, Av PÃ g },
+{ XK_End, Fi },
+{ XK_Home, Inici },
+{ XK_Delete, Supr },
+{ XK_Escape, Esc },
+{ XK_Right, Dreta },
+{ XK_Left, Esquerra },
+{ XK_Up, Amunt },
+{ XK_Down, Avall },
+{ XK_BackSpace, Retrocés },
+{ XK_Return, Retorn },
+{ XK_space, Espai },
+{ XK_KP_Enter, Retorn },
+{ SunXK_Stop, Atura },
+{ SunXK_Again, Repeteix },
+{ SunXK_Props, Props },
+{ SunXK_Undo, Desfés },
+{ SunXK_Front, Davant },
+{ SunXK_Copy, Còpia },
+{ SunXK_Open, Obre },
+{ SunXK_Paste, Enganxa },
+{ SunXK_Find, Cerca },
+{ SunXK_Cut, Retalla },
+};
+
static const struct KeyboardReplacements aKeyboards[] =
{
+{ ca, aImplReplacements_Catalan,
SAL_N_ELEMENTS(aImplReplacements_Catalan) },
{ de, aImplReplacements_German,
SAL_N_ELEMENTS(aImplReplacements_German) },
{ es, aImplReplacements_Spanish,
SAL_N_ELEMENTS(aImplReplacements_Spanish) },
{ et, aImplReplacements_Estonian,
SAL_N_ELEMENTS(aImplReplacements_Estonian) },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] fdo#50415: Add Catalan translations of keyboard shortcuts
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1543 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1543 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieeab5b84674d26e4d29324614641813d8b65c517 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jesús Corrius jcorr...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - vcl/unx
vcl/unx/generic/app/keysymnames.cxx | 31 +++
1 file changed, 31 insertions(+)
New commits:
commit d4f4aff77ad99083baf4150be358ec72c5918a07
Author: Jesús Corrius jcorr...@gmail.com
Date: Fri Jan 4 16:17:23 2013 +0100
fdo#50415: Add Catalan translations of keyboard shortcuts
Change-Id: Ieeab5b84674d26e4d29324614641813d8b65c517
Reviewed-on: https://gerrit.libreoffice.org/1544
Reviewed-by: Tor Lillqvist t...@iki.fi
Tested-by: Tor Lillqvist t...@iki.fi
diff --git a/vcl/unx/generic/app/keysymnames.cxx
b/vcl/unx/generic/app/keysymnames.cxx
index 69aee0d..05c37d4 100644
--- a/vcl/unx/generic/app/keysymnames.cxx
+++ b/vcl/unx/generic/app/keysymnames.cxx
@@ -341,8 +341,39 @@ namespace vcl_sal {
{ SunXK_Cut, Lõika },
};
+static const struct KeysymNameReplacement aImplReplacements_Catalan[] =
+{
+{ XK_Shift_L, Maj },
+{ XK_Shift_R, Maj },
+{ XK_Page_Up, Re PÃ g },
+{ XK_Page_Down, Av PÃ g },
+{ XK_End, Fi },
+{ XK_Home, Inici },
+{ XK_Delete, Supr },
+{ XK_Escape, Esc },
+{ XK_Right, Dreta },
+{ XK_Left, Esquerra },
+{ XK_Up, Amunt },
+{ XK_Down, Avall },
+{ XK_BackSpace, Retrocés },
+{ XK_Return, Retorn },
+{ XK_space, Espai },
+{ XK_KP_Enter, Retorn },
+{ SunXK_Stop, Atura },
+{ SunXK_Again, Repeteix },
+{ SunXK_Props, Props },
+{ SunXK_Undo, Desfés },
+{ SunXK_Front, Davant },
+{ SunXK_Copy, Còpia },
+{ SunXK_Open, Obre },
+{ SunXK_Paste, Enganxa },
+{ SunXK_Find, Cerca },
+{ SunXK_Cut, Retalla },
+};
+
static const struct KeyboardReplacements aKeyboards[] =
{
+{ ca, aImplReplacements_Catalan,
SAL_N_ELEMENTS(aImplReplacements_Catalan) },
{ de, aImplReplacements_German,
SAL_N_ELEMENTS(aImplReplacements_German) },
{ es, aImplReplacements_Spanish,
SAL_N_ELEMENTS(aImplReplacements_Spanish) },
{ et, aImplReplacements_Estonian,
SAL_N_ELEMENTS(aImplReplacements_Estonian) },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - 2 commits - writerfilter/source
writerfilter/source/dmapper/CellMarginHandler.cxx |6 -
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 17 --
writerfilter/source/dmapper/TablePropertiesHandler.cxx | 20 +
3 files changed, 40 insertions(+), 3 deletions(-)
New commits:
commit 0d40dfd6e0a66e36d5ee1479a4b5fd84470ed502
Author: Miklos Vajna vmik...@suse.cz
Date: Fri Jan 4 12:56:40 2013 +0100
n#793262 DOCX: import w:tcMar inside w:tc
These were ignored previously, and in case they contained some margins,
the resulting table was potentially smaller than necessary.
(cherry picked from commit 672de66ff8ad6d1fbf8a198ee518c996611b9e2d)
diff --git a/writerfilter/source/dmapper/CellMarginHandler.cxx
b/writerfilter/source/dmapper/CellMarginHandler.cxx
index 36a85f1..8b14975 100644
--- a/writerfilter/source/dmapper/CellMarginHandler.cxx
+++ b/writerfilter/source/dmapper/CellMarginHandler.cxx
@@ -84,6 +84,7 @@ void CellMarginHandler::lcl_sprm(Sprm rSprm)
switch( rSprm.getId() )
{
case NS_ooxml::LN_CT_TblCellMar_top:
+case NS_ooxml::LN_CT_TcMar_top:
m_nTopMargin = m_nValue;
m_bTopMarginValid = true;
break;
@@ -100,10 +101,12 @@ void CellMarginHandler::lcl_sprm(Sprm rSprm)
}
break;
case NS_ooxml::LN_CT_TblCellMar_left:
+case NS_ooxml::LN_CT_TcMar_left:
m_nLeftMargin = m_nValue;
m_bLeftMarginValid = true;
break;
case NS_ooxml::LN_CT_TblCellMar_bottom:
+case NS_ooxml::LN_CT_TcMar_bottom:
m_nBottomMargin = m_nValue;
m_bBottomMarginValid = true;
break;
@@ -120,11 +123,12 @@ void CellMarginHandler::lcl_sprm(Sprm rSprm)
}
break;
case NS_ooxml::LN_CT_TblCellMar_right:
+case NS_ooxml::LN_CT_TcMar_right:
m_nRightMargin = m_nValue;
m_bRightMarginValid = true;
break;
default:
-OSL_FAIL( unknown attribute);
+OSL_FAIL( unknown sprm);
}
}
m_nValue = 0;
diff --git a/writerfilter/source/dmapper/TablePropertiesHandler.cxx
b/writerfilter/source/dmapper/TablePropertiesHandler.cxx
index 4e7e1d2..5de8cf1 100644
--- a/writerfilter/source/dmapper/TablePropertiesHandler.cxx
+++ b/writerfilter/source/dmapper/TablePropertiesHandler.cxx
@@ -152,6 +152,26 @@ namespace dmapper {
}
}
break;
+case NS_ooxml::LN_CT_TcPrBase_tcMar:
+{
+writerfilter::ReferenceProperties::Pointer_t pProperties
= rSprm.getProps();
+if (pProperties.get())
+{
+CellMarginHandlerPtr pCellMarginHandler(new
CellMarginHandler);
+pProperties-resolve(*pCellMarginHandler);
+TablePropertyMapPtr pCellProperties(new
TablePropertyMap);
+if (pCellMarginHandler-m_bTopMarginValid)
+pCellProperties-Insert(PROP_TOP_BORDER_DISTANCE,
false, uno::makeAny(pCellMarginHandler-m_nTopMargin));
+if (pCellMarginHandler-m_bLeftMarginValid)
+pCellProperties-Insert(PROP_LEFT_BORDER_DISTANCE,
false, uno::makeAny(pCellMarginHandler-m_nLeftMargin));
+if (pCellMarginHandler-m_bBottomMarginValid)
+
pCellProperties-Insert(PROP_BOTTOM_BORDER_DISTANCE, false,
uno::makeAny(pCellMarginHandler-m_nBottomMargin));
+if (pCellMarginHandler-m_bRightMarginValid)
+
pCellProperties-Insert(PROP_RIGHT_BORDER_DISTANCE, false,
uno::makeAny(pCellMarginHandler-m_nRightMargin));
+cellProps(pCellProperties);
+}
+}
+break;
case NS_ooxml::LN_CT_TblPrBase_shd:
{
writerfilter::ReferenceProperties::Pointer_t pProperties =
rSprm.getProps();
commit f60a7f9af31f69ebe22f2deffa6ebe4132a50e56
Author: Miklos Vajna vmik...@suse.cz
Date: Thu Jan 3 16:40:29 2013 +0100
n#793262 fix DOCX import of last empty header/footer para char props
At the end of the header/footer import, the last empty paragraph was
removed. In case the last but one paragraph was empty, but had character
properties (e.g. a custom font size), the removal changed these, and
used the character properties of the last paragraph instead.
Simply dispose the last paragraph, this way character properties are
always kept.
(cherry picked from commit e8b661dd0aed9b35104e910acbb814748a2c3af0)
Conflicts:
writerfilter/source/dmapper/DomainMapper_Impl.cxx
Change-Id: Ic78f197fe99458becb9d86901bee6dfcb7076a13
diff --git
[PUSHED] Change in core[libreoffice-4-0]: fdo#50415: Add Catalan translations of keyboard shortcuts
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1544 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1544 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieeab5b84674d26e4d29324614641813d8b65c517 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Jesús Corrius jcorr...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Change in core[libreoffice-4-0]: Fix for rtfexport subsequenttest
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1545 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/1545/1 Fix for rtfexport subsequenttest was re-using previous data buffer in later write to file fixes segfault in rtfexport subsequenttest should correct WMF image garbling, rtf breakage Change-Id: I9a296da5cfd29dc88c8e3e1352a6e9b38aeba4ef --- M sw/source/filter/ww8/rtfattributeoutput.cxx 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx b/sw/source/filter/ww8/rtfattributeoutput.cxx index 36d1cea..9a65c42 100644 --- a/sw/source/filter/ww8/rtfattributeoutput.cxx +++ b/sw/source/filter/ww8/rtfattributeoutput.cxx @@ -3347,7 +3347,7 @@ OSL_FAIL(failed to export the graphic); aWmfStream.Seek(STREAM_SEEK_TO_END); nSize = aWmfStream.Tell(); -pGraphicAry = (sal_uInt8*)aStream.GetData(); +pGraphicAry = (sal_uInt8*)aWmfStream.GetData(); m_aRunText-append(ExportPICT( pFlyFrmFmt, aSize, aRendered, aMapped, rCr, pBLIPType, pGraphicAry, nSize, m_rExport )); m_aRunText-append(}); // nonshppict } -- To view, visit https://gerrit.libreoffice.org/1545 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9a296da5cfd29dc88c8e3e1352a6e9b38aeba4ef Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: LeMoyne Castle lemoyne.cas...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Crash with gnome#627420-1.ods in string related function
On Thursday 03 of January 2013, Markus Mohrhard wrote: 2013/1/3 Lubos Lunak l.lu...@suse.cz: On Thursday 03 of January 2013, Markus Mohrhard wrote: Hey, while going through the list of calc documents crashing during import I came across gnome#627420-1.ods which creates an insanely large OUStringBuffer that ultimately leads to a crash. Since I believe we have quite a few places contain such problems. I wanted to ask if we should not try to find a solution in the string classes instead of having crashs with such documents from time to time. The question is, what kind of solution do you expect? Presumably the crash was because the allocation failed and the assert was a no-op because of non-debug build, leading to NULL pointer dereference. So probably the only thing we can do is have the assert always active, changing the crash to a different kind of crash, but that seems to be about it. Just to cear somethings up. I do have a dbgutil/debug build and it did not return a null pointer. It returned a pointer to some invalid memory which later results in the crash. Memory allocation functions are not supposed to return invalid memory just like that. Either the crash was because of memory overcommit (which is unlikely to cause a crash right after the allocation, and these days Linux distros do not enable it by default anyway), or the allocation function is buggy (which seems unlikely as well, ImplAlloc even checks for overflows). So I think it would help to know what actually went wrong. Please also note that the document is perfectly fine and valid according to ODF and my fix for it is for example now only a random limit for the text length. I have no idea how to find a general solution but I know that it would be good to have a way to prevent crashes with these documents. It sounds much better to find a way to prevent the crash in these documents on the string implementation than hope to find all places in our import code. While it might be a good idea to fix the import and check the input we will always have new import code where we forget to add these additional dafety checks. A string that is several ten million characters long is a good indicator for a potential problem. The point is, I don't think you can achieve that, which is why I asked what kind of solution you expect. If you alter the function to return a smaller/empty buffer in case of such a big size request, in some cases this call will be followed by code which will expect the buffer to be as big as requested and access it anyway (e.g. OUStringBuffer). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: oox/inc oox/source sw/source
oox/inc/oox/export/vmlexport.hxx |2 +-
oox/source/export/vmlexport.cxx |6 +++---
sw/source/filter/ww8/rtfsdrexport.cxx |2 +-
sw/source/filter/ww8/rtfsdrexport.hxx |2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
New commits:
commit a0d2c3c59fbe9324395152e544890fe298b60432
Author: Miklos Vajna vmik...@suse.cz
Date: Fri Jan 4 18:12:06 2013 +0100
adapt RtfSdrExport and oox::vml::VMLExport to filter changes
diff --git a/oox/inc/oox/export/vmlexport.hxx b/oox/inc/oox/export/vmlexport.hxx
index 54296a0..29ccdab 100644
--- a/oox/inc/oox/export/vmlexport.hxx
+++ b/oox/inc/oox/export/vmlexport.hxx
@@ -111,7 +111,7 @@ private:
virtual void OpenContainer( sal_uInt16 nEscherContainer, int nRecInstance
= 0 );
virtual void CloseContainer();
-virtual sal_uInt32 EnterGroup( const String rShapeName, const Rectangle*
pBoundRect = 0 );
+virtual sal_uInt32 EnterGroup( const OUString rShapeName, const
Rectangle* pBoundRect = 0 );
virtual void LeaveGroup();
virtual void AddShape( sal_uInt32 nShapeType, sal_uInt32 nShapeFlags,
sal_uInt32 nShapeId = 0 );
diff --git a/oox/source/export/vmlexport.cxx b/oox/source/export/vmlexport.cxx
index b843baf..407180c 100644
--- a/oox/source/export/vmlexport.cxx
+++ b/oox/source/export/vmlexport.cxx
@@ -99,7 +99,7 @@ void VMLExport::CloseContainer()
EscherEx::CloseContainer();
}
-sal_uInt32 VMLExport::EnterGroup( const String rShapeName, const Rectangle*
pRect )
+sal_uInt32 VMLExport::EnterGroup( const OUString rShapeName, const Rectangle*
pRect )
{
sal_uInt32 nShapeId = GenerateShapeId();
@@ -108,8 +108,8 @@ sal_uInt32 VMLExport::EnterGroup( const String rShapeName,
const Rectangle* pRe
pAttrList-add( XML_id, ShapeIdString( nShapeId ) );
-if ( rShapeName.Len() )
-pAttrList-add( XML_alt, OUStringToOString( OUString( rShapeName ),
RTL_TEXTENCODING_UTF8 ) );
+if ( rShapeName.getLength() )
+pAttrList-add( XML_alt, OUStringToOString( rShapeName,
RTL_TEXTENCODING_UTF8 ) );
// style
if ( pRect )
diff --git a/sw/source/filter/ww8/rtfsdrexport.cxx
b/sw/source/filter/ww8/rtfsdrexport.cxx
index 91fe300..2ca7ed6 100644
--- a/sw/source/filter/ww8/rtfsdrexport.cxx
+++ b/sw/source/filter/ww8/rtfsdrexport.cxx
@@ -82,7 +82,7 @@ void RtfSdrExport::CloseContainer()
EscherEx::CloseContainer();
}
-sal_uInt32 RtfSdrExport::EnterGroup( const String /*rShapeName*/, const
Rectangle* /*pRect*/ )
+sal_uInt32 RtfSdrExport::EnterGroup( const OUString /*rShapeName*/, const
Rectangle* /*pRect*/ )
{
SAL_INFO(sw.rtf, OSL_THIS_FUNC);
diff --git a/sw/source/filter/ww8/rtfsdrexport.hxx
b/sw/source/filter/ww8/rtfsdrexport.hxx
index 69c25d2..12eafbf 100644
--- a/sw/source/filter/ww8/rtfsdrexport.hxx
+++ b/sw/source/filter/ww8/rtfsdrexport.hxx
@@ -82,7 +82,7 @@ private:
virtual void CloseContainer();
using EscherEx::EnterGroup;
-virtual sal_uInt32 EnterGroup( const String rShapeName, const Rectangle*
pBoundRect = 0 );
+virtual sal_uInt32 EnterGroup( const OUString rShapeName, const
Rectangle* pBoundRect = 0 );
virtual void LeaveGroup();
virtual void AddShape( sal_uInt32 nShapeType, sal_uInt32 nShapeFlags,
sal_uInt32 nShapeId = 0 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] String cleanup in filter
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1507 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1507 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b8bd3535a5ba5323b9a17941c4345f4c1e0e822 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
not installing icon themes
Hello, i'd like to start stripping unneeded stuff when building for headless, starting from images. I've tried with --with-theme= but got the default themes instead. Would it be ok to change the meaning of to be none instead of default? Then i've tried with this patch which compiles fine but gives an error at install time because the installer still looks for them. Some grepping of theme in solenv shows gb_ResTarget_DEFIMAGESLOCATION which used later in $(call gb_ResTarget_get_target,%) makes me think that at least an icon set is mandatory. Any hint on a sensible approach? thanks in advance, riccardo diff --git a/postprocess/Module_postprocess.mk b/postprocess/Module_postprocess.mk index 0716ae7..f926306 100644 --- a/postprocess/Module_postprocess.mk +++ b/postprocess/Module_postprocess.mk @@ -17,14 +17,19 @@ $(eval $(call gb_Module_Module,postprocess)) $(eval $(call gb_Module_add_targets,postprocess,\ CustomTarget_config \ - CustomTarget_images \ CustomTarget_registry \ Package_config \ - Package_images \ Package_registry \ Rdb_services \ )) +ifneq ($(ENABLE_HEADLESS),TRUE) +$(eval $(call gb_Module_add_targets,postprocess,\ + CustomTarget_images \ + Package_images \ +)) +endif + ifeq ($(WINDOWS_BUILD_SIGNING),TRUE) $(eval $(call gb_Module_add_targets,postprocess,\ CustomTarget_signing \ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: how to submit a patch set 2 (or greater) to gerrit?
On Thu, Jan 3, 2013 at 9:50 AM, Winfried Donkers w.donk...@dci-electronics.nl wrote: Forgive me for being a dummy in this matter: For some time now I submit via gerrit and no longer to the dev-list with an attached patch. I submit with ./logerrit submit, as described in https://wiki.documentfoundation.org/Development#Using_Git_for_LibreOffice_development I can't work out how to update a submitted patch. https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch I encourage you to use the local branch workflow, using simply git commands. it is simple, effective and avoid a whole class of bugs that the different 'wrapper tools' bring in. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Doing massive source changes
On Fri, Jan 4, 2013 at 8:12 AM, Lubos Lunak l.lu...@suse.cz wrote: so this hopefully should be safe, but most of the changes have been done using sed, so there may be something that I've missed Well that is the crux of it isn't it ? Although the risk per change is small, with that many changes there are indeed a substantial chance somewhere of problems... and the only option is to revert it all... there is no practical means to narrow down where the problem might come from. that could be annoying enough in master... but on 4-0, after freeze and that close from planned release... I'm not wild about that. Norbert PS: a quick scrip on git log master..libreoffice-4-0-0.beta2 indicate that, out of all the 277 patch specifc to the 4.0 branch, 39 have touched line that contained 'rtl::' and therefore _could_ be in conflict... iow at most 1 in 5 considering that back-porting should be already made with caution and attentive review, running git mergetool on these to resolve these fairly straight forward conflict should not be too much over-head overall. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 58943, which changed state. Bug 58943 Summary: FILEOPEN .ods from LibO 3.6: Number FORMATTING not inherited in formula like =A1 https://bugs.freedesktop.org/show_bug.cgi?id=58943 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 5 commits - sc/source
sc/source/core/data/cell.cxx|5 -
sc/source/filter/oox/formulabuffer.cxx | 15 ---
sc/source/filter/oox/workbookhelper.cxx |6 +++---
sc/source/filter/xml/xmlcelli.cxx |6 +++---
4 files changed, 14 insertions(+), 18 deletions(-)
New commits:
commit d7524b9e8bff832b305ca9ec735664607c50224f
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Jan 4 20:06:07 2013 +0100
don't forget the dependency tree during OOXML import, fdo#58863
Change-Id: I8863faddd1bca0b55764d09c4ef9f959264b53ae
diff --git a/sc/source/filter/oox/formulabuffer.cxx
b/sc/source/filter/oox/formulabuffer.cxx
index 720f2af..b04c9d2 100644
--- a/sc/source/filter/oox/formulabuffer.cxx
+++ b/sc/source/filter/oox/formulabuffer.cxx
@@ -122,7 +122,8 @@ void FormulaBuffer::applyCellFormula( ScDocument rDoc,
const ApiTokenSequence
ScAddress aCellPos;
ScUnoConversion::FillScAddress( aCellPos, rAddress );
ScTokenConversion::ConvertToTokenArray( rDoc, aTokenArray, rTokens );
-ScBaseCell* pNewCell = new ScFormulaCell( rDoc, aCellPos, aTokenArray );
+ScFormulaCell* pNewCell = new ScFormulaCell( rDoc, aCellPos, aTokenArray
);
+pNewCell-StartListeningTo( rDoc );
rDoc.PutCell( aCellPos, pNewCell, sal_True );
}
commit 63b5af3d1f355a5f9649302058b32124ab262a20
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Jan 4 20:04:54 2013 +0100
don't forget the dependency tree during formula import
Change-Id: I0a9137e4f72477c0cffde6056d8952aa08e13f35
diff --git a/sc/source/filter/xml/xmlcelli.cxx
b/sc/source/filter/xml/xmlcelli.cxx
index 58919b0..2369dce 100644
--- a/sc/source/filter/xml/xmlcelli.cxx
+++ b/sc/source/filter/xml/xmlcelli.cxx
@@ -1025,16 +1025,16 @@ void ScXMLTableRowCellContext::PutFormulaCell( const
ScAddress rCellPos )
if ( aText[0] == '=' aText.getLength() 1 )
{
// temporary formula string as string tokens
-ScTokenArray* pCode = new ScTokenArray;
+boost::scoped_ptrScTokenArray pCode(new ScTokenArray);
pCode-AddStringXML( aText );
if( (eGrammar == formula::FormulaGrammar::GRAM_EXTERNAL)
!aFormulaNmsp.isEmpty() )
pCode-AddStringXML( aFormulaNmsp );
pDoc-IncXMLImportedFormulaCount( aText.getLength() );
-pNewCell = new ScFormulaCell( pDoc, rCellPos, pCode, eGrammar,
MM_NONE );
-delete pCode;
+pNewCell = new ScFormulaCell( pDoc, rCellPos, pCode.get(),
eGrammar, MM_NONE );
ScFormulaCell* pFCell = static_castScFormulaCell*(pNewCell);
+pFCell-StartListeningTo(pDoc);
SetFormulaCell(pFCell);
}
else if ( aText[0] == '\'' aText.getLength() 1 )
commit 86024f7ff841e016c4b4616802eaadc744a5b8bf
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Jan 4 19:46:43 2013 +0100
remove unnecessary german comment
Change-Id: I954015fb76089ae7d83344e8d99f6bc04587016f
diff --git a/sc/source/core/data/cell.cxx b/sc/source/core/data/cell.cxx
index bbf8976..3718976 100644
--- a/sc/source/core/data/cell.cxx
+++ b/sc/source/core/data/cell.cxx
@@ -1826,11 +1826,6 @@ void ScFormulaCell::SetDirty( bool bDirtyFlag )
SetDirtyVar();
else
{
-// Mehrfach-FormulaTracking in Load und in CompileAll
-// nach CopyScenario und CopyBlockFromClip vermeiden.
-// Wenn unbedingtes FormulaTracking noetig, vor SetDirty
bDirty=false
-// setzen, z.B. in CompileTokenArray
-
// Multiple Formulas avoid tracking in Load and Copy compileAll
// by Scenario and Copy Block From Clip.
// If unconditional required Formula tracking is set before
SetDirty
commit 9358e8f4622dd287daf9aa9a9f2bb6f7468122f8
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Jan 4 18:38:10 2013 +0100
correct indentation
Change-Id: I9b57ac13a8d508c260666535ee60783dee889508
diff --git a/sc/source/filter/oox/formulabuffer.cxx
b/sc/source/filter/oox/formulabuffer.cxx
index 70efcaf..720f2af 100644
--- a/sc/source/filter/oox/formulabuffer.cxx
+++ b/sc/source/filter/oox/formulabuffer.cxx
@@ -118,12 +118,12 @@ void FormulaBuffer::finalizeImport()
void FormulaBuffer::applyCellFormula( ScDocument rDoc, const
ApiTokenSequence rTokens, const ::com::sun::star::table::CellAddress rAddress
)
{
-ScTokenArray aTokenArray;
-ScAddress aCellPos;
-ScUnoConversion::FillScAddress( aCellPos, rAddress );
-ScTokenConversion::ConvertToTokenArray( rDoc, aTokenArray, rTokens );
-ScBaseCell* pNewCell = new ScFormulaCell( rDoc, aCellPos,
aTokenArray );
-rDoc.PutCell( aCellPos, pNewCell, sal_True );
+ScTokenArray aTokenArray;
+ScAddress aCellPos;
+ScUnoConversion::FillScAddress( aCellPos, rAddress );
+ScTokenConversion::ConvertToTokenArray( rDoc, aTokenArray,
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - sc/source
sc/source/filter/oox/formulabuffer.cxx | 13 +++--
sc/source/filter/xml/xmlcelli.cxx |6 +++---
2 files changed, 10 insertions(+), 9 deletions(-)
New commits:
commit 7b1ab8f2cf8b07e713c8511984c55e30d70c12d0
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Jan 4 20:06:07 2013 +0100
don't forget the dependency tree during OOXML import, fdo#58863
Change-Id: I8863faddd1bca0b55764d09c4ef9f959264b53ae
diff --git a/sc/source/filter/oox/formulabuffer.cxx
b/sc/source/filter/oox/formulabuffer.cxx
index 70efcaf..bd8598f 100644
--- a/sc/source/filter/oox/formulabuffer.cxx
+++ b/sc/source/filter/oox/formulabuffer.cxx
@@ -118,12 +118,13 @@ void FormulaBuffer::finalizeImport()
void FormulaBuffer::applyCellFormula( ScDocument rDoc, const
ApiTokenSequence rTokens, const ::com::sun::star::table::CellAddress rAddress
)
{
-ScTokenArray aTokenArray;
-ScAddress aCellPos;
-ScUnoConversion::FillScAddress( aCellPos, rAddress );
-ScTokenConversion::ConvertToTokenArray( rDoc, aTokenArray, rTokens );
-ScBaseCell* pNewCell = new ScFormulaCell( rDoc, aCellPos,
aTokenArray );
-rDoc.PutCell( aCellPos, pNewCell, sal_True );
+ScTokenArray aTokenArray;
+ScAddress aCellPos;
+ScUnoConversion::FillScAddress( aCellPos, rAddress );
+ScTokenConversion::ConvertToTokenArray( rDoc, aTokenArray, rTokens );
+ScFormulaCell* pNewCell = new ScFormulaCell( rDoc, aCellPos, aTokenArray
);
+pNewCell-StartListeningTo( rDoc );
+rDoc.PutCell( aCellPos, pNewCell, sal_True );
}
void FormulaBuffer::applyCellFormulas( const std::vector TokenAddressItem
rVector )
commit 4e0766f1707434aa34fcd71601d5a74c3865a9df
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Jan 4 20:04:54 2013 +0100
don't forget the dependency tree during formula import
Change-Id: I0a9137e4f72477c0cffde6056d8952aa08e13f35
diff --git a/sc/source/filter/xml/xmlcelli.cxx
b/sc/source/filter/xml/xmlcelli.cxx
index d58b9f5..5e745e9 100644
--- a/sc/source/filter/xml/xmlcelli.cxx
+++ b/sc/source/filter/xml/xmlcelli.cxx
@@ -1025,16 +1025,16 @@ void ScXMLTableRowCellContext::PutFormulaCell( const
ScAddress rCellPos )
if ( aText[0] == '=' aText.getLength() 1 )
{
// temporary formula string as string tokens
-ScTokenArray* pCode = new ScTokenArray;
+boost::scoped_ptrScTokenArray pCode(new ScTokenArray);
pCode-AddStringXML( aText );
if( (eGrammar == formula::FormulaGrammar::GRAM_EXTERNAL)
!aFormulaNmsp.isEmpty() )
pCode-AddStringXML( aFormulaNmsp );
pDoc-IncXMLImportedFormulaCount( aText.getLength() );
-pNewCell = new ScFormulaCell( pDoc, rCellPos, pCode, eGrammar,
MM_NONE );
-delete pCode;
+pNewCell = new ScFormulaCell( pDoc, rCellPos, pCode.get(),
eGrammar, MM_NONE );
ScFormulaCell* pFCell = static_castScFormulaCell*(pNewCell);
+pFCell-StartListeningTo(pDoc);
SetFormulaCell(pFCell);
}
else if ( aText[0] == '\'' aText.getLength() 1 )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 58863, which changed state. Bug 58863 Summary: FILEOPEN .xlsx: IF condition not calculated https://bugs.freedesktop.org/show_bug.cgi?id=58863 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Makefile.in
Makefile.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 149277ba2f630261ab9880523bf742318a7a7f12 Author: Matúš Kukan matus.ku...@gmail.com Date: Fri Jan 4 21:09:17 2013 +0100 fix the if filter-expression Let's use the orginal patch from https://gerrit.libreoffice.org/#/c/1479/ There is difference, visible e.g. by 'make help testtools' Change-Id: Iaf929ed1d315f038eb29fca1b4ba37e2143c6294 diff --git a/Makefile.in b/Makefile.in index b5a0428..fb00c38 100644 --- a/Makefile.in +++ b/Makefile.in @@ -21,7 +21,7 @@ BUILDDIR := @BUILDDIR@ # If you want to make something more than help clean distclean, # and make has not yet restarted itself.. # ..run autogen.sh if needed and force make to restart itself. -ifeq (,$(MAKE_RESTARTS)$(if $(filter help clean distclean,$(MAKECMDGOALS)),T)) +ifeq (,$(MAKE_RESTARTS)$(if $(filter-out help clean distclean,$(MAKECMDGOALS)),,T)) .PHONY : force-restart Makefile: $(BUILDDIR)/config_host.mk force-restart ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/inc sc/qa
sc/inc/document.hxx |2 -
sc/qa/unit/data/ods/row-height-import.ods |binary
sc/qa/unit/subsequent_filters-test.cxx| 56 ++
3 files changed, 57 insertions(+), 1 deletion(-)
New commits:
commit 4a11267d8140143dce0bdb51791f5e703187a7e9
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Jan 4 15:28:49 2013 -0500
New ods test document to check the import of row height values.
Test disabled as it currently fails.
Change-Id: I33ea3c95357fd7fdb9deaba30372567cfb69ebd6
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 41afbf2..5b5a472 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1357,7 +1357,7 @@ public:
SCROW LastNonFilteredRow(SCROW nStartRow, SCROW
nEndRow, SCTAB nTab);
SCROW CountNonFilteredRows(SCROW nStartRow, SCROW
nEndRow, SCTAB nTab);
-bool IsManualRowHeight(SCROW nRow, SCTAB nTab) const;
+SC_DLLPUBLIC bool IsManualRowHeight(SCROW nRow, SCTAB nTab) const;
/**
* Write all column row flags to table's flag data, because not all column
diff --git a/sc/qa/unit/data/ods/row-height-import.ods
b/sc/qa/unit/data/ods/row-height-import.ods
new file mode 100644
index 000..2deb104
Binary files /dev/null and b/sc/qa/unit/data/ods/row-height-import.ods differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx
b/sc/qa/unit/subsequent_filters-test.cxx
index d31bd8d..c283508 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -169,6 +169,8 @@ public:
void testPivotTableBasicODS();
+void testRowHeight();
+
CPPUNIT_TEST_SUITE(ScFiltersTest);
CPPUNIT_TEST(testRangeNameXLS);
CPPUNIT_TEST(testRangeNameXLSX);
@@ -210,6 +212,7 @@ public:
CPPUNIT_TEST(testCellAnchoredShapesODS);
CPPUNIT_TEST(testPivotTableBasicODS);
+// CPPUNIT_TEST(testRowHeight);
//disable testPassword on MacOSX due to problems with libsqlite3
//also crashes on DragonFly due to problems with nss/nspr headers
@@ -1569,6 +1572,59 @@ void ScFiltersTest::testPivotTableBasicODS()
xDocSh-DoClose();
}
+void ScFiltersTest::testRowHeight()
+{
+OUString aFileNameBase(row-height-import.);
+OUString aFileExt = OUString::createFromAscii(aFileFormats[ODS].pName);
+OUString aFilterName =
OUString::createFromAscii(aFileFormats[ODS].pFilterName);
+OUString aFilterType =
OUString::createFromAscii(aFileFormats[ODS].pTypeName);
+
+rtl::OUString aFileName;
+createFileURL(aFileNameBase, aFileExt, aFileName);
+
+unsigned int nFormatType = aFileFormats[ODS].nFormatType;
+unsigned int nClipboardId = nFormatType ? SFX_FILTER_IMPORT |
SFX_FILTER_USESOPTIONS : 0;
+ScDocShellRef xDocSh = load(aFilterName, aFileName, rtl::OUString(),
aFilterType,
+nFormatType, nClipboardId, SOFFICE_FILEFORMAT_CURRENT);
+
+SCTAB nTab = 0;
+SCROW nRow = 0;
+ScDocument* pDoc = xDocSh-GetDocument();
+
+// The first 3 rows have manual heights.
+int nHeight = pDoc-GetRowHeight(nRow, nTab, false);
+bool bManual = pDoc-IsManualRowHeight(nRow, nTab);
+CPPUNIT_ASSERT_EQUAL(600, nHeight);
+CPPUNIT_ASSERT_MESSAGE(this row should have a manual row height.,
bManual);
+nHeight = pDoc-GetRowHeight(++nRow, nTab, false);
+bManual = pDoc-IsManualRowHeight(nRow, nTab);
+CPPUNIT_ASSERT_EQUAL(1200, nHeight);
+CPPUNIT_ASSERT_MESSAGE(this row should have a manual row height.,
bManual);
+nHeight = pDoc-GetRowHeight(++nRow, nTab, false);
+bManual = pDoc-IsManualRowHeight(nRow, nTab);
+CPPUNIT_ASSERT_EQUAL(1800, nHeight);
+CPPUNIT_ASSERT_MESSAGE(this row should have a manual row height.,
bManual);
+
+// This one should have an automatic row height.
+bManual = pDoc-IsManualRowHeight(++nRow, nTab);
+CPPUNIT_ASSERT_MESSAGE(Row should have an automatic height., !bManual);
+
+// Followed by a row with manual height.
+nHeight = pDoc-GetRowHeight(++nRow, nTab, false);
+bManual = pDoc-IsManualRowHeight(nRow, nTab);
+CPPUNIT_ASSERT_EQUAL(2400, nHeight);
+CPPUNIT_ASSERT_MESSAGE(this row should have a manual row height.,
bManual);
+
+// And all the rest should have automatic heights.
+bManual = pDoc-IsManualRowHeight(++nRow, nTab);
+CPPUNIT_ASSERT_MESSAGE(Row should have an automatic height., !bManual);
+
+bManual = pDoc-IsManualRowHeight(MAXROW, nTab);
+CPPUNIT_ASSERT_MESSAGE(Row should have an automatic height., !bManual);
+
+xDocSh-DoClose();
+}
+
namespace {
void testColorScaleFormat_Impl(const rtl::OUString rFilePath, const
ScConditionalFormat* pFormat)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/inc sc/qa
sc/inc/document.hxx |2 -
sc/qa/unit/data/ods/row-height-import.ods |binary
sc/qa/unit/subsequent_filters-test.cxx| 56 ++
3 files changed, 57 insertions(+), 1 deletion(-)
New commits:
commit 13b8cbbb1e527051940749e29c1d106773c39a94
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Jan 4 15:28:49 2013 -0500
New ods test document to check the import of row height values.
Test disabled as it currently fails.
Change-Id: I33ea3c95357fd7fdb9deaba30372567cfb69ebd6
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 41afbf2..5b5a472 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1357,7 +1357,7 @@ public:
SCROW LastNonFilteredRow(SCROW nStartRow, SCROW
nEndRow, SCTAB nTab);
SCROW CountNonFilteredRows(SCROW nStartRow, SCROW
nEndRow, SCTAB nTab);
-bool IsManualRowHeight(SCROW nRow, SCTAB nTab) const;
+SC_DLLPUBLIC bool IsManualRowHeight(SCROW nRow, SCTAB nTab) const;
/**
* Write all column row flags to table's flag data, because not all column
diff --git a/sc/qa/unit/data/ods/row-height-import.ods
b/sc/qa/unit/data/ods/row-height-import.ods
new file mode 100644
index 000..2deb104
Binary files /dev/null and b/sc/qa/unit/data/ods/row-height-import.ods differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx
b/sc/qa/unit/subsequent_filters-test.cxx
index d31bd8d..c283508 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -169,6 +169,8 @@ public:
void testPivotTableBasicODS();
+void testRowHeight();
+
CPPUNIT_TEST_SUITE(ScFiltersTest);
CPPUNIT_TEST(testRangeNameXLS);
CPPUNIT_TEST(testRangeNameXLSX);
@@ -210,6 +212,7 @@ public:
CPPUNIT_TEST(testCellAnchoredShapesODS);
CPPUNIT_TEST(testPivotTableBasicODS);
+// CPPUNIT_TEST(testRowHeight);
//disable testPassword on MacOSX due to problems with libsqlite3
//also crashes on DragonFly due to problems with nss/nspr headers
@@ -1569,6 +1572,59 @@ void ScFiltersTest::testPivotTableBasicODS()
xDocSh-DoClose();
}
+void ScFiltersTest::testRowHeight()
+{
+OUString aFileNameBase(row-height-import.);
+OUString aFileExt = OUString::createFromAscii(aFileFormats[ODS].pName);
+OUString aFilterName =
OUString::createFromAscii(aFileFormats[ODS].pFilterName);
+OUString aFilterType =
OUString::createFromAscii(aFileFormats[ODS].pTypeName);
+
+rtl::OUString aFileName;
+createFileURL(aFileNameBase, aFileExt, aFileName);
+
+unsigned int nFormatType = aFileFormats[ODS].nFormatType;
+unsigned int nClipboardId = nFormatType ? SFX_FILTER_IMPORT |
SFX_FILTER_USESOPTIONS : 0;
+ScDocShellRef xDocSh = load(aFilterName, aFileName, rtl::OUString(),
aFilterType,
+nFormatType, nClipboardId, SOFFICE_FILEFORMAT_CURRENT);
+
+SCTAB nTab = 0;
+SCROW nRow = 0;
+ScDocument* pDoc = xDocSh-GetDocument();
+
+// The first 3 rows have manual heights.
+int nHeight = pDoc-GetRowHeight(nRow, nTab, false);
+bool bManual = pDoc-IsManualRowHeight(nRow, nTab);
+CPPUNIT_ASSERT_EQUAL(600, nHeight);
+CPPUNIT_ASSERT_MESSAGE(this row should have a manual row height.,
bManual);
+nHeight = pDoc-GetRowHeight(++nRow, nTab, false);
+bManual = pDoc-IsManualRowHeight(nRow, nTab);
+CPPUNIT_ASSERT_EQUAL(1200, nHeight);
+CPPUNIT_ASSERT_MESSAGE(this row should have a manual row height.,
bManual);
+nHeight = pDoc-GetRowHeight(++nRow, nTab, false);
+bManual = pDoc-IsManualRowHeight(nRow, nTab);
+CPPUNIT_ASSERT_EQUAL(1800, nHeight);
+CPPUNIT_ASSERT_MESSAGE(this row should have a manual row height.,
bManual);
+
+// This one should have an automatic row height.
+bManual = pDoc-IsManualRowHeight(++nRow, nTab);
+CPPUNIT_ASSERT_MESSAGE(Row should have an automatic height., !bManual);
+
+// Followed by a row with manual height.
+nHeight = pDoc-GetRowHeight(++nRow, nTab, false);
+bManual = pDoc-IsManualRowHeight(nRow, nTab);
+CPPUNIT_ASSERT_EQUAL(2400, nHeight);
+CPPUNIT_ASSERT_MESSAGE(this row should have a manual row height.,
bManual);
+
+// And all the rest should have automatic heights.
+bManual = pDoc-IsManualRowHeight(++nRow, nTab);
+CPPUNIT_ASSERT_MESSAGE(Row should have an automatic height., !bManual);
+
+bManual = pDoc-IsManualRowHeight(MAXROW, nTab);
+CPPUNIT_ASSERT_MESSAGE(Row should have an automatic height., !bManual);
+
+xDocSh-DoClose();
+}
+
namespace {
void testColorScaleFormat_Impl(const rtl::OUString rFilePath, const
ScConditionalFormat* pFormat)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: vcl/source
vcl/source/filter/jpeg/jpeg.cxx |4 ++--
vcl/source/filter/jpeg/jpegc.c |4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 540f090a68ae4375a36d0ee6dfbb4a82f28ac704
Author: Jan Holesovsky ke...@suse.cz
Date: Fri Jan 4 22:02:34 2013 +0100
Fix build on linux.
Change-Id: I5753a822e9f18d1afa831ece6134e030f88ad47f
diff --git a/vcl/source/filter/jpeg/jpeg.cxx b/vcl/source/filter/jpeg/jpeg.cxx
index 3c0fe9c..72c6e57 100644
--- a/vcl/source/filter/jpeg/jpeg.cxx
+++ b/vcl/source/filter/jpeg/jpeg.cxx
@@ -24,8 +24,8 @@ extern C
{
#include stdio.h
#include jpeg.h
-#include jpeg/jpeglib.h
-#include jpeg/jerror.h
+#include jpeglib.h
+#include jerror.h
}
#define _JPEGPRIVATE
diff --git a/vcl/source/filter/jpeg/jpegc.c b/vcl/source/filter/jpeg/jpegc.c
index f9bcc07..e70aa53 100644
--- a/vcl/source/filter/jpeg/jpegc.c
+++ b/vcl/source/filter/jpeg/jpegc.c
@@ -20,8 +20,8 @@
#include stdio.h
#include stdlib.h
#include setjmp.h
-#include jpeg/jpeglib.h
-#include jpeg/jerror.h
+#include jpeglib.h
+#include jerror.h
#include jpeg.h
#include rtl/alloc.h
#include osl/diagnose.h
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: bug/bug_fr
bug/bug_fr/bug/mail.php |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 32981f96d1d2f2aba545fc81140aceb5ac247a32 Author: Rob Snelders programm...@ertai.nl Date: Fri Jan 4 22:45:52 2013 +0100 removed emailadres diff --git a/bug/bug_fr/bug/mail.php b/bug/bug_fr/bug/mail.php index 892ca5a..68ea3ee 100644 --- a/bug/bug_fr/bug/mail.php +++ b/bug/bug_fr/bug/mail.php @@ -5,7 +5,7 @@ echo(FALSE); } - $to = programm...@ertai.nl; + $to = ; $subject = New Bug via the French BSA!; $body = Hi,\n\nThere was a new bug filed in french. Can somebody triage it for us?\n\n; $body = $body + Component: + $_POST[component] + \n; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/qa
sc/qa/unit/data/ods/dependencyTree.ods |binary
sc/qa/unit/subsequent_filters-test.cxx | 30 ++
2 files changed, 30 insertions(+)
New commits:
commit c8f8a2d3f9867850ad7effb585ff6414815c73ce
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Jan 4 22:41:50 2013 +0100
add unit test for dependency tree during ods import
Change-Id: I92bff38304959237042b9a0078be25948d642b25
diff --git a/sc/qa/unit/data/ods/dependencyTree.ods
b/sc/qa/unit/data/ods/dependencyTree.ods
new file mode 100644
index 000..fc5aae0
Binary files /dev/null and b/sc/qa/unit/data/ods/dependencyTree.ods differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx
b/sc/qa/unit/subsequent_filters-test.cxx
index c283508..5acbfb8 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -168,6 +168,7 @@ public:
void testCellAnchoredShapesODS();
void testPivotTableBasicODS();
+void testFormulaDependency();
void testRowHeight();
@@ -213,6 +214,7 @@ public:
CPPUNIT_TEST(testPivotTableBasicODS);
// CPPUNIT_TEST(testRowHeight);
+CPPUNIT_TEST(testFormulaDependency);
//disable testPassword on MacOSX due to problems with libsqlite3
//also crashes on DragonFly due to problems with nss/nspr headers
@@ -1749,6 +1751,34 @@ void ScFiltersTest::testNewCondFormat()
testCondFile(aCSVPath, pDoc, 0);
}
+void ScFiltersTest::testFormulaDependency()
+{
+const rtl::OUString aFileNameBase(dependencyTree.);
+rtl::OUString aFileExtension(aFileFormats[ODS].pName,
strlen(aFileFormats[ODS].pName), RTL_TEXTENCODING_UTF8 );
+rtl::OUString aFilterName(aFileFormats[ODS].pFilterName,
strlen(aFileFormats[ODS].pFilterName), RTL_TEXTENCODING_UTF8) ;
+rtl::OUString aFileName;
+createFileURL(aFileNameBase, aFileExtension, aFileName);
+rtl::OUString aFilterType(aFileFormats[ODS].pTypeName,
strlen(aFileFormats[ODS].pTypeName), RTL_TEXTENCODING_UTF8);
+std::cout aFileFormats[ODS].pName Test std::endl;
+
+unsigned int nFormatType = aFileFormats[ODS].nFormatType;
+unsigned int nClipboardId = nFormatType ? SFX_FILTER_IMPORT |
SFX_FILTER_USESOPTIONS : 0;
+ScDocShellRef xDocSh = load(aFilterName, aFileName, rtl::OUString(),
aFilterType,
+nFormatType, nClipboardId, SOFFICE_FILEFORMAT_CURRENT);
+
+ScDocument* pDoc = xDocSh-GetDocument();
+
+// check if formula in A1 changes value
+double nVal = pDoc-GetValue(0,0,0);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(nVal, 1.0, 1e-10);
+pDoc-SetValue(0,1,0, 0.0);
+nVal = pDoc-GetValue(0,0,0);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(nVal, 2.0, 1e-10);
+
+// check that the number format is implicity inherited
+// CPPUNIT_ASSERT_EQUAL(pDoc-GetString(0,4,0), pDoc-GetString(0,5,0));
+}
+
ScFiltersTest::ScFiltersTest()
: m_aBaseString(RTL_CONSTASCII_USTRINGPARAM(/sc/qa/unit/data))
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/qa
sc/qa/unit/data/ods/dependencyTree.ods |binary
sc/qa/unit/subsequent_filters-test.cxx | 30 ++
2 files changed, 30 insertions(+)
New commits:
commit cc84ff4a51790f52f2e729cc61f7515fbbd51f35
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Jan 4 22:41:50 2013 +0100
add unit test for dependency tree during ods import
Change-Id: I92bff38304959237042b9a0078be25948d642b25
diff --git a/sc/qa/unit/data/ods/dependencyTree.ods
b/sc/qa/unit/data/ods/dependencyTree.ods
new file mode 100644
index 000..fc5aae0
Binary files /dev/null and b/sc/qa/unit/data/ods/dependencyTree.ods differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx
b/sc/qa/unit/subsequent_filters-test.cxx
index c283508..5acbfb8 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -168,6 +168,7 @@ public:
void testCellAnchoredShapesODS();
void testPivotTableBasicODS();
+void testFormulaDependency();
void testRowHeight();
@@ -213,6 +214,7 @@ public:
CPPUNIT_TEST(testPivotTableBasicODS);
// CPPUNIT_TEST(testRowHeight);
+CPPUNIT_TEST(testFormulaDependency);
//disable testPassword on MacOSX due to problems with libsqlite3
//also crashes on DragonFly due to problems with nss/nspr headers
@@ -1749,6 +1751,34 @@ void ScFiltersTest::testNewCondFormat()
testCondFile(aCSVPath, pDoc, 0);
}
+void ScFiltersTest::testFormulaDependency()
+{
+const rtl::OUString aFileNameBase(dependencyTree.);
+rtl::OUString aFileExtension(aFileFormats[ODS].pName,
strlen(aFileFormats[ODS].pName), RTL_TEXTENCODING_UTF8 );
+rtl::OUString aFilterName(aFileFormats[ODS].pFilterName,
strlen(aFileFormats[ODS].pFilterName), RTL_TEXTENCODING_UTF8) ;
+rtl::OUString aFileName;
+createFileURL(aFileNameBase, aFileExtension, aFileName);
+rtl::OUString aFilterType(aFileFormats[ODS].pTypeName,
strlen(aFileFormats[ODS].pTypeName), RTL_TEXTENCODING_UTF8);
+std::cout aFileFormats[ODS].pName Test std::endl;
+
+unsigned int nFormatType = aFileFormats[ODS].nFormatType;
+unsigned int nClipboardId = nFormatType ? SFX_FILTER_IMPORT |
SFX_FILTER_USESOPTIONS : 0;
+ScDocShellRef xDocSh = load(aFilterName, aFileName, rtl::OUString(),
aFilterType,
+nFormatType, nClipboardId, SOFFICE_FILEFORMAT_CURRENT);
+
+ScDocument* pDoc = xDocSh-GetDocument();
+
+// check if formula in A1 changes value
+double nVal = pDoc-GetValue(0,0,0);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(nVal, 1.0, 1e-10);
+pDoc-SetValue(0,1,0, 0.0);
+nVal = pDoc-GetValue(0,0,0);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(nVal, 2.0, 1e-10);
+
+// check that the number format is implicity inherited
+// CPPUNIT_ASSERT_EQUAL(pDoc-GetString(0,4,0), pDoc-GetString(0,5,0));
+}
+
ScFiltersTest::ScFiltersTest()
: m_aBaseString(RTL_CONSTASCII_USTRINGPARAM(/sc/qa/unit/data))
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: bug/bug_fr
bug/bug_fr/Makefile |5 + bug/bug_fr/bug.xhtml | 40 dev/null |binary 3 files changed, 21 insertions(+), 24 deletions(-) New commits: commit fe0715353cfb193d826b4db994dd946d37819be5 Author: Rob Snelders programm...@ertai.nl Date: Fri Jan 4 23:22:31 2013 +0100 translating to French diff --git a/bug/bug_fr/.bug.xhtml.swp b/bug/bug_fr/.bug.xhtml.swp deleted file mode 100644 index ce5fb6b..000 Binary files a/bug/bug_fr/.bug.xhtml.swp and /dev/null differ diff --git a/bug/bug_fr/Makefile b/bug/bug_fr/Makefile index 4ae7318..52bee92 100644 --- a/bug/bug_fr/Makefile +++ b/bug/bug_fr/Makefile @@ -20,9 +20,6 @@ extract: mkdir -p build curl --silent https://wiki.documentfoundation.org/BugReport_Details | tidy --numeric-entities yes -asxhtml 2/dev/null build/tidyout.xhtml || echo ignoring tidy error xsltproc --encoding UTF-8 --novalid stripnamespace.xsl build/tidyout.xhtml build/BugReport_Details.xhtml - xsltproc --encoding UTF-8 --novalid component_comments.xsl build/BugReport_Details.xhtml build/component_comments.xhtml - xsltproc --encoding UTF-8 --novalid subcomponents.xsl build/BugReport_Details.xhtml build/subcomponents.xhtml - xsltproc --encoding UTF-8 --novalid components.xsl build/BugReport_Details.xhtml build/components.xhtml curl --silent 'https://bugs.freedesktop.org/query.cgi?product=LibreOfficequery_format=advanced' build/query.xhtml perl op_sys.pl op_sys.txt build/op_sys.xhtml perl query.pl build/query.xhtml build/versions.xhtml @@ -35,5 +32,5 @@ check: perl sanity.pl TEST clean: - rm -f build/BugReport_Details.xhtml build/tidyout.xhtml build/component_comments.xhtml build/subcomponents.xhtml build/components.xhtml build/query.xhtml build/versions.xhtml bug/bug.html + rm -f build/BugReport_Details.xhtml build/tidyout.xhtml build/query.xhtml build/versions.xhtml bug/bug.html rmdir build diff --git a/bug/bug_fr/bug.xhtml b/bug/bug_fr/bug.xhtml index 75c136f..8d9c473 100644 --- a/bug/bug_fr/bug.xhtml +++ b/bug/bug_fr/bug.xhtml @@ -26,7 +26,7 @@ along with this program. If not, see http:www.gnu.org/licenses/. -- head -titleBug Submission Assistant/title +titleAssistant de soumission de bugs/title meta http-equiv=Content-type content=text/html;charset=UTF-8/ script type=text/javascript src=jquery-1.6.2.js/script script type=text/javascript src=bug.js/script @@ -53,28 +53,28 @@ /div div class=header div class=title - divBug/div - divSubmission/div divAssistant/div + divde soumission/div + divde bugs/div /div div class=submission - Thank you for using LibreOffice. We regret that you seem to have found a bug in our software, but we are glad that you decided to report it. This assistant will lead you step by step through the bug reporting process. + Merci d'utiliser LibreOffice. Nous sommes désolés du dysfonctionnement trouvé dans notre logiciel, mais nous sommes contents que vous souhaitiez en faire le rapport. Cet assistant va vous guider à travers les étapes du processus de rapport de bugs. /div /div div class=content div class=left div -div class=step step_signindiv class=count1/divdiv class=labelSign in/div/div -div class=step step_componentdiv class=count2/divdiv class=labelComponent/div/div -div class=step step_detailsdiv class=count3/divdiv class=labelDetails/div/div +div class=step step_signindiv class=count1/divdiv class=labelS'inscrire/div/div +div class=step step_componentdiv class=count2/divdiv class=labelComposant/div/div +div class=step step_detailsdiv class=count3/divdiv class=labelDétails/div/div div class=step step_descriptiondiv class=count4/divdiv class=labelDescription/div/div -div class=step step_submitdiv class=count5/divdiv class=labelSubmit/div/div +div class=step step_submitdiv class=count5/divdiv class=labelSoumettre/div/div /div div class=legal -All your contributions will be public in WWW! By clicking the 'Submit' button you irrevocably agree to release your contribution under the CC-BY-SA 3.0 License and the GFDL. If you can't agree to these terms for documents you planned to attach you can state in this report that such a document exists. QA team will discuss with you further proceeding in the bug. +Toutes vos contributions seront rendues publiques dans WWW ! En cliquant sur le bouton 'Soumettre' vous acceptez irrévocablement de mettre à disposition votre contribution sous la licence CC-BY-SA 3.0 et GFDL. Si vous n'acceptez par ces termes pour les documents que vous allez attacher vous pouvez indiquer dans ce rapport qu'un
[Libreoffice-commits] .: 2 commits - cui/source vcl/source
cui/source/options/personalization.cxx | 28 +---
vcl/source/window/dockingarea.cxx |1 +
2 files changed, 26 insertions(+), 3 deletions(-)
New commits:
commit 3f3d0c52ae29b6ab6b2c10a5557714361aa76a26
Author: Jan Holesovsky ke...@suse.cz
Date: Fri Jan 4 23:43:42 2013 +0100
Personas: Broadcast the information that the Persona has changed.
Change-Id: Ic563204c1a1a64d315e3e73dff30b6a6d05cfd87
diff --git a/cui/source/options/personalization.cxx
b/cui/source/options/personalization.cxx
index ae8f605..14e071f 100644
--- a/cui/source/options/personalization.cxx
+++ b/cui/source/options/personalization.cxx
@@ -16,6 +16,7 @@
#include tools/urlobj.hxx
#include vcl/edit.hxx
#include vcl/msgbox.hxx
+#include vcl/svapp.hxx
#include com/sun/star/lang/XMultiServiceFactory.hpp
#include com/sun/star/system/SystemShellExecute.hpp
@@ -161,6 +162,13 @@ sal_Bool SvxPersonalizationTabPage::FillItemSet(
SfxItemSet )
batch-commit();
+if ( bModified )
+{
+// broadcast the change
+DataChangedEvent aDataChanged( DATACHANGED_SETTINGS, NULL,
SETTINGS_STYLE );
+Application::NotifyAllWindows( aDataChanged );
+}
+
return bModified;
}
diff --git a/vcl/source/window/dockingarea.cxx
b/vcl/source/window/dockingarea.cxx
index 7d97dd9..8269c5e 100644
--- a/vcl/source/window/dockingarea.cxx
+++ b/vcl/source/window/dockingarea.cxx
@@ -103,6 +103,7 @@ void DockingAreaWindow::DataChanged( const
DataChangedEvent rDCEvt )
if ( (rDCEvt.GetType() == DATACHANGED_SETTINGS) (rDCEvt.GetFlags()
SETTINGS_STYLE) )
{
ImplInitBackground( this );
+Invalidate();
}
}
commit c223e5ff859171adab1597025b30ec2501fc5771
Author: Jan Holesovsky ke...@suse.cz
Date: Fri Jan 4 23:09:18 2013 +0100
Personas: More robust Persona URL handling.
Change-Id: I55fa2570decd52e978747e589887f2fe972812c8
diff --git a/cui/source/options/personalization.cxx
b/cui/source/options/personalization.cxx
index 7d31b0f..ae8f605 100644
--- a/cui/source/options/personalization.cxx
+++ b/cui/source/options/personalization.cxx
@@ -71,7 +71,14 @@ OUString SelectPersonaDialog::GetPersonaURL() const
return OUString();
}
-return aText;
+// canonicalize the URL
+OUString aPersona( persona/ );
+sal_Int32 nPersona = aText.lastIndexOf( aPersona );
+
+if ( nPersona 0 )
+return OUString();
+
+return http://www.getpersonas.com/persona/; + aText.copy( nPersona +
aPersona.getLength() );
}
IMPL_LINK( SelectPersonaDialog, VisitPersonas, PushButton*, /*pButton*/ )
@@ -236,7 +243,7 @@ IMPL_LINK( SvxPersonalizationTabPage, SelectPersona,
PushButton*, /*pButton*/ )
while ( aDialog.Execute() == RET_OK )
{
OUString aURL( aDialog.GetPersonaURL() );
-if ( aURL != )
+if ( !aURL.isEmpty() )
{
if ( CopyPersonaToGallery( aURL ) )
m_pOwnPersona-Check();
@@ -312,7 +319,14 @@ bool SvxPersonalizationTabPage::CopyPersonaToGallery(
const OUString rURL )
if ( !xFileAccess.is() )
return false;
-uno::Reference io::XInputStream xStream( xFileAccess-openFileRead(
rURL ), uno::UNO_QUERY );
+uno::Reference io::XInputStream xStream;
+try {
+xStream = xFileAccess-openFileRead( rURL );
+}
+catch (...)
+{
+return false;
+}
if ( !xStream.is() )
return false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - libcdr/libcdr-issupported-exception.patch.1 libcdr/UnpackedTarball_cdr.mk sw/source
libcdr/UnpackedTarball_cdr.mk |1
libcdr/libcdr-issupported-exception.patch.1 | 43
sw/source/ui/uno/unotxdoc.cxx |5 ++-
3 files changed, 48 insertions(+), 1 deletion(-)
New commits:
commit 374f7465729c98f2cc8af72f876a8eab01d192a6
Author: Michael Stahl mst...@redhat.com
Date: Fri Jan 4 23:44:38 2013 +0100
rhbz#891082: CMXDocument::isSupported: catch exceptions
Change-Id: I715975dfa93d736cb537076feab4afe6b75c162a
diff --git a/libcdr/UnpackedTarball_cdr.mk b/libcdr/UnpackedTarball_cdr.mk
index 3b02022..b8b6726 100644
--- a/libcdr/UnpackedTarball_cdr.mk
+++ b/libcdr/UnpackedTarball_cdr.mk
@@ -15,6 +15,7 @@ $(eval $(call gb_UnpackedTarball_set_patchlevel,cdr,1))
$(eval $(call gb_UnpackedTarball_add_patches,cdr,\
libcdr/libcdr-configure.patch.1 \
+ libcdr/libcdr-issupported-exception.patch.1 \
libcdr/libcdr-msvc.patch \
))
diff --git a/libcdr/libcdr-issupported-exception.patch.1
b/libcdr/libcdr-issupported-exception.patch.1
new file mode 100644
index 000..ee4ecec
--- /dev/null
+++ b/libcdr/libcdr-issupported-exception.patch.1
@@ -0,0 +1,43 @@
+rhbz#891082: CMXDocument::isSupported: catch exceptions
+
+diff -ru cdr.old/src/lib/CMXDocument.cpp cdr/src/lib/CMXDocument.cpp
+--- cdr.old/src/lib/CMXDocument.cpp
cdr/src/lib/CMXDocument.cpp
+@@ -46,20 +46,24 @@
+ */
+ bool libcdr::CMXDocument::isSupported(WPXInputStream *input)
+ {
+- input-seek(0, WPX_SEEK_SET);
+- unsigned riff = readU32(input);
+- if (riff != FOURCC_RIFF riff != FOURCC_RIFX)
+-return false;
+- input-seek(4, WPX_SEEK_CUR);
+- char signature_c = (char)readU8(input);
+- if (signature_c != 'C' signature_c != 'c')
+-return false;
+- char signature_d = (char)readU8(input);
+- if (signature_d != 'M' signature_d != 'm')
+-return false;
+- char signature_r = (char)readU8(input);
+- if (signature_r != 'X' signature_r != 'x')
++ try {
++input-seek(0, WPX_SEEK_SET);
++unsigned riff = readU32(input);
++if (riff != FOURCC_RIFF riff != FOURCC_RIFX)
++ return false;
++input-seek(4, WPX_SEEK_CUR);
++char signature_c = (char)readU8(input);
++if (signature_c != 'C' signature_c != 'c')
++ return false;
++char signature_d = (char)readU8(input);
++if (signature_d != 'M' signature_d != 'm')
++ return false;
++char signature_r = (char)readU8(input);
++if (signature_r != 'X' signature_r != 'x')
++ return false;
++ } catch (...) {
+ return false;
++ }
+ return true;
+ }
+
commit 1c52268a5bc6d79c6ee1344e4e341c7e3820d4e0
Author: Michael Stahl mst...@redhat.com
Date: Fri Jan 4 22:27:22 2013 +0100
rhbz#890080: crash in SwXTextDocument::getRendererCount
No idea how to reproduce it; pSwView is checked before use except here.
(possibly regression from 2f9f480b22f2fff59d9c48b4b46706c3d5223e66)
Change-Id: Ia7667e879a6944e084a45c06133efc1ac2d8b3c0
diff --git a/sw/source/ui/uno/unotxdoc.cxx b/sw/source/ui/uno/unotxdoc.cxx
index ba146fd..9977d7b 100644
--- a/sw/source/ui/uno/unotxdoc.cxx
+++ b/sw/source/ui/uno/unotxdoc.cxx
@@ -2537,7 +2537,10 @@ sal_Int32 SAL_CALL SwXTextDocument::getRendererCount(
SwViewOption aOpt( *pViewShell-GetViewOptions() );
aOpt.setBrowseMode( false );
pViewShell-ApplyViewOptions( aOpt );
-pSwView-RecheckBrowseMode();
+if (pSwView)
+{
+pSwView-RecheckBrowseMode();
+}
}
// reformating the document for printing will show the changes in
the view
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - libcdr/libcdr-issupported-exception.patch.1 libcdr/UnpackedTarball_cdr.mk sw/source
libcdr/UnpackedTarball_cdr.mk |1
libcdr/libcdr-issupported-exception.patch.1 | 43
sw/source/ui/uno/unotxdoc.cxx |5 ++-
3 files changed, 48 insertions(+), 1 deletion(-)
New commits:
commit 6738ae52bd075dc6478dedfeddc60d1c25cffcb2
Author: Michael Stahl mst...@redhat.com
Date: Fri Jan 4 23:44:38 2013 +0100
rhbz#891082: CMXDocument::isSupported: catch exceptions
Change-Id: I715975dfa93d736cb537076feab4afe6b75c162a
(cherry picked from commit 374f7465729c98f2cc8af72f876a8eab01d192a6)
diff --git a/libcdr/UnpackedTarball_cdr.mk b/libcdr/UnpackedTarball_cdr.mk
index 3b02022..b8b6726 100644
--- a/libcdr/UnpackedTarball_cdr.mk
+++ b/libcdr/UnpackedTarball_cdr.mk
@@ -15,6 +15,7 @@ $(eval $(call gb_UnpackedTarball_set_patchlevel,cdr,1))
$(eval $(call gb_UnpackedTarball_add_patches,cdr,\
libcdr/libcdr-configure.patch.1 \
+ libcdr/libcdr-issupported-exception.patch.1 \
libcdr/libcdr-msvc.patch \
))
diff --git a/libcdr/libcdr-issupported-exception.patch.1
b/libcdr/libcdr-issupported-exception.patch.1
new file mode 100644
index 000..ee4ecec
--- /dev/null
+++ b/libcdr/libcdr-issupported-exception.patch.1
@@ -0,0 +1,43 @@
+rhbz#891082: CMXDocument::isSupported: catch exceptions
+
+diff -ru cdr.old/src/lib/CMXDocument.cpp cdr/src/lib/CMXDocument.cpp
+--- cdr.old/src/lib/CMXDocument.cpp
cdr/src/lib/CMXDocument.cpp
+@@ -46,20 +46,24 @@
+ */
+ bool libcdr::CMXDocument::isSupported(WPXInputStream *input)
+ {
+- input-seek(0, WPX_SEEK_SET);
+- unsigned riff = readU32(input);
+- if (riff != FOURCC_RIFF riff != FOURCC_RIFX)
+-return false;
+- input-seek(4, WPX_SEEK_CUR);
+- char signature_c = (char)readU8(input);
+- if (signature_c != 'C' signature_c != 'c')
+-return false;
+- char signature_d = (char)readU8(input);
+- if (signature_d != 'M' signature_d != 'm')
+-return false;
+- char signature_r = (char)readU8(input);
+- if (signature_r != 'X' signature_r != 'x')
++ try {
++input-seek(0, WPX_SEEK_SET);
++unsigned riff = readU32(input);
++if (riff != FOURCC_RIFF riff != FOURCC_RIFX)
++ return false;
++input-seek(4, WPX_SEEK_CUR);
++char signature_c = (char)readU8(input);
++if (signature_c != 'C' signature_c != 'c')
++ return false;
++char signature_d = (char)readU8(input);
++if (signature_d != 'M' signature_d != 'm')
++ return false;
++char signature_r = (char)readU8(input);
++if (signature_r != 'X' signature_r != 'x')
++ return false;
++ } catch (...) {
+ return false;
++ }
+ return true;
+ }
+
commit 36371917258bd66c29e1ac15f68df3aea0288151
Author: Michael Stahl mst...@redhat.com
Date: Fri Jan 4 22:27:22 2013 +0100
rhbz#890080: crash in SwXTextDocument::getRendererCount
No idea how to reproduce it; pSwView is checked before use except here.
(possibly regression from 2f9f480b22f2fff59d9c48b4b46706c3d5223e66)
Change-Id: Ia7667e879a6944e084a45c06133efc1ac2d8b3c0
(cherry picked from commit 1c52268a5bc6d79c6ee1344e4e341c7e3820d4e0)
diff --git a/sw/source/ui/uno/unotxdoc.cxx b/sw/source/ui/uno/unotxdoc.cxx
index 2c26127..ceca233 100644
--- a/sw/source/ui/uno/unotxdoc.cxx
+++ b/sw/source/ui/uno/unotxdoc.cxx
@@ -2533,7 +2533,10 @@ sal_Int32 SAL_CALL SwXTextDocument::getRendererCount(
SwViewOption aOpt( *pViewShell-GetViewOptions() );
aOpt.setBrowseMode( false );
pViewShell-ApplyViewOptions( aOpt );
-pSwView-RecheckBrowseMode();
+if (pSwView)
+{
+pSwView-RecheckBrowseMode();
+}
}
// reformating the document for printing will show the changes in
the view
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] Change in core[libreoffice-3-6]: rhbz#890080: crash in SwXTextDocument::getRendererCount
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1546
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/1546/1
rhbz#890080: crash in SwXTextDocument::getRendererCount
No idea how to reproduce it; pSwView is checked before use except here.
(possibly regression from 2f9f480b22f2fff59d9c48b4b46706c3d5223e66)
Change-Id: Ia7667e879a6944e084a45c06133efc1ac2d8b3c0
(cherry picked from commit 1c52268a5bc6d79c6ee1344e4e341c7e3820d4e0)
---
M sw/source/ui/uno/unotxdoc.cxx
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sw/source/ui/uno/unotxdoc.cxx b/sw/source/ui/uno/unotxdoc.cxx
index 69e524d..e6d25e3 100644
--- a/sw/source/ui/uno/unotxdoc.cxx
+++ b/sw/source/ui/uno/unotxdoc.cxx
@@ -2556,7 +2556,10 @@
SwViewOption aOpt( *pViewShell-GetViewOptions() );
aOpt.setBrowseMode( false );
pViewShell-ApplyViewOptions( aOpt );
-pSwView-RecheckBrowseMode();
+if (pSwView)
+{
+pSwView-RecheckBrowseMode();
+}
}
// reformating the document for printing will show the changes in
the view
--
To view, visit https://gerrit.libreoffice.org/1546
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7667e879a6944e084a45c06133efc1ac2d8b3c0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Michael Stahl mst...@redhat.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - sc/qa sc/source
sc/qa/unit/subsequent_filters-test.cxx |2 +-
sc/source/filter/xml/xmlrowi.cxx |7 ---
sc/source/filter/xml/xmlrowi.hxx |2 --
3 files changed, 1 insertion(+), 10 deletions(-)
New commits:
commit 3e102b36977a62931b0de4176bcd92a307408d8b
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Jan 5 00:18:21 2013 +0100
enable the unit test
diff --git a/sc/qa/unit/subsequent_filters-test.cxx
b/sc/qa/unit/subsequent_filters-test.cxx
index 5acbfb8..618e627 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -213,7 +213,7 @@ public:
CPPUNIT_TEST(testCellAnchoredShapesODS);
CPPUNIT_TEST(testPivotTableBasicODS);
-// CPPUNIT_TEST(testRowHeight);
+CPPUNIT_TEST(testRowHeight);
CPPUNIT_TEST(testFormulaDependency);
//disable testPassword on MacOSX due to problems with libsqlite3
commit 9ddd869873603f929d7c342d62a8d52d19de83ec
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Jan 5 00:14:47 2013 +0100
Revert workaround problems with row import, fdo#58539
This reverts commit 119483d9b0af6b4830733161fcf56cea10ed01d7.
diff --git a/sc/source/filter/xml/xmlrowi.cxx b/sc/source/filter/xml/xmlrowi.cxx
index a4434e1..ec4c5a5 100644
--- a/sc/source/filter/xml/xmlrowi.cxx
+++ b/sc/source/filter/xml/xmlrowi.cxx
@@ -98,7 +98,6 @@ ScXMLTableRowContext::ScXMLTableRowContext( ScXMLImport
rImport,
break;*/
}
}
-mnLastRow = GetScImport().GetTables().GetCurrentRow() + nRepeatedRows;
GetScImport().GetTables().AddRow();
GetScImport().GetTables().SetRowStyle(sCellStyleName);
}
@@ -156,12 +155,6 @@ void ScXMLTableRowContext::EndElement()
}
SCTAB nSheet = rXMLImport.GetTables().GetCurrentSheet();
sal_Int32 nCurrentRow(rXMLImport.GetTables().GetCurrentRow());
-if(nCurrentRow != mnLastRow)
-{
-// this document is most likely invalid in some way
-SAL_WARN(sc, we did not generate enough rows in the cell import!!);
-nCurrentRow = mnLastRow;
-}
uno::Referencesheet::XSpreadsheet
xSheet(rXMLImport.GetTables().GetCurrentXSheet());
if(xSheet.is())
{
diff --git a/sc/source/filter/xml/xmlrowi.hxx b/sc/source/filter/xml/xmlrowi.hxx
index 02c5255..a900ff7 100644
--- a/sc/source/filter/xml/xmlrowi.hxx
+++ b/sc/source/filter/xml/xmlrowi.hxx
@@ -29,8 +29,6 @@ class ScXMLTableRowContext : public SvXMLImportContext
rtl::OUString sStyleName;
rtl::OUString sVisibility;
sal_Int32 nRepeatedRows;
-sal_Int32 mnLastRow; // to workaround problems with the cell import, can
be removed when the cell
-// always adds enough rows
bool bHasCell;
const ScXMLImport GetScImport() const { return (const
ScXMLImport)GetImport(); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] Change in core[libreoffice-3-6]: rhbz#891082: CMXDocument::isSupported: catch exceptions
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1547
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/1547/1
rhbz#891082: CMXDocument::isSupported: catch exceptions
(cherry picked from commit 374f7465729c98f2cc8af72f876a8eab01d192a6)
Conflicts:
libcdr/UnpackedTarball_cdr.mk
Change-Id: I715975dfa93d736cb537076feab4afe6b75c162a
---
A libcdr/libcdr-issupported-exception.patch.1
M libcdr/makefile.mk
2 files changed, 44 insertions(+), 0 deletions(-)
diff --git a/libcdr/libcdr-issupported-exception.patch.1
b/libcdr/libcdr-issupported-exception.patch.1
new file mode 100644
index 000..4196c46
--- /dev/null
+++ b/libcdr/libcdr-issupported-exception.patch.1
@@ -0,0 +1,42 @@
+rhbz#891082: CMXDocument::isSupported: catch exceptions
+
+--- misc/libcdr-0.0.9/src/lib/CMXDocument.cpp
misc/build/libcdr-0.0.9/src/lib/CMXDocument.cpp
+@@ -46,20 +46,24 @@
+ */
+ bool libcdr::CMXDocument::isSupported(WPXInputStream *input)
+ {
+- input-seek(0, WPX_SEEK_SET);
+- unsigned riff = readU32(input);
+- if (riff != FOURCC_RIFF riff != FOURCC_RIFX)
+-return false;
+- input-seek(4, WPX_SEEK_CUR);
+- char signature_c = (char)readU8(input);
+- if (signature_c != 'C' signature_c != 'c')
+-return false;
+- char signature_d = (char)readU8(input);
+- if (signature_d != 'M' signature_d != 'm')
+-return false;
+- char signature_r = (char)readU8(input);
+- if (signature_r != 'X' signature_r != 'x')
++ try {
++input-seek(0, WPX_SEEK_SET);
++unsigned riff = readU32(input);
++if (riff != FOURCC_RIFF riff != FOURCC_RIFX)
++ return false;
++input-seek(4, WPX_SEEK_CUR);
++char signature_c = (char)readU8(input);
++if (signature_c != 'C' signature_c != 'c')
++ return false;
++char signature_d = (char)readU8(input);
++if (signature_d != 'M' signature_d != 'm')
++ return false;
++char signature_r = (char)readU8(input);
++if (signature_r != 'X' signature_r != 'x')
++ return false;
++ } catch (...) {
+ return false;
++ }
+ return true;
+ }
+
diff --git a/libcdr/makefile.mk b/libcdr/makefile.mk
index 0a8df79..2ede985 100755
--- a/libcdr/makefile.mk
+++ b/libcdr/makefile.mk
@@ -62,6 +62,8 @@
TARFILE_NAME=libcdr-0.0.9
TARFILE_MD5=3c0037fb07dea2f0bbae8386fa7c6a9a
+PATCH_FILES=libcdr-issupported-exception.patch.1
+
BUILD_ACTION=dmake $(MFLAGS) $(CALLMACROS)
BUILD_DIR=src$/lib
--
To view, visit https://gerrit.libreoffice.org/1547
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I715975dfa93d736cb537076feab4afe6b75c162a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Michael Stahl mst...@redhat.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
RE: [libreoffice-dev] - architecture question about interproces,extension,addIn
Hi, I found an example of add-in and was able to build, deploy and run it. http://wiki.openoffice.org/wiki/SimpleCalcAddIn (myRNG.tar deploys RNG service) However, the 2nd and more complete example http://wiki.openoffice.org/wiki/CompleteAddIn fails at registry time with error (CannotRegisterImplementationException): loading component library failed: libsrvcCalc.so regcomp -register -r *.rdb -c *.so libsrvcCalc.so register component 'libsrvcCalc.so' in registry 'srvcCalc.rdb' failed! error (CannotRegisterImplementationException): loading component library failed: libsrvcCalc.so I found some discussion online where someone had same problem with RNG (the simple Addin) and fixed it. http://www.oooforum.org/forum/viewtopic.phtml?t=79491#312692 Q1. Would someone happen to know if the example is supposed to work ? How do I debug the error CannotRegisterImplementationException ? My LD_LIBRARY_PATH seems correct because I can build RNG from the same shell. It seems when Eric found the problem with RNG, he moved a lot of things from wiki to code/makefile/setupenv files. Q2. Is it possible to make the RNG example as part of the package? I can contribute the code for complete-Add-in if I can get it working. The advantage of having it as part of build is that it doesn't break and requires little maintenance, while wiki can silently become outdated. it would benefit newbies like me to get working code as part of distribution. Is that the preferred way to go ? I would like to hear other opinions on this. Thanks Neeraj -Original Message- From: Michael Stahl [mailto:mst...@redhat.com] Sent: Thursday, January 03, 2013 3:44 PM To: Rai, Neeraj [ICG-MKTS] Cc: 'libreoffice@lists.freedesktop.org' Subject: Re: [libreoffice-dev] - architecture question about interproces,extension,addIn hi Neeraj, On 03/01/13 16:54, Rai, Neeraj wrote: Based on above text, I looked at addIns but it doesn't seem like what I need. I don't want to be restricted to a function call. I need a component running in scalc. _http://wiki.openoffice.org/wiki/Documentation/DevGuide/Spreadsheets/Spreadsheet_Add-Ins_ Can someone please advise what is the fastest code as a C++ UNO component mean and where can I find more docs related to it. C++ UNO components that are instantiated in-process currently do not go through a bridge when interacting with the LO API (although there have been varying opinions about changing that, since it makes maintaining backward compatibility more difficult): for such components, calling a LO API method (or being called from LO itself) is just a C++ virtual function call. the best documented way to get this performance benefit is to implement your client code as an extension. http://wiki.openoffice.org/wiki/Documentation/DevGuide/Extensions/Extensions there may also be a way to get there with less efforts, there are some variables to add additional service rdbs to the soffice process (URE_MORE_SERVICES/URE_MORE_TYPES) but i don't have any experience with them; probably there is some way to implement what you want to do as a service and then start it from inside soffice, if all else fails via a trivial BASIC macro :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Eike Rathke er...@redhat.com changed: What|Removed |Added Depends on||59039 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Pyuno ImportError
Hello everybody, I've just built libreoffice after a couple of weeks and now pyuno fails to import elements from the API, like from com.sun.star.awt.VclWindowPeerAttribute import OK. It worked well before Christmas. Any regression introduced during this time? regards, Xisco ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Error building with clang
Miklos was right - the newer version changes everything. I just
finished building, and the only option I used was to enable the
plugins.
I'll put together a small blog entry about this, in case others want
to try the same. Should I update the wiki too?
Marc-André LAVERDIÈRE
Perseverance must finish its work so that you may be mature and complete,
not lacking anything. -James 1:4
http://asimplediscipleslife.blogspot.com/
mlaverd.theunixplace.com
On Fri, Jan 4, 2013 at 3:37 PM, Lubos Lunak l.lu...@suse.cz wrote:
On Friday 04 of January 2013, Marc-André Laverdière wrote:
Hi,
I am building with clang. I ran make clean and even wiped my ccache cache.
I run into this problem:
/home/marc-andre/lo/core/solver/unxlngx6.pro/inc/external/boost/uuid/seed_r
ng.hpp:143:61: note: override this message by inserting an explicit cast
unsigned int rn[] = { std::rand(), std::rand(), std::rand() };
Read again what the message says. This message is a hint how to fix the
problem, the error message precedes it.
Note that when I build with --with-system-boost, I do not get this
error. The system version is 1.49.0.1
I am guessing that we are using a somewhat older version of boost.
So: a) can anyone duplicate this? b) which version of boost should we
upgrade to?
Use whichever one works for you. I'll have a look at the internal copy.
--
Lubos Lunak
l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/inc sc/source
sc/inc/compiler.hxx |2 +-
sc/source/filter/xml/xmlcelli.cxx | 10 --
2 files changed, 9 insertions(+), 3 deletions(-)
New commits:
commit 3cd31cd46f38e00d4fb31cf055b9bcbb5e94e5db
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Jan 5 04:09:48 2013 +0100
don't set formula cells with possible error val clean, fdo#59039
Change-Id: Ide96d7f052ee4c8f56b33629ae48c6425a8ca19f
diff --git a/sc/inc/compiler.hxx b/sc/inc/compiler.hxx
index fe24511..4aa393d 100644
--- a/sc/inc/compiler.hxx
+++ b/sc/inc/compiler.hxx
@@ -350,7 +350,6 @@ private:
bool IsDBRange( const String );
bool IsColRowName( const String );
bool IsBoolean( const String );
-bool IsErrorConstant( const String );
void AutoCorrectParsedSymbol();
void SetRelNameReference();
@@ -387,6 +386,7 @@ public:
// Check if it is a valid english function name
bool IsEnglishSymbol( const String rName );
+bool IsErrorConstant( const String );
//! _either_ CompileForFAP _or_ AutoCorrection, _not_ both
// #i101512# SetCompileForFAP is in formula::FormulaCompiler
diff --git a/sc/source/filter/xml/xmlcelli.cxx
b/sc/source/filter/xml/xmlcelli.cxx
index 2369dce..b67496c 100644
--- a/sc/source/filter/xml/xmlcelli.cxx
+++ b/sc/source/filter/xml/xmlcelli.cxx
@@ -47,6 +47,7 @@
#include scerrors.hxx
#include editutil.hxx
#include cell.hxx
+#include compiler.hxx
#include xmloff/xmltkmap.hxx
@@ -726,8 +727,13 @@ void
ScXMLTableRowCellContext::SetFormulaCell(ScFormulaCell* pFCell) const
{
if( bFormulaTextResult pOUTextValue )
{
-pFCell-SetHybridString( *pOUTextValue );
-pFCell-ResetDirty();
+static ScCompiler aComp(NULL, ScAddress());
+aComp.SetGrammar(formula::FormulaGrammar::GRAM_ODFF);
+if(!aComp.IsErrorConstant(*pOUTextValue))
+{
+pFCell-SetHybridString( *pOUTextValue );
+pFCell-ResetDirty();
+}
}
else if (!rtl::math::isNan(fValue))
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 3 commits - sc/inc sc/qa sc/source
sc/inc/compiler.hxx|2 +-
sc/qa/unit/subsequent_filters-test.cxx |2 +-
sc/source/filter/xml/xmlcelli.cxx | 10 --
sc/source/filter/xml/xmlrowi.cxx |7 ---
sc/source/filter/xml/xmlrowi.hxx |2 --
5 files changed, 10 insertions(+), 13 deletions(-)
New commits:
commit 235aaeb596c3701373889535f8fd8e29c92d333e
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Jan 5 04:09:48 2013 +0100
don't set formula cells with possible error val clean, fdo#59039
Change-Id: Ide96d7f052ee4c8f56b33629ae48c6425a8ca19f
diff --git a/sc/inc/compiler.hxx b/sc/inc/compiler.hxx
index fe24511..4aa393d 100644
--- a/sc/inc/compiler.hxx
+++ b/sc/inc/compiler.hxx
@@ -350,7 +350,6 @@ private:
bool IsDBRange( const String );
bool IsColRowName( const String );
bool IsBoolean( const String );
-bool IsErrorConstant( const String );
void AutoCorrectParsedSymbol();
void SetRelNameReference();
@@ -387,6 +386,7 @@ public:
// Check if it is a valid english function name
bool IsEnglishSymbol( const String rName );
+bool IsErrorConstant( const String );
//! _either_ CompileForFAP _or_ AutoCorrection, _not_ both
// #i101512# SetCompileForFAP is in formula::FormulaCompiler
diff --git a/sc/source/filter/xml/xmlcelli.cxx
b/sc/source/filter/xml/xmlcelli.cxx
index 5e745e9..b64ab03 100644
--- a/sc/source/filter/xml/xmlcelli.cxx
+++ b/sc/source/filter/xml/xmlcelli.cxx
@@ -47,6 +47,7 @@
#include scerrors.hxx
#include editutil.hxx
#include cell.hxx
+#include compiler.hxx
#include xmloff/xmltkmap.hxx
@@ -726,8 +727,13 @@ void
ScXMLTableRowCellContext::SetFormulaCell(ScFormulaCell* pFCell) const
{
if( bFormulaTextResult pOUTextValue )
{
-pFCell-SetHybridString( *pOUTextValue );
-pFCell-ResetDirty();
+static ScCompiler aComp(NULL, ScAddress());
+aComp.SetGrammar(formula::FormulaGrammar::GRAM_ODFF);
+if(!aComp.IsErrorConstant(*pOUTextValue))
+{
+pFCell-SetHybridString( *pOUTextValue );
+pFCell-ResetDirty();
+}
}
else if (!rtl::math::isNan(fValue))
{
commit 1cdb049115a5a62bcd0febdd590d80049f67ebe6
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Jan 5 00:18:21 2013 +0100
enable the unit test
diff --git a/sc/qa/unit/subsequent_filters-test.cxx
b/sc/qa/unit/subsequent_filters-test.cxx
index 5acbfb8..618e627 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -213,7 +213,7 @@ public:
CPPUNIT_TEST(testCellAnchoredShapesODS);
CPPUNIT_TEST(testPivotTableBasicODS);
-// CPPUNIT_TEST(testRowHeight);
+CPPUNIT_TEST(testRowHeight);
CPPUNIT_TEST(testFormulaDependency);
//disable testPassword on MacOSX due to problems with libsqlite3
commit 734c469a91fad731715870e30886de9bb420c5c6
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Jan 5 00:14:47 2013 +0100
Revert workaround problems with row import, fdo#58539
This reverts commit 119483d9b0af6b4830733161fcf56cea10ed01d7.
diff --git a/sc/source/filter/xml/xmlrowi.cxx b/sc/source/filter/xml/xmlrowi.cxx
index a4434e1..ec4c5a5 100644
--- a/sc/source/filter/xml/xmlrowi.cxx
+++ b/sc/source/filter/xml/xmlrowi.cxx
@@ -98,7 +98,6 @@ ScXMLTableRowContext::ScXMLTableRowContext( ScXMLImport
rImport,
break;*/
}
}
-mnLastRow = GetScImport().GetTables().GetCurrentRow() + nRepeatedRows;
GetScImport().GetTables().AddRow();
GetScImport().GetTables().SetRowStyle(sCellStyleName);
}
@@ -156,12 +155,6 @@ void ScXMLTableRowContext::EndElement()
}
SCTAB nSheet = rXMLImport.GetTables().GetCurrentSheet();
sal_Int32 nCurrentRow(rXMLImport.GetTables().GetCurrentRow());
-if(nCurrentRow != mnLastRow)
-{
-// this document is most likely invalid in some way
-SAL_WARN(sc, we did not generate enough rows in the cell import!!);
-nCurrentRow = mnLastRow;
-}
uno::Referencesheet::XSpreadsheet
xSheet(rXMLImport.GetTables().GetCurrentXSheet());
if(xSheet.is())
{
diff --git a/sc/source/filter/xml/xmlrowi.hxx b/sc/source/filter/xml/xmlrowi.hxx
index 02c5255..a900ff7 100644
--- a/sc/source/filter/xml/xmlrowi.hxx
+++ b/sc/source/filter/xml/xmlrowi.hxx
@@ -29,8 +29,6 @@ class ScXMLTableRowContext : public SvXMLImportContext
rtl::OUString sStyleName;
rtl::OUString sVisibility;
sal_Int32 nRepeatedRows;
-sal_Int32 mnLastRow; // to workaround problems with the cell import, can
be removed when the cell
-// always adds enough rows
bool bHasCell;
const ScXMLImport GetScImport() const { return (const
ScXMLImport)GetImport(); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 59039, which changed state. Bug 59039 Summary: FILEOPEN: type information of formula error results lost in cached results https://bugs.freedesktop.org/show_bug.cgi?id=59039 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/source
sw/source/filter/xml/xmliteme.cxx |2 -
sw/source/filter/xml/xmlithlp.cxx |2 -
sw/source/filter/xml/xmltble.cxx | 30 ++---
sw/source/filter/xml/xmltbli.cxx | 54 +++---
sw/source/filter/xml/xmltbli.hxx | 22 +++
sw/source/filter/xml/xmltexte.cxx |8 ++---
sw/source/filter/xml/xmltexti.cxx | 40 ++--
7 files changed, 79 insertions(+), 79 deletions(-)
New commits:
commit a472d6176c7d2a88fbea0f25de17924753b052b2
Author: Takeshi Abe t...@fixedpoint.jp
Date: Fri Jan 4 21:38:38 2013 +0900
sal_Bool to bool
Change-Id: If855e5fafb8f1291d69d5e50fdaa9ef165071293
diff --git a/sw/source/filter/xml/xmliteme.cxx
b/sw/source/filter/xml/xmliteme.cxx
index 1dbefcb..d17c101 100644
--- a/sw/source/filter/xml/xmliteme.cxx
+++ b/sw/source/filter/xml/xmliteme.cxx
@@ -135,7 +135,7 @@ void SwXMLTableItemMapper_Impl::handleSpecialItem(
{
sal_Int16 eHoriOrient =
((const SwFmtHoriOrient *)pItem)-GetHoriOrient();
-sal_Bool bExport = sal_False;
+bool bExport = false;
sal_uInt16 nMemberId =
static_castsal_uInt16( rEntry.nMemberId
MID_SW_FLAG_MASK );
switch( nMemberId )
diff --git a/sw/source/filter/xml/xmlithlp.cxx
b/sw/source/filter/xml/xmlithlp.cxx
index 2e3ce1a..2f4e4c3 100644
--- a/sw/source/filter/xml/xmlithlp.cxx
+++ b/sw/source/filter/xml/xmlithlp.cxx
@@ -186,7 +186,7 @@ bool sw_frmitems_setXMLBorder( SvxBorderLine* rpLine,
((API_LINE_SOLID == nStyle rpLine-GetDistance()) ||
(API_LINE_DOUBLE == nStyle !rpLine-GetDistance())) ) )
{
- sal_Bool bDouble = (bHasWidth API_LINE_DOUBLE == nStyle ) ||
+ bool bDouble = (bHasWidth API_LINE_DOUBLE == nStyle ) ||
rpLine-GetDistance();
// fdo#38542: for double borders, do not override the width
diff --git a/sw/source/filter/xml/xmltble.cxx b/sw/source/filter/xml/xmltble.cxx
index 0dc0be5..344ef1d 100644
--- a/sw/source/filter/xml/xmltble.cxx
+++ b/sw/source/filter/xml/xmltble.cxx
@@ -195,12 +195,12 @@ public:
SwXMLTableFrmFmtsSort_Impl ( sal_uInt16 /* nInit */, sal_uInt16 /*nGrow*/ )
{}
-sal_Bool AddRow( SwFrmFmt rFrmFmt, const OUString rNamePrefix,
sal_uInt32 nLine );
-sal_Bool AddCell( SwFrmFmt rFrmFmt, const OUString rNamePrefix,
+bool AddRow( SwFrmFmt rFrmFmt, const OUString rNamePrefix, sal_uInt32
nLine );
+bool AddCell( SwFrmFmt rFrmFmt, const OUString rNamePrefix,
sal_uInt32 nCol, sal_uInt32 nRow, sal_Bool bTop );
};
-sal_Bool SwXMLTableFrmFmtsSort_Impl::AddRow( SwFrmFmt rFrmFmt,
+bool SwXMLTableFrmFmtsSort_Impl::AddRow( SwFrmFmt rFrmFmt,
const OUString rNamePrefix,
sal_uInt32 nLine )
{
@@ -221,10 +221,10 @@ sal_Bool SwXMLTableFrmFmtsSort_Impl::AddRow( SwFrmFmt
rFrmFmt,
// empty styles have not to be exported
if( !pFrmSize !pBrush !pRowSplit )
-return sal_False;
+return false;
// order is: -/brush, size/-, size/brush
-sal_Bool bInsert = sal_True;
+bool bInsert = true;
SwXMLFrmFmts_Impl::iterator i;
for( i = aFormatList.begin(); i aFormatList.end(); ++i )
{
@@ -290,7 +290,7 @@ sal_Bool SwXMLTableFrmFmtsSort_Impl::AddRow( SwFrmFmt
rFrmFmt,
// found!
const String rFmtName = pTestFmt-GetName();
rFrmFmt.SetName( rFmtName );
-bInsert = sal_False;
+bInsert = false;
break;
}
@@ -330,7 +330,7 @@ static void lcl_xmltble_appendBoxPrefix( OUStringBuffer
rBuffer,
rBuffer.append( (sal_Int32)(nRow + 1));
}
-sal_Bool SwXMLTableFrmFmtsSort_Impl::AddCell( SwFrmFmt rFrmFmt,
+bool SwXMLTableFrmFmtsSort_Impl::AddCell( SwFrmFmt rFrmFmt,
const OUString rNamePrefix,
sal_uInt32 nCol, sal_uInt32 nRow,
sal_Bool bTop )
{
@@ -361,7 +361,7 @@ sal_Bool SwXMLTableFrmFmtsSort_Impl::AddCell( SwFrmFmt
rFrmFmt,
// empty styles have not to be exported
if( !pVertOrient !pBrush !pBox !pNumFmt !pFrameDir )
-return sal_False;
+return false;
// order is: -/-/-/num,
// -/-/box/-, --/-/box/num,
@@ -369,7 +369,7 @@ sal_Bool SwXMLTableFrmFmtsSort_Impl::AddCell( SwFrmFmt
rFrmFmt,
// vert/-/-/-, vert/-/-/num, vert/-/box/-, ver/-/box/num,
// vert/brush/-/-, vert/brush/-/num, vert/brush/box/-,
// vert/brush/box/num
-sal_Bool bInsert = sal_True;
+bool bInsert = true;
SwXMLFrmFmts_Impl::iterator i;
for( i = aFormatList.begin(); i aFormatList.end(); ++i )
{
@@ -470,7 +470,7 @@ sal_Bool SwXMLTableFrmFmtsSort_Impl::AddCell( SwFrmFmt
rFrmFmt,
// found!
const String rFmtName = pTestFmt-GetName();
Re: [Libreoffice-qa] bug always existed: unspecified or 3.3
Hi! IMHO it should be the earliest beta of the 3.3.0 version... Am 04.01.2013 00:19, schrieb Tommy: hi QA guys, I'm gonna ask you one thing about correct labeling the version field in Bugzilla. If a bug has always been there from first LibO 3.3 release, and maybe is inherited from OOo, which version should I choose: unspecified or 3.3.0 beta 2 ? thanks. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ -- _Florian Reisinger _ LibreOffice herunterladen! http://de.libreoffice.org/download/ ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 55079] EDITING: program crashes
https://bugs.freedesktop.org/show_bug.cgi?id=55079 Stefan Lindel ste...@famlindel.de changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #5 from Stefan Lindel ste...@famlindel.de --- The speed is not satisfactorily. When I want to edit one cell the changes need 40-50 seconds to save -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59014] New: EXTENSIONSWEBSITE: Search with LibO Version criteria does not show all available Extensions
https://bugs.freedesktop.org/show_bug.cgi?id=59014 Priority: medium Bug ID: 59014 CC: webs...@global.libreoffice.org Assignee: libreoffice-bugs@lists.freedesktop.org Summary: EXTENSIONSWEBSITE: Search with LibO Version criteria does not show all available Extensions Severity: normal Classification: Unclassified OS: All Reporter: libreoff...@bielefeldundbuss.de URL: http://extensions.libreoffice.org/extension-center Hardware: Other Status: UNCONFIRMED Version: unspecified Component: WWW Product: LibreOffice Steps how to reproduce: 1. click URL link above 2. Query for 'All cat. - LibO 4.0 - Highest rated - LanguageTool search' Expected: Will be found Actual: Not found Results for all Version criteria: * 4.0: Not found!!! * 3.6: Found * 3.5: Found * 3.4: Not found!!! * 3.3: Not found!!! Now check http://extensions.libreoffice.org/extension-center/languagetool You will see that * Version 2.0 is available for LibO 3.5 ... 4.0 * Version 1.7 is available for LibO 3.3 ... 3.5 So all Not found results are not correct. Also other Extensions are affected. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59014] EXTENSIONSWEBSITE: Search with LibO Version criteria does not show all available Extensions
https://bugs.freedesktop.org/show_bug.cgi?id=59014 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=58992 --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- This one might be related to Bug 58992 - EXTENSIONSWEBSITE: Wrong Compatible with LibO Version info in overview -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58992] EXTENSIONSWEBSITE: Wrong Compatible with LibO Version info in overview
https://bugs.freedesktop.org/show_bug.cgi?id=58992 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=59014 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55079] EDITING: program crashes
https://bugs.freedesktop.org/show_bug.cgi?id=55079 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Julien Nabet serval2...@yahoo.fr --- Stefan: implicitly, you confirm in your previous comment that there's no crash anymore. Please open a new bugtracker about this slowliness, it'll help to manage bugs correctly. Thank you in advance. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59016] New: FILEOPEN: RTF file open in Calc
https://bugs.freedesktop.org/show_bug.cgi?id=59016 Priority: medium Bug ID: 59016 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILEOPEN: RTF file open in Calc Severity: normal Classification: Unclassified OS: Windows (All) Reporter: jumbo4...@yahoo.fr Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 3.6.4.3 release Component: UI Product: LibreOffice Problem description: Steps to reproduce: 1. launch Calc (either with a new file or opening a file) 2. open a RTF file (either with File Open, Ctrl+O or Open button) Current behavior: RTF file is opened in Calc. Text appears in the first column. Expected behavior: RTF file should be opened in Writer, as with LibO 3.5 and previous versions. Confirmed with LibO 4.0.0b2 on Win7 and Vista. Operating System: Windows 7 Version: 3.6.4.3 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59016] FILEOPEN: RTF file open in Calc
https://bugs.freedesktop.org/show_bug.cgi?id=59016 Laurent BP jumbo4...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Laurent BP jumbo4...@yahoo.fr --- Confirmed on qa@fr mailing list. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59017] New: Writer does not follow HTML META redirects
https://bugs.freedesktop.org/show_bug.cgi?id=59017 Priority: medium Bug ID: 59017 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Writer does not follow HTML META redirects Severity: normal Classification: Unclassified OS: Windows (All) Reporter: jz-2...@heute-morgen.de Hardware: Other Status: UNCONFIRMED Version: 3.6.1.2 release Component: Writer Product: LibreOffice Created attachment 72502 -- https://bugs.freedesktop.org/attachment.cgi?id=72502action=edit HTML Meta redirect test Hi. It seems that LibreOffice Writer has stopped following META redirects. At least Version 3.6.1.2 does not do it, while lower versions on Debian Linux (higest is 3.5.4.2) do follow redirects. Unfortunately this is an important feature because it is needed for the _only_ way, to create a webdav editable link. See http://www.heute-morgen.de/site/03_Web_Tech/60_CMS_with_WebDAV_and_Openoffice.shtml for details. If this has been removed on purpose this is a request for a configuration option to restore the old behaviour, maybe on a per site basis. The behaviour can be reproduced by opening the attached file with LibreOffice Writer. Sincerely, Joachim -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53378] table sort in libreoffice 3.4
https://bugs.freedesktop.org/show_bug.cgi?id=53378 Joren De Cuyper joren.libreoff...@telenet.be changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||joren.libreoffice@telenet.b ||e Version|unspecified |3.4.0 release Ever confirmed|0 |1 --- Comment #2 from Joren De Cuyper joren.libreoff...@telenet.be --- Is this bug still reproducible using more recent versions of LibreOffice? LO 4.0 is quite outdated right now. You can find a newer version of LibreOffice right here: https://www.libreoffice.org/download/ I hope this will solve your problem. Until response of reporter - bug status to NEEDINFO kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55667] FORMATTING: Inserting a comment switching line
https://bugs.freedesktop.org/show_bug.cgi?id=55667 Joren De Cuyper joren.libreoff...@telenet.be changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||joren.libreoffice@telenet.b ||e Ever confirmed|0 |1 --- Comment #1 from Joren De Cuyper joren.libreoff...@telenet.be --- (In reply to comment #0) Created attachment 68121 [details] A Calender?! Just see the excample and insert a comment. Then you will see. I guess! :-) Can you please provide us steps-by-step how we can reproduce your bug? I made a couple of comments in your spreadsheet ... but can't find anything buggy right now. Thanks in advance -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55667] FORMATTING: Inserting a comment switching line
https://bugs.freedesktop.org/show_bug.cgi?id=55667 Joren De Cuyper joren.libreoff...@telenet.be changed: What|Removed |Added Attachment #68121|text/plain |application/vnd.oasis.opend mime type||ocument.spreadsheet --- Comment #2 from Joren De Cuyper joren.libreoff...@telenet.be --- Comment on attachment 68121 -- https://bugs.freedesktop.org/attachment.cgi?id=68121 A Calender?! Change MIME type -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58940] CONFIGURATION: Can not change paths used by LibreOffice
https://bugs.freedesktop.org/show_bug.cgi?id=58940 Rafael DeGennaro rdegenn...@earthlink.net changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #22 from Rafael DeGennaro rdegenn...@earthlink.net --- I am a relative newbie, but in the spirit of generating possible ideas or questions, I offer the following two facts FWIW, neither of which relate to LibreOffice: 1) I changed the hostname immediately after installing Linux Mint 14. I changed it in both places and followed instructions exactly. It seems correct now. Another guy experiencing this bug did not change his hostname. 2) Print to file: Results always go to /home/username see post here: http://forums.linuxmint.com/viewtopic.php?f=47t=120962 that has received no response. When I print to file on this same system, it won't let me select a folder through the other dropdown. This always worked well in Linux Mint 12 and 13. The normal procedure that I've followed for years is: Go print to file. Then save in folder: other and browse to a folder. Then create a file name, and print. Now it lets me do that, but then always puts the file in the /home/username directory, ignoring what I specified. I've spent hours Googling forums, but only find people trying to change the default folder for print to PDF, which is different. (Although I'm a newbie, I've installed Linux Mint about 5-6 times now successfully, and am methodical and not going a lot of other things during the install.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58963] SLIDESHOW not full screen
https://bugs.freedesktop.org/show_bug.cgi?id=58963 Joren De Cuyper joren.libreoff...@telenet.be changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #8 from Joren De Cuyper joren.libreoff...@telenet.be --- In current master it is indeed fixed: 4.1.0.0.alpha0+ (Build ID: 6a393297ce6d99bbc4edefbf01ab9c5c6f0eff8) TinderBox: MacOSX-Intel@1-built_no-moz_on_10.6.8, Branch:master, Time: 2013-01-04_01:05:31 Thanks! - VERIFIED FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 --- Comment #12 from ape os...@yandex.ru --- LOdev_4.1 crashes when closing a new empty (ODG or ODP) document: WindowsXP 64-bit; LOdev_4.1.0.0.alpha0+ (ID: 6a393297ce6d99bbc4edefbf01ab9c5c6f0eff8; TinderBox: Win-x86@6, Branch:master, Time: 2013-01-04_01:06:01). 1. Run Draw or Impress 2. Close the new empty document (i.e., close the Draw or Impress) 3. LOdev_4.1.0.0.alpha0+ suffers crash. But LOdev_4.0.0.0.beta2+ - OK. These are regressions compared to LOdev_4.0.0.0.beta2 (ID assembly: b060b43f093dce23222fd99375b1c6bd433703d; Tinderbox l.lu...@suse.cz: Win-x86 @ 6, time 2013-01-03 13:16:15) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 ape os...@yandex.ru changed: What|Removed |Added Severity|critical|blocker CC||os...@yandex.ru Version|4.0.0.0.beta1 |4.1.0.0.alpha0+ Master -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56725] ActionTriggerContainer.createInstance (com.sun.star.ui.ActionTrigger) creates an actionTrigger with no PropertySet interfaces
https://bugs.freedesktop.org/show_bug.cgi?id=56725 --- Comment #1 from donja...@freenet.de --- Most of the interfaces are missing on both ActionTrigger and ActionTriggerContainer. This has been fixed in Apache OpenOffice: https://issues.apache.org/ooo/show_bug.cgi?id=67068 -- Services ActionTrigger and ActionTriggerContainer don't implement XTypeProvider -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58815] [CRASH] new document, add slide/page, close without saving crashes Impress, Draw
https://bugs.freedesktop.org/show_bug.cgi?id=58815 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Version|4.1.0.0.alpha0+ Master |4.0.0.0.beta1 --- Comment #13 from Julien Nabet serval2...@yahoo.fr --- ape: I put back former version, for more explanation, see https://wiki.documentfoundation.org/BugReport_Details#Version -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56725] ActionTriggerContainer.createInstance (com.sun.star.ui.ActionTrigger) creates an actionTrigger with no PropertySet interfaces
https://bugs.freedesktop.org/show_bug.cgi?id=56725 donja...@freenet.de changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58102] LibreOffice Won't Print
https://bugs.freedesktop.org/show_bug.cgi?id=58102 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #2 from Julien Nabet serval2...@yahoo.fr --- jnbathens: as mariosv, could you try with a brand new LO directory profile (see https://wiki.documentfoundation.org/UserProfile)? If you still reproduce the problem: - did you try with a brand new file? - Do you have the same for PDF Export? - Do you have the same for printing on PDFCreator for example? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58983] Cannot open Powerpoint 97-2003 file
https://bugs.freedesktop.org/show_bug.cgi?id=58983 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from tommy27 ba...@quipo.it --- Hi Werner, I received you .ppt file by private mail. I promise I won't diffuse it over the net. The bug you describe in LibO 3.5.7 is NOT REPRODUCIBILE in LibO 3.6.4 and LibO 4.0 beta2+ using Windows Vista 64bit. I can open that file with both versions. I suggest to upgrade to LibO 3.6.4 since the 3.5.x branch is dead (there will not be any 3.5.8 release). In the meantime you may test your file with a portable version of LibO 3.6.4 (no installatione required) that you can download from here: http://www.winpenpack.com/en/download.php?view.1338 I'm gonna mark this bug report ad RESOLVED WORKSFORME. feel free to reopen it if you still experience that issue with LibO 3.6.4 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58539] documents that crash Libreoffice Calc master from 18.12.2012
https://bugs.freedesktop.org/show_bug.cgi?id=58539 --- Comment #54 from Markus Mohrhard markus.mohrh...@googlemail.com --- Actually that's what I'd come up with, which should indeed fix the crash itself. But the concern here is that why the matrix become empty? The matrix there should at least contain one element, so neither the column nor row dimension should become zero there (it should be a 1 by 1 matrix, not empty matrix). That's what I meant to say in Comment 28. Ah ok. But in the end we either need this patch or we can remove the if clause and ignore it. Right now every time we reach this PushIllegalArgument() call we crash later. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51199] custom hotkeys for submenu items do not work
https://bugs.freedesktop.org/show_bug.cgi?id=51199 tommy27 ba...@quipo.it changed: What|Removed |Added Version|unspecified |3.3.0 Beta2 --- Comment #5 from tommy27 ba...@quipo.it --- (In reply to comment #3) Tools Customize Keyboard Application Recent Documents Shortcut key has never worked (LibreOffice/OpenOffice.org). Adjusted: Version: unspecified. reverting version to 3.3.0 beta2 I asked to the QA guys and they told me that if a bug as always been present (even those inherited from prior OOo versions) the correct label is 3.3.0 beta2. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
