Change in core[libreoffice-4-0-0]: Resolving crash in wizards fdo#59931 by NULL checking

2013-01-28 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1913 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1913/1 Resolving crash in wizards fdo#59931 by NULL checking Change-Id: Iccc3f3b2913f21a3831ce55c706aa4dd1da53ad6 Revie

Change in core[libreoffice-4-0]: Resolving crash in wizards fdo#59931 by NULL checking

2013-01-28 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1912 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/1912/1 Resolving crash in wizards fdo#59931 by NULL checking Change-Id: Iccc3f3b2913f21a3831ce55c706aa4dd1da53ad6 Revie

[Libreoffice-commits] .: svtools/source

2013-01-28 Thread Libreoffice Gerrit user
svtools/source/control/roadmap.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 78fde59e65bf1fbf8290e60b8cbe4b34e3489b93 Author: Arnaud Versini Date: Mon Jan 28 20:04:03 2013 +0100 Resolving crash in wizards fdo#59931 by NULL checking Change-Id

Change in core[master]: Resolving crash in wizards fdo#59931 by NULL checking

2013-01-28 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1909 Approvals: Stephan Bergmann: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1909 To unsubscribe, v

Re: [libreoffice-dev] - libreoffice 4.0 - waiting on multiple sockets

2013-01-28 Thread Stephan Bergmann
On 01/28/2013 07:39 PM, Rai, Neeraj wrote: Hi Stephan, I misspoke on Q2. It wasn't compilation error but a register error CannotRegisterImplementationException:loading component library failed:. I am not sure how to debug this as same code with osl::socket registers. Do I need to link with cer

[Libreoffice-commits] .: sdext/source

2013-01-28 Thread Libreoffice Gerrit user
sdext/source/presenter/PresenterButton.cxx| 30 sdext/source/presenter/PresenterSlideShowView.cxx | 41 ++ 2 files changed, 20 insertions(+), 51 deletions(-) New commits: commit e252ac072276a6e9459a5573c862e8066b78c29d Author: Ahmad Harthi Date:

Change in core[master]: More fixes to fdo#57422

2013-01-28 Thread Ahmad Harthi (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1521 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1521 To unsubscribe, visit

Re: [ANNOUNCE] : Gerrit Patch Verification Buildbot

2013-01-28 Thread David Ostrovsky
Am 29.01.2013 00:43, schrieb Norbert Thiebaud: On Mon, Jan 28, 2013 at 5:16 PM, Eike Rathke wrote: >Hi Norbert, > >On Saturday, 2013-01-26 01:48:17 -0600, Norbert Thiebaud wrote: > >>The goal being to test build gerrit patch on Linux, Mac and Windows, >>to verify them before they get integrate

UBS Benachrichtigung - Ihre Internet-Banking gesperrt

2013-01-28 Thread UBS AG
Sehr geehrter Kunde, Kürzlich zeigen unsere Aufzeichnungen, dass Ihr UBS-Konto möglich durch einen Dritten unbefugten Zutritt. Die Sicherheit Ihres Kontos ist unser wichtigstes Anliegen, deshalb haben wir beschlossen, den Zugang zu Ihrem Konto vorübergehend zu begrenzen. Für den vollen Zugan

[Libreoffice-commits] .: svx/source

2013-01-28 Thread Libreoffice Gerrit user
svx/source/table/viewcontactoftableobj.cxx |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) New commits: commit 8c200d85cdbece5c65b35211644f1e98491f307a Author: karth Date: Thu Jan 24 05:49:50 2013 +0530 Resolves the bug fdo#59117 missing borders of last column

Change in core[master]: Resolves the bug fdo#59117 missing borders of last column

2013-01-28 Thread Ahmad Harthi (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1834 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1834 To unsubscribe, visit

[Bug 37361] LibreOffice 3.5 most annoying bugs

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on|44275 | -- You are receiving this mail beca

Re: master fails in make dev-install

2013-01-28 Thread Jean-Baptiste Faure
Hi Kohei, Le 29/01/2013 02:10, Kohei Yoshida a écrit : > On 01/28/2013 07:47 PM, Kohei Yoshida wrote: >> >> Normally I don't have a single problem, but today I decided to build it >> with >> >> --with-lang="ja de fr" > > It turns out that I need to give en-US to the list, Indeed. > or else

Re: how to add a new font in installer package

2013-01-28 Thread huqitu du
yes, Iam sure, I don't know build a patch file, so I cut's some source and describe it. 1. in scp2\source\ooo\file_font_ooo.scp add this source. //mongolian fonts #ifndef WITHOUT_FONTS STD_FONT_FILE( gid_File_Fnt_MenkQagan, MQG8F01.ttf, Menk Qagan Tig) #endif 2. in scp2\source\ooo\module_hidden_

[Libreoffice-commits] .: sw/source

2013-01-28 Thread Libreoffice Gerrit user
sw/source/core/layout/calcmove.cxx |4 sw/source/core/layout/tabfrm.cxx |4 sw/source/filter/html/htmlatr.cxx |4 sw/source/ui/inc/conrect.hxx |6 - sw/source/ui/inc/content.hxx | 16 +- sw/source/ui/inc/conttree.hxx | 56 - sw/source/ui/misc/glos

Re: master fails in make dev-install

2013-01-28 Thread Kohei Yoshida
On 01/28/2013 07:47 PM, Kohei Yoshida wrote: Normally I don't have a single problem, but today I decided to build it with --with-lang="ja de fr" It turns out that I need to give en-US to the list, or else the build fails at the very last minute. Quite a surprise... BTW, what is this

master fails in make dev-install

2013-01-28 Thread Kohei Yoshida
I need help. I was trying to build master today on Linux, and I just can't get make dev-install to work. Normally I don't have a single problem, but today I decided to build it with --with-lang="ja de fr" to have a multi-language build. Whether this has something to do with my dev-in

Re: [REVIEW 4-0-0 2/3] ... sdremote foo ...

2013-01-28 Thread Michael Meeks
On Mon, 2013-01-28 at 18:05 +0100, Stephan Bergmann wrote: > As I said at , > comment 6 to "sdremote - deadlock ...," it would probably make more > sense "to dispatch events into the VCL event loop from > sd::Communicator::execute, instead

[Libreoffice-commits] .: slideshow/source

2013-01-28 Thread Libreoffice Gerrit user
slideshow/source/engine/slideshowimpl.cxx |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) New commits: commit ab8e37573628f2e5863e7fc0252103ab32203fc2 Author: Michael Meeks Date: Tue Jan 29 11:24:36 2013 +1100 fdo#59881 - sdremote: revert un-necessary locking change.

Change in core[libreoffice-4-0]: fdo#42387 Fixed Merging of cells in RTL Tables in impress

2013-01-28 Thread Lior Kaplan (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1911 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/1911/1 fdo#42387 Fixed Merging of cells in RTL Tables in impress The problem was in calculating the cell area, the widt

Re: [ANNOUNCE] : Gerrit Patch Verification Buildbot

2013-01-28 Thread Norbert Thiebaud
On Mon, Jan 28, 2013 at 5:16 PM, Eike Rathke wrote: > Hi Norbert, > > On Saturday, 2013-01-26 01:48:17 -0600, Norbert Thiebaud wrote: > >> The goal being to test build gerrit patch on Linux, Mac and Windows, >> to verify them before they get integrated. > > First of all: Great stuff! Thanks! > >>

[Libreoffice-commits] .: sc/source

2013-01-28 Thread Libreoffice Gerrit user
sc/source/filter/excel/xeroot.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 53e28cba18bfc1210f119c899e7559e70de360ac Author: Eike Rathke Date: Tue Jan 29 00:20:54 2013 +0100 osl ensure on the correct member ... Change-Id: Ic41f95431203409b841273

[Libreoffice-commits] .: svx/source

2013-01-28 Thread Libreoffice Gerrit user
svx/source/dialog/srchdlg.cxx | 129 -- 1 file changed, 62 insertions(+), 67 deletions(-) New commits: commit cea879072c2193cb5b3ede318fa3573df4926ae5 Author: Caolán McNamara Date: Mon Jan 28 23:19:16 2013 + use SvtModuleOptions::ClassifyFacto

[Libreoffice-commits] .: svx/inc svx/source

2013-01-28 Thread Libreoffice Gerrit user
svx/inc/svx/dialogs.hrc |4 +- svx/inc/svx/srchdlg.hxx |2 + svx/source/dialog/srchdlg.cxx | 63 +++--- svx/source/dialog/srchdlg.src |8 + 4 files changed, 71 insertions(+), 6 deletions(-) New commits: commit 0b7aef113cefd7a7fecc8

Change in core[master]: fdo#59397 Use more precise wording at 'Find & Replace - Mor...

2013-01-28 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1905 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1905 To unsubscribe, vi

Re: [ANNOUNCE] : Gerrit Patch Verification Buildbot

2013-01-28 Thread Eike Rathke
Hi Norbert, On Saturday, 2013-01-26 01:48:17 -0600, Norbert Thiebaud wrote: > The goal being to test build gerrit patch on Linux, Mac and Windows, > to verify them before they get integrated. First of all: Great stuff! Thanks! > Fourth we will ask people to leave the Verify field of the patches

[Libreoffice-commits] .: mysqlc/Extension_mysql-connector-ooo.mk mysqlc/source RepositoryExternal.mk Repository.mk

2013-01-28 Thread Libreoffice Gerrit user
Repository.mk |2 +- RepositoryExternal.mk |8 mysqlc/Extension_mysql-connector-ooo.mk |6 ++ mysqlc/source/META-INF/manifest.xml |2 +- mysqlc/source/description.xml |4 ++-- 5 files changed, 10 insertions(

Change in core[master]: convert mysqlc to gbuild and add to tail_build

2013-01-28 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1901 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1901 To unsubscribe, visi

Change in core[master]: convert mysqlcppconn to gbuild and add to tail_build

2013-01-28 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1900 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1900 To unsubscribe, visi

[Libreoffice-commits] .: 2 commits - vcl/coretext vcl/inc

2013-01-28 Thread Libreoffice Gerrit user
vcl/coretext/salcoretextfontutils.cxx |3 vcl/coretext/salcoretextlayout.cxx | 633 + vcl/coretext/salcoretextstyle.cxx | 18 vcl/coretext/salgdi.cxx| 33 - vcl/inc/coretext/salcoretextlayout.hxx | 80 5 files changed, 438

[Libreoffice-commits] .: sd/AllLangResTarget_sd.mk sd/source

2013-01-28 Thread Libreoffice Gerrit user
sd/AllLangResTarget_sd.mk |1 - sd/source/ui/app/app.src | 25 - 2 files changed, 26 deletions(-) New commits: commit db86d20fce6ceb78c21840fc7e1889e08eeb2e21 Author: Robert Roth Date: Mon Jan 28 23:43:51 2013 +0200 Removed empty app.src from draw C

Change in core[master]: Removed empty app.src from draw

2013-01-28 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1910 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1910 To unsubscribe, vi

Change in core[master]: Removed empty app.src from draw

2013-01-28 Thread Robert Roth (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1910 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/1910/1 Removed empty app.src from draw Change-Id: I4e9bd57db4510b48b84847dda23feed5b8817df3 --- M sd/AllLangResTarget_s

[Libreoffice-commits] .: Branch 'feature/bplustree' - sw/inc sw/source

2013-01-28 Thread Libreoffice Gerrit user
sw/inc/bplustree.hxx| 19 +++-- sw/source/core/bastyp/bplustree.cxx | 122 2 files changed, 134 insertions(+), 7 deletions(-) New commits: commit e556d42b538019f0314b0b74ad843a0c3ae149b8 Author: Jan Holesovsky Date: Mon Jan 28 22:16:38 20

Re: GDB - Can I See Every Symbol Called?

2013-01-28 Thread Tom Tromey
> "Joel" == Joel Madero writes: Joel> I've finally gotten comfortable with gdb as far as break points and Joel> what not. What I want to know is if there is a way for me to see all Joel> symbols called during a given run of soffice. Getting a log that shows Joel> every symbol called would all

Change in core[master]: Resolving crash in wizards fdo#59931 by NULL checking

2013-01-28 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1909 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/1909/1 Resolving crash in wizards fdo#59931 by NULL checking Change-Id: Iccc3f3b2913f21a3831ce55c706aa4dd1da53ad6 --- M

[Libreoffice-commits] .: vcl/aqua

2013-01-28 Thread Libreoffice Gerrit user
vcl/aqua/source/gdi/atsui/salatslayout.cxx | 62 - 1 file changed, 53 insertions(+), 9 deletions(-) New commits: commit 6f0de1a4ebcc2b9b88b66f2e0f1608ccd7b680eb Author: Tor Lillqvist Date: Mon Jan 28 22:56:10 2013 +0200 Sprinkle some SAL_INFO debugging output

Re: GDB - Can I See Every Symbol Called?

2013-01-28 Thread Tom Tromey
> "Michael" == Michael Meeks writes: Michael>IIWY I'd insert a break-point thus: Michael>break unotxdoc.cxx:12345 Michael>where 12345 is the line-number of the lcl_ function that Michael> is most likely inlined (as static 's tend to be) which usually Michael> confuse

Change in core[libreoffice-4-0]: fdo#44582 fixing horizontal scroll bar in sub windows

2013-01-28 Thread Lior Kaplan (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1908 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/1908/1 fdo#44582 fixing horizontal scroll bar in sub windows Change-Id: Ifea57dec77c5b23771684a1e46267f8431478075 Revie

Re: Remove "Save" Function from Writer Print Dialog

2013-01-28 Thread Cor Nouws
Hi, Joel Madero wrote (28-01-13 20:37) My opinion is we remove the save function from Writer completely so that we are consistent and then I can make a new enhancement request to correctly implement saving preferences. I didn't want to make the changes until I get some feedback. We had a littl

Change in core[libreoffice-4-0]: fdo#54629 MultiSalLayout::GetBoundRect always uses level 0 f...

2013-01-28 Thread Lior Kaplan (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1907 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/1907/1 fdo#54629 MultiSalLayout::GetBoundRect always uses level 0 fallback font ...in X11SalGraphics::GetGlyphBoundRect

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sd/source

2013-01-28 Thread Libreoffice Gerrit user
sd/source/ui/remotecontrol/ImagePreparer.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 88cb36db72775c116c4721163763beb1b2ec0ea3 Author: Luboš Luňák Date: Mon Jan 28 20:06:18 2013 +0100 remove stray SAL_CALL that breaks windows build Change-Id

[Libreoffice-commits] .: svx/source

2013-01-28 Thread Libreoffice Gerrit user
svx/source/xoutdev/xattr.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 984ac8a7b4af06147a113845899ec918d5934921 Author: Miklos Vajna Date: Mon Jan 28 21:33:12 2013 +0100 WaE: declaration of nWhich shadows a member of ´this´ Change-Id: I0a5

Change in core[libreoffice-4-0-0]: Resolves: fdo#59965 crash dialog title area text is missing

2013-01-28 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1906 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/1906/1 Resolves: fdo#59965 crash dialog title area text is missing Change-Id: I19adc5047d744acee243c94ff4e31531ae8c458a

Re: Are we using SimpleReferenceObject correctly?

2013-01-28 Thread Henrik /KaarPoSoft
On 01/28/2013 02:22 PM, Michael Stahl wrote: On 27/01/13 22:55, Henrik /KaarPoSoft wrote: Dear all, As described in the mailing-list-thread Issues building LibreOffice 4.0.0.1 http://lists.freedesktop.org/archives/libreoffice/2013-January/044838.html I am trying to build and package LibreOffice

Change in core[master]: fdo#59397 Use more precise wording at 'Find & Replace - Mor...

2013-01-28 Thread Vishv Brahmbhatt (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1905 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/1905/1 fdo#59397 Use more precise wording at 'Find & Replace - More Options - Styles' Change-Id: I5013e8b2ce99478f244575

Remove "Save" Function from Writer Print Dialog

2013-01-28 Thread Joel Madero
Hi All, I wanted to get feedback about this one. Joren and I have been exploring this bug: https://bugs.freedesktop.org/show_bug.cgi?id=47572 Print options are saved in Writer despite Cancel being pushed (saved also when Ok is pushed). Diving deeper we found that options are not saved at all in

Re: [REVIEW 4-0, 4-0-0] ... sdremote foo ...

2013-01-28 Thread Lubos Lunak
On Monday 28 of January 2013, Thorsten Behrens wrote: > Michael Meeks wrote: > > I'd love to see it in -4-0 and -4-0-0 if possible; ideally tested on > > Windows too ... > > Pushed to -4-0, two more reviews missing for -4-0-0 - would love > someone on windows to give it a spin. It doesn't eve

[Libreoffice-commits] .: sd/source

2013-01-28 Thread Libreoffice Gerrit user
sd/source/ui/remotecontrol/ImagePreparer.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 668bec99efb4a15ca0fe364fa3c217baba8a6f27 Author: Luboš Luňák Date: Mon Jan 28 20:06:18 2013 +0100 remove stray SAL_CALL that breaks windows build Change-Id

RE: [libreoffice-dev] - libreoffice 4.0 - waiting on multiple sockets

2013-01-28 Thread Rai, Neeraj
Hi Stephan, I misspoke on Q2. It wasn't compilation error but a register error CannotRegisterImplementationException:loading component library failed:. I am not sure how to debug this as same code with osl::socket registers. Do I need to link with certain libs? regcomp -register -r Calc

[Libreoffice-commits] .: svl/inc svl/source

2013-01-28 Thread Libreoffice Gerrit user
svl/inc/svl/poolitem.hxx | 38 +++--- svl/source/items/itemset.cxx |2 +- svl/source/items/poolitem.cxx | 19 ++- 3 files changed, 30 insertions(+), 29 deletions(-) New commits: commit 9ad661e5740142a95893e91e4c138caee2abe7c2 Author: M

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 59724, which changed state. Bug 59724 Summary: FILEOPEN: Inherited currency format not retained through close and open https://bugs.freedesktop.org/show_bug.cgi?id=59724 What|Removed |

Change in core[master]: Explicitely check for gtk when enabling telepathy

2013-01-28 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1904 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/1904/1 Explicitely check for gtk when enabling telepathy This is needed in tubes. Change-Id: Ia77968a68da4e781c6e5d4c2

[Libreoffice-commits] .: sfx2/source

2013-01-28 Thread Libreoffice Gerrit user
sfx2/source/doc/templatedlg.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 4651402a5399e00f62311bb3fe545413b0818a2d Author: Cédric Bosdonnat Date: Mon Jan 28 18:50:39 2013 +0100 Template Manager: focus in search edit when clicking search action diff --git a/sfx2/sour

[Libreoffice-commits] .: sfx2/source

2013-01-28 Thread Libreoffice Gerrit user
sfx2/source/doc/templatedlg.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 2064d3df551b651479c0602e197674d4efede15f Author: Cédric Bosdonnat Date: Mon Jan 28 17:51:54 2013 +0100 Template Manager: don't show any tab and show all folders when saving template diff --gi

Change in core[master]: fdo#56098 paste special shift options incorrect/incomplete

2013-01-28 Thread Winfried Donkers (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1903 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/1903/1 fdo#56098 paste special shift options incorrect/incomplete Change-Id: Ic84ec07f4e0963ad1759036f1d7cbfa295289375

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - svx/source

2013-01-28 Thread Libreoffice Gerrit user
svx/source/dialog/docrecovery.cxx |2 +- svx/source/inc/docrecovery.hxx|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit f0b294e013105f93829a510b6540a7f4adce082c Author: Caolán McNamara Date: Mon Jan 28 10:55:10 2013 + Resolves: fdo#59965 crash d

Change in core[libreoffice-3-6]: Resolves: fdo#59965 crash dialog title area text is missing

2013-01-28 Thread Petr Mladek (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1894 Approvals: Petr Mladek: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1894 To unsubscribe, visit

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - svx/source

2013-01-28 Thread Libreoffice Gerrit user
svx/source/dialog/docrecovery.cxx |2 +- svx/source/inc/docrecovery.hxx|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 13d390b9d55f81ca87f86d86249a19e672efcc2f Author: Caolán McNamara Date: Mon Jan 28 10:55:10 2013 + Resolves: fdo#59965 crash d

Change in core[libreoffice-4-0]: Resolves: fdo#59965 crash dialog title area text is missing

2013-01-28 Thread Petr Mladek (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1893 Approvals: Petr Mladek: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1893 To unsubscribe, visit

[Libreoffice-commits] .: 2 commits - sal/inc sal/qa sal/rtl sal/util

2013-01-28 Thread Libreoffice Gerrit user
sal/inc/rtl/string.h | 23 +++ sal/inc/rtl/string.hxx | 198 ++-- sal/inc/rtl/ustring.h | 23 +++ sal/inc/rtl/ustring.hxx| 202 +++-- sal/qa/rtl/strings/test_str

Re: [REVIEW 4-0-0 2/3] ... sdremote foo ...

2013-01-28 Thread Stephan Bergmann
On 01/28/2013 05:32 PM, Thorsten Behrens wrote: Michael Meeks wrote: I'd love to see it in -4-0 and -4-0-0 if possible; ideally tested on Windows too ... Pushed to -4-0, two more reviews missing for -4-0-0 - would love someone on windows to give it a spin. As I said at

[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - sc/source

2013-01-28 Thread Libreoffice Gerrit user
sc/source/filter/excel/xecontent.cxx | 18 ++--- sc/source/filter/excel/xeextlst.cxx |3 + sc/source/filter/excel/xeformula.cxx |9 sc/source/filter/excel/xeroot.cxx| 51 +++ sc/source/filter/excel/xestream.cxx

Change in core[libreoffice-4-0-0]: resolved fdo#59819 write correct OOXML function name mapping

2013-01-28 Thread Petr Mladek (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1884 Approvals: Markus Mohrhard: Looks good to me, but someone else must approve Petr Mladek: Verified; Looks good to me, approved -- To vie

Change in core[libreoffice-4-0]: Template Manager: don't show any tab and show all folders wh...

2013-01-28 Thread Bosdonnat Cedric (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1902 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/1902/1 Template Manager: don't show any tab and show all folders when saving template Change-Id: Ib8f8dd66374a56a5c4915

Re: Impress Feature

2013-01-28 Thread Thorsten Behrens
Janit Anjaria wrote: > Can everyone please let me know if the feature of having something like a > "Post-It" NOtes on Impress Slides or the Doc. pages be useful.?? > You mean Insert->Comment (Ctrl-Alt-C)? If you meant that, can happily provide you with code pointers. Cheers, -- Thorsten signat

Change in core[master]: convert mysqlc to gbuild and add to tail_build

2013-01-28 Thread Peter Foley (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1901 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/1901/1 convert mysqlc to gbuild and add to tail_build Change-Id: Ia64bc884ed04a5d5652fb743f543a39e6b6bbcf2 --- M Module

Change in core[master]: convert mysqlcppconn to gbuild and add to tail_build

2013-01-28 Thread Peter Foley (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1900 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/1900/1 convert mysqlcppconn to gbuild and add to tail_build Change-Id: I33a9ff3393b90c5b9f7d7fa85e8761c02160664f --- M

Re: [libreoffice-dev] - libreoffice 4.0 - waiting on multiple sockets

2013-01-28 Thread Stephan Bergmann
On 01/28/2013 04:04 PM, Rai, Neeraj wrote: I had tried interprocess communication before and found it to be slow (12 sec vs 14ms). Somewhere in the docs, there was a mention that it has latency of 2ms. However, if you can point me to samples or provide other advise that make it as fast as osl::

[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - formula/inc sc/inc sc/source

2013-01-28 Thread Libreoffice Gerrit user
formula/inc/formula/token.hxx |3 ++ sc/inc/cell.hxx |8 + sc/inc/formularesult.hxx |4 ++ sc/inc/token.hxx | 45 +++ sc/source/core/data/cell.cxx | 12 sc/source/core/

Change in core[libreoffice-4-0-0]: import inherited number formats with cached values, fdo#5972...

2013-01-28 Thread Petr Mladek (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1870 Approvals: Petr Mladek: Verified; Looks good to me, approved Eike Rathke: Verified; Looks good to me, but someone else must approve --

Change in core[master]: fdo#38838 Some removal/replacement of the String/UniString w...

2013-01-28 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1824 -- To view, visit https://gerrit.libreoffice.org/1824 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

Re: [REVIEW 4-0, 4-0-0] ... sdremote foo ...

2013-01-28 Thread Thorsten Behrens
Michael Meeks wrote: > I'd love to see it in -4-0 and -4-0-0 if possible; ideally tested on > Windows too ... > Pushed to -4-0, two more reviews missing for -4-0-0 - would love someone on windows to give it a spin. Cheers, -- Thorsten signature.asc Description: Digital signature

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sd/source slideshow/source

2013-01-28 Thread Libreoffice Gerrit user
sd/source/ui/remotecontrol/Communicator.cxx |2 - sd/source/ui/remotecontrol/ImagePreparer.cxx | 33 ++- sd/source/ui/remotecontrol/ImagePreparer.hxx | 10 +++- sd/source/ui/remotecontrol/Listener.cxx |9 --- sd/source/ui/remotecontrol/Receiver.cxx

[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - sc/inc sc/source

2013-01-28 Thread Libreoffice Gerrit user
sc/inc/drwlayer.hxx |1 + sc/source/core/data/drwlayer.cxx |7 +++ sc/source/ui/view/viewfun7.cxx |8 ++-- 3 files changed, 14 insertions(+), 2 deletions(-) New commits: commit aa732455f0a6ab7d03540db50ee520cf5cb86332 Author: Kohei Yoshida Date: Fri Jan 25 12

Change in core[libreoffice-4-0-0]: fdo#59056: Re-calculate cell anchor position of a pasted dra...

2013-01-28 Thread Petr Mladek (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1899 Approvals: Markus Mohrhard: Looks good to me, but someone else must approve Petr Mladek: Verified; Looks good to me, approved -- To vie

fdo#59710 - CLI bridge (.NET) if both OOo 2.4.0 (and above?) and LibreOffice (any version) are installed

2013-01-28 Thread Joel Madero
Hi All, I've already talked to one developer about this and his advice was to close it as WONTFIX. I wanted to verify this before doing so. Also, if we are going to close it as such, can someone give me the reason why so that if this asks why, I have a response. https://bugs.freedesktop.org/

Re: [Libreoffice-qa] Minutes - QA Call 01/25/2013

2013-01-28 Thread Joel Madero
On 01/28/2013 04:57 AM, Petr Mladek wrote: On Sat, 2013-01-26 at 14:27 -0800, Joel Madero wrote: +Assigning Bugs -AGREED: At this time QA team “pushing” bugs to developers isn't working, we will now only do “pull” philosophy (developers choose their own bugs and assign themselves

[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - pyuno/source

2013-01-28 Thread Libreoffice Gerrit user
pyuno/source/loader/pythonloader.py |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 355f644fb1d987947d63f2aa7e6a8f59d8337324 Author: Stephan Bergmann Date: Wed Jan 23 17:58:25 2013 +0100 fdo#59728: Fix encoding of .py files as UTF-8 for Python 3 .

Change in core[libreoffice-4-0-0]: fdo#59728: Fix encoding of .py files as UTF-8 for Python 3

2013-01-28 Thread Petr Mladek (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1836 Approvals: Noel Power: Looks good to me, but someone else must approve Petr Mladek: Verified; Looks good to me, approved Eike Rathke: Lo

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - filter/source

2013-01-28 Thread Libreoffice Gerrit user
filter/source/msfilter/svdfppt.cxx | 15 +++ 1 file changed, 15 insertions(+) New commits: commit 0a61d2f56aabceb0f506baf066e37744a993e380 Author: Muthu Subramanian Date: Thu Nov 22 20:18:34 2012 +0530 n#782833: (PPT) Fix font size at end of para. Font size at the e

Re: Same function implemented 6 times in calc tests

2013-01-28 Thread Markus Mohrhard
Hey, 2013/1/28 Marcos Souza : > Hi guys! > > While I was looking at some STRINGPARAM macros in calc, I saw the function > createFileURL is implemented several times: > > http://opengrok.libreoffice.org/search?q=void+createFileURL&project=core&defs=&refs=&path=sc&hist= > > And they are all equal. I

Same function implemented 6 times in calc tests

2013-01-28 Thread Marcos Souza
Hi guys! While I was looking at some STRINGPARAM macros in calc, I saw the function createFileURL is implemented several times: http://opengrok.libreoffice.org/search?q=void+createFileURL&project=core&defs=&refs=&path=sc&hist= And they are all equal. In UnoApiTest exists a createFileURL too, and

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sw/source

2013-01-28 Thread Libreoffice Gerrit user
sw/source/core/doc/poolfmt.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 66cb07cf28186840b8e32d1260b522b5bc7937ea Author: Cédric Bosdonnat Date: Fri Jan 25 15:08:30 2013 +0100 fdo#59779: Set the first page attributes on pooled styles creation Change-Id: If599b

Change in core[libreoffice-4-0-0]: fdo#59779: Set the first page attributes on pooled styles cr...

2013-01-28 Thread Petr Mladek (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1864 Approvals: Miklos Vajna: Looks good to me, but someone else must approve Petr Mladek: Verified; Looks good to me, approved Michael Stahl

[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - sw/source

2013-01-28 Thread Libreoffice Gerrit user
sw/source/core/doc/poolfmt.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 2f8abaad2830530ad299221d72964894d5ddb402 Author: Cédric Bosdonnat Date: Fri Jan 25 15:08:30 2013 +0100 fdo#59779: Set the first page attributes on pooled styles creation Change-Id: If599b

RE: [libreoffice-dev] - libreoffice 4.0 - waiting on multiple sockets

2013-01-28 Thread Rai, Neeraj
Hi Stephan, I had tried interprocess communication before and found it to be slow (12 sec vs 14ms). Somewhere in the docs, there was a mention that it has latency of 2ms. However, if you can point me to samples or provide other advise that make it as fast as osl::socket, I'd be happy to switch b

Change in core[libreoffice-4-0-0]: fdo#59056: Re-calculate cell anchor position of a pasted dra...

2013-01-28 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1899 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/1899/1 fdo#59056: Re-calculate cell anchor position of a pasted drawing object. Else it would re-use the anchor positio

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sd/source

2013-01-28 Thread Libreoffice Gerrit user
sd/source/ui/view/outlnvs2.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 639f739fbcfb5421c7b7173c700136f169e38bc8 Author: Herbert Dürr Date: Tue Jun 19 10:20:57 2012 + fdo#51232: i#119987# fix Impress crash when pasting text under Outline view Patch by: Wa

Change in core[libreoffice-4-0]: fdo#51232: i#119987# fix Impress crash when pasting text und...

2013-01-28 Thread Petr Mladek (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1897 Approvals: Joren De Cuyper: Looks good to me, but someone else must approve Petr Mladek: Verified; Looks good to me, approved -- To vie

Need comfirmation about no function of Modeless Dialogs in 4.0

2013-01-28 Thread Fernand Vanrie
We uses the Basic codelines below to make Modeless Dialogs, sinds 4.0 we endup with a non-visible window is this Windows only or a more general regression ?, it was working until 3.6.4 windows? Greetz Fernand Sub Main oDoc = ThisComponent oParentFrame = oDoc.CurrentController.Frame oPee

[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - librelogo/source

2013-01-28 Thread Libreoffice Gerrit user
librelogo/source/LibreLogo/LibreLogo.py |2 ++ 1 file changed, 2 insertions(+) New commits: commit 397dabaea81af7d70f6c17b91e1f3bb424640d35 Author: László Németh Date: Mon Jan 28 14:30:59 2013 +0100 fdo#59969 crash fix (insecure clear screen during Logo execution) Change-I

Change in core[libreoffice-4-0-0]: fdo#59969 crash fix (insecure clear screen during Logo execu...

2013-01-28 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1896 Approvals: Andras Timar: Looks good to me, but someone else must approve Miklos Vajna: Looks good to me, but someone else must approve -

Re: LibreOffice Development [ Comments in .pptx ] (Annotations Issue)

2013-01-28 Thread Vinaya Mandke
Hi, PFA the diff file... I know that its incomplete and should have a separate handler, but as of now I can atleast save the comment data... This is what I have done - I have handled comments exactly as notes - In slidefragmenthandler added tokens to handle the comment attributes - New

Change in help[libreoffice-4-0]: add Turkish to WikiHelp, it is fully translated

2013-01-28 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1895 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1895 To unsubscribe, visit

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - helpcontent2

2013-01-28 Thread Libreoffice Gerrit user
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 52130a179700c2ca9758bcd96c9d8aa6b5e3 Author: Andras Timar Date: Mon Jan 28 14:33:22 2013 +0100 Updated core Project: help fab8b3ed91a4b24d2a06832929ecad3f9ba65630 add Turkish to Wik

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - help-to-wiki.py

2013-01-28 Thread Libreoffice Gerrit user
help-to-wiki.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fab8b3ed91a4b24d2a06832929ecad3f9ba65630 Author: Andras Timar Date: Mon Jan 28 14:33:22 2013 +0100 add Turkish to WikiHelp, it is fully translated Change-Id: If89ffb1950f9e9a8d99140e1f37d

Change in core[libreoffice-4-0]: fdo#51232: i#119987# fix Impress crash when pasting text und...

2013-01-28 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1897 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/1897/1 fdo#51232: i#119987# fix Impress crash when pasting text under Outline view Patch by: Wang Zhe Testing by: Yan J

Change in core[libreoffice-4-0-0]: fdo#59969 crash fix (insecure clear screen during Logo execu...

2013-01-28 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1896 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/1896/1 fdo#59969 crash fix (insecure clear screen during Logo execution) Change-Id: Id0af685c67c02fecd8b10a40d4fb81

Re: how to add a new font in installer package

2013-01-28 Thread Michael Stahl
On 28/01/13 10:23, huqitu du wrote: > yes, I did it , but dosnt work! are you sure? there are 2 places in scp2 where a file has to be added, one is the line you quoted below, and the other is a reference from some other file that uses the gid_File_whatever. please post your complete patch so we c

  1   2   >