[PUSHED] UpdateTableShape() is called when we call SetAttrToSelectedC...

2013-04-28 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3391 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3391 To unsubscribe, visi

[Libreoffice-commits] core.git: svx/source

2013-04-28 Thread Gokul
svx/source/table/tablecontroller.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 40ef445db670fb641532190d17d35818e3bd623d Author: Gokul Date: Mon Apr 15 11:19:21 2013 +0300 UpdateTableShape() is called when we call SetAttrToSelectedCells method IMO Calling this me

[PUSHED] fdo#63546: set appropriate alignment when wrt direction of c...

2013-04-28 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3549 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3549 To unsubscribe, visi

[Libreoffice-commits] core.git: sc/source

2013-04-28 Thread navin patidar
sc/source/ui/view/formatsh.cxx | 55 +++-- 1 file changed, 42 insertions(+), 13 deletions(-) New commits: commit 706e3b8e43df94310b2fe8458da67875073a046c Author: navin patidar Date: Mon Apr 22 10:17:07 2013 +0300 fdo#63546: set appropriate alignment w

[PUSHED] fdo#60949: Remove UNOLIBS_OOO

2013-04-28 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3626 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3626 To unsubscribe, visit

[PUSHED] fdo#39468 Translation and cleanup

2013-04-28 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3643 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3643 To unsubscribe, visit

Using UNO API for java

2013-04-28 Thread adrivero
Using UNO API for java and charge a template that contains a table I try to copy that table on the next page (I need copy also property ) to create a new and I find as // first query the XTextTablesSupplier interface from our document XTextTablesSupplier xTablesSupplier = (XTextTabl

[Libreoffice-commits] core.git: 6 commits - chart2/source include/oox oox/source sc/source

2013-04-28 Thread Markus Mohrhard
chart2/source/tools/ErrorBar.cxx |1 include/oox/export/chartexport.hxx |3 oox/source/export/chartexport.cxx | 177 ++--- sc/source/filter/xml/xmlsubti.cxx |9 - 4 files changed, 174 insertions(+), 16 deletions(-) New commits: commit e81d0c400c0

[PUSHED] script to create git tree with submodule setup from bundles

2013-04-28 Thread Thorsten Behrens (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3653 Approvals: Thorsten Behrens: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3653 To unsubscribe, v

[Libreoffice-commits] dev-tools.git: lo-submodules-from-bundles.sh

2013-04-28 Thread Christian Lohmaier
lo-submodules-from-bundles.sh | 179 ++ 1 file changed, 179 insertions(+) New commits: commit 3328f5e88ade4b6f132c261b977793f863deae2e Author: Christian Lohmaier Date: Sun Apr 28 22:42:45 2013 +0200 script to create git tree with submodule setup fr

[PATCH] script to create git tree with submodule setup from bundles

2013-04-28 Thread Christian Lohmaier (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3653 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/dev-tools refs/changes/53/3653/1 script to create git tree with submodule setup from bundles the existing script doesn't do anything useful

[PUSHED] fdo#63197: convert osxres

2013-04-28 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3652 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3652 To unsubscribe, visit

[Libreoffice-commits] core.git: scp2/source vcl/Module_vcl.mk vcl/Package_osxres.mk vcl/Zip_osxres.mk

2013-04-28 Thread Julien Nabet
scp2/source/ooo/file_ooo.scp |8 +-- vcl/Module_vcl.mk|2 vcl/Package_osxres.mk| 90 +++ vcl/Zip_osxres.mk| 88 -- 4 files changed, 95 insertions(+), 93 deletions(-) New co

[PATCH] fdo#63197: convert osxres

2013-04-28 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3652 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/3652/1 fdo#63197: convert osxres Change-Id: I969217263fdda3e61b38dc16f0a9251b745de885 --- M scp2/source/ooo/file_ooo.sc

[PATCH] Fixing Indentation RTL bug

2013-04-28 Thread Adam Co (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3651 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/3651/1 Fixing Indentation RTL bug Change-Id: Ie8c3d30cb28afb97d4ded4ac67241ed18ab9e50c --- M writerfilter/source/ooxml/

LO Impress: text field (and other main fields of different layout) needs reset function for size and position

2013-04-28 Thread Karl-Philipp Richter
Hi together, it is not clear how to reset size and position of the text field (or any other layout (table, video, etc.) main field) in LO Impress. If it is possible (and I didn't find it quick enough (as you might expect from an intuitive program)) there ought to be a "reset" or "default" butto

[PUSHED] fdo#63197: convert liblangtag_data

2013-04-28 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3650 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3650 To unsubscribe, visit

[Libreoffice-commits] core.git: liblangtag/ExternalPackage_liblangtag_data.mk liblangtag/Module_liblangtag.mk liblangtag/Zip_liblangtag_data.mk scp2/source

2013-04-28 Thread Julien Nabet
liblangtag/ExternalPackage_liblangtag_data.mk | 30 ++ liblangtag/Module_liblangtag.mk |2 - liblangtag/Zip_liblangtag_data.mk | 30 -- scp2/source/ooo/file_extra_ooo.scp|6 ++--- 4 files changed, 34

[PATCH] fdo#63197: convert liblangtag_data

2013-04-28 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3650 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/3650/1 fdo#63197: convert liblangtag_data Change-Id: I0727b800c715962a88e256b30046c9e13d6bd2a9 --- A liblangtag/Externa

[Libreoffice-commits] core.git: 12 commits - instsetoo_native/config instsetoo_native/CustomTarget_setup.mk instsetoo_native/Module_instsetoo_native.mk instsetoo_native/Package_config.mk instsetoo_nat

2013-04-28 Thread David Tardon
instsetoo_native/CustomTarget_setup.mk | 51 instsetoo_native/Module_instsetoo_native.mk |9 instsetoo_native/Package_config.mk | 22 instsetoo_native/Package_rdb.mk | 19 ++ instsetoo_native/Package_setup.m

[PUSHED] fdo#63197: convert fontunxafm

2013-04-28 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3648 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3648 To unsubscribe, visit

[PUSHED] fdo#63197: convert helpxsl

2013-04-28 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3649 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3649 To unsubscribe, visit

[Libreoffice-commits] core.git: afms/ExternalPackage_fontunxafm.mk afms/Module_afms.mk afms/Zip_fontunxafm.mk scp2/source

2013-04-28 Thread Julien Nabet
afms/ExternalPackage_fontunxafm.mk | 48 +++ afms/Module_afms.mk|2 - afms/Zip_fontunxafm.mk | 50 - scp2/source/ooo/file_extra_ooo.scp |6 ++-- 4 files changed, 52 insertions(+), 54 deletio

[Libreoffice-commits] core.git: scp2/source xmlhelp/Module_xmlhelp.mk xmlhelp/Package_helpxsl.mk xmlhelp/Zip_helpxsl.mk

2013-04-28 Thread Julien Nabet
scp2/source/ooo/file_ooo.scp |7 --- xmlhelp/Module_xmlhelp.mk|2 +- xmlhelp/Package_helpxsl.mk | 20 xmlhelp/Zip_helpxsl.mk | 18 -- 4 files changed, 25 insertions(+), 22 deletions(-) New commits: commit 2c04d86f692d4b0841adba508a2

[Bug 60270] LibreOffice 4.1 most annoying bugs

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60270 Bug 60270 depends on bug 63680, which changed state. Bug 63680 Summary: EDITING: CRASH when click on contents or entering a line of text https://bugs.freedesktop.org/show_bug.cgi?id=63680 What|Removed |Added -

[PUSHED] Bin CLOOK comments and un-split one large switch statement

2013-04-28 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3640 Approvals: LibreOffice gerrit bot: Verified David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreof

[Libreoffice-commits] core.git: sfx2/source

2013-04-28 Thread David Tardon
sfx2/source/doc/objmisc.cxx | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) New commits: commit f7cea8fb5b5d92ff6b8ac09b38d02badaaf7db04 Author: David Tardon Date: Sun Apr 28 11:18:35 2013 +0200 use SAL_CONFIGFILE macro Change-Id: I958a961993aaf920c52b5d7b8e

[Libreoffice-commits] core.git: sw/source

2013-04-28 Thread Miklos Vajna
sw/source/core/text/itrcrsr.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 1fd3167695aaebb050df53acd91f2e1625e8305a Author: Miklos Vajna Date: Sun Apr 28 16:12:19 2013 +0200 fdo#63680 SwTxtCursor::GetCrsrOfst: don't pass reference to a temporary

[PUSHED] Keep OUString instance by using local variable to avoid cras...

2013-04-28 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3647 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3647 To unsubscribe, visit

[Libreoffice-commits] core.git: sw/source

2013-04-28 Thread Arnaud Versini
sw/source/core/text/itrcrsr.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit d0d295af530e7dc1379a878ba5854e28eae250ad Author: Arnaud Versini Date: Sun Apr 28 14:38:22 2013 +0200 Keep OUString instance by using local variable to avoid crash. Crash

[Libreoffice-commits] libmspub.git: src/lib

2013-04-28 Thread Franz Schmid
src/lib/MSPUBBlockID.h |1 + src/lib/MSPUBCollector.cpp |6 ++ src/lib/MSPUBParser.cpp|3 +++ src/lib/MSPUBTypes.h |3 ++- 4 files changed, 12 insertions(+), 1 deletion(-) New commits: commit 8b3c9c61a8d1d83e4be8f2bfcd45d6f4c4487550 Author: Franz Schmid Date:

[RESTORED] Keep OUString instance by using local variable to avoid cras...

2013-04-28 Thread Arnaud Versini (via Code Review)
Arnaud Versini has restored this change. Change subject: Keep OUString instance by using local variable to avoid crash. .. Patch Set 1: Restored Tomorary fix untail Miklos finish its patch. -- To view, visit https://gerrit.li

[PATCH] fdo#63197: convert helpxsl

2013-04-28 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3649 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/3649/1 fdo#63197: convert helpxsl Change-Id: Icd436733b47d7883209fe73dc1d0099dc87db089 --- M scp2/source/ooo/file_ooo.s

[ABANDONED] Keep OUString instance by using local variable to avoid cras...

2013-04-28 Thread Arnaud Versini (via Code Review)
Arnaud Versini has abandoned this change. Change subject: Keep OUString instance by using local variable to avoid crash. .. Patch Set 1: Abandoned http://cgit.freedesktop.org/~vmiklos/lo-core/commit/?id=bfb8d155269e915b150f2690

[PATCH] fdo#63197: convert fontunxafm

2013-04-28 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3648 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/3648/1 fdo#63197: convert fontunxafm Change-Id: Ib382319a4916b711c820c06ba57928ca11d0b804 --- R afms/ExternalPackage_fo

[Libreoffice-commits] core.git: 4 commits - solenv/gbuild

2013-04-28 Thread David Tardon
solenv/gbuild/InternalUnoApi.mk |4 solenv/gbuild/TargetLocations.mk |2 -- solenv/gbuild/UnoApi.mk | 21 + solenv/gbuild/UnoApiTarget.mk| 11 +-- 4 files changed, 14 insertions(+), 24 deletions(-) New commits: commit 92b618f5829bc46104c4

[PATCH] Keep OUString instance by using local variable to avoid cras...

2013-04-28 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3647 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3647/1 Keep OUString instance by using local variable to avoid crash. Crash with GCC 4.8 without the modification. Cha

[SOLVED] Re: About coverity 988424 (svdfppt.cxx from filter module)

2013-04-28 Thread Julien Nabet
On 24/04/2013 18:25, Caolán McNamara wrote: On Sat, 2013-03-16 at 14:03 -0700, julien2412 wrote: Hello, Scan coverity detected this: CID 988424 (#1 of 1): Logically dead code (DEADCODE)dead_error_line: Execution cannot reach this expression "nExtBuInd + nExtParaNibble< aStyleTextProp9->size()"

[Libreoffice-commits] core.git: filter/source

2013-04-28 Thread Julien Nabet
filter/source/msfilter/svdfppt.cxx |6 -- 1 file changed, 6 deletions(-) New commits: commit b5ca660e41fd81156ed62aa2c8451ed66a61eed4 Author: Julien Nabet Date: Sun Apr 28 14:13:05 2013 +0200 coverity#988424: Logically dead code Change-Id: I916d72cb1104a4d6109a3c5a3a74fb7

[PUSHED] fdo#39468 Comment translation GER-ENG in sw/source/ui/shells...

2013-04-28 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3646 Approvals: Chris Sherlock: Looks good to me, but someone else must approve David Tardon: Verified; Looks good to me, approved -- To vie

[Libreoffice-commits] core.git: sw/source

2013-04-28 Thread Matthias Freund
sw/source/ui/shells/beziersh.cxx |8 ++--- sw/source/ui/shells/drawsh.cxx | 18 +++ sw/source/ui/shells/drformsh.cxx |7 +--- sw/source/ui/shells/drwbassh.cxx | 37 ++- sw/source/ui/shells/drwtxtex.cxx | 26 +++- sw/source/ui/shells/drwtxtsh.

[PUSHED] fdo#60910: discard UNO shape object in SdrObject::SetPage

2013-04-28 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3642 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3642 To unsubscribe, visit

[Libreoffice-commits] core.git: svx/source

2013-04-28 Thread Luke Deller
svx/source/svdraw/svdoashp.cxx |1 - svx/source/svdraw/svdobj.cxx | 12 2 files changed, 12 insertions(+), 1 deletion(-) New commits: commit 57082b1243e86694b72c5e4fad013bf207bfe81a Author: Luke Deller Date: Sun Apr 28 07:06:11 2013 +1000 fdo#60910: discard UNO shape

[Libreoffice-commits] libvisio.git: src/lib

2013-04-28 Thread Fridrich Štrba
src/lib/gentoken.pl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cbe03a66e9bee3edae23c6462b8292b454892541 Author: Fridrich Å trba Date: Fri Apr 26 11:16:15 2013 +0200 Token ID 0 is special in the way the has handles it diff --git a/src/lib/gentoken.pl b/sr

Re: Need Guidance on bug fdo#37222

2013-04-28 Thread Tomaž Vajngerl
Hi, system("xdg-open abc.pdf"); is not good enough - this won't work on OSX or Windows. You have to use XSystemShellExecute: Reference xSystemShellExecute(SystemShellExecute::create( ::comphelper::getProcessComponentContext() ) ); xSystemShellExecute->execute( aFileName, OUString(), SystemShellEx

[Libreoffice-commits] core.git: desktop/inc desktop/source desktop/unx sw/source

2013-04-28 Thread Thomas Arnhold
desktop/inc/app.hxx | 14 +--- desktop/source/app/appfirststart.cxx |2 desktop/source/app/appinit.cxx |4 - desktop/source/app/check_ext_deps.cxx|3 + desktop/source/deployment/gui/license_dialog.hxx | 18 ++--

[Libreoffice-commits] core.git: sc/source

2013-04-28 Thread Caolán McNamara
sc/source/filter/orcus/interface.cxx | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) New commits: commit ca97ee598a08365f7bef7e7b8172bff4433ee8b0 Author: Caolán McNamara Date: Sat Apr 27 21:05:42 2013 +0100 collision between orcus::spreadsheet

[ABANDONED] make use of pOutWin, which is member of ImpEditView class.

2013-04-28 Thread navin patidar (via Code Review)
navin patidar has abandoned this change. Change subject: make use of pOutWin, which is member of ImpEditView class. .. Patch Set 2: Abandoned dynamic cast produces pOutWin only when pTargetDevice is NULL for ImpEditEngine::Pai

Re: [PATCH] fdo#35320 A fix for Arabic justification problem caused by k...

2013-04-28 Thread Khaled Hosny
On Sun, Apr 28, 2013 at 06:04:04AM +, Ahmad Harthi (via Code Review) wrote: > Hi, > > I have submitted a patch for review: > > https://gerrit.libreoffice.org/3644 > > To pull it, you can do: > > git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/3644/1 > > fdo#35320 A

[PATCH] fdo#39468 Comment translation GER-ENG in sw/source/ui/shells...

2013-04-28 Thread Matthias Freund (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3646 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/3646/1 fdo#39468 Comment translation GER-ENG in sw/source/ui/shells/ (Part 2) Change-Id: I389569b027a900f42e43762c5685e