Re: Compile errors when setting DBG_LEVEL=2

2013-05-12 Thread Chris Sherlock
Worked it out - missing brace in an if statement. I was staring at this for a long time till I decided to remove the conditional defines to make it compile... then I found it. I've pushed the fix. Chris On Sun, May 12, 2013 at 12:06 PM, Chris Sherlock chris.sherloc...@gmail.com wrote: Hey

[Libreoffice-commits] core.git: cppcanvas/source vcl/source

2013-05-12 Thread Chris Sherlock
cppcanvas/source/mtfrenderer/emfplus.cxx | 35 +++ vcl/source/filter/wmf/enhwmf.cxx |3 +- 2 files changed, 28 insertions(+), 10 deletions(-) New commits: commit 00fbf73b07adc4d8f0e37e36bb844f2e9d19ae15 Author: Chris Sherlock chris.sherloc...@gmail.com

[Libreoffice-commits] core.git: dictionaries

2013-05-12 Thread Björgvin Ragnarsson
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 26ca446fb7d5e3913b75b7e00b4cd04330b45c8f Author: Björgvin Ragnarsson nifgr...@gmail.com Date: Sun May 12 00:05:51 2013 +0200 Updated core Project: dictionaries

[PUSHED] EMF+ fixes

2013-05-12 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3861 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3861 To unsubscribe,

[PUSHED] add Icelandic Hunspell dictionary

2013-05-12 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3859 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3859 To unsubscribe,

[Libreoffice-commits] core.git: extras/CustomTarget_autocorr.mk extras/Package_autocorr.mk extras/source

2013-05-12 Thread Björgvin Ragnarsson
extras/CustomTarget_autocorr.mk|4 extras/Package_autocorr.mk |1 extras/source/autotext/lang/is/acor/META-INF/manifest.xml |6 extras/source/autotext/lang/is/acor/SentenceExceptList.xml | 151 + 4 files

[PUSHED] Add Icelandic autocorrection support, Only SentenceExceptLis...

2013-05-12 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3862 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3862 To unsubscribe,

[Libreoffice-commits] core.git: cppcanvas/source

2013-05-12 Thread David Tardon
cppcanvas/source/mtfrenderer/emfplus.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2293815a6329d2918954cc11d6dfd8d111ab8c57 Author: David Tardon dtar...@redhat.com Date: Sun May 12 07:37:00 2013 +0200 fix build Change-Id:

[PATCH] Accidentally added std::hex

2013-05-12 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3866 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/3866/1 Accidentally added std::hex Change-Id: Icf83f118849d99bbb41cacc76c2e101f0c156b72 --- M

[PATCH] Janitorial: indent code correctly

2013-05-12 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3867 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3867/1 Janitorial: indent code correctly Change-Id: I9fcbeb5f60df1a977347076dac82d4b5f7aba2c1 --- M

[ABANDONED] Accidentally added std::hex

2013-05-12 Thread Chris Sherlock (via Code Review)
Chris Sherlock has abandoned this change. Change subject: Accidentally added std::hex .. Patch Set 2: Abandoned dtardon fixed this in master already. -- To view, visit https://gerrit.libreoffice.org/3866 To unsubscribe,

[Libreoffice-commits] libvisio.git: 4 commits - src/lib

2013-05-12 Thread David Tardon
src/lib/VSDContentCollector.cpp | 48 --- src/lib/VSDContentCollector.h |4 +- src/lib/VSDParser.cpp | 61 ++-- 3 files changed, 74 insertions(+), 39 deletions(-) New commits: commit

[Libreoffice-commits] core.git: vcl/coretext

2013-05-12 Thread Tor Lillqvist
vcl/coretext/salcoretextlayout.cxx |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) New commits: commit 0037c288a15423d800d4df311741cc77411663df Author: Tor Lillqvist t...@iki.fi Date: Sun May 12 10:13:57 2013 +0300 WaE: private field 'mpGraphics' is not used

several reports of a problem with jpeg test in vcl

2013-05-12 Thread Markus Mohrhard
Hey Caolan, *, so after we got several complains about test failure in vcl with the same file I looked at it with memcheck and can at least produce an output there. The test does not fail for me or at the tinderbox but we had now 3 independet people having problems with the same file on different

[Libreoffice-commits] libvisio.git: src/lib

2013-05-12 Thread David Tardon
src/lib/VSDParser.cpp |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit 62a1abdadcba61f9a0d0daf38c442f0cd86c8718 Author: David Tardon dtar...@redhat.com Date: Sun May 12 11:27:14 2013 +0200 avoid access to uninit. memory diff --git a/src/lib/VSDParser.cpp

Re: several reports of a problem with jpeg test in vcl

2013-05-12 Thread Tomaž Vajngerl
Hi, Probably one of my changes is the cause for this. One of the problems is that CVE-2004-0200-3.jpg is a semi corrupt file. Usually it can be read fine but doing any transform operations fails. For example jpegtrans fails for this file, GIMP does not open it, ImageMagick's convert does not

[Libreoffice-commits] core.git: dbaccess/source reportdesign/source

2013-05-12 Thread Julien Nabet
dbaccess/source/filter/xml/xmlDataSourceSetting.cxx |2 +- reportdesign/source/filter/xml/xmlControlProperty.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit e13bd0cfc7cd395baa125fff86171d030be71f8c Author: Julien Nabet serval2...@yahoo.fr Date: Sun May

[Libreoffice-commits] core.git: writerfilter/source

2013-05-12 Thread Julien Nabet
writerfilter/source/dmapper/DomainMapper.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit d29cdd990d44c5b11bf949397fd30154a1f61475 Author: Julien Nabet serval2...@yahoo.fr Date: Sun May 12 12:03:48 2013 +0200 cppcheck: fix redundantAssignInSwitch

[Libreoffice-commits] core.git: configure.ac

2013-05-12 Thread Lionel Elie Mamane
configure.ac |2 ++ 1 file changed, 2 insertions(+) New commits: commit 180b1e1e18d6cc2b2ab35979ea53982ee0b58396 Author: Lionel Elie Mamane lio...@mamane.lu Date: Sun May 12 13:32:23 2013 +0200 configure.ac: check for newly needed mdds header Change-Id:

Re: fdo#41572 Making it possible to add custom animation to master slides

2013-05-12 Thread Janit Anjaria
Hey! I am hereby attaching my patch which is a work in progress. Thorsten : Check out *Line number 148* in sd/source/core/sdtool.cxx where i have mentioned(i.e. in the form of comment) the query i have in mind ,and the question i had asked you on IRC. I hope the surrounding code would make things

[Libreoffice-commits] core.git: filter/source

2013-05-12 Thread Julien Nabet
filter/source/config/cache/filterfactory.cxx | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) New commits: commit 86f4856c78cf31fcaa0f0fc61b3795dc75859972 Author: Julien Nabet serval2...@yahoo.fr Date: Sun May 12 13:45:03 2013 +0200 Quiet cppcheck +

[Libreoffice-commits] core.git: cppcanvas/source

2013-05-12 Thread Chris Sherlock
cppcanvas/source/mtfrenderer/emfplus.cxx | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) New commits: commit 931984489e1f2da1b223ba927bda6a06e0d3f75f Author: Chris Sherlock chris.sherloc...@gmail.com Date: Sun May 12 15:42:32 2013 +1000 Janitorial: indent

[PUSHED] Janitorial: indent code correctly

2013-05-12 Thread Thorsten Behrens (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3867 Approvals: Thorsten Behrens: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3867 To unsubscribe,

[PATCH] cppcheck: fix arrayIndexThenCheck/optimize loops

2013-05-12 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3869 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/3869/1 cppcheck: fix arrayIndexThenCheck/optimize loops Change-Id: If399abf5fb3eaea91f4f5d5e86b86b37790d3c9a --- M

[PATCH] cppcheck: fix arrayIndexThenCheck in vcl

2013-05-12 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3868 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/3868/1 cppcheck: fix arrayIndexThenCheck in vcl Change-Id: Id7258dd35c131c2c8151bc5e0f97076241e6d10f --- M

Cppcheck: throwing exception in destructor in SyncDbusSessionHelper.cxx (shell module)

2013-05-12 Thread julien2412
Hello, Cppcheck reported exception thrown in destructor in shell/source/sessioninstall/SyncDbusSessionHelper.cxx, line 39 28 class GErrorWrapper 29 { 30 GError* m_pError; 31 public: 32 GErrorWrapper(GError* pError) : m_pError(pError) {}

[Libreoffice-commits] core.git: basegfx/source

2013-05-12 Thread Armin Le Grand
basegfx/source/tools/gradienttools.cxx | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) New commits: commit ed43421545c86f85b5fc4b9a33be077748fb8487 Author: Armin Le Grand a...@apache.org Date: Tue Aug 14 08:19:40 2012 + Resolves: fdo#49508# #i120539# Fixed

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 00/8bc1d4b8cd47ca9940be00a8cfdcdb1ef85856

2013-05-12 Thread Caolán McNamara
00/8bc1d4b8cd47ca9940be00a8cfdcdb1ef85856 |1 + 1 file changed, 1 insertion(+) New commits: commit 662cabcd38c872b021d4b83a354cd6a21f186339 Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 15:39:39 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: vcl/source

2013-05-12 Thread Armin Le Grand
vcl/source/gdi/outdev.cxx |8 vcl/source/gdi/outdev6.cxx |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) New commits: commit f94000bf5be0e1e0f9196306c6de5741707ad7b7 Author: Armin Le Grand a...@apache.org Date: Tue May 7 09:34:50 2013 + Resolves: #i122241#

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 66/4f4d882129c98d502463e08ce601259b85fc8c

2013-05-12 Thread Caolán McNamara
66/4f4d882129c98d502463e08ce601259b85fc8c |1 + 1 file changed, 1 insertion(+) New commits: commit 2d836c5fcc34b6095bc79f5df128040a4a5c6e8a Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 15:53:55 2013 +0100 Notes added by 'git notes add' diff --git

[PATCH] Fixes fdo#64237 by modifying the underlyning string

2013-05-12 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3870 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/3870/1 Fixes fdo#64237 by modifying the underlyning string Change-Id: I7d387e40464b53a55524bf950b8d413cf8468376 --- M

[Libreoffice-commits] core.git: 3 commits - odk/examples sfx2/workben

2013-05-12 Thread Ariel Constenla-Haile
dev/null|binary odk/examples/cpp/custompanel/CalcWindowState.xcu| 39 +++ odk/examples/cpp/custompanel/DrawWindowState.xcu| 39 +++ odk/examples/cpp/custompanel/Factories.xcu | 39 +++

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 2 commits - 5a/ff353f227ecfeb36ef6b8be787495916610490 8a/f699cb89d9477b13d8701266b7c1fdf9356cfa

2013-05-12 Thread Caolán McNamara
5a/ff353f227ecfeb36ef6b8be787495916610490 |1 + 8a/f699cb89d9477b13d8701266b7c1fdf9356cfa |1 + 2 files changed, 2 insertions(+) New commits: commit 3b198c2d5e9c93a543a7361b5bfbd935cbd59d6b Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 16:13:16 2013 +0100 Notes

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - d0/b30a0f10f506187fcff9775934d3594c140ead

2013-05-12 Thread Caolán McNamara
d0/b30a0f10f506187fcff9775934d3594c140ead |1 + 1 file changed, 1 insertion(+) New commits: commit 1ddaeb1a3bfef567364963a17d6770695dddef92 Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 16:13:32 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - cb/4019e9c52ae7f89a6b63c738c4bc4e670a9666

2013-05-12 Thread Caolán McNamara
cb/4019e9c52ae7f89a6b63c738c4bc4e670a9666 |1 + 1 file changed, 1 insertion(+) New commits: commit 8df46f5c5a5f782caaeb0ec7217bab08c5177ad2 Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 16:15:37 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: sd/source

2013-05-12 Thread Andre Fischer
sd/source/ui/docshell/docshel4.cxx | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) New commits: commit 4da833308a496363cd05baad577a073e5bfb0872 Author: Andre Fischer a...@apache.org Date: Fri Jul 6 10:45:08 2012 + Resolves: #i119902# Rename all master pages in a

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 7d/aa651fbc74a6fc08d713282b9e25cda14e39e9

2013-05-12 Thread Caolán McNamara
7d/aa651fbc74a6fc08d713282b9e25cda14e39e9 |1 + 1 file changed, 1 insertion(+) New commits: commit f60ece89e2c740956c2766a20f4adedc2d60ffb7 Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 16:29:07 2013 +0100 Notes added by 'git notes add' diff --git

[PATCH] Added further documentation for sfx2

2013-05-12 Thread Lennard Wasserthal (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3871 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/3871/1 Added further documentation for sfx2 Added further documentation on the sfx2 framework. Turned the packed odg

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 5f/8fdf26690191f185ba81cb3d3f3118acf34442

2013-05-12 Thread Caolán McNamara
5f/8fdf26690191f185ba81cb3d3f3118acf34442 |1 + 1 file changed, 1 insertion(+) New commits: commit 2fbc7f5505aa602550a3142393e5c328327159fb Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 16:36:12 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: 2 commits - sw/source

2013-05-12 Thread Matteo Casalin
sw/source/ui/uiview/viewport.cxx | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) New commits: commit 0e540d7e393b05b3813206ed60be2c51a8d80aa2 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun May 12 17:37:22 2013 +0200 Fix indentation

[PATCH] fdo#55582 calc part

2013-05-12 Thread Lennard Wasserthal (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3872 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/3872/1 fdo#55582 calc part Since the actual Patch for fdo#55582 hangs on the writer part, I commit that bloody sc part

[Libreoffice-commits] core.git: vcl/source

2013-05-12 Thread Armin Le Grand
vcl/source/filter/wmf/enhwmf.cxx | 77 +-- 1 file changed, 75 insertions(+), 2 deletions(-) New commits: commit 0752c18df9a975ffa182a4a7bc86e0bcadd58aec Author: Armin Le Grand a...@apache.org Date: Fri Jul 27 14:01:18 2012 + Resolves: #i119450#

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 1e/a8c3a924d518043c5d3d1427cd40cf500c8b21

2013-05-12 Thread Caolán McNamara
1e/a8c3a924d518043c5d3d1427cd40cf500c8b21 |1 + 1 file changed, 1 insertion(+) New commits: commit 56f351517c88d5c0e851536acf81d592b22dccc2 Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 17:01:04 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: 5 commits - filter/source include/filter sd/source

2013-05-12 Thread Jan Holesovsky
filter/source/msfilter/svdfppt.cxx | 11 +- include/filter/msfilter/svdfppt.hxx |3 - sd/source/filter/ppt/pptin.cxx | 57 ++-- 3 files changed, 20 insertions(+), 51 deletions(-) New commits: commit 55c63ccfd460895af22e91979967cec15d80b72d

[Libreoffice-commits] core.git: swext/mediawiki

2013-05-12 Thread Ariel Constenla-Haile
swext/mediawiki/src/filter/odt2mediawiki.xsl | 48 ++- 1 file changed, 33 insertions(+), 15 deletions(-) New commits: commit bc0e857b9699bfefa2d8204fe627063675c9cfc9 Author: Ariel Constenla-Haile arie...@apache.org Date: Sat Mar 23 12:49:10 2013 + Resolves:

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 41/4a61fa4c4f03a2b2645682c55ee56ae9c84a79

2013-05-12 Thread Caolán McNamara
41/4a61fa4c4f03a2b2645682c55ee56ae9c84a79 |1 + 1 file changed, 1 insertion(+) New commits: commit 45e8bcc5093ae2a239e238b918cc24aee81fde8a Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 17:09:21 2013 +0100 Notes added by 'git notes add' diff --git

[PATCH] cppcheck: fix uselessAssignmentPtrArg

2013-05-12 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3873 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/3873/1 cppcheck: fix uselessAssignmentPtrArg Change-Id: I260bb1207cebb8cefb52fe1db3f51b63239b25a7 --- M

Cppcheck: uselessAssignmentPtrArg in wrapper.cxx (sdext module)

2013-05-12 Thread julien2412
Hello, Cppcheck reported this an useless assignment in sdext/source/pdfimport/wrapper/wrapper.cxx, line 475 462 int Parser::parseFontCheckForString( const sal_Unicode* pCopy, const char* s, sal_Int32 nLen, 463 FontAttributes aResult, bool bItalic, bool bBold) 464 { 465

Re: Cppcheck: uselessAssignmentPtrArg in wrapper.cxx (sdext module)

2013-05-12 Thread julien2412
A bunch of similar warnings here: error file=basic/source/sbx/sbxbyte.cxx line=215 id=uselessAssignmentPtrArg severity=style msg=Assignment of function parameter has no effect outside the function./ error file=basic/source/sbx/sbxchar.cxx line=200 id=uselessAssignmentPtrArg severity=style

[Libreoffice-commits] core.git: vcl/generic

2013-05-12 Thread Khaled Hosny
vcl/generic/glyphs/gcach_layout.cxx | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) New commits: commit 2ede6c95e6481c92cc199e7d74fd36c841636304 Author: Khaled Hosny khaledho...@eglug.org Date: Sun May 12 17:59:50 2013 +0200 Some logging

[Libreoffice-commits] core.git: vcl/source

2013-05-12 Thread Caolán McNamara
vcl/source/filter/wmf/enhwmf.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit fa169ffc3d8d5e3cde41411858cc40546fc04e0e Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 17:55:41 2013 +0100 WaE: signed/unsigned comparison Change-Id:

[PATCH] Icelandic currency: fractions of króna are not used any more...

2013-05-12 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3874 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/3874/1 Icelandic currency: fractions of króna are not used any more. As of 2003, banks stopped accepting aurar and

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - c8/d736bc7dc78a3357c0265d3bd1c1954d44c714

2013-05-12 Thread Caolán McNamara
c8/d736bc7dc78a3357c0265d3bd1c1954d44c714 |1 + 1 file changed, 1 insertion(+) New commits: commit f7ce3bd728ab070f647a60223d4a616ccacaf896 Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 18:08:33 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 71/160a5518070318a1fa0fcaf91e8c663131be1d

2013-05-12 Thread Caolán McNamara
71/160a5518070318a1fa0fcaf91e8c663131be1d |1 + 1 file changed, 1 insertion(+) New commits: commit 7bfd3511441e44f01ab6f845d20aa98707e4afed Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 18:08:48 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - b6/fac6a8a6875c73b8e16a9ef796e3180a0f6821

2013-05-12 Thread Caolán McNamara
b6/fac6a8a6875c73b8e16a9ef796e3180a0f6821 |1 + 1 file changed, 1 insertion(+) New commits: commit cb578c29382dbc2915c4c64ac6104982a7967f1e Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 18:17:56 2013 +0100 Notes added by 'git notes add' diff --git

Cppcheck: incorrectLogicOperator in svxrectctaccessiblecontext.cxx (in svx module)

2013-05-12 Thread julien2412
Hello, cppcheck reported this: error file=svx/source/accessibility/svxrectctaccessiblecontext.cxx line=612 id=incorrectLogicOperator severity=style msg=Logical disjunction always evaluates to true: nIndex gt;= 0 || nIndex lt; 0./ Indeed we have in this file that: 610 void

Where to find the sources for the tinderbox status?

2013-05-12 Thread Philipp Riemer
Hi, when looking at http://tinderbox.libreoffice.org/MASTER/status.html, I currently see the first Android-Tinderbox in a green status -- with 3 errors! However, when checking the output on the Brief Build Log, it appears that these are all false positives. The three lines that are highlighted as

Re: Where to find the sources for the tinderbox status?

2013-05-12 Thread julien2412
Philipp Riemer wrote ... Can someone give me a pointer to the related reporting script/ whatever reports the number of errors, so that I can try removing these false positive cases? I don't know but in full log, I noticed this: Reading autogen.lastrun. Please rename it to autogen.input to

Re: Where to find the sources for the tinderbox status?

2013-05-12 Thread Christian Lohmaier
Hi Philipp, On Sun, May 12, 2013 at 7:38 PM, Philipp Riemer ruderphil...@gmail.com wrote: Hi, when looking at http://tinderbox.libreoffice.org/MASTER/status.html, I currently see the first Android-Tinderbox in a green status Yes, all that counts in terms of build success or failure is the

RES: Problem Trying call LibreOffice from Java

2013-05-12 Thread Fernando Digitaldoc
Hi Stepahn, We will make another example. (have some problems with officebean.dll and officebean.so .. , we are solving for the example) But now , we are trying to make more tests. The most critical issue now is the call from Ubuntu. KDE on Windows or Linux, we can run, but in Ubuntu, after

QA test breaking libreoffice-4.0.3 packaging

2013-05-12 Thread Francois Tigeot
One of the QA test is trying to write into the user home directory during the build, and this breaks packaging: [build CMP] chart2/source/controller/chartcontroller [build LNK] Library/libcuilo.so [build MOD] scripting mkstemp(/root/.execoooAxI0ZD) failed: Read-only file system No fonts could be

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 32/b7cbf216b86571e19168d2a4213b2c33861ee9

2013-05-12 Thread Caolán McNamara
32/b7cbf216b86571e19168d2a4213b2c33861ee9 |1 + 1 file changed, 1 insertion(+) New commits: commit 4829d3c0b3f3ab894b55756ffc74082f4034b0b5 Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 20:00:07 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: sd/source

2013-05-12 Thread Andre Fischer
sd/source/filter/eppt/pptexanimations.cxx | 10 ++ 1 file changed, 10 insertions(+) New commits: commit 9e0b99a78b1fdb545eefc76a0931e908481bbdb6 Author: Andre Fischer a...@apache.org Date: Mon Jun 25 08:09:05 2012 + Resolves: #i119740# Fixed export of fill property of

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - c4/c014f74afaa9ca1b31c750b0445cf3f34e61a6

2013-05-12 Thread Caolán McNamara
c4/c014f74afaa9ca1b31c750b0445cf3f34e61a6 |1 + 1 file changed, 1 insertion(+) New commits: commit 72eab5766e471d6e50caf353bc1ada5e905045ce Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 20:04:28 2013 +0100 Notes added by 'git notes add' diff --git

Re: QA test breaking libreoffice-4.0.3 packaging

2013-05-12 Thread Rene Engelhard
On Sun, May 12, 2013 at 12:46:14PM +0200, Francois Tigeot wrote: I'll probably have to create a patch to completely disable starmath unit tests if I don't find the culprit quickly. Would it be possible to add a configure flag to skip the qa tests during packaging ? They are more a PITA than

[Libreoffice-commits] core.git: offapi/com

2013-05-12 Thread Ariel Constenla-Haile
offapi/com/sun/star/presentation/XSlideShow.idl |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 5de5a073e0c64699e716d71e1d6b700380eeced6 Author: Ariel Constenla-Haile arie...@apache.org Date: Mon Jul 2 08:28:55 2012 + Related: #i120145# Remove

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 59/d811efac87bf84169ca439a7d9b5181fc5929d

2013-05-12 Thread Caolán McNamara
59/d811efac87bf84169ca439a7d9b5181fc5929d |1 + 1 file changed, 1 insertion(+) New commits: commit e5a580f78374da574d88c89d004a8c0cc710c835 Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 20:08:55 2013 +0100 Notes added by 'git notes add' diff --git

Re: Excel Function Meta Bug?

2013-05-12 Thread Philipp Riemer
Hi, I am currently cleaning up my mailbox and found this mail that is close to a year old. 2012/7/17 Joel Madero jmadero@gmail.com Nice, the updates make it quite a bit more functional. I noticed that most of the really useful functions are already well on their way to being implemented.

[Libreoffice-commits] core.git: comphelper/source

2013-05-12 Thread Andre Fischer
comphelper/source/container/embeddedobjectcontainer.cxx | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) New commits: commit dbec45e8136a6de7968d93b2fc891d7409133b13 Author: Andre Fischer a...@apache.org Date: Mon Jul 9 14:39:47 2012 + Resolves: #i120168# Do

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 82/2661c165198467b56fa2a1034ddc002ba99f7e

2013-05-12 Thread Caolán McNamara
82/2661c165198467b56fa2a1034ddc002ba99f7e |1 + 1 file changed, 1 insertion(+) New commits: commit f5ca2031b4381ae9d72ca554b81872ef74a6be0c Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 20:14:17 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] .: 2 commits - src/docdirstream.py src/docrecord.py

2013-05-12 Thread Miklos Vajna
src/docdirstream.py | 12 ++ src/docrecord.py| 59 +++- 2 files changed, 65 insertions(+), 6 deletions(-) New commits: commit 388bef4e111c22d9a373f49f9453781d268f6ed4 Author: Miklos Vajna vmik...@suse.cz Date: Sun May 12 21:19:06

[Libreoffice-commits] core.git: sd/source

2013-05-12 Thread Andre Fischer
sd/source/ui/slidesorter/inc/view/SlsPageObjectPainter.hxx |6 ++ sd/source/ui/slidesorter/view/SlsPageObjectPainter.cxx | 39 - 2 files changed, 31 insertions(+), 14 deletions(-) New commits: commit 8056d92635dd1cb03798d4691611d2484bf680af Author: Andre Fischer

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - b8/f5370aeea74b68333885450f7ec34918c1d8c8

2013-05-12 Thread Caolán McNamara
b8/f5370aeea74b68333885450f7ec34918c1d8c8 |1 + 1 file changed, 1 insertion(+) New commits: commit dc661ae790bb15207a90298ee47c0f1421a69ad7 Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 20:24:42 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: vcl/source

2013-05-12 Thread Armin Le Grand
vcl/source/gdi/bitmapex.cxx | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) New commits: commit baebeb7de4c5f9511e45c2846ec2a72861a948c0 Author: Armin Le Grand a...@apache.org Date: Fri Jul 27 14:04:19 2012 + Resolves: #i120165# Adapt Mask/Alpha at

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 3c/fc24693469fb9b682e9c76c28610be1e004799

2013-05-12 Thread Caolán McNamara
3c/fc24693469fb9b682e9c76c28610be1e004799 |1 + 1 file changed, 1 insertion(+) New commits: commit a3cae6593cfebc103375aeee27c6b617dcda2008 Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 20:31:29 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 2f/2c34dacc49f34053bb08fe09143292156705e2

2013-05-12 Thread Caolán McNamara
2f/2c34dacc49f34053bb08fe09143292156705e2 |1 + 1 file changed, 1 insertion(+) New commits: commit 544bd414a9c5977f74d3e124d2d75836653a565b Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 20:32:28 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - fb/612e2caae83134dd9b5e22048569ff76fadc57

2013-05-12 Thread Caolán McNamara
fb/612e2caae83134dd9b5e22048569ff76fadc57 |1 + 1 file changed, 1 insertion(+) New commits: commit 1ab3bda8a579f69bd8f2f7fb02ee38bbe50cba6f Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 20:34:44 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - fc/0ca3e74d10bd94943beeac2dbcefa99122df14

2013-05-12 Thread Caolán McNamara
fc/0ca3e74d10bd94943beeac2dbcefa99122df14 |1 + 1 file changed, 1 insertion(+) New commits: commit d0aacb9a4478ff5cd75f50c266b7ab4ca548a7ea Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 20:35:27 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - a5/81e6b99c4633c7bcc2eedc45a8d8c1c4a77aff

2013-05-12 Thread Caolán McNamara
a5/81e6b99c4633c7bcc2eedc45a8d8c1c4a77aff |1 + 1 file changed, 1 insertion(+) New commits: commit 07ab84e2f8e1d975b2adbe286e24d218e9f43ff0 Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 20:36:25 2013 +0100 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 57/fadc88cdc88b07262d6ad302532ac1e2d602a1

2013-05-12 Thread Caolán McNamara
57/fadc88cdc88b07262d6ad302532ac1e2d602a1 |1 + 1 file changed, 1 insertion(+) New commits: commit 26c0f7a06edded330dc81a66d0cf1d418310f3f3 Author: Caolán McNamara caol...@redhat.com Date: Sun May 12 20:38:24 2013 +0100 Notes added by 'git notes add' diff --git

Re: Where to find the sources for the tinderbox status?

2013-05-12 Thread Philipp Riemer
Hey Julien, Christian, 2013/5/12 Christian Lohmaier lohmaier+libreoff...@googlemail.com Hi Philipp, On Sun, May 12, 2013 at 7:38 PM, Philipp Riemer ruderphil...@gmail.com wrote: Hi, when looking at http://tinderbox.libreoffice.org/MASTER/status.html, I currently see the first

[Libreoffice-commits] .: 2 commits - src/docrecord.py src/docstream.py

2013-05-12 Thread Miklos Vajna
src/docrecord.py | 39 --- src/docstream.py | 20 +++- 2 files changed, 39 insertions(+), 20 deletions(-) New commits: commit f569aa25d496c7281b6cfaaa9ef739f880ee8089 Author: Miklos Vajna vmik...@suse.cz Date: Sun May 12 21:47:40 2013

[Libreoffice-commits] core.git: include/vcl vcl/source

2013-05-12 Thread Tomaž Vajngerl
include/vcl/bitmap.hxx |9 --- vcl/source/gdi/bitmap3.cxx | 103 - 2 files changed, 112 deletions(-) New commits: commit 71cca07fc18149b37fb22956257dd0b8f5df89a1 Author: Tomaž Vajngerl qui...@gmail.com Date: Sun May 12 22:00:22 2013 +0200

[Libreoffice-commits] core.git: sc/source

2013-05-12 Thread Julien Nabet
sc/source/ui/view/output2.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit dfcdfd8577534ac2ab56259afc6f1e19572e6d4a Author: Julien Nabet serval2...@yahoo.fr Date: Sun May 12 22:43:09 2013 +0200 cppcheck: unusedVariable (pPreviewPattr) Change-Id:

Re: Where to find the sources for the tinderbox status?

2013-05-12 Thread Christian Lohmaier
Hi Philipp, *, On Sun, May 12, 2013 at 9:40 PM, Philipp Riemer ruderphil...@gmail.com wrote: Thanks for the link. Uh, Perl... regular expressions would be mor or less the same in other langauges, so no difference here. And using something else than perl just for the sake of it would be

[Libreoffice-commits] core.git: codemaker/source

2013-05-12 Thread Julien Nabet
codemaker/source/cppumaker/cpputype.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 53d7ae8c6b4de6ef50472639979609afa542038a Author: Julien Nabet serval2...@yahoo.fr Date: Sun May 12 22:53:28 2013 +0200 cppcheck: unusedVariable (parameters) Change-Id:

[PATCH] fdo#39468 Comment translation GER-ENG in sw/source/ui/shells...

2013-05-12 Thread Matthias Freund (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3875 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/3875/1 fdo#39468 Comment translation GER-ENG in sw/source/ui/shells/ (Part 3) Translations and cleanups. Change-Id:

Re: [PATCH] Fixes fdo#64237 by modifying the underlyning string

2013-05-12 Thread Jean-Baptiste Faure
Hi, It seems that OpenID hates me and I can't connect to gerrit. So I answer here. With the patch the bugdoc of fdo#64237 opens fine and it is possible to scroll through the document without memory leak and crash. I tested too the original document (not anonymized) and it works fine. Thank you

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add onlineupdate module

2013-05-12 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3877 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/3877/1 fdo#60924 autoinstall - gbuild/scp2: add onlineupdate module Change-Id:

[Libreoffice-commits] core.git: vcl/generic

2013-05-12 Thread Khaled Hosny
vcl/generic/glyphs/gcach_ftyp.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c0417e82174297ace604c68fc577c831929f3573 Author: Khaled Hosny khaledho...@eglug.org Date: Mon May 13 02:33:14 2013 +0200 Typo Change-Id:

Re: [PATCH][REJECTED] made available under the MPL/LGPLv3+

2013-05-12 Thread David Tardon
Hi, On Fri, May 03, 2013 at 10:15:13PM +0530, nilesh gupta wrote: https://bugs.freedesktop.org/show_bug.cgi?id=63926 easy hack number 63926 https://bugs.freedesktop.org/show_bug.cgi?id=63926 Please read the bug description again. Please check what are you committing: there are two tiny

[PATCH] fdo#60924: autoinstall onlineupdate libraries

2013-05-12 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3878 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/3878/1 fdo#60924: autoinstall onlineupdate libraries Change-Id: I9e06d165351161ff144b7605094a3e490d13d5f2 --- M

Re: QA test breaking libreoffice-4.0.3 packaging

2013-05-12 Thread Francois Tigeot
On Sun, May 12, 2013 at 09:03:37PM +0200, Rene Engelhard wrote: On Sun, May 12, 2013 at 12:46:14PM +0200, Francois Tigeot wrote: I'll probably have to create a patch to completely disable starmath unit tests if I don't find the culprit quickly. Would it be possible to add a configure

[Libreoffice-commits] core.git: editeng/source include/vcl sc/source sw/inc sw/source vcl/inc vcl/source vcl/win

2013-05-12 Thread Yohei Yukawa
editeng/source/editeng/impedit2.cxx | 27 + include/vcl/cmdevt.hxx |2 + include/vcl/window.hxx |2 + sc/source/ui/app/inputhdl.cxx | 15 + sc/source/ui/view/gridwin.cxx |3 + sw/inc/crsrsh.hxx |4

[PUSHED] Support IMR_QUERYCHARPOSITION in Writer and Calc.

2013-05-12 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3849 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3849 To unsubscribe,

[Libreoffice-commits] core.git: 2 commits - configure.ac

2013-05-12 Thread Lionel Elie Mamane
configure.ac |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit ca8201ef54cd58e41504dc04101aa76c97a78733 Author: Lionel Elie Mamane lio...@mamane.lu Date: Mon May 13 07:53:52 2013 +0200 configure.ac: fix error message on non-MacOS X builds Change-Id:

Re: [Libreoffice-qa] Cleaning up QA Nabble and Archive folders from Spam?

2013-05-12 Thread Florian Reisinger
Hi Stuat, Am 12.05.2013 00:16, schrieb V Stuart Foote: [...] Hmm, I think the QA list IS hosted the same as the other TDF mail lists, with freedesktop.org DNS registration. I really think not, becuase I have to log in @freedesktop to do moderation (yes I do moderation, but I do not have

Re: [Libreoffice-qa] Cleaning up QA Nabble and Archive folders from Spam?

2013-05-12 Thread Sophie Gautier
Hi Pedro, On 11/05/2013 23:48, Pedro wrote: Hi again Sophie sophi wrote The QA list is out of our domain, it's on freedsktop.org, so I doubt we can do anything here, the messages are not posted from Nabble. Even to moderate these mails on the queue so they don't appear at all. Florian

Re: [Libreoffice-qa] Can someone triage fdo#35041 Improve 'Link to External Data' concerning CGI - Oldest Unconfirmed bug

2013-05-12 Thread Niklas Johansson
Hi Joel Joel Madero skrev 2013-05-12 01:40: Can someone take a look at this one and try to confirm it - it is our oldest standing unconfirmed bug and should be dealt with IMO. Either push it forward or close it (probably needs a dev to comment).

Re: [Libreoffice-qa] Cleaning up QA Nabble and Archive folders from Spam?

2013-05-12 Thread Florian Effenberger
Hi, Sophie Gautier wrote on 2013-05-11 18:50: Drew is currently not available and I'm taking care of Nabble. I think the spam you see here is the one getting on the list. I can remove all the spam mails on Nabble, but they'll still be on the archive, see:

  1   2   3   >