LibreOffice Gerrit News 2013-09-26
Moin! * Open changes on master for project core changed in the last 25 hours: + String to OUString in https://gerrit.libreoffice.org/6031 from Matteo Casalin + fdo#54938: Adapt supportsService implementations to cppu::supportsService in https://gerrit.libreoffice.org/6035 from Marcos Souza + fix for fdo#65295, gradient issue in https://gerrit.libreoffice.org/6039 from Siqi LIU + translation fix in https://gerrit.libreoffice.org/6038 from Siqi LIU + adding some comments in https://gerrit.libreoffice.org/6037 from Siqi LIU + fdo#43157 - Clean up OSL_ENSURE in https://gerrit.libreoffice.org/6036 from Jacobo Aragunde Pérez + General cleanup in sal module for all and unix. in https://gerrit.libreoffice.org/6016 from Arnaud Versini + fdo63235 - improve import of svg path data in https://gerrit.libreoffice.org/6021 from Christina Roßmanith + [PATCH] fdo#50118 use local add-in function names in https://gerrit.libreoffice.org/6032 from Winfried Donkers * Merged changes on master for project core changed in the last 25 hours: + String to OUString in https://gerrit.libreoffice.org/6024 from Matteo Casalin + list types added to Expert Config page in https://gerrit.libreoffice.org/5917 from Efe Gürkan Yalaman + String to OUString in https://gerrit.libreoffice.org/6030 from Matteo Casalin + Add LO_JAVA_DIR to CppunitTest env. in https://gerrit.libreoffice.org/6023 from Andrzej J.R. Hunt * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + Remove more unusedcode in https://gerrit.libreoffice.org/5937 from Marcos Souza + Simplify oslThreadIdentifier on Linux 32. in https://gerrit.libreoffice.org/5553 from Arnaud Versini + improve performance of copyArea in Ios in https://gerrit.libreoffice.org/5707 from Tsahi Glik @ CloudOn + Fix for IOS scroll by pixels, and pinch to zoom Change-Id: Ied6087a264f1c in https://gerrit.libreoffice.org/5742 from Ptyl + fix polygon rendering with clip area of one line only in https://gerrit.libreoffice.org/5709 from Tsahi Glik @ CloudOn + fix for text watermark in https://gerrit.libreoffice.org/5568 from Adam CloudOn + fdo#39468: Translate German comments (first part) in include/svl/filerec. in https://gerrit.libreoffice.org/5793 from Philipp Riemer + fdo#44689: fix for specific case restart value 0 in https://gerrit.libreoffice.org/5681 from Adam CloudOn + Dynamically align toolbars in LibreOffice in https://gerrit.libreoffice.org/5655 from Prashant Pandey + fdo#36791 : fix for import of greeting card in https://gerrit.libreoffice.org/4240 from Adam CloudOn + fdo#66401: fix for combined characters in https://gerrit.libreoffice.org/5018 from Adam CloudOn + more debug logs, extra debug layer, file is not used in p3k in https://gerrit.libreoffice.org/5267 from James Michael Dupont + Remove old outdated gallery images and sounds in https://gerrit.libreoffice.org/4993 from Samuel Mehrbrodt + Positional Tab additions in https://gerrit.libreoffice.org/5387 from Adam CloudOn + fdo#64817 : fix for rectangle with image fill in https://gerrit.libreoffice.org/4718 from Adam CloudOn Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/ui/config/optcomp.cxx | 32 +++-
sw/source/ui/inc/optcomp.hxx|5 +++--
2 files changed, 18 insertions(+), 19 deletions(-)
New commits:
commit 3b74822938e66dc50d6ae659bc849223aec23a9e
Author: Matteo Casalin matteo.casa...@yahoo.com
Date: Wed Sep 18 00:46:03 2013 +0200
String to OUString
Change-Id: I775327d5218655841006bcac5a1dbf236503fbb5
Reviewed-on: https://gerrit.libreoffice.org/6025
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/source/ui/config/optcomp.cxx b/sw/source/ui/config/optcomp.cxx
index 5b3e990..5a52f5f 100644
--- a/sw/source/ui/config/optcomp.cxx
+++ b/sw/source/ui/config/optcomp.cxx
@@ -47,8 +47,8 @@ using namespace ::std;
struct CompatibilityItem
{
-String m_sName;
-String m_sModule;
+OUStringm_sName;
+OUStringm_sModule;
boolm_bUsePrtMetrics;
boolm_bAddSpacing;
boolm_bAddSpacingAtPages;
@@ -63,7 +63,7 @@ struct CompatibilityItem
boolm_bIsDefault;
boolm_bIsUser;
-CompatibilityItem( const String _rName, const String _rModule,
+CompatibilityItem( const OUString _rName, const OUString _rModule,
bool _bUsePrtMetrics, bool _bAddSpacing, bool
_bAddSpacingAtPages,
bool _bUseOurTabStops, bool _bNoExtLeading, bool
_bUseLineSpacing,
bool _bAddTableSpacing, bool _bUseObjPos, bool
_bUseOurTextWrapping,
@@ -112,7 +112,7 @@ SwCompatibilityOptPage::SwCompatibilityOptPage(Window*
pParent, const SfxItemSet
for (sal_uInt16 nId = COPT_USE_PRINTERDEVICE; nId =
COPT_EXPAND_WORDSPACE; ++nId)
{
-String sEntry = m_pFormattingLB-GetEntry(nId);
+OUString sEntry = m_pFormattingLB-GetEntry(nId);
if ( COPT_USE_OUR_TABSTOPS == nId ||
COPT_USE_LINESPACING == nId ||
COPT_USE_OBJECTPOSITIONING == nId ||
@@ -143,20 +143,18 @@ SwCompatibilityOptPage::~SwCompatibilityOptPage()
delete m_pImpl;
}
-void SwCompatibilityOptPage::ReplaceFormatName( String rEntry )
+void SwCompatibilityOptPage::ReplaceFormatName( OUString rEntry )
{
OUString sFormatName(utl::ConfigManager::getProductName());
-OUString sFormatVersion;
-bool bOpenOffice = ( sFormatName == OpenOffice.org );
-if ( bOpenOffice )
-sFormatVersion = OUString(1.1);
-else
-sFormatVersion = OUString(6.0/7);
+const bool bOpenOffice = ( sFormatName == OpenOffice.org );
+const OUString sFormatVersion = bOpenOffice
+? OUString(1.1)
+: OUString(6.0/7);
if ( !bOpenOffice ( sFormatName != StarSuite ) )
-sFormatName = OUString(StarOffice);
+sFormatName = StarOffice;
-rEntry.SearchAndReplace( OUString(%FORMATNAME), sFormatName );
-rEntry.SearchAndReplace( OUString(%FORMATVERSION), sFormatVersion );
+rEntry = rEntry.replaceFirst( %FORMATNAME, sFormatName )
+ .replaceFirst( %FORMATVERSION, sFormatVersion );
}
sal_uLong convertBools2Ulong_Impl
@@ -216,7 +214,7 @@ sal_uLong convertBools2Ulong_Impl
void SwCompatibilityOptPage::InitControls( const SfxItemSet rSet )
{
// init objectshell and detect document name
-String sDocTitle;
+OUString sDocTitle;
const SfxPoolItem* pItem = NULL;
SfxObjectShell* pObjShell = NULL;
if ( SFX_ITEM_SET == rSet.GetItemState( FN_PARAM_WRTSHELL, sal_False,
pItem ) )
@@ -252,7 +250,6 @@ void SwCompatibilityOptPage::InitControls( const
SfxItemSet rSet )
int i, j, nCount = aList.getLength();
for ( i = 0; i nCount; ++i )
{
-String sNewEntry;
const Sequence PropertyValue rEntry = aList[i];
for ( j = 0; j rEntry.getLength(); j++ )
{
@@ -297,6 +294,7 @@ void SwCompatibilityOptPage::InitControls( const
SfxItemSet rSet )
if ( aItem.m_bIsDefault )
continue;
+OUString sNewEntry;
if ( sName.equals( USER_ENTRY ) )
sNewEntry = m_sUserEntry;
else if ( pObjShell !sName.isEmpty() )
@@ -307,7 +305,7 @@ void SwCompatibilityOptPage::InitControls( const
SfxItemSet rSet )
sNewEntry = pFilter-GetUIName();
}
-if ( sNewEntry.Len() == 0 )
+if ( sNewEntry.isEmpty() )
sNewEntry = sName;
sal_uInt16 nPos = m_pFormattingLB-InsertEntry( sNewEntry );
diff --git a/sw/source/ui/inc/optcomp.hxx b/sw/source/ui/inc/optcomp.hxx
index c6fd91c..fd9f127 100644
--- a/sw/source/ui/inc/optcomp.hxx
+++ b/sw/source/ui/inc/optcomp.hxx
@@ -25,6 +25,7 @@
#include vcl/lstbox.hxx
#include unotools/compatibility.hxx
#include svx/checklbx.hxx
+#include rtl/ustring.hxx
// class SwCompatibilityOptPage --
class SwWrtShell;
@@ -41,7 +42,7 @@ private:
// config item
SvtCompatibilityOptions m_aConfigItem;
// text of the user
[Libreoffice-commits] core.git: sw/source
sw/source/ui/inc/glossary.hxx | 26
sw/source/ui/misc/glossary.cxx | 129 +++--
2 files changed, 75 insertions(+), 80 deletions(-)
New commits:
commit 233c387f8962a35c8e7a85f58cf6fe4a269dee98
Author: Matteo Casalin matteo.casa...@yahoo.com
Date: Sun Sep 22 02:10:24 2013 +0200
String to OUString
Change-Id: If5569249cc4fd5de99fdf634af1c338d02ddb84b
Reviewed-on: https://gerrit.libreoffice.org/6027
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/source/ui/inc/glossary.hxx b/sw/source/ui/inc/glossary.hxx
index cb3a8b4..c08f81c 100644
--- a/sw/source/ui/inc/glossary.hxx
+++ b/sw/source/ui/inc/glossary.hxx
@@ -38,6 +38,8 @@
#include com/sun/star/container/XIndexAccess.hpp
#include com/sun/star/text/XAutoTextContainer2.hpp
+#include rtl/ustring.hxx
+
#include actctrl.hxx
class SwGlossaryHdl;
@@ -53,7 +55,7 @@ const short RET_EDIT = 100;
class SwGlTreeListBox : public SvTreeListBox
{
-const StringsReadonly;
+const OUStringsReadonly;
SvTreeListEntry* pDragEntry;
@@ -103,15 +105,15 @@ class SwGlossaryDlg : public SvxStandardDialog
PushButton* m_pBibBtn;
PushButton* m_pPathBtn;
-String sReadonlyPath;
+OUStringsReadonlyPath;
::com::sun::star::uno::Reference
::com::sun::star::text::XAutoTextContainer2 m_xAutoText;
SwOneExampleFrame* pExampleFrame;
SwGlossaryHdl* pGlossaryHdl;
-String sResumeGroup;
-String sResumeShortName;
+OUStringsResumeGroup;
+OUStringsResumeShortName;
sal_BoolbResume;
@@ -140,30 +142,30 @@ class SwGlossaryDlg : public SvxStandardDialog
virtual voidApply();
voidInit();
-SvTreeListEntry*DoesBlockExist(const String sBlock, const String
rShort);
-voidShowAutoText(const String rGroup, const String
rShortName);
+SvTreeListEntry*DoesBlockExist(const OUString sBlock, const OUString
rShort);
+voidShowAutoText(const OUString rGroup, const OUString
rShortName);
voidResumeShowAutoText();
-sal_BoolGetResumeData(String rGroup, String rShortName)
+sal_BoolGetResumeData(OUString rGroup, OUString rShortName)
{rGroup = sResumeGroup; rShortName = sResumeShortName;
return bResume;}
-voidSetResumeData(const String rGroup, const String
rShortName)
+voidSetResumeData(const OUString rGroup, const OUString
rShortName)
{sResumeGroup = rGroup; sResumeShortName = rShortName;
bResume = sal_True;}
voidResetResumeData() {bResume = sal_False;}
public:
SwGlossaryDlg(SfxViewFrame* pViewFrame, SwGlossaryHdl* pGlosHdl,
SwWrtShell *pWrtShell);
~SwGlossaryDlg();
-String GetCurrGrpName() const;
-String GetCurrLongName() const
+OUString GetCurrGrpName() const;
+OUString GetCurrLongName() const
{
return m_pNameED-GetText();
}
-String GetCurrShortName() const
+OUString GetCurrShortName() const
{
return m_pShortNameEdit-GetText();
}
static OUString GetCurrGroup();
static void SetActGroup(const OUString rNewGroup);
-static String GetExtension();
+static OUString GetExtension();
};
#endif
diff --git a/sw/source/ui/misc/glossary.cxx b/sw/source/ui/misc/glossary.cxx
index 4945b88..d92 100644
--- a/sw/source/ui/misc/glossary.cxx
+++ b/sw/source/ui/misc/glossary.cxx
@@ -78,23 +78,23 @@ using namespace ::com::sun::star::ui::dialogs;
using namespace ::ucbhelper;
using namespace ::sfx2;
-static String lcl_GetValidShortCut( const String rName )
+static OUString lcl_GetValidShortCut( const OUString rName )
{
-const sal_uInt16 nSz = rName.Len();
+const sal_Int32 nSz = rName.getLength();
if ( 0 == nSz )
return rName;
-sal_uInt16 nStart = 1;
-while( rName.GetChar( nStart-1 ) == ' ' nStart nSz )
+sal_Int32 nStart = 1;
+while( rName[nStart-1]==' ' nStart nSz )
nStart++;
-String aBuf = OUString(rName.GetChar(nStart-1));
+OUString aBuf = OUString(rName[nStart-1]);
for( ; nStart nSz; ++nStart )
{
-if( rName.GetChar( nStart-1 ) == ' ' rName.GetChar( nStart ) != ' ')
-aBuf += rName.GetChar( nStart );
+if( rName[nStart-1]==' ' rName[nStart]!=' ')
+aBuf += OUString(rName[nStart]);
}
return aBuf;
}
@@ -258,7 +258,7 @@ IMPL_LINK( SwGlossaryDlg, GrpSelect, SvTreeListBox *, pBox )
{
OUString aName(pBox-GetEntryText(pEntry));
m_pNameED-SetText(aName);
-m_pShortNameEdit-SetText(*(String*)pEntry-GetUserData());
+
m_pShortNameEdit-SetText(*reinterpret_castOUString*(pEntry-GetUserData()));
pEntry = pBox-GetParent(pEntry);
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/swabstdlg.hxx |2 +-
sw/source/ui/dialog/swdlgfact.cxx|2 +-
sw/source/ui/dialog/swdlgfact.hxx|2 +-
sw/source/ui/inc/mailmergewizard.hxx | 27 ++-
4 files changed, 17 insertions(+), 16 deletions(-)
New commits:
commit 1ebe1d6d26857f492281fa8c2467bbb5c95c2c91
Author: Matteo Casalin matteo.casa...@yahoo.com
Date: Mon Sep 23 14:57:37 2013 +0200
String to OUString
Change-Id: I510de30ca31db0d0a6615ef500e7d03a648ca609
Reviewed-on: https://gerrit.libreoffice.org/6028
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index cc8baed..2e03953 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -311,7 +311,7 @@ class AbstractMailMergeWizard : public VclAbstractDialog2
{
public:
virtual voidSetReloadDocument(const OUString rURL) = 0;
-virtual const OUString GetReloadDocument() const = 0;
+virtual OUStringGetReloadDocument() const = 0;
virtual sal_BoolShowPage( sal_uInt16 nLevel ) = 0;
virtual sal_uInt16 GetRestartPage() const = 0;
};
diff --git a/sw/source/ui/dialog/swdlgfact.cxx
b/sw/source/ui/dialog/swdlgfact.cxx
index e8c0b88..eb6722e 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -620,7 +620,7 @@ void AbstractMailMergeWizard_Impl::SetReloadDocument(const
OUString rURL)
pDlg-SetReloadDocument(rURL);
}
-const OUString AbstractMailMergeWizard_Impl::GetReloadDocument() const
+OUString AbstractMailMergeWizard_Impl::GetReloadDocument() const
{
return pDlg-GetReloadDocument();
}
diff --git a/sw/source/ui/dialog/swdlgfact.hxx
b/sw/source/ui/dialog/swdlgfact.hxx
index 342d81b..8f3dd72 100644
--- a/sw/source/ui/dialog/swdlgfact.hxx
+++ b/sw/source/ui/dialog/swdlgfact.hxx
@@ -362,7 +362,7 @@ public:
virtual longGetResult();
virtual voidSetReloadDocument(const OUString rURL);
-virtual const OUString GetReloadDocument() const;
+virtual OUStringGetReloadDocument() const;
virtual sal_BoolShowPage( sal_uInt16 nLevel );
virtual sal_uInt16 GetRestartPage() const;
};
diff --git a/sw/source/ui/inc/mailmergewizard.hxx
b/sw/source/ui/inc/mailmergewizard.hxx
index 95015bb..b46d653 100644
--- a/sw/source/ui/inc/mailmergewizard.hxx
+++ b/sw/source/ui/inc/mailmergewizard.hxx
@@ -20,6 +20,7 @@
#define _MAILMERGEWIZARD_HXX
#include svtools/roadmapwizard.hxx
+#include rtl/ustring.hxx
class SwView;
class SwMailMergeConfigItem;
@@ -41,16 +42,16 @@ class SwMailMergeWizard : public ::svt::RoadmapWizard
SwMailMergeConfigItem m_rConfigItem;
-String m_sStarting;
-String m_sDocumentType;
-String m_sAddressBlock;
-String m_sAddressList;
-String m_sGreetingsLine;
-String m_sLayout;
-String m_sPrepareMerge;
-String m_sMerge;
-String m_sOutput;
-String m_sFinish;
+OUStringm_sStarting;
+OUStringm_sDocumentType;
+OUStringm_sAddressBlock;
+OUStringm_sAddressList;
+OUStringm_sGreetingsLine;
+OUStringm_sLayout;
+OUStringm_sPrepareMerge;
+OUStringm_sMerge;
+OUStringm_sOutput;
+OUStringm_sFinish;
sal_uInt16 m_nRestartPage;
@@ -71,8 +72,8 @@ public:
SwView* GetSwView() {return m_pSwView;}
SwMailMergeConfigItem GetConfigItem() { return m_rConfigItem;}
-voidSetReloadDocument(const String rURL){sDocumentURL
= rURL;}
-const OUString GetReloadDocument() const {return sDocumentURL;}
+voidSetReloadDocument(const OUString rURL)
{sDocumentURL = rURL;}
+OUStringGetReloadDocument() const {return sDocumentURL;}
//next step requires loading of document
voidSetDocumentLoad(bool bSet) {m_bDocumentLoad =
bSet;}
@@ -88,7 +89,7 @@ public:
voidupdateRoadmapItemLabel( WizardState _nState );
- virtual short Execute();
+virtual short Execute();
virtual voidStartExecuteModal( const Link rEndDialogHdl );
};
#endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: l10ntools/source
l10ntools/source/pocheck.cxx | 73 ++-
1 file changed, 32 insertions(+), 41 deletions(-)
New commits:
commit 7924a77ef62e20d84963b5925fa738f9e711959e
Author: Matteo Casalin matteo.casa...@yahoo.com
Date: Mon Sep 23 18:53:14 2013 +0200
Fix memory leaks
Change-Id: I21662cb52c51332700e1021ae55d92cb46ccc15a
Reviewed-on: https://gerrit.libreoffice.org/6029
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/l10ntools/source/pocheck.cxx b/l10ntools/source/pocheck.cxx
index a7c16e4..74c8ce1 100644
--- a/l10ntools/source/pocheck.cxx
+++ b/l10ntools/source/pocheck.cxx
@@ -21,7 +21,7 @@ static void checkStyleNames(OString aLanguage)
{
std::mapOString,sal_uInt16 aLocalizedStyleNames;
std::mapOString,sal_uInt16 aLocalizedNumStyleNames;
-std::listPoEntry* repeatedEntries;
+std::listPoEntry repeatedEntries;
OString aPoPath = OString(getenv(SRC_ROOT)) +
/translations/source/ +
@@ -33,19 +33,18 @@ static void checkStyleNames(OString aLanguage)
for(;;)
{
-PoEntry* pPoEntry = new PoEntry();
-aPoInput.readEntry(*pPoEntry);
+PoEntry aPoEntry;
+aPoInput.readEntry(aPoEntry);
bool bRepeated = false;
if( aPoInput.eof() )
{
-delete pPoEntry;
break;
}
-if( !pPoEntry-isFuzzy() pPoEntry-getSourceFile() == poolfmt.src
-pPoEntry-getGroupId().startsWith(STR_POOLCOLL) )
+if( !aPoEntry.isFuzzy() aPoEntry.getSourceFile() == poolfmt.src
+aPoEntry.getGroupId().startsWith(STR_POOLCOLL) )
{
-OString aMsgStr = pPoEntry-getMsgStr();
+OString aMsgStr = aPoEntry.getMsgStr();
if( aMsgStr.isEmpty() )
continue;
if( aLocalizedStyleNames.find(aMsgStr) ==
aLocalizedStyleNames.end() )
@@ -55,10 +54,10 @@ static void checkStyleNames(OString aLanguage)
bRepeated = true;
}
}
-if( !pPoEntry-isFuzzy() pPoEntry-getSourceFile() == poolfmt.src
-pPoEntry-getGroupId().startsWith(STR_POOLNUMRULE) )
+if( !aPoEntry.isFuzzy() aPoEntry.getSourceFile() == poolfmt.src
+aPoEntry.getGroupId().startsWith(STR_POOLNUMRULE) )
{
-OString aMsgStr = pPoEntry-getMsgStr();
+OString aMsgStr = aPoEntry.getMsgStr();
if( aMsgStr.isEmpty() )
continue;
if( aLocalizedNumStyleNames.find(aMsgStr) ==
aLocalizedNumStyleNames.end() )
@@ -69,10 +68,7 @@ static void checkStyleNames(OString aLanguage)
}
}
if (bRepeated)
-repeatedEntries.push_back(pPoEntry);
- else
-delete pPoEntry;
-
+repeatedEntries.push_back(aPoEntry);
}
aPoInput.close();
@@ -110,8 +106,8 @@ static void checkStyleNames(OString aLanguage)
aPoInput.readEntry(aPoEntry);
if( aPoInput.eof() )
break;
-for ( std::listPoEntry*::iterator it=repeatedEntries.begin();
it!=repeatedEntries.end(); ++it) {
-if ((*it)-getMsgId() == aPoEntry.getMsgId()
(*it)-getGroupId() == aPoEntry.getGroupId()) {
+for ( std::listPoEntry::iterator it=repeatedEntries.begin();
it!=repeatedEntries.end(); ++it) {
+if (it-getMsgId() == aPoEntry.getMsgId() it-getGroupId() ==
aPoEntry.getGroupId()) {
bError = true;
break;
}
@@ -139,7 +135,7 @@ static void checkFunctionNames(OString aLanguage)
std::mapOString,sal_uInt16 aLocalizedFunctionNames;
std::mapOString,sal_uInt16 aLocalizedCoreFunctionNames;
//
-std::listPoEntry* repeatedEntries;
+std::listPoEntry repeatedEntries;
OString aPoPaths[4];
OUString aPoPathURL;
@@ -155,20 +151,19 @@ static void checkFunctionNames(OString aLanguage)
for(;;)
{
-PoEntry* aPoEntry = new PoEntry();
-aPoInput.readEntry(*aPoEntry);
+PoEntry aPoEntry;
+aPoInput.readEntry(aPoEntry);
if( aPoInput.eof() )
break;
-if( !aPoEntry-isFuzzy() aPoEntry-getGroupId() ==
RID_STRLIST_FUNCTION_NAMES )
+if( !aPoEntry.isFuzzy() aPoEntry.getGroupId() ==
RID_STRLIST_FUNCTION_NAMES )
{
-OString aMsgStr = aPoEntry-getMsgStr();
+OString aMsgStr = aPoEntry.getMsgStr();
if( aMsgStr.isEmpty() )
continue;
if( aLocalizedCoreFunctionNames.find(aMsgStr) ==
aLocalizedCoreFunctionNames.end() )
aLocalizedCoreFunctionNames[aMsgStr] = 1;
if( aLocalizedFunctionNames.find(aMsgStr) ==
aLocalizedFunctionNames.end() ) {
aLocalizedFunctionNames[aMsgStr] = 1;
-delete aPoEntry;
} else {
aLocalizedFunctionNames[aMsgStr]++;
[Libreoffice-commits] core.git: sw/source
sw/source/ui/dbui/mailmergehelper.cxx | 19 ---
sw/source/ui/dbui/mmoutputpage.cxx| 25 -
sw/source/ui/envelp/mailmrge.cxx | 11 +--
sw/source/ui/inc/mailmergehelper.hxx |3 ++-
4 files changed, 27 insertions(+), 31 deletions(-)
New commits:
commit 1e3e64aae4014821e9cee4d4b856a5c29550d421
Author: Matteo Casalin matteo.casa...@yahoo.com
Date: Tue Sep 24 12:45:50 2013 +0200
String to OUString
Change-Id: I9e99c88be67a3cfa97b5d964075c77c3208136f6
Reviewed-on: https://gerrit.libreoffice.org/6031
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/source/ui/dbui/mailmergehelper.cxx
b/sw/source/ui/dbui/mailmergehelper.cxx
index f6f9a89..7445bf9 100644
--- a/sw/source/ui/dbui/mailmergehelper.cxx
+++ b/sw/source/ui/dbui/mailmergehelper.cxx
@@ -51,23 +51,20 @@ using namespace ::com::sun::star::sdbcx;
namespace SwMailMergeHelper
{
-String CallSaveAsDialog(String rFilter)
+OUString CallSaveAsDialog(OUString rFilter)
{
-ErrCode nRet;
-String
sFactory(OUString::createFromAscii(SwDocShell::Factory().GetShortName()));
::sfx2::FileDialogHelper aDialog(
ui::dialogs::TemplateDescription::FILESAVE_AUTOEXTENSION,
0,
-sFactory );
+
OUString::createFromAscii(SwDocShell::Factory().GetShortName()) );
-String sRet;
-nRet = aDialog.Execute();
-if(ERRCODE_NONE == nRet)
+if (aDialog.Execute()!=ERRCODE_NONE)
{
-uno::Reference ui::dialogs::XFilePicker xFP =
aDialog.GetFilePicker();
-sRet = xFP-getFiles().getConstArray()[0];
-rFilter = aDialog.GetRealFilter();
+return OUString();
}
-return sRet;
+
+rFilter = aDialog.GetRealFilter();
+uno::Reference ui::dialogs::XFilePicker xFP = aDialog.GetFilePicker();
+return xFP-getFiles().getConstArray()[0];
}
/*
diff --git a/sw/source/ui/dbui/mmoutputpage.cxx
b/sw/source/ui/dbui/mmoutputpage.cxx
index 668969f..da72f2d 100644
--- a/sw/source/ui/dbui/mmoutputpage.cxx
+++ b/sw/source/ui/dbui/mmoutputpage.cxx
@@ -600,14 +600,14 @@ IMPL_LINK(SwMailMergeOutputPage, SaveOutputHdl_Impl,
PushButton*, pButton)
if(m_aSaveAsOneRB.IsChecked())
{
-String sFilter;
-String sPath = SwMailMergeHelper::CallSaveAsDialog(sFilter);
-if(!sPath.Len())
+OUString sFilter;
+const OUString sPath = SwMailMergeHelper::CallSaveAsDialog(sFilter);
+if (sPath.isEmpty())
return 0;
uno::Sequence beans::PropertyValue aValues(1);
beans::PropertyValue* pValues = aValues.getArray();
pValues[0].Name = FilterName;
-pValues[0].Value = OUString(sFilter);
+pValues[0].Value = sFilter;
uno::Reference frame::XStorable xStore(
pTargetView-GetDocShell()-GetModel(), uno::UNO_QUERY);
sal_uInt32 nErrorCode = ERRCODE_NONE;
@@ -645,9 +645,9 @@ IMPL_LINK(SwMailMergeOutputPage, SaveOutputHdl_Impl,
PushButton*, pButton)
if(nEnd rConfigItem.GetMergedDocumentCount())
nEnd = rConfigItem.GetMergedDocumentCount();
}
-String sFilter;
-String sPath = SwMailMergeHelper::CallSaveAsDialog(sFilter);
-if(!sPath.Len())
+OUString sFilter;
+OUString sPath = SwMailMergeHelper::CallSaveAsDialog(sFilter);
+if (sPath.isEmpty())
return 0;
String sTargetTempURL = URIHelper::SmartRel2Abs(
INetURLObject(), utl::TempFile::CreateTempName(),
@@ -694,12 +694,11 @@ IMPL_LINK(SwMailMergeOutputPage, SaveOutputHdl_Impl,
PushButton*, pButton)
{
SwDocMergeInfo rInfo = rConfigItem.GetDocumentMergeInfo(nDoc);
INetURLObject aURL(sPath);
-String sExtension = aURL.getExtension();
-if(!sExtension.Len())
+OUString sExtension = aURL.getExtension();
+if (sExtension.isEmpty())
{
sExtension =
comphelper::string::getToken(pSfxFlt-GetWildcard().getGlob(), 1, '.');
-sPath += '.';
-sPath += sExtension;
+sPath += . + sExtension;
}
String sStat(SW_RES(STR_STATSTR_LETTER));
sStat += ' ';
@@ -729,7 +728,7 @@ IMPL_LINK(SwMailMergeOutputPage, SaveOutputHdl_Impl,
PushButton*, pButton)
String sOutPath = aURL.GetMainURL(INetURLObject::DECODE_TO_IURI);
String sCounter = OUString('_');
sCounter += OUString::number(nDoc);
-sOutPath.Insert(sCounter, sOutPath.Len() - sExtension.Len() - 1);
+sOutPath.Insert(sCounter, sOutPath.Len() - sExtension.getLength()
- 1);
while(true)
{
@@ -739,7 +738,7 @@ IMPL_LINK(SwMailMergeOutputPage, SaveOutputHdl_Impl,
PushButton*, pButton)
bool bFailed = false;
try
{
-
[Libreoffice-commits] core.git: sw/source
sw/source/ui/config/optcomp.cxx |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
New commits:
commit e8c0a9ab7458d66b3ef015b40996b426f5e5b58a
Author: Matteo Casalin matteo.casa...@yahoo.com
Date: Wed Sep 18 01:10:46 2013 +0200
Reduce scope of some local variables
Change-Id: I36cedb18a00dfdee1058823fd2461ad45bc886e3
Reviewed-on: https://gerrit.libreoffice.org/6026
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/source/ui/config/optcomp.cxx b/sw/source/ui/config/optcomp.cxx
index 5a52f5f..d6029e4 100644
--- a/sw/source/ui/config/optcomp.cxx
+++ b/sw/source/ui/config/optcomp.cxx
@@ -247,11 +247,12 @@ void SwCompatibilityOptPage::InitControls( const
SfxItemSet rSet )
bool bUseOurTextWrapping = false;
bool bConsiderWrappingStyle = false;
bool bExpandWordSpace = false;
-int i, j, nCount = aList.getLength();
-for ( i = 0; i nCount; ++i )
+const sal_Int32 nCount = aList.getLength();
+for ( sal_Int32 i = 0; i nCount; ++i )
{
const Sequence PropertyValue rEntry = aList[i];
-for ( j = 0; j rEntry.getLength(); j++ )
+const sal_Int32 nEntries = rEntry.getLength();
+for ( sal_Int32 j = 0; j nEntries; j++ )
{
PropertyValue aValue = rEntry[j];
if ( aValue.Name == COMPATIBILITY_PROPERTYNAME_NAME )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - ucb/source vcl/unx
ucb/source/ucp/gio/gio_content.cxx |5 -
vcl/unx/gtk/app/gtkinst.cxx| 34 ++
2 files changed, 14 insertions(+), 25 deletions(-)
New commits:
commit ca4ee400edcb9d077a094f0286861a884c9bc97a
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Sep 26 09:35:34 2013 +0200
Improve debug output
Change-Id: I10a9c3679ae2d6ca8183b68b60b52e91ecd8f91f
diff --git a/ucb/source/ucp/gio/gio_content.cxx
b/ucb/source/ucp/gio/gio_content.cxx
index ac5ba3a..8621782 100644
--- a/ucb/source/ucp/gio/gio_content.cxx
+++ b/ucb/source/ucp/gio/gio_content.cxx
@@ -363,7 +363,10 @@ GFileInfo* Content::getGFileInfo(const uno::Reference
ucb::XCommandEnvironment
if (ppError != 0) {
*ppError = err;
} else if (err != 0) {
-SAL_WARN(ucb.ucp.gio, ignoring GError \ err-message \);
+SAL_WARN(
+ucb.ucp.gio,
+ignoring GError \ err-message \ for
+ m_xIdentifier-getContentIdentifier() );
g_error_free(err);
}
return mpInfo;
commit 8802d376686e142f6e07893e3c5a2f5650c31fe5
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Sep 26 09:34:52 2013 +0200
fprintf - sal/log.hxx
Change-Id: Ic9962abc8ac8e9992fc26136eb3693e146d38c63
diff --git a/vcl/unx/gtk/app/gtkinst.cxx b/vcl/unx/gtk/app/gtkinst.cxx
index 115550b..dbbcbd1 100644
--- a/vcl/unx/gtk/app/gtkinst.cxx
+++ b/vcl/unx/gtk/app/gtkinst.cxx
@@ -38,10 +38,6 @@
#include rtl/uri.hxx
-#if OSL_DEBUG_LEVEL 1
-#include stdio.h
-#endif
-
#include dlfcn.h
#include fcntl.h
#include unistd.h
@@ -64,11 +60,10 @@ extern C
VCLPLUG_GTK_PUBLIC SalInstance* create_SalInstance( oslModule )
{
-#if OSL_DEBUG_LEVEL 1
-fprintf( stderr, create vcl plugin instance with gtk version %d %d
%d\n,
- (int) gtk_major_version, (int) gtk_minor_version,
- (int) gtk_micro_version );
-#endif
+SAL_INFO(
+vcl.gtk,
+create vcl plugin instance with gtk version gtk_major_version
+gtk_minor_version gtk_micro_version);
if( gtk_major_version 2 || // very unlikely sanity check
( gtk_major_version == 2 gtk_minor_version 4 ) )
{
@@ -93,9 +88,7 @@ extern C
#endif
if( pVersion )
{
-#if OSL_DEBUG_LEVEL 1
-fprintf( stderr, gtk version conflict: %s\n, pVersion );
-#endif
+SAL_WARN(vcl.gtk, gtk version conflict: pVersion);
return NULL;
}
@@ -109,19 +102,14 @@ extern C
#error Requires gtk 2.4.0+ for lock hooking
#endif
gdk_threads_set_lock_functions (GdkThreadsEnter, GdkThreadsLeave);
-
-#if OSL_DEBUG_LEVEL 1
-fprintf( stderr, Hooked gdk threads locks\n );
-#endif
+SAL_INFO(vcl.gtk, Hooked gdk threads locks);
pYieldMutex = new GtkYieldMutex();
gdk_threads_init();
GtkInstance* pInstance = new GtkInstance( pYieldMutex );
-#if OSL_DEBUG_LEVEL 1
-fprintf( stderr, creating GtkSalInstance 0x%p\n, pInstance );
-#endif
+SAL_INFO(vcl.gtk, creating GtkSalInstance pInstance);
//Create SalData, this does not leak
/*GtkData *pSalData =*/ new GtkData( pInstance );
@@ -342,11 +330,9 @@ void GtkYieldMutex::ThreadsLeave()
{
aYieldStack.push_front( mnCount );
-#if OSL_DEBUG_LEVEL 1
-if( mnThreadId
-mnThreadId != osl::Thread::getCurrentIdentifier())
-fprintf( stderr, \n\n--- A different thread owns the mutex
...---\n\n\n);
-#endif
+SAL_WARN_IF(
+mnThreadId mnThreadId != osl::Thread::getCurrentIdentifier(),
+vcl.gtk, other thread mnThreadId owns the mutex);
while( mnCount 1 )
release();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/source
framework/source/loadenv/loadenv.cxx | 74 +--
1 file changed, 37 insertions(+), 37 deletions(-)
New commits:
commit a1bc57563f659579e889f279d7f63a9fb487dcb2
Author: Jesús Corrius jcorr...@gmail.com
Date: Thu Sep 26 10:02:26 2013 +0200
Some spellchecker love in the comments
Change-Id: I88dee4ae25ac57a78b72fa020b76e0d9b7709b31
diff --git a/framework/source/loadenv/loadenv.cxx
b/framework/source/loadenv/loadenv.cxx
index 1767133..0346412 100644
--- a/framework/source/loadenv/loadenv.cxx
+++ b/framework/source/loadenv/loadenv.cxx
@@ -257,7 +257,7 @@ void LoadEnv::initializeLoading(const OUString
// try to find out, if its really a content, which can be loaded or must
be handled
// We use a default value for this in-parameter. Then we have to start a
complex check method
-// internally. But if this check was already done outside it can be
supressed to perform
+// internally. But if this check was already done outside it can be
suppressed to perform
// the load request. We take over the result then!
if (m_eContentType == E_UNSUPPORTED_CONTENT)
{
@@ -286,9 +286,9 @@ void LoadEnv::initializeLoading(const OUString
if (pIt != m_lMediaDescriptor.end())
m_lMediaDescriptor.erase(pIt);
-// patch the MediaDescriptor, so it fullfill the outside requirements
+// patch the MediaDescriptor, so it fulfil the outside requirements
// Means especially items like e.g. UI InteractionHandler, Status
Indicator,
-// MacroExecutionMode etcpp.
+// MacroExecutionMode, etc.
/*TODO progress is bound to a frame ... How can we set it here? */
@@ -376,7 +376,7 @@ void LoadEnv::startLoading()
// - SAFE
aReadLock.unlock();
-// detect its type/filter etcpp.
+// detect its type/filter etc.
// These information will be available by the
// used descriptor member afterwards and is needed
// for all following operations!
@@ -385,8 +385,8 @@ void LoadEnv::startLoading()
impl_detectTypeAndFilter();
// start loading the content ...
-// Attention: Dont check m_eContentType deeper then UNSUPPORTED/SUPPORTED!
-// Because it was made in th easiest way ... may a flat detection was made
only.
+// Attention: Don't check m_eContentType deeper then UNSUPPORTED/SUPPORTED!
+// Because it was made in the easiest way ... may a flat detection was
made only.
// And such simple detection can fail some times .-)
// Use another strategy here. Try it and let it run into the case loading
not possible.
sal_Bool bStarted = sal_False;
@@ -417,7 +417,7 @@ sal_Bool LoadEnv::waitWhileLoading(sal_uInt32 nTimeout)
// Because its not a good idea to block the main thread
// (and we can't be sure that we are currently not used inside the
// main thread!), we can't use conditions here really. We must yield
-// in an intellegent manner :-)
+// in an intelligent manner :-)
sal_Int32 nTime = nTimeout;
while(true)
@@ -706,7 +706,7 @@ LoadEnv::EContentType LoadEnv::classifyContent(const
OUString
//---
// (TODO) At this point, we have no idea .-)
//But it seems to be better, to break all
-//further requests for this URL. Otherwhise
+//further requests for this URL. Otherwise
//we can run into some trouble.
return E_UNSUPPORTED_CONTENT;
}
@@ -801,7 +801,7 @@ void LoadEnv::impl_detectTypeAndFilter()
ReadGuard aReadLock(m_aLock);
// Attention: Because our stl media descriptor is a copy of an uno sequence
-// we can't use as an in/out parameter here. Copy it before and dont
forget to
+// we can't use as an in/out parameter here. Copy it before and don't
forget to
// update structure afterwards again!
css::uno::Sequence css::beans::PropertyValue lDescriptor =
m_lMediaDescriptor.getAsConstPropertyValueList();
css::uno::Reference css::uno::XComponentContext xContext =
m_xContext;
@@ -845,8 +845,8 @@ void LoadEnv::impl_detectTypeAndFilter()
aWriteLock.unlock();
// - SAFE
-// But the type isnt enough. For loading sometimes we need more
information.
-// E.g. for our _default feature, where we recylce any frame which
contains
+// But the type isn't enough. For loading sometimes we need more
information.
+// E.g. for our _default feature, where we recycle any frame which
contains
// and Untitled document, we must know if the new document is based on a
template!
// But this information is available as a filter property only.
// = We must try(!) to detect the right filter for this load request.
@@ -855,7 +855,7 @@ void LoadEnv::impl_detectTypeAndFilter()
if (sFilter.isEmpty())
{
// no - try to find a preferred filter for the detected type.
-// Dont forget to updatet he media descriptor.
+// Don't forget to
[Libreoffice-commits] core.git: framework/inc framework/source include/salhelper include/svtools
framework/inc/classes/checkediterator.hxx |2 +- framework/inc/classes/filtercachedata.hxx |2 +- framework/inc/classes/framecontainer.hxx |2 +- framework/inc/dispatch/closedispatcher.hxx |4 ++-- framework/inc/helper/propertysetcontainer.hxx |2 +- framework/inc/helper/statusindicatorfactory.hxx|2 +- framework/inc/helper/vclstatusindicator.hxx|2 +- framework/inc/recording/dispatchrecorder.hxx |2 +- framework/inc/services/autorecovery.hxx|2 +- framework/inc/services/desktop.hxx |2 +- framework/inc/services/layoutmanager.hxx |2 +- framework/inc/services/license.hxx |2 +- framework/inc/services/substitutepathvars.hxx |2 +- framework/inc/services/tabwindowservice.hxx|2 +- framework/inc/uiconfiguration/globalsettings.hxx |2 +- framework/inc/uiconfiguration/imagemanager.hxx |2 +- framework/inc/uiconfiguration/moduleimagemanager.hxx |2 +- framework/inc/uiconfiguration/moduleuicfgsupplier.hxx |2 +- framework/inc/uiconfiguration/moduleuiconfigurationmanager.hxx |2 +- framework/inc/uiconfiguration/uicategorydescription.hxx|2 +- framework/inc/uiconfiguration/uiconfigurationmanager.hxx |2 +- framework/inc/uiconfiguration/windowstateconfiguration.hxx |2 +- framework/inc/uielement/menubarmanager.hxx |2 +- framework/inc/uielement/uicommanddescription.hxx |2 +- framework/inc/uifactory/uielementfactorymanager.hxx|2 +- framework/inc/uifactory/windowcontentfactorymanager.hxx|2 +- framework/source/inc/loadenv/actionlockguard.hxx |2 +- framework/source/inc/loadenv/loadenv.hxx |6 +++--- framework/source/layoutmanager/toolbarlayoutmanager.hxx|2 +- framework/source/uiconfiguration/imagemanagerimpl.hxx |2 +- include/salhelper/singletonref.hxx |8 include/svtools/acceleratorexecute.hxx |2 +- 32 files changed, 38 insertions(+), 38 deletions(-) New commits: commit 6a3cf741d1d4d9e700c14da6d6ae386d3aa372f8 Author: Jesús Corrius jcorr...@gmail.com Date: Thu Sep 26 10:21:12 2013 +0200 Otherwhise - Otherwise Change-Id: Iaec23e1d240f675a04b52cd251c4cb2a1242bb44 diff --git a/framework/inc/classes/checkediterator.hxx b/framework/inc/classes/checkediterator.hxx index 241e1e7..a7e4745 100644 --- a/framework/inc/classes/checkediterator.hxx +++ b/framework/inc/classes/checkediterator.hxx @@ -151,7 +151,7 @@ class CheckedIterator /*-//** @short reset this iterator @descr It must be called on an already initialized iterator. -Means the member m_pContainer must be valid. Otherwhise the reaction +Means the member m_pContainer must be valid. Otherwise the reaction isn't defined. @param - diff --git a/framework/inc/classes/filtercachedata.hxx b/framework/inc/classes/filtercachedata.hxx index 809cc00..d585e49 100644 --- a/framework/inc/classes/filtercachedata.hxx +++ b/framework/inc/classes/filtercachedata.hxx @@ -20,7 +20,7 @@ #ifndef __FRAMEWORK_CLASSES_FILTERCACHEDATA_HXX_ #define __FRAMEWORK_CLASSES_FILTERCACHEDATA_HXX_ -/** Attention: stl headers must(!) be included at first. Otherwhise it can make trouble +/** Attention: stl headers must(!) be included at first. Otherwise it can make trouble with solaris headers ... */ #include boost/unordered_map.hpp diff --git a/framework/inc/classes/framecontainer.hxx b/framework/inc/classes/framecontainer.hxx index 0fddd0f..f388cfa 100644 --- a/framework/inc/classes/framecontainer.hxx +++ b/framework/inc/classes/framecontainer.hxx @@ -20,7 +20,7 @@ #ifndef __FRAMEWORK_CLASSES_FRAMECONTAINER_HXX_ #define __FRAMEWORK_CLASSES_FRAMECONTAINER_HXX_ -/** Attention: stl headers must(!) be included at first. Otherwhise it can make trouble +/** Attention: stl headers must(!) be included at first. Otherwise it can make trouble with solaris headers ... */ #include vector diff --git a/framework/inc/dispatch/closedispatcher.hxx b/framework/inc/dispatch/closedispatcher.hxx index 7bb3ac4..de51671 100644 --- a/framework/inc/dispatch/closedispatcher.hxx +++ b/framework/inc/dispatch/closedispatcher.hxx @@ -182,7 +182,7 @@ class CloseDispatcher : // baseclasses ... order is necessary for right initiali /** @short a callback for
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/breakiterator/breakiterator_unicode.cxx | 29 ++--
1 file changed, 26 insertions(+), 3 deletions(-)
New commits:
commit 968f4d72a23bb28d097a7694d66f0b866b3b33f0
Author: László Németh nem...@numbertext.org
Date: Wed Sep 25 23:46:22 2013 +0200
fdo#56392 fix hyphenation of words with punctuation
Change-Id: I17e094fa93a7ba6a554f4bc2dfd353f718f1a500
Reviewed-on: https://gerrit.libreoffice.org/6040
Reviewed-by: Németh László nem...@numbertext.org
Tested-by: Németh László nem...@numbertext.org
diff --git a/i18npool/source/breakiterator/breakiterator_unicode.cxx
b/i18npool/source/breakiterator/breakiterator_unicode.cxx
index 0e64343..4c08a5f 100644
--- a/i18npool/source/breakiterator/breakiterator_unicode.cxx
+++ b/i18npool/source/breakiterator/breakiterator_unicode.cxx
@@ -373,12 +373,28 @@ LineBreakResults SAL_CALL
BreakIterator_Unicode::getLineBreak(
lbr.breakIndex = nStartPos;
lbr.breakType = BreakType::WORDBOUNDARY;
} else if (hOptions.rHyphenator.is()) { //Hyphenation break
-Boundary wBoundary = getWordBoundary( Text, nStartPos, rLocale,
-WordType::DICTIONARY_WORD, false);
+sal_Int32 boundary_with_punctuation = (line.aBreakIterator-next()
!= BreakIterator::DONE) ? line.aBreakIterator-current() : 0;
+line.aBreakIterator-preceding(nStartPos + 1); // reset to check
correct hyphenation of word-word
+
+sal_Int32 nStartPosWordEnd = nStartPos;
+while (line.aBreakIterator-current() nStartPosWordEnd
u_ispunct((sal_uInt32)Text[nStartPosWordEnd])) // starting punctuation
+nStartPosWordEnd --;
+
+Boundary wBoundary = getWordBoundary( Text, nStartPosWordEnd,
rLocale,
+WordType::DICTIONARY_WORD, false);
+
+nStartPosWordEnd = wBoundary.endPos + 1;
+while (nStartPosWordEnd Text.getLength()
(u_ispunct((sal_uInt32)Text[nStartPosWordEnd]))) // ending punctuation
+nStartPosWordEnd ++;
+nStartPosWordEnd = nStartPosWordEnd - wBoundary.endPos - 1;
+if (hOptions.hyphenIndex - wBoundary.startPos nStartPosWordEnd)
nStartPosWordEnd = hOptions.hyphenIndex - wBoundary.startPos;
+#define SPACE 0x0020
+while (boundary_with_punctuation wBoundary.endPos
Text[--boundary_with_punctuation] == SPACE);
+if (boundary_with_punctuation != 0) boundary_with_punctuation += 1
- wBoundary.endPos;
uno::Reference linguistic2::XHyphenatedWord aHyphenatedWord;
aHyphenatedWord =
hOptions.rHyphenator-hyphenate(Text.copy(wBoundary.startPos,
wBoundary.endPos - wBoundary.startPos), rLocale,
-(sal_Int16) (hOptions.hyphenIndex - wBoundary.startPos),
hOptions.aHyphenationOptions);
+(sal_Int16) (hOptions.hyphenIndex - wBoundary.startPos -
nStartPosWordEnd), hOptions.aHyphenationOptions);
if (aHyphenatedWord.is()) {
lbr.rHyphenatedWord = aHyphenatedWord;
if(wBoundary.startPos + aHyphenatedWord-getHyphenationPos() +
1 nMinBreakPos )
@@ -386,6 +402,13 @@ LineBreakResults SAL_CALL
BreakIterator_Unicode::getLineBreak(
else
lbr.breakIndex = wBoundary.startPos;
//aHyphenatedWord-getHyphenationPos();
lbr.breakType = BreakType::HYPHENATION;
+
+// check not optimal hyphenation of word-word (word with
hyphens)
+if (lbr.breakIndex -1 wBoundary.startPos +
aHyphenatedWord-getHyphenationPos() line.aBreakIterator-current()) {
+lbr.breakIndex = line.aBreakIterator-current();
+lbr.breakType = BreakType::WORDBOUNDARY;
+}
+
} else {
lbr.breakIndex = line.aBreakIterator-preceding(nStartPos);
lbr.breakType = BreakType::WORDBOUNDARY;;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: filter/source framework/inc framework/source include/comphelper include/framework include/salhelper include/ucbhelper include/unotools
filter/source/config/cache/filtercache.hxx |4 ++--
filter/source/config/cache/typedetection.hxx|2 +-
framework/inc/classes/propertysethelper.hxx |2 +-
framework/inc/dispatch/closedispatcher.hxx |2 +-
framework/inc/dispatch/startmoduledispatcher.hxx|2 +-
framework/inc/helper/persistentwindowstate.hxx |4 ++--
framework/inc/services/autorecovery.hxx |4 ++--
framework/inc/services/modulemanager.hxx|2 +-
framework/source/inc/accelerators/presethandler.hxx |2 +-
include/comphelper/configurationhelper.hxx |2 +-
include/framework/framelistanalyzer.hxx |4 ++--
include/salhelper/singletonref.hxx |2 +-
include/ucbhelper/interceptedinteraction.hxx|4 ++--
include/unotools/moduleoptions.hxx |2 +-
14 files changed, 19 insertions(+), 19 deletions(-)
New commits:
commit 7d491bec4063b447726c49a98be47c80df1d4e24
Author: Jesús Corrius jcorr...@gmail.com
Date: Thu Sep 26 10:33:38 2013 +0200
Everytimes - Every time
Change-Id: Ib84cee7dbb493387760ce68c25ec442bf0a4a121
diff --git a/filter/source/config/cache/filtercache.hxx
b/filter/source/config/cache/filtercache.hxx
index 7305c48..595927e 100644
--- a/filter/source/config/cache/filtercache.hxx
+++ b/filter/source/config/cache/filtercache.hxx
@@ -327,7 +327,7 @@ class FilterCache : public BaseLock
Otherwise this method does nothing!
This method must be called from every user of this
cache
-everytimes it need a filled cache. Normaly we load
+every time it need a filled cache. Normaly we load
only standard information into this cache on startup.
After a few seconds we start a special thread, which
may fill this cache completely. But if somehwere
outside
@@ -669,7 +669,7 @@ class FilterCache : public BaseLock
@descr It checks first, if the internal member m_xConfig
already
points to an open update access. If not - it opens a
new one.
-Doing so this method can be called everytimes a
configuration
+Doing so this method can be called every time a
configuration
access is needed.
@param eProvider
diff --git a/filter/source/config/cache/typedetection.hxx
b/filter/source/config/cache/typedetection.hxx
index bb4d45f..3ce6042 100644
--- a/filter/source/config/cache/typedetection.hxx
+++ b/filter/source/config/cache/typedetection.hxx
@@ -110,7 +110,7 @@ private:
@param rLastChance
the internal name of a suggested type ... (see before)
-Note: it will be reseted to an empty string everytimes. So
+Note: it will be reseted to an empty string every time. So
a set value of rLastChance can be detected outside very
easy.
@param rUsedDetectors
diff --git a/framework/inc/classes/propertysethelper.hxx
b/framework/inc/classes/propertysethelper.hxx
index 7288356..7ae333e 100644
--- a/framework/inc/classes/propertysethelper.hxx
+++ b/framework/inc/classes/propertysethelper.hxx
@@ -41,7 +41,7 @@ namespace framework{
/** supports the API XPropertySet and XPropertySetInfo.
*
* It must be used as baseclass. The internal list of supported
- * properties can be changed everytimes so dynamic property set's
+ * properties can be changed every time so dynamic property set's
* can be implemented.
*
* Further the derived and this base class share the same lock.
diff --git a/framework/inc/dispatch/closedispatcher.hxx
b/framework/inc/dispatch/closedispatcher.hxx
index de51671..a196cf1 100644
--- a/framework/inc/dispatch/closedispatcher.hxx
+++ b/framework/inc/dispatch/closedispatcher.hxx
@@ -257,7 +257,7 @@ class CloseDispatcher : // baseclasses ... order is
necessary for right initiali
/** @short notify a DispatchResultListener.
@descr We check the listener reference before we use it.
-So this method can be called everytimes!
+So this method can be called every time!
@parama xListener
the listener, which should be notified.
diff --git a/framework/inc/dispatch/startmoduledispatcher.hxx
b/framework/inc/dispatch/startmoduledispatcher.hxx
index d54887e..d1596c3 100644
--- a/framework/inc/dispatch/startmoduledispatcher.hxx
+++ b/framework/inc/dispatch/startmoduledispatcher.hxx
@@ -154,7 +154,7 @@ class StartModuleDispatcher : // baseclasses ... order is
necessary for right in
/** @short notify a DispatchResultListener.
@descr We check the listener reference before we use it.
-So this method can be called
Re: minutes of ESC face-to-face ...
About devs and bugs, perhaps it could be interesting to indicate in https://wiki.documentfoundation.org/FindTheExpert if we want to be warned or not about every bug (concerning module associated to the dev)? (or perhaps ping only for important bugs) Julien -- View this message in context: http://nabble.documentfoundation.org/minutes-of-ESC-face-to-face-tp4075224p4075306.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
unexpected behaviour whilst fixing fdo#50118
Hi, I'm working on a neat fix for bug fdo#50118 (Add-in functions are always shown in locale, regardless of global setting 'Use English function names') and I encounter an unexpected behaviour. In /sc/source/core/tool/addincol.cxx in ScUnoAddInCollection::ReadFromAddIn() I use Application::GetSettings().GetUILanguageTag().getLocale() (not yet pushed, still in https://gerrit.libreoffice.org/#/c/6032/), which works well during start up. But when calling Application::GetSettings().GetUILanguageTag().getLocale() again later, when the gobal setting 'Use English function names' has been changed, the call returns an empty locale (i.e. locale.Country is empty)! Any ideas what causes this? Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/breakiterator/breakiterator_unicode.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 634f1d11d2a027887807494b3ca67f33825d5d23 Author: László Németh nem...@numbertext.org Date: Thu Sep 26 12:19:01 2013 +0200 fdo#56392 fix hyph. of words with single punctuation marks Change-Id: I0a24fb53c2ff48c26b1c97b9a4768c3a725cd686 diff --git a/i18npool/source/breakiterator/breakiterator_unicode.cxx b/i18npool/source/breakiterator/breakiterator_unicode.cxx index 4c08a5f..5c7d588 100644 --- a/i18npool/source/breakiterator/breakiterator_unicode.cxx +++ b/i18npool/source/breakiterator/breakiterator_unicode.cxx @@ -383,10 +383,10 @@ LineBreakResults SAL_CALL BreakIterator_Unicode::getLineBreak( Boundary wBoundary = getWordBoundary( Text, nStartPosWordEnd, rLocale, WordType::DICTIONARY_WORD, false); -nStartPosWordEnd = wBoundary.endPos + 1; +nStartPosWordEnd = wBoundary.endPos; while (nStartPosWordEnd Text.getLength() (u_ispunct((sal_uInt32)Text[nStartPosWordEnd]))) // ending punctuation nStartPosWordEnd ++; -nStartPosWordEnd = nStartPosWordEnd - wBoundary.endPos - 1; +nStartPosWordEnd = nStartPosWordEnd - wBoundary.endPos; if (hOptions.hyphenIndex - wBoundary.startPos nStartPosWordEnd) nStartPosWordEnd = hOptions.hyphenIndex - wBoundary.startPos; #define SPACE 0x0020 while (boundary_with_punctuation wBoundary.endPos Text[--boundary_with_punctuation] == SPACE); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 54157] LibreOffice 4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 56392, which changed state. Bug 56392 Summary: Writer: hyphenation is not always used in line break algorithm https://bugs.freedesktop.org/show_bug.cgi?id=56392 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: include/oox offapi/com oox/source sw/inc sw/qa sw/source writerfilter/source
include/oox/vml/vmlshape.hxx |1 +
offapi/com/sun/star/text/BaseFrameProperties.idl | 10 ++
oox/source/vml/vmlshape.cxx | 22 ++
oox/source/vml/vmltextboxcontext.cxx |2 ++
sw/inc/hintids.hxx|1 +
sw/inc/unoprnms.hxx |1 +
sw/qa/extras/ooxmlimport/data/fdo69636.docx |binary
sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 11 +++
sw/source/core/bastyp/init.cxx|2 ++
sw/source/core/unocore/unomap.cxx |2 ++
sw/source/core/unocore/unoprnms.cxx |1 +
writerfilter/source/dmapper/DomainMapper.cxx |3 +++
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 17 -
writerfilter/source/dmapper/DomainMapper_Impl.hxx |1 +
14 files changed, 73 insertions(+), 1 deletion(-)
New commits:
commit 8738ded7bb1bb6262fe1038e310b5110407f4cfa
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Thu Sep 26 12:21:59 2013 +0200
fdo#69636 VML import: handle mso-layout-flow-alt shape prop for sw frames
Writer core doesn't support this, and this has been a problem for table
cells as well. There the workaround we're using for quite a while is to
do the rotation at a text portion level instead, which results in
reasonable layout for simple cases. Do the same here.
One additional complexity is that the API between oox and writerfilter
is a single UNO shape, we get this property in oox, and we have to
handle it in writerfilter, when the text frame is already attached to
some text. Kill this problem by adding a FrameInteropGrabBag for sw text
frames: it's useful anyway, and then we can pass around this property
inside the grab bag.
Change-Id: Idb5ec83b5cbdde8f29d15b2cebfad24226bb6507
diff --git a/include/oox/vml/vmlshape.hxx b/include/oox/vml/vmlshape.hxx
index 345210b..b40e211 100644
--- a/include/oox/vml/vmlshape.hxx
+++ b/include/oox/vml/vmlshape.hxx
@@ -101,6 +101,7 @@ struct OOX_DLLPUBLIC ShapeTypeModel
OUString maWrapDistanceRight;/// Distance from the right side of
the shape to the text that wraps around it.
OUString maWrapDistanceTop; /// Distance from the top of the
shape to the text that wraps around it.
OUString maWrapDistanceBottom; /// Distance from the bottom of the
shape to the text that wraps around it.
+OUString maLayoutFlowAlt; /// Specifies the alternate layout flow for
text in textboxes.
explicitShapeTypeModel();
diff --git a/offapi/com/sun/star/text/BaseFrameProperties.idl
b/offapi/com/sun/star/text/BaseFrameProperties.idl
index ff00e2c..edbb1cc 100644
--- a/offapi/com/sun/star/text/BaseFrameProperties.idl
+++ b/offapi/com/sun/star/text/BaseFrameProperties.idl
@@ -326,6 +326,16 @@ published service BaseFrameProperties
*/
[optional, property] short ShadowTransparence;
+/** Grab bag of frame properties, used as a string-any map for interim
interop purposes.
+
+@since LibreOffice 4.2
+
+pThis property is intentionally not handled by the ODF filter.
Any
+member that should be handled there should be first moved out from
this grab
+bag to a separate property./p
+*/
+[optional, property] sequencecom::sun::star::beans::PropertyValue
FrameInteropGrabBag;
+
};
diff --git a/oox/source/vml/vmlshape.cxx b/oox/source/vml/vmlshape.cxx
index 26cc704..b50551d 100644
--- a/oox/source/vml/vmlshape.cxx
+++ b/oox/source/vml/vmlshape.cxx
@@ -554,6 +554,28 @@ Reference XShape SimpleShape::implConvertAndInsert(
const Reference XShapes
PropertySet( xShape ).setAnyProperty( PROP_RightBorderDistance,
makeAny( sal_Int32( getTextBox()-borderDistanceRight )));
PropertySet( xShape ).setAnyProperty( PROP_BottomBorderDistance,
makeAny( sal_Int32( getTextBox()-borderDistanceBottom )));
}
+if (!maTypeModel.maLayoutFlowAlt.isEmpty())
+{
+// Can't handle this property here, as the frame is not attached
yet: pass it to writerfilter.
+uno::Referencebeans::XPropertySet xPropertySet(xShape,
uno::UNO_QUERY);
+uno::Sequencebeans::PropertyValue aGrabBag;
+xPropertySet-getPropertyValue(FrameInteropGrabBag) = aGrabBag;
+beans::PropertyValue aPair;
+aPair.Name = mso-layout-flow-alt;
+aPair.Value = uno::makeAny(maTypeModel.maLayoutFlowAlt);
+if (aGrabBag.hasElements())
+{
+sal_Int32 nLength = aGrabBag.getLength();
+aGrabBag.realloc(nLength + 1);
+aGrabBag[nLength + 1] = aPair;
+}
+else
+{
+aGrabBag.realloc(1);
+aGrabBag[0] = aPair;
+}
+
[Libreoffice-commits] core.git: sal/osl
sal/osl/unx/mutex.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 92db3f7c397ba5508daa386e19caf2b1661ec4b4
Author: David Tardon dtar...@redhat.com
Date: Thu Sep 26 13:04:23 2013 +0200
malloc returns void*; must be cast to real ptr type
Change-Id: Ic19707b99b1a53005ac319887219fc52b3e60e89
diff --git a/sal/osl/unx/mutex.c b/sal/osl/unx/mutex.c
index b894758..b2afa29 100644
--- a/sal/osl/unx/mutex.c
+++ b/sal/osl/unx/mutex.c
@@ -42,7 +42,7 @@ typedef struct _oslMutexImpl
/*/
oslMutex SAL_CALL osl_createMutex()
{
-oslMutexImpl* pMutex = malloc(sizeof(oslMutexImpl));
+oslMutexImpl* pMutex = (oslMutexImpl*) malloc(sizeof(oslMutexImpl));
pthread_mutexattr_t aMutexAttr;
int nRet=0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: minutes of ESC face-to-face ...
On Thu, 26 Sep 2013 12:00:45 +0200, julien2412 serval2...@yahoo.fr wrote: About devs and bugs, perhaps it could be interesting to indicate in https://wiki.documentfoundation.org/FindTheExpert if we want to be warned or not about every bug (concerning module associated to the dev)? (or perhaps ping only for important bugs) Julien +1 actually the Wiki page says: The following table shows several experts, you can add the appropriate expert to CC of a confirmed (NEW) bug. so the devs who don't wanna be CC'ed on bugs should ask to be removed from that list to avoid annoyances. actually users and QA members have no clue from that table to discern who likes to be CC'ed and who doesn't. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - comphelper/source sfx2/source ucb/source
comphelper/source/misc/mediadescriptor.cxx | 21 ++---
sfx2/source/doc/docfile.cxx|5 +++--
ucb/source/ucp/cmis/cmis_content.cxx | 25 -
ucb/source/ucp/cmis/cmis_url.cxx |3 +--
4 files changed, 42 insertions(+), 12 deletions(-)
New commits:
commit 86218bda0d74fc5bfc877b5c12d594d527207b11
Author: Cao Cuong Ngo cao.cuong@gmail.com
Date: Thu Sep 26 16:13:18 2013 +0200
Fix fdo#68894 Cmis crashes on start up.
The reason of the crash is that the recent file opening
feature can't get the session automatically.
Change-Id: I6890c04cfdafc81d19c6b2b2024896df040fe091
diff --git a/ucb/source/ucp/cmis/cmis_content.cxx
b/ucb/source/ucp/cmis/cmis_content.cxx
index 48556ed..0022a8a 100644
--- a/ucb/source/ucp/cmis/cmis_content.cxx
+++ b/ucb/source/ucp/cmis/cmis_content.cxx
@@ -364,6 +364,17 @@ namespace cmis
libcmis::ObjectPtr Content::getObject( const uno::Reference
ucb::XCommandEnvironment xEnv ) throw ( libcmis::Exception )
{
+// can't get the session for some reason
+// the recent file openning at start up is an example.
+try
+{
+if ( !getSession( xEnv ) )
+return m_pObject;
+}
+catch ( uno::RuntimeException )
+{
+return m_pObject;
+}
if ( !m_pObject.get() )
{
if ( !m_sObjectId.isEmpty( ) )
commit 34f4d2574987b272681b5843e8f5edc374f55fde
Author: Cao Cuong Ngo cao.cuong@gmail.com
Date: Sat Sep 21 23:36:06 2013 +0200
CMIS file picker: it really does not like ID Mark
The file picker can't go back folder if we use
ID mark in the URL.
Conflicts:
ucb/source/ucp/cmis/cmis_content.cxx
Change-Id: I6985feec71dc23848ee022e0bab9e8515a21ffd2
diff --git a/comphelper/source/misc/mediadescriptor.cxx
b/comphelper/source/misc/mediadescriptor.cxx
index 7fd7d5f..21361f5 100644
--- a/comphelper/source/misc/mediadescriptor.cxx
+++ b/comphelper/source/misc/mediadescriptor.cxx
@@ -47,6 +47,23 @@
namespace comphelper{
+namespace {
+
+OUString removeFragment(OUString const uri) {
+css::uno::Reference css::uri::XUriReference ref(
+css::uri::UriReferenceFactory::create(
+comphelper::getProcessComponentContext())-
+parse(uri));
+if (ref.is()) {
+ref-clearFragment();
+return ref-getUriReference();
+} else {
+SAL_WARN(comphelper, cannot parse uri );
+return uri;
+}
+}
+}
+
const OUString MediaDescriptor::PROP_ABORTED()
{
static const OUString sProp(Aborted);
@@ -467,9 +484,7 @@ sal_Bool MediaDescriptor::impl_addInputStream( sal_Bool
bLockFile )
css::uno::Reference css::uno::XInterface ());
// Parse URL! Only the main part has to be used further. E.g. a
jumpmark can make trouble
-// We need to keep the full URL with Mark to store the Object ID
-// in CMIS UCB
-return impl_openStreamWithURL( sURL, bLockFile );
+return impl_openStreamWithURL( removeFragment(sURL), bLockFile );
}
catch(const css::uno::Exception ex)
{
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 710ea5f..329cfb8 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -2479,7 +2479,7 @@ void SfxMedium::Init_Impl()
{
if ( aUrl.HasMark() )
{
-// keep the Mark to store the Document ID
+pImp-m_aLogicName = aUrl.GetURLNoMark(
INetURLObject::NO_DECODE );
GetItemSet()-Put( SfxStringItem( SID_JUMPMARK, aUrl.GetMark()
) );
}
@@ -2994,7 +2994,8 @@ const INetURLObject SfxMedium::GetURLObject() const
if (!pImp-m_pURLObj)
{
pImp-m_pURLObj = new INetURLObject( pImp-m_aLogicName );
-// keep the Mark to store the Document ID
+if (pImp-m_pURLObj-HasMark())
+*pImp-m_pURLObj = INetURLObject( pImp-m_aLogicName
).GetURLNoMark();
}
return *pImp-m_pURLObj;
diff --git a/ucb/source/ucp/cmis/cmis_content.cxx
b/ucb/source/ucp/cmis/cmis_content.cxx
index 4bc7c3c..48556ed 100644
--- a/ucb/source/ucp/cmis/cmis_content.cxx
+++ b/ucb/source/ucp/cmis/cmis_content.cxx
@@ -1258,8 +1258,6 @@ namespace cmis
m_pObjectType.reset( );
m_pObjectProps.clear( );
m_bTransient = false;
-uno::Reference ucb::XContentIdentifier xId(new
::ucbhelper::ContentIdentifier(m_sURL));
-m_xIdentifier = xId;
inserted();
}
}
@@ -1538,10 +1536,16 @@ namespace cmis
return parentUrl;
else
{
-INetURLObject aParentUrl( m_sURL );
-aParentUrl.removeSegment( );
-return
[Libreoffice-commits] core.git: Branch 'feature/sc-notes-storage' - sc/source
sc/source/ui/view/printfun.cxx | 12
1 file changed, 8 insertions(+), 4 deletions(-)
New commits:
commit c5109870fb536a6e938c2b0080b639e9f285b8d8
Author: Laurent Godard lgodard.li...@laposte.net
Date: Thu Sep 26 16:32:34 2013 +0200
optim notes loop
Change-Id: I62a680e64493aff86445791ce3e9e1b5bfec4324
diff --git a/sc/source/ui/view/printfun.cxx b/sc/source/ui/view/printfun.cxx
index 953fc70..3b4b382 100644
--- a/sc/source/ui/view/printfun.cxx
+++ b/sc/source/ui/view/printfun.cxx
@@ -2493,12 +2493,16 @@ long ScPrintFunc::CountNotePages()
if (bDoThis)
{
-for ( SCROW nRow = nStartRow; nRow = nEndRow; ++nRow )
+// TODO : notes
+for ( SCCOL nCol = nStartCol; nCol = nEndCol; ++nCol )
{
-for ( SCCOL nCol = nStartCol; nCol = nEndCol; ++nCol )
+if (pDoc-HasColNotes(nCol, nPrintTab))
{
-if ( pDoc-HasNote(nCol, nRow, nPrintTab) )
-aNotePosList.push_back( ScAddress( nCol, nRow,
nPrintTab ) );
+for ( SCROW nRow = nStartRow; nRow = nEndRow; ++nRow )
+{
+if ( pDoc-HasNote(nCol, nRow, nPrintTab) )
+aNotePosList.push_back( ScAddress( nCol, nRow,
nPrintTab ) );
+}
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 42092, which changed state. Bug 42092 Summary: SVG vector graphics exported as bitmaps to PDF https://bugs.freedesktop.org/show_bug.cgi?id=42092 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Checkbox Format Paragraph Text Flow Breaks in Writer
Hello, Is this possible to have the checkbox Format Paragraph Text Flow Breaks always check for a table ? This bug is demanding it https://bugassistant.libreoffice.org/show_bug.cgi?id=39400 and for a malformated RTF, I also need it. If not, is this possible to tell me where the checkbox is managed int he code? Thank you very much for your help. Matthieu GAY. This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: inter-sheet formulas don't automatically update any more?
The bug is still there in 4.1.2.2 as far as I can tell. I can try to create a test case, but the spreadsheet I have right now is very complicated and proprietary. There's also a regression where references to CSV sheets give a #REF rather than a value half the time, which also renders the 4.1 branch unusable. Thanks, Yi On Wed, Sep 25, 2013 at 1:27 PM, Kohei Yoshida kohei.yosh...@collabora.com wrote: On Mon, 2013-09-23 at 08:31 -0500, Yi Ding wrote: It seems like since the release of 4.1 inter-sheet formulas (formulas that span multiple sheets in the spreadsheet) don't automatically update themselves anymore. Is this a bug or a feature? We would need a bit more information there and preferably a test case. There was a bug that may fit your problem description which I fixed between 4.1.0 and 4.1.1. But to be sure if it's the same problem, we would need a test document from you. Is it possible for you to file a bugzilla bug with a test document and steps to reproduce your bug? Also, have you tried the latest 4.1.x release and see if the bug is still there? Thanks. Kohei -- Kohei Yoshida, Consultant Principal Software Engineer Collabora Productivity ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/dialog/infobar.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 4cd9024db1898176ed2dc06dfe36a2c71213bb02 Author: Cao Cuong Ngo cao.cuong@gmail.com Date: Thu Sep 26 19:14:52 2013 +0200 Fix Infobar crash The infobar should be added to the infobar list. Change-Id: I105dd5091daf3596fdd7dd119a07d6160444c673 diff --git a/sfx2/source/dialog/infobar.cxx b/sfx2/source/dialog/infobar.cxx index 82c2c3a..e14b8bb 100644 --- a/sfx2/source/dialog/infobar.cxx +++ b/sfx2/source/dialog/infobar.cxx @@ -251,6 +251,7 @@ void SfxInfoBarContainerWindow::appendInfoBar( const OUString sId, const OUStri SfxInfoBarWindow* pInfoBar = new SfxInfoBarWindow( this, sId, sMessage, aButtons ); pInfoBar-SetPosPixel( Point( 0, aSize.getHeight( ) ) ); pInfoBar-Show( ); +m_pInfoBars.push_back( pInfoBar ); long nHeight = pInfoBar-GetSizePixel( ).getHeight( ); aSize.setHeight( aSize.getHeight() + nHeight ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/doctok/Dff.cxx | 39
writerfilter/source/doctok/Dff.hxx |7 ---
writerfilter/source/doctok/resourcesimpl.xsl | 63 ---
3 files changed, 109 deletions(-)
New commits:
commit 7367bd9fff37031d5ddcfe926dd3a7f6ecdb0500
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Thu Sep 26 20:23:58 2013 +0200
writerfilter: remove dead createDffRecord
Change-Id: I27dc30c8aba7b77cdac771ca733fadb805a5c75b
diff --git a/writerfilter/source/doctok/Dff.cxx
b/writerfilter/source/doctok/Dff.cxx
index f39505e..e66d716 100644
--- a/writerfilter/source/doctok/Dff.cxx
+++ b/writerfilter/source/doctok/Dff.cxx
@@ -107,27 +107,6 @@ sal_uInt32 DffRecord::getRecordType() const
void DffRecord::initChildren()
{
-if (isContainer())
-{
-sal_uInt32 nOffset = 8;
-sal_uInt32 nCount = calcSize();
-
-while (nCount - nOffset = 8)
-{
-sal_uInt32 nSize = 0;
-boost::shared_ptrDffRecord pRec
-(createDffRecord(this, nOffset, nSize));
-
-if (nSize == 0)
-break;
-
-mRecords.push_back(pRec);
-
-nOffset += nSize;
-}
-}
-
-bInitialized = true;
}
Records_t DffRecord::findRecords(sal_uInt32 nType, bool bRecursive, bool bAny)
@@ -376,24 +355,6 @@ DffBlock::DffBlock(const DffBlock rSrc)
void DffBlock::initChildren()
{
-sal_uInt32 nOffset = 0;
-sal_uInt32 nCount = getCount();
-
-while (nOffset nCount)
-{
-sal_uInt32 nSize = 0;
-DffRecord::Pointer_t pDffRecord
-(createDffRecord(this, nOffset, nSize));
-
-if (nSize == 0)
-break;
-
-mRecords.push_back(pDffRecord);
-
-nOffset += nSize + mnPadding;
-}
-
-bInitialized = true;
}
Records_t DffBlock::findRecords(sal_uInt32 nType, bool bRecursive, bool bAny)
diff --git a/writerfilter/source/doctok/Dff.hxx
b/writerfilter/source/doctok/Dff.hxx
index ef43808..62b8ef6 100644
--- a/writerfilter/source/doctok/Dff.hxx
+++ b/writerfilter/source/doctok/Dff.hxx
@@ -133,13 +133,6 @@ public:
virtual string getType() const;
};
-DffRecord *
-createDffRecord(WW8StructBase * pParent, sal_uInt32 nOffset,
-sal_uInt32 * nSize = NULL);
-DffRecord *
-createDffRecord(WW8Stream rStream, sal_uInt32 nOffset,
-sal_uInt32 * nSize = NULL);
-
}}
#endif
diff --git a/writerfilter/source/doctok/resourcesimpl.xsl
b/writerfilter/source/doctok/resourcesimpl.xsl
index d0b714d..196b44e 100644
--- a/writerfilter/source/doctok/resourcesimpl.xsl
+++ b/writerfilter/source/doctok/resourcesimpl.xsl
@@ -679,69 +679,6 @@ WW8Value::Pointer_t WW8FOPTE::get_stringValue()
xsl:template match=UML:Model mode=createdffrecord
xsl:text
-DffRecord * createDffRecord
-(WW8StructBase * pParent, sal_uInt32 nOffset, sal_uInt32 * pCount)
-{
-DffRecord * pResult = NULL;
-DffRecord aTmpRec(pParent, nOffset, 8);
-sal_uInt32 nSize = aTmpRec.calcSize();
-
-if (pCount != NULL)
-*pCount = nSize;
-
-switch (aTmpRec.getRecordType())
-{#xa;/xsl:text
-xsl:for-each
select='.//UML:Class[.//UML:Stereotype/@xmi.idref=dffrecord]'
- xsl:textcase /xsl:text
- xsl:value-of
select=.//UML:TaggedValue[.//UML:TagDefinition/@xmi.idref='dffid']//UML:TaggedValue.dataValue/
- xsl:text:
- pResult = new Dff/xsl:text
- xsl:value-of select=@name/
- xsl:text(pParent, nOffset, nSize);
-
- break;#xa;/xsl:text
-/xsl:for-each
-xsl:text
- default:
- pResult = new DffRecord(pParent, nOffset, nSize);
-
- break;
-}
-
-return pResult;
-}
-
-DffRecord * createDffRecord
-(WW8Stream amp; rStream, sal_uInt32 nOffset, sal_uInt32 * pCount)
-{
-DffRecord * pResult = NULL;
-DffRecord aTmpRec(rStream, nOffset, 8);
-sal_uInt32 nSize = aTmpRec.calcSize();
-
-if (pCount != NULL)
-*pCount = nSize;
-
-switch (aTmpRec.getRecordType())
-{#xa;/xsl:text
-xsl:for-each
select='.//UML:Class[.//UML:Stereotype/@xmi.idref=dffrecord]'
- xsl:textcase /xsl:text
- xsl:value-of
select=.//UML:TaggedValue[.//UML:TagDefinition/@xmi.idref='dffid']//UML:TaggedValue.dataValue/
- xsl:text:
- pResult = new Dff/xsl:text
- xsl:value-of select=@name/
- xsl:text(rStream, nOffset, nSize);
-
- break;#xa;/xsl:text
-/xsl:for-each
-xsl:text
- default:
- pResult = new DffRecord(rStream, nOffset, nSize);
-
- break;
-}
-
-return pResult;
-}
/xsl:text
/xsl:template
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svl/source
svl/source/svdde/ddesvr.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 3d373e8a4adcbc2f9cd4b7cedf8308865989fad5 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Sep 26 20:42:51 2013 +0200 Missing #include Change-Id: I2af468933b1e9bdad1c6da1f881daaf068b6bec0 diff --git a/svl/source/svdde/ddesvr.cxx b/svl/source/svdde/ddesvr.cxx index 25a3f3f..f51d08b 100644 --- a/svl/source/svdde/ddesvr.cxx +++ b/svl/source/svdde/ddesvr.cxx @@ -24,6 +24,7 @@ #include comphelper/string.hxx #include svl/svdde.hxx #include tools/debug.hxx +#include tools/string.hxx #include osl/thread.h #include o3tl/sorted_vector.hxx ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: writerfilter/inc
writerfilter/inc/doctok/WW8Document.hxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 4930146e1bf1ed036638c7270721d1051095a3c2
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Thu Sep 26 20:43:01 2013 +0200
writerfilter: no need to have these as public anymore
And hopefully this will also fix the Windows build as well.
Change-Id: I6a008c0bf74d436be7eef0c5d0945dd07e3954e5
diff --git a/writerfilter/inc/doctok/WW8Document.hxx
b/writerfilter/inc/doctok/WW8Document.hxx
index 9300e2f..b135f8e 100644
--- a/writerfilter/inc/doctok/WW8Document.hxx
+++ b/writerfilter/inc/doctok/WW8Document.hxx
@@ -44,7 +44,7 @@ using namespace ::com::sun::star;
stream consists of substreams that are identified by string
identifiers.
*/
-class WRITERFILTER_DOCTOK_DLLPUBLIC WW8Stream
+class WW8Stream
{
public:
/**
@@ -269,7 +269,7 @@ enum PropertyType {
The use of the iterator is analogous to WW8PropertySetIterator.
*/
-class WRITERFILTER_DOCTOK_DLLPUBLIC WW8DocumentIterator
+class WW8DocumentIterator
{
public:
typedef boost::shared_ptrWW8DocumentIterator Pointer_t;
@@ -384,7 +384,7 @@ public:
/**
A Word 8 document.
*/
-class WRITERFILTER_DOCTOK_DLLPUBLIC WW8Document :
+class WW8Document :
public writerfilter::ReferenceStream
{
public:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/source
cui/source/options/optaboutconfig.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ff0bd9ff42bd6fe6ab7f8667c256c952aa261809
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Sep 26 21:24:05 2013 +0200
Fix 32-bit builds
Change-Id: I78cdd43e02a891fac7240105a9457df105fb849f
diff --git a/cui/source/options/optaboutconfig.cxx
b/cui/source/options/optaboutconfig.cxx
index c5eed73..4cba4d7 100644
--- a/cui/source/options/optaboutconfig.cxx
+++ b/cui/source/options/optaboutconfig.cxx
@@ -407,7 +407,7 @@ std::vector OUString
CuiAboutConfigTabPage::commaStringToSequence( const OUSt
{
std::vectorOUString tempVector;
-int index = 0;
+sal_Int32 index = 0;
do
{
OUString word = rCommaSepString.getToken(0, static_castsal_Unicode
(','), index);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/editeng
include/editeng/editstat.hxx |1 + 1 file changed, 1 insertion(+) New commits: commit 703e9f90c00da364e4cddd7e1ea332e6846fe6ce Author: Stephan Bergmann sberg...@redhat.com Date: Thu Sep 26 21:10:43 2013 +0200 Missing #include Change-Id: I4ed43a7464da4f4e68636dc90bb92c9a1f76336f diff --git a/include/editeng/editstat.hxx b/include/editeng/editstat.hxx index 0369c25..51482ba 100644 --- a/include/editeng/editstat.hxx +++ b/include/editeng/editstat.hxx @@ -21,6 +21,7 @@ #define _EDITSTAT_HXX #include rtl/ustring.hxx +#include tools/solar.h #include i18nlangtag/lang.h #define EE_CNTRL_USECHARATTRIBS 0x0001 // Use of hard character attributes ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: unexpected behaviour whilst fixing fdo#50118
Hi Winfried, On Thursday, 2013-09-26 12:12:48 +0200, Winfried Donkers wrote: In /sc/source/core/tool/addincol.cxx in ScUnoAddInCollection::ReadFromAddIn() I use Application::GetSettings().GetUILanguageTag().getLocale() (not yet pushed, still in https://gerrit.libreoffice.org/#/c/6032/), which works well during start up. But when calling Application::GetSettings().GetUILanguageTag().getLocale() again later, when the gobal setting 'Use English function names' has been changed, the call returns an empty locale (i.e. locale.Country is empty)! Let me guess, your system locale and UI localization is Dutch, and at that place of the application locale only Country and Variant are empty but Language==nl? I think I know why, need some more digging. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Support the FSFE, care about Free Software! https://fsfe.org/support/?erack pgpaONuSCIiX2.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: ucb/Library_ucpgio1.mk ucb/source
ucb/Library_ucpgio1.mk |1 +
ucb/source/ucp/gio/gio_content.cxx | 11 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
New commits:
commit 2eb36dc4b846ab5886ae71fd2978b56b2a2d1d08
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Sep 26 22:30:11 2013 +0200
Hack to not leave SolarMutex released after g_main_loop_run call
Change-Id: I26923469d08308233ce3fabe749806c16d75cecd
diff --git a/ucb/Library_ucpgio1.mk b/ucb/Library_ucpgio1.mk
index eb39c8e..000f557 100644
--- a/ucb/Library_ucpgio1.mk
+++ b/ucb/Library_ucpgio1.mk
@@ -21,6 +21,7 @@ $(eval $(call gb_Library_use_libraries,ucpgio1,\
sal \
salhelper \
ucbhelper \
+ vcl \
))
$(eval $(call gb_Library_use_externals,ucpgio1,\
diff --git a/ucb/source/ucp/gio/gio_content.cxx
b/ucb/source/ucp/gio/gio_content.cxx
index 8621782..f7ce5f9 100644
--- a/ucb/source/ucp/gio/gio_content.cxx
+++ b/ucb/source/ucp/gio/gio_content.cxx
@@ -62,6 +62,7 @@
#include ucbhelper/propertyvalueset.hxx
#include ucbhelper/interactionrequest.hxx
#include ucbhelper/cancelcommandexecution.hxx
+#include vcl/svapp.hxx
#include osl/conditn.hxx
@@ -325,7 +326,15 @@ void MountOperation::Completed(GObject *source,
GAsyncResult *res, gpointer user
GError *MountOperation::Mount(GFile *pFile)
{
g_file_mount_enclosing_volume(pFile, G_MOUNT_MOUNT_NONE, mpAuthentication,
NULL, MountOperation::Completed, this);
-g_main_loop_run(mpLoop);
+{
+//HACK: At least the gdk_threads_set_lock_functions(GdkThreadsEnter,
+// GdkThreadsLeave) call in vcl/unx/gtk/app/gtkinst.cxx will lead to
+// GdkThreadsLeave unlock the SolarMutex down to zero at the end of
+// g_main_loop_run, so we need ~SolarMutexReleaser to raise it back to
+// the original value again:
+SolarMutexReleaser rel;
+g_main_loop_run(mpLoop);
+}
return mpError;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
LibreOffice Conference 2013 Streams
Not at LibreOffice Conference for some reason or another, or you just could not afford the trip? Sit back in your arm chair and join in on the streaming conference channels. There are re-broadcasts of sessions that you may find interesting. You may even want to watch along with a little bruschetta or some risotto, just to make it feel like you are in Milan! :-) You will find the feeds on our LibOCon.org site here: [http://conference.libreoffice.org/2013/en/streams] BTW ... here are some group shots tweeted by Florian ... [https://plus.google.com/photos/116265564718884370181/albums/5927943226881893921] Follow the conference on Twitter @Libocon (not many tweets yet) I wish I could be there, have a great time guys! Cheers, Marc Marketing Team Member (Watching feeds from Canada) -- Marc Paré marc.p...@libreoffice.org http://www.LibreOffice.org http://blog.documentfoundation.org http://www.LibOCon.org http://donate.libreOffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: unotools/source
unotools/source/config/syslocaleoptions.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit ecefa40c081a0b6677e946603d553d9382f9b9ca
Author: Eike Rathke er...@redhat.com
Date: Thu Sep 26 22:58:34 2013 +0200
use makeFallback() in MakeRalLocale()/MakeRealUILocale()
The old MsLangId::convert...() methods did implicitly fall back to a
known locale, this behavior is explicitly needed here to select a proper
completely known locale.
Change-Id: I350989f3af679890ddb0de964c2d107420331160
diff --git a/unotools/source/config/syslocaleoptions.cxx
b/unotools/source/config/syslocaleoptions.cxx
index 7e13611..f266b4d 100644
--- a/unotools/source/config/syslocaleoptions.cxx
+++ b/unotools/source/config/syslocaleoptions.cxx
@@ -266,11 +266,11 @@ void SvtSysLocaleOptions_Impl::MakeRealLocale()
if (m_aLocaleString.isEmpty())
{
LanguageType nLang = MsLangId::getSystemLanguage();
-m_aRealLocale.reset( nLang);
+m_aRealLocale.reset( nLang).makeFallback();
}
else
{
-m_aRealLocale.reset( m_aLocaleString);
+m_aRealLocale.reset( m_aLocaleString).makeFallback();
}
}
@@ -279,11 +279,11 @@ void SvtSysLocaleOptions_Impl::MakeRealUILocale()
if (m_aUILocaleString.isEmpty())
{
LanguageType nLang = MsLangId::getSystemUILanguage();
-m_aRealUILocale.reset( nLang);
+m_aRealUILocale.reset( nLang).makeFallback();
}
else
{
-m_aRealUILocale.reset( m_aUILocaleString);
+m_aRealUILocale.reset( m_aUILocaleString).makeFallback();
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: unexpected behaviour whilst fixing fdo#50118
Hi Winfried, On Thursday, 2013-09-26 22:19:14 +0200, Eike Rathke wrote: But when calling Application::GetSettings().GetUILanguageTag().getLocale() again later, when the gobal setting 'Use English function names' has been changed, the call returns an empty locale (i.e. locale.Country is empty)! Let me guess, your system locale and UI localization is Dutch, and at that place of the application locale only Country and Variant are empty but Language==nl? I think I know why, need some more digging. Commit ecefa40c081a0b6677e946603d553d9382f9b9ca should fix that and the locale should be 'nl-NL'. There may be other places though that previously relied on the implicit fallback whenever MsLangId::convert...() were called. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Support the FSFE, care about Free Software! https://fsfe.org/support/?erack pgppU7szdRM13.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC face-to-face ...
Hi all, Michael Meeks wrote (25-09-13 02:30) * do developers have a good overview of bugs filed vs. their module ? (Cor) [...] + concern is that developers may overlook things (Cor) Idea was more to learn how that works for the people. Knowing that, helps me for exmaple to do less, or more effective work (skip actions that I may considered being covered by the way devs tend to act). Answers given were halepful in that respect :) Cheers Cor Great to meet here and have open and effective exchange of ideas ! -- - Cor Nouws - http://nl.libreoffice.org - The Document Foundation Membership Committee Member ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: cui/AllLangResTarget_cui.mk cui/source cui/uiconfig cui/UIConfig_cui.mk
cui/AllLangResTarget_cui.mk |1
cui/UIConfig_cui.mk |1
cui/source/inc/optasian.hxx | 34 +--
cui/source/options/optasian.cxx | 137 ++
cui/source/options/optasian.hrc | 42
cui/source/options/optasian.src | 141 --
cui/uiconfig/ui/optasianpage.ui | 381
7 files changed, 463 insertions(+), 274 deletions(-)
New commits:
commit 20b9f53e9681aa1a4e3a257a417aae0c4eb03f7d
Author: Jan Holesovsky ke...@collabora.com
Date: Thu Sep 26 23:39:48 2013 +0200
Convert optasian page to .ui + adapt code.
Change-Id: Ia3ea3fcf38512431fb99191f230450f26c7b3e2f
diff --git a/cui/AllLangResTarget_cui.mk b/cui/AllLangResTarget_cui.mk
index e82b4e0..119a1d6 100644
--- a/cui/AllLangResTarget_cui.mk
+++ b/cui/AllLangResTarget_cui.mk
@@ -50,7 +50,6 @@ $(eval $(call gb_SrsTarget_add_files,cui/res,\
cui/source/options/dbregister.src \
cui/source/options/doclinkdialog.src \
cui/source/options/internationaloptions.src \
-cui/source/options/optasian.src \
cui/source/options/optchart.src \
cui/source/options/optcolor.src \
cui/source/options/optdict.src \
diff --git a/cui/UIConfig_cui.mk b/cui/UIConfig_cui.mk
index 5d3538b..9868086 100644
--- a/cui/UIConfig_cui.mk
+++ b/cui/UIConfig_cui.mk
@@ -63,6 +63,7 @@ $(eval $(call gb_UIConfig_add_uifiles,cui,\
cui/uiconfig/ui/optaccessibilitypage \
cui/uiconfig/ui/optadvancedpage \
cui/uiconfig/ui/optappearancepage \
+ cui/uiconfig/ui/optasianpage \
cui/uiconfig/ui/optbasicidepage \
cui/uiconfig/ui/optbrowserpage \
cui/uiconfig/ui/optctlpage \
diff --git a/cui/source/inc/optasian.hxx b/cui/source/inc/optasian.hxx
index db7b2b0..e68452a 100644
--- a/cui/source/inc/optasian.hxx
+++ b/cui/source/inc/optasian.hxx
@@ -29,26 +29,22 @@
struct SvxAsianLayoutPage_Impl;
class SvxAsianLayoutPage : public SfxTabPage
{
-FixedLineaKerningGB;
-RadioButton aCharKerningRB;
-RadioButton aCharPunctKerningRB;
+RadioButton* m_pCharKerningRB;
+RadioButton* m_pCharPunctKerningRB;
-FixedLineaCharDistGB;
-RadioButton aNoCompressionRB;
-RadioButton aPunctCompressionRB;
-RadioButton aPunctKanaCompressionRB;
+RadioButton* m_pNoCompressionRB;
+RadioButton* m_pPunctCompressionRB;
+RadioButton* m_pPunctKanaCompressionRB;
-FixedLineaStartEndGB;
+FixedText* m_pLanguageFT;
+SvxLanguageBox* m_pLanguageLB;
+CheckBox* m_pStandardCB;
-FixedText aLanguageFT;
-SvxLanguageBox aLanguageLB;
-CheckBoxaStandardCB;
-
-FixedText aStartFT;
-EditaStartED;
-FixedText aEndFT;
-EditaEndED;
-FixedText aHintFT;
+FixedText* m_pStartFT;
+Edit*m_pStartED;
+FixedText* m_pEndFT;
+Edit*m_pEndED;
+FixedText* m_pHintFT;
SvxAsianLayoutPage_Impl* pImpl;
@@ -62,8 +58,8 @@ public:
virtual ~SvxAsianLayoutPage();
static SfxTabPage* Create( Window* pParent, const SfxItemSet rAttrSet );
-static sal_uInt16* GetRanges();
-virtual sal_BoolFillItemSet( SfxItemSet rSet );
+static sal_uInt16* GetRanges();
+virtual sal_BoolFillItemSet( SfxItemSet rSet );
virtual voidReset( const SfxItemSet rSet );
};
diff --git a/cui/source/options/optasian.cxx b/cui/source/options/optasian.cxx
index a74b30a..2c86765 100644
--- a/cui/source/options/optasian.cxx
+++ b/cui/source/options/optasian.cxx
@@ -21,7 +21,6 @@
#include optasian.hxx
#include editeng/langitem.hxx
#include editeng/unolingu.hxx
-#include optasian.hrc
#include dialmgr.hxx
#include cuires.hrc
#include i18nlangtag/mslangid.hxx
@@ -64,7 +63,7 @@ typedef ::std::map LanguageType, SvxForbiddenChars_Impl*
SvxForbiddenCharacte
struct SvxAsianLayoutPage_Impl
{
SvxAsianConfig aConfig;
-SvxAsianLayoutPage_Impl() {}
+SvxAsianLayoutPage_Impl() {}
~SvxAsianLayoutPage_Impl();
@@ -123,34 +122,31 @@ void SvxAsianLayoutPage_Impl::addForbiddenCharacters(
static LanguageType eLastUsedLanguageTypeForForbiddenCharacters = USHRT_MAX;
SvxAsianLayoutPage::SvxAsianLayoutPage( Window* pParent, const SfxItemSet
rSet ) :
-SfxTabPage(pParent, CUI_RES( RID_SVXPAGE_ASIAN_LAYOUT ), rSet),
-aKerningGB( this, CUI_RES(GB_KERNING)),
-aCharKerningRB( this, CUI_RES(RB_CHAR_KERNING )),
-aCharPunctKerningRB(this, CUI_RES(RB_CHAR_PUNCT )),
-aCharDistGB(this, CUI_RES(GB_CHAR_DIST )),
-aNoCompressionRB( this, CUI_RES(RB_NO_COMP)),
-aPunctCompressionRB(this, CUI_RES(RB_PUNCT_COMP )),
- aPunctKanaCompressionRB(this, CUI_RES(RB_PUNCT_KANA_COMP )),
-aStartEndGB(this, CUI_RES(GB_START_END )),
-aLanguageFT(this, CUI_RES(FT_LANGUAGE )),
-aLanguageLB(this,
Re: Locale mixup on master (Hebrew is recognized as Hindi)
Hi Lior, On Wednesday, 2013-09-25 17:46:45 +0200, Lior Kaplan wrote: I've noticed a locale mixup on master when starting LibreOffice from the command line with export LC_ALL=he_IL.UTF-8. While the UI translation is shown in Hebrew, the interface has Hindi (hi) settings (including looking as LTR instead of RTL). If starting with en_US.UTF-8 locale and manually set Hebrew locale in the language setting, I get Gujarati locale settings on restart. Yes, I noticed some quirk in locale selection as well, I'll investigate. It looks like in a localized UI (not en-US) the paired strings of the language list are shifted by an offset of one and display something different than the actual locale. This may be related to a pair being inserted to the original en-US .src file that does not have a translation yet and thus is missing. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Support the FSFE, care about Free Software! https://fsfe.org/support/?erack pgpUW0XsVOVmv.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: svtools/source
svtools/source/misc/langtab.src |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit bcfb5f0e9b659d16b72fe0add599dd8ec1a7c098 Author: Eike Rathke er...@redhat.com Date: Fri Sep 27 00:12:26 2013 +0200 moved newly inserted entries to the end In UI localizations where the translation for such an entry is missing the entire entry is omitted, causing the following entries to be shifted by an offset and picking a wrong entry. Seems that rsc does not handle this case properly. Change-Id: I0efe1ac5d1f704ab2ba6919c4997caaca2153401 diff --git a/svtools/source/misc/langtab.src b/svtools/source/misc/langtab.src index 1752742..f9bd866 100644 --- a/svtools/source/misc/langtab.src +++ b/svtools/source/misc/langtab.src @@ -84,7 +84,6 @@ StringArray STR_ARR_SVT_LANGUAGE_TABLE Dutch (Belgium) ; LANGUAGE_DUTCH_BELGIAN ; ; English (USA) ; LANGUAGE_ENGLISH_US ; ; English (UK) ; LANGUAGE_ENGLISH_UK ; ; - English, OED spelling (UK) ; LANGUAGE_USER_ENGLISH_UK_OED ; ; English (Australia) ; LANGUAGE_ENGLISH_AUS ; ; English (Canada) ; LANGUAGE_ENGLISH_CAN ; ; English (New Zealand) ; LANGUAGE_ENGLISH_NZ ; ; @@ -158,7 +157,6 @@ StringArray STR_ARR_SVT_LANGUAGE_TABLE Serbian Latin (Serbia) ; LANGUAGE_USER_SERBIAN_LATIN_SERBIA ; ; Serbian Cyrillic (Montenegro) ; LANGUAGE_USER_SERBIAN_CYRILLIC_MONTENEGRO ; ; Serbian Latin (Montenegro) ; LANGUAGE_USER_SERBIAN_LATIN_MONTENEGRO ; ; - Serbian Latin ; LANGUAGE_SERBIAN_LATIN_NEUTRAL ; ; Sidama ; LANGUAGE_USER_SIDAMA ; ; Sindhi ; LANGUAGE_SINDHI ; ; Slovak ; LANGUAGE_SLOVAK ; ; @@ -195,7 +193,6 @@ StringArray STR_ARR_SVT_LANGUAGE_TABLE Urdu (India) ; LANGUAGE_URDU_INDIA ; ; Ukrainian ; LANGUAGE_UKRAINIAN ; ; Uzbek Latin ; LANGUAGE_UZBEK_LATIN ; ; - Uzbek Cyrillic ; LANGUAGE_UZBEK_CYRILLIC ; ; Welsh ; LANGUAGE_WELSH ; ; Latin ; LANGUAGE_LATIN ; ; Esperanto ; LANGUAGE_USER_ESPERANTO ; ; @@ -206,7 +203,6 @@ StringArray STR_ARR_SVT_LANGUAGE_TABLE Northern Sotho ; LANGUAGE_SEPEDI ; ; Gaelic (Scotland) ; LANGUAGE_GAELIC_SCOTLAND ; ; Mongolian Cyrillic ; LANGUAGE_MONGOLIAN ; ; - Mongolian Mongolian ; LANGUAGE_MONGOLIAN_MONGOLIAN ; ; Interlingua ; LANGUAGE_USER_INTERLINGUA ; ; Bosnian ; LANGUAGE_BOSNIAN_BOSNIA_HERZEGOVINA ; ; Bengali (Bangladesh) ; LANGUAGE_BENGALI_BANGLADESH ; ; @@ -370,6 +366,10 @@ StringArray STR_ARR_SVT_LANGUAGE_TABLE Cornish ; LANGUAGE_USER_CORNISH ; ; Sami, Pite (Sweden) ; LANGUAGE_USER_SAMI_PITE_SWEDEN ; ; Ngäbere ; LANGUAGE_USER_NGAEBERE ; ; + Serbian Latin ; LANGUAGE_SERBIAN_LATIN_NEUTRAL ; ; + English, OED spelling (UK) ; LANGUAGE_USER_ENGLISH_UK_OED ; ; + Mongolian Mongolian ; LANGUAGE_MONGOLIAN_MONGOLIAN ; ; + Uzbek Cyrillic ; LANGUAGE_UZBEK_CYRILLIC ; ; }; }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Locale mixup on master (Hebrew is recognized as Hindi)
I did a quick search by your description, and this one looks relevant. c8cfda297691b793048b67affe7b1db08e028c6d And thanks for the checks. Kaplan On Fri, Sep 27, 2013 at 12:06 AM, Eike Rathke er...@redhat.com wrote: Hi Lior, On Wednesday, 2013-09-25 17:46:45 +0200, Lior Kaplan wrote: I've noticed a locale mixup on master when starting LibreOffice from the command line with export LC_ALL=he_IL.UTF-8. While the UI translation is shown in Hebrew, the interface has Hindi (hi) settings (including looking as LTR instead of RTL). If starting with en_US.UTF-8 locale and manually set Hebrew locale in the language setting, I get Gujarati locale settings on restart. Yes, I noticed some quirk in locale selection as well, I'll investigate. It looks like in a localized UI (not en-US) the paired strings of the language list are shifted by an offset of one and display something different than the actual locale. This may be related to a pair being inserted to the original en-US .src file that does not have a translation yet and thus is missing. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Support the FSFE, care about Free Software! https://fsfe.org/support/?erack ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Locale mixup on master (Hebrew is recognized as Hindi)
Hi Lior, On Friday, 2013-09-27 00:06:46 +0200, Eike Rathke wrote: I've noticed a locale mixup on master when starting LibreOffice from the command line with export LC_ALL=he_IL.UTF-8. Yes, I noticed some quirk in locale selection as well, I'll investigate. It looks like in a localized UI (not en-US) the paired strings of the language list are shifted by an offset of one and display something different than the actual locale. This may be related to a pair being inserted to the original en-US .src file that does not have a translation yet and thus is missing. Commit bcfb5f0e9b659d16b72fe0add599dd8ec1a7c098 fixes the symptom. However, the .po / rsc combo (don't know yet which is the cause) should handle the case of a non-translated entry and use en-US instead. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Support the FSFE, care about Free Software! https://fsfe.org/support/?erack pgpq1s8nX265O.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Support in research about newcomers
Hello all, thanks for those who already answered my survey. I am very glad to be supported by this community. If any of you want to contribute to my research, please feel free to answer to survey or to send an email answering: what are the main difficulties faced by newcomer when they want to start contributing to OSS project? Thanks once again -- Igor Fabio Steinmacher Faculty at Computer Sciences Dept. at Universidade Tecnológica Federal do Paraná On Tue, Sep 24, 2013 at 2:26 PM, Igor Steinmacher igorsteinmac...@gmail.com wrote: Hello, I am a PhD Candidate from Brazil. My research is interest is on how to support new contributors during their first steps in the project. My final goal is to verify what kind of tooling is appropriate to support the newcomers overcoming their difficulties when they are willing to contribute to the project. The first step of my reasearch is to find out what are the main obstacles and difficulties faced by these newcomers. My goal is to hear from the community itself. I need your help answering three quick questions available here: http://igor.pro.br/limesurvey/index.php?sid=89755lang=en You will not take more than 10 minutes, and the survey responses does not contain any identifying information about you unless a specific question in the survey has asked for this. Thanks in advance -- Igor Fabio Steinmacher PhD Candidate - IME/University of São Paulo Faculty at Computer Sciences Dept. at Universidade Tecnológica Federal do Paraná ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] minutes of ESC face-to-face ...
Hi all, Michael Meeks wrote (25-09-13 02:30) * do developers have a good overview of bugs filed vs. their module ? (Cor) [...] + concern is that developers may overlook things (Cor) Idea was more to learn how that works for the people. Knowing that, helps me for exmaple to do less, or more effective work (skip actions that I may considered being covered by the way devs tend to act). Answers given were halepful in that respect :) Cheers Cor Great to meet here and have open and effective exchange of ideas ! -- - Cor Nouws - http://nl.libreoffice.org - The Document Foundation Membership Committee Member ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] BSA conversations at Hackathon
Hi all, Reporting-in from the hackathon in Milan regarding some discussions we've had about the BSA. --- Passed-in Variables: Right now the BSA doesn't receive any variables passed-in from LO due to the way that it's embedding in an iframe, but Cloph and Rob think that we can solve that problem by taking most of the BSA out of the iframe, and just using the (invisible) iframe for our communication with Bugzilla. Rob is pretty busy right now, but is hoping to get that implemented soon (Rob: Any guess on timeframe?) --- Version Removal: Rob suggested that we remove the non-release versions from the Version Picker. Given the makeup of our BSA users, that seemed roughly reasonable to me. Cor mentioned that we sometimes have special events where we ask end users to download and test an 'rc, so in those particular cases we might want to re-enable those versions in the BSA *temporarily*. Thoughts? (Joel -- I know you'll want to chime-in here) --- Simplify/de-clutter user interface elements: After a user selects a Component, we could collapse the grid of icons (perhaps fade them down and move them to one side?) and then enlarge the icon of the selected component. This would make that interface element less busy and keep the page cleaner when we start to add more fields in the next steps. [Side note: There are still multiple components for whom there is no unique icon; I think that if we're going to have a grid of icons for components, we need to have a unique icon for each one, otherwise the inconsistency gets confusing] --- That's all for now. Cheers, --R ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 69746] FILEOPEN: empty cell content is overwritten by a multiline cell content
https://bugs.freedesktop.org/show_bug.cgi?id=69746 brigitte.roschew...@hksinformatik.de changed: What|Removed |Added Attachment #86508|0 |1 is obsolete|| --- Comment #6 from brigitte.roschew...@hksinformatik.de --- Created attachment 86615 -- https://bugs.freedesktop.org/attachment.cgi?id=86615action=edit opened sample-file as screenshot (LibreOffice 4.1.1.2) The red marked cells should be empty (see content.xml) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65631] importing visio object causes scaling or distortion of shown object
https://bugs.freedesktop.org/show_bug.cgi?id=65631 --- Comment #7 from Winfried Donkers winfrieddonk...@libreoffice.org --- Problem still present in version 4.1.2.2 Additional information: When inserting a Visio object via copy in Visio and paste special in Libreoffice, the object is inserted correctly, and then changed to a distorted version within a second. Double clicking on the object and performing a bogus change (e.g. change a text by replacing a character (with the same)) makes the distortion go away. I will ask permission to upload the visio object with which I can reproduce this behaviour. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69595] EDITING: Pasting selected pictures and text from web page produce error
https://bugs.freedesktop.org/show_bug.cgi?id=69595 --- Comment #2 from eng.georgigeorg...@gmail.com --- (In reply to comment #1) not reproducibile in 4.1.1.2 under Win7 64bit I see no hanging and no error message after copying and pasting web content from Internet Explorer 10. Here I'm using Firefox (last version). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65631] importing visio object causes scaling or distortion of shown object
https://bugs.freedesktop.org/show_bug.cgi?id=65631 --- Comment #8 from Winfried Donkers winfrieddonk...@libreoffice.org --- Created attachment 86616 -- https://bugs.freedesktop.org/attachment.cgi?id=86616action=edit visio document -sampleb -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65631] importing visio object causes scaling or distortion of shown object
https://bugs.freedesktop.org/show_bug.cgi?id=65631 --- Comment #9 from Winfried Donkers winfrieddonk...@libreoffice.org --- Created attachment 86617 -- https://bugs.freedesktop.org/attachment.cgi?id=86617action=edit writer document with visio sampleb inserted Steps to reproduce (I used Windows 7): -open new writer document (I used version 4.1.2.RC2) -open visio document with visio (I used visio 2007) -select all in visio document -copy (Ctrl C) -go to writer document -paste special (Shift Ctrl V) -select Visio object, OK -the object is inserted and shows OK, but within (half) a second the object is changed to parts of the original image (see attachment) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69461] SLIDESHOW: Inserted Movie files show a white screen for about one frame at the start
https://bugs.freedesktop.org/show_bug.cgi?id=69461 ign_christian ign_christ...@yahoo.com changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from ign_christian ign_christ...@yahoo.com --- Hello.. please let status UNCONFIRMED while filing new bug. Someone (other than reporter) with same or newer version will mark NEW if he/she can confirm that problem. I can't reproduce with LO 4.0.5.2 (Win7 32bit), so let someone confirm that. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65631] importing visio object causes scaling or distortion of shown object
https://bugs.freedesktop.org/show_bug.cgi?id=65631 --- Comment #10 from Winfried Donkers winfrieddonk...@libreoffice.org --- Created attachment 86618 -- https://bugs.freedesktop.org/attachment.cgi?id=86618action=edit writer document with visio sampleb after dummy edit Steps to reproduce: -start with steps in previous comment -double click on object to edit -Visio opens with the correct image -change one little thing (e.g. replace a character in a text) -close Visio -the object in the writer document shows OK now Note: My colleagues report that somewhat similar behaviour sometimes also occurs with other inserted objects, e.g. calc graphs or other (non-Visio) images. I have not been able to reproduce that, but it may be that the cause is not in the libvisio part but in the mebedded object part of LibreOffice. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69461] SLIDESHOW: Inserted Movie files show a white screen for about one frame at the start
https://bugs.freedesktop.org/show_bug.cgi?id=69461 ign_christian ign_christ...@yahoo.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68927] FORMATTING: SVG images are converted to bitmap if used as page wide background
https://bugs.freedesktop.org/show_bug.cgi?id=68927 a07cd040897db54e1...@spambog.com changed: What|Removed |Added Severity|normal |major Priority|medium |high Version|4.1.0.4 release |4.1.1.2 release --- Comment #7 from a07cd040897db54e1...@spambog.com --- Opening the resulting odt file shows, that the SVG ist *not* CONVERTED to bitmap. The folder Pictures still contains the original SVG image. Nevertheless the SVG image is DISPLAYED like it was a bitmap. Even converting to PDF does not change the way the image is displayed. The image still seems like bitmap although the size of the resulting pdf is very small, so that it can *not* really be a a bitmap. So i conclude that the problem is the way LO *displays* the image not the way it is *stored*. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69746] FILEOPEN: empty cell content is overwritten by a multiline cell content
https://bugs.freedesktop.org/show_bug.cgi?id=69746 --- Comment #7 from Markus Mohrhard markus.mohrh...@googlemail.com --- (In reply to comment #6) Created attachment 86615 [details] opened sample-file as screenshot (LibreOffice 4.1.1.2) The red marked cells should be empty (see content.xml) They are empty in my master build. I'll need to check with a 4-1 build next week. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65631] importing visio object causes scaling or distortion of shown object
https://bugs.freedesktop.org/show_bug.cgi?id=65631 Winfried Donkers winfrieddonk...@libreoffice.org changed: What|Removed |Added CC||mst...@redhat.com See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=59405, ||https://bugs.freedesktop.or ||g/show_bug.cgi?id=63799, ||https://bugs.freedesktop.or ||g/show_bug.cgi?id=64265 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63799] FORMATTING: Distorted stencil on copy Paste from Visio 2010
https://bugs.freedesktop.org/show_bug.cgi?id=63799 Winfried Donkers winfrieddonk...@libreoffice.org changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=65631 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64265] Inserted Visio object cannot be edited with Visio
https://bugs.freedesktop.org/show_bug.cgi?id=64265 Winfried Donkers winfrieddonk...@libreoffice.org changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=65631 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68886] EDITING: Changed Arrows are not saved
https://bugs.freedesktop.org/show_bug.cgi?id=68886 --- Comment #10 from thfr th.lostinm...@gmail.com --- Created attachment 86621 -- https://bugs.freedesktop.org/attachment.cgi?id=86621action=edit Video showing that the route of the arrow is saved. Thanks for correcting the status. Since I have made video showing the problem, I might as well upload it here. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68886] EDITING: Changed Arrows are not saved
https://bugs.freedesktop.org/show_bug.cgi?id=68886 thfr th.lostinm...@gmail.com changed: What|Removed |Added Attachment #86621|Video showing that the |Video showing that the description|route of the arrow is |route of the arrow is not |saved. |saved. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68886] EDITING: Changed Arrows are not saved
https://bugs.freedesktop.org/show_bug.cgi?id=68886 --- Comment #11 from ign_christian ign_christ...@yahoo.com --- Created attachment 86622 -- https://bugs.freedesktop.org/attachment.cgi?id=86622action=edit PDF printed on LO 4.0.5.2 Perhaps I'm wrong...I can succesfully change the route to what is seen in this attachment. Same result after closing reopening file. Tested on LO 4.0.5.2 (Win7 32bit) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68886] EDITING: Changed Arrows are not saved
https://bugs.freedesktop.org/show_bug.cgi?id=68886 --- Comment #12 from ign_christian ign_christ...@yahoo.com --- (In reply to comment #10) Created attachment 86621 [details] Video showing that the route of the arrow is saved. Sorry..I've just realized that you attached a video :) Still can't reproduce using that way with LO 4.0.5.2. Looks like a regression.. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69810] FORMATTING gets lost when dragging multiple cells
https://bugs.freedesktop.org/show_bug.cgi?id=69810 GerardF gerard.farg...@orange.fr changed: What|Removed |Added Attachment #86559|text/plain |application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68886] EDITING: Changed Arrows are not saved
https://bugs.freedesktop.org/show_bug.cgi?id=68886 --- Comment #13 from ign_christian ign_christ...@yahoo.com --- I think it's a duplicate to Bug 68104. Same behavior I can't also reproduce bug 68104 with LO 4.0.5.2. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68886] EDITING: Changed Arrows are not saved
https://bugs.freedesktop.org/show_bug.cgi?id=68886 --- Comment #14 from Lars Lischke lisc...@gmx.net --- @Joel: I assume that it worked, but I do not exactly know:( @ign_christian: It looks like Bug 68104. Sorry for duplicate it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50846] Macros: Wrong type of function GetLastUsedRow (standard library Tools, module Misc)
https://bugs.freedesktop.org/show_bug.cgi?id=50846 --- Comment #2 from bugquestcon...@online.de --- It is just a comment as I don't have the expertise to verify the reported bug. JohnSUN is one of top contributors in AskLibO and there is no comment yet on a possible bug fix. Therefore I ask for a look into this bug report and try to find a solution. (I am aware that we have only volunteers as devs and appreciate their work a lot!) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56392] Writer: hyphenation is not always used in line break algorithm
https://bugs.freedesktop.org/show_bug.cgi?id=56392 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard||target:4.2.0 --- Comment #8 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Laszlo Nemeth committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=968f4d72a23bb28d097a7694d66f0b866b3b33f0 fdo#56392 fix hyphenation of words with punctuation The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67756] LibreOffice suddenly stops exporting to PDF: The file could not be written.
https://bugs.freedesktop.org/show_bug.cgi?id=67756 --- Comment #10 from Bernhard theo...@gmx.de --- For me, disabling View pdf after export also solves the problem, as described by BC_Admin. Could it be that with a new account, the option is disabled by default? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69839] New: BASIC: New Label Creation - BAD next record
https://bugs.freedesktop.org/show_bug.cgi?id=69839 Priority: medium Bug ID: 69839 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: BASIC: New Label Creation - BAD next record Severity: normal Classification: Unclassified OS: Linux (All) Reporter: pe...@metodo.net Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.1.1.2 release Component: BASIC Product: LibreOffice Versione: 4.1.1.2 Build ID: 7e4286b58adc75a14f6d83f53a03b6c11fa2903 Problem description: when creating New Label from databse whit the gui: File - New - Label the file created print ONE record/page and not ONE record/LABEL that becouse the file created have a BAD next record field at the end of the labels fields. Steps to reproduce: 1. create a simple database (whit about 10 records) 2. create a New Label Sheet 3. Print the label 4. it will print 10 PAGES any page wiht 1 LABEL instead of 1 PAGE with 10 LABELS Current behavior: Erasing the next record created automatically and replacing whit a new fresh one inserted manually from: Insert - Fileds - Other - Database - SELECT DATABASE - Next Record the label sheet work well. Expected behavior: Correct NEXT RECORD fileds at the end of LABEL. Operating System: Fedora Version: 4.1.1.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69840] New: FILEOPEN general error (IOErrorCode_ACCESS_DENIED) and ERROR_SHARING_VIOLATION when opening OpenDocument file on filesystem on WINDOWS
https://bugs.freedesktop.org/show_bug.cgi?id=69840 Priority: medium Bug ID: 69840 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILEOPEN general error (IOErrorCode_ACCESS_DENIED) and ERROR_SHARING_VIOLATION when opening OpenDocument file on filesystem on WINDOWS Severity: major Classification: Unclassified OS: All Reporter: matthieu@capgemini.com Hardware: Other Status: UNCONFIRMED Version: 4.0.5.2 release Component: framework Product: LibreOffice Hello, The problem is: When I double click on a specific file in the filesystem with LO 4.0.5, then if I change something in the document and I click on save, I have these errors: 1. error saving the document : Access to XXX was denied 2. error saving the document : Access to XXX was denied 3. error saving the document : General Input/Output Error The problem is not happened if I open the file from LO or If I click on Save AS. I think I have this error because of this commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=6523f78456c9f78fb842b7215eb84a96f4e92472h=libreoffice-4-0 As you can see in the comment: this situation may fail on +// Windows with ERROR_SHARING_VIOLATION... but that is apparently +// not a problem in practice currently In version 4.1.1.2 of libreoffice I don't have this problem, it's probably due to this commit: http://cgit.freedesktop.org/libreoffice/core/commit/sfx2/source/doc/docfile.cxx?h=libreoffice-4-1-2id=0c2206081de38a41597aadfb2255540d6308be63 I'll try to backport it to be sure, but I have problem to build on windows (probably antivirus problem) So I can you backport the commit in 4.0.6 Beta in the daily build to test my problem. Sorry, I can't put my test file yet, but I'm working on it to put it less confidential. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69595] EDITING: Pasting selected pictures and text from web page produce error
https://bugs.freedesktop.org/show_bug.cgi?id=69595 --- Comment #3 from tommy27 ba...@quipo.it --- try testing with Explorer and tell me the results. we should understand if the issue in on LibO side or browser side. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69841] New: SetDataArray removes direct formatting
https://bugs.freedesktop.org/show_bug.cgi?id=69841 Priority: medium Bug ID: 69841 Keywords: regression Assignee: libreoffice-bugs@lists.freedesktop.org Summary: SetDataArray removes direct formatting Severity: major Classification: Unclassified OS: All Reporter: pierre-yves.sa...@laposte.net Hardware: Other Status: NEW Version: 4.1.2.1 rc Component: BASIC Product: LibreOffice Created attachment 86629 -- https://bugs.freedesktop.org/attachment.cgi?id=86629action=edit DataArray.ods including DataArray instruction Hello The following statement should only copy the values in the target range: oTargetRange.DataArray = oSourceRange.DataArray Actually, values are copied but the direct formatting is lost. Steps to reproduce: 1 Open the attached spreadsheet (DataArray.ods) 2. Allow macros to run and click on the button Copy values. The expected result is to copy the values from the range A1:E10 to the range A15:E24. This target range is pre-formatted: - Direct formatting in column A and E (borders, background color, number...) - Style formatting in column C. After clicking the button the values must be introduced in the range and formats preserved. Actual result: With plaform (Windows XP Version: 4.1.2.1 Build ID: bf15ac65c2167fb1ef3daf3710609d4a4c369a9) copy values but the direct formatting is lost. Also reproduced (qa-fr) with Vista-32b and Version: 4.1.2.2 Build ID: 281b75f427729060b6446ddb3777b32f957a8fb Last known correct versions : 4.0.5.2 and 4.1.1.2 This technique is widely used in applications so I select major severity even if there is no data loss. May be related to bug 69720 ? Regards Pierre-Yves -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37703] Pictures not pasted into writer when copied from Safari web browser
https://bugs.freedesktop.org/show_bug.cgi?id=37703 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it Summary|Pictures on not pasted into |Pictures not pasted into |writer when copied from |writer when copied from |Sarfari web browser |Safari web browser --- Comment #10 from tommy27 ba...@quipo.it --- @Mac users is issue still there with current 4.0.5 or 4.1.1 releases? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39468] translate German comments, removing redundant ones
https://bugs.freedesktop.org/show_bug.cgi?id=39468 --- Comment #89 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Philipp Riemer committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=1043e4cb3ae68d5684d5725bd743097890ff7eb3 fdo#39468: Translate German comments The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62475] Remove pointless comments and ASCII art
https://bugs.freedesktop.org/show_bug.cgi?id=62475 --- Comment #24 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Philipp Riemer committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ba665a9957955e8306aa5554d8ce59b56751ea02 fdo#62475: remove visual noise The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69595] EDITING: Pasting selected pictures and text from web page produce error
https://bugs.freedesktop.org/show_bug.cgi?id=69595 --- Comment #4 from Tomaz Vajngerl qui...@gmail.com --- When I copy/paste with IE, then it copies only as text into Writer and not as HTML, which I think is the cause why it works fast and with no other problems with IE. When I use Chrome / Firefox to copy the page, Writer tries to parse the HTML into the document structure and this takes some time - however I have no problems with images. It may be that downloading of images timed out - or there was a connection problem in your case. I used the LO daily build because this is the only I have available currently. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69843] New: One cannot enter a whole column as a range
https://bugs.freedesktop.org/show_bug.cgi?id=69843 Priority: medium Bug ID: 69843 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: One cannot enter a whole column as a range Severity: normal Classification: Unclassified OS: Linux (All) Reporter: kaese...@gmail.com Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.1.2.2 rc Component: Spreadsheet Product: LibreOffice This is the problem: - enter some numbers into cells A1:A5 - go into C1 and enter =SUM( - and then try to make click on the A in the column header, which you can't but which used to be possible. This is quite annoying because it means if you want to add more values into A6:A10 and have the sum in C1 updated, you must enter a specific larger range into C1 - you can't just specify 'the whole column however far down it is', which would be the intuitive thing to do. Even more counterintuitively: if you create a Pivot table by - highlighting multiple columns by clicking on the column headers - then clicking: Data: Pivot Table: Create then the Select Source window says Highlight Selection, which is after all the whole column, but then the Pivot table data range in the next window is really only until the bottommost data point (say, C22) so when you add new data and refresh the Pivot Table, new stuff one may have entered is not included even though I created the Pivot table from the selection, which was the whole column. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48783] Clipboard cleared on exit on Linux
https://bugs.freedesktop.org/show_bug.cgi?id=48783 Christopher M. Penalver christopher.m.penal...@gmail.com changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #8 from Christopher M. Penalver christopher.m.penal...@gmail.com --- Marking back to NEW unless there is a non-robo discussion/discourse to address. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56392] Writer: hyphenation is not always used in line break algorithm
https://bugs.freedesktop.org/show_bug.cgi?id=56392 --- Comment #9 from László Németh nem...@numbertext.org --- Created attachment 86631 -- https://bugs.freedesktop.org/attachment.cgi?id=86631action=edit test file with different test cases -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56392] Writer: hyphenation is not always used in line break algorithm
https://bugs.freedesktop.org/show_bug.cgi?id=56392 --- Comment #10 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Laszlo Nemeth committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=634f1d11d2a027887807494b3ca67f33825d5d23 fdo#56392 fix hyph. of words with single punctuation marks The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56392] Writer: hyphenation is not always used in line break algorithm
https://bugs.freedesktop.org/show_bug.cgi?id=56392 --- Comment #11 from László Németh nem...@numbertext.org --- Created attachment 86632 -- https://bugs.freedesktop.org/attachment.cgi?id=86632action=edit screenshots (bad and fixed hyphenation) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56392] Writer: hyphenation is not always used in line break algorithm
https://bugs.freedesktop.org/show_bug.cgi?id=56392 László Németh nem...@numbertext.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #12 from László Németh nem...@numbertext.org --- Fixed this problem and the other one (compound words with hyphen signs) in master. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54157] LibreOffice 4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 56392, which changed state. Bug 56392 Summary: Writer: hyphenation is not always used in line break algorithm https://bugs.freedesktop.org/show_bug.cgi?id=56392 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68104] FILESAVE: Lines get modified after saving and reopenning a drawing
https://bugs.freedesktop.org/show_bug.cgi?id=68104 thfr th.lostinm...@gmail.com changed: What|Removed |Added Hardware|x86-64 (AMD64) |All --- Comment #11 from thfr th.lostinm...@gmail.com --- I confirmed it on Windows as well (x86 Version on x86_64 Windows) with the LO 4.1.1.2 and as stated in Bug 68886 , the problem does not occur in LO 4.0.5.2. After changing back from LO 4.1.1.2 to 4.0.5.2, I loaded a document which was last edited with version 4.1.1.2 and the problem did not occur. So the arrow properties seem to be saved, but not loaded properly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69844] New: Table does not resize when containing equation gets smaller
https://bugs.freedesktop.org/show_bug.cgi?id=69844 Priority: medium Bug ID: 69844 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Table does not resize when containing equation gets smaller Severity: normal Classification: Unclassified OS: All Reporter: mahf...@gmail.com Hardware: Other Status: UNCONFIRMED Version: 4.1.0.0.beta2 Component: Writer Product: LibreOffice Table in Writer does not resize if it contains a taller equation and the equation is made smaller. 1. Create a table with any number of cells. One does fine. 2. Inside the table place a equation (Insert → Object → Equation) 3. Make the equation taller, e.g σ = F over A 4. Make the equation smaller again, e.g replace the equation with simply F = 0. 5. See that the table remains tall and does not resize. 6. Save the document and open it again, everything looks fine now. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69770] Other: Samba
https://bugs.freedesktop.org/show_bug.cgi?id=69770 --- Comment #5 from rmfbe...@gmail.com --- The problem started with the upgrade to version 4.1.1.2, have tested version 4.1.2.2 and the problem continues. The libreoffice informs that the file is in the sharing is open by another user. 2013/9/25 bugzilla-dae...@freedesktop.org *Comment # 4 https://bugs.freedesktop.org/show_bug.cgi?id=69770#c4 on bug 69770 https://bugs.freedesktop.org/show_bug.cgi?id=69770 from ign_christian ign_christ...@yahoo.com * Rmfbekao, please don't reply directly from email. Use link to this bug instead to replying. Regarding Bug 67534 https://bugs.freedesktop.org/show_bug.cgi?id=67534 from what Maxim told, could you confirm that LO version in Win7 Debian using 4.1.x? Have you tried 4.0.4.2 in both OS? -- You are receiving this mail because: - You reported the bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67534] FILEOPEN SMB File claimed to be Locked By Unknown User when opened via double-click in Explorer
https://bugs.freedesktop.org/show_bug.cgi?id=67534 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Version|4.1.0.4 release |4.0.5.2 release --- Comment #45 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Due to several comments, changed version for the earliest where users experienced the bug: 4.0.5 Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67506] Impress starts with first slide regardless of setting in options
https://bugs.freedesktop.org/show_bug.cgi?id=67506 ine...@aon.at ine...@aon.at changed: What|Removed |Added CC||ine...@aon.at --- Comment #9 from ine...@aon.at ine...@aon.at --- same error here with LibreOffice 4.1.1.2 (Build ID: 7e4286b58adc75a14f6d83f53a03b6c11fa2903) running on Mac OSX 10.8.5 I do my 5 different lectures in one presentation file each. They have 200-300 slides per file. Need to click 280 times to reach slide 280 is annoying! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56392] Writer: hyphenation is not always used in line break algorithm
https://bugs.freedesktop.org/show_bug.cgi?id=56392 --- Comment #13 from László Németh nem...@numbertext.org --- A post about the fix: http://libreoffice.hu/2013/09/26/better-document-layout-interoperability-by-fixing-old-and-ugly-hyphenation-bugs/ stfhell: many thanks for your bug report! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69781] Formulas incorrect after inserting rows.
https://bugs.freedesktop.org/show_bug.cgi?id=69781 --- Comment #7 from dlw dt...@gmx.com --- Forgive me for replying via email. My user name and password do not work when trying to login. I only have one username and two passwords and neither work. The method used below is correct. I downloaded 4.1 and it doesn't work there either. The method you sent works great. =IF(A2=;;OFFSET(A2;-1;1)+A2) If I can not continue to log in I will create a new user. Thanks, dlw Link to my post: [1]http://en.libreofficeforum.org/node/6727 -- The problem is not the gun, the problem is the person pulling the trigger. On Wed, Sep 25, 2013, at 07:27 PM, [2]bugzilla-dae...@freedesktop.org wrote: [3]ign_christian changed [4]bug 69781 What Removed Added OS Linux (All) All CC ign_christ...@yahoo.com [5]Comment # 6 on [6]bug 69781 from [7]ign_christian Dlw, please don't reply directly from email. Use link to this bug instead to replying. Someone on the forum said to report it as a bug. Could you please post link to the forum in this bug report? You could use PPA to upgrade that is recommended for Ubuntu based distro: [8]https://launchpad.net/~libreoffice/+archive/ppa Short hint: [9]http://askubuntu.com/questions/16695/how-do-i-install-the-latest-version-of-l ibreoffice Anyway I could produce same behavior using LO 4.0.5.2 (Win7 32bit). I'll try to explain the steps with more detail: 1. Copy row 3 2. Mark all rows 4,5,6 right-click Insert Rows right-click Paste 3. See that cell B7 =IF(A7=;;B3+A7) and cell B8 =IF(A8=;;B7+A8) - there were inconsistency since B3 looks like locked in cell B7, but that's not happen in cell B8 cell B9 @Dlw, could you confirm that was procedure you were using to reproduce? __ You are receiving this mail because: * You reported the bug. References 1. http://en.libreofficeforum.org/node/6727 2. mailto:bugzilla-dae...@freedesktop.org 3. mailto:ign_christ...@yahoo.com 4. https://bugs.freedesktop.org/show_bug.cgi?id=69781 5. https://bugs.freedesktop.org/show_bug.cgi?id=69781#c6 6. https://bugs.freedesktop.org/show_bug.cgi?id=69781 7. mailto:ign_christ...@yahoo.com 8. https://launchpad.net/~libreoffice/+archive/ppa 9. http://askubuntu.com/questions/16695/how-do-i-install-the-latest-version-of-libreoffice -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42092] SVG vector graphics exported as bitmaps to PDF
https://bugs.freedesktop.org/show_bug.cgi?id=42092 a07cd040897db54e1...@spambog.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=68927 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68927] FORMATTING: SVG images are converted to bitmap if used as page wide background
https://bugs.freedesktop.org/show_bug.cgi?id=68927 a07cd040897db54e1...@spambog.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=42092 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68828] FORMATTING: formatting issues with calibre demo doc
https://bugs.freedesktop.org/show_bug.cgi?id=68828 Teo91 mcavaller...@gmail.com changed: What|Removed |Added OS|Linux (All) |All Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Teo91 mcavaller...@gmail.com --- Confirmed with LO 4.1.2.2 on Windows 7. Both image bullet and indented table are displayed incorrectly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68044] This presentation always crashes LibreOffice Impress when press F5 for presenting
https://bugs.freedesktop.org/show_bug.cgi?id=68044 --- Comment #10 from Roger roger.pow...@brunel.ac.uk --- Apologies but this is no longer a problem for me. Whether it was this morning's two updates that did the trick (tiff libraries?) I don't know. But F5 no longer crashes LO Impress. All is working perfectly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68334] EDITING: The same .odt file has different formatting results (4.0 vs. 4.1)
https://bugs.freedesktop.org/show_bug.cgi?id=68334 --- Comment #21 from Thomas Pulzer t.pul...@kniel.de --- minhsien0330: On a fresh installed Fedora 19 with recent updates (20130926) and additional installed LO 4.0.5.2 with your latest template (offset6.odt) following behavior occured: Before the installation of the font you provided, both version span the document over two pages. After the installation of said font, LO 4.0.5.2 displays a two-paged document, whereas LO 4.1.1.2 does display two pages of the document, but the table fills only the first page. Strange about is, that in LO 4.1.1.2 the font shows as not installed in the font picker. Compatibility settings are the same for both program versions. From my point of view, this is a bug earning the status 'confirmed'. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68044] This presentation always crashes LibreOffice Impress when press F5 for presenting
https://bugs.freedesktop.org/show_bug.cgi?id=68044 --- Comment #11 from tommy27 ba...@quipo.it --- @Roger nice to hear that @Krasimir @poky do you guys still experience the bug? if not we could mark it as RESOLVED WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69744] Data in Visual FoxPro DBF is garbled
https://bugs.freedesktop.org/show_bug.cgi?id=69744 --- Comment #4 from Urmas davian...@gmail.com --- I think VFP screenshot gives an unambiguous answer whether this is an LO bug or not. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68334] EDITING: The same .odt file has different formatting results (4.0 vs. 4.1)
https://bugs.freedesktop.org/show_bug.cgi?id=68334 --- Comment #22 from Thomas Pulzer t.pul...@kniel.de --- Created attachment 86637 -- https://bugs.freedesktop.org/attachment.cgi?id=86637action=edit Screenshot of offset6.odt in LO 4.0.5.2 Screenshot for Comment #21, showing the behavior of LO 4.0.5.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68334] EDITING: The same .odt file has different formatting results (4.0 vs. 4.1)
https://bugs.freedesktop.org/show_bug.cgi?id=68334 --- Comment #23 from Thomas Pulzer t.pul...@kniel.de --- Created attachment 86638 -- https://bugs.freedesktop.org/attachment.cgi?id=86638action=edit Screenshot of offset6.odt in LO 4.1.1.2 Screenshot for Comment #21, showing the behavior of LO 4.1.1.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68334] EDITING: The same .odt file has different formatting results (4.0 vs. 4.1)
https://bugs.freedesktop.org/show_bug.cgi?id=68334 --- Comment #24 from Thomas Pulzer t.pul...@kniel.de --- (In reply to comment #21) minhsien0330: On a fresh installed Fedora 19 with recent updates (20130926) and additional installed LO 4.0.5.2 with your latest template (offset6.odt) following behavior occured: Before the installation of the font you provided, both version span the document over two pages. After the installation of said font, LO 4.0.5.2 displays a two-paged document, whereas LO 4.1.1.2 does display two pages of the document, but the table fills only the first page. Strange about is, that in LO 4.1.1.2 the font shows as not installed in the font picker. Compatibility settings are the same for both program versions. From my point of view, this is a bug earning the status 'confirmed'. I did not notice, that you changed the font to Liberation Sans. So, I'm curious, why the .odt thinks, it's still cwTeX 粗黑體. That could explain the strange behavior after installing this font. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68044] This presentation always crashes LibreOffice Impress when press F5 for presenting
https://bugs.freedesktop.org/show_bug.cgi?id=68044 --- Comment #12 from Krasimir Ivanov k...@mail.orbitel.bg --- Unfortunately I still have same problem. The LibreOffice crashes immediately after pressing F5 Now I am using LibreOffice Version: 4.1.1.2 Build ID: 7e4286b58adc75a14f6d83f53a03b6c11fa2903 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
