LibreOffice Gerrit News 2013-10-12
Moin! * Open changes on master for project core changed in the last 25 hours: + fdo#70383: move libpng to a subdir of external in https://gerrit.libreoffice.org/6231 from Björn Michaelsen + Introduce unit test for the replace functionnality in Writer. in https://gerrit.libreoffice.org/6184 from Arnaud Versini + don't include unused tools/string.hxx in https://gerrit.libreoffice.org/6206 from Christina Roßmanith + fdo#60071: Don't export SDNUM and SDVAL options to HTML in https://gerrit.libreoffice.org/6194 from Thomas Arnhold + Code changes unit tests for fixing multicolumn section separator line i in https://gerrit.libreoffice.org/6211 from Yogesh Bharate + fdo#7 add support for COVARIANCE.P and COVARIANCE.S functions in https://gerrit.libreoffice.org/6135 from Winfried Donkers + fdo#61950 De-externalize Presentation Minimizer in https://gerrit.libreoffice.org/6143 from David Ostrovsky + sw: Smart-Art related UTs updated to new option in https://gerrit.libreoffice.org/6139 from Andres Gomez + unotools: add menu option to enable/disable Smart-Art lock in https://gerrit.libreoffice.org/6138 from Andres Gomez + oox: added methods to lock Smart-Art edition in https://gerrit.libreoffice.org/6059 from Andres Gomez * Merged changes on master for project core changed in the last 25 hours: + Fix for Corruption of chart due to Data Lables in Writer, Impress and Cal in https://gerrit.libreoffice.org/6090 from Rohit Deshmukh + fdo#66399 - fix rendering of 'two lines in one' in https://gerrit.libreoffice.org/6187 from Adam CloudOn + iOS experimental app support for selection marking via long press gesture in https://gerrit.libreoffice.org/5911 from Ptyl * Abandoned changes on master for project core changed in the last 25 hours: + fdo#54533: Fixes text/csv import while using 'Link to external data' in c in https://gerrit.libreoffice.org/6190 from Viktor Varga * Open changes needing tweaks, but being untouched for more than a week: + Make libatomic_ops buildable and enable on non-X86. in https://gerrit.libreoffice.org/5812 from Andrzej J.R. Hunt + Remove obsolete MIME associatons on MAC OS in https://gerrit.libreoffice.org/6103 from Samuel Mehrbrodt + Increase number of remembered recent documents from 10 to 25 in https://gerrit.libreoffice.org/6101 from Krisztian Pinter + startcenter: Make SC open faster by timeouting thumbnails in https://gerrit.libreoffice.org/6102 from Krisztian Pinter + Remove old outdated gallery images and sounds in https://gerrit.libreoffice.org/4993 from Samuel Mehrbrodt + fdo#69407 Putting no fill frame color instead of transparent by default in https://gerrit.libreoffice.org/5996 from matthieu gay + Remove more unusedcode in https://gerrit.libreoffice.org/5937 from Marcos Souza + Simplify oslThreadIdentifier on Linux 32. in https://gerrit.libreoffice.org/5553 from Arnaud Versini + fix polygon rendering with clip area of one line only in https://gerrit.libreoffice.org/5709 from Tsahi Glik @ CloudOn + Dynamically align toolbars in LibreOffice in https://gerrit.libreoffice.org/5655 from Prashant Pandey + fdo#36791 : fix for import of greeting card in https://gerrit.libreoffice.org/4240 from Adam CloudOn + more debug logs, extra debug layer, file is not used in p3k in https://gerrit.libreoffice.org/5267 from James Michael Dupont + Positional Tab additions in https://gerrit.libreoffice.org/5387 from Adam CloudOn + fdo#64817 : fix for rectangle with image fill in https://gerrit.libreoffice.org/4718 from Adam CloudOn Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 3 commits - avmedia/source basctl/source
avmedia/source/vlc/wrapper/SymbolLoader.hxx |4 ++--
basctl/source/basicide/baside2.cxx |5 +
basctl/source/basicide/baside3.cxx |6 +++---
3 files changed, 10 insertions(+), 5 deletions(-)
New commits:
commit 81f94edc6341b4c898d8109ed50260de9ed06504
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 09:34:51 2013 +0300
What (who?) are OW and MTF?
Change-Id: I47b9b91d72e423c0ef37eaa9f081e755adfc36d6
diff --git a/basctl/source/basicide/baside2.cxx
b/basctl/source/basicide/baside2.cxx
index 667bae5..7080371 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -72,6 +72,11 @@ namespace Print
short const ValidWindow = 0x1234;
+// What (who) are OW and MTF? Compare to baside3.cxx where an
+// identically named variable, used in the same way, has the value
+// *.* on Windows, * otherwise. Is that what should be done here,
+// too?
+
#if defined(OW) || defined(MTF)
char const FilterMask_All[] = *;
#else
commit 5705102c02fefa715426424f0536d675c3faee68
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 09:30:34 2013 +0300
Test WNT instead of the vague UNX
Change-Id: I99aa82d29d056afde92d258fd5cdf13359f9b74c
diff --git a/basctl/source/basicide/baside3.cxx
b/basctl/source/basicide/baside3.cxx
index a6c73d1..b22db95 100644
--- a/basctl/source/basicide/baside3.cxx
+++ b/basctl/source/basicide/baside3.cxx
@@ -64,10 +64,10 @@ using namespace ::com::sun::star::io;
using namespace ::com::sun::star::resource;
using namespace ::com::sun::star::ui::dialogs;
-#if defined(UNX)
-char const FilterMask_All[] = *;
-#else
+#ifdef WNT
char const FilterMask_All[] = *.*;
+#else
+char const FilterMask_All[] = *;
#endif
DBG_NAME( DialogWindow )
commit f1b956f5aaa83b53b1217d85be24d71d6379e97e
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 09:26:17 2013 +0300
s/UNX/LINUX/, as that is what is meant here
Change-Id: I6b58f6f62bc304b29c336fc46f87bce8d2ce22fe
diff --git a/avmedia/source/vlc/wrapper/SymbolLoader.hxx
b/avmedia/source/vlc/wrapper/SymbolLoader.hxx
index 7061faf..e7db7a7 100644
--- a/avmedia/source/vlc/wrapper/SymbolLoader.hxx
+++ b/avmedia/source/vlc/wrapper/SymbolLoader.hxx
@@ -34,7 +34,7 @@ struct ApiMap
namespace
{
-#if defined( UNX )
+#if defined( LINUX )
const char LibName[] = libvlc.so.5;
#elif defined( MACOSX )
const char LibName[] =
/Applications/VLC.app/Contents/MacOS/lib/libvlc.dylib;
@@ -92,7 +92,7 @@ namespace
templatesize_t N
bool InitApiMap( const ApiMap ( pMap )[N] )
{
-#if defined( UNX ) || defined( MACOSX )
+#if defined( LINUX ) || defined( MACOSX )
const OUString fullPath = OUString::createFromAscii(LibName);
#elif defined( WNT )
const OUString fullPath = GetVLCPath() +
OUString::createFromAscii(LibName);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - basic/source
basic/source/classes/propacc.cxx | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
New commits:
commit 9097611359d37003c9ac5b253dd592fed17e0aae
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 09:45:17 2013 +0300
We already have SAL_CALL that means __cdecl on Windows
Not that there should be any need to use it here; it is the default anyway.
Also the extern C is bogus here as far as I know; that affects only the
external name of the function, and that a function is passed to bsearch()
doesn't set any requirements on the external name of it. It could be a
static
function with no global symbol name. But oh well.
Change-Id: Ia264bf2f952fd6f38aa36a25a084383d4d3f1bdc
diff --git a/basic/source/classes/propacc.cxx b/basic/source/classes/propacc.cxx
index 81fd946..2ea51d4 100644
--- a/basic/source/classes/propacc.cxx
+++ b/basic/source/classes/propacc.cxx
@@ -33,13 +33,6 @@ using namespace com::sun::star::lang;
using namespace com::sun::star::beans;
using namespace cppu;
-#ifdef WNT
-#define CDECL _cdecl
-#endif
-#if defined(UNX)
-#define CDECL
-#endif
-
struct SbCompare_UString_PropertyValue_Impl
{
bool operator() (const OUString lhs, PropertyValue const rhs)
@@ -58,7 +51,7 @@ struct SbCompare_UString_PropertyValue_Impl
#endif
};
-extern C int CDECL SbCompare_UString_Property_Impl( const void *arg1, const
void *arg2 )
+extern C int SAL_CALL SbCompare_UString_Property_Impl( const void *arg1,
const void *arg2 )
{
const OUString *pArg1 = (OUString*) arg1;
const Property *pArg2 = (Property*) arg2;
commit 7329fbd9c48a264bf917f43db3f50d3ab031ae64
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 09:42:24 2013 +0300
Bin two unused functions
Change-Id: I8362bfa0152f84a425ea3d461653d45c07816b92
diff --git a/basic/source/classes/propacc.cxx b/basic/source/classes/propacc.cxx
index 48e56c2..81fd946 100644
--- a/basic/source/classes/propacc.cxx
+++ b/basic/source/classes/propacc.cxx
@@ -40,11 +40,6 @@ using namespace cppu;
#define CDECL
#endif
-int CDECL SbCompare_PropertyValues_Impl( const void *arg1, const void *arg2 )
-{
- return ((PropertyValue*)arg1)-Name.compareTo( ((PropertyValue*)arg2)-Name
);
-}
-
struct SbCompare_UString_PropertyValue_Impl
{
bool operator() (const OUString lhs, PropertyValue const rhs)
@@ -63,11 +58,6 @@ struct SbCompare_UString_PropertyValue_Impl
#endif
};
-int CDECL SbCompare_Properties_Impl( const void *arg1, const void *arg2 )
-{
- return ((Property*)arg1)-Name.compareTo( ((Property*)arg2)-Name );
-}
-
extern C int CDECL SbCompare_UString_Property_Impl( const void *arg1, const
void *arg2 )
{
const OUString *pArg1 = (OUString*) arg1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - basic/source
basic/source/comp/parser.cxx |6 +++---
basic/source/runtime/methods.cxx | 19 ++-
basic/source/sbx/sbxscan.cxx |2 --
3 files changed, 9 insertions(+), 18 deletions(-)
New commits:
commit ff7ba8c81c3b00722e58ed01a1ab361094aeb609
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 10:08:08 2013 +0300
Nothing Unix-specific about stdlib.h
Although unsure whether this source file actually uses anything declared in
stdlib.h...
Change-Id: Ibb5dfe5d0de1576a37a5f2c9cffcd9b850602b14
diff --git a/basic/source/sbx/sbxscan.cxx b/basic/source/sbx/sbxscan.cxx
index 4c919d5..724c5fa 100644
--- a/basic/source/sbx/sbxscan.cxx
+++ b/basic/source/sbx/sbxscan.cxx
@@ -23,9 +23,7 @@
#include unotools/syslocale.hxx
-#if defined ( UNX )
#include stdlib.h
-#endif
#include vcl/svapp.hxx
#include math.h
commit b680e352546dc614f3b30bbe212e6b415a6a6bf4
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 09:55:48 2013 +0300
Test WNT instead of the vague UNX
Change-Id: Icacdae592f05bcdcf50223d607976d687e182c96
diff --git a/basic/source/comp/parser.cxx b/basic/source/comp/parser.cxx
index 8ac380f..6c31a12 100644
--- a/basic/source/comp/parser.cxx
+++ b/basic/source/comp/parser.cxx
@@ -856,10 +856,10 @@ void SbiParser::AddConstants( void )
addStringConst( aPublics, vbCrLf, \x0D\x0A );
addStringConst( aPublics, vbFormFeed, \x0C );
addStringConst( aPublics, vbLf, \x0A );
-#if defined(UNX)
-addStringConst( aPublics, vbNewLine, \x0A );
-#else
+#ifndef WNT
addStringConst( aPublics, vbNewLine, \x0D\x0A );
+#else
+addStringConst( aPublics, vbNewLine, \x0A );
#endif
addStringConst( aPublics, vbNullString, );
addStringConst( aPublics, vbTab, \x09 );
diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index 4167152..549c561 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -79,6 +79,7 @@ using namespace com::sun::star::uno;
#include stdio.h
#include stdlib.h
#include ctype.h
+#include errno.h
SbxVariable* getDefaultProp( SbxVariable* pRef );
@@ -86,11 +87,6 @@ SbxVariable* getDefaultProp( SbxVariable* pRef );
#include direct.h // _getdcwd get current work directory, _chdrive
#endif
-#ifdef UNX
-#include errno.h
-#include unistd.h
-#endif
-
#include basic/sbobjmod.hxx
#ifdef WNT
@@ -399,11 +395,6 @@ RTLFUNC(ChrW)
implChr( rPar, bChrW );
}
-
-#ifdef UNX
-#define _PATH_INCR 250
-#endif
-
RTLFUNC(CurDir)
{
(void)pBasic;
@@ -449,9 +440,11 @@ RTLFUNC(CurDir)
}
delete [] pBuffer;
-#elif defined( UNX )
+#else
+
+const int PATH_INCR = 250;
-int nSize = _PATH_INCR;
+int nSize = PATH_INCR;
char* pMem;
while( true )
{
@@ -474,7 +467,7 @@ RTLFUNC(CurDir)
return;
}
delete [] pMem;
-nSize += _PATH_INCR;
+nSize += PATH_INCR;
};
#endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: ATTENTION, creators of mysql-connector-ooo.oxt (--enable-ext-mariadb-connector)
Hi Stephan, After your changes, the new version seems to work flawlessly :) I will update a new version for the MySQL Connector to the templates site for LibO 4.1 after it has been properly tested (beginning of the next week). Additionally if someone wants to help with the test, feel free to message me and I will send you the extensions. Cheers, 2013/10/11 Stephan Bergmann sberg...@redhat.com If you use the LO git repo to build the mysql-connector-ooo.oxt extension (via --enable-ext-mariadb-**connector, formerly --enable-ext-mysql-connector) and then use/distribute that extension as a non-bundled extension (i.e., not unzip it into a LO installation's share/extensions/ directory): Please be aware that doing so off the LO git libreoffice-4-1[-*] and master (towards LO 4.2) branches leads to a broken extension that should not be distributed. What is broken is detailed at http://cgit.freedesktop.org/** libreoffice/core/commit/?id=**3bafe5f5f529f6539363c5a291dd13**ef1e2cbbdehttp://cgit.freedesktop.org/libreoffice/core/commit/?id=3bafe5f5f529f6539363c5a291dd13ef1e2cbbde Extension shared library components must not use the 'prefix' feature, along with a fix of the problem, for which I also requested backports to libreoffice-4-1 (https://gerrit.libreoffice.**org/#/c/6209/https://gerrit.libreoffice.org/#/c/6209/) and libreoffice-4-1-3 (https://gerrit.libreoffice.**org/#/c/6210/https://gerrit.libreoffice.org/#/c/6210/ ). A further reason I'm so panicky about not distributing any broken versions is that there are cooking up changes to the UNO component prefix feature that would make it desirable that no non-bundled extension ever used that prefix feature. In the wild, I find: * http://extensions.**libreoffice.org/extension-** center/mysql-native-connector-**for-libreoffice-4.xhttp://extensions.libreoffice.org/extension-center/mysql-native-connector-for-libreoffice-4.x MySQL Native Connector for LibreOffice 4.x from an UNKNOWN UPLOADER, which only offers http://extensions.**libreoffice.org/extension-** center/mysql-native-connector-**for-libreoffice-4.x/releases/** 1.0/mysql-connector-ooo.oxthttp://extensions.libreoffice.org/extension-center/mysql-native-connector-for-libreoffice-4.x/releases/1.0/mysql-connector-ooo.oxt which is apparently too old to be affected. * http://extensions.**libreoffice.org/extension-** center/mysql-native-connectorhttp://extensions.libreoffice.org/extension-center/mysql-native-connector MySQL Native Connector from an UKNOWN UPLOADER which only offers http://extensions.**libreoffice.org/extension-** center/mysql-native-connector/**releases/1.0/mysql-native-** connector-32-bit/viewhttp://extensions.libreoffice.org/extension-center/mysql-native-connector/releases/1.0/mysql-native-connector-32-bit/view and http://extensions.**libreoffice.org/extension-** center/mysql-native-connector/**releases/1.0/mysql-native-** connector-64-bit/viewhttp://extensions.libreoffice.org/extension-center/mysql-native-connector/releases/1.0/mysql-native-connector-64-bit/view which both are apparently too old to be affected. * http://sourceforge.net/**projects/**lomysqlconnectorextension/http://sourceforge.net/projects/lomysqlconnectorextension/ by Alex Thurgood, which /is/ affected. Alex, can you make available a fixed build there, either off master past http://cgit.freedesktop.org/** libreoffice/core/commit/?id=**3bafe5f5f529f6539363c5a291dd13**ef1e2cbbdehttp://cgit.freedesktop.org/libreoffice/core/commit/?id=3bafe5f5f529f6539363c5a291dd13ef1e2cbbde or off libreoffice-4-1 past pending integration of https://gerrit.libreoffice.**org/#/c/6209/https://gerrit.libreoffice.org/#/c/6209/ ? Andreas, can you contact the uploaders of the two extensions marked UNKNOWN UPLOADER above, to make sure they do not inadvertently upload broken versions? Thanks, Stephan __**_ LibreOffice mailing list LibreOffice@lists.freedesktop.**org LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/**mailman/listinfo/libreofficehttp://lists.freedesktop.org/mailman/listinfo/libreoffice -- Jesús Corrius je...@softcatala.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70371] Identify unused headers
https://bugs.freedesktop.org/show_bug.cgi?id=70371 --- Comment #2 from Jelle van der Waa je...@vdwaa.nl --- Created attachment 87504 -- https://bugs.freedesktop.org/attachment.cgi?id=87504action=edit compares workdir files with git ls-tree -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70371] Identify unused headers
https://bugs.freedesktop.org/show_bug.cgi?id=70371 --- Comment #3 from Jelle van der Waa je...@vdwaa.nl --- (In reply to comment #2) Created attachment 87504 [details] compares workdir files with git ls-tree This is a work in progress quickly hacked perl script, which should do what is descibed in the request. Example output: http://sprunge.us/CZSh Note: I've disabled some options when compiling so there might be some false-positives ;) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70371] Identify unused headers
https://bugs.freedesktop.org/show_bug.cgi?id=70371 --- Comment #4 from Jorendc jore...@libreoffice.org --- (In reply to comment #0) This might still create some false positives because of e.g. platform dependant files, but it should be a good starting point: Obviously such headers if truly unused, should be removed from the repository tree. Just a thought from a non-developer: what if we combine the output of all platforms (tinderboxes for example)? If header 'A' comes up in all output files, we can be (almost?) sure it isn't platform dependent. Isn't it? Kind regards, Joren -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: ATTENTION, creators of mysql-connector-ooo.oxt (--enable-ext-mariadb-connector)
Hello Jesús, *, On Samstag, 12. Oktober 2013 12:17 Jesús Corrius wrote: After your changes, the new version seems to work flawlessly :) I will update a new version for the MySQL Connector to the templates site for LibO 4.1 after it has been properly tested (beginning of the next week). Additionally if someone wants to help with the test, feel free to message me and I will send you the extensions. just out of interest: For which OS/archticture did you build your extension? If you have one for Debian/AMD64, I can help to test it a little bit (but have to add, that I am using MariaDB here, if this does make any difference ... ;) ). Read you Thomas. TOFU removed -- Pardon me while I laugh. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: i18nlangtag/qa i18nlangtag/source
i18nlangtag/qa/cppunit/test_languagetag.cxx| 18 +++
i18nlangtag/source/languagetag/languagetag.cxx | 38 +
2 files changed, 51 insertions(+), 5 deletions(-)
New commits:
commit 79fc6b82b7071262ec71c27f81e68b7d274ae695
Author: Eike Rathke er...@redhat.com
Date: Sat Oct 12 15:04:37 2013 +0200
for unmapped language-only register primary language ID if available
... instead of an on-the-fly ID
Change-Id: I5cb38e91b67d02f0ccda90feb2ad0c60cd3765c5
diff --git a/i18nlangtag/qa/cppunit/test_languagetag.cxx
b/i18nlangtag/qa/cppunit/test_languagetag.cxx
index 91ef1ef..8a055be 100644
--- a/i18nlangtag/qa/cppunit/test_languagetag.cxx
+++ b/i18nlangtag/qa/cppunit/test_languagetag.cxx
@@ -324,6 +324,24 @@ void TestLanguageTag::testAllTags()
CPPUNIT_ASSERT( de_DE.getLanguageType() == LANGUAGE_GERMAN );
}
+// Unmapped but known language-only.
+{
+OUString s_de( de );
+LanguageTag de( s_de, true );
+lang::Locale aLocale = de.getLocale();
+CPPUNIT_ASSERT( de.getBcp47() == s_de );
+CPPUNIT_ASSERT( aLocale.Language == de );
+CPPUNIT_ASSERT( aLocale.Country == );
+CPPUNIT_ASSERT( aLocale.Variant == );
+LanguageType de_LangID = de.getLanguageType();
+CPPUNIT_ASSERT( de_LangID != LANGUAGE_GERMAN );
+CPPUNIT_ASSERT( MsLangId::getPrimaryLanguage( de_LangID) ==
MsLangId::getPrimaryLanguage( LANGUAGE_GERMAN) );
+CPPUNIT_ASSERT( de.makeFallback().getBcp47() == de-DE);
+// Check registered mapping.
+LanguageTag de_l( de_LangID);
+CPPUNIT_ASSERT( de_l.getBcp47() == s_de );
+}
+
// 'de-1901' derived from 'de-DE-1901' grandfathered to check that it is
// accepted as (DIGIT 3ALNUM) variant
{
diff --git a/i18nlangtag/source/languagetag/languagetag.cxx
b/i18nlangtag/source/languagetag/languagetag.cxx
index 02225a4..fc1f5b5 100644
--- a/i18nlangtag/source/languagetag/languagetag.cxx
+++ b/i18nlangtag/source/languagetag/languagetag.cxx
@@ -308,9 +308,13 @@ private:
/** Generates on-the-fly LangID and registers the maBcp47,mnLangID pair.
+@param nRegisterID
+If not 0 and not LANGUAGE_DONTKNOW, use that ID instead of
+generating an on-the-fly ID.
+
@return NULL if no ID could be obtained or registration failed.
*/
-LanguageTag::ImplPtr registerOnTheFly();
+LanguageTag::ImplPtr registerOnTheFly( LanguageType nRegisterID );
/** Obtain Language, Script, Country and Variants via simpleExtract() and
assign them to the cached variables if successful.
@@ -592,7 +596,7 @@ LanguageTag::~LanguageTag()
}
-LanguageTag::ImplPtr LanguageTagImpl::registerOnTheFly()
+LanguageTag::ImplPtr LanguageTagImpl::registerOnTheFly( LanguageType
nRegisterID )
{
LanguageTag::ImplPtr pImpl;
@@ -640,7 +644,8 @@ LanguageTag::ImplPtr LanguageTagImpl::registerOnTheFly()
if (!bOtherImpl || !pImpl-mbInitializedLangID)
{
-LanguageType nLang = getNextOnTheFlyLanguage();
+LanguageType nLang = ((nRegisterID == 0 || nRegisterID ==
LANGUAGE_DONTKNOW) ?
+getNextOnTheFlyLanguage() : nRegisterID);
if (!nLang)
{
// out of IDs, nothing to register
@@ -878,7 +883,11 @@ LanguageTag::ImplPtr LanguageTag::registerImpl() const
pImpl-convertBcp47ToLocale();
if (!pImpl-mbInitializedLangID)
pImpl-convertLocaleToLang( true);
-bool bInsert = LanguageTag::isOnTheFlyID( pImpl-mnLangID);
+// Unconditionally insert (round-trip is possible) for
+// on-the-fly IDs and (generated or not) primary language IDs.
+bool bInsert = (pImpl-mnLangID != LANGUAGE_DONTKNOW
+(LanguageTag::isOnTheFlyID( pImpl-mnLangID) ||
+ (pImpl-mnLangID == MsLangId::getPrimaryLanguage(
pImpl-mnLangID;
OUString aBcp47;
if (!bInsert)
{
@@ -1298,7 +1307,26 @@ void LanguageTagImpl::convertLocaleToLang( bool
bAllowOnTheFlyID )
if (mnLangID == LANGUAGE_DONTKNOW bAllowOnTheFlyID)
{
if (isValidBcp47())
-registerOnTheFly();
+{
+// For language-only (including script) look if we know some
+// locale of that language and if so use the primary language
+// ID of that instead of generating an on-the-fly-ID.
+if (getCountry().isEmpty() isIsoODF())
+{
+lang::Locale aLoc(
MsLangId::Conversion::lookupFallbackLocale( maLocale));
+// 'en-US' is last resort, do not use except when looking
+// for 'en'.
+if (aLoc.Language != en || getLanguage() == en)
+{
+mnLangID =
Re: minutes of ESC call ...
On Thu, Oct 10, 2013 at 05:09:34PM +0100, Michael Meeks wrote: + Canonical bibisect repo is updated - since October 4th (Bjoern) + also started personal build of that, we have 2x of these running updating So, my local build is finished, and the last 20 build turned out right and usable. Unfortunately previous builds finished successfully, but are unusable because of fscking linkoo and esp. because of fscking linkoo even being being enabled by default. Luckily we now got rid of that crap (and good riddance), but still for this series of builds, that doesnt really help. I wonder, if I should upload this 20 build bibisect, so that we at least have something of a recent master build available for testers, or if I should skip this completely. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: scp2/source
scp2/source/firebird/module_firebird.scp |2 ++ scp2/source/ooo/module_pdfimport.scp |2 ++ scp2/source/python/module_python.scp |4 3 files changed, 8 insertions(+) New commits: commit 3f3d684430f0c8437550d207b5d54da9c80f19ff Author: Andras Timar andras.ti...@collabora.com Date: Sat Oct 12 16:54:04 2013 +0200 add name/description in order to avoid warnings in feature.pm Change-Id: I291d4d969c73d39f3c02511cb7ea2dce27f163d6 diff --git a/scp2/source/firebird/module_firebird.scp b/scp2/source/firebird/module_firebird.scp index 88c0eb4..7087eed 100644 --- a/scp2/source/firebird/module_firebird.scp +++ b/scp2/source/firebird/module_firebird.scp @@ -21,6 +21,8 @@ #ifndef SYSTEM_FIREBIRD Module gid_Module_Firebird +Name = Firebird +Description = Firebird PackageInfo = packinfo_office.txt; ParentID = gid_Module_Root_Brand; Files = ( diff --git a/scp2/source/ooo/module_pdfimport.scp b/scp2/source/ooo/module_pdfimport.scp index 0d42536..1641480 100644 --- a/scp2/source/ooo/module_pdfimport.scp +++ b/scp2/source/ooo/module_pdfimport.scp @@ -26,6 +26,8 @@ #include macros.inc Module gid_Module_Pdfimport +Name = PDF Import +Description = PDF Import PackageInfo = packinfo_office.txt; ParentID = gid_Module_Root_Brand; Styles = (HIDDEN_ROOT); diff --git a/scp2/source/python/module_python.scp b/scp2/source/python/module_python.scp index 6be3239..aa03353 100644 --- a/scp2/source/python/module_python.scp +++ b/scp2/source/python/module_python.scp @@ -23,6 +23,8 @@ Module gid_Module_Pyuno PackageInfo = packinfo_office.txt; ParentID = gid_Module_Root_Brand; +Name = PyUNO +Description = Python-UNO bridge Dirs = (gid_Dir_PythonFramework, gid_Dir_PythonFramework_Versions, gid_Dir_PythonFramework_Versions_ver, @@ -69,6 +71,8 @@ Module gid_Module_Pyuno End Module gid_Module_Script_Provider_For_Python +Name = Script Provider For Python +Description = Script Provider For Python PackageInfo = packinfo_office.txt; ParentID = gid_Module_Root_Brand; Files = ( gid_File_scriptproviderforpython ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 8 commits - bridges/test canvas/source comphelper/source config_host/config_features.h.in configure.ac connectivity/workben cui/source dbaccess/source editeng/source
bridges/test/performance/testperformance.cxx|2 +-
canvas/source/cairo/cairo_devicehelper.cxx |3 ++-
comphelper/source/eventattachermgr/eventattachermgr.cxx |4
config_host/config_features.h.in|7 +++
configure.ac|1 +
connectivity/workben/iniParser/main.cxx |5 -
connectivity/workben/little/main.cxx|5 -
connectivity/workben/testmoz/main.cxx |6 +-
connectivity/workben/testmoz/mozthread.cxx |6 +-
cui/source/tabpages/tparea.cxx |6 ++
dbaccess/source/ui/misc/TokenWriter.cxx |6 +++---
editeng/source/editeng/impedit4.cxx | 16
12 files changed, 18 insertions(+), 49 deletions(-)
New commits:
commit 49da6374b357277d46dfddfeb9e102c722a32111
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 18:27:40 2013 +0300
Bin some of Malte Timmermann's personal old debugging code
Change-Id: I4d8070e6c9441a39094d499c433e5009f093d823
diff --git a/editeng/source/editeng/impedit4.cxx
b/editeng/source/editeng/impedit4.cxx
index fa8110b..fb61b94 100644
--- a/editeng/source/editeng/impedit4.cxx
+++ b/editeng/source/editeng/impedit4.cxx
@@ -152,12 +152,6 @@ EditPaM ImpEditEngine::ReadXML( SvStream rInput,
EditSelection aSel )
EditPaM ImpEditEngine::ReadRTF( SvStream rInput, EditSelection aSel )
{
-#if (OSL_DEBUG_LEVEL 2) !defined( UNX )
-SvFileStream aRTFOut( OUString( d:\\rtf_in.rtf ), STREAM_WRITE );
-aRTFOut rInput;
-aRTFOut.Close();
-rInput.Seek( 0 );
-#endif
if ( aSel.HasRange() )
aSel = ImpDeleteSelection( aSel );
@@ -688,16 +682,6 @@ sal_uInt32 ImpEditEngine::WriteRTF( SvStream rOutput,
EditSelection aSel )
for (it = aFontTable.begin(); it != aFontTable.end(); ++it)
delete *it;
-#if (OSL_DEBUG_LEVEL 2) !defined( UNX )
-{
-SvFileStream aStream( OUString( d:\\rtf_out.rtf ),
STREAM_WRITE|STREAM_TRUNC );
-sal_uLong nP = rOutput.Tell();
-rOutput.Seek( 0 );
-aStream rOutput;
-rOutput.Seek( nP );
-}
-#endif
-
return rOutput.GetError();
}
commit 8b73652822aae8941b81e8f076db5f5f0b14948d
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 18:20:46 2013 +0300
Test _WIN32 instead of UNX as it is Win32 that's different here
Change-Id: I05e93ef13523a4729c46c9dbf36657d7288c62e6
diff --git a/dbaccess/source/ui/misc/TokenWriter.cxx
b/dbaccess/source/ui/misc/TokenWriter.cxx
index 80194af..ad2caef 100644
--- a/dbaccess/source/ui/misc/TokenWriter.cxx
+++ b/dbaccess/source/ui/misc/TokenWriter.cxx
@@ -72,10 +72,10 @@ using namespace ::com::sun::star::awt;
using namespace ::com::sun::star::util;
using ::com::sun::star::frame::XModel;
-#if defined(UNX)
-const char ODatabaseImportExport::sNewLine = '\012';
-#else
+#ifdef _WIN32
const char ODatabaseImportExport::sNewLine[] = \015\012;
+#else
+const char ODatabaseImportExport::sNewLine = '\012';
#endif
const static char sMyBegComment[] = !-- ;
commit 3db218c8f70a8d9c29a5013a5e056639b028864b
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 18:18:16 2013 +0300
There is nothing scary about stdlib.h
Change-Id: Ie30e4d67435808fd6c31e1ca7f10a58faad1c6ce
diff --git a/cui/source/tabpages/tparea.cxx b/cui/source/tabpages/tparea.cxx
index 5363cb9..462b410 100644
--- a/cui/source/tabpages/tparea.cxx
+++ b/cui/source/tabpages/tparea.cxx
@@ -17,16 +17,14 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
+#include stdlib.h
+
#include tools/shl.hxx
#include tools/urlobj.hxx
#include sfx2/app.hxx
#include sfx2/module.hxx
#include svx/dialogs.hrc
-#if defined (UNX) || defined (ICC) || defined(WNT)
-#include stdlib.h
-#endif
-
#include svx/xattr.hxx
#include svx/xpool.hxx
#include cuires.hrc
commit ac057ce23d57aa81dbd44852682abaaf5f5510a1
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 17:17:02 2013 +0300
Bin bogus use of UNX (in not compiled test code)
Change-Id: Idef7344e215e9b58e1449fbf71f8a64df8c3
diff --git a/connectivity/workben/iniParser/main.cxx
b/connectivity/workben/iniParser/main.cxx
index 05dcfa1..8938735 100644
--- a/connectivity/workben/iniParser/main.cxx
+++ b/connectivity/workben/iniParser/main.cxx
@@ -165,12 +165,7 @@ public:
};
-#if (defined UNX)
int main( int argc, char * argv[] )
-#else
-int _cdecl main( int argc, char * argv[] )
-#endif
-
{
IniParser parser(OUString(test.ini));
diff --git a/connectivity/workben/little/main.cxx
b/connectivity/workben/little/main.cxx
index dbfd248..cf04c3a 100644
--- a/connectivity/workben/little/main.cxx
+++ b/connectivity/workben/little/main.cxx
@@ -42,12 +42,7 @@ using namespace cppu;
-#if (defined UNX)
void main( int argc, char * argv[] )
-#else
-void _cdecl
[Libreoffice-commits] core.git: 4 commits - comphelper/source framework/source idl/source include/comphelper include/filter
comphelper/source/misc/syntaxhighlight.cxx|2 +-
framework/source/uielement/menubarmanager.cxx | 10 +-
idl/source/prj/svidl.cxx |6 --
include/comphelper/syntaxhighlight.hxx| 13 -
include/filter/dllapi.h |6 --
5 files changed, 2 insertions(+), 35 deletions(-)
New commits:
commit 352f4f1f047be99c1068ba8bac3a4e3aaebf030a
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 20:03:29 2013 +0300
FILTER_PLUGIN_PUBLIC is not used anywhere
Change-Id: I2788bac96326f888e758a895d587125d4b8a3b3b
diff --git a/include/filter/dllapi.h b/include/filter/dllapi.h
index 9b94621..5b93bff 100644
--- a/include/filter/dllapi.h
+++ b/include/filter/dllapi.h
@@ -29,12 +29,6 @@
#define FILTER_DLLPUBLIC SAL_DLLPUBLIC_IMPORT
#endif
-#if defined UNX ! defined MACOS
-#define FILTER_PLUGIN_PUBLIC FILTER_DLLPUBLIC
-#else
-#define FILTER_PLUGIN_PUBLIC SAL_DLLPRIVATE
-#endif
-
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 265ae345c01335a4d9d28bd23b86c43705062497
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 19:35:26 2013 +0300
Bin obsolete CDECL crack
Change-Id: I69da428711681d14fd48c198fbce0bb545665b5a
diff --git a/comphelper/source/misc/syntaxhighlight.cxx
b/comphelper/source/misc/syntaxhighlight.cxx
index 11cfc34..c1f4ca5 100644
--- a/comphelper/source/misc/syntaxhighlight.cxx
+++ b/comphelper/source/misc/syntaxhighlight.cxx
@@ -224,7 +224,7 @@ static const char* strListSqlKeyWords[] = {
};
-extern C int CDECL compare_strings( const void *arg1, const void *arg2 )
+static int compare_strings( const void *arg1, const void *arg2 )
{
return strcmp( (char *)arg1, *(char **)arg2 );
}
diff --git a/include/comphelper/syntaxhighlight.hxx
b/include/comphelper/syntaxhighlight.hxx
index ef1a948..dfea10f 100644
--- a/include/comphelper/syntaxhighlight.hxx
+++ b/include/comphelper/syntaxhighlight.hxx
@@ -24,23 +24,10 @@
#include comphelper/comphelperdllapi.h
-
-#if defined CDECL
-#undef CDECL
-#endif
-
-// for the bsearch
-#ifdef WNT
-#define CDECL _cdecl
-#endif
-#if defined(UNX)
-#define CDECL
-#endif
#ifdef UNX
#include sys/resource.h
#endif
-
// Token-Typen TT_...
enum TokenTypes
{
commit 2c096cb5b0154a94b7c8a59d1e7c7943ac699910
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 19:21:40 2013 +0300
cdecl is the default anyway
Change-Id: Iee47fbc9ea43be2af2712efe15df3d7936277cf7
diff --git a/idl/source/prj/svidl.cxx b/idl/source/prj/svidl.cxx
index 4db3d36..b9dc81e 100644
--- a/idl/source/prj/svidl.cxx
+++ b/idl/source/prj/svidl.cxx
@@ -103,14 +103,8 @@ inline OUString tempFileHelper(OUString const fname)
return aTmpFile;
}
-#if defined( UNX ) || defined (__MINGW32__)
int main ( int argc, char ** argv)
{
-#else
-int cdecl main ( int argc, char ** argv)
-{
-#endif
-
OUString aTmpListFile;
OUString aTmpSlotMapFile;
OUString aTmpSfxItemFile;
commit 87708fd311145a7fb0415842f277693fdea3c816
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 19:17:21 2013 +0300
Simplify
Change-Id: Ic2afa7e60da57c5b516a043f717dea21a3cf0d55
diff --git a/framework/source/uielement/menubarmanager.cxx
b/framework/source/uielement/menubarmanager.cxx
index e0bac02..027448c 100644
--- a/framework/source/uielement/menubarmanager.cxx
+++ b/framework/source/uielement/menubarmanager.cxx
@@ -274,19 +274,11 @@ Any SAL_CALL MenuBarManager::getMenuHandle( const
Sequence sal_Int8 /*Proces
aSystemMenuData.nSize = sizeof( SystemMenuData );
m_pVCLMenu-GetSystemMenuData( aSystemMenuData );
-#ifdef MACOSX
-if( SystemType == SystemDependent::SYSTEM_MAC )
-{
-}
-#elif (defined WNT)
+#ifdef _WIN32
if( SystemType == SystemDependent::SYSTEM_WIN32 )
{
a = (long) aSystemMenuData.hMenu;
}
-#elif (defined UNX)
-if( SystemType == SystemDependent::SYSTEM_XWINDOW )
-{
-}
#endif
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/modules/installer/windows/feature.pm |1 +
1 file changed, 1 insertion(+)
New commits:
commit 914fbb57bdd4038d0a3e1e2cad45ff81672fc748
Author: Andras Timar andras.ti...@collabora.com
Date: Sat Oct 12 10:00:51 2013 -0700
fdo#33798 msidbFeatureAttributesUIDisallowAbsent for hidden feat.
Change-Id: I0c8788f88b3c219e789af7f8bfa79e5dd31c5b3a
diff --git a/solenv/bin/modules/installer/windows/feature.pm
b/solenv/bin/modules/installer/windows/feature.pm
index f230fa6..23f6a0f 100644
--- a/solenv/bin/modules/installer/windows/feature.pm
+++ b/solenv/bin/modules/installer/windows/feature.pm
@@ -179,6 +179,7 @@ sub get_feature_attributes
if ( $onefeature-{'ParentID'} ) { $parentgid = $onefeature-{'ParentID'};
}
if (( $parentgid eq ) || ( $parentgid eq
$installer::globals::rootmodulegid )) { $attributes = 8; }
+elsif ( get_feature_display($onefeature) eq 0 ) { $attributes = 26; }
# fdo#33798
else { $attributes = 10; }
return $attributes
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: scp2/source
scp2/source/firebird/module_firebird.scp |4 ++-- scp2/source/ooo/module_pdfimport.scp |4 ++-- scp2/source/python/module_python.scp |4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) New commits: commit 79896c3a43b7ae4d45fb164f1f11ba020bd8a74f Author: Andras Timar andras.ti...@collabora.com Date: Sat Oct 12 19:24:53 2013 +0200 missing semicolons Change-Id: Ib1cf6ec8ffe622be887c7dd567d0b44eaf1a75e6 diff --git a/scp2/source/firebird/module_firebird.scp b/scp2/source/firebird/module_firebird.scp index 7087eed..1e7f744 100644 --- a/scp2/source/firebird/module_firebird.scp +++ b/scp2/source/firebird/module_firebird.scp @@ -21,8 +21,8 @@ #ifndef SYSTEM_FIREBIRD Module gid_Module_Firebird -Name = Firebird -Description = Firebird +Name = Firebird; +Description = Firebird; PackageInfo = packinfo_office.txt; ParentID = gid_Module_Root_Brand; Files = ( diff --git a/scp2/source/ooo/module_pdfimport.scp b/scp2/source/ooo/module_pdfimport.scp index 1641480..ee504fc 100644 --- a/scp2/source/ooo/module_pdfimport.scp +++ b/scp2/source/ooo/module_pdfimport.scp @@ -26,8 +26,8 @@ #include macros.inc Module gid_Module_Pdfimport -Name = PDF Import -Description = PDF Import +Name = PDF Import; +Description = PDF Import; PackageInfo = packinfo_office.txt; ParentID = gid_Module_Root_Brand; Styles = (HIDDEN_ROOT); diff --git a/scp2/source/python/module_python.scp b/scp2/source/python/module_python.scp index aa03353..ff720a2 100644 --- a/scp2/source/python/module_python.scp +++ b/scp2/source/python/module_python.scp @@ -71,8 +71,8 @@ Module gid_Module_Pyuno End Module gid_Module_Script_Provider_For_Python -Name = Script Provider For Python -Description = Script Provider For Python +Name = Script Provider For Python; +Description = Script Provider For Python; PackageInfo = packinfo_office.txt; ParentID = gid_Module_Root_Brand; Files = ( gid_File_scriptproviderforpython ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: scp2/source
scp2/source/python/module_python.scp |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 9e30d407564a67917e667f5d67962efa0eadc9b0 Author: Andras Timar andras.ti...@collabora.com Date: Sat Oct 12 19:31:30 2013 +0200 missing semicolons Change-Id: I06607610d6a593ad8bf2deb2affe2e40af158087 diff --git a/scp2/source/python/module_python.scp b/scp2/source/python/module_python.scp index ff720a2..faa157d 100644 --- a/scp2/source/python/module_python.scp +++ b/scp2/source/python/module_python.scp @@ -23,8 +23,8 @@ Module gid_Module_Pyuno PackageInfo = packinfo_office.txt; ParentID = gid_Module_Root_Brand; -Name = PyUNO -Description = Python-UNO bridge +Name = PyUNO; +Description = Python-UNO bridge; Dirs = (gid_Dir_PythonFramework, gid_Dir_PythonFramework_Versions, gid_Dir_PythonFramework_Versions_ver, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 3 commits - framework/source include/helpcompiler include/svtools svtools/source
framework/source/uielement/menubarmanager.cxx |2 ++
include/helpcompiler/dllapi.h |6 --
include/svtools/htmlout.hxx |6 +-
include/svtools/rtfout.hxx|6 +-
svtools/source/svhtml/htmlout.cxx |6 +++---
svtools/source/svrtf/rtfout.cxx |6 +++---
6 files changed, 10 insertions(+), 22 deletions(-)
New commits:
commit 5c046a31e1e19e01a60d4bf22cf2a5eb8ef13a63
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 20:34:06 2013 +0300
WaE: unused parameter 'SystemType'
Change-Id: I52717d85269dd1802b942ba19f5710b9e469faf1
diff --git a/framework/source/uielement/menubarmanager.cxx
b/framework/source/uielement/menubarmanager.cxx
index 027448c..4729859 100644
--- a/framework/source/uielement/menubarmanager.cxx
+++ b/framework/source/uielement/menubarmanager.cxx
@@ -279,6 +279,8 @@ Any SAL_CALL MenuBarManager::getMenuHandle( const Sequence
sal_Int8 /*Proces
{
a = (long) aSystemMenuData.hMenu;
}
+#else
+(void) SystemType;
#endif
}
commit b11f257d9b6927a7df1f2a3f03405e045a1beec6
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 20:13:48 2013 +0300
Test _WIN32 instead of UNX as it's Win32 that is the special case here
Change-Id: Ic729eab62109d854122fa5c6b7b4dc163088dd04
diff --git a/include/svtools/htmlout.hxx b/include/svtools/htmlout.hxx
index 789ee194..9b0c8fd 100644
--- a/include/svtools/htmlout.hxx
+++ b/include/svtools/htmlout.hxx
@@ -51,11 +51,7 @@ struct SVT_DLLPUBLIC HTMLOutContext
struct HTMLOutFuncs
{
-#if defined(UNX)
-static const sal_Char sNewLine; // nur \012 oder \015
-#else
-static const sal_Char sNewLine[]; // \015\012
-#endif
+static const sal_Char sNewLine[];
SVT_DLLPUBLIC static OString ConvertStringToHTML( const OUString sSrc,
rtl_TextEncoding eDestEnc = RTL_TEXTENCODING_MS_1252,
diff --git a/include/svtools/rtfout.hxx b/include/svtools/rtfout.hxx
index 9258053..7c38947 100644
--- a/include/svtools/rtfout.hxx
+++ b/include/svtools/rtfout.hxx
@@ -33,11 +33,7 @@ class SvStream;
class SVT_DLLPUBLIC RTFOutFuncs
{
public:
-#if defined(UNX)
-static const sal_Char sNewLine; // nur \012 oder \015
-#else
-static const sal_Char sNewLine[]; // \015\012
-#endif
+static const sal_Char sNewLine[];
static SvStream Out_Char( SvStream, sal_Unicode cChar,
int *pUCMode,
diff --git a/svtools/source/svhtml/htmlout.cxx
b/svtools/source/svhtml/htmlout.cxx
index b633e70..5c0b1d8 100644
--- a/svtools/source/svhtml/htmlout.cxx
+++ b/svtools/source/svhtml/htmlout.cxx
@@ -31,10 +31,10 @@
#include svtools/imappoly.hxx
#include svl/urihelper.hxx
-#if defined(UNX)
-const sal_Char HTMLOutFuncs::sNewLine = '\012';
-#else
+#ifdef _WIN32
const sal_Char HTMLOutFuncs::sNewLine[] = \015\012;
+#else
+const sal_Char HTMLOutFuncs::sNewLine[] = \012;
#endif
#define TXTCONV_BUFFER_SIZE 20
diff --git a/svtools/source/svrtf/rtfout.cxx b/svtools/source/svrtf/rtfout.cxx
index 5272fe1..919a009 100644
--- a/svtools/source/svrtf/rtfout.cxx
+++ b/svtools/source/svrtf/rtfout.cxx
@@ -25,10 +25,10 @@
#include svtools/rtfout.hxx
-#if defined(UNX)
-const sal_Char RTFOutFuncs::sNewLine = '\012';
-#else
+#ifdef _WIN32
const sal_Char RTFOutFuncs::sNewLine[] = \015\012;
+#else
+const sal_Char RTFOutFuncs::sNewLine[] = \012;
#endif
commit 610681b97aca28c4c40c3462875cd47105442a21
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 20:06:28 2013 +0300
L10N_PLUGIN_PUBLIC is not used anywhere
Change-Id: I27bc41e76aa19cf6bd0a9eb4dcbfa07a0d165eb0
diff --git a/include/helpcompiler/dllapi.h b/include/helpcompiler/dllapi.h
index c823952..a2035ba 100644
--- a/include/helpcompiler/dllapi.h
+++ b/include/helpcompiler/dllapi.h
@@ -29,12 +29,6 @@
#define L10N_DLLPUBLIC SAL_DLLPUBLIC_IMPORT
#endif
-#if defined UNX ! defined MACOS
-#define L10N_PLUGIN_PUBLIC L10N_DLLPUBLIC
-#else
-#define L10N_PLUGIN_PUBLIC SAL_DLLPRIVATE
-#endif
-
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: xmloff/inc xmloff/source
xmloff/inc/MultiPropertySetHelper.hxx|4 xmloff/inc/anim.hxx |4 xmloff/source/chart/SchXMLTableContext.cxx |6 xmloff/source/chart/SchXMLTableContext.hxx |2 xmloff/source/chart/XMLAxisPositionPropertyHdl.cxx |2 xmloff/source/chart/XMLErrorIndicatorPropertyHdl.cxx |2 xmloff/source/draw/animexp.cxx | 232 +-- xmloff/source/draw/animimp.cxx |2 xmloff/source/draw/eventimp.cxx |2 xmloff/source/draw/shapeexport2.cxx |2 xmloff/source/style/MultiPropertySetHelper.cxx |4 xmloff/source/text/txtftne.cxx | 16 - xmloff/source/text/txtparae.cxx |6 xmloff/source/text/txtsecte.cxx |2 14 files changed, 143 insertions(+), 143 deletions(-) New commits: commit d22ee5be41ffa0ac5a075c68a00b9b9eb6b8d376 Author: Takeshi Abe t...@fixedpoint.jp Date: Sun Oct 13 02:34:47 2013 +0900 sal_Bool to bool Change-Id: I3db66690f9eaa809bcbf2257804d319aaec0f975 diff --git a/xmloff/inc/MultiPropertySetHelper.hxx b/xmloff/inc/MultiPropertySetHelper.hxx index 452ff19..c73ebd7 100644 --- a/xmloff/inc/MultiPropertySetHelper.hxx +++ b/xmloff/inc/MultiPropertySetHelper.hxx @@ -96,7 +96,7 @@ public: * Return whether hasProperties was called * (i.e. if we are ready to call getValues) */ -sal_Bool checkedProperties(); +bool checkedProperties(); /** * Get values from the XMultiPropertySet. @@ -147,7 +147,7 @@ public: const ::com::sun::star::uno::Any getValue( sal_Int16 nIndex, const ::com::sun::star::uno::Reference ::com::sun::star::beans::XPropertySet , -sal_Bool bTryMulti = sal_False ); +bool bTryMulti = false ); /** * Get a value from the XMultiPropertySet on demand. diff --git a/xmloff/inc/anim.hxx b/xmloff/inc/anim.hxx index 9e1a0e5..8f81891 100644 --- a/xmloff/inc/anim.hxx +++ b/xmloff/inc/anim.hxx @@ -89,8 +89,8 @@ extern SvXMLEnumMapEntry aXML_AnimationDirection_EnumMap[]; extern SvXMLEnumMapEntry aXML_AnimationSpeed_EnumMap[]; -void SdXMLImplSetEffect( ::com::sun::star::presentation::AnimationEffect eEffect, XMLEffect eKind, XMLEffectDirection eDirection, sal_Int16 nStartScale, sal_Bool bIn ); -::com::sun::star::presentation::AnimationEffect ImplSdXMLgetEffect( XMLEffect eKind, XMLEffectDirection eDirection, sal_Int16 nStartScale, sal_Bool bIn ); +void SdXMLImplSetEffect( ::com::sun::star::presentation::AnimationEffect eEffect, XMLEffect eKind, XMLEffectDirection eDirection, sal_Int16 nStartScale, bool bIn ); +::com::sun::star::presentation::AnimationEffect ImplSdXMLgetEffect( XMLEffect eKind, XMLEffectDirection eDirection, sal_Int16 nStartScale, bool bIn ); #endif // _XMLOFF_ANIM_HXX diff --git a/xmloff/source/chart/SchXMLTableContext.cxx b/xmloff/source/chart/SchXMLTableContext.cxx index b3189a5..ad0b7cd 100644 --- a/xmloff/source/chart/SchXMLTableContext.cxx +++ b/xmloff/source/chart/SchXMLTableContext.cxx @@ -652,7 +652,7 @@ void SchXMLTableCellContext::StartElement( const uno::Reference xml::sax::XAttr } } -mbReadText = sal_True; +mbReadText = true; SchXMLCell aCell; aCell.eType = eValueType; @@ -664,7 +664,7 @@ void SchXMLTableCellContext::StartElement( const uno::Reference xml::sax::XAttr aCell.fValue = fData; // dont read text from following text:p or text:list element -mbReadText = sal_False; +mbReadText = false; } mrTable.aData[ mrTable.nRowIndex ].push_back( aCell ); @@ -687,7 +687,7 @@ SvXMLImportContext* SchXMLTableCellContext::CreateChildContext( rCell.aComplexString = Sequence OUString (); rCell.eType = SCH_CELL_TYPE_COMPLEX_STRING; pContext = new SchXMLTextListContext( GetImport(), rLocalName, rCell.aComplexString ); -mbReadText = sal_False;//don't apply text from text:p +mbReadText = false;//don't apply text from text:p } // text:p element - read text (and range from text:id old version) else if( nPrefix == XML_NAMESPACE_TEXT IsXMLToken( rLocalName, XML_P ) ) diff --git a/xmloff/source/chart/SchXMLTableContext.hxx b/xmloff/source/chart/SchXMLTableContext.hxx index f6b212b..09d2fa7 100644 --- a/xmloff/source/chart/SchXMLTableContext.hxx +++ b/xmloff/source/chart/SchXMLTableContext.hxx @@ -172,7 +172,7 @@ private: SchXMLTable mrTable; OUString maCellContent; OUString maRangeId; -sal_Bool mbReadText; +bool mbReadText; public: SchXMLTableCellContext( SchXMLImportHelper rImpHelper, diff --git a/xmloff/source/chart/XMLAxisPositionPropertyHdl.cxx b/xmloff/source/chart/XMLAxisPositionPropertyHdl.cxx index 3b82f7a..1243011 100644 ---
[Libreoffice-commits] core.git: 2 commits - include/svx include/tools
include/svx/svdmodel.hxx |8 +--- include/tools/stream.hxx |2 +- 2 files changed, 2 insertions(+), 8 deletions(-) New commits: commit 22481c65ff2019dcfb03d9fe58e6ad2574b759fd Author: Tor Lillqvist t...@collabora.com Date: Sat Oct 12 20:44:45 2013 +0300 Avoid git grep match for UNX in comment Change-Id: Ie8dde0810a3953a03ef6cfdcfaa24445ee45de5a diff --git a/include/tools/stream.hxx b/include/tools/stream.hxx index b051e9a..1bc3f2a 100644 --- a/include/tools/stream.hxx +++ b/include/tools/stream.hxx @@ -48,7 +48,7 @@ typedef sal_uInt16 StreamMode; // file i/o #define STREAM_NOCREATE 0x0004 /// 1 == Dont create file #define STREAM_TRUNC0x0008 /// Truncate _existing_ file to zero length -#define STREAM_COPY_ON_SYMLINK 0x0010 /// copy-on-write for symlinks (UNX) +#define STREAM_COPY_ON_SYMLINK 0x0010 /// copy-on-write for symlinks (Unix) #define STREAM_READWRITEBITS(STREAM_READ | STREAM_WRITE | \ STREAM_NOCREATE | STREAM_TRUNC) commit 55ed54021b9c59d3e642ca93fcf4412fe2951102 Author: Tor Lillqvist t...@collabora.com Date: Sat Oct 12 20:41:42 2013 +0300 Unicode is Unocode on all platforms Change-Id: Iea8065f8d0f8e305cf2b1f56ba7ddd4189306ad2 diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx index c8ed6c2..03efa04 100644 --- a/include/svx/svdmodel.hxx +++ b/include/svx/svdmodel.hxx @@ -45,13 +45,7 @@ class OutputDevice; #include rtl/ref.hxx #include deque -#if defined(UNX) || defined(WNT) -#define DEGREE_CHAR ((sal_Unicode)176) /* 0xB0 = Ansi */ -#endif - -#ifndef DEGREE_CHAR -#error unbekannte Plattrorm -#endif +#define DEGREE_CHAR ((sal_Unicode)0x00B0) /* U+00B0 DEGREE SIGN */ class SdrOutliner; class SdrLayerAdmin; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: rsc/source
rsc/source/prj/gui.cxx | 15 ---
1 file changed, 15 deletions(-)
New commits:
commit 0937d07cd5bbdc68fcae8127149ffa6c813d3a97
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 21:03:36 2013 +0300
Simpligy: Bin odd atexit crack
Change-Id: Ib7e491ae66525b8ba2555b50fe7c9e1fed150987
diff --git a/rsc/source/prj/gui.cxx b/rsc/source/prj/gui.cxx
index 4535b56..a2d321e 100644
--- a/rsc/source/prj/gui.cxx
+++ b/rsc/source/prj/gui.cxx
@@ -23,16 +23,6 @@
#include rscrsc.hxx
#include rscdb.hxx
-static RscCompiler * pRscCompiler = NULL;
-#if defined( UNX ) || defined ( __GNUC__ ) || defined(__MINGW32__)
-void ExitProgram( void ){
-#else
-void cdecl ExitProgram( void ){
-#endif
-if( pRscCompiler )
-delete pRscCompiler;
-}
-
static RscVerbosity lcl_determineVerbosity( int argc, char ** argv )
{
for ( int i = 0; i argc; ++i )
@@ -49,9 +39,6 @@ static RscVerbosity lcl_determineVerbosity( int argc, char **
argv )
int rsc2_main( int argc, char **argv )
{
-#ifndef UNX
-atexit( ExitProgram );
-#endif
#if OSL_DEBUG_LEVEL 1
fprintf( stderr, debugging %s\n, argv[0] );
#endif
@@ -71,9 +58,7 @@ int rsc2_main( int argc, char **argv )
else{
RscCompiler* pCompiler = new RscCompiler( pCmdLine, pTypCont );
-pRscCompiler = pCompiler;
aError = pCompiler-Start();
-pRscCompiler = NULL;
delete pCompiler;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/inc/expbase.hxx |4
sc/source/filter/rtf/expbase.cxx |6 +++---
2 files changed, 3 insertions(+), 7 deletions(-)
New commits:
commit 816a888643114a3a8ac07126c2cd710d318a5781
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 21:07:40 2013 +0300
Test _WIN32 instead of UNX as it's Windows that is the special case
Change-Id: I6252f4737dbc297525792412e006b2ed0147a0d6
diff --git a/sc/source/filter/inc/expbase.hxx b/sc/source/filter/inc/expbase.hxx
index 5123a19..92ebf3a 100644
--- a/sc/source/filter/inc/expbase.hxx
+++ b/sc/source/filter/inc/expbase.hxx
@@ -31,11 +31,7 @@ class ScFieldEditEngine;
class ScExportBase
{
public:
-#if defined UNX
-static const sal_Char sNewLine;
-#else
static const sal_Char sNewLine[];
-#endif
protected:
diff --git a/sc/source/filter/rtf/expbase.cxx b/sc/source/filter/rtf/expbase.cxx
index efa0fc0..f43adb3 100644
--- a/sc/source/filter/rtf/expbase.cxx
+++ b/sc/source/filter/rtf/expbase.cxx
@@ -24,10 +24,10 @@
//--
-#if defined(UNX)
-const sal_Char ScExportBase::sNewLine = '\012';
-#else
+#ifdef _WIN32
const sal_Char ScExportBase::sNewLine[] = \015\012;
+#else
+const sal_Char ScExportBase::sNewLine[] = \012;
#endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sc/source
sc/source/ui/drawfunc/fuconstr.cxx |2 --
sc/source/ui/drawfunc/fusel.cxx |2 --
sc/source/ui/vba/vbaapplication.cxx | 10 +-
3 files changed, 1 insertion(+), 13 deletions(-)
New commits:
commit 33fdb0b1161ac1b8786f26de840811a34867730c
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 21:13:38 2013 +0300
Use SAL_PATHDELIMITER
Change-Id: I5b5346dcf5b4ab3277fea28ee73bc36dc0579105
diff --git a/sc/source/ui/vba/vbaapplication.cxx
b/sc/source/ui/vba/vbaapplication.cxx
index 0013ec1..eb3c9eb 100644
--- a/sc/source/ui/vba/vbaapplication.cxx
+++ b/sc/source/ui/vba/vbaapplication.cxx
@@ -101,13 +101,6 @@ using ::com::sun::star::uno::Reference;
using ::com::sun::star::uno::UNO_QUERY_THROW;
using ::com::sun::star::uno::UNO_QUERY;
-// #TODO is this defined somewhere else?
-#if ( defined UNX ) //unix
-#define FILE_PATH_SEPARATOR /
-#else // windows
-#define FILE_PATH_SEPARATOR \\
-#endif
-
//
/** Global application settings shared by all open workbooks. */
@@ -942,8 +935,7 @@ ScVbaApplication::getTemplatesPath() throw
(uno::RuntimeException)
OUString SAL_CALL
ScVbaApplication::getPathSeparator() throw (uno::RuntimeException)
{
-static OUString sPathSep( FILE_PATH_SEPARATOR );
-return sPathSep;
+return OUString( (sal_Unicode) SAL_PATHDELIMITER );
}
//
commit aa7d62c3e385af3029b11fa86f7dd98987dddee0
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 21:08:42 2013 +0300
Bin pointless comments
Change-Id: I651854e653ae863577bd1f0f22ef640dd7044ebc
diff --git a/sc/source/ui/drawfunc/fuconstr.cxx
b/sc/source/ui/drawfunc/fuconstr.cxx
index 381aeb4..c2d7458 100644
--- a/sc/source/ui/drawfunc/fuconstr.cxx
+++ b/sc/source/ui/drawfunc/fuconstr.cxx
@@ -63,8 +63,6 @@ FuConstruct::~FuConstruct()
sal_uInt8 FuConstruct::Command(const CommandEvent rCEvt)
{
-// special code for non-VCL OS2/UNX removed
-
return FuDraw::Command( rCEvt );
}
diff --git a/sc/source/ui/drawfunc/fusel.cxx b/sc/source/ui/drawfunc/fusel.cxx
index 946be47..13e1d30 100644
--- a/sc/source/ui/drawfunc/fusel.cxx
+++ b/sc/source/ui/drawfunc/fusel.cxx
@@ -85,8 +85,6 @@ FuSelection::~FuSelection()
sal_uInt8 FuSelection::Command(const CommandEvent rCEvt)
{
-// special code for non-VCL OS2/UNX removed
-
return FuDraw::Command( rCEvt );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.0' - solenv/bin
solenv/bin/modules/installer/windows/feature.pm |1 +
1 file changed, 1 insertion(+)
New commits:
commit a620d0f01cd15e6f24475490ec93d67f4ceb347f
Author: Andras Timar andras.ti...@collabora.com
Date: Sat Oct 12 10:00:51 2013 -0700
fdo#33798 msidbFeatureAttributesUIDisallowAbsent for hidden feat.
Change-Id: I0c8788f88b3c219e789af7f8bfa79e5dd31c5b3a
diff --git a/solenv/bin/modules/installer/windows/feature.pm
b/solenv/bin/modules/installer/windows/feature.pm
index 33aa351..83a5897 100644
--- a/solenv/bin/modules/installer/windows/feature.pm
+++ b/solenv/bin/modules/installer/windows/feature.pm
@@ -189,6 +189,7 @@ sub get_feature_attributes
if ( $onefeature-{'ParentID'} ) { $parentgid = $onefeature-{'ParentID'};
}
if (( $parentgid eq ) || ( $parentgid eq
$installer::globals::rootmodulegid )) { $attributes = 8; }
+elsif ( get_feature_display($onefeature) eq 0 ) { $attributes = 26; }
# fdo#33798
else { $attributes = 10; }
return $attributes
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 4 commits - sfx2/source svl/source svx/source sw/source
sfx2/source/bastyp/frmhtmlw.cxx |6 +++---
svl/source/numbers/zforlist.cxx | 22 +++---
svx/source/items/chrtitem.cxx |3 ---
sw/source/core/edit/edglss.cxx |6 +++---
4 files changed, 13 insertions(+), 24 deletions(-)
New commits:
commit fcb0e1e97dc9f1f76cba1028f8fc2cf6943df9b3
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 21:28:23 2013 +0300
Test _WIN32 instead of UNX as it's Windows that is the special case
Change-Id: I701ea390440023f1aac0debb48747a8f1a216972
diff --git a/sw/source/core/edit/edglss.cxx b/sw/source/core/edit/edglss.cxx
index 9e58d51..757d623 100644
--- a/sw/source/core/edit/edglss.cxx
+++ b/sw/source/core/edit/edglss.cxx
@@ -276,10 +276,10 @@ sal_Bool SwEditShell::GetSelectedText( String rBuf, int
nHndlParaBrk )
else if( IsSelFullPara()
GETSELTXT_PARABRK_TO_ONLYCR != nHndlParaBrk )
{
-#if defined(UNX)
-rBuf += '\012';
-#else
+#ifdef _WIN32
rBuf += OUString(\015\012);
+#else
+rBuf += '\012';
#endif
}
}
commit bee2ff9817e096507bd268b62ac2b71a43803c22
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 21:25:54 2013 +0300
No idea why wchar.h would be needed here on non-Linux Unix
Change-Id: Ic9fc0c7500336c4ecb4e6e46c9a7574d92235268
diff --git a/svx/source/items/chrtitem.cxx b/svx/source/items/chrtitem.cxx
index 2242b50..d0b38ee 100644
--- a/svx/source/items/chrtitem.cxx
+++ b/svx/source/items/chrtitem.cxx
@@ -19,9 +19,6 @@
#include tools/stream.hxx
#include basic/sbxvar.hxx
-#if defined UNX !defined LINUX
-#include wchar.h
-#endif
#include rtl/math.hxx
#include unotools/intlwrapper.hxx
#include com/sun/star/chart/ChartAxisArrangeOrderType.hpp
commit cb8183d44c7dc40afd9fa86070adb96310e6fffd
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 21:24:45 2013 +0300
Simplify and avoid use of UNX
Change-Id: Ia1f718341858de57d0e417d079981d91968f912b
diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx
index 6c731e7..c672b5e 100644
--- a/svl/source/numbers/zforlist.cxx
+++ b/svl/source/numbers/zforlist.cxx
@@ -4434,25 +4434,17 @@ sal_Char NfCurrencyEntry::GetEuroSymbol(
rtl_TextEncoding eTextEncoding )
{
switch ( eTextEncoding )
{
-case RTL_TEXTENCODING_MS_1252 : // WNT Ansi
-case RTL_TEXTENCODING_ISO_8859_1 : // UNX for use with TrueType fonts
+case RTL_TEXTENCODING_MS_1252 :
+case RTL_TEXTENCODING_ISO_8859_1 :
return '\x80';
-case RTL_TEXTENCODING_ISO_8859_15 : // UNX real
+case RTL_TEXTENCODING_ISO_8859_15 :
return '\xA4';
-case RTL_TEXTENCODING_IBM_850 : // OS2
+case RTL_TEXTENCODING_IBM_850 :
return '\xD5';
-case RTL_TEXTENCODING_APPLE_ROMAN : // MAC
+case RTL_TEXTENCODING_APPLE_ROMAN :
return '\xDB';
-default:// default system
-#if defined(WNT)
-return '\x80';
-#elif defined(UNX)
-// return '\xA4'; // #56121# 0xA4 would be correct for iso-8859-15
-return '\x80'; // but Windows code for the converted TrueType
fonts
-#else
-#error EuroSymbol is what?
-return '\x80';
-#endif
+default:
+return '\x80'; // Windows code for the converted TrueType fonts
(whatever that means)
}
}
commit eca81d9969e232b1236bc5020ab2b9304d5f4640
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 21:16:53 2013 +0300
Test _WIN32 instead of UNX as it's Windows that is the special case
Change-Id: I66e6167df47ac3051d543490ff780bc09dedd82d
diff --git a/sfx2/source/bastyp/frmhtmlw.cxx b/sfx2/source/bastyp/frmhtmlw.cxx
index 4fa984c..fda2852 100644
--- a/sfx2/source/bastyp/frmhtmlw.cxx
+++ b/sfx2/source/bastyp/frmhtmlw.cxx
@@ -54,10 +54,10 @@ static sal_Char const sHTML_SC_yes[] = YES;
static sal_Char const sHTML_SC_no[] = NO;
static sal_Char const sHTML_MIME_text_html[] = text/html; charset=;
-#if defined(UNX)
-const sal_Char SfxFrameHTMLWriter::sNewLine[] = \012;
-#else
+#ifdef _WIN32
const sal_Char SfxFrameHTMLWriter::sNewLine[] = \015\012;
+#else
+const sal_Char SfxFrameHTMLWriter::sNewLine[] = \012;
#endif
void SfxFrameHTMLWriter::OutMeta( SvStream rStrm,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 3 commits - sw/source
sw/source/filter/ascii/wrtasc.cxx |4 ++--
sw/source/filter/html/htmlfly.cxx |8
sw/source/filter/html/wrthtml.cxx |6 +++---
sw/source/filter/html/wrthtml.hxx |6 +-
sw/source/filter/ww8/rtfexport.cxx |6 +++---
sw/source/filter/ww8/rtfexport.hxx |6 +-
6 files changed, 10 insertions(+), 26 deletions(-)
New commits:
commit e9c0819e60631efbb5057c60c64431e8a1946efd
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 21:40:17 2013 +0300
Simplify, and check _WIN32 instead of UNX
Change-Id: I89f975faf65da56bab68b093f32dccad80d502ad
diff --git a/sw/source/filter/ww8/rtfexport.cxx
b/sw/source/filter/ww8/rtfexport.cxx
index 76a7629..73e132d 100644
--- a/sw/source/filter/ww8/rtfexport.cxx
+++ b/sw/source/filter/ww8/rtfexport.cxx
@@ -69,10 +69,10 @@ using namespace ::com::sun::star;
using sw::mark::IMark;
-#if defined(UNX)
-const sal_Char RtfExport::sNewLine = '\012';
-#else
+#ifdef _WIN32
const sal_Char* const RtfExport::sNewLine = \015\012;
+#else
+const sal_Char* const RtfExport::sNewLine = \012;
#endif
// the default text encoding for the export, if it doesn't fit unicode will
diff --git a/sw/source/filter/ww8/rtfexport.hxx
b/sw/source/filter/ww8/rtfexport.hxx
index fb08b9d..fe577db 100644
--- a/sw/source/filter/ww8/rtfexport.hxx
+++ b/sw/source/filter/ww8/rtfexport.hxx
@@ -144,11 +144,7 @@ public:
/// Destructor.
virtual ~RtfExport();
-#if defined(UNX)
-static const sal_Char sNewLine; // \012 or \015
-#else
-static const sal_Char* const sNewLine; // \015\012
-#endif
+static const sal_Char* const sNewLine;
rtl_TextEncoding eDefaultEncoding;
rtl_TextEncoding eCurrentEncoding;
commit 4258b82f79b1e1c1a5d6428bf6650b2694a953fb
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 21:36:45 2013 +0300
Simplify, and check _WIN32 instead of UNX
Change-Id: Id13d51388ecee3bee706510c2f22182e9e1f2d28
diff --git a/sw/source/filter/html/htmlfly.cxx
b/sw/source/filter/html/htmlfly.cxx
index 1b5871d..0004c9c 100644
--- a/sw/source/filter/html/htmlfly.cxx
+++ b/sw/source/filter/html/htmlfly.cxx
@@ -928,21 +928,13 @@ Writer OutHTML_Image( Writer rWrt, const SwFrmFmt
rFrmFmt,
OString aIndMap, aIndArea;
const sal_Char *pLF = 0, *pIndArea = 0, *pIndMap = 0;
-#if defined(UNX)
-sal_Char aLF[2] = \x00;
-#endif
if( rHTMLWrt.bLFPossible )
{
rHTMLWrt.OutNewLine( sal_True );
aIndMap = rHTMLWrt.GetIndentString();
aIndArea = rHTMLWrt.GetIndentString(1);
-#if defined(UNX)
-aLF[0] = SwHTMLWriter::sNewLine;
-pLF = aLF;
-#else
pLF = SwHTMLWriter::sNewLine;
-#endif
pIndArea = aIndArea.getStr();
pIndMap = aIndMap.getStr();
}
diff --git a/sw/source/filter/html/wrthtml.cxx
b/sw/source/filter/html/wrthtml.cxx
index a2f8a68..c73eb04 100644
--- a/sw/source/filter/html/wrthtml.cxx
+++ b/sw/source/filter/html/wrthtml.cxx
@@ -80,10 +80,10 @@
#define MAX_INDENT_LEVEL 20
-#if defined(UNX)
-const sal_Char SwHTMLWriter::sNewLine = '\012';
-#else
+#ifdef _WIN32
const sal_Char SwHTMLWriter::sNewLine[] = \015\012;
+#else
+const sal_Char SwHTMLWriter::sNewLine[] = \012;
#endif
static sal_Char sIndentTabs[MAX_INDENT_LEVEL+2] =
diff --git a/sw/source/filter/html/wrthtml.hxx
b/sw/source/filter/html/wrthtml.hxx
index 66f368d..5fb71bb 100644
--- a/sw/source/filter/html/wrthtml.hxx
+++ b/sw/source/filter/html/wrthtml.hxx
@@ -283,11 +283,7 @@ protected:
sal_uLong WriteStream();
public:
-#if defined(UNX)
-static const sal_Char sNewLine; // nur \012 oder \015
-#else
-static const sal_Char sNewLine[]; // \015\012
-#endif
+static const sal_Char sNewLine[];
std::vectorString aImgMapNames; // geschriebene Image Maps
std::setString aImplicitMarks;// implizite Stprungmarken
commit 246dda00dd1bd75d909721a0f758667332484402
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 21:32:37 2013 +0300
Test _WIN32 instead of WNT and UNX
Change-Id: I5c48fb1363609fe6d051794351fa5aaab29979b9
diff --git a/sw/source/filter/ascii/wrtasc.cxx
b/sw/source/filter/ascii/wrtasc.cxx
index a7ee4f1..3b03c5b 100644
--- a/sw/source/filter/ascii/wrtasc.cxx
+++ b/sw/source/filter/ascii/wrtasc.cxx
@@ -55,7 +55,7 @@ SwASCWriter::SwASCWriter( const OUString rFltNm )
break;
case 'A':
-#if !defined(WNT)
+#ifndef _WIN32
aNewOpts.SetCharSet( RTL_TEXTENCODING_MS_1252 );
aNewOpts.SetParaFlags( LINEEND_CRLF );
#endif
@@ -67,7 +67,7 @@ SwASCWriter::SwASCWriter( const OUString rFltNm )
break;
case 'X':
-#if !defined(UNX)
+#ifdef _WIN32
aNewOpts.SetCharSet( RTL_TEXTENCODING_MS_1252 );
aNewOpts.SetParaFlags( LINEEND_LF );
#endif
___
Libreoffice-commits mailing list
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/window.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 271ce90753d7004cfb2f1d1aeddd2ee4f36e16c4
Author: Tor Lillqvist t...@collabora.com
Date: Sat Oct 12 21:54:27 2013 +0300
It's whether X11 is used that is meant here
Change-Id: Ie03696eccde6b1a02a839321f84c6a23b73419ca
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 9aa6289..27df84f 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -8418,7 +8418,7 @@ uno::Reference XDragSource Window::GetDragSource()
aDropTargetSN =
OUString(com.sun.star.datatransfer.dnd.OleDropTarget);
aDragSourceAL[ 1 ] = makeAny( static_castsal_uInt64(
reinterpret_castsal_IntPtr(pEnvData-pView) ) );
aDropTargetAL[ 0 ] = makeAny( static_castsal_uInt64(
reinterpret_castsal_IntPtr(pEnvData-pView) ) );
-#elif defined UNX
+#elif HAVE_FEATURE_X11
aDragSourceSN =
OUString(com.sun.star.datatransfer.dnd.X11DragSource);
aDropTargetSN =
OUString(com.sun.star.datatransfer.dnd.X11DropTarget);
@@ -8504,7 +8504,7 @@ uno::Reference XClipboard Window::GetPrimarySelection()
{
uno::Reference XComponentContext xContext(
comphelper::getProcessComponentContext() );
-#if defined(UNX) !defined(MACOSX) !defined(IOS) !defined(ANDROID)
+#if HAVE_FEATURE_X11
// A hack, making the primary selection available as an
instance
// of the SystemClipboard service on X11:
css::uno::Sequencecss::uno::Any args(1);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: avmedia/source
avmedia/source/viewer/mediawindow_impl.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit 4446ee5ae039e30b82365014be408354838a9ae8 Author: Tor Lillqvist t...@collabora.com Date: Sat Oct 12 22:00:22 2013 +0300 Bin apparently unneeded #include Change-Id: Ib459531736b0c1cccfcb3f51aa58257c2c80e991 diff --git a/avmedia/source/viewer/mediawindow_impl.cxx b/avmedia/source/viewer/mediawindow_impl.cxx index adfe1cd..32ad2de 100644 --- a/avmedia/source/viewer/mediawindow_impl.cxx +++ b/avmedia/source/viewer/mediawindow_impl.cxx @@ -27,9 +27,6 @@ #include cmath #include osl/mutex.hxx #include vcl/svapp.hxx -#ifdef UNX -#include vcl/sysdata.hxx -#endif #include com/sun/star/awt/SystemPointer.hpp #include com/sun/star/lang/XComponent.hpp ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/CppunitTest_sw_odfimport.mk sw/qa sw/source
sw/CppunitTest_sw_odfimport.mk |1 +
sw/qa/extras/odfimport/odfimport.cxx | 18 ++
sw/source/ui/inc/olmenu.hxx |2 +-
3 files changed, 20 insertions(+), 1 deletion(-)
New commits:
commit 08c104a94cd4e4908f326c3e7c14aedd597665d0
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Oct 12 20:54:37 2013 +0200
sw: add missing testcase for spellmenu-redline.odt
There are various cases here, as a start just test that any spellcheck
popup menu in a redlined document should at least contain the go to
prev/next change menu items.
Change-Id: Ic70b6dae4cac8fd970ad54e5015a61d50b024b2b
diff --git a/sw/CppunitTest_sw_odfimport.mk b/sw/CppunitTest_sw_odfimport.mk
index 1320fef..ecaf98b 100644
--- a/sw/CppunitTest_sw_odfimport.mk
+++ b/sw/CppunitTest_sw_odfimport.mk
@@ -58,6 +58,7 @@ $(eval $(call gb_CppunitTest_use_components,sw_odfimport,\
filter/source/config/cache/filterconfig1 \
framework/util/fwk \
i18npool/util/i18npool \
+ lingucomponent/source/languageguessing/guesslang \
linguistic/source/lng \
package/util/package2 \
package/source/xstor/xstor \
diff --git a/sw/qa/extras/odfimport/odfimport.cxx
b/sw/qa/extras/odfimport/odfimport.cxx
index d661a67..d436d1a 100644
--- a/sw/qa/extras/odfimport/odfimport.cxx
+++ b/sw/qa/extras/odfimport/odfimport.cxx
@@ -17,6 +17,8 @@
#include swdtflvr.hxx
#include view.hxx
#include edtwin.hxx
+#include olmenu.hxx
+#include cmdid.h
typedef std::mapOUString, com::sun::star::uno::Sequence
com::sun::star::table::BorderLine AllBordersMap;
typedef std::pairOUString, com::sun::star::uno::Sequence
com::sun::star::table::BorderLine StringSequencePair;
@@ -38,6 +40,7 @@ public:
void testFdo37606Copy();
void testFdo69862();
void testFdo69979();
+void testSpellmenuRedline();
CPPUNIT_TEST_SUITE(Test);
#if !defined(MACOSX) !defined(WNT)
@@ -66,6 +69,7 @@ void Test::run()
{fdo37606.odt, Test::testFdo37606Copy},
{fdo69862.odt, Test::testFdo69862},
{fdo69979.odt, Test::testFdo69979},
+{spellmenu-redline.odt, Test::testSpellmenuRedline},
};
header();
for (unsigned int i = 0; i SAL_N_ELEMENTS(aMethods); ++i)
@@ -461,6 +465,20 @@ void Test::testFdo69979()
CPPUNIT_ASSERT_EQUAL(OUString(Hello.), rEnd.GetTxt());
}
+void Test::testSpellmenuRedline()
+{
+SwXTextDocument* pTxtDoc = dynamic_castSwXTextDocument
*(mxComponent.get());
+SwWrtShell* pWrtShell = pTxtDoc-GetDocShell()-GetWrtShell();
+OUString aParaText;
+uno::Referencelinguistic2::XSpellAlternatives xAlt;
+SwSpellPopup aPopup(pWrtShell, xAlt, aParaText);
+// Make sure that if we show the spellcheck popup menu (for the current
+// document, which contains redlines), then the last two entries will be
+// always 'go to next/previous change'.
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(FN_REDLINE_NEXT_CHANGE),
aPopup.GetItemId(aPopup.GetItemCount() - 2));
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(FN_REDLINE_PREV_CHANGE),
aPopup.GetItemId(aPopup.GetItemCount() - 1));
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(Test);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/ui/inc/olmenu.hxx b/sw/source/ui/inc/olmenu.hxx
index 23d1fd3..b21e0f4 100644
--- a/sw/source/ui/inc/olmenu.hxx
+++ b/sw/source/ui/inc/olmenu.hxx
@@ -34,7 +34,7 @@
class SwWrtShell;
-class SwSpellPopup : public PopupMenu
+class SW_DLLPUBLIC SwSpellPopup : public PopupMenu
{
SwWrtShell* pSh;
::com::sun::star::uno::Sequence ::com::sun::star::uno::Reference
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/inc/decl.h | 10 +-
sc/source/filter/lotus/memory.cxx |1 -
2 files changed, 1 insertion(+), 10 deletions(-)
New commits:
commit d7961b15572373a29cc0839858ae514db6238ccd
Author: Takeshi Abe t...@fixedpoint.jp
Date: Sun Oct 13 04:47:33 2013 +0900
Drop unused typedefs and #includes
Change-Id: I83f645ff93f7a351053b09d55ac23e9a5656d143
diff --git a/sc/source/filter/inc/decl.h b/sc/source/filter/inc/decl.h
index 5d484da..3860090 100644
--- a/sc/source/filter/inc/decl.h
+++ b/sc/source/filter/inc/decl.h
@@ -21,16 +21,8 @@
#ifndef SC_DECL_H
#define SC_DECL_H
-#include tools/solar.h
-
enum WKTYP { eWK_UNKNOWN = -2, eWK_1 = 0, eWK_2, eWK3, eWK4, eWK_Error, eWK123
};
-typedef void ( BEARBFKT )( void );
-typedef sal_Char STRING16[ 16 ];
-typedef sal_Char STRING14[ 14 ];
-typedef sal_Char STRING8[ 8 ];
-typedef sal_Char STRING6[ 6 ];
-typedef sal_uInt16 USHORT4[ 4 ];
-//typedef unsigned short USHORT4[ 4 ];
+
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/filter/lotus/memory.cxx
b/sc/source/filter/lotus/memory.cxx
index 3bfddfe..77c7b57 100644
--- a/sc/source/filter/lotus/memory.cxx
+++ b/sc/source/filter/lotus/memory.cxx
@@ -29,7 +29,6 @@
#include attrib.hxx
-#include decl.h
#include tool.h
extern ScDocument* pDoc;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: ATTENTION, creators of mysql-connector-ooo.oxt (--enable-ext-mariadb-connector)
Hi Thomas, 2013/10/12 Thomas Hackert thack...@nexgo.de just out of interest: For which OS/archticture did you build your extension? If you have one for Debian/AMD64, I can help to test it a little bit (but have to add, that I am using MariaDB here, if this does make any difference ... ;) ). I only build it for Windows, so no luck here ;) -- Jesús Corrius je...@softcatala.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70414] create VSProject files for code editing in MSVS from gbuild
https://bugs.freedesktop.org/show_bug.cgi?id=70414 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Whiteboard||EasyHack ||DifficultyInteresting ||SkillScript CC||dtar...@redhat.com, ||libreoffice@lists.freedeskt ||op.org, mst...@redhat.com Ever confirmed|0 |1 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70371] Identify unused headers
https://bugs.freedesktop.org/show_bug.cgi?id=70371 --- Comment #5 from Björn Michaelsen bjoern.michael...@canonical.com --- @Jelle: Awesome, quick work! Could you commit this to ./bin in the core repo (if you want to use gerrit, feel free to add me as a reviewer, so I can fasttrack that)? @Jorendc: Lets see how much false-positives there really are. If they are too many we might e.g. blacklist them (per platform). Another possibility would be to do `git grep` on the basename of the header and then see if there is any include statement for it. But first, lets get the script as-is in. ;) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: ATTENTION, creators of mysql-connector-ooo.oxt (--enable-ext-mariadb-connector)
Good morning Jesús, *, On Samstag, 12. Oktober 2013 23:29 Jesús Corrius wrote: 2013/10/12 Thomas Hackert thack...@nexgo.de just out of interest: For which OS/archticture did you build your extension? If you have one for Debian/AMD64, I can help to test it a little bit (but have to add, that I am using MariaDB here, if this does make any difference ... ;) ). I only build it for Windows, so no luck here ;) O.K. Thanks for your answer :) Then I cannot be of any help here ... ;) Have a nice day Thomas. -- Delta: We're Amtrak with wings. -- David Letterman ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sc/source
sc/source/ui/docshell/tablink.cxx | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
New commits:
commit 8b12ee3ae1f22ada7d8ffb3d86fb7c5b94ef1971
Author: Eike Rathke er...@redhat.com
Date: Thu Oct 10 18:02:25 2013 +0200
fixed another Out of bounds substring access
Introduced with 3c2a26c84e70fd996855181d319970e2230b2459
Didn't have consequences here because the result was used to check for a
startsWith condition which it wouldn't had matched anyway. However,
use the real startsWith() now.
(cherry picked from commit b1caf176a44b6979d2e0ea47f495a3dacf86e197)
With 5688ab5ba457ea9a50152570d161a11a1d093994 in 4-0 we should have this
as well.
Conflicts:
sc/source/ui/docshell/tablink.cxx
Change-Id: Ia1d558fc106d9a2010ad41c30f7eb2a2a480c59b
Reviewed-on: https://gerrit.libreoffice.org/6223
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com
diff --git a/sc/source/ui/docshell/tablink.cxx
b/sc/source/ui/docshell/tablink.cxx
index b7d3a54..7a28d22 100644
--- a/sc/source/ui/docshell/tablink.cxx
+++ b/sc/source/ui/docshell/tablink.cxx
@@ -522,12 +522,11 @@ bool ScDocumentLoader::GetFilterName(
void ScDocumentLoader::RemoveAppPrefix( rtl::OUString rFilterName )
{
-rtl::OUStringBuffer aAppPrefix;
-aAppPrefix.appendAscii(STRING_SCAPP);
-aAppPrefix.appendAscii(: );
-sal_Int32 nPreLen = aAppPrefix.getLength();
-if (rFilterName.copy(0, nPreLen).equals(aAppPrefix.makeStringAndClear()))
-rFilterName = rFilterName.copy(nPreLen);
+rtl::OUStringBuffer aBuf;
+aBuf.appendAscii( STRING_SCAPP).appendAscii( : );
+OUString aAppPrefix( aBuf.makeStringAndClear());
+if (rFilterName.startsWith( aAppPrefix))
+rFilterName = rFilterName.copy( aAppPrefix.getLength());
}
ScDocumentLoader::ScDocumentLoader( const rtl::OUString rFileName,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - sc/source
sc/source/ui/docshell/tablink.cxx | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
New commits:
commit 856e8cdf9cb67acfc858c9ca55bda5bd24ee7b57
Author: Eike Rathke er...@redhat.com
Date: Thu Oct 10 18:02:25 2013 +0200
fixed another Out of bounds substring access
Introduced with 3c2a26c84e70fd996855181d319970e2230b2459
Didn't have consequences here because the result was used to check for a
startsWith condition which it wouldn't had matched anyway. However,
use the real startsWith() now.
(cherry picked from commit b1caf176a44b6979d2e0ea47f495a3dacf86e197)
With f81ed484ffd443e2593627f3d8d3133161817af2 in 4-1 we should have this
as well.
Change-Id: Ia1d558fc106d9a2010ad41c30f7eb2a2a480c59b
Reviewed-on: https://gerrit.libreoffice.org/6218
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com
diff --git a/sc/source/ui/docshell/tablink.cxx
b/sc/source/ui/docshell/tablink.cxx
index 14ab878..ba1ed72 100644
--- a/sc/source/ui/docshell/tablink.cxx
+++ b/sc/source/ui/docshell/tablink.cxx
@@ -512,12 +512,11 @@ bool ScDocumentLoader::GetFilterName(
void ScDocumentLoader::RemoveAppPrefix( OUString rFilterName )
{
-OUStringBuffer aAppPrefix;
-aAppPrefix.appendAscii(STRING_SCAPP);
-aAppPrefix.appendAscii(: );
-sal_Int32 nPreLen = aAppPrefix.getLength();
-if (rFilterName.copy(0, nPreLen).equals(aAppPrefix.makeStringAndClear()))
-rFilterName = rFilterName.copy(nPreLen);
+OUStringBuffer aBuf;
+aBuf.appendAscii( STRING_SCAPP).appendAscii( : );
+OUString aAppPrefix( aBuf.makeStringAndClear());
+if (rFilterName.startsWith( aAppPrefix))
+rFilterName = rFilterName.copy( aAppPrefix.getLength());
}
ScDocumentLoader::ScDocumentLoader( const OUString rFileName,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] minutes of ESC call ...
On Thu, Oct 10, 2013 at 05:09:34PM +0100, Michael Meeks wrote: + Canonical bibisect repo is updated - since October 4th (Bjoern) + also started personal build of that, we have 2x of these running updating So, my local build is finished, and the last 20 build turned out right and usable. Unfortunately previous builds finished successfully, but are unusable because of fscking linkoo and esp. because of fscking linkoo even being being enabled by default. Luckily we now got rid of that crap (and good riddance), but still for this series of builds, that doesnt really help. I wonder, if I should upload this 20 build bibisect, so that we at least have something of a recent master build available for testers, or if I should skip this completely. Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 70284] EDITING: Assinged to of Names change to $#REF!
https://bugs.freedesktop.org/show_bug.cgi?id=70284 --- Comment #10 from yachiyo...@yahoo.co.jp --- Created attachment 87499 -- https://bugs.freedesktop.org/attachment.cgi?id=87499action=edit a before file with Define window capture This is a before file with Define window capture -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70284] EDITING: Assinged to of Names change to $#REF!
https://bugs.freedesktop.org/show_bug.cgi?id=70284 --- Comment #11 from yachiyo...@yahoo.co.jp --- Created attachment 87500 -- https://bugs.freedesktop.org/attachment.cgi?id=87500action=edit a file with Sheet copy. I upload a file with Sheet copy. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70284] EDITING: Assinged to of Names change to $#REF!
https://bugs.freedesktop.org/show_bug.cgi?id=70284 --- Comment #12 from yachiyo...@yahoo.co.jp --- I upload a file with Sheet copy. and upload a before file with Define window capture. When the number of the seats increased and decreased, I think that the address of the seat slips off by the seat which I add it and deleted. When I deleted a seat of the end or added a seat to the end, this phenomenon does not occur. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69695] Can't fill forms in doc file (treated as read-only)
https://bugs.freedesktop.org/show_bug.cgi?id=69695 tommy27 ba...@quipo.it changed: What|Removed |Added Summary|Not able to fill forms in |Can't fill forms in doc |doc file|file (treated as read-only) Version|4.1.2.2 rc |Inherited From OOo --- Comment #4 from tommy27 ba...@quipo.it --- test done. this issue is inherited from OOo. the test file is treated ad read-only and forms cannot be filled in OOo 3.3.0, in any LibO release (from 3.3.0 to 4.2 alpha Sept.10 build) and in AOO 4.0.0 as well. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61850] PDF: Exporting forms to PDF mis-formats in Adobe reader
https://bugs.freedesktop.org/show_bug.cgi?id=61850 --- Comment #5 from tommy27 ba...@quipo.it --- Created attachment 87501 -- https://bugs.freedesktop.org/attachment.cgi?id=87501action=edit PDF document (Export in LO4.1.2) test file can correctly exported to PDF with no loss of text in LibO 4.1.2 under Win7 64bit. see attached file. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61850] PDF: Exporting forms to PDF mis-formats in Adobe reader
https://bugs.freedesktop.org/show_bug.cgi?id=61850 tommy27 ba...@quipo.it changed: What|Removed |Added Component|Writer |Printing and PDF export -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61850] PDF: Exporting forms to PDF mis-formats in Adobe reader
https://bugs.freedesktop.org/show_bug.cgi?id=61850 tommy27 ba...@quipo.it changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC||ba...@quipo.it --- Comment #6 from tommy27 ba...@quipo.it --- set status to RESOLVED WFM. feel free to reopen if you still experience this bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70363] When paste the text from the Spreadsheet to Writer table appears a page break
https://bugs.freedesktop.org/show_bug.cgi?id=70363 Thomas van der Meulen pje335...@hotmail.com changed: What|Removed |Added Hardware|Other |All OS|Linux (All) |All Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Thomas van der Meulen pje335...@hotmail.com --- Thank you for your bug report, I can reproduce this bug running: Version: 4.1.2.3 Build ID: 40b2d7fde7e8d2d7bc5a449dc65df4d08a7dd38 OS: Windows 7 64-bits -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70363] When paste the text from the Spreadsheet to Writer table appears a page break
https://bugs.freedesktop.org/show_bug.cgi?id=70363 --- Comment #4 from Sergey Leschenko hart...@hartois.info --- I can also reproduce it on 4.1.1.2, 4.0.6.1. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35907] [FORMATTING] Using numbers with RTL text breaks underline
https://bugs.freedesktop.org/show_bug.cgi?id=35907 Eyal Rozenberg eyal...@technion.ac.il changed: What|Removed |Added OS|Linux (All) |All Severity|trivial |normal Priority|lowest |low --- Comment #9 from Eyal Rozenberg eyal...@technion.ac.il --- Seeing this bug with Win7 on X86-64, with v. 4.1.2.3 release. I've increased the severity based on Shimi's comment #4. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70394] New: Outline level/movement arrows don't belong in the Formatting toolbar
https://bugs.freedesktop.org/show_bug.cgi?id=70394 Priority: medium Bug ID: 70394 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Outline level/movement arrows don't belong in the Formatting toolbar Severity: trivial Classification: Unclassified OS: All Reporter: maz...@gmail.com Hardware: Other Status: UNCONFIRMED Version: 4.2.0.0.alpha0+ Master Component: UI Product: LibreOffice In LibreOffice Impress, the Outline level/movement arrows (Promote, Demote, Move Up, and Move Down) are displayed in the Formatting toolbar. However, they can't be applied to text objects like the rest of the commands in the toolbar. Instead, they can only be applied in Outline view. Therefore, it would make more sense to have these four buttons in the Outline toolbar. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70395] New: FILESAVE: Can not export as GIF with big size
https://bugs.freedesktop.org/show_bug.cgi?id=70395 Priority: medium Bug ID: 70395 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILESAVE: Can not export as GIF with big size Severity: normal Classification: Unclassified OS: All Reporter: alexpik...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.1.2.3 rc Component: Drawing Product: LibreOffice Problem description: When I try to export picture from libreoffice draw to GIF I can not get more size than 595x841 pixels. Steps to reproduce: 1. Run libreoffice draw 2. click File-Export 3. Select GIF file type 4. Press Save button 5. In window Options set width more than 595 pixels and press OK. Current behavior: The created file has a size of 595x841 pixels. Expected behavior: The file should have a size which was set in Options dialogue. I have tried it in libreoffice 4.0.3 and 4.1.2.3 in Windows 7 and libreoffice 4.1.0-5~bpo70+3 from debian backports with the same result. Exporting to BMP or JPEG is correct. Best wishes, Alexandr Operating System: All Version: 4.1.2.3 rc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70396] New: CONFIGURATION: Font colours
https://bugs.freedesktop.org/show_bug.cgi?id=70396 Priority: medium Bug ID: 70396 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: CONFIGURATION: Font colours Severity: normal Classification: Unclassified OS: Windows (All) Reporter: asharp...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.0.5.2 release Component: Writer Product: LibreOffice This is not a bug report but this page is where the link from LibreOffice Writer Send Feedback brought me. The default colour for the font is black which is fine. But if I want to select a different colour from the font colour icon, it defaiults to a dirty brown. Is it possible to make the default an option of the user's choosing? Operating System: Windows 7 Version: 4.0.5.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68558] EDITING: Custom text formatting error
https://bugs.freedesktop.org/show_bug.cgi?id=68558 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Attachment #87390|application/octet-stream|application/vnd.oasis.opend mime type||ocument.speadsheet -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68558] EDITING: Custom text formatting error
https://bugs.freedesktop.org/show_bug.cgi?id=68558 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Attachment #87390|application/vnd.oasis.opend |application/vnd.oasis.opend mime type|ocument.speadsheet |ocument.spreadsheet -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67130] LibO does not start if not all components of LibO are installed in certain cases
https://bugs.freedesktop.org/show_bug.cgi?id=67130 --- Comment #6 from Andras Timar tima...@gmail.com --- The culprit is share/registry/librelogo.xcd. If it is there, and writer.xcd is not there, the LibreOffice will not start. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69030] Multiple instances of the Unity launcher icon for the same LO-App (e.g. writer) instead of grouping
https://bugs.freedesktop.org/show_bug.cgi?id=69030 --- Comment #4 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Thank you Marco for the workaround, but I have the same problem with the generic Linux version on Ubuntu 13.04 and this workaround does not work in this case. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67592] SELECTING: allow to resize selection box from any corner
https://bugs.freedesktop.org/show_bug.cgi?id=67592 Victor Krymskiy ilr...@hotmail.com changed: What|Removed |Added Status|RESOLVED|VERIFIED Resolution|FIXED |WORKSFORME --- Comment #16 from Victor Krymskiy ilr...@hotmail.com --- (In reply to comment #15) The functionality is now in daily builds. I tested it on this buld (under Ubuntu): on: 4.2.0.0.alpha0+ Build ID: b1caf176a44b6979d2e0ea47f495a3dacf86e197 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2013-10-12_06:04:49 The corners are moving in spite of the fact the sum is not calculating. By the way it seems to be working. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70133] Missing startcenter in gnome-shell menu
https://bugs.freedesktop.org/show_bug.cgi?id=70133 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||jbf.fa...@sud-ouest.org Ever confirmed|0 |1 --- Comment #6 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Same problem in Unity. The file .desktop exists in /opt/libreoffice4.1/share/xdg and the link in /usr/share/applications exists too but it does not appear in the dash. Same problem with LibreOffice 4.1 Math module. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68108] FORMATTING: LibreOffice Calc - Date Sorting Issue
https://bugs.freedesktop.org/show_bug.cgi?id=68108 --- Comment #7 from yagolf yagonuch...@hotmail.com --- I can confirm this bug in LibreOffice 4.1.1.2 Build ID: 410m0(Build:2) on Linux Mint 13 64bit running the Gnome Shell. I've tried importing with different encodings (UTF-8, Western Europe (ISO-8859-2) and Western Europe (ASCII/US). I've also tried using different locales (though only English-US and English-UK, the latter being my default one), and 'detecting special characters', and still dates are not imported correctly no matter how you format the data (or without formatting it at all) Very annoying as it forces me to reboot into Windows and use Excel just to get this done properly -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70398] New: libreoffice frezzes, when trying to save an NAS-Server
https://bugs.freedesktop.org/show_bug.cgi?id=70398 Priority: medium Bug ID: 70398 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: libreoffice frezzes, when trying to save an NAS-Server Severity: blocker Classification: Unclassified OS: Mac OS X (All) Reporter: i...@hautog.de Hardware: Other Status: UNCONFIRMED Version: unspecified Component: BASIC Product: LibreOffice Version: 4.1.1.2 Build ID: 7e4286b58adc75a14f6d83f53a03b6c11fa2903 hello, I tried to save a textfile on a NAS-Server, which was in sleeping-mode. The NAS doesnt start then and the libreoffice freezes. OTHER PROGRAMS wait until the NAS is online again and then save the files. The NAS is an Synology DS 213 with kindly regards Frank -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61850] PDF: Exporting forms to PDF mis-formats in Adobe reader
https://bugs.freedesktop.org/show_bug.cgi?id=61850 --- Comment #7 from Paul Simmonds p...@digitaljingle.co.uk --- Created attachment 87502 -- https://bugs.freedesktop.org/attachment.cgi?id=87502action=edit Screen Cap of ODT document / form in LO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61850] PDF: Exporting forms to PDF mis-formats in Adobe reader
https://bugs.freedesktop.org/show_bug.cgi?id=61850 --- Comment #8 from Paul Simmonds p...@digitaljingle.co.uk --- Created attachment 87503 -- https://bugs.freedesktop.org/attachment.cgi?id=87503action=edit Screen Cap of PDF document / form in Acrobat -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61850] PDF: Exporting forms to PDF mis-formats in Adobe reader
https://bugs.freedesktop.org/show_bug.cgi?id=61850 Paul Simmonds p...@digitaljingle.co.uk changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #9 from Paul Simmonds p...@digitaljingle.co.uk --- Test document tried in latest LO (4.1.2.3 on Windows 7) this problem is *** NOT *** fixed. See the two screen captures; One from LO 4.1.2.3 with the test document, clearly showing correctly aligned text and three lines showing in the large text entry box. Then see the Adobe Acrobat screen capture where the single line is not aligned correctly, and there is only one line showing in the big text box. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70399] New: Port Solver for Nonlinear Programming to native code
https://bugs.freedesktop.org/show_bug.cgi?id=70399 Priority: medium Bug ID: 70399 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Port Solver for Nonlinear Programming to native code Severity: enhancement Classification: Unclassified OS: All Reporter: vascofal...@gmail.com Hardware: All Status: UNCONFIRMED Version: unspecified Component: Spreadsheet Product: LibreOffice I think the NLP Solver really needs to be ported to native code. It reduces Java code, which seems to be a sort of mid-term goal for LO. It also performs some of the most performance intensive operations in the whole of LO, so it seems we'd wand this to run closer to the metal. Microsoft Excel of course has non-linear algorithms fully integrated. PS - I wasn't sure whether to submit this to Spreadsheet or Extensions. Please move it if it's not in the correct section. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70363] When paste the text from the Spreadsheet to Writer table appears a page break
https://bugs.freedesktop.org/show_bug.cgi?id=70363 --- Comment #5 from Sergey Leschenko hart...@hartois.info --- In 4.0.0.1 version - inserting blank line. Since 4.0.0.2 - reproduce bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70371] Identify unused headers
https://bugs.freedesktop.org/show_bug.cgi?id=70371 --- Comment #2 from Jelle van der Waa je...@vdwaa.nl --- Created attachment 87504 -- https://bugs.freedesktop.org/attachment.cgi?id=87504action=edit compares workdir files with git ls-tree -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70371] Identify unused headers
https://bugs.freedesktop.org/show_bug.cgi?id=70371 --- Comment #3 from Jelle van der Waa je...@vdwaa.nl --- (In reply to comment #2) Created attachment 87504 [details] compares workdir files with git ls-tree This is a work in progress quickly hacked perl script, which should do what is descibed in the request. Example output: http://sprunge.us/CZSh Note: I've disabled some options when compiling so there might be some false-positives ;) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62664] cells gets formatted by itself
https://bugs.freedesktop.org/show_bug.cgi?id=62664 --- Comment #5 from Dominique Boutry dominique.bout...@laposte.net --- The behaviour that I understand is : - there is a difference between the (unique) active cell (the one with large black border, reported in the heading) and the one or more cells selected (the ones with light blue background) - a format command applies to the selected cell(s) if any, and defaulted to the active cell if there are no selected cells - no ambiguity when the format is the settings of a background, - a precise behaviour is needed when the format is the setting of borders, in order to distinguish between inner and outer borders of the selected cells. And in fact the results appears a little bit fancyful. Just one exemple below. - on a new Calc sheet, click on B3, ctrl-click on C2, C3 and D3, no matter the order, resulting in 4 selected cells (B3, C2, C3, D3) - format cell border, select the 2 external horizontals, OK - then click on B6, ctrl-click on C5, C6 and D6, no matter the order, resulting in 4 selected cells (B6, C5, C6, D6) - format cell border, select the 2 external verticals, OK - compare the two resuls. Can't we say that the horizontal outline is understandable, while the vertical one is not (in particular, for C6) ? The issue would be : please write down current implemented rules ; if it is impracticable, please imagine, write in docs and implement a rule understandable and useful for users. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70371] Identify unused headers
https://bugs.freedesktop.org/show_bug.cgi?id=70371 --- Comment #4 from Jorendc jore...@libreoffice.org --- (In reply to comment #0) This might still create some false positives because of e.g. platform dependant files, but it should be a good starting point: Obviously such headers if truly unused, should be removed from the repository tree. Just a thought from a non-developer: what if we combine the output of all platforms (tinderboxes for example)? If header 'A' comes up in all output files, we can be (almost?) sure it isn't platform dependent. Isn't it? Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63394] Function edition pane at Calc dont scrolling
https://bugs.freedesktop.org/show_bug.cgi?id=63394 --- Comment #1 from Dominique Boutry dominique.bout...@laposte.net --- It looks like a bad placement of the formula edition pane (too high ; the top arrow of the scrolling bar is hiden), i.e. a pure UI bug. - what host, what LibO version ? - any idea of the steps done just before this situation, which could have caused it ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63394] Function edition pane at Calc dont scrolling
https://bugs.freedesktop.org/show_bug.cgi?id=63394 --- Comment #2 from Dominique Boutry dominique.bout...@laposte.net --- Sorry, I have just see now the host and the LibO version. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65323] Objects anchored as characters aren't treated as characters
https://bugs.freedesktop.org/show_bug.cgi?id=65323 --- Comment #3 from Mike Kaganski mikekagan...@hotmail.com --- (In reply to comment #2) - OpenOffice apparently endorses that an object behave like a word-breaking character rather than en alphabetic character ; so the point 1 is not a bug, - both solutions are defendable You are absolutely right! I must have thought about this myself. however, if you think that the string (formula) must be processed like a word (for the purpose of wrapping) so that anchored as character must now be understood as anchored as alphabetical character, I'm afraid that it raises new bug issues like my sentence sentence_bodylarge_image_object does no longer wrap correctly when sentence_body ends with a letter : the wrapped image always pulls the last word with her... You are right; however, the current state only allows for one thing: unconditionally wrapping the object. The proposed change allows one to control this: simply add the spaces around objects that need wrapping, and everything is OK; otherwise, if you need object to stay with leading/trailing text, it is doable by omitting the space. This is likely to break layout of some existing documents. This may be mitigated either by automatically inserting spaces (if absent) around such objects on importing documents created by older versions (this needs knowledge of version of creator software), or by introducing a new option selectable by user document-wide or per object. - may I suggest that you include the parenthesis into the formula ? No :) Actually, this is a wrong approach. Consider this text: some text (for example, formula object). Here, if I put right closing parenthesis into the formula, I run into a number of issues: 1. I must use the syntax right none ... left ) inside the formula to enter only one parenthesis, and it is the scaling parenthesis, so it will likely not match the size of opening parenthesis written in plain text; 2. Even if I manage to enter one closing parenthesis of correct size (by enclosing it in quotes in formula), it will likely be of a different shape (by different font); 3. Even if I define the same font for the formula (which may be undesirable, to keep visual distinction of formulas), I will depend on correct vertical alignment of the parenthesis (which is not always that correct), so the parenthesis will likely be misaligned. 4. The resulting text will fire warnings from spell checker. And maybe there are some other issues I haven't thought of. - I confirm that textblankobjectparagraph_mark matches [[:space:]]$, - This fact can't be summarized as ... there is no object... because spaceobjectspace doen't match spacespace (either with and without the Regular Expression box checked) - also this text spaceobjectspace doesn't match [[:space:]][[:space:]] but it matches [[:space:]].[[:space:]] - so the bug is : inconsistencies in the way the pseuso-character representing an object anchored as character is used anywhere (word wrapping, searching, etc). A consistent behaviour should be proposed, closest to the current behaviour. I agree. And I think that the correct behavior of search and replace should treat such objects as a character that can be matched by regexes like ., [^[:space:]], [^[:alpha:]], [^[:digit:]], [[:print:]] (because it's printable object), [^[:cntrl:]], [^[:lower:]], [^[:upper:]]. If so, lines like textspaceobject will not match regex [[:space:]]$ I think that this issue should be split to two (one bug report about regexes and one RFE). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64111] EDITING: Editing input fields is not consistent with other fields
https://bugs.freedesktop.org/show_bug.cgi?id=64111 --- Comment #1 from Dominique Boutry dominique.bout...@laposte.net --- I can't reproduce the issue (LibO 4.0.5.2, Win7), I can't even get the dialog you provided as attachment. Can you please list the minimum steps to get it from a new empty text ? Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70175] missing characters
https://bugs.freedesktop.org/show_bug.cgi?id=70175 --- Comment #6 from Rob Snelders programm...@ertai.nl --- Please go to the terminal and run locale. Then post here the output. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70400] New: Other: Can't print do Lexmark printer
https://bugs.freedesktop.org/show_bug.cgi?id=70400 Priority: medium Bug ID: 70400 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Other: Can't print do Lexmark printer Severity: normal Classification: Unclassified OS: Linux (All) Reporter: herbert_hornda...@web.de Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.1.2.3 rc Component: Libreoffice Product: LibreOffice Problem description: Lexmark printers (E360dn and C544) do not print. Steps to reproduce: 1. Open any document 2. STRG+P or by icon 3. Print Current behavior: First time printer is making some noise put does not grab the paper. At the next times I want to print, printer does nothing. Expected behavior: Printing It occours only with Lexmark printers. Kyocera and Epson work as expected. Also printing from other applications (firefox, Gedit, kate) does work with the Lexmark printers. PPD is called: E360dn, Postscript-Lexmark 20130226 (Openprinting LSB 3.2) PS I'm not sure about the latest known-working version as it is a new system and the old laptop is formated. Operating System: Ubuntu Version: 4.1.2.3 rc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64312] UI strange behaviour of formula text box
https://bugs.freedesktop.org/show_bug.cgi?id=64312 --- Comment #11 from Dominique Boutry dominique.bout...@laposte.net --- Same bug than 63394, I guess -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70353] Datei Tabellenkalkulation wird für Office XP beschädigt
https://bugs.freedesktop.org/show_bug.cgi?id=70353 Rob Snelders programm...@ertai.nl changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64591] Tables borders not properly displayed in writer
https://bugs.freedesktop.org/show_bug.cgi?id=64591 --- Comment #4 from Dominique Boutry dominique.bout...@laposte.net --- Reproduced with LibO 4.0.5.2 on Win7. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70240] When starting LibreOffice, documents to be restored are always shown...but cannot be restored
https://bugs.freedesktop.org/show_bug.cgi?id=70240 --- Comment #2 from Foss f...@openmailbox.org --- Also, does this still happen with 4.1.2.3? http://www.libreoffice.org/download -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70383] Other: Openning PDFs
https://bugs.freedesktop.org/show_bug.cgi?id=70383 Rob Snelders programm...@ertai.nl changed: What|Removed |Added OS|Windows (All) |All Severity|normal |enhancement Priority|medium |lowest --- Comment #1 from Rob Snelders programm...@ertai.nl --- This isn't a bug because only draw can read PDF-files. Writer can't read them. I don't think this should be implemented soon. Maybe somebody else can tell what he/she thinks. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70400] Other: Can't print do Lexmark printer
https://bugs.freedesktop.org/show_bug.cgi?id=70400 --- Comment #1 from Herb herbert_hornda...@web.de --- Addition: The problem is occuring when printing by (W)LAN and by USB. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70383] Other: Opening PDFs in Writer
https://bugs.freedesktop.org/show_bug.cgi?id=70383 Rob Snelders programm...@ertai.nl changed: What|Removed |Added Summary|Other: Openning PDFs|Other: Opening PDFs in ||Writer Component|Printing and PDF export |Writer -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62664] cells gets formatted by itself
https://bugs.freedesktop.org/show_bug.cgi?id=62664 --- Comment #6 from andrej8anu...@gmail.com --- Created attachment 87511 -- https://bugs.freedesktop.org/attachment.cgi?id=87511action=edit 1 beginning - some cells -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62664] cells gets formatted by itself
https://bugs.freedesktop.org/show_bug.cgi?id=62664 --- Comment #7 from andrej8anu...@gmail.com --- Created attachment 87512 -- https://bugs.freedesktop.org/attachment.cgi?id=87512action=edit 2 select cells to get formatted -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62664] cells gets formatted by itself
https://bugs.freedesktop.org/show_bug.cgi?id=62664 --- Comment #8 from andrej8anu...@gmail.com --- Created attachment 87513 -- https://bugs.freedesktop.org/attachment.cgi?id=87513action=edit 3 format ONLY the upper side of the cells - everything else leave untouched -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62664] cells gets formatted by itself
https://bugs.freedesktop.org/show_bug.cgi?id=62664 --- Comment #10 from andrej8anu...@gmail.com --- Please see the pictures appended (names with explanation) 1 beginning - some cells.png 2 select cells to get formatted.png 3 format ONLY the upper side of the cells - everything else leave untouched.png 4 result - cells are ALSO formatted in the middle of previously selected cells - FAIL.png -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62664] cells gets formatted by itself
https://bugs.freedesktop.org/show_bug.cgi?id=62664 --- Comment #9 from andrej8anu...@gmail.com --- Created attachment 87514 -- https://bugs.freedesktop.org/attachment.cgi?id=87514action=edit 4 result - cells are ALSO formatted in the middle of previously selected cells - FAIL -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61850] PDF: Exporting forms to PDF mis-formats in Adobe reader
https://bugs.freedesktop.org/show_bug.cgi?id=61850 --- Comment #10 from tommy27 ba...@quipo.it --- did you see my attached PDF? it looks the same as the source .ODT I do not see the differences of your screenshots. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69195] Crash when delete a style in use
https://bugs.freedesktop.org/show_bug.cgi?id=69195 Jorendc jore...@libreoffice.org changed: What|Removed |Added Status|NEW |NEEDINFO CC||jore...@libreoffice.org --- Comment #1 from Jorendc jore...@libreoffice.org --- I fail to reproduce this, tested using Linux Mint 15 x64 with LibreOffice Version: 4.1.1.2 Build ID: 7e4286b58adc75a14f6d83f53a03b6c11fa2903 @Gabriel: you mind creating a small test document so I can try to reproduce this behaviour? I did some work related to style-deletion, so I might have introduce this behaviour (but I have to reproduce it before I can fix it :) ) Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61850] PDF: Exporting forms to PDF mis-formats in Adobe reader
https://bugs.freedesktop.org/show_bug.cgi?id=61850 --- Comment #11 from Paul Simmonds p...@digitaljingle.co.uk --- This is a problem with the Form Fields. Look at the two screen captures, On Open Office you can see one correct line in the top form field, and three lines in the large form field On the export to PDF then the top form field is corrupted with the top half of the characters truncated and in the large form field only one line shows. Basically, something in the export appears to be adding space before or after the paragraph when exporting to PDF. I currently have to maintain an old copy of OpenOffice 3.2.0 so I can PDF my fillable forms - this was the last version it appeared to work correctly in. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48233] VIEWING: Writer Option Display Drawings and controls without Function
https://bugs.freedesktop.org/show_bug.cgi?id=48233 --- Comment #3 from Harald Koester harald.koes...@mail.de --- Bug still exists in Version 4.1.2.3. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67263] CRASH when deleting applied bulleted paragraph style [EDITING, FORMATTING]
https://bugs.freedesktop.org/show_bug.cgi?id=67263 --- Comment #3 from Jorendc jore...@libreoffice.org --- Created attachment 87516 -- https://bugs.freedesktop.org/attachment.cgi?id=87516action=edit backtrace Reproducible using Linux Mint 15 x64 with LibreOffice Version: 4.2.0.0.alpha0+ Build ID: ff7ba8c81c3b00722e58ed01a1ab361094aeb609 Attached a backtrace -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67263] CRASH when deleting applied bulleted paragraph style [EDITING, FORMATTING]
https://bugs.freedesktop.org/show_bug.cgi?id=67263 Jorendc jore...@libreoffice.org changed: What|Removed |Added Keywords||have-backtrace -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69114] Some exported XLS files (using matrix formulas) will crash in Excel
https://bugs.freedesktop.org/show_bug.cgi?id=69114 --- Comment #3 from Christian Fries em...@christian-fries.de --- I had this problem again today with a fresh install of 4.1.2.3 (current and very new version). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69114] Some exported XLS files (using matrix formulas) will crash in Excel
https://bugs.freedesktop.org/show_bug.cgi?id=69114 --- Comment #4 from Christian Fries em...@christian-fries.de --- PS: I am using MacOS and the daily build directory is often empty... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64111] EDITING: Editing input fields is not consistent with other fields
https://bugs.freedesktop.org/show_bug.cgi?id=64111 --- Comment #2 from Yann Papouin yann.papo...@gmail.com --- Press CTRL+F2 or use the menu: Insert Fields Other... In this dialog you can create some function fields like: - Conditional text - Input Field - Placeholder - etc. After adding a input field you can click on it to edit its name and to edit its reference, you have to do a right click (contextual menu) and click on Fields... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69114] Some exported XLS files (using matrix formulas) will crash in Excel
https://bugs.freedesktop.org/show_bug.cgi?id=69114 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|WORKSFORME |--- CC||markus.mohrhard@googlemail. ||com --- Comment #5 from Joel Madero jmadero@gmail.com --- Yes indeed - it seems like the patch never found it's way into 4.1. I'm going to mark this as NEW and add Markus to see if he can help locate what fixed it with 4.2. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69114] Some exported XLS files (using matrix formulas) will crash in Excel
https://bugs.freedesktop.org/show_bug.cgi?id=69114 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33798] In certain partial installation scenarios just one module gets installed
https://bugs.freedesktop.org/show_bug.cgi?id=33798 Andras Timar tima...@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |tima...@gmail.com |desktop.org | --- Comment #12 from Andras Timar tima...@gmail.com --- gm_Prg has gm_p_Wrt, gm_p_Calc, etc. children. gm_p_Wrt also has children, but they are hidden: gm_p_Wrt_Bin, gm_Brand_p_Wrt, gm_p_Wrt_MSO_Reg. Documentation says: To guarantee that the child feature's state always follows the state of its parent, even when the child and parent are initially set to absent in the SelectionTree Control, you must include both msidbFeatureAttributesFollowParent and msidbFeatureAttributesUIDisallowAbsent in the attributes of the child feature. Note that if you set msidbFeatureAttributesFollowParent without setting msidbFeatureAttributesUIDisallowAbsent, the installer cannot force the child feature out of the absent state. In this case, the child feature matches the parent's installation state only if the child is set to something other than absent. Set msidbFeatureAttributesFollowParent and msidbFeatureAttributesUIDisallowAbsent to ensure a child feature follows the state of the parent feature. So the solution of this bug in my opinion will be, that we set msidbFeatureAttributesUIDisallowAbsent bit for the hidden features. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41884] [Task] Windows Installer Most Annoying Bugs
https://bugs.freedesktop.org/show_bug.cgi?id=41884 Bug 41884 depends on bug 33798, which changed state. Bug 33798 Summary: In certain partial installation scenarios just one module gets installed https://bugs.freedesktop.org/show_bug.cgi?id=33798 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57433] Borderless toolbars in 4.x
https://bugs.freedesktop.org/show_bug.cgi?id=57433 --- Comment #25 from Emir Sarı emir_s...@msn.com --- I think these patches might be related: http://cgit.freedesktop.org/libreoffice/core/commit/?id=264cf8bffa598326b255e352d4e4a7a791cf8409 http://cgit.freedesktop.org/libreoffice/core/commit/?id=dd7382353d4c248a6d6f9d21401480ccc37e2b9d http://cgit.freedesktop.org/libreoffice/core/commit/?id=18ad2ef60ec192089dd5ac9a01e0ccefc8207c7d http://cgit.freedesktop.org/libreoffice/core/commit/?id=9b10ef9fc39dc0251b03d6d9285bb86aab29abee For the ideal look, I've slightly modified the image in 3.6 Release Notes, more or less the ideal look should be like this, I've just added a border to the white area of the ruler as well. This way with the toolbar (viewshell) and the ruler looks distinguished from the document area. I didn't draw for the vertical ruler for the mock-up, but it should be the same as well. Here's the image: http://imgur.com/NO1YtOx -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69548] Hyperlinks with spaces in between words in the url work but then change themselves after reopening document (libreoffice deletes the space in the url).
https://bugs.freedesktop.org/show_bug.cgi?id=69548 Mihkel Tõnnov mihh...@gmail.com changed: What|Removed |Added CC||mihh...@gmail.com --- Comment #3 from Mihkel Tõnnov mihh...@gmail.com --- (In reply to comment #2) (In reply to comment #1) a hyperlink with spaces in between words in the target/url works at first but once you save, close, then reopen the document the hyperlink has changed itself to get rid of spaces (this happens with all hyperlinks that have spaces in them whether they be to a bookmark within the document, a link to another document, a link to a bookmark in another document, etc.) *this happens with all hyperlinks that have spaces in their target/url whether ... Could you be more specific, i.e. what are the steps needed to observe this behaviour? Currently, I can't reproduce this on 4.1.3 RC1. What I tried: Insert - Hyperlink, set some pseudo-URL with spaces in it as Target, saved the file, then closed and reopened it. Upon hovering the link the URL looked like it was before, and when I opened the hyperlink dialog again, the target was displayed as it was before there as well. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
