[Bug 64945] inconvenient localized symbol code
https://bugs.freedesktop.org/show_bug.cgi?id=64945 vulc...@gmx.com changed: What|Removed |Added CC||vulc...@gmx.com Blocks||65675 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
LibreOffice Gerrit News for core on 2014-09-08
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + mediawiki: improve storeConfiguration loadConfiguration methods in https://gerrit.libreoffice.org/11331 from Robert Antoni Buj i Gelonch about module swext + xmerge: Integer Boolean Parsing in https://gerrit.libreoffice.org/11329 from Robert Antoni Buj i Gelonch about module xmerge + qadevOOo: All classes in the java.lang package are imported by default in https://gerrit.libreoffice.org/11325 from Robert Antoni Buj i Gelonch about module qadevOOo + qadevOOo: remove import from the same package in https://gerrit.libreoffice.org/11324 from Robert Antoni Buj i Gelonch about module qadevOOo + qadevOOo: reuse the value of entryName.indexOf(Left Parenthesis) in https://gerrit.libreoffice.org/11323 from Robert Antoni Buj i Gelonch about module qadevOOo + scripting: the assigned value is never used in https://gerrit.libreoffice.org/11319 from Robert Antoni Buj i Gelonch about module scripting + scripting: if...else if...else Statement in https://gerrit.libreoffice.org/11322 from Robert Antoni Buj i Gelonch about module scripting + l10ntools/source/export.cxx: add sanity check to aOutput.mSimple in https://gerrit.libreoffice.org/11321 from Douglas Mencken about module l10ntools + l10ntools/source/export.cxx: be more std:: in https://gerrit.libreoffice.org/11320 from Douglas Mencken about module l10ntools + l10ntools/source/export.cxx: improve style of code in https://gerrit.libreoffice.org/11318 from Douglas Mencken about module l10ntools + l10ntools-transex3: convert 'int' to 'bool' where it's logical in https://gerrit.libreoffice.org/11317 from Douglas Mencken about module l10ntools + l10ntools/inc/helper.hxx: bin unused header cassert in https://gerrit.libreoffice.org/11316 from Douglas Mencken about module l10ntools + l10ntools-transex3: make pParseQueue field private in https://gerrit.libreoffice.org/11315 from Douglas Mencken about module l10ntools End of freshness + Make configure respect --without-system-$lib-for-build in https://gerrit.libreoffice.org/11330 from Peter Foley about module build + Improve toolbar tooltips in Writer standard toolbar in https://gerrit.libreoffice.org/11303 from Samuel Mehrbrodt about module framework, officecfg, sw + semibold - bold in Color Picker headings in https://gerrit.libreoffice.org/11328 from Adolfo Jayme Barrientos about module cui + fdo#82502 Ctrl-F should select the text in the search bar, not close it in https://gerrit.libreoffice.org/0 from Samuel Mehrbrodt about module svx * Merged changes on master for project core changed in the last 25 hours: + javaunohelper: fix javadoc error: unknown tag: attention (Doxygen) in https://gerrit.libreoffice.org/11308 from Robert Antoni Buj i Gelonch + reportbuilder: fix javadoc error: reference not found in https://gerrit.libreoffice.org/11309 from Robert Antoni Buj i Gelonch + scripting: there isn't any benefit by reducing the scope here. in https://gerrit.libreoffice.org/11312 from Robert Antoni Buj i Gelonch + fdo#83428: Custom Properties dropped while exporting to docx in https://gerrit.libreoffice.org/11265 from Heena Gupta + create clang plugin to warn about C-style casts in https://gerrit.libreoffice.org/10367 from Noel Grandin + more accurate typing in https://gerrit.libreoffice.org/11314 from Lionel Elie Mamane + AUTH_FIELD_END looks like it is made for this in https://gerrit.libreoffice.org/11313 from Lionel Elie Mamane + Make OOO_EXIT_POST_STARTUP behave more nicely when blank in https://gerrit.libreoffice.org/11264 from Matthew Francis * Abandoned changes on master for project core changed in the last 25 hours: + Add Calculate Hard to Calc menubar and improve wording in https://gerrit.libreoffice.org/11305 from Samuel Mehrbrodt + fdo#81272 Attempt to speed up xdictionary::seekSegment() in https://gerrit.libreoffice.org/11280 from Matthew Francis + l10ntools: fixes and improvements for transex3 executable in https://gerrit.libreoffice.org/10212 from Douglas Mencken * Open changes needing tweaks, but being untouched for more than a week: + fdo#79018: LO hangs while opening file. in https://gerrit.libreoffice.org/9564 from Yogesh Bharate + fdo#81426 : Data from header and footer is getting lost. in https://gerrit.libreoffice.org/10531 from Rajashri Udhoji + fdo#79541 :Corrupt: Shape enclosed within a floating table in https://gerrit.libreoffice.org/9914 from Rajashri Udhoji + fdo#80996:Fix for DataLabel not preserved for ColumnChart after RT in https://gerrit.libreoffice.org/10169 from Dushyant Bhalgami + fdo#77716 : Paragraph spacing is not preserved after RT. in https://gerrit.libreoffice.org/9197 from Tushar Bende + fdo#77121 Header / Footer positions not preserved after RT in https://gerrit.libreoffice.org/9235 from Priyanka Gaikwad Best, Your
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 vulc...@gmx.com changed: What|Removed |Added Depends on||64945 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Jaumann license statement
Hi, all my current and past contributions made to the LibreOffice project may be licensed under the MPLv2/LGPLv3+ dual license. Until further notice, all my future contributions to the LibreOffice project are available under the MPLv2/LGPLv3+ dual license. Best regards, Michael Jaumann___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: l10ntools/inc l10ntools/source
l10ntools/inc/export.hxx|6 --
l10ntools/source/export.cxx |6 +++---
2 files changed, 7 insertions(+), 5 deletions(-)
New commits:
commit 5aeb852efcabdd51545d5d41c92f4bf3cef1d663
Author: Douglas Mencken dougmenc...@gmail.com
Date: Sun Sep 7 03:48:53 2014 -0400
l10ntools-transex3: make pParseQueue field private
Change-Id: Ieefed6e939e12b668a635eb8d7e70def2d52a85d
Reviewed-on: https://gerrit.libreoffice.org/11315
Reviewed-by: Norbert Thiebaud nthieb...@gmail.com
Tested-by: Norbert Thiebaud nthieb...@gmail.com
diff --git a/l10ntools/inc/export.hxx b/l10ntools/inc/export.hxx
index 4415e30..2010293 100644
--- a/l10ntools/inc/export.hxx
+++ b/l10ntools/inc/export.hxx
@@ -145,6 +145,8 @@ private:
std::vectorOString aLanguages;
+ParserQueue* pParseQueue;
+
bool WriteData( ResData *pResData, bool bCreateNew = false ); /// called
before dest. cur ResData
bool WriteExportList( ResData *pResData, ExportList rExportList, const
sal_uInt16 nTyp );
@@ -179,13 +181,13 @@ public:
void Init();
int Execute( int nToken, const char * pToken ); /// called from lexer
+
void SetError() { bError = true; }
bool GetError() { return bError; }
-ParserQueue* pParseQueue; // public!!
+ParserQueue* GetParseQueue() { return pParseQueue; }
};
-
// class MergeEntrys
diff --git a/l10ntools/source/export.cxx b/l10ntools/source/export.cxx
index 6f8c8b8..170d76f 100644
--- a/l10ntools/source/export.cxx
+++ b/l10ntools/source/export.cxx
@@ -108,16 +108,16 @@ int Parse( int nTyp, const char *pTokenText ){
global::exporter-Execute( nTyp , pTokenText );
return 1;
}
+
void Close(){
-global::exporter-pParseQueue-Close();
+global::exporter-GetParseQueue()-Close();
global::exporter.reset();
// avoid nontrivial Export dtor being executed during exit
}
int WorkOnTokenSet( int nTyp, char *pTokenText )
{
-
-global::exporter-pParseQueue-Push( QueueEntry( nTyp ,
OString(pTokenText) ) );
+global::exporter-GetParseQueue()-Push( QueueEntry( nTyp ,
OString(pTokenText) ) );
return 1;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: l10ntools/inc
l10ntools/inc/helper.hxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 06622ec4baa6a7f4a4aa194e5ad9a6d01be54ca8 Author: Douglas Mencken dougmenc...@gmail.com Date: Sun Sep 7 03:50:29 2014 -0400 l10ntools/inc/helper.hxx: bin unused header cassert Change-Id: Ib2c43d9b158423c023a5bfd4da324554aa04902e Reviewed-on: https://gerrit.libreoffice.org/11316 Reviewed-by: Norbert Thiebaud nthieb...@gmail.com Tested-by: Norbert Thiebaud nthieb...@gmail.com diff --git a/l10ntools/inc/helper.hxx b/l10ntools/inc/helper.hxx index 72391f7..a588693 100644 --- a/l10ntools/inc/helper.hxx +++ b/l10ntools/inc/helper.hxx @@ -15,8 +15,6 @@ #include sal/config.h #include sal/types.h -#include cassert - #include libxml/parser.h #include rtl/string.hxx ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/cstylecast.cxx | 88 - compilerplugins/clang/store/cstylecast.cxx | 88 + 2 files changed, 88 insertions(+), 88 deletions(-) New commits: commit 889e27c16525f4c9da8bf43c976a2d0942473afe Author: Stephan Bergmann sberg...@redhat.com Date: Mon Sep 8 09:04:19 2014 +0200 codebase is not yet cleaned up for loplugin:cstylecast Change-Id: Ic2faece46bebea046eee984a0d53d9cd2892e0c9 diff --git a/compilerplugins/clang/cstylecast.cxx b/compilerplugins/clang/store/cstylecast.cxx similarity index 100% rename from compilerplugins/clang/cstylecast.cxx rename to compilerplugins/clang/store/cstylecast.cxx ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: xmerge/source
xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/BookSettings.java
|3 --
xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/SxcDocumentSerializer.java
| 14 +-
xmerge/source/xmerge/java/org/openoffice/xmerge/merger/diff/IteratorRowCompare.java
|6 +---
xmerge/source/xmerge/java/org/openoffice/xmerge/merger/merge/PositionBaseRowMerge.java
|6 +---
4 files changed, 7 insertions(+), 22 deletions(-)
New commits:
commit fa52447b24a833849d0be79487822c036b44554d
Author: rbuj robert@gmail.com
Date: Sun Sep 7 23:24:12 2014 +0200
xmerge: Integer Boolean Parsing
Change-Id: I9553121a7faf10799c9d9a53336470cb2634c4ee
Reviewed-on: https://gerrit.libreoffice.org/11329
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git
a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/BookSettings.java
b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/BookSettings.java
index 2b1a48f..e96951a 100644
---
a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/BookSettings.java
+++
b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/BookSettings.java
@@ -148,8 +148,7 @@ public class BookSettings implements OfficeConstants {
if(name.equals(ActiveTable)) {
activeSheet = value;
} else if(name.equals(HasColumnRowHeaders)) {
-Boolean b = Boolean.valueOf(value);
-hasColumnRowHeaders = b.booleanValue();
+hasColumnRowHeaders = Boolean.parseBoolean(value);
}
}
diff --git
a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/SxcDocumentSerializer.java
b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/SxcDocumentSerializer.java
index bf6d2dc7..aa4e5c1 100644
---
a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/SxcDocumentSerializer.java
+++
b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/SxcDocumentSerializer.java
@@ -386,16 +386,10 @@ public abstract class SxcDocumentSerializer implements
OfficeConstants,
// There is a number of rows repeated attribute:
if (rowsRepeatedNode != null) {
-
// Get the number of times the row is repeated
String rowsRepeatedString = rowsRepeatedNode.getNodeValue();
-
-Integer rowsRepeatedInt = Integer.valueOf(rowsRepeatedString);
-
-rowsRepeated = rowsRepeatedInt.intValue();
-
+rowsRepeated = Integer.parseInt(rowsRepeatedString);
} else {
-
// The row is not repeated
rowsRepeated = 1;
}
@@ -575,14 +569,10 @@ public abstract class SxcDocumentSerializer implements
OfficeConstants,
// There is a number of cols repeated attribute
if (colsRepeatedNode != null) {
-
// Get the number of times the cell is repeated
String colsRepeatedString = colsRepeatedNode.getNodeValue();
-
-Integer colsRepeatedInt = Integer.valueOf(colsRepeatedString);
-colsRepeated = colsRepeatedInt.intValue();
+colsRepeated = Integer.parseInt(colsRepeatedString);
} else {
-
// The cell is not repeated
colsRepeated = 1;
}
diff --git
a/xmerge/source/xmerge/java/org/openoffice/xmerge/merger/diff/IteratorRowCompare.java
b/xmerge/source/xmerge/java/org/openoffice/xmerge/merger/diff/IteratorRowCompare.java
index f2689d1..8be248c 100644
---
a/xmerge/source/xmerge/java/org/openoffice/xmerge/merger/diff/IteratorRowCompare.java
+++
b/xmerge/source/xmerge/java/org/openoffice/xmerge/merger/diff/IteratorRowCompare.java
@@ -118,12 +118,10 @@ public class IteratorRowCompare implements DiffAlgorithm {
int modRowNum = 1;
if (orgRowRepeated.length() 0) {
-orgRowNum =
-Integer.valueOf(orgRowRepeated).intValue();
+orgRowNum = Integer.parseInt(orgRowRepeated);
}
if (modRowRepeated.length() 0) {
-modRowNum =
-Integer.valueOf(modRowRepeated).intValue();
+modRowNum = Integer.parseInt(modRowRepeated);
}
// try to find out the common number of repeated Rows
diff --git
a/xmerge/source/xmerge/java/org/openoffice/xmerge/merger/merge/PositionBaseRowMerge.java
b/xmerge/source/xmerge/java/org/openoffice/xmerge/merger/merge/PositionBaseRowMerge.java
index b3bff5b..6aa6d25 100644
---
a/xmerge/source/xmerge/java/org/openoffice/xmerge/merger/merge/PositionBaseRowMerge.java
+++
b/xmerge/source/xmerge/java/org/openoffice/xmerge/merger/merge/PositionBaseRowMerge.java
@@ -95,12 +95,10 @@ public final class
[Libreoffice-commits] core.git: qadevOOo/runner
qadevOOo/runner/convwatch/DBHelper.java |1 -
qadevOOo/runner/convwatch/PerformanceContainer.java |2 --
2 files changed, 3 deletions(-)
New commits:
commit b75c3bd0faf00112b26ee3e3e1ac572011d0c6e3
Author: rbuj robert@gmail.com
Date: Sun Sep 7 18:23:48 2014 +0200
qadevOOo: All classes in the java.lang package are imported by default
Change-Id: I10f87af6e8128354bfca3587dbd390e5d41f5ce7
Reviewed-on: https://gerrit.libreoffice.org/11325
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/qadevOOo/runner/convwatch/DBHelper.java
b/qadevOOo/runner/convwatch/DBHelper.java
index 1a13fd0..26be888 100644
--- a/qadevOOo/runner/convwatch/DBHelper.java
+++ b/qadevOOo/runner/convwatch/DBHelper.java
@@ -23,7 +23,6 @@ import java.sql.DriverManager;
import java.sql.Statement;
import java.sql.SQLException;
-import java.lang.Thread;
import java.util.StringTokenizer;
class ShareConnection
diff --git a/qadevOOo/runner/convwatch/PerformanceContainer.java
b/qadevOOo/runner/convwatch/PerformanceContainer.java
index 3199673..9db65e0 100644
--- a/qadevOOo/runner/convwatch/PerformanceContainer.java
+++ b/qadevOOo/runner/convwatch/PerformanceContainer.java
@@ -21,8 +21,6 @@ package convwatch;
import java.io.File;
import java.io.FileWriter;
import java.io.RandomAccessFile;
-import java.lang.Double;
-
public class PerformanceContainer /* extends *//* implements */ {
/*
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 51357] SVG: Add support for more shape transition effects to svg documents exported by Impress
https://bugs.freedesktop.org/show_bug.cgi?id=51357 d.sikele...@gmail.com changed: What|Removed |Added Assignee|d.sikele...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 51357] SVG: Add support for more shape transition effects to svg documents exported by Impress
https://bugs.freedesktop.org/show_bug.cgi?id=51357 --- Comment #6 from d.sikele...@gmail.com --- I'm sorry, but I can't do the IrisWipe-Transition anymore, because I get some kernel rejected CS messages when using the IrisWipe. So it's still left to be implemented. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 35862] Increase font and decrease font could work even if the selection contains differing font sizes
https://bugs.freedesktop.org/show_bug.cgi?id=35862 d.sikele...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |d.sikele...@gmail.com |desktop.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: oox/source
oox/source/core/xmlfilterbase.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 3bb2c23f5b03120f71ac8ed8f9a00b4d30666c82
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Sep 8 09:49:23 2014 +0200
loplugin:implicitboolconversion
Change-Id: I6caec8c11fab5fc8f1318be676e4bdf5f9cdbac5
diff --git a/oox/source/core/xmlfilterbase.cxx
b/oox/source/core/xmlfilterbase.cxx
index 0f0ac4c..4ab32f8 100644
--- a/oox/source/core/xmlfilterbase.cxx
+++ b/oox/source/core/xmlfilterbase.cxx
@@ -742,7 +742,7 @@ writeCustomProperties( XmlFilterBase rSelf, Reference
XDocumentProperties xP
{
bool val ;
val = *( sal_Bool * )( aprop[n].Value ).getValue();
-writeElement( pAppProps, FSNS( XML_vt, XML_bool ), val);
+writeElement( pAppProps, FSNS( XML_vt, XML_bool ), val ? 1
: 0);
}
break;
default:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/data/fdo83057.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport5.cxx| 16
sw/source/filter/ww8/attributeoutputbase.hxx |2 ++
sw/source/filter/ww8/docxattributeoutput.cxx |8 +++-
sw/source/filter/ww8/docxattributeoutput.hxx |3 +++
sw/source/filter/ww8/wrtw8nds.cxx|1 +
6 files changed, 29 insertions(+), 1 deletion(-)
New commits:
commit e6b295e55d82f236206c24f5cf1dcc314c34b20f
Author: Vinaya Mandke vinaya.man...@synerzip.com
Date: Thu Aug 28 11:29:06 2014 +0530
fdo#83057 File corrupts on save, as SDT is added incorrectly
A fly frame was attached to a para which started within a hint (run)
containing an SDT.
This SDT was handled while exporting the FLYFRAME and also the text of the
run.
So, eventhough the original file had only one sdt in the header, the RT
file had two;
one for a seperate run as expected, and one incorrectly exported in the
alternateContent (FLYFRAME)
So don't collect SDTPr from grabbag if the FLY is not processed.
As, the SDT will be handled when the run is exported.
Change-Id: I7b3c94208c171afbec54467fd6b756a6e30c816b
Reviewed-on: https://gerrit.libreoffice.org/11161
Reviewed-by: Miklos Vajna vmik...@collabora.co.uk
Tested-by: Miklos Vajna vmik...@collabora.co.uk
diff --git a/sw/qa/extras/ooxmlexport/data/fdo83057.docx
b/sw/qa/extras/ooxmlexport/data/fdo83057.docx
new file mode 100644
index 000..d4d4232
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/fdo83057.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
index 27de7ee..21b8976 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
@@ -684,6 +684,22 @@ DECLARE_OOXMLEXPORT_TEST(testSdt2Run, sdt-2-run.docx)
assertXPathContent(pXmlDoc, /w:document/w:body/w:p[1]/w:r/w:t, third);
}
+DECLARE_OOXMLEXPORT_TEST(testFD083057, fdo83057.docx)
+{
+xmlDocPtr pXmlDoc = parseExport(word/header1.xml);
+if (!pXmlDoc)
+return;
+
+// A fly frame was attached to a para which started with a hint (run)
containing an SDT.
+// This SDT was handled while exporting the FLYFRAME and also the text of
the run.
+// So, eventhough the original file had only one sdt in the header, the RT
file had two;
+// one for a seperate run as expected, and one incorrectly exported in the
alternateContent (FLYFRAME)
+
+// Assert that the file has only one sdt, in a seperate run
+assertXPath(pXmlDoc, //w:sdt, 1);
+assertXPath(pXmlDoc, //mc:AlternateContent//w:sdt, 0);
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/attributeoutputbase.hxx
b/sw/source/filter/ww8/attributeoutputbase.hxx
index a32a4ba..93b6aaa 100644
--- a/sw/source/filter/ww8/attributeoutputbase.hxx
+++ b/sw/source/filter/ww8/attributeoutputbase.hxx
@@ -309,6 +309,8 @@ public:
/// Has different headers/footers for the title page.
virtual void SectionTitlePage() = 0;
+/// Set the state of the Fly at current position
+virtual void SetStateOfFlyFrame( sal_Int16 /*nStateOfFlyFrame*/ ){};
/// If the node has an anchor linked.
virtual void SetAnchorIsLinkedToNode( bool /*bAnchorLinkedToNode*/){};
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index b4587e8..518ce24 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -969,6 +969,11 @@ void DocxAttributeOutput::EndParagraphProperties( const
SfxItemSet* pParagraphMa
m_pSerializer-mergeTopMarks( sax_fastparser::MERGE_MARKS_PREPEND );
}
+void DocxAttributeOutput::SetStateOfFlyFrame( sal_Int16 nStateOfFlyFrame )
+{
+m_nStateOfFlyFrame = nStateOfFlyFrame;
+}
+
void DocxAttributeOutput::SetAnchorIsLinkedToNode( bool bAnchorLinkedToNode )
{
m_bAnchorLinkedToNode = bAnchorLinkedToNode ;
@@ -8145,7 +8150,7 @@ void DocxAttributeOutput::CharGrabBag( const
SfxGrabBagItem rItem )
if (m_bStartedCharSdt)
m_bEndCharSdt = true;
}
-else if (i-first == SdtPr)
+else if (i-first == SdtPr FLY_NOT_PROCESSED !=
m_nStateOfFlyFrame )
{
uno::Sequencebeans::PropertyValue aGrabBagSdt =
i-second.get uno::Sequencebeans::PropertyValue ();
@@ -8286,6 +8291,7 @@ DocxAttributeOutput::DocxAttributeOutput( DocxExport
rExport, FSHelperPtr pSeri
, m_pParagraphSdtPrTokenAttributes(NULL)
, m_pParagraphSdtPrDataBindingAttrs(NULL)
, m_nRunSdtPrToken(0)
+, m_nStateOfFlyFrame( FLY_NOT_PROCESSED )
, m_pRunSdtPrTokenChildren(NULL)
, m_pRunSdtPrDataBindingAttrs(NULL)
, m_bParagraphSdtHasId(false)
diff --git a/sw/source/filter/ww8/docxattributeoutput.hxx
b/sw/source/filter/ww8/docxattributeoutput.hxx
index
[Libreoffice-commits] core.git: qadevOOo/runner
qadevOOo/runner/convwatch/BorderRemover.java|1 -
qadevOOo/runner/convwatch/BuildID.java |1 -
qadevOOo/runner/convwatch/ConvWatch.java|6 --
qadevOOo/runner/convwatch/ConvWatchCancelException.java |2 --
qadevOOo/runner/convwatch/ConvWatchStarter.java |6 --
qadevOOo/runner/convwatch/DocumentConverter.java|4
qadevOOo/runner/convwatch/EnhancedComplexTestCase.java |1 -
qadevOOo/runner/convwatch/FilenameHelper.java |1 -
qadevOOo/runner/convwatch/GfxCompare.java |4
qadevOOo/runner/convwatch/GraphicalDifferenceCheck.java |4
qadevOOo/runner/convwatch/MSOfficePrint.java|2 --
qadevOOo/runner/convwatch/PRNCompare.java |2 --
qadevOOo/runner/convwatch/PixelCounter.java |3 ---
qadevOOo/runner/convwatch/ReferenceBuilder.java |5 -
14 files changed, 42 deletions(-)
New commits:
commit c9dbe53a4a3ccd4ad85354322e63c9e92c1c0dda
Author: rbuj robert@gmail.com
Date: Sun Sep 7 18:13:28 2014 +0200
qadevOOo: remove import from the same package
Change-Id: Id12bece6f1bba0591c3b311553df3fecec40e524
Reviewed-on: https://gerrit.libreoffice.org/11324
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/qadevOOo/runner/convwatch/BorderRemover.java
b/qadevOOo/runner/convwatch/BorderRemover.java
index 650412b..09cc785 100644
--- a/qadevOOo/runner/convwatch/BorderRemover.java
+++ b/qadevOOo/runner/convwatch/BorderRemover.java
@@ -18,7 +18,6 @@
package convwatch;
-import convwatch.ImageHelper;
import java.io.File;
import java.awt.image.RenderedImage;
import java.awt.image.BufferedImage;
diff --git a/qadevOOo/runner/convwatch/BuildID.java
b/qadevOOo/runner/convwatch/BuildID.java
index 97bdf66..7f903af 100644
--- a/qadevOOo/runner/convwatch/BuildID.java
+++ b/qadevOOo/runner/convwatch/BuildID.java
@@ -20,7 +20,6 @@ package convwatch;
import java.io.File;
import helper.OSHelper;
-import convwatch.IniFile;
public class BuildID
{
diff --git a/qadevOOo/runner/convwatch/ConvWatch.java
b/qadevOOo/runner/convwatch/ConvWatch.java
index 588814e..4d23bae 100644
--- a/qadevOOo/runner/convwatch/ConvWatch.java
+++ b/qadevOOo/runner/convwatch/ConvWatch.java
@@ -18,12 +18,6 @@
package convwatch;
-import convwatch.ConvWatchException;
-import convwatch.ConvWatchCancelException;
-import convwatch.FileHelper;
-import convwatch.OfficePrint;
-import convwatch.PRNCompare;
-import convwatch.StatusHelper;
import helper.URLHelper;
import java.io.File;
diff --git a/qadevOOo/runner/convwatch/ConvWatchCancelException.java
b/qadevOOo/runner/convwatch/ConvWatchCancelException.java
index 093a589..ad37c2d 100644
--- a/qadevOOo/runner/convwatch/ConvWatchCancelException.java
+++ b/qadevOOo/runner/convwatch/ConvWatchCancelException.java
@@ -18,8 +18,6 @@
package convwatch;
-import convwatch.ConvWatchException;
-
public class ConvWatchCancelException extends ConvWatchException
{
public ConvWatchCancelException(String _aMessage)
diff --git a/qadevOOo/runner/convwatch/ConvWatchStarter.java
b/qadevOOo/runner/convwatch/ConvWatchStarter.java
index a695315..9c06162 100644
--- a/qadevOOo/runner/convwatch/ConvWatchStarter.java
+++ b/qadevOOo/runner/convwatch/ConvWatchStarter.java
@@ -23,17 +23,11 @@ import java.util.ArrayList;
import java.io.File;
import java.io.FileFilter;
-import convwatch.EnhancedComplexTestCase;
import com.sun.star.lang.XMultiServiceFactory;
-import convwatch.ConvWatchException;
-import convwatch.DirectoryHelper;
-import convwatch.GraphicalTestArguments;
-import convwatch.HTMLOutputter;
import helper.OfficeProvider;
import helper.OfficeWatcher;
import helper.OSHelper;
-import convwatch.PerformanceContainer;
/**
* The following Complex Test will test
diff --git a/qadevOOo/runner/convwatch/DocumentConverter.java
b/qadevOOo/runner/convwatch/DocumentConverter.java
index 5a6f024..6325215 100644
--- a/qadevOOo/runner/convwatch/DocumentConverter.java
+++ b/qadevOOo/runner/convwatch/DocumentConverter.java
@@ -25,10 +25,6 @@ import java.util.ArrayList;
import com.sun.star.lang.XMultiServiceFactory;
-import convwatch.DirectoryHelper;
-import convwatch.OfficePrint;
-import convwatch.EnhancedComplexTestCase;
-import convwatch.PropertyName;
import helper.OfficeProvider;
/**
diff --git a/qadevOOo/runner/convwatch/EnhancedComplexTestCase.java
b/qadevOOo/runner/convwatch/EnhancedComplexTestCase.java
index 9792d6f..16a743e 100644
--- a/qadevOOo/runner/convwatch/EnhancedComplexTestCase.java
+++ b/qadevOOo/runner/convwatch/EnhancedComplexTestCase.java
@@ -20,7 +20,6 @@ package convwatch;
import complexlib.ComplexTestCase;
import helper.ProcessHandler;
-import convwatch.GraphicalTestArguments;
/**
* Some Helperfunctions which are nice in ReferenceBuilder and ConvWatchTest
diff --git
[Libreoffice-commits] core.git: qadevOOo/runner
qadevOOo/runner/complexlib/ComplexTestCase.java |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
New commits:
commit 34a68f0aa92de05123c1e951899c08eed5a55543
Author: rbuj robert@gmail.com
Date: Sun Sep 7 17:43:22 2014 +0200
qadevOOo: reuse the value of entryName.indexOf(Left Parenthesis)
Change-Id: I1950275af2a063db74fef326ac0dd4e555e5170d
Reviewed-on: https://gerrit.libreoffice.org/11323
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/qadevOOo/runner/complexlib/ComplexTestCase.java
b/qadevOOo/runner/complexlib/ComplexTestCase.java
index 7eacef2..8d39b7c 100644
--- a/qadevOOo/runner/complexlib/ComplexTestCase.java
+++ b/qadevOOo/runner/complexlib/ComplexTestCase.java
@@ -119,12 +119,13 @@ public abstract class ComplexTestCase extends Assurance
implements ComplexTest
String entryName = subEntry.entryName;
Object[] parameter = null;
-if (entryName.indexOf(() != -1)
+int posLeftParenthesis = entryName.indexOf(();
+if (posLeftParenthesis != -1)
{
-String sParameter =
(entryName.substring(entryName.indexOf(() + 1, entryName.indexOf(;
+String sParameter =
(entryName.substring(posLeftParenthesis + 1, entryName.indexOf(;
mTestMethodName = entryName;
parameter = new String[] { sParameter };
-entryName = entryName.substring(0, entryName.indexOf(());
+entryName = entryName.substring(0, posLeftParenthesis);
testMethod = this.getClass().getMethod(entryName, new
Class[] { String.class });
}
else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Outlines
On Thu, Sep 04, 2014 at 08:35:54PM -0400, Keith Fretz larkg...@gmail.com wrote: Could we use the tuxcards code to add outline capacity to libreoffice? See e.g. https://help.libreoffice.org/Common/Outline, we already have some support of outlines. Please be more specific on exactly what do you miss in which application. signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: dbaccess/source sc/inc sc/source svx/source uui/source xmlsecurity/inc xmlsecurity/source xmlsecurity/workben
dbaccess/source/core/recovery/dbdocrecovery.cxx| 58 +-
dbaccess/source/core/recovery/subcomponentrecovery.cxx | 71 ++---
dbaccess/source/core/recovery/subcomponentrecovery.hxx | 38 +++---
dbaccess/source/core/recovery/subcomponents.hxx| 10 -
sc/inc/ScPanelFactory.hxx | 13 +-
sc/inc/validat.hxx |1
sc/source/core/data/documen3.cxx |2
sc/source/core/data/validat.cxx|6 -
sc/source/filter/excel/xecontent.cxx |2
sc/source/filter/excel/xicontent.cxx |2
sc/source/ui/dbgui/validate.cxx|2
sc/source/ui/view/cellsh2.cxx |2
sc/source/ui/view/gridwin.cxx |2
svx/source/sidebar/insert/InsertPropertyPanel.hxx |5
uui/source/secmacrowarnings.hxx| 14 +-
xmlsecurity/inc/xmlsecurity/digitalsignaturesdialog.hxx| 11 --
xmlsecurity/source/component/documentdigitalsignatures.cxx |4
xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx |6 -
xmlsecurity/workben/signaturetest.cxx |2
19 files changed, 123 insertions(+), 128 deletions(-)
New commits:
commit 481cd6368bd1af2b4a51be57bcedfb8fc631bf0e
Author: Stefan Weiberg stefan.weib...@germandev.org
Date: Fri Sep 5 15:34:48 2014 +
Related #82088: removed last css aliases in hxx
* Only unfixed header namespace alias in
ConnectionLog.hxx:
LogLevel = ::com::sun::star::logging::LogLevel
Change-Id: I48c941a4762830f2265c8241f4c1695a43ec891a
Reviewed-on: https://gerrit.libreoffice.org/11333
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/dbaccess/source/core/recovery/dbdocrecovery.cxx
b/dbaccess/source/core/recovery/dbdocrecovery.cxx
index 2708589..94cdb49 100644
--- a/dbaccess/source/core/recovery/dbdocrecovery.cxx
+++ b/dbaccess/source/core/recovery/dbdocrecovery.cxx
@@ -43,35 +43,35 @@
namespace dbaccess
{
-using ::com::sun::star::uno::Reference;
-using ::com::sun::star::uno::XInterface;
-using ::com::sun::star::uno::UNO_QUERY;
-using ::com::sun::star::uno::UNO_QUERY_THROW;
-using ::com::sun::star::uno::UNO_SET_THROW;
-using ::com::sun::star::uno::Exception;
-using ::com::sun::star::uno::RuntimeException;
-using ::com::sun::star::uno::Any;
-using ::com::sun::star::uno::makeAny;
-using ::com::sun::star::uno::Sequence;
-using ::com::sun::star::uno::Type;
-using ::com::sun::star::uno::XComponentContext;
-using ::com::sun::star::embed::XStorage;
-using ::com::sun::star::frame::XController;
-using ::com::sun::star::sdb::application::XDatabaseDocumentUI;
-using ::com::sun::star::lang::XComponent;
-using ::com::sun::star::document::XStorageBasedDocument;
-using ::com::sun::star::beans::PropertyValue;
-using ::com::sun::star::io::XStream;
-using ::com::sun::star::io::XTextOutputStream;
-using ::com::sun::star::io::XActiveDataSource;
-using ::com::sun::star::io::TextInputStream;
-using ::com::sun::star::io::XTextInputStream2;
-using ::com::sun::star::io::XActiveDataSink;
-using ::com::sun::star::frame::XModel;
-using ::com::sun::star::util::XModifiable;
-using ::com::sun::star::beans::XPropertySet;
-
-namespace ElementModes = ::com::sun::star::embed::ElementModes;
+using css::uno::Reference;
+using css::uno::XInterface;
+using css::uno::UNO_QUERY;
+using css::uno::UNO_QUERY_THROW;
+using css::uno::UNO_SET_THROW;
+using css::uno::Exception;
+using css::uno::RuntimeException;
+using css::uno::Any;
+using css::uno::makeAny;
+using css::uno::Sequence;
+using css::uno::Type;
+using css::uno::XComponentContext;
+using css::embed::XStorage;
+using css::frame::XController;
+using css::sdb::application::XDatabaseDocumentUI;
+using css::lang::XComponent;
+using css::document::XStorageBasedDocument;
+using css::beans::PropertyValue;
+using css::io::XStream;
+using css::io::XTextOutputStream;
+using css::io::XActiveDataSource;
+using css::io::TextInputStream;
+using css::io::XTextInputStream2;
+using css::io::XActiveDataSink;
+using css::frame::XModel;
+using css::util::XModifiable;
+using css::beans::XPropertySet;
+
+namespace ElementModes = css::embed::ElementModes;
// helpers
namespace
diff --git a/dbaccess/source/core/recovery/subcomponentrecovery.cxx
b/dbaccess/source/core/recovery/subcomponentrecovery.cxx
index c5b977e..f50d175 100644
--- a/dbaccess/source/core/recovery/subcomponentrecovery.cxx
+++ b/dbaccess/source/core/recovery/subcomponentrecovery.cxx
@@ -42,40 +42,41 @@
namespace dbaccess
{
-
Re: Crash test update
On Thu, Sep 04, 2014 at 09:44:21AM +0100, Caolán McNamara caol...@redhat.com wrote: Meh, top three of the pdf import failures, fdo50841-2.pdf, gnome554483-1.pdf and moz724015-1.pdf import locally for me without error, albeit a bit sluggish. But if they had timed-out I imagine they should have appeared in http://dev-builds.libreoffice.org/crashtest/ef2668bad976f1fbb70759887cafd35ea7833655/pdf/timeoutFiles.log not http://dev-builds.libreoffice.org/crashtest/ef2668bad976f1fbb70759887cafd35ea7833655/pdf/crashlog.txt which is a bit confusing. Maybe the crash is caused by the crashtesting VM having only 4G ram, so using unusual amount of memory is just slow on your machine, but it's a crash there? Just guessing. signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: UNO Writer: Merging cells results in wrong column count from XTextTable
On Fri, Aug 29, 2014 at 11:54:24AM +0200, Jan-Marek Glogowski glo...@fbihome.de wrote: | | | -- | | | Hmm - from my POV you would have 3 columns in this example. Probably we should mark SwXTableColumns::getCount() as deprecated and drop it in the next major update? Then I would suggest deprecating getByIndex() as well, those two methods are due to implementing XIndexAccess. Dropping -- at least would have to check first if any of our internal code depends on it. ;-) signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/attributeoutputbase.hxx |3 ++-
sw/source/filter/ww8/docxattributeoutput.cxx |2 +-
sw/source/filter/ww8/docxattributeoutput.hxx |4 ++--
sw/source/filter/ww8/wrtw8nds.cxx|4 ++--
sw/source/filter/ww8/wrtww8.hxx |2 +-
5 files changed, 8 insertions(+), 7 deletions(-)
New commits:
commit 46be75d73b534f88486806c7152cb2436894595a
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Sep 8 10:00:28 2014 +0200
sal_Int16 - FlyProcessingState
Change-Id: Ibbc48711e656a804a5ac6a5651091131bbf81c4f
diff --git a/sw/source/filter/ww8/attributeoutputbase.hxx
b/sw/source/filter/ww8/attributeoutputbase.hxx
index 93b6aaa..a823b5f 100644
--- a/sw/source/filter/ww8/attributeoutputbase.hxx
+++ b/sw/source/filter/ww8/attributeoutputbase.hxx
@@ -22,6 +22,7 @@
#include fields.hxx
#include WW8TableInfo.hxx
+#include wrtww8.hxx
#include rtl/textenc.h
#include editeng/svxenum.hxx
@@ -310,7 +311,7 @@ public:
virtual void SectionTitlePage() = 0;
/// Set the state of the Fly at current position
-virtual void SetStateOfFlyFrame( sal_Int16 /*nStateOfFlyFrame*/ ){};
+virtual void SetStateOfFlyFrame( FlyProcessingState /*nStateOfFlyFrame*/
){};
/// If the node has an anchor linked.
virtual void SetAnchorIsLinkedToNode( bool /*bAnchorLinkedToNode*/){};
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 518ce24..dd24202 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -969,7 +969,7 @@ void DocxAttributeOutput::EndParagraphProperties( const
SfxItemSet* pParagraphMa
m_pSerializer-mergeTopMarks( sax_fastparser::MERGE_MARKS_PREPEND );
}
-void DocxAttributeOutput::SetStateOfFlyFrame( sal_Int16 nStateOfFlyFrame )
+void DocxAttributeOutput::SetStateOfFlyFrame( FlyProcessingState
nStateOfFlyFrame )
{
m_nStateOfFlyFrame = nStateOfFlyFrame;
}
diff --git a/sw/source/filter/ww8/docxattributeoutput.hxx
b/sw/source/filter/ww8/docxattributeoutput.hxx
index 51f775c..f860f2d 100644
--- a/sw/source/filter/ww8/docxattributeoutput.hxx
+++ b/sw/source/filter/ww8/docxattributeoutput.hxx
@@ -215,7 +215,7 @@ public:
/// End of the tag that encloses the run.
void EndRedline( const SwRedlineData * pRedlineData );
-virtual void SetStateOfFlyFrame( sal_Int16 nStateOfFlyFrame ) SAL_OVERRIDE;
+virtual void SetStateOfFlyFrame( FlyProcessingState nStateOfFlyFrame )
SAL_OVERRIDE;
virtual void SetAnchorIsLinkedToNode( bool bAnchorLinkedToNode = false )
SAL_OVERRIDE;
virtual bool IsFlyProcessingPostponed() SAL_OVERRIDE;
virtual void ResetFlyProcessingFlag() SAL_OVERRIDE;
@@ -909,7 +909,7 @@ private:
/// members to control the existence of grabbagged SDT properties in the
text run
sal_Int32 m_nRunSdtPrToken;
/// State of the Fly at current position
-sal_Int16 m_nStateOfFlyFrame;
+FlyProcessingState m_nStateOfFlyFrame;
::sax_fastparser::FastAttributeList *m_pRunSdtPrTokenChildren;
::sax_fastparser::FastAttributeList *m_pRunSdtPrDataBindingAttrs;
/// Value of the w:alias paragraph SDT element.
diff --git a/sw/source/filter/ww8/wrtw8nds.cxx
b/sw/source/filter/ww8/wrtw8nds.cxx
index d03b1b4..b7da8b6 100644
--- a/sw/source/filter/ww8/wrtw8nds.cxx
+++ b/sw/source/filter/ww8/wrtw8nds.cxx
@@ -560,7 +560,7 @@ bool SwWW8AttrIter::IsAnchorLinkedToThisNode( sal_uLong
nNodePos )
return false ;
}
-sal_Int16 SwWW8AttrIter::OutFlys(sal_Int32 nSwPos)
+FlyProcessingState SwWW8AttrIter::OutFlys(sal_Int32 nSwPos)
{
/*
#i2916#
@@ -2051,7 +2051,7 @@ void MSWordExportBase::OutputTextNode( const SwTxtNode
rNode )
do {
const SwRedlineData* pRedlineData = aAttrIter.GetRunLevelRedline(
nAktPos );
-sal_Int16 nStateOfFlyFrame = 0;
+FlyProcessingState nStateOfFlyFrame = FLY_PROCESSED;
bool bPostponeWritingText= false ;
OUString aSavedSnippet ;
diff --git a/sw/source/filter/ww8/wrtww8.hxx b/sw/source/filter/ww8/wrtww8.hxx
index d2ca234..a1621ac 100644
--- a/sw/source/filter/ww8/wrtww8.hxx
+++ b/sw/source/filter/ww8/wrtww8.hxx
@@ -1548,7 +1548,7 @@ public:
int OutAttrWithRange(sal_Int32 nPos);
const SwRedlineData* GetParagraphLevelRedline( );
const SwRedlineData* GetRunLevelRedline( sal_Int32 nPos );
-sal_Int16 OutFlys(sal_Int32 nSwPos);
+FlyProcessingState OutFlys(sal_Int32 nSwPos);
sal_Int32 WhereNext() const { return nAktSwPos; }
sal_uInt16 GetScript() const { return mnScript; }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 7 commits - sc/source sd/source sfx2/source svx/source sw/source vcl/source
sc/source/core/data/table3.cxx |3 ++-
sd/source/ui/app/sdmod1.cxx | 12 +---
sfx2/source/appl/sfxpicklist.cxx |2 +-
svx/source/form/filtnav.cxx | 19 +++
sw/source/core/docnode/node.cxx |2 +-
vcl/source/uipreviewer/previewer.cxx | 10 +-
vcl/source/window/layout.cxx |2 ++
7 files changed, 27 insertions(+), 23 deletions(-)
New commits:
commit 513a3a6a01679046d354f9acc75d98d9e97979db
Author: Caolán McNamara caol...@redhat.com
Date: Mon Sep 8 08:34:23 2014 +0100
coverity#704947 Dereference after null check
Change-Id: Id6eb50de48b8a674d7b48d1256b1529637155eb1
diff --git a/sw/source/core/docnode/node.cxx b/sw/source/core/docnode/node.cxx
index 5f490f1..cc73f02 100644
--- a/sw/source/core/docnode/node.cxx
+++ b/sw/source/core/docnode/node.cxx
@@ -990,7 +990,7 @@ void SwCntntNode::Modify( const SfxPoolItem* pOldValue,
const SfxPoolItem* pNewV
break;
case RES_UPDATE_ATTR:
-if( GetNodes().IsDocNodes() IsTxtNode() )
+if (GetNodes().IsDocNodes() IsTxtNode() pNewValue)
{
const sal_uInt16 nTmp = ((SwUpdateAttr*)pNewValue)-getWhichAttr();
if ( RES_ATTRSET_CHG == nTmp )
commit d396d5b47876f47b51d3ba42861895e86831738b
Author: Caolán McNamara caol...@redhat.com
Date: Mon Sep 8 08:24:40 2014 +0100
coverity#1237357 Uncaught exception
Change-Id: Ie116e0070792c59893ed0b4f41bcf9831400deb9
diff --git a/vcl/source/uipreviewer/previewer.cxx
b/vcl/source/uipreviewer/previewer.cxx
index 5bd2d3d..1e318ff 100644
--- a/vcl/source/uipreviewer/previewer.cxx
+++ b/vcl/source/uipreviewer/previewer.cxx
@@ -64,6 +64,8 @@ int UIPreviewApp::Main()
// turn on tooltips
Help::EnableQuickHelp();
+int nRet = EXIT_SUCCESS;
+
try
{
Dialog *pDialog = new Dialog(DIALOG_NO_PARENT, WB_STDDIALOG |
WB_SIZEABLE);
@@ -93,9 +95,15 @@ int UIPreviewApp::Main()
catch (const uno::Exception e)
{
fprintf(stderr, fatal error: %s\n, OUStringToOString(e.Message,
osl_getThreadTextEncoding()).getStr());
+nRet = EXIT_FAILURE;
+}
+catch (const std::exception e)
+{
+fprintf(stderr, fatal error: %s\n, e.what());
+nRet = EXIT_FAILURE;
}
-return EXIT_SUCCESS;
+return nRet;
}
void vclmain::createApplication()
commit 00212cdb3ee2bb0b4d8fb61a482a7f9f01c0a9b7
Author: Caolán McNamara caol...@redhat.com
Date: Mon Sep 8 08:21:35 2014 +0100
coverity#1237355 Dereference null return value
Change-Id: I66956979c494f96f76eb0a7840f28c8edc91d816
diff --git a/sd/source/ui/app/sdmod1.cxx b/sd/source/ui/app/sdmod1.cxx
index cfe75ff..c588a2c 100644
--- a/sd/source/ui/app/sdmod1.cxx
+++ b/sd/source/ui/app/sdmod1.cxx
@@ -652,19 +652,17 @@ SfxFrame* SdModule::ExecuteNewDocument( SfxRequest rReq )
}
::sd::DrawDocShell* pDocShell(NULL);
+::sd::ViewShellBase* pBase(NULL);
+SdDrawDocument* pDoc(NULL);
if (pShell pViewFrame)
{
pDocShell = PTR_CAST(::sd::DrawDocShell, pShell);
+pDoc = pDocShell ? pDocShell-GetDoc() : NULL;
+pBase =
::sd::ViewShellBase::GetViewShellBase(pViewFrame);
}
-if (pDocShell)
+if (pDoc pBase)
{
- SdDrawDocument* pDoc = pDocShell-GetDoc();
-
-::sd::ViewShellBase* pBase =
- ::sd::ViewShellBase::GetViewShellBase (
- pViewFrame);
-assert(pBase!=NULL);
::boost::shared_ptrsd::ViewShell pViewSh =
pBase-GetMainViewShell();
SdOptions* pOptions =
GetSdOptions(pDoc-GetDocumentType());
commit 2f27dd63d2c1dd36a1df898b72d1d4949ae8230c
Author: Caolán McNamara caol...@redhat.com
Date: Mon Sep 8 08:12:28 2014 +0100
coverity#1237351 Logically dead code
Change-Id: Ia82d8d137c5f36cc48826cc851d6f00626e978aa
diff --git a/sfx2/source/appl/sfxpicklist.cxx b/sfx2/source/appl/sfxpicklist.cxx
index 115c954..a416e2e 100644
--- a/sfx2/source/appl/sfxpicklist.cxx
+++ b/sfx2/source/appl/sfxpicklist.cxx
@@ -376,7 +376,7 @@ void SfxPickList::Notify( SfxBroadcaster, const SfxHint
rHint )
if ( pEventHint )
{
// only ObjectShell-related events with media interest
-SfxObjectShell* pDocSh = pEventHint ? pEventHint-GetObjShell() : NULL;
+SfxObjectShell* pDocSh = pEventHint-GetObjShell();
if( !pDocSh )
return;
commit a30d5cd97336fc8f953fa54f6bfa885b659199a8
Author: Caolán McNamara caol...@redhat.com
Date: Mon Sep 8 08:10:32 2014 +0100
coverity#708008
[Bug 75240] improve coding style in bitmap3.cxx
https://bugs.freedesktop.org/show_bug.cgi?id=75240 Stefan Weiberg stefan.weib...@germandev.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Stefan Weiberg stefan.weib...@germandev.org --- I assume we can set this EasyHack to Resolved and Fixed? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: configure.ac
configure.ac |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 2114e88fc69c6c650ebe1a390de6117d58b10716 Author: Peter Foley pefol...@pefoley.com Date: Sun Sep 7 21:07:43 2014 -0400 Make configure respect --without-system-$lib-for-build Change-Id: I64cb58e7980de8fdb23f5c0efa75c05a1f0aa904 Reviewed-on: https://gerrit.libreoffice.org/11330 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/configure.ac b/configure.ac index 897cb1e..2ec2226 100644 --- a/configure.ac +++ b/configure.ac @@ -4705,11 +4705,11 @@ if test $cross_compiling = yes; then test -n $with_ant_home sub_conf_opts=$sub_conf_opts --with-ant-home=$with_ant_home test $with_junit = no sub_conf_opts=$sub_conf_opts --without-junit test -n $TARFILE_LOCATION sub_conf_opts=$sub_conf_opts --with-external-tar=$TARFILE_LOCATION -test -n $with_system_boost_for_build sub_conf_opts=$sub_conf_opts --with-system-boost -test -n $with_system_cppunit_for_build sub_conf_opts=$sub_conf_opts --with-system-cppunit -test -n $with_system_expat_for_build sub_conf_opts=$sub_conf_opts --with-system-expat +test -n $with_system_boost_for_build sub_conf_opts=$sub_conf_opts --with-system-boost=$with_system_boost_for_build +test -n $with_system_cppunit_for_build sub_conf_opts=$sub_conf_opts --with-system-cppunit=$with_system_cppunit_for_build +test -n $with_system_expat_for_build sub_conf_opts=$sub_conf_opts --with-system-expat=$with_system_expat_for_build test $with_system_icu_for_build = yes -o $with_system_icu_for_build = force sub_conf_opts=$sub_conf_opts --with-system-icu -test -n $with_system_libxml_for_build sub_conf_opts=$sub_conf_opts --with-system-libxml +test -n $with_system_libxml_for_build sub_conf_opts=$sub_conf_opts --with-system-libxml=$with_system_libxml_for_build # we need the msi build tools on mingw if we are creating the # installation set if test $WITH_MINGW = yes; then ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 38844] Reduce XOR rendering
https://bugs.freedesktop.org/show_bug.cgi?id=38844 --- Comment #6 from Stefan Weiberg stefan.weib...@germandev.org --- Is this EasyHack resolved and fixed? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - configure.ac scripting/java
configure.ac
| 26 ---
scripting/java/com/sun/star/script/framework/io/UCBStreamHandler.java
|2
scripting/java/com/sun/star/script/framework/provider/ScriptProvider.java
| 79 +-
scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptProviderForBeanShell.java
|3
4 files changed, 44 insertions(+), 66 deletions(-)
New commits:
commit 1fba1feac46d808ce801e44f1f29234f7fb3a31f
Author: rbuj robert@gmail.com
Date: Sun Sep 7 11:49:23 2014 +0200
scripting: the assigned value is never used
Change-Id: I61dcf285ecc6d0affdb949ca03d686f96601d884
Reviewed-on: https://gerrit.libreoffice.org/11319
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git
a/scripting/java/com/sun/star/script/framework/io/UCBStreamHandler.java
b/scripting/java/com/sun/star/script/framework/io/UCBStreamHandler.java
index 0f48814..075ab66 100644
--- a/scripting/java/com/sun/star/script/framework/io/UCBStreamHandler.java
+++ b/scripting/java/com/sun/star/script/framework/io/UCBStreamHandler.java
@@ -187,7 +187,7 @@ public class UCBStreamHandler extends URLStreamHandler {
private InputStream getFileStreamFromJarStream(String file, InputStream is)
throws IOException
{
-ZipEntry entry = null;
+ZipEntry entry;
ZipInputStream zis = new ZipInputStream(is);
diff --git
a/scripting/java/com/sun/star/script/framework/provider/ScriptProvider.java
b/scripting/java/com/sun/star/script/framework/provider/ScriptProvider.java
index 963178d..b49a526 100644
--- a/scripting/java/com/sun/star/script/framework/provider/ScriptProvider.java
+++ b/scripting/java/com/sun/star/script/framework/provider/ScriptProvider.java
@@ -361,54 +361,55 @@ public abstract class ScriptProvider
public ScriptMetaData getScriptData( /*IN*/String scriptURI ) throws
ScriptFrameworkErrorException
{
-ParsedScriptUri details = null;
try
{
-details = m_container.parseScriptUri( scriptURI );
-ScriptMetaData scriptData = m_container.findScript( details );
-if ( scriptData == null )
+ParsedScriptUri details = m_container.parseScriptUri( scriptURI );
+try
{
-throw new ScriptFrameworkErrorException( details.function +
does not exist,
-null, details.function, language,
ScriptFrameworkErrorType.NO_SUCH_SCRIPT );
+ScriptMetaData scriptData = m_container.findScript(details);
+if (scriptData == null)
+{
+throw new ScriptFrameworkErrorException(details.function +
does not exist,
+null, details.function, language,
ScriptFrameworkErrorType.NO_SUCH_SCRIPT);
+}
+return scriptData;
+}
+catch (com.sun.star.container.NoSuchElementException nse)
+{
+ScriptFrameworkErrorException e2
+= new ScriptFrameworkErrorException(
+nse.getMessage(), null, details.function,
language,
+ScriptFrameworkErrorType.NO_SUCH_SCRIPT);
+e2.initCause(nse);
+throw e2;
+}
+catch (com.sun.star.lang.WrappedTargetException wta)
+{
+// TODO specify the correct error Type
+Exception wrapped = (Exception) wta.TargetException;
+String message = wta.getMessage();
+if (wrapped != null)
+{
+message = wrapped.getMessage();
+}
+ScriptFrameworkErrorException e2
+= new ScriptFrameworkErrorException(
+message, null, details.function, language,
+ScriptFrameworkErrorType.UNKNOWN);
+e2.initCause(wta);
+throw e2;
}
-return scriptData;
-}
-catch ( com.sun.star.lang.IllegalArgumentException ila )
-{
-// TODO specify the correct error Type
-ScriptFrameworkErrorException e2 =
-new ScriptFrameworkErrorException(
-ila.getMessage(), null, scriptURI, language,
-ScriptFrameworkErrorType.UNKNOWN );
-e2.initCause( ila );
-throw e2;
-}
-catch ( com.sun.star.container.NoSuchElementException nse )
-{
-ScriptFrameworkErrorException e2 =
-new ScriptFrameworkErrorException(
-nse.getMessage(), null, details.function, language,
-ScriptFrameworkErrorType.NO_SUCH_SCRIPT );
-e2.initCause(
[Libreoffice-commits] core.git: scripting/java
scripting/java/com/sun/star/script/framework/provider/ScriptProvider.java |
14 +-
1 file changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 3bb05281cb980c01cde07b5412c2e4c440e4ab7d
Author: rbuj robert@gmail.com
Date: Sun Sep 7 12:29:27 2014 +0200
scripting: if...else if...else Statement
Change-Id: Ia60b352b4cb52d2712b2499550859ece699341d1
Reviewed-on: https://gerrit.libreoffice.org/11322
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git
a/scripting/java/com/sun/star/script/framework/provider/ScriptProvider.java
b/scripting/java/com/sun/star/script/framework/provider/ScriptProvider.java
index b49a526..d08011b 100644
--- a/scripting/java/com/sun/star/script/framework/provider/ScriptProvider.java
+++ b/scripting/java/com/sun/star/script/framework/provider/ScriptProvider.java
@@ -214,8 +214,7 @@ public abstract class ScriptProvider
extensionDb =
vnd.sun.star.expand:${$BRAND_BASE_DIR/$BRAND_BIN_SUBDIR/ +
PathUtils.BOOTSTRAP_NAME + ::UserInstallation}/user;
extensionRepository = bundled;
}
-
-if ( originalContextURL.startsWith( share ) )
+else if ( originalContextURL.startsWith( share ) )
{
contextUrl =
vnd.sun.star.expand:$BRAND_BASE_DIR/$BRAND_SHARE_SUBDIR;
extensionDb =
vnd.sun.star.expand:${$BRAND_BASE_DIR/$BRAND_BIN_SUBDIR/ +
PathUtils.BOOTSTRAP_NAME + ::UserInstallation}/user;
@@ -231,12 +230,13 @@ public abstract class ScriptProvider
if ( originalContextURL.endsWith( uno_packages) )
{
isPkgProvider = true;
+if (!originalContextURL.equals(contextUrl)
+ !extensionRepository.equals(bundled))
+{
+contextUrl = PathUtils.make_url(contextUrl,
uno_packages);
+}
}
-if ( originalContextURL.endsWith( uno_packages)
!originalContextURL.equals( contextUrl )
- !extensionRepository.equals(bundled))
-{
-contextUrl = PathUtils.make_url( contextUrl,
uno_packages );
-}
+
if ( isPkgProvider )
{
m_container = new UnoPkgContainer( m_xContext,
contextUrl, extensionDb, extensionRepository, language );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: swext/mediawiki
swext/mediawiki/src/com/sun/star/wiki/Settings.java | 101 +---
1 file changed, 48 insertions(+), 53 deletions(-)
New commits:
commit c88eae0866b943e7c664819fadbf4d2c4f0c55a8
Author: rbuj robert@gmail.com
Date: Mon Sep 8 02:40:54 2014 +0200
mediawiki: improve storeConfiguration loadConfiguration methods
* Use enhanced for-loops (storeConfiguration loadConfiguration)
* Use curly braces to reduce the variable scope and, to reuse variable
names (storeConfiguration)
* Avoid map.get(key) in iterations over each map's entry
(storeConfiguration):
for (Map.EntryString, Object entry : ht.entrySet())
Change-Id: I678d5a9f205efb2c89ab868b59e1b654419381d8
Reviewed-on: https://gerrit.libreoffice.org/11331
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/swext/mediawiki/src/com/sun/star/wiki/Settings.java
b/swext/mediawiki/src/com/sun/star/wiki/Settings.java
index 3d87446..74d6018 100644
--- a/swext/mediawiki/src/com/sun/star/wiki/Settings.java
+++ b/swext/mediawiki/src/com/sun/star/wiki/Settings.java
@@ -20,7 +20,6 @@ package com.sun.star.wiki;
import java.util.ArrayList;
import java.util.HashMap;
-import java.util.Iterator;
import java.util.List;
import java.util.Map;
@@ -214,58 +213,56 @@ public class Settings
{
try
{
-// remove stored connection information
-XNameContainer xContainer = Helper.GetConfigNameContainer(
m_xContext, org.openoffice.Office.Custom.WikiExtension/ConnectionList );
-String[] pNames = xContainer.getElementNames();
-for( int i=0; ipNames.length; i++ )
{
-xContainer.removeByName( pNames[i] );
+// remove stored connection information
+XNameContainer xContainer =
Helper.GetConfigNameContainer(m_xContext,
org.openoffice.Office.Custom.WikiExtension/ConnectionList);
+String[] pNames = xContainer.getElementNames();
+for (String pName : pNames)
+{
+xContainer.removeByName(pName);
+}
+// store all connections
+XSingleServiceFactory xConnectionFactory =
UnoRuntime.queryInterface(XSingleServiceFactory.class, xContainer);
+for (MapString, String ht : m_WikiConnections)
+{
+Object oNewConnection =
xConnectionFactory.createInstance();
+XNameReplace xNewConn =
UnoRuntime.queryInterface(XNameReplace.class, oNewConnection);
+if (xNewConn != null)
+{
+xNewConn.replaceByName(UserName, ht.get(Username));
+}
+xContainer.insertByName(ht.get(Url), xNewConn);
+}
+// commit changes
+XChangesBatch xBatch =
UnoRuntime.queryInterface(XChangesBatch.class, xContainer);
+xBatch.commitChanges();
}
-// store all connections
-XSingleServiceFactory xConnectionFactory =
UnoRuntime.queryInterface( XSingleServiceFactory.class, xContainer );
-for ( int i=0; i m_WikiConnections.size(); i++ )
{
-Object oNewConnection = xConnectionFactory.createInstance();
-MapString,String ht = m_WikiConnections.get( i );
-XNameReplace xNewConn = UnoRuntime.queryInterface(
XNameReplace.class, oNewConnection );
-
-if ( xNewConn != null )
-xNewConn.replaceByName( UserName, ht.get( Username ) );
-
-xContainer.insertByName( ht.get( Url ), xNewConn );
-}
-// commit changes
-XChangesBatch xBatch = UnoRuntime.queryInterface(
XChangesBatch.class, xContainer );
-xBatch.commitChanges();
-
-// remove stored connection information
-XNameContainer xContainer2 = Helper.GetConfigNameContainer(
m_xContext, org.openoffice.Office.Custom.WikiExtension/RecentDocs );
-String[] pNames2 = xContainer2.getElementNames();
-for( int i=0; ipNames2.length; i++ )
-{
-xContainer2.removeByName( pNames2[i] );
-}
-// store all Docs
-XSingleServiceFactory xDocListFactory = UnoRuntime.queryInterface(
XSingleServiceFactory.class, xContainer2 );
-for ( int i=0; i m_aWikiDocs.size(); i++ )
-{
-MapString,Object ht = m_aWikiDocs.get( i );
-
-Object oNewDoc = xDocListFactory.createInstance();
-XNameReplace xNewDoc = UnoRuntime.queryInterface(
XNameReplace.class, oNewDoc );
-
-for ( IteratorString iter = ht.keySet().iterator();
iter.hasNext(); )
+// remove stored connection information
+XNameContainer xContainer =
[Libreoffice-commits] core.git: oox/source
oox/source/core/xmlfilterbase.cxx | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
New commits:
commit 4036cf9ede88a41c16e2b77483e07c9e3d58399f
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Sep 8 11:23:42 2014 +0200
Presumably, all numeric values shall be written as i4
...in 47c5454ea67632278d69a1ddfe97d74f5cc4449f fdo#83428: Custom Properties
dropped while exporting to docx, not just ones of UNO type double. At
least,
that fixes CppunitTest_sc_subsequent_export_test's
testPivotTableTwoDataFieldsXLSX to not write a DocSecurity property
without
content (and thus fail validation).
Change-Id: I2d764e65ec2af61139c6564f644d27aa9a00bd7d
diff --git a/oox/source/core/xmlfilterbase.cxx
b/oox/source/core/xmlfilterbase.cxx
index 4ab32f8..545e444 100644
--- a/oox/source/core/xmlfilterbase.cxx
+++ b/oox/source/core/xmlfilterbase.cxx
@@ -731,13 +731,6 @@ writeCustomProperties( XmlFilterBase rSelf, Reference
XDocumentProperties xP
writeElement( pAppProps, FSNS( XML_vt, XML_lpwstr ),
aValue );
}
break;
-case TypeClass_DOUBLE:
-{
-double val;
-val = * reinterpret_cast const double * ( (
aprop[n].Value ).getValue() );
-writeElement( pAppProps, FSNS( XML_vt, XML_i4 ), val );
-}
-break;
case TypeClass_BOOLEAN:
{
bool val ;
@@ -747,10 +740,15 @@ writeCustomProperties( XmlFilterBase rSelf, Reference
XDocumentProperties xP
break;
default:
{
+double num;
util::Date aDate;
util::Duration aDuration;
util::DateTime aDateTime;
-if ( ( aprop[n].Value ) = aDate )
+if ( ( aprop[n].Value ) = num )
+{
+writeElement( pAppProps, FSNS( XML_vt, XML_i4 ), num );
+}
+else if ( ( aprop[n].Value ) = aDate )
{
aDateTime = util::DateTime( 0, 0 , 0, 0, aDate.Year,
aDate.Month, aDate.Day, true );
writeElement( pAppProps, FSNS( XML_vt, XML_filetime ),
aDateTime);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/helper/qahelper.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 7f96d6d5b6dfcb3970fefaca74f004fad071297e
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Sep 8 11:31:30 2014 +0200
Keep files of failing tests around
(Arguably, such files should be stored in a workdir/CppunitTest/...
directory
removed and freshly created before every test run, instead of in TMPDIR.)
Change-Id: Ibf1f54fd3d3f9c354c12067e671196e182ef7159
diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx
index b5d9a17..9db7c6e 100644
--- a/sc/qa/unit/helper/qahelper.cxx
+++ b/sc/qa/unit/helper/qahelper.cxx
@@ -609,7 +609,6 @@ ScDocShellRef ScBootstrapFixture::saveAndReload(
{
utl::TempFile aTempFile;
-aTempFile.EnableKillingFile();
SfxMedium aStoreMedium( aTempFile.GetURL(), STREAM_STD_WRITE );
sal_uInt32 nExportFormat = 0;
if (nFormatType == ODS_FORMAT_TYPE)
@@ -634,6 +633,7 @@ ScDocShellRef ScBootstrapFixture::saveAndReload(
validate(aTempFile.GetFileName(), test::OOXML);
else if (nFormatType == ODS_FORMAT_TYPE)
validate(aTempFile.GetFileName(), test::ODF);
+aTempFile.EnableKillingFile();
return xDocSh;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - 4 commits - sw/qa sw/source writerfilter/source
sw/qa/extras/inc/swmodeltestbase.hxx | 12 +++
sw/qa/extras/rtfexport/data/abi10039.odt |binary
sw/qa/extras/rtfexport/data/fdo32613.odt |binary
sw/qa/extras/rtfexport/rtfexport.cxx | 17 -
sw/qa/extras/rtfimport/data/fdo74229.rtf | 33 +
sw/qa/extras/rtfimport/data/fdo79959.rtf |4 +
sw/qa/extras/rtfimport/rtfimport.cxx | 16
sw/source/filter/ww8/rtfattributeoutput.cxx| 85 +++--
writerfilter/source/rtftok/rtfdocumentimpl.cxx | 15 +++-
9 files changed, 173 insertions(+), 9 deletions(-)
New commits:
commit f16f40089db8ba59c6ac67f1b85438c8c62b5285
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Aug 29 17:40:51 2014 +0200
fdo#79959 RTF import: trim whitespace around style names
(cherry picked from commit 305ecd1848a802a6c43ecc6e76f4c6bc36a03418)
Conflicts:
writerfilter/source/rtftok/rtfdocumentimpl.cxx
Change-Id: Id23cbd62b057442c577fef124a5705e4d551076f
diff --git a/sw/qa/extras/rtfimport/data/fdo79959.rtf
b/sw/qa/extras/rtfimport/data/fdo79959.rtf
new file mode 100644
index 000..231f39a
--- /dev/null
+++ b/sw/qa/extras/rtfimport/data/fdo79959.rtf
@@ -0,0 +1,4 @@
+{\rtf1\ansi\ansicpg1251\deff0\deflang1049{\fonttbl{\f0\fnil\fcharset0
Calibri;}}
+{\stylesheet{\s0 Test;}}
+\viewkind4\uc1\pard\s0\slmult1\lang9\f0\fs22 Hello world!\par
+}
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx
b/sw/qa/extras/rtfimport/rtfimport.cxx
index a9c3cb8..b3349f1 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -1689,6 +1689,12 @@ DECLARE_RTFIMPORT_TEST(testFdo74229, fdo74229.rtf)
CPPUNIT_ASSERT_EQUAL(sal_Int32(TWIP_TO_MM100(67)),
getPropertysal_Int32(xCell, RightBorderDistance));
}
+DECLARE_RTFIMPORT_TEST(testFdo79959, fdo79959.rtf)
+{
+// This was false, as the style was imported as Test, i.e. no
whitespace stripping.
+CPPUNIT_ASSERT_EQUAL(true,
static_castbool(getStyles(ParagraphStyles)-hasByName(Test)));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index fd1d718..649b3fc 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -1121,8 +1121,8 @@ void RTFDocumentImpl::text(OUString rString)
if
(m_aStates.top().aTableAttributes.find(NS_rtf::LN_SGC))
{
OUString aName =
m_aStates.top().aDestinationText.makeStringAndClear();
-m_aStyleNames[m_nCurrentStyleIndex] = aName;
-RTFValue::Pointer_t pValue(new
RTFValue(aName));
+m_aStyleNames[m_nCurrentStyleIndex] =
aName.trim();
+RTFValue::Pointer_t pValue(new
RTFValue(aName.trim()));
m_aStates.top().aTableAttributes.set(NS_ooxml::LN_CT_Style_styleId, pValue);
m_aStates.top().aTableSprms.set(NS_ooxml::LN_CT_Style_name, pValue);
commit ed0af187f9e9fb63b311684369e3f2fe1aba700b
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Sep 5 10:36:08 2014 +0200
abi#10039 RTF export: support page-anchored frames
(cherry picked from commit 845fb7bf6753ec9582d0b1d1c9b4276aa9e6c65e)
Conflicts:
sw/qa/extras/rtfexport/rtfexport.cxx
Change-Id: I71c961799f76446cdf24faeba86f881ae02ffe3b
diff --git a/sw/qa/extras/rtfexport/data/abi10039.odt
b/sw/qa/extras/rtfexport/data/abi10039.odt
new file mode 100644
index 000..4d5dde5
Binary files /dev/null and b/sw/qa/extras/rtfexport/data/abi10039.odt differ
diff --git a/sw/qa/extras/rtfexport/rtfexport.cxx
b/sw/qa/extras/rtfexport/rtfexport.cxx
index c10def0..593dc98 100644
--- a/sw/qa/extras/rtfexport/rtfexport.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport.cxx
@@ -617,6 +617,12 @@ DECLARE_RTFEXPORT_TEST(testFdo32613, fdo32613.odt)
CPPUNIT_ASSERT_EQUAL(text::TextContentAnchorType_AT_CHARACTER,
getPropertytext::TextContentAnchorType(getShape(1), AnchorType));
}
+DECLARE_RTFEXPORT_TEST(testAbi10039, abi10039.odt)
+{
+// Make sure we don't just crash on export, and additionally the shape
should not be inline (as it's at-page anchored originally).
+CPPUNIT_ASSERT(text::TextContentAnchorType_AS_CHARACTER !=
getPropertytext::TextContentAnchorType(getShape(1), AnchorType));
+}
+
#endif
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx
b/sw/source/filter/ww8/rtfattributeoutput.cxx
index ff482d9..ec3c748 100644
--- a/sw/source/filter/ww8/rtfattributeoutput.cxx
+++ b/sw/source/filter/ww8/rtfattributeoutput.cxx
@@ -3706,8 +3706,16 @@ void RtfAttributeOutput::FlyFrameGraphic( const
SwFlyFrmFmt* pFlyFrmFmt, const S
[Libreoffice-commits] core.git: 2 commits - cui/source swext/mediawiki
cui/source/options/treeopt.cxx|8
swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java | 11 +++
2 files changed, 15 insertions(+), 4 deletions(-)
New commits:
commit 5f6b19760865d1f7720466416a69cc2d29f13b59
Author: Caolán McNamara caol...@redhat.com
Date: Mon Sep 8 12:10:43 2014 +0100
mediawiki options went missing
regression from 34bcf9b498bccb5c924f4cec850ff15d88df6f07
Change-Id: Ibd0645bd218c81da110b3704a530e3849b761fb4
Date: Wed Aug 13 10:08:31 2014 +0200
java: remove dead methods
found by UCDetector
diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java
b/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java
index 22b344e..959cf99 100644
--- a/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java
+++ b/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java
@@ -68,7 +68,18 @@ public final class WikiEditorImpl extends WeakBase
m_aSettings = Settings.getSettings( m_xContext );
}
+public static XSingleComponentFactory __getComponentFactory( String
sImplementationName )
+{
+XSingleComponentFactory xFactory = null;
+
+if ( sImplementationName.equals( m_implementationName ) )
+xFactory = Factory.createComponentFactory( WikiEditorImpl.class,
m_serviceNames );
+else if ( sImplementationName.equals(
WikiOptionsEventHandlerImpl.m_sImplementationName ) )
+xFactory = Factory.createComponentFactory(
WikiOptionsEventHandlerImpl.class,
+
WikiOptionsEventHandlerImpl.m_pServiceNames );
+return xFactory;
+}
// com.sun.star.lang.XServiceInfo:
public String getImplementationName()
commit 9d4ed5737f2c6f73b02e5878cd3f8cc013443b34
Author: Caolán McNamara caol...@redhat.com
Date: Mon Sep 8 11:20:33 2014 +0100
don't make reason for exception a mystery
Change-Id: I3a3a2273dc0f97931dd6ddfd9492d5a883448aa3
diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx
index d7293b8..292a5ee 100644
--- a/cui/source/options/treeopt.cxx
+++ b/cui/source/options/treeopt.cxx
@@ -2250,13 +2250,13 @@ void ExtensionsTabPage::CreateDialogWithHandler()
}
}
}
-catch ( ::com::sun::star::lang::IllegalArgumentException )
+catch (const css::lang::IllegalArgumentException e)
{
-SAL_WARN( cui.options,
ExtensionsTabPage::CreateDialogWithHandler(): illegal argument );
+SAL_WARN(cui.options, ExtensionsTabPage::CreateDialogWithHandler():
illegal argument: e.Message);
}
-catch ( Exception )
+catch (const Exception e)
{
-SAL_WARN( cui.options,
ExtensionsTabPage::CreateDialogWithHandler(): exception of
XDialogProvider2::createDialogWithHandler() );
+SAL_WARN( cui.options,
ExtensionsTabPage::CreateDialogWithHandler(): exception of
XDialogProvider2::createDialogWithHandler(): e.Message);
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Outlines
Keith Fretz wrote Could we use the tuxcards code to add outline capacity to libreoffice? Tuxcards is licensed under GPL v2 which is more restrictive than LGPL/MPL (under which LO is licensed). This incompatibility would need to first be resolved through re-licensing of the Tuxcards source code. -- View this message in context: http://nabble.documentfoundation.org/Outlines-tp4121259p4121547.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
LibreOffice Weekly News #4 released
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi *, I've just finished writing the fourth LOWN edition. [1] Comments are, as always, welcome. As I wrote in the introduction, I still need to catch up +700 mails (most are technical dev oriented) and summarize the slides/videos from the LibreOffice conference for LOWN 5. If you get involved at the conference and had a talk there, please provide your slides on your blog (if you have any) or any social network. I'm following the most influential on each social networks, if you published your slides there, I will find them. ;-) As a reminder, if you have suggestions of topics non mentioned in the mailing lists, do not hesitate to put a note in the next issue [2]. LOWN basically consists in writing a summary which could be reused: * for the annual report The Document Foundation has to provide to German authorities, * by the marketing team; * and also by IT news like NextInpact, Phoronix, etc if they want to cover LibreOffice development. Regards, [1] https://wiki.documentfoundation.org/LOWN/4 [2] https://wiki.documentfoundation.org/LOWN/5 - -- William Gathoye will...@gathoye.be -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBAgAGBQJUDZWYAAoJEA595SwE1xaDa8cP/1JQLZkj5/vVG33iFj+gi/xk giEY0W3c7pz6ol5c0RaXueixdIS9FXsWTkWYx4UC23XyjLl5Uog8DD01zSF/2x3M y8kUqUi/yfdGoZRv8gpcBU2asuzAvUExLarVCjZNFEcWGpZUTaN0c0uc8IIMNou3 ZlkbGWDwZWKvmon2/bKI4hAu8H3LeNgVpa10qDrK2pUO79jOmW48JnspvMmAhcAF Y+JmjLAuCU7Cj9GxJ66nrArn88Vo/1dpJYVC0yX6bvIjm49nasesepybU6DvnDoD +1PMIBZ8QMneaY4eJhO6Ur0OenZ21une4kcTT9IweUPUo5fJncpKWuOJoUdZT5AN uC08p8hdTHlpf+gz2uPwUaEaDNX5mJUW14S+Gt3AU9KrblZAhfvMhTpwAdE4XbMK 0dBubU8GE3dkOIJHJnhRKoQ7Ys8Y/Nlc3WUo3JNIcd38mJ1KneLzsR7/txsfOSHp Wmg1KDGsJgw5sRvGHVxj7NHRV/sLfWDc9jQni7SeH7qAU5ehDL1APhLL8R3J/sBY uNwAv87rr2DmqFJYi7E0b+uymOWOJt1s6/DDZCSJ2L4KdBHch6JYvX7iaJ4Lmy3k iuKrrq/tg8Ly7Wbq9vHiH9xPkwQmwr6tIgZ65fLkU3kxbzp0LAHiGORevDmhsGem Xv9XWUtNjPzR1+fAJm6s =NX5q -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: vcl/source
vcl/source/opengl/OpenGLContext.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ae2efbf125052fad12ecb799ba45992c8ff56c2e
Author: Matúš Kukan matus.ku...@collabora.com
Date: Mon Sep 8 14:16:39 2014 +0200
WaE: 'DBG_UTIL' is not defined, evaluates to 0 [-Wundef]
Change-Id: I425b852dc983f7603fac88b5332650c61d9c6c3a
diff --git a/vcl/source/opengl/OpenGLContext.cxx
b/vcl/source/opengl/OpenGLContext.cxx
index 4f73fb0..d00f3e6 100644
--- a/vcl/source/opengl/OpenGLContext.cxx
+++ b/vcl/source/opengl/OpenGLContext.cxx
@@ -485,7 +485,7 @@ bool OpenGLContext::ImplInit()
return false;
#elif defined( UNX )
-#if DBG_UTIL
+#ifdef DBG_UTIL
if (glXCreateContextAttribsARB !mbRequestLegacyContext)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Lower case Greek letters (FDO#80650)
Hi All, Just wanted to raise awareness of this one. If anyone has some time to poke it. Regression with nearly 50 comments on it and I get pinged daily with dupes or more people saying that it's still an issue in a comment. Thanks Best, Joel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - include/vcl swext/mediawiki vcl/source
include/vcl/layout.hxx|4 +++-
swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java |2 ++
vcl/source/window/layout.cxx |1 -
3 files changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 253b97cc353731dfec6fa6dc9923f34a946b0d21
Author: Caolán McNamara caol...@redhat.com
Date: Mon Sep 8 13:42:49 2014 +0100
missing imports
Change-Id: Id569f55097cf513825b62225ec8861319b0a93cf
diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java
b/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java
index 959cf99..15ece8c 100644
--- a/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java
+++ b/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java
@@ -36,6 +36,8 @@ import com.sun.star.frame.XFrame;
import com.sun.star.frame.XModel;
import com.sun.star.frame.XStorable;
import com.sun.star.lang.XInitialization;
+import com.sun.star.lang.XSingleComponentFactory;
+import com.sun.star.lib.uno.helper.Factory;
import com.sun.star.lib.uno.helper.WeakBase;
import com.sun.star.uno.UnoRuntime;
import com.sun.star.uno.XComponentContext;
commit fbc634d44889376cf5fbde4413093ea9ed2d
Author: Caolán McNamara caol...@redhat.com
Date: Mon Sep 8 08:05:18 2014 +0100
make this ctor of MessageDialog for the builder only
Change-Id: Ic92f6e46164bdb2e15a0a23876fce5be10a73324
diff --git a/include/vcl/layout.hxx b/include/vcl/layout.hxx
index 6c4ce28..cddac9e 100644
--- a/include/vcl/layout.hxx
+++ b/include/vcl/layout.hxx
@@ -719,6 +719,9 @@ private:
void setButtonHandlers(VclButtonBox *pButtonBox);
short get_response(const Window *pWindow) const;
void create_owned_areas();
+
+friend class VclBuilder;
+MessageDialog(Window* pParent, WinBits nStyle = WB_MOVEABLE | WB_3DLOOK |
WB_CLOSEABLE);
public:
MessageDialog(Window* pParent,
@@ -726,7 +729,6 @@ public:
VclMessageType eMessageType = VCL_MESSAGE_ERROR,
VclButtonsType eButtonsType = VCL_BUTTONS_OK,
WinBits nStyle = WB_MOVEABLE | WB_3DLOOK | WB_CLOSEABLE);
-MessageDialog(Window* pParent, WinBits nStyle = WB_MOVEABLE | WB_3DLOOK |
WB_CLOSEABLE);
MessageDialog(Window* pParent, const OString rID, const OUString
rUIXMLDescription);
virtual bool set_property(const OString rKey, const OString rValue)
SAL_OVERRIDE;
virtual short Execute() SAL_OVERRIDE;
diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx
index 3c71327..fb99034 100644
--- a/vcl/source/window/layout.cxx
+++ b/vcl/source/window/layout.cxx
@@ -1946,7 +1946,6 @@ MessageDialog::MessageDialog(Window* pParent, WinBits
nStyle)
, m_pSecondaryMessage(NULL)
{
SetType(WINDOW_MESSBOX);
-create_owned_areas();
}
MessageDialog::MessageDialog(Window* pParent,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx |6 +-
writerfilter/source/rtftok/rtfdocumentimpl.cxx| 51 --
writerfilter/source/rtftok/rtfdocumentimpl.hxx|3 -
3 files changed, 24 insertions(+), 36 deletions(-)
New commits:
commit 01a53d19b138cf7285e3b31be545dc915958b3c9
Author: Michael Stahl mst...@redhat.com
Date: Sat Aug 2 18:55:55 2014 +0200
fdo#81944 fdo#82107: writerfilter: RTF import: don't drop fonts in
stylesheet
The font definitions in the style sheet meet an untimely death in
StyleSheetTable::lcl_sprm(), which special-cases LN_EG_RPrBase_rFonts,
routing it into TblStylePrHandler.
Avoid this by sending style entries to the domain mapper in the same way
as the OOXML tokenizer, i.e., with paragraph and run properties nested
below CT_Style_pPr/rPr.
This reveals that the CT_Style_basedOn was wrongly handled as paragraph
property.
(cherry picked from commit f8e8e476aa0a5576234dbb4daac9dc299e044e61)
Conflicts:
writerfilter/source/rtftok/rtfdocumentimpl.cxx
Change-Id: Ic724ba48fe36bf782b1b430bdafdb1df480d5ad3
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 2b87cd7..4e9a6f1 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -4333,15 +4333,17 @@ uno::Referencecontainer::XIndexAccess
DomainMapper_Impl::GetCurrentNumberingRu
// So we are in a paragraph style and it has numbering. Look up the
relevant numbering rules.
OUString aListName = ListDef::GetStyleName(nListId);
-uno::Reference style::XStyleFamiliesSupplier
xStylesSupplier(GetTextDocument(), uno::UNO_QUERY);
+uno::Reference style::XStyleFamiliesSupplier
xStylesSupplier(GetTextDocument(), uno::UNO_QUERY_THROW);
uno::Reference container::XNameAccess xStyleFamilies =
xStylesSupplier-getStyleFamilies();
uno::Referencecontainer::XNameAccess xNumberingStyles;
xStyleFamilies-getByName(NumberingStyles) = xNumberingStyles;
uno::Referencebeans::XPropertySet
xStyle(xNumberingStyles-getByName(aListName), uno::UNO_QUERY);
xRet.set(xStyle-getPropertyValue(NumberingRules), uno::UNO_QUERY);
}
-catch( const uno::Exception )
+catch (const uno::Exception e)
{
+SAL_WARN(writerfilter.dmapper,
+GetCurrentNumberingRules: exception caught: e.Message);
}
return xRet;
}
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 649b3fc..76a083c 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -1127,7 +1127,7 @@ void RTFDocumentImpl::text(OUString rString)
m_aStates.top().aTableSprms.set(NS_ooxml::LN_CT_Style_name, pValue);
writerfilter::ReferenceProperties::Pointer_t
const pProp(
-new
RTFReferenceProperties(mergeAttributes(), mergeSprms())
+ createStyleProperties()
);
m_aStyleTableEntries.insert(make_pair(m_nCurrentStyleIndex, pProp));
}
@@ -3059,6 +3059,10 @@ int RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword,
int nParam)
case RTF_LEVELNFC: nSprm = NS_rtf::LN_NFC; break;
case RTF_LEVELSTARTAT: nSprm = NS_rtf::LN_ISTARTAT; break;
case RTF_LEVELPICTURE: nSprm = NS_ooxml::LN_CT_Lvl_lvlPicBulletId;
break;
+case RTF_SBASEDON:
+ nSprm = (nKeyword == RTF_SBASEDON) ? NS_ooxml::LN_CT_Style_basedOn
: NS_ooxml::LN_CT_Style_next;
+ pIntValue.reset(new RTFValue(getStyleName(nParam)));
+ break;
default: break;
}
if (nSprm 0)
@@ -3096,10 +3100,6 @@ int RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword,
int nParam)
case RTF_RI: nSprm = NS_sprm::LN_PDxaRight; break;
case RTF_RIN: nSprm = 0x845d; break;
case RTF_ITAP: nSprm = NS_sprm::LN_PTableDepth; break;
-case RTF_SBASEDON:
- nSprm = (nKeyword == RTF_SBASEDON) ? NS_ooxml::LN_CT_Style_basedOn
: NS_ooxml::LN_CT_Style_next;
- pIntValue.reset(new RTFValue(getStyleName(nParam)));
- break;
default: break;
}
if (nSprm 0)
@@ -4194,19 +4194,21 @@ int RTFDocumentImpl::pushState()
return 0;
}
-RTFSprms RTFDocumentImpl::mergeSprms()
+writerfilter::ReferenceProperties::Pointer_t
+RTFDocumentImpl::createStyleProperties()
{
-RTFSprms aSprms;
-for (RTFSprms::Iterator_t i = m_aStates.top().aTableSprms.begin();
-i != m_aStates.top().aTableSprms.end(); ++i)
-aSprms.set(i-first, i-second);
-for (RTFSprms::Iterator_t i = m_aStates.top().aCharacterSprms.begin();
-
[Libreoffice-commits] core.git: 2 commits - unotools/CppunitTest_unotools_fontdefs.mk unotools/Module_unotools.mk unotools/qa unotools/source
unotools/CppunitTest_unotools_fontdefs.mk| 34
unotools/Module_unotools.mk |3 +
unotools/qa/unit/testGetEnlishSearchName.cxx | 55 +++
unotools/source/misc/fontdefs.cxx| 33
4 files changed, 102 insertions(+), 23 deletions(-)
New commits:
commit 1f7e6bdd23600cf118b786bbeb869949c36297e7
Author: Michael Meeks michael.me...@collabora.com
Date: Mon Sep 8 13:03:03 2014 +0100
fdo#82854 - cleanup review bits.
Change-Id: Ia5b2628adb62013a22cf6c5e384154c54abc2294
diff --git a/unotools/qa/unit/testGetEnlishSearchName.cxx
b/unotools/qa/unit/testGetEnlishSearchName.cxx
index 38b10ea..1701215 100644
--- a/unotools/qa/unit/testGetEnlishSearchName.cxx
+++ b/unotools/qa/unit/testGetEnlishSearchName.cxx
@@ -15,10 +15,8 @@
#include cppunit/plugin/TestPlugIn.h
#include unotools/fontdefs.hxx
-
class Test: public CppUnit::TestFixture
{
-
public:
virtual void setUp() SAL_OVERRIDE;
void testSingleElement();
@@ -34,36 +32,23 @@ void Test::setUp()
void Test::testSingleElement()
{
-{ //lowercase
-printf(GetEnglishSearchFontName( \SYMBOL\ ));
+{ // lowercase
OUString test1 = GetEnglishSearchFontName( SYMBOL );
CPPUNIT_ASSERT_EQUAL(test1, OUString(symbol));
-printf(return %s,test1.getStr());
-//trailingWhitespaces
-printf(GetEnglishSearchFontName( \SYMBOL\ ));
+// trailingWhitespaces
test1 = GetEnglishSearchFontName( Symbol );
CPPUNIT_ASSERT_EQUAL(test1, OUString(symbol));
-printf(return %s,test1.getStr());
-//removing Skripts
-printf(GetEnglishSearchFontName( \SYMBOL(skript)\ ));
+// removing Skripts
test1 = GetEnglishSearchFontName( Symbol(skript) );
CPPUNIT_ASSERT_EQUAL(test1, OUString(symbol));
-printf(return %s,test1.getStr());
-//remove Whitespaces between
-printf(GetEnglishSearchFontName( \SYMBOL (skript)\ ));
+// remove Whitespaces between
test1 = GetEnglishSearchFontName( Symbol (skript) );
CPPUNIT_ASSERT_EQUAL(test1, OUString(symbol));
-printf(return %s,test1.getStr());
-//trailingWhitespaces
-
+// trailingWhitespaces
}
-
-
}
-
-
CPPUNIT_TEST_SUITE_REGISTRATION(Test);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/unotools/source/misc/fontdefs.cxx
b/unotools/source/misc/fontdefs.cxx
index be2079f..4f0fb08 100644
--- a/unotools/source/misc/fontdefs.cxx
+++ b/unotools/source/misc/fontdefs.cxx
@@ -400,7 +400,6 @@ OUString GetEnglishSearchFontName( const OUString rInName )
else if( ((c '0') || (c '9')) (c != ';') ) // not 0-9 or
semicolon
{
// Remove white spaces and special characters
-
rName.remove(i,1);
nLen--;
continue;
@@ -426,7 +425,7 @@ OUString GetEnglishSearchFontName( const OUString rInName )
FontNameDictionary::const_iterator it = aDictionary.find( rNameStr );
if( it != aDictionary.end() )
-rName = OUString::createFromAscii ( it-second );
+rNameStr = OUString::createFromAscii ( it-second );
}
return rNameStr;
commit 8e1a7034ff35ee825f3f8f22e14d93189149a1aa
Author: Michael Jaumann meta_...@yahoo.com
Date: Tue Sep 2 06:49:48 2014 +
fdo#82854 - use OUStringBuffer in fontdefs.cxx plus unit-test.
Change-Id: Ia3a4814467ed98bd3b1889991cc3644c0c23f515
diff --git a/unotools/CppunitTest_unotools_fontdefs.mk
b/unotools/CppunitTest_unotools_fontdefs.mk
new file mode 100644
index 000..468838b
--- /dev/null
+++ b/unotools/CppunitTest_unotools_fontdefs.mk
@@ -0,0 +1,34 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_CppunitTest_CppunitTest,unotools_fontdefs))
+
+$(eval $(call gb_CppunitTest_use_external,unotools_fontdefs,boost_headers))
+
+$(eval $(call gb_CppunitTest_use_api,unotools_fontdefs, \
+offapi \
+udkapi \
+))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,unotools_fontdefs, \
+unotools/qa/unit/testGetEnlishSearchName \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,unotools_fontdefs, \
+ comphelper \
+ cppu \
+ cppuhelper \
+ tl \
+ sal \
+ svt \
+ utl \
+$(gb_UWINAPI) \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/unotools/Module_unotools.mk b/unotools/Module_unotools.mk
index d450dfc..c8a46e3 100644
--- a/unotools/Module_unotools.mk
+++ b/unotools/Module_unotools.mk
@@ -16,5 +16,8 @@ $(eval $(call gb_Module_add_targets,unotools,\
$(eval $(call gb_Module_add_subsequentcheck_targets,unotools,\
[Libreoffice-commits] core.git: dbaccess/source dbaccess/uiconfig
dbaccess/source/ui/querydesign/querydlg.cxx |5 ++
dbaccess/uiconfig/ui/joindialog.ui | 61 ++--
2 files changed, 36 insertions(+), 30 deletions(-)
New commits:
commit 3fc1e691c5e14f3b7a2579b563188e814f731cf6
Author: Caolán McNamara caol...@redhat.com
Date: Mon Sep 8 15:49:24 2014 +0100
Resolves: fdo#83501 STR_QUERY_* populate the join dialog
Change-Id: Id4cff969297009c9f9cd3323ac01c743b29ca6c4
diff --git a/dbaccess/source/ui/querydesign/querydlg.cxx
b/dbaccess/source/ui/querydesign/querydlg.cxx
index b655a9b..23db605 100644
--- a/dbaccess/source/ui/querydesign/querydlg.cxx
+++ b/dbaccess/source/ui/querydesign/querydlg.cxx
@@ -55,6 +55,11 @@ DlgQryJoin::DlgQryJoin( OQueryTableView * pParent,
, m_xConnection(_xConnection)
{
get(m_pML_HelpText, helptext);
+Size aSize(LogicToPixel(Size(179, 49), MAP_APPFONT));
+//alternatively loop through the STR_QUERY_* strings with their
STR_JOIN_TYPE_HINT
+//suffix to find the longest entry at runtime
+m_pML_HelpText-set_height_request(aSize.Height());
+m_pML_HelpText-set_width_request(aSize.Width());
get(m_pLB_JoinType, type);
get(m_pCBNatural, natural);
get(m_pPB_OK, ok);
diff --git a/dbaccess/uiconfig/ui/joindialog.ui
b/dbaccess/uiconfig/ui/joindialog.ui
index 0c4add3..a7375e4 100644
--- a/dbaccess/uiconfig/ui/joindialog.ui
+++ b/dbaccess/uiconfig/ui/joindialog.ui
@@ -3,6 +3,36 @@
interface
requires lib=gtk+ version=3.0/
!-- interface-requires LibreOffice 1.0 --
+ object class=GtkListStore id=liststore1
+columns
+ !-- column-name gchararray1 --
+ column type=gchararray/
+ !-- column-name gint1 --
+ column type=gint/
+/columns
+data
+ row
+col id=0 translatable=yesInner join/col
+col id=11/col
+ /row
+ row
+col id=0 translatable=yesLeft join/col
+col id=12/col
+ /row
+ row
+col id=0 translatable=yesRight join/col
+col id=13/col
+ /row
+ row
+col id=0 translatable=yesFull (outer) join/col
+col id=14/col
+ /row
+ row
+col id=0 translatable=yesCross join/col
+col id=15/col
+ /row
+/data
+ /object
object class=GtkDialog id=JoinDialog
property name=can_focusFalse/property
property name=border_width6/property
@@ -167,6 +197,7 @@
property name=visibleTrue/property
property name=can_focusFalse/property
property name=xalign0/property
+property name=yalign0/property
property name=wrapTrue/property
property name=max_width_chars48/property
/object
@@ -333,34 +364,4 @@
widget name=type/
/widgets
/object
- object class=GtkListStore id=liststore1
-columns
- !-- column-name gchararray1 --
- column type=gchararray/
- !-- column-name gint1 --
- column type=gint/
-/columns
-data
- row
-col id=0 translatable=yesInner join/col
-col id=11/col
- /row
- row
-col id=0 translatable=yesLeft join/col
-col id=12/col
- /row
- row
-col id=0 translatable=yesRight join/col
-col id=13/col
- /row
- row
-col id=0 translatable=yesFull (outer) join/col
-col id=14/col
- /row
- row
-col id=0 translatable=yesCross join/col
-col id=15/col
- /row
-/data
- /object
/interface
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [libreoffice] allow passing FilterOptions via cli
Sorry, I meant 4.3.3 as 4.3.2 is in freeze already. On 08/09/14 17:10, Tomas Hlavaty wrote: Hi all, would it be possible to cherry-pick http://cgit.freedesktop.org/libreoffice/core/commit/?id=45ba4d79d968f81f74ef0c4588fd15b1ce91153f to the 4.3.2 release? It is currently commited towards 4.4 (scheduled for 2/2015) but as this is an old bug and 4.3.2 is called bugfix release, I wonder if it was be acceptable? Thank you, Tomas On 04/06/14 14:28, Stephan Bergmann wrote: On 06/04/2014 02:16 PM, Tomas Hlavaty wrote: From your remark https://bugs.freedesktop.org/show_bug.cgi?id=36313#c17 I understand, that it does not seem very user friendly. However, the patch at least makes it possible to achieve the desired behaviour, which was not possible previously. Maybe the remaining problem should be seen as how to make the CVS filter options more user friendly? I don't have an answer to that, unfortunatelly. Yeah; maybe leave it to one of the people who reported to that issue to decide whether to mark it as resolved. I found another bug report https://bugs.freedesktop.org/show_bug.cgi?id=47892 which explicitly asks for FilterOptions at least for --convert-to so I should have probably addressed this, but I found it later. Should I mark https://bugs.freedesktop.org/show_bug.cgi?id=47892 as resolved or leave it to QA people to handle that? Please do mark that one as resolved. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: l10ntools/source
l10ntools/source/export.cxx | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
New commits:
commit 181b1c0f7cfe6a26874705d64b5efe6ea93f6e93
Author: Douglas Mencken dougmenc...@gmail.com
Date: Mon Sep 8 10:18:14 2014 -0400
l10ntools/source/export.cxx: improve style of code
Change-Id: Ieef44da0ab8f2d33faaf8c32970bb9d33df6750b
Reviewed-on: https://gerrit.libreoffice.org/11318
Reviewed-by: Norbert Thiebaud nthieb...@gmail.com
Tested-by: Norbert Thiebaud nthieb...@gmail.com
diff --git a/l10ntools/source/export.cxx b/l10ntools/source/export.cxx
index 170d76f..efd336d 100644
--- a/l10ntools/source/export.cxx
+++ b/l10ntools/source/export.cxx
@@ -74,8 +74,8 @@ static OString lcl_GetListTyp( const sal_uInt16 nTyp, const
bool bUpperCamelCase
extern C {
-FILE * init(int argc, char ** argv) {
-
+FILE * init(int argc, char ** argv)
+{
common::HandledArgs aArgs;
if ( !common::handleArguments(argc, argv, aArgs) )
{
@@ -109,7 +109,8 @@ int Parse( int nTyp, const char *pTokenText ){
return 1;
}
-void Close(){
+void Close()
+{
global::exporter-GetParseQueue()-Close();
global::exporter.reset();
// avoid nontrivial Export dtor being executed during exit
@@ -121,19 +122,12 @@ int WorkOnTokenSet( int nTyp, char *pTokenText )
return 1;
}
-} // extern
-
-extern C {
-
int SetError()
{
// set error at global instance of class Export
global::exporter-SetError();
return 1;
}
-}
-
-extern C {
int GetError()
{
@@ -142,7 +136,8 @@ int GetError()
return 1;
return sal_False;
}
-}
+
+} // extern C
// class ResData
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/subsequent_export-test.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit c4da2452149b6ccc07c8d74717f11665767bb210
Author: Michael Stahl mst...@redhat.com
Date: Mon Sep 8 18:40:21 2014 +0200
spurious warning C4189 local variable initialized but not referenced
Change-Id: I1162ad2b222445b61a3cc3c6314c74b1b11f5483
diff --git a/sc/qa/unit/subsequent_export-test.cxx
b/sc/qa/unit/subsequent_export-test.cxx
index 61c2afc..924f779 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -2152,6 +2152,7 @@ void ScExportTest::testPivotTableTwoDataFieldsXLSX()
}
const char* pNames[] = { Name, Value };
+(void) pNames;
size_t nCount = pCache-GetFieldCount();
if (nCount != SAL_N_ELEMENTS(pNames))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Crash test update
New crashtest update available at dev-builds.libreoffice.org/crashtest/845fb7bf6753ec9582d0b1d1c9b4276aa9e6c65e exportCrashes.csv Description: Binary data importCrash.csv Description: Binary data validationErrors.csv Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Boris Egorov license statement
Hello, folks. I want to join your team. All of my past future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. -- Best regards, Boris Egorov ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - bean/com jurt/com swext/mediawiki
bean/com/sun/star/beans/LocalOfficeWindow.java |2 ++
bean/com/sun/star/comp/beans/CallWatchThread.java|2 +-
bean/com/sun/star/comp/beans/LocalOfficeConnection.java |2 ++
bean/com/sun/star/comp/beans/OOoBean.java|2 +-
jurt/com/sun/star/lib/uno/environments/remote/JobQueue.java |2 ++
jurt/com/sun/star/lib/util/AsynchronousFinalizer.java|2 +-
swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java |7 +++
swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java|7 ---
8 files changed, 16 insertions(+), 10 deletions(-)
New commits:
commit 53425404ae70bf365073cce2f5d576b769446c97
Author: Michael Stahl mst...@redhat.com
Date: Tue Sep 2 10:49:51 2014 +0200
swext: use proper syntax for accessing outer class this
Change-Id: Ie2d466b4e1a567d204b109208fce84842bea2a19
diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java
b/swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java
index 1c9db30..2c74d40 100644
--- a/swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java
+++ b/swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java
@@ -361,7 +361,6 @@ public class WikiEditSettingDialog extends WikiDialog
{
final XDialog xDialogForThread = xDialog;
final XComponentContext xContext = m_xContext;
-final WikiEditSettingDialog aThis = this;
// the thread name is used to allow the error dialogs
m_bThreadFinished = false;
@@ -376,9 +375,9 @@ public class WikiEditSettingDialog extends WikiDialog
} catch( java.lang.Exception e ){}
DoLogin();
-aThis.EnableControls( true );
-aThis.SetThrobberActive( false );
-aThis.SetThrobberVisible( false );
+WikiEditSettingDialog.this.EnableControls( true );
+WikiEditSettingDialog.this.SetThrobberActive( false );
+WikiEditSettingDialog.this.SetThrobberVisible( false );
ThreadStop( true );
diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java
b/swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java
index 48e55f3..a9df952 100644
--- a/swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java
+++ b/swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java
@@ -275,7 +275,6 @@ public class WikiPropDialog extends WikiDialog{
ex.printStackTrace();
}
-final WikiPropDialog aThisDialog = this;
final XDialog xDialogToClose = xDialog;
final XComponentContext xContext = m_xContext;
@@ -297,7 +296,8 @@ public class WikiPropDialog extends WikiDialog{
if ( m_aWikiEditor != null )
{
Thread.yield();
-m_bAction = m_aWikiEditor.SendArticleImpl(
aThisDialog, aWikiSettings );
+m_bAction = m_aWikiEditor.SendArticleImpl(
+WikiPropDialog.this, aWikiSettings);
}
}
finally
@@ -321,7 +321,8 @@ public class WikiPropDialog extends WikiDialog{
{
if ( m_aWikiEditor != null )
{
-m_bAction = m_aWikiEditor.SendArticleImpl(
aThisDialog, aWikiSettings );
+m_bAction = m_aWikiEditor.SendArticleImpl(
+WikiPropDialog.this, aWikiSettings);
}
} catch( java.lang.Exception e )
{}
commit 420170c8ddc5b6f16ca44113e28f77653aa3262f
Author: Michael Stahl mst...@redhat.com
Date: Tue Sep 2 10:42:37 2014 +0200
set names on some Java threads
Change-Id: I611821d5f84b440ba542a8d62a374df7b505de15
diff --git a/bean/com/sun/star/beans/LocalOfficeWindow.java
b/bean/com/sun/star/beans/LocalOfficeWindow.java
index ebae69d..d7356f8 100644
--- a/bean/com/sun/star/beans/LocalOfficeWindow.java
+++ b/bean/com/sun/star/beans/LocalOfficeWindow.java
@@ -264,6 +264,8 @@ public class LocalOfficeWindow
private CallWatchThread( long nTimeout )
{
+super(CallWatchThread deprecated);
+
this.aWatchedThread = Thread.currentThread();
this.nTimeout = nTimeout;
start();
diff --git a/bean/com/sun/star/comp/beans/CallWatchThread.java
b/bean/com/sun/star/comp/beans/CallWatchThread.java
index 45cecbc..2f99adc 100644
--- a/bean/com/sun/star/comp/beans/CallWatchThread.java
+++ b/bean/com/sun/star/comp/beans/CallWatchThread.java
@@ -36,7 +36,7 @@
[Libreoffice-commits] core.git: sdext/source
sdext/source/presenter/PresenterTimer.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5d0676066411f9f0d2061a89b97754aa09a0b9c8 Author: Michael Stahl mst...@redhat.com Date: Mon Sep 8 21:17:48 2014 +0200 sdext: check the copy on the stack, not the member Change-Id: Id8aaccf5fa31ad670215db61853bb729302b1fec diff --git a/sdext/source/presenter/PresenterTimer.cxx b/sdext/source/presenter/PresenterTimer.cxx index d3362ee..a54a3cb 100644 --- a/sdext/source/presenter/PresenterTimer.cxx +++ b/sdext/source/presenter/PresenterTimer.cxx @@ -483,7 +483,7 @@ void PresenterClockTimer::CheckCurrentTime (const TimeValue rCurrentTime) } } } -if (mxRequestCallback.is() xCallback.is()) +if (xRequestCallback.is() xCallback.is()) xRequestCallback-addCallback(xCallback, Any()); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 5 commits - framework/source include/vcl sfx2/source vcl/Library_vcl.mk vcl/source
framework/source/layoutmanager/layoutmanager.cxx | 10
include/vcl/menu.hxx | 29
sfx2/source/control/dispatch.cxx | 439 ---
vcl/Library_vcl.mk |4
vcl/source/window/menu.cxx | 3255 ---
vcl/source/window/menubarwindow.cxx | 1156
vcl/source/window/menubarwindow.hxx | 147 +
vcl/source/window/menufloatingwindow.cxx | 1209
vcl/source/window/menufloatingwindow.hxx | 121
vcl/source/window/menuitemlist.cxx | 280 +
vcl/source/window/menuitemlist.hxx | 152 +
vcl/source/window/menuwindow.cxx | 161 +
vcl/source/window/menuwindow.hxx | 59
13 files changed, 3559 insertions(+), 3463 deletions(-)
New commits:
commit 9195fd3819197c14f6fc018483075c4be5bf85fd
Author: Jan Holesovsky ke...@collabora.com
Date: Mon Sep 8 13:18:17 2014 +0200
vcl: Kill bIsMenuBar.
Change-Id: I16bcb4be7fcdba6272f9f4a92d5c90c71dc431e8
diff --git a/include/vcl/menu.hxx b/include/vcl/menu.hxx
index aeff356..741ed21 100644
--- a/include/vcl/menu.hxx
+++ b/include/vcl/menu.hxx
@@ -144,10 +144,9 @@ private:
sal_uInt16 nImgOrChkPos;
sal_uInt16 nTextPos;
-boolbIsMenuBar : 1,// Is this a menubar?
-bCanceled : 1,// Terminated during a callback
-bInCallback : 1,// In Activate/Deactivate
-bKilled : 1;// Killed...
+boolbCanceled : 1,/// Terminated during a
callback
+bInCallback : 1,/// In Activate/Deactivate
+bKilled : 1;/// Killed
::com::sun::star::uno::Reference
::com::sun::star::accessibility::XAccessible mxAccessible;
mutable vcl::MenuLayoutData* mpLayoutData;
@@ -201,12 +200,11 @@ public:
SAL_DLLPRIVATE void ImplKillLayoutData() const;
SAL_DLLPRIVATE Menu*ImplGetStartedFrom() const { return
pStartedFrom; }
-Menu();
-explicitMenu( bool bMenuBar );
SAL_DLLPRIVATE Window* ImplGetWindow() const { return pWindow; }
void ImplSelectWithStart( Menu* pStartMenu = NULL );
-public:
+public:
+Menu();
virtual ~Menu();
virtual voidActivate();
@@ -285,7 +283,7 @@ public:
boolIsItemPosVisible( sal_uInt16 nItemPos ) const;
boolIsMenuVisible() const;
-boolIsMenuBar() const { return bIsMenuBar; }
+virtual boolIsMenuBar() const { return false; }
voidRemoveDisabledEntries( bool bCheckPopups = true, bool
bRemoveEmptyPopups = false );
boolHasValidEntries( bool bCheckPopups = true );
@@ -413,6 +411,8 @@ public:
MenuBaroperator =( const MenuBar rMenu );
+virtual boolIsMenuBar() const SAL_OVERRIDE { return true; }
+
voidShowCloser( bool bShow = true );
boolHasCloser() const { return mbCloserVisible; }
boolHasFloatButton() const { return mbFloatBtnVisible; }
diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index f41729f..56a1d5d 100644
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -112,15 +112,6 @@ static void ImplSetMenuItemData( MenuItemData* pData )
Menu::Menu()
{
-bIsMenuBar = false;
-ImplInit();
-}
-
-// this constructor makes sure we're creating the native menu
-// with the correct type (ie, MenuBar vs. PopupMenu)
-Menu::Menu( bool bMenubar )
-{
-bIsMenuBar = bMenubar;
ImplInit();
}
@@ -176,7 +167,6 @@ void Menu::ImplInit()
mpSalMenu = NULL;
nMenuFlags = 0;
nDefaultItem= 0;
-//bIsMenuBar = false; // this is now set in the ctor, must not be
changed here!!!
nSelectedId = 0;
pItemList = new MenuItemList;
pLogo = NULL;
@@ -189,7 +179,7 @@ void Menu::ImplInit()
mpLayoutData= NULL;
mpFirstDel = NULL; // Dtor notification list
// Native-support: returns NULL if not supported
-mpSalMenu = ImplGetSVData()-mpDefInst-CreateMenu( bIsMenuBar, this );
+mpSalMenu = ImplGetSVData()-mpDefInst-CreateMenu(IsMenuBar(), this);
}
void Menu::ImplLoadRes( const ResId rResId )
@@ -216,7 +206,7 @@ void Menu::ImplLoadRes( const ResId rResId )
if( nObjMask RSC_MENU_TEXT )
{
-if( bIsMenuBar ) // no title in menubar
+if (IsMenuBar()) // no title in menubar
ReadStringRes();
else
aTitleText = ReadStringRes();
@@ -571,7 +561,7 @@ void Menu::InsertItem( const ResId rResId, sal_uInt16 nPos
)
void Menu::InsertSeparator(const OString rIdent, sal_uInt16 nPos)
{
// do
[Libreoffice-bugs] [Bug 83601] New: Add support for opening and editing .MHT documents
https://bugs.freedesktop.org/show_bug.cgi?id=83601 Priority: medium Bug ID: 83601 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Add support for opening and editing .MHT documents Severity: normal Classification: Unclassified OS: All Reporter: ve4er...@gmail.com Hardware: Other Status: UNCONFIRMED Version: 4.3.0.4 release Component: Writer Product: LibreOffice This is similar to https://bugs.freedesktop.org/show_bug.cgi?id=77213. LibreOffice Writer (or should I say unoconv) should be able to open and edit .MHT files, Like M$ Word can. Right now, I have to open the .MHT file with Word, save it as .DOC and open it using LibreOffice to get .MHT files to work with LibreOffice. LibreOffic should support .MHT (opening and saving as) out of the box. My version of LibreOffice: v4.3.0.4 (Build ID: 62ad5818884a2fc2e5780dd45466868d41009ec0). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 vulc...@gmx.com changed: What|Removed |Added Depends on||64945 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78529] Editing very slow with big picture on page
https://bugs.freedesktop.org/show_bug.cgi?id=78529 --- Comment #19 from Garri g.djavad...@gmail.com --- Excuse me, what is required to move status to CONFIRMED? Thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83588] Scrollwheel zoom centers page in Impress and Draw
https://bugs.freedesktop.org/show_bug.cgi?id=83588 Jean-Baptiste Faure jbfa...@libreoffice.org changed: What|Removed |Added Status|NEW |NEEDINFO CC||jbfa...@libreoffice.org --- Comment #3 from Jean-Baptiste Faure jbfa...@libreoffice.org --- Not sure if this behavior is a bug or a feature. I am pretty sure I already saw a bug or a discussion asking for this behavior. Not able to search where at the moment. Set status to NEEDINFO. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83602] New: While printing A4 page Size is passed on to cups even if A4.duplex paper size is selected in LO print dialog
https://bugs.freedesktop.org/show_bug.cgi?id=83602 Priority: medium Bug ID: 83602 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: While printing A4 page Size is passed on to cups even if A4.duplex paper size is selected in LO print dialog Severity: major Classification: Unclassified OS: Linux (All) Reporter: sanjay.kuma...@hp.com Hardware: All Status: UNCONFIRMED Version: 4.2.3.3 release Component: Libreoffice Product: LibreOffice Created attachment 105881 -- https://bugs.freedesktop.org/attachment.cgi?id=105881action=edit PPD used for creating print queue Libreoffice sends A4 even though A4.duplex is selected in the Libreoffice print dialog. Since there is a constraint between A4 and Duplex=Long or Short Edge and looks like because of that Libreoffice changes Duplex option from Long/short Edge to OFF as well. Just to prove what I said, I captured the application output file (d9-001.pdf) and its corresponding control file(c9), I can see that below options are passed on to cups in c9 file. Duplex: None PageSize: A4 Please find c9, d9-001.pdf files in below bug report. https://bugs.launchpad.net/hplip/+bug/1352316 https://answers.launchpad.net/hplip/+question/252277 The ppd used for creating the print queue is attached in this Bug report. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83602] While printing A4 page Size is passed on to cups even if A4.duplex paper size is selected in LO print dialog
https://bugs.freedesktop.org/show_bug.cgi?id=83602 --- Comment #1 from Sanjay Kumar sanjay.kuma...@hp.com --- Created attachment 105882 -- https://bugs.freedesktop.org/attachment.cgi?id=105882action=edit IPP request file passed on to Cups while printing -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62355] Formula objects with widehat/widevector in Writer have wrong size, top of the hat/vector is cropped
https://bugs.freedesktop.org/show_bug.cgi?id=62355 Gaborit Jean-Luc jl85.gabo...@free.fr changed: What|Removed |Added OS|Linux (All) |All CC||jl85.gabo...@free.fr -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62355] Formula objects with widehat/widevector in Writer have wrong size, top of the hat/vector is cropped
https://bugs.freedesktop.org/show_bug.cgi?id=62355 Gaborit Jean-Luc jl85.gabo...@free.fr changed: What|Removed |Added Component|Libreoffice |Formula Editor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51357] SVG: Add support for more shape transition effects to svg documents exported by Impress
https://bugs.freedesktop.org/show_bug.cgi?id=51357 d.sikele...@gmail.com changed: What|Removed |Added Assignee|d.sikele...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35862] Increase font and decrease font could work even if the selection contains differing font sizes
https://bugs.freedesktop.org/show_bug.cgi?id=35862 d.sikele...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |d.sikele...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83057] FILESAVE: [DOCX] File corrupts after Round Trip
https://bugs.freedesktop.org/show_bug.cgi?id=83057 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard||target:4.4.0 --- Comment #4 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Vinaya Mandke committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e6b295e55d82f236206c24f5cf1dcc314c34b20f fdo#83057 File corrupts on save, as SDT is added incorrectly The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80952] UI: Writer dialog Insert Frame, tab Background, choice Color, doesn't show colors..
https://bugs.freedesktop.org/show_bug.cgi?id=80952 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #4 from Cor Nouws c...@nouenoff.nl --- Thanks raal - is fixed indeed -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83603] New: Help has no links
https://bugs.freedesktop.org/show_bug.cgi?id=83603 Priority: medium Bug ID: 83603 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Help has no links Severity: normal Classification: Unclassified OS: Windows (All) Reporter: bfrh...@hotmail.com Hardware: Other Status: UNCONFIRMED Version: unspecified Component: Documentation Product: LibreOffice When I click Help within Writer, it opens Firefox on a Help page which cannot be used because there are no links. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38844] Reduce XOR rendering
https://bugs.freedesktop.org/show_bug.cgi?id=38844 --- Comment #6 from Stefan Weiberg stefan.weib...@germandev.org --- Is this EasyHack resolved and fixed? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work
https://bugs.freedesktop.org/show_bug.cgi?id=83572 --- Comment #7 from Maxim Monastirsky momonas...@gmail.com --- (In reply to comment #6) I think most people would be confused/unaware with the single/double clicking of a zoom mode button. As it is a mode, the mode should be functional until the mode is turned off. Yes it might be a bit confusing. There is even a proposal in Bug 39268 to get rid of those single/double click differences completely. Any ideas why it was removed and in which commit? I gave a link to that commit. The only functionality that i see missing from the statusbar and scrollbars is the zoom in mode, but its not that difficult to zoom into a particular area with the a combination of shift + scrollwheel (pan left/right), scrollwheel (pan up/down) and ctrl + scrollwheel (zoom in/out). Thinking of it again, you probably right. It's not worth keeping this button visible by default. Unfortunately i cant find that tooltip. :( You must enable extended tooltips at Tools-Options...-LibreOffice-General. Anyway you don't need the tooltip, as you can judge from its behavior - it always zoom by 200% of the current zoom. (Just a speculation - maybe those 200% are the reason it was made to work in one use way, because when you zoom 200% each time, it turns too much zoomed very quickly.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83604] New: : Pagination is incomprehensibel
https://bugs.freedesktop.org/show_bug.cgi?id=83604 Priority: medium Bug ID: 83604 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: : Pagination is incomprehensibel Severity: normal Classification: Unclassified OS: Windows (All) Reporter: bfrh...@hotmail.com Hardware: Other Status: UNCONFIRMED Version: 4.2.5.2 release Component: Writer Product: LibreOffice I imported a table to another document and it interfered with the page numbers and left one page out. It would not allow me to restore it. I don't know if it is a bug or just mysterious logic, but pagination within LibreOffice is diabolical and not user friendly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83604] : Pagination is incomprehensible
https://bugs.freedesktop.org/show_bug.cgi?id=83604 Bruce Rhind bfrh...@hotmail.com changed: What|Removed |Added Summary|: Pagination is |: Pagination is |incomprehensibel|incomprehensible -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues
https://bugs.freedesktop.org/show_bug.cgi?id=81234 Bug 81234 depends on bug 82078, which changed state. Bug 82078 Summary: FILEOPEN: RTF bold text spilling over to non-bold text https://bugs.freedesktop.org/show_bug.cgi?id=82078 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53224] Wrong zoom center
https://bugs.freedesktop.org/show_bug.cgi?id=53224 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added CC||paolobe...@gmail.com --- Comment #1 from Maxim Monastirsky momonas...@gmail.com --- *** Bug 68875 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68875] zooming with mouse doesn't consider mouse position
https://bugs.freedesktop.org/show_bug.cgi?id=68875 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Maxim Monastirsky momonas...@gmail.com --- *** This bug has been marked as a duplicate of bug 53224 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53224] Wrong zoom center
https://bugs.freedesktop.org/show_bug.cgi?id=53224 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=83588 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37601] zoom in to selected object or text cursor
https://bugs.freedesktop.org/show_bug.cgi?id=37601 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=83588 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83588] Scrollwheel zoom centers page in Impress and Draw
https://bugs.freedesktop.org/show_bug.cgi?id=83588 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added CC||momonas...@gmail.com See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=53224, ||https://bugs.freedesktop.or ||g/show_bug.cgi?id=37601 --- Comment #4 from Maxim Monastirsky momonas...@gmail.com --- (In reply to comment #3) I am pretty sure I already saw a bug or a discussion asking for this behavior. There is very similar Bug 53224, but it's an old bug while this one says it's a regression from 4.2 (which BTW I couldn't confirm). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83107] FILEOPEN: LibO 4.3 permanently damages existing presentation files
https://bugs.freedesktop.org/show_bug.cgi?id=83107 sergio.calleg...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from sergio.calleg...@gmail.com --- Well, I must confess I have never thought of this as unusual. I believed that the very purpose of having multiple slide masters was to let them be /different/. And this has always worked perfectly in Libreoffice up to 4.2. And used to work just fine in Openoffice too. When working with slides, the program was applying to the current slide those styles defined in the corresponding master page. This is also a very usual flow too, at least in the academy. One often needs to assemble in a single presentation some slides that have different sources. And if the original slides use different bullet point indentations, one wants to respect them, not to be compelled to reformat all of them by hand, just because the text does not fix or does not flow correctly. This means that different slides, corresponding to different master pages should be able to have different bullet point setting, with particular respect to their positioning. In my opinion, it makes sense to have the styles belong to the master page, not to the document. I wonder what the ODP format says in this respect. Is the current behavior a mis-interpretation of the standard? Or was the previous behavior a mis-interpretation? In any case can this be added to the release notes while in doubt, so that people who uses different master pages avoids LibO 4.3? Let me remark it again. The issue here is not that LibO 4.3 does not /show/ the document as LibO 4.3 used to do. The issue is that a roundtrip through LibO 4.3 permanently changes the presentation file in such a way that the old behavior cannot be obtained anymore, even in LibO 4.3. Even if the current behavior was the right one (and I don't think so, for sure it is more restricted and far less useful), people should have a chance to transition gracefully (or even to decide to stay at LibO 4.2 forever if they do not like it). Now, I see that also Apache Openoffice is broken in this respect. So, I believe that the regression was introduced there and carried over to Libreoffice. Should I report the bug to AOO rather than here? In any case, since it is not only me to see this behavioral change, I am marking the bug as confirmed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83588] Scrollwheel zoom centers page in Impress and Draw
https://bugs.freedesktop.org/show_bug.cgi?id=83588 --- Comment #5 from Maxim Monastirsky momonas...@gmail.com --- OK, got the point. If at some point the slide is not centered, it will center it on each zoom in/out. This is indeed different in 4.3 from 4.2. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82641] Currency drop-down ...
https://bugs.freedesktop.org/show_bug.cgi?id=82641 Stefan Weiberg stefan.weib...@germandev.org changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |stefan.weib...@germandev.or |desktop.org |g -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82641] Currency drop-down ...
https://bugs.freedesktop.org/show_bug.cgi?id=82641 --- Comment #1 from Stefan Weiberg stefan.weib...@germandev.org --- Hi Michael, I'd like to implement this feature. Can I include the include/sfx2/tbxctrl.hxx to the cui/source/inc/numfmt.hxx as well? That way I could introduce a new method in tbxctrl.hxx where all these Toolboxes seem to be managed instead of fiddling around in other header files. Thanks in advance for your help! Cheers, Stefan -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53300] Calc charts - Impossible to choose non-contiguous cells/lines/columns when editing data range
https://bugs.freedesktop.org/show_bug.cgi?id=53300 --- Comment #11 from luca m. luc...@gmail.com --- Confirming. This bug is present on 3.4.1 and 4.x. It is a very annoying bug, my colleagues has documents full of graphs and editing all of these is a very pain. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83588] Scrollwheel zoom centers page in Impress and Draw
https://bugs.freedesktop.org/show_bug.cgi?id=83588 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added CC||caol...@redhat.com --- Comment #6 from Maxim Monastirsky momonas...@gmail.com --- This change was made by Caolán in http://cgit.freedesktop.org/libreoffice/core/commit/?id=b179235f702e474b115ca479b603052f422346fd -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83107] FILEOPEN: LibO 4.3 permanently damages existing presentation files
https://bugs.freedesktop.org/show_bug.cgi?id=83107 --- Comment #5 from sergio.calleg...@gmail.com --- Just checked. All Openoffice versions since Apache have the issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74848] EDITING: Greyed-out menu bug when trying to insert formula
https://bugs.freedesktop.org/show_bug.cgi?id=74848 --- Comment #6 from Alexander Karatarakis danimothonl...@gmail.com --- Currently on LibO 4.2.6.3 under ubuntu 14.04 (with unity) and the issue is the same. Note again that this still does not occur under LXDE, so I would guess it has something to do with the LibO-unity interaction. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64499] Goalseek does not get answer although Excel has no problem on same sheet saved in xls format
https://bugs.freedesktop.org/show_bug.cgi?id=64499 --- Comment #22 from Owen Genat owen.ge...@gmail.com --- (In reply to comment #21) In the case of the use of the solver, I do not reproduce with version 4.3.2.0.0+ build at home under Ubuntu 14.04 x86-64. It works perfectly well (and find the solution as MS-Excel) ... So it would be useful to know how GoalSeek performs its calculation. Perhaps it could better if GoalSeek did the same computations as the default linear solver. Good point. I can also reproduce an accurate result using the Solver (linear algorithm) under GNU/Linux using: - v4.1.6.2 Build ID: 40ff705089295be5be0aae9b15123f687c05b0a - v4.2.6.3 Build ID: 3fd416d4c6db7d3204c17ce57a1d70f6e531ee21 - v4.3.1.2 Build ID: 958349dc3b25111dbca392fbc281a05559ef6848 ... so the difference has evidently been there for a while. I don't trust NLPSolver results in v4.4 at present due to bug 82288. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83107] FILEOPEN: LibO 4.3 permanently damages existing presentation files
https://bugs.freedesktop.org/show_bug.cgi?id=83107 --- Comment #6 from sergio.calleg...@gmail.com --- Furthermore, a funny thing is that if you start a document anew with LibO 4.3, the different styles in different masters, sorts of work (see demo2 attachment). However, at a certain point it stops working and often LibO 4.3 ends up crashing. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80650] lower case greek alphabet missing in localized Math symbol table
https://bugs.freedesktop.org/show_bug.cgi?id=80650 Valdas zmo...@hotmail.com changed: What|Removed |Added CC||zmo...@hotmail.com --- Comment #48 from Valdas zmo...@hotmail.com --- Confirmed in 4.3.1.2, locale LT (Lithuanian), system Kubuntu 14.04 (64b): lower-case beta is missing. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81811] ExtTextEngine (macro editor, spelling dialog) refuses to stay in column 1 during keyboard navigation
https://bugs.freedesktop.org/show_bug.cgi?id=81811 Jay Philips philip...@hotmail.com changed: What|Removed |Added OS|All |Mac OS X (All) Status|NEEDINFO|UNCONFIRMED CC||f...@openmailbox.org, ||ipla...@yahoo.co.uk, ||jore...@libreoffice.org Ever confirmed|1 |0 --- Comment #8 from Jay Philips philip...@hotmail.com --- Tested the issue in the spelling dialog and didnt have a problem there as well on Linux, also tested macro and spelling on 4.3.1 on Windows and no problem, so this seems to be mac specific. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83603] Help has no links
https://bugs.freedesktop.org/show_bug.cgi?id=83603 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Adolfo Jayme f...@libreoffice.org --- Provide a screenshot or at least a link to the page you ended up at. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83588] Scrollwheel zoom centers page in Impress and Draw
https://bugs.freedesktop.org/show_bug.cgi?id=83588 Jay Philips philip...@hotmail.com changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #7 from Jay Philips philip...@hotmail.com --- Look forward to knowing why Caolán added it. The behaviour in writer and calc is for zooming not to center the document. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83606] Data ranges in chart inside spreadsheet can't be modified/updated in the data range window
https://bugs.freedesktop.org/show_bug.cgi?id=83606 Francisco franciscoadriansanc...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=72814 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83608] New: Printers missing
https://bugs.freedesktop.org/show_bug.cgi?id=83608 Priority: medium Bug ID: 83608 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Printers missing Severity: critical Classification: Unclassified OS: Windows (All) Reporter: jerryedmond...@yahoo.com Hardware: All Status: UNCONFIRMED Version: 4.2.6.2 release Component: Printing and PDF export Product: LibreOffice Since upgrading to 4.2.6.3, my printers do not show up in Print or Printer Settings commands. I need to be able to print. None of the other programs that I print from are affected, and LibreOffice functioned until the update. Please advise. Thank you, Jerry -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74848] EDITING: Greyed-out menu bug when trying to insert formula
https://bugs.freedesktop.org/show_bug.cgi?id=74848 Alexander Karatarakis danimothonl...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83607] New: Crash - when moving with Shift down in specific document
https://bugs.freedesktop.org/show_bug.cgi?id=83607 Priority: medium Bug ID: 83607 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Crash - when moving with Shift down in specific document Severity: normal Classification: Unclassified OS: Linux (All) Reporter: c...@nouenoff.nl Hardware: x86 (IA32) Status: UNCONFIRMED Version: 4.4.0.0.alpha0+ Master Component: Writer Product: LibreOffice I'll attach a Writer document – place cursor in front of placeholder field START (5th line) – press Shift+Down twice (crossing page break) Crash My version Version: 4.4.0.0.alpha0+ Build ID: 1298c1d13572c6fbfbabb813b2d6843368c6df1f TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2014-08-29_00:42:19 Ubuntu 32 bits -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83608] Printers missing
https://bugs.freedesktop.org/show_bug.cgi?id=83608 --- Comment #1 from Jerry jerryedmond...@yahoo.com --- EDIT: No print settings AT ALL appear, not even print to file. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83607] Crash - when moving with Shift down in specific document
https://bugs.freedesktop.org/show_bug.cgi?id=83607 --- Comment #1 from Cor Nouws c...@nouenoff.nl --- Created attachment 105889 -- https://bugs.freedesktop.org/attachment.cgi?id=105889action=edit test document for crash -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83607] Crash - when moving with Shift down in specific document
https://bugs.freedesktop.org/show_bug.cgi?id=83607 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added CC||c...@nouenoff.nl Keywords||regression --- Comment #2 from Cor Nouws c...@nouenoff.nl --- doesn't crash in 4.3.1.2 regression -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83607] Crash - when moving with Shift down in specific document
https://bugs.freedesktop.org/show_bug.cgi?id=83607 --- Comment #3 from Cor Nouws c...@nouenoff.nl --- easier to reproduce: any selection with Shift+Arrow on page 2 makes the thing crash -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78529] Editing very slow with big picture on page
https://bugs.freedesktop.org/show_bug.cgi?id=78529 --- Comment #20 from Jay Philips philip...@hotmail.com --- The confirmed status is set as NEW. :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work
https://bugs.freedesktop.org/show_bug.cgi?id=83572 --- Comment #8 from Jay Philips philip...@hotmail.com --- (In reply to comment #7) Yes it might be a bit confusing. There is even a proposal in Bug 39268 to get rid of those single/double click differences completely. I think the behaviour for some buttons like format painter are fine, but think it would be confusing for a zoom mode, just as it is silly to have to click the shift button each time i've finished a shift, as most people pan multiple times. Any ideas why it was removed and in which commit? I gave a link to that commit. Was looking for the commit where it was removed. :) Thinking of it again, you probably right. It's not worth keeping this button visible by default. Yep it isnt worth having it visible by default as more useful buttons should be placed in the toolbar, which are easily understandable. I was going over the stats from OOo on the button usage and here are where all the clicks are going. .uno:ZoomPlus38.27% .uno:ZoomMinus21.21% .uno:Zoom100Percent14.96% .uno:ZoomPage11.13% .uno:ZoomPageWidth 7.76% .uno:ZoomOptimal 3.99% .uno:ZoomObjects 0.96% .uno:ZoomPanning 1.71% Its hard to judge .uno:ZoomPlus's click ratio, as i'd assume many users would be mistakenly click it multiple times thinking that it does zoom in (me included :D). What makes it quite confusing also is that the icon and tooltip are the same as in writer's page preview mode, but they have different behaviours. You must enable extended tooltips at Tools-Options...-LibreOffice-General. Anyway you don't need the tooltip, as you can judge from its behavior - it always zoom by 200% of the current zoom. (Just a speculation - maybe those 200% are the reason it was made to work in one use way, because when you zoom 200% each time, it turns too much zoomed very quickly.) Thanks for the info, though i enabled it and it still didnt appear. Maybe i need to restart LibO. I think the behaviour of zoom out to decrease by half is way to much. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83610] New: Not remembering adjustments after saving as .xlsx
https://bugs.freedesktop.org/show_bug.cgi?id=83610 Priority: medium Bug ID: 83610 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Not remembering adjustments after saving as .xlsx Severity: normal Classification: Unclassified OS: All Reporter: ba...@hotmail.com Hardware: All Status: UNCONFIRMED Version: 4.3.1.2 release Component: Spreadsheet Product: LibreOffice File save not saving date and time adjustments for columns. A date column is saved as a date, but the format is gone. It was dd MMM yy A time column is saved as a time, but the format is gone. It was hh:mm They are saved, but in another format. I have the problem on more PC''s, 32 bit, 64bit, win 7, win 8. Please correct. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83611] New: Other: Unable to install the update
https://bugs.freedesktop.org/show_bug.cgi?id=83611 Priority: medium Bug ID: 83611 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Other: Unable to install the update Severity: normal Classification: Unclassified OS: Windows (All) Reporter: daniel.bruc...@free.fr Hardware: Other Whiteboard: BSA PossibleRegression Status: UNCONFIRMED Version: 4.3.1.2 release Component: Installation Product: LibreOffice Created attachment 105890 -- https://bugs.freedesktop.org/attachment.cgi?id=105890action=edit displays i got Problem description: When I try to execute the msi file I am prompted to save again the downloaded file. When done, I get the same answer from the new saved file (and so on...). Steps to reproduce: 1. Execute msi file 2. Save ? 3. Cry Current behavior: install not done Expected behavior: Wow ! It works Operating System: Windows 7 Version: 4.3.1.2 release Last worked in: 4.2.1.1 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83612] New: Renumbering problems in master document
https://bugs.freedesktop.org/show_bug.cgi?id=83612 Priority: medium Bug ID: 83612 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Renumbering problems in master document Severity: normal Classification: Unclassified OS: All Reporter: daniel.grigo...@movidius.com Hardware: Other Status: UNCONFIRMED Version: unspecified Component: Writer Product: LibreOffice Created attachment 105891 -- https://bugs.freedesktop.org/attachment.cgi?id=105891action=edit sample master document Hi, For some reason figure numbers are no longer renumbered with respect to their order in the master document. In the sample files attached and also uploaded on Dropbox (https://www.dropbox.com/s/4100misqxkhxmtd/sample%20files.zip?dl=0) you will see that in the master document, Figure 1 from Subdocument 2, instead of being renumbered as Figure 2 is still Figure 1 in the master document despite being preceded in the master document by Figure 1 from Subdocument 1. What could be causing this problem? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56028] [UI]Zooming makes cell content disappear partly
https://bugs.freedesktop.org/show_bug.cgi?id=56028 --- Comment #4 from Teo91 mcavaller...@gmail.com --- Another (weak) workaround, at the beginning of a macro you can use something like: ThisComponent.CurrentController.ZoomValue = 100 It's still a poor solution, users might be disoriented by a zoom automatic change. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82107] FILEOPEN: RTF paragraph spacing not retained
https://bugs.freedesktop.org/show_bug.cgi?id=82107 Miklos Vajna vmik...@collabora.co.uk changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk |desktop.org | --- Comment #5 from Miklos Vajna vmik...@collabora.co.uk --- This is the same problem as bug 81944. *** This bug has been marked as a duplicate of bug 81944 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
