LibreOffice Gerrit News for core on 2014-10-11
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + Sane configure GStreamer handling in https://gerrit.libreoffice.org/11912 from Jan-Marek Glogowski about module build + fdo#39625 Make existing CppUnittests work in https://gerrit.libreoffice.org/11605 from Tobias Madl about module sal + accessibility: The if statement is redundant in https://gerrit.libreoffice.org/11890 from Robert Antoni Buj i Gelonch about module toolkit End of freshness + kill OUTPATH in https://gerrit.libreoffice.org/11908 from Norbert Thiebaud about module build, instsetoo_native, solenv + Work around IsNesting() of SwTxtAttrNesting vs. SwTxtInputFld confusion in https://gerrit.libreoffice.org/11909 from Stephan Bergmann about module sw + convert vcl StateChangedType to enum class in https://gerrit.libreoffice.org/11843 from Noel Grandin about module avmedia, cui, dbaccess, extensions, forms, framework, include, sc, sd, sfx2, starmath, svtools, svx, sw, vcl + fdo#84647 : Fixed default value for TickLableSkip value. in https://gerrit.libreoffice.org/11901 from sushil_shinde about module chart2, oox + fdo#75757: remove inheritance to std::map in https://gerrit.libreoffice.org/11899 from Takeshi Abe about module include, oox, sc * Merged changes on master for project core changed in the last 25 hours: + installer: populate installer::globals::[os,com,cpuname] in https://gerrit.libreoffice.org/11907 from Norbert Thiebaud + remove unused $variables{'os'} in https://gerrit.libreoffice.org/11906 from Norbert Thiebaud + fdo#65864: dont't traverse defs-nodes when in shape writing mode in https://gerrit.libreoffice.org/11793 from Christina Roßmanith + Fix fdo#84795 Menu, DropDown-List not disappears with right mouse click in https://gerrit.libreoffice.org/11881 from juegen funk + Scripting: Remove org package in https://gerrit.libreoffice.org/11868 from David Ostrovsky + xmerge: The if statement is redundant in https://gerrit.libreoffice.org/11894 from Robert Antoni Buj i Gelonch + runner: The if statement is redundant in https://gerrit.libreoffice.org/11895 from Robert Antoni Buj i Gelonch + unchecked call to getDeclaredMethod(String,Class?...) in https://gerrit.libreoffice.org/11882 from Robert Antoni Buj i Gelonch + jurt: use new exception constructors in https://gerrit.libreoffice.org/11892 from Robert Antoni Buj i Gelonch + bean: Use com.sun.star.uno.RuntimeException(Throwable thrwbl) in https://gerrit.libreoffice.org/11889 from Robert Antoni Buj i Gelonch + move TRANSPARENT #define from windows.h out of global namespace in https://gerrit.libreoffice.org/11880 from Noel Grandin * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + fdo#58194 - export DOCX Automatic indent as firstLine indent in https://gerrit.libreoffice.org/10425 from Joren De Cuyper + WIP (do not merge): remove custom impl of bidirectional list in https://gerrit.libreoffice.org/11001 from Chris Laplante + fdo#83003 Startcenter: No method for returnin Recent Docs in https://gerrit.libreoffice.org/11525 from Efe Gürkan Yalaman + fdo#82335. in https://gerrit.libreoffice.org/11555 from Sudarshan Rao + HIG-ification of GSoC Color Picker dialog in https://gerrit.libreoffice.org/11494 from Olivier Hallot + Perftest for loading autocorrect dictionaries (fdo#79761) in https://gerrit.libreoffice.org/11296 from Matúš Kukan + fdo#81956 : Rendering of vml group shape was wrong. in https://gerrit.libreoffice.org/11013 from sushil_shinde + fdo#79018: LO hangs while opening file. in https://gerrit.libreoffice.org/9564 from Yogesh Bharate + fdo#81426 : Data from header and footer is getting lost. in https://gerrit.libreoffice.org/10531 from Rajashri Udhoji + fdo#79541 :Corrupt: Shape enclosed within a floating table in https://gerrit.libreoffice.org/9914 from Rajashri Udhoji + fdo#80996:Fix for DataLabel not preserved for ColumnChart after RT in https://gerrit.libreoffice.org/10169 from Dushyant Bhalgami + fdo#77716 : Paragraph spacing is not preserved after RT. in https://gerrit.libreoffice.org/9197 from Tushar Bende + fdo#77121 Header / Footer positions not preserved after RT in https://gerrit.libreoffice.org/9235 from Priyanka Gaikwad Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/ooxml/factoryimpl_ns.py |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) New commits: commit f0e7d9eb64f1586daf9b54ee533c5ba0841e031a Author: Miklos Vajna vmik...@collabora.co.uk Date: Sat Oct 11 09:37:45 2014 +0200 writerfilter: drop support for simple list types without constants In other words, from now it's a must to map ST_Foo simple types to NS_ooxml::LN_something constants, and raw integers (which are hard to grep and hard to track down where are they used) are no longer an option. Change-Id: I968b27bca3f64f6f4a382b87e2dbc499a3132ea2 diff --git a/writerfilter/source/ooxml/factoryimpl_ns.py b/writerfilter/source/ooxml/factoryimpl_ns.py index 610fac0..407bb49 100644 --- a/writerfilter/source/ooxml/factoryimpl_ns.py +++ b/writerfilter/source/ooxml/factoryimpl_ns.py @@ -200,11 +200,8 @@ def factoryAttributeToResourceMap(nsNode): def idToLabel(idName): -if : in idName: -ns, ln = idName.split(':') -return NS_%s::LN_%s % (ns, ln) -else: -return idName +ns, ln = idName.split(':') +return NS_%s::LN_%s % (ns, ln) def appendValueData(values, name, value): ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/WrapPolygonHandler.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9abc8067365e394bdc7c4fe49f642207a86d13f5 Author: Miklos Vajna vmik...@collabora.co.uk Date: Sat Oct 11 09:36:16 2014 +0200 error C2677: binary '*' : no global operator found Change-Id: I13899545421fa710a590cde042e142cdb3293c7c diff --git a/writerfilter/source/dmapper/WrapPolygonHandler.cxx b/writerfilter/source/dmapper/WrapPolygonHandler.cxx index ffc7c59..73989b6 100644 --- a/writerfilter/source/dmapper/WrapPolygonHandler.cxx +++ b/writerfilter/source/dmapper/WrapPolygonHandler.cxx @@ -92,7 +92,7 @@ WrapPolygon::Pointer_t WrapPolygon::scale(const boost::rationallong rFraction while (aIt != aItEnd) { -awt::Point aPoint( boost::rational_castlong(long(aIt-X) * rFractionX), boost::rational_castlong(long(aIt-Y) * rFractionY) ); +awt::Point aPoint( boost::rational_castlong(rFractionX * long(aIt-X)), boost::rational_castlong(rFractionY * long(aIt-Y))); pResult-addPoint(aPoint); ++aIt; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/modules/installer/environment.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 75381109025694628d9c95a0391a38e1ab7f2938 Author: Chris Sherlock chris.sherloc...@gmail.com Date: Sat Oct 11 18:44:20 2014 +1100 Fix missing quote in environment.pm Change-Id: I6f91165b5c4bfd06a23224f2ed16818c7d74852b diff --git a/solenv/bin/modules/installer/environment.pm b/solenv/bin/modules/installer/environment.pm index 5e106b21..af9e4e2 100644 --- a/solenv/bin/modules/installer/environment.pm +++ b/solenv/bin/modules/installer/environment.pm @@ -109,7 +109,7 @@ sub set_global_environment_variables $installer::globals::compiler = $environment-{'OUTPATH'}; $installer::globals::os = $environment-{'OS'}; $installer::globals::com = $environment-{'COM'}; -$installer::globals::cpuname = $environment-{'CPUNAME}; +$installer::globals::cpuname = $environment-{'CPUNAME'}; if ( $ENV{'LAST_MINOR'} ) { $installer::globals::lastminor = $ENV{'LAST_MINOR'}; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: minutes of ESC call ...
Hi, Le 09/10/2014 16:59, Michael Meeks a écrit : [...] * Calc sorting issue (Kohei) + Filed by Jean-Baptiste Faure topic http://lists.freedesktop.org/archives/libreoffice/2014-October/063900.html + Both ways of sorting could be useful + was a pure bug-fix for a reference update issue (Kohei) AI: + back-port the patch to 4.3 - and chop the UI change out (Michael) + it may introduce new bugs, people still complaining vs. master (Kohei) + but no use-case to demonstrate that. + a unit test is there to test both options. JBF's concern: https://bugs.freedesktop.org/show_bug.cgi?id=81633#c40 + Isn't it a nightmare SUM(A1:A6), sort A2:10 ? (Michael) + no - doesn't handle range references (Kohei) + for single references we do do that, and limited case of range references + both sides seem to think they are right (Kohei) + https://bugs.freedesktop.org/show_bug.cgi?id=81309 Sorting should automatically adjust references. + https://bugs.freedesktop.org/show_bug.cgi?id=81633 Sorting shouldn't always automatically adjust references. + really annoying to go through lots of process to do this (Kohei) + people should be able to wait until 4.4 + bit of a translation nightmare variously (Bjoern / Michael) AI: + review perhaps turn the new feature off by default in 4.3 (Michael/Eike) AI: + get a clear use-case description of what doesn't work vs. master (JBF) I am currently doing a review of all bug reports related to sorting with references. For each bug I am trying to decide if it is a new case or if it is a duplicate of the main bug reports (fdo#45146, fdo#79441, fdo#81309 and fdo#81633) I identified up to now. Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - dbaccess/source
dbaccess/source/core/api/RowSet.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 85da280aaa29775cda87af128bfdf7d37f4708f2 Author: Lionel Elie Mamane lio...@mamane.lu Date: Mon Oct 6 12:22:03 2014 +0200 fdo#84658 on reexec, cancel modification before resetting IsModification state Change-Id: I878bff4d36ca1c2dd9474c937b03d0b366a6e911 Reviewed-on: https://gerrit.libreoffice.org/11824 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/dbaccess/source/core/api/RowSet.cxx b/dbaccess/source/core/api/RowSet.cxx index 216e2da..c136c03 100644 --- a/dbaccess/source/core/api/RowSet.cxx +++ b/dbaccess/source/core/api/RowSet.cxx @@ -561,6 +561,8 @@ void ORowSet::freeResources( bool _bComplete ) } m_aClones.clear(); +doCancelModification(); + m_aBookmark = Any(); m_bBeforeFirst = true; m_bAfterLast= false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - svtools/source
svtools/source/contnr/svimpbox.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit d3a227820040c25bb4ad3b28a9042e3f7d37eef0 Author: Caolán McNamara caol...@redhat.com Date: Thu Oct 9 13:50:20 2014 +0100 Resolves: fdo#82270 Grabbing focus can invalidate the entries Change-Id: Ie9b4f936cebdcf2a37e66abef456c6b0c0e26201 (cherry picked from commit fef9bf4e39b041c7f13e4d1584e3086068e781fc) Reviewed-on: https://gerrit.libreoffice.org/11878 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/svtools/source/contnr/svimpbox.cxx b/svtools/source/contnr/svimpbox.cxx index 79ae60b..d08660d 100644 --- a/svtools/source/contnr/svimpbox.cxx +++ b/svtools/source/contnr/svimpbox.cxx @@ -2049,6 +2049,8 @@ void SvImpLBox::MouseButtonDown( const MouseEvent rMEvt ) nCurTabPos = FIRST_ENTRY_TAB; nFlags = (~F_FILLING); pView-GrabFocus(); +//fdo#82270 Grabbing focus can invalidate the entries, re-fetch +pEntry = GetEntry(aPos); // the entry can still be invalid! if( !pEntry || !pView-GetViewData( pEntry )) return; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3-3' - download.lst external/nss
download.lst|2 external/nss/ExternalProject_nss.mk |2 external/nss/nss-linux-x86.patch.0 | 12 +- external/nss/nss-pem.patch | 17 +++ external/nss/nss.aix.patch | 133 ++--- external/nss/nss.patch | 160 ++-- external/nss/nss_macosx.patch | 41 - 7 files changed, 195 insertions(+), 172 deletions(-) New commits: commit 46243f91d867708b69b8106ef51c9991f0228e6b Author: Caolán McNamara caol...@redhat.com Date: Mon Sep 29 16:58:50 2014 +0100 bump nss from 3.15.3 to 3.16.5 Reviewed-on: https://gerrit.libreoffice.org/11700 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com (cherry picked from commit 726172e3eb8370125b89f853cebb1fb901547ebe) Signed-off-by: Michael Stahl mst...@redhat.com Conflicts: external/nss/ExternalProject_nss.mk external/nss/nspr-build-config.patch external/nss/nss_macosx.patch Change-Id: I8318982eb1cee1a694dbdd504e0ca106a29d807e (cherry picked from commit afd19a5ee99b1855bc2c2a48a29d2da16be883d1) Reviewed-on: https://gerrit.libreoffice.org/11898 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com Reviewed-by: Christian Lohmaier lohmaier+libreoff...@googlemail.com Tested-by: Christian Lohmaier lohmaier+libreoff...@googlemail.com diff --git a/download.lst b/download.lst index 9c0de03..6f26f2e 100644 --- a/download.lst +++ b/download.lst @@ -103,7 +103,7 @@ export MWAW_TARBALL := libmwaw-0.3.1.tar.bz2 export MYSQLCPPCONN_TARBALL := 0981bda6548a8c8233ffce2b6e4b2a23-mysql-connector-c++-1.1.0.tar.gz export MYTHES_TARBALL := 46e92b68e31e858512b680b3b61dc4c1-mythes-1.2.3.tar.gz export NEON_TARBALL := ff369e69ef0f0143beb5626164e87ae2-neon-0.29.5.tar.gz -export NSS_TARBALL := 06beb053e257d9e22641339c905c6eba-nss-3.15.3-with-nspr-4.10.2.tar.gz +export NSS_TARBALL := b279551b7638d0e36d1199548124c247-nss-3.16.5-with-nspr-4.10.6.tar.gz export ODFGEN_MD5SUM := c22c83c17cda0754382ada4e116594b7 export ODFGEN_TARBALL := libodfgen-0.1.1.tar.bz2 export OPENCOLLADA_MD5SUM := 4ca8a6ef0afeefc864e9ef21b9f14bd6 diff --git a/external/nss/ExternalProject_nss.mk b/external/nss/ExternalProject_nss.mk index 8fd1085..d88810f 100644 --- a/external/nss/ExternalProject_nss.mk +++ b/external/nss/ExternalProject_nss.mk @@ -16,7 +16,7 @@ $(eval $(call gb_ExternalProject_register_targets,nss,\ $(call gb_ExternalProject_get_state_target,nss,configure): $(call gb_ExternalProject_run,configure,\ - $(if $(filter MSC,$(COM)),LIB=$(ILIB)) \ + $(if $(filter MSC,$(COM)),INCLUDE=$(COMPATH)/include LIB=$(ILIB)) \ nspr/configure --includedir=$(call gb_UnpackedTarball_get_dir,nss)/mozilla/dist/out/include \ $(if $(CROSS_COMPILING),--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM)) \ $(if $(filter MSC-X86_64,$(COM)-$(CPUNAME)),--enable-64bit) \ diff --git a/external/nss/nss-linux-x86.patch.0 b/external/nss/nss-linux-x86.patch.0 index e23a786..95a489b 100644 --- a/external/nss/nss-linux-x86.patch.0 +++ b/external/nss/nss-linux-x86.patch.0 @@ -1,10 +1,10 @@ nss/lib/freebl/Makefile -+++ nss/lib/freebl/Makefile -@@ -195,6 +195,7 @@ - ifeq ($(CPU_ARCH),x86) - ASFILES = mpi_x86.s +--- nss/lib/freebl/Makefile2014-09-29 16:52:50.356265282 +0100 nss/lib/freebl/Makefile2014-09-29 16:53:01.823340024 +0100 +@@ -110,6 +110,7 @@ + ifeq (OS2,$(OS_TARGET)) + ASFILES = mpi_x86_os2.s DEFINES += -DMP_ASSEMBLY_MULTIPLY -DMP_ASSEMBLY_SQUARE +DEFINES += -DMP_USE_UINT_DIGIT DEFINES += -DMP_ASSEMBLY_DIV_2DX1D + DEFINES += -DMP_USE_UINT_DIGIT -DMP_NO_MP_WORD DEFINES += -DMP_CHAR_STORE_SLOW -DMP_IS_LITTLE_ENDIAN - # The floating point ECC code doesn't work on Linux x86 (bug 311432). diff --git a/external/nss/nss-pem.patch b/external/nss/nss-pem.patch index c2f34fe..c3f28bc 100644 --- a/external/nss/nss-pem.patch +++ b/external/nss/nss-pem.patch @@ -5230,7 +5230,7 @@ new file mode 100644 index 000..1179f2a --- /dev/null +++ b/b/nss/lib/ckfw/pem/rsawrapr.c -@@ -0,0 +1,808 @@ +@@ -0,0 +1,823 @@ +/* + * PKCS#1 encoding and decoding functions. + * This file is believed to contain no code licensed from other parties. @@ -5435,6 +5435,21 @@ index 000..1179f2a +} + +/* ++ * RSA block types ++ * ++ * The actual values are important -- they are fixed, *not* arbitrary. ++ * The explicit value assignments are not needed (because C would give ++ * us those same values anyway) but are included as a reminder... ++ */ ++typedef enum { ++RSA_BlockPrivate0 = 0, /* unused, really */ ++RSA_BlockPrivate = 1, /* pad for a private-key operation */ ++RSA_BlockPublic = 2,/* pad for a public-key operation */ ++RSA_BlockRaw = 4,
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - basctl/source
basctl/source/basicide/moduldl2.cxx | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) New commits: commit 0707938e49636759459ba20d94beb848825d826c Author: Caolán McNamara caol...@redhat.com Date: Thu Oct 9 15:40:08 2014 +0100 Resolves: fdo#60904 allow export of VBAProject xModLibContainerExport has a VBAProject entry but xDlgLibContainerExport doesn't, so just export the one we do have Change-Id: I15f7794904a5aff7679f2cf9fd654d741fd5cbe3 Reviewed-on: https://gerrit.libreoffice.org/11883 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/basctl/source/basicide/moduldl2.cxx b/basctl/source/basicide/moduldl2.cxx index 598a170..c04bbda 100644 --- a/basctl/source/basicide/moduldl2.cxx +++ b/basctl/source/basicide/moduldl2.cxx @@ -1104,8 +1104,14 @@ void LibPage::implExportLib( const OUString aLibName, const OUString aTargetUR if ( xModLibContainerExport.is() ) xModLibContainerExport-exportLibrary( aOULibName, aTargetURL, Handler ); -if ( xDlgLibContainerExport.is() ) -xDlgLibContainerExport-exportLibrary( aOULibName, aTargetURL, Handler ); +if (!xDlgLibContainerExport.is()) +return; +Referencecontainer::XNameAccess xNameAcc(xDlgLibContainerExport, UNO_QUERY); +if (!xNameAcc.is()) +return; +if (!xNameAcc-hasByName(aOULibName)) +return; +xDlgLibContainerExport-exportLibrary(aOULibName, aTargetURL, Handler); } // Implementation XCommandEnvironment ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sw/source
sw/source/core/bastyp/breakit.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b8100e1c75dbad75bffb64db94c2b40f75e2ed28 Author: Caolán McNamara caol...@redhat.com Date: Thu Oct 9 16:08:22 2014 +0100 Resolves: fdo#65823 crash on negative position in redlined word there is possibly something deeper wrong here I think after all, see 946ea643185af680508a0333f63c086ed3f454a3 Resolves: fdo#84649 as well but for now silence this and I can investigate further later Change-Id: I1323584d1f71c14634d56ad4e4a705496b1bd1c0 (cherry picked from commit d7418f8831acdff907d404c1701870b00e974df6) Reviewed-on: https://gerrit.libreoffice.org/11884 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/sw/source/core/bastyp/breakit.cxx b/sw/source/core/bastyp/breakit.cxx index 0e3aeea..9aec54d 100644 --- a/sw/source/core/bastyp/breakit.cxx +++ b/sw/source/core/bastyp/breakit.cxx @@ -105,7 +105,7 @@ sal_uInt16 SwBreakIt::GetRealScriptOfText( const OUString rTxt, sal_Int32 nPos --nPos; nScript = xBreak-getScriptType( rTxt, nPos ); sal_Int32 nChgPos = 0; -if ( i18n::ScriptType::WEAK == nScript nPos + 1 rTxt.getLength() ) +if (i18n::ScriptType::WEAK == nScript nPos = 0 nPos + 1 rTxt.getLength()) { // A weak character followed by a mark may be meant to combine with // the mark, so prefer the following character's script ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - connectivity/source dbaccess/qa dbaccess/source dbaccess/uiconfig
connectivity/source/commontools/DateConversion.cxx |6 +++--- connectivity/source/parse/sqlbison.y|8 dbaccess/qa/complex/dbaccess/SingleSelectQueryComposer.java |2 +- dbaccess/source/ui/querydesign/QueryDesignView.cxx |2 +- dbaccess/uiconfig/ui/specialsettingspage.ui |2 +- 5 files changed, 14 insertions(+), 6 deletions(-) New commits: commit 9398fe153ae1a7a26d53424b98c2e8190f236890 Author: Julien Nabet serval2...@yahoo.fr Date: Sun Oct 5 21:14:46 2014 +0200 fdo#84073: change ODBC/JDBC escapes to lowercase Change-Id: I19ce3acb9575fbef8273bbd84cb4dc322e101ac8 Reviewed-on: https://gerrit.libreoffice.org/11885 Reviewed-by: Julien Nabet serval2...@yahoo.fr Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/connectivity/source/commontools/DateConversion.cxx b/connectivity/source/commontools/DateConversion.cxx index 1f63db8..1cab87e 100644 --- a/connectivity/source/commontools/DateConversion.cxx +++ b/connectivity/source/commontools/DateConversion.cxx @@ -136,7 +136,7 @@ OUString DBTypeConversion::toSQLString(sal_Int32 eType, const Any _rVal, bool b if ( bOk ) { if (bQuote) -aRet.appendAscii({TS '); +aRet.appendAscii({ts '); aRet.append(DBTypeConversion::toDateTimeString(aDateTime)); if (bQuote) aRet.appendAscii('}); @@ -166,7 +166,7 @@ OUString DBTypeConversion::toSQLString(sal_Int32 eType, const Any _rVal, bool b bOk = _rVal = aDate; OSL_VERIFY_RES( bOk, DBTypeConversion::toSQLString: _rVal is not date!); if (bQuote) -aRet.appendAscii({D '); +aRet.appendAscii({d '); aRet.append(DBTypeConversion::toDateString(aDate)); if (bQuote) aRet.appendAscii('}); @@ -193,7 +193,7 @@ OUString DBTypeConversion::toSQLString(sal_Int32 eType, const Any _rVal, bool b bOk = _rVal = aTime; OSL_VERIFY_RES( bOk,DBTypeConversion::toSQLString: _rVal is not time!); if (bQuote) -aRet.appendAscii({T '); +aRet.appendAscii({t '); aRet.append(DBTypeConversion::toTimeString(aTime)); if (bQuote) aRet.appendAscii('}); diff --git a/connectivity/source/parse/sqlbison.y b/connectivity/source/parse/sqlbison.y index 231c9e1..a5b9f2f 100644 --- a/connectivity/source/parse/sqlbison.y +++ b/connectivity/source/parse/sqlbison.y @@ -4638,6 +4638,14 @@ OString OSQLParser::TokenIDToStr(sal_uInt32 nTokenID, const IParseContext* pCont aStr = yytname[YYTRANSLATE(nTokenID)]; if(aStr.startsWith(SQL_TOKEN_)) aStr = aStr.copy(10); + switch( nTokenID ) + { + case SQL_TOKEN_OJ: + case SQL_TOKEN_TS: + case SQL_TOKEN_T: + case SQL_TOKEN_D: + aStr = aStr.toAsciiLowerCase(); + } } return aStr; } diff --git a/dbaccess/qa/complex/dbaccess/SingleSelectQueryComposer.java b/dbaccess/qa/complex/dbaccess/SingleSelectQueryComposer.java index fc9a5a6..8d6eec6 100644 --- a/dbaccess/qa/complex/dbaccess/SingleSelectQueryComposer.java +++ b/dbaccess/qa/complex/dbaccess/SingleSelectQueryComposer.java @@ -51,7 +51,7 @@ public class SingleSelectQueryComposer extends CRMBasedTestCase + OR ( \ID\ = 3 AND \Postal\ = '6' AND \Address\ = '7' ) + OR ( \Address\ = '8' ) + OR ( \Postal\ = '9' ) -+ OR ( NOW( ) = {D '2010-01-01' } ); ++ OR ( NOW( ) = {d '2010-01-01' } ); private final static String INNERPRODUCTSQUERY = products (inner); diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx b/dbaccess/source/ui/querydesign/QueryDesignView.cxx index 1bfb73c..33bab8f 100644 --- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx +++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx @@ -1073,7 +1073,7 @@ namespace { // create outer join if ( bUseEscape ) -aStr += { OJ ; +aStr += { oj ; aStr += aJoin; if ( bUseEscape ) aStr += }; diff --git a/dbaccess/uiconfig/ui/specialsettingspage.ui
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/rtfexport/rtfexport.cxx |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) New commits: commit 7dc6c9af4ba313f054331f5130470d83d875bc16 Author: Miklos Vajna vmik...@collabora.co.uk Date: Sat Oct 11 14:46:57 2014 +0200 CppunitTest_sw_rtfexport: enable on Windows Change-Id: I232f13e8294ff1039519f943c3380f114f6821be diff --git a/sw/qa/extras/rtfexport/rtfexport.cxx b/sw/qa/extras/rtfexport/rtfexport.cxx index f0071cd..954dc2f 100644 --- a/sw/qa/extras/rtfexport/rtfexport.cxx +++ b/sw/qa/extras/rtfexport/rtfexport.cxx @@ -8,8 +8,6 @@ #include swmodeltestbase.hxx -#if !defined(WNT) - #include com/sun/star/awt/Gradient.hpp #include com/sun/star/document/XDocumentPropertiesSupplier.hpp #include com/sun/star/drawing/EnhancedCustomShapeParameterPair.hpp @@ -161,10 +159,10 @@ DECLARE_RTFEXPORT_TEST(testFdo38244, fdo38244.rtf) DECLARE_RTFEXPORT_TEST(testCommentsNested, comments-nested.odt) { uno::Referencebeans::XPropertySet xOuter(getProperty uno::Referencebeans::XPropertySet (getRun(getParagraph(1), 2), TextField), uno::UNO_QUERY); -CPPUNIT_ASSERT_EQUAL(OUString(Outer), getPropertyOUString(xOuter, Content)); +CPPUNIT_ASSERT_EQUAL(OUString(Outer), getPropertyOUString(xOuter, Content).trim()); uno::Referencebeans::XPropertySet xInner(getProperty uno::Referencebeans::XPropertySet (getRun(getParagraph(1), 4), TextField), uno::UNO_QUERY); -CPPUNIT_ASSERT_EQUAL(OUString(Inner), getPropertyOUString(xInner, Content)); +CPPUNIT_ASSERT_EQUAL(OUString(Inner), getPropertyOUString(xInner, Content).trim()); } DECLARE_RTFEXPORT_TEST(testMathAccents, math-accents.rtf) @@ -698,8 +696,6 @@ DECLARE_RTFEXPORT_TEST(testNumberingFont, numbering-font.rtf) CPPUNIT_ASSERT_EQUAL(OUString(Verdana), getPropertyOUString(xStyle, CharFontName)); } -#endif - CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 81008, which changed state. Bug 81008 Summary: DOCX export: first and subsequent header problems https://bugs.freedesktop.org/show_bug.cgi?id=81008 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: config_host.mk.in configure.ac external/lpsolve solenv/gbuild
config_host.mk.in |1 - configure.ac| 12 external/lpsolve/lp_solve_5.5.patch | 11 +++ solenv/gbuild/platform/macosx.mk|4 4 files changed, 3 insertions(+), 25 deletions(-) New commits: commit b592b3e89ee8cccd77dbe59a5d7965e3529c265e Author: Douglas Mencken dougmenc...@gmail.com Date: Mon Oct 6 01:53:47 2014 -0400 drop -Wno-long-double compiler flag new GCC compilers do not accept obsolete and totally removed in gcc 4.2 and later -Wno-long-double flag actually, it used to be Apple-only GCC extension for gcc=3.3 Change-Id: Ied3320cbd45915682b628c99bb0a168ea4753bb7 Reviewed-on: https://gerrit.libreoffice.org/11819 Reviewed-by: Douglas Mencken dougmenc...@gmail.com Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/config_host.mk.in b/config_host.mk.in index 11f8523..0fefbb0 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -248,7 +248,6 @@ export HAVE_GCC_FNO_DEFAULT_INLINE=@HAVE_GCC_FNO_DEFAULT_INLINE@ export HAVE_GCC_FNO_ENFORCE_EH_SPECS=@HAVE_GCC_FNO_ENFORCE_EH_SPECS@ export HAVE_GCC_FNO_INLINE=@HAVE_GCC_FNO_INLINE@ export HAVE_GCC_GGDB2=@HAVE_GCC_GGDB2@ -export HAVE_GCC_NO_LONG_DOUBLE=@HAVE_GCC_NO_LONG_DOUBLE@ export HAVE_GCC_PRAGMA_OPERATOR=@HAVE_GCC_PRAGMA_OPERATOR@ export HAVE_GCC_VISIBILITY_BROKEN=@HAVE_GCC_VISIBILITY_BROKEN@ export HAVE_GCC_VISIBILITY_FEATURE=@HAVE_GCC_VISIBILITY_FEATURE@ diff --git a/configure.ac b/configure.ac index 6b79026..f05034d 100644 --- a/configure.ac +++ b/configure.ac @@ -5748,17 +5748,6 @@ if test $GCC = yes; then AC_MSG_RESULT([no]) fi -AC_MSG_CHECKING([whether $CC supports -Wno-long-double]) -save_CFLAGS=$CFLAGS -CFLAGS=$CFLAGS -Werror -Wno-long-double -AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[ return 0; ]])],[ HAVE_GCC_NO_LONG_DOUBLE=TRUE ],[]) -CFLAGS=$save_CFLAGS -if test $HAVE_GCC_NO_LONG_DOUBLE = TRUE; then -AC_MSG_RESULT([yes]) -else -AC_MSG_RESULT([no]) -fi - AC_MSG_CHECKING([whether $CC supports -mno-avx]) save_CFLAGS=$CFLAGS CFLAGS=$CFLAGS -Werror -mno-avx @@ -5862,7 +5851,6 @@ if test $GCC = yes; then AC_LANG_POP([C++]) fi -AC_SUBST(HAVE_GCC_NO_LONG_DOUBLE) AC_SUBST(HAVE_GCC_AVX) AC_SUBST(HAVE_GCC_BUILTIN_ATOMIC) diff --git a/external/lpsolve/lp_solve_5.5.patch b/external/lpsolve/lp_solve_5.5.patch index 124fed8..2f0f07d 100644 --- a/external/lpsolve/lp_solve_5.5.patch +++ b/external/lpsolve/lp_solve_5.5.patch @@ -55,8 +55,8 @@ rm *.o 2/dev/null --- misc/build/lp_solve_5.5/lpsolve55/ccc.osx.orig Thu Jun 23 22:53:08 2005 -+++ misc/build/lp_solve_5.5/lpsolve55/ccc.osx Sun May 22 11:19:48 2011 -@@ -1,23 +1,36 @@ misc/build/lp_solve_5.5/lpsolve55/ccc.osx +@@ -1,23 +1,31 @@ src='../lp_MDO.c ../shared/commonlib.c ../shared/mmio.c ../shared/myblas.c ../ini.c ../fortify.c ../colamd/colamd.c ../lp_rlp.c ../lp_crash.c ../bfp/bfp_LUSOL/lp_LUSOL.c ../bfp/bfp_LUSOL/LUSOL/lusol.c ../lp_Hash.c ../lp_lib.c ../lp_wlp.c ../lp_matrix.c ../lp_mipbb.c ../lp_MPS.c ../lp_params.c ../lp_presolve.c ../lp_price.c ../lp_pricePSE.c ../lp_report.c ../lp_scale.c ../lp_simplex.c ../lp_SOS.c ../lp_utils.c ../yacc_read.c' -c=cc +c=$CC @@ -78,12 +78,7 @@ fi -opts='-idirafter /usr/include/sys -O3 -DINTEGERTIME -Wno-long-double' -+if [ $HAVE_GCC_NO_LONG_DOUBLE = YES ] ; then -+opts='-idirafter /usr/include/sys -O3 -DINTEGERTIME -Wno-long-double' -+else -+opts='-idirafter /usr/include/sys -O3 -DINTEGERTIME' -+fi -+ ++opts='-idirafter /usr/include/sys -O3 -DINTEGERTIME' -$c -s -c -I.. -I../shared -I../bfp -I../bfp/bfp_LUSOL -I../bfp/bfp_LUSOL/LUSOL -I../colamd $opts $def -DYY_NEVER_INTERACTIVE -DPARSER_LP -DINVERSE_ACTIVE=INVERSE_LUSOL -DRoleIsExternalInvEngine $src +$c $extra_cflags -s -c -I.. -I../shared -I../bfp -I../bfp/bfp_LUSOL -I../bfp/bfp_LUSOL/LUSOL -I../colamd $opts $def -DYY_NEVER_INTERACTIVE -DPARSER_LP -DINVERSE_ACTIVE=INVERSE_LUSOL -DRoleIsExternalInvEngine $extra_cdefs $src diff --git a/solenv/gbuild/platform/macosx.mk b/solenv/gbuild/platform/macosx.mk index 59d6a56..185fb26 100644 --- a/solenv/gbuild/platform/macosx.mk +++ b/solenv/gbuild/platform/macosx.mk @@ -57,10 +57,6 @@ gb_CXXFLAGS := \ #-Wshadow \ break in compiler headers already #-fsigned-char \ might be removed? -ifeq ($(HAVE_GCC_NO_LONG_DOUBLE),TRUE) -gb_CXXFLAGS += -Wno-long-double -endif - # these are to get g++ to switch to Objective-C++ mode # (see toolkit module for a case where it is necessary to do it this way) gb_OBJCXXFLAGS := -x objective-c++ -fobjc-exceptions ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/oox oox/source sc/source
include/oox/core/relations.hxx | 18 +- oox/source/core/relations.cxx | 15 --- oox/source/core/relationshandler.cxx |2 +- sc/source/filter/oox/worksheetfragment.cxx |6 +++--- 4 files changed, 29 insertions(+), 12 deletions(-) New commits: commit c51f77b1c02d03a4932d1b20ba6440465d265d48 Author: Takeshi Abe t...@fixedpoint.jp Date: Fri Oct 10 14:08:49 2014 +0900 fdo#75757: remove inheritance to std::map from oox::core::Relations. Change-Id: If2e0109a2ad6598436177b7638cb6d568fb2d3d6 Reviewed-on: https://gerrit.libreoffice.org/11899 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/include/oox/core/relations.hxx b/include/oox/core/relations.hxx index 38a99c8..e33cb93 100644 --- a/include/oox/core/relations.hxx +++ b/include/oox/core/relations.hxx @@ -68,11 +68,26 @@ struct Relation class Relations; typedef ::boost::shared_ptr Relations RelationsRef; -class OOX_DLLPUBLIC Relations : public ::std::map OUString, Relation +class OOX_DLLPUBLIC Relations { public: explicitRelations( const OUString rFragmentPath ); +size_t size() const { return maMap.size(); } +size_t count( const OUString rId ) const { return maMap.count( rId ); } +::std::map OUString, Relation ::const_iterator begin() const +{ +return maMap.begin(); +} +::std::map OUString, Relation ::const_iterator end() const +{ +return maMap.end(); +} +void insert( const ::std::map OUString, Relation ::value_type rVal ) +{ +maMap.insert( rVal ); +} + /** Returns the path of the fragment this relations collection is related to. */ const OUString getFragmentPath() const { return maFragmentPath; } @@ -99,6 +114,7 @@ public: OUString getFragmentPathFromFirstTypeFromOfficeDoc( const OUString rType ) const; private: +::std::map OUString, Relation maMap; OUString maFragmentPath; }; diff --git a/oox/source/core/relations.cxx b/oox/source/core/relations.cxx index 4122678..5c75b33 100644 --- a/oox/source/core/relations.cxx +++ b/oox/source/core/relations.cxx @@ -52,20 +52,21 @@ OUString createOfficeDocRelationTypeStrict(const OUString rType) } -Relations::Relations( const OUString rFragmentPath ) : -maFragmentPath( rFragmentPath ) +Relations::Relations( const OUString rFragmentPath ) +: maMap() +, maFragmentPath( rFragmentPath ) { } const Relation* Relations::getRelationFromRelId( const OUString rId ) const { -const_iterator aIt = find( rId ); -return (aIt == end()) ? 0 : aIt-second; +::std::map OUString, Relation ::const_iterator aIt = maMap.find( rId ); +return (aIt == maMap.end()) ? 0 : aIt-second; } const Relation* Relations::getRelationFromFirstType( const OUString rType ) const { -for( const_iterator aIt = begin(), aEnd = end(); aIt != aEnd; ++aIt ) +for( ::std::map OUString, Relation ::const_iterator aIt = maMap.begin(), aEnd = maMap.end(); aIt != aEnd; ++aIt ) if( aIt-second.maType.equalsIgnoreAsciiCase( rType ) ) return aIt-second; return 0; @@ -74,10 +75,10 @@ const Relation* Relations::getRelationFromFirstType( const OUString rType ) con RelationsRef Relations::getRelationsFromTypeFromOfficeDoc( const OUString rType ) const { RelationsRef xRelations( new Relations( maFragmentPath ) ); -for( const_iterator aIt = begin(), aEnd = end(); aIt != aEnd; ++aIt ) +for( ::std::map OUString, Relation ::const_iterator aIt = maMap.begin(), aEnd = maMap.end(); aIt != aEnd; ++aIt ) if( aIt-second.maType.equalsIgnoreAsciiCase( createOfficeDocRelationTypeTransitional(rType) ) || aIt-second.maType.equalsIgnoreAsciiCase( createOfficeDocRelationTypeStrict(rType) )) -(*xRelations)[ aIt-first ] = aIt-second; +xRelations-maMap[ aIt-first ] = aIt-second; return xRelations; } diff --git a/oox/source/core/relationshandler.cxx b/oox/source/core/relationshandler.cxx index 20adc05..4802b8f 100644 --- a/oox/source/core/relationshandler.cxx +++ b/oox/source/core/relationshandler.cxx @@ -76,7 +76,7 @@ Reference XFastContextHandler RelationsFragment::createFastChildContext( OSL_ENSURE( mxRelations-count( aRelation.maId ) == 0, RelationsFragment::createFastChildContext - relation identifier exists already ); -mxRelations-insert( Relations::value_type( aRelation.maId, aRelation ) ); +mxRelations-insert( ::std::map OUString, Relation ::value_type( aRelation.maId, aRelation ) ); } } break; diff --git a/sc/source/filter/oox/worksheetfragment.cxx b/sc/source/filter/oox/worksheetfragment.cxx index f93d56ee..9f2ff39 100644 --- a/sc/source/filter/oox/worksheetfragment.cxx +++ b/sc/source/filter/oox/worksheetfragment.cxx @@ -194,7
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sw/qa writerfilter/source
sw/qa/extras/rtfimport/data/fdo84679.rtf | 12 sw/qa/extras/rtfimport/rtfimport.cxx | 11 +++ writerfilter/source/rtftok/rtfdocumentimpl.cxx |9 + 3 files changed, 28 insertions(+), 4 deletions(-) New commits: commit a3cd122a8fbf5788d39491134c00e75149032783 Author: Miklos Vajna vmik...@collabora.co.uk Date: Fri Oct 10 16:21:29 2014 +0200 fdo#84679 RTF import: fix paragraph spacing handling in tables Regression from commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305: writerfilter RTF import: override style properties like Word, 2014-06-17), we failed to do the proper deduplication in buffered content, like tables. Fix this by adapting RTFDocumentImpl::replayBuffer() to RTFDocumentImpl::checkNeedPap(), which already did the proper deduplication. To be fair, the inconsistency was there earlier since 9f5263c477b82fef5aa9c3e79fb6af92aa049e24 (fdo#44736 RTF import: ignore direct formatting which equals to style, 2012-11-25), but it caused no real harm earlier. (cherry picked from commit e34906d20c9febc420b115fa2a8b171826dea0be) Change-Id: I0673408088d9d83768f0780ea92ece87913d03f3 Reviewed-on: https://gerrit.libreoffice.org/11914 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/sw/qa/extras/rtfimport/data/fdo84679.rtf b/sw/qa/extras/rtfimport/data/fdo84679.rtf new file mode 100644 index 000..64611be --- /dev/null +++ b/sw/qa/extras/rtfimport/data/fdo84679.rtf @@ -0,0 +1,12 @@ +{\rtf1 +{\stylesheet +{\ql \sa160\widctlpar\wrapdefault\aspalpha\aspnum\faauto\adjustright\rin0\lin0\itap0 \rtlch\fcs1 +\af31507\afs28\alang1054 \ltrch\fcs0 \fs22\lang1033\langfe2052\loch\f31506\hich\af31506\dbch\af31505\cgrid\langnp1033\langfenp2052 \snext0 \sqformat \spriority0 Normal;} +} +\pard\plain\par +\trowd +\clvertalt\clbrdrt\brdrs\brdrw10 \clbrdrl\brdrs\brdrw10 \clbrdrb\brdrs\brdrw10 \clbrdrr\brdrs\brdrw10\cellx3121 +\clvertalt\clbrdrt\brdrs\brdrw10 \clbrdrl\brdrs\brdrw10 \clbrdrb\brdrs\brdrw10 \clbrdrr\brdrs\brdrw10\cellx6238 +A1\cell A2\cell \row +\pard\plain\par +} diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx b/sw/qa/extras/rtfimport/rtfimport.cxx index 12c6b52..cc51a42 100644 --- a/sw/qa/extras/rtfimport/rtfimport.cxx +++ b/sw/qa/extras/rtfimport/rtfimport.cxx @@ -1887,6 +1887,17 @@ DECLARE_RTFIMPORT_TEST(testPictureWrapPolygon, picture-wrap-polygon.rtf) CPPUNIT_ASSERT_EQUAL(sal_Int32(convertTwipToMm100(-67)), getPropertysal_Int32(getShape(1), VertOrientPosition)); } +DECLARE_RTFIMPORT_TEST(testFdo84679, fdo84679.rtf) +{ +// The problem was that the paragraph in A1 had some bottom margin, but it should not. +uno::Referencetext::XTextTablesSupplier xTextTablesSupplier(mxComponent, uno::UNO_QUERY); +uno::Referencecontainer::XIndexAccess xTables(xTextTablesSupplier-getTextTables(), uno::UNO_QUERY); +uno::Referencetext::XTextTable xTable(xTables-getByIndex(0), uno::UNO_QUERY); +uno::Referencetext::XTextRange xCell(xTable-getCellByName(A1), uno::UNO_QUERY); +// This was 282. +CPPUNIT_ASSERT_EQUAL(static_castsal_Int32(0), getPropertysal_Int32(getParagraphOfText(1, xCell-getText()), ParaBottomMargin)); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx index 9f35f26..3fdc5ef 100644 --- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx +++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx @@ -445,7 +445,9 @@ void RTFDocumentImpl::setNeedSect(bool bNeedSect) writerfilter::ReferenceProperties::Pointer_t RTFDocumentImpl::getProperties(RTFSprms rAttributes, RTFSprms rSprms) { -int nStyle = m_aStates.top().nCurrentStyleIndex; +int nStyle = 0; +if (!m_aStates.empty()) +nStyle = m_aStates.top().nCurrentStyleIndex; RTFReferenceTable::Entries_t::iterator it = m_aStyleTableEntries.find(nStyle); if (it != m_aStyleTableEntries.end()) { @@ -1402,10 +1404,9 @@ void RTFDocumentImpl::replayBuffer(RTFBuffer_t rBuffer, rBuffer.pop_front(); if (boost::get0(aTuple) == BUFFER_PROPS) { +// Construct properties via getProperties() and not directly, to take care of deduplication. writerfilter::ReferenceProperties::Pointer_t const pProp( -new RTFReferenceProperties( -boost::get1(aTuple)-getAttributes(), -boost::get1(aTuple)-getSprms()) +getProperties(boost::get1(aTuple)-getAttributes(), boost::get1(aTuple)-getSprms()) ); Mapper().props(pProp); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: connectivity/qa
connectivity/qa/connectivity/tools/HsqlDatabase.java | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) New commits: commit 0bc6ea3637e279fa2807d8ee649fb33f1ae6da47 Author: Robert Antoni Buj i Gelonch robert@gmail.com Date: Sat Oct 11 16:16:09 2014 +0200 connectivity: Iterate over each Entry in a Map Enhanced for-loops Change-Id: Id4a340584fc727058f6e37c1f0d3c5887e931417 Reviewed-on: https://gerrit.libreoffice.org/11917 Reviewed-by: Noel Grandin noelgran...@gmail.com Tested-by: Noel Grandin noelgran...@gmail.com diff --git a/connectivity/qa/connectivity/tools/HsqlDatabase.java b/connectivity/qa/connectivity/tools/HsqlDatabase.java index b5a7e21..13b0f32 100644 --- a/connectivity/qa/connectivity/tools/HsqlDatabase.java +++ b/connectivity/qa/connectivity/tools/HsqlDatabase.java @@ -30,10 +30,9 @@ import com.sun.star.sdbcx.XTablesSupplier; import com.sun.star.uno.UnoRuntime; import helper.URLHelper; -import java.util.HashMap; -import java.util.Iterator; -import java.util.Set; import java.io.File; +import java.util.HashMap; +import java.util.Map; public class HsqlDatabase extends AbstractDatabase { @@ -162,14 +161,12 @@ public class HsqlDatabase extends AbstractDatabase createStatement.append(')'); } -final SetString foreignKeyTables = foreignKeys.keySet(); -for (final IteratorString foreignKey = foreignKeyTables.iterator(); -foreignKey.hasNext();) +for (Map.EntryString, String foreignKey : foreignKeys.entrySet()) { -final String foreignTable = foreignKey.next(); +final String foreignTable = foreignKey.getKey(); createStatement.append(, FOREIGN KEY (); -createStatement.append(foreignKeys.get(foreignTable)); +createStatement.append(foreignKey.getValue()); createStatement.append() REFERENCES \); createStatement.append(foreignTable); createStatement.append(\(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: avmedia/source cui/source dbaccess/source extensions/source forms/source framework/source include/svtools include/svx include/vcl sc/source sd/source sfx2/source starma
avmedia/source/viewer/mediawindow_impl.cxx|4 cui/source/dialogs/hangulhanjadlg.cxx |2 cui/source/dialogs/iconcdlg.cxx |2 cui/source/options/connpooloptions.cxx|2 cui/source/tabpages/autocdlg.cxx |2 cui/source/tabpages/numfmt.cxx|4 dbaccess/source/ui/browser/dataview.cxx |4 dbaccess/source/ui/control/dbtreelistbox.cxx |2 dbaccess/source/ui/dlg/indexdialog.cxx|4 dbaccess/source/ui/dlg/tablespage.cxx |2 dbaccess/source/ui/querydesign/JoinTableView.cxx |2 dbaccess/source/ui/querydesign/TableWindow.cxx|2 dbaccess/source/ui/querydesign/TableWindowTitle.cxx |2 extensions/source/propctrlr/browserpage.cxx |2 forms/source/richtext/richtextimplcontrol.hxx |2 forms/source/richtext/richtextvclcontrol.cxx |6 - forms/source/solar/control/navtoolbar.cxx |9 + framework/source/uielement/addonstoolbarmanager.cxx |2 framework/source/uielement/toolbarmanager.cxx |6 - include/svtools/wizdlg.hxx|2 include/svx/sidebar/PanelLayout.hxx |2 include/vcl/dialog.hxx|2 include/vcl/layout.hxx|2 include/vcl/syswin.hxx|2 include/vcl/tabctrl.hxx |2 include/vcl/window.hxx| 48 + sc/source/ui/app/inputwin.cxx |2 sc/source/ui/formdlg/dwfunctr.cxx |4 sc/source/ui/formdlg/privsplt.cxx |8 - sc/source/ui/miscdlgs/anyrefdg.cxx|2 sc/source/ui/namedlg/namemgrtable.cxx |2 sd/source/ui/animations/CustomAnimationPane.cxx |2 sd/source/ui/dlg/PaneDockingWindow.cxx| 10 +- sfx2/source/control/thumbnailview.cxx | 16 +-- sfx2/source/dialog/basedlgs.cxx |4 sfx2/source/dialog/dockwin.cxx|4 sfx2/source/dialog/recfloat.cxx |2 sfx2/source/dialog/srchdlg.cxx|2 sfx2/source/dialog/templdlg.cxx |4 sfx2/source/dialog/titledockwin.cxx |3 sfx2/source/view/frame2.cxx |2 sfx2/source/view/viewfrm2.cxx |2 starmath/source/toolbox.cxx |2 starmath/source/view.cxx |4 svtools/source/brwbox/brwbox1.cxx |2 svtools/source/brwbox/brwbox2.cxx | 14 +- svtools/source/brwbox/ebbcontrols.cxx |2 svtools/source/brwbox/editbrowsebox.cxx | 12 +- svtools/source/contnr/fileview.cxx|2 svtools/source/contnr/treelistbox.cxx |4 svtools/source/control/calendar.cxx |4 svtools/source/control/filectrl.cxx | 12 +- svtools/source/control/headbar.cxx| 10 +- svtools/source/control/ruler.cxx | 12 +- svtools/source/control/tabbar.cxx | 12 +- svtools/source/control/toolbarmenu.cxx|2 svtools/source/control/valueset.cxx | 16 +-- svtools/source/dialogs/wizdlg.cxx |2 svtools/source/table/tablecontrol.cxx |9 + svx/source/dialog/charmap.cxx |4 svx/source/dialog/dialcontrol.cxx |7 - svx/source/dialog/dlgctrl.cxx |8 - svx/source/dialog/fntctrl.cxx |4 svx/source/fmcomp/gridctrl.cxx| 16 +-- svx/source/sidebar/paragraph/ParaBulletsControl.cxx |4 svx/source/sidebar/paragraph/ParaNumberingControl.cxx |4 svx/source/tbxctrls/tbcontrl.cxx |4 sw/source/ui/dbui/mmoutputtypepage.cxx|2 sw/source/ui/fldui/inpdlg.cxx |2 sw/source/uibase/dbui/mailmergehelper.cxx |2 vcl/source/control/button.cxx | 88 +- vcl/source/control/combobox.cxx | 20 ++-- vcl/source/control/ctrl.cxx | 16 +-- vcl/source/control/edit.cxx | 22 ++-- vcl/source/control/fixed.cxx | 56 +-- vcl/source/control/group.cxx | 16 +-- vcl/source/control/ilstbox.cxx| 40 vcl/source/control/lstbox.cxx |
[Libreoffice-commits] core.git: avmedia/source basctl/source cui/source include/sfx2 include/vbahelper sc/source sd/source sfx2/source starmath/qa starmath/source svx/source sw/source vbahelper/source
avmedia/source/framework/mediaplayer.cxx |2 basctl/source/basicide/basicbox.cxx |2 basctl/source/basicide/basobj3.cxx|2 basctl/source/basicide/bastype2.cxx |2 basctl/source/basicide/bastypes.cxx |2 basctl/source/basicide/macrodlg.cxx | 12 +- basctl/source/basicide/moduldl2.cxx |8 - basctl/source/basicide/moduldlg.cxx | 18 ++-- basctl/source/basicide/tbxctl.cxx |2 cui/source/dialogs/SpellDialog.cxx|2 cui/source/dialogs/cuihyperdlg.cxx|8 - cui/source/dialogs/hldocntp.cxx |4 cui/source/dialogs/hlinettp.cxx |2 cui/source/dialogs/hlmailtp.cxx |2 cui/source/options/treeopt.cxx| 14 +-- cui/source/tabpages/tpcolor.cxx |4 include/sfx2/bindings.hxx | 42 +++--- include/sfx2/dispatch.hxx |4 include/sfx2/request.hxx | 11 +- include/vbahelper/vbahelper.hxx |2 sc/source/core/data/global.cxx|2 sc/source/ui/app/inputwin.cxx |6 - sc/source/ui/condformat/condformatdlgentry.cxx|2 sc/source/ui/dbgui/PivotLayoutDialog.cxx |2 sc/source/ui/dbgui/consdlg.cxx|2 sc/source/ui/dbgui/filtdlg.cxx|2 sc/source/ui/dbgui/sfiltdlg.cxx |2 sc/source/ui/dialogs/searchresults.cxx|2 sc/source/ui/docshell/docsh4.cxx |2 sc/source/ui/drawfunc/drtxtob.cxx |2 sc/source/ui/drawfunc/fuconstr.cxx|8 - sc/source/ui/drawfunc/fudraw.cxx |6 - sc/source/ui/drawfunc/fusel.cxx |4 sc/source/ui/drawfunc/futext.cxx | 14 +-- sc/source/ui/formdlg/dwfunctr.cxx |2 sc/source/ui/formdlg/formula.cxx |2 sc/source/ui/miscdlgs/solvrdlg.cxx|2 sc/source/ui/miscdlgs/tabopdlg.cxx|2 sc/source/ui/navipi/navipi.cxx| 10 +- sc/source/ui/navipi/scenwnd.cxx |2 sc/source/ui/pagedlg/areasdlg.cxx |2 sc/source/ui/sidebar/AlignmentPropertyPanel.cxx | 16 +-- sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx |6 - sc/source/ui/sidebar/CellBorderStyleControl.cxx | 14 +-- sc/source/ui/sidebar/CellLineStyleControl.cxx |4 sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx|6 - sc/source/ui/undo/undotab.cxx | 10 +- sc/source/ui/unoobj/viewuno.cxx |4 sc/source/ui/vba/vbaapplication.cxx |2 sc/source/ui/vba/vbahelper.cxx|4 sc/source/ui/vba/vbarange.cxx |2 sc/source/ui/view/cellsh3.cxx |2 sc/source/ui/view/formatsh.cxx|2 sc/source/ui/view/gridwin.cxx | 16 +-- sc/source/ui/view/preview.cxx |2 sc/source/ui/view/prevwsh.cxx |2 sc/source/ui/view/spelldialog.cxx |2 sc/source/ui/view/tabcont.cxx |6 - sc/source/ui/view/tabview5.cxx|4 sc/source/ui/view/tabvwsh3.cxx|2 sc/source/ui/view/tabvwsh4.cxx| 14 +-- sc/source/ui/view/tabvwsh5.cxx|2 sc/source/ui/view/tabvwsh9.cxx|2 sc/source/ui/view/tabvwshb.cxx|2 sc/source/ui/view/tabvwshe.cxx| 10 +- sc/source/ui/view/viewfun2.cxx|4 sc/source/ui/view/viewfun4.cxx|4 sc/source/ui/view/viewfun5.cxx|2 sc/source/ui/view/viewfun6.cxx|4 sc/source/ui/view/viewutil.cxx
[Libreoffice-commits] core.git: sd/source
sd/source/ui/app/strings.src |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 475df8db916a7bf16afd3e82808e0b59cbf71d5f Author: Samuel Mehrbrodt s.mehrbr...@gmail.com Date: Sat Oct 11 17:36:27 2014 +0200 fdo#84916 Fix string: Insert Audio/Video Change-Id: I76cd8502f9cb2af379dd732d2081feb094599aca diff --git a/sd/source/ui/app/strings.src b/sd/source/ui/app/strings.src index 6250df0..ac61eae 100644 --- a/sd/source/ui/app/strings.src +++ b/sd/source/ui/app/strings.src @@ -1197,7 +1197,7 @@ String STR_INSERT_PICTURE String STR_INSERT_MOVIE { - Text [ en-US ] = Insert Movie; + Text [ en-US ] = Insert Audio/Video; }; String STRING_DRAG_AND_DROP_PAGES ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/appl/app.cxx |2 ++ sfx2/source/appl/appserv.cxx |1 + 2 files changed, 3 insertions(+) New commits: commit f9695150942341a755a43996d4639eb623d7640b Author: Caolán McNamara caol...@redhat.com Date: Sat Oct 11 16:31:55 2014 +0100 too risky to dlclose basctl once opened e.g. use macro organizer for the first time and launch a macro, user event with handle to basctl function posted Change-Id: I2f0f4a7536f071926ea1bd6994f8178fbd4a796f diff --git a/sfx2/source/appl/app.cxx b/sfx2/source/appl/app.cxx index 78054f4..83794e8 100644 --- a/sfx2/source/appl/app.cxx +++ b/sfx2/source/appl/app.cxx @@ -494,6 +494,8 @@ IMPL_LINK( SfxApplication, GlobalBasicErrorHdl_Impl, StarBASIC*, pStarBasic ) // get symbol basicide_handle_basic_error pSymbol = (basicide_handle_basic_error) aMod.getFunctionSymbol(basicide_handle_basic_error); +aMod.release(); + // call basicide_handle_basic_error in basctl long nRet = pSymbol ? pSymbol( pStarBasic ) : 0; diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx index 0db333f..7d0f4c6 100644 --- a/sfx2/source/appl/appserv.cxx +++ b/sfx2/source/appl/appserv.cxx @@ -855,6 +855,7 @@ OUString ChooseMacro( const Reference XModel rxLimitToDocument, bool bChoose SAL_WARN_IF(!pSymbol, sfx.doc, SfxApplication::MacroOrganizer, no symbol!); if (!pSymbol) return OUString(); +aMod.release(); #else #define pSymbol basicide_choose_macro #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 14 commits - connectivity/source embeddedobj/source sw/source tools/source ucb/source uui/source vcl/source xmloff/source
connectivity/source/drivers/dbase/DTable.cxx | 10 +++-- embeddedobj/source/commonembedding/persistence.cxx |3 -- sw/source/uibase/docvw/PostItMgr.cxx |2 - sw/source/uibase/uiview/view2.cxx |2 - sw/source/uibase/uiview/viewport.cxx |4 +-- sw/source/uibase/wrtsh/wrtundo.cxx |4 +-- tools/source/generic/poly2.cxx |6 ++--- ucb/source/ucp/cmis/cmis_content.cxx |2 - ucb/source/ucp/cmis/cmis_content.hxx |3 +- ucb/source/ucp/cmis/cmis_repo_content.cxx |5 ++-- uui/source/iahndl-ssl.cxx |8 --- vcl/source/filter/wmf/wmfwr.cxx| 23 + vcl/source/window/menu.cxx |2 - xmloff/source/draw/propimp0.cxx| 20 +++--- xmloff/source/draw/ximpshap.cxx|2 - 15 files changed, 58 insertions(+), 38 deletions(-) New commits: commit 9aad656156fbf76288e8a281760e60f1eccc6622 Author: Caolán McNamara caol...@redhat.com Date: Sat Oct 11 17:14:53 2014 +0100 coverity#703952 Unchecked return value originally return was checked in commit c37f4bb94a119e4031796c097a35c1217e221e6c Date: Tue Nov 4 13:30:21 2003 + #112739# add breakLink method then use of bElExists was removed in commit aec29756d7e058b47dc8dcef79bc93c3e9c61928 Date: Fri Nov 14 14:24:28 2003 + #112923# ole implementation related changes at which point this line should have been removed, but it wasn't later at commit 00b1faf239dbf676178dcaa0d15a1678d1148a0d Author: Jens-Heiner Rechtien h...@openoffice.org INTEGRATION: CWS warnings01 (1.19.10); FILE MERGED 2005/11/03 10:31:40 cd 1.19.10.1: #i55991# Warning free code for gcc this still wasn't removed, just bElExists commented out Change-Id: I1af2635558cd4f47da06e148e45489f522e0183f diff --git a/embeddedobj/source/commonembedding/persistence.cxx b/embeddedobj/source/commonembedding/persistence.cxx index 260cce0..2da05bc 100644 --- a/embeddedobj/source/commonembedding/persistence.cxx +++ b/embeddedobj/source/commonembedding/persistence.cxx @@ -1852,9 +1852,6 @@ void SAL_CALL OCommonEmbeddedObject::breakLink( const uno::Reference embed::XSt if ( !xNameAccess.is() ) throw uno::RuntimeException(); //TODO -// detect entry existence -/*sal_Bool bElExists =*/ xNameAccess-hasByName( sEntName ); - m_bReadOnly = false; if ( m_xParentStorage != xStorage || !m_aEntryName.equals( sEntName ) ) commit 9863f7db9196a9d04790887a4c1be09240cd3d72 Author: Caolán McNamara caol...@redhat.com Date: Sat Oct 11 17:06:16 2014 +0100 coverity#735621 Division or modulo by zero Change-Id: Ic92bb6946495124d50e57c2c84995cae6465af92 diff --git a/vcl/source/filter/wmf/wmfwr.cxx b/vcl/source/filter/wmf/wmfwr.cxx index ddfa18f..2587823 100644 --- a/vcl/source/filter/wmf/wmfwr.cxx +++ b/vcl/source/filter/wmf/wmfwr.cxx @@ -1201,14 +1201,21 @@ void WMFWriter::WriteRecords( const GDIMetaFile rMTF ) nLen = aTemp.getLength(); boost::scoped_arraylong pDXAry(nLen ? new long[ nLen ] : NULL); nNormSize = pVirDev-GetTextArray( aTemp, pDXAry.get() ); -for ( i = 0; i ( nLen - 1 ); i++ ) -pDXAry[ i ] = pDXAry[ i ] * (sal_Int32)pA-GetWidth() / nNormSize; -if ( ( nLen = 1 ) || ( (sal_Int32)pA-GetWidth() == nNormSize ) ) -pDXAry.reset(); -aSrcLineInfo = LineInfo(); -SetAllAttr(); -if ( !WMFRecord_Escape_Unicode( pA-GetPoint(), aTemp, pDXAry.get() ) ) -WMFRecord_ExtTextOut( pA-GetPoint(), aTemp, pDXAry.get() ); +if (nLen nNormSize == 0) +{ +OSL_FAIL(Impossible div by 0 action: MetaStretchTextAction!); +} +else +{ +for ( i = 0; i ( nLen - 1 ); i++ ) +pDXAry[ i ] = pDXAry[ i ] * (sal_Int32)pA-GetWidth() / nNormSize; +if ( ( nLen = 1 ) || ( (sal_Int32)pA-GetWidth() == nNormSize ) ) +pDXAry.reset(); +aSrcLineInfo = LineInfo(); +SetAllAttr(); +if ( !WMFRecord_Escape_Unicode( pA-GetPoint(), aTemp, pDXAry.get() ) ) +WMFRecord_ExtTextOut( pA-GetPoint(), aTemp, pDXAry.get() ); +} } break; commit 88e1b0215b27c8897ca66509fa08b96d86023ef7 Author: Caolán McNamara caol...@redhat.com Date: Sat Oct 11 16:58:11 2014 +0100 coverity#735605 Division
[Libreoffice-commits] core.git: sc/uiconfig sd/uiconfig
sc/uiconfig/scalc/menubar/menubar.xml|1 + sd/uiconfig/sdraw/menubar/menubar.xml|1 + sd/uiconfig/simpress/menubar/menubar.xml |1 + 3 files changed, 3 insertions(+) New commits: commit 89c98b7d20d05ed0ee0f4d014295b430611b095f Author: Yousuf Philips philip...@hotmail.com Date: Sat Oct 11 16:47:38 2014 +0400 fdo#84912 - MENU: Addition of AutoSpellcheck to Tools menu Change-Id: I5e16f68f8565a26857f4ef233e06a002209e2566 Reviewed-on: https://gerrit.libreoffice.org/11915 Reviewed-by: Julien Nabet serval2...@yahoo.fr Tested-by: Julien Nabet serval2...@yahoo.fr diff --git a/sc/uiconfig/scalc/menubar/menubar.xml b/sc/uiconfig/scalc/menubar/menubar.xml index 69102a5..728f702 100644 --- a/sc/uiconfig/scalc/menubar/menubar.xml +++ b/sc/uiconfig/scalc/menubar/menubar.xml @@ -372,6 +372,7 @@ menu:menu menu:id=.uno:ToolsMenu menu:menupopup menu:menuitem menu:id=.uno:SpellDialog/ +menu:menuitem menu:id=.uno:SpellOnline/ menu:menu menu:id=.uno:LanguageMenu menu:menupopup menu:menuitem menu:id=.uno:HangulHanjaConversion/ diff --git a/sd/uiconfig/sdraw/menubar/menubar.xml b/sd/uiconfig/sdraw/menubar/menubar.xml index 77ae00d..871fb15 100644 --- a/sd/uiconfig/sdraw/menubar/menubar.xml +++ b/sd/uiconfig/sdraw/menubar/menubar.xml @@ -247,6 +247,7 @@ menu:menu menu:id=.uno:ToolsMenu menu:menupopup menu:menuitem menu:id=.uno:SpellDialog/ + menu:menuitem menu:id=.uno:SpellOnline/ menu:menu menu:id=.uno:LanguageMenu menu:menupopup menu:menuitem menu:id=.uno:SetLanguageAllTextMenu/ diff --git a/sd/uiconfig/simpress/menubar/menubar.xml b/sd/uiconfig/simpress/menubar/menubar.xml index 1b15c3f..f48774b 100644 --- a/sd/uiconfig/simpress/menubar/menubar.xml +++ b/sd/uiconfig/simpress/menubar/menubar.xml @@ -276,6 +276,7 @@ menu:menu menu:id=.uno:ToolsMenu menu:menupopup menu:menuitem menu:id=.uno:SpellDialog/ +menu:menuitem menu:id=.uno:SpellOnline/ menu:menu menu:id=.uno:LanguageMenu menu:menupopup menu:menuitem menu:id=.uno:SetLanguageAllTextMenu/ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/qa oox/source
chart2/qa/extras/chart2import.cxx | 23 + chart2/qa/extras/data/xlsx/chart-text-can-overlap.xlsx |binary oox/source/drawingml/chart/axismodel.cxx |2 - 3 files changed, 24 insertions(+), 1 deletion(-) New commits: commit 4027bc476a1df9df1924447795ddc2d8b7744e20 Author: sushil_shinde sushilshi...@libreoffice.org Date: Fri Oct 10 11:25:42 2014 +0530 fdo#84647 : Fixed default value for TickLableSkip value. 1. 'TextCanOverlap' property was stored as false if TickLableSkip is not equal to one. 2. For OOXML charts TickLableSkip can be between 1 to 9. 3. We can not apply zero or less than zero value to TickLableSkip. ( As per specification) 4. In axis model default value for TickLableSkip was zero which is incorrect. 5. Added unit test to check 'TextCanOverlap' property for chart. Change-Id: Ib3104b1d932f6e9376c149eabb201c8e9ad23da9 Reviewed-on: https://gerrit.libreoffice.org/11901 Reviewed-by: Kohei Yoshida libreoff...@kohei.us Tested-by: Kohei Yoshida libreoff...@kohei.us diff --git a/chart2/qa/extras/chart2import.cxx b/chart2/qa/extras/chart2import.cxx index b853466..3b1f1e7 100644 --- a/chart2/qa/extras/chart2import.cxx +++ b/chart2/qa/extras/chart2import.cxx @@ -18,9 +18,11 @@ #include com/sun/star/chart2/XInternalDataProvider.hpp #include com/sun/star/chart/XChartDataArray.hpp #include com/sun/star/drawing/FillStyle.hpp +#include com/sun/star/chart/XTwoAxisXSupplier.hpp #include com/sun/star/util/Color.hpp + class Chart2ImportTest : public ChartTest { public: @@ -53,6 +55,7 @@ public: void testFdo78080(); void testFdo54361(); void testAutoBackgroundXLSX(); +void testTextCanOverlapXLSX(); void testNumberFormatsXLSX(); void testTransparentBackground(OUString const filename); @@ -88,6 +91,7 @@ public: CPPUNIT_TEST(testFdo78080); CPPUNIT_TEST(testFdo54361); CPPUNIT_TEST(testAutoBackgroundXLSX); +CPPUNIT_TEST(testTextCanOverlapXLSX); CPPUNIT_TEST(testNumberFormatsXLSX); CPPUNIT_TEST_SUITE_END(); @@ -635,6 +639,25 @@ void Chart2ImportTest::testAutoBackgroundXLSX() (nColor 0x00FF) == 0x00FF); // highest 2 bytes are transparency which we ignore here. } +void Chart2ImportTest::testTextCanOverlapXLSX() +{ +// fdo#84647 : To check textoverlap value is imported correclty. +load(/chart2/qa/extras/data/xlsx/, chart-text-can-overlap.xlsx); +uno::Reference chart::XDiagram mxDiagram; +uno::Reference beans::XPropertySet xAxisProp; +bool textCanOverlap = false; +uno::Reference chart::XChartDocument xChartDoc ( getChartCompFromSheet( 0, mxComponent ), UNO_QUERY_THROW); +CPPUNIT_ASSERT(xChartDoc.is()); +mxDiagram.set(xChartDoc-getDiagram()); +CPPUNIT_ASSERT(mxDiagram.is()); +uno::Reference chart::XAxisXSupplier xAxisXSupp( mxDiagram, uno::UNO_QUERY ); +CPPUNIT_ASSERT(xAxisXSupp.is()); +xAxisProp = xAxisXSupp-getXAxis(); +xAxisProp-getPropertyValue(TextCanOverlap) = textCanOverlap; +// Expected value of 'TextCanOverlap' is true +CPPUNIT_ASSERT(textCanOverlap); +} + void Chart2ImportTest::testNumberFormatsXLSX() { load(/chart2/qa/extras/data/xlsx/, number-formats.xlsx); diff --git a/chart2/qa/extras/data/xlsx/chart-text-can-overlap.xlsx b/chart2/qa/extras/data/xlsx/chart-text-can-overlap.xlsx new file mode 100644 index 000..59f907d Binary files /dev/null and b/chart2/qa/extras/data/xlsx/chart-text-can-overlap.xlsx differ diff --git a/oox/source/drawingml/chart/axismodel.cxx b/oox/source/drawingml/chart/axismodel.cxx index d4163bc..cbd66b7 100644 --- a/oox/source/drawingml/chart/axismodel.cxx +++ b/oox/source/drawingml/chart/axismodel.cxx @@ -46,7 +46,7 @@ AxisModel::AxisModel( sal_Int32 nTypeId ) : mnMinorTimeUnit( XML_days ), mnOrientation( XML_minMax ), mnTickLabelPos( XML_nextTo ), -mnTickLabelSkip( 0 ), +mnTickLabelSkip( 1 ), mnTickMarkSkip( 0 ), mnTypeId( nTypeId ), mbAuto( false ), ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'ports/macosx10.5/master' - 411 commits - accessibility/source android/experimental avmedia/Module_avmedia.mk avmedia/source basctl/source basegfx/CppunitTest_ba
Rebased ref, commits from common ancestor: commit dc963c98b35bdc623f6877dfcb62c97c236aa33f Author: Douglas Mencken dougmenc...@gmail.com Date: Wed Oct 8 10:38:28 2014 -0400 use GNU objc ABI/runtime instead of NeXT ABI/runtime when compiler is GCC with workaround for cannot find interface declaration for NXConstantString also, include objc/objc-api.h when OBJC_EXPORT is not defined Change-Id: I5f0df322435be8244d372642dee1c21d783306f1 diff --git a/sal/osl/unx/system.h b/sal/osl/unx/system.h index d952518..143a1bd 100644 --- a/sal/osl/unx/system.h +++ b/sal/osl/unx/system.h @@ -215,6 +215,9 @@ #ifdef MACOSX #define __OPENTRANSPORTPROVIDERS__ // these are already defined #define TimeValue CFTimeValue // Do not conflict with TimeValue in sal/inc/osl/time.h +#ifndef OBJC_EXPORT +#include objc/objc-api.h +#endif #include Carbon/Carbon.h #undef TimeValue # ifndef ETIME diff --git a/solenv/gbuild/platform/macosx.mk b/solenv/gbuild/platform/macosx.mk index 185fb26..52a0b5a 100644 --- a/solenv/gbuild/platform/macosx.mk +++ b/solenv/gbuild/platform/macosx.mk @@ -59,9 +59,21 @@ gb_CXXFLAGS := \ # these are to get g++ to switch to Objective-C++ mode # (see toolkit module for a case where it is necessary to do it this way) -gb_OBJCXXFLAGS := -x objective-c++ -fobjc-exceptions - -gb_OBJCFLAGS := -x objective-c -fobjc-exceptions +gb_OBJCXXFLAGS := \ + -x objective-c++ \ + -fobjc-exceptions \ + $(if $(filter TRUE,$(COM_GCC_IS_CLANG)),,\ + -fgnu-runtime \ + -fconstant-string-class=NSConstantString \ + ) + +gb_OBJCFLAGS := \ + -x objective-c \ + -fobjc-exceptions \ + $(if $(filter TRUE,$(COM_GCC_IS_CLANG)),,\ + -fgnu-runtime \ + -fconstant-string-class=NSConstantString \ + ) # LinkTarget class diff --git a/vcl/inc/osx/a11yfactory.h b/vcl/inc/osx/a11yfactory.h index c739f3e..4e92126 100644 --- a/vcl/inc/osx/a11yfactory.h +++ b/vcl/inc/osx/a11yfactory.h @@ -20,6 +20,10 @@ #ifndef INCLUDED_VCL_INC_OSX_A11YFACTORY_H #define INCLUDED_VCL_INC_OSX_A11YFACTORY_H +#ifndef OBJC_EXPORT +#include objc/objc-api.h +#endif + #include osxvcltypes.h #include a11ywrapper.h #include com/sun/star/accessibility/XAccessibleContext.hpp diff --git a/vcl/inc/osx/osxvcltypes.h b/vcl/inc/osx/osxvcltypes.h index f1659c4..96edccc 100644 --- a/vcl/inc/osx/osxvcltypes.h +++ b/vcl/inc/osx/osxvcltypes.h @@ -21,6 +21,9 @@ #define INCLUDED_VCL_INC_OSX_OSXVCLTYPES_H #include premac.h +#ifndef OBJC_EXPORT +#include objc/objc-api.h +#endif #import Cocoa/Cocoa.h #import AppKit/NSEvent.h #include postmac.h diff --git a/vcl/inc/osx/printview.h b/vcl/inc/osx/printview.h index e396bd8..b63900b 100644 --- a/vcl/inc/osx/printview.h +++ b/vcl/inc/osx/printview.h @@ -21,6 +21,9 @@ #define INCLUDED_VCL_INC_OSX_PRINTVIEW_H #include premac.h +#ifndef OBJC_EXPORT +#include objc/objc-api.h +#endif #include Cocoa/Cocoa.h #include postmac.h diff --git a/vcl/inc/osx/saldata.hxx b/vcl/inc/osx/saldata.hxx index 413754b..1665b06 100644 --- a/vcl/inc/osx/saldata.hxx +++ b/vcl/inc/osx/saldata.hxx @@ -23,6 +23,9 @@ #include config_features.h #include premac.h +#ifndef OBJC_EXPORT +#include objc/objc-api.h +#endif #include Cocoa/Cocoa.h #include postmac.h diff --git a/vcl/inc/osx/salinst.h b/vcl/inc/osx/salinst.h index 8a88a26..4efcbe0 100644 --- a/vcl/inc/osx/salinst.h +++ b/vcl/inc/osx/salinst.h @@ -25,6 +25,9 @@ #include osl/conditn.h #ifdef MACOSX +#ifndef OBJC_EXPORT +#include objc/objc-api.h +#endif #include osx/osxvcltypes.h #endif diff --git a/vcl/inc/osx/saltimer.h b/vcl/inc/osx/saltimer.h index b751a81..e663c65 100644 --- a/vcl/inc/osx/saltimer.h +++ b/vcl/inc/osx/saltimer.h @@ -21,6 +21,9 @@ #define INCLUDED_VCL_INC_OSX_SALTIMER_H #include premac.h +#ifndef OBJC_EXPORT +#include objc/objc-api.h +#endif #include Cocoa/Cocoa.h #include postmac.h diff --git a/vcl/inc/osx/vclnsapp.h b/vcl/inc/osx/vclnsapp.h index 541b509..675cacc 100644 --- a/vcl/inc/osx/vclnsapp.h +++ b/vcl/inc/osx/vclnsapp.h @@ -23,6 +23,9 @@ #include config_features.h #include premac.h +#ifndef OBJC_EXPORT +#include objc/objc-api.h +#endif #include Cocoa/Cocoa.h #include postmac.h diff --git a/vcl/inc/quartz/utils.h b/vcl/inc/quartz/utils.h index e408250..ac264ec 100644 --- a/vcl/inc/quartz/utils.h +++ b/vcl/inc/quartz/utils.h @@ -23,6 +23,9 @@ #include iostream #include premac.h +#ifndef OBJC_EXPORT +#include objc/objc-api.h +#endif #include CoreFoundation/CoreFoundation.h #include Foundation/Foundation.h #ifdef MACOSX commit 17bc7f2616e095de0cd7715b9374ec07c9ac214f Author: Douglas Mencken dougmenc...@gmail.com Date: Sun Oct 5 18:02:00 2014 -0400 vcl-quartz: restore conditional code for SDKs 10.8 Fixes: fatal error: CoreGraphics/CoreGraphics.h: No such file or directory Related commit: 4fa8282816cb39692678e9da6b6693e821a3039b Change-Id:
[Libreoffice-commits] core.git: sc/source
sc/source/ui/undo/undoblk3.cxx | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) New commits: commit 424bfaa773e58d6b609ac7f64907db4b542d1315 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Sat Oct 11 14:18:10 2014 -0400 fdo#80846: Broadcast changes before EndUndo(). EndUndo() calls PostDataChanged(), which renders the recalculated formula cells. Not broadcasting before EndUndo causes some dependent formula cells to not get recalculated. This one unfortunately is not currently unit-testable as this behavior depends on the presence of ScTabViewShell Change-Id: I86288608b7f2627cda7c74be27a18029832775ef diff --git a/sc/source/ui/undo/undoblk3.cxx b/sc/source/ui/undo/undoblk3.cxx index 49e2280..de1f238 100644 --- a/sc/source/ui/undo/undoblk3.cxx +++ b/sc/source/ui/undo/undoblk3.cxx @@ -170,12 +170,20 @@ void ScUndoDeleteContents::DoChange( const bool bUndo ) SetChangeTrack(); } +if (nFlags IDF_CONTENTS) +{ +// Broadcast only when the content changes. fdo#74687 +if (mpDataSpans) +BroadcastChanges(*mpDataSpans); +else +BroadcastChanges(aRange); +} + ScTabViewShell* pViewShell = ScTabViewShell::GetActiveViewShell(); if ( !( (pViewShell) pViewShell-AdjustRowHeight( aRange.aStart.Row(), aRange.aEnd.Row() ) ) ) /*A*/ pDocShell-PostPaint( aRange, PAINT_GRID | PAINT_EXTRAS, nExtFlags ); -pDocShell-PostDataChanged(); if (pViewShell) pViewShell-CellContentChanged(); @@ -188,16 +196,9 @@ void ScUndoDeleteContents::Undo() DoChange( true ); EndUndo(); -if (nFlags IDF_CONTENTS) -{ -// Broadcast only when the content changes. fdo#74687 -if (mpDataSpans) -BroadcastChanges(*mpDataSpans); -else -BroadcastChanges(aRange); -} HelperNotifyChanges::NotifyIfChangesListeners(*pDocShell, aRange); +// pDocShell-PostDataChanged(); } void ScUndoDeleteContents::Redo() @@ -206,10 +207,6 @@ void ScUndoDeleteContents::Redo() DoChange( false ); EndRedo(); -if (nFlags IDF_CONTENTS) -// Broadcast only when the content changes. fdo#74687 -BroadcastChanges(aRange); - HelperNotifyChanges::NotifyIfChangesListeners(*pDocShell, aRange); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/undo/undoblk3.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit b384ee5442a18f3e7678a868e2cfe82782afaeb7 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Sat Oct 11 14:22:42 2014 -0400 Cleanup. Change-Id: Ic39043d0453830d348ac3bc8a027b862e4bbdfd8 diff --git a/sc/source/ui/undo/undoblk3.cxx b/sc/source/ui/undo/undoblk3.cxx index de1f238..661b434 100644 --- a/sc/source/ui/undo/undoblk3.cxx +++ b/sc/source/ui/undo/undoblk3.cxx @@ -196,9 +196,7 @@ void ScUndoDeleteContents::Undo() DoChange( true ); EndUndo(); - HelperNotifyChanges::NotifyIfChangesListeners(*pDocShell, aRange); -// pDocShell-PostDataChanged(); } void ScUndoDeleteContents::Redo() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/headless
vcl/headless/svpgdi.cxx | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) New commits: commit 6ba7f47de32074895b830e1ef3682fa1d0d1b6be Author: Michael Meeks michael.me...@collabora.com Date: Thu Oct 2 16:55:14 2014 +0100 vcl: whitespace cleanup. Change-Id: I0e61ecfc32f13bba0fa992689604c8b79e6139e9 diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx index ef8f126..6f993db 100644 --- a/vcl/headless/svpgdi.cxx +++ b/vcl/headless/svpgdi.cxx @@ -510,28 +510,28 @@ bool SvpSalGraphics::drawPolyLine( basegfx::B2DLineJoin /*eJoin*/, com::sun::star::drawing::LineCap /*eLineCap*/) { -// TODO: implement and advertise OutDevSupport_B2DDraw support -return false; +// TODO: implement and advertise OutDevSupport_B2DDraw support +return false; } bool SvpSalGraphics::drawPolyLineBezier( sal_uInt32, - const SalPoint*, - const sal_uInt8* ) + const SalPoint*, + const sal_uInt8* ) { return false; } bool SvpSalGraphics::drawPolygonBezier( sal_uInt32, -const SalPoint*, -const sal_uInt8* ) +const SalPoint*, +const sal_uInt8* ) { return false; } bool SvpSalGraphics::drawPolyPolygonBezier( sal_uInt32, -const sal_uInt32*, -const SalPoint* const*, -const sal_uInt8* const* ) +const sal_uInt32*, +const SalPoint* const*, +const sal_uInt8* const* ) { return false; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'private/mmeeks/icontest'
New branch 'private/mmeeks/icontest' available with the following commits: commit 92f15e5352df09fc1a59dc8a0e787c53581e94a2 Author: Michael Meeks michael.me...@collabora.com Date: Sat Oct 11 22:12:51 2014 +0100 icontext: get OpenGL setup working (for me). Oddly I have to have a different size to see anything (huh). Change-Id: I1a8cfddd96266886f0fc667a7558991c2451a7b0 commit 02ff83a49e2f966e5699ec264a9c64834c4d0cac Author: Michael Meeks michael.me...@collabora.com Date: Sat Oct 11 21:42:49 2014 +0100 icontest: replicate drawinglayer on-demand scaling behavior. Change-Id: Ieedf15843d5a423e36497d0c5010cefdebaeaf10 commit b0caf08c6bb79382cc279dacddf192080497ab06 Author: Michael Meeks michael.me...@collabora.com Date: Thu Oct 2 16:55:14 2014 +0100 vcl: whitespace cleanup. Change-Id: I0e61ecfc32f13bba0fa992689604c8b79e6139e9 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'private/mmeeks/icontest' - 2 commits - vcl/source vcl/workben
vcl/source/bitmap/bitmapscalesuper.cxx | 10 + vcl/workben/icontest.cxx | 36 ++--- 2 files changed, 39 insertions(+), 7 deletions(-) New commits: commit 54cab7f193d5dc6b13350c78695fd3f4485476bd Author: Michael Meeks michael.me...@collabora.com Date: Sat Oct 11 23:24:42 2014 +0100 icontest: allow initial scaling to test direct bitmap rendering path. Change-Id: Id670bfd4af8bfabe01b5b006ce5c9ccf029dfb6c diff --git a/vcl/workben/icontest.cxx b/vcl/workben/icontest.cxx index 7e2fd41..a8df1c9 100644 --- a/vcl/workben/icontest.cxx +++ b/vcl/workben/icontest.cxx @@ -54,7 +54,6 @@ namespace { return (double)aValue.Seconds + (double)aValue.Nanosec / (1000*1000*1000); } - } class MyWorkWindow : public WorkWindow @@ -97,12 +96,15 @@ void MyWorkWindow::Paint( const Rectangle /* rRect */ ) OutputDevice rDev = *this; // yes indeed drawinglayer re-scales the image per render etc. -BitmapEx aScaledBitamp( maGraphic.GetBitmapEx() ); -aScaledBitamp.Scale( maDestinationSize, BMP_SCALE_SUPER); +BitmapEx aScaledBitmap( maGraphic.GetBitmapEx() ); +aScaledBitmap.Scale( maDestinationSize, BMP_SCALE_SUPER); std::cerr == Paint! nPaintCount++ (vcl) GetSizePixel() getTimeNow() - nStartTime image of size maGraphic.GetBitmapEx().GetSizePixel() scale to size maDestinationSize std::endl; -rDev.DrawBitmapEx( Point( 0, 0 ), aScaledBitamp ); +rDev.DrawBitmapEx( Point( 0, 0 ), aScaledBitmap ); + +if (nPaintCount 100) +Application::Quit(); Invalidate( INVALIDATE_CHILDREN ); // trigger re-render } @@ -112,12 +114,20 @@ void MyWorkWindow::Paint( const Rectangle /* rRect */ ) void MyOpenGLWorkWindow::Paint( const Rectangle ) { std::cerr == Paint! nPaintCount++ (OpenGL) GetSizePixel() getTimeNow() - nStartTime std::endl; + OpenGLContext aCtx = mpOpenGLWindow-getContext(); aCtx.makeCurrent(); CHECK_GL_ERROR(); aCtx.requestLegacyContext(); CHECK_GL_ERROR(); +if (aCtx.supportMultiSampling()) +{ +// doesn't work but worth a try ... +glEnable(GL_MULTISAMPLE); +CHECK_GL_ERROR(); +} + if (!mbHaveTexture) LoadTexture(); @@ -143,7 +153,7 @@ void MyOpenGLWorkWindow::Paint( const Rectangle ) glPushMatrix(); CHECK_GL_ERROR(); -glTranslatef(-1, -1, 0); +glTranslatef(-1, -0.5, 0); glScalef(2, 2, 2); if (mnTextureAspect = ((float) WIDTH) / HEIGHT) @@ -170,6 +180,9 @@ void MyOpenGLWorkWindow::Paint( const Rectangle ) aCtx.swapBuffers(); CHECK_GL_ERROR(); +if (nPaintCount 100) +Application::Quit(); + Invalidate( INVALIDATE_CHILDREN ); // trigger re-render } @@ -225,9 +238,11 @@ void MyOpenGLWorkWindow::LoadTexture() CHECK_GL_ERROR(); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_REPEAT); CHECK_GL_ERROR(); -glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); + +// Need to better simulate scale24bitRGB2 cf. bitmapscalesuper.cxx +glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); CHECK_GL_ERROR(); -glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); +glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); CHECK_GL_ERROR(); BitmapEx aBitmap( maGraphic.GetBitmapEx( ) ); @@ -365,6 +380,13 @@ void MyWorkWindow::LoadGraphic( const OUString sImageFile ) maDestinationSize = Size( WIDTH, HEIGHT/aspect ); else maDestinationSize = Size( WIDTH * aspect, HEIGHT ); + +if (getenv(PRESCALE)) // test non-scaling rendering +{ +BitmapEx aScaledBitmap( maGraphic.GetBitmapEx() ); +aScaledBitmap.Scale( maDestinationSize, BMP_SCALE_SUPER); +maGraphic = Graphic( aScaledBitmap ); +} } catch (const uno::Exception e) { commit 3b6414908f271be9ddde18889c3c28d9ee4c4bea Author: Michael Meeks michael.me...@collabora.com Date: Sat Oct 11 22:49:46 2014 +0100 vcl: add a brief comment on bitmap scaling. Change-Id: Id177f2af0d264d144509fb47aa072d011f46b2a6 diff --git a/vcl/source/bitmap/bitmapscalesuper.cxx b/vcl/source/bitmap/bitmapscalesuper.cxx index cbfb08e..206054f 100644 --- a/vcl/source/bitmap/bitmapscalesuper.cxx +++ b/vcl/source/bitmap/bitmapscalesuper.cxx @@ -24,6 +24,16 @@ #define MAP( cVal0, cVal1, nFrac ) ((sal_uInt8)long)(cVal0)7L)+nFrac*((long)(cVal1)-(cVal0)))7L)) +/** + * generate a map of pixel source locations and errors for each + * destination pixel; we should end up with pMapIX containing a + * series of effectively integer pixel offsets across the row eg. + * for something slightly larger than a doubling in size with + * no flips: + * pMapIX: 0 0 1 1 1 2 2 3 3 3 ... + * then pMapFX - contains fixed-point offsets from these + * co-ordinates to reflect sub-pixel positions. + */
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 80846, which changed state. Bug 80846 Summary: Undo after reference cell deletion not updating dependent cell https://bugs.freedesktop.org/show_bug.cgi?id=80846 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - sc/source
sc/source/ui/undo/undoblk3.cxx | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) New commits: commit e392a590399af9c5b87cfbba419d77784c28c250 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Sat Oct 11 14:18:10 2014 -0400 fdo#80846: Broadcast changes before EndUndo(). EndUndo() calls PostDataChanged(), which renders the recalculated formula cells. Not broadcasting before EndUndo causes some dependent formula cells to not get recalculated. This one unfortunately is not currently unit-testable as this behavior depends on the presence of ScTabViewShell Change-Id: I86288608b7f2627cda7c74be27a18029832775ef (cherry picked from commit 424bfaa773e58d6b609ac7f64907db4b542d1315) diff --git a/sc/source/ui/undo/undoblk3.cxx b/sc/source/ui/undo/undoblk3.cxx index 6c258e0..35b80ba 100644 --- a/sc/source/ui/undo/undoblk3.cxx +++ b/sc/source/ui/undo/undoblk3.cxx @@ -169,12 +169,20 @@ void ScUndoDeleteContents::DoChange( const sal_Bool bUndo ) SetChangeTrack(); } +if (nFlags IDF_CONTENTS) +{ +// Broadcast only when the content changes. fdo#74687 +if (mpDataSpans) +BroadcastChanges(*mpDataSpans); +else +BroadcastChanges(aRange); +} + ScTabViewShell* pViewShell = ScTabViewShell::GetActiveViewShell(); if ( !( (pViewShell) pViewShell-AdjustRowHeight( aRange.aStart.Row(), aRange.aEnd.Row() ) ) ) /*A*/ pDocShell-PostPaint( aRange, PAINT_GRID | PAINT_EXTRAS, nExtFlags ); -pDocShell-PostDataChanged(); if (pViewShell) pViewShell-CellContentChanged(); @@ -187,15 +195,6 @@ void ScUndoDeleteContents::Undo() DoChange( sal_True ); EndUndo(); -if (nFlags IDF_CONTENTS) -{ -// Broadcast only when the content changes. fdo#74687 -if (mpDataSpans) -BroadcastChanges(*mpDataSpans); -else -BroadcastChanges(aRange); -} - HelperNotifyChanges::NotifyIfChangesListeners(*pDocShell, aRange); } @@ -205,10 +204,6 @@ void ScUndoDeleteContents::Redo() DoChange( false ); EndRedo(); -if (nFlags IDF_CONTENTS) -// Broadcast only when the content changes. fdo#74687 -BroadcastChanges(aRange); - HelperNotifyChanges::NotifyIfChangesListeners(*pDocShell, aRange); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: qadevOOo/runner wizards/com
qadevOOo/runner/convwatch/DBHelper.java |4 ++-- wizards/com/sun/star/wizards/common/FileAccess.java |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit d860ea91d75568e2e63b0b2c84e50523d562be24 Author: Robert Antoni Buj i Gelonch robert@gmail.com Date: Sat Oct 11 19:15:44 2014 +0200 It is more efficient to use the integer implementations of String.indexOf() Change-Id: Idb1e4945088b8443e9b507826e5289ee758a2bd2 Reviewed-on: https://gerrit.libreoffice.org/11919 Reviewed-by: Noel Grandin noelgran...@gmail.com Tested-by: Noel Grandin noelgran...@gmail.com diff --git a/qadevOOo/runner/convwatch/DBHelper.java b/qadevOOo/runner/convwatch/DBHelper.java index 26be888..aaf6497 100644 --- a/qadevOOo/runner/convwatch/DBHelper.java +++ b/qadevOOo/runner/convwatch/DBHelper.java @@ -187,8 +187,8 @@ public class DBHelper public String Quote(String _sToQuote) { -String ts = '; -String ds = \; +char ts = '\''; +char ds = ''; int nQuote = _sToQuote.indexOf(ts); if (nQuote = 0) { diff --git a/wizards/com/sun/star/wizards/common/FileAccess.java b/wizards/com/sun/star/wizards/common/FileAccess.java index a44c786..3424860 100644 --- a/wizards/com/sun/star/wizards/common/FileAccess.java +++ b/wizards/com/sun/star/wizards/common/FileAccess.java @@ -1063,7 +1063,7 @@ public class FileAccess { if (path.startsWith(/)) { // unix -int nextSlash = path.indexOf(/, 1) + 1; +int nextSlash = path.indexOf('/', 1) + 1; firstPart = Math.min(nextSlash, (maxLength - 3) / 2); } else ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bean/com
bean/com/sun/star/comp/beans/OOoBean.java |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0c48deb59ffb67ac0ddd315ba58872cbf978bc74 Author: Robert Antoni Buj i Gelonch robert@gmail.com Date: Sat Oct 11 19:58:11 2014 +0200 bean: String comparison Change-Id: Id2449ac887c92f87deb3b871b178ac16d3d6b4b8 Reviewed-on: https://gerrit.libreoffice.org/11922 Reviewed-by: Noel Grandin noelgran...@gmail.com Tested-by: Noel Grandin noelgran...@gmail.com diff --git a/bean/com/sun/star/comp/beans/OOoBean.java b/bean/com/sun/star/comp/beans/OOoBean.java index 0d1e34e..d874386 100644 --- a/bean/com/sun/star/comp/beans/OOoBean.java +++ b/bean/com/sun/star/comp/beans/OOoBean.java @@ -1330,7 +1330,7 @@ xLayoutManager.showElement(private:resource/menubar/menubar); // is new argument already set? for ( int n = 0; n nNumArgs; ++n ) { -if ( aArguments[n].Name == aArgument.Name ) +if ( aArguments[n].Name.equals(aArgument.Name) ) { // substitute this argument aArguments[n] = aArgument; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/inc/excform.hxx |4 +-- sc/source/filter/inc/imp_op.hxx |4 +-- sc/source/filter/inc/lotform.hxx |4 +-- sc/source/filter/inc/scflt.hxx| 46 +++--- sc/source/filter/inc/tokstack.hxx |4 +-- 5 files changed, 31 insertions(+), 31 deletions(-) New commits: commit 1361c56aab70e579623b69e67dd99edb4c7b8d89 Author: Christian M. Heller christian.helle...@gmail.com Date: Sat Oct 11 16:19:50 2014 -0400 fdo#39468 Translate German Comments - sc/source/filter/inc/ leftovers Change-Id: I0fe5c0165e1c430861028175c82ff116bac969aa Reviewed-on: https://gerrit.libreoffice.org/11926 Reviewed-by: Noel Grandin noelgran...@gmail.com Tested-by: Noel Grandin noelgran...@gmail.com diff --git a/sc/source/filter/inc/excform.hxx b/sc/source/filter/inc/excform.hxx index 59e933f..8372c20 100644 --- a/sc/source/filter/inc/excform.hxx +++ b/sc/source/filter/inc/excform.hxx @@ -37,8 +37,8 @@ protected: boolbExternName;// external name was found static const sal_uInt16 nRowMask; -static const sal_uInt16 nLastInd; // last Index for Excel-SC- -// Token Umsetzung +static const sal_uInt16 nLastInd; // last Index for Excel-SC- token + XclFunctionProvider maFuncProv; const XclBiff meBiff; diff --git a/sc/source/filter/inc/imp_op.hxx b/sc/source/filter/inc/imp_op.hxx index 5fd69bc..241338a 100644 --- a/sc/source/filter/inc/imp_op.hxx +++ b/sc/source/filter/inc/imp_op.hxx @@ -100,8 +100,8 @@ protected: ScfUInt32VecmaSheetOffsets; ScRange maScOleSize;/// Visible range if embedded. -NameBuffer* pExtNameBuff; // ... externe Namen (Ind.-Basis=1) -ExcelToSc* pFormConv; // Formel-Konverter +NameBuffer* pExtNameBuff; // ... external names (Ind.-Basis=1) +ExcelToSc* pFormConv; // formula-converter XclImpOutlineBuffer*pColOutlineBuff; XclImpOutlineBuffer*pRowOutlineBuff; diff --git a/sc/source/filter/inc/lotform.hxx b/sc/source/filter/inc/lotform.hxx index 427e84f..37aa95a 100644 --- a/sc/source/filter/inc/lotform.hxx +++ b/sc/source/filter/inc/lotform.hxx @@ -83,9 +83,9 @@ private: // with '(rParam)+1' and finished with Store() ! voidDecToken( TokenId rParam ); -// ACHTUNG: ~ +// Attention: ~ voidNegToken( TokenId rParam ); -// ACHTUNG: like ~, but with '-(rParam)' +// Attention: like ~, but with '-(rParam)' public: LotusToSc(LotusContext rContext, SvStream aStr, svl::SharedStringPool rSPool, rtl_TextEncoding eSrc, bool b); diff --git a/sc/source/filter/inc/scflt.hxx b/sc/source/filter/inc/scflt.hxx index b073a09..2ac1168 100644 --- a/sc/source/filter/inc/scflt.hxx +++ b/sc/source/filter/inc/scflt.hxx @@ -24,12 +24,12 @@ #include collect.hxx #include tools/solar.h -// FehlerNummern +// Error numbers #define errUnknownFormat1 #define errUnknownID2 #define errOutOfMemory 3 -// Identifiers im FileFormat +// Identifiers in FileFormat #define ColWidthID 1 #define ColAttrID 2 #define RowHeightID 3 @@ -41,18 +41,18 @@ #define PatternID 9 #define DataBaseID 10 -// Zeilen/Spalten Flags +// Row/Column Flags #define crfSoftBreak1 #define crfHardBreak2 #define crfHidden 4 -// Zelltypen +// Cell types #define ctValue 1 #define ctString2 #define ctFormula 3 #define ctNote 4 -// FontStyles +// Font Styles #define ffDontCare 0x00 #define ffRoman 0x10 #define ffSwiss 0x20 @@ -60,34 +60,34 @@ #define ffScript0x40 #define ffDecorative0x50 -// FontWeight +// Font Weight #define fwNormal400 -// FontAttribute +// Font attributes #define atNone 0 #define atBold 1 #define atItalic2 #define atUnderline 4 #define atStrikeOut 8 -// Horizontale Ausrichtung +// Horizontal alignment #define hjNone 0 #define hjLeft 1 #define hjCenter2 #define hjRight 3 -// Vertikale Ausrichtung +// Vertical alignment #define vjNone 0 #define vjTop 1 #define vjCenter2 #define vjBottom3 -// AusrichtungsFlags +// Allignment flags #define ojWordBreak 0x01 #define ojBottomTop 0x02 #define ojTopBottom 0x04 -// ZellRaster +// Cell grid #define raNone 0 #define raGray121 #define raGray252 @@ -95,13 +95,13 @@ #define raGray754 #define raGray100 5 -// Zellschutz +//
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/fmtfld.hxx| 25 ++--- sw/source/core/docnode/nodes.cxx |8 sw/source/core/text/txtfld.cxx |2 +- sw/source/core/txtnode/atrfld.cxx|4 ++-- sw/source/core/txtnode/thints.cxx|6 +++--- sw/source/core/undo/SwUndoField.cxx |2 +- sw/source/core/unocore/unofield.cxx |2 +- sw/source/uibase/docvw/AnnotationWin.cxx |2 +- sw/source/uibase/docvw/PostItMgr.cxx | 14 +++--- sw/source/uibase/shells/textfld.cxx |2 +- 10 files changed, 35 insertions(+), 32 deletions(-) New commits: commit d0d64225d853d01bf601b3738c26fd8ada41650e Author: Noel Grandin n...@peralex.com Date: Sun Oct 12 01:58:52 2014 +0200 convert SWFMTFLD_ #defines to an enum Change-Id: I5daf6436fd049410c4863a4b065c9abd95b5d361 Reviewed-on: https://gerrit.libreoffice.org/11928 Reviewed-by: Noel Grandin noelgran...@gmail.com Tested-by: Noel Grandin noelgran...@gmail.com diff --git a/sw/inc/fmtfld.hxx b/sw/inc/fmtfld.hxx index 3c63741..9cc505d 100644 --- a/sw/inc/fmtfld.hxx +++ b/sw/inc/fmtfld.hxx @@ -117,27 +117,30 @@ public: { m_wXTextField = xTextField; } }; -class SW_DLLPUBLIC SwFmtFldHint : public SfxHint +enum class SwFmtFldHintWhich { -#define SWFMTFLD_INSERTED 1 -#define SWFMTFLD_REMOVED2 -#define SWFMTFLD_FOCUS 3 -#define SWFMTFLD_CHANGED4 -#define SWFMTFLD_LANGUAGE 5 +INSERTED = 1, +REMOVED= 2, +FOCUS = 3, +CHANGED= 4, +LANGUAGE = 5 +}; -const SwFmtFld* pFld; -sal_Int16 nWhich; -const SwView* pView; +class SW_DLLPUBLIC SwFmtFldHint : public SfxHint +{ +const SwFmtFld* pFld; +SwFmtFldHintWhich nWhich; +const SwView* pView; public: -SwFmtFldHint( const SwFmtFld* p, sal_Int16 n, const SwView* pV = 0) +SwFmtFldHint( const SwFmtFld* p, SwFmtFldHintWhich n, const SwView* pV = 0) : pFld(p) , nWhich(n) , pView(pV) {} const SwFmtFld* GetField() const { return pFld; } -sal_Int16 Which() const { return nWhich; } +SwFmtFldHintWhich Which() const { return nWhich; } const SwView* GetView() const { return pView; } }; diff --git a/sw/source/core/docnode/nodes.cxx b/sw/source/core/docnode/nodes.cxx index 253a792..4873847 100644 --- a/sw/source/core/docnode/nodes.cxx +++ b/sw/source/core/docnode/nodes.cxx @@ -280,8 +280,8 @@ void SwNodes::ChgNode( SwNodeIndex rDelPos, sal_uLong nSz, SwFmtFldHint( pTxtFld-GetFmtFld(), ( pTxtFld-GetFmtFld().IsFldInDoc() - ? SWFMTFLD_INSERTED - : SWFMTFLD_REMOVED ) ) ); + ? SwFmtFldHintWhich::INSERTED + : SwFmtFldHintWhich::REMOVED ) ) ); } else if( RES_DDEFLD == pTyp-Which() ) { @@ -1553,7 +1553,7 @@ void SwNodes::MoveRange( SwPaM rPam, SwPosition rPos, SwNodes rNodes ) pEnd-nContent = pStt-nContent; rPam.DeleteMark(); GetDoc()-GetDocShell()-Broadcast( SwFmtFldHint( 0, -rNodes.IsDocNodes() ? SWFMTFLD_INSERTED : SWFMTFLD_REMOVED ) ); +rNodes.IsDocNodes() ? SwFmtFldHintWhich::INSERTED : SwFmtFldHintWhich::REMOVED ) ); return; } @@ -1675,7 +1675,7 @@ void SwNodes::MoveRange( SwPaM rPam, SwPosition rPos, SwNodes rNodes ) *pEnd = *pStt; rPam.DeleteMark(); GetDoc()-GetDocShell()-Broadcast( SwFmtFldHint( 0, -rNodes.IsDocNodes() ? SWFMTFLD_INSERTED : SWFMTFLD_REMOVED ) ); +rNodes.IsDocNodes() ? SwFmtFldHintWhich::INSERTED : SwFmtFldHintWhich::REMOVED ) ); } ///@see SwNodes::_MoveNodes (TODO: seems to be CP programming here) diff --git a/sw/source/core/text/txtfld.cxx b/sw/source/core/text/txtfld.cxx index b42397e..8b925cf 100644 --- a/sw/source/core/text/txtfld.cxx +++ b/sw/source/core/text/txtfld.cxx @@ -86,7 +86,7 @@ SwExpandPortion *SwTxtFormatter::NewFldPortion( SwTxtFormatInfo rInf, pFld-SetLanguage( GetFnt()-GetLanguage() ); // let the visual note know about its new language if (pFld-GetTyp()-Which()==RES_POSTITFLD) -const_castSwFmtFld* (pHint-GetFmtFld())-Broadcast( SwFmtFldHint( pHint-GetFmtFld(), SWFMTFLD_LANGUAGE ) ); +const_castSwFmtFld* (pHint-GetFmtFld())-Broadcast( SwFmtFldHint( pHint-GetFmtFld(), SwFmtFldHintWhich::LANGUAGE ) ); } SwViewShell *pSh = rInf.GetVsh(); diff --git a/sw/source/core/txtnode/atrfld.cxx b/sw/source/core/txtnode/atrfld.cxx index 732b722..828bc64 100644 --- a/sw/source/core/txtnode/atrfld.cxx
[Libreoffice-bugs] [Bug 84854] Calc issues with screen drawing for a new spreadsheet
https://bugs.freedesktop.org/show_bug.cgi?id=84854 Jean-Baptiste Faure jbfa...@libreoffice.org changed: What|Removed |Added CC||jbfa...@libreoffice.org --- Comment #12 from Jean-Baptiste Faure jbfa...@libreoffice.org --- Not reproducible for me with Version: 4.4.0.0.alpha0+ Build ID: 96adec2fd56d1ca09d679c0966567c674d812dfb updated few hours ago and built at home under Ubuntu 14.04 x86-64 Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70759] Writer: Apply Style toolbar Clear formatting action does not result in Default Style
https://bugs.freedesktop.org/show_bug.cgi?id=70759 --- Comment #3 from Jon Grossart j...@grossart.net --- Not sure when the change went in. Both options used to reset the selected text to Default Format. It was like that in many releases on Windows. I just noticed the change now on 4.3.2.2. I can see the case for Clear direct formating to just match it to the rest of the paragraph, but that's not really a clear description for it. And I would think Clear formatting would put it back to the Default Style. If they are supposed to be the same, then the verbage in the pull down selection should be made to match. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75683] SLIDESHOW: LibreOffice: no sound on some pps files
https://bugs.freedesktop.org/show_bug.cgi?id=75683 --- Comment #51 from Julien Nabet serval2...@yahoo.fr --- Alex: about building sorry, you're right, I had already asked you. You can do: ./g pull -r make to update your build or start the debug with gdb by putting a breakpoint just before the error avmedia/source/gstreamer/gstplayer.cxx:213: gstreamer error: 'Resource not found.' Then it could be useful to retrieve a backtrace by typing bt. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84729] CRASH on an EMF IMPORT
https://bugs.freedesktop.org/show_bug.cgi?id=84729 --- Comment #4 from Chris Sherlock chris.sherloc...@gmail.com --- When I get a moment, I'll see what I can do. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84874] .ods format to .xlsx
https://bugs.freedesktop.org/show_bug.cgi?id=84874 --- Comment #4 from Paavo Ingalsuo pingal...@gmail.com --- Created attachment 107695 -- https://bugs.freedesktop.org/attachment.cgi?id=107695action=edit This the same file without psw. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84874] .ods format to .xlsx
https://bugs.freedesktop.org/show_bug.cgi?id=84874 --- Comment #5 from Paavo Ingalsuo pingal...@gmail.com --- Created attachment 107696 -- https://bugs.freedesktop.org/attachment.cgi?id=107696action=edit Here same file in .xlsx format without psw -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84832] FILESAVE: RTF - table space to content lost
https://bugs.freedesktop.org/show_bug.cgi?id=84832 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||vmik...@collabora.co.uk Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84700] Page Number field format not reflected in indexes i.e., does not override page style definition (Page tab Layout settings Format)
https://bugs.freedesktop.org/show_bug.cgi?id=84700 Owen Genat owen.ge...@gmail.com changed: What|Removed |Added Summary|Page Number Format is not |Page Number field format |Retained in TOC Other |not reflected in indexes |Automatic Indexes |i.e., does not override ||page style definition (Page ||tab Layout settings ||Format) --- Comment #9 from Owen Genat owen.ge...@gmail.com --- (In reply to Joel Madero from comment #6) Indeed this works but I still think it's a valid enhancement request (definitely not a bug). If you have a page number field on the page, and have changed the format, the TOC should reflect this Joel, I have no problem with an index using the format defined in the page number field. (maybe the Format in Format - Page should automatically update to reflect the field style you choose). By all means use a field format to override a page style definition (i.e., in terms of the ToC, as indeicated). A change in field however should never update a style definition of any type, page or otherwise. Page styles are a very powerful and essential aspect to creating complex documents. This enhancement will possibly simplify the ability to get a desired result, but it will come at a cost, in the same way directly applied formatting comes at a cost (as Cor has indicated). Summary amended for clarity. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84832] FILESAVE: RTF - table space to content lost
https://bugs.freedesktop.org/show_bug.cgi?id=84832 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it --- Comment #1 from tommy27 ba...@quipo.it --- Created attachment 107697 -- https://bugs.freedesktop.org/attachment.cgi?id=107697action=edit screenshot issue confirmed under Win7x64 using 4.3.2.2 bug reproduced with all these conversions: .docx - .rft .doc - .rtf .odt - .rtf added comparative screenshot as well. status NEW. I add Miklos to CC list. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75683] SLIDESHOW: LibreOffice: no sound on some pps files
https://bugs.freedesktop.org/show_bug.cgi?id=75683 --- Comment #52 from Julien Nabet serval2...@yahoo.fr --- Forgot to say if your autogen.input didn't include --enable-dbgutil, please add it and run: make clean make postprocess.clean ./g pull -r ./autogen.sh make Of course, this option means it'll take more time to build, it will use more space on your hard disk + it will be slower to run LO but that's the price to pay to retrieve the maximum of information :-) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84874] .ods format to .xlsx
https://bugs.freedesktop.org/show_bug.cgi?id=84874 --- Comment #6 from raal r...@post.cz --- @ Paavo: Tools - protect document - document Pass is still here. I want to try delete parts of document to find where is the problem and I'm unable to delete sheet when document is locked. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84874] .ods format to .xlsx
https://bugs.freedesktop.org/show_bug.cgi?id=84874 --- Comment #7 from Paavo Ingalsuo pingal...@gmail.com --- Created attachment 107698 -- https://bugs.freedesktop.org/attachment.cgi?id=107698action=edit Now unlocked.. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82229] NaN instead of percentage values with some locales (Ubuntu 12.04 + PPA / Debian backports only)
https://bugs.freedesktop.org/show_bug.cgi?id=82229 --- Comment #19 from Olibuntu olibu...@arcor.de --- (In reply to Olibuntu from comment #16) The bug is present in LO Version: 4.3.2.2 Build-ID: 430m0(Build:2) from the Ubuntu PPA for 12.04 32-bit, locale: German Package: libc6 Source: eglibc Version: 2.15-0ubuntu10.7 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84898] New: Enhancement - Version of Libreoffice in the start up screen.
https://bugs.freedesktop.org/show_bug.cgi?id=84898 Bug ID: 84898 Summary: Enhancement - Version of Libreoffice in the start up screen. Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Libreoffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ypa...@gmail.com Hello, i think it would be helpful, in the left side of the start up screen of libreoffice, somewhere above the buttons help and extensions, to be able to see the version of libreoffice i'm using. I need that information because it is essential when i want to ask a question in http://ask.libreoffice.org or fill in a bug report, so maybe it should be available in a more accessible place in the program. Thanks. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84700] Page Number field format not reflected in indexes i.e., does not override page style definition (Page tab Layout settings Format)
https://bugs.freedesktop.org/show_bug.cgi?id=84700 --- Comment #10 from Joel Madero jmadero@gmail.com --- Hey Owen - Can you provide an example where you'd want the page number field to show i but you'd want the page number in the format - page to be set to 1,2,3? This seems very strange to me. To say the least I think a field that is set to i,ii,iii should change the page format numbering but then a user is free to change it back. Or an option should be available that links the two Like I said, I can't see a practical reason why you'd want them to differ. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84595] COLOR PICKER: 'Color Picker' button at bottom of dialog is cropped
https://bugs.freedesktop.org/show_bug.cgi?id=84595 --- Comment #15 from Jay Philips philip...@hotmail.com --- (In reply to Owen Genat from comment #14) It seems a separate issue to the scrollbar Jay. Have a look at attachment 107214 [details] (under Windows with scrollbar) and it can clearly be seen that the entire content of the dialog (separating lines, pull-down, swatches/scrollbar, and buttons) is closer to the right edge, than the left. As the scrollbar is on the right and it is being removed even in windows (attachment 107339), this bug can focus on increasing the height of the dialog and that bug can focus on increasing the width of the dialog. From my windows and linux screenshots and your linux screenshot Owen, they all look quite similar in how much it is cropped at the bottom, while tommy's screenshot seems to be the odd one out. Stuart can you send in a screenshot on windows with the mouse over the button and let us know what theme your using. In previous versions the spacing is equal down either side. It may need a new report. Which previous version was the spacing equal on both sides? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58187] EDITING: Unintended Collapse of Headings in Navigator while moving a chapter
https://bugs.freedesktop.org/show_bug.cgi?id=58187 --- Comment #18 from Jean-Baptiste Faure jbfa...@libreoffice.org --- The fix has (In reply to Björn Michaelsen from comment #17) Can this one be closed? It seems resolved. The fix has not been backported to branch 4.3, is it possible to do that before closing this bug as fixed ? Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47598] Allow to use italics and bold in (alphabetical) index
https://bugs.freedesktop.org/show_bug.cgi?id=47598 --- Comment #5 from Owen Genat owen.ge...@gmail.com --- This is likely a duplicate of bug 30732, as alphabetic indexes are one type of index covered by the indicated report. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84802] Huge Files not responding
https://bugs.freedesktop.org/show_bug.cgi?id=84802 SriJanani jananikumar...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from SriJanani jananikumar...@gmail.com --- I have uploaded the file please check and revert. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84858] Cannot paste fully copied doucument from other offices
https://bugs.freedesktop.org/show_bug.cgi?id=84858 --- Comment #3 from SUBASH T subasht...@gmail.com --- I am using version of libreoffice 4.3.0.2 and operating System is windows7,8 (64 bits) and version of microsoft word 2007. i copied more than two pages from microsoft word 2007, and pasted to libre office writer 4.3.0.2. but first page only pasted in libre office writer other pages not paste. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84819] FILEOPEN: Can't read function from Excel contains column in defined range
https://bugs.freedesktop.org/show_bug.cgi?id=84819 --- Comment #3 from SriJanani jananikumar...@gmail.com --- Hi, I am sorry its related to the bug 84802. please ignore. So the conlusion is =SUBTOTAL(109;Table5[epsac]) function is not available with LO? is that right? also does Libre office support dynamic table? Regards, SriJanani -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84603] Can't install 4.3.2 on Win 7
https://bugs.freedesktop.org/show_bug.cgi?id=84603 --- Comment #7 from Norbert Richter norbert_rich...@gmx.de --- Great! It works! I deinstalled the KB2918614, after that the Installation of LO 4.3.2.2 was running without errors. What to do next? - reinstall the KB2918614 - delete the new ...roaming\libreoffice\4 - rename the old ...roaming\libreoffice\2014 to \4 - before installing the next LO-Update, deinstall the running LO Is that right to do so? Is it possible to integrate the deinstallation of an old version into the install-script? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82300] Shift+F5 = Restore Editing View doesn't work anymore
https://bugs.freedesktop.org/show_bug.cgi?id=82300 --- Comment #2 from Geoff ge...@openware.co.nz --- Confirmed on Debian (32-bit): Version: 4.3.1.2 Build ID: 958349dc3b25111dbca392fbc281a05559ef6848 Version: 4.3.2.2 Build ID: edfb5295ba211bd31ad47d0bad0118690f76407d -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84825] pages cannot properly display using book page.
https://bugs.freedesktop.org/show_bug.cgi?id=84825 --- Comment #3 from SUBASH T subasht...@gmail.com --- Sir, I raised the bug id is 84825,84828. bug id 84825 title is pages cannot properly display using book page. bug id 84828 title is Cannot Work Page Viewer icon. This bugs are not similar. but you announced bug id 84828 is duplicate of bug id 84825. And you gave the solution is bug id 84825. Your solution is (Reduce also the zoom factor to 75% or less, then you will see the correct effect when you play with those icons.). You promoted status of bug id 84825 is (unconform to notabug). but your solution is perfectly working the bug id is 84828. Not working bug id 84825. So,please recheck this bug id 84825. Note: please check the 3rd icon of (bookpage) near zoom in, zoom out bar, that is placed on right side and bottom of the text document writer.Please go through my steps. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82430] LO 4.3.0 for Windows crashes on CPUs that do not support SSE2: Application Error soffice.bin, version 4.3.0.4, module sal3.dll, version 4.3.0.4, address 0x000268d5.
https://bugs.freedesktop.org/show_bug.cgi?id=82430 --- Comment #28 from Jean-Baptiste Faure jbfa...@libreoffice.org --- Could be possible that bug 83277 is a duplicate of this one ? Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80960] EDITING Opening file doesn't place the cursor on the last position of editing
https://bugs.freedesktop.org/show_bug.cgi?id=80960 --- Comment #19 from Geoff ge...@openware.co.nz --- It's not just the Windows version. I've had this in Linux x86(deb) since: Version: 4.3.1.2 Build ID: 958349dc3b25111dbca392fbc281a05559ef6848 Just tried upgrading to: Version: 4.3.2.2 Build ID: edfb5295ba211bd31ad47d0bad0118690f76407d but no improvement. (Note that Shift+F5 doesn't work either.) Older files (saved pre 4.3) do still open at the last saved position. Downgrading to: Version: 4.2.6.3 Build ID: 3fd416d4c6db7d3204c17ce57a1d70f6e531ee21 solves the issue, so if this is an important feature for you (it is to me!) I suggest you stay away from 4.3 till it's fixed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84904] New: Distribution icons look distorted
https://bugs.freedesktop.org/show_bug.cgi?id=84904 Bug ID: 84904 Summary: Distribution icons look distorted Product: LibreOffice Version: 4.4.0.0.alpha0+ Master Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@quipo.it Created attachment 107703 -- https://bugs.freedesktop.org/attachment.cgi?id=107703action=edit screenshot 4.4.0.0+ vs. 4.3.2.2 tested under Win7x64 with 4.4.0.0.alpha0+ Build ID: 9177329a425cf70b515d1f266132838894fe54c6 TinderBox: Win-x86@42, Branch:master, Time: 2014-10-06_00:13:13 STEPS TO REPRODUCE 1- load attachment 51876 in LibO Draw 2- shift+left-click on more than 3 images 3- click menu Modify/Distribution 4- Distribution dialog pops-up see show the icons look distorted and compare with their normal look in LibO 4.3.2.2 in the attached screenshot. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84904] Distribution icons look distorted
https://bugs.freedesktop.org/show_bug.cgi?id=84904 tommy27 ba...@quipo.it changed: What|Removed |Added Keywords||regression CC||ba...@quipo.it -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82229] NaN instead of percentage values with some locales (Ubuntu 12.04 + PPA / Debian backports only)
https://bugs.freedesktop.org/show_bug.cgi?id=82229 --- Comment #20 from Alexandr alexpik...@gmail.com --- Created attachment 107704 -- https://bugs.freedesktop.org/attachment.cgi?id=107704action=edit Wheezy-backports dependences I reproduce the bug with LibreOffice 4.3.1.2 from Debian Wheezy backports with i386 and amd64 architecture. Libc6 version: 2.13-38+deb7u4 I attach all LibreOffice dependences in case the issue is caused by another library. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61914] [META] Start Center -- implementation UI and UX
https://bugs.freedesktop.org/show_bug.cgi?id=61914 tommy27 ba...@quipo.it changed: What|Removed |Added Depends on||84898 --- Comment #29 from tommy27 ba...@quipo.it --- added Bug 84898 - show LibO version in the Start Center -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84898] show LibO version in the Start Center
https://bugs.freedesktop.org/show_bug.cgi?id=84898 tommy27 ba...@quipo.it changed: What|Removed |Added Blocks||61914 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84898] show LibO version in the Start Center
https://bugs.freedesktop.org/show_bug.cgi?id=84898 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||ba...@quipo.it Version|unspecified |4.2.0.0.alpha1 Summary|Enhancement - Version of|show LibO version in the |Libreoffice in the start up |Start Center |screen. | Ever confirmed|0 |1 --- Comment #1 from tommy27 ba...@quipo.it --- I'd like it too. I set status to NEW and add it to Start Center metabug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83213] Integrity of formula and results are broken after Sorting.
https://bugs.freedesktop.org/show_bug.cgi?id=83213 Jean-Baptiste Faure jbfa...@libreoffice.org changed: What|Removed |Added Attachment #105399|text/plain |application/vnd.oasis.opend mime type||ocument.spreadsheet CC||jbfa...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70418] : When selecting text, automatically select entire word
https://bugs.freedesktop.org/show_bug.cgi?id=70418 Samuel Mehrbrodt s.mehrbr...@gmail.com changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- Doesn't this already work? When I select a whole word by double-clicking on it, then move the mouse, the whole next word is selected. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83213] Integrity of formula and results are broken after Sorting.
https://bugs.freedesktop.org/show_bug.cgi?id=83213 Jean-Baptiste Faure jbfa...@libreoffice.org changed: What|Removed |Added Resolution|WORKSFORME |DUPLICATE --- Comment #5 from Jean-Baptiste Faure jbfa...@libreoffice.org --- In fact this bug is a duplicate of bug 79441 which is fixed in version 4.2.6.2 : https://wiki.documentfoundation.org/Releases/4.2.6/RC2 Best regards. JBF *** This bug has been marked as a duplicate of bug 79441 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70418] : When selecting text, automatically select entire word
https://bugs.freedesktop.org/show_bug.cgi?id=70418 --- Comment #4 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- The same works with paragraphs btw. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84874] .ods format to .xlsx
https://bugs.freedesktop.org/show_bug.cgi?id=84874 raal r...@post.cz changed: What|Removed |Added Attachment #107698|1 |0 is patch|| Attachment #107698|text/plain |application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81637] No Data Labels available for data series
https://bugs.freedesktop.org/show_bug.cgi?id=81637 Owen Genat owen.ge...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #8 from Owen Genat owen.ge...@gmail.com --- When editing a chart, right-click on a data series Format Data Labels... (or first insert it if this option is not available) Data Labels tab there is no Show series option, only a Show category option. Using attachment 103365 under GNU/Linux I can confirm that this has been the case since v3.3.4.1. Thanks for the clear example. It would be useful to have this option. Status set to NEW. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84907] New: VIEWING: No border line to separate tab sections and slide
https://bugs.freedesktop.org/show_bug.cgi?id=84907 Bug ID: 84907 Summary: VIEWING: No border line to separate tab sections and slide Product: LibreOffice Version: Inherited From OOo Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Presentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com Created attachment 107708 -- https://bugs.freedesktop.org/attachment.cgi?id=107708action=edit screenshot with red rectangle on the area When the ruler is hidden in Impress, there is no border line separating to show a cut off point at the top of the slide. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49419] TABLE: Setting cell number format of empty cells is ignored - breaks number recognition
https://bugs.freedesktop.org/show_bug.cgi?id=49419 --- Comment #4 from Cor Nouws c...@nouenoff.nl --- Hi Bjoern, At least it works in LibreOffice 3.3.0 - providing of course via Tools Options Writer Table Number recognition is activated.. Will try to find first version where it is broken. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82529] CHART: Donut chart cannot display multiple series names in legend or data labels
https://bugs.freedesktop.org/show_bug.cgi?id=82529 Owen Genat owen.ge...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Genat owen.ge...@gmail.com --- Even though the chart type in the linked bug is column (and here it is donut), if the chart in the linked bug is converted to the donut type, the same problem is evident. It has never been possible to display series labels (only category labels), hence the enhancement. *** This bug has been marked as a duplicate of bug 81637 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82060] FILTER: Problem with sorting
https://bugs.freedesktop.org/show_bug.cgi?id=82060 Jean-Baptiste Faure jbfa...@libreoffice.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED CC||jbfa...@libreoffice.org Resolution|--- |DUPLICATE --- Comment #2 from Jean-Baptiste Faure jbfa...@libreoffice.org --- Closing as duplicate of bug 81696. @Henk Lodewijk: please feel free to reopen if you still encounter the same crash with current stable Fresh version (currently 4.3.2). In such a case, attach your test document as asked in comment #1. Best regards. JBF *** This bug has been marked as a duplicate of bug 81696 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84233] CONTEXT MENU: Reorganizing the slide menu
https://bugs.freedesktop.org/show_bug.cgi?id=84233 Jay Philips philip...@hotmail.com changed: What|Removed |Added Blocks||84909 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84236] CONTEXT MENU: Adding all view modes and including them in a submenu
https://bugs.freedesktop.org/show_bug.cgi?id=84236 Jay Philips philip...@hotmail.com changed: What|Removed |Added Blocks||84909 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84909] New: Meta: Enhancing Impress' toolbars and context menu
https://bugs.freedesktop.org/show_bug.cgi?id=84909 Bug ID: 84909 Summary: Meta: Enhancing Impress' toolbars and context menu Product: LibreOffice Version: Inherited From OOo Hardware: Other OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Presentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com CC: s.mehrbr...@gmail.com Depends on: 84213, 84233, 84236, 84235 Similar to bug 81475, I am working on improving Impress' standard, text formatting and presentation toolbars and right-click context menu with the help of OOo's tracking data. Some initial work and discussion has already been done regarding improvements to the toolbars, which can be found at https://redmine.documentfoundation.org/boards/1/topics/85 . -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84213] CONTEXT MENU: Adding enable/disable ruler under snap lines menu
https://bugs.freedesktop.org/show_bug.cgi?id=84213 Jay Philips philip...@hotmail.com changed: What|Removed |Added Blocks||84909 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75683] SLIDESHOW: LibreOffice: no sound on some pps files
https://bugs.freedesktop.org/show_bug.cgi?id=75683 --- Comment #53 from Michael Meeks michael.me...@collabora.com --- Julien: FWIW - encouraging Alex to build LibreOffice himself is almost certainly a waste of time. The issue is (almost certainly) some intersection of bespoke compiler, bespoke Gstreamer setup, and bespoke LibreOffice configure options. I'd say that is just a waste of time. More useful would be just firing up VirtualBox and installing a 32bit Ubuntu inside it, installing the latest master LibreOffice snapshot binaries, and then playing audio from that - bingo it will work [ at least I rather suspect so ]. At which point - the only moving part is the base-OS underneath. Alex: FYI Vendor is derived from the Latin verb to sell =) I'm not sure it's a great adjective for TDF. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82023] EDITING: Sorting problem in Calc
https://bugs.freedesktop.org/show_bug.cgi?id=82023 Jean-Baptiste Faure jbfa...@libreoffice.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED CC||jbfa...@libreoffice.org Resolution|--- |WORKSFORME --- Comment #4 from Jean-Baptiste Faure jbfa...@libreoffice.org --- Crash reproducible with version 4.2.6.3 but not with versions 4.3.4.0.0+ and the master (4.4.0 alpha). Tested under Ubuntu 14.04 x86-64. Closing as WorksForMe. @empido...@gmail.com : please feel free to reopen if you still encounter the same crash. I such a case, attach your own test file. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82528] CHART: No Option to Change Bubble Chart Bubble Size
https://bugs.freedesktop.org/show_bug.cgi?id=82528 --- Comment #1 from Owen Genat owen.ge...@gmail.com --- Created attachment 107712 -- https://bugs.freedesktop.org/attachment.cgi?id=107712action=edit ODS with 3 charts showing relative bubble sizing in LOv4322. (In reply to Doug from comment #0) 2. Link to data to change sizes of bubbles, succeed in creating data series. 3. Bubbles all are too large, would like to make smaller. I can understand the request. To clarify, this is what ODF v1.2, Part 1, §19.5.1 states: chart:bubble – Circles(bubbles) with different sizes are displayed in a Cartesian coordinate system with horizontal x-axis and vertical y-axis. The values given by a chart:values-cell-range-address attribute on a chart:series element are interpreted as relative bubble area. ... thus the size of the largest bubble is a fixed measure, to which all other bubbles are relative in size. Refer attached example. Workaround noted to change value of one of datapoints, to change data scale, but since it involves changing underlying data is it not optimal approach. While it is possible to include sizing in the data (as indicated), this particular chart type is not handled well by the wizard, making data manipulation even more tedious. A solution may be to set the scale (relative size) for the largest bubble via an option and calculate all bubble sizes based on this additional value, somewhat like a zoom factor. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82528] CHART: Provide option to set relative scaling of size dimension (of largest bubble) in Bubble Chart
https://bugs.freedesktop.org/show_bug.cgi?id=82528 Owen Genat owen.ge...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Summary|CHART: No Option to Change |CHART: Provide option to |Bubble Chart Bubble Size|set relative scaling of ||size dimension (of largest ||bubble) in Bubble Chart Ever confirmed|0 |1 --- Comment #2 from Owen Genat owen.ge...@gmail.com --- Status set to NEW. Summary amended for clarity. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49419] TABLE: Setting cell number format of empty cells is ignored - breaks number recognition
https://bugs.freedesktop.org/show_bug.cgi?id=49419 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Keywords||regression Version|3.5.2 release |4.0.3.3 release --- Comment #5 from Cor Nouws c...@nouenoff.nl --- Last version where it is OK: 4.0.2.2 First version where it is broken: 4.0.3.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80960] EDITING Opening file doesn't place the cursor on the last position of editing
https://bugs.freedesktop.org/show_bug.cgi?id=80960 --- Comment #20 from Cor Nouws c...@nouenoff.nl --- (In reply to Geoff from comment #19) ... so if this is an important feature for you (it is to me!) I suggest you stay away from 4.3 till it's fixed. Hi Geoff! Well, I do like the feature, but missing all the improvements in later versions for this glitch ... No, not me ;) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65535] Adding a comment in the middle of a word makes it recognised as misspelt by spellchecker
https://bugs.freedesktop.org/show_bug.cgi?id=65535 --- Comment #7 from Luuk luu...@gmail.com --- Created attachment 107713 -- https://bugs.freedesktop.org/attachment.cgi?id=107713action=edit a comment is seen as the end (or start) of a word. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82584] CHART: No Option to Use Logarithmic Visual Scale Display Data with Zero or Negative Values
https://bugs.freedesktop.org/show_bug.cgi?id=82584 --- Comment #3 from Owen Genat owen.ge...@gmail.com --- Created attachment 107714 -- https://bugs.freedesktop.org/attachment.cgi?id=107714action=edit ODS containing 1 chart with non-linear x scale in LOv4322. In the attached, editing the X-axis shows it initially displaying a Minimum value of -2000. This is the default value determined by Calc given the data, I have merely unchecked the Automatic option. Checking the Logarithmic scale option results in the reported error. I am a bit uncertain to what degree this is an enhancement or bug. I feel it is mostly likely more of an enhancement than a bug, although the developers may need to have a closer look at what is occurring here to make a clearer judgement. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82584] CHART: Option to allow a zero/negative Minimum value when scaling an axis logarithmically
https://bugs.freedesktop.org/show_bug.cgi?id=82584 Owen Genat owen.ge...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Hardware|Other |All Summary|CHART: No Option to Use|CHART: Option to allow a |Logarithmic Visual Scale|zero/negative Minimum value |Display Data with Zero or |when scaling an axis |Negative Values |logarithmically Ever confirmed|0 |1 OS|Windows (All) |All --- Comment #4 from Owen Genat owen.ge...@gmail.com --- Status set to NEW. Summary amended for clarity. Platform set to All/All. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58187] EDITING: Unintended Collapse of Headings in Navigator while moving a chapter
https://bugs.freedesktop.org/show_bug.cgi?id=58187 --- Comment #19 from Paddy Landau pa...@landau.ws --- I confirm that this has been fixed in 4.3.2.2 (released just a couple of weeks ago), at least in the Linux operating system Ubuntu 14.04. (Thank you to the developers.) I have not tested it in any other operating system. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84898] show LibO version in the Start Center
https://bugs.freedesktop.org/show_bug.cgi?id=84898 --- Comment #2 from Urmas davian...@gmail.com --- It doesn't belong there, as it is completely useless. Such information should be available in the About dialog, where it has its place. The presence of unneeded parts is a sign of shoddy design. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82604] FORMATTING: Underlining exceeds paragraph mark
https://bugs.freedesktop.org/show_bug.cgi?id=82604 --- Comment #3 from Owen Genat owen.ge...@gmail.com --- (In reply to Marc PHILIPPE from comment #0) a) The underlining exceeds the paragraph mark. b) The problem only occurs if the special character is not defined in the font used. (I guess LO falls back onto a default font for drawing the character.) On Windows 7, most fonts don't have →. c) There is no problem if the paragraph begins with →, but the exceeding underlining starts as soon as → is placed 2nd, and increases as → moves forward in the paragraph. Not reproducible under GNU/Linux using v4.3.2.2 with the provided example, regardless of whether Benguiat Frisky font is installed or not. Possibly only affects the Windows build. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84874] .ods format to .xlsx
https://bugs.freedesktop.org/show_bug.cgi?id=84874 --- Comment #8 from raal r...@post.cz --- Created attachment 107717 -- https://bugs.freedesktop.org/attachment.cgi?id=107717action=edit printscreen of workbook.xml Hello Paavo, I tried to delete all three sheets and save as xlsx. This file I can not open in excel viewer. So it looks like this file is somewhat broken. New file saved as xlsx I can open in excel viewer without problem. Please could you verify this? Delete all sheets, save, open in Excel 2013 / Office 365. I looked into xlsx file, in subfile workbook.xml are tags definedNames. After deleting them, I can resave file as .xlsx and open in the excel viewer. This file was originally excel file (Excel_BuiltIn_Print_Area). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58187] EDITING: Unintended Collapse of Headings in Navigator while moving a chapter
https://bugs.freedesktop.org/show_bug.cgi?id=58187 --- Comment #20 from Jean-Baptiste Faure jbfa...@libreoffice.org --- (In reply to Paddy Landau from comment #19) I confirm that this has been fixed in 4.3.2.2 (released just a couple of weeks ago), at least in the Linux operating system Ubuntu 14.04. (Thank you to the developers.) I have not tested it in any other operating system. That's strange, I looked at the code modified by the commit in the master and the same code in 4.3 branch has not been modified. best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84885] Chart Wizard Dialogue cut off
https://bugs.freedesktop.org/show_bug.cgi?id=84885 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||caol...@redhat.com, ||chris.sherloc...@gmail.com, ||serval2...@yahoo.fr --- Comment #6 from Julien Nabet serval2...@yahoo.fr --- Caolan/Chris: It seems Windows only bug (at least neither Ign-Christian nor me reproduce this on Linux). I thought you might be interested in this one since it seems more vcl/UI problem than a pure Calc problem. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84911] New: Drawing has become unstable
https://bugs.freedesktop.org/show_bug.cgi?id=84911 Bug ID: 84911 Summary: Drawing has become unstable Product: LibreOffice Version: 4.4.0.0.alpha0+ Master Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: major Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: davian...@gmail.com In October 8 version, creating new/opening existing ODG files causes application to terminate. Sometimes Unknown SEH exception dialog appears. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82613] User Variables list is not sorted
https://bugs.freedesktop.org/show_bug.cgi?id=82613 --- Comment #5 from Owen Genat owen.ge...@gmail.com --- Created attachment 107718 -- https://bugs.freedesktop.org/attachment.cgi?id=107718action=edit ODT containing user fields w2, x1, x10, y10, and Y1. Tested under GNU/Linux using: v3.3.4.1 OOO330m19 Build: 401 v3.4.6.2 OOO340m1 Build: 602 v3.5.7.2 Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b v3.6.7.2 Build ID: e183d5b v4.0.6.2 Build ID: 2e2573268451a50806fcd60ae2d9fe01dd0ce24 v4.1.6.2 Build ID: 40ff705089295be5be0aae9b15123f687c05b0a v4.2.6.3 Build ID: 3fd416d4c6db7d3204c17ce57a1d70f6e531ee21 v4.3.2.2 Build ID: edfb5295ba211bd31ad47d0bad0118690f76407d v4.4.0.0.alpha0+ Build ID: e21f6e3838a64f6c2517479d021e943e2ffcab94 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2014-10-10_09:04:45 v3.3-4.1 all display the Selection list entries in variable name order, while v4.2-4.4 all display the Selection list entries in the order they were created. This appears to be a regression in handling as the order variables were created in is of little use to a user. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84912] New: MENU: Addition of AutoSpellcheck to Tools menu
https://bugs.freedesktop.org/show_bug.cgi?id=84912 Bug ID: 84912 Summary: MENU: Addition of AutoSpellcheck to Tools menu Product: LibreOffice Version: Inherited From OOo Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Presentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com CC: s.mehrbr...@gmail.com Blocks: 84909 Similar to adding AutoSpellcheck to the tools menu for writer (bug 82969), the same needs to be done for Impress, Draw, and Calc. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs