LibreOffice Gerrit News for core on 2014-10-20

2014-10-20 Thread gerrit
Moin!

* Open changes on master for project core changed in the last 25 hours:

 First time contributors doing great things! 
+ coinmp: change the install path of dylib files
  in https://gerrit.libreoffice.org/12041 from Robert Antoni Buj i Gelonch
  about module external
+ fdo#84405 TRACK CHANGES: New icons for the changes toolbar (small)
  in https://gerrit.libreoffice.org/12033 from Yousuf Philips
  about module icon-themes
+ coinmp: conditional patch
  in https://gerrit.libreoffice.org/12040 from Robert Antoni Buj i Gelonch
  about module external
+ fdo#85185 Pass OUString by value to avoid a use after free
  in https://gerrit.libreoffice.org/12031 from Matthew Francis
  about module include, svx
 End of freshness 

+ Remove OUString possible overflow in SwIoSystem::GetFileFilter
  in https://gerrit.libreoffice.org/12039 from Arnaud Versini
  about module sw
+ fdo#84168 change writerperfect filters to use a new base class template
  in https://gerrit.libreoffice.org/12038 from Takeshi Abe
  about module writerperfect
+ vcl: mv mirror from SalGraphics to OutputDevice - part 8: polylinebezier
  in https://gerrit.libreoffice.org/12037 from Chris Sherlock
  about module include, vcl
+ vcl: move mirror from SalGraphics to OutputDevice - part 7: polypolygons
  in https://gerrit.libreoffice.org/12035 from Chris Sherlock
  about module include, vcl
+ fdo#39468 Translate German Comments - sc/source/filter/{lotus,starcalc,xm
  in https://gerrit.libreoffice.org/12036 from Christian M. Heller
  about module sc
+ vcl: move mirror from SalGraphics to OutputDevice - part 6: polygons
  in https://gerrit.libreoffice.org/12032 from Chris Sherlock
  about module include, vcl
+ vcl: move mirror from SalGraphics to OutputDevice - part 5: polylines
  in https://gerrit.libreoffice.org/12030 from Chris Sherlock
  about module include, vcl
+ vcl: move mirror from SalGraphics to OutputDevice - part 4: rectangles
  in https://gerrit.libreoffice.org/12029 from Chris Sherlock
  about module include, vcl
+ vcl: move mirror from SalGraphics to OutputDevice - part 3: lines
  in https://gerrit.libreoffice.org/12028 from Chris Sherlock
  about module include, vcl
+ vcl: move mirror from SalGraphics to OutputDevice - part 2: clipping
  in https://gerrit.libreoffice.org/12027 from Chris Sherlock
  about module vcl
+ vcl: mv mirror from SalGraphics to OutputDevice - part 1 mirror  pixel
  in https://gerrit.libreoffice.org/12026 from Chris Sherlock
  about module include, vcl
+ HIG-ification of GSoC Color Picker dialog
  in https://gerrit.libreoffice.org/11494 from Olivier Hallot
  about module svx


* Merged changes on master for project core changed in the last 25 hours:

+ accessibility: The if statement is redundant
  in https://gerrit.libreoffice.org/11890 from Robert Antoni Buj i Gelonch
+ scripting: redundant cast to String
  in https://gerrit.libreoffice.org/11859 from Robert Antoni Buj i Gelonch
+ runner: Iterate over each Entry in a Map
  in https://gerrit.libreoffice.org/11918 from Robert Antoni Buj i Gelonch


* Abandoned changes on master for project core changed in the last 25 hours:

+ java: unchecked cast
  in https://gerrit.libreoffice.org/11989 from Robert Antoni Buj i Gelonch


* Open changes needing tweaks, but being untouched for more than a week:

+ fdo#58194 - export DOCX Automatic indent as firstLine indent
  in https://gerrit.libreoffice.org/10425 from Joren De Cuyper
+ WIP (do not merge): remove custom impl of bidirectional list
  in https://gerrit.libreoffice.org/11001 from Chris Laplante
+ fdo#83003 Startcenter: No method for returnin Recent Docs
  in https://gerrit.libreoffice.org/11525 from Efe Gürkan Yalaman
+ fdo#82335.
  in https://gerrit.libreoffice.org/11555 from Sudarshan Rao
+ Perftest for loading autocorrect dictionaries (fdo#79761)
  in https://gerrit.libreoffice.org/11296 from Matúš Kukan
+ fdo#81956 : Rendering of vml group shape was wrong.
  in https://gerrit.libreoffice.org/11013 from sushil_shinde
+ fdo#79018: LO hangs while opening file.
  in https://gerrit.libreoffice.org/9564 from Yogesh Bharate
+ fdo#81426 : Data from header and footer is getting lost.
  in https://gerrit.libreoffice.org/10531 from Rajashri Udhoji
+ fdo#79541 :Corrupt: Shape  enclosed within a floating table
  in https://gerrit.libreoffice.org/9914 from Rajashri Udhoji
+ fdo#80996:Fix for DataLabel not preserved for ColumnChart after RT
  in https://gerrit.libreoffice.org/10169 from Dushyant Bhalgami
+ fdo#77121 Header / Footer positions not preserved after RT
  in https://gerrit.libreoffice.org/9235 from Priyanka Gaikwad


Best,

Your friendly LibreOffice Gerrit Digest Mailer

Note: The bot generating this message can be found and improved here:
   
https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'feature/perfwork4' - 10 commits - filter/source include/svtools include/vcl oox/source svtools/source svx/source sw/inc sw/qa sw/source vcl/inc vcl/source

2014-10-20 Thread Zolnai Tamás
 filter/source/msfilter/msdffimp.cxx  |1 
 include/svtools/grfmgr.hxx   |2 -
 include/vcl/graph.hxx|1 
 oox/source/export/drawingml.cxx  |3 --
 svtools/source/graphic/grfmgr.cxx|   31 ++
 svx/source/svdraw/svdograf.cxx   |8 -
 sw/inc/editsh.hxx|2 -
 sw/qa/extras/odfexport/data/some_images.odt  |binary
 sw/qa/extras/odfexport/odfexport.cxx |   38 +++
 sw/source/core/edit/editsh.cxx   |6 ++--
 sw/source/core/graphic/ndgrf.cxx |9 --
 sw/source/core/unocore/unoframe.cxx  |2 -
 sw/source/filter/ww8/docxattributeoutput.cxx |6 
 sw/source/filter/ww8/rtfattributeoutput.cxx  |6 
 sw/source/filter/ww8/writerhelper.cxx|3 --
 sw/source/filter/ww8/wrtww8gr.cxx|4 --
 sw/source/filter/xml/xmltexte.cxx|4 --
 sw/source/ui/frmdlg/wrap.cxx |2 -
 sw/source/uibase/shells/basesh.cxx   |4 +-
 vcl/inc/impgraph.hxx |1 
 vcl/source/gdi/graph.cxx |6 
 vcl/source/gdi/impgraph.cxx  |   13 ++---
 22 files changed, 86 insertions(+), 66 deletions(-)

New commits:
commit 19e933854e46b6f1de72a4286bb58defd9c07033
Author: Zolnai Tamás tamas.zol...@collabora.com
Date:   Sat Oct 18 14:51:38 2014 +0200

Don't call SetUserData() when it actually does not change

This call leads to infinite loop, because SetUserDat() set
graphic state to swapped out which triggers ImportGraphic..

Change-Id: Id49c38e60a0bb924ff5ec0465e4fb141df61abe5

diff --git a/sw/source/core/graphic/ndgrf.cxx b/sw/source/core/graphic/ndgrf.cxx
index 1b62098..abf38d3 100644
--- a/sw/source/core/graphic/ndgrf.cxx
+++ b/sw/source/core/graphic/ndgrf.cxx
@@ -461,7 +461,6 @@ bool SwGrfNode::ImportGraphic( SvStream rStrm )
 mpReplacementGraphic = 0;
 
 maGrfObj.SetGraphic( aGraphic );
-maGrfObj.SetUserData( aURL );
 onGraphicChanged();
 return true;
 }
commit 671301283fe37c796f251526279f477d5578a3d5
Author: Zolnai Tamás tamas.zol...@collabora.com
Date:   Sat Oct 18 15:08:39 2014 +0200

Make SetSwapState() an internal method

So we can be sure it is always called when user data changed.

Change-Id: If107907afffb85a7a57817f5807847a5c028416c

diff --git a/include/svtools/grfmgr.hxx b/include/svtools/grfmgr.hxx
index 30ac634..d452276 100644
--- a/include/svtools/grfmgr.hxx
+++ b/include/svtools/grfmgr.hxx
@@ -313,6 +313,7 @@ protected:
 
 virtual voidGraphicManagerDestroyed();
 virtual SvStream*   GetSwapStream() const;
+voidSetSwapState();
 
 virtual voidLoad( SvStream ) SAL_OVERRIDE;
 virtual voidSave( SvStream ) SAL_OVERRIDE;
@@ -421,7 +422,6 @@ public:
 boolIsInSwapOut() const { return mbIsInSwapOut; }
 boolIsInSwap() const { return( mbIsInSwapOut || 
mbIsInSwapOut ); }
 boolIsSwappedOut() const { return( mbAutoSwapped || 
maGraphic.IsSwapOut() ); }
-voidSetSwapState();
 
 boolDraw(
 OutputDevice* pOut,
diff --git a/svtools/source/graphic/grfmgr.cxx 
b/svtools/source/graphic/grfmgr.cxx
index ef2f9fd..45367cd 100644
--- a/svtools/source/graphic/grfmgr.cxx
+++ b/svtools/source/graphic/grfmgr.cxx
@@ -102,6 +102,8 @@ GraphicObject::GraphicObject( const GraphicObject 
rGraphicObj, const GraphicMan
 ImplConstruct();
 ImplAssignGraphicData();
 ImplSetGraphicManager( pMgr, NULL, rGraphicObj );
+if( rGraphicObj.HasUserData()  rGraphicObj.IsSwappedOut() )
+SetSwapState();
 }
 
 GraphicObject::GraphicObject( const OString rUniqueID, const GraphicManager* 
pMgr ) :
@@ -351,8 +353,9 @@ GraphicObject GraphicObject::operator=( const 
GraphicObject rGraphicObj )
 ImplAssignGraphicData();
 mbAutoSwapped = false;
 mpMgr = rGraphicObj.mpMgr;
-
 mpMgr-ImplRegisterObj( *this, maGraphic, NULL, rGraphicObj );
+if( rGraphicObj.HasUserData()  rGraphicObj.IsSwappedOut() )
+SetSwapState();
 }
 
 return *this;
@@ -427,6 +430,7 @@ void GraphicObject::SetUserData()
 void GraphicObject::SetUserData( const OUString rUserData )
 {
 maUserData = rUserData;
+SetSwapState();
 }
 
 void GraphicObject::SetSwapStreamHdl()
diff --git a/svx/source/svdraw/svdograf.cxx b/svx/source/svdraw/svdograf.cxx
index b101d03..acbc721 100644
--- a/svx/source/svdraw/svdograf.cxx
+++ b/svx/source/svdraw/svdograf.cxx
@@ -552,10 +552,6 @@ void SdrGrafObj::SetGrafStreamURL( const OUString 
rGraphicStreamURL )
 else if( pModel-IsSwapGraphics() )
 {
 pGraphic-SetUserData( rGraphicStreamURL );
-
-// set state of 

Java problem when running CppunitTest_dbaccess_dialog_save on OS X 10.10 with Oracle JDK 1.8

2014-10-20 Thread Tor Lillqvist
Our code to detect what Java versions there are on a machine and cleverly
choose the right one is really sad and over-engineered. Something in there
goes wrong when building LibreOffice on OS X 10.10 with the latest Oracle
JDK (1.8.0_25) installed.

The CppunitTest_dbaccess_dialog_save fails and you get an asynchronous
dialog window (i.e. the unit test program does not wait for the dialog to
be dismissed) with the unhelpful and presumably quite misleading message
'To open this Java application you need to install the legacy Java SE 6
runtime'. I did spend a little time (like a few hours) debugging this in
the weekend but didn't figure out the root cause. But I was once again
appalled by the code in there, in jvmfwk.

For now, until somebody fixes this, it is best to use --without-java
instead of trying to build with Java 1.8 on OS X 10.10, I guess. Possibly
the same holds for Java 1.8 on earlier OS X versions.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: include/rtl

2014-10-20 Thread Matthew J . Francis
 include/rtl/strbuf.hxx |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

New commits:
commit 8091cf383a122f2348d6e25df90fc26579fe6ef7
Author: Matthew J. Francis mjay.fran...@gmail.com
Date:   Fri Oct 17 20:48:08 2014 +0800

Increase assert coverage of OStringBuffer arguments

Change-Id: Ifd3c9919ef104909efa8964e7a0cb5e723e3331d
Signed-off-by: Stephan Bergmann sberg...@redhat.com

diff --git a/include/rtl/strbuf.hxx b/include/rtl/strbuf.hxx
index b8d1d9d..1bfe640 100644
--- a/include/rtl/strbuf.hxx
+++ b/include/rtl/strbuf.hxx
@@ -491,7 +491,7 @@ public:
  */
 OStringBuffer  append( const sal_Char * str, sal_Int32 len)
 {
-// insert behind the last character
+assert( len = 0 );
 rtl_stringbuffer_insert( pData, nCapacity, getLength(), str, len );
 return *this;
 }
@@ -729,7 +729,8 @@ public:
  */
 OStringBuffer  insert( sal_Int32 offset, const sal_Char * str, sal_Int32 
len)
 {
-// insert behind the last character
+assert( offset = 0  offset = pData-length );
+assert( len = 0 );
 rtl_stringbuffer_insert( pData, nCapacity, offset, str, len );
 return *this;
 }
@@ -911,6 +912,8 @@ public:
  */
 OStringBuffer  remove( sal_Int32 start, sal_Int32 len )
 {
+assert( start = 0  start = pData-length );
+assert( len = 0 );
 rtl_stringbuffer_remove( pData, start, len );
 return *this;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: accessibility/source avmedia/source basctl/source chart2/source cui/source dbaccess/source forms/source framework/inc framework/source include/rsc include/sfx2 include/

2014-10-20 Thread Noel Grandin
 accessibility/source/standard/vclxaccessibletoolboxitem.cxx  |   10 +-
 avmedia/source/framework/mediacontrol.cxx|6 -
 basctl/source/basicide/tbxctl.cxx|2 
 chart2/source/controller/main/ShapeToolbarController.cxx |2 
 cui/source/customize/cfg.cxx |4 -
 dbaccess/source/ui/app/AppDetailPageHelper.cxx   |2 
 dbaccess/source/ui/control/toolboxcontroller.cxx |2 
 forms/source/solar/control/navtoolbar.cxx|4 -
 framework/inc/uielement/toolbarmanager.hxx   |2 
 framework/source/uielement/complextoolbarcontroller.cxx  |8 +-
 framework/source/uielement/generictoolbarcontroller.cxx  |   10 +-
 framework/source/uielement/popuptoolbarcontroller.cxx|   12 +--
 framework/source/uielement/togglebuttontoolbarcontroller.cxx |4 -
 framework/source/uielement/toolbarmanager.cxx|   26 +++---
 framework/source/uielement/toolbarmerger.cxx |2 
 include/rsc/rsc-vcl-shared-types.hxx |   33 +---
 include/sfx2/sidebar/SidebarToolBox.hxx  |2 
 include/vcl/toolbox.hxx  |   10 +-
 reportdesign/source/ui/misc/toolboxcontroller.cxx|2 
 rsc/inc/rscdb.hxx|1 
 rsc/source/parser/rscicpx.cxx|   24 +++---
 sc/source/ui/app/inputwin.cxx|   18 ++--
 sc/source/ui/cctrl/tbinsert.cxx  |2 
 sc/source/ui/navipi/navipi.cxx   |2 
 sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx |8 +-
 sd/source/ui/app/tbxww.cxx   |2 
 sd/source/ui/controller/slidelayoutcontroller.cxx|4 -
 sd/source/ui/dlg/navigatr.cxx|4 -
 sfx2/source/dialog/templdlg.cxx  |8 +-
 sfx2/source/dialog/titledockwin.cxx  |2 
 sfx2/source/doc/templatedlg.cxx  |6 -
 sfx2/source/toolbox/tbxitem.cxx  |   12 +--
 svtools/source/uno/generictoolboxcontroller.cxx  |8 +-
 svx/source/customshapes/tbxcustomshapes.cxx  |2 
 svx/source/form/tbxform.cxx  |6 -
 svx/source/gallery2/galbrws2.cxx |4 -
 svx/source/mnuctrls/clipboardctl.cxx |6 -
 svx/source/sidebar/area/AreaPropertyPanel.cxx|4 -
 svx/source/sidebar/line/LinePropertyPanel.cxx|4 -
 svx/source/sidebar/paragraph/ParaPropertyPanel.cxx   |4 -
 svx/source/sidebar/text/TextPropertyPanel.cxx|2 
 svx/source/tbxctrls/fontworkgallery.cxx  |2 
 svx/source/tbxctrls/grafctrl.cxx |4 -
 svx/source/tbxctrls/layctrl.cxx  |4 -
 svx/source/tbxctrls/lboxctrl.cxx |4 -
 svx/source/tbxctrls/linectrl.cxx |2 
 svx/source/tbxctrls/subtoolboxcontrol.cxx|2 
 svx/source/tbxctrls/tbcontrl.cxx |6 -
 svx/source/tbxctrls/tbxalign.cxx |2 
 svx/source/tbxctrls/tbxdrctl.cxx |2 
 sw/source/uibase/ribbar/inputwin.cxx |4 -
 sw/source/uibase/ribbar/tblctrl.cxx  |2 
 sw/source/uibase/ribbar/tbxanchr.cxx |2 
 sw/source/uibase/ribbar/workctrl.cxx |   10 +-
 sw/source/uibase/sidebar/PagePropertyPanel.cxx   |8 +-
 sw/source/uibase/utlui/navipi.cxx|8 +-
 vcl/source/window/builder.cxx|4 -
 vcl/source/window/menubarwindow.cxx  |4 -
 vcl/source/window/toolbox.cxx|   43 +--
 vcl/source/window/toolbox2.cxx   |   20 ++---
 60 files changed, 208 insertions(+), 201 deletions(-)

New commits:
commit 67c9d054517fc3b5cbc203c330eedef4b50f0e57
Author: Noel Grandin n...@peralex.com
Date:   Sat Oct 18 20:16:11 2014 +0200

fdo#84938: replace TIB_ constants with enum

Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84
Reviewed-on: https://gerrit.libreoffice.org/12023
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com

diff --git a/accessibility/source/standard/vclxaccessibletoolboxitem.cxx 
b/accessibility/source/standard/vclxaccessibletoolboxitem.cxx
index 3f77107..7906f64 100644
--- a/accessibility/source/standard/vclxaccessibletoolboxitem.cxx
+++ 

Re: Java problem when running CppunitTest_dbaccess_dialog_save on OS X 10.10 with Oracle JDK 1.8

2014-10-20 Thread Tor Lillqvist
Stephan pointed me to old discussion in
https://bugs.libreoffice.org/show_bug.cgi?id=74877 , and that is relevant
also for OS X 10.10 and Java 1.8, it seems that one (sadly) really needs to
install the Apple-supplied Java 1.6 in order to use an Oracle-supplied
leading-edge Java (1.7 or 1.8) with LibreOffice.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Main-loop / idle handler bits ...

2014-10-20 Thread Jennifer Liebel
Hi Michael,

we have a new wiki page. Can you check it, if we have the proper
information?
https://wiki.documentfoundation.org/Development/LHM_LiMux/Main_Loop

We acquired a scheduling concept:
Scheduling with priorities: Every Timer gets a default priority. To avoid
starvation, the priority increases after every cycle (dynamic priorities).
When it was executed, it gets the default priority again.

Do you agree?

Kind regards

2014-10-18 21:57 GMT+02:00 Michael Meeks michael.me...@collabora.com:

 Hi guys,

 Just wondering how this is going =) I could really use an UNO
 method
 that essentially processes all 'idle' handlers synchronously to finish
 up all pending work - to help with some profiling tasks - but (of
 course) to do that, we need some genuine 'idle' vs. 'timeout'
 distinction.

 How is that coming along? I see lots of nice things in the wiki
 page
 here:


 https://wiki.documentfoundation.org/Development/LHM_LiMux#Priority_Main_Loop

 On Wed, 2014-10-01 at 17:04 +0100, Michael Meeks wrote:
Yep - a very helpful table there. I've asked to have that sorted by
  timeout not source-location; and to have all the UI related timeouts
  split to their own section.

 So - I did some thinking and mapped the timeouts to some sort of
 descriptive priority names - something like this:

 enum IdlePriority {
 VCL_IDLE_PRIORITY_HIGHEST, //   - 0ms
 VCL_IDLE_PRIORITY_HIGH, //  - 1ms
 VCL_IDLE_PRIORITY_REPAINT //- 30ms
 VCL_IDLE_PRIORITY_RESIZE  //- 50ms
 VCL_IDLE_PRIORITY_MEDIUM // - 50ms
 VCL_IDLE_PRIORITY_LOW //- 100ms
 VCL_IDLE_PRIORITY_LOWER //  - 200ms
 VCL_IDLE_PRIORITY_LOWEST // - 400ms
 };

 we can rip/replace the 'ms' comments later of course. Then we would
 need a patch something like the attached. Of course, worked through all
 of the instances of idle handlers =) Patch is un-tested to avoid having
 to trigger a rather slow re-build here; please do hack it about into
 whatever form you like.

 Is it possible to extend that suitably ? when we have the code
 changed
 around the place, and the problem isolated; we can start to prioritize
 and avoid having these silly timeouts at all (I hope).

 Having said that, when we get to 400ms - I imagine this is a UI
 interaction timeout - which prolly should stay at 400ms ;-) - it'd be
 good to review those to see if they are UI / behaviour related - it'd
 suck to suddenly have the double-click time be ~instant ;-)

 All the best,

 Michael.

 --
  michael.me...@collabora.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: OS X: coinmp is not using install_name_tool

2014-10-20 Thread Stephan Bergmann

On 10/19/2014 05:22 PM, Robert Antoni Buj i Gelonch wrote:

The previous message was for the master branch, the next output was
obtained in 4.3 branch:


There are two situations to consider:

1  Genuine LO code links against an external dylib A.  A's install name 
needs to contain a special filepath segment denoting where A is located 
in the installset, see the comment at the top of 
solenv/bin/macosx-change-install-names.pl and e.g.



$(if $(filter 
MACOSX,$(OS)),--prefix=/@.__OOO)
 \


in external/cairo/ExternalProject_cairo.mk.

2  An external dylib B links against another external dylib A (from the 
same or another external project).  A needs to be set up according to 
(1).  The ExternalProject_*.mk for B needs to explicitly call 
macosx-change-install-names on B, see e.g.



$(if $(filter MACOSX,$(OS)), $(PERL) \
$(SRCDIR)/solenv/bin/macosx-change-install-names.pl shl 
OOO \

$(gb_Package_SOURCEDIR_icu)/source/lib/libicudata$(gb_Library_DLLEXT).$(icu_VERSION)
 \

$(gb_Package_SOURCEDIR_icu)/source/lib/libicuuc$(gb_Library_DLLEXT).$(icu_VERSION)
 \

$(gb_Package_SOURCEDIR_icu)/source/lib/libicui18n$(gb_Library_DLLEXT).$(icu_VERSION))
 \


in external/icu/ExternalProject_icu.mk.

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 2 commits - jvmfwk/plugins

2014-10-20 Thread Tor Lillqvist
 jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx |   22 +++-
 jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx|2 
 jvmfwk/plugins/sunmajor/pluginlib/util.cxx  |   51 +++-
 jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx|9 ++-
 4 files changed, 36 insertions(+), 48 deletions(-)

New commits:
commit 68e0f4d4f2becba41a12109095c693680825cb3e
Author: Tor Lillqvist t...@collabora.com
Date:   Sun Oct 19 00:50:17 2014 +0300

Clean jvmfwk tracing output

Change-Id: I070fb24e9466d697a6014bd65635f6cda8736819

diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
index d1e02ce..db58c54 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
@@ -602,8 +602,7 @@ javaPluginError jfw_plugin_startJavaVirtualMachine(
 if ( ! isVendorSupported(pInfo-sVendor))
 return JFW_PLUGIN_E_WRONG_VENDOR;
 OUString sRuntimeLib = getRuntimeLib(pInfo-arVendorData);
-JFW_TRACE2([Java framework] Using Java runtime library: 
-  + sRuntimeLib + .\n);
+JFW_TRACE2(Using Java runtime library:   sRuntimeLib);
 
 #ifndef ANDROID
 // On linux we load jvm with RTLD_GLOBAL. This is necessary for debugging, 
because
@@ -624,9 +623,7 @@ javaPluginError jfw_plugin_startJavaVirtualMachine(
 [Java framework]sunjavaplugin SAL_DLLEXTENSION
 could not load Java runtime library: \n
 + sRuntimeLib + \n);
- JFW_TRACE0([Java framework]sunjavaplugin SAL_DLLEXTENSION
- could not load Java runtime library: \n
-+ sRuntimeLib +  \n);
+ JFW_TRACE0(Could not load Java runtime library:   sRuntimeLib);
  return JFW_PLUGIN_E_VM_CREATION_FAILED;
  }
 
@@ -704,7 +701,7 @@ javaPluginError jfw_plugin_startJavaVirtualMachine(
 }
 #endif
 #if OSL_DEBUG_LEVEL = 2
-JFW_TRACE2(VM option:   options[n].optionString  \n);
+JFW_TRACE2(VM option:   options[n].optionString);
 #endif
 ++n;
 }
@@ -765,7 +762,7 @@ javaPluginError jfw_plugin_startJavaVirtualMachine(
 else
 {
 *ppVm = pJavaVM;
-JFW_TRACE2([Java framework] sunjavaplugin SAL_DLLEXTENSION  has 
created a VM.\n);
+JFW_TRACE2(JVM created);
 }
 #else
 (void) arOptions;
@@ -809,28 +806,25 @@ javaPluginError jfw_plugin_existJRE(const JavaInfo 
*pInfo, sal_Bool *exist)
 if (ret == JFW_PLUGIN_E_NONE  *exist == sal_True)
 {
 OUString sRuntimeLib = getRuntimeLib(pInfo-arVendorData);
-JFW_TRACE2([Java framework] Checking existence of Java runtime 
library.\n);
+JFW_TRACE2(Checking existence of Java runtime library);
 
 ::osl::DirectoryItem itemRt;
 ::osl::File::RC rc_itemRt = ::osl::DirectoryItem::get(sRuntimeLib, 
itemRt);
 if (::osl::File::E_None == rc_itemRt)
 {
 *exist = sal_True;
-JFW_TRACE2([Java framework] Java runtime library exist: 
-  + sRuntimeLib + \n);
+JFW_TRACE2(Java runtime library exist:   sRuntimeLib);
 
 }
 else if (::osl::File::E_NOENT == rc_itemRt)
 {
 *exist = sal_False;
-JFW_TRACE2([Java framework] Java runtime library does not exist: 
-   + sRuntimeLib + \n);
+JFW_TRACE2(Java runtime library does not exist:   sRuntimeLib);
 }
 else
 {
 ret = JFW_PLUGIN_E_ERROR;
-JFW_TRACE2([Java framework] Error while looking for Java runtime 
library: 
-   + sRuntimeLib +  \n);
+JFW_TRACE2(Error while looking for Java runtime library:   
sRuntimeLib);
 }
 }
 return ret;
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx
index 457ba8d..504c16c 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx
@@ -403,7 +403,7 @@ SelfTest::SelfTest()
 break;
 }
 if (bRet)
-JFW_TRACE2([Java framework] sunjavaplugin: Testing class SunVersion 
succeeded.\n);
+JFW_TRACE2(Testing class SunVersion succeeded.);
 else
 OSL_ENSURE(bRet, [Java framework] sunjavaplugin: SunVersion self test 
failed.\n);
 }
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
index eb840b6..6d46121 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
@@ -165,8 +165,7 @@ namespace
 #endif
 buf.appendAscii( SAL_CONFIGFILE(/sunjavaplugin) );
 sIni = buf.makeStringAndClear();
-JFW_TRACE2([Java framework] sunjavaplugin: 
-   Using configuration file \n +  sIni);
+JFW_TRACE2(Using configuration file   sIni);
 

[Libreoffice-commits] dev-tools.git: ciabot/libreoffice-bugzilla.pl

2014-10-20 Thread Markus Mohrhard
 ciabot/libreoffice-bugzilla.pl |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a3301d2bad20a143bf115e37b55ad75b897716dd
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Mon Oct 20 10:20:34 2014 +0200

improve error message to find out why script fails

diff --git a/ciabot/libreoffice-bugzilla.pl b/ciabot/libreoffice-bugzilla.pl
index 9df77fb..5d109fa 100755
--- a/ciabot/libreoffice-bugzilla.pl
+++ b/ciabot/libreoffice-bugzilla.pl
@@ -205,7 +205,7 @@ die cannot connect to bugzilla unless defined $bz;
 
 my $product = $bz-product;
 
-die wrong product unless $product eq 'LibreOffice';
+die wrong product . $product unless $product eq 'LibreOffice';
 
 my $whiteboard = $bz-status_whiteboard();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sw/qa writerfilter/source

2014-10-20 Thread Miklos Vajna
 sw/qa/extras/rtfimport/data/fdo83464.rtf   |   24 
 sw/qa/extras/rtfimport/rtfimport.cxx   |9 +
 writerfilter/source/rtftok/rtfdocumentimpl.cxx |2 ++
 3 files changed, 35 insertions(+)

New commits:
commit 8cca66b47ca6d94b21d740089b2a3bae1c0566ff
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Sun Oct 19 10:35:45 2014 +0200

fdo#83464 RTF import: \plain should reset \rtlch and \hich as well

Regression from 36246aa9fb57c9fe4e546c91a8274d8828b1424e (RTF import:
fix handling of \loch \hich \dbch \ltrch \rtlch, 2014-06-03), now that
\f no longer means the ascii font name, \plain should reset a few more
parser state members.

(cherry picked from commit 69bf37136c1386c7220f38a896aa9865bdae665f)

Conflicts:
sw/qa/extras/rtfimport/rtfimport.cxx
writerfilter/source/rtftok/rtfdocumentimpl.cxx

Change-Id: Ia6b0bdf25563dd5300e108b46731751f0886f67d
Reviewed-on: https://gerrit.libreoffice.org/12034
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com

diff --git a/sw/qa/extras/rtfimport/data/fdo83464.rtf 
b/sw/qa/extras/rtfimport/data/fdo83464.rtf
new file mode 100644
index 000..28c9202
--- /dev/null
+++ b/sw/qa/extras/rtfimport/data/fdo83464.rtf
@@ -0,0 +1,24 @@
+{\rtf1\adeflang1025\ansi\ansicpg1252\uc1\adeff31507\deff0\stshfdbch0\stshfloch0\stshfhich0\stshfbi0\deflang1033\deflangfe1033\themelang1033\themelangfe0\themelangcs1025
+{\fonttbl
+{\f0\fbidi \froman\fcharset0\fprq2 Times New Roman;}
+{\f39\fbidi \fswiss\fcharset0\fprq2 Verdana;}
+}
+{\stylesheet
+{\s43\ql \f39\fs16 Table Text;}
+}
+\pard\plain \ltrpar\ql 
\li0\ri0\sb60\sa60\widctlpar\tx360\jclisttab\tx720\tx1080\tx1440\tx1800\tx2160\tx2520\tx2880\tx3240\tx3600\tx3960\tx4320\tx4680\tx5040\tx5400\tx5760\wrapdefault\aspalpha\aspnum\faauto\adjustright\rin0\lin0\itap0\pararsid10449364
 \rtlch\fcs1 \af0\afs18\alang1037 \ltrch\fcs0 
\fs16\lang1024\langfe1024\loch\af2\hich\af2\dbch\af35\cgrid\noproof\langnp1033\langfenp1033
 
+\par
+{\rtlch\fcs1 \ltrch\fcs0 \insrsid11419963 
+{\shp
+{\*\shpinst\shpleft-90\shptop720\shpright9405\shpbottom2940\shpfhdr0\shpbxcolumn\shpbxignore\shpbymargin\shpbyignore\shpwr3\shpwrk0\shpfblwtxt0\shpz2\shplid1027
+{\sp
+{\sn shapeType}
+{\sv 202}
+}
+{\shptxt \pard\plain\f39\fs16 Hello\par
+}
+}
+}
+}
+\par
+}
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx 
b/sw/qa/extras/rtfimport/rtfimport.cxx
index cc51a42..24afe98 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -1898,6 +1898,15 @@ DECLARE_RTFIMPORT_TEST(testFdo84679, fdo84679.rtf)
 CPPUNIT_ASSERT_EQUAL(static_castsal_Int32(0), 
getPropertysal_Int32(getParagraphOfText(1, xCell-getText()), 
ParaBottomMargin));
 }
 
+DECLARE_RTFIMPORT_TEST(testFdo83464, fdo83464.rtf)
+{
+// Problem was that the text in the textfrme had wrong font.
+uno::Referencetext::XTextRange xFrameText(getShape(1), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString(Hello), xFrameText-getString());
+// This was Times New Roman.
+CPPUNIT_ASSERT_EQUAL(OUString(Verdana), 
getPropertyOUString(getRun(getParagraphOfText(1, xFrameText-getText()), 1), 
CharFontName));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 3fdc5ef..9339c51 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -2812,6 +2812,8 @@ int RTFDocumentImpl::dispatchFlag(RTFKeyword nKeyword)
 m_aStates.top().aCharacterSprms = getDefaultState().aCharacterSprms;
 m_aStates.top().nCurrentEncoding = 
getEncoding(getFontIndex(m_nDefaultFontIndex));
 m_aStates.top().aCharacterAttributes = 
getDefaultState().aCharacterAttributes;
+m_aStates.top().isRightToLeft = false;
+m_aStates.top().eRunType = RTFParserState::LOCH;
 }
 break;
 case RTF_PARD:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] dev-tools.git: ciabot/libreoffice-bugzilla.pl

2014-10-20 Thread Markus Mohrhard
 ciabot/libreoffice-bugzilla.pl |4 
 1 file changed, 4 deletions(-)

New commits:
commit e842752a265888a54d57d9547a13aef18814
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Mon Oct 20 10:29:23 2014 +0200

remove the product check

It seems that since the last bugzilla update we no longer get the
correct product in the variable

diff --git a/ciabot/libreoffice-bugzilla.pl b/ciabot/libreoffice-bugzilla.pl
index 5d109fa..19d5454 100755
--- a/ciabot/libreoffice-bugzilla.pl
+++ b/ciabot/libreoffice-bugzilla.pl
@@ -203,10 +203,6 @@ my $bz = WWW::Bugzilla-new(
 
 die cannot connect to bugzilla unless defined $bz;
 
-my $product = $bz-product;
-
-die wrong product . $product unless $product eq 'LibreOffice';
-
 my $whiteboard = $bz-status_whiteboard();
 
 if ( !defined( $whiteboard ) || $whiteboard eq '' )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: [Libreoffice-qa] Minutes of ESC call: 2014-10-16

2014-10-20 Thread Stephan Bergmann

On 10/17/2014 08:29 PM, Bjoern Michaelsen wrote:

  - 1/ Replace all custom shell tooling (sed/grep/gawk/perl horrors) and
   consolidate on either native (C/C++) code (see e.g. concat-deps) or _one_
   and only one consolidated solution beyond that, likely Python3 (as we are
   bundling that and it is a good crossplatform superset of the POSIX
   shell-world). Bootstrapping on Windows would then likely be: Install
   native Python3, execute Python script that sets up the rest.

   rationale: As we already use a native GNU make on Windows, with this we
   could remove our dependency on cygwin as Python3 is available natively on
   Windows (and all other platforms).


...if we also successfully abstract over the differences between 
GNU/cygwin and Windows of all those very little tools called from make 
recipes (like moving a file).


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: configmgr/source

2014-10-20 Thread Daniel Sikeler
 configmgr/source/access.hxx |8 
 configmgr/source/components.hxx |5 ++---
 configmgr/source/config_map.hxx |3 ---
 configmgr/source/data.hxx   |2 +-
 configmgr/source/nodemap.hxx|3 ++-
 5 files changed, 9 insertions(+), 12 deletions(-)

New commits:
commit a2deca9d755710bd543fd0caaea0352ac746396d
Author: Daniel Sikeler d.sikele...@gmail.com
Date:   Mon Oct 20 08:11:21 2014 +0200

fdo#75757: remove inheritance to std::map

Change-Id: I189d7a1d68eb9022a32e882d68ce8c8dc567c1fd
Reviewed-on: https://gerrit.libreoffice.org/12042
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com

diff --git a/configmgr/source/access.hxx b/configmgr/source/access.hxx
index 807f2a2..d8db2a8 100644
--- a/configmgr/source/access.hxx
+++ b/configmgr/source/access.hxx
@@ -487,7 +487,7 @@ private:
 bool theDirectlyModified);
 };
 
-typedef config_map ModifiedChild  ModifiedChildren;
+typedef std::map OUString, ModifiedChild, LengthContentsCompare  
ModifiedChildren;
 
 rtl::Reference ChildAccess  getModifiedChild(
 ModifiedChildren::iterator const  childIterator);
@@ -516,7 +516,7 @@ private:
 
 rtl::Reference Access  getNotificationRoot();
 
-typedef config_map ChildAccess *  WeakChildMap;
+typedef std::map OUString, ChildAccess *, LengthContentsCompare  
WeakChildMap;
 
 typedef
 std::multiset
@@ -536,7 +536,7 @@ private:
 com::sun::star::beans::XPropertyChangeListener  
 PropertyChangeListenersElement;
 
-typedef config_map PropertyChangeListenersElement 
+typedef std::map OUString, PropertyChangeListenersElement, 
LengthContentsCompare 
 PropertyChangeListeners;
 
 typedef
@@ -545,7 +545,7 @@ private:
 com::sun::star::beans::XVetoableChangeListener  
 VetoableChangeListenersElement;
 
-typedef config_map VetoableChangeListenersElement 
+typedef std::map OUString, VetoableChangeListenersElement, 
LengthContentsCompare 
 VetoableChangeListeners;
 
 typedef
diff --git a/configmgr/source/components.hxx b/configmgr/source/components.hxx
index 48c1f7a..abd40b8 100644
--- a/configmgr/source/components.hxx
+++ b/configmgr/source/components.hxx
@@ -148,9 +148,8 @@ private:
 typedef std::set RootAccess *  WeakRootSet;
 
 typedef
-config_map
-com::sun::star::uno::Reference
-com::sun::star::beans::XPropertySet  
+std::map OUString, com::sun::star::uno::Reference
+com::sun::star::beans::XPropertySet , LengthContentsCompare 
 ExternalServices;
 
 class WriteThread;
diff --git a/configmgr/source/config_map.hxx b/configmgr/source/config_map.hxx
index 0e9f614..943d409 100644
--- a/configmgr/source/config_map.hxx
+++ b/configmgr/source/config_map.hxx
@@ -9,7 +9,6 @@
 #ifndef CONFIG_MAP_HXX
 #define CONFIG_MAP_HXX
 
-#include map
 #include rtl/ustring.hxx
 
 // The realisation here is that while a map is a reasonably compact
@@ -28,8 +27,6 @@ struct LengthContentsCompare
 }
 };
 
-template class T  struct config_map : public std::map OUString, T, 
LengthContentsCompare  { };
-
 #endif // CONFIG_MAP_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/configmgr/source/data.hxx b/configmgr/source/data.hxx
index 17a0e1d..3dd8d08 100644
--- a/configmgr/source/data.hxx
+++ b/configmgr/source/data.hxx
@@ -86,7 +86,7 @@ struct Data: private boost::noncopyable {
 OUString const  url);
 
 private:
-typedef config_map rtl::Reference ExtensionXcu  
+typedef std::map OUString, rtl::Reference ExtensionXcu , 
LengthContentsCompare 
 ExtensionXcuAdditions;
 
 rtl::Reference Node  root_;
diff --git a/configmgr/source/nodemap.hxx b/configmgr/source/nodemap.hxx
index a000b30..1c01aa3 100644
--- a/configmgr/source/nodemap.hxx
+++ b/configmgr/source/nodemap.hxx
@@ -21,13 +21,14 @@
 #define INCLUDED_CONFIGMGR_SOURCE_NODEMAP_HXX
 
 #include sal/config.h
+#include map
 #include config_map.hxx
 #include rtl/ref.hxx
 #include node.hxx
 
 namespace configmgr {
 
-typedef config_map rtl::Reference Node   NodeMapImpl;
+typedef std::map OUString, rtl::Reference Node , LengthContentsCompare  
NodeMapImpl;
 class NodeMap
 {
 NodeMapImpl maImpl;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Changes to 'feature/opengl-canvas-rework'

2014-10-20 Thread Michael Jaumann
New branch 'feature/opengl-canvas-rework' available with the following commits:
commit 242902d60797dd69a42fcd4b4e3024e4377c334f
Author: Michael Jaumann meta_...@yahoo.com
Date:   Mon Oct 20 08:46:48 2014 +

replaced fixed pipeline in ogl_canvashelper

Change-Id: I380dd31636df8b125166ac6cdf2e00b0d263e15f

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: jvmfwk/plugins

2014-10-20 Thread Stephan Bergmann
 jvmfwk/plugins/sunmajor/pluginlib/util.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e3dc8cb177a3ab6a4fb47018763a08ada8eccaf9
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Oct 20 11:02:44 2014 +0200

Missing 

Change-Id: I5d596f85fe11bc9336e1669d571795f3dfc70c6c

diff --git a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
index 6d46121..8bf31e7 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
@@ -1239,7 +1239,7 @@ void 
createJavaInfoDirScan(vectorrtl::ReferenceVendorBase  vecInfos)
 JFW_TRACE2(Could not read directory   usDir2   
because of missing access rights);
 continue;
 default:
-JFW_TRACE2(Could not read directory  usDir2  . 
Osl file error:   openErr);
+JFW_TRACE2(Could not read directory   usDir2  . 
Osl file error:   openErr);
 continue;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 11 commits - filter/CppunitTest_filter_eps_test.mk filter/Module_filter.mk filter/qa filter/source forms/source include/filter sd/source svx/source vcl/source xmlsecuri

2014-10-20 Thread Caolán McNamara
 filter/CppunitTest_filter_eps_test.mk   |   45 +
 filter/Module_filter.mk |1 
 filter/qa/cppunit/data/eps/fail/CVE-2009-4195-1.eps |binary
 filter/qa/cppunit/data/eps/indeterminate/.gitignore |1 
 filter/qa/cppunit/data/eps/pass/CVE-2013-4979-1.eps |binary
 filter/qa/cppunit/data/eps/pass/fdo13433-4.eps  |  667 
 filter/qa/cppunit/filters-eps-test.cxx  |   71 ++
 filter/source/msfilter/escherex.cxx |4 
 filter/source/msfilter/svdfppt.cxx  |5 
 forms/source/component/DatabaseForm.cxx |   18 
 forms/source/component/FormComponent.cxx|   12 
 include/filter/msfilter/svdfppt.hxx |2 
 sd/source/filter/ppt/pptinanimations.cxx|2 
 svx/source/svdraw/svdoashp.cxx  |3 
 svx/source/xoutdev/_xoutbmp.cxx |7 
 vcl/source/filter/wmf/winwmf.cxx|   64 +
 xmlsecurity/source/xmlsec/nss/nssinitializer.cxx|2 
 17 files changed, 877 insertions(+), 27 deletions(-)

New commits:
commit 87118d5adf92124450ba688f2643cc9447304976
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 20 10:45:44 2014 +0100

coverity#735638 Division or modulo by float zero

Change-Id: I2f183bc0bb9c67e3873e13a4bdbc57be9471b8a3

diff --git a/svx/source/svdraw/svdoashp.cxx b/svx/source/svdraw/svdoashp.cxx
index 021e9a0..3f8b1fd 100644
--- a/svx/source/svdraw/svdoashp.cxx
+++ b/svx/source/svdraw/svdoashp.cxx
@@ -2484,7 +2484,8 @@ Rectangle SdrObjCustomShape::ImpCalculateTextFrame( const 
bool bHgt, const bool
 Rectangle aAdjustedTextRect( aNewTextRect );// 
- new text rectangle is being tested by AdjustTextFrameWidthAndHeight to ensure
 if ( AdjustTextFrameWidthAndHeight( aAdjustedTextRect, bHgt, bWdt ) )   // 
   that the new text rectangle is matching the current text size from the 
outliner
 {
-if ( ( aAdjustedTextRect != aNewTextRect )  ( aOldTextRect != 
aAdjustedTextRect ) )
+if (aAdjustedTextRect != aNewTextRect  aOldTextRect != 
aAdjustedTextRect 
+aNewTextRect.GetWidth()  aNewTextRect.GetHeight())
 {
 aReturnValue = aRect;
 double fXScale = (double)aOldTextRect.GetWidth() / 
(double)aNewTextRect.GetWidth();
commit 90fbb7086c711dbb21770f5d364bdb0abc909573
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 20 10:43:44 2014 +0100

coverity#735639 Division or modulo by float zero

Change-Id: I2ba45c49fb00fdd53b8e388e25df503e82c2332e

diff --git a/svx/source/xoutdev/_xoutbmp.cxx b/svx/source/xoutdev/_xoutbmp.cxx
index da0ca01..0a16759 100644
--- a/svx/source/xoutdev/_xoutbmp.cxx
+++ b/svx/source/xoutdev/_xoutbmp.cxx
@@ -494,11 +494,12 @@ Polygon XOutBitmap::GetCountour( const Bitmap rBmp, 
const sal_uIntPtr nFlags,
 
 BitmapReadAccess* pAcc = aWorkBmp.AcquireReadAccess();
 
-if( pAcc )
+const long nWidth = pAcc ? pAcc-Width() : 0;
+const long nHeight = pAcc ? pAcc-Height() : 0;
+
+if (pAcc  nWidth  nHeight)
 {
 const Size rPrefSize = aWorkBmp.GetPrefSize();
-const long  nWidth = pAcc-Width();
-const long  nHeight = pAcc-Height();
 const doublefFactorX = (double) rPrefSize.Width() / nWidth;
 const doublefFactorY = (double) rPrefSize.Height() / 
nHeight;
 const long  nStartX1 = aWorkRect.Left() + 1L;
commit 366c658c77d02fd8d82116ca49640ee87c92f933
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 20 09:46:01 2014 +0100

add CVE-2013-4979 test

Change-Id: I54025f46394ec1b16443ba75ff9edf9d8e1f6738

diff --git a/filter/qa/cppunit/data/eps/pass/CVE-2013-4979-1.eps 
b/filter/qa/cppunit/data/eps/pass/CVE-2013-4979-1.eps
new file mode 100644
index 000..ae6c6aa
Binary files /dev/null and 
b/filter/qa/cppunit/data/eps/pass/CVE-2013-4979-1.eps differ
commit 069485673730ec003f53e2fc9697ee29732f8ba6
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 20 09:33:49 2014 +0100

add eps import regression test

Change-Id: Iba88c7e54ba83132a859124d51f88be72cb3e3e1

diff --git a/filter/CppunitTest_filter_eps_test.mk 
b/filter/CppunitTest_filter_eps_test.mk
new file mode 100644
index 000..89d1102
--- /dev/null
+++ b/filter/CppunitTest_filter_eps_test.mk
@@ -0,0 +1,45 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_CppunitTest_CppunitTest,filter_eps_test))
+
+$(eval $(call gb_CppunitTest_use_external,filter_eps_test,boost_headers))
+
+$(eval $(call 

[Libreoffice-commits] core.git: include/rsc

2014-10-20 Thread Adam Co
 include/rsc/rsc-vcl-shared-types.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit eb7aa9f1fa58ff43d4a974aec868f627755ce152
Author: Adam Co rattles2...@gmail.com
Date:   Mon Oct 20 13:37:51 2014 +0300

fix problem with gcc compiler complaining on variable type

Change-Id: I9a16e24e79d22b0af1710d6ac25eaa5fb19c71ff
Reviewed-on: https://gerrit.libreoffice.org/12047
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com

diff --git a/include/rsc/rsc-vcl-shared-types.hxx 
b/include/rsc/rsc-vcl-shared-types.hxx
index 1c14412..1da829d 100644
--- a/include/rsc/rsc-vcl-shared-types.hxx
+++ b/include/rsc/rsc-vcl-shared-types.hxx
@@ -49,7 +49,7 @@ typedef sal_uInt16 MenuItemBits;
 #define MIB_ICON((MenuItemBits)0x0080)
 #define MIB_TEXT((MenuItemBits)0x0100)
 
-enum class ToolBoxItemBits : sal_uInt16
+enum class ToolBoxItemBits
 {
 NONE= 0x,
 CHECKABLE   = 0x0001,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: include/unotools unotools/source vcl/source

2014-10-20 Thread Caolán McNamara
 include/unotools/fontdefs.hxx  |9 +++
 unotools/source/misc/fontdefs.cxx  |   67 -
 vcl/source/font/PhysicalFontCollection.cxx |   36 ---
 3 files changed, 48 insertions(+), 64 deletions(-)

New commits:
commit e12ba2eddc827e39444f5efe6107d8afe1f7aaff
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 20 11:17:56 2014 +0100

Resolves: fdo#85006 limit script stripping to known suffixes

Change-Id: I276535b007bbb5148d5937076b86da5de825

diff --git a/include/unotools/fontdefs.hxx b/include/unotools/fontdefs.hxx
index 7ac715e..e060106 100644
--- a/include/unotools/fontdefs.hxx
+++ b/include/unotools/fontdefs.hxx
@@ -83,6 +83,15 @@ UNOTOOLS_DLLPUBLIC OUString GetNextFontToken( const 
OUString rTokenStr, sal_Int
 
 UNOTOOLS_DLLPUBLIC OUString GetEnglishSearchFontName( const OUString rName );
 
+/** Strip any script font suffix from the font name
+
+Related: fdo#49271 RTF files often contain weird-ass
+Win 3.1/Win95 style fontnames which attempt to put the
+charset encoding into the filename
+http://www.webcenter.ru/~kazarn/eng/fonts_ttf.htm
+*/
+UNOTOOLS_DLLPUBLIC OUString StripScriptFromName(const OUString rName);
+
 /** Determine if the font is the special Star|Open Symbol font
 
 @param rFontName
diff --git a/unotools/source/misc/fontdefs.cxx 
b/unotools/source/misc/fontdefs.cxx
index 4f0fb08..cac720f 100644
--- a/unotools/source/misc/fontdefs.cxx
+++ b/unotools/source/misc/fontdefs.cxx
@@ -320,9 +320,43 @@ static ImplLocalizedFontName aImplLocalizedNamesList[] =
 {   NULL,   NULL },
 };
 
-OUString GetEnglishSearchFontName( const OUString rInName )
+OUString StripScriptFromName(const OUString _aName)
 {
-OUStringBuffer rName( rInName.getStr());
+// I worry that someone will have a font which *does* have
+// e.g. Greek legitimately at the end of its name :-(
+const char*suffixes[] = {  baltic,
+   ce,
+   cyr,
+   greek,
+   tur,
+   (arabic),
+   (hebrew),
+   (thai),
+   (vietnamese)
+};
+
+OUString aName = _aName;
+// These can be crazily piled up, e.g. Times New Roman CYR Greek
+bool bFinished = false;
+while (!bFinished)
+{
+bFinished = true;
+for (size_t i = 0; i  SAL_N_ELEMENTS(suffixes); ++i)
+{
+size_t nLen = strlen(suffixes[i]);
+if (aName.endsWithIgnoreAsciiCaseAsciiL(suffixes[i], nLen))
+{
+bFinished = false;
+aName = aName.copy(0, aName.getLength() - nLen);
+}
+}
+}
+return aName;
+}
+
+OUString GetEnglishSearchFontName(const OUString rInName)
+{
+OUStringBuffer rName(rInName);
 boolbNeedTranslation = false;
 sal_Int32  nLen = rName.getLength();
 
@@ -334,33 +368,8 @@ OUString GetEnglishSearchFontName( const OUString rInName 
)
  rName.truncate(i);
 
 // Remove Script at the end
-// Scriptname must be the last part of the fontname and
-// looks like fontname (scriptname). So there can only be a
-// script name at the end of the fontname, when the last char is ')'
-if ( (nLen = 3)  rName[ nLen-1 ] == ')' )
-{
-int nOpen = 1;
-sal_Int32 nTempLen = nLen-2;
-while ( nTempLen )
-{
-if ( rName[ nTempLen ] == '(' )
-{
-nOpen--;
-if ( !nOpen )
-{
-// Remove Space at the end
-if ( nTempLen  (rName[ nTempLen-1 ] == ' ') )
-nTempLen--;
-rName.truncate(nTempLen);
-nLen = nTempLen;
-break;
-}
-}
-if ( rName[ nTempLen ] == ')' )
-nOpen++;
-nTempLen--;
-}
-}
+rName = StripScriptFromName(rName.toString());
+nLen = rName.getLength();
 
 // remove all whitespaces and converts to lower case ASCII
 // TODO: better transliteration to ASCII e.g. all digits
diff --git a/vcl/source/font/PhysicalFontCollection.cxx 
b/vcl/source/font/PhysicalFontCollection.cxx
index af2440c..416cc6b 100644
--- a/vcl/source/font/PhysicalFontCollection.cxx
+++ b/vcl/source/font/PhysicalFontCollection.cxx
@@ -36,40 +36,6 @@
 
 #include PhysicalFontCollection.hxx
 
-static OUString lcl_stripCharSetFromName(const OUString _aName)
-{
-// I worry that someone will have a font which *does* have
-// e.g. Greek legitimately at the end of its name :-(
-const char*suffixes[] = {  baltic,
-   ce,
-   cyr,
-   greek,
-   tur,
-   

[Bug 65675] LibreOffice 4.2 most annoying bugs

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65675
Bug 65675 depends on bug 78784, which changed state.

Bug 78784 Summary: EDITING: Choosing Format-Layer when editing Drawing object 
causes crash
https://bugs.freedesktop.org/show_bug.cgi?id=78784

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 4 commits - include/svx svx/source xmlhelp/source

2014-10-20 Thread Noel Grandin
 include/svx/imapdlg.hxx |2 
 include/svx/sdasitm.hxx |1 
 svx/source/accessibility/AccessibleOLEShape.cxx |2 
 svx/source/accessibility/ShapeTypeHandler.cxx   |2 
 svx/source/customshapes/EnhancedCustomShape3d.cxx   |   76 
 svx/source/customshapes/EnhancedCustomShapeEngine.cxx   |   24 +-
 svx/source/customshapes/EnhancedCustomShapeFontWork.cxx |   26 +-
 svx/source/dialog/_bmpmask.cxx  |   28 +--
 svx/source/dialog/compressgraphicdialog.cxx |2 
 svx/source/dialog/connctrl.cxx  |4 
 svx/source/dialog/contwnd.cxx   |4 
 svx/source/dialog/dlgctl3d.cxx  |   48 ++---
 svx/source/dialog/dlgctrl.cxx   |8 
 svx/source/dialog/docrecovery.cxx   |2 
 svx/source/dialog/fntctrl.cxx   |   78 
 svx/source/dialog/fontwork.cxx  |2 
 svx/source/dialog/hdft.cxx  |   68 +++
 svx/source/dialog/imapdlg.cxx   |2 
 svx/source/dialog/imapwnd.cxx   |   34 +--
 svx/source/dialog/optgrid.cxx   |8 
 svx/source/dialog/rubydialog.cxx|4 
 svx/source/dialog/rulritem.cxx  |   38 ++--
 svx/source/dialog/srchctrl.cxx  |4 
 svx/source/dialog/srchdlg.cxx   |   52 ++---
 svx/source/dialog/svxgrahicitem.cxx |2 
 svx/source/dialog/txencbox.cxx  |6 
 svx/source/engine3d/float3d.cxx |   94 +-
 svx/source/fmcomp/fmgridcl.cxx  |   16 -
 svx/source/fmcomp/fmgridif.cxx  |   60 +++---
 svx/source/fmcomp/gridcell.cxx  |  114 ++--
 svx/source/fmcomp/gridctrl.cxx  |   44 ++--
 svx/source/form/datanavi.cxx|6 
 svx/source/form/filtnav.cxx |   26 +-
 svx/source/form/fmPropBrw.cxx   |4 
 svx/source/form/fmexpl.cxx  |8 
 svx/source/form/fmitems.cxx |2 
 svx/source/form/fmmodel.cxx |4 
 svx/source/form/fmobj.cxx   |2 
 svx/source/form/fmpage.cxx  |6 
 svx/source/form/fmpgeimp.cxx|4 
 svx/source/form/fmshell.cxx |2 
 svx/source/form/fmsrcimp.cxx|4 
 svx/source/form/fmtextcontrolshell.cxx  |8 
 svx/source/form/fmundo.cxx  |4 
 svx/source/form/fmview.cxx  |4 
 svx/source/form/fmvwimp.cxx |6 
 svx/source/form/formcontroller.cxx  |   12 -
 svx/source/form/navigatortree.cxx   |   18 -
 svx/source/form/navigatortreemodel.cxx  |   30 +--
 svx/source/form/tabwin.cxx  |4 
 svx/source/form/tbxform.cxx |6 
 svx/source/inc/filtnav.hxx  |2 
 svx/source/items/algitem.cxx|8 
 svx/source/items/customshapeitem.cxx|   20 ++
 svx/source/items/hlnkitem.cxx   |4 
 svx/source/items/numinf.cxx |2 
 svx/source/items/ofaitem.cxx|2 
 svx/source/items/pageitem.cxx   |2 
 svx/source/items/viewlayoutitem.cxx |2 
 svx/source/items/zoomslideritem.cxx |2 
 svx/source/mnuctrls/fntctl.cxx  |2 
 svx/source/mnuctrls/fntszctl.cxx|6 
 svx/source/sdr/primitive3d/sdrattributecreator3d.cxx|   28 +--
 svx/source/sdr/properties/attributeproperties.cxx   |   20 +-
 svx/source/sdr/properties/captionproperties.cxx |4 
 svx/source/sdr/properties/circleproperties.cxx  |6 
 svx/source/sdr/properties/connectorproperties.cxx   |4 
 svx/source/sdr/properties/e3dcompoundproperties.cxx |6 
 svx/source/sdr/properties/e3dextrudeproperties.cxx  |2 
 svx/source/sdr/properties/e3dlatheproperties.cxx|2 
 svx/source/sdr/properties/e3dproperties.cxx |4 
 svx/source/sdr/properties/e3dsceneproperties.cxx|   20 +-
 svx/source/sdr/properties/e3dsphereproperties.cxx   |2 
 svx/source/sdr/properties/graphicproperties.cxx |4 
 svx/source/sdr/properties/groupproperties.cxx   |   16 -
 

[Libreoffice-commits] core.git: configmgr/source

2014-10-20 Thread Stephan Bergmann
 configmgr/source/access.hxx |8 
 configmgr/source/components.hxx |5 +++--
 configmgr/source/config_map.hxx |3 +++
 configmgr/source/data.hxx   |2 +-
 configmgr/source/nodemap.hxx|3 +--
 5 files changed, 12 insertions(+), 9 deletions(-)

New commits:
commit 9df18fd92c0eb3153576f60b4b95a8cf96469eef
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Oct 20 13:38:12 2014 +0200

Revert fdo#75757: remove inheritance to std::map

This reverts commit a2deca9d755710bd543fd0caaea0352ac746396d: config_map had
been introduced on purpose with bfb978334cea775b8ae5c40ceea050ea0660d80a
configmgr: faster / simpler compare for keys.

Change-Id: I3ae0edc4d23977c6537bd2f462f90a702266de6d

diff --git a/configmgr/source/access.hxx b/configmgr/source/access.hxx
index d8db2a8..807f2a2 100644
--- a/configmgr/source/access.hxx
+++ b/configmgr/source/access.hxx
@@ -487,7 +487,7 @@ private:
 bool theDirectlyModified);
 };
 
-typedef std::map OUString, ModifiedChild, LengthContentsCompare  
ModifiedChildren;
+typedef config_map ModifiedChild  ModifiedChildren;
 
 rtl::Reference ChildAccess  getModifiedChild(
 ModifiedChildren::iterator const  childIterator);
@@ -516,7 +516,7 @@ private:
 
 rtl::Reference Access  getNotificationRoot();
 
-typedef std::map OUString, ChildAccess *, LengthContentsCompare  
WeakChildMap;
+typedef config_map ChildAccess *  WeakChildMap;
 
 typedef
 std::multiset
@@ -536,7 +536,7 @@ private:
 com::sun::star::beans::XPropertyChangeListener  
 PropertyChangeListenersElement;
 
-typedef std::map OUString, PropertyChangeListenersElement, 
LengthContentsCompare 
+typedef config_map PropertyChangeListenersElement 
 PropertyChangeListeners;
 
 typedef
@@ -545,7 +545,7 @@ private:
 com::sun::star::beans::XVetoableChangeListener  
 VetoableChangeListenersElement;
 
-typedef std::map OUString, VetoableChangeListenersElement, 
LengthContentsCompare 
+typedef config_map VetoableChangeListenersElement 
 VetoableChangeListeners;
 
 typedef
diff --git a/configmgr/source/components.hxx b/configmgr/source/components.hxx
index abd40b8..48c1f7a 100644
--- a/configmgr/source/components.hxx
+++ b/configmgr/source/components.hxx
@@ -148,8 +148,9 @@ private:
 typedef std::set RootAccess *  WeakRootSet;
 
 typedef
-std::map OUString, com::sun::star::uno::Reference
-com::sun::star::beans::XPropertySet , LengthContentsCompare 
+config_map
+com::sun::star::uno::Reference
+com::sun::star::beans::XPropertySet  
 ExternalServices;
 
 class WriteThread;
diff --git a/configmgr/source/config_map.hxx b/configmgr/source/config_map.hxx
index 943d409..0e9f614 100644
--- a/configmgr/source/config_map.hxx
+++ b/configmgr/source/config_map.hxx
@@ -9,6 +9,7 @@
 #ifndef CONFIG_MAP_HXX
 #define CONFIG_MAP_HXX
 
+#include map
 #include rtl/ustring.hxx
 
 // The realisation here is that while a map is a reasonably compact
@@ -27,6 +28,8 @@ struct LengthContentsCompare
 }
 };
 
+template class T  struct config_map : public std::map OUString, T, 
LengthContentsCompare  { };
+
 #endif // CONFIG_MAP_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/configmgr/source/data.hxx b/configmgr/source/data.hxx
index 3dd8d08..17a0e1d 100644
--- a/configmgr/source/data.hxx
+++ b/configmgr/source/data.hxx
@@ -86,7 +86,7 @@ struct Data: private boost::noncopyable {
 OUString const  url);
 
 private:
-typedef std::map OUString, rtl::Reference ExtensionXcu , 
LengthContentsCompare 
+typedef config_map rtl::Reference ExtensionXcu  
 ExtensionXcuAdditions;
 
 rtl::Reference Node  root_;
diff --git a/configmgr/source/nodemap.hxx b/configmgr/source/nodemap.hxx
index 1c01aa3..a000b30 100644
--- a/configmgr/source/nodemap.hxx
+++ b/configmgr/source/nodemap.hxx
@@ -21,14 +21,13 @@
 #define INCLUDED_CONFIGMGR_SOURCE_NODEMAP_HXX
 
 #include sal/config.h
-#include map
 #include config_map.hxx
 #include rtl/ref.hxx
 #include node.hxx
 
 namespace configmgr {
 
-typedef std::map OUString, rtl::Reference Node , LengthContentsCompare  
NodeMapImpl;
+typedef config_map rtl::Reference Node   NodeMapImpl;
 class NodeMap
 {
 NodeMapImpl maImpl;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sw/CppunitTest_sw_htmlexport.mk sw/qa sw/source

2014-10-20 Thread Marco Cecchetti
 sw/CppunitTest_sw_htmlexport.mk   |1 
 sw/qa/extras/htmlexport/data/checkbox-radiobutton.doc |binary
 sw/qa/extras/htmlexport/htmlexport.cxx|   20 ++
 sw/source/filter/html/htmlforw.cxx|5 +++-
 4 files changed, 25 insertions(+), 1 deletion(-)

New commits:
commit 7a4d272bc2220afd365d2f324b2aaaccaa16a39e
Author: Marco Cecchetti mrcek...@gmail.com
Date:   Fri Oct 3 15:45:17 2014 +0200

html export: Fix export of checked checkbox and radiobutton.

Change-Id: Ia77f9840df7508d96292aac63e65714a7892342f
Reviewed-on: https://gerrit.libreoffice.org/12049
Reviewed-by: Jan Holesovsky ke...@collabora.com
Tested-by: Jan Holesovsky ke...@collabora.com

diff --git a/sw/CppunitTest_sw_htmlexport.mk b/sw/CppunitTest_sw_htmlexport.mk
index d190050..72a9fda 100644
--- a/sw/CppunitTest_sw_htmlexport.mk
+++ b/sw/CppunitTest_sw_htmlexport.mk
@@ -55,6 +55,7 @@ $(eval $(call gb_CppunitTest_use_components,sw_htmlexport,\
canvas/source/factory/canvasfactory \
 comphelper/util/comphelp \
 configmgr/source/configmgr \
+dbaccess/util/dba \
 embeddedobj/util/embobj \
 filter/source/config/cache/filterconfig1 \
 filter/source/storagefilterdetect/storagefd \
diff --git a/sw/qa/extras/htmlexport/data/checkbox-radiobutton.doc 
b/sw/qa/extras/htmlexport/data/checkbox-radiobutton.doc
new file mode 100644
index 000..17162a4
Binary files /dev/null and 
b/sw/qa/extras/htmlexport/data/checkbox-radiobutton.doc differ
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx 
b/sw/qa/extras/htmlexport/htmlexport.cxx
index 94fb667..9e666a8 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -164,6 +164,26 @@ DECLARE_HTMLEXPORT_TEST(testSkipImageEmbeddedDocument, 
skipimage-embedded-docum
 
 #endif
 
+DECLARE_HTMLEXPORT_TEST(testExportCheckboxRadioButtonState, 
checkbox-radiobutton.doc)
+{
+htmlDocPtr pDoc = parseHtml(maTempFile);
+CPPUNIT_ASSERT(pDoc);
+
+assertXPath(pDoc, /html/body, 1);
+assertXPath(pDoc, /html/body/p[1]/input, type, checkbox);
+assertXPath(pDoc, /html/body/p[1]/input, checked, checked);
+assertXPath(pDoc, /html/body/p[2]/input, type, checkbox);
+assertXPathNoAttribute(pDoc, /html/body/p[2]/input, checked);
+assertXPath(pDoc, /html/body/form/p[1]/input, type, checkbox);
+assertXPath(pDoc, /html/body/form/p[1]/input, checked, checked);
+assertXPath(pDoc, /html/body/form/p[2]/input, type, checkbox);
+assertXPathNoAttribute(pDoc, /html/body/form/p[2]/input, checked);
+assertXPath(pDoc, /html/body/form/p[3]/input, type, radio);
+assertXPath(pDoc, /html/body/form/p[3]/input, checked, checked);
+assertXPath(pDoc, /html/body/form/p[4]/input, type, radio);
+assertXPathNoAttribute(pDoc, /html/body/form/p[4]/input, checked);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/html/htmlforw.cxx 
b/sw/source/filter/html/htmlforw.cxx
index 91eec2d..7b226e9 100644
--- a/sw/source/filter/html/htmlforw.cxx
+++ b/sw/source/filter/html/htmlforw.cxx
@@ -760,6 +760,9 @@ Writer OutHTML_DrawFrmFmtAsControl( Writer rWrt,
 TRISTATE_FALSE != *(sal_Int16*) aTmp.getValue() )
 {
 sOptions +=   + OString(OOO_STRING_SVTOOLS_HTML_O_checked);
+sOptions += =\;
+sOptions += OString(OOO_STRING_SVTOOLS_HTML_O_checked);
+sOptions += \;
 }
 
 aTmp = xPropSet-getPropertyValue(
@@ -987,7 +990,7 @@ Writer OutHTML_DrawFrmFmtAsControl( Writer rWrt,
 sOut = \;
 }
 
-sOut = sOptions;
+sOut +=   + sOptions;
 
 if( TYPE_IMAGE == eType )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Bug 75025] LibreOffice 4.3 most annoying bugs

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75025

Timur gti...@gmail.com changed:

   What|Removed |Added

 Depends on||61410

--- Comment #75 from Timur gti...@gmail.com ---
Since 4.2 is close to EoL, I add Bug 61410 - Save ODT as DOC or DOCX turns on
Show Changes when Record Changes also on here. It can confuse some users.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 75025] LibreOffice 4.3 most annoying bugs

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75025

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 Depends on|61410   |

--- Comment #76 from tommy27 ba...@quipo.it ---
(In reply to Timur from comment #75)
 Since 4.2 is close to EoL, I add Bug 61410 - Save ODT as DOC or DOCX turns
 on Show Changes when Record Changes also on here. It can confuse some users.

please do not file 4.2.x bugs into the mab4.3 list until the real EOL of the
4.2.x branch is reached which is november 2014.

I'm removing it from the 4.3.x list.
if you will file that bug in the mab4.2 list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 3 commits - config_host.mk.in configure.ac external/Module_external.mk filter/Configuration_filter.mk filter/source Makefile.fetch RepositoryExternal.mk writerperfect/L

2014-10-20 Thread David Tardon
 Makefile.fetch  |2 
 RepositoryExternal.mk   |   16 
 config_host.mk.in   |4 
 configure.ac|   35 +
 external/Module_external.mk |2 
 filter/Configuration_filter.mk  |2 
 filter/source/config/fragments/filters/ClarisWorks_Impress.xcu  |   30 +
 filter/source/config/fragments/types/impress_ClarisWorks.xcu|   29 +
 writerperfect/Library_wpftimpress.mk|3 
 writerperfect/qa/unit/WpftImpressFilterTest.cxx |1 
 writerperfect/qa/unit/data/impress/libmwaw/pass/ClarisWorks_6.0.cwk |binary
 writerperfect/source/impress/ImportFilterBase.cxx   |  248 
++
 writerperfect/source/impress/ImportFilterBase.hxx   |  113 
 writerperfect/source/impress/KeynoteImportFilter.cxx|  156 
--
 writerperfect/source/impress/KeynoteImportFilter.hxx|   41 -
 writerperfect/source/impress/MWAWPresentationImportFilter.cxx   |  181 
+++
 writerperfect/source/impress/MWAWPresentationImportFilter.hxx   |   53 ++
 writerperfect/source/impress/wpftimpress.component  |4 
 writerperfect/source/impress/wpftimpress_genericfilter.cxx  |7 
 19 files changed, 744 insertions(+), 183 deletions(-)

New commits:
commit f24c60870531689d95c056037e48cd29ad1d17bb
Author: David Tardon dtar...@redhat.com
Date:   Mon Oct 20 14:21:22 2014 +0200

allow to build with system opencollada

Change-Id: I6101099c57d429987e06bca0652c843f4a94f8cc

diff --git a/Makefile.fetch b/Makefile.fetch
index e8ccf5b..18b12be 100644
--- a/Makefile.fetch
+++ b/Makefile.fetch
@@ -184,7 +184,7 @@ $(WORKDIR)/download: $(BUILDDIR)/config_host.mk 
$(SRCDIR)/download.lst $(SRCDIR)
$(call fetch_Optional,NSS,NSS_TARBALL) \
$(call fetch_Optional_pack,NUMBERTEXT_EXTENSION_PACK) \
$(call fetch_Optional,ODFGEN,ODFGEN_TARBALL) \
-   $(call fetch_Optional,COLLADA2GLTF,OPENCOLLADA_TARBALL) \
+   $(call fetch_Optional,OPENCOLLADA,OPENCOLLADA_TARBALL) \
$(call fetch_Optional,OPENLDAP,OPENLDAP_TARBALL) \
$(call fetch_Optional,OPENSSL,OPENSSL_TARBALL) \
$(call fetch_Optional,ORCUS,ORCUS_TARBALL) \
diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 5277aea..911dab1 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -3371,6 +3371,20 @@ endif # SYSTEN_LIBGLTF
 
 ifeq ($(ENABLE_COLLADA),TRUE)
 
+ifeq ($(SYSTEM_OPENCOLLADA),TRUE)
+
+define gb_LinkTarget__use_opencollada_parser
+$(call gb_LinkTarget_set_include,$(1),\
+   $$(INCLUDE) \
+   $(OPENCOLLADA_CFLAGS) \
+)
+
+$(call gb_LinkTarget_add_libs,$(1),$(OPENCOLLADA_LIBS))
+
+endef
+
+else # !SYSTEM_OPENCOLLADA
+
 define gb_LinkTarget__use_opencollada_parser
 $(call gb_LinkTarget_set_include,$(1),\
-I$(call 
gb_UnpackedTarball_get_dir,opencollada)/COLLADABaseUtils/include \
@@ -3385,6 +3399,8 @@ $(call gb_LinkTarget_use_static_libraries,$(1),\
 )
 endef
 
+endif # SYSTEM_OPENCOLLADA
+
 define gb_LinkTarget__use_collada2gltf
 $(call gb_LinkTarget_set_include,$(1),\
-I$(call gb_UnpackedTarball_get_dir,collada2gltf) \
diff --git a/config_host.mk.in b/config_host.mk.in
index 0fefbb0..738c80c 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -431,7 +431,8 @@ export OOOP_SAMPLES_PACK=@OOOP_SAMPLES_PACK@
 export OOOP_TEMPLATES_PACK=@OOOP_TEMPLATES_PACK@
 export OOO_JUNIT_JAR=@OOO_JUNIT_JAR@
 export OOO_VENDOR=@OOO_VENDOR@
-export OPENSSL_CFLAGS=$(gb_SPACE)@OPENSSL_CFLAGS@
+export OPENCOLLADA_CFLAGS=$(gb_SPACE)@OPENCOLLADA_CFLAGS@
+export OPENCOLLADA_LIBS=$(gb_SPACE)@OPENCOLLADA_LIBS@
 export OPENSSL_LIBS=$(gb_SPACE)@OPENSSL_LIBS@
 export ORCUS_CFLAGS=$(gb_SPACE)@ORCUS_CFLAGS@
 export ORCUS_LIBS=$(gb_SPACE)@ORCUS_LIBS@
@@ -558,6 +559,7 @@ export SYSTEM_NPAPI_HEADERS=@SYSTEM_NPAPI_HEADERS@
 export SYSTEM_NSS=@SYSTEM_NSS@
 export SYSTEM_ODBC_HEADERS=@SYSTEM_ODBC_HEADERS@
 export SYSTEM_ODFGEN=@SYSTEM_ODFGEN@
+export SYSTEM_OPENCOLLADA=@SYSTEM_OPENCOLLADA@
 export SYSTEM_OPENLDAP=@SYSTEM_OPENLDAP@
 export SYSTEM_OPENSSL=@SYSTEM_OPENSSL@
 export SYSTEM_PAGEMAKER=@SYSTEM_PAGEMAKER@
diff --git a/configure.ac b/configure.ac
index 17feb1a..5d2198b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1641,6 +1641,11 @@ AC_ARG_WITH(system-ucpp,
 [Use ucpp already on system.]),,
 [])
 
+AC_ARG_WITH(system-opencollada,
+AS_HELP_STRING([--with-system-opencollada],
+[Use openCOLLADA already on system.]),,
+[with_system_opencollada=no])
+
 AC_ARG_WITH(system-openldap,
 AS_HELP_STRING([--with-system-openldap],
 [Use the OpenLDAP LDAP SDK already on system.]),,
@@ -10342,11 

[Libreoffice-commits] core.git: Branch 'feature/opengl-canvas-rework' - canvas/opengl canvas/source

2014-10-20 Thread Michael Jaumann
 canvas/opengl/textFragmentShader.glsl   |5 +++--
 canvas/source/opengl/ogl_canvascustomsprite.cxx |   23 +--
 canvas/source/opengl/ogl_canvascustomsprite.hxx |   20 +---
 3 files changed, 37 insertions(+), 11 deletions(-)

New commits:
commit 5943fdb3dfa10268699cd55ea79aee5d1ca156fb
Author: Michael Jaumann meta_...@yahoo.com
Date:   Mon Oct 20 12:14:42 2014 +

reformating, alpha blending now in fragment shader

Change-Id: I9f1d707e2434712efb9e3e346ecf50aa9c539d5b

diff --git a/canvas/opengl/textFragmentShader.glsl 
b/canvas/opengl/textFragmentShader.glsl
index b1589c6..32a0423e 100644
--- a/canvas/opengl/textFragmentShader.glsl
+++ b/canvas/opengl/textFragmentShader.glsl
@@ -9,13 +9,14 @@
 
 #version 120 core
 
-uniform sampler2D TextTex;
+uniform sampler2D TextTex; 
+uniform vec4 colorTex;
 //Texture Coordinates
 varying vec2 textC oords;
 
 void main()
 {
-gl_FragColor = texture2D( TextTex, textCoords );
+gl_FragColor = texture2D( TextTex, textCoords )*colorTex;
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/canvas/source/opengl/ogl_canvascustomsprite.cxx 
b/canvas/source/opengl/ogl_canvascustomsprite.cxx
index cc04907..bf5f347 100644
--- a/canvas/source/opengl/ogl_canvascustomsprite.cxx
+++ b/canvas/source/opengl/ogl_canvascustomsprite.cxx
@@ -142,6 +142,8 @@ namespace oglcanvas
 m_simpleTexUnf = glGetUniformLocation(m_simpleProgID, TextTex);
 m_manCordUnf = glGetUniformLocation(m_texManProgID, texCord);
 m_texColorUnf = glGetUniformLocation(m_texProgID, constantColor);
+m_manColorUnf = glGetUniformLocation(m_texManProgID,colorTex);
+m_simpleColorUnf = glGetUniformLocation(m_simpleProgID,colorTex);
 //Gen Buffers for texturecoordinates/vertices
 glGenBuffers(1, m_vertexBuffer);
 glGenBuffers(1, m_uvBuffer);
@@ -212,8 +214,6 @@ namespace oglcanvas
 GL_ONE_MINUS_SRC_ALPHA);
 
 // blend against fixed vertex color; texture alpha is 
multiplied in
-glColor4f(1,1,1,mfAlpha);
-
 if( mxClip.is() )
 {
 const double fWidth=maSize.Width;
@@ -243,10 +243,14 @@ namespace oglcanvas
 //Bind Buffers
 glBindBuffer(GL_ARRAY_BUFFER, m_vertexBuffer);
 glBufferData(GL_ARRAY_BUFFER, sizeof(vertices), vertices, 
GL_STATIC_DRAW);
+
 glUseProgram(m_texManProgID);
+
 //Set Uniforms
 glUniform1i(m_manTexUnf, 0);
 glUniform2f(m_manCordUnf,fWidth,fHeight);
+glUniform4f(m_manColorUnf, 1, 1, 1, mfAlpha);
+
 glEnableVertexAttribArray(m_manPosAttrb);
 glBindBuffer(GL_ARRAY_BUFFER, m_vertexBuffer);
 glVertexAttribPointer(
@@ -257,7 +261,9 @@ namespace oglcanvas
 0,// stride
 (void*)0  // array buffer offset
 );
+
 glDrawArrays(GL_TRIANGLES, 0, 
rTriangulatedPolygon.count());
+
 glDisableVertexAttribArray(m_manPosAttrb);
 glUseProgram(0);
 }
@@ -265,6 +271,7 @@ namespace oglcanvas
 {
 const double fWidth=maSize.Width/aSpriteSizePixel.getX();
 const double fHeight=maSize.Height/aSpriteSizePixel.getY();
+
 GLfloat vertices[] = {0, 0,
   0, (float) aSpriteSizePixel.getY(),
   (float) aSpriteSizePixel.getX(), 0,
@@ -273,13 +280,17 @@ namespace oglcanvas
0, (float) fHeight,
(float) fWidth, 0,
(float) fWidth, (float) fHeight 
};
+
 glBindBuffer(GL_ARRAY_BUFFER, m_vertexBuffer);
 glBufferData(GL_ARRAY_BUFFER, sizeof(vertices), vertices, 
GL_STATIC_DRAW);
+
 glBindBuffer(GL_ARRAY_BUFFER, m_uvBuffer);
 glBufferData(GL_ARRAY_BUFFER, sizeof(uvCoordinates), 
uvCoordinates, GL_STATIC_DRAW);
 
 glUseProgram(m_simpleProgID);
+
 glUniform1i(m_simpleTexUnf, 0);
+glUniform4f(m_simpleColorUnf, 1, 1, 1, mfAlpha);
 
 glEnableVertexAttribArray(m_simplePosAttrb); //richtige ID 
herausfinden
 glBindBuffer(GL_ARRAY_BUFFER, m_vertexBuffer);
@@ -302,7 +313,9 @@ namespace oglcanvas
 0,// stride
 (void*)0  // array buffer offset
 );
+
 glDrawArrays(GL_TRIANGLE_STRIP, 0, 4);

[Libreoffice-commits] core.git: sw/qa writerfilter/source

2014-10-20 Thread Miklos Vajna
 sw/qa/extras/ooxmlexport/data/page-break-before.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport.cxx |9 -
 writerfilter/source/dmapper/DomainMapper.cxx |5 +
 3 files changed, 9 insertions(+), 5 deletions(-)

New commits:
commit 382bab9412b87f82da82276332496eb28b28d4f3
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Mon Oct 20 14:43:42 2014 +0200

DOCX import: fix w:pageBreakBefore wrt. inherited styles

We used to ignore this element with a false logical attribute, but
that causes a problem when an inherited style wants to explicitly
disable this element from a parent style.

Change-Id: I2fc4c5b2002987d44679d863ea3f19114b9ab7a4

diff --git a/sw/qa/extras/ooxmlexport/data/page-break-before.docx 
b/sw/qa/extras/ooxmlexport/data/page-break-before.docx
new file mode 100644
index 000..99d8c3a
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/page-break-before.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index b35f97b..3d76287 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
@@ -11,9 +11,10 @@
 
 #include com/sun/star/awt/XBitmap.hpp
 #include com/sun/star/graphic/XGraphic.hpp
+#include com/sun/star/style/BreakType.hpp
+#include com/sun/star/text/FontEmphasis.hpp
 #include com/sun/star/text/HoriOrientation.hpp
 #include com/sun/star/text/XTextRangeCompare.hpp
-#include com/sun/star/text/FontEmphasis.hpp
 
 #include string
 
@@ -493,6 +494,12 @@ DECLARE_OOXMLEXPORT_TEST(testParagraphMark, 
paragraph-mark.docx)
 CPPUNIT_ASSERT_EQUAL(OUString(Emphasis), 
getPropertyOUString(getRun(getParagraph(1), 1), CharStyleName));
 }
 
+DECLARE_OOXMLEXPORT_TEST(testPageBreakBefore, page-break-before.docx)
+{
+// This was style::BreakType_PAGE_BEFORE, i.e. page break wasn't ignored, 
as it should have been.
+CPPUNIT_ASSERT_EQUAL(style::BreakType_NONE, 
getPropertystyle::BreakType(getParagraph(2), BreakType));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 45fb28f..12763b9 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -1135,10 +1135,7 @@ void DomainMapper::sprmWithProps( Sprm rSprm, 
PropertyMapPtr rContext )
 rContext-Insert(PROP_PARA_KEEP_TOGETHER, uno::makeAny( nIntValue ? 
true : false) );
 break;
 case NS_ooxml::LN_CT_PPrBase_pageBreakBefore:
-if ( nIntValue == 1 )
-{
-rContext-Insert(PROP_BREAK_TYPE, uno::makeAny( 
com::sun::star::style::BreakType_PAGE_BEFORE ) );
-}
+rContext-Insert(PROP_BREAK_TYPE, uno::makeAny(nIntValue ? 
style::BreakType_PAGE_BEFORE : style::BreakType_NONE));
 break;
 case NS_ooxml::LN_CT_NumPr_ilvl:
 if (nIntValue  0 || 10 = nIntValue) // Writer can't do everything
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - a9/2c8ad51f2b75a3ae40f171cb5445c2d6791c08

2014-10-20 Thread Caolán McNamara
 a9/2c8ad51f2b75a3ae40f171cb5445c2d6791c08 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 93ea0553cb9f4c767cfe91cfe4d806ba8cac3e98
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 20 14:27:55 2014 +0100

Notes added by 'git notes add'

diff --git a/a9/2c8ad51f2b75a3ae40f171cb5445c2d6791c08 
b/a9/2c8ad51f2b75a3ae40f171cb5445c2d6791c08
new file mode 100644
index 000..a4edfa5
--- /dev/null
+++ b/a9/2c8ad51f2b75a3ae40f171cb5445c2d6791c08
@@ -0,0 +1 @@
+prefer: 083114bb132b879cfb899361ece375c8580ae505
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: chart2/uiconfig

2014-10-20 Thread Caolán McNamara
 chart2/uiconfig/ui/tp_DataSource.ui |   62 
 1 file changed, 35 insertions(+), 27 deletions(-)

New commits:
commit f9c242674094eba7ac19bd279f611dba0a8e5571
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 20 14:22:40 2014 +0100

Resolves: fdo#84885 chart wizard dialog cut off

Change-Id: Ie24687cd1c54b1fed04745c83f507c17a5574175

diff --git a/chart2/uiconfig/ui/tp_DataSource.ui 
b/chart2/uiconfig/ui/tp_DataSource.ui
index 06a01cf..8de0320 100644
--- a/chart2/uiconfig/ui/tp_DataSource.ui
+++ b/chart2/uiconfig/ui/tp_DataSource.ui
@@ -167,12 +167,13 @@
   /packing
 /child
 child
-  object class=GtkBox id=box3
+  object class=GtkGrid id=grid2
 property name=visibleTrue/property
 property name=can_focusFalse/property
+property name=valignstart/property
 property name=hexpandTrue/property
-property name=orientationvertical/property
-property name=spacing6/property
+property name=vexpandTrue/property
+property name=row_spacing6/property
 child
   object class=GtkLabel id=FT_ROLE
 property name=visibleTrue/property
@@ -183,9 +184,10 @@
 property name=mnemonic_widgetLB_ROLE:border/property
   /object
   packing
-property name=expandFalse/property
-property name=fillTrue/property
-property name=position0/property
+property name=left_attach0/property
+property name=top_attach0/property
+property name=width1/property
+property name=height1/property
   /packing
 /child
 child
@@ -193,16 +195,18 @@
 property name=width_request440/property
 property name=height_request100/property
 property name=visibleTrue/property
-property name=can_focusFalse/property
+property name=can_focusTrue/property
 property name=hexpandTrue/property
+property name=vexpandTrue/property
 child internal-child=selection
-  object class=GtkTreeSelection id=Tab List-selection1/
+  object class=GtkTreeSelection id=Tab List-selection/
 /child
   /object
   packing
-property name=expandFalse/property
-property name=fillTrue/property
-property name=position1/property
+property name=left_attach0/property
+property name=top_attach1/property
+property name=width1/property
+property name=height1/property
   /packing
 /child
 child
@@ -215,9 +219,10 @@
 property name=mnemonic_widgetEDT_RANGE/property
   /object
   packing
-property name=expandFalse/property
-property name=fillTrue/property
-property name=position2/property
+property name=left_attach0/property
+property name=top_attach2/property
+property name=width1/property
+property name=height1/property
   /packing
 /child
 child
@@ -229,7 +234,7 @@
 child
   object class=GtkEntry id=EDT_RANGE
 property name=visibleTrue/property
-property name=can_focusFalse/property
+property name=can_focusTrue/property
 property name=hexpandTrue/property
 property name=invisible_char•/property
   /object
@@ -243,7 +248,7 @@
   object class=GtkButton id=IMB_RANGE_MAIN
 property name=use_action_appearanceFalse/property
 property name=visibleTrue/property
-property name=can_focusFalse/property
+property name=can_focusTrue/property
 property name=receives_defaultTrue/property
 property name=imageimageIMB_RANGE_MAIN/property
   /object
@@ -255,9 +260,10 @@
 /child
   /object
   packing
-property name=expandFalse/property
-property name=fillTrue/property
-property name=position3/property
+property name=left_attach0/property
+property name=top_attach3/property
+property name=width1/property
+property name=height1/property
   /packing
 /child
 child
@@ -296,9 +302,10 @@
 /child
   /object
   packing
-property name=expandFalse/property
-  

[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sfx2/inc sfx2/source sfx2/uiconfig

2014-10-20 Thread Caolán McNamara
 sfx2/inc/templatedlg.hxx|4 ++--
 sfx2/source/doc/templatedlg.cxx |4 +++-
 sfx2/uiconfig/ui/templatedlg.ui |3 +++
 3 files changed, 8 insertions(+), 3 deletions(-)

New commits:
commit 1f42f9ada97acc625548c836c838a9fcb9d9361a
Author: Caolán McNamara caol...@redhat.com
Date:   Tue Oct 14 17:25:18 2014 +0100

Resolves: fdo#72587 make template dialog Modal

(cherry picked from commit 60126254eba8a6a6b94c60b2101ee90986161e24)

Change-Id: Ifb6d7ebbe297d17fc99426b501c92daf8577dd20
Reviewed-on: https://gerrit.libreoffice.org/11978
Reviewed-by: Muthu Subramanian K muthus...@gmail.com
Reviewed-by: Adolfo Jayme Barrientos fit...@ubuntu.com
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com

diff --git a/sfx2/inc/templatedlg.hxx b/sfx2/inc/templatedlg.hxx
index 58d18cf..6731b71 100644
--- a/sfx2/inc/templatedlg.hxx
+++ b/sfx2/inc/templatedlg.hxx
@@ -39,13 +39,13 @@ namespace com {
 }   }   }
 }
 
-class SfxTemplateManagerDlg : public ModelessDialog
+class SfxTemplateManagerDlg : public ModalDialog
 {
 typedef bool (*selection_cmp_fn)(const ThumbnailViewItem*,const 
ThumbnailViewItem*);
 
 public:
 
-SfxTemplateManagerDlg (Window *parent = DIALOG_NO_PARENT);
+SfxTemplateManagerDlg(Window *parent = NULL);
 
 virtual ~SfxTemplateManagerDlg ();
 
diff --git a/sfx2/source/doc/templatedlg.cxx b/sfx2/source/doc/templatedlg.cxx
index 2f91796..94457a8 100644
--- a/sfx2/source/doc/templatedlg.cxx
+++ b/sfx2/source/doc/templatedlg.cxx
@@ -175,7 +175,7 @@ static bool cmpSelectionItems (const ThumbnailViewItem 
*pItem1, const ThumbnailV
 }
 
 SfxTemplateManagerDlg::SfxTemplateManagerDlg(Window *parent)
-: ModelessDialog(parent, TemplateDialog, sfx/ui/templatedlg.ui),
+: ModalDialog(parent, TemplateDialog, sfx/ui/templatedlg.ui),
   maSelTemplates(cmpSelectionItems),
   maSelFolders(cmpSelectionItems),
   mbIsSaveMode(false),
@@ -183,6 +183,8 @@ SfxTemplateManagerDlg::SfxTemplateManagerDlg(Window *parent)
   mbIsSynced(false),
   maRepositories()
 {
+fprintf(stderr, SfxTemplateManagerDlg::SfxTemplateManagerDlg\n);
+
 get(mpTabControl, tab_control);
 get(mpSearchEdit, search_edit);
 get(mpViewBar, action_view);
diff --git a/sfx2/uiconfig/ui/templatedlg.ui b/sfx2/uiconfig/ui/templatedlg.ui
index b6ecee8..f6bcdff 100644
--- a/sfx2/uiconfig/ui/templatedlg.ui
+++ b/sfx2/uiconfig/ui/templatedlg.ui
@@ -7,6 +7,7 @@
 property name=width_request800/property
 property name=height_request560/property
 property name=can_focusFalse/property
+property name=modalTrue/property
 child
   object class=GtkBox id=box1
 property name=visibleTrue/property
@@ -326,6 +327,7 @@
   object class=sfxlo-TemplateSearchView id=search_view
 property name=can_focusTrue/property
 property name=no_show_allTrue/property
+property name=margin0/property
 property name=hexpandTrue/property
 property name=vexpandTrue/property
   /object
@@ -339,6 +341,7 @@
   object class=sfxlo-TemplateRemoteView id=remote_view
 property name=can_focusTrue/property
 property name=no_show_allTrue/property
+property name=margin0/property
 property name=hexpandTrue/property
 property name=vexpandTrue/property
   /object
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 2 commits - sc/uiconfig vcl/source

2014-10-20 Thread Adolfo Jayme Barrientos
 sc/uiconfig/scalc/ui/advancedfilterdialog.ui|   44 --
 sc/uiconfig/scalc/ui/allheaderfooterdialog.ui   |5 
 sc/uiconfig/scalc/ui/analysisofvariancedialog.ui|   42 --
 sc/uiconfig/scalc/ui/changesourcedialog.ui  |8 
 sc/uiconfig/scalc/ui/chardialog.ui  |6 
 sc/uiconfig/scalc/ui/colorrowdialog.ui  |7 
 sc/uiconfig/scalc/ui/colwidthdialog.ui  |   12 
 sc/uiconfig/scalc/ui/condformatmanager.ui   |5 
 sc/uiconfig/scalc/ui/conditionalformatdialog.ui |6 
 sc/uiconfig/scalc/ui/conflictsdialog.ui |   13 
 sc/uiconfig/scalc/ui/consolidatedialog.ui   |   43 --
 sc/uiconfig/scalc/ui/correlationdialog.ui   |   26 -
 sc/uiconfig/scalc/ui/covariancedialog.ui|   26 -
 sc/uiconfig/scalc/ui/createnamesdialog.ui   |   10 
 sc/uiconfig/scalc/ui/datafielddialog.ui |   39 --
 sc/uiconfig/scalc/ui/datafieldoptionsdialog.ui  |   57 ---
 sc/uiconfig/scalc/ui/datastreams.ui |   37 --
 sc/uiconfig/scalc/ui/definedatabaserangedialog.ui   |8 
 sc/uiconfig/scalc/ui/definename.ui  |   36 --
 sc/uiconfig/scalc/ui/deletecells.ui |4 
 sc/uiconfig/scalc/ui/deletecontents.ui  |  306 +---
 sc/uiconfig/scalc/ui/descriptivestatisticsdialog.ui |   26 -
 sc/uiconfig/scalc/ui/exponentialsmoothingdialog.ui  |   32 --
 sc/uiconfig/scalc/ui/externaldata.ui|   14 
 sc/uiconfig/scalc/ui/filldlg.ui |   32 --
 sc/uiconfig/scalc/ui/footerdialog.ui|5 
 sc/uiconfig/scalc/ui/formatcellsdialog.ui   |5 
 sc/uiconfig/scalc/ui/formulacalculationoptions.ui   |   84 -
 sc/uiconfig/scalc/ui/goalseekdlg.ui |   24 -
 sc/uiconfig/scalc/ui/groupbydate.ui |   51 +--
 sc/uiconfig/scalc/ui/groupbynumber.ui   |   18 -
 sc/uiconfig/scalc/ui/groupdialog.ui |6 
 sc/uiconfig/scalc/ui/headerdialog.ui|5 
 sc/uiconfig/scalc/ui/headerfooterdialog.ui  |5 
 sc/uiconfig/scalc/ui/imoptdialog.ui |   33 --
 sc/uiconfig/scalc/ui/inputstringdialog.ui   |5 
 sc/uiconfig/scalc/ui/insertcells.ui |7 
 sc/uiconfig/scalc/ui/insertname.ui  |4 
 sc/uiconfig/scalc/ui/insertsheet.ui |   31 --
 sc/uiconfig/scalc/ui/integerdialog.ui   |4 
 sc/uiconfig/scalc/ui/leftfooterdialog.ui|5 
 sc/uiconfig/scalc/ui/leftheaderdialog.ui|5 
 sc/uiconfig/scalc/ui/managenamesdialog.ui   |   32 --
 sc/uiconfig/scalc/ui/movecopysheet.ui   |   10 
 sc/uiconfig/scalc/ui/movingaveragedialog.ui |   32 --
 sc/uiconfig/scalc/ui/multipleoperationsdialog.ui|   34 --
 sc/uiconfig/scalc/ui/namerangesdialog.ui|   31 --
 sc/uiconfig/scalc/ui/nosolutiondialog.ui|8 
 sc/uiconfig/scalc/ui/optcalculatepage.ui|   40 --
 sc/uiconfig/scalc/ui/optchangespage.ui  |   29 -
 sc/uiconfig/scalc/ui/optdefaultpage.ui  |   16 -
 sc/uiconfig/scalc/ui/optformula.ui  |   56 ---
 sc/uiconfig/scalc/ui/optimalcolwidthdialog.ui   |   14 
 sc/uiconfig/scalc/ui/optimalrowheightdialog.ui  |   14 
 sc/uiconfig/scalc/ui/pagetemplatedialog.ui  |5 
 sc/uiconfig/scalc/ui/paradialog.ui  |6 
 sc/uiconfig/scalc/ui/paratemplatedialog.ui  |5 
 sc/uiconfig/scalc/ui/pastespecial.ui|   12 
 sc/uiconfig/scalc/ui/pivotfilterdialog.ui   |   47 ---
 sc/uiconfig/scalc/ui/pivottablelayoutdialog.ui  |   48 ---
 sc/uiconfig/scalc/ui/printareasdialog.ui|   24 -
 sc/uiconfig/scalc/ui/printeroptions.ui  |3 
 sc/uiconfig/scalc/ui/protectsheetdlg.ui |   17 -
 sc/uiconfig/scalc/ui/queryrunstreamscriptdialog.ui  |5 
 sc/uiconfig/scalc/ui/randomnumbergenerator.ui   |   42 --
 sc/uiconfig/scalc/ui/retypepassdialog.ui|4 
 sc/uiconfig/scalc/ui/retypepassworddialog.ui|   24 -
 sc/uiconfig/scalc/ui/rightfooterdialog.ui   |5 
 sc/uiconfig/scalc/ui/rightheaderdialog.ui   |5 
 sc/uiconfig/scalc/ui/rowheightdialog.ui |   14 
 sc/uiconfig/scalc/ui/samplingdialog.ui  |   38 --
 sc/uiconfig/scalc/ui/scenariodialog.ui  |   34 --
 sc/uiconfig/scalc/ui/scgeneralpage.ui   |   38 --
 sc/uiconfig/scalc/ui/selectdatasource.ui|   22 -
 sc/uiconfig/scalc/ui/selectsource.ui|9 
 sc/uiconfig/scalc/ui/sharedfooterdialog.ui  |5 
 sc/uiconfig/scalc/ui/sharedheaderdialog.ui  |5 
 sc/uiconfig/scalc/ui/sharedocumentdlg.ui|5 
 sc/uiconfig/scalc/ui/showchangesdialog.ui   |   24 -
 sc/uiconfig/scalc/ui/showdetaildialog.ui|4 
 

[Libreoffice-commits] core.git: forms/source

2014-10-20 Thread Stephan Bergmann
 forms/source/component/FormComponent.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 66da64c74829a68a8dc55c9380ecd6c84d0fc331
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Oct 20 15:42:36 2014 +0200

Missing include

...and only use getCaughtException as first statement in catch block.

Change-Id: Idcac073896b84fd2671b52b2315f454651dbf910

diff --git a/forms/source/component/FormComponent.cxx 
b/forms/source/component/FormComponent.cxx
index 180a2c0..b7a3a9e 100644
--- a/forms/source/component/FormComponent.cxx
+++ b/forms/source/component/FormComponent.cxx
@@ -42,6 +42,7 @@
 #include comphelper/listenernotification.hxx
 #include comphelper/property.hxx
 #include connectivity/dbtools.hxx
+#include cppuhelper/exc_hlp.hxx
 #include cppuhelper/queryinterface.hxx
 #include cppuhelper/supportsservice.hxx
 #include toolkit/helper/emptyfontdescriptor.hxx
@@ -654,10 +655,11 @@ void SAL_CALL OControlModel::setName(const OUString 
_rName) throw(RuntimeExcept
 }
 catch (const css::beans::UnknownPropertyException)
 {
+css::uno::Any a(cppu::getCaughtException());
 throw WrappedTargetRuntimeException(
 OControlModel::setName,
 *const_cast OControlModel* ( this ),
-::cppu::getCaughtException()
+a
 );
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: readlicense_oo/docs

2014-10-20 Thread Andras Timar
 readlicense_oo/docs/readme.xrm |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0c1ad017f76bdc2e7b123985516456450e2e4f17
Author: Andras Timar andras.ti...@collabora.com
Date:   Mon Oct 20 15:58:31 2014 +0200

fdo#85042 Windows XP SP2 is required

Change-Id: Ie36cc7444fe5d685393e06d3d3a3a8d827b2f775

diff --git a/readlicense_oo/docs/readme.xrm b/readlicense_oo/docs/readme.xrm
index 13ae196..ff1242f 100644
--- a/readlicense_oo/docs/readme.xrm
+++ b/readlicense_oo/docs/readme.xrm
@@ -41,7 +41,7 @@
div class=WIN id=SystemRequirements_WIN
ul
li
-   p id=s2s3sdf21 
xml:lang=en-USMicrosoft Windows XP, Vista, Windows 7, or Windows 8/p
+   p id=s2s3sdf21 
xml:lang=en-USMicrosoft Windows XP SP2, Vista, Windows 7, or Windows 8/p
/li
/ul
p class=note id=edssc3d 
xml:lang=en-USPlease be aware that administrator rights are needed for the 
installation process./p
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Changes to 'feature/opengl-vcl'

2014-10-20 Thread Robert Antoni Buj i Gelonch
New branch 'feature/opengl-vcl' available with the following commits:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: avmedia/source

2014-10-20 Thread Stephan Bergmann
 avmedia/source/quicktime/player.hxx |3 ---
 avmedia/source/quicktime/player.mm  |3 +--
 2 files changed, 1 insertion(+), 5 deletions(-)

New commits:
commit 70ae4721b9324ebc83fcd7f49f67db60982c9345
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Oct 20 16:03:43 2014 +0200

-Werror,-Wunused-private-field

Change-Id: I2e7c2206872dfe22c77555f3a14ea2a10c2453c2

diff --git a/avmedia/source/quicktime/player.hxx 
b/avmedia/source/quicktime/player.hxx
index df31ecf..73cf13d 100644
--- a/avmedia/source/quicktime/player.hxx
+++ b/avmedia/source/quicktime/player.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_AVMEDIA_SOURCE_QUICKTIME_PLAYER_HXX
 #define INCLUDED_AVMEDIA_SOURCE_QUICKTIME_PLAYER_HXX
 
-#include osl/conditn.h
 #include quicktimecommon.hxx
 
 #include com/sun/star/media/XPlayer.hpp
@@ -78,8 +77,6 @@ private:
 
 boolmbMuted;
 boolmbInitialized;
-
-oslConditionmaSizeCondition;
 };
 
 } // namespace quicktime
diff --git a/avmedia/source/quicktime/player.mm 
b/avmedia/source/quicktime/player.mm
index 403e7bf..d376459 100644
--- a/avmedia/source/quicktime/player.mm
+++ b/avmedia/source/quicktime/player.mm
@@ -40,8 +40,7 @@ Player::Player( const uno::Reference 
lang::XMultiServiceFactory  rxMgr ) :
 mnUnmutedVolume( 0 ),
 mnStopTime( DBL_MAX ),  //max double
 mbMuted( false ),
-mbInitialized( false ),
-maSizeCondition( osl_createCondition() )
+mbInitialized( false )
 {
 NSApplicationLoad();
 NSAutoreleasePool* pool = [[NSAutoreleasePool alloc] init];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Fwd: Java problem when running CppunitTest_dbaccess_dialog_save on OS X 10.10 with Oracle JDK 1.8

2014-10-20 Thread Tor Lillqvist
(Forwarding to the development list.)

On 20 October 2014 16:39, Robert Antoni Buj i Gelonch robert@gmail.com
wrote:

 Xcode doesn't include the java framework.

 jvmfwk/plugins/sunmajor/pluginlib/otherjre.cxx:
 /../../../../../Frameworks/*JavaVM*.framework/*JavaVM*  //as of
 1.6.0_22

You mean that that line used to end up referring to something that came
with an Xcode installation, but was otherwise not present? I do have
a /System/Library/Frameworks/JavaVM.framework. Probably that is what the
above entry was supposed to point to, but as the location of the java
binary changed at some point, that relative path does not work any longer?
Maybe using a relative path here is pointless even? This code is
over-complicated, patches to simplify it are more than welcome;)

 We also have the tool /usr/libexec/java_home and work with the output
of /usr/libexec/java_home -V or something similar.

Yep. It is used in configure.ac to set up a JAVA_HOME environment variable
for *build-time* use. Whether that is strictly necessary or not, I have no
idea. (IMHO it might be cleaner if at build-time the same automated
mechanism was used to find the JVM to use as at LibreOffice run-time.)

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'feature/perfwork4' - sd/qa

2014-10-20 Thread Zolnai Tamás
 sd/qa/unit/data/xml/fdo64586_0.xml |4 ++--
 sd/qa/unit/data/xml/n758621_0.xml  |4 ++--
 sd/qa/unit/data/xml/n758621_1.xml  |4 ++--
 sd/qa/unit/data/xml/n819614_0.xml  |2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit bd252ab156980edb4122d67f44c59d524e9aa928
Author: Zolnai Tamás tamas.zol...@collabora.com
Date:   Mon Oct 20 16:17:46 2014 +0200

Adapt sd test broken by a recent change

Commit broke the test:
ae72de8d10acd088d0a5f46880b8c4a3c8fd2c24

Change-Id: Ia3635e0f6622d603499dd47443d2434d093da38e

diff --git a/sd/qa/unit/data/xml/fdo64586_0.xml 
b/sd/qa/unit/data/xml/fdo64586_0.xml
index a248783..7bbf719 100644
--- a/sd/qa/unit/data/xml/fdo64586_0.xml
+++ b/sd/qa/unit/data/xml/fdo64586_0.xml
@@ -4,7 +4,7 @@
   FillTransparenceGradient style=LINEAR startColor=00 
endColor=ff angle=0 border=0 xOffset=50 yOffset=50 
startIntensity=100 endIntensity=100 stepCount=0/
   FillGradient style=LINEAR startColor=00 endColor=ff angle=0 
border=0 xOffset=50 yOffset=50 startIntensity=100 endIntensity=100 
stepCount=0/
   FillHatch style=SINGLE color=3465a4 distance=20 angle=0/
-  FillBitmap/
+  FillBitmap width=0 height=0/
   LineDash style=RECT dots=1 dotLen=20 dashes=1 dashLen=20 
distance=20/
   LineStart/
   LineEnd/
@@ -18,7 +18,7 @@
   FillTransparenceGradient style=LINEAR startColor=00 
endColor=ff angle=0 border=0 xOffset=50 yOffset=50 
startIntensity=100 endIntensity=100 stepCount=0/
   FillGradient style=LINEAR startColor=00 endColor=ff angle=0 
border=0 xOffset=50 yOffset=50 startIntensity=100 endIntensity=100 
stepCount=0/
   FillHatch style=SINGLE color=3465a4 distance=20 angle=0/
-  FillBitmap/
+  FillBitmap width=0 height=0/
   LineDash style=RECT dots=1 dotLen=20 dashes=1 dashLen=20 
distance=20/
   LineStart/
   LineEnd/
diff --git a/sd/qa/unit/data/xml/n758621_0.xml 
b/sd/qa/unit/data/xml/n758621_0.xml
index 754be1d..288bf98 100644
--- a/sd/qa/unit/data/xml/n758621_0.xml
+++ b/sd/qa/unit/data/xml/n758621_0.xml
@@ -4,7 +4,7 @@
   FillTransparenceGradient style=LINEAR startColor=00 
endColor=ff angle=0 border=0 xOffset=50 yOffset=50 
startIntensity=100 endIntensity=100 stepCount=0/
   FillGradient style=LINEAR startColor=00 endColor=ff angle=0 
border=0 xOffset=50 yOffset=50 startIntensity=100 endIntensity=100 
stepCount=0/
   FillHatch style=SINGLE color=3465a4 distance=20 angle=0/
-  FillBitmap/
+  FillBitmap width=0 height=0/
   LineDash style=RECT dots=1 dotLen=20 dashes=1 dashLen=20 
distance=20/
   LineStart/
   LineEnd/
@@ -18,7 +18,7 @@
   FillTransparenceGradient style=LINEAR startColor=00 
endColor=ff angle=0 border=0 xOffset=50 yOffset=50 
startIntensity=100 endIntensity=100 stepCount=0/
   FillGradient style=LINEAR startColor=00 endColor=ff angle=0 
border=0 xOffset=50 yOffset=50 startIntensity=100 endIntensity=100 
stepCount=0/
   FillHatch style=SINGLE color=3465a4 distance=20 angle=0/
-  FillBitmap/
+  FillBitmap width=0 height=0/
   LineDash style=RECT dots=1 dotLen=20 dashes=1 dashLen=20 
distance=20/
   LineStart/
   LineEnd/
diff --git a/sd/qa/unit/data/xml/n758621_1.xml 
b/sd/qa/unit/data/xml/n758621_1.xml
index 0f71931..a124211 100644
--- a/sd/qa/unit/data/xml/n758621_1.xml
+++ b/sd/qa/unit/data/xml/n758621_1.xml
@@ -4,7 +4,7 @@
   FillTransparenceGradient style=LINEAR startColor=00 
endColor=ff angle=0 border=0 xOffset=50 yOffset=50 
startIntensity=100 endIntensity=100 stepCount=0/
   FillGradient style=LINEAR startColor=00 endColor=ff angle=0 
border=0 xOffset=50 yOffset=50 startIntensity=100 endIntensity=100 
stepCount=0/
   FillHatch style=SINGLE color=3465a4 distance=20 angle=0/
-  FillBitmap/
+  FillBitmap width=0 height=0/
   LineDash style=RECT dots=1 dotLen=20 dashes=1 dashLen=20 
distance=20/
   LineStart/
   LineEnd/
@@ -18,7 +18,7 @@
   FillTransparenceGradient style=LINEAR startColor=00 
endColor=ff angle=0 border=0 xOffset=50 yOffset=50 
startIntensity=100 endIntensity=100 stepCount=0/
   FillGradient style=LINEAR startColor=00 endColor=ff angle=0 
border=0 xOffset=50 yOffset=50 startIntensity=100 endIntensity=100 
stepCount=0/
   FillHatch style=SINGLE color=3465a4 distance=20 angle=0/
-  FillBitmap/
+  FillBitmap width=0 height=0/
   LineDash style=RECT dots=1 dotLen=20 dashes=1 dashLen=20 
distance=20/
   LineStart/
   LineEnd/
diff --git a/sd/qa/unit/data/xml/n819614_0.xml 
b/sd/qa/unit/data/xml/n819614_0.xml
index aff9c32..b7005be 100644
--- a/sd/qa/unit/data/xml/n819614_0.xml
+++ b/sd/qa/unit/data/xml/n819614_0.xml
@@ -4,7 +4,7 @@
   FillTransparenceGradient style=LINEAR startColor=00 
endColor=ff angle=0 border=0 xOffset=50 yOffset=50 
startIntensity=100 endIntensity=100 stepCount=0/
   FillGradient style=LINEAR startColor=00 endColor=ff angle=0 
border=0 xOffset=50 yOffset=50 startIntensity=100 endIntensity=100 
stepCount=0/
   FillHatch style=SINGLE color=3465a4 distance=20 

[Libreoffice-commits] core.git: unotools/qa unotools/source

2014-10-20 Thread Caolán McNamara
 unotools/qa/unit/testGetEnlishSearchName.cxx |6 +++---
 unotools/source/misc/fontdefs.cxx|2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit d89a2aaaeb7c4afdb70978e5cb54443119e3ee45
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 20 15:32:18 2014 +0100

fix font tests

Change-Id: I2738ea2a5c6714d8e43c06aa2eb4c53500a5afe9

diff --git a/unotools/qa/unit/testGetEnlishSearchName.cxx 
b/unotools/qa/unit/testGetEnlishSearchName.cxx
index 06ffcef..dbc8b17 100644
--- a/unotools/qa/unit/testGetEnlishSearchName.cxx
+++ b/unotools/qa/unit/testGetEnlishSearchName.cxx
@@ -40,10 +40,10 @@ void Test::testSingleElement()
 test1 = GetEnglishSearchFontName( Symbol );
 CPPUNIT_ASSERT_EQUAL(OUString(symbol),test1);
 //removing Skripts
-test1 = GetEnglishSearchFontName( Symbol(skript) );
-CPPUNIT_ASSERT_EQUAL(OUString(symbol),test1);
+test1 = GetEnglishSearchFontName( Symbol(SIP) );
+CPPUNIT_ASSERT_EQUAL(OUString(symbol(sip)),test1);
 //remove Whitespaces between
-test1 = GetEnglishSearchFontName( Symbol (skript) );
+test1 = GetEnglishSearchFontName( Symbol (thai) );
 CPPUNIT_ASSERT_EQUAL( OUString(symbol),test1);
 //remove special characters; leave semicolon, numbers
 test1 = GetEnglishSearchFontName( sy;mb?=ol129 );
diff --git a/unotools/source/misc/fontdefs.cxx 
b/unotools/source/misc/fontdefs.cxx
index cac720f..79f2821 100644
--- a/unotools/source/misc/fontdefs.cxx
+++ b/unotools/source/misc/fontdefs.cxx
@@ -406,7 +406,7 @@ OUString GetEnglishSearchFontName(const OUString rInName)
 c += 'a' - 'A';
 rName[ i ] = c;
 }
-else if( ((c  '0') || (c  '9'))  (c != ';') ) // not 0-9 or 
semicolon
+else if( ((c  '0') || (c  '9'))  (c != ';')  (c != '(')  
(c != ')') ) // not 0-9, semicolon, or brackets
 {
 // Remove white spaces and special characters
 rName.remove(i,1);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: bin/refcount_leak.py

2014-10-20 Thread Michael Stahl
 bin/refcount_leak.py |  179 +++
 1 file changed, 179 insertions(+)

New commits:
commit a4e219eee6314f26b7d9058e714c62facc2bc08c
Author: Michael Stahl mst...@redhat.com
Date:   Mon Oct 20 15:33:05 2014 +0200

add bin/refcount_leak.py script to help detect leaks of UNO objects

Initially this didn't help at all, but with some tweaks it now finds
the leaked ChartModel as the #3 and #4 printed stacks, with a very bad
score of 40.

Change-Id: I918bcb64bad0b9432bf2b670b03915836fb34a11

diff --git a/bin/refcount_leak.py b/bin/refcount_leak.py
new file mode 100755
index 000..2a24cb5
--- /dev/null
+++ b/bin/refcount_leak.py
@@ -0,0 +1,179 @@
+#!/usr/bin/python3
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+### script to help debug leaks of reference counted objects
+
+## I. to use it, first override acquire() and release()
+
+# Foo * g_pTrackedFoo = 0;
+
+# Foo::Foo()
+#   static int nFoos = 0;
+# if (++nFoos == 42) // track instance #42
+#   g_pTrackedFoo = this;
+
+# void Foo::acquire()
+#   if (this == g_pTrackedFoo)
+# ; // set gdb breakpoint here
+#   Foo_Base::acquire()
+
+# void Foo::release()
+#   if (this == g_pTrackedFoo)
+#  ; // set gdb breakpoint here
+#   Foo_Base::release()
+
+## II. run test/soffice in gdb and set breakpoints in acquire/release
+## with a command to print the backtrace
+
+# set logging on
+# break foo.cxx:123
+# break foo.cxx:234
+
+# command 1 2
+# bt
+# c
+# end
+# run
+
+## III. now feed logfile gdb.txt into this script
+
+# bin/refcount_leak.py  gdb.txt
+
+###
+
+from operator import itemgetter
+import re
+import sys
+
+threshold = 2
+
+class Trace:
+clock = 0 # global counter
+# frames: list of stack frames, beginning with outermost
+def __init__(self, lines):
+lines.reverse()
+self.frames = lines
+Trace.clock += 1
+self.clock = Trace.clock
+
+def addTrace(traces, lines):
+if not(traces is None) and len(lines)  0:
+traces.append(Trace(lines))
+
+def readGdbLog(infile):
+traces_acquire = []
+traces_release = []
+current = None
+lines = []
+apattern = re.compile(^Breakpoint.*::acquire)
+rpattern = re.compile(^Breakpoint.*::release)
+for line in infile:
+if apattern.match(line):
+addTrace(current, lines)
+lines = []
+current = traces_acquire
+if rpattern.match(line):
+addTrace(current, lines)
+lines = []
+current = traces_release
+if line.startswith(#):
+# strip #123 stack frame number, and newline
+lines.append(line[line.index(0x):-1])
+addTrace(current, lines)
+print(# parsed traces acquire: , len(traces_acquire))
+print(# parsed traces release: , len(traces_release))
+return (traces_acquire, traces_release)
+
+def getFunction(frame):
+start = frame.index( in ) + len( in )
+try:
+end = frame.index( at , start)
+except ValueError as e:
+# argh... stack frames may be split across multiple lines if
+# a parameter has a fancy pretty printer
+return frame[start:]
+return frame[start:end]
+
+
+def matchStack(trace_acquire, trace_release):
+if trace_release.clock  trace_acquire.clock:
+return None # acquire must precede release
+common = 0
+refpattern = re.compile(r::Reference.*::Reference\()
+for (frame1, frame2) in zip(trace_release.frames, trace_acquire.frames):
+if frame1 == frame2:
+common += 1
+else:
+if getFunction(frame1) == getFunction(frame2):
+common += 1
+acquireframes = len(trace_acquire.frames)
+# there is sometimes a dozen frames of UNO type related junk
+# on the stack where the acquire() happens, which breaks the
+# matching; try to avoid that
+for i in range(common, acquireframes):
+if refpattern.search(trace_acquire.frames[i]):
+acquireframes = i+1 # cut off junk above Reference ctor
+break
+score = max(len(trace_release.frames), acquireframes) - common
+# smaller score is better
+return (score, trace_release.clock - trace_acquire.clock)
+
+# brute force greedy n^2 matching
+def matchStacks(traces_acquire, traces_release):
+matches = []
+for release in traces_release:
+for acquire in traces_acquire:
+score = matchStack(acquire, release)
+if score is not None:
+matches.append((score, acquire, release))
+matches.sort(key=itemgetter(0))
+   

[Libreoffice-commits] core.git: forms/source

2014-10-20 Thread Caolán McNamara
 forms/source/component/DatabaseForm.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit ae218f4895082ea9fca8f414a332bcf47045ba8c
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 20 15:24:52 2014 +0100

tweak CaughtException

Change-Id: If5aac87876b139bfb394ec124136de131c3518ae

diff --git a/forms/source/component/DatabaseForm.cxx 
b/forms/source/component/DatabaseForm.cxx
index 25debf7..2744b34 100644
--- a/forms/source/component/DatabaseForm.cxx
+++ b/forms/source/component/DatabaseForm.cxx
@@ -390,10 +390,11 @@ ODatabaseForm::ODatabaseForm( const ODatabaseForm 
_cloneSource )
 }
 catch(const Exception)
 {
+css::uno::Any a(cppu::getCaughtException());
 throw WrappedTargetException(
 Could not clone the given database form.,
 *const_cast ODatabaseForm* ( _cloneSource ),
-::cppu::getCaughtException()
+a
 );
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/source

2014-10-20 Thread Caolán McNamara
 vcl/source/control/ilstbox.cxx |5 +
 vcl/source/window/menu.cxx |5 ++---
 vcl/source/window/winproc.cxx  |   21 +
 3 files changed, 12 insertions(+), 19 deletions(-)

New commits:
commit 454f5c3018c6d61d5872f7c23c7590c2157444e4
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 20 16:40:40 2014 +0100

Revert Fix fdo#84795 Menu, DropDown-List not disappears with right mouse 
click

This reverts commit 53c836701e22b1babd3702b502facd76236df7ff.

because it means that all disabled buttons get their click delivered
so disabled buttons are only visually disabled.

e.g. writer: insert-table-autoformat, click on the disabled rename or 
add
or remove and the sub dialog appears. Or in calc insert-object-chart and
click on the disabled back - crash

diff --git a/vcl/source/control/ilstbox.cxx b/vcl/source/control/ilstbox.cxx
index ec8eb6b..228d3b6 100644
--- a/vcl/source/control/ilstbox.cxx
+++ b/vcl/source/control/ilstbox.cxx
@@ -3073,10 +3073,7 @@ void ImplListBoxFloatingWindow::StartFloat( bool 
bStartTracking )
 if( pGrandparent-ImplIsAntiparallel() )
 pGrandparentOutDev-ReMirror( aRect );
 
-// mouse-button right: close the List-Box-Float-win and don't stop the 
handling fdo#84795
-const sal_uLong nFlags = FLOATWIN_POPUPMODE_PATHMOUSECANCELCLICK | 
FLOATWIN_POPUPMODE_ALLMOUSEBUTTONCLOSE;
-
-StartPopupMode( aRect, FLOATWIN_POPUPMODE_DOWN | nFlags );
+StartPopupMode( aRect, FLOATWIN_POPUPMODE_DOWN );
 
 if( nPos != LISTBOX_ENTRY_NOTFOUND )
 mpImplLB-ShowProminentEntry( nPos );
diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index 4ed5174..f951769 100644
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -2816,9 +2816,8 @@ sal_uInt16 PopupMenu::ImplExecute( vcl::Window* pW, const 
Rectangle rRect, sal_
 WinBits nStyle = WB_BORDER;
 if (bRealExecute)
 nPopupModeFlags |= FLOATWIN_POPUPMODE_NEWLEVEL;
-
-// mouse-button right: close the sub-menu (float-win) and don't stop the 
handling fdo#84795
-nPopupModeFlags |= FLOATWIN_POPUPMODE_PATHMOUSECANCELCLICK | 
FLOATWIN_POPUPMODE_ALLMOUSEBUTTONCLOSE;
+if (!pStartedFrom || !pStartedFrom-IsMenuBar())
+nPopupModeFlags |= FLOATWIN_POPUPMODE_PATHMOUSECANCELCLICK | 
FLOATWIN_POPUPMODE_ALLMOUSEBUTTONCLOSE;
 
 nPopupModeFlags |= FLOATWIN_POPUPMODE_NOKEYCLOSE;
 
diff --git a/vcl/source/window/winproc.cxx b/vcl/source/window/winproc.cxx
index 18e2f45..a677af1 100644
--- a/vcl/source/window/winproc.cxx
+++ b/vcl/source/window/winproc.cxx
@@ -101,7 +101,7 @@ static bool ImplHandleMouseFloatMode( vcl::Window* pChild, 
const Point rMousePo
 pLastLevelFloat = 
pSVData-maWinData.mpFirstFloat-ImplFindLastLevelFloat();
 nPopupFlags = pLastLevelFloat-GetPopupModeFlags();
 pLastLevelFloat-EndPopupMode( 
FLOATWIN_POPUPMODEEND_CANCEL | FLOATWIN_POPUPMODEEND_CLOSEALL );
-return false;   // don't stop the handling  fdo#84795
+return true;
 }
 else if ( nHitTest == HITTEST_RECT )
 {
@@ -381,7 +381,7 @@ bool ImplHandleMouseEvent( vcl::Window* pWindow, sal_uInt16 
nSVEvent, bool bMous
 // #106845# if the window was disabed during capturing we have to pass 
the mouse events to release capturing
 if ( pSVData-maWinData.mpCaptureWin != pChild  
(!pChild-IsEnabled() || !pChild-IsInputEnabled() || 
pChild-IsInModalNonRefMode() ) )
 {
-bool bStopHdl = ImplHandleMouseFloatMode( pChild, aMousePos, 
nCode, nSVEvent, bMouseLeave );
+ImplHandleMouseFloatMode( pChild, aMousePos, nCode, nSVEvent, 
bMouseLeave );
 if ( nSVEvent == EVENT_MOUSEMOVE )
 {
 ImplHandleMouseHelpRequest( pChild, aMousePos );
@@ -401,18 +401,15 @@ bool ImplHandleMouseEvent( vcl::Window* pWindow, 
sal_uInt16 nSVEvent, bool bMous
 pChild-ImplNotifyKeyMouseCommandEventListeners( aNEvt );
 }
 
-if(bStopHdl) // mouse-button left: don't stop the handling for the 
click fdo#84795
+if ( nSVEvent == EVENT_MOUSEBUTTONDOWN )
+return true;
+else
 {
-if ( nSVEvent == EVENT_MOUSEBUTTONDOWN )
-return true;
-else
-{
-// Set normal MousePointer for disabled windows
-if ( nSVEvent == EVENT_MOUSEMOVE )
-ImplSetMousePointer( pChild );
+// Set normal MousePointer for disabled windows
+if ( nSVEvent == EVENT_MOUSEMOVE )
+ImplSetMousePointer( pChild );
 
-return false;
-}
+return false;
 }
 }
 

[Libreoffice-commits] core.git: chart2/source

2014-10-20 Thread Michael Stahl
 chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx |2 +-
 chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx   |6 +++---
 chart2/source/inc/AxisHelper.hxx|2 +-
 chart2/source/inc/chartview/ExplicitValueProvider.hxx   |2 +-
 chart2/source/tools/AxisHelper.cxx  |6 +++---
 chart2/source/tools/ExplicitCategoriesProvider.cxx  |2 +-
 chart2/source/view/axes/VCartesianCoordinateSystem.cxx  |9 
+++--
 chart2/source/view/axes/VCartesianCoordinateSystem.hxx  |2 +-
 chart2/source/view/axes/VCoordinateSystem.cxx   |6 +++---
 chart2/source/view/axes/VPolarCoordinateSystem.cxx  |9 
+++--
 chart2/source/view/axes/VPolarCoordinateSystem.hxx  |2 +-
 chart2/source/view/inc/VCoordinateSystem.hxx|4 ++--
 chart2/source/view/main/ChartView.cxx   |   10 
++
 13 files changed, 37 insertions(+), 25 deletions(-)

New commits:
commit 908d1b6e632922a6fa59385c49828be3c3eeb969
Author: Michael Stahl mst...@redhat.com
Date:   Mon Oct 20 14:56:32 2014 +0200

chart2: fix memory leak due to cyclic reference in VAxisBase

The VAxisBase::m_xNumberFormatsSupplier refers to the ChartModel itself,
and apparently that is a cyclic reference.  Naively using the
ChartModel's m_xNumberFormatsSupplier in
ChartView::impl_createDiagramAndContent() because it will later be passed
to AxisHelper::getExplicitNumberFormatKeyForAxis(), which expects to be
able to convert it to a ChartModel.

Since passing around the ChartModel as an XNumberFormattingSupplier is
sort of un-intuitive anyway, refactor some methods to use XChartDocument
instead, and only create the VPolarAxis / VCartesianAxis with the
ChartModel's m_xNumberFormatsSupplier.

The drawback is that if ChartModel::attachNumberFormatsSupplier()
is called after ChartView::update() has created the axes, it may not
have an effect on them; not sure if that is a real or hypothetical
problem.

Change-Id: Ib5f0d5882b85adaf44f80e086f19178b3e64882f

diff --git a/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx 
b/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx
index 1588a2f..afdebd1 100644
--- a/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx
+++ b/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx
@@ -158,7 +158,7 @@ sal_Int32 
Chart2ModelContact::getExplicitNumberFormatKeyForAxis(
   xAxis, ChartModelHelper::findDiagram( m_xChartModel ) ) );
 
 return ExplicitValueProvider::getExplicitNumberFormatKeyForAxis( xAxis, 
xCooSys
-  , Reference util::XNumberFormatsSupplier ( 
m_xChartModel.get(), uno::UNO_QUERY ) );
+  , getChart2Document());
 }
 
 sal_Int32 Chart2ModelContact::getExplicitNumberFormatKeyForSeries(
diff --git a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx 
b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
index e2cd620..76f7d68 100644
--- a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
@@ -363,7 +363,7 @@ void AxisItemConverter::FillSpecialItem( sal_uInt16 
nWhichId, SfxItemSet  rOutI
 Reference chart2::XAxis  xCrossingMainAxis( 
AxisHelper::getCrossingMainAxis( m_xAxis, xCooSys ) );
 
 sal_Int32 nFormatKey = 
ExplicitValueProvider::getExplicitNumberFormatKeyForAxis(
-xCrossingMainAxis, xCooSys, Reference 
util::XNumberFormatsSupplier ( m_xChartDoc, uno::UNO_QUERY ) );
+xCrossingMainAxis, xCooSys, m_xChartDoc);
 
 rOutItemSet.Put( SfxUInt32Item( nWhichId, nFormatKey ));
 }
@@ -407,7 +407,7 @@ void AxisItemConverter::FillSpecialItem( sal_uInt16 
nWhichId, SfxItemSet  rOutI
   m_xAxis, ChartModelHelper::findDiagram( 
m_xChartDoc ) ) );
 
 sal_Int32 nFormatKey = 
ExplicitValueProvider::getExplicitNumberFormatKeyForAxis(
-m_xAxis, xCooSys, Reference util::XNumberFormatsSupplier 
( m_xChartDoc, uno::UNO_QUERY ) );
+m_xAxis, xCooSys, m_xChartDoc);
 
 rOutItemSet.Put( SfxUInt32Item( nWhichId, nFormatKey ));
 }
@@ -948,7 +948,7 @@ bool AxisItemConverter::ApplySpecialItem( sal_uInt16 
nWhichId, const SfxItemSet
   m_xAxis, ChartModelHelper::findDiagram( 
m_xChartDoc ) ) );
 
 sal_Int32 nFormatKey = 
ExplicitValueProvider::getExplicitNumberFormatKeyForAxis(
-m_xAxis, xCooSys, Reference 
util::XNumberFormatsSupplier ( m_xChartDoc, uno::UNO_QUERY ) );
+m_xAxis, xCooSys, m_xChartDoc);
 
 aValue = nFormatKey;
 }
diff --git 

Re: [Libreoffice-qa] Minutes of ESC call: 2014-10-16

2014-10-20 Thread Bjoern Michaelsen
On Mon, Oct 20, 2014 at 10:42:54AM +0200, Stephan Bergmann wrote:
 ...if we also successfully abstract over the differences between
 GNU/cygwin and Windows of all those very little tools called from
 make recipes (like moving a file).

Well, I dont think we want to get rid of that on Linux/OSX where GNU coreutils
is a pretty natural thing to be available there. For Windows in the end, a lot
of that should possible to be covered by MSBuild:

 http://msdn.microsoft.com/en-us/library/7z253716.aspx

But all of that is still quite a way off and not too urgent. But we should be
moving roughly in the right direction at least IMHO (which is build preferable
with what can be expected to be there on the target platform and which is
unlikely to change/go away).

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] Minutes of ESC call: 2014-10-16

2014-10-20 Thread Tor Lillqvist
 Well, I dont think we want to get rid of that on Linux/OSX where GNU
 coreutils
 is a pretty natural thing to be available there.



s/GNU coreutils/POSIX utilities

After all, who knows what useful extensions (irony) GNU might see fit to
provide in the future, which would then be available on (GNU/)Linux only,
as it isn't unlikeli that Apple wants to stay with the version of coreutils
it currently provides. And not all of coreutils is provided in OS X; some
of the corresponding POSIX commands come from BSD.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: jvmfwk/plugins

2014-10-20 Thread Stephan Bergmann
 jvmfwk/plugins/sunmajor/pluginlib/otherjre.hxx  |1 
 jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx |4 +-
 jvmfwk/plugins/sunmajor/pluginlib/sunjre.hxx|1 
 jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx|   20 +--
 jvmfwk/plugins/sunmajor/pluginlib/vendorbase.hxx|   36 ++--
 5 files changed, 23 insertions(+), 39 deletions(-)

New commits:
commit 5dcfbe57c8c35814d0e8e20c7069be340151da8f
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Oct 20 17:58:30 2014 +0200

Clean up VendorBase (virtual) member functions

Change-Id: I1377dfded1246c8e96db3addc28489886c7f2d99

diff --git a/jvmfwk/plugins/sunmajor/pluginlib/otherjre.hxx 
b/jvmfwk/plugins/sunmajor/pluginlib/otherjre.hxx
index 2c2b1b7..d95a9a4 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/otherjre.hxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/otherjre.hxx
@@ -34,7 +34,6 @@ public:
 
 static rtl::ReferenceVendorBase createInstance();
 
-using VendorBase::getLibraryPaths;
 virtual char const* const* getRuntimePaths(int * size) SAL_OVERRIDE;
 virtual char const* const* getLibraryPaths(int* size) SAL_OVERRIDE;
 virtual int compareVersions(const OUString sSecond) const SAL_OVERRIDE;
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
index db58c54..3d4e3f4 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
@@ -157,10 +157,10 @@ JavaInfo* createJavaInfo(const rtl::ReferenceVendorBase 
 info)
 pInfo-nRequirements = info-needsRestart() ? JFW_REQUIRE_NEEDRESTART : 0;
 OUStringBuffer buf(1024);
 buf.append(info-getRuntimeLibrary());
-if (!info-getLibraryPaths().isEmpty())
+if (!info-getLibraryPath().isEmpty())
 {
 buf.appendAscii(\n);
-buf.append(info-getLibraryPaths());
+buf.append(info-getLibraryPath());
 buf.appendAscii(\n);
 }
 
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunjre.hxx 
b/jvmfwk/plugins/sunmajor/pluginlib/sunjre.hxx
index a25a8e5..1d63794 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/sunjre.hxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/sunjre.hxx
@@ -33,7 +33,6 @@ public:
 
 static rtl::ReferenceVendorBase createInstance();
 
-using VendorBase::getLibraryPaths;
 virtual char const* const* getRuntimePaths(int * size) SAL_OVERRIDE;
 virtual char const* const* getLibraryPaths(int* size) SAL_OVERRIDE;
 
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx
index c72ac27..563c850 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx
@@ -54,12 +54,6 @@ VendorBase::VendorBase(): m_bAccessibility(false)
 {
 }
 
-rtl::ReferenceVendorBase VendorBase::createInstance()
-{
-VendorBase *pBase = new VendorBase();
-return rtl::ReferenceVendorBase(pBase);
-}
-
 bool VendorBase::initialize(vectorpairOUString, OUString  props)
 {
 //get java.vendor, java.version, java.home,
@@ -209,7 +203,7 @@ const OUString  VendorBase::getHome() const
 return m_sHome;
 }
 
-const OUString  VendorBase::getLibraryPaths() const
+const OUString  VendorBase::getLibraryPath() const
 {
 return m_sLD_LIBRARY_PATH;
 }
@@ -225,21 +219,11 @@ bool VendorBase::supportsAccessibility() const
 
 bool VendorBase::needsRestart() const
 {
-if (!getLibraryPaths().isEmpty())
+if (!getLibraryPath().isEmpty())
 return true;
 return false;
 }
 
-int VendorBase::compareVersions(const OUString /*sSecond*/) const
-{
-OSL_FAIL([Java framework] VendorBase::compareVersions must be 
-   overridden in derived class.);
-return 0;
-}
-
-
-
-
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.hxx 
b/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.hxx
index 29f2641..7210173 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.hxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.hxx
@@ -88,7 +88,9 @@ class VendorBase: public salhelper::SimpleReferenceObject
 {
 public:
 VendorBase();
-/* returns relative paths to the java executable as
+/* static char const* const *  getJavaExePaths(int* size);
+
+   returns relative paths to the java executable as
file URLs.
 
For example bin/java.exe. You need
@@ -103,9 +105,10 @@ public:
The signature of this function must correspond to
getJavaExePaths_func.
  */
-static char const* const *  getJavaExePaths(int* size);
 
-/* creates an instance of this class. MUST be overridden
+/* static rtl::ReferenceVendorBase createInstance();
+
+   creates an instance of this class. MUST be overridden
in a derived class.

OVERRIDE in derived class
@@ -113,7 +116,6 @@ public:
@param
   

Re: [Libreoffice-qa] Minutes of ESC call: 2014-10-16

2014-10-20 Thread Bjoern Michaelsen
On Mon, Oct 20, 2014 at 06:54:48PM +0300, Tor Lillqvist wrote:
 s/GNU coreutils/POSIX utilities
 
 After all, who knows what useful extensions (irony) GNU might see fit to
 provide in the future, which would then be available on (GNU/)Linux only,
 as it isn't unlikeli that Apple wants to stay with the version of coreutils
 it currently provides. And not all of coreutils is provided in OS X; some
 of the corresponding POSIX commands come from BSD.

I was just hesitant to write POSIX as Im pretty sure we are using functionality
beyond that (and that works because a lot of things work on BSD/OSX too that
arent strictly POSIX). Restricting ourselves to POSIX purity just for the
standards sake, rather than that it should work on all platforms seem like a
mostly futile endevour to me.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: jvmfwk/plugins

2014-10-20 Thread Stephan Bergmann
 jvmfwk/plugins/sunmajor/pluginlib/gnujre.cxx |5 +++
 jvmfwk/plugins/sunmajor/pluginlib/gnujre.hxx |2 +
 jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx |   10 --
 jvmfwk/plugins/sunmajor/pluginlib/vendorbase.hxx |   33 +++
 4 files changed, 23 insertions(+), 27 deletions(-)

New commits:
commit af748c7fff9e57a5b95bdc569456cc0da93a1f90
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Oct 20 18:01:05 2014 +0200

Clean up VendorBase (virtual) member functions further

Change-Id: If6b9355c6992eb6651f71c0944a93af0856ef1c7

diff --git a/jvmfwk/plugins/sunmajor/pluginlib/gnujre.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/gnujre.cxx
index 4f5a877..9fc69d6 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/gnujre.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/gnujre.cxx
@@ -84,6 +84,11 @@ char const* const* GnuInfo::getRuntimePaths(int * size)
 return ar;
 }
 
+char const* const* GnuInfo::getLibraryPaths(int* /*size*/)
+{
+return NULL;
+}
+
 bool GnuInfo::initialize(vectorpairOUString, OUString  props)
 {
 //get java.vendor, java.version, java.home,
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/gnujre.hxx 
b/jvmfwk/plugins/sunmajor/pluginlib/gnujre.hxx
index 4c364a6..f4683d5 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/gnujre.hxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/gnujre.hxx
@@ -37,6 +37,8 @@ public:
 
 virtual char const* const* getRuntimePaths(int * size) SAL_OVERRIDE;
 
+virtual char const* const* getLibraryPaths(int* size) SAL_OVERRIDE;
+
 virtual bool initialize(
 std::vectorstd::pairOUString, OUString  props) SAL_OVERRIDE;
 virtual int compareVersions(const OUString sSecond) const SAL_OVERRIDE;
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx
index 563c850..f91f75e 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx
@@ -179,16 +179,6 @@ bool VendorBase::initialize(vectorpairOUString, 
OUString  props)
 return true;
 }
 
-char const* const* VendorBase::getRuntimePaths(int* /*size*/)
-{
-return NULL;
-}
-
-char const* const* VendorBase::getLibraryPaths(int* /*size*/)
-{
-return NULL;
-}
-
 const OUString  VendorBase::getVendor() const
 {
 return m_sVendor;
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.hxx 
b/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.hxx
index 7210173..2ecd01f 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.hxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.hxx
@@ -117,23 +117,6 @@ public:
Key - value pairs of the system properties of the JRE.
  */
 
-/* called automatically on the instance created by createInstance.
-
-   @return
-   true - the object could completely initialize.
-   false - the object could not completely initialize. In this case
-   it will be discarded by the caller.
-*/
-virtual bool initialize(
-std::vectorstd::pairOUString, OUString  props);
-
-/* returns relative file URLs to the runtime library.
-   For example /bin/client/jvm.dll
-*/
-virtual char const* const* getRuntimePaths(int* size);
-
-virtual char const* const* getLibraryPaths(int* size);
-
 const OUString  getVendor() const;
 const OUString  getVersion() const;
 const OUString  getHome() const;
@@ -163,6 +146,22 @@ public:
 virtual int compareVersions(const OUString sSecond) const = 0;
 
 protected:
+/* called automatically on the instance created by createInstance.
+
+   @return
+   true - the object could completely initialize.
+   false - the object could not completely initialize. In this case
+   it will be discarded by the caller.
+*/
+virtual bool initialize(
+std::vectorstd::pairOUString, OUString  props);
+
+/* returns relative file URLs to the runtime library.
+   For example /bin/client/jvm.dll
+*/
+virtual char const* const* getRuntimePaths(int* size) = 0;
+
+virtual char const* const* getLibraryPaths(int* size) = 0;
 
 OUString m_sVendor;
 OUString m_sVersion;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sw/qa

2014-10-20 Thread Jan Holesovsky
 sw/qa/extras/htmlexport/htmlexport.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 9971bedd0fcdddf741b312a4d02aeb1f703ef2a9
Author: Jan Holesovsky ke...@collabora.com
Date:   Mon Oct 20 18:13:34 2014 +0200

Fix build breakage.

diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx 
b/sw/qa/extras/htmlexport/htmlexport.cxx
index 9e666a8..a59515e 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -173,15 +173,15 @@ 
DECLARE_HTMLEXPORT_TEST(testExportCheckboxRadioButtonState, checkbox-radiobutto
 assertXPath(pDoc, /html/body/p[1]/input, type, checkbox);
 assertXPath(pDoc, /html/body/p[1]/input, checked, checked);
 assertXPath(pDoc, /html/body/p[2]/input, type, checkbox);
-assertXPathNoAttribute(pDoc, /html/body/p[2]/input, checked);
+// FIXME not in 4.3 assertXPathNoAttribute(pDoc, /html/body/p[2]/input, 
checked);
 assertXPath(pDoc, /html/body/form/p[1]/input, type, checkbox);
 assertXPath(pDoc, /html/body/form/p[1]/input, checked, checked);
 assertXPath(pDoc, /html/body/form/p[2]/input, type, checkbox);
-assertXPathNoAttribute(pDoc, /html/body/form/p[2]/input, checked);
+// FIXME not in 4.3 assertXPathNoAttribute(pDoc, 
/html/body/form/p[2]/input, checked);
 assertXPath(pDoc, /html/body/form/p[3]/input, type, radio);
 assertXPath(pDoc, /html/body/form/p[3]/input, checked, checked);
 assertXPath(pDoc, /html/body/form/p[4]/input, type, radio);
-assertXPathNoAttribute(pDoc, /html/body/form/p[4]/input, checked);
+// FIXME not in 4.3 assertXPathNoAttribute(pDoc, 
/html/body/form/p[4]/input, checked);
 }
 
 CPPUNIT_PLUGIN_IMPLEMENT();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: build fails for 4.3 with the last commit on htmlexport

2014-10-20 Thread Jan Holesovsky
Hi Jean-Baptiste,

Jean-Baptiste Faure píše v Po 20. 10. 2014 v 15:47 +0200:

  .../LibO/lo43/sw/qa/extras/htmlexport/htmlexport.cxx: In member function 
  ‘virtual void testExportCheckboxRadioButtonState::verify()’:
  .../LibO/lo43/sw/qa/extras/htmlexport/htmlexport.cxx:176:68: error: 
  ‘assertXPathNoAttribute’ was not declared in this scope
   assertXPathNoAttribute(pDoc, /html/body/p[2]/input, checked);
  ^
  make[1]: *** 
  [.../LibO/lo43/workdir/CxxObject/sw/qa/extras/htmlexport/htmlexport.o] 
  Erreur 1
  make[1]: *** Attente des tâches non terminées
  make: *** [build] Erreur 2 
 
 I did only an incremental build, perhaps I must do a complete rebuild ?

No, it uses a function that has been introduced in master only; pushed a
quick fix.  Sorry for the problem.

All the best,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: svtools/source

2014-10-20 Thread Caolán McNamara
 svtools/source/contnr/svlbitm.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 9bdca0019bd3781f15e542becca5537fac2e0a9d
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 20 17:13:04 2014 +0100

crash in tools-options-advanced

regression from...

commit 06562c678410e425de629109ce92933c2d89a8f6
Date:   Sat Oct 18 10:36:36 2014 +0200

convert SV_BMP_ constants to enum

Change-Id: I46cb7f649fa44d8967e0e7da03583157d2706f05
Reviewed-on: https://gerrit.libreoffice.org/12018
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com

Change-Id: I29486e8fe17d9e06e01c33f93d99ffc6ae3d017c

diff --git a/svtools/source/contnr/svlbitm.cxx 
b/svtools/source/contnr/svlbitm.cxx
index 0711589..014a36a 100644
--- a/svtools/source/contnr/svlbitm.cxx
+++ b/svtools/source/contnr/svlbitm.cxx
@@ -35,12 +35,12 @@ struct SvLBoxButtonData_Impl
 SvLBoxButtonData_Impl() : pEntry( NULL ), bDefaultImages( false ), 
bShowRadioButton( false ) {}
 };
 
-
-
 void SvLBoxButtonData::InitData( bool bImagesFromDefault, bool _bRadioBtn, 
const Control* pCtrl )
 {
 nWidth = nHeight = 0;
 
+aBmps.resize((int)SvBmp::STATICIMAGE+1);
+
 pImpl = new SvLBoxButtonData_Impl;
 
 bDataOk = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: [Libreoffice-qa] Minutes of ESC call: 2014-10-16

2014-10-20 Thread Wols Lists
On 20/10/14 17:04, Bjoern Michaelsen wrote:
 I was just hesitant to write POSIX as Im pretty sure we are using 
 functionality
 beyond that (and that works because a lot of things work on BSD/OSX too that
 arent strictly POSIX). Restricting ourselves to POSIX purity just for the
 standards sake, rather than that it should work on all platforms seem like a
 mostly futile endevour to me.

Bear in mind that linux uses Posix as a guideline, not a requirement.
Linus ignores stupid Posix stuff, and I'm sure others do too ...

Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


tracking down reference counting memory leaks

2014-10-20 Thread Michael Stahl

as everyone knows, C++ programs do not leak memory because they use RAII
and smart pointers to automatically release all allocated memory at just
the right time.

... but enough with the jocularities: there was this ChartModel that was
leaked due to a uno::Reference cycle, which means that the usual tools
like valgrind and address sanitizer aren't very useful as such.

after an hour or so of adding just some simple SAL_DEBUGs it was obvious
that a temp file was leaked by CppunitTest_chart2_export because on the
2nd instance of ChartModel there were 1968 acquire() calls but only 1966
release() calls.

there are 2 ways i've tried to track down the 2 leaking acquire()s:

1. instrument the acquire()/release() method and run the test in gdb,
with breakpoint commands that print a backtrace on every
acquire()/release(), then run the resulting logfile through a little
python script that tries to find matching pairs of acquire()/release()

(this was suggested by mjayfancis and noel_grandin on IRC)

the script is now on master in bin/refcount_leak.py, at the top of the
file there are some comments on how to best use it.

the script just takes 2 minutes to run (90 seconds of which are spent in
a single regex) but unfortunately printing 4000 stack traces with gdb
takes  3 hours on my laptop; probably that can be sped up by disabling
various pretty printing options or perhaps using some tracing tool other
than gdb.

the printed stack traces are sorted by badness but unfortunately it's
still necessary to inspect them manually; it's quite possible that the
leaking acquire() is erroneously matched with an unrelated release();
basically only matches with a score of 2 are reliable, which is just
~75% of them.  the actual leak i was looking for is printed as backtrace
#3 and #4, which isn't too bad, but a few tweaks were needed to get
there, and honestly i've used method #2 to first identify the leaking
trace :)

2. instrument the uno::Reference class so that every acquire()/release()
call is accompanied by a dummy memory allocation/release, so that
standard tools like valgrind/address sanitizer can detect the leaked
Reference

(this was suggested on the valgrind mailing list by Philippe Waroquiers
some years ago)

this was also a bit of work, because the uno::Reference has dozens of
weird constructors, set methods, SAL_NO_ACQUIRE, and worst of all, can
be created from uno::Any...

https://gerrit.libreoffice.org/#/c/12054/

... is the gerrit patch; it can detect only uno::Reference leaks, but
requires further work to detect rtl::Reference, uno::Any (and maybe
uno::Sequence and whatever other weird things?) too.

the obvious drawback is that effectively this requires a full rebuild
due to the changes in cppu headers.

there is also a bit of runtime overhead here so i'm not sure if it's a
good idea to turn it always on in --enable-dbgutil...

but the advantage is that searching for hack_acquire in valgrind's
output very quickly finds the actual leak.

***

overall i think that the second approach is probably better, since it
shouldn't need much manual interpretation of the results.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] Minutes of ESC call: 2014-10-16

2014-10-20 Thread Tor Lillqvist
 Restricting ourselves to POSIX purity just for the
 standards sake, rather than that it should work on all platforms seem
 like a
 mostly futile endevour to me.


Sure; but let's say so then, it should work on all platforms, so that we
can reject use of GNU coreutils features that are not present on some
platform.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: config_host.mk.in

2014-10-20 Thread David Tardon
 config_host.mk.in |1 +
 1 file changed, 1 insertion(+)

New commits:
commit bd4e81bab2726cbab30b58a71c25db9b7d1ddb7e
Author: David Tardon dtar...@redhat.com
Date:   Mon Oct 20 18:38:44 2014 +0200

put back variable deleted by mistake

Change-Id: Ic705fe6bb7c3b9bae4b09d0b487f48056675b4b8

diff --git a/config_host.mk.in b/config_host.mk.in
index 738c80c..32b5145 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -433,6 +433,7 @@ export OOO_JUNIT_JAR=@OOO_JUNIT_JAR@
 export OOO_VENDOR=@OOO_VENDOR@
 export OPENCOLLADA_CFLAGS=$(gb_SPACE)@OPENCOLLADA_CFLAGS@
 export OPENCOLLADA_LIBS=$(gb_SPACE)@OPENCOLLADA_LIBS@
+export OPENSSL_CFLAGS=$(gb_SPACE)@OPENSSL_CFLAGS@
 export OPENSSL_LIBS=$(gb_SPACE)@OPENSSL_LIBS@
 export ORCUS_CFLAGS=$(gb_SPACE)@ORCUS_CFLAGS@
 export ORCUS_LIBS=$(gb_SPACE)@ORCUS_LIBS@
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/lof-4.3' - svx/source

2014-10-20 Thread Tor Lillqvist
 svx/source/gallery2/gallery1.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit debaf1a8d5f51b484e336f350923c9ee4c7daca5
Author: Tor Lillqvist t...@collabora.com
Date:   Wed Oct 8 19:08:22 2014 +0300

Fix thinko. Thanks to vmiklos for noticing

Change-Id: Id4e65908cc73978205bc0858a3a809b882864b62
(cherry picked from commit d61f8185e660a6820351b8cea3ac51d344f0ab3e)

diff --git a/svx/source/gallery2/gallery1.cxx b/svx/source/gallery2/gallery1.cxx
index cd95038..067acbd 100644
--- a/svx/source/gallery2/gallery1.cxx
+++ b/svx/source/gallery2/gallery1.cxx
@@ -19,7 +19,7 @@
 
 #include config_features.h
 
-#if defined(MACOSX)  defined(HAVE_FEATURE_READONLY_INSTALLSET)
+#if defined(MACOSX)  HAVE_FEATURE_READONLY_INSTALLSET
 #define __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES 0
 #include premac.h
 #include Foundation/Foundation.h
@@ -244,7 +244,7 @@ void Gallery::ImplLoadSubDirs( const INetURLObject 
rBaseURL, bool rbDirIsReadO
 
 uno::Reference sdbc::XResultSet  xResultSet( aCnt.createCursor( 
aProps, ::ucbhelper::INCLUDE_DOCUMENTS_ONLY ) );
 
-#if defined(MACOSX)  defined(HAVE_FEATURE_READONLY_INSTALLSET)
+#if defined(MACOSX)  HAVE_FEATURE_READONLY_INSTALLSET
 if( rBaseURL.GetProtocol() == INET_PROT_FILE )
 {
 const char *appBundle = [[[NSBundle mainBundle] bundlePath] 
UTF8String];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.3' - 26 commits - configure.ac cppuhelper/source external/python3 instsetoo_native/CustomTarget_setup.mk lo.xcent.in Makefile.in pyuno/sou

2014-10-20 Thread Tor Lillqvist
 Makefile.in|   
28 
 Repository.mk  |   
 6 
 configure.ac   |   
15 
 cppuhelper/source/bootstrap.cxx|   
 9 
 external/python3/python-3.3.0-darwin.patch.1   |   
22 
 instsetoo_native/CustomTarget_setup.mk |   
 2 
 lo.xcent.in|   
 9 
 pyuno/source/loader/pyuno_loader.cxx   |   
 6 
 registry/Module_registry.mk|   
 6 
 scp2/source/ooo/common_brand.scp   |   
 6 
 scp2/source/ooo/file_ooo.scp   |   
 2 
 scripting/java/com/sun/star/script/framework/container/ScriptMetaData.java |   
 2 
 scripting/java/com/sun/star/script/framework/provider/ScriptProvider.java  |   
 8 
 scripting/source/pyprov/pythonscript.py|   
 2 
 sfx2/source/view/viewsh.cxx|   
12 
 solenv/bin/macosx-codesign-app-bundle  |  
108 
 solenv/gbuild/platform/macosx.mk   |   
 9 
 svx/Library_svxcore.mk |   
12 
 svx/source/gallery2/gallery1.cxx   |   
20 
 sysui/desktop/icons/main.icns  
|binary
 sysui/desktop/macosx/Info.plist.in | 
1368 ++
 21 files changed, 1158 insertions(+), 494 deletions(-)

New commits:
commit 321ef4fb8ed484e7f15d8d77e6b20f158c501e0b
Author: Tor Lillqvist t...@collabora.com
Date:   Sun Sep 21 20:32:54 2014 +0300

Make the OS X icon round

Should really play with GIMP or something to add some (subtle)
embossing effects.

Change-Id: I5bdb63c974bf20200b7d5e8c1f598d93aeca34db
(cherry picked from commit 6a750e189eda0b0e1a8e6e30c84739764b36692a)

diff --git a/sysui/desktop/icons/main.icns b/sysui/desktop/icons/main.icns
index 9ef3f72..b2029bd 100644
Binary files a/sysui/desktop/icons/main.icns and 
b/sysui/desktop/icons/main.icns differ
commit 6b92d8f37b6b50d5e01f47d5bbce8ffd7fd4d3b2
Author: Tor Lillqvist t...@collabora.com
Date:   Fri Sep 12 23:49:21 2014 +0300

Use the white on purple LOfC icon

Change-Id: I2c49e5018742f35c57ab1290b783e47ed0a3b73b
(cherry picked from commit 0307129596344fb40dc5ade2fb6a6dd913b1799e)

diff --git a/sysui/desktop/icons/main.icns b/sysui/desktop/icons/main.icns
index c3e1bf6..9ef3f72 100644
Binary files a/sysui/desktop/icons/main.icns and 
b/sysui/desktop/icons/main.icns differ
commit 7e688f7e21997dedc6748def787df3c27a83e34c
Author: Tor Lillqvist t...@collabora.com
Date:   Wed Oct 8 19:08:22 2014 +0300

Fix thinko. Thanks to vmiklos for noticing

Change-Id: Id4e65908cc73978205bc0858a3a809b882864b62
(cherry picked from commit d61f8185e660a6820351b8cea3ac51d344f0ab3e)

diff --git a/svx/source/gallery2/gallery1.cxx b/svx/source/gallery2/gallery1.cxx
index cd95038..067acbd 100644
--- a/svx/source/gallery2/gallery1.cxx
+++ b/svx/source/gallery2/gallery1.cxx
@@ -19,7 +19,7 @@
 
 #include config_features.h
 
-#if defined(MACOSX)  defined(HAVE_FEATURE_READONLY_INSTALLSET)
+#if defined(MACOSX)  HAVE_FEATURE_READONLY_INSTALLSET
 #define __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES 0
 #include premac.h
 #include Foundation/Foundation.h
@@ -244,7 +244,7 @@ void Gallery::ImplLoadSubDirs( const INetURLObject 
rBaseURL, bool rbDirIsReadO
 
 uno::Reference sdbc::XResultSet  xResultSet( aCnt.createCursor( 
aProps, ::ucbhelper::INCLUDE_DOCUMENTS_ONLY ) );
 
-#if defined(MACOSX)  defined(HAVE_FEATURE_READONLY_INSTALLSET)
+#if defined(MACOSX)  HAVE_FEATURE_READONLY_INSTALLSET
 if( rBaseURL.GetProtocol() == INET_PROT_FILE )
 {
 const char *appBundle = [[[NSBundle mainBundle] bundlePath] 
UTF8String];
commit 698e501860a5a52a716b1ac88aa06a427b01c3a0
Author: Tor Lillqvist t...@collabora.com
Date:   Wed Oct 8 11:28:00 2014 +0300

Don't try to create cdefghij.klm inside the app bundle on OS X when 
sandboxed

Actually, we check HAVE_FEATURE_READONLY_INSTALLSET and not
HAVE_FEATURE_MACOSX_SANDBOX, but in practice we set the former only
for the latter case.

We could do this test cross-platform but I didn't bother now. Nobody
uses --enable-readonly-installset when building for Linux or Windows
anyway, I think.

(There must be more places where we could and should check
HAVE_FEATURE_READONLY_INSTALLSET.)

Change-Id: Ie54f436616a1db3119b0bc0148149784127b156d
(cherry picked from commit 

[Bug 36946] Slide transitions in Impress should be sorted in meaningful categories (Usability improvement)

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36946

--- Comment #14 from Bastián Díaz diaz.bast...@ymail.com ---
For this section the short term, I think there should be two drop down menus in
the sidebar. On the one hand showing the type (name) of the transition and the
other variants of transitions. This would shorten far the long list that is
currently displayed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


build fails for 4.3 with the last commit on htmlexport

2014-10-20 Thread Jean-Baptiste Faure
Hi,

the last commit on branch 4.3 (html export: Fix export of checked
checkbox and radiobutton.) seems to break the build :

 .../LibO/lo43/sw/qa/extras/htmlexport/htmlexport.cxx: In member function 
 ‘virtual void testExportCheckboxRadioButtonState::verify()’:
 .../LibO/lo43/sw/qa/extras/htmlexport/htmlexport.cxx:176:68: error: 
 ‘assertXPathNoAttribute’ was not declared in this scope
  assertXPathNoAttribute(pDoc, /html/body/p[2]/input, checked);
 ^
 make[1]: *** 
 [.../LibO/lo43/workdir/CxxObject/sw/qa/extras/htmlexport/htmlexport.o] Erreur 
 1
 make[1]: *** Attente des tâches non terminées
 make: *** [build] Erreur 2
 

I did only an incremental build, perhaps I must do a complete rebuild ?

Best regards.
JBF
-- 
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


RE: [Libreoffice-qa] Minutes of ESC call: 2014-10-16

2014-10-20 Thread nicholas ferguson
I will also add...that LibreOffice's approach to a complicated build... has
legs and could be marketed as a buid system for complicated apps, that are
cross platform.  Especially if it removes cygwin from its equation.  

-Original Message-
From: LibreOffice [mailto:libreoffice-boun...@lists.freedesktop.org] On
Behalf Of nicholas ferguson
Sent: Friday, October 17, 2014 9:39 PM
To: 'Bjoern Michaelsen'; 'Jan Holesovsky'
Cc: 'Libreoffice-qa'; 'libreoffice-dev'
Subject: RE: [Libreoffice-qa] Minutes of ESC call: 2014-10-16

(1)  A LibreOffice is not sanely built from Visual Studio.  just too big. It
overloads eclipse. A python + MSBuild, as an initial build, download of tar
files...anything divorced from cygwin is a better idea.
1.1  It's present build system, after study and understanding of
what build path to take...does run smoothly and does recover when build
threads crash.  Divorce it  from cygwin and keep that smoothness would be
great.
(2)  If VStudio is to be used, then a VStudio solution file for SCALC, and a
separate one for Word, or Visio... Each would load up all of its
dependencies and any associated env initialization files ( ala cppunit
test).  That could work.  Though.. a combination of python scripts for
builds and Visual Studio will probably be used in conjunction ...by windows
develoeprs...similar to using cygwin shells scripts and visual studio.
2.1  Any developer would be concentrating on one of those modules,
anyway.




-Original Message-
From: LibreOffice [mailto:libreoffice-boun...@lists.freedesktop.org] On
Behalf Of Bjoern Michaelsen
Sent: Friday, October 17, 2014 2:29 PM
To: Jan Holesovsky
Cc: Libreoffice-qa; libreoffice-dev
Subject: Re: [Libreoffice-qa] Minutes of ESC call: 2014-10-16

On Fri, Oct 17, 2014 at 11:13:12AM +0200, Jan Holesovsky wrote:
 * Open-source related projects for a local university (Jacobo)
 + ~200-300 hours projects sought
 + ideas appreciated!
 + please send to the ML too :-) (Norbert)

Two ideas from the build system world:

 - 1/ Replace all custom shell tooling (sed/grep/gawk/perl horrors) and
  consolidate on either native (C/C++) code (see e.g. concat-deps) or
_one_
  and only one consolidated solution beyond that, likely Python3 (as we
are
  bundling that and it is a good crossplatform superset of the POSIX
  shell-world). Bootstrapping on Windows would then likely be: Install
  native Python3, execute Python script that sets up the rest.

  rationale: As we already use a native GNU make on Windows, with this
we
  could remove our dependency on cygwin as Python3 is available natively
on
  Windows (and all other platforms).

 - 2/ Generate native Microsoft VS Project files from the gbuild description
  for our own native C/C++ files. This:
   https://bugs.freedesktop.org/show_bug.cgi?id=70414
   https://www.youtube.com/watch?v=Xn3CtIrMpIAhd=1
  would be the starting point.

  rationale: The aim would not be to do full release builds from these
(see
  1/ about that), but should allow patching and rebuilding one specific
library,
  which then can be pushed to gerrit.
  If we have this we could make the generation of these project files
part
  of the Windows build and deliverables (as some kind of sdk).
  Windows people could use these to patch some libs of their version of
  LibreOffice (without a full rebuild and thus without cygwin).

2/ is the one with the more immediate payoff: I might severly lower the
barrier to entry for new contributors on Windows at least for patches with a
limited scope. With gerrit builders we have the infra in place to verify and
handle such changes without too much extra work. Of course, combined with 1/
it would allow to ultimately move to make all Windows builds without cygwin.
Which would be all kinds of awesome for the Windows devs, I guess.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 45615] Implement additional 3d slideshow transitions

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45615

--- Comment #4 from Bastián Díaz diaz.bast...@ymail.com ---
Are very grateful to have more transition effects to LibreOffice.
As a user I wonder if these will be compatible (per style or category) with
those used in Keynote or MS PowerPoint, so in this case besides mantenet the
content and format, the display will be similar to the built in software
different from LibreOffice.

Here is the link for some videos showing the transitions found in Keynote or MS
PowerPoint.
http://m.youtube.com/watch?v=1fLQg5hFQQg
http://m.youtube.com/watch?v=vSCydTaOdC8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: svx/source

2014-10-20 Thread Matthew J . Francis
 svx/source/tbxctrls/PaletteManager.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 36b25a83fe0b6b0ae0f179bedfc207375633ed19
Author: Matthew J. Francis mjay.fran...@gmail.com
Date:   Sun Oct 19 16:24:55 2014 +0800

fdo#85185 Copy OUString argument to avoid a use after free

The original OUString is destroyed along with its containing
object part way through the call to PaletteManager::PopupColorPicker(),
so a copy must be taken

Change-Id: I8417ff23a17003e80a4f65e0cf1ad2a8dda5386c
Reviewed-on: https://gerrit.libreoffice.org/12031
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com

diff --git a/svx/source/tbxctrls/PaletteManager.cxx 
b/svx/source/tbxctrls/PaletteManager.cxx
index ca4c014..c561a5e 100644
--- a/svx/source/tbxctrls/PaletteManager.cxx
+++ b/svx/source/tbxctrls/PaletteManager.cxx
@@ -197,6 +197,8 @@ void 
PaletteManager::SetBtnUpdater(svx::ToolboxButtonColorUpdater* pBtnUpdater)
 
 void PaletteManager::PopupColorPicker(const OUString aCommand)
 {
+// The calling object goes away during aColorDlg.Execute(), so we must 
copy this
+OUString aCommandCopy = aCommand;
 SvColorDialog aColorDlg( 0 );
 aColorDlg.SetColor ( mLastColor );
 aColorDlg.SetMode( svtools::ColorPickerMode_MODIFY );
@@ -206,7 +208,7 @@ void PaletteManager::PopupColorPicker(const OUString 
aCommand)
 mpBtnUpdater-Update( aColorDlg.GetColor() );
 mLastColor = aColorDlg.GetColor();
 AddRecentColor( mLastColor );
-DispatchColorCommand(aCommand, mLastColor);
+DispatchColorCommand(aCommandCopy, mLastColor);
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: build fails for 4.3 with the last commit on htmlexport

2014-10-20 Thread Jean-Baptiste Faure
Hi Kendy,

Le 20/10/2014 18:15, Jan Holesovsky a écrit :
 Hi Jean-Baptiste,
 
 Jean-Baptiste Faure píše v Po 20. 10. 2014 v 15:47 +0200:
 
 .../LibO/lo43/sw/qa/extras/htmlexport/htmlexport.cxx: In member function 
 ‘virtual void testExportCheckboxRadioButtonState::verify()’:
 .../LibO/lo43/sw/qa/extras/htmlexport/htmlexport.cxx:176:68: error: 
 ‘assertXPathNoAttribute’ was not declared in this scope
  assertXPathNoAttribute(pDoc, /html/body/p[2]/input, checked);
 ^
 make[1]: *** 
 [.../LibO/lo43/workdir/CxxObject/sw/qa/extras/htmlexport/htmlexport.o] 
 Erreur 1
 make[1]: *** Attente des tâches non terminées
 make: *** [build] Erreur 2 

 I did only an incremental build, perhaps I must do a complete rebuild ?
 
 No, it uses a function that has been introduced in master only; pushed a
 quick fix.  Sorry for the problem.

Thank you, build successful.

Best regards.
JBF

-- 
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sc/source

2014-10-20 Thread Kohei Yoshida
 sc/source/core/data/table2.cxx |7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit b35c51d15189835bd388411f9ab4baefacd7b460
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Fri Oct 17 21:48:31 2014 -0400

fdo#80284: Avoid broadcasting during cell delete  shift.

Broadcasting it here and marking formula cells dirty prevents them
from being entered into the formula tree at the end.  They get marked
postponed dirty during reference update, and are supposed to be
set dirty at the end.

Change-Id: I65977300ee4ee26b6166d170acd2145abcbbf288
(cherry picked from commit 7fef943114b9184e69c8c714bf158116b8d9caf7)
Reviewed-on: https://gerrit.libreoffice.org/12014
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com

diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index 9abd954..9b4fd02 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -391,11 +391,8 @@ void ScTable::DeleteCol(
 }
 }
 
-{   // scope for bulk broadcast
-ScBulkBroadcast aBulkBroadcast( pDocument-GetBASM());
-for (SCSIZE i = 0; i  nSize; i++)
-aCol[nStartCol + i].DeleteArea(nStartRow, nEndRow, IDF_ALL);
-}
+for (SCSIZE i = 0; i  nSize; i++)
+aCol[nStartCol + i].DeleteArea(nStartRow, nEndRow, IDF_ALL, false);
 
 if ((nStartRow == 0)  (nEndRow == MAXROW))
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sc/source

2014-10-20 Thread Kohei Yoshida
 sc/source/core/tool/token.cxx |   47 ++
 1 file changed, 47 insertions(+)

New commits:
commit ab5ff775b5b197a11a76a5e91859c31421ff559f
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Sat Oct 18 20:22:53 2014 -0400

fdo#82047: Correctly adjust references in range names on row deletion.

Change-Id: Iac924b0b6932863f7f9cc088f996e0b07c340d2c
(cherry picked from commit 281847613bd3ae472523822f4be9c21cc353867e)
Reviewed-on: https://gerrit.libreoffice.org/12025
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com

diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx
index 916a88e..84c8ccc 100644
--- a/sc/source/core/tool/token.cxx
+++ b/sc/source/core/tool/token.cxx
@@ -3170,6 +3170,53 @@ sc::RefUpdateResult ScTokenArray::AdjustReferenceInName(
 if (adjustDoubleRefInName(rRef, rCxt, rPos))
 aRes.mbReferenceModified = true;
 }
+else if (rCxt.mnRowDelta  0)
+{
+// row(s) deleted.
+if (rRef.Ref1.IsRowRel() || rRef.Ref2.IsRowRel())
+// Don't modify relative references in names.
+break;
+
+if (aAbs.aStart.Col()  rCxt.maRange.aStart.Col() || 
rCxt.maRange.aEnd.Col()  aAbs.aEnd.Col())
+// column range of the reference is not entirely in 
the deleted column range.
+break;
+
+ScRange aDeleted = rCxt.maRange;
+aDeleted.aStart.IncRow(rCxt.mnRowDelta);
+
aDeleted.aEnd.SetRow(aDeleted.aStart.Row()-rCxt.mnRowDelta-1);
+
+if (aAbs.aEnd.Row()  aDeleted.aStart.Row() || 
aDeleted.aEnd.Row()  aAbs.aStart.Row())
+// reference range doesn't intersect with the deleted 
range.
+break;
+
+if (aDeleted.aStart.Row() = aAbs.aStart.Row()  
aAbs.aEnd.Row() = aDeleted.aEnd.Row())
+{
+// This reference is entirely deleted.
+rRef.Ref1.SetRowDeleted(true);
+rRef.Ref2.SetRowDeleted(true);
+aRes.mbReferenceModified = true;
+break;
+}
+
+if (aAbs.aStart.Row()  aDeleted.aStart.Row())
+{
+if (aDeleted.aEnd.Row()  aAbs.aEnd.Row())
+// Deleted in the middle.  Make the reference 
shorter.
+rRef.Ref2.IncRow(rCxt.mnRowDelta);
+else
+// Deleted at tail end.  Cut off the lower part.
+rRef.Ref2.SetAbsRow(aDeleted.aStart.Row()-1);
+}
+else
+{
+// Deleted at the top.  Cut the top off and shift up.
+rRef.Ref1.SetAbsRow(aDeleted.aEnd.Row()+1);
+rRef.Ref1.IncRow(rCxt.mnRowDelta);
+rRef.Ref2.IncRow(rCxt.mnRowDelta);
+}
+
+aRes.mbReferenceModified = true;
+}
 else if (rCxt.maRange.Intersects(aAbs))
 {
 if (rCxt.mnColDelta  rCxt.maRange.aStart.Row() = 
aAbs.aStart.Row()  aAbs.aEnd.Row() = rCxt.maRange.aEnd.Row())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: configure.ac

2014-10-20 Thread Tor Lillqvist
 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1ddc9fd6365059e93d3e080d2121693a658c9ff7
Author: Tor Lillqvist t...@collabora.com
Date:   Tue Oct 21 00:44:22 2014 +0300

Correct comment

Change-Id: I29633cfe7b378796bec5fe822941193ded8a9aa9

diff --git a/configure.ac b/configure.ac
index 5d2198b..de17612 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2725,7 +2725,7 @@ if test $_os = Darwin; then
 # SDK will be found automatically without any configure options.
 
 # For developers with a current Xcode, the lowest-numbered SDK
-# higher than the minimum required should be found.
+# higher than or equal to the minimum required should be found.
 
 AC_MSG_CHECKING([what Mac OS X SDK to use])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: configure.ac

2014-10-20 Thread Tor Lillqvist
 configure.ac |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 7caf64cd7d289993f00f78ee374010e353484608
Author: Tor Lillqvist t...@collabora.com
Date:   Tue Oct 21 01:00:34 2014 +0300

Current iOS SDK is now 8.1

Change-Id: Ie2860cf1a279d08cf8a08b72c20539ddaa00be15

diff --git a/configure.ac b/configure.ac
index de17612..8babb1d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2954,8 +2954,8 @@ if test $_os = iOS; then
 
 xcode_developer=`xcode-select -print-path`
 
-current_sdk_ver=7.1
-for sdkver in 8.0 7.1; do
+current_sdk_ver=8.1
+for sdkver in 8.1 8.0; do
 
t=$xcode_developer/Platforms/$platform.platform/Developer/SDKs/$platform$sdkver.sdk
 if test -d $t; then
 ios_sdk=$sdkver
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'feature/perfwork4' - 6 commits - chart2/inc chart2/source

2014-10-20 Thread Michael Stahl
 chart2/inc/ChartView.hxx|1 
 chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx |2 
 chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx   |6 
 chart2/source/inc/AxisHelper.hxx|2 
 chart2/source/inc/chartview/ExplicitValueProvider.hxx   |2 
 chart2/source/inc/macros.hxx|1 
 chart2/source/tools/AxisHelper.cxx  |6 
 chart2/source/tools/ExplicitCategoriesProvider.cxx  |2 
 chart2/source/view/axes/Tickmarks.cxx   |   29 --
 chart2/source/view/axes/Tickmarks.hxx   |8 
 chart2/source/view/axes/VAxisBase.cxx   |   25 --
 chart2/source/view/axes/VAxisBase.hxx   |9 
 chart2/source/view/axes/VCartesianAxis.cxx  |  118 
++
 chart2/source/view/axes/VCartesianAxis.hxx  |   10 
 chart2/source/view/axes/VCartesianCoordinateSystem.cxx  |   22 -
 chart2/source/view/axes/VCartesianCoordinateSystem.hxx  |2 
 chart2/source/view/axes/VCoordinateSystem.cxx   |   41 ---
 chart2/source/view/axes/VPolarCoordinateSystem.cxx  |9 
 chart2/source/view/axes/VPolarCoordinateSystem.hxx  |2 
 chart2/source/view/inc/VCoordinateSystem.hxx|9 
 chart2/source/view/main/ChartView.cxx   |   70 ++---
 21 files changed, 101 insertions(+), 275 deletions(-)

New commits:
commit 31375f662517d864e90c0dcc040606d7ca8776c0
Author: Michael Stahl mst...@redhat.com
Date:   Mon Oct 20 14:56:32 2014 +0200

chart2: fix memory leak due to cyclic reference in VAxisBase

The VAxisBase::m_xNumberFormatsSupplier refers to the ChartModel itself,
and apparently that is a cyclic reference.  Naively using the
ChartModel's m_xNumberFormatsSupplier in
ChartView::impl_createDiagramAndContent() because it will later be passed
to AxisHelper::getExplicitNumberFormatKeyForAxis(), which expects to be
able to convert it to a ChartModel.

Since passing around the ChartModel as an XNumberFormattingSupplier is
sort of un-intuitive anyway, refactor some methods to use XChartDocument
instead, and only create the VPolarAxis / VCartesianAxis with the
ChartModel's m_xNumberFormatsSupplier.

The drawback is that if ChartModel::attachNumberFormatsSupplier()
is called after ChartView::update() has created the axes, it may not
have an effect on them; not sure if that is a real or hypothetical
problem.

Change-Id: Ib5f0d5882b85adaf44f80e086f19178b3e64882f

diff --git a/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx 
b/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx
index 1588a2f..afdebd1 100644
--- a/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx
+++ b/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx
@@ -158,7 +158,7 @@ sal_Int32 
Chart2ModelContact::getExplicitNumberFormatKeyForAxis(
   xAxis, ChartModelHelper::findDiagram( m_xChartModel ) ) );
 
 return ExplicitValueProvider::getExplicitNumberFormatKeyForAxis( xAxis, 
xCooSys
-  , Reference util::XNumberFormatsSupplier ( 
m_xChartModel.get(), uno::UNO_QUERY ) );
+  , getChart2Document());
 }
 
 sal_Int32 Chart2ModelContact::getExplicitNumberFormatKeyForSeries(
diff --git a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx 
b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
index e2cd620..76f7d68 100644
--- a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
@@ -363,7 +363,7 @@ void AxisItemConverter::FillSpecialItem( sal_uInt16 
nWhichId, SfxItemSet  rOutI
 Reference chart2::XAxis  xCrossingMainAxis( 
AxisHelper::getCrossingMainAxis( m_xAxis, xCooSys ) );
 
 sal_Int32 nFormatKey = 
ExplicitValueProvider::getExplicitNumberFormatKeyForAxis(
-xCrossingMainAxis, xCooSys, Reference 
util::XNumberFormatsSupplier ( m_xChartDoc, uno::UNO_QUERY ) );
+xCrossingMainAxis, xCooSys, m_xChartDoc);
 
 rOutItemSet.Put( SfxUInt32Item( nWhichId, nFormatKey ));
 }
@@ -407,7 +407,7 @@ void AxisItemConverter::FillSpecialItem( sal_uInt16 
nWhichId, SfxItemSet  rOutI
   m_xAxis, ChartModelHelper::findDiagram( 
m_xChartDoc ) ) );
 
 sal_Int32 nFormatKey = 
ExplicitValueProvider::getExplicitNumberFormatKeyForAxis(
-m_xAxis, xCooSys, Reference util::XNumberFormatsSupplier 
( m_xChartDoc, uno::UNO_QUERY ) );
+m_xAxis, xCooSys, m_xChartDoc);
 
 rOutItemSet.Put( SfxUInt32Item( nWhichId, nFormatKey ));
 }
@@ -948,7 +948,7 @@ 

[Libreoffice-qa] Reminder: Our next QA Meeting is on Wednesday!

2014-10-20 Thread Robinson Tryon
This Wednesday, join us for a quick meeting on IRC and

1) Let us know what you've been doing this week!
2) Bring up any high-priority or needAdvice bugs
3) Hear about our stats

(spoiler: UNCONCONFIRMED bug count is down to 776)

4) I'll give a quick update on the Seattle LibreFest this weekend
(which is shaping up to be one of our biggest QA events yet!)

When? Where? How?
Find the handy-dandy link (to the website that shows the meeting time
in your local time zone), the IRC Channel, and all of that good stuff
on the meeting page here:
https://wiki.documentfoundation.org/QA/Meetings/2014/October_22

I hope to see all of you there!

Best,
--R


-- 
Robinson Tryon
QA Engineer - The Document Foundation
LibreOffice Community Outreach Herald
qu...@libreoffice.org
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


Re: [Libreoffice-qa] Reminder: Our next QA Meeting is on Wednesday!

2014-10-20 Thread Tommy
On Mon, 20 Oct 2014 18:31:58 +0200, Robinson Tryon  
bishop.robin...@gmail.com wrote:




3) Hear about our stats

(spoiler: UNCONCONFIRMED bug count is down to 776)


let's try to drop the 750 milestone till wednesday !!! :-)

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


[Libreoffice-qa] Seattle LibreFest: Join us online or in person this Sunday!

2014-10-20 Thread Robinson Tryon
Hi all,

Remember: Next Sunday (Oct 26th) we'll be having a 'LibreFest'
combination Bug-Triaging-Bee and Hackfest in Seattle, Washington in
the US:
https://wiki.documentfoundation.org/Events/2014/Seattle_LibreFest

Right we've got three devs, 1 person from QA (me), 1 of our awesome
volunteers from OSCON, and and about 16 other people signed up for the
event. New students and other volunteers are signing up each day!

In the QA portion of the event, we're going to get people up to speed
with the basics of bug triage and (time/experience permitting)
introduce some of the more advanced QAers to our bibisect tools.

If you happen to be in the area, we'd love to see you in person (just
email me!), but for everyone who is further away, we'd love to have
you join us online. It would be great to have your help with mentoring
over IRC, or just have you help us attack our backlog of UNCONFIRMED,
NEEDINFO, and other bugs.

Notes:
- Please concentrate your efforts on *harder* bugs this week. Let's
make sure we have a good crop of easy pickings for the newbies
- If you have a suggestion for introductory-level QA tasks, ping me!
- Let me know if you want to join in online. We might be able to put
the remote people up on the big screen via Google Hangouts

Thanks for your help!
--R

-- 
Robinson Tryon
QA Engineer - The Document Foundation
LibreOffice Community Outreach Herald
qu...@libreoffice.org
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


Re: [Libreoffice-qa] Reminder: Our next QA Meeting is on Wednesday!

2014-10-20 Thread Terrence Enger
On Mon, 2014-10-20 at 19:40 +0200, Tommy wrote:
 On Mon, 20 Oct 2014 18:31:58 +0200, Robinson Tryon  
 bishop.robin...@gmail.com wrote:
 
  
  3) Hear about our stats
 
  (spoiler: UNCONCONFIRMED bug count is down to 776)
 
 let's try to drop the 750 milestone till wednesday !!! :-)

I suggest tracking as well UNCONFIRMED plus NEEDINFO minus Need
developer advice.  The NEEDINFO bugs are not in our court, so to
speak, but they are among the bugs filed but not ready for
developer attention.  And the transition from NEEDINFO back to
UNCONFIRMED marks *progress*, we hope.


___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


[Libreoffice-bugs] [Bug 84008] EDITING: Crash when inserting 3D Model

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84008

Zolnai Tamás zolnaitamas2...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #22 from Zolnai Tamás zolnaitamas2...@gmail.com ---
I tested the 4.3.3.1 linux x86 rpm package and collada\kmz support works.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85055] export size is different from selection possibilities

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85055

--- Comment #8 from Alexander Berg a.b...@berg-kommunikation.de ---
Thats simple:

Just select Export... than choose HTML-document... and follow the steps. I
added a screenshot of the third step, where the problem can be found (You see,
I selected 1024*768) but after 1024*768 the exported size is only 800*600. And
instead of 800*600 its only 640*480 and instead of 640*480 the grafics are only
512*384 pixel.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85055] export size is different from selection possibilities

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85055

--- Comment #9 from Alexander Berg a.b...@berg-kommunikation.de ---
Created attachment 108083
  -- https://bugs.freedesktop.org/attachment.cgi?id=108083action=edit
Screenshot of export

Here you can see the selected size.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 73386] EDITING: There is no warning/information when one accidentaly deletes non-visible (zero width) fields (e.g. mail merge next record !)

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73386

Alex Thurgood ipla...@yahoo.co.uk changed:

   What|Removed |Added

  Attachment #91640|text/plain  |image/png
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 73386] EDITING: There is no warning/information when one accidentaly deletes non-visible (zero width) fields (e.g. mail merge next record !)

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73386

Alex Thurgood ipla...@yahoo.co.uk changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #11 from Alex Thurgood ipla...@yahoo.co.uk ---
Confirmed, for me this is a  request for enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 70867] FILEOPEN: Libreoffice takes 20 min to open xlsx file and then cannot save it in ods

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70867

--- Comment #5 from todven...@suomi24.fi ---
Opened in a couple of minutes on Win 7 64-bit 4.3.2.2.
Opened in a couple of seconds on dev build Version: 4.4.0.0.alpha0+
Build ID: 3e2bd1e4022e25b77bcc8eba5e02c1adc57008a1
TinderBox: Win-x86@42, Branch:master, Time: 2014-10-16_01:04:13

Tried saving to .ods with 4.3.2.2, hangs.
Tried saving to .ods with dev build, success in about 30 secs, but opening the
.ods freezes LO!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 74300] Base:Database Position and Size box does not paint - it displays what's beneath it instead

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74300

--- Comment #9 from Alex Thurgood ipla...@yahoo.co.uk ---
Can't reproduce on 

Version: 4.3.2.2
Build ID: edfb5295ba211bd31ad47d0bad0118690f76407d

OSX Yosemite 10.10

Graphics : 

Jeu de composants :NVIDIA GeForce 320M
  Type :Processeur graphique (GPU)
  Bus :PCI
  VRAM (totale) :256 Mo
  Fournisseur :NVIDIA (0x10de)
  Identifiant du périphérique :0x08a4
  Identifiant de révision :0x00a2
  Révision de la ROM :3546

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85213] Crash when changing default detailed calculation options

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85213

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl
 Ever confirmed|0   |1

--- Comment #1 from Cor Nouws c...@nouenoff.nl ---
Can confirm this on Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 70519] ACCESSIBILITY: option to make spelling and grammar checker wavy line THICKER

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70519

--- Comment #5 from Kumāra kumara.bhik...@gmail.com ---
Yes. Thank you very much. :) _/\_

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85212] FORMATTING: Strange gray lines around charts

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85212

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||c...@nouenoff.nl
 Resolution|--- |NOTABUG

--- Comment #1 from Cor Nouws c...@nouenoff.nl ---
Hi Juha,

Thanks for the report and the sample file and the graphic!
LibreOffice imports floating tables in a frame. So that are the grey lines you
see ;) So I close as not a bug.

Regards,
Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 74300] Base:Database Position and Size box does not paint - it displays what's beneath it instead

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74300

--- Comment #10 from Alex Thurgood ipla...@yahoo.co.uk ---
Could well be a graphics driver issue

I followed your instructions from comment 6, i.e. complete new database using
default Assets table via database wizard, the directly on to creating form with
corresponding wizard. Open form for editing (form design mode), select a field
with mouse, right mouse button click, choose Position  Size.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 74300] Base:Database Position and Size box does not paint - it displays what's beneath it instead

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74300

Alex Thurgood ipla...@yahoo.co.uk changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85210] FORMATTING: Strange gray rectangles

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85210

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||c...@nouenoff.nl
 Resolution|--- |NOTABUG

--- Comment #1 from Cor Nouws c...@nouenoff.nl ---
those are non braking spaces. See View  Field shadings

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 74300] Base:Database Position and Size box does not paint - it displays what's beneath it instead

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74300

--- Comment #11 from Alex Thurgood ipla...@yahoo.co.uk ---
Do you still see this with latest production release 4322 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 72909] FILEOPEN: Hyperlink Record

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72909

--- Comment #2 from todven...@suomi24.fi ---
I can open the unpossible1.ods just fine on Win 7 64-bit 4.3.2.2 and dev build
Version: 4.4.0.0.alpha0+
Build ID: 3e2bd1e4022e25b77bcc8eba5e02c1adc57008a1
TinderBox: Win-x86@42, Branch:master, Time: 2014-10-16_01:04:13

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85212] FORMATTING: Strange gray lines around charts

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85212

--- Comment #2 from Cor Nouws c...@nouenoff.nl ---
*** Bug 85211 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 76053] xComponentLoader.loadComponentFromURL'd different number of iteration in different versions

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76053

Alex Thurgood ipla...@yahoo.co.uk changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #6 from Alex Thurgood ipla...@yahoo.co.uk ---
Thanks for getting back, closing as wfm

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85211] FORMATTING: Strange gray lines around images

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85211

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||c...@nouenoff.nl
 Resolution|--- |DUPLICATE

--- Comment #1 from Cor Nouws c...@nouenoff.nl ---
Maybe for such questions you could consider to first ask for user-support. For
example there is a group of users with a great variety of skills that can offer
help with questions:
  http://www.libreoffice.org/get-help/community-support/

Best,
Cor

*** This bug has been marked as a duplicate of bug 85212 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 81759] Mac OS X dictation (aka Siri) does not work with Libreoffice 4.3.0.3 or newer (did work in 4.2)

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81759

--- Comment #14 from Alex Thurgood ipla...@yahoo.co.uk ---
(In reply to detlefscloud from comment #13)


 I can start LO Version: 4.3.2.2 on my iMac (now OS X 10.10) over the VM ware
 Parallels with windows 7. And if I do so  Siri is working. The question is,
 how is para working. Is the newly implemented AVFoundation code for
 Mac-Version and Windows-Version the same code? Are there distinctions?



Unfortunately, I have no idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 81605] Creating labels from database data leads to many duplicate labels

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81605

Alex Thurgood ipla...@yahoo.co.uk changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #5 from Alex Thurgood ipla...@yahoo.co.uk ---
The database file contains no data, it is an empty Writer document, please
provide corresponding database

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82316] Dialog box wrong size query editor table relationships (regression 4.3.0.4?)

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82316

Alex Thurgood ipla...@yahoo.co.uk changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #8 from Alex Thurgood ipla...@yahoo.co.uk ---
Possibly Windows only bug ?

@Doug : please test with LO 4322 with clean LO profile and report back

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 50774] FILEOPEN DOC/DOCX: automatic numbering in numbered lists different from Word numbering

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50774

--- Comment #18 from todven...@suomi24.fi ---
Numbering works ok for me on Win 7 64-bit 4.3.2.2 and dev build Version:
4.4.0.0.alpha0+
Build ID: 3e2bd1e4022e25b77bcc8eba5e02c1adc57008a1
TinderBox: Win-x86@42, Branch:master, Time: 2014-10-16_01:04:13

Please test!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 49946] landscape PRINTING result on portrait paper sheet for 2 pages per sheet

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=49946

--- Comment #27 from stof...@cmdt.ch ---
 not resolved !!! ***

hi

with 

opensuse13.1
LO Version: 4.3.2.2 Build ID: edfb5295ba211bd31ad47d0bad0118690f76407d
print via cups
2 pages per sheet
to brother MFC-J6510DW
Name: mfcj6510dwcupswrapper
Version : 3.0.0
Release : 1
Architecture: i386
Install Date: Mit 25 Jun 2014 17:47:16 CEST
Group   : Applications
Size: 64256
License : 2004-2012 Brother Industries, Ltd. All Rights Reserved
Signature   : (none)
Source RPM  : mfcj6510dwcupswrapper-3.0.0-1.src.rpm
Build Date  : Don 22 Mär 2012 09:07:35 CET
Build Host  : localhost.domain
Relocations : (not relocatable)
Packager: root@localhost
Vendor  : Brother Industries, Ltd.
Summary : Brother CUPS Inkjet Printer Definitions
Description :
Brother Inkjet printer CUPS Driver
Distribution: (none)

LO prints the pages still as shown in the attachment current and expected
behavior.

thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82318] Form editing repositioning of screen, away from control being edited

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82318

Alex Thurgood ipla...@yahoo.co.uk changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Alex Thurgood ipla...@yahoo.co.uk ---
@Doug : this problem has always been present, even before creation of the
current project, e.g. it has been in every iteration of OOo

Simple workaround : add appropriate paragraph returns to your Writer form in
design mode

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82318] Form editing repositioning of screen, away from control being edited

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82318

--- Comment #5 from Alex Thurgood ipla...@yahoo.co.uk ---
Set this as rfe.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82318] Form editing repositioning of screen, away from control being edited

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82318

Alex Thurgood ipla...@yahoo.co.uk changed:

   What|Removed |Added

   Priority|medium  |low
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 77007] FILEOPEN: User asked to save changes upon exit from unmodified XLS file (possibly because of particular chart)

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77007

--- Comment #4 from Yan Pashkovsky yanp...@gmail.com ---
What do you mean under testcase? List of steps how to create such file with
bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 49946] landscape PRINTING result on portrait paper sheet for 2 pages per sheet

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=49946

--- Comment #28 from stof...@cmdt.ch ---
and as a remember:

printing the odt as an pdf with okular (kde pdf-reader) 2 pages per sheet does
the job as it should be.

thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   >