LibreOffice Gerrit News for core on 2014-10-28

2014-10-28 Thread gerrit
Moin!

* Open changes on master for project core changed in the last 25 hours:

 First time contributors doing great things! 
+ fdo#85046 - MENU: Edit  Changes should be renamed for better clarity
  in https://gerrit.libreoffice.org/12098 from Yousuf Philips
  about module officecfg, sc, svx, sw
+ Apache Commons Lang 3.3.1 at least requires Java 1.6 and pass ENABLE_DEBU
  in https://gerrit.libreoffice.org/12116 from Robert Antoni Buj i Gelonch
  about module external
+ Apache Commons Codec 1.9 at least requires Java 1.6 and pass ENABLE_DEBUG
  in https://gerrit.libreoffice.org/12115 from Robert Antoni Buj i Gelonch
  about module external
+ fdo#82272 - New 'Chart' toolbar icon
  in https://gerrit.libreoffice.org/12112 from Yousuf Philips
  about module icon-themes
+ fdo#80403: AutoCorrect uses XFastParser
  in https://gerrit.libreoffice.org/12083 from Daniel Sikeler
  about module editeng
+ fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT
  in https://gerrit.libreoffice.org/12103 from Naruhiko Ogasawara
  about module pyuno
+ Clarify configure GStreamer handling
  in https://gerrit.libreoffice.org/11912 from Jan-Marek Glogowski
  about module avmedia, build, postprocess
+ Fix python wrapper script on OS X
  in https://gerrit.libreoffice.org/12101 from Matthew Francis
  about module pyuno
+ fdo#83395 - Export: PDF export dialog has no mention of the word 'hybrid 
  in https://gerrit.libreoffice.org/12081 from Yousuf Philips
  about module filter
 End of freshness 

+ vcl: seperate gradient metafile from gradient drawing
  in https://gerrit.libreoffice.org/12119 from Chris Sherlock
  about module include, vcl
+ vcl: introduce SalGraphics::DrawGradient()
  in https://gerrit.libreoffice.org/12120 from Chris Sherlock
  about module vcl
+ fdo#84938: replace TIMEF_ constants with enum
  in https://gerrit.libreoffice.org/12114 from Noel Grandin
  about module extensions, include, rsc, sd, vcl
+ fdo#39468 Translate German Comments - sc/source/filter/{lotus,starcalc,xm
  in https://gerrit.libreoffice.org/12036 from Christian M. Heller
  about module sc
+ sal_Int16 as the underlying type of WindowBorderStyle
  in https://gerrit.libreoffice.org/12110 from Takeshi Abe
  about module include, rsc
+ [PATCH] RFC: ref-counting vcl::Window subclasses
  in https://gerrit.libreoffice.org/11972 from Noel Grandin
  about module extensions, filter, include, reportdesign, sfx2, svtools, vcl
+ android: Show document browser back in the menu
  in https://gerrit.libreoffice.org/12108 from Jacobo Aragunde Pérez
  about module android


* Merged changes on master for project core changed in the last 25 hours:

+ TANGO: add new icons for page break, line spacing, comment, and footnote
  in https://gerrit.libreoffice.org/12118 from Yousuf Philips
+ nss: add libnsspem.dylib to macosx-change-install-names.pl call
  in https://gerrit.libreoffice.org/12079 from Robert Antoni Buj i Gelonch
+ fdo#84408 Toolbar: Insert Field dropdown doesn't contain icons
  in https://gerrit.libreoffice.org/12068 from juegen funk
+ SIFR: add missing icons for calc's function wizard and sum toolbar button
  in https://gerrit.libreoffice.org/12109 from Yousuf Philips
+ fdo#85500 - TOOLBAR: Use insert page number icon for insert field control
  in https://gerrit.libreoffice.org/12107 from Yousuf Philips
+ fdo#84938: replace KEYTYPE_ constants with enum
  in https://gerrit.libreoffice.org/12104 from Noel Grandin


* Abandoned changes on master for project core changed in the last 25 hours:

+ vcl: move mirror from SalGraphics to OutputDevice - part 12: CopyBits
  in https://gerrit.libreoffice.org/12060 from Chris Sherlock
+ vcl: move mirror from SalGraphics to OutputDevice - part 11: CopyArea
  in https://gerrit.libreoffice.org/12059 from Chris Sherlock
+ vcl: mv mirror from SalGraphics to OutputDevice - pt10 polypolygonbezier
  in https://gerrit.libreoffice.org/12051 from Chris Sherlock
+ vcl: mv mirror from SalGraphics to OutputDevice - part 9: polygon bezier
  in https://gerrit.libreoffice.org/12048 from Chris Sherlock
+ vcl: mv mirror from SalGraphics to OutputDevice - part 8: polylinebezier
  in https://gerrit.libreoffice.org/12037 from Chris Sherlock
+ vcl: move mirror from SalGraphics to OutputDevice - part 7: polypolygons
  in https://gerrit.libreoffice.org/12035 from Chris Sherlock
+ vcl: move mirror from SalGraphics to OutputDevice - part 6: polygons
  in https://gerrit.libreoffice.org/12032 from Chris Sherlock
+ vcl: move mirror from SalGraphics to OutputDevice - part 5: polylines
  in https://gerrit.libreoffice.org/12030 from Chris Sherlock
+ vcl: move mirror from SalGraphics to OutputDevice - part 4: rectangles
  in https://gerrit.libreoffice.org/12029 from Chris Sherlock
+ vcl: move mirror from SalGraphics to OutputDevice - part 3: lines
  in https://gerrit.libreoffice.org/12028 from Chris Sherlock
+ vcl: move mirror from SalGraphics to OutputDevice - part 2: clipping
  in https://gerrit.libreoffice.org/12027 from Chris Sherlock
+ vcl: mv 

[Libreoffice-commits] core.git: 6 commits - cui/source extensions/source include/rsc rsc/inc rsc/source sc/inc sc/source sd/source vcl/source

2014-10-28 Thread Noel Grandin
 cui/source/tabpages/transfrm.cxx   |2 
 extensions/source/propctrlr/standardcontrol.cxx|2 
 include/rsc/rsc-vcl-shared-types.hxx   |2 
 rsc/inc/rscdb.hxx  |5 
 rsc/source/parser/rscibas.cxx  |6 
 sc/inc/drwlayer.hxx|4 
 sc/source/core/opencl/openclwrapper.cxx|4 
 sc/source/filter/excel/excimp8.cxx |2 
 sc/source/filter/excel/tokstack.cxx|   52 ++--
 sc/source/filter/excel/xiescher.cxx|2 
 sc/source/filter/html/htmlexp.cxx  |   56 ++--
 sc/source/filter/html/htmlexp2.cxx |4 
 sc/source/filter/html/htmlimp.cxx  |   26 +-
 sc/source/filter/inc/scflt.hxx |   24 +-
 sc/source/filter/inc/tokstack.hxx  |2 
 sc/source/filter/rtf/eeimpars.cxx  |4 
 sc/source/filter/rtf/rtfexp.cxx|   16 -
 sc/source/filter/rtf/rtfimp.cxx|2 
 sc/source/filter/rtf/rtfparse.cxx  |6 
 sc/source/filter/starcalc/scflt.cxx|   10 
 sc/source/filter/xcl97/XclExpChangeTrack.cxx   |6 
 sc/source/filter/xcl97/xcl97esc.cxx|   10 
 sc/source/filter/xcl97/xcl97rec.cxx|4 
 sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx |8 
 sc/source/ui/attrdlg/attrdlg.cxx   |2 
 sc/source/ui/attrdlg/tabpages.cxx  |4 
 sc/source/ui/condformat/colorformat.cxx|2 
 sc/source/ui/condformat/condformatdlgentry.cxx |4 
 sc/source/ui/dbgui/consdlg.cxx |8 
 sc/source/ui/dbgui/filtdlg.cxx |6 
 sc/source/ui/dbgui/pfiltdlg.cxx|6 
 sc/source/ui/dbgui/scendlg.cxx |4 
 sc/source/ui/dbgui/sfiltdlg.cxx|6 
 sc/source/ui/dbgui/tpsort.cxx  |   16 -
 sc/source/ui/dbgui/tpsubt.cxx  |   18 -
 sc/source/ui/dbgui/validate.cxx|   22 -
 sc/source/ui/docshell/docfunc.cxx  |   14 -
 sc/source/ui/docshell/docsh.cxx|   28 +-
 sc/source/ui/docshell/docsh3.cxx   |   30 +-
 sc/source/ui/docshell/docsh4.cxx   |   70 +++---
 sc/source/ui/docshell/docsh6.cxx   |4 
 sc/source/ui/docshell/tablink.cxx  |2 
 sc/source/ui/drawfunc/drawsh.cxx   |2 
 sc/source/ui/drawfunc/drawsh2.cxx  |2 
 sc/source/ui/drawfunc/drawsh4.cxx  |4 
 sc/source/ui/drawfunc/drawsh5.cxx  |6 
 sc/source/ui/drawfunc/drtxtob.cxx  |   68 ++---
 sc/source/ui/drawfunc/drtxtob2.cxx |6 
 sc/source/ui/drawfunc/fuconcustomshape.cxx |6 
 sc/source/ui/drawfunc/fuconpol.cxx |2 
 sc/source/ui/drawfunc/fuconrec.cxx |   10 
 sc/source/ui/drawfunc/fuconstr.cxx |2 
 sc/source/ui/drawfunc/fudraw.cxx   |2 
 sc/source/ui/drawfunc/fuins1.cxx   |8 
 sc/source/ui/drawfunc/fuins2.cxx   |6 
 sc/source/ui/drawfunc/fusel.cxx|6 
 sc/source/ui/drawfunc/futext.cxx   |   10 
 sc/source/ui/drawfunc/graphsh.cxx  |   22 -
 sc/source/ui/formdlg/formula.cxx   |8 
 sc/source/ui/miscdlgs/acredlin.cxx |   14 -
 sc/source/ui/miscdlgs/anyrefdg.cxx |   22 -
 sc/source/ui/miscdlgs/autofmt.cxx  |   32 +-
 sc/source/ui/miscdlgs/crnrdlg.cxx  |   16 -
 sc/source/ui/miscdlgs/scuiautofmt.cxx  |2 
 sc/source/ui/miscdlgs/tabbgcolordlg.cxx|2 
 sc/source/ui/miscdlgs/textdlgs.cxx |2 
 sc/source/ui/navipi/content.cxx|   14 -
 sc/source/ui/navipi/navipi.cxx |4 
 sc/source/ui/navipi/scenwnd.cxx

[Libreoffice-commits] core.git: include/rsc rsc/inc

2014-10-28 Thread Takeshi Abe
 include/rsc/rsc-vcl-shared-types.hxx |2 +-
 rsc/inc/rscdb.hxx|2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 95ca903043c0ad9010deaca7e32ae09cc8afbbf8
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Mon Oct 27 22:43:48 2014 +0900

sal_Int16 as the underlying type of WindowBorderStyle

because g++ 4.7.2 generates [-Werror=type-limits] as follows:
 [build CXX] vcl/source/window/settings.cxx
 [build CXX] vcl/source/window/paint.cxx
 [build CXX] vcl/source/window/resource.cxx
 [build CXX] vcl/source/window/accel.cxx
 [build CXX] vcl/source/window/accmgr.cxx
 [build CXX] vcl/source/window/brdwin.cxx
 [build CXX] vcl/source/window/accessibility.cxx
 [build CXX] vcl/source/window/legacyaccessibility.cxx
 [build CXX] vcl/source/window/clipping.cxx
 [build CXX] vcl/source/window/stacking.cxx
 [build CXX] vcl/source/window/debug.cxx
 [build CXX] vcl/source/window/globalization.cxx
 [build CXX] vcl/source/window/btndlg.cxx
 [build CXX] vcl/source/window/builder.cxx
 [build CXX] vcl/source/window/cmdevt.cxx
 [build CXX] vcl/source/window/cursor.cxx
 [build CXX] vcl/source/window/debugevent.cxx
 [build CXX] vcl/source/window/decoview.cxx
 In file included from 
/home/tabe/core/include/rsc/rsc-vcl-shared-types.hxx:24:0,
  from /home/tabe/core/include/vcl/keycodes.hxx:23,
  from /home/tabe/core/include/vcl/keycod.hxx:26,
  from /home/tabe/core/vcl/inc/svdata.hxx:35,
  from /home/tabe/core/vcl/source/window/brdwin.cxx:21:
 /home/tabe/core/include/o3tl/typed_flags_set.hxx: In instantiation of 
'typename o3tl::typed_flagsT::Wrap operator(E, E) [with E = 
WindowBorderStyle; typename o3tl::typed_flagsT::Wrap = 
o3tl::is_typed_flagsWindowBorderStyle, 12339::Wrap]':
 /home/tabe/core/vcl/source/window/brdwin.cxx:1027:44:   required from here
 /home/tabe/core/include/o3tl/typed_flags_set.hxx:105:5: error: comparison 
is always true due to limited range of data type [-Werror=type-limits]
 /home/tabe/core/include/o3tl/typed_flags_set.hxx:106:5: error: comparison 
is always true due to limited range of data type [-Werror=type-limits]
 cc1plus: all warnings being treated as errors
 make[1]: *** 
[/home/tabe/build/workdir/CxxObject/vcl/source/window/brdwin.o] Error 1
 make[1]: *** Waiting for unfinished jobs
 make: *** [vcl.all] Error 2
 tabe@thunk:~/build$

Cf. a6b01d01f77f84517d267bdfe31de91b9050a70c

Change-Id: Ic596eaf886d9aebb8a5b8636b5b90d5935aeadaf

diff --git a/include/rsc/rsc-vcl-shared-types.hxx 
b/include/rsc/rsc-vcl-shared-types.hxx
index b93864f..ca3f513 100644
--- a/include/rsc/rsc-vcl-shared-types.hxx
+++ b/include/rsc/rsc-vcl-shared-types.hxx
@@ -116,7 +116,7 @@ enum class SymbolType : sal_uInt16
 
 
 // Border-Styles fuer SetBorder()
-enum class WindowBorderStyle : sal_uInt16
+enum class WindowBorderStyle : sal_Int16
 {
 NONE  = 0x,
 NORMAL= 0x0001,
diff --git a/rsc/inc/rscdb.hxx b/rsc/inc/rscdb.hxx
index 1212fad..137c958 100644
--- a/rsc/inc/rscdb.hxx
+++ b/rsc/inc/rscdb.hxx
@@ -38,7 +38,7 @@ class RscCont;
 class RscCmdLine;
 enum class SymbolType : sal_uInt16;
 enum class ToolBoxItemBits;
-enum class WindowBorderStyle : sal_uInt16;
+enum class WindowBorderStyle : sal_Int16;
 enum class TimeFieldFormat : sal_Int32;
 enum class KeyFuncType : sal_Int32;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: icon-themes/tango

2014-10-28 Thread Yousuf Philips
 icon-themes/tango/cmd/lc_drawchart-lc_insertobjectchart.svg |  617 
 icon-themes/tango/cmd/lc_drawchart.png  |binary
 icon-themes/tango/cmd/lc_drawchart.xcf.bz2  |binary
 icon-themes/tango/cmd/lc_insertobjectchart.png  |binary
 icon-themes/tango/cmd/sc_drawchart.png  |binary
 icon-themes/tango/cmd/sc_insertobjectchart.png  |binary
 6 files changed, 617 insertions(+)

New commits:
commit 9997e60ba50483b791c5da3586f3372a3960f5ce
Author: Yousuf Philips philip...@hotmail.com
Date:   Mon Oct 27 19:14:18 2014 +0400

fdo#82272 - New 'Chart' toolbar icon

Change-Id: If1c5ec13bc145f2cd71c0d87bf81fb2f170a8294
Reviewed-on: https://gerrit.libreoffice.org/12112
Reviewed-by: Matthew Francis mjay.fran...@gmail.com
Tested-by: Matthew Francis mjay.fran...@gmail.com

diff --git a/icon-themes/tango/cmd/lc_drawchart-lc_insertobjectchart.svg 
b/icon-themes/tango/cmd/lc_drawchart-lc_insertobjectchart.svg
new file mode 100644
index 000..312f2c0
--- /dev/null
+++ b/icon-themes/tango/cmd/lc_drawchart-lc_insertobjectchart.svg
@@ -0,0 +1,617 @@
+?xml version=1.0 encoding=UTF-8 standalone=no?
+!-- Created with Inkscape (http://www.inkscape.org/) --
+
+svg
+   xmlns:dc=http://purl.org/dc/elements/1.1/;
+   xmlns:cc=http://creativecommons.org/ns#;
+   xmlns:rdf=http://www.w3.org/1999/02/22-rdf-syntax-ns#;
+   xmlns:svg=http://www.w3.org/2000/svg;
+   xmlns=http://www.w3.org/2000/svg;
+   xmlns:xlink=http://www.w3.org/1999/xlink;
+   xmlns:sodipodi=http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
+   xmlns:inkscape=http://www.inkscape.org/namespaces/inkscape;
+   width=24
+   height=24
+   id=svg2
+   version=1.1
+   inkscape:version=0.48.3.1 r9886
+   sodipodi:docname=lc_drawchart-lc_insertobjectchart.svg
+   
inkscape:export-filename=/home/alexander/libo/icon-themes/tango_testing/cmd/lc_drawchart.png
+   inkscape:export-xdpi=90
+   inkscape:export-ydpi=90
+  defs
+ id=defs4
+linearGradient
+   id=linearGradient3941
+  stop
+ style=stop-color:#ff;stop-opacity:1;
+ offset=0
+ id=stop3943 /
+  stop
+ style=stop-color:#ff;stop-opacity:0;
+ offset=1
+ id=stop3945 /
+/linearGradient
+linearGradient
+   id=linearGradient6427-7-3
+   inkscape:collect=always
+  stop
+ id=stop6429-5-1
+ offset=0
+ style=stop-color:#d3d7cf;stop-opacity:1 /
+  stop
+ id=stop6431-3-2
+ offset=1
+ style=stop-color:#555753;stop-opacity:1 /
+/linearGradient
+radialGradient
+   r=11
+   fy=205.21869
+   fx=13.03634
+   cy=205.21869
+   cx=13.03634
+   
gradientTransform=matrix(-4.8529075e-7,3.69624,-2.002,-2.625862e-7,483.43742,188.84234)
+   gradientUnits=userSpaceOnUse
+   id=radialGradient11681
+   xlink:href=#linearGradient6427-7-3
+   inkscape:collect=always /
+radialGradient
+   r=11
+   fy=205.21869
+   fx=13.03634
+   cy=205.21869
+   cx=13.03634
+   
gradientTransform=matrix(-4.8529075e-7,3.69624,-2.002,-2.625862e-7,483.43742,188.84234)
+   gradientUnits=userSpaceOnUse
+   id=radialGradient11683
+   xlink:href=#linearGradient6427-7-3
+   inkscape:collect=always /
+linearGradient
+   id=linearGradient4258
+  stop
+ id=stop4260
+ offset=0
+ style=stop-color:#ef2929;stop-opacity:1; /
+  stop
+ id=stop4262
+ offset=1
+ style=stop-color:#cc;stop-opacity:1; /
+/linearGradient
+linearGradient
+   id=linearGradient4266
+  stop
+ id=stop4268
+ offset=0
+ style=stop-color:#729fcf;stop-opacity:1; /
+  stop
+ id=stop4270
+ offset=1
+ style=stop-color:#3465a4;stop-opacity:1; /
+/linearGradient
+radialGradient
+   inkscape:collect=always
+   xlink:href=#linearGradient6427-7-3
+   id=radialGradient3500
+   gradientUnits=userSpaceOnUse
+   
gradientTransform=matrix(-4.8529075e-7,3.69624,-2.002,-2.625862e-7,483.43742,188.84234)
+   cx=13.03634
+   cy=205.21869
+   fx=13.03634
+   fy=205.21869
+   r=11 /
+radialGradient
+   inkscape:collect=always
+   xlink:href=#linearGradient6427-7-3
+   id=radialGradient3502
+   gradientUnits=userSpaceOnUse
+   
gradientTransform=matrix(-4.8529075e-7,3.69624,-2.002,-2.625862e-7,483.43742,188.84234)
+   cx=13.03634
+   cy=205.21869
+   fx=13.03634
+   fy=205.21869
+   r=11 /
+radialGradient
+   inkscape:collect=always
+   xlink:href=#linearGradient6427-7-3
+   id=radialGradient3504
+   gradientUnits=userSpaceOnUse
+   
gradientTransform=matrix(-4.8529075e-7,3.69624,-2.002,-2.625862e-7,483.43742,188.84234)
+   cx=13.03634
+   cy=205.21869
+   fx=13.03634
+   fy=205.21869
+   r=11 /
+

Re: enhancing perfcheck - Proof of concept proposals

2014-10-28 Thread Laurent Godard

Hi Matus,

Thanks a lot for your detailled response

I'm actually in holidays with family and will be back next week; I hope 
then to be able to continue this work (but feel free to start it !)



I've added it to loperf; it's now in
http://dev-builds.libreoffice.org/callgrind_report/

So, there is no need for the load test now, I think.



Great, thanks a lot.


but I think it's a bit different with callgrind - you see everything there.
And with 100 items, you should be already able to spot quadratic complexity.



Ok then to reduce the 'big file' size and not instrument its loading
I'll do it when back. I'll rebuild a new one


Regarding output results, the approach i took was to first gather all 
the results in the csv file
Then post-processing it in a spreadsheet (say, randomly, calc) and use 
standard filters to isolate the tests



Instead something like
commit date test_name-1-dump_comment-1 ... test_name-n-dump_comment-m

commit date number_1 ... numbers for different tests
commit+1 date number_2 ...



will be restricted to 1024 columns (500 tests) but may be enough


would be better I think - you can just compare
number_1 and number_2 on the next row in the same column.
Hopefully this makes sense.



Sure it makes sense :)


The script would need to be clever enough to add new columns when needed 
somehow.
Or, another possibility is to have another script which would generate
file with the second format mentioned here from the existing csv file.



Yes, i'll have a look a this. Then we could have both formats (in case 
in needed) and this second script could also dump alerts



- set IS_PERFCHECK


this would be set all the time (not needed)
make perfcheck would just run tests under callgrind, where it makes sense



ok but i still do not catch how the beast would know if callgrind is 
running or not. how would startImplemntation and endImplementation 
behave if callgrind is not running (case of normal tests)



I am happy to hack this in, or help you with implementation - as you choose.



as said before, i won't be able to work on this until middle of next 
week, sorry


So feel free to enhance this and when joining back, i'll start on the 
evolutions you may have implemented


thanks a lot Matus

Laurent
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: sw/source

2014-10-28 Thread Miklos Vajna
 sw/source/filter/ww8/docxattributeoutput.cxx |   42 ++-
 sw/source/filter/ww8/docxattributeoutput.hxx |   12 +++
 2 files changed, 29 insertions(+), 25 deletions(-)

New commits:
commit c1f4dc6b10ac512c8bda88c7a91403ea0e5108a4
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Tue Oct 28 08:50:19 2014 +0100

DocxTableExportContext: allow usage outside DocxAttributeOutput

In particular, if push/pop is done in DocxAttributeOutput, then this can
be used in DocxExport as well in the future.

Change-Id: If1302c7ccc3842ffd0b48149a3173ee864176bb5

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index be93040..85b38bb 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -497,9 +497,10 @@ void DocxAttributeOutput::EndParagraph( 
ww8::WW8TableNodeInfoInner::Pointer_t pT
otherwise the StartParagraph function will use the 
previous existing
table reference attributes since the variable is being 
shared.
 */
-DocxTableExportContext 
aDMLTableExportContext(m_rExport.mpTableInfo, 
m_tableReference-m_bTableCellOpen, m_tableReference-m_nTableDepth);
+DocxTableExportContext aDMLTableExportContext;
+pushToTableExportContext(aDMLTableExportContext);
 m_rExport.SdrExporter().writeDMLTextFrame(aFrame, 
m_anchorId++);
-aDMLTableExportContext.restore(m_rExport.mpTableInfo, 
m_tableReference-m_bTableCellOpen, m_tableReference-m_nTableDepth);
+popFromTableExportContext(aDMLTableExportContext);
 m_pSerializer-endElementNS(XML_mc, XML_Choice);
 SetAlternateContentChoiceOpen( false );
 
@@ -510,9 +511,10 @@ void DocxAttributeOutput::EndParagraph( 
ww8::WW8TableNodeInfoInner::Pointer_t pT
 //reset the tableReference.
 
 m_pSerializer-startElementNS(XML_mc, XML_Fallback, FSEND);
-DocxTableExportContext 
aVMLTableExportContext(m_rExport.mpTableInfo, 
m_tableReference-m_bTableCellOpen, m_tableReference-m_nTableDepth);
+DocxTableExportContext aVMLTableExportContext;
+pushToTableExportContext(aVMLTableExportContext);
 m_rExport.SdrExporter().writeVMLTextFrame(aFrame);
-aVMLTableExportContext.restore(m_rExport.mpTableInfo, 
m_tableReference-m_bTableCellOpen, m_tableReference-m_nTableDepth);
+popFromTableExportContext(aVMLTableExportContext);
 m_rExport.mpTableInfo = pOldTableInfo;
 
 m_pSerializer-endElementNS(XML_mc, XML_Fallback);
@@ -5093,47 +5095,49 @@ void DocxAttributeOutput::WriteOutliner(const 
OutlinerParaObject rParaObj)
 m_pSerializer-endElementNS( XML_w, XML_txbxContent );
 }
 
-DocxTableExportContext::DocxTableExportContext(ww8::WW8TableInfo::Pointer_t 
pTableInfo, bool bTableCellOpen, sal_uInt32 nTableDepth)
+void DocxAttributeOutput::pushToTableExportContext(DocxTableExportContext 
rContext)
 {
-m_pTableInfo = pTableInfo;
-pTableInfo = ww8::WW8TableInfo::Pointer_t(new ww8::WW8TableInfo());
+rContext.m_pTableInfo = m_rExport.mpTableInfo;
+m_rExport.mpTableInfo = ww8::WW8TableInfo::Pointer_t(new 
ww8::WW8TableInfo());
 
-m_bTableCellOpen = bTableCellOpen;
-bTableCellOpen = false;
+rContext.m_bTableCellOpen = m_tableReference-m_bTableCellOpen;
+m_tableReference-m_bTableCellOpen = false;
 
-m_nTableDepth = nTableDepth;
-nTableDepth = 0;
+rContext.m_nTableDepth = m_tableReference-m_nTableDepth;
+m_tableReference-m_nTableDepth = 0;
 }
 
-void DocxTableExportContext::restore(ww8::WW8TableInfo::Pointer_t pTableInfo, 
bool bTableCellOpen, sal_uInt32 nTableDepth)
+void DocxAttributeOutput::popFromTableExportContext(DocxTableExportContext 
rContext)
 {
-pTableInfo = m_pTableInfo;
-bTableCellOpen = m_bTableCellOpen;
-nTableDepth = m_nTableDepth;
+m_rExport.mpTableInfo = rContext.m_pTableInfo;
+m_tableReference-m_bTableCellOpen = rContext.m_bTableCellOpen;
+m_tableReference-m_nTableDepth = rContext.m_nTableDepth;
 }
 
 void DocxAttributeOutput::WriteTextBox(uno::Referencedrawing::XShape xShape)
 {
-DocxTableExportContext aTableExportContext(m_rExport.mpTableInfo, 
m_tableReference-m_bTableCellOpen, m_tableReference-m_nTableDepth);
+DocxTableExportContext aTableExportContext;
+pushToTableExportContext(aTableExportContext);
 
 SwFrmFmt* pTextBox = SwTextBoxHelper::findTextBox(xShape);
 const SwPosition* pAnchor = pTextBox-GetAnchor().GetCntntAnchor();
 sw::Frame aFrame(*pTextBox, *pAnchor);
 m_rExport.SdrExporter().writeDMLTextFrame(aFrame, m_anchorId++, 
/*bTextBoxOnly=*/true);
 
-aTableExportContext.restore(m_rExport.mpTableInfo, 
m_tableReference-m_bTableCellOpen, m_tableReference-m_nTableDepth);
+

[Libreoffice-commits] core.git: solenv/gbuild

2014-10-28 Thread Stephan Bergmann
 solenv/gbuild/Jar.mk |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 93208dfe39490b630a07856e21e959f7788fd9a1
Author: Stephan Bergmann sberg...@redhat.com
Date:   Tue Oct 28 09:06:56 2014 +0100

Remove unused gb_Jar_JAVACOMMAND

Change-Id: Iccaf452a16e1971afbca9c7af330d8ab3aa7318d

diff --git a/solenv/gbuild/Jar.mk b/solenv/gbuild/Jar.mk
index 6f82ebe..3d4401b 100644
--- a/solenv/gbuild/Jar.mk
+++ b/solenv/gbuild/Jar.mk
@@ -19,7 +19,6 @@
 
 # Jar class
 
-gb_Jar_JAVACOMMAND := $(JAVAINTERPRETER)
 gb_Jar_JARCOMMAND := jar
 
 gb_Jar_LAYER_DIRS := \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: officecfg/registry sc/uiconfig svx/uiconfig sw/uiconfig

2014-10-28 Thread Yousuf Philips
 officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu|4 
++--
 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |2 +-
 officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu  |   10 
+-
 sc/uiconfig/scalc/menubar/menubar.xml|3 +--
 svx/uiconfig/ui/acceptrejectchangesdialog.ui |2 +-
 sw/uiconfig/sglobal/menubar/menubar.xml  |3 +--
 sw/uiconfig/swform/menubar/menubar.xml   |3 +--
 sw/uiconfig/swreport/menubar/menubar.xml |3 +--
 sw/uiconfig/swriter/menubar/menubar.xml  |3 +--
 sw/uiconfig/swxform/menubar/menubar.xml  |3 +--
 10 files changed, 15 insertions(+), 21 deletions(-)

New commits:
commit d61c55b4d11f4a4ffdf4fb75ba2e950de8ae2beb
Author: Yousuf Philips philip...@hotmail.com
Date:   Sun Oct 26 00:49:50 2014 +0400

fdo#85046 - MENU: Edit  Changes should be renamed for better clarity

Change-Id: I8bb6582cc0e5bac390c18308fea8e647d5a0526d
Reviewed-on: https://gerrit.libreoffice.org/12098
Reviewed-by: Adolfo Jayme Barrientos fit...@ubuntu.com
Reviewed-by: Matthew Francis mjay.fran...@gmail.com
Tested-by: Matthew Francis mjay.fran...@gmail.com

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
index 38e9dc2..5919776 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
@@ -911,7 +911,7 @@
   /node
   node oor:name=.uno:AcceptChanges oor:op=replace
 prop oor:name=Label oor:type=xs:string
-  value xml:lang=en-US~Accept or Reject Changes.../value
+  value xml:lang=en-US~List of Changes.../value
 /prop
 prop oor:name=ContextLabel oor:type=xs:string
   value xml:lang=en-US~Accept or Reject.../value
@@ -927,7 +927,7 @@
   /node
   node oor:name=.uno:CommentChange oor:op=replace
 prop oor:name=Label oor:type=xs:string
-  value xml:lang=en-US~Comments.../value
+  value xml:lang=en-US~Comment on Change.../value
 /prop
   /node
   node oor:name=.uno:UnderlineDotted oor:op=replace
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index 3417c20..a5b5140 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -5436,7 +5436,7 @@
   /node
   node oor:name=.uno:ChangesMenu oor:op=replace
 prop oor:name=Label oor:type=xs:string
-  value xml:lang=en-USChan~ges/value
+  value xml:lang=en-USTrack Chan~ges/value
 /prop
   /node
   node oor:name=.uno:ToolsMenu oor:op=replace
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
index 2c9f5f6..839f5cd 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
@@ -158,7 +158,7 @@
   /node
   node oor:name=.uno:ProtectTraceChangeMode oor:op=replace
 prop oor:name=Label oor:type=xs:string
-  value xml:lang=en-US~Protect Records.../value
+  value xml:lang=en-US~Protect Changes.../value
 /prop
 prop oor:name=Properties oor:type=xs:int
   value1/value
@@ -203,7 +203,7 @@
   /node
   node oor:name=.uno:TrackChanges oor:op=replace
 prop oor:name=Label oor:type=xs:string
-  value xml:lang=en-US~Record/value
+  value xml:lang=en-US~Record Changes/value
 /prop
 prop oor:name=Properties oor:type=xs:int
   value1/value
@@ -211,7 +211,7 @@
   /node
   node oor:name=.uno:ShowTrackedChanges oor:op=replace
 prop oor:name=Label oor:type=xs:string
-  value xml:lang=en-US~Show/value
+  value xml:lang=en-US~Show Changes/value
 /prop
 prop oor:name=Properties oor:type=xs:int
   value1/value
@@ -224,7 +224,7 @@
   /node
   node oor:name=.uno:CommentChangeTracking oor:op=replace
 prop oor:name=Label oor:type=xs:string
-  value xml:lang=en-US~Comment.../value
+  value xml:lang=en-US~Comment on Change.../value
 /prop
 prop oor:name=Properties oor:type=xs:int
   value1/value
@@ -242,7 +242,7 @@
   /node
   node oor:name=.uno:AcceptTrackedChanges oor:op=replace
 prop oor:name=Label oor:type=xs:string
-  value xml:lang=en-US~Accept or Reject.../value
+  value xml:lang=en-US~List of Changes.../value
 

[Libreoffice-commits] core.git: Branch 'feature/opengl-canvas-rework' - 3 commits - canvas/source

2014-10-28 Thread Michael Jaumann
 canvas/source/opengl/ogl_canvascustomsprite.cxx |6 -
 canvas/source/opengl/ogl_canvashelper.cxx   |  101 +---
 canvas/source/opengl/ogl_canvashelper.hxx   |3 
 canvas/source/opengl/ogl_canvastools.cxx|   28 +-
 canvas/source/opengl/ogl_canvastools.hxx|   17 ++--
 canvas/source/opengl/ogl_renderHelper.cxx   |   14 +--
 canvas/source/opengl/ogl_renderHelper.hxx   |   14 ++-
 7 files changed, 97 insertions(+), 86 deletions(-)

New commits:
commit f8b451457fbbf80e42e3fdd41a2d3776920579f9
Author: Michael Jaumann meta_...@yahoo.com
Date:   Tue Oct 28 08:38:54 2014 +

renderHelper instead fixedPipeline part 1

Change-Id: Ic866a76be6a06ee259e25e2b1901693cd35562aa

diff --git a/canvas/source/opengl/ogl_canvashelper.cxx 
b/canvas/source/opengl/ogl_canvashelper.cxx
index 8c4969b..58e234f 100644
--- a/canvas/source/opengl/ogl_canvashelper.cxx
+++ b/canvas/source/opengl/ogl_canvashelper.cxx
@@ -98,15 +98,16 @@ namespace oglcanvas
 GLenum   eSrcBlend,
 GLenum   eDstBlend,
 const rendering::ARGBColor  rColor,
-const geometry::RealPoint2D rPoint )
+const geometry::RealPoint2D rPoint,
+RenderHelper mRenderHelper)
 {
-TransformationPreserver aPreserver;
-setupState(rTransform, eSrcBlend, eDstBlend, rColor);
-
-glBegin(GL_POINTS);
-glVertex2d(rPoint.X, rPoint.Y);
-glEnd();
-
+mRenderHelper.SetModelAndMVP(setupState(rTransform, eSrcBlend, 
eDstBlend));
+glm::vec4 color  = glm::vec4( (float) rColor.Red,
+(float) rColor.Green,
+(float) rColor.Blue,
+(float) rColor.Alpha);
+GLfloat vertices[] = {(float) rPoint.X, (float) rPoint.Y};
+mRenderHelper.renderVertexConstColor(vertices, color, GL_POINTS);
 return true;
 }
 
@@ -116,16 +117,17 @@ namespace oglcanvas
GLenum   eDstBlend,
const rendering::ARGBColor  rColor,
const geometry::RealPoint2D rStartPoint,
-   const geometry::RealPoint2D rEndPoint )
+   const geometry::RealPoint2D rEndPoint,
+   RenderHelper mRenderHelper)
 {
-TransformationPreserver aPreserver;
-setupState(rTransform, eSrcBlend, eDstBlend, rColor);
-
-glBegin(GL_LINES);
-glVertex2d(rStartPoint.X, rStartPoint.Y);
-glVertex2d(rEndPoint.X, rEndPoint.Y);
-glEnd();
-
+mRenderHelper.SetModelAndMVP(setupState(rTransform, eSrcBlend, 
eDstBlend));
+glm::vec4 color  = glm::vec4( (float) rColor.Red,
+(float) rColor.Green,
+(float) rColor.Blue,
+(float) rColor.Alpha);
+GLfloat vertices[] = {(float) rStartPoint.X, (float) rStartPoint.Y,
+  (float) rEndPoint.X, (float) rEndPoint.Y };
+mRenderHelper.renderVertexConstColor(vertices, color, GL_LINES);
 return true;
 }
 
@@ -136,9 +138,12 @@ namespace oglcanvas
   const rendering::ARGBColor
rColor,
   const ::basegfx::B2DPolyPolygonVector 
rPolyPolygons )
 {
-TransformationPreserver aPreserver;
-setupState(rTransform, eSrcBlend, eDstBlend, rColor);
-
+//move renderPolyPolygon here?
+ //   mRenderHelper.SetModelAndMVP(setupState(rTransform, eSrcBlend, 
eDstBlend));
+glm::vec4 color  = glm::vec4( (float) rColor.Red,
+(float) rColor.Green,
+(float) rColor.Blue,
+(float) rColor.Alpha);
 ::basegfx::B2DPolyPolygonVector::const_iterator 
aCurr=rPolyPolygons.begin();
 const ::basegfx::B2DPolyPolygonVector::const_iterator 
aEnd=rPolyPolygons.end();
 while( aCurr != aEnd )
@@ -154,8 +159,9 @@ namespace oglcanvas
   const rendering::ARGBColor
rColor,
   const ::basegfx::B2DPolyPolygonVector 
rPolyPolygons )
 {
+//no texture bind ?
 TransformationPreserver aPreserver;
-setupState(rTransform, eSrcBlend, eDstBlend, rColor);
+setupState(rTransform, eSrcBlend, eDstBlend);
 
 ::basegfx::B2DPolyPolygonVector::const_iterator 
aCurr=rPolyPolygons.begin();
 const 

[Libreoffice-commits] core.git: 4 commits - bean/com cui/source sc/inc

2014-10-28 Thread Noel Grandin
 bean/com/sun/star/comp/beans/JavaWindowPeerFake.java|4 +-
 bean/com/sun/star/comp/beans/LocalOfficeConnection.java |8 ++---
 bean/com/sun/star/comp/beans/LocalOfficeWindow.java |2 -
 bean/com/sun/star/comp/beans/OOoBean.java   |8 ++---
 cui/source/customize/cfg.cxx|   21 +++---
 cui/source/inc/cfg.hxx  |   24 
 sc/inc/fillinfo.hxx |   11 ++-
 7 files changed, 37 insertions(+), 41 deletions(-)

New commits:
commit 9813516d5e704c5949bd0010874ad115d57218dc
Author: Noel Grandin n...@peralex.com
Date:   Tue Oct 28 10:49:33 2014 +0200

Revert some changes that affected the bean/com/sun/star/comp API

from commits
  8583da1e934a49791ef8d86668f3d5c3c5dae1d7
java: remove unused fields
  68cd011c907d00493bf2bfde531c1e244819596b
java: reduce scope, make some methods private
  da677dfd59c2b551f3335ee0a5d5dfb33f9869c5
java: reduce scope, make fields private
  e701b3f732fa7f70cb273183e9ae8dbfd840f5e4
java: reduce scope, make constants private

Change-Id: I7fe0381c0e17b41bad2e4256c5511fe1f7863498

diff --git a/bean/com/sun/star/comp/beans/JavaWindowPeerFake.java 
b/bean/com/sun/star/comp/beans/JavaWindowPeerFake.java
index 2467993..1c39e06 100644
--- a/bean/com/sun/star/comp/beans/JavaWindowPeerFake.java
+++ b/bean/com/sun/star/comp/beans/JavaWindowPeerFake.java
@@ -28,8 +28,8 @@ import com.sun.star.awt.*;
 class JavaWindowPeerFake
 implements XSystemDependentWindowPeer, XWindowPeer
 {
- private int localSystemType;
-private Any wrappedHandle;
+protected int localSystemType;
+protected Any wrappedHandle;
 
 /** Create the faked window peer.
  * @param _hWindow the system handle to the window.
diff --git a/bean/com/sun/star/comp/beans/LocalOfficeConnection.java 
b/bean/com/sun/star/comp/beans/LocalOfficeConnection.java
index 7174dca..c81796d 100644
--- a/bean/com/sun/star/comp/beans/LocalOfficeConnection.java
+++ b/bean/com/sun/star/comp/beans/LocalOfficeConnection.java
@@ -47,9 +47,9 @@ import com.sun.star.lib.util.NativeLibraryLoader;
 public class LocalOfficeConnection
 implements OfficeConnection
 {
-private static final String  OFFICE_APP_NAME = soffice;
-
-private static final String  OFFICE_ID_SUFFIX= _Office;
+public static final String  OFFICE_APP_NAME = soffice;
+public static final String   OFFICE_LIB_NAME = officebean;
+public static final String  OFFICE_ID_SUFFIX= _Office;
 
 private Process mProcess;
 private XComponentContext   mContext;
@@ -745,7 +745,7 @@ public class LocalOfficeConnection
 private java.io.InputStream m_in;
 private java.io.PrintStream m_print;
 
-private StreamProcessor(final java.io.InputStream in, final 
java.io.PrintStream out)
+public StreamProcessor(final java.io.InputStream in, final 
java.io.PrintStream out)
 {
 super(StreamProcessor);
 
diff --git a/bean/com/sun/star/comp/beans/LocalOfficeWindow.java 
b/bean/com/sun/star/comp/beans/LocalOfficeWindow.java
index d481fbf..b8b493e 100644
--- a/bean/com/sun/star/comp/beans/LocalOfficeWindow.java
+++ b/bean/com/sun/star/comp/beans/LocalOfficeWindow.java
@@ -253,7 +253,7 @@ public class LocalOfficeWindow
  * The second NamedValue  has the name XEMBED and the value is true, 
when the XEmbed
  * protocol shall be used fore embedding the native Window.
 */
-private Any getWrappedWindowHandle()
+protected Any getWrappedWindowHandle()
 {
 
 NamedValue window = new NamedValue(
diff --git a/bean/com/sun/star/comp/beans/OOoBean.java 
b/bean/com/sun/star/comp/beans/OOoBean.java
index 384ad60..04abd76 100644
--- a/bean/com/sun/star/comp/beans/OOoBean.java
+++ b/bean/com/sun/star/comp/beans/OOoBean.java
@@ -803,7 +803,7 @@ public class OOoBean
 @throws NoDocumentException
 if no document is loaded
  */
-private void storeToURL(
+public void storeToURL(
 final String aURL,
 final com.sun.star.beans.PropertyValue aArguments[] )
 throws
@@ -1041,7 +1041,7 @@ 
xLayoutManager.showElement(private:resource/menubar/menubar);
 which can be obtained from a frame, to control toolbars. See also
 {@link #setAllBarsVisible setAllBarsVisible}.
  */
-private void applyToolVisibilities()
+protected void applyToolVisibilities()
 {
 bIgnoreVisibility = true;
 setMenuBarVisible( bMenuBarVisible );
@@ -1061,7 +1061,7 @@ 
xLayoutManager.showElement(private:resource/menubar/menubar);
 which can be obtained from a frame, to control toolbars. See also
 {@link #setAllBarsVisible}.
  */
-private boolean setToolVisible( String aProperty, String aResourceURL,
+protected boolean setToolVisible( String aProperty, 

[Libreoffice-commits] core.git: sc/source

2014-10-28 Thread Stephan Bergmann
 sc/source/filter/oox/formulaparser.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 43589626af4bc04dc8282b4321a1462eba2d653a
Author: Stephan Bergmann sberg...@redhat.com
Date:   Tue Oct 28 07:48:09 2014 +0100

loplugin:unreffun

Change-Id: I080474c3930d634ff1cf1c8bfd0f51a3ca537992

diff --git a/sc/source/filter/oox/formulaparser.cxx 
b/sc/source/filter/oox/formulaparser.cxx
index 77ecaee..9909818 100644
--- a/sc/source/filter/oox/formulaparser.cxx
+++ b/sc/source/filter/oox/formulaparser.cxx
@@ -747,7 +747,8 @@ size_t FormulaParserImpl::popOperandSize()
 
 ApiToken FormulaParserImpl::getOperandToken( size_t nOpCountFromEnd, size_t 
nOpIndex, size_t nTokenIndex )
 {
-OSL_ENSURE( getOperandSize( nOpCountFromEnd, nOpIndex )  nTokenIndex,
+SAL_WARN_IF(
+getOperandSize( nOpCountFromEnd, nOpIndex ) = nTokenIndex, 
sc.filter,
 FormulaParserImpl::getOperandToken - invalid parameters );
 SizeTypeVector::const_iterator aIndexIt = maTokenIndexes.end();
 for( SizeTypeVector::const_iterator aEnd = maOperandSizeStack.end(), aIt = 
aEnd - nOpCountFromEnd + nOpIndex; aIt != aEnd; ++aIt )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: icon-themes/human icon-themes/tango

2014-10-28 Thread Yousuf Philips
 icon-themes/human/cmd/lc_drawchart.png|binary
 icon-themes/human/cmd/lc_insertannotation.png |binary
 icon-themes/human/cmd/lc_insertobjectchart.png|binary
 icon-themes/human/cmd/sc_drawchart.png|binary
 icon-themes/human/cmd/sc_insertannotation.png |binary
 icon-themes/human/cmd/sc_insertmath.png   |binary
 icon-themes/tango/cmd/lc_insertmath.png   |binary
 icon-themes/tango/cmd/lc_insertobjectstarmath.png |binary
 icon-themes/tango/cmd/lc_insertsection.png|binary
 icon-themes/tango/cmd/lc_zoommode.png |binary
 icon-themes/tango/cmd/lc_zoommode.xcf.bz2 |binary
 icon-themes/tango/cmd/sc_insertmath.png   |binary
 12 files changed

New commits:
commit 10727e53f718086e8b26ded1b904cb4f11501e34
Author: Yousuf Philips philip...@hotmail.com
Date:   Tue Oct 28 14:07:33 2014 +0400

ICONS: Exchanged icons between tango and human and small change to zoom mode

Change-Id: Iab3f148258204fefc667e94307adfa0537364ac9
Reviewed-on: https://gerrit.libreoffice.org/12125
Reviewed-by: Matthew Francis mjay.fran...@gmail.com
Tested-by: Matthew Francis mjay.fran...@gmail.com

diff --git a/icon-themes/human/cmd/lc_drawchart.png 
b/icon-themes/human/cmd/lc_drawchart.png
index 79a759b..c18de25 100644
Binary files a/icon-themes/human/cmd/lc_drawchart.png and 
b/icon-themes/human/cmd/lc_drawchart.png differ
diff --git a/icon-themes/human/cmd/lc_insertannotation.png 
b/icon-themes/human/cmd/lc_insertannotation.png
index a1023e8..02bc8ce 100644
Binary files a/icon-themes/human/cmd/lc_insertannotation.png and 
b/icon-themes/human/cmd/lc_insertannotation.png differ
diff --git a/icon-themes/human/cmd/lc_insertobjectchart.png 
b/icon-themes/human/cmd/lc_insertobjectchart.png
index 79a759b..c18de25 100644
Binary files a/icon-themes/human/cmd/lc_insertobjectchart.png and 
b/icon-themes/human/cmd/lc_insertobjectchart.png differ
diff --git a/icon-themes/human/cmd/sc_drawchart.png 
b/icon-themes/human/cmd/sc_drawchart.png
index 420fa8b..f02b31d 100644
Binary files a/icon-themes/human/cmd/sc_drawchart.png and 
b/icon-themes/human/cmd/sc_drawchart.png differ
diff --git a/icon-themes/human/cmd/sc_insertannotation.png 
b/icon-themes/human/cmd/sc_insertannotation.png
index 2dbb154..5864cb4 100644
Binary files a/icon-themes/human/cmd/sc_insertannotation.png and 
b/icon-themes/human/cmd/sc_insertannotation.png differ
diff --git a/icon-themes/human/cmd/sc_insertmath.png 
b/icon-themes/human/cmd/sc_insertmath.png
index a175e58..113af72 100644
Binary files a/icon-themes/human/cmd/sc_insertmath.png and 
b/icon-themes/human/cmd/sc_insertmath.png differ
diff --git a/icon-themes/tango/cmd/lc_insertmath.png 
b/icon-themes/tango/cmd/lc_insertmath.png
new file mode 100644
index 000..b25be4e
Binary files /dev/null and b/icon-themes/tango/cmd/lc_insertmath.png differ
diff --git a/icon-themes/tango/cmd/lc_insertobjectstarmath.png 
b/icon-themes/tango/cmd/lc_insertobjectstarmath.png
new file mode 100644
index 000..b25be4e
Binary files /dev/null and b/icon-themes/tango/cmd/lc_insertobjectstarmath.png 
differ
diff --git a/icon-themes/tango/cmd/lc_insertsection.png 
b/icon-themes/tango/cmd/lc_insertsection.png
new file mode 100644
index 000..da90266
Binary files /dev/null and b/icon-themes/tango/cmd/lc_insertsection.png differ
diff --git a/icon-themes/tango/cmd/lc_zoommode.png 
b/icon-themes/tango/cmd/lc_zoommode.png
index 5b04e4d..f9b94bc 100644
Binary files a/icon-themes/tango/cmd/lc_zoommode.png and 
b/icon-themes/tango/cmd/lc_zoommode.png differ
diff --git a/icon-themes/tango/cmd/lc_zoommode.xcf.bz2 
b/icon-themes/tango/cmd/lc_zoommode.xcf.bz2
index bb18c7c8..133ac8d 100644
Binary files a/icon-themes/tango/cmd/lc_zoommode.xcf.bz2 and 
b/icon-themes/tango/cmd/lc_zoommode.xcf.bz2 differ
diff --git a/icon-themes/tango/cmd/sc_insertmath.png 
b/icon-themes/tango/cmd/sc_insertmath.png
new file mode 100644
index 000..113af72
Binary files /dev/null and b/icon-themes/tango/cmd/sc_insertmath.png differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: pyuno/CustomTarget_python_shell.mk pyuno/zipcore

2014-10-28 Thread Matthew J . Francis
 pyuno/CustomTarget_python_shell.mk |1 -
 pyuno/zipcore/mac.sh   |9 +++--
 pyuno/zipcore/nonmac.sh|4 
 pyuno/zipcore/python.sh|5 -
 4 files changed, 11 insertions(+), 8 deletions(-)

New commits:
commit 65809118914e84bf7cb355e2fd3bce75d7271778
Author: Matthew J. Francis mjay.fran...@gmail.com
Date:   Sun Oct 26 11:34:43 2014 +0800

Fix python wrapper script on OS X

Change-Id: Icfac94022ee026ad8e9d9d5298e5cc7fbd7121be
Signed-off-by: Stephan Bergmann sberg...@redhat.com

diff --git a/pyuno/CustomTarget_python_shell.mk 
b/pyuno/CustomTarget_python_shell.mk
index 4cf7f8b..bc6d355 100644
--- a/pyuno/CustomTarget_python_shell.mk
+++ b/pyuno/CustomTarget_python_shell.mk
@@ -30,7 +30,6 @@ $(call gb_CustomTarget_get_workdir,pyuno/python_shell)/os.sh 
: \
$(SRCDIR)/pyuno/zipcore/$(if $(filter 
MACOSX,$(OS)),mac,nonmac).sh
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),SED,1)
sed -e s/%%PYVERSION%%/$(pyuno_PYTHON_SHELL_VERSION)/g \
--e s,%%PYTHON_FRAMEWORK_RELATIVE_PATH%%,$(if $(filter 
MACOSX,$(OS)),../Frameworks/),g \
$  $@
 
 # vim: set noet sw=4 ts=4:
diff --git a/pyuno/zipcore/mac.sh b/pyuno/zipcore/mac.sh
index 9f04b99..830bcda 100644
--- a/pyuno/zipcore/mac.sh
+++ b/pyuno/zipcore/mac.sh
@@ -1,8 +1,13 @@
-PYTHONHOME=$sd_prog/%%PYTHON_FRAMEWORK_RELATIVE_PATH%%LibreOfficePython.framework
+# Set URE_BOOTSTRAP so that uno.getComponentContext() bootstraps a complete
+# OOo UNO environment:
+: ${URE_BOOTSTRAP=vnd.sun.star.pathname:$sd_prog/../Resources/fundamentalrc}
+export URE_BOOTSTRAP
+
+PYTHONHOME=$sd_prog/../Frameworks/LibreOfficePython.framework
 export PYTHONHOME
 
 pybasislibdir=$PYTHONHOME/Versions/%%PYVERSION%%/lib/python%%PYVERSION%%
-PYTHONPATH=$sd_prog:$pybasislibdir:$pybasislibdir/lib-dynload:$pybasislibdir/lib-tk:$pybasislibdir/site-packages${PYTHONPATH+:$PYTHONPATH}
+PYTHONPATH=$sd_prog/../Resources:$sd_prog/../Frameworks:$pybasislibdir:$pybasislibdir/lib-dynload:$pybasislibdir/lib-tk:$pybasislibdir/site-packages${PYTHONPATH+:$PYTHONPATH}
 export PYTHONPATH
 
 # execute binary
diff --git a/pyuno/zipcore/nonmac.sh b/pyuno/zipcore/nonmac.sh
index 791a340..5e7cca1 100644
--- a/pyuno/zipcore/nonmac.sh
+++ b/pyuno/zipcore/nonmac.sh
@@ -1,3 +1,7 @@
+# Set URE_BOOTSTRAP so that uno.getComponentContext() bootstraps a complete
+# OOo UNO environment:
+: ${URE_BOOTSTRAP=vnd.sun.star.pathname:$sd_prog/fundamentalrc}
+export URE_BOOTSTRAP
 
 
PYTHONPATH=$sd_prog:$sd_prog/python-core-%%PYVERSION%%/lib:$sd_prog/python-core-%%PYVERSION%%/lib/lib-dynload:$sd_prog/python-core-%%PYVERSION%%/lib/lib-tk:$sd_prog/python-core-%%PYVERSION%%/lib/site-packages${PYTHONPATH+:$PYTHONPATH}
 export PYTHONPATH
diff --git a/pyuno/zipcore/python.sh b/pyuno/zipcore/python.sh
old mode 100644
new mode 100755
index 89e73b7..bfe6785
--- a/pyuno/zipcore/python.sh
+++ b/pyuno/zipcore/python.sh
@@ -38,8 +38,3 @@ export PATH
 : ${UNO_PATH=$sd_prog}
 export UNO_PATH
 
-# Set URE_BOOTSTRAP so that uno.getComponentContext() bootstraps a complete
-# OOo UNO environment:
-: ${URE_BOOTSTRAP=vnd.sun.star.pathname:$sd_prog/fundamentalrc}
-export URE_BOOTSTRAP
-
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Java problem when running CppunitTest_dbaccess_dialog_save on OS X 10.10 with Oracle JDK 1.8

2014-10-28 Thread Stephan Bergmann

On 10/20/2014 01:48 PM, Alexander Thurgood wrote:

I encountrered this very same problem, and solved it by installing the
appropriate  JavaforOSX2014-001.dmg, which allowed my build to complete
the debug tests, but this apparently also has consequences for use of
third party jdbc drivers that rely on JDK 1.8


In how far?

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 14 commits - basegfx/source connectivity/source dbaccess/source desktop/unx idlc/source sc/source sfx2/source soltools/mkdepend sw/source vcl/unx

2014-10-28 Thread Caolán McNamara
 basegfx/source/polygon/b2dpolygontools.cxx  |9 ++-
 connectivity/source/drivers/dbase/DTable.cxx|9 ++-
 dbaccess/source/core/dataaccess/definitioncontainer.cxx |   43 
 desktop/unx/source/start.c  |2 
 idlc/source/idlcproduce.cxx |6 +-
 sc/source/ui/vba/vbaformatconditions.cxx|   25 -
 sc/source/ui/vba/vbastyles.cxx  |   25 -
 sfx2/source/doc/docfile.cxx |6 +-
 soltools/mkdepend/main.c|4 -
 sw/source/core/unocore/unostyle.cxx |1 
 sw/source/filter/ww8/ww8par.cxx |3 +
 sw/source/filter/ww8/ww8par2.cxx|9 ++-
 vcl/unx/generic/app/sm.cxx  |8 +-
 13 files changed, 124 insertions(+), 26 deletions(-)

New commits:
commit cb67f0c5f9424fc085c4169211bda7e36cfbd904
Author: Caolán McNamara caol...@redhat.com
Date:   Tue Oct 28 09:41:44 2014 +

coverity#1242656 Untrusted loop bound

Change-Id: Iaf60d887860476e17d3db306a2089bfffd0564c9

diff --git a/sw/source/filter/ww8/ww8par2.cxx b/sw/source/filter/ww8/ww8par2.cxx
index b5cc9a8..542afa9 100644
--- a/sw/source/filter/ww8/ww8par2.cxx
+++ b/sw/source/filter/ww8/ww8par2.cxx
@@ -4265,8 +4265,15 @@ void WW8RStyle::ImportOldFormatStyles()
 }
 
 std::vectorpxoffset aPAPXOffsets(stcp);
+size_t nMaxByteCount = rSt.remainingSize();
 sal_uInt16 cbPapx(0);
-rSt.ReadUInt16( cbPapx );
+rSt.ReadUInt16(cbPapx);
+if (cbPapx  nMaxByteCount)
+{
+SAL_WARN(sw.ww8, WW8RStyle::ImportOldFormatStyles: truncating out 
of range 
+ cbPapx   to   nMaxByteCount);
+cbPapx = nMaxByteCount;
+}
 nByteCount = 2;
 stcp=0;
 while (nByteCount  cbPapx)
commit 8c8c2dd14a5f8f2771b8b750937156a98f4a74b6
Author: Caolán McNamara caol...@redhat.com
Date:   Tue Oct 28 09:15:20 2014 +

assert on missing SolarMutex in SwXStyle dtor

 #18 0x2ba554c3b9d2 in ImplDbgTestSolarMutex () at 
vcl/source/app/dbggui.cxx:793
__PRETTY_FUNCTION__ = void ImplDbgTestSolarMutex()
 #19 0x2ba553a8897e in DbgFunc (nAction=3, pParam=0x0) at 
tools/source/debug/debug.cxx:299
pDebugData = 0x2ba553d51be0 aDebugData
 #20 0x2ba5525bf509 in SfxBroadcaster::RemoveListener (this=0x3512a60, 
rListener=...) at svl/source/notify/SfxBroadcaster.cxx:127
aIter =
__PRETTY_FUNCTION__ = void 
SfxBroadcaster::RemoveListener(SfxListener)
positionOfRemovedElement = 63395440
 #21 0x2ba5525cfea1 in SfxListener::EndListening (this=0x3d16de0, 
rBroadcaster=..., bAllDups=false) at svl/source/notify/lstner.cxx:91
it =
 #22 0x2ba5666f9bd1 in SwXStyle::~SwXStyle (this=0x3d16d80, 
__in_chrg=optimized out) at sw/source/core/unocore/unostyle.cxx:1306
No locals.
 #23 0x2ba5666f9cb0 in SwXStyle::~SwXStyle (this=0x3d16d80, 
__in_chrg=optimized out) at sw/source/core/unocore/unostyle.cxx:1308
No locals.
 #24 0x2ba550985142 in cppu::OWeakObject::release (this=0x3d16d80) at 
cppuhelper/source/weak.cxx:204
No locals.

Change-Id: Ieb33e5a8c739b575dd3b546deb3cc2cef53e8ec8

diff --git a/sw/source/core/unocore/unostyle.cxx 
b/sw/source/core/unocore/unostyle.cxx
index d1b7f14..1038f26 100644
--- a/sw/source/core/unocore/unostyle.cxx
+++ b/sw/source/core/unocore/unostyle.cxx
@@ -1302,6 +1302,7 @@ SwXStyle::SwXStyle(SfxStyleSheetBasePool rPool, 
SfxStyleFamily eFam,
 
 SwXStyle::~SwXStyle()
 {
+SolarMutexGuard aGuard;
 if(pBasePool)
 EndListening(*pBasePool);
 delete pPropImpl;
commit 17354cb84a2622cb4504f854af55adf6c62813fb
Author: Caolán McNamara caol...@redhat.com
Date:   Tue Oct 28 09:09:45 2014 +

improve Sttb dumping for truncated case

Change-Id: I52c7c6d75a843673d1cacbf9adc77ac574fa95f7

diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index 12ffe46..fcba4e0 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -503,7 +503,10 @@ void Sttb::Print( FILE* fp )
 for (sal_uInt16 index = 0; index  cData; ++index)
 {
 if (index = dataItems.size())
+{
 fprintf(fp,Sttb truncated at entry %d(0x%x)\n, 
static_cast int ( index ), static_cast unsigned int ( index ));
+break;
+}
 fprintf(fp,   string dataItem[ %d(0x%x) ] has name %s\n, 
static_cast int ( index ), static_cast unsigned int ( index ), 
OUStringToOString( dataItems[ index ].data, RTL_TEXTENCODING_UTF8 ).getStr() );
 }
 }
commit 316ac78e78b7ff75aa914d9b34c086cef9ef843c
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Oct 27 21:01:05 2014 +

coverity#982185 silence Unchecked return value from library

and

[Libreoffice-commits] core.git: sc/inc

2014-10-28 Thread Stephan Bergmann
 sc/inc/fillinfo.hxx |   11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)

New commits:
commit 27dcfc03c1f9f0802e54191ecd8aacd6b09f
Author: Stephan Bergmann sberg...@redhat.com
Date:   Tue Oct 28 11:28:45 2014 +0100

Revert cid#738785 Uninitialized pointer field

This reverts commit 8e156ef6d8a236a49303b12a66ac6cae1ccd567c,
those members apparently need to be initialized to null.

diff --git a/sc/inc/fillinfo.hxx b/sc/inc/fillinfo.hxx
index 2af32c1..1db76d9 100644
--- a/sc/inc/fillinfo.hxx
+++ b/sc/inc/fillinfo.hxx
@@ -115,9 +115,9 @@ struct CellInfo : boost::noncopyable
 
 ScShadowParteHShadowPart : 4;   // shadow 
effective for drawing
 ScShadowParteVShadowPart : 4;
-sal_uInt8   nClipMark;
-sal_uInt16  nWidth;
-sal_uInt8   nRotateDir;
+sal_uInt8nClipMark;
+sal_uInt16  nWidth;
+sal_uInt8nRotateDir;
 
 boolbMarked : 1;
 boolbEmptyCellText : 1;
@@ -132,6 +132,11 @@ struct CellInfo : boost::noncopyable
 boolbHideGrid : 1;  // output-internal
 boolbEditEngine : 1;// output-internal
 
+CellInfo():
+pColorScale(NULL),
+pDataBar(NULL),
+pIconSet(NULL) {}
+
 ~CellInfo()
 {
 delete pColorScale;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/inc sc/source

2014-10-28 Thread Stephan Bergmann
 sc/inc/fillinfo.hxx  |   22 +++---
 sc/source/core/data/fillinfo.cxx |6 +++---
 sc/source/ui/view/output.cxx |   20 ++--
 3 files changed, 20 insertions(+), 28 deletions(-)

New commits:
commit ba1d2677af955e95d7aa673c21d8be961b88389a
Author: Stephan Bergmann sberg...@redhat.com
Date:   Tue Oct 28 11:42:24 2014 +0100

cid#738785 Uninitialized pointer field

Change-Id: I2256682639084c8889d1137f087e34f7b0dab6e7

diff --git a/sc/inc/fillinfo.hxx b/sc/inc/fillinfo.hxx
index 1db76d9..45b4a64 100644
--- a/sc/inc/fillinfo.hxx
+++ b/sc/inc/fillinfo.hxx
@@ -20,6 +20,10 @@
 #ifndef INCLUDED_SC_INC_FILLINFO_HXX
 #define INCLUDED_SC_INC_FILLINFO_HXX
 
+#include sal/config.h
+
+#include memory
+
 #include svx/framelinkarray.hxx
 #include global.hxx
 #include colorscale.hxx
@@ -98,9 +102,9 @@ struct CellInfo : boost::noncopyable
 
 const ScPatternAttr*pPatternAttr;
 const SfxItemSet*   pConditionSet;
-const Color*pColorScale;
-const ScDataBarInfo*pDataBar;
-const ScIconSetInfo*pIconSet;
+std::unique_ptrconst Color pColorScale;
+std::unique_ptrconst ScDataBarInfo pDataBar;
+std::unique_ptrconst ScIconSetInfo pIconSet;
 
 const SvxBrushItem* pBackground;
 
@@ -131,18 +135,6 @@ struct CellInfo : boost::noncopyable
 boolbPrinted : 1;   // when required 
(pagebreak mode)
 boolbHideGrid : 1;  // output-internal
 boolbEditEngine : 1;// output-internal
-
-CellInfo():
-pColorScale(NULL),
-pDataBar(NULL),
-pIconSet(NULL) {}
-
-~CellInfo()
-{
-delete pColorScale;
-delete pDataBar;
-delete pIconSet;
-}
 };
 
 const SCCOL SC_ROTMAX_NONE = SCCOL_MAX;
diff --git a/sc/source/core/data/fillinfo.cxx b/sc/source/core/data/fillinfo.cxx
index 294020c..b7be1628 100644
--- a/sc/source/core/data/fillinfo.cxx
+++ b/sc/source/core/data/fillinfo.cxx
@@ -575,18 +575,18 @@ void ScDocument::FillInfo(
 }
 if(aData.pColorScale)
 {
-pInfo-pColorScale = 
aData.pColorScale;
+
pInfo-pColorScale.reset(aData.pColorScale);
 bFound = true;
 }
 
 if(aData.pDataBar)
 {
-pInfo-pDataBar = aData.pDataBar;
+
pInfo-pDataBar.reset(aData.pDataBar);
 bFound = true;
 }
 if(aData.pIconSet)
 {
-pInfo-pIconSet = aData.pIconSet;
+
pInfo-pIconSet.reset(aData.pIconSet);
 bFound = true;
 }
 }
diff --git a/sc/source/ui/view/output.cxx b/sc/source/ui/view/output.cxx
index 03048ad..6fc29bb 100644
--- a/sc/source/ui/view/output.cxx
+++ b/sc/source/ui/view/output.cxx
@@ -736,16 +736,16 @@ static bool lcl_EqualBack( const RowInfo rFirst, const 
RowInfo rOther,
 
 for ( nX=nX1; nX=nX2; nX++ )
 {
-const Color* pCol1 = rFirst.pCellInfo[nX+1].pColorScale;
-const Color* pCol2 = rOther.pCellInfo[nX+1].pColorScale;
+const Color* pCol1 = rFirst.pCellInfo[nX+1].pColorScale.get();
+const Color* pCol2 = rOther.pCellInfo[nX+1].pColorScale.get();
 if( (pCol1  !pCol2) || (!pCol1  pCol2) )
 return false;
 
 if (pCol1  (*pCol1 != *pCol2))
 return false;
 
-const ScDataBarInfo* pInfo1 = rFirst.pCellInfo[nX+1].pDataBar;
-const ScDataBarInfo* pInfo2 = rOther.pCellInfo[nX+1].pDataBar;
+const ScDataBarInfo* pInfo1 = rFirst.pCellInfo[nX+1].pDataBar.get();
+const ScDataBarInfo* pInfo2 = rOther.pCellInfo[nX+1].pDataBar.get();
 
 if( (pInfo1  !pInfo2) || (!pInfo1  pInfo2) )
 return false;
@@ -754,8 +754,8 @@ static bool lcl_EqualBack( const RowInfo rFirst, const 
RowInfo rOther,
 return false;
 
 // each cell with an icon set should be painted the same way
-const ScIconSetInfo* pIconSet1 = rFirst.pCellInfo[nX+1].pIconSet;
-const ScIconSetInfo* pIconSet2 = rOther.pCellInfo[nX+1].pIconSet;
+const ScIconSetInfo* pIconSet1 = rFirst.pCellInfo[nX+1].pIconSet.get();
+const ScIconSetInfo* pIconSet2 = rOther.pCellInfo[nX+1].pIconSet.get();
 
 if(pIconSet1 || pIconSet2)

[Libreoffice-commits] core.git: basegfx/source

2014-10-28 Thread Stephan Bergmann
 basegfx/source/polygon/b2dpolygontools.cxx |6 --
 1 file changed, 6 deletions(-)

New commits:
commit a00bae79f93b46c741ae9d5fbc90e27dd5442926
Author: Stephan Bergmann sberg...@redhat.com
Date:   Tue Oct 28 11:54:34 2014 +0100

Fix --disable-sal-log builds

Change-Id: Ie0250745c9bd39e6e81f5f9eb96e661de2e4e2ef

diff --git a/basegfx/source/polygon/b2dpolygontools.cxx 
b/basegfx/source/polygon/b2dpolygontools.cxx
index d5bbcf7..03c298e 100644
--- a/basegfx/source/polygon/b2dpolygontools.cxx
+++ b/basegfx/source/polygon/b2dpolygontools.cxx
@@ -3416,9 +3416,7 @@ namespace basegfx
 {
 // prepare loop
 bool bControlA(false);
-#if defined SAL_LOG_WARN
 bool bControlB(false);
-#endif
 
 // get next point and flag
 aNewCoordinatePair = B2DPoint(pPointSequence-X, 
pPointSequence-Y);
@@ -3439,9 +3437,7 @@ namespace basegfx
 if(b  nCount  com::sun::star::drawing::PolygonFlags_CONTROL 
== ePolygonFlag)
 {
 aControlB = aNewCoordinatePair;
-#if defined SAL_LOG_WARN
 bControlB = true;
-#endif
 
 // get next point and flag
 aNewCoordinatePair = B2DPoint(pPointSequence-X, 
pPointSequence-Y);
@@ -3467,9 +3463,7 @@ namespace basegfx
  aControlA.equal(aRetval.getB2DPoint(aRetval.count() - 
1)))
 {
 bControlA = false;
-#if defined SAL_LOG_WARN
 bControlB = false;
-#endif
 }
 
 if(bControlA)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/unx

2014-10-28 Thread Markus Mohrhard
 vcl/unx/generic/gdi/x11windowprovider.cxx |   16 
 1 file changed, 16 insertions(+)

New commits:
commit 4c40b2887b2af4f2a604e51c5cb47274e87af12d
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Tue Oct 28 12:33:22 2014 +0100

add missing file

Change-Id: I2dcbc2f299c8994cd11e24f0beffe491d8f4f278

diff --git a/vcl/unx/generic/gdi/x11windowprovider.cxx 
b/vcl/unx/generic/gdi/x11windowprovider.cxx
new file mode 100644
index 000..5eaa3f6
--- /dev/null
+++ b/vcl/unx/generic/gdi/x11windowprovider.cxx
@@ -0,0 +1,16 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include unx/x11windowprovider.hxx
+
+X11WindowProvider::~X11WindowProvider()
+{
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


build error

2014-10-28 Thread soyol aron
libreoffice@lists.freedesktop.org

Hi list,
Following error is occurred on my system(win7 ,64bit, cygwin32bit)
the source code is libreoffice-4.3.2.2.tar.xz,
my configure is
./autogen.sh \
--with-visual-studio=2013 \
--with-ant-home=/cygdrive/c/ant \
--without-junit \
--disable-directx \
--disable-atl \
--disable-activex \
--with-external-tar=/cygdrive/d/lo/lo-external
I installed both vs2010 and vs2013,(but this error were occurred when I
have not installed vs2010)

How do I resolve it?
Regards


[ C   ] UnpackedTarball/expat/lib/xmlparse.c
[ C   ] UnpackedTarball/expat/lib/xmlrole.c
[ C   ] UnpackedTarball/expat/lib/xmltok.c
cl : Command line warning D9025 : overriding '/W4' with '/w'
cl : Command line warning D9025 : overriding '/W4' with '/w'
cl : Command line warning D9025 : overriding '/W4' with '/w'
Microsoft (R) Build Engine version 4.0.30319.18408
[Microsoft .NET Framework, version 4.0.30319.18444]
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 2014/10/28 20:23:38.
Project
D:\lo\lo-core\workdir\UnpackedTarball\lcms2\Projects\VC2010\lcms2_DLL\lcms2_DLL.vcxproj
on node 1 (default targets).
InitializeBuildStatus:
  Touching Release\lcms2_DLL.unsuccessfulbuild.
ClCompile:
  C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\CL.exe /c
/I../../../include /Zi /nologo /W4 /WX- /MP /Ox /Ob1 /Oi /Ot /Oy /GT /GL /D
WIN32 /D NDEBUG /D _WINDOWS /D _USRDLL /D CMS_DLL_BUILD /D
_CRT_SECURE_NO_WARNINGS /D _WINDLL /D _UNICODE /D UNICODE /GF /Gm- /EHsc
/MT /GS /Gy /fp:precise /Zc:wchar_t /Zc:forScope /FoRelease\\
/FdRelease\vc100.pdb /Gd /TC /analyze- /errorReport:queue
..\..\..\src\cmsnamed.c ..\..\..\src\cmsvirt.c
  cmsnamed.c
  cmsvirt.c
ResourceCompile:
  All outputs are up-to-date.
Link:
  C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\link.exe
/ERRORREPORT:QUEUE /OUT:..\..\..\bin\lcms2.dll /INCREMENTAL:NO /NOLOGO
kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib
shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib
/DEF:..\..\..\src\lcms2.def /MANIFEST
/ManifestFile:Release\lcms2.dll.intermediate.manifest
/MANIFESTUAC:level='asInvoker' uiAccess='false' /DEBUG
/PDB:D:\lo\lo-core\workdir\UnpackedTarball\lcms2\bin\lcms2.pdb
/SUBSYSTEM:WINDOWS /OPT:REF /OPT:ICF /LTCG /TLBID:1 /DYNAMICBASE /NXCOMPAT
/IMPLIB:..\..\..\bin\lcms2.lib /MACHINE:X86 /DLL Release\lcms2.res
  Release\cmscam02.obj
  Release\cmscgats.obj
  Release\cmscnvrt.obj
  Release\cmserr.obj
  Release\cmsgamma.obj
  Release\cmsgmt.obj
  Release\cmshalf.obj
  Release\cmsintrp.obj
  Release\cmsio0.obj
  Release\cmsio1.obj
  Release\cmslut.obj
  Release\cmsmd5.obj
  Release\cmsmtrx.obj
  Release\cmsnamed.obj
  Release\cmsopt.obj
  Release\cmspack.obj
  Release\cmspcs.obj
  Release\cmsplugin.obj
  Release\cmsps2.obj
  Release\cmssamp.obj
  Release\cmssm.obj
  Release\cmstypes.obj
  Release\cmsvirt.obj
  Release\cmswtpnt.obj
  Release\cmsxform.obj
 Creating library ..\..\..\bin\lcms2.lib and object
..\..\..\bin\lcms2.exp
  Generating code
  Finished generating code
LINK : fatal error LNK1123: failure during conversion to COFF: file invalid
or corrupt
[D:\lo\lo-core\workdir\UnpackedTarball\lcms2\Projects\VC2010\lcms2_DLL\lcms2_DLL.vcxproj]
Done Building Project
D:\lo\lo-core\workdir\UnpackedTarball\lcms2\Projects\VC2010\lcms2_DLL\lcms2_DLL.vcxproj
(default targets) -- FAILED.

Build FAILED.

D:\lo\lo-core\workdir\UnpackedTarball\lcms2\Projects\VC2010\lcms2_DLL\lcms2_DLL.vcxproj
(default target) (1) -
(Link target) -
  LINK : fatal error LNK1123: failure during conversion to COFF: file
invalid or corrupt
[D:\lo\lo-core\workdir\UnpackedTarball\lcms2\Projects\VC2010\lcms2_DLL\lcms2_DLL.vcxproj]

0 Warning(s)
1 Error(s)

Time Elapsed 00:00:10.00
make[1]: *** [D:/lo/lo-core/workdir/ExternalProject/lcms2/build] Error 1
make[1]: *** Waiting for unfinished jobs
make: *** [build] Error 2

-- 
Aron
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: build error

2014-10-28 Thread Tor Lillqvist
 How do I resolve it?


By not using VS2013? It is claimed to be possible to use VS2013 to build
master, but hardly 4.3.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 10 commits - sc/source

2014-10-28 Thread Tor Lillqvist
 sc/source/core/opencl/openclwrapper.cxx |   44 
 sc/source/core/opencl/openclwrapper.hxx |   83 
 2 files changed, 2 insertions(+), 125 deletions(-)

New commits:
commit 1b1c11f51914448d1ebc0fe18abf2b325f8c4791
Author: Tor Lillqvist t...@collabora.com
Date:   Tue Oct 28 13:42:43 2014 +0200

Bin dead and commented-out code

Change-Id: I4c3d666155af4bd36e819c077f660a30dbe72cdb

diff --git a/sc/source/core/opencl/openclwrapper.cxx 
b/sc/source/core/opencl/openclwrapper.cxx
index 0e0cf1e..baf3bcc 100644
--- a/sc/source/core/opencl/openclwrapper.cxx
+++ b/sc/source/core/opencl/openclwrapper.cxx
@@ -76,45 +76,6 @@ OString getCacheFolder()
 return rtl::OUStringToOString(url, RTL_TEXTENCODING_UTF8);
 }
 
-void clearCache()
-{
-#if 0
-// We used to delete all files that did not end with the hash of
-// the static kernel source string from oclkernels.hxx. But as
-// those static kernels were not used for anything, it was
-// pointless, that hash never changed. The static kernels are now
-// removed, their hash is not part of the .bin file names any
-// more.  So there is little this function can do until we come up
-// with some other way to figure out which cached .bin files are
-// current.
-OUString aCacheDirURL(rtl::OStringToOUString(OpenCLDevice::maCacheFolder, 
RTL_TEXTENCODING_UTF8));
-osl::Directory aCacheDir(aCacheDirURL);
-osl::FileBase::RC status = aCacheDir.open();
-if(status != osl::FileBase::E_None)
-return;
-
-osl::DirectoryItem aItem;
-while(osl::FileBase::E_None == aCacheDir.getNextItem(aItem))
-{
-osl::FileStatus 
aFileStatus(osl_FileStatus_Mask_FileName|osl_FileStatus_Mask_FileURL);
-status = aItem.getFileStatus(aFileStatus);
-if(status != osl::FileBase::E_None)
-continue;
-
-OUString aFileName = aFileStatus.getFileName();
-if(aFileName.endsWith(.bin))
-{
-if ( file is in some way obsolete )
-{
-// delete the file
-OUString aFileUrl = aFileStatus.getFileURL();
-osl::File::remove(aFileUrl);
-}
-}
-}
-#endif
-}
-
 }
 
 OString OpenCLDevice::maCacheFolder = getCacheFolder();
@@ -212,7 +173,6 @@ std::vectorboost::shared_ptrosl::File  
OpenCLDevice::binaryGenerated( const
 
 bool OpenCLDevice::writeBinaryToFile( const OString rFileName, const char* 
binary, size_t numBytes )
 {
-clearCache();
 osl::File file(rtl::OStringToOUString(rFileName, RTL_TEXTENCODING_UTF8));
 osl::FileBase::RC status = file.open(
 osl_File_OpenFlag_Write | osl_File_OpenFlag_Create );
commit e901c15c63ad118f9722505776cb8d74c2004526
Author: Tor Lillqvist t...@collabora.com
Date:   Tue Oct 28 13:34:30 2014 +0200

Bin unused SingleVectorFormula and DoubleVectorFormula types

Change-Id: Ia71a4aec6097a6dd07716438d7647dff4252e190

diff --git a/sc/source/core/opencl/openclwrapper.hxx 
b/sc/source/core/opencl/openclwrapper.hxx
index 8e1974d..ef9842a 100644
--- a/sc/source/core/opencl/openclwrapper.hxx
+++ b/sc/source/core/opencl/openclwrapper.hxx
@@ -68,28 +68,6 @@ struct GPUEnv
 bool mnAmdFp64Flag;
 };
 
-struct SingleVectorFormula
-{
-const double *mdpInputLeftData;
-const double *mdpInputRightData;
-size_t mnInputLeftDataSize;
-size_t mnInputRightDataSize;
-uint mnInputLeftStartPosition;
-uint mnInputRightStartPosition;
-int mnInputLeftOffset;
-int mnInputRightOffset;
-};
-
-struct DoubleVectorFormula
-{
-const double *mdpInputData;
-size_t mnInputDataSize;
-uint mnInputStartPosition;
-uint mnInputEndPosition;
-int mnInputStartOffset;
-int mnInputEndOffset;
-};
-
 class OpenCLDevice
 {
 public:
commit 7aa411f0b4586dc27ae75adf673eef331acb7d36
Author: Tor Lillqvist t...@collabora.com
Date:   Tue Oct 28 13:32:16 2014 +0200

This is C++

Change-Id: I10e8be566fc0814e81938b878e14849cfef31986

diff --git a/sc/source/core/opencl/openclwrapper.hxx 
b/sc/source/core/opencl/openclwrapper.hxx
index c8ff48c4..8e1974d 100644
--- a/sc/source/core/opencl/openclwrapper.hxx
+++ b/sc/source/core/opencl/openclwrapper.hxx
@@ -34,12 +34,12 @@ if( status != CL_SUCCESS )\
 
 #include cstdio
 
-typedef struct _KernelEnv
+struct KernelEnv
 {
 cl_context mpkContext;
 cl_command_queue mpkCmdQueue;
 cl_program mpkProgram;
-} KernelEnv;
+};
 
 namespace sc { namespace opencl {
 
commit ca0670c5bb1d35c3960fbd8e44fb712f68770938
Author: Tor Lillqvist t...@collabora.com
Date:   Tue Oct 28 13:26:00 2014 +0200

Bin unused cl_kernel_function typedef

Change-Id: I42c944bdeb93dd0fdbc582ef48d8722380915bf1

diff --git a/sc/source/core/opencl/openclwrapper.hxx 
b/sc/source/core/opencl/openclwrapper.hxx
index 0d9ce14..c8ff48c4 100644
--- a/sc/source/core/opencl/openclwrapper.hxx
+++ b/sc/source/core/opencl/openclwrapper.hxx
@@ -41,14 +41,6 @@ typedef struct 

Re: call about new testing hardware

2014-10-28 Thread Markus Mohrhard
On Mon, Oct 27, 2014 at 2:10 PM, Markus Mohrhard
markus.mohrh...@googlemail.com wrote:
 Hey,

 so based on the doodle poll everyone who wants to join has time
 Tuesday at 14:00 UTC. Everyone who is interested in discussing how we
 can use our testing hardware is invited to join the call.

 Some of the topics are:

 * fuzzing
 * crash testing
 * performance testing
 * which hardware?
 * administration
 * other ideas

 I suppose we will use the same room as for the public ESC call so if
 you want to join have a look at the last ESC invite to find the number
 and the room details.




So just to document the numbers here:

Room number: 21 24 86

Country Number

Czech Republic  +420 22 888 07 95
Germany +49 30 34044134
Finland +35 89 42 45 00 19
France (Paris)  +33 170 743 070
Great Britain   +44 333 202 00 22
Great Britain   +44 1 777 29 56 08
Hungary +36 18 08 84 82
Italy (Milan)   +39 02 87 212 000
Italy (Rome)+39 06 888 12 000
Japan   +81 3 45 20 93 34
Netherlands +3 12 52 74 40 06
Norway  +47 21 04 92 14
Poland  +48 22 30 70 70 4
Portugal+351 30 88 00 624
Romania +40 333 63 000 3
Slovakia+421 2 33 45 66 16
Slovenia+386 16 00 14 01
South Africa+27 2 13 00 95 90
Spain   +34 911 822 733
Sweden  +46 8 40 30 96 98
USA (N.Y.)  +1 347 416 5028
USA +1 917 200 9279

More numbers: https://wiki.documentfoundation.org/Talkyoo
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/inc

2014-10-28 Thread Markus Mohrhard
 vcl/inc/unx/x11windowprovider.hxx |   28 
 1 file changed, 28 insertions(+)

New commits:
commit f1f2c46e03c38861bcd2583ed1e04996a6815994
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Tue Oct 28 14:18:03 2014 +0100

add missing header

Change-Id: I3378c7c0bfdf5a6901e4ce8ecc4ae807a0d893eb

diff --git a/vcl/inc/unx/x11windowprovider.hxx 
b/vcl/inc/unx/x11windowprovider.hxx
new file mode 100644
index 000..776c8e4
--- /dev/null
+++ b/vcl/inc/unx/x11windowprovider.hxx
@@ -0,0 +1,28 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_VCL_UNX_X11WINDOWPROVIDER
+#define INCLUDED_VCL_UNX_X11WINDOWPROVIDER
+
+#include prex.h
+#include postx.h
+
+#include vcl/dllapi.h
+
+class VCL_PLUGIN_PUBLIC X11WindowProvider
+{
+public:
+virtual ~X11WindowProvider();
+
+virtual Window GetX11Window() = 0;
+};
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: external/icu

2014-10-28 Thread Stephan Bergmann
 external/icu/icu-ubsan.patch.0 |   17 -
 1 file changed, 16 insertions(+), 1 deletion(-)

New commits:
commit 3025a28bc2e89af05c9d287a07223be0447d3c2f
Author: Stephan Bergmann sberg...@redhat.com
Date:   Tue Oct 28 14:33:46 2014 +0100

external/icu: More workaround UBSan flexible array member detection

Change-Id: Ie83e3104bd639be42ac0c6e25fc2eafd88cf0c6f

diff --git a/external/icu/icu-ubsan.patch.0 b/external/icu/icu-ubsan.patch.0
index 5f9e85f..7268bb7 100644
--- a/external/icu/icu-ubsan.patch.0
+++ b/external/icu/icu-ubsan.patch.0
@@ -9,9 +9,24 @@
  /*  This array does not have two elements 
*/
  /*Array Size is actually 
fData-fHeader-fCatCount */
  /*CAUTION:  see 
RBBITableBuilder::getTableSize()  */
+@@ -126,7 +126,7 @@
+ uint32_t fRowLen;   /*  Length of a state table row, in 
bytes.*/
+ uint32_t fFlags;/*  Option Flags for this state table 
*/
+ uint32_t fReserved; /*  reserved  
*/
+-char fTableData[4]; /*  First RBBIStateTableRow begins here.  
*/
++char fTableData[1]; /*  First RBBIStateTableRow begins here.  
*/
+ /*(making it char[] simplifies ugly 
address   */
+ /* arithmetic for indexing variable 
length rows.) */
+ };
 --- source/common/rbbitblb.cpp
 +++ source/common/rbbitblb.cpp
-@@ -1072,10 +1072,10 @@
+@@ -1067,15 +1067,15 @@
+ return 0;
+ }
+ 
+-size= sizeof(RBBIStateTable) - 4;// The header, with no rows to 
the table.
++size= offsetof(RBBIStateTable, fTableData);// The header, with no 
rows to the table.
+ 
  numRows = fDStates-size();
  numCols = fRB-fSetBuilder-getNumCharCategories();
  
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: IAccessible2 bridgecomponent context fails

2014-10-28 Thread Niklas Johansson
--enable-atl did the trick, I now have working IAccessible2 support in 
my builds again.


Thanks again,
Niklas

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/Library_vclplug_gen.mk

2014-10-28 Thread Michael Meeks
 vcl/Library_vclplug_gen.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 421dfcdd17265f540367bae9ad8325b3df6cf72a
Author: Michael Meeks michael.me...@collabora.com
Date:   Tue Oct 28 14:25:09 2014 +

Add missing glew dependency.

Change-Id: Ib06a64a1378b531e64e433ae3e86ddf4b9da2782

diff --git a/vcl/Library_vclplug_gen.mk b/vcl/Library_vclplug_gen.mk
index 634fa74..f303911 100644
--- a/vcl/Library_vclplug_gen.mk
+++ b/vcl/Library_vclplug_gen.mk
@@ -47,6 +47,7 @@ $(eval $(call gb_Library_use_externals,vclplug_gen,\
boost_headers \
cairo \
graphite \
+   glew \
harfbuzz \
icuuc \
valgrind \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Is LibreOffice vulnerable to Microsoft OLE-vulnerability

2014-10-28 Thread Caolán McNamara
On Sat, 2014-10-25 at 16:19 +0100, Michael Meeks wrote:
 On Sat, 2014-10-25 at 16:46 +0200, Simon Justesen wrote:
  A few days ago, Microsoft issued this security advisory: 
  https://technet.microsoft.com/library/security/3010060
 
   Good question; its not been reported as a security issue to us; it
 looks like the fix is to various (almost all) versions of Windows, not
 Office.

3010060 is CVE-2014-6352 which is apparently a variant of
CVE-2014-4114. There are some reproducers for CVE-2014-4114, and as
far as I can tell CVE-2014-4114 doesn't affect us (at least when I
checked with what reproducers were available on Oct 21)

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: external/icu

2014-10-28 Thread Stephan Bergmann
 external/icu/icu-ubsan.patch.0 |   67 +
 1 file changed, 67 insertions(+)

New commits:
commit 1f03a8d48c350f6e7c3612b30e0695aa9623982b
Author: Stephan Bergmann sberg...@redhat.com
Date:   Tue Oct 28 16:00:16 2014 +0100

external/icu: workaround -fsanitize=signed-integer-overflow warnings

Change-Id: I44b5d74a3c1addaec77e724a3e7356e3648fc10c

diff --git a/external/icu/icu-ubsan.patch.0 b/external/icu/icu-ubsan.patch.0
index 7268bb7..f3e9d99 100644
--- a/external/icu/icu-ubsan.patch.0
+++ b/external/icu/icu-ubsan.patch.0
@@ -49,6 +49,17 @@
  table-fNumStates = fDStates-size();
  table-fFlags = 0;
  if (fRB-fLookAheadHardBreak) {
+--- source/common/ucharstriebuilder.cpp
 source/common/ucharstriebuilder.cpp
+@@ -285,7 +285,7 @@
+ 
+ UCharsTrieBuilder::UCTLinearMatchNode::UCTLinearMatchNode(const UChar *units, 
int32_t len, Node *nextNode)
+ : LinearMatchNode(len, nextNode), s(units) {
+-hash=hash*37+ustr_hashUCharsN(units, len);
++hash=hash*37U+ustr_hashUCharsN(units, len);
+ }
+ 
+ UBool
 --- source/common/ucmndata.h
 +++ source/common/ucmndata.h
 @@ -50,7 +50,7 @@
@@ -60,6 +71,62 @@
  } UDataOffsetTOC;
  
  /**
+--- source/common/unicode/stringtriebuilder.h
 source/common/unicode/stringtriebuilder.h
+@@ -269,7 +269,7 @@
+ void setValue(int32_t v) {
+ hasValue=TRUE;
+ value=v;
+-hash=hash*37+v;
++hash=hash*37U+v;
+ }
+ protected:
+ UBool hasValue;
+@@ -296,7 +296,7 @@
+ class LinearMatchNode : public ValueNode {
+ public:
+ LinearMatchNode(int32_t len, Node *nextNode)
+-: ValueNode((0x33*37+len)*37+hashCode(nextNode)),
++: ValueNode((0x33U*37+len)*37+hashCode(nextNode)),
+   length(len), next(nextNode) {}
+ virtual UBool operator==(const Node other) const;
+ virtual int32_t markRightEdgesFirst(int32_t edgeNumber);
+@@ -330,7 +330,7 @@
+ equal[length]=NULL;
+ values[length]=value;
+ ++length;
+-hash=(hash*37+c)*37+value;
++hash=(hash*37U+c)*37+value;
+ }
+ // Adds a unit which leads to another match node.
+ void add(int32_t c, Node *node) {
+@@ -338,7 +338,7 @@
+ equal[length]=node;
+ values[length]=0;
+ ++length;
+-hash=(hash*37+c)*37+hashCode(node);
++hash=(hash*37U+c)*37+hashCode(node);
+ }
+ protected:
+ Node *equal[kMaxBranchLinearSubNodeLength];  // NULL means has final 
value.
+@@ -353,7 +353,7 @@
+ class SplitBranchNode : public BranchNode {
+ public:
+ SplitBranchNode(UChar middleUnit, Node *lessThanNode, Node 
*greaterOrEqualNode)
+-: BranchNode(((0x55*37+middleUnit)*37+
++: BranchNode(((0x55U*37+middleUnit)*37+
+   
hashCode(lessThanNode))*37+hashCode(greaterOrEqualNode)),
+   unit(middleUnit), lessThan(lessThanNode), 
greaterOrEqual(greaterOrEqualNode) {}
+ virtual UBool operator==(const Node other) const;
+@@ -370,7 +370,7 @@
+ class BranchHeadNode : public ValueNode {
+ public:
+ BranchHeadNode(int32_t len, Node *subNode)
+-: ValueNode((0x66*37+len)*37+hashCode(subNode)),
++: ValueNode((0x66U*37+len)*37+hashCode(subNode)),
+   length(len), next(subNode) {}
+ virtual UBool operator==(const Node other) const;
+ virtual int32_t markRightEdgesFirst(int32_t edgeNumber);
 --- source/common/ustring.cpp
 +++ source/common/ustring.cpp
 @@ -1486,7 +1486,7 @@
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 23 commits - connectivity/source cpputools/source editeng/source oox/source sal/rtl sc/source svtools/source svx/source sw/source tools/source ucb/source unotools/sourc

2014-10-28 Thread Caolán McNamara
 connectivity/source/manager/mdrivermanager.cxx   |   26 +-
 cpputools/source/unoexe/unoexe.cxx   |1 
 editeng/source/misc/svxacorr.cxx |   10 +-
 oox/source/ole/axcontrol.cxx |4 -
 sal/rtl/alloc_cache.cxx  |2 
 sc/source/filter/html/htmlpars.cxx   |2 
 sc/source/filter/oox/workbookfragment.cxx|1 
 sc/source/ui/unoobj/datauno.cxx  |2 
 svtools/source/control/ruler.cxx |2 
 svx/source/fmcomp/dbaexchange.cxx|2 
 svx/source/fmcomp/gridcell.cxx   |2 
 sw/source/core/unocore/unoobj.cxx|2 
 sw/source/filter/ww8/ww8par2.cxx |   20 -
 sw/source/filter/ww8/ww8scan.cxx |   14 +++
 sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx |2 
 sw/source/uibase/dochdl/swdtflvr.cxx |   12 ++-
 sw/source/uibase/lingu/olmenu.cxx|   60 +++
 sw/source/uibase/utlui/navipi.cxx|4 -
 tools/source/generic/poly.cxx|6 +
 ucb/source/ucp/ftp/ftpcontent.cxx|2 
 unotools/source/config/configitem.cxx|2 
 vcl/qa/cppunit/timer.cxx |5 +
 vcl/source/fontsubset/ttcr.cxx   |   29 +++
 vcl/source/gdi/animate.cxx   |2 
 writerfilter/source/dmapper/DomainMapperTableManager.cxx |   17 +++-
 25 files changed, 149 insertions(+), 82 deletions(-)

New commits:
commit 7acb634f58e86375f4a3cd4926a560679a45896f
Author: Caolán McNamara caol...@redhat.com
Date:   Tue Oct 28 13:39:08 2014 +

Resolves: fdo#85081 terminate if can't load kde addressbook

Change-Id: I3b1b78127d7d4080a23c0ac9f7d37706197de62c

diff --git a/connectivity/source/manager/mdrivermanager.cxx 
b/connectivity/source/manager/mdrivermanager.cxx
index 494a304..6e90f65 100644
--- a/connectivity/source/manager/mdrivermanager.cxx
+++ b/connectivity/source/manager/mdrivermanager.cxx
@@ -119,12 +119,26 @@ Any SAL_CALL ODriverEnumeration::nextElement(  ) 
throw(NoSuchElementException, W
 
 const DriverAccess operator()( const DriverAccess _rDescriptor ) 
const
 {
-if ( !_rDescriptor.xDriver.is() )
-// we did not load this driver, yet
-if ( _rDescriptor.xComponentFactory.is() )
-// we have a factory for it
-const_cast DriverAccess ( _rDescriptor ).xDriver.set(
-
_rDescriptor.xComponentFactory-createInstanceWithContext( mxContext ), 
css::uno::UNO_QUERY);
+// we did not load this driver, yet
+if (!_rDescriptor.xDriver.is())
+{
+// we have a factory for it
+if (_rDescriptor.xComponentFactory.is())
+{
+DriverAccess rDesc = 
const_castDriverAccess(_rDescriptor);
+try
+{
+//load driver
+rDesc.xDriver.set(
+
rDesc.xComponentFactory-createInstanceWithContext(mxContext), 
css::uno::UNO_QUERY);
+}
+catch (const Exception)
+{
+//failure, abandon driver
+rDesc.xComponentFactory.clear();
+}
+}
+}
 return _rDescriptor;
 }
 
commit aa0499cefda1f808e6361e400d02a04cd4a0ef65
Author: Caolán McNamara caol...@redhat.com
Date:   Tue Oct 28 14:12:32 2014 +

coverity#982593 experiment with silencing Infinite loop

etc.

Change-Id: I1548d60280ab4f74fe023d026435a05f7865b516

diff --git a/cpputools/source/unoexe/unoexe.cxx 
b/cpputools/source/unoexe/unoexe.cxx
index f06b2dc..91d75b4 100644
--- a/cpputools/source/unoexe/unoexe.cxx
+++ b/cpputools/source/unoexe/unoexe.cxx
@@ -493,6 +493,7 @@ SAL_IMPLEMENT_MAIN()
 
 nIndex = 0;
 OUString aUnoUrlToken( aUnoUrl.getToken( 1, ';', nIndex ) );
+// coverity[infinite_loop]
 for (;;)
 {
 // accepting
diff --git a/sal/rtl/alloc_cache.cxx b/sal/rtl/alloc_cache.cxx
index 19591a8..be6cd4da 100644
--- a/sal/rtl/alloc_cache.cxx
+++ b/sal/rtl/alloc_cache.cxx
@@ -919,12 +919,14 @@ rtl_cache_deactivate (
 /* cleanup cpu layer */
 if ((mag = cache-m_cpu_curr) != 0)
 {
+// coverity[missing_lock]
 cache-m_cpu_curr = 0;
 rtl_cache_magazine_clear (cache, mag);
 rtl_cache_free (mag_cache, mag);
 }
 if ((mag = cache-m_cpu_prev) != 0)
 {
+// 

[Libreoffice-commits] core.git: sw/source

2014-10-28 Thread Miklos Vajna
 sw/source/core/unocore/unoportenum.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 9b01059f6e2143c5b5b481f3d321309648fc7dd4
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Tue Oct 28 15:44:06 2014 +0100

SwXTextPortionEnumeration ctor: avoid dynamic_cast in the common case

For a document of 1000 pages and with 1000 bookmarks, this brings a
considerable speedup on ODF export:

before:
real3m28.187s
after:
real2m51.565s

Change-Id: Ic3f85c727a8ea4b5012d5c3f0a5887ff47762fb8

diff --git a/sw/source/core/unocore/unoportenum.cxx 
b/sw/source/core/unocore/unoportenum.cxx
index 4d74772..7f70bc5 100644
--- a/sw/source/core/unocore/unoportenum.cxx
+++ b/sw/source/core/unocore/unoportenum.cxx
@@ -153,14 +153,13 @@ namespace
 ++ppMark)
 {
 ::sw::mark::IMark* const pBkmk = ppMark-get();
-::sw::mark::CrossRefBookmark *const pCrossRefMark(
-dynamic_cast ::sw::mark::CrossRefBookmark*(pBkmk));
 bool const hasOther = pBkmk-IsExpanded();
 
 const SwPosition rStartPos = pBkmk-GetMarkStart();
 if(rStartPos.nNode == nOwnNode)
 {
 // #i109272#: cross reference marks: need special handling!
+::sw::mark::CrossRefBookmark *const 
pCrossRefMark(dynamic_cast ::sw::mark::CrossRefBookmark*(pBkmk));
 sal_uInt8 const nType = (hasOther || pCrossRefMark)
 ? BKM_TYPE_START : BKM_TYPE_START_END;
 rBkmArr.insert(SwXBookmarkPortion_ImplSharedPtr(
@@ -174,6 +173,7 @@ namespace
 {
 unique_ptrSwPosition pCrossRefEndPos;
 const SwPosition* pEndPos = NULL;
+::sw::mark::CrossRefBookmark *const 
pCrossRefMark(dynamic_cast ::sw::mark::CrossRefBookmark*(pBkmk));
 if(hasOther)
 {
 pEndPos = rEndPos;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2014-10-28 Thread Caolán McNamara
 sw/source/filter/ww8/ww8par.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit e9566f27c8b8bab822888c285abec06b58432358
Author: Caolán McNamara caol...@redhat.com
Date:   Tue Oct 28 15:24:23 2014 +

fix a big pile of the crash tester .doc import failures

wrt the blasted SwIndexReg dtor assert

Change-Id: I4b3eeab76d5d76f7b769b458baeadbc0a9bd4238

diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index fcba4e0..2ab0967 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -5404,11 +5404,13 @@ sal_uLong SwWW8ImplReader::CoreLoad(WW8Glossary 
*pGloss, const SwPosition rPos)
 if (mbNewDoc)
   rDoc.getIDocumentRedlineAccess().SetRedlineMode((RedlineMode_t)( eMode 
));
 
-UpdatePageDescs(rDoc, nPageDescOffset);
-
 SAL_WARN_IF(mpTableEndPaM, sw.ww8, document ended without table 
ending);
 mpTableEndPaM.reset();  //ensure this is deleted before pPaM
 delete pPaM, pPaM = 0;
+lastAnchorPos.reset();  //ensure this is deleted before UpdatePageDescs
+
+UpdatePageDescs(rDoc, nPageDescOffset);
+
 return nErrRet;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'feature/perfwork4' - 2 commits - include/svx svx/source

2014-10-28 Thread Kohei Yoshida
 include/svx/sdr/properties/properties.hxx |   11 +
 svx/source/sdr/properties/properties.cxx  |   10 +
 svx/source/unodraw/unoshape.cxx   |  167 ++
 3 files changed, 98 insertions(+), 90 deletions(-)

New commits:
commit 808817a27a7cb43a164dab71838132950bb6025d
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Fri Oct 24 15:23:58 2014 -0400

Make this member private. Nobody accesses it directly.

Change-Id: Id00917198bda71eb80768526375eb83ba46dba11

diff --git a/include/svx/sdr/properties/properties.hxx 
b/include/svx/sdr/properties/properties.hxx
index 4b7e6f2..f0c1065 100644
--- a/include/svx/sdr/properties/properties.hxx
+++ b/include/svx/sdr/properties/properties.hxx
@@ -50,19 +50,20 @@ namespace sdr
 {
 class SVX_DLLPUBLIC BaseProperties
 {
-protected:
+private:
 // the owner of this Properties. Set from constructor and not
 // to be changed in any way.
 SdrObject  mrObject;
 
+protected:
+
 // create a new object specific itemset with object specific 
ranges.
 virtual SfxItemSet* CreateObjectSpecificItemSet(SfxItemPool 
pPool) = 0;
 
 // internal access to SdrObject
-SdrObject GetSdrObject() const
-{
-return mrObject;
-}
+const SdrObject GetSdrObject() const;
+
+SdrObject GetSdrObject();
 
 // Test changeability for a single item. If a implementation wants 
to prevent
 // changing an item this method may be overloaded.
diff --git a/svx/source/sdr/properties/properties.cxx 
b/svx/source/sdr/properties/properties.cxx
index 5865948..e705fd4 100644
--- a/svx/source/sdr/properties/properties.cxx
+++ b/svx/source/sdr/properties/properties.cxx
@@ -44,6 +44,16 @@ namespace sdr
 {
 }
 
+const SdrObject BaseProperties::GetSdrObject() const
+{
+return mrObject;
+}
+
+SdrObject BaseProperties::GetSdrObject()
+{
+return mrObject;
+}
+
 const SfxItemSet BaseProperties::GetMergedItemSet() const
 {
 // default implementation falls back to GetObjectItemSet()
commit d425dce58875bfa3673c87dda09db8c7aa73a16d
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Fri Oct 24 14:41:45 2014 -0400

Scope reduction by early bailout.

Change-Id: I3a5c944d6ed863c347da03e0a60ff653232b3e72

diff --git a/svx/source/unodraw/unoshape.cxx b/svx/source/unodraw/unoshape.cxx
index c3d17a5..e14c892 100644
--- a/svx/source/unodraw/unoshape.cxx
+++ b/svx/source/unodraw/unoshape.cxx
@@ -1643,112 +1643,109 @@ void SAL_CALL SvxShape::_setPropertyValue( const 
OUString rPropertyName, const
 
 const SfxItemPropertySimpleEntry* pMap = 
mpPropSet-getPropertyMapEntry(rPropertyName);
 
-if( mpObj.is()  mpModel )
+if (!mpObj.is() || !mpModel)
 {
-if( pMap == NULL )
-throw beans::UnknownPropertyException();
+// Since we have no actual sdr object right now, remember all
+// properties in a list. These properties will be set when the sdr
+// object is created.
 
-if( (pMap-nFlags  beans::PropertyAttribute::READONLY ) != 0 )
-throw beans::PropertyVetoException(
-( OUString(
-Readonly property can't be set:  )
-  + rPropertyName ),
-uno::Reference drawing::XShape ( this ) );
+if (pMap  pMap-nWID)
+{
+// FIXME: We should throw a UnknownPropertyException here.
+//But since this class is aggregated from classes that
+//support additional properties that we don't know here we
+//silently store *all* properties, even if they may be not
+//supported after creation.
+mpPropSet-setPropertyValue( pMap, rVal );
+}
+return;
+}
 
-mpModel-SetChanged();
+if (!pMap)
+throw beans::UnknownPropertyException();
 
-if(!setPropertyValueImpl( rPropertyName, pMap, rVal ) )
-{
-DBG_ASSERT( pMap-nWID == SDRATTR_TEXTDIRECTION || pMap-nWID  
SDRATTR_NOTPERSIST_FIRST || pMap-nWID  SDRATTR_NOTPERSIST_LAST, Not persist 
item not handled! );
-DBG_ASSERT( pMap-nWID  OWN_ATTR_VALUE_START || pMap-nWID  
OWN_ATTR_VALUE_END, Not item property not handled! );
+if ((pMap-nFlags  beans::PropertyAttribute::READONLY) != 0)
+throw beans::PropertyVetoException(
+OUString(Readonly property can't be set: ) + rPropertyName,
+uno::Referencedrawing::XShape(this));
 
-bool bIsNotPersist = pMap-nWID = SDRATTR_NOTPERSIST_FIRST  
pMap-nWID = SDRATTR_NOTPERSIST_LAST  pMap-nWID != SDRATTR_TEXTDIRECTION;
+mpModel-SetChanged();
 
-if( pMap-nWID == SDRATTR_ECKENRADIUS 

[Libreoffice-commits] core.git: sw/source

2014-10-28 Thread Andras Timar
 sw/source/uibase/docvw/edtwin.cxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 5f447bb0156322c542649809e1f8ec1db2f22e7d
Author: Andras Timar andras.ti...@collabora.com
Date:   Tue Oct 28 12:13:55 2014 +0100

fdo#37960 fix shift+click to select multiple drawings

I simply didn't get the logic behind calling GotoNextFly(). It caused
not only this bug. For example Ctrl+click on a background text frame
did not select the text frame, but an image on the previous page.

Change-Id: I85ccbbda2f324de55417d6199b4abe79e59bf295

diff --git a/sw/source/uibase/docvw/edtwin.cxx 
b/sw/source/uibase/docvw/edtwin.cxx
index 38e4232..d60fcfa 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -3698,8 +3698,6 @@ void SwEditWin::MouseButtonDown(const MouseEvent _rMEvt)
  rSh.IsObjSelectable( aDocPos ) )  
!lcl_urlOverBackground( rSh, aDocPos ) )
 {
 SwMvContext aMvContext( rSh );
-if( !rSh.IsFrmSelected() )
-rSh.GotoNextFly();
 rSh.EnterSelFrmMode();
 bCallBase = false;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/qa sw/source

2014-10-28 Thread Miklos Vajna
 sw/qa/core/data/odt/pass/fdo84692.odt |binary
 sw/source/core/unocore/unostyle.cxx   |4 ++--
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 6cee94ba6b224399e5a4a2511df39d3118454c83
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Tue Oct 28 16:43:04 2014 +0100

fdo#84692 SwXAutoStyleFamily::insertStyle: don't throw on unknown property

Regression from commit 7d9bb549d498d6beed2c4050c402d09643febdfa
(Related: #i124638# Second step of DrawingLayer FillAttributes...,
2014-06-02), the problem was that the new branch (used for paragraphs)
in the method does not tolerate unknown properties (it throws), while
the behavior was just a warning.

Adapt the new branch to the old behavior, so that the document can be
opened again.

Change-Id: I5d849987602fb8aa0cbbda92ce07c050067473b3

diff --git a/sw/qa/core/data/odt/pass/fdo84692.odt 
b/sw/qa/core/data/odt/pass/fdo84692.odt
new file mode 100644
index 000..db5c878
Binary files /dev/null and b/sw/qa/core/data/odt/pass/fdo84692.odt differ
diff --git a/sw/source/core/unocore/unostyle.cxx 
b/sw/source/core/unocore/unostyle.cxx
index 1038f26..84d7148 100644
--- a/sw/source/core/unocore/unostyle.cxx
+++ b/sw/source/core/unocore/unostyle.cxx
@@ -4210,8 +4210,8 @@ uno::Reference style::XAutoStyle  
SwXAutoStyleFamily::insertStyle(
 
 if (!pEntry)
 {
-throw uno::RuntimeException(OUString(Unknown property: ) + 
rPropName,
-static_castcppu::OWeakObject*(this));
+SAL_WARN(sw.core, SwXAutoStyleFamily::Modify: Unknown 
property:   rPropName);
+continue;
 }
 
 const sal_uInt8 nMemberId(pEntry-nMemberId  (~SFX_METRIC_ITEM));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2014-10-28 Thread ᚉᚐᚑᚂᚐᚅ McNamara
 sc/source/filter/excel/xltoolbar.cxx |   10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

New commits:
commit 5356d06f5c3cae96c15c4da49ab31c760509d6d7
Author: ᚉᚐᚑᚂᚐᚅ McNamara caol...@redhat.com
Date:   Tue Oct 28 15:59:42 2014 +

coverity#1242796 Untrusted loop bound

and throw ogham at the bugzilla bot for kicks

Change-Id: I50cdf676e59e4e966f999218837dabfdd2008b6e

diff --git a/sc/source/filter/excel/xltoolbar.cxx 
b/sc/source/filter/excel/xltoolbar.cxx
index 0121b21..f85f455 100644
--- a/sc/source/filter/excel/xltoolbar.cxx
+++ b/sc/source/filter/excel/xltoolbar.cxx
@@ -356,8 +356,16 @@ ScCTBWrapper::Read( SvStream rS)
 {
 OSL_TRACE(ScCTBWrapper::Read() stream pos 0x%x, rS.Tell() );
 nOffSet = rS.Tell();
-if ( !ctbSet.Read( rS ) )
+if (!ctbSet.Read(rS))
 return false;
+
+//ScCTB is 1 TB which is min 15bytes, nViews TBVisualData which is min 
20bytes
+//and one 32bit number (4 bytes)
+const size_t nMinRecordSize = 39;
+const size_t nMaxPossibleRecords = rS.remainingSize()/nMinRecordSize;
+if (ctbSet.ctb  nMaxPossibleRecords)
+return false;
+
 for ( sal_uInt16 index = 0; index  ctbSet.ctb; ++index )
 {
 ScCTB aCTB( ctbSet.ctbViews );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2014-10-28 Thread Caolán McNamara
 sw/source/filter/ww8/ww8par.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d49755ba3ae60b0d50e1f6edcf2107f1f695017b
Author: Caolán McNamara caol...@redhat.com
Date:   Tue Oct 28 16:08:31 2014 +

lastAnchorPos got renamed to mpLastAnchorPos

Change-Id: Icfb055123e049cdc16a5825e4be4f18a42d6cb7f

diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index 2ab0967..97e7c6b 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -5407,7 +5407,7 @@ sal_uLong SwWW8ImplReader::CoreLoad(WW8Glossary *pGloss, 
const SwPosition rPos)
 SAL_WARN_IF(mpTableEndPaM, sw.ww8, document ended without table 
ending);
 mpTableEndPaM.reset();  //ensure this is deleted before pPaM
 delete pPaM, pPaM = 0;
-lastAnchorPos.reset();  //ensure this is deleted before UpdatePageDescs
+mpLastAnchorPos.reset();//ensure this is deleted before UpdatePageDescs
 
 UpdatePageDescs(rDoc, nPageDescOffset);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: filter/source

2014-10-28 Thread ᚉᚐᚑᚂᚐᚅ McNamara
 filter/source/msfilter/mstoolbar.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 911faa4db7c1ea6064fdd49e3e481df6a7a0706f
Author: ᚉᚐᚑᚂᚐᚅ McNamara caol...@redhat.com
Date:   Tue Oct 28 16:01:22 2014 +

coverity#1242844 Untrusted loop bound

Change-Id: I64a805503d0c044b5c5a80df1513e35df5c39171

diff --git a/filter/source/msfilter/mstoolbar.cxx 
b/filter/source/msfilter/mstoolbar.cxx
index 13d5505..c8ff2f0 100644
--- a/filter/source/msfilter/mstoolbar.cxx
+++ b/filter/source/msfilter/mstoolbar.cxx
@@ -673,8 +673,11 @@ bool TBCCDData::Read( SvStream rS)
 {
 nOffSet = rS.Tell();
 rS.ReadInt16( cwstrItems );
-if ( cwstrItems )
+if (cwstrItems  0)
 {
+//each WString is at least one byte
+if (rS.remainingSize()  static_castsize_t(cwstrItems))
+return false;
 for( sal_Int32 index=0; index  cwstrItems; ++index )
 {
 WString aString;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


minutes for call about new testing hardware

2014-10-28 Thread Markus Mohrhard
Hey,

here are the minutes for the call of the new testing hardware.

present: cloph, moggi, Florian, Norbert, Matus, Alex, Caolan

* virtual or real hardware?

** options:
*** cloud
 spot pricing?
* can be shut down randomly
*** another server
 similar configuration to existing server

** cloud good for services that are not important (Cloph)
*** no need to run everyday and don't care if they are shut down
*** about c3.8xlarge on amazon (32cpu, 60GB): ~480 $/month
(reserved/guranteed if running 24/7 - ~0.62$/hour) + 4289$/year - so
more or less the same (Cloph)

** real hardware
*** about 800€ for a 64 core, 256GB memory machine (Florian)
*** could be conntected to the remaining infrastructure

** mixed environment ?
*** real hardware for important parts
*** leave room in budget for cloud infrastructure
 fuzzing might be a good candidate for cloud spot pricing
*** consensus that this is best solution

* how to handle requests for VM to implement new ideas? (Norbert)
** how to get access?
** we have gandalf (Markus)
*** hopefully upgrade to SLE 12 soon, therefore being able to build
libreoffice again
** additionally want to have at least one VM for doing crazy stuff
there (Markus)
** talk to the ESC if you want to use them (Markus)
** board is the wrong target for these decisions (Markus, Norbert)

* need test if hardware is fast enough? (Florian)
** 5x VM resources as upper bound to get below one day for crash
testing (Markus)
** no need, hardware should be fast enough, surely faster than now

* is there room with the selected hardware for cloud instance in the
budget? (Norbert)
** hardware around 10k/year
** budget 15k
** there is still room for cloud infrastructure if necessary
** no need to run to the board for small changes

* services running on them?
** crash testing
** performance testing
** fuzzing
** maybe some tinderboxes with special tests
** VM for crazy ideas

AI: check for the price (Florian)
* expected 2-4 weeks
* ping Cloph, Alex, Norbet, Markus when hardware is available
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: cui/uiconfig

2014-10-28 Thread Miklos Vajna
 cui/uiconfig/ui/backgroundpage.ui |   77 --
 1 file changed, 77 deletions(-)

New commits:
commit 431d2e3aaf5ccef45fcbdb6f4b4f11f9441f3c10
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Tue Oct 28 17:08:25 2014 +0100

cui: clean up gradient parts of the background tab page

I forgot to clean this up when cherry-picking
6e61ecd09679a66060f932835622821d39e92f01 (Merge back branch
alg_writerframes to trunk, 2014-03-19).

Change-Id: I531dea63d3b62d16f11d414758012432bb4b2503

diff --git a/cui/uiconfig/ui/backgroundpage.ui 
b/cui/uiconfig/ui/backgroundpage.ui
index 791ca47..be78570 100644
--- a/cui/uiconfig/ui/backgroundpage.ui
+++ b/cui/uiconfig/ui/backgroundpage.ui
@@ -678,79 +678,6 @@
 property name=height1/property
   /packing
 /child
-child
-  object class=GtkFrame id=backgroundgradientframe
-property name=can_focusFalse/property
-property name=hexpandTrue/property
-property name=vexpandTrue/property
-property name=label_xalign0/property
-property name=shadow_typenone/property
-child
-  object class=GtkAlignment id=alignment5
-property name=visibleTrue/property
-property name=can_focusFalse/property
-property name=hexpandTrue/property
-property name=vexpandTrue/property
-property name=top_padding6/property
-property name=left_padding12/property
-child
-  object class=GtkGrid id=grid11
-property name=visibleTrue/property
-property name=can_focusFalse/property
-property name=hexpandTrue/property
-property name=vexpandTrue/property
-property name=column_spacing24/property
-property name=column_homogeneousTrue/property
-child
-  object class=svxlo-GradientLB id=gradientslb:border
-property name=visibleTrue/property
-property name=can_focusFalse/property
-property name=hexpandTrue/property
-property name=vexpandTrue/property
-  /object
-  packing
-property name=left_attach0/property
-property name=top_attach0/property
-property name=width1/property
-property name=height1/property
-  /packing
-/child
-child
-  object class=svxlo-SvxXRectPreview id=previewctl
-property name=visibleTrue/property
-property name=can_focusFalse/property
-property name=hexpandTrue/property
-property name=vexpandTrue/property
-  /object
-  packing
-property name=left_attach1/property
-property name=top_attach0/property
-property name=width1/property
-property name=height1/property
-  /packing
-/child
-  /object
-/child
-  /object
-/child
-child type=label
-  object class=GtkLabel id=label1
-property name=visibleTrue/property
-property name=can_focusFalse/property
-property name=label translatable=yesBackground 
Gradient/property
-attributes
-  attribute name=weight value=bold/
-/attributes
-  /object
-/child
-  /object
-  packing
-property name=left_attach0/property
-property name=top_attach3/property
-property name=width1/property
-property name=height1/property
-  /packing
-/child
   /object
   object class=GtkListStore id=liststore1
 columns
@@ -765,10 +692,6 @@
 col id=11/col
   /row
   row
-col id=0 translatable=yesGradient/col
-col id=12/col
-  /row
-  row
 col id=0 translatable=yesGraphic/col
 col id=14/col
   /row
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Bug 65675] LibreOffice 4.2 most annoying bugs

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65675
Bug 65675 depends on bug 37960, which changed state.

Bug 37960 Summary: Shift click to select multiple drawings does not work if 
picture there[Summary in Comment # 30]
https://bugs.freedesktop.org/show_bug.cgi?id=37960

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: external/icu

2014-10-28 Thread Stephan Bergmann
 external/icu/icu-ubsan.patch.0 |   11 +++
 1 file changed, 11 insertions(+)

New commits:
commit acd62e055ee71f330b1d48c3c3c83aaa5ceca29a
Author: Stephan Bergmann sberg...@redhat.com
Date:   Tue Oct 28 17:29:35 2014 +0100

external/icu: workaround -fsanitize=signed-integer-overflow warnings

Change-Id: I7d8e3be80f04ec0a9d1dbd394ac0e2ab2f1a4551

diff --git a/external/icu/icu-ubsan.patch.0 b/external/icu/icu-ubsan.patch.0
index f3e9d99..479007b 100644
--- a/external/icu/icu-ubsan.patch.0
+++ b/external/icu/icu-ubsan.patch.0
@@ -127,6 +127,17 @@
length(len), next(subNode) {}
  virtual UBool operator==(const Node other) const;
  virtual int32_t markRightEdgesFirst(int32_t edgeNumber);
+--- source/common/uresbund.cpp
 source/common/uresbund.cpp
+@@ -53,7 +53,7 @@
+ UHashTok namekey, pathkey;
+ namekey.pointer = b-fName;
+ pathkey.pointer = b-fPath;
+-return uhash_hashChars(namekey)+37*uhash_hashChars(pathkey);
++return uhash_hashChars(namekey)+37U*uhash_hashChars(pathkey);
+ }
+ 
+ /* INTERNAL: compares two entries */
 --- source/common/ustring.cpp
 +++ source/common/ustring.cpp
 @@ -1486,7 +1486,7 @@
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'feature/orcus-continuous-integration' - 3528 commits - accessibility/inc accessibility/source android/abs-lib android/Bootstrap android/CustomTarget_android_des

2014-10-28 Thread Markus Mohrhard
Rebased ref, commits from common ancestor:
commit 546e2a2d03a81a9ccc168e2ff63f3bbf2033f111
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Tue Oct 28 14:46:26 2014 +0100

implement import_sheet_properties interface

Change-Id: Ifed14df422c067fb6faacf370cbe9e1acf336d24

diff --git a/sc/source/filter/inc/orcusinterface.hxx 
b/sc/source/filter/inc/orcusinterface.hxx
index a9d1cd7..7e86530 100644
--- a/sc/source/filter/inc/orcusinterface.hxx
+++ b/sc/source/filter/inc/orcusinterface.hxx
@@ -102,6 +102,25 @@ private:
 ScRange maRange;
 };
 
+class ScOrcusSheetProperties : public 
orcus::spreadsheet::iface::import_sheet_properties
+{
+ScDocumentImport mrDoc;
+SCTAB mnTab;
+public:
+ScOrcusSheetProperties(SCTAB nTab, ScDocumentImport rDoc);
+virtual ~ScOrcusSheetProperties();
+
+virtual void set_column_width(orcus::spreadsheet::col_t col, double width, 
orcus::length_unit_t unit) SAL_OVERRIDE;
+
+virtual void set_column_hidden(orcus::spreadsheet::col_t col, bool hidden) 
SAL_OVERRIDE;
+
+virtual void set_row_height(orcus::spreadsheet::row_t row, double height, 
orcus::length_unit_t unit) SAL_OVERRIDE;
+
+virtual void set_row_hidden(orcus::spreadsheet::row_t row, bool hidden) 
SAL_OVERRIDE;
+
+virtual void set_merge_cell_range(const char* p_range, size_t n_range) 
SAL_OVERRIDE;
+};
+
 class ScOrcusSheet : public orcus::spreadsheet::iface::import_sheet
 {
 ScDocumentImport mrDoc;
@@ -109,6 +128,7 @@ class ScOrcusSheet : public 
orcus::spreadsheet::iface::import_sheet
 ScOrcusFactory mrFactory;
 sc::SharedFormulaGroups maFormulaGroups;
 ScOrcusAutoFilter maAutoFilter;
+ScOrcusSheetProperties maProperties;
 
 typedef std::mapsize_t, ScRangeData* SharedFormulaContainer;
 SharedFormulaContainer maSharedFormulas;
@@ -121,6 +141,7 @@ public:
 ScOrcusSheet(ScDocumentImport rDoc, SCTAB nTab, ScOrcusFactory rFactory);
 
 virtual orcus::spreadsheet::iface::import_auto_filter* get_auto_filter() 
SAL_OVERRIDE { return maAutoFilter; }
+virtual orcus::spreadsheet::iface::import_sheet_properties* 
get_sheet_properties() SAL_OVERRIDE;
 
 // Orcus import interface
 virtual void set_auto(orcus::spreadsheet::row_t row, 
orcus::spreadsheet::col_t col, const char* p, size_t n) SAL_OVERRIDE;
diff --git a/sc/source/filter/orcus/interface.cxx 
b/sc/source/filter/orcus/interface.cxx
index d96ae77..8a00f21 100644
--- a/sc/source/filter/orcus/interface.cxx
+++ b/sc/source/filter/orcus/interface.cxx
@@ -212,8 +212,51 @@ void ScOrcusFactory::setStatusIndicator(const 
uno::Referencetask::XStatusIndica
 mxStatusIndicator = rIndicator;
 }
 
+ScOrcusSheetProperties::ScOrcusSheetProperties(SCTAB nTab, ScDocumentImport 
rDoc):
+mrDoc(rDoc),
+mnTab(nTab)
+{
+}
+
+ScOrcusSheetProperties::~ScOrcusSheetProperties()
+{
+}
+
+void ScOrcusSheetProperties::set_column_width(os::col_t col, double width, 
orcus::length_unit_t /*unit*/)
+{
+mrDoc.getDoc().SetColWidthOnly(col, mnTab, width);
+}
+
+void ScOrcusSheetProperties::set_column_hidden(os::col_t col, bool hidden)
+{
+if (hidden)
+mrDoc.getDoc().SetColHidden(col, col, mnTab, hidden);
+}
+
+void ScOrcusSheetProperties::set_row_height(os::row_t row, double height, 
orcus::length_unit_t /*unit*/)
+{
+mrDoc.getDoc().SetRowHeightOnly(row, row,mnTab, height);
+}
+
+void ScOrcusSheetProperties::set_row_hidden(os::row_t row, bool hidden)
+{
+if (hidden)
+mrDoc.getDoc().SetRowHidden(row, row, mnTab, hidden);
+}
+
+void ScOrcusSheetProperties::set_merge_cell_range(const char* /*p_range*/, 
size_t /*n_range*/)
+{
+}
+
 ScOrcusSheet::ScOrcusSheet(ScDocumentImport rDoc, SCTAB nTab, ScOrcusFactory 
rFactory) :
-mrDoc(rDoc), mnTab(nTab), mrFactory(rFactory), 
maAutoFilter(rDoc.getDoc()), mnCellCount(0) {}
+mrDoc(rDoc),
+mnTab(nTab),
+mrFactory(rFactory),
+maAutoFilter(rDoc.getDoc()),
+maProperties(mnTab, mrDoc),
+mnCellCount(0)
+{
+}
 
 void ScOrcusSheet::cellInserted()
 {
@@ -225,6 +268,11 @@ void ScOrcusSheet::cellInserted()
 }
 }
 
+os::iface::import_sheet_properties* ScOrcusSheet::get_sheet_properties()
+{
+return maProperties;
+}
+
 void ScOrcusSheet::set_auto(os::row_t row, os::col_t col, const char* p, 
size_t n)
 {
 OUString aVal(p, n, RTL_TEXTENCODING_UTF8);
commit 967fb16b4ce71360c88b35559e76ffbb409786bf
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Tue Oct 28 14:33:33 2014 +0100

prevent default operator=

Change-Id: Ibcd843a992b06b73e628b0249fb9f3ea723510d2

diff --git a/sc/inc/documentimport.hxx b/sc/inc/documentimport.hxx
index 4b84f0d..a6e4564 100644
--- a/sc/inc/documentimport.hxx
+++ b/sc/inc/documentimport.hxx
@@ -40,6 +40,7 @@ class SC_DLLPUBLIC ScDocumentImport : boost::noncopyable
 ScDocumentImportImpl* mpImpl;
 
 ScDocumentImport(); // disabled
+ScDocumentImport operator=(const ScDocumentImport); //disabled
 
 public:
 ScDocumentImport(ScDocument rDoc);

[Libreoffice-commits] core.git: vcl/headless

2014-10-28 Thread Stephan Bergmann
 vcl/headless/svpinst.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 2b4ffd8e333dee31ee7df58f693d8eff9ec5a93e
Author: Stephan Bergmann sberg...@redhat.com
Date:   Tue Oct 28 17:42:48 2014 +0100

Fix -fsanitize=signed-integer-overflow (when long int is 32-bit)

Change-Id: Ia6f1b60108784660c4a2dfd311592207e6bf5d88

diff --git a/vcl/headless/svpinst.cxx b/vcl/headless/svpinst.cxx
index 3f20e19..3bb44e0 100644
--- a/vcl/headless/svpinst.cxx
+++ b/vcl/headless/svpinst.cxx
@@ -311,8 +311,8 @@ void SvpSalInstance::Yield( bool bWait, bool 
bHandleAllCurrentEvents )
 timeval Timeout;
 // determine remaining timeout.
 gettimeofday (Timeout, 0);
-nTimeoutMS = m_aTimeout.tv_sec*1000 + m_aTimeout.tv_usec/1000
- - Timeout.tv_sec*1000 - Timeout.tv_usec/1000;
+nTimeoutMS = (m_aTimeout.tv_sec - Timeout.tv_sec) * 1000
+ + m_aTimeout.tv_usec/1000 - Timeout.tv_usec/1000;
 if( nTimeoutMS  0 )
 nTimeoutMS = 0;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'feature/perfwork4' - include/svx sd/source svx/inc svx/source

2014-10-28 Thread Kohei Yoshida
 include/svx/sdr/properties/attributeproperties.hxx   |   96 ---
 include/svx/sdr/properties/e3dcompoundproperties.hxx |   71 --
 include/svx/sdr/properties/e3dproperties.hxx |   64 
 include/svx/sdr/properties/emptyproperties.hxx   |   96 ---
 include/svx/sdr/properties/rectangleproperties.hxx   |   61 
 include/svx/sdr/properties/textproperties.hxx|   93 --
 sd/source/core/stlsheet.cxx  |1 
 svx/inc/sdr/properties/attributeproperties.hxx   |   95 ++
 svx/inc/sdr/properties/captionproperties.hxx |2 
 svx/inc/sdr/properties/circleproperties.hxx  |2 
 svx/inc/sdr/properties/connectorproperties.hxx   |2 
 svx/inc/sdr/properties/customshapeproperties.hxx |2 
 svx/inc/sdr/properties/e3dcompoundproperties.hxx |   71 ++
 svx/inc/sdr/properties/e3dextrudeproperties.hxx  |5 
 svx/inc/sdr/properties/e3dlatheproperties.hxx|5 
 svx/inc/sdr/properties/e3dproperties.hxx |   63 
 svx/inc/sdr/properties/e3dsceneproperties.hxx|2 
 svx/inc/sdr/properties/e3dsphereproperties.hxx   |2 
 svx/inc/sdr/properties/emptyproperties.hxx   |   95 ++
 svx/inc/sdr/properties/graphicproperties.hxx |2 
 svx/inc/sdr/properties/measureproperties.hxx |2 
 svx/inc/sdr/properties/oleproperties.hxx |2 
 svx/inc/sdr/properties/pageproperties.hxx|2 
 svx/inc/sdr/properties/rectangleproperties.hxx   |   60 +++
 svx/inc/sdr/properties/textproperties.hxx|   92 ++
 svx/source/engine3d/obj3d.cxx|4 
 svx/source/sdr/properties/attributeproperties.cxx|2 
 svx/source/sdr/properties/e3dcompoundproperties.cxx  |2 
 svx/source/sdr/properties/e3dproperties.cxx  |2 
 svx/source/sdr/properties/emptyproperties.cxx|2 
 svx/source/sdr/properties/rectangleproperties.cxx|2 
 svx/source/sdr/properties/textproperties.cxx |2 
 svx/source/svdraw/svdoattr.cxx   |2 
 svx/source/svdraw/svdobj.cxx |2 
 svx/source/svdraw/svdorect.cxx   |2 
 svx/source/svdraw/svdotext.cxx   |2 
 svx/source/table/cell.cxx|2 
 svx/source/table/svdotable.cxx   |2 
 svx/source/table/tableundo.cxx   |2 
 39 files changed, 505 insertions(+), 513 deletions(-)

New commits:
commit 3955a8484dbfda48e81c0aa0bb37c60b05575e31
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Tue Oct 28 12:03:34 2014 -0400

Move these headers from include to svx; they are not used outside svx.

Change-Id: I8685b451a39e890250a3309ddb70346bac4084b2

diff --git a/sd/source/core/stlsheet.cxx b/sd/source/core/stlsheet.cxx
index f960506..2bfd870 100644
--- a/sd/source/core/stlsheet.cxx
+++ b/sd/source/core/stlsheet.cxx
@@ -34,7 +34,6 @@
 #include svl/smplhint.hxx
 #include svl/itemset.hxx
 
-#include svx/sdr/properties/attributeproperties.hxx
 #include svx/xflbmtit.hxx
 #include svx/xflbstit.hxx
 #include editeng/bulletitem.hxx
diff --git a/include/svx/sdr/properties/attributeproperties.hxx 
b/svx/inc/sdr/properties/attributeproperties.hxx
similarity index 96%
rename from include/svx/sdr/properties/attributeproperties.hxx
rename to svx/inc/sdr/properties/attributeproperties.hxx
index bbe4be826..43073ff 100644
--- a/include/svx/sdr/properties/attributeproperties.hxx
+++ b/svx/inc/sdr/properties/attributeproperties.hxx
@@ -23,7 +23,6 @@
 #include svl/lstner.hxx
 #include svl/stylesheetuser.hxx
 #include svx/sdr/properties/defaultproperties.hxx
-#include svx/svxdllapi.h
 
 
 
@@ -31,7 +30,7 @@ namespace sdr
 {
 namespace properties
 {
-class SVX_DLLPUBLIC AttributeProperties : public DefaultProperties, 
public SfxListener, public svl::StyleSheetUser
+class AttributeProperties : public DefaultProperties, public 
SfxListener, public svl::StyleSheetUser
 {
 // add style sheet, do all the necessary handling
 void ImpAddStyleSheet(SfxStyleSheet* pNewStyleSheet, bool 
bDontRemoveHardAttr);
diff --git a/svx/inc/sdr/properties/captionproperties.hxx 
b/svx/inc/sdr/properties/captionproperties.hxx
index 04fdc09..7c2aea8 100644
--- a/svx/inc/sdr/properties/captionproperties.hxx
+++ b/svx/inc/sdr/properties/captionproperties.hxx
@@ -20,7 +20,7 @@
 #ifndef INCLUDED_SVX_INC_SDR_PROPERTIES_CAPTIONPROPERTIES_HXX
 #define INCLUDED_SVX_INC_SDR_PROPERTIES_CAPTIONPROPERTIES_HXX
 
-#include svx/sdr/properties/rectangleproperties.hxx
+#include sdr/properties/rectangleproperties.hxx
 
 
 
diff --git a/svx/inc/sdr/properties/circleproperties.hxx 
b/svx/inc/sdr/properties/circleproperties.hxx
index 3b9a18a..283b285 100644
--- 

[Libreoffice-commits] core.git: include/svx sd/source svx/inc svx/source

2014-10-28 Thread Kohei Yoshida
 include/svx/sdr/properties/attributeproperties.hxx   |   96 ---
 include/svx/sdr/properties/e3dcompoundproperties.hxx |   71 --
 include/svx/sdr/properties/e3dproperties.hxx |   64 
 include/svx/sdr/properties/emptyproperties.hxx   |   96 ---
 include/svx/sdr/properties/rectangleproperties.hxx   |   61 
 include/svx/sdr/properties/textproperties.hxx|   93 --
 sd/source/core/stlsheet.cxx  |1 
 svx/inc/sdr/properties/attributeproperties.hxx   |   95 ++
 svx/inc/sdr/properties/captionproperties.hxx |2 
 svx/inc/sdr/properties/circleproperties.hxx  |2 
 svx/inc/sdr/properties/connectorproperties.hxx   |2 
 svx/inc/sdr/properties/customshapeproperties.hxx |2 
 svx/inc/sdr/properties/e3dcompoundproperties.hxx |   71 ++
 svx/inc/sdr/properties/e3dextrudeproperties.hxx  |5 
 svx/inc/sdr/properties/e3dlatheproperties.hxx|5 
 svx/inc/sdr/properties/e3dproperties.hxx |   63 
 svx/inc/sdr/properties/e3dsceneproperties.hxx|2 
 svx/inc/sdr/properties/e3dsphereproperties.hxx   |2 
 svx/inc/sdr/properties/emptyproperties.hxx   |   95 ++
 svx/inc/sdr/properties/graphicproperties.hxx |2 
 svx/inc/sdr/properties/measureproperties.hxx |2 
 svx/inc/sdr/properties/oleproperties.hxx |2 
 svx/inc/sdr/properties/pageproperties.hxx|2 
 svx/inc/sdr/properties/rectangleproperties.hxx   |   60 +++
 svx/inc/sdr/properties/textproperties.hxx|   92 ++
 svx/source/engine3d/obj3d.cxx|4 
 svx/source/sdr/properties/attributeproperties.cxx|2 
 svx/source/sdr/properties/e3dcompoundproperties.cxx  |2 
 svx/source/sdr/properties/e3dproperties.cxx  |2 
 svx/source/sdr/properties/emptyproperties.cxx|2 
 svx/source/sdr/properties/rectangleproperties.cxx|2 
 svx/source/sdr/properties/textproperties.cxx |2 
 svx/source/svdraw/svdoattr.cxx   |2 
 svx/source/svdraw/svdobj.cxx |2 
 svx/source/svdraw/svdorect.cxx   |2 
 svx/source/svdraw/svdotext.cxx   |2 
 svx/source/table/cell.cxx|2 
 svx/source/table/svdotable.cxx   |2 
 svx/source/table/tableundo.cxx   |2 
 39 files changed, 505 insertions(+), 513 deletions(-)

New commits:
commit 8c5f640308b618ec330e83527019a4baa982f902
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Tue Oct 28 12:03:34 2014 -0400

Move these headers from include to svx; they are not used outside svx.

Change-Id: I8685b451a39e890250a3309ddb70346bac4084b2

diff --git a/sd/source/core/stlsheet.cxx b/sd/source/core/stlsheet.cxx
index f960506..2bfd870 100644
--- a/sd/source/core/stlsheet.cxx
+++ b/sd/source/core/stlsheet.cxx
@@ -34,7 +34,6 @@
 #include svl/smplhint.hxx
 #include svl/itemset.hxx
 
-#include svx/sdr/properties/attributeproperties.hxx
 #include svx/xflbmtit.hxx
 #include svx/xflbstit.hxx
 #include editeng/bulletitem.hxx
diff --git a/include/svx/sdr/properties/attributeproperties.hxx 
b/svx/inc/sdr/properties/attributeproperties.hxx
similarity index 96%
rename from include/svx/sdr/properties/attributeproperties.hxx
rename to svx/inc/sdr/properties/attributeproperties.hxx
index a14b634..4dbb800 100644
--- a/include/svx/sdr/properties/attributeproperties.hxx
+++ b/svx/inc/sdr/properties/attributeproperties.hxx
@@ -23,7 +23,6 @@
 #include svl/lstner.hxx
 #include svl/stylesheetuser.hxx
 #include svx/sdr/properties/defaultproperties.hxx
-#include svx/svxdllapi.h
 
 
 
@@ -31,7 +30,7 @@ namespace sdr
 {
 namespace properties
 {
-class SVX_DLLPUBLIC AttributeProperties : public DefaultProperties, 
public SfxListener, public svl::StyleSheetUser
+class AttributeProperties : public DefaultProperties, public 
SfxListener, public svl::StyleSheetUser
 {
 // add style sheet, do all the necessary handling
 void ImpAddStyleSheet(SfxStyleSheet* pNewStyleSheet, bool 
bDontRemoveHardAttr);
diff --git a/svx/inc/sdr/properties/captionproperties.hxx 
b/svx/inc/sdr/properties/captionproperties.hxx
index e4c88d2..9ac7f2a 100644
--- a/svx/inc/sdr/properties/captionproperties.hxx
+++ b/svx/inc/sdr/properties/captionproperties.hxx
@@ -20,7 +20,7 @@
 #ifndef INCLUDED_SVX_INC_SDR_PROPERTIES_CAPTIONPROPERTIES_HXX
 #define INCLUDED_SVX_INC_SDR_PROPERTIES_CAPTIONPROPERTIES_HXX
 
-#include svx/sdr/properties/rectangleproperties.hxx
+#include sdr/properties/rectangleproperties.hxx
 
 
 
diff --git a/svx/inc/sdr/properties/circleproperties.hxx 
b/svx/inc/sdr/properties/circleproperties.hxx
index 980ad87..14e44da 100644
--- 

[Libreoffice-commits] core.git: include/tools tools/qa tools/source

2014-10-28 Thread Juan Picca
 include/tools/fract.hxx |   54 +++-
 tools/qa/cppunit/test_fract.cxx |7 
 tools/source/generic/fract.cxx  |  487 +++-
 3 files changed, 231 insertions(+), 317 deletions(-)

New commits:
commit 2ce0aededea43231d91a0955fc0676120dcc4f13
Author: Juan Picca jumap...@gmail.com
Date:   Fri Oct 24 11:43:52 2014 -0200

fdo#81356: use boost::rational internally in Fraction

Change-Id: I6f40eafee7652209395bd471e3508fe3a3d19d73
Reviewed-on: https://gerrit.libreoffice.org/12085
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/include/tools/fract.hxx b/include/tools/fract.hxx
index 10e810e..0e81155 100644
--- a/include/tools/fract.hxx
+++ b/include/tools/fract.hxx
@@ -19,26 +19,32 @@
 #ifndef INCLUDED_TOOLS_FRACT_HXX
 #define INCLUDED_TOOLS_FRACT_HXX
 
+#include boost/rational.hpp
+#include sal/log.hxx
 #include tools/toolsdllapi.h
 
 class SvStream;
 
+// This class uses the platform defined type 'long' as valid values but do all
+// calculations using sal_Int64 with checks for 'long' overflows.
 class TOOLS_DLLPUBLIC SAL_WARN_UNUSED Fraction
 {
 private:
-longnNumerator;
-longnDenominator;
+boolvalid;
+boost::rationalsal_Int64  value;
+
+boolHasOverflowValue();
 
 public:
-Fraction() { nNumerator = 0; nDenominator = 1; }
+Fraction() { valid = true; }
 Fraction( const Fraction  rFrac );
 Fraction( long nNum, long nDen=1 );
 Fraction( double dVal );
 
 boolIsValid() const;
 
-longGetNumerator() const { return nNumerator; }
-longGetDenominator() const { return nDenominator; }
+longGetNumerator() const;
+longGetDenominator() const;
 
 operatorlong() const;
 operatordouble() const;
@@ -70,28 +76,50 @@ public:
 
 inline Fraction::Fraction( const Fraction rFrac )
 {
-nNumerator   = rFrac.nNumerator;
-nDenominator = rFrac.nDenominator;
+valid = rFrac.valid;
+if ( valid )
+value.assign( rFrac.value.numerator(), rFrac.value.denominator() );
+}
+
+inline long Fraction::GetNumerator() const
+{
+if ( !valid ) {
+SAL_WARN( tools.fraction, 'GetNumerator()' on invalid fraction );
+return 0;
+}
+return value.numerator();
+}
+
+inline long Fraction::GetDenominator() const {
+if ( !valid ) {
+SAL_WARN( tools.fraction, 'GetDenominator()' on invalid fraction );
+return -1;
+}
+return value.denominator();
 }
 
 inline Fraction Fraction::operator=( const Fraction rFrac )
 {
-nNumerator   = rFrac.nNumerator;
-nDenominator = rFrac.nDenominator;
+if ( this != rFrac ) {
+valid = rFrac.valid;
+if ( valid )
+value.assign( rFrac.value.numerator(), rFrac.value.denominator() );
+}
 return *this;
 }
 
 inline bool Fraction::IsValid() const
 {
-return (nDenominator  0);
+return valid;
 }
 
 inline Fraction::operator long() const
 {
-if ( nDenominator  0 )
-return (nNumerator / nDenominator);
-else
+if ( !valid ) {
+SAL_WARN( tools.fraction, 'operator long()' on invalid fraction );
 return 0;
+}
+return boost::rational_castlong(value);
 }
 
 inline Fraction operator+( const Fraction rVal1, const Fraction rVal2 )
diff --git a/tools/qa/cppunit/test_fract.cxx b/tools/qa/cppunit/test_fract.cxx
index febece0..6352588 100644
--- a/tools/qa/cppunit/test_fract.cxx
+++ b/tools/qa/cppunit/test_fract.cxx
@@ -96,9 +96,16 @@ public:
 CPPUNIT_ASSERT_EQUAL(1L, f.GetDenominator());
 }
 
+void testCreateFromDoubleIn32BitsPlatform() {
+// This pass in 64 bits but fail in 32 bits
+Fraction f(0.960945);
+CPPUNIT_ASSERT_EQUAL(true, f.IsValid());
+}
+
 CPPUNIT_TEST_SUITE(FractionTest);
 CPPUNIT_TEST(testFraction);
 CPPUNIT_TEST(testMinLongDouble);
+CPPUNIT_TEST(testCreateFromDoubleIn32BitsPlatform);
 CPPUNIT_TEST_SUITE_END();
 };
 
diff --git a/tools/source/generic/fract.cxx b/tools/source/generic/fract.cxx
index ec219d8..45d54a4 100644
--- a/tools/source/generic/fract.cxx
+++ b/tools/source/generic/fract.cxx
@@ -26,81 +26,12 @@
 #include tools/fract.hxx
 #include tools/lineend.hxx
 #include tools/stream.hxx
-#include tools/bigint.hxx
 
-/** Compute greates common divisor using Euclidian algorithm
+templatetypename T
+static boost::rationalT rational_FromDouble(double dVal);
 
-As the algorithm works on positive values only, the absolute value
-of each parameter is used.
-
-@param nVal1
-@param nVal2
-
-@note: If one parameter is {0,1}, GetGGT returns 1.
-*/
-static long GetGGT( long nVal1, long nVal2 )
-{
-nVal1 = std::abs( nVal1 );
-nVal2 = std::abs( nVal2 );
-
-if ( nVal1 = 1 || nVal2 = 1 )
-  

[Libreoffice-commits] core.git: Branch 'ports/macosx10.5/master' - 152 commits - apple_remote/source avmedia/Module_avmedia.mk basegfx/source bean/com bridges/Library_cpp_uno.mk bridges/source configu

2014-10-28 Thread Douglas Mencken
Rebased ref, commits from common ancestor:
commit 5207d81483eed5a24c3a20cca57f80e99a58d7a8
Author: Douglas Mencken dougmenc...@gmail.com
Date:   Sat Oct 25 11:03:56 2014 -0400

workarounds for `objc_msgSend' on 10.5

(vcl/osx/salframe.cxx, vcl/osx/salmenu.cxx)

plus, move conditional includes in salframe.cxx down a bit

Change-Id: I39886b4590f227ec69042fed0f5240ba0b0fd7f2

diff --git a/vcl/osx/salframe.cxx b/vcl/osx/salframe.cxx
index ce3e371..dacf9fe 100644
--- a/vcl/osx/salframe.cxx
+++ b/vcl/osx/salframe.cxx
@@ -37,11 +37,6 @@
 #include osx/a11yfactory.h
 #include quartz/utils.h
 
-#if MACOSX_SDK_VERSION  1060
-#include vcl/timer.hxx
-#include osx/saltimer.h
-#endif
-
 #include salwtype.hxx
 
 #include premac.h
@@ -54,6 +49,11 @@
 #include Carbon/Carbon.h
 #include postmac.h
 
+#if MACOSX_SDK_VERSION  1060
+#include vcl/timer.hxx
+#include osx/saltimer.h
+#endif
+
 using namespace std;
 
 AquaSalFrame* AquaSalFrame::s_pCaptureFrame = NULL;
@@ -201,16 +201,16 @@ void AquaSalFrame::initWindowAndView()
 [mpNSWindow setAcceptsMouseMovedEvents: YES];
 [mpNSWindow setHasShadow: YES];
 
-#if MACOSX_SDK_VERSION  1060
-objc_msgSend(mpNSWindow, @selector(setDelegate:), mpNSWindow);
-#else
+#if MACOSX_SDK_VERSION = 1070
+/* objc_msgSend(mpNSWindow, @selector(setDelegate:), mpNSWindow); */
 [mpNSWindow setDelegate: static_castidNSWindowDelegate (mpNSWindow)];
-#endif
 
 if( [mpNSWindow respondsToSelector: @selector(setRestorable:)])
 {
 objc_msgSend(mpNSWindow, @selector(setRestorable:), NO);
 }
+#endif
+
 const NSRect aRect = { NSZeroPoint, NSMakeSize( maGeometry.nWidth, 
maGeometry.nHeight )};
 mnTrackingRectTag = [mpNSView addTrackingRect: aRect owner: mpNSView 
userData: nil assumeInside: NO];
 
diff --git a/vcl/osx/salmenu.cxx b/vcl/osx/salmenu.cxx
index 32ce46b..1c876ea 100644
--- a/vcl/osx/salmenu.cxx
+++ b/vcl/osx/salmenu.cxx
@@ -246,9 +246,8 @@ AquaSalMenu::AquaSalMenu( bool bMenuBar ) :
 if( ! mbMenuBar )
 {
 mpMenu = [[SalNSMenu alloc] initWithMenu: this];
-#if MACOSX_SDK_VERSION  1060
-objc_msgSend(mpMenu, @selector(setDelegate:), mpMenu);
-#else
+#if MACOSX_SDK_VERSION = 1060
+/* objc_msgSend(mpMenu, @selector(setDelegate:), mpMenu); */
 [mpMenu setDelegate: (idNSMenuDelegate)mpMenu];
 #endif
 }
commit fc90e9e9239bab65e6f7eafa6921b97ac23d8747
Author: Douglas Mencken dougmenc...@gmail.com
Date:   Sun Oct 26 06:38:10 2014 -0400

vcl: fix some cannot convert 'objc_object*' to... issues

Change-Id: I4b0e32c412937da4b2ea4bf350be32ea31362b3c

diff --git a/vcl/osx/a11ywrapper.mm b/vcl/osx/a11ywrapper.mm
index 4e19e1d..f821da7 100644
--- a/vcl/osx/a11ywrapper.mm
+++ b/vcl/osx/a11ywrapper.mm
@@ -160,7 +160,7 @@ static std::ostream operator(std::ostream s, NSPoint 
point) {
 // (getter with parameter)attributeNameHereAttributeForParameter:
 // (setter)   setAttributeNameHereAttributeForElement:to:
 -(SEL)selectorForAttribute:(NSString *)attribute asGetter:(BOOL)asGetter 
withGetterParameter:(BOOL)withGetterParameter {
-SEL selector = nil;
+SEL selector = (SEL)nil;
 NSAutoreleasePool * pool = [ [ NSAutoreleasePool alloc ] init ];
 @try {
 // step 1: create method name from attribute name
@@ -186,7 +186,7 @@ static std::ostream operator(std::ostream s, NSPoint 
point) {
 // step 2: create selector
 selector = NSSelectorFromString ( methodName );
 } @catch ( id exception ) {
-selector = nil;
+selector = (SEL)nil;
 }
 [ pool release ];
 return selector;
diff --git a/vcl/osx/salframeview.mm b/vcl/osx/salframeview.mm
index 19dda57..4e90836 100644
--- a/vcl/osx/salframeview.mm
+++ b/vcl/osx/salframeview.mm
@@ -482,7 +482,7 @@ static AquaSalFrame* getMouseContainerFrame()
 mpFrame = pFrame;
 mMarkedRange = NSMakeRange(NSNotFound, 0);
 mSelectedRange = NSMakeRange(NSNotFound, 0);
-mpReferenceWrapper = nil;
+mpReferenceWrapper = (ReferenceWrapper*)nil;
 mpMouseEventListener = nil;
 mpLastSuperEvent = nil;
 }
@@ -1788,7 +1788,7 @@ private:
 // some frames never become visible ..
 ::vcl::Window *pWindow = mpFrame - GetWindow();
 if ( ! pWindow )
-return nil;
+return (::com::sun::star::accessibility::XAccessibleContext*)nil;
 
 mpReferenceWrapper = new ReferenceWrapper;
 mpReferenceWrapper - rAccessibleContext =  pWindow - 
/*GetAccessibleChildWindow( 0 ) -*/ GetAccessible() - getAccessibleContext();
diff --git a/vcl/osx/salnativewidgets.cxx b/vcl/osx/salnativewidgets.cxx
index ce3ab41..69f7753 100644
--- a/vcl/osx/salnativewidgets.cxx
+++ b/vcl/osx/salnativewidgets.cxx
@@ -558,7 +558,7 @@ bool AquaSalGraphics::drawNativeControl(ControlType nType,
 [NSNumber numberWithBool:NO], 
@kCUIWindowFrameDrawTitleSeparatorKey,
 [NSNumber 

[Libreoffice-commits] core.git: tools/source

2014-10-28 Thread David Tardon
 tools/source/generic/fract.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit ddc7f5dda51b100e69a8e7d86c0f8144ed3d8ea5
Author: David Tardon dtar...@redhat.com
Date:   Tue Oct 28 19:02:37 2014 +0100

fix build on android-arm tinderbox

Change-Id: If528f3cbaab66ceec07e35b479b4fe2ed55aa3c7

diff --git a/tools/source/generic/fract.cxx b/tools/source/generic/fract.cxx
index 45d54a4..3d35b4e 100644
--- a/tools/source/generic/fract.cxx
+++ b/tools/source/generic/fract.cxx
@@ -41,7 +41,7 @@ Fraction::Fraction( long nNum, long nDen )
 {
 if ( nDen == 0 ) {
 valid = false;
-SAL_WARN( tools.fraction, 'Fraction( + std::to_string(nNum) + 
,0)' invalid fraction created );
+SAL_WARN( tools.fraction, 'Fraction(  nNum  ,0)' invalid 
fraction created );
 return;
 }
 value.assign( nNum, nDen);
@@ -57,7 +57,7 @@ Fraction::Fraction( double dVal )
 valid = true;
 } catch(const boost::bad_rational unused) {
 valid = false;
-SAL_WARN( tools.fraction, 'Fraction( + std::to_string(dVal) + )' 
invalid fraction created );
+SAL_WARN( tools.fraction, 'Fraction(  dVal  )' invalid 
fraction created );
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: tools/source

2014-10-28 Thread Tor Lillqvist
 tools/source/generic/fract.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bdd22c4e53523e0dc204ecd9cd3e8e3614c96b0d
Author: Tor Lillqvist t...@collabora.com
Date:   Tue Oct 28 20:49:54 2014 +0200

WaE: C4101: 'unused' : unreferenced local variable

Change-Id: I511c2df37c7feda8a3ffa311074bcf2fe669a73a

diff --git a/tools/source/generic/fract.cxx b/tools/source/generic/fract.cxx
index 3d35b4e..7102d5a 100644
--- a/tools/source/generic/fract.cxx
+++ b/tools/source/generic/fract.cxx
@@ -55,7 +55,7 @@ Fraction::Fraction( double dVal )
 if ( HasOverflowValue() )
 throw boost::bad_rational();
 valid = true;
-} catch(const boost::bad_rational unused) {
+} catch(const boost::bad_rational) {
 valid = false;
 SAL_WARN( tools.fraction, 'Fraction(  dVal  )' invalid 
fraction created );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sd/inc

2014-10-28 Thread Kohei Yoshida
 sd/inc/pch/precompiled_sd.hxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 9b1dda187be0057a9d87c1ef95da2ee4db905449
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Tue Oct 28 15:05:50 2014 -0400

Windows build fix.

Change-Id: Ia118c81e39f5f48d4678cc375bad45f31ba8322e

diff --git a/sd/inc/pch/precompiled_sd.hxx b/sd/inc/pch/precompiled_sd.hxx
index 2df50de..a091554 100644
--- a/sd/inc/pch/precompiled_sd.hxx
+++ b/sd/inc/pch/precompiled_sd.hxx
@@ -694,7 +694,6 @@
 #include svx/sdr/overlay/overlayobjectcell.hxx
 #include svx/sdr/overlay/overlaypolypolygon.hxx
 #include svx/sdr/overlay/overlayprimitive2dsequenceobject.hxx
-#include svx/sdr/properties/attributeproperties.hxx
 #include svx/sdr/properties/properties.hxx
 #include svx/sdr/table/tablecontroller.hxx
 #include svx/sdr/table/tabledesign.hxx
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'feature/perfwork4' - package/inc

2014-10-28 Thread Matúš Kukan
 package/inc/ZipPackageStream.hxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 27b91f1167738bb22d8c952d6457159f24d6e4d1
Author: Matúš Kukan matus.ku...@collabora.com
Date:   Tue Oct 28 20:58:29 2014 +0100

ZipPackageStream::getRawData can be private

Change-Id: I66cbbfb2aa6abc6c8ebe34d9ea69855436c23edd

diff --git a/package/inc/ZipPackageStream.hxx b/package/inc/ZipPackageStream.hxx
index b639a1f..d5a9a56 100644
--- a/package/inc/ZipPackageStream.hxx
+++ b/package/inc/ZipPackageStream.hxx
@@ -71,7 +71,10 @@ private:
 bool m_bUseWinEncoding;
 bool m_bRawStream;
 
+/// Check that m_xStream implements io::XSeekable and return it
 ::com::sun::star::uno::Reference ::com::sun::star::io::XInputStream  
GetOwnSeekStream();
+::com::sun::star::uno::Reference ::com::sun::star::io::XInputStream  
SAL_CALL getRawData()
+throw(::com::sun::star::uno::RuntimeException);
 
 public:
 bool IsEncrypted () const{ return m_bIsEncrypted;}
@@ -135,8 +138,6 @@ public:
 const rtlRandomPool rRandomPool ) SAL_OVERRIDE;
 
 void setZipEntryOnLoading( const ZipEntry rInEntry);
-::com::sun::star::uno::Reference ::com::sun::star::io::XInputStream  
SAL_CALL getRawData()
-throw(::com::sun::star::uno::RuntimeException);
 void successfullyWritten( ZipEntry *pEntry );
 
 static ::com::sun::star::uno::Sequence  sal_Int8  
static_getImplementationId();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Bug 75025] LibreOffice 4.3 most annoying bugs

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75025

Anastasius anastasius_zw...@hotmail.com changed:

   What|Removed |Added

 Depends on||75467

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 75025] LibreOffice 4.3 most annoying bugs

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75025

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 Depends on|75467   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] dev-tools.git: scripts/update-stats.pl

2014-10-28 Thread Jan Holesovsky
 scripts/update-stats.pl |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 2b9a3a9c883ca6200b567b0088a9d61e6b1ed8ee
Author: Jan Holesovsky ke...@collabora.com
Date:   Tue Oct 28 21:30:45 2014 +0100

Add 4.3.2 to update stats.

diff --git a/scripts/update-stats.pl b/scripts/update-stats.pl
index 45c8ede..1d06f2b 100755
--- a/scripts/update-stats.pl
+++ b/scripts/update-stats.pl
@@ -96,6 +96,8 @@ my %versions = (
 '62ad5818884a2fc2e5780dd45466868d41009ec0' = '4.3.0_RC4',
 
 '958349dc3b25111dbca392fbc281a05559ef6848' = '4.3.1_RC2',
+
+'edfb5295ba211bd31ad47d0bad0118690f76407d' = '4.3.2_RC2',
 );
 
 my %month_to_num = (
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 5 commits - include/svx svx/source svx/uiconfig

2014-10-28 Thread Maxim Monastirsky
 include/svx/SvxColorValueSet.hxx |2 -
 svx/source/tbxctrls/PaletteManager.cxx   |6 ++-
 svx/source/tbxctrls/SvxColorValueSet.cxx |2 -
 svx/source/tbxctrls/colorwindow.hxx  |5 --
 svx/source/tbxctrls/tbcontrl.cxx |   61 +++
 svx/uiconfig/ui/colorwindow.ui   |2 -
 6 files changed, 31 insertions(+), 47 deletions(-)

New commits:
commit 3efc3cc5b0b4b6151e928c2348c7dc6f74181db5
Author: Maxim Monastirsky momonas...@gmail.com
Date:   Tue Oct 28 22:24:23 2014 +0200

colorwindow: try to fix initial layout

Change-Id: Ic69bbcd877d248afd0f23a867d4c57d801479b74

diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 9ca375a..f42b853 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -1148,10 +1148,6 @@ SvxColorWindow_Impl::SvxColorWindow_Impl( const 
OUStringrCommand,
 mpColorSet-SetStyle( WinBits(WB_FLATVALUESET | WB_ITEMBORDER | WB_3DLOOK 
| WB_NO_DIRECTSELECT) );
 mpRecentColorSet-SetStyle( WinBits(WB_FLATVALUESET | WB_ITEMBORDER | 
WB_3DLOOK | WB_NO_DIRECTSELECT) );
 
-mpColorSet-layoutAllVisible(mrPaletteManager.GetColorCount());
-mpRecentColorSet-SetLineCount( 1 );
-mpRecentColorSet-layoutAllVisible(mrPaletteManager.GetRecentColorCount());
-
 if ( SID_ATTR_CHAR_COLOR_BACKGROUND == theSlotId || SID_BACKGROUND_COLOR 
== theSlotId )
 {
 mpButtonAutoColor-SetText( SVX_RESSTR( RID_SVXSTR_TRANSPARENT ) );
@@ -1211,7 +1207,14 @@ SvxColorWindow_Impl::SvxColorWindow_Impl( const 
OUStringrCommand,
 SetText( rWndTitle );
 
 mrPaletteManager.ReloadColorSet(*mpColorSet);
+mpColorSet-layoutToGivenHeight(mpColorSet-GetSizePixel().Height(), 
mrPaletteManager.GetColorCount());
+
 mrPaletteManager.ReloadRecentColorSet(*mpRecentColorSet);
+mpRecentColorSet-SetLineCount( 1 );
+Size aSize = 
mpRecentColorSet-layoutAllVisible(mrPaletteManager.GetRecentColorCount());
+mpRecentColorSet-set_height_request(aSize.Height());
+mpRecentColorSet-set_width_request(aSize.Width());
+
 AddStatusListener( .uno:ColorTableState );
 AddStatusListener( maCommand );
 }
@@ -1293,8 +1296,6 @@ IMPL_LINK_NOARG(SvxColorWindow_Impl, OpenPickerClickHdl)
 
 void SvxColorWindow_Impl::Resize()
 {
-mpColorSet-SetSizePixel( this-GetOutputSizePixel() );
-mpRecentColorSet-SetSizePixel( this-GetOutputSizePixel() );
 }
 
 void SvxColorWindow_Impl::StartSelection()
@@ -1313,11 +1314,11 @@ void SvxColorWindow_Impl::StateChanged( sal_uInt16 
nSID, SfxItemState eState, co
 {
 if (( nSID == SID_COLOR_TABLE )  ( pState-ISA( SvxColorListItem )))
 {
-mrPaletteManager.ReloadColorSet(*mpColorSet);
-mrPaletteManager.ReloadRecentColorSet(*mpRecentColorSet);
-
-mpColorSet-layoutAllVisible(mrPaletteManager.GetColorCount());
-
mpRecentColorSet-layoutAllVisible(mrPaletteManager.GetRecentColorCount());
+if ( mrPaletteManager.GetPalette() == 0 )
+{
+mrPaletteManager.ReloadColorSet(*mpColorSet);
+
mpColorSet-layoutToGivenHeight(mpColorSet-GetSizePixel().Height(), 
mrPaletteManager.GetColorCount());
+}
 }
 else if ( SfxItemState::DEFAULT = eState )
 {
diff --git a/svx/uiconfig/ui/colorwindow.ui b/svx/uiconfig/ui/colorwindow.ui
index 1c2978e..1055385 100644
--- a/svx/uiconfig/ui/colorwindow.ui
+++ b/svx/uiconfig/ui/colorwindow.ui
@@ -108,7 +108,7 @@
 property name=receives_defaultTrue/property
   /object
   packing
-property name=expandTrue/property
+property name=expandFalse/property
 property name=fillTrue/property
 property name=position7/property
   /packing
commit 7ff283c6b3dad49129cd0df9176275805d25d7b9
Author: Maxim Monastirsky momonas...@gmail.com
Date:   Tue Oct 28 21:09:16 2014 +0200

colorwindow: Use exactly one row of recent colors

Right now one row of SvxColorValueSet is 12 colors.

Change-Id: I9be6e8487d5325866e17f578b7abb08f7c338fb1

diff --git a/svx/source/tbxctrls/PaletteManager.cxx 
b/svx/source/tbxctrls/PaletteManager.cxx
index e07ad15..b6d3cb7 100644
--- a/svx/source/tbxctrls/PaletteManager.cxx
+++ b/svx/source/tbxctrls/PaletteManager.cxx
@@ -24,13 +24,15 @@
 #include svx/drawitem.hxx
 #include svx/dialogs.hrc
 #include svtools/colrdlg.hxx
+#include vcl/svapp.hxx
+#include vcl/settings.hxx
 
 #define STR_DEFAULT_PAL Default palette
 #define STR_DOC_COLORS  Document colors
 #define STR_DOC_COLOR_PREFIXDocument Color 
 
 PaletteManager::PaletteManager() :
-mnMaxRecentColors(10),
+
mnMaxRecentColors(Application::GetSettings().GetStyleSettings().GetColorValueSetColumnCount()),
 mnNumOfPalettes(2),
 mnCurrentPalette(0),
 mnColorCount(0),
diff --git a/svx/source/tbxctrls/colorwindow.hxx 

Re: [Libreoffice-qa] No activity warnings - EasyHacks

2014-10-28 Thread Jan Holesovsky
Hi Joel, Tommy,

Tommy píše v Pá 24. 10. 2014 v 22:22 +0200:

  I suppose we shouldn't be sending these to EasyHacks - I guess it's
  worth treating them separately :-)  Is it possible to skip EasyHacks
  when sending these, please?
  What would be the rationale for skipping them for easy hacks? These get
  fixed just as inadvertently as other bugs. Just curious

The Easy Hacks usually are a kind of features; and features are usually
unlikely to be fixed / implemented inadvertently...

From my point of view, it would be better to batch-review the EasyHacks
I guess - to see that they really are Easy Hacks - with existing,
reasonable code pointers, etc.

But that's probably hard to do ATM, so I'd avoid any retest pings
there; or at least phrase them differently - in the Easy Hacks, the
pings shouldn't be about retesting, but more about the review of the
Easy Hack itself, because the fact that it was not taken might indicate
that it is not an Easy Hack in the first place :-)

 maybe Jan is complaining of the spam that is generated in the dev list by  
 any retest ping message that hits easy hacks.

No, I did not mean that, sorry for not being clear.

All the best,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] No activity warnings - EasyHacks

2014-10-28 Thread Bjoern Michaelsen
On Tue, Oct 28, 2014 at 10:18:04PM +0100, Jan Holesovsky wrote:
 But that's probably hard to do ATM, so I'd avoid any retest pings
 there; or at least phrase them differently - in the Easy Hacks, the
 pings shouldn't be about retesting, but more about the review of the
 Easy Hack itself, because the fact that it was not taken might indicate
 that it is not an Easy Hack in the first place :-)

Indeed. For everything else, lets please refrain from adding automated messages
to EasyHacks, if possible -- they are supposed to be read by an enthusiastic
new contributor and too many comments (esp. over 10 comments and automated
ones) are quite a demotivating turn-off.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70998] Termchange: Graphic/Picture - Image

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70998

--- Comment #27 from Stanislav Horacek stanislav.hora...@gmail.com ---
Updated list of remaining occurences of Graphics or Pictures from the
comment above (in current master) - I don't know if all of them should be
renamed:

Writer - Tools - Options - Libreoffice - Memory - Graphics cache
Writer - Tools - Options - Libreoffice Writer - View - Graphics and
objects
Writer - Tools - Options - Libreoffice Writer - Print - Pictures and
objects
Writer - Tools - Options - Libreoffice Writer/Web - View - Graphics and
objects
Writer - Tools - Options - Libreoffice Writer/Web - Print - Pictures and
objects
Writer - Tools - Customize - Keyboard - Functions - Category - Graphic
Writer - Tools - Customize - Keyboard - Functions - Category - Format ||
Function - Graphics mode

Writer - Side Bar - Properties - Graphic
Writer - Side Bar - Styles and Formatting - Graphics

Writer - Toolbar - Apply Style - Graphics ***Should be the same as the one
above???
Writer - Toolbar - Apply Style - Paragraphs Styles - Default Styles -
Caption - Illustration ???I'm not sure about this one.

Toolbars - Graphic filter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] No activity warnings - EasyHacks

2014-10-28 Thread Jan Holesovsky
Hi Joel, Tommy,

Tommy píše v Pá 24. 10. 2014 v 22:22 +0200:

  I suppose we shouldn't be sending these to EasyHacks - I guess it's
  worth treating them separately :-)  Is it possible to skip EasyHacks
  when sending these, please?
  What would be the rationale for skipping them for easy hacks? These get
  fixed just as inadvertently as other bugs. Just curious

The Easy Hacks usually are a kind of features; and features are usually
unlikely to be fixed / implemented inadvertently...

From my point of view, it would be better to batch-review the EasyHacks
I guess - to see that they really are Easy Hacks - with existing,
reasonable code pointers, etc.

But that's probably hard to do ATM, so I'd avoid any retest pings
there; or at least phrase them differently - in the Easy Hacks, the
pings shouldn't be about retesting, but more about the review of the
Easy Hack itself, because the fact that it was not taken might indicate
that it is not an Easy Hack in the first place :-)

 maybe Jan is complaining of the spam that is generated in the dev list by  
 any retest ping message that hits easy hacks.

No, I did not mean that, sorry for not being clear.

All the best,
Kendy

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] No activity warnings - EasyHacks

2014-10-28 Thread Bjoern Michaelsen
On Tue, Oct 28, 2014 at 10:18:04PM +0100, Jan Holesovsky wrote:
 But that's probably hard to do ATM, so I'd avoid any retest pings
 there; or at least phrase them differently - in the Easy Hacks, the
 pings shouldn't be about retesting, but more about the review of the
 Easy Hack itself, because the fact that it was not taken might indicate
 that it is not an Easy Hack in the first place :-)

Indeed. For everything else, lets please refrain from adding automated messages
to EasyHacks, if possible -- they are supposed to be read by an enthusiastic
new contributor and too many comments (esp. over 10 comments and automated
ones) are quite a demotivating turn-off.

Best,

Bjoern
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] No activity warnings - EasyHacks

2014-10-28 Thread Tommy
On Tue, 28 Oct 2014 22:23:31 +0100, Bjoern Michaelsen  
bjoern.michael...@canonical.com wrote:



On Tue, Oct 28, 2014 at 10:18:04PM +0100, Jan Holesovsky wrote:

But that's probably hard to do ATM, so I'd avoid any retest pings
there; or at least phrase them differently - in the Easy Hacks, the
pings shouldn't be about retesting, but more about the review of the
Easy Hack itself, because the fact that it was not taken might indicate
that it is not an Easy Hack in the first place :-)


Indeed. For everything else, lets please refrain from adding automated  
messages
to EasyHacks, if possible -- they are supposed to be read by an  
enthusiastic
new contributor and too many comments (esp. over 10 comments and  
automated

ones) are quite a demotivating turn-off.

Best,

Bjoern



I understand your point and you are both right.
If we do another ping retest thing we will keep the easy hacks out of it

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 84391] White lines between paragraphs when paragraph background color set

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84391

Luke lukebe...@hotmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Luke lukebe...@hotmail.com ---
This was fixed upstream by Armin Le Grand
http://cgit.freedesktop.org/libreoffice/core/commit/?h=aoo/trunkid=f4d179a8f647336b27098ebb2e0418b22b3ba44e

and cherry picked
http://cgit.freedesktop.org/libreoffice/core/commit/?id=1e09d294f443f015e51c601d1b02f19389fb90ac

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85542] New: FILEOPEN: DOCX import of overlapping bookmarks broken

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85542

Bug ID: 85542
   Summary: FILEOPEN: DOCX import of overlapping bookmarks broken
   Product: LibreOffice
   Version: 4.4.0.0.alpha1
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Libreoffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lukebe...@hotmail.com

Created attachment 108555
  -- https://bugs.freedesktop.org/attachment.cgi?id=108555action=edit
sample document to test overlapping bookmarks

Steps to reproduce:
1. Open testdoc01-2007.docx in Word
2. Go to-Bookmark-B1 and B2
3. Open testdoc01-2007.docx in Writer
4. Navigator-Bookmark-B1 and B2

Results:
Word2013 - b1:[A[BBB], b2:[BBB]C]
AOO 4.2 - b1:[A[BBB], b2:[BBB]C] - Good
LO 4.2.6.3 - b1:[A[BBB], b2:[BBB]C] - Good
LO 4.4 master - b1:[BBB]C], b2:[A[BBB] - bookmark b1 and b2 are reversed

Why this is important:
This is a serious issue as in Microsoft Word document certain internal used
bookmarks for TOC link target and Cross-References are overlapping resp.
marking the same text range.

Patches to fix AOO:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=aoo/trunkid=f73412f09ca8a34bb7ec73370dae3e6033c0c581

http://cgit.freedesktop.org/libreoffice/core/commit/?h=aoo/trunkid=f27e75828f65ce454a50f92ba64ee6847456f88f

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85542] FILEOPEN: DOCX import of overlapping bookmarks broken

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85542

Luke lukebe...@hotmail.com changed:

   What|Removed |Added

 Whiteboard||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85542] FILEOPEN: DOCX import of overlapping bookmarks broken

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85542

Luke lukebe...@hotmail.com changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85542] FILEOPEN: DOCX import of overlapping bookmarks broken

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85542

Luke lukebe...@hotmail.com changed:

   What|Removed |Added

   See Also||https://issues.apache.org/o
   ||oo/show_bug.cgi?id=125215

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85543] New: LibO startet nur minimiert, wenn bereits ein LibO-Programm laeuft

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85543

Bug ID: 85543
   Summary: LibO startet nur minimiert, wenn bereits ein
LibO-Programm laeuft
   Product: LibreOffice
   Version: 4.2.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Libreoffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ka...@web.de

LibreOffice 4.2.6.2
Windows 7 Professional 64 Bit
LibO startet nur minimiert, wenn bereits ein LibO-Programm laeuft. Dabei ist es
egal, ob dieses minimiert oder als Vollbild angezeigt und von einem anderem
Programm ueberlagert wird

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84991] Sort Ascending/ Descending option bug

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84991

--- Comment #2 from Anser Ahamed A anserahame...@gmail.com ---
Created attachment 108556
  -- https://bugs.freedesktop.org/attachment.cgi?id=108556action=edit
Libre Office Spread Sheet

Select two words and click the highlighted (yellow) option.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85540] Background color toolbar doesn't set same as property as TableTablePropertiesBackground

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85540

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

 Attachment #108550|text/plain  |application/vnd.oasis.opend
  mime type||ocument.text
 CC||philip...@hotmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84991] Sort Ascending/ Descending option bug

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84991

--- Comment #3 from Anser Ahamed A anserahame...@gmail.com ---
Created attachment 108557
  -- https://bugs.freedesktop.org/attachment.cgi?id=108557action=edit
Spread sheet crashed

After clicking the highlighted option the file has crashed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85542] FILEOPEN: DOCX import of overlapping bookmarks broken

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85542

Luke lukebe...@hotmail.com changed:

   What|Removed |Added

 Attachment #108555|text/plain  |application/vnd.openxmlform
  mime type||ats-officedocument.wordproc
   ||essingml.document

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84991] Sort Ascending/ Descending option bug

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84991

Anser Ahamed A anserahame...@gmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85520] Data : Group - Collapse / Expand buttons are mixed up and functionality is not quite like Excel

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85520

--- Comment #1 from raal r...@post.cz ---
Hello Salman,

Thank you for reporting the bug. Please attach a sample document, as this makes
it easier for us to verify the bug. 
(Please note that the attachment will be public, remove any sensitive
information before attaching it. 
See
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
for help on how to do so.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85544] New: Calc Zeile markieren und Rechtsklick geht nicht sofort

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85544

Bug ID: 85544
   Summary: Calc Zeile markieren und Rechtsklick geht nicht sofort
   Product: LibreOffice
   Version: 4.2.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Libreoffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ka...@web.de

LibreOffice 4.2.6.2
Windows 7 Professional 64 Bit
Calc : Tabelle mit Spalten A - R, wenn ganze Zeile markiert von R aus Richtung
A mit Shift + Pos1, passiert bei 1. Rechtsklick auf Markierung NIE etwas,
erst beim 2. Rechtsklick oeffnet sich das Kontextmenue

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82504] EDITING: Cell background not completely filled using background color icon

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82504

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

 CC||lukebe...@hotmail.com

--- Comment #9 from Jay Philips philip...@hotmail.com ---
*** Bug 85540 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85540] Background color toolbar doesn't set same as property as TableTablePropertiesBackground

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85540

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Jay Philips philip...@hotmail.com ---


*** This bug has been marked as a duplicate of bug 82504 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85545] New: Calc ENTER nach Kopieren ueberschreibt Zelle statt sie zum Bearbeiten zu oeffnen

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85545

Bug ID: 85545
   Summary: Calc ENTER nach Kopieren ueberschreibt Zelle statt sie
zum Bearbeiten zu oeffnen
   Product: LibreOffice
   Version: 4.2.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Libreoffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ka...@web.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85545] Calc ENTER nach Kopieren ueberschreibt Zelle statt sie zum Bearbeiten zu oeffnen

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85545

--- Comment #1 from KB_Pößneck ka...@web.de ---
LibreOffice 4.2.6.2
Windows 7 Professional 64 Bit
Calc : Zelle kopieren mit Strg + Einfg, naechste Zelle auswaehlen und
ENTER zum Bearbeiten druecken. Dabei wird der Zellinhalt ueberschrieben.
Es ist in den Programmeinstellungen eingestellt, dass ENTER die Zelle zum
Bearbeiten oeffnet und nicht deren Inhalt ueberschreibt. So sollte das auch
funktionieren und bei OpenOffice ging das auch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82504] EDITING: Background color button should fill cell background and not paragraph color when in a cell

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82504

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

Summary|EDITING: Cell background|EDITING: Background color
   |not completely filled using |button should fill cell
   |background color icon   |background and not
   ||paragraph color when in a
   ||cell

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82504] EDITING: Background color button should fill cell background and not paragraph color when in a cell

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82504

--- Comment #10 from Jay Philips philip...@hotmail.com ---
(In reply to Jay Philips from comment #3)
 1) that the default behaviour of the background icon should always be to set
 a cell's background color if inside a cell.

I think this is the best choice, as users in coming from calc are used to
clicking the same background color icon to fill the cell.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83836] FILESAVE: Corrupted content.xml after saving a ODS spreadsheet

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83836

raal r...@post.cz changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=85496

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85496] Read-error.Format error discovered in the file sub-document content.xml at 2, 217379

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85496

raal r...@post.cz changed:

   What|Removed |Added

 CC||r...@post.cz
   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=83836

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82504] EDITING: Background color button should fill cell background and not paragraph color when in a cell

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82504

Luke lukebe...@hotmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #11 from Luke lukebe...@hotmail.com ---
See attachment 108550 for a Sample table demonstrating the issue

Steps to reproduce
1) In Writer create a table
2) In one Cell use Table Toolbar-Background-green
3) In another cell, Table-Table Properties-Background-green

Expected Results:
Cell from 2) looks like Cell from 3)

Actual Results:
Cell 2) is just partially filled with a white border

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85492] Impress Remote for Android does not connect to Mac OSX

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85492

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||fdb...@neosheffield.co.uk
 Ever confirmed|0   |1

--- Comment #2 from Matthew Francis fdb...@neosheffield.co.uk ---
Just to complete the confusion over reproduction:

With a stock Nexus 7 2013 and OSX 10.9, I can connect over WiFi to both 4.3.2.2
and a recent 4.4 master build. Bluetooth fails to connect to either - the
hardware pairs well enough, but LibreOffice and the remote fail to find each
other.

As it seems that at least Bluetooth will fail to connect under some
circumstances, setting this - NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85542] FILEOPEN: DOCX import of overlapping bookmarks broken

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85542

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||philip...@hotmail.com
  Component|Libreoffice |Writer
 Ever confirmed|0   |1
 Whiteboard|filter:docx |filter:docx bibisectRequest

--- Comment #1 from Jay Philips philip...@hotmail.com ---
Confirmed in master. Its fine in 4.3 daily.

Version: 4.4.0.0.alpha1+
Build ID: 6ba8b7f5eacac969e4781d63718083a05491b1bc
TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2014-10-24_05:10:51

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 81633] Sorting shouldn't always automatically adjust references.

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81633

--- Comment #62 from dmdcare...@care2.com ---
(In reply to Luke from comment #61)
 
 Thank you very much for following up with this report and with the ESC, but
 I do not think we can consider this issue resolved until the old
 functionality is restored.

I agree with Luke.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 75595] VCL GTK3 plugin does not work completely

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75595

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||fdb...@neosheffield.co.uk
 Ever confirmed|0   |1
   Severity|normal  |enhancement

--- Comment #2 from Matthew Francis fdb...@neosheffield.co.uk ---
GTK3 support is experimental and may well not work at present.

Setting to - NEW, and to enhancement on the basis that it's an incomplete
feature that's probably never yet worked satisfactorily

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 38481] Envelope layout wrong for centered lengthwise (OKI printers)

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38481

--- Comment #16 from Alex Thurgood ipla...@yahoo.co.uk ---
@Dan : please try with the latest 4.3 production release of LibreOffice,
renaming your LO user profile before restarting LO after installation and
report back here with your findings

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84560] WebDAV : the 507 code does not display error messages to the user

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84560

FrOutlook fr.outl...@fiducial.fr changed:

   What|Removed |Added

   Priority|medium  |highest

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 49407] FORMATTING: Lack of Font Effects in Draw and impress and calc

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=49407

--- Comment #10 from Jay Philips philip...@hotmail.com ---
Currently the drop down is visible in Impress/Draw and invisible in Calc. To me
this is a bug and not an enhancement, as being able to modify a direct
formatting or style option like this is mandatory.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85524] OSX - CRASH sigabrt when opening presentation in Impress containing video clips

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85524

--- Comment #4 from Alex Thurgood ipla...@yahoo.co.uk ---
Created attachment 108559
  -- https://bugs.freedesktop.org/attachment.cgi?id=108559action=edit
apple trace from daily build

possibly more useful trace indicating that there is a problem with the jvm

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82504] EDITING: Background color button should fill cell background and not paragraph color when in a cell

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82504

--- Comment #12 from Cor Nouws c...@nouenoff.nl ---
Created attachment 108560
  -- https://bugs.freedesktop.org/attachment.cgi?id=108560action=edit
picture with to be changed button and the one to stay

Hi Jay, *

 I think this is the best choice, as users in coming from calc are used to
 clicking the same background color icon to fill the cell.

Yes, that's by far best. Add since change paragraph background is still on the
standard toolbar, people can choose.
I would suggest another icon too when changing the behaviour..

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85415] STYLES: Easy access to create new styles from style drop down

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85415

--- Comment #9 from Jay Philips philip...@hotmail.com ---
Hi Cor,

(In reply to Cor Nouws from comment #7)
 Hi Jay,
 
 I'm afraid it leads to confusion since for A there is no visual link with
 the  style that will be the basis for the action.

Well i guess the easiest solution is that A is for creating a new style always
based on Default. I'm assuming most users not heavily into style will choose
this option over opening any of the submenus.

 Even if this New would be added in the Style dropdown, still not all
 functions available in window F11 would be available. So IMHO either only
 version B, or none at all in the Style dropdown

Well we are not trying to duplicate all the functions available in the F11
window, just the most basic ones suitable for the drop down, which a user
shouldnt have to go into the F11 window to access.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85548] New: slow FILESAVE and slow to exit from editing large chart; only when name for data series spans more than one cell (ie Name In Range)

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85548

Bug ID: 85548
   Summary: slow FILESAVE and slow to exit from editing large
chart; only when name for data series spans more than
one cell (ie Name In Range)
   Product: LibreOffice
   Version: 4.2.6.3 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Spreadsheet
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j...@compsci.corklab.com

Created attachment 108561
  -- https://bugs.freedesktop.org/attachment.cgi?id=108561action=edit
Testfile showing slowdown (~3000 point xy-dataset with chart)

Hello,
Given a LibreOffice CALC spreadsheet with ~3000 x-y data points in columns
(attached):
I create a chart (xy scatter) of the dataset, 
and when I edit the range pointed to for the name of the Data Series (Name In
Range =...) such that this range now spans more than one cell (eg
$Sheet1.$D$3:$E$3) then suddenly...
 the time taken for saving the file and
 the time taken for exiting from the chart editor mode (after trivial change)
... both suddenly jump from a few(handful) seconds previously, to a painful
30sec for the absolute simplest(!) spreadsheet or 60sec for any real-world
analytical sheet.

This did not used to happen with LO CALC 4.1.6, which I used up to now; but it
did occur when I tried some 4.2 version a few months ago(I'm afraid I don't
know the exact version I was trying out at the time --- I reverted to 4.1.6 so
as to continue working)

[NB operating performance is otherwise perfectly acceptable so far with
4.2.6.3; Win7 32bit; dualcore 2GHz; 2GB RAM]

## Testfile illustrating the slowdown is attached:
SlowdownWhenSeriesNameSpans2Cells.ods ##

In the attachment, there are data in columns B and C, an xy-scatter plot of
these and a name for the data series in two cells at D3:E3 == PrefixSpec
Sample Spec.
If a trivial modification is made to the chart (eg resize slightly; edit text
of axis-title; etc) then exiting the chart edit mode takes ~30 seconds for me.
Saving any changes to the file, also takes ~30 seconds.

The inordinate slowdown is removed by editing the chart, such that the name of
the data series is pointed to just one cell eg E3 == SampleSpec...
ieDoubleClick chart  Data Ranges  Data Series  Select 'Name'  Range
For Name  click button to 'select data range', select cell E3  OK.

Regards, John.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85046] MENU: Edit Changes should be renamed for better clarity

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85046

Adolfo Jayme f...@libreoffice.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC|libreoffice-ux-advise@lists |
   |.freedesktop.org|
  Component|ux-advise   |UI
 Resolution|--- |FIXED
 Whiteboard||target:4.4.0

--- Comment #11 from Adolfo Jayme f...@libreoffice.org ---
http://cgit.freedesktop.org/libreoffice/core/commit/?id=d61c55b4d11f4a4ffdf4fb75ba2e950de8ae2beb

Now it’d be cool to have the help repository updated as well...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 72487] EDITING: sorting columns

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72487

--- Comment #15 from Luke lukebe...@hotmail.com ---
Created attachment 108562
  -- https://bugs.freedesktop.org/attachment.cgi?id=108562action=edit
testsort1.ods Sorted in Google Sheets and Excel

testsort1.ods and testsort2 do not follow long established spreadsheet
conventions. Giving a #REF error is not a bug as you can see by my attachment.
To get the desired behavior, spreadsheets should have been created with
absolute references. This report should have been marked invalid a long time
ago.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85524] OSX - CRASH sigabrt when opening presentation in Impress containing video clips

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85524

--- Comment #5 from Alex Thurgood ipla...@yahoo.co.uk ---
Test file here

https://www.dropbox.com/s/kx5cvemji9ei755/testvidinsert.odp?dl=0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85524] OSX - CRASH sigabrt when opening presentation in Impress containing video clips

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85524

--- Comment #6 from Alex Thurgood ipla...@yahoo.co.uk ---
Created attachment 108563
  -- https://bugs.freedesktop.org/attachment.cgi?id=108563action=edit
another full bt

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85415] STYLES: Easy access to create new styles from style drop down

2014-10-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85415

--- Comment #10 from Cor Nouws c...@nouenoff.nl ---
Hi Jay,

(In reply to Jay Philips from comment #9)
 (In reply to Cor Nouws from comment #7)
  I'm afraid it leads to confusion since for A there is no visual link with
  the  style that will be the basis for the action.
 
 Well i guess the easiest solution is that A is for creating a new style
 always based on Default. I'm assuming most users not heavily into style will
 choose this option over opening any of the submenus.

I'm not happy at all with such a change that would add a behaviour that is not
supported by the visual situation and that is different from the behaviour as
is in the window Styles and Formatting.

  Even if this New would be added in the Style dropdown, still not all
  functions available in window F11 would be available. So IMHO either only
  version B, or none at all in the Style dropdown
 
 Well we are not trying to duplicate all the functions available in the F11

I know.

 window, just the most basic ones suitable for the drop down, which a user
 shouldnt have to go into the F11 window to access.

If the need to bring New to the dropdown is strong enough then definitely in
position B.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   >