[Libreoffice-commits] core.git: Branch 'feature/rendercontext' - 2 commits - vcl/source
vcl/source/window/dockingarea.cxx | 90 +-
vcl/source/window/dockmgr.cxx | 131 +++---
2 files changed, 111 insertions(+), 110 deletions(-)
New commits:
commit 6ea7a051b699ea8d1afa6a4f61d966454942f67b
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Thu May 7 15:18:41 2015 +0900
refactor PopupFloatWin to use RenderContext
Change-Id: Ib3f74c89c9a930deb0c153bf456f9c84095e237e
diff --git a/vcl/source/window/dockmgr.cxx b/vcl/source/window/dockmgr.cxx
index 7d0f826..15b0e0c 100644
--- a/vcl/source/window/dockmgr.cxx
+++ b/vcl/source/window/dockmgr.cxx
@@ -487,7 +487,7 @@ public:
virtual void dispose() SAL_OVERRIDE;
virtual ::com::sun::star::uno::Reference
::com::sun::star::accessibility::XAccessible CreateAccessible() SAL_OVERRIDE;
-virtual voidPaint( vcl::RenderContext /*rRenderContext*/, const
Rectangle rRect ) SAL_OVERRIDE;
+virtual voidPaint(vcl::RenderContext rRenderContext, const
Rectangle rRect) SAL_OVERRIDE;
virtual voidMouseMove( const MouseEvent rMEvt ) SAL_OVERRIDE;
virtual voidMouseButtonDown( const MouseEvent rMEvt )
SAL_OVERRIDE;
virtual voidMouseButtonUp( const MouseEvent rMEvt ) SAL_OVERRIDE;
@@ -498,8 +498,8 @@ public:
Rectangle GetDragRect() const;
Point GetToolboxPosition() const;
Point GetTearOffPosition() const;
-voidDrawGrip();
-voidDrawBorder();
+voidDrawGrip(vcl::RenderContext rRenderContext);
+voidDrawBorder(vcl::RenderContext rRenderContext);
boolhasGrip() const { return mbHasGrip; }
};
@@ -600,9 +600,9 @@ Point ImplPopupFloatWin::GetTearOffPosition() const
return aPt;
}
-void ImplPopupFloatWin::DrawBorder()
+void ImplPopupFloatWin::DrawBorder(vcl::RenderContext rRenderContext)
{
-SetFillColor();
+rRenderContext.SetFillColor();
Point aPt;
Rectangle aRect( aPt, GetOutputSizePixel() );
@@ -614,113 +614,114 @@ void ImplPopupFloatWin::DrawBorder()
aItemClipRect.SetPos( AbsoluteScreenToOutputPixel(
aItemClipRect.TopLeft() ) );
// draw the excluded border part with the background color of a toolbox
-SetClipRegion( vcl::Region( aItemClipRect ) );
-SetLineColor( GetSettings().GetStyleSettings().GetFaceColor() );
-DrawRect( aRect );
+rRenderContext.SetClipRegion( vcl::Region( aItemClipRect ) );
+rRenderContext.SetLineColor(
GetSettings().GetStyleSettings().GetFaceColor() );
+rRenderContext.DrawRect( aRect );
aClipRgn.Exclude( aItemClipRect );
SetClipRegion( aClipRgn );
}
-SetLineColor( GetSettings().GetStyleSettings().GetShadowColor() );
-DrawRect( aRect );
-SetClipRegion( oldClipRgn );
+rRenderContext.SetLineColor(
rRenderContext.GetSettings().GetStyleSettings().GetShadowColor() );
+rRenderContext.DrawRect( aRect );
+rRenderContext.SetClipRegion( oldClipRgn );
}
-void ImplPopupFloatWin::DrawGrip()
+void ImplPopupFloatWin::DrawGrip(vcl::RenderContext rRenderContext)
{
-bool bLinecolor = IsLineColor();
-Color aLinecolor= GetLineColor();
-bool bFillcolor = IsFillColor();
-Color aFillcolor= GetFillColor();
+bool bLinecolor = rRenderContext.IsLineColor();
+Color aLinecolor= rRenderContext.GetLineColor();
+bool bFillcolor = rRenderContext.IsFillColor();
+Color aFillcolor= rRenderContext.GetFillColor();
// draw background
-Rectangle aRect( GetDragRect() );
-aRect.Top() += POPUP_DRAGBORDER;
-aRect.Bottom() -= POPUP_DRAGBORDER;
-aRect.Left()+=3;
-aRect.Right()-=3;
+Rectangle aRect(GetDragRect());
+aRect.Top() += POPUP_DRAGBORDER;
+aRect.Bottom() -= POPUP_DRAGBORDER;
+aRect.Left() += 3;
+aRect.Right() -= 3;
-if( mbHighlight )
+if (mbHighlight)
{
-Erase( aRect );
-DrawSelectionBackground( aRect, 2, false, true, false );
+rRenderContext.Erase(aRect);
+DrawSelectionBackground(aRect, 2, false, true, false);
}
else
{
-SetFillColor( GetSettings().GetStyleSettings().GetFaceColor() );
-SetLineColor();
-DrawRect( aRect );
+
rRenderContext.SetFillColor(rRenderContext.GetSettings().GetStyleSettings().GetFaceColor());
+rRenderContext.SetLineColor();
+rRenderContext.DrawRect(aRect);
}
-if( !ToolBox::AlwaysLocked() ) // no grip if toolboxes are locked
+if (!ToolBox::AlwaysLocked()) // no grip if toolboxes are locked
{
#ifdef TEAROFF_DASHED
// draw single dashed line
-LineInfo aLineInfo( LINE_DASH );
-aLineInfo.SetDistance( 4 );
-aLineInfo.SetDashLen( 12 );
-aLineInfo.SetDashCount( 1 );
+LineInfo aLineInfo(LINE_DASH);
+
[Libreoffice-bugs] [Bug 91108] No visible Cursor during placing of Draw-elements (incl. form-elements)
https://bugs.documentfoundation.org/show_bug.cgi?id=91108 --- Comment #2 from Thomas Krumbein t...@mic-consulting.de --- Hey raal, Yes, my version is: Version: 5.0.0.0.alpha1 (x64) Build-ID: f0853d5c2c38b050fbfd48e09cd0bf0b400aaef8 Gebietsschema: de_DE So, I checked it again with a 32bit Build on a different computer (Win Vista) - with version 5.0.0.0.alpha1 and can confirm it again. No visible Cursor when selecting a drawing-tool and want to place it. Happend in all modules: Steps to reproduce: - Open a new Document (writr, calc, draw ... no matter). - activat draw-functions (toolbar) - select one tool (line , square, eclipse ... no matter) - move mouse cursor inside document - he disappear. No visible feedback. No Idea where you start your grafic -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/unotools
include/unotools/fontcfg.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit fbd85c25ba90b8db461555d735ab8b13f52d01ee
Author: Noel Grandin n...@peralex.com
Date: Thu May 7 09:01:09 2015 +0200
fix for older gcc
include/o3tl/typed_flags_set.hxx: In instantiation of
'o3tl::is_typed_flagsImplFontAttrs, -0x1':
include/unotools/fontcfg.hxx:88:94: instantiated from here
include/o3tl/typed_flags_set.hxx:66:5: error: static assertion failed:
is_typed_flags expects only non-negative bit values
Change-Id: Ica7873bef3fd664370a96d8066d63c473ff6798f
diff --git a/include/unotools/fontcfg.hxx b/include/unotools/fontcfg.hxx
index c13e4a5..1fdd40f 100644
--- a/include/unotools/fontcfg.hxx
+++ b/include/unotools/fontcfg.hxx
@@ -85,7 +85,7 @@ enum class ImplFontAttrs : sal_uLong
};
namespace o3tl
{
-template struct typed_flagsImplFontAttrs :
is_typed_flagsImplFontAttrs, 0x {};
+template struct typed_flagsImplFontAttrs :
is_typed_flagsImplFontAttrs, 0xUL {};
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91064] FILESAVE: Docx Corrupted on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91064 --- Comment #3 from Radu ioan.rad...@gmail.com --- Luke please add an empty document saved as docx from Office 2013. Thank you! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl svtools/source svx/source vcl/source vcl/unx
include/vcl/bitmap.hxx | 17 -
include/vcl/bitmapex.hxx |2 +-
svtools/source/graphic/grfmgr2.cxx |2 +-
svx/source/xoutdev/_xoutbmp.cxx|2 +-
vcl/source/gdi/bitmap3.cxx |8
vcl/source/gdi/bitmapex.cxx|2 +-
vcl/unx/generic/dtrans/bmp.cxx |2 +-
7 files changed, 21 insertions(+), 14 deletions(-)
New commits:
commit efecaf03adff75aa88be7862eb2c4f1261df5e60
Author: Noel Grandin n...@peralex.com
Date: Wed May 6 10:52:59 2015 +0200
convert BMP_DITHER flags to scoped enum
Change-Id: I652faacf39a32fc8803147819ec9366948ff12b9
Reviewed-on: https://gerrit.libreoffice.org/15646
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index 5e75b69..8ee2c87 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -59,10 +59,17 @@ enum class BmpScaleFlag
};
-#define BMP_DITHER_NONE 0xUL
-#define BMP_DITHER_MATRIX 0x0001UL
-#define BMP_DITHER_FLOYD0x0002UL
-#define BMP_DITHER_FLOYD_16 0x0004UL
+enum class BmpDitherFlags
+{
+NONE = 0x,
+Matrix = 0x0001,
+Floyd= 0x0002,
+Floyd16 = 0x0004,
+};
+namespace o3tl
+{
+template struct typed_flagsBmpDitherFlags :
is_typed_flagsBmpDitherFlags, 0x07 {};
+}
#define BMP_VECTORIZE_INNER 0x0001UL
#define BMP_VECTORIZE_OUTER 0x0002UL
@@ -417,7 +424,7 @@ public:
@param nDitherFlags
The algorithm to be used for dithering
*/
-boolDither( sal_uLong nDitherFlags = BMP_DITHER_MATRIX
);
+boolDither( BmpDitherFlags nDitherFlags =
BmpDitherFlags::Matrix );
/** Crop the bitmap
diff --git a/include/vcl/bitmapex.hxx b/include/vcl/bitmapex.hxx
index 13afdcd..096e2a0 100644
--- a/include/vcl/bitmapex.hxx
+++ b/include/vcl/bitmapex.hxx
@@ -132,7 +132,7 @@ public:
@param nDitherFlags
The algorithm to be used for dithering
*/
-boolDither( sal_uLong nDitherFlags = BMP_DITHER_MATRIX );
+boolDither( BmpDitherFlags nDitherFlags =
BmpDitherFlags::Matrix );
/** Crop the bitmap
diff --git a/svtools/source/graphic/grfmgr2.cxx
b/svtools/source/graphic/grfmgr2.cxx
index 202528d..9022bdc 100644
--- a/svtools/source/graphic/grfmgr2.cxx
+++ b/svtools/source/graphic/grfmgr2.cxx
@@ -1002,7 +1002,7 @@ bool GraphicManager::ImplCreateOutput( OutputDevice*
pOutputDevice,
// OutDev adjustment if necessary
if( pOutputDevice-GetOutDevType() != OUTDEV_PRINTER
pOutputDevice-GetBitCount() = 8 aOutBmpEx.GetBitCount() = 8 )
-aOutBmpEx.Dither( BMP_DITHER_MATRIX );
+aOutBmpEx.Dither( BmpDitherFlags::Matrix );
}
}
diff --git a/svx/source/xoutdev/_xoutbmp.cxx b/svx/source/xoutdev/_xoutbmp.cxx
index 6a47748..758e324 100644
--- a/svx/source/xoutdev/_xoutbmp.cxx
+++ b/svx/source/xoutdev/_xoutbmp.cxx
@@ -619,7 +619,7 @@ bool DitherBitmap( Bitmap rBitmap )
bool bRet = false;
if( ( rBitmap.GetBitCount() = 8 ) (
Application::GetDefaultDevice()-GetColorCount() 257 ) )
-bRet = rBitmap.Dither( BMP_DITHER_FLOYD );
+bRet = rBitmap.Dither( BmpDitherFlags::Floyd );
else
bRet = false;
diff --git a/vcl/source/gdi/bitmap3.cxx b/vcl/source/gdi/bitmap3.cxx
index 3ad2c18..4ed1aab 100644
--- a/vcl/source/gdi/bitmap3.cxx
+++ b/vcl/source/gdi/bitmap3.cxx
@@ -1668,7 +1668,7 @@ bool Bitmap::ImplScaleConvolution(
return bResult;
}
-bool Bitmap::Dither( sal_uLong nDitherFlags )
+bool Bitmap::Dither( BmpDitherFlags nDitherFlags )
{
bool bRet = false;
@@ -1676,11 +1676,11 @@ bool Bitmap::Dither( sal_uLong nDitherFlags )
if( aSizePix.Width() == 1 || aSizePix.Height() == 1 )
bRet = true;
-else if( nDitherFlags BMP_DITHER_MATRIX )
+else if( nDitherFlags BmpDitherFlags::Matrix )
bRet = ImplDitherMatrix();
-else if( nDitherFlags BMP_DITHER_FLOYD )
+else if( nDitherFlags BmpDitherFlags::Floyd )
bRet = ImplDitherFloyd();
-else if( ( nDitherFlags BMP_DITHER_FLOYD_16 ) ( GetBitCount() == 24 )
)
+else if( ( nDitherFlags BmpDitherFlags::Floyd16 ) ( GetBitCount() ==
24 ) )
bRet = ImplDitherFloyd16();
return bRet;
diff --git a/vcl/source/gdi/bitmapex.cxx b/vcl/source/gdi/bitmapex.cxx
index 537c7dc..e6fa951 100644
--- a/vcl/source/gdi/bitmapex.cxx
+++ b/vcl/source/gdi/bitmapex.cxx
@@ -625,7 +625,7 @@ bool BitmapEx::Erase( const Color rFillColor )
return bRet;
}
-bool BitmapEx::Dither( sal_uLong nDitherFlags )
+bool BitmapEx::Dither( BmpDitherFlags nDitherFlags )
{
return !!aBitmap aBitmap.Dither( nDitherFlags );
}
diff --git a/vcl/unx/generic/dtrans/bmp.cxx
[Libreoffice-bugs] [Bug 90956] LO crashes 100% of attempts to Export as PDF from file menu
https://bugs.documentfoundation.org/show_bug.cgi?id=90956 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Michael Meeks michael.me...@collabora.com --- fixed locally - will push in a sec. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Renaming in sw/
Hi, I mentioned at the ESC that I'd like to do some larger renaming in sw/, and got an action item to send the list first; so here it is. I did not mean to change namespace (eg. do not want to change SwFrm to sw::Frame) as that would make it harder to grep (and could potentially cause larger problems), but mostly meant to insert vowels into the names to make the reading easier [and writing too, actually - try to type Cntnt :-)]. I mention only the class names in the examples, but I'd like to do it wholesale - so even in the variable or function names: Frm - Frame (to handle things like SwFrm, SwCellFrm, SwRowFrm, SwColumnFrm, ..., SwFrmFmt, FrmMap, SwFlyFrm, etc.) Fmt - Format (to handle those SwFrmFmt, SvxSwAutoFmtFlags, SwTxtCharFmt, SwFmtFillOrder, SwFmtFrmSize, SwFmtCntnt, ...) Cntnt - Content (to handle SwCntntNode, SwCntntFrm, SwCntntNode, etc.) Txt - Text (to handle SwTxtNode, SwTxtFrm, SwTxtAttr, SwTxtFld, SwNoTxtNode, etc.) Fld - Field (to handle SwFldTypes, SwDocUpdtFld, SwTxtFld, SwFmtFld, etc.) Ftn - Footnote (to handle SwFtnContFrm, SwFtnFrm, SwFtnPortion, SwFtnContFrm, etc.) Updt - Update (SwDocUpdtFld, TableFmlUpdtFlags, SwDocUpdtFld, Fml - Formula (SwTableFmlUpdate, TableFmlUpdtFlags) Hnt - Hint (mostly in variable names) That's it for now - comments appreciated! I deliberately leave out eg. Cnt (usually Count, but could be Content by mistake), or PaM (as PointAndMark would be too long - but I think it would deserve some better name too). Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 91052] cleanup makeWindow constructors ...
https://bugs.documentfoundation.org/show_bug.cgi?id=91052 --- Comment #2 from Caolán McNamara caol...@redhat.com --- could also remove all the makeFOO stuff and pass a factory helper to the builder from the dialog ctors so if you use custom widgets in a dialog/builder the caller has to send in a thing that knows how to make the custom widgets -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - include/sfx2 include/svx sfx2/source svx/source vcl/source
include/sfx2/tbxctrl.hxx|3 +--
include/svx/layctrl.hxx |2 --
sfx2/source/toolbox/tbxitem.cxx | 11 +--
svx/source/tbxctrls/layctrl.cxx | 23 ---
vcl/source/control/combobox.cxx | 29 -
vcl/source/window/floatwin.cxx |1 +
6 files changed, 19 insertions(+), 50 deletions(-)
New commits:
commit 35fa267341be9d5d22a41e2aad1f1da462543783
Author: Michael Meeks michael.me...@collabora.com
Date: Wed May 6 21:04:31 2015 +0100
tdf#90956 - ComboBox: handle re-size calculation during dispose.
Change-Id: I3d6e421a10b0d6b0edb85c0a6454315198bfd22f
diff --git a/vcl/source/control/combobox.cxx b/vcl/source/control/combobox.cxx
index 7c12bbc..b55f1cb 100644
--- a/vcl/source/control/combobox.cxx
+++ b/vcl/source/control/combobox.cxx
@@ -559,20 +559,23 @@ void ComboBox::Resize()
{
Control::Resize();
-Size aOutSz = GetOutputSizePixel();
-if( IsDropDownBox() )
+if (mpSubEdit)
{
-ComboBoxBounds aBounds(calcComboBoxDropDownComponentBounds(aOutSz,
-GetWindow(WINDOW_BORDER)-GetOutputSizePixel()));
-mpSubEdit-SetPosSizePixel(aBounds.aSubEditPos, aBounds.aSubEditSize);
-mpBtn-SetPosSizePixel(aBounds.aButtonPos, aBounds.aButtonSize);
-}
-else
-{
-mpSubEdit-SetSizePixel( Size( aOutSz.Width(), mnDDHeight ) );
-mpImplLB-setPosSizePixel( 0, mnDDHeight, aOutSz.Width(),
aOutSz.Height() - mnDDHeight );
-if ( !GetText().isEmpty() )
-ImplUpdateFloatSelection();
+Size aOutSz = GetOutputSizePixel();
+if( IsDropDownBox() )
+{
+ComboBoxBounds aBounds(calcComboBoxDropDownComponentBounds(aOutSz,
+GetWindow(WINDOW_BORDER)-GetOutputSizePixel()));
+mpSubEdit-SetPosSizePixel(aBounds.aSubEditPos,
aBounds.aSubEditSize);
+mpBtn-SetPosSizePixel(aBounds.aButtonPos, aBounds.aButtonSize);
+}
+else
+{
+mpSubEdit-SetSizePixel( Size( aOutSz.Width(), mnDDHeight ) );
+mpImplLB-setPosSizePixel( 0, mnDDHeight, aOutSz.Width(),
aOutSz.Height() - mnDDHeight );
+if ( !GetText().isEmpty() )
+ImplUpdateFloatSelection();
+}
}
// adjust the size of the FloatingWindow even when invisible
commit 207b0799d9b5b7029ccde23787f55e6efc2df2aa
Author: Michael Meeks michael.me...@collabora.com
Date: Wed May 6 20:43:06 2015 +0100
tdf#91073 - keep the popup pointer around while we operate on it.
Change-Id: I33767036847aed3d5c7ee4a7d13e81590e46b65b
diff --git a/sfx2/source/toolbox/tbxitem.cxx b/sfx2/source/toolbox/tbxitem.cxx
index d30b026..5119f608 100644
--- a/sfx2/source/toolbox/tbxitem.cxx
+++ b/sfx2/source/toolbox/tbxitem.cxx
@@ -622,7 +622,7 @@ void SAL_CALL SfxToolBoxControl::doubleClick() throw
(::com::sun::star::uno::Run
Reference ::com::sun::star::awt::XWindow SAL_CALL
SfxToolBoxControl::createPopupWindow() throw
(::com::sun::star::uno::RuntimeException, std::exception)
{
SolarMutexGuard aGuard;
-vcl::Window* pWindow = CreatePopupWindow();
+VclPtrvcl::Window pWindow = CreatePopupWindow();
if ( pWindow )
return VCLUnoHelper::GetInterface( pWindow );
else
diff --git a/vcl/source/window/floatwin.cxx b/vcl/source/window/floatwin.cxx
index 0d6ef0d..f7892c5 100644
--- a/vcl/source/window/floatwin.cxx
+++ b/vcl/source/window/floatwin.cxx
@@ -186,6 +186,7 @@ void FloatingWindow::doDeferredInit(WinBits nBits)
FloatingWindow::~FloatingWindow()
{
disposeOnce();
+assert (!mnPostId);
}
void FloatingWindow::dispose()
commit ca0bf47a14fc57c0c38915ad4a5a0ebfa0219295
Author: Michael Meeks michael.me...@collabora.com
Date: Wed May 6 15:34:21 2015 +0100
Remove unused CreatePopupWindowCascading virtual methods.
Change-Id: I44125b9909c0d81abd84c9666d44225e99c94c54
diff --git a/include/sfx2/tbxctrl.hxx b/include/sfx2/tbxctrl.hxx
index d39337c..11da16c 100644
--- a/include/sfx2/tbxctrl.hxx
+++ b/include/sfx2/tbxctrl.hxx
@@ -198,8 +198,7 @@ protected:
virtual void DoubleClick();
virtual void Click();
virtual SfxPopupWindowType GetPopupWindowType() const;
-virtual VclPtrSfxPopupWindowCreatePopupWindow();
-virtual SfxPopupWindow*CreatePopupWindowCascading();
+virtual VclPtrSfxPopupWindow CreatePopupWindow();
virtual VclPtrvcl::Window CreateItemWindow( vcl::Window *pParent );
// Must be called by subclass to set a new popup window instance
diff --git a/include/svx/layctrl.hxx b/include/svx/layctrl.hxx
index 05eaf5d..ec62655 100644
--- a/include/svx/layctrl.hxx
+++ b/include/svx/layctrl.hxx
@@ -32,7 +32,6 @@ private:
public:
virtual SfxPopupWindowType GetPopupWindowType() const SAL_OVERRIDE;
virtual VclPtrSfxPopupWindow CreatePopupWindow() SAL_OVERRIDE;
-virtual SfxPopupWindow* CreatePopupWindowCascading() SAL_OVERRIDE;
virtual void
[Libreoffice-bugs] [Bug 91073] Crash on insert table split button
https://bugs.documentfoundation.org/show_bug.cgi?id=91073 --- Comment #10 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Meeks committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=207b0799d9b5b7029ccde23787f55e6efc2df2aa tdf#91073 - keep the popup pointer around while we operate on it. It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90956] LO crashes 100% of attempts to Export as PDF from file menu
https://bugs.documentfoundation.org/show_bug.cgi?id=90956 --- Comment #9 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Meeks committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=35fa267341be9d5d22a41e2aad1f1da462543783 tdf#90956 - ComboBox: handle re-size calculation during dispose. It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91127] Crash on closing the Field dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=91127 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Keywords||regression Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Michael Meeks michael.me...@collabora.com --- Thanks - taking ... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91127] New: Crash on closing the Field dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=91127 Bug ID: 91127 Summary: Crash on closing the Field dialog Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vmik...@collabora.co.uk Backtrace: Program received signal SIGSEGV, Segmentation fault. 0x709ed7dd in vcl::Window::dispose (this=0x2154ea0) at /home/vmiklos/git/libreoffice/master/vcl/source/window/window.cxx:554 554 if ( mpWindowImpl-mbFrame ) (gdb) print mpWindowImpl $1 = (WindowImpl *) 0x (gdb) up #1 0x70a55c36 in Control::dispose (this=0x2154ea0) at /home/vmiklos/git/libreoffice/master/vcl/source/control/ctrl.cxx:76 76 Window::dispose(); (gdb) #2 0x72bb82c2 in SvTreeListBox::dispose (this=0x2154ea0) at /home/vmiklos/git/libreoffice/master/svtools/source/contnr/treelistbox.cxx:1584 1584Control::dispose(); (gdb) up #3 0x7fffd5b2c791 in SwDBTreeList::dispose (this=0x2154ea0) at /home/vmiklos/git/libreoffice/master/sw/source/uibase/dbui/dbtree.cxx:205 205 SvTreeListBox::dispose(); (gdb) #4 0x70b2f62c in OutputDevice::disposeOnce (this=0x2154ea0) at /home/vmiklos/git/libreoffice/master/vcl/source/outdev/outdev.cxx:203 203 dispose(); (gdb) #5 0x708aa77e in VclPtrvcl::Window::disposeAndClear (this=0x2154cb8) at /home/vmiklos/git/libreoffice/master/include/vcl/vclptr.hxx:209 209 aTmp-disposeOnce(); (gdb) #6 0x7088d51f in VclBuilder::disposeBuilder (this=0x20f7c90) at /home/vmiklos/git/libreoffice/master/vcl/source/window/builder.cxx:536 536 aI-m_pWindow.disposeAndClear(); (gdb) bt #0 0x709ed7dd in vcl::Window::dispose (this=0x2154ea0) at /home/vmiklos/git/libreoffice/master/vcl/source/window/window.cxx:554 #1 0x70a55c36 in Control::dispose (this=0x2154ea0) at /home/vmiklos/git/libreoffice/master/vcl/source/control/ctrl.cxx:76 #2 0x72bb82c2 in SvTreeListBox::dispose (this=0x2154ea0) at /home/vmiklos/git/libreoffice/master/svtools/source/contnr/treelistbox.cxx:1584 #3 0x7fffd5b2c791 in SwDBTreeList::dispose (this=0x2154ea0) at /home/vmiklos/git/libreoffice/master/sw/source/uibase/dbui/dbtree.cxx:205 #4 0x70b2f62c in OutputDevice::disposeOnce (this=0x2154ea0) at /home/vmiklos/git/libreoffice/master/vcl/source/outdev/outdev.cxx:203 #5 0x708aa77e in VclPtrvcl::Window::disposeAndClear (this=0x2154cb8) at /home/vmiklos/git/libreoffice/master/include/vcl/vclptr.hxx:209 #6 0x7088d51f in VclBuilder::disposeBuilder (this=0x20f7c90) at /home/vmiklos/git/libreoffice/master/vcl/source/window/builder.cxx:536 #7 0x708e540d in VclBuilderContainer::disposeBuilder (this=0x20f8b10) at /home/vmiklos/git/libreoffice/master/vcl/source/window/dialog.cxx:462 #8 0x709a46f0 in TabPage::dispose (this=0x20f88f0) at /home/vmiklos/git/libreoffice/master/vcl/source/window/tabpage.cxx:95 #9 0x73c63ca1 in SfxTabPage::dispose (this=0x20f88f0) at /home/vmiklos/git/libreoffice/master/sfx2/source/dialog/tabdlg.cxx:181 #10 0x7fffc4f6e572 in SwFldDBPage::dispose (this=0x20f88f0) at /home/vmiklos/git/libreoffice/master/sw/source/ui/fldui/flddb.cxx:94 #11 0x70b2f62c in OutputDevice::disposeOnce (this=0x20f88f0) at /home/vmiklos/git/libreoffice/master/vcl/source/outdev/outdev.cxx:203 #12 0x73bcdaaa in VclPtrSfxTabPage::disposeAndClear (this=0x2013908) at /home/vmiklos/git/libreoffice/master/include/vcl/vclptr.hxx:209 #13 0x73c64a31 in SfxTabDialog::dispose (this=0x2013320) at /home/vmiklos/git/libreoffice/master/sfx2/source/dialog/tabdlg.cxx:401 #14 0x70b2f62c in OutputDevice::disposeOnce (this=0x2013320) at /home/vmiklos/git/libreoffice/master/vcl/source/outdev/outdev.cxx:203 #15 0x73a90d5a in VclPtrvcl::Window::disposeAndClear (this=0x20107e8) at /home/vmiklos/git/libreoffice/master/include/vcl/vclptr.hxx:209 #16 0x73a8cf67 in SfxChildWindow::~SfxChildWindow (this=0x20107d0, __in_chrg=optimized out) at /home/vmiklos/git/libreoffice/master/sfx2/source/appl/childwin.cxx:201 #17 0x7fffd591ef62 in SwChildWinWrapper::~SwChildWinWrapper (this=0x20107d0, __in_chrg=optimized out) at /home/vmiklos/git/libreoffice/master/sw/source/uibase/inc/chldwrap.hxx:27 #18 0x7fffd591f02a in SwFldDlgWrapper::~SwFldDlgWrapper (this=0x20107d0, __in_chrg=optimized out) at /home/vmiklos/git/libreoffice/master/sw/source/uibase/inc/fldwrap.hxx:25 #19 0x7fffd591f05a in SwFldDlgWrapper::~SwFldDlgWrapper (this=0x20107d0, __in_chrg=optimized out) at /home/vmiklos/git/libreoffice/master/sw/source/uibase/inc/fldwrap.hxx:25 Sounds like vcl::Window::dispose() is called twice. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/vclwidgets.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 8d7791858ae09dc6185bf0b116a66c7580040b09
Author: Tor Lillqvist t...@collabora.com
Date: Thu May 7 11:44:15 2015 +0300
It's its, not it's
Change-Id: Ic108625cdc8376095dfd19184ecad39bfeccd160
diff --git a/compilerplugins/clang/vclwidgets.cxx
b/compilerplugins/clang/vclwidgets.cxx
index e7066c2..ff55832 100644
--- a/compilerplugins/clang/vclwidgets.cxx
+++ b/compilerplugins/clang/vclwidgets.cxx
@@ -206,7 +206,7 @@ bool VCLWidgets::VisitCXXDestructorDecl(const
CXXDestructorDecl* pCXXDestructorD
{
report(
DiagnosticsEngine::Warning,
-OutputDevice subclass should have nothing in it's destructor
but a call to disposeOnce().,
+OutputDevice subclass should have nothing in its destructor
but a call to disposeOnce().,
pCXXDestructorDecl-getLocStart())
pCXXDestructorDecl-getSourceRange();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/floatwin.cxx |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit 8c1bba83384e835e7207fe8338f149ea8d77c3a9
Author: Tor Lillqvist t...@collabora.com
Date: Thu May 7 11:56:54 2015 +0300
WaE: OutputDevice subclass should have nothing in its destructor but ...
Change-Id: I9b48a2c9d878ef449fc9c04228eff9deb03b0718
diff --git a/vcl/source/window/floatwin.cxx b/vcl/source/window/floatwin.cxx
index f7892c5..d2a7a90 100644
--- a/vcl/source/window/floatwin.cxx
+++ b/vcl/source/window/floatwin.cxx
@@ -186,7 +186,11 @@ void FloatingWindow::doDeferredInit(WinBits nBits)
FloatingWindow::~FloatingWindow()
{
disposeOnce();
-assert (!mnPostId);
+
+// Unfortunately the vclwidgets clang plug-in says: OutputDevice
+// subclass should have nothing in its destructor but a call to
+// disposeOnce().
+// assert (!mnPostId);
}
void FloatingWindow::dispose()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88895] Rotated text in table expands cell instead of flowing down
https://bugs.documentfoundation.org/show_bug.cgi?id=88895 Timur gti...@gmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=38 ||066 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38066] FILEOPEN .docx: rotated multiline text in table cell wrong FORMATTING, displayed in single line
https://bugs.documentfoundation.org/show_bug.cgi?id=38066 Timur gti...@gmail.com changed: What|Removed |Added CC||gti...@gmail.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=88 ||895 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Renaming in sw/
Hi Tor, Tor Lillqvist píše v Čt 07. 05. 2015 v 12:04 +0300: While at it, could we also come up with a new term for the fly concept (and its plural, flys) please? I hate flies. How about floater, if floating is what a fly does? Sounds good to me too - any objections from Bjoern / Caolán / Michael S. / Miklos / anybody? And also I remembered one more: Crsr - Cursor (as in SwCrsrShell, SwShellCrsr, SwUnoCrsr, etc.) [and SwCrsrShell vs. SwShellCrsr looks annoying too - I guess SwCrsrShell would deserve a better name overall]. Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 80225] FILESAVE: Weird characters appear before text when saving as .PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=80225 --- Comment #5 from Yogesh Bharate yogesh.bhar...@synerzip.com --- Created attachment 115401 -- https://bugs.documentfoundation.org/attachment.cgi?id=115401action=edit PPTX file open in LibreOffice again. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - sfx2/source vcl/source
sfx2/source/dialog/infobar.cxx |8 ++--
vcl/source/window/winproc.cxx |5 -
2 files changed, 10 insertions(+), 3 deletions(-)
New commits:
commit 3faf9c4a2a5d2f761dc83b942199f55cdbd5f054
Author: Philippe Jung phil.j...@free.fr
Date: Thu May 7 10:15:46 2015 +0200
Fix a crash in SfxInfoBarWindow
Fix a crash that occurs when a locked doc is opened. Ask to open it
read-only, then click on Edit the document in the info bar. Used to
crash.
Change-Id: Ic6e53853345e9e8431cae0eb2408ab0624d92cce
diff --git a/sfx2/source/dialog/infobar.cxx b/sfx2/source/dialog/infobar.cxx
index ff91cc6..3c2c197 100644
--- a/sfx2/source/dialog/infobar.cxx
+++ b/sfx2/source/dialog/infobar.cxx
@@ -283,17 +283,21 @@ SfxInfoBarWindow*
SfxInfoBarContainerWindow::getInfoBar(const OUString sId)
void SfxInfoBarContainerWindow::removeInfoBar(SfxInfoBarWindow* pInfoBar)
{
+// Store a VclPtr to the pInfoBar while we remove it from m_pInfoBars
+ScopedVclPtrSfxInfoBarWindow pTmp(pInfoBar);
+
+// Remove
for (auto it = m_pInfoBars.begin(); it != m_pInfoBars.end(); ++it)
{
if (pInfoBar == it-get())
{
+it-disposeAndClear();
m_pInfoBars.erase(it);
break;
}
}
-if (pInfoBar)
-pInfoBar-disposeOnce();
+// Resize
long nY = 0;
for (auto it = m_pInfoBars.begin(); it != m_pInfoBars.end(); ++it)
{
commit cc444e083c59ffcd73520faf55a28f55cfcb0068
Author: Michael Meeks michael.me...@collabora.com
Date: Thu May 7 11:08:24 2015 +0100
Hold a reference on the Window while emitting events from vcl backends.
Change-Id: I4673dc03c214ca8f5c227a444e182a45f6199b9b
diff --git a/vcl/source/window/winproc.cxx b/vcl/source/window/winproc.cxx
index 6cccd18..30db414 100644
--- a/vcl/source/window/winproc.cxx
+++ b/vcl/source/window/winproc.cxx
@@ -2377,11 +2377,14 @@ static void ImplHandleSalQueryCharPosition( vcl::Window
*pWindow,
}
}
-bool ImplWindowFrameProc( vcl::Window* pWindow, SalFrame* /*pFrame*/,
+bool ImplWindowFrameProc( vcl::Window* _pWindow, SalFrame* /*pFrame*/,
sal_uInt16 nEvent, const void* pEvent )
{
DBG_TESTSOLARMUTEX();
+// Ensure the window survives during this method.
+VclPtrvcl::Window pWindow( _pWindow );
+
bool nRet = false;
// #119709# for some unknown reason it is possible to receive events (in
this case key events)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/qa
vcl/qa/cppunit/graphicfilter/filters-test.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 93d004c544c17521eebfa6e6850dca4b532e904a Author: David Tardon dtar...@redhat.com Date: Thu May 7 08:27:23 2015 +0200 WaE: format â%dâ expects argument of type âintâ Change-Id: I1697f563d21c02551088ea1469eb973a6cfc5a10 diff --git a/vcl/qa/cppunit/graphicfilter/filters-test.cxx b/vcl/qa/cppunit/graphicfilter/filters-test.cxx index 9e5f798..86dafa4 100644 --- a/vcl/qa/cppunit/graphicfilter/filters-test.cxx +++ b/vcl/qa/cppunit/graphicfilter/filters-test.cxx @@ -67,7 +67,7 @@ void VclFiltersTest::testScaling() Bitmap aBitmap( Size( 413, 409 ), 24 ); BitmapEx aBitmapEx( aBitmap ); -fprintf( stderr, scale with type %d\n, i ); +fprintf( stderr, scale with type %d\n, int( i ) ); CPPUNIT_ASSERT( aBitmapEx.Scale( 0.1937046, 0.193154, i ) ); Size aAfter( aBitmapEx.GetSizePixel() ); fprintf( stderr, size %ld, %ld\n, (long)aAfter.Width(), ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/wrtw8sty.cxx | 38 +++---
sw/source/filter/ww8/wrtww8.hxx |8
2 files changed, 23 insertions(+), 23 deletions(-)
New commits:
commit a7530de8e6b41255ca884d40f63773fbe5642b35
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Thu May 7 09:09:34 2015 +0200
sw: prefix members of MSWordStyles
Change-Id: I9cd8474c658643d1f6044ecf6c56efdd42530979
diff --git a/sw/source/filter/ww8/wrtw8sty.cxx
b/sw/source/filter/ww8/wrtw8sty.cxx
index f2de751..1c80c2f 100644
--- a/sw/source/filter/ww8/wrtw8sty.cxx
+++ b/sw/source/filter/ww8/wrtw8sty.cxx
@@ -152,8 +152,8 @@ MSWordStyles::MSWordStyles( MSWordExportBase rExport, bool
bListStyles )
(bListStyles ?
m_rExport.m_pDoc-GetNumRuleTbl().size() - 1 : 0);
// somewhat generous ( free for up to 15 )
-pFmtA = new SwFmt*[ nAlloc ];
-memset( pFmtA, 0, nAlloc * sizeof( SwFmt* ) );
+m_pFmtA = new SwFmt*[ nAlloc ];
+memset( m_pFmtA, 0, nAlloc * sizeof( SwFmt* ) );
BuildStylesTable();
BuildStyleIds();
@@ -161,15 +161,15 @@ MSWordStyles::MSWordStyles( MSWordExportBase rExport,
bool bListStyles )
MSWordStyles::~MSWordStyles()
{
-delete[] pFmtA;
+delete[] m_pFmtA;
}
// Sty_SetWWSlot() dependencies for the styles - zero is allowed
sal_uInt16 MSWordStyles::GetSlot( const SwFmt* pFmt ) const
{
sal_uInt16 n;
-for ( n = 0; n nUsedSlots; n++ )
-if ( pFmtA[n] == pFmt )
+for ( n = 0; n m_nUsedSlots; n++ )
+if ( m_pFmtA[n] == pFmt )
return n;
return 0xfff; // 0xfff: WW: zero
}
@@ -196,7 +196,7 @@ sal_uInt16 MSWordStyles::BuildGetSlot( const SwFmt rFmt )
break;
default:
-nRet = nUsedSlots++;
+nRet = m_nUsedSlots++;
break;
}
return nRet;
@@ -274,14 +274,14 @@ sal_uInt16 MSWordStyles::GetWWId( const SwFmt rFmt )
void MSWordStyles::BuildStylesTable()
{
-nUsedSlots = WW8_RESERVED_SLOTS;// soviele sind reserviert fuer
+m_nUsedSlots = WW8_RESERVED_SLOTS;// soviele sind reserviert fuer
// Standard und HeadingX u.a.
const SwCharFmts rArr = *m_rExport.m_pDoc-GetCharFmts(); // first
CharFmt
// das Default-ZeichenStyle ( 0 ) wird nicht mit ausgegeben !
for( sal_uInt16 n = 1; n rArr.size(); n++ )
{
SwCharFmt* pFmt = rArr[n];
-pFmtA[ BuildGetSlot( *pFmt ) ] = pFmt;
+m_pFmtA[ BuildGetSlot( *pFmt ) ] = pFmt;
}
const SwTxtFmtColls rArr2 = *m_rExport.m_pDoc-GetTxtFmtColls(); //
then TxtFmtColls
@@ -289,7 +289,7 @@ void MSWordStyles::BuildStylesTable()
for( sal_uInt16 n = 1; n rArr2.size(); n++ )
{
SwTxtFmtColl* pFmt = rArr2[n];
-pFmtA[ BuildGetSlot( *pFmt ) ] = pFmt;
+m_pFmtA[ BuildGetSlot( *pFmt ) ] = pFmt;
}
if (!m_bListStyles)
@@ -313,11 +313,11 @@ void MSWordStyles::BuildStyleIds()
m_aStyleIds.push_back(Normal);
aUsed.insert(normal);
-for (sal_uInt16 n = 1; n nUsedSlots; ++n)
+for (sal_uInt16 n = 1; n m_nUsedSlots; ++n)
{
OUString aName;
-if(pFmtA[n])
-aName = pFmtA[n]-GetName();
+if(m_pFmtA[n])
+aName = m_pFmtA[n]-GetName();
else if (m_aNumRules.find(n) != m_aNumRules.end())
aName = m_aNumRules[n]-GetName();
OStringBuffer aStyleIdBuf(aName.getLength());
@@ -623,9 +623,9 @@ void MSWordStyles::OutputStyle( SwFmt* pFmt, sal_uInt16
nPos )
// Check if we still have a clash, in which case we add a suffix
for ( int nSuffix = 0; ; ++nSuffix ) {
bool clash=false;
-for ( sal_uInt16 n = 1; n nUsedSlots; ++n )
-if ( pFmtA[n]
- pFmtA[n]-GetName().equalsIgnoreAsciiCase(aName) )
+for ( sal_uInt16 n = 1; n m_nUsedSlots; ++n )
+if ( m_pFmtA[n]
+ m_pFmtA[n]-GetName().equalsIgnoreAsciiCase(aName) )
{
clash = true;
break;
@@ -704,17 +704,17 @@ void MSWordStyles::OutputStylesTable()
// so simply if there are more styles, don't export those
// Implementing check for all exports DOCX, DOC, RTF
sal_uInt16 nLimit = MSWORD_MAX_STYLES_LIMIT;
-nUsedSlots = (nLimit nUsedSlots)? nUsedSlots : nLimit;
+m_nUsedSlots = (nLimit m_nUsedSlots)? m_nUsedSlots : nLimit;
-for ( n = 0; n nUsedSlots; n++ )
+for ( n = 0; n m_nUsedSlots; n++ )
{
if (m_aNumRules.find(n) != m_aNumRules.end())
OutputStyle(m_aNumRules[n], n);
else
-OutputStyle( pFmtA[n], n );
+OutputStyle( m_pFmtA[n], n );
}
-m_rExport.AttrOutput().EndStyles( nUsedSlots );
+m_rExport.AttrOutput().EndStyles( m_nUsedSlots );
[Libreoffice-commits] core.git: unotools/source
unotools/source/config/configitem.cxx |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
New commits:
commit 498e25e14bfeac30c00e5f6204fa8103270c96a5
Author: Noel Grandin n...@peralex.com
Date: Thu May 7 09:50:19 2015 +0200
fix for CONFIG_MODE constant - enum conversion
in my commit b35828ba7dc33af81d17c8c870ec981d18a57b08
convert CONFIG_MODE constants to scoped enum
Change-Id: Iafb6b1643920eb066a2d50150f408161331f9d04
diff --git a/unotools/source/config/configitem.cxx
b/unotools/source/config/configitem.cxx
index 2e32a0e..0d055ec 100644
--- a/unotools/source/config/configitem.cxx
+++ b/unotools/source/config/configitem.cxx
@@ -532,11 +532,10 @@ void ConfigItem::DisableNotification()
RemoveChangesListener();
}
-boolConfigItem::EnableNotification(const Sequence OUString rNames,
-bool bEnableInternalNotification )
-
+bool ConfigItem::EnableNotification(const Sequence OUString rNames,
+bool bEnableInternalNotification )
{
-OSL_ENSURE(bool(m_nMode ConfigItemMode::ReleaseTree), notification in
ConfigItemMode::ReleaseTree mode not possible);
+OSL_ENSURE(!(m_nMode ConfigItemMode::ReleaseTree), notification in
ConfigItemMode::ReleaseTree mode not possible);
m_bEnableInternalNotification = bEnableInternalNotification;
ReferenceXHierarchicalNameAccess xHierarchyAccess = GetTree();
ReferenceXChangesNotifier xChgNot(xHierarchyAccess, UNO_QUERY);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91095] crash exporting the given docx to docbook
https://bugs.documentfoundation.org/show_bug.cgi?id=91095 --- Comment #5 from Laurent Godard lgodard.li...@laposte.net --- a unit test is available on gerrit https://gerrit.libreoffice.org/#/c/15653/1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91057] CRASH- Writer crashes when typing ß character at beginning of a word
https://bugs.documentfoundation.org/show_bug.cgi?id=91057 --- Comment #10 from Caolán McNamara caol...@redhat.com --- in Transliteration_body::transliterateChar2Char we are throwing MultipleCharsOutputException when there is more than one option for uppercase. This probably started causing trouble for us with 5.1 (icu51) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl sd/source vcl/source
include/vcl/bitmap.hxx | 19 +--
sd/source/ui/dlg/vectdlg.cxx |2 +-
vcl/source/gdi/bitmap3.cxx |4 ++--
vcl/source/gdi/impvect.cxx | 14 +++---
vcl/source/gdi/impvect.hxx |4 ++--
vcl/source/outdev/text.cxx |2 +-
6 files changed, 26 insertions(+), 19 deletions(-)
New commits:
commit 220c9fc2e9fa8c83a1851e3f73682d8300f6dff1
Author: Noel Grandin n...@peralex.com
Date: Wed May 6 11:45:37 2015 +0200
convert BMP_VECTORIZE constants to scoped enum
Change-Id: Ifa6614f6a17356481a335a686e9ea0f9b983c5c5
Reviewed-on: https://gerrit.libreoffice.org/15647
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index 8ee2c87..a9f2146 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -71,10 +71,17 @@ namespace o3tl
template struct typed_flagsBmpDitherFlags :
is_typed_flagsBmpDitherFlags, 0x07 {};
}
-#define BMP_VECTORIZE_INNER 0x0001UL
-#define BMP_VECTORIZE_OUTER 0x0002UL
-#define BMP_VECTORIZE_BOUND_ONLY0x0004UL
-#define BMP_VECTORIZE_REDUCE_EDGES 0x0008UL
+enum class BmpVectorizeFlags
+{
+Inner = 0x0001,
+Outer = 0x0002,
+BoundOnly = 0x0004,
+ReduceEdges = 0x0008,
+};
+namespace o3tl
+{
+template struct typed_flagsBmpVectorizeFlags :
is_typed_flagsBmpVectorizeFlags, 0x0f {};
+}
#define BMP_COL_TRANS Color( 252, 3, 251 )
@@ -721,7 +728,7 @@ public:
*/
boolVectorize(
tools::PolyPolygon rPolyPoly,
-sal_uLong nFlags = BMP_VECTORIZE_OUTER,
+BmpVectorizeFlags nFlags =
BmpVectorizeFlags::Outer,
const Link* pProgress = NULL );
/** Convert the bitmap to a meta file
@@ -748,7 +755,7 @@ public:
boolVectorize(
GDIMetaFile rMtf,
sal_uInt8 cReduce = 0,
-sal_uLong nFlags = BMP_VECTORIZE_INNER,
+BmpVectorizeFlags nFlags =
BmpVectorizeFlags::Inner,
const Link* pProgress = NULL );
/** Change various global color characteristics
diff --git a/sd/source/ui/dlg/vectdlg.cxx b/sd/source/ui/dlg/vectdlg.cxx
index 99271d2..1865ac5 100644
--- a/sd/source/ui/dlg/vectdlg.cxx
+++ b/sd/source/ui/dlg/vectdlg.cxx
@@ -159,7 +159,7 @@ void SdVectorizeDlg::Calculate( Bitmap rBmp, GDIMetaFile
rMtf )
if( !!aTmp )
{
const Link aPrgsHdl( LINK( this, SdVectorizeDlg, ProgressHdl ) );
-aTmp.Vectorize( rMtf, (sal_uInt8) m_pMtReduce-GetValue(),
BMP_VECTORIZE_OUTER | BMP_VECTORIZE_REDUCE_EDGES, aPrgsHdl );
+aTmp.Vectorize( rMtf, (sal_uInt8) m_pMtReduce-GetValue(),
BmpVectorizeFlags::Outer | BmpVectorizeFlags::ReduceEdges, aPrgsHdl );
if( m_pCbFillHoles-IsChecked() )
{
diff --git a/vcl/source/gdi/bitmap3.cxx b/vcl/source/gdi/bitmap3.cxx
index 4ed1aab..9a656d6 100644
--- a/vcl/source/gdi/bitmap3.cxx
+++ b/vcl/source/gdi/bitmap3.cxx
@@ -2445,12 +2445,12 @@ void Bitmap::ImplMedianCut( sal_uLong* pColBuf,
BitmapPalette rPal,
}
}
-bool Bitmap::Vectorize( tools::PolyPolygon rPolyPoly, sal_uLong nFlags, const
Link* pProgress )
+bool Bitmap::Vectorize( tools::PolyPolygon rPolyPoly, BmpVectorizeFlags
nFlags, const Link* pProgress )
{
return ImplVectorizer::ImplVectorize( *this, rPolyPoly, nFlags, pProgress
);
}
-bool Bitmap::Vectorize( GDIMetaFile rMtf, sal_uInt8 cReduce, sal_uLong
nFlags, const Link* pProgress )
+bool Bitmap::Vectorize( GDIMetaFile rMtf, sal_uInt8 cReduce,
BmpVectorizeFlags nFlags, const Link* pProgress )
{
return ImplVectorizer::ImplVectorize( *this, rMtf, cReduce, nFlags,
pProgress );
}
diff --git a/vcl/source/gdi/impvect.cxx b/vcl/source/gdi/impvect.cxx
index fb64021..166f0be 100644
--- a/vcl/source/gdi/impvect.cxx
+++ b/vcl/source/gdi/impvect.cxx
@@ -52,7 +52,7 @@ class ImplChain;
namespace ImplVectorizer
{
ImplVectMap* ImplExpand( BitmapReadAccess* pRAcc, const Color rColor );
-void ImplCalculate( ImplVectMap* pMap, tools::PolyPolygon rPolyPoly,
sal_uInt8 cReduce, sal_uLong nFlags );
+void ImplCalculate( ImplVectMap* pMap, tools::PolyPolygon rPolyPoly,
sal_uInt8 cReduce, BmpVectorizeFlags nFlags );
bool ImplGetChain( ImplVectMap* pMap, const Point rStartPt,
ImplChain rChain );
bool ImplIsUp( ImplVectMap* pMap, long nY, long nX );
void ImplLimitPolyPoly( tools::PolyPolygon rPolyPoly );
@@ -634,7 +634,7 @@ void ImplChain::ImplPostProcess( const ImplPointArray rArr
)
namespace ImplVectorizer {
bool ImplVectorize( const Bitmap rColorBmp, GDIMetaFile rMtf,
-sal_uInt8 cReduce, sal_uLong nFlags, const
Link*
[Libreoffice-bugs] [Bug 35913] EDITING - vertical horizontal text flip inconsistent and wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=35913 Timur gti...@gmail.com changed: What|Removed |Added Version|3.3.2 release |Inherited From OOo --- Comment #10 from Timur gti...@gmail.com --- Seems inherited from OO. There were changes in text position, but also with 5.0-dev, it's still inconsistent. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91099] comment not readable after pasting
https://bugs.documentfoundation.org/show_bug.cgi?id=91099 Paul pip@gmx.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Paul pip@gmx.com --- No problem, marking as duplicate. *** This bug has been marked as a duplicate of bug 88457 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88457] Copying and pasting text between comments makes text unreadable
https://bugs.documentfoundation.org/show_bug.cgi?id=88457 Paul pip@gmx.com changed: What|Removed |Added CC||georges.guar...@gmail.com --- Comment #8 from Paul pip@gmx.com --- *** Bug 91099 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91070] opposite result in conditioned format in Libreoff CALC
https://bugs.documentfoundation.org/show_bug.cgi?id=91070 --- Comment #8 from raal r...@post.cz --- Created attachment 115400 -- https://bugs.documentfoundation.org/attachment.cgi?id=115400action=edit test file xlsx -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang
compilerplugins/clang/vclwidgets.cxx | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
New commits:
commit 08967d36ba0da5bf85e52ff64f41732a12b37a2e
Author: Noel Grandin n...@peralex.com
Date: Thu May 7 11:18:25 2015 +0200
workaround for clang3.2 in vclwidgets clang plugin
Change-Id: I7ac67dd14d14a93fe163febe0f18df56dd613376
diff --git a/compilerplugins/clang/vclwidgets.cxx
b/compilerplugins/clang/vclwidgets.cxx
index 2e7d4eb..a09f8db 100644
--- a/compilerplugins/clang/vclwidgets.cxx
+++ b/compilerplugins/clang/vclwidgets.cxx
@@ -186,16 +186,25 @@ bool VCLWidgets::VisitCXXDestructorDecl(const
CXXDestructorDecl* pCXXDestructorD
}
// check that the destructor for a OutputDevice subclass does nothing
except call into the disposeOnce() method
bool ok = false;
-if (pCompoundStatement pCompoundStatement-size() == 1) {
-const CXXMemberCallExpr *pCallExpr =
dyn_castCXXMemberCallExpr(*pCompoundStatement-body_begin());
-if (pCallExpr) {
-if( const FunctionDecl* func = pCallExpr-getDirectCallee()) {
-if( func-getNumParams() == 0 func-getIdentifier() != NULL
- ( func-getName() == disposeOnce )) {
-ok = true;
+if (pCompoundStatement) {
+bool bFoundDisposeOnce = false;
+int nNumExtraStatements = 0;
+for(auto const * x : pCompoundStatement-body())
+{
+const CXXMemberCallExpr *pCallExpr =
dyn_castCXXMemberCallExpr(x);
+if (pCallExpr) {
+if( const FunctionDecl* func = pCallExpr-getDirectCallee()) {
+if( func-getNumParams() == 0 func-getIdentifier() !=
NULL
+ ( func-getName() == disposeOnce )) {
+bFoundDisposeOnce = true;
+}
}
}
+// checking for ParenExpr is a hacky way to ignore assert
statements in older versions of clang (i.e. = 3.2)
+if (!pCallExpr !dyn_castParenExpr(x))
+nNumExtraStatements++;
}
+ok = bFoundDisposeOnce nNumExtraStatements == 0;
}
if (!ok) {
SourceLocation spellingLocation =
compiler.getSourceManager().getSpellingLoc(
commit 4eeaaf84d4251d77a86155609e21f86add086f3f
Author: Noel Grandin n...@peralex.com
Date: Thu May 7 11:05:02 2015 +0200
fix comment
Change-Id: Ifa59bdc4bfd80fe3100ba5f1ac8119ad990e3936
diff --git a/compilerplugins/clang/vclwidgets.cxx
b/compilerplugins/clang/vclwidgets.cxx
index 77a8476..2e7d4eb 100644
--- a/compilerplugins/clang/vclwidgets.cxx
+++ b/compilerplugins/clang/vclwidgets.cxx
@@ -184,7 +184,7 @@ bool VCLWidgets::VisitCXXDestructorDecl(const
CXXDestructorDecl* pCXXDestructorD
pCXXDestructorDecl-getSourceRange();
return true;
}
-// check that the destructor for a OutputDevice subclass does nothing
except call into the dispose() method
+// check that the destructor for a OutputDevice subclass does nothing
except call into the disposeOnce() method
bool ok = false;
if (pCompoundStatement pCompoundStatement-size() == 1) {
const CXXMemberCallExpr *pCallExpr =
dyn_castCXXMemberCallExpr(*pCompoundStatement-body_begin());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91070] opposite result in conditioned format in Libreoff CALC
https://bugs.documentfoundation.org/show_bug.cgi?id=91070 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #9 from raal r...@post.cz --- I downloaded your file (it's xlsx). With LO 4.4.2 I see all styles. After save as xlsx and reopen, the file look the same as before. Please try with LO 4.4 and let us know if you still observe the problem. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91058] Show styles by means of subtle text background colours EDITING:
https://bugs.documentfoundation.org/show_bug.cgi?id=91058 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #8 from Cor Nouws c...@nouenoff.nl --- (In reply to Christopher R Lee from comment #7) Also, the styles for un-numbered headers are not obvious in LO if you don't recognise the character size. Different paragraph styles (including default) may look the same. Of course there are those cases :) Thanks for your further explanation Christopher. Set to New -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76434] FILESAVE: calc-spreadsheet gets destroyed randomly during save
https://bugs.documentfoundation.org/show_bug.cgi?id=76434 Beluga todven...@suomi24.fi changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #9 from Beluga todven...@suomi24.fi --- Ok, let's set to WORKSFORME as we don't know the commit that fixed it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: starmath/source
starmath/source/dialog.cxx |3 ---
1 file changed, 3 deletions(-)
New commits:
commit f72e77f4086e4c22072d5815c9a6cbebc323ba8e
Author: Caolán McNamara caol...@redhat.com
Date: Thu May 7 09:06:24 2015 +0100
drop unused debugging Color
Change-Id: I02fc8f71543e7fda48fbbce131abd172c8c03259
diff --git a/starmath/source/dialog.cxx b/starmath/source/dialog.cxx
index 80d3917..98f4513 100644
--- a/starmath/source/dialog.cxx
+++ b/starmath/source/dialog.cxx
@@ -2196,9 +2196,6 @@ void SmSymDefineDialog::dispose()
void SmSymDefineDialog::InitColor_Impl()
{
-#if OSL_DEBUG_LEVEL 1
-Color aBC( GetDisplayBackground().GetColor() );
-#endif
ColorData nBgCol = COL_WHITE,
nTxtCol = COL_BLACK;
bool bHighContrast =
GetSettings().GetStyleSettings().GetHighContrastMode();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90956] LO crashes 100% of attempts to Export as PDF from file menu
https://bugs.documentfoundation.org/show_bug.cgi?id=90956 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|bibisected |bibisected target:5.0.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl
include/vcl/window.hxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 12b0e654d1f508508921863c6f8b4eb2c65e6c1d
Author: Noel Grandin n...@peralex.com
Date: Thu May 7 10:54:28 2015 +0200
revert part of new clang plugin: rendercontext
committed in error
Change-Id: I768b9683dd4dd997b3728c53054043aea0e88040
diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index 687..3209906 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -705,6 +705,7 @@ public:
virtual voidPrePaint();
virtual voidPaint(vcl::RenderContext
rRenderContext, const Rectangle rRect);
virtual voidErase() SAL_OVERRIDE;
+virtual voidErase( const Rectangle rRect )
SAL_OVERRIDE { ::OutputDevice::Erase( rRect ); }
virtual voidDraw( ::OutputDevice* pDev, const
Point rPos, const Size rSize, sal_uLong nFlags );
virtual voidMove();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Renaming in sw/
While at it, could we also come up with a new term for the fly concept (and its plural, flys) please? I hate flies. How about floater, if floating is what a fly does? Or is being able to talk naturally about flys just one of the competences one has to acquire in order to call oneself a Certified LO Developer? (Plus talking about the office, of course.) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Renaming in sw/
Hi Norbert, Norbert Thiebaud píše v Čt 07. 05. 2015 v 04:39 -0500: What is the projected timeline ? before/after the branch-point to 5.0 ? ( I'm asking because of the impact on cherry-picking maintenance going forward) Before 5.0 branch-point was my plan - sometime on Monday probably [so that it is easy to fix tinderboxes etc.] if I get a 'go-ahead' on the today's ESC... All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 90382] Regression in libreoffice 4.3.6.1 on sending document by mail
https://bugs.documentfoundation.org/show_bug.cgi?id=90382 --- Comment #8 from Stephan Bergmann sberg...@redhat.com --- (In reply to bruno from comment #7) (In reply to Stephan Bergmann from comment #6) (In reply to bruno from comment #5) Your patch indeed is fixing my issue, when I improved it. I added comments to that gerrit link. no idea what your patch is diff -up ./shell/source/unix/misc/senddoc.sh.bco ./shell/source/unix/misc/senddoc.sh --- ./shell/source/unix/misc/senddoc.sh.bco2015-05-05 22:43:57.641568680 +0200 +++ ./shell/source/unix/misc/senddoc.sh 2015-05-05 22:44:06.696568259 +0200 @@ -77,6 +77,13 @@ shift fi +if [ $MAILER = ]; then +client=`gconftool-2 --get /desktop/gnome/url-handlers/mailto/command | cut -d ' ' -f 1` || +if [ `basename $client` = thunderbird ]; then +MAILER=$client +fi +fi + # autodetect mail client from executable name case `basename $MAILER | sed 's/-.*$//'` in Note that I have nothing to do with that patch, apart from saying that it is a wrong approach. 'If the mailclient value has not been specified, ie under Options: Internet - E-mail - E-mail program, E-mail program is empty.' My argument is that this should not normally happen on Linux. If the user does not explicitly specify the E-mail program option, it should automatically obtain a value (on GNOME, using the exact same gconf value that you're using in your patch). In our case we use KDE, and thunderbird is configured in the KDE panel as default mail client using the line /usr/bin/thunderbird -compse ... and there is no program specified manually in libreoffice options. Do you have the KDE backend libkdebe1lo.so installed as part of LO? That is not part of the libreoffice packages we have in our Mageia repository. (based on version 4.3.6 and 4.3.7 which are the latest stable for Mageia 4) If not, that explains why LO's E-mail program option is not automatically filled in. Do you think we're missing a package here to support this ? Yes, looks like a Mageia distro problem. For KDE, they should make available the LO artefacts generated when configuring --with-kde in the LO build. (So when you are on KDE, it is kind of structurally the wrong thing anyway to try and use GNOME's gconftool-2 to obtain a KDE setting's value.) Well, not my choice in fact, but that's what was called by senddoc so I debugged that. Now that I know we may miss one shared module, I'll also report on the mgeia side to see what we can do as well on our side. Note that senddoc does not call gconftool-2. Anyway I still think that the sciprt should be fix to handle full path names. I see nothing in the existing script that would need fixing? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48300] UI: Window doesn't take focus when opening an already open document
https://bugs.documentfoundation.org/show_bug.cgi?id=48300 --- Comment #22 from Nicolas R nico2...@yopmail.com --- And also present in 4.3.7 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/characterclassification/cclass_unicode.cxx | 56 -
1 file changed, 36 insertions(+), 20 deletions(-)
New commits:
commit d0a0da717682a0e57f733d75d9d0700cfb198823
Author: Caolán McNamara caol...@redhat.com
Date: Thu May 7 10:23:13 2015 +0100
Resolves: tdf#91057 transliterateChar2Char throws
MultipleCharsOutputException
for Ã, but toTitle only allows RuntimeException, which is our usual
awesomeness
Change-Id: Ib5618a55a369fa5cd1d323f657f0798776828386
diff --git a/i18npool/source/characterclassification/cclass_unicode.cxx
b/i18npool/source/characterclassification/cclass_unicode.cxx
index b65fd18..95a6c57 100644
--- a/i18npool/source/characterclassification/cclass_unicode.cxx
+++ b/i18npool/source/characterclassification/cclass_unicode.cxx
@@ -21,8 +21,10 @@
#include com/sun/star/i18n/UnicodeScript.hpp
#include com/sun/star/i18n/UnicodeType.hpp
#include com/sun/star/i18n/KCharacterType.hpp
+#include com/sun/star/lang/WrappedTargetRuntimeException.hpp
#include unicode/uchar.h
#include comphelper/string.hxx
+#include cppuhelper/exc_hlp.hxx
#include cppuhelper/supportsservice.hxx
#include breakiteratorImpl.hxx
@@ -79,27 +81,41 @@ cclass_Unicode::toLower( const OUString Text, sal_Int32
nPos, sal_Int32 nCount,
OUString SAL_CALL
cclass_Unicode::toTitle( const OUString Text, sal_Int32 nPos, sal_Int32
nCount, const Locale rLocale ) throw(RuntimeException, std::exception) {
-sal_Int32 len = Text.getLength();
-if (nPos = len)
-return OUString();
-if (nCount + nPos len)
-nCount = len - nPos;
-
-trans-setMappingType(MappingTypeToTitle, rLocale);
-rtl_uString* pStr = rtl_uString_alloc(nCount);
-sal_Unicode* out = pStr-buffer;
-BreakIteratorImpl brk(m_xContext);
-Boundary bdy = brk.getWordBoundary(Text, nPos, rLocale,
-WordType::ANYWORD_IGNOREWHITESPACES, sal_True);
-for (sal_Int32 i = nPos; i nCount + nPos; i++, out++) {
-if (i = bdy.endPos)
-bdy = brk.nextWord(Text, bdy.endPos, rLocale,
-WordType::ANYWORD_IGNOREWHITESPACES);
-*out = (i == bdy.startPos) ?
-trans-transliterateChar2Char(Text[i]) : Text[i];
+try
+{
+sal_Int32 len = Text.getLength();
+if (nPos = len)
+return OUString();
+if (nCount + nPos len)
+nCount = len - nPos;
+
+trans-setMappingType(MappingTypeToTitle, rLocale);
+rtl_uString* pStr = rtl_uString_alloc(nCount);
+sal_Unicode* out = pStr-buffer;
+BreakIteratorImpl brk(m_xContext);
+Boundary bdy = brk.getWordBoundary(Text, nPos, rLocale,
+WordType::ANYWORD_IGNOREWHITESPACES, sal_True);
+for (sal_Int32 i = nPos; i nCount + nPos; i++, out++) {
+if (i = bdy.endPos)
+bdy = brk.nextWord(Text, bdy.endPos, rLocale,
+WordType::ANYWORD_IGNOREWHITESPACES);
+*out = (i == bdy.startPos) ?
+trans-transliterateChar2Char(Text[i]) : Text[i];
+}
+*out = 0;
+return OUString( pStr, SAL_NO_ACQUIRE );
+}
+catch (const RuntimeException)
+{
+throw;
+}
+catch (const Exception e)
+{
+uno::Any a(cppu::getCaughtException());
+throw lang::WrappedTargetRuntimeException(
+wrapped Exception + e.Message,
+uno::Referenceuno::XInterface(), a);
}
-*out = 0;
-return OUString( pStr, SAL_NO_ACQUIRE );
}
sal_Int16 SAL_CALL
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91057] CRASH- Writer crashes when typing ß character at beginning of a word
https://bugs.documentfoundation.org/show_bug.cgi?id=91057 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.0.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74309] FORMATTING: Microsoft Office document is not rendering the same in Writer and in Word 2007
https://bugs.documentfoundation.org/show_bug.cgi?id=74309 --- Comment #3 from geoffroy+...@gramaize.eu --- Created attachment 115402 -- https://bugs.documentfoundation.org/attachment.cgi?id=115402action=edit LibreOffice 4.4.2.2 rendering -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74309] FORMATTING: Microsoft Office document is not rendering the same in Writer and in Word 2007
https://bugs.documentfoundation.org/show_bug.cgi?id=74309 --- Comment #4 from geoffroy+...@gramaize.eu --- Tested version: 4.4.2.2 Tested OS: Windows 7 and Windows 10 build 10041 The rendering is still incorrect (please check attachment), but the situation has improved since 4.2.0.4. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73359] Missing documentation for frame alignment
https://bugs.documentfoundation.org/show_bug.cgi?id=73359 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Beluga todven...@suomi24.fi --- I don't understand, why you think I should have written this report on your behalf, but let's set to NEW. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/view/drviews1.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit af9b1a8b2e7589d33168e5b252ee38d7c9821ab1 Author: Caolán McNamara caol...@redhat.com Date: Thu May 7 09:23:54 2015 +0100 VclPtr: one ref too many Change-Id: I84cf33c8e68c41223aaa12208a2845675bbbfd5a diff --git a/sd/source/ui/view/drviews1.cxx b/sd/source/ui/view/drviews1.cxx index b5674ce..9aa19da 100644 --- a/sd/source/ui/view/drviews1.cxx +++ b/sd/source/ui/view/drviews1.cxx @@ -494,8 +494,9 @@ SvxRuler* DrawViewShell::CreateHRuler (::sd::Window* pWin, bool bIsFirst) else aWBits = WB_HSCROLL | WB_3DLOOK | WB_BORDER; -pRuler = new Ruler (*this, GetParentWindow(), pWin, nFlags, +pRuler = VclPtrRuler::Create(*this, GetParentWindow(), pWin, nFlags, GetViewFrame()-GetBindings(), aWBits); + pRuler-SetSourceUnit(pWin-GetMapMode().GetMapUnit()); // Metric ... ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/vclwidgets.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 1275a450c10d581e453f0d822d9d77b5bdf07d68
Author: Tor Lillqvist t...@collabora.com
Date: Thu May 7 11:52:28 2015 +0300
More of the same
Change-Id: I2e735a3534a7f374a550d5072359aca70494a547
diff --git a/compilerplugins/clang/vclwidgets.cxx
b/compilerplugins/clang/vclwidgets.cxx
index ff55832..77a8476 100644
--- a/compilerplugins/clang/vclwidgets.cxx
+++ b/compilerplugins/clang/vclwidgets.cxx
@@ -179,7 +179,7 @@ bool VCLWidgets::VisitCXXDestructorDecl(const
CXXDestructorDecl* pCXXDestructorD
if (foundVclPtrField pCompoundStatement pCompoundStatement-size()
== 0) {
report(
DiagnosticsEngine::Warning,
-OutputDevice subclass with VclPtr field must call dispose() from
it's destructor.,
+OutputDevice subclass with VclPtr field must call dispose() from
its destructor.,
pCXXDestructorDecl-getLocStart())
pCXXDestructorDecl-getSourceRange();
return true;
@@ -378,7 +378,7 @@ bool VCLWidgets::VisitFunctionDecl( const FunctionDecl*
functionDecl )
if (!isDisposeCallingSuperclassDispose(pMethodDecl)) {
report(
DiagnosticsEngine::Warning,
-OutputDevice subclass dispose() method MUST call it's
superclass dispose() as the last thing it does,
+OutputDevice subclass dispose() method MUST call
dispose() of its superclass as the last thing it does,
functionDecl-getLocStart())
functionDecl-getSourceRange();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90956] LO crashes 100% of attempts to Export as PDF from file menu
https://bugs.documentfoundation.org/show_bug.cgi?id=90956 --- Comment #11 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Caolán McNamara committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbdd739d6e2024f57e692e646295644faf44af22 Related: tdf#90956 don't resize the border window when disposing It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/window2.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit bbdd739d6e2024f57e692e646295644faf44af22
Author: Caolán McNamara caol...@redhat.com
Date: Thu May 7 10:37:41 2015 +0100
Related: tdf#90956 don't resize the border window when disposing
Change-Id: Ia5a2108214369a82dfe5e886524fbf5e685bb9f9
diff --git a/vcl/source/window/window2.cxx b/vcl/source/window/window2.cxx
index c928516..9df9085 100644
--- a/vcl/source/window/window2.cxx
+++ b/vcl/source/window/window2.cxx
@@ -1466,7 +1466,7 @@ void Window::queue_resize(StateChangedType eReason)
}
}
-if (bSomeoneCares)
+if (bSomeoneCares !mpWindowImpl-mbInDispose)
{
//fdo#57090 force a resync of the borders of the borderwindow onto this
//window in case they have changed
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Renaming in sw/
On Thu, May 7, 2015 at 4:23 AM, Jan Holesovsky ke...@collabora.com wrote: Hi Tor, Tor Lillqvist píše v Čt 07. 05. 2015 v 12:04 +0300: While at it, could we also come up with a new term for the fly concept (and its plural, flys) please? I hate flies. How about floater, if floating is what a fly does? Sounds good to me too - any objections from Bjoern / Caolán / Michael S. / Miklos / anybody? What is the projected timeline ? before/after the branch-point to 5.0 ? ( I'm asking because of the impact on cherry-picking maintenance going forward) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/rendercontext' - vcl/source
vcl/source/window/brdwin.cxx | 318 +--
1 file changed, 160 insertions(+), 158 deletions(-)
New commits:
commit 383b46c93b83d7deb3f9046c37c2d14e57d2e0f1
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Thu May 7 15:26:25 2015 +0900
refactor BorderWindowView to use RenderContext
Change-Id: Ib2aeae77ab7a570c4113f9767515e4f5833040b2
diff --git a/vcl/source/window/brdwin.cxx b/vcl/source/window/brdwin.cxx
index 82aa0be..c843cd4 100644
--- a/vcl/source/window/brdwin.cxx
+++ b/vcl/source/window/brdwin.cxx
@@ -1182,26 +1182,27 @@ long ImplSmallBorderWindowView::CalcTitleWidth() const
return 0;
}
-void ImplSmallBorderWindowView::DrawWindow( sal_uInt16 nDrawFlags,
OutputDevice*, const Point* )
+void ImplSmallBorderWindowView::DrawWindow(sal_uInt16 nDrawFlags,
OutputDevice*, const Point* )
{
WindowBorderStyle nBorderStyle = mpBorderWindow-GetBorderStyle();
-if ( nBorderStyle WindowBorderStyle::NOBORDER )
+if (nBorderStyle WindowBorderStyle::NOBORDER)
return;
bool bNativeOK = false;
// for native widget drawing we must find out what
// control this border belongs to
-vcl::Window *pWin = NULL, *pCtrl = NULL;
-if( mpOutDev-GetOutDevType() == OUTDEV_WINDOW )
+vcl::Window* pWin = NULL;
+vcl::Window* pCtrl = NULL;
+if (mpOutDev-GetOutDevType() == OUTDEV_WINDOW)
pWin = static_castvcl::Window*(mpOutDev.get());
ControlType aCtrlType = 0;
ControlPart aCtrlPart = PART_ENTIRE_CONTROL;
std::unique_ptrImplControlValue xControlValue(new ImplControlValue());
-if( pWin (pCtrl = mpBorderWindow-GetWindow( WINDOW_CLIENT )) != NULL )
+if (pWin (pCtrl = mpBorderWindow-GetWindow(WINDOW_CLIENT)) != NULL)
{
xControlValue.reset(new EditBoxValue(pCtrl-GetTextHeight()));
-switch( pCtrl-GetType() )
+switch (pCtrl-GetType())
{
case WINDOW_MULTILINEEDIT:
aCtrlType = CTRL_MULTILINE_EDITBOX;
@@ -1216,7 +1217,7 @@ void ImplSmallBorderWindowView::DrawWindow( sal_uInt16
nDrawFlags, OutputDevice*
case WINDOW_NUMERICFIELD:
case WINDOW_SPINFIELD:
case WINDOW_CALCINPUTLINE:
-if( pCtrl-GetStyle() WB_SPIN )
+if (pCtrl-GetStyle() WB_SPIN)
aCtrlType = CTRL_SPINBOX;
else
aCtrlType = CTRL_EDITBOX;
@@ -1226,7 +1227,7 @@ void ImplSmallBorderWindowView::DrawWindow( sal_uInt16
nDrawFlags, OutputDevice*
case WINDOW_MULTILISTBOX:
case WINDOW_TREELISTBOX:
aCtrlType = CTRL_LISTBOX;
-if( pCtrl-GetStyle() WB_DROPDOWN )
+if (pCtrl-GetStyle() WB_DROPDOWN)
aCtrlPart = PART_ENTIRE_CONTROL;
else
aCtrlPart = PART_WINDOW;
@@ -1245,7 +1246,7 @@ void ImplSmallBorderWindowView::DrawWindow( sal_uInt16
nDrawFlags, OutputDevice*
case WINDOW_DATEBOX:
case WINDOW_TIMEBOX:
case WINDOW_LONGCURRENCYBOX:
-if( pCtrl-GetStyle() WB_DROPDOWN )
+if (pCtrl-GetStyle() WB_DROPDOWN)
{
aCtrlType = CTRL_COMBOBOX;
aCtrlPart = PART_ENTIRE_CONTROL;
@@ -1262,83 +1263,84 @@ void ImplSmallBorderWindowView::DrawWindow( sal_uInt16
nDrawFlags, OutputDevice*
}
}
-if ( aCtrlType pCtrl-IsNativeControlSupported(aCtrlType, aCtrlPart) )
+if (aCtrlType pCtrl-IsNativeControlSupported(aCtrlType, aCtrlPart))
{
-ControlState nState = ControlState::ENABLED;
+ControlState nState = ControlState::ENABLED;
-if ( !pWin-IsEnabled() )
+if (!pWin-IsEnabled())
nState = ~ControlState::ENABLED;
-if ( pWin-HasFocus() )
+if (pWin-HasFocus())
nState |= ControlState::FOCUSED;
-else if( mbNWFBorder )
+else if(mbNWFBorder)
{
// FIXME: this is currently only on OS X, see if other platforms
can profit
// FIXME: for OS X focus rings all controls need to support
GetNativeControlRegion
// for the dropdown style
-if( pCtrl-HasFocus() || pCtrl-HasChildPathFocus() )
+if (pCtrl-HasFocus() || pCtrl-HasChildPathFocus())
nState |= ControlState::FOCUSED;
}
bool bMouseOver = false;
-vcl::Window *pCtrlChild = pCtrl-GetWindow( WINDOW_FIRSTCHILD );
-while( pCtrlChild !(bMouseOver = pCtrlChild-IsMouseOver()) )
-pCtrlChild = pCtrlChild-GetWindow( WINDOW_NEXT );
+vcl::Window *pCtrlChild = pCtrl-GetWindow(WINDOW_FIRSTCHILD);
+while(pCtrlChild !(bMouseOver = pCtrlChild-IsMouseOver()))
+{
+pCtrlChild = pCtrlChild-GetWindow(WINDOW_NEXT);
+}
-if( bMouseOver )
+if (bMouseOver)
nState
[Libreoffice-bugs] [Bug 76434] FILESAVE: calc-spreadsheet gets destroyed randomly during save
https://bugs.documentfoundation.org/show_bug.cgi?id=76434 pfund_s...@gmx.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #8 from pfund_s...@gmx.de --- I tried again, this time using Libreoffice 4.4.2.2 (Linux, Build-ID: c4c7d32d0d49397cad38d62472b0bc8acff48dd6 Language environment; de_DE) and it seems that the problem does not ccour any more. Many thanks for your support, I'll keep supporting your project by another donation. :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
help with the LO bibliography as seen by the source code?
Hello guys, I'm trying to create some kind of a stopgap solution for the https://bugs.documentfoundation.org/show_bug.cgi?id=88697 The issue is bibliography entries in recent versions of LO are not exported correctly to word2003 (!) .DOC. I have 4.3.7.1 built from sources and I've succeeded in cludging something looking vaguely promising for the bibliography entries as such, at least for my specific case (well, for anybody who'd want to submit a manuscript in word2003 .DOC format). However, I'm now somewhat at a loss, how to proceed with the LO bibliography itself. I don't know anything about LO internals. How do I iterate over the .ODT bibliography? Thanks. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 48851] VIEWING: Random display corruption of headings in document [Summary in Comment #55]
https://bugs.documentfoundation.org/show_bug.cgi?id=48851 --- Comment #69 from Cor Nouws c...@nouenoff.nl --- (In reply to Jon Grossart from comment #68) Honestly, even though it's an odd bug, I do think it's a real bug, and not just something for me. Sorry, but I missed that up until now. And regarding the VM, it's still in the state waiting for a dev to have the interest to debug it or even tell me more to look at. The only debugging instruction for windows is for crashes, which this isn't. If you are interested to try yourself, please go to irc and start to bite the bullet. But if development is new to you, it's a huge one to swallow ;) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74899] EDITING: Paste content and move cells downwards changes a fixed reference
https://bugs.documentfoundation.org/show_bug.cgi?id=74899 --- Comment #4 from Seved Torstendahl sev...@gmail.com --- Now I have also checked with Open Office 3.2.0 that I had installed on another computer: yes the error was there. Apache Open Office 4.1.1 has the same problem. Gnumeric does not have this feature, (paste and move). Microsoft Office does not have this feature, (paste and move). Normally I use the latest version of LibreOffice with support for Swedish, which now is Version: 4.4.2.2 Build ID: 40m0(Build:2) Språkinställning: sv_SE Operating system Ubuntu 15.04 or Ubuntu 14.04 LTS (on another computer). Sometimes I use Windows Vista or Windows 8.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/rendercontext' - 454 commits - accessibility/inc accessibility/source android/Bootstrap android/experimental animations/source avmedia/inc avmedia/sourc
Rebased ref, commits from common ancestor:
commit 2da59aafde97fa509a0e91afce1eebb68a3779d9
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Thu May 7 15:26:25 2015 +0900
refactor BorderWindowView to use RenderContext
Change-Id: Ib2aeae77ab7a570c4113f9767515e4f5833040b2
diff --git a/vcl/source/window/brdwin.cxx b/vcl/source/window/brdwin.cxx
index b54914f..bc6b8ef 100644
--- a/vcl/source/window/brdwin.cxx
+++ b/vcl/source/window/brdwin.cxx
@@ -1182,26 +1182,27 @@ long ImplSmallBorderWindowView::CalcTitleWidth() const
return 0;
}
-void ImplSmallBorderWindowView::DrawWindow( sal_uInt16 nDrawFlags,
OutputDevice*, const Point* )
+void ImplSmallBorderWindowView::DrawWindow(sal_uInt16 nDrawFlags,
OutputDevice*, const Point* )
{
WindowBorderStyle nBorderStyle = mpBorderWindow-GetBorderStyle();
-if ( nBorderStyle WindowBorderStyle::NOBORDER )
+if (nBorderStyle WindowBorderStyle::NOBORDER)
return;
bool bNativeOK = false;
// for native widget drawing we must find out what
// control this border belongs to
-vcl::Window *pWin = NULL, *pCtrl = NULL;
-if( mpOutDev-GetOutDevType() == OUTDEV_WINDOW )
+vcl::Window* pWin = NULL;
+vcl::Window* pCtrl = NULL;
+if (mpOutDev-GetOutDevType() == OUTDEV_WINDOW)
pWin = static_castvcl::Window*(mpOutDev.get());
ControlType aCtrlType = 0;
ControlPart aCtrlPart = PART_ENTIRE_CONTROL;
std::unique_ptrImplControlValue xControlValue(new ImplControlValue());
-if( pWin (pCtrl = mpBorderWindow-GetWindow( WINDOW_CLIENT )) != NULL )
+if (pWin (pCtrl = mpBorderWindow-GetWindow(WINDOW_CLIENT)) != NULL)
{
xControlValue.reset(new EditBoxValue(pCtrl-GetTextHeight()));
-switch( pCtrl-GetType() )
+switch (pCtrl-GetType())
{
case WINDOW_MULTILINEEDIT:
aCtrlType = CTRL_MULTILINE_EDITBOX;
@@ -1216,7 +1217,7 @@ void ImplSmallBorderWindowView::DrawWindow( sal_uInt16
nDrawFlags, OutputDevice*
case WINDOW_NUMERICFIELD:
case WINDOW_SPINFIELD:
case WINDOW_CALCINPUTLINE:
-if( pCtrl-GetStyle() WB_SPIN )
+if (pCtrl-GetStyle() WB_SPIN)
aCtrlType = CTRL_SPINBOX;
else
aCtrlType = CTRL_EDITBOX;
@@ -1226,7 +1227,7 @@ void ImplSmallBorderWindowView::DrawWindow( sal_uInt16
nDrawFlags, OutputDevice*
case WINDOW_MULTILISTBOX:
case WINDOW_TREELISTBOX:
aCtrlType = CTRL_LISTBOX;
-if( pCtrl-GetStyle() WB_DROPDOWN )
+if (pCtrl-GetStyle() WB_DROPDOWN)
aCtrlPart = PART_ENTIRE_CONTROL;
else
aCtrlPart = PART_WINDOW;
@@ -1245,7 +1246,7 @@ void ImplSmallBorderWindowView::DrawWindow( sal_uInt16
nDrawFlags, OutputDevice*
case WINDOW_DATEBOX:
case WINDOW_TIMEBOX:
case WINDOW_LONGCURRENCYBOX:
-if( pCtrl-GetStyle() WB_DROPDOWN )
+if (pCtrl-GetStyle() WB_DROPDOWN)
{
aCtrlType = CTRL_COMBOBOX;
aCtrlPart = PART_ENTIRE_CONTROL;
@@ -1262,83 +1263,84 @@ void ImplSmallBorderWindowView::DrawWindow( sal_uInt16
nDrawFlags, OutputDevice*
}
}
-if ( aCtrlType pCtrl-IsNativeControlSupported(aCtrlType, aCtrlPart) )
+if (aCtrlType pCtrl-IsNativeControlSupported(aCtrlType, aCtrlPart))
{
-ControlState nState = ControlState::ENABLED;
+ControlState nState = ControlState::ENABLED;
-if ( !pWin-IsEnabled() )
+if (!pWin-IsEnabled())
nState = ~ControlState::ENABLED;
-if ( pWin-HasFocus() )
+if (pWin-HasFocus())
nState |= ControlState::FOCUSED;
-else if( mbNWFBorder )
+else if(mbNWFBorder)
{
// FIXME: this is currently only on OS X, see if other platforms
can profit
// FIXME: for OS X focus rings all controls need to support
GetNativeControlRegion
// for the dropdown style
-if( pCtrl-HasFocus() || pCtrl-HasChildPathFocus() )
+if (pCtrl-HasFocus() || pCtrl-HasChildPathFocus())
nState |= ControlState::FOCUSED;
}
bool bMouseOver = false;
-vcl::Window *pCtrlChild = pCtrl-GetWindow( WINDOW_FIRSTCHILD );
-while( pCtrlChild !(bMouseOver = pCtrlChild-IsMouseOver()) )
-pCtrlChild = pCtrlChild-GetWindow( WINDOW_NEXT );
+vcl::Window *pCtrlChild = pCtrl-GetWindow(WINDOW_FIRSTCHILD);
+while(pCtrlChild !(bMouseOver = pCtrlChild-IsMouseOver()))
+{
+pCtrlChild = pCtrlChild-GetWindow(WINDOW_NEXT);
+}
-if( bMouseOver )
+if (bMouseOver)
nState |= ControlState::ROLLOVER;
Point aPoint;
-Rectangle aCtrlRegion( aPoint, Size(
[Libreoffice-commits] core.git: compilerplugins/clang include/vcl vcl/source
compilerplugins/clang/rendercontext.cxx | 93
include/vcl/window.hxx |1
vcl/source/window/brdwin.cxx| 10 +--
3 files changed, 98 insertions(+), 6 deletions(-)
New commits:
commit 0825b020caa0d802a0d76d9a7643daedbf9874e6
Author: Noel Grandin n...@peralex.com
Date: Thu May 7 10:00:46 2015 +0200
new clang plugin: rendercontext
to help with converting calls to OutputDevice to pass via
vcl::RenderContext.
Change-Id: I4b49d2f5e4afca46898d2a7c7ed33cbf5577e664
diff --git a/compilerplugins/clang/rendercontext.cxx
b/compilerplugins/clang/rendercontext.cxx
new file mode 100644
index 000..a1e7018
--- /dev/null
+++ b/compilerplugins/clang/rendercontext.cxx
@@ -0,0 +1,93 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include string
+#include iostream
+
+#include plugin.hxx
+#include compat.hxx
+#include clang/AST/CXXInheritance.h
+
+// Check for calls to OutputDevice methods that are not passing through
RenderContext
+
+namespace {
+
+class RenderContext:
+public RecursiveASTVisitorRenderContext, public loplugin::Plugin
+{
+public:
+explicit RenderContext(InstantiationData const data): Plugin(data) {}
+
+virtual void run() override {
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
+
+bool TraverseFunctionDecl(const FunctionDecl * decl);
+
+bool VisitCXXMemberCallExpr(const CXXMemberCallExpr *);
+
+private:
+boolmbChecking = false;
+};
+
+bool RenderContext::TraverseFunctionDecl(const FunctionDecl * pFunctionDecl) {
+if (ignoreLocation(pFunctionDecl)) {
+return true;
+}
+if (!pFunctionDecl-hasBody()) {
+return true;
+}
+if ( pFunctionDecl != pFunctionDecl-getCanonicalDecl() ) {
+return true;
+}
+const CXXMethodDecl *pCXXMethodDecl =
dyn_castCXXMethodDecl(pFunctionDecl);
+if (pCXXMethodDecl) {
+std::string aParentName =
pCXXMethodDecl-getParent()-getQualifiedNameAsString();
+if (aParentName == OutputDevice)
+return true;
+}
+mbChecking = true;
+TraverseStmt(pFunctionDecl-getBody());
+mbChecking = false;
+return true;
+}
+
+bool RenderContext::VisitCXXMemberCallExpr(const CXXMemberCallExpr*
pCXXMemberCallExpr)
+{
+if (!mbChecking)
+return true;
+if (ignoreLocation(pCXXMemberCallExpr)) {
+return true;
+}
+const CXXRecordDecl *pCXXRecordDecl = pCXXMemberCallExpr-getRecordDecl();
+if (pCXXRecordDecl-getQualifiedNameAsString() != OutputDevice) {
+return true;
+}
+const ImplicitCastExpr *pImplicitCastExpr =
dyn_castImplicitCastExpr(pCXXMemberCallExpr-getImplicitObjectArgument());
+std::string t2 = 0;
+if (pImplicitCastExpr) {
+t2 = 2;
+QualType aType = pImplicitCastExpr-getSubExpr()-getType();
+if (aType-isPointerType())
+aType = aType-getPointeeType();
+t2 = aType.getAsString();
+if (t2 == vcl::RenderContext)
+return true;
+}
+report(
+DiagnosticsEngine::Warning,
+Should be calling OutputDevice method through RenderContext.,
+pCXXMemberCallExpr-getLocStart())
+ pCXXMemberCallExpr-getSourceRange();
+return true;
+}
+
+loplugin::Plugin::Registration RenderContext X(rendercontext, false);
+
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index 3209906..687 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -705,7 +705,6 @@ public:
virtual voidPrePaint();
virtual voidPaint(vcl::RenderContext
rRenderContext, const Rectangle rRect);
virtual voidErase() SAL_OVERRIDE;
-virtual voidErase( const Rectangle rRect )
SAL_OVERRIDE { ::OutputDevice::Erase( rRect ); }
virtual voidDraw( ::OutputDevice* pDev, const
Point rPos, const Size rSize, sal_uLong nFlags );
virtual voidMove();
diff --git a/vcl/source/window/brdwin.cxx b/vcl/source/window/brdwin.cxx
index bc6b8ef..1bf2ac8 100644
--- a/vcl/source/window/brdwin.cxx
+++ b/vcl/source/window/brdwin.cxx
@@ -99,7 +99,7 @@ void Window::ImplCalcSymbolRect( Rectangle rRect )
} /* namespace vcl */
-static void ImplDrawBrdWinSymbol( OutputDevice* pDev,
+static void ImplDrawBrdWinSymbol( vcl::RenderContext* pDev,
const Rectangle rRect, SymbolType eSymbol )
{
// we leave 5% room between the symbol and the button border
@@ -110,7 +110,7 @@ static void
[Libreoffice-bugs] [Bug 80225] FILESAVE: Weird characters appear before text when saving as .PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=80225 Yogesh Bharate yogesh.bhar...@synerzip.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Yogesh Bharate yogesh.bhar...@synerzip.com --- This issue fixed on master. Tomaž Vajngerl proposed changed related to bulletchar. Link : https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=3f1f2d71 build id: Version: 5.0.0.0.alpha1+ Build ID: 6e78bf76f3a10b43475e1bd801bdcbb9ce62f668 Locale: en-IN (en_IN) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/sot
include/sot/storage.hxx |1 -
1 file changed, 1 deletion(-)
New commits:
commit 65ab049bcfc60657bcd0f285b83851479fc8b619
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu May 7 11:33:32 2015 +0200
error: class 'SotStorage' is implicitly friends with itself
Change-Id: Id05657c866f872846676bb8d8c7ab009292569ab
diff --git a/include/sot/storage.hxx b/include/sot/storage.hxx
index 8c31ee2..0850bde 100644
--- a/include/sot/storage.hxx
+++ b/include/sot/storage.hxx
@@ -85,7 +85,6 @@ class UNOStorageHolder;
class SOT_DLLPUBLIC SotStorage : virtual public SotObject
{
friend class SotStorageStream;
-friend class SotStorage;
BaseStorage * m_pOwnStg; // target storage
SvStream * m_pStorStm; // only for SDSTORAGES
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 91030] Writer: Find and Find--Replace need character auto-replacement to support string searches and replacements
https://bugs.documentfoundation.org/show_bug.cgi?id=91030 --- Comment #2 from Heiko Tietze heiko.tie...@user-prompt.com --- I use the auto replacement frequently for -- which creates an arrow. I never would expect it to be available in the search by --. But with digraphs or strange characters we run into trouble. Is it possible at all to find such a text? If so we could offer a checkbox look for replacements or rather show those results in a different color. By the way: I hate the LO find and replace dialog. Not sure if its true for Writer but in Calc I replace A by 1 and B by 2 and so on and have always to dismiss the result dialog. And since only selection is hidden and unchecked by default I regularly do the task twice. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91030] Writer: Find and Find--Replace need character auto-replacement to support string searches and replacements
https://bugs.documentfoundation.org/show_bug.cgi?id=91030 --- Comment #2 from Heiko Tietze heiko.tie...@user-prompt.com --- I use the auto replacement frequently for -- which creates an arrow. I never would expect it to be available in the search by --. But with digraphs or strange characters we run into trouble. Is it possible at all to find such a text? If so we could offer a checkbox look for replacements or rather show those results in a different color. By the way: I hate the LO find and replace dialog. Not sure if its true for Writer but in Calc I replace A by 1 and B by 2 and so on and have always to dismiss the result dialog. And since only selection is hidden and unchecked by default I regularly do the task twice. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 19 commits - basctl/source cui/source include/vcl sw/source vcl/inc vcl/source
basctl/source/basicide/baside2b.cxx |6
cui/source/dialogs/hangulhanjadlg.cxx|4
include/vcl/button.hxx | 20
include/vcl/edit.hxx |4
include/vcl/menu.hxx |6
include/vcl/scrbar.hxx |4
include/vcl/slider.hxx |9
include/vcl/spin.h | 14
include/vcl/status.hxx | 22 -
include/vcl/tabctrl.hxx |6
include/vcl/textview.hxx | 17
include/vcl/toolbox.hxx | 38 +
sw/source/uibase/docvw/srcedtw.cxx |4
vcl/inc/ilstbox.hxx |4
vcl/source/app/help.cxx | 36 -
vcl/source/control/button.cxx| 525 ---
vcl/source/control/combobox.cxx |6
vcl/source/control/edit.cxx | 256 +--
vcl/source/control/fixed.cxx | 114 ++---
vcl/source/control/ilstbox.cxx | 191
vcl/source/control/imgctrl.cxx | 28 -
vcl/source/control/lstbox.cxx| 10
vcl/source/control/prgsbar.cxx | 32 -
vcl/source/control/scrbar.cxx| 255 +--
vcl/source/control/slider.cxx| 166 ---
vcl/source/control/spinbtn.cxx | 18
vcl/source/control/spinfld.cxx | 154 +++
vcl/source/control/tabctrl.cxx | 179
vcl/source/edit/texteng.cxx |5
vcl/source/edit/textview.cxx | 86 +--
vcl/source/edit/vclmedit.cxx |6
vcl/source/window/brdwin.cxx | 318 +++---
vcl/source/window/dockingarea.cxx| 90 ++--
vcl/source/window/dockmgr.cxx| 131 +++--
vcl/source/window/menu.cxx | 205 +++--
vcl/source/window/menubarwindow.cxx | 155 +++
vcl/source/window/menubarwindow.hxx |2
vcl/source/window/menufloatingwindow.cxx | 143 +++---
vcl/source/window/menufloatingwindow.hxx |4
vcl/source/window/status.cxx | 148 +++---
vcl/source/window/toolbox.cxx| 680 +++
vcl/source/window/toolbox2.cxx | 14
42 files changed, 2061 insertions(+), 2054 deletions(-)
New commits:
commit 2da59aafde97fa509a0e91afce1eebb68a3779d9
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Thu May 7 15:26:25 2015 +0900
refactor BorderWindowView to use RenderContext
Change-Id: Ib2aeae77ab7a570c4113f9767515e4f5833040b2
diff --git a/vcl/source/window/brdwin.cxx b/vcl/source/window/brdwin.cxx
index b54914f..bc6b8ef 100644
--- a/vcl/source/window/brdwin.cxx
+++ b/vcl/source/window/brdwin.cxx
@@ -1182,26 +1182,27 @@ long ImplSmallBorderWindowView::CalcTitleWidth() const
return 0;
}
-void ImplSmallBorderWindowView::DrawWindow( sal_uInt16 nDrawFlags,
OutputDevice*, const Point* )
+void ImplSmallBorderWindowView::DrawWindow(sal_uInt16 nDrawFlags,
OutputDevice*, const Point* )
{
WindowBorderStyle nBorderStyle = mpBorderWindow-GetBorderStyle();
-if ( nBorderStyle WindowBorderStyle::NOBORDER )
+if (nBorderStyle WindowBorderStyle::NOBORDER)
return;
bool bNativeOK = false;
// for native widget drawing we must find out what
// control this border belongs to
-vcl::Window *pWin = NULL, *pCtrl = NULL;
-if( mpOutDev-GetOutDevType() == OUTDEV_WINDOW )
+vcl::Window* pWin = NULL;
+vcl::Window* pCtrl = NULL;
+if (mpOutDev-GetOutDevType() == OUTDEV_WINDOW)
pWin = static_castvcl::Window*(mpOutDev.get());
ControlType aCtrlType = 0;
ControlPart aCtrlPart = PART_ENTIRE_CONTROL;
std::unique_ptrImplControlValue xControlValue(new ImplControlValue());
-if( pWin (pCtrl = mpBorderWindow-GetWindow( WINDOW_CLIENT )) != NULL )
+if (pWin (pCtrl = mpBorderWindow-GetWindow(WINDOW_CLIENT)) != NULL)
{
xControlValue.reset(new EditBoxValue(pCtrl-GetTextHeight()));
-switch( pCtrl-GetType() )
+switch (pCtrl-GetType())
{
case WINDOW_MULTILINEEDIT:
aCtrlType = CTRL_MULTILINE_EDITBOX;
@@ -1216,7 +1217,7 @@ void ImplSmallBorderWindowView::DrawWindow( sal_uInt16
nDrawFlags, OutputDevice*
case WINDOW_NUMERICFIELD:
case WINDOW_SPINFIELD:
case WINDOW_CALCINPUTLINE:
-if( pCtrl-GetStyle() WB_SPIN )
+if (pCtrl-GetStyle() WB_SPIN)
aCtrlType = CTRL_SPINBOX;
else
aCtrlType = CTRL_EDITBOX;
@@ -1226,7 +1227,7 @@ void ImplSmallBorderWindowView::DrawWindow( sal_uInt16
nDrawFlags, OutputDevice*
case WINDOW_MULTILISTBOX:
case WINDOW_TREELISTBOX:
aCtrlType = CTRL_LISTBOX;
-if( pCtrl-GetStyle() WB_DROPDOWN )
+if (pCtrl-GetStyle() WB_DROPDOWN)
[Libreoffice-bugs] [Bug 91057] CRASH- Writer crashes when typing ß character at beginning of a word
https://bugs.documentfoundation.org/show_bug.cgi?id=91057 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91057] CRASH- Writer crashes when typing ß character at beginning of a word
https://bugs.documentfoundation.org/show_bug.cgi?id=91057 --- Comment #11 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Caolán McNamara committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=d0a0da717682a0e57f733d75d9d0700cfb198823 Resolves: tdf#91057 transliterateChar2Char throws MultipleCharsOutputException It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90956] LO crashes 100% of attempts to Export as PDF from file menu
https://bugs.documentfoundation.org/show_bug.cgi?id=90956 --- Comment #10 from Caolán McNamara caol...@redhat.com --- I imagine that the problem is the explicit Resize (pBorderWindow-Resize()) on the border window due to bug 57090, the border windows stuff in vcl is sadly chaotic. Putting the mpWindowImpl-mbInDispose condition around that would presumably be safe seeing as the border window and the widget itself are sort of the same thing while sticking it at the top might hide that the widget has gone from containers and make them not reshuffle the remainder of their children -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91070] opposite result in conditioned format in Libreoff CALC
https://bugs.documentfoundation.org/show_bug.cgi?id=91070 --- Comment #11 from gmarco gmmell...@inwind.it --- Created attachment 115431 -- https://bugs.documentfoundation.org/attachment.cgi?id=115431action=edit new test 2a -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90935] Calc crashes on opening/closing some dialog boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=90935 --- Comment #13 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Meeks committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=94b1c8ca69c888aa15e5736f70a966dfc04273ca tdf#90935 - calc / sort dialog fixage. It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91140] ODF Import: Frame Area changed from image to color:white / 100% transparent on legacy documents
https://bugs.documentfoundation.org/show_bug.cgi?id=91140 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Priority|medium |high Status|UNCONFIRMED |NEW CC||mst...@redhat.com, ||vstuart.fo...@utsa.edu Ever confirmed|0 |1 --- Comment #1 from V Stuart Foote vstuart.fo...@utsa.edu --- Confirming. Frame background image is visible in Version: 4.3.7.2 Build ID: 8a35821d8636a03b8bf4e15b48f59794652c68ba But not visible when the ODT is opened in 4.4.0+, including current builds of master. And if saved there, the background graphic is being lost to a color fill in white. Reopening in 4.3.7.2 no longer shows background graphic--the Penguin .PNG is deleted from the ODF archive, so there is data loss as things are. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91070] opposite result in conditioned format in Libreoff CALC
https://bugs.documentfoundation.org/show_bug.cgi?id=91070 gmarco gmmell...@inwind.it changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Assignee|libreoffice-b...@lists.free |gmmell...@inwind.it |desktop.org | Ever confirmed|1 |0 --- Comment #12 from gmarco gmmell...@inwind.it --- Created attachment 115432 -- https://bugs.documentfoundation.org/attachment.cgi?id=115432action=edit new test 2b (see comments) Hi Julien and Raal I'll try to update 442 asap but actually look at this. Let we try to fly over the initial case that occurs on a spreadsheet migrated from MS Excel, it still is so, it is difficult to reproduce, but I cannot find a way to correct it. Trying and trying again i believe I have identified some states of apparent anomaly, easily reproducible (I can reproduce them at infinity), on which you should be able to investigate. Explaining fully in english (which is not my native language) is for me a little complicated but I'll try to. 1) Create a new sheet and enter the values and formulas (A1 =230, A2 =225, A3 =A1-A2), copy col.A into col.B, creates a style and apply the conditional formatting (Format-Conditional Formatting) on A3 (if = 5), do the same thing with B3; now you can try and try to change the conditions in B3 and A3 and the result will be always correct. 1a) creates a new sheet as above, applies the conditional formatting on A3 and then copy it on B3 using Copy - Paste special-formats as exemplified in the help 'https://help.libreoffice.org/Calc/Applying_Conditional_Formatting; Step 5: Copy Cell Style'; now try to change the condition in B3 (if = 0), you will notice that the result is not changed (see attached case1a.jpg) and, continuing to change the condition of B3, the result will be always remain until you change the condition of A3 (it is sufficient to open the window of Conditional Formatting and, even without changing anything, clicking OK). 2) Create a new sheet and enter the values and formulas (A1 =230, A2 =225, A3 =A1-A2), copy A1/A3 to A5/A7 and A9/A11 then copy col.A into col.B and col.C, creates a style and apply the conditional formatting (Format-Conditional Formatting) on A3 (if = 5) and copy it (Copy - Paste special-formats) on B3 D3 A7 B7 D7 A11 B11 D11; go to Conditional Formatting-Manage Conditional Formatting and the window shows only A3 A7 A11 B3 (see attached case2a.jpg). Now, trying to change the condition of C3, a warning window will appear (see attached case2b.jpg) that does not appear if you change the condition of B3 (these are only examples, you can prove this even with other cells); however the result in B3 does not change (as already seen at point 1a). I show that in help https://help.libreoffice.org/Calc/Conditional_Formatting; there is an incomprehensible statement Conditional Formatting - Choose Conditional Formatting to define format styles depending on certain conditions. If a style was already assigned to a cell, it remains unchanged. : I can't understand what it means, it would seem a false statement (see my test point 1) but it could hide some limitation mal implied that would otherwise better clarified. I hope that you will be able to reproduce the above and find the explanation, it could be the cause of other faults: if it is a bug it should be fixed, if it is intentional it should be highlighted more thoroughly and completely. Let me ask you also a curiosity: I frequently used in MS Excel the conditional formatting, there it is much less cumbersome and I never had any problems, is there a reason? Finally, at the margin, I show an error translation in the help (both internet and online): https://help.libreoffice.org/calc/applying_conditional_formatting; Step 5: Copy Cell Style To apply the conditional formatting to other cells later: 1.Click one of the cells that has been assigned conditional formatting. .. was incorrectly translated 1.Fate clic su una delle celle a cui deve essere applicata la formattazione condizionata. the correct translation is 1.Fate clic su una delle celle a cui è stata applicata la formattazione condizionata. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91138] LibreOffice Draw crashes when trying to edit extrusions
https://bugs.documentfoundation.org/show_bug.cgi?id=91138 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 --- Comment #2 from raal r...@post.cz --- I can confirm with Version: 5.0.0.0.alpha1+ Build ID: bcbf45d9f94d177c6841ccede3ff0ba69c4f22b1 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-05-04_03:51:16 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91128] LibO crashes when clicking on Navigator in Impress/Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=91128 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||118 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91118] LibO crashes when clicking find replace dialog title close button
https://bugs.documentfoundation.org/show_bug.cgi?id=91118 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added Attachment #115390|0 |1 is obsolete|| --- Comment #5 from Yousuf (Jay) Philips philip...@hotmail.com --- Created attachment 115434 -- https://bugs.documentfoundation.org/attachment.cgi?id=115434action=edit linux backtrace Steps: 1) Open Writer 2) Undock the sidebar 3) Click the 'X' to close the sidebar 4) Crash -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/uno/unotxdoc.cxx |6 ++ 1 file changed, 6 insertions(+) New commits: commit 1168d5a82e212c1a0a93faa72ebe7bf24fc20900 Author: Miklos Vajna vmik...@collabora.co.uk Date: Thu May 7 20:25:33 2015 +0200 sw: fix -Werror=unused-parameter Change-Id: I67223090a2a45e9519bd29e41e3e90eb847c5c19 diff --git a/sw/source/uibase/uno/unotxdoc.cxx b/sw/source/uibase/uno/unotxdoc.cxx index 86689a0..6f1c5a8 100644 --- a/sw/source/uibase/uno/unotxdoc.cxx +++ b/sw/source/uibase/uno/unotxdoc.cxx @@ -3294,6 +3294,12 @@ void SAL_CALL SwXTextDocument::paintTile( const ::css::uno::Any Parent, ::sal_I paintTile( aDevice, nOutputWidth, nOutputHeight, nTilePosX, nTilePosY, nTileWidth, nTileHeight ); #else // TODO: support other platforms +(void)nOutputWidth; +(void)nOutputHeight; +(void)nTilePosX; +(void)nTilePosY; +(void)nTileWidth; +(void)nTileHeight; #endif } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90935] Calc crashes on opening/closing some dialog boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=90935 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #12 from Michael Meeks michael.me...@collabora.com --- thanks ! =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/dbgui/sortdlg.cxx|4 ++--
sc/source/ui/dbgui/sortkeydlg.cxx | 11 +++
sc/source/ui/dbgui/tpsort.cxx |2 ++
sc/source/ui/inc/sortkeydlg.hxx |4 +++-
sc/source/ui/inc/tpsort.hxx |2 +-
5 files changed, 19 insertions(+), 4 deletions(-)
New commits:
commit 94b1c8ca69c888aa15e5736f70a966dfc04273ca
Author: Michael Meeks michael.me...@collabora.com
Date: Thu May 7 19:08:18 2015 +0100
tdf#90935 - calc / sort dialog fixage.
Change-Id: I9b33d2a6a47ba210561317679fd8514a1b5cfd11
diff --git a/sc/source/ui/dbgui/sortdlg.cxx b/sc/source/ui/dbgui/sortdlg.cxx
index 4702a06..35848bf 100644
--- a/sc/source/ui/dbgui/sortdlg.cxx
+++ b/sc/source/ui/dbgui/sortdlg.cxx
@@ -29,7 +29,7 @@ ScSortDlg::ScSortDlg(vcl::Window* pParent, const SfxItemSet*
pArgSet)
, bIsHeaders(false)
, bIsByRows(false)
{
-AddTabPage(criteria, ScTabPageSortFields::Create, 0);
+AddTabPage(criteria, ScTabPageSortFields::Create, 0);
AddTabPage(options, ScTabPageSortOptions::Create, 0);
}
@@ -37,7 +37,7 @@ ScSortWarningDlg::ScSortWarningDlg(vcl::Window* pParent,
const OUString rExtendText, const OUString rCurrentText)
: ModalDialog(pParent, SortWarning, modules/scalc/ui/sortwarning.ui)
{
-get(aFtText, sorttext );
+get( aFtText, sorttext );
get( aBtnExtSort, extend );
get( aBtnCurSort, current );
diff --git a/sc/source/ui/dbgui/sortkeydlg.cxx
b/sc/source/ui/dbgui/sortkeydlg.cxx
index e0518cd..6ffbf10 100644
--- a/sc/source/ui/dbgui/sortkeydlg.cxx
+++ b/sc/source/ui/dbgui/sortkeydlg.cxx
@@ -52,6 +52,12 @@ ScSortKeyWindow::ScSortKeyWindow(SfxTabPage* pParent,
ScSortKeyItems rSortKeyIt
ScSortKeyWindow::~ScSortKeyWindow()
{
+dispose();
+}
+
+void ScSortKeyWindow::dispose()
+{
+m_pBox.disposeAndClear();
mrSortKeyItems.clear();
}
@@ -89,6 +95,11 @@ ScSortKeyCtrl::ScSortKeyCtrl(SfxTabPage* pParent,
ScSortKeyItems rItems)
m_rVertScroll.SetScrollHdl( aScrollLink );
}
+void ScSortKeyCtrl::dispose()
+{
+m_aSortWin.dispose();
+}
+
void ScSortKeyCtrl::checkAutoVScroll()
{
WinBits nBits = m_rScrolledWindow.GetStyle();
diff --git a/sc/source/ui/dbgui/tpsort.cxx b/sc/source/ui/dbgui/tpsort.cxx
index 5b34cdf..68fbc94 100644
--- a/sc/source/ui/dbgui/tpsort.cxx
+++ b/sc/source/ui/dbgui/tpsort.cxx
@@ -101,6 +101,8 @@ ScTabPageSortFields::~ScTabPageSortFields()
void ScTabPageSortFields::dispose()
{
pDlg.clear();
+maSortKeyItems.clear();
+maSortKeyCtrl.dispose();
SfxTabPage::dispose();
}
diff --git a/sc/source/ui/inc/sortkeydlg.hxx b/sc/source/ui/inc/sortkeydlg.hxx
index a0a027c..07c1273 100644
--- a/sc/source/ui/inc/sortkeydlg.hxx
+++ b/sc/source/ui/inc/sortkeydlg.hxx
@@ -44,7 +44,7 @@ typedef boost::ptr_vectorScSortKeyItem ScSortKeyItems;
class ScSortKeyWindow
{
private:
-VclPtrVclBox m_pBox;
+VclPtrVclBox m_pBox;
sal_Int32 nItemHeight;
ScSortKeyItems mrSortKeyItems;
@@ -52,6 +52,7 @@ private:
public:
ScSortKeyWindow(SfxTabPage* pParent, ScSortKeyItems mrSortKeyItems);
~ScSortKeyWindow();
+void dispose();
void AddSortKey( sal_uInt16 nItem );
void DoScroll( sal_Int32 nNewPos );
@@ -72,6 +73,7 @@ private:
public:
ScSortKeyCtrl(SfxTabPage* pParent, ScSortKeyItems mrSortKeyItems);
+void dispose();
void setScrollRange();
void AddSortKey( sal_uInt16 nItem );
};
diff --git a/sc/source/ui/inc/tpsort.hxx b/sc/source/ui/inc/tpsort.hxx
index 82ad52dd..631ccc6 100644
--- a/sc/source/ui/inc/tpsort.hxx
+++ b/sc/source/ui/inc/tpsort.hxx
@@ -72,7 +72,7 @@ private:
OUStringaStrRow;
const sal_uInt16nWhichSort;
-VclPtrScSortDlg pDlg;
+VclPtrScSortDlg pDlg;
ScViewData* pViewData;
ScSortParam aSortData;
std::vectorSCCOLROW nFieldArr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91139] LibreOffice Draw crashes when closing the Glue Points window
https://bugs.documentfoundation.org/show_bug.cgi?id=91139 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||michael.me...@collabora.com ||, r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal r...@post.cz --- I can confirm crash with Version: 5.0.0.0.alpha1+ Build ID: bcbf45d9f94d177c6841ccede3ff0ba69c4f22b1 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-05-04_03:51:16 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91128] LibO crashes when clicking on Navigator in Impress/Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=91128 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal r...@post.cz --- Reproducible with Version: 5.0.0.0.alpha1+ Build ID: 5984cc83fe756f7483d1ac582b8adbef5042be8b TinderBox: Win-x86@42, Branch:master, Time: 2015-05-07_05:11:59 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91100] Closing Word count crashes writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91100 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||118 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91118] LibO crashes when clicking find replace dialog title close button
https://bugs.documentfoundation.org/show_bug.cgi?id=91118 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added Status|RESOLVED|NEW See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||128, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||100 Resolution|DUPLICATE |--- --- Comment #4 from Yousuf (Jay) Philips philip...@hotmail.com --- Still crashing when clicking the 'X' of a floating sidebar, even after Meeks' patch. Version: 5.0.0.0.alpha1+ Build ID: 6e78bf76f3a10b43475e1bd801bdcbb9ce62f668 TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2015-05-07_00:08:39 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91082] Format paintbrush makes disappear cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=91082 --- Comment #6 from Juan Pablo Orradre jporra...@gmail.com --- (In reply to raal from comment #4) Look similar to 91108 Looking at that report, it could be the same issue. Perhaps you should fusion this report with that one... Thanks, Juan Pablo. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/uno/unotxdoc.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 893871d86870708a0b2166eb1f583fe65b21a1b6 Author: Miklos Vajna vmik...@collabora.co.uk Date: Thu May 7 20:28:39 2015 +0200 sw: unused Parent [-Werror=unused-parameter] Change-Id: I4576837da4b908ac0393be155758b6b60afc6c45 diff --git a/sw/source/uibase/uno/unotxdoc.cxx b/sw/source/uibase/uno/unotxdoc.cxx index 6f1c5a8..18308a5 100644 --- a/sw/source/uibase/uno/unotxdoc.cxx +++ b/sw/source/uibase/uno/unotxdoc.cxx @@ -3294,6 +3294,7 @@ void SAL_CALL SwXTextDocument::paintTile( const ::css::uno::Any Parent, ::sal_I paintTile( aDevice, nOutputWidth, nOutputHeight, nTilePosX, nTilePosY, nTileWidth, nTileHeight ); #else // TODO: support other platforms +(void)Parent; (void)nOutputWidth; (void)nOutputHeight; (void)nTilePosX; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues
https://bugs.documentfoundation.org/show_bug.cgi?id=81234 Bug 81234 depends on bug 72578, which changed state. Bug 72578 Summary: rtf created with Writer containing tables are saved but loaded wrong https://bugs.documentfoundation.org/show_bug.cgi?id=72578 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72578] rtf created with Writer containing tables are saved but loaded wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=72578 Alexandr alexpik...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Alexandr alexpik...@gmail.com --- Reproducible with LibreOffice 5.0.0.0 alpha1, but correct in 5.0.0.0.alpha1+ Build ID: bcbf45d9f94d177c6841ccede3ff0ba69c4f22b1 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-05-04_03:51:16 I believe it is a duplicate of bug 80708 which is fixed now. *** This bug has been marked as a duplicate of bug 80708 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91082] Format paintbrush makes disappear cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=91082 --- Comment #5 from Juan Pablo Orradre jporra...@gmail.com --- (In reply to Beluga from comment #3) Could not repro. You have selected Writer, but you speak of work sheets like this affected Calc. So are you referring to Writer in any case? Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: 98436c4b53639d86f261ac630c46d32e3c7b8e28 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-05-04_00:07:10 Locale: fi-FI (fi_FI) Sorry if I misspoke. I meant by work sheet, a Writer sheet :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91070] opposite result in conditioned format in Libreoff CALC
https://bugs.documentfoundation.org/show_bug.cgi?id=91070 --- Comment #10 from gmarco gmmell...@inwind.it --- Created attachment 115430 -- https://bugs.documentfoundation.org/attachment.cgi?id=115430action=edit new test 1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91043] Crash in gtk+ file dialog from LibreLex ...
https://bugs.documentfoundation.org/show_bug.cgi?id=91043 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Comment #5 from Michael Meeks michael.me...@collabora.com --- You will need a stack-trace taken vs. a build with debug symbols to make this useful I think; fixing such things blind is a bit of a pain =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84353] EDITING: Very slow when selecting multiple row
https://bugs.documentfoundation.org/show_bug.cgi?id=84353 Yan Pashkovsky yanp...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #7 from Yan Pashkovsky yanp...@gmail.com --- In 4.4 problem is fixed. WORKSFORME because I don't know line of code where it was fixed -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-qa] [TEST] locking priority, severity, assignee, QA contact in bugzilla
Hi All, I've hacked bugzilla a bit but it needs some thorough testing before we commit it to our actual bugzilla instance. *What I've done*: * Locked the following fields to anyone that does not belong to group contributors or are assigned the bug o QA Contact; o Assignee; o Severity o Priority *To test:* 1. Head over to our test instance of bugzilla: *https://bugzilla-test.documentfoundation.org/* 1. As a starting point you can check by going here: https://bugzilla-test.documentfoundation.org/show_bug.cgi?id=89058 (you should see fields locked out) 2. Contact me to get added to contributor group (include your email that you use on bugzilla) 3. Create a test login that won't have any privileges Now you should be able to report bugs and compare what happens with your two users (the one in contributors and the new test account you create) *What Needs Testing * 1. Basically do everything you could think of, create a bug with both accounts, compare your access, change status (NEW, FIXED, ETC), see what impact you see, report any issues to me directly (please include repro steps to save me time :) ) *Goal: **We hope to abandon MAB once and for all and replace with objectively accurate priorities/severity *Being added to contributor group will be *very* easy, we'll document it on the wiki but basically it will be emailing the QA list with a generic email that requests being added. We don't want this to be a hurdle beyond users manipulating bug priority/severity. Contact me with any questions/concerns Thanks all Best, Joel ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 80768] Cell ranges with the same Conditional Formatting should be consolidated to 1 range.
https://bugs.documentfoundation.org/show_bug.cgi?id=80768 --- Comment #26 from Kevin bonbonbi...@gmail.com --- (In reply to helplibreoffice from comment #25) Given Kevin's description and additional details, should this be changed from an enhancement to another level of importance? Also, Kevin's words state not yet resolved until today. If I am reading his intent correctly, I believe he actually means Still not resolved. Yes,Still not resolved. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91130] Smaller default font name list
https://bugs.documentfoundation.org/show_bug.cgi?id=91130 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||stgohi-lob...@yahoo.de Ever confirmed|0 |1 --- Comment #2 from A (Andy) stgohi-lob...@yahoo.de --- This is an interesting enhancement. I regularly use only about 5 fonts and it would be good if the font filter could be improved by for instance listing the maybe 3 to 5 user-dependent (user-specific) most often used fonts at the beginning. Currently, the font list adapts in that way that the last used fonts will be shown at the beginning after they had been selected. I don't know if there are maybe also other good/better solutions, but for me Jay's proposals sound interesting to think about (especially No. 1, regarding No. 2 I am not yet sure, because it should further be easy to select different and new fonts without many mouse clicks). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91142] Ugly LibreOffice Start Center
https://bugs.documentfoundation.org/show_bug.cgi?id=91142 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added CC||stgohi-lob...@yahoo.de OS|Mac OS X (All) |All --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- These elements are a design element and I personally like this design very much. But of course as in most things in life this is also a matter of taste. In the long run it could maybe be interesting that the users could choose between different designs for the start screen. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91129] comment seems empty when opening, editing not possible
https://bugs.documentfoundation.org/show_bug.cgi?id=91129 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||mari...@miguelangel.mobi Ever confirmed|0 |1 --- Comment #4 from m.a.riosv mari...@miguelangel.mobi --- Reproducible Win7x64 Version: 4.4.3.2 Build ID: 88805f81e9fe61362df02b9941de8e38a9b5fd16 Version: 4.4.4.0.0+ Build ID: 31c2a2230e6debd0fa53656f6a2159918d2d67d8 TinderBox: Win-x86@42, Branch:libreoffice-4-4, Time: 2015-05-05_14:26:59 Version: 5.0.0.0.alpha1 (x64) Build ID: f0853d5c2c38b050fbfd48e09cd0bf0b400aaef8 Version: 5.0.0.0.alpha1+ (x64)Build ID: 6e78bf76f3a10b43475e1bd801bdcbb9ce62f668 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-05-07_00:45:19 Hi Winfried, could be only an issue with windows?. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: extras/source
extras/source/gallery/arrows/A16-CircleArrow.png |binary extras/source/gallery/arrows/A17-CircleArrow.png |binary extras/source/gallery/arrows/A18-CircleArrow.png |binary extras/source/gallery/arrows/A19-CircleArrow.png |binary extras/source/gallery/arrows/A26-CurvedArrow-Orange.png|binary extras/source/gallery/arrows/A27-CurvedArrow-DarkRed.png |binary extras/source/gallery/arrows/A28-CurvedArrow-DarkBlue.png |binary extras/source/gallery/arrows/A29-CurvedArrow-Green.png |binary extras/source/gallery/arrows/A44-TrendArrow-Orange-GoUp.png|binary extras/source/gallery/arrows/A45-TrendArrow-Red-GoUp.png |binary extras/source/gallery/arrows/A47-TrendArrow-LightBlue.png |binary extras/source/gallery/computers/Computer-Cloud.png |binary extras/source/gallery/computers/Computer-Desktop.png |binary extras/source/gallery/computers/Computer-Laptop-Black.png |binary extras/source/gallery/computers/Computer-Laptop-Silver.png |binary extras/source/gallery/computers/Database-Add.png |binary extras/source/gallery/computers/Database-Delete.png|binary extras/source/gallery/computers/Database-Download.png |binary extras/source/gallery/computers/Database.png |binary extras/source/gallery/computers/Folder01-Blue.png |binary extras/source/gallery/computers/Folder02-Green.png |binary extras/source/gallery/computers/Folder03-Manilla.png |binary extras/source/gallery/computers/Folder04-Yellow.png|binary extras/source/gallery/computers/Folder05-OpenBlue.png |binary extras/source/gallery/computers/Folder06-OpenGreen.png |binary extras/source/gallery/computers/Folder07-OpenManilla.png |binary extras/source/gallery/computers/Folder08-OpenYellow.png|binary extras/source/gallery/computers/Server.png |binary extras/source/gallery/computers/WirelessAccessPoint.png|binary extras/source/gallery/education/Blackboard.png |binary extras/source/gallery/education/Books.png |binary extras/source/gallery/education/Chalk.png |binary extras/source/gallery/education/Globe.png |binary extras/source/gallery/education/Glue.png |binary extras/source/gallery/education/GraduationCap.png |binary extras/source/gallery/education/Microscope.png |binary extras/source/gallery/education/Notebook.png |binary extras/source/gallery/education/PaperClip-Blue.png |binary extras/source/gallery/education/PaperClip-Red.png |binary extras/source/gallery/education/Pencil.png |binary extras/source/gallery/education/Ruler.png |binary extras/source/gallery/education/TestTubes.png |binary extras/source/gallery/environment/DrippingFaucet.png |binary extras/source/gallery/environment/Earth.png|binary extras/source/gallery/environment/EndangeredAnimals1.png |binary extras/source/gallery/environment/EndangeredAnimals2.png |binary extras/source/gallery/environment/GreenCar.png |binary extras/source/gallery/environment/GreenFactory.png |binary extras/source/gallery/environment/GreenHouse.png |binary extras/source/gallery/environment/Leaf1.png|binary extras/source/gallery/environment/Leaf2.png|binary extras/source/gallery/environment/LightBulb-Flourescent-Off.png|binary extras/source/gallery/environment/LightBulb-Flourescent-On.png |binary extras/source/gallery/environment/LightBulb-Standard-Off1.png |binary extras/source/gallery/environment/LightBulb-Standard-Off2.png |binary extras/source/gallery/environment/LightBulb-Standard-On.png|binary extras/source/gallery/environment/Pollution-Car.png|binary extras/source/gallery/environment/Pollution-Factory.png|binary extras/source/gallery/environment/Raindrop.png |binary extras/source/gallery/environment/RecycleBin.png |binary extras/source/gallery/environment/RecycleSymbol.png|binary extras/source/gallery/environment/RenewableEnergy-Solar.png|binary extras/source/gallery/environment/RenewableEnergy-Water.png|binary extras/source/gallery/environment/RenewableEnergy-Wind.png |binary extras/source/gallery/environment/RenewableEnergySymbol.png|binary extras/source/gallery/environment/Sun1.png
[Libreoffice-bugs] [Bug 91086] OS X - UI : White space all over menu bar when the window is expanded
https://bugs.documentfoundation.org/show_bug.cgi?id=91086 --- Comment #7 from Iandol ian...@gmail.com --- Note that there is NO white bar ON TOP the menu bar as the menu bar is normally hidden in fullscreen mode, and does display when you hover the top of the screen. The only problem of this is a waste of screenspace... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91150] New: Including additional Adobe open source fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=91150 Bug ID: 91150 Summary: Including additional Adobe open source fonts Product: LibreOffice Version: 5.0.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: ux-advise Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com CC: libreoffice-ux-adv...@lists.freedesktop.org Presently, LibO bundles Adobe's Source Sans Pro font, but Adobe has also released a monospace variant (Source Code Pro) in 2012 and a serif variant (Source Serif Pro) in 2014. So are we intending to also bundle those as well? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91150] New: Including additional Adobe open source fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=91150 Bug ID: 91150 Summary: Including additional Adobe open source fonts Product: LibreOffice Version: 5.0.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: ux-advise Assignee: libreoffice-b...@lists.freedesktop.org Reporter: philip...@hotmail.com CC: libreoffice-ux-advise@lists.freedesktop.org Presently, LibO bundles Adobe's Source Sans Pro font, but Adobe has also released a monospace variant (Source Code Pro) in 2012 and a serif variant (Source Serif Pro) in 2014. So are we intending to also bundle those as well? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91086] OS X - UI : White space all over menu bar when the window is expanded
https://bugs.documentfoundation.org/show_bug.cgi?id=91086 --- Comment #8 from Claude 1claudechampa...@gmail.com --- (In reply to Iandol from comment #7) Note that there is NO white bar ON TOP the menu bar as the menu bar is normally hidden in fullscreen mode, and does display when you hover the top of the screen. The only problem of this is a waste of screenspace... Yes, and it's pretty anoying. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - rat-excludes
rat-excludes |4 1 file changed, 4 deletions(-) New commits: commit 5b0df64160678bbbd373bd80de8583d25c77df49 Author: Kay Schenk ksch...@apache.org Date: Thu May 7 22:13:12 2015 + Remove hangul info from rat-excludes. diff --git a/rat-excludes b/rat-excludes index 0f08f157..eb808d1 100644 --- a/rat-excludes +++ b/rat-excludes @@ -138,10 +138,6 @@ main/extras/source/misc_config/autotbl.fmt # binary information for a Visual Basic form (?) main/migrationanalysis/src/wizard/Wizard.FRX -# Used in main/testautomation/writer/optional/input/import/hangul.hwp (1), part of SGA -# binary? AOO specific? Hangul Word Processor file -main/testautomation/writer/optional/input/import/hangul.hwp - # main/scripting/java/org/openoffice/netbeans/editor/OOo.jcb (1), part of SGA # binary, file type not clear main/scripting/java/org/openoffice/netbeans/editor/OOo.jcb ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 76817] Outline Numbering for DOCX not working when new headings inserted in between (Simple Steps in comment 3)
https://bugs.documentfoundation.org/show_bug.cgi?id=76817 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added Priority|highest |medium See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=84 ||317 Whiteboard||filter:docx Severity|blocker |major -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
