date:20150717

[Libreoffice-bugs] [Bug 91495] Style preview in Styles and Formatting sidebar should be optional

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91495

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 CC||qui...@gmail.com,
   ||vstuart.fo...@utsa.edu

--- Comment #9 from V Stuart Foote vstuart.fo...@utsa.edu ---
On Widnows 7 sp1, 64-bit en-US with
Version: 5.1.0.0.alpha1+ (x64)
Build ID: 14257152b19c08618a107c6eb0f684de11483da8
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-17_03:23:36
Locale: en-US (en_US)

Using Tools - Options - Advanced: Expert Configuration to search for
StylesAndFormatting and setting false correctly disables all rendering in the
Sidebar's Styles and Formatting Content Panel. Close module and reopen (no need
to exit). 

Without style applied the selection labels all look to be rendered in the LO
system default at a fixed font size and pitch. Applies the same to Paragraph,
Character, Frame, Page and List tabs all of which just list their selections
unstyled.

A little jarring visually, in that only the Hierarchical listing collapses the
list to single spacing--all other selections are multi-line spacing (or maybe
have too much padding).  Might be more appealing if all the now unstyled lists
can be collapsed to single line spacing.

Also, the Formatting toolbar Apply Style dropdown, continues to render its
list of defined styles, which might also annoy folks for Styles that do not
show complete fidelity.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: distro-configs/LibreOfficeLinux.conf distro-configs/LibreOfficeWin32.conf distro-configs/LibreOfficeWin64.conf

2015-07-17 Thread Christian Lohmaier

 distro-configs/LibreOfficeLinux.conf |1 +
 distro-configs/LibreOfficeWin32.conf |1 +
 distro-configs/LibreOfficeWin64.conf |1 +
 3 files changed, 3 insertions(+)

New commits:
commit 094f894bace181708bc5c826f86c9a8e9f126675
Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Date:   Fri Jul 17 16:28:24 2015 +0200

Linux and Win builds use mergelibs starting with 5.0

Change-Id: I7cdcdcdc4ba44b3fb8014f93cc522b61f5fc

diff --git a/distro-configs/LibreOfficeLinux.conf 
b/distro-configs/LibreOfficeLinux.conf
index 2824fb6..0175ff9 100644
--- a/distro-configs/LibreOfficeLinux.conf
+++ b/distro-configs/LibreOfficeLinux.conf
@@ -38,3 +38,4 @@
 --disable-randr-link
 --disable-kde4
 --disable-gtk3
+--enable-mergelibs
diff --git a/distro-configs/LibreOfficeWin32.conf 
b/distro-configs/LibreOfficeWin32.conf
index fac9864..c231ccd 100644
--- a/distro-configs/LibreOfficeWin32.conf
+++ b/distro-configs/LibreOfficeWin32.conf
@@ -11,3 +11,4 @@
 --with-help
 --with-myspell-dicts
 --with-package-format=msi
+--enable-mergelibs
diff --git a/distro-configs/LibreOfficeWin64.conf 
b/distro-configs/LibreOfficeWin64.conf
index 1c3ee28..e2d7aca 100644
--- a/distro-configs/LibreOfficeWin64.conf
+++ b/distro-configs/LibreOfficeWin64.conf
@@ -11,3 +11,4 @@
 --with-help
 --with-myspell-dicts
 --with-package-format=msi
+--enable-mergelibs
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - distro-configs/LibreOfficeLinux.conf distro-configs/LibreOfficeWin32.conf distro-configs/LibreOfficeWin64.conf

2015-07-17 Thread Christian Lohmaier

 distro-configs/LibreOfficeLinux.conf |1 +
 distro-configs/LibreOfficeWin32.conf |1 +
 distro-configs/LibreOfficeWin64.conf |1 +
 3 files changed, 3 insertions(+)

New commits:
commit 28b45035dbd16a34af54909fd4823f7e201bb3a2
Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Date:   Fri Jul 17 16:28:24 2015 +0200

Linux and Win builds use mergelibs starting with 5.0

(cherry picked from commit 094f894bace181708bc5c826f86c9a8e9f126675)

Change-Id: I7cdcdcdc4ba44b3fb8014f93cc522b61f5fc

diff --git a/distro-configs/LibreOfficeLinux.conf 
b/distro-configs/LibreOfficeLinux.conf
index 2ab94d4..fcd7746 100644
--- a/distro-configs/LibreOfficeLinux.conf
+++ b/distro-configs/LibreOfficeLinux.conf
@@ -36,3 +36,4 @@
 --disable-gio
 --disable-randr-link
 --disable-kde4
+--enable-mergelibs
diff --git a/distro-configs/LibreOfficeWin32.conf 
b/distro-configs/LibreOfficeWin32.conf
index fac9864..c231ccd 100644
--- a/distro-configs/LibreOfficeWin32.conf
+++ b/distro-configs/LibreOfficeWin32.conf
@@ -11,3 +11,4 @@
 --with-help
 --with-myspell-dicts
 --with-package-format=msi
+--enable-mergelibs
diff --git a/distro-configs/LibreOfficeWin64.conf 
b/distro-configs/LibreOfficeWin64.conf
index 5fa640d..cc8211f 100644
--- a/distro-configs/LibreOfficeWin64.conf
+++ b/distro-configs/LibreOfficeWin64.conf
@@ -12,3 +12,4 @@
 --with-help
 --with-myspell-dicts
 --with-package-format=msi
+--enable-mergelibs
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - distro-configs/LibreOfficeLinux.conf distro-configs/LibreOfficeWin32.conf distro-configs/LibreOfficeWin64.conf

2015-07-17 Thread Christian Lohmaier

 distro-configs/LibreOfficeLinux.conf |1 +
 distro-configs/LibreOfficeWin32.conf |1 +
 distro-configs/LibreOfficeWin64.conf |1 +
 3 files changed, 3 insertions(+)

New commits:
commit 5bd083669321cc809505dab43b2bd2aa3ac339fd
Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Date:   Fri Jul 17 16:28:24 2015 +0200

Linux and Win builds use mergelibs starting with 5.0

(cherry picked from commit 094f894bace181708bc5c826f86c9a8e9f126675)

Change-Id: I7cdcdcdc4ba44b3fb8014f93cc522b61f5fc
(cherry picked from commit 28b45035dbd16a34af54909fd4823f7e201bb3a2)

diff --git a/distro-configs/LibreOfficeLinux.conf 
b/distro-configs/LibreOfficeLinux.conf
index 2ab94d4..fcd7746 100644
--- a/distro-configs/LibreOfficeLinux.conf
+++ b/distro-configs/LibreOfficeLinux.conf
@@ -36,3 +36,4 @@
 --disable-gio
 --disable-randr-link
 --disable-kde4
+--enable-mergelibs
diff --git a/distro-configs/LibreOfficeWin32.conf 
b/distro-configs/LibreOfficeWin32.conf
index fac9864..c231ccd 100644
--- a/distro-configs/LibreOfficeWin32.conf
+++ b/distro-configs/LibreOfficeWin32.conf
@@ -11,3 +11,4 @@
 --with-help
 --with-myspell-dicts
 --with-package-format=msi
+--enable-mergelibs
diff --git a/distro-configs/LibreOfficeWin64.conf 
b/distro-configs/LibreOfficeWin64.conf
index 5fa640d..cc8211f 100644
--- a/distro-configs/LibreOfficeWin64.conf
+++ b/distro-configs/LibreOfficeWin64.conf
@@ -12,3 +12,4 @@
 --with-help
 --with-myspell-dicts
 --with-package-format=msi
+--enable-mergelibs
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/unx

2015-07-17 Thread Caolán McNamara

 vcl/unx/gtk/window/gtksalframe.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 406a815642a7b2b34107c49856f3f25ccfd4277d
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 15:46:09 2015 +0100

WaE: unused macro

Change-Id: Ic7112f9bdd638ad72758e1b187778d004df4dd7b

diff --git a/vcl/unx/gtk/window/gtksalframe.cxx 
b/vcl/unx/gtk/window/gtksalframe.cxx
index bdb360a..2abc94f 100644
--- a/vcl/unx/gtk/window/gtksalframe.cxx
+++ b/vcl/unx/gtk/window/gtksalframe.cxx
@@ -106,7 +106,6 @@
 #endif
 
 #if !GTK_CHECK_VERSION(3,10,0)
-#define GDK_WINDOWING_X11
 #define GDK_IS_X11_DISPLAY(foo) (true)
 #endif
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

2015-07-17 Thread Vasily Melenchuk

 sfx2/source/doc/docfile.cxx |   61 
 1 file changed, 29 insertions(+), 32 deletions(-)

New commits:
commit c8cd629132f5b4d879edc53911a4e4abeb8d90aa
Author: Vasily Melenchuk vasily.melenc...@cib.de
Date:   Wed Jul 15 18:49:51 2015 +0200

tdf#92758: no more duplication of document in CMIS after checkin

Document now is correctly reloaded after checkin, so no copy of
closed on server private working copy remains.

Change-Id: I1625bda2f960827d60018b0702447b93886043f3
Reviewed-on: https://gerrit.libreoffice.org/17118
Reviewed-by: Thorsten Behrens thorsten.behr...@cib.de
Tested-by: Thorsten Behrens thorsten.behr...@cib.de

diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index d89235a..49e7a47 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -3640,44 +3640,41 @@ bool SfxMedium::SwitchDocumentToFile( const OUString 
aURL )
 uno::Reference embed::XStorage  xStorage = GetStorage();
 uno::Reference embed::XOptimizedStorage  xOptStorage( xStorage, 
uno::UNO_QUERY );
 
-if ( xOptStorage.is() )
-{
-// TODO/LATER: reuse the pImp-pTempFile if it already exists
-CanDisposeStorage_Impl( false );
-Close();
-SetPhysicalName_Impl( OUString() );
-SetName( aURL );
+// TODO/LATER: reuse the pImp-pTempFile if it already exists
+CanDisposeStorage_Impl( false );
+Close();
+SetPhysicalName_Impl( OUString() );
+SetName( aURL );
 
-// open the temporary file based document
-GetMedium_Impl();
-LockOrigFileOnDemand( false, false );
-CreateTempFile( true );
-GetMedium_Impl();
+// open the temporary file based document
+GetMedium_Impl();
+LockOrigFileOnDemand( false, false );
+CreateTempFile( true );
+GetMedium_Impl();
 
-if ( pImp-xStream.is() )
+if ( pImp-xStream.is() )
+{
+try
 {
-try
-{
-uno::Reference io::XTruncate  xTruncate( pImp-xStream, 
uno::UNO_QUERY_THROW );
-if ( xTruncate.is() )
-xTruncate-truncate();
-
+uno::Reference io::XTruncate  xTruncate( pImp-xStream, 
uno::UNO_QUERY_THROW );
+if ( xTruncate.is() )
+xTruncate-truncate();
+if ( xOptStorage.is() )
 xOptStorage-writeAndAttachToStream( pImp-xStream );
-pImp-xStorage = xStorage;
-bResult = true;
-}
-catch( const uno::Exception )
-{}
-}
-
-if ( !bResult )
-{
-Close();
-SetPhysicalName_Impl( OUString() );
-SetName( aOrigURL );
-GetMedium_Impl();
 pImp-xStorage = xStorage;
+bResult = true;
 }
+catch( const uno::Exception )
+{}
+}
+
+if ( !bResult )
+{
+Close();
+SetPhysicalName_Impl( OUString() );
+SetName( aOrigURL );
+GetMedium_Impl();
+pImp-xStorage = xStorage;
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/qa filter/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/tiff/fail/hang-2.tiff |binary
 filter/source/graphicfilter/itiff/itiff.cxx  |   11 ++-
 2 files changed, 10 insertions(+), 1 deletion(-)

New commits:
commit 85d5385ed47009782abbeaa538611a6367b61bb4
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 09:59:23 2015 +0100

detect another loop in tif format

Change-Id: I950f751277d9080b4fc00c38f63453cce81bcc32
(cherry picked from commit 49bf2c6700d8f0fc9155ac2d06bf0a7bd84915d8)
Reviewed-on: https://gerrit.libreoffice.org/17154
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/filter/qa/cppunit/data/tiff/fail/hang-2.tiff 
b/filter/qa/cppunit/data/tiff/fail/hang-2.tiff
new file mode 100644
index 000..28ec8c0
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/hang-2.tiff differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index 9ae2a06..80c859c 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -1178,10 +1178,19 @@ bool TIFFReader::ReadTIFF(SvStream  rTIFF, Graphic  
rGraphic )
 {
 sal_uInt32 nOffset = nFirstIfd;
 
+std::vectorsal_uInt32 aSeenOffsets;
 // calculate length of TIFF file
 do
 {
-pTIFF-Seek( nOrigPos + nOffset );
+if (std::find(aSeenOffsets.begin(), aSeenOffsets.end(), nOffset) 
!= aSeenOffsets.end())
+{
+SAL_WARN(filter.tiff, Parsing error:   nOffset 
+  already processed, format loop);
+bStatus = false;
+break;
+}
+pTIFF-Seek(nOrigPos + nOffset);
+aSeenOffsets.push_back(nOffset);
 
 if( pTIFF-GetError() )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/qa filter/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/tiff/fail/hang-1.tiff |binary
 filter/source/graphicfilter/itiff/itiff.cxx  |7 +--
 2 files changed, 5 insertions(+), 2 deletions(-)

New commits:
commit 5681a8b41dd95fea324d4a9797fbe959e2022feb
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 09:45:26 2015 +0100

test that nNumStripOffsets value is within bounds of file

Change-Id: I1483ea3671420be5349692374641e10b344d
(cherry picked from commit feedb957310fc3282ca47d5ffc1482dbb944a36e)
Reviewed-on: https://gerrit.libreoffice.org/17151
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/filter/qa/cppunit/data/tiff/fail/hang-1.tiff 
b/filter/qa/cppunit/data/tiff/fail/hang-1.tiff
new file mode 100644
index 000..9cd2aa2
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/hang-1.tiff differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index 80c859c..aed15f6 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -373,14 +373,17 @@ void TIFFReader::ReadTagData( sal_uInt16 nTagType, 
sal_uInt32 nDataLen)
 nNumStripOffsets = 0;
 nOldNumSO = nNumStripOffsets;
 nDataLen += nOldNumSO;
-if ( ( nDataLen  nOldNumSO )  ( nDataLen  SAL_MAX_UINT32 / 
sizeof( sal_uInt32 ) ) )
+size_t nMaxAllocAllowed = SAL_MAX_UINT32 / sizeof(sal_uInt32);
+size_t nMaxRecordsAvailable = pTIFF-remainingSize() / 
DataTypeSize();
+if (nDataLen  nOldNumSO  nDataLen  nMaxAllocAllowed 
+(nDataLen - nOldNumSO) = nMaxRecordsAvailable)
 {
 nNumStripOffsets = nDataLen;
 try
 {
 pStripOffsets = new sal_uLong[ nNumStripOffsets ];
 }
-catch (const std::bad_alloc )
+catch (const std::bad_alloc )
 {
 pStripOffsets = NULL;
 nNumStripOffsets = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/qa filter/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/pict/fail/exception-1.pct |binary
 filter/source/graphicfilter/ipict/ipict.cxx  |5 +
 2 files changed, 5 insertions(+)

New commits:
commit dc32feb2548aa557a8be6474986fc636d23c4e06
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Thu Jul 16 10:01:24 2015 +0100

exception on div by 0

Change-Id: Id33d6a5e3df5812babd28ebfc65b95ce97219ad3
(cherry picked from commit cf4159e16c13a13d0bedccebb50bb08f1662bc1c)
Reviewed-on: https://gerrit.libreoffice.org/17122
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/filter/qa/cppunit/data/pict/fail/exception-1.pct 
b/filter/qa/cppunit/data/pict/fail/exception-1.pct
new file mode 100644
index 000..f9cd85a
Binary files /dev/null and b/filter/qa/cppunit/data/pict/fail/exception-1.pct 
differ
diff --git a/filter/source/graphicfilter/ipict/ipict.cxx 
b/filter/source/graphicfilter/ipict/ipict.cxx
index 852e69b..4f0e431 100644
--- a/filter/source/graphicfilter/ipict/ipict.cxx
+++ b/filter/source/graphicfilter/ipict/ipict.cxx
@@ -1837,6 +1837,7 @@ sal_uLong PictReader::ReadData(sal_uInt16 nOpcode)
 
 void PictReader::ReadPict( SvStream  rStreamPict, GDIMetaFile  rGDIMetaFile )
 {
+try {
 sal_uInt16  nOpcode;
 sal_uInt8   nOneByteOpcode;
 sal_uLong   nSize, nPercent, nLastPercent;
@@ -1929,6 +1930,10 @@ void PictReader::ReadPict( SvStream  rStreamPict, 
GDIMetaFile  rGDIMetaFile )
 pPict-SetNumberFormatInt(nOrigNumberFormat);
 
 if (pPict-GetError()) pPict-Seek(nOrigPos);
+} catch (...)
+{
+rStreamPict.SetError(SVSTREAM_FILEFORMAT_ERROR);
+}
 }
 
 namespace pict {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/qa filter/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/tiff/fail/loop.tif   |binary
 filter/source/graphicfilter/itiff/itiff.cxx |   12 +++-
 2 files changed, 11 insertions(+), 1 deletion(-)

New commits:
commit 07b3e1504f1175c9b626a4c729032604613cf8fb
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 09:23:17 2015 +0100

detect loop in tif format

Change-Id: I27645566cd9fc0ac8cf753f0217ae6cf0fa9929e
(cherry picked from commit 290465b0effecb6d620adc20ca279f8057eeab9a)
Reviewed-on: https://gerrit.libreoffice.org/17150
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/filter/qa/cppunit/data/tiff/fail/loop.tif 
b/filter/qa/cppunit/data/tiff/fail/loop.tif
new file mode 100644
index 000..6d8cee7
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/loop.tif differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index 9dfa328..0474c5b 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -1226,9 +1226,19 @@ bool TIFFReader::ReadTIFF(SvStream  rTIFF, Graphic  
rGraphic )
 }
 while( nOffset );
 
+std::vectorsal_uInt32 aSeenIfds;
+
 for ( sal_uInt32 nNextIfd = nFirstIfd; nNextIfd  bStatus; )
 {
-pTIFF-Seek( nOrigPos + nNextIfd );
+if (std::find(aSeenIfds.begin(), aSeenIfds.end(), nNextIfd) != 
aSeenIfds.end())
+{
+SAL_WARN(filter.tiff, Parsing error:   nNextIfd 
+  already processed, format loop);
+bStatus = false;
+break;
+}
+pTIFF-Seek(nOrigPos + nNextIfd);
+aSeenIfds.push_back(nNextIfd);
 {
 bByteSwap = false;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/qa filter/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/tiff/fail/hang-2.tiff |binary
 filter/source/graphicfilter/itiff/itiff.cxx  |   11 ++-
 2 files changed, 10 insertions(+), 1 deletion(-)

New commits:
commit ce52c9dcc3eaec8c8e4c72b1c5933d3ca2fbb384
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 09:59:23 2015 +0100

detect another loop in tif format

Change-Id: I950f751277d9080b4fc00c38f63453cce81bcc32
(cherry picked from commit 49bf2c6700d8f0fc9155ac2d06bf0a7bd84915d8)
Reviewed-on: https://gerrit.libreoffice.org/17155
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/filter/qa/cppunit/data/tiff/fail/hang-2.tiff 
b/filter/qa/cppunit/data/tiff/fail/hang-2.tiff
new file mode 100644
index 000..28ec8c0
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/hang-2.tiff differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index 92d7a3c..6d1be66 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -1197,10 +1197,19 @@ bool TIFFReader::ReadTIFF(SvStream  rTIFF, Graphic  
rGraphic )
 {
 sal_uInt32 nOffset = nFirstIfd;
 
+std::vectorsal_uInt32 aSeenOffsets;
 // calculate length of TIFF file
 do
 {
-pTIFF-Seek( nOrigPos + nOffset );
+if (std::find(aSeenOffsets.begin(), aSeenOffsets.end(), nOffset) 
!= aSeenOffsets.end())
+{
+SAL_WARN(filter.tiff, Parsing error:   nOffset 
+  already processed, format loop);
+bStatus = false;
+break;
+}
+pTIFF-Seek(nOrigPos + nOffset);
+aSeenOffsets.push_back(nOffset);
 
 if( pTIFF-GetError() )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/qa filter/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/pcx/fail/hang-1.pcx |binary
 filter/source/graphicfilter/ipcx/ipcx.cxx  |4 ++--
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f45821e73e4db672c013d9c71816c1d36c421873
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 10:11:34 2015 +0100

don't loop forever if pcx has short read

Change-Id: I638792417924bcb8e48995f4e789f84a2cbf4757
(cherry picked from commit c9ba7a2a4d29af2542f31562cfdd64db2237aea8)
Reviewed-on: https://gerrit.libreoffice.org/17159
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/filter/qa/cppunit/data/pcx/fail/hang-1.pcx 
b/filter/qa/cppunit/data/pcx/fail/hang-1.pcx
new file mode 100644
index 000..73798ea
Binary files /dev/null and b/filter/qa/cppunit/data/pcx/fail/hang-1.pcx differ
diff --git a/filter/source/graphicfilter/ipcx/ipcx.cxx 
b/filter/source/graphicfilter/ipcx/ipcx.cxx
index 09604932..f5326fe 100644
--- a/filter/source/graphicfilter/ipcx/ipcx.cxx
+++ b/filter/source/graphicfilter/ipcx/ipcx.cxx
@@ -230,7 +230,7 @@ void PCXReader::ImplReadBody(BitmapWriteAccess * pAcc)
 nCount = 0;
 for ( ny = 0; ny  nHeight; ny++ )
 {
-if (m_rPCX.GetError() || m_rPCX.IsEof())
+if (!m_rPCX.good())
 {
 nStatus = false;
 break;
@@ -256,7 +256,7 @@ void PCXReader::ImplReadBody(BitmapWriteAccess * pAcc)
 nx--;
 nCount--;
 }
-while ( nx  0 )
+while (nx  0  m_rPCX.good())
 {
 m_rPCX.ReadUChar( nDat );
 if ( ( nDat  0xc0 ) == 0xc0 )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/qa tools/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/tiff/fail/hang-4.tiff |binary
 tools/source/stream/stream.cxx   |2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f37d7df1696c089206c5922814c28553a08117aa
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 10:26:46 2015 +0100

in remainingSize consider that its is possible to seek past the end

Change-Id: I1652244d5515629f1cd8f15f4c5b15f139dba0aa
(cherry picked from commit 6a1f31898d4d44d69f4f65e56f5dd087607885af)
Reviewed-on: https://gerrit.libreoffice.org/17160
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/filter/qa/cppunit/data/tiff/fail/hang-4.tiff 
b/filter/qa/cppunit/data/tiff/fail/hang-4.tiff
new file mode 100644
index 000..4048941
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/hang-4.tiff differ
diff --git a/tools/source/stream/stream.cxx b/tools/source/stream/stream.cxx
index faf6e09..886b896 100644
--- a/tools/source/stream/stream.cxx
+++ b/tools/source/stream/stream.cxx
@@ -1465,7 +1465,7 @@ sal_uInt64 SvStream::remainingSize()
 {
 sal_uInt64 const nCurr = Tell();
 sal_uInt64 const nEnd = Seek(STREAM_SEEK_TO_END);
-sal_uInt64 nMaxAvailable = nEnd-nCurr;
+sal_uInt64 nMaxAvailable = nEnd  nCurr ? (nEnd-nCurr) : 0;
 Seek(nCurr);
 return nMaxAvailable;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/qa filter/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/pcx/fail/hang-1.pcx |binary
 filter/source/graphicfilter/ipcx/ipcx.cxx  |4 ++--
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 26cd5af62fdeb650714f36c948784de1016591e4
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 10:11:34 2015 +0100

don't loop forever if pcx has short read

Change-Id: I638792417924bcb8e48995f4e789f84a2cbf4757
(cherry picked from commit c9ba7a2a4d29af2542f31562cfdd64db2237aea8)
Reviewed-on: https://gerrit.libreoffice.org/17157
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/filter/qa/cppunit/data/pcx/fail/hang-1.pcx 
b/filter/qa/cppunit/data/pcx/fail/hang-1.pcx
new file mode 100644
index 000..73798ea
Binary files /dev/null and b/filter/qa/cppunit/data/pcx/fail/hang-1.pcx differ
diff --git a/filter/source/graphicfilter/ipcx/ipcx.cxx 
b/filter/source/graphicfilter/ipcx/ipcx.cxx
index 61b7fa6..8a5ddb3 100644
--- a/filter/source/graphicfilter/ipcx/ipcx.cxx
+++ b/filter/source/graphicfilter/ipcx/ipcx.cxx
@@ -224,7 +224,7 @@ void PCXReader::ImplReadBody(BitmapWriteAccess * pAcc)
 nCount = 0;
 for ( ny = 0; ny  nHeight; ny++ )
 {
-if (m_rPCX.GetError() || m_rPCX.IsEof())
+if (!m_rPCX.good())
 {
 nStatus = false;
 break;
@@ -248,7 +248,7 @@ void PCXReader::ImplReadBody(BitmapWriteAccess * pAcc)
 nx--;
 nCount--;
 }
-while ( nx  0 )
+while (nx  0  m_rPCX.good())
 {
 m_rPCX.ReadUChar( nDat );
 if ( ( nDat  0xc0 ) == 0xc0 )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/qa tools/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/tiff/fail/hang-4.tiff |binary
 tools/source/stream/stream.cxx   |2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1d43b962d28641428007eedfe8dfdcc8ec3f8044
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 10:26:46 2015 +0100

in remainingSize consider that its is possible to seek past the end

Change-Id: I1652244d5515629f1cd8f15f4c5b15f139dba0aa
(cherry picked from commit 6a1f31898d4d44d69f4f65e56f5dd087607885af)
Reviewed-on: https://gerrit.libreoffice.org/17158
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/filter/qa/cppunit/data/tiff/fail/hang-4.tiff 
b/filter/qa/cppunit/data/tiff/fail/hang-4.tiff
new file mode 100644
index 000..4048941
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/hang-4.tiff differ
diff --git a/tools/source/stream/stream.cxx b/tools/source/stream/stream.cxx
index 002d9e5..bb6d21e 100644
--- a/tools/source/stream/stream.cxx
+++ b/tools/source/stream/stream.cxx
@@ -1464,7 +1464,7 @@ sal_uInt64 SvStream::remainingSize()
 {
 sal_uInt64 const nCurr = Tell();
 sal_uInt64 const nEnd = Seek(STREAM_SEEK_TO_END);
-sal_uInt64 nMaxAvailable = nEnd-nCurr;
+sal_uInt64 nMaxAvailable = nEnd  nCurr ? (nEnd-nCurr) : 0;
 Seek(nCurr);
 return nMaxAvailable;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - basctl/Library_basctl.mk basctl/source officecfg/registry svx/source

2015-07-17 Thread Maxim Monastirsky

 basctl/Library_basctl.mk|1 
 basctl/source/basicide/basidesh.cxx |2 
 basctl/source/basicide/tbxctl.cxx   |  143 
--
 basctl/source/basicide/tbxctl.hxx   |   58 
 officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu |   28 +
 svx/source/form/fmobjfac.cxx|1 
 svx/source/form/tbxform.cxx |  125 
 svx/source/inc/tbxform.hxx  |   20 -
 8 files changed, 28 insertions(+), 350 deletions(-)

New commits:
commit 1f6882348e74f7a3b7c144f693c99b7120c5b89b
Author: Maxim Monastirsky momonas...@gmail.com
Date:   Fri Jul 17 12:44:47 2015 +0300

Convert form control buttons to the generic controller

Change-Id: Ibecf33160d5d021e84e796f6b16db673f644699d

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
index ce96b6d..0c30cb6 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
@@ -201,6 +201,20 @@
   valueinsertcontrolsbar/value
 /prop
   /node
+  node oor:name=FormsControlsToolBox oor:op=replace
+prop oor:name=Command
+  value.uno:Config/value
+/prop
+prop oor:name=Module
+  value/
+/prop
+prop oor:name=Controller
+  valuecom.sun.star.comp.framework.SubToolBarController/value
+/prop
+prop oor:name=Value
+  valueformcontrols;.uno:Config/value
+/prop
+  /node
   node oor:name=AlignmentControl oor:op=replace
 prop oor:name=Command
   value.uno:ObjectAlign/value
diff --git a/svx/source/form/fmobjfac.cxx b/svx/source/form/fmobjfac.cxx
index 7538d04..a5e370b 100644
--- a/svx/source/form/fmobjfac.cxx
+++ b/svx/source/form/fmobjfac.cxx
@@ -61,7 +61,6 @@ FmFormObjFactory::FmFormObjFactory()
 
 
 // Konfigurations-::com::sun::star::frame::Controller und 
NavigationBar registrieren
-SvxFmTbxCtlConfig::RegisterControl( SID_FM_CONFIG );
 SvxFmTbxCtlAbsRec::RegisterControl( SID_FM_RECORD_ABSOLUTE );
 SvxFmTbxCtlRecText::RegisterControl( SID_FM_RECORD_TEXT );
 SvxFmTbxCtlRecFromText::RegisterControl( SID_FM_RECORD_FROM_TEXT );
diff --git a/svx/source/form/tbxform.cxx b/svx/source/form/tbxform.cxx
index a083537..a8ea0b9 100644
--- a/svx/source/form/tbxform.cxx
+++ b/svx/source/form/tbxform.cxx
@@ -100,131 +100,6 @@ void SvxFmAbsRecWin::KeyInput( const KeyEvent rKeyEvent )
 }
 
 
-// class SvxFmTbxCtlConfig
-
-
-struct MapSlotToCmd
-{
-sal_uInt16  nSlotId;
-const char* pCommand;
-};
-
-static const MapSlotToCmd SlotToCommands[] =
-{
-{ SID_FM_PUSHBUTTON,.uno:Pushbutton   },
-{ SID_FM_RADIOBUTTON,   .uno:RadioButton  },
-{ SID_FM_CHECKBOX,  .uno:CheckBox },
-{ SID_FM_FIXEDTEXT, .uno:Label},
-{ SID_FM_GROUPBOX,  .uno:GroupBox },
-{ SID_FM_LISTBOX,   .uno:ListBox  },
-{ SID_FM_COMBOBOX,  .uno:ComboBox },
-{ SID_FM_EDIT,  .uno:Edit },
-{ SID_FM_DBGRID,.uno:Grid },
-{ SID_FM_IMAGEBUTTON,   .uno:Imagebutton  },
-{ SID_FM_IMAGECONTROL,  .uno:ImageControl },
-{ SID_FM_FILECONTROL,   .uno:FileControl  },
-{ SID_FM_DATEFIELD, .uno:DateField},
-{ SID_FM_TIMEFIELD, .uno:TimeField},
-{ SID_FM_NUMERICFIELD,  .uno:NumericField },
-{ SID_FM_CURRENCYFIELD, .uno:CurrencyField},
-{ SID_FM_PATTERNFIELD,  .uno:PatternField },
-{ SID_FM_DESIGN_MODE,   .uno:SwitchControlDesignMode },
-{ SID_FM_FORMATTEDFIELD,.uno:FormattedField   },
-{ SID_FM_SCROLLBAR, .uno:ScrollBar},
-{ SID_FM_SPINBUTTON,.uno:SpinButton   },
-{ 0,  }
-};
-
-SFX_IMPL_TOOLBOX_CONTROL( SvxFmTbxCtlConfig, SfxUInt16Item );
-
-
-SvxFmTbxCtlConfig::SvxFmTbxCtlConfig( sal_uInt16 nSlotId, sal_uInt16 nId, 
ToolBox rTbx )
-: SfxToolBoxControl( nSlotId, nId, rTbx )
-,nLastSlot( 0 )
-{
-rTbx.SetItemBits( nId, ToolBoxItemBits::DROPDOWN | rTbx.GetItemBits( nId ) 
);
-}
-
-
-void SvxFmTbxCtlConfig::StateChanged(sal_uInt16 nSID, SfxItemState eState, 
const SfxPoolItem* pState )
-{
-if (nSID == SID_FM_CONFIG)
-{
-sal_uInt16 nSlot   = 0;
-if (eState = SfxItemState::DEFAULT)
-nSlot = static_castconst SfxUInt16Item*(pState)-GetValue();
-
-switch( nSlot )
-{
-case SID_FM_PUSHBUTTON:
-case SID_FM_RADIOBUTTON:
-case SID_FM_CHECKBOX:
-case

[Libreoffice-bugs] [Bug 30891] Toolbars too large with a bootleg UI theme on XP

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=30891

--- Comment #39 from Grey greym...@gmail.com ---
If someone could confirm that this is still an issue on 4.4 that would be 
great.
I confirm in version 4.4.4 and 5.0.0.3.
Windows 7 SP1 (64x).
Custom theme Elune from deviantart.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/qa filter/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/eps/fail/short-1.eps |binary
 filter/source/graphicfilter/ieps/ieps.cxx   |  249 ++--
 2 files changed, 125 insertions(+), 124 deletions(-)

New commits:
commit 74f07db7bd42929fad5daa9240ecf3244ebae8c0
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Thu Jul 16 16:44:16 2015 +0100

min size of eps for a preview is 32

(cherry picked from commit bf02304a0ea4771e01f39dd0032cbf276997ca00)

+

V668 no sense in testing the result of new against null

cherry-picked from
commit 556373c41fddbac6cbee1c89e7707631270a1852
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Wed Mar 11 09:06:08 2015 +

V668 no sense in testing the result of new against null

in order to merge simply

Change-Id: Icb82d9dd0a3918f2bdc4cb768c566774cd0d8ac4
Reviewed-on: https://gerrit.libreoffice.org/17133
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/filter/qa/cppunit/data/eps/fail/short-1.eps 
b/filter/qa/cppunit/data/eps/fail/short-1.eps
new file mode 100644
index 000..4b38b78
Binary files /dev/null and b/filter/qa/cppunit/data/eps/fail/short-1.eps differ
diff --git a/filter/source/graphicfilter/ieps/ieps.cxx 
b/filter/source/graphicfilter/ieps/ieps.cxx
index d70e471..12f9247 100644
--- a/filter/source/graphicfilter/ieps/ieps.cxx
+++ b/filter/source/graphicfilter/ieps/ieps.cxx
@@ -52,7 +52,7 @@ class FilterConfigItem;
 |*
 */
 
-static sal_uInt8* ImplSearchEntry( sal_uInt8* pSource, sal_uInt8* pDest, 
sal_uLong nComp, sal_uLong nSize )
+static sal_uInt8* ImplSearchEntry( sal_uInt8* pSource, sal_uInt8 const * 
pDest, sal_uLong nComp, sal_uLong nSize )
 {
 while ( nComp-- = nSize )
 {
@@ -71,7 +71,7 @@ static sal_uInt8* ImplSearchEntry( sal_uInt8* pSource, 
sal_uInt8* pDest, sal_uLo
 
 
 // SecurityCount is the buffersize of the buffer in which we will parse for a 
number
-static long ImplGetNumber( sal_uInt8 **pBuf, int nSecurityCount )
+static long ImplGetNumber( sal_uInt8 **pBuf, sal_uInt32 nSecurityCount )
 {
 boolbValid = true;
 boolbNegative = false;
@@ -504,7 +504,7 @@ void MakePreview(sal_uInt8* pBuf, sal_uInt32 nBytesRead,
 if ( pDest )
 {
 pDest += 16;
-int nCount = 4;
+sal_uInt32 nCount = 4;
 long nNumber = ImplGetNumber( pDest, nCount );
 if ( nCount  ( (sal_uInt32)nNumber  10 ) )
 {
@@ -595,162 +595,163 @@ GraphicImport( SvStream  rStream, Graphic  rGraphic, 
FilterConfigItem* )
 {
 rStream.Seek( nPSStreamPos );
 sal_uInt8* pBuf = new sal_uInt8[ nPSSize ];
-if ( pBuf )
+
+sal_uInt32 nBufStartPos = rStream.Tell();
+sal_uInt32 nBytesRead = rStream.Read( pBuf, nPSSize );
+if ( nBytesRead == nPSSize )
 {
-sal_uInt32  nBufStartPos = rStream.Tell();
-sal_uInt32  nBytesRead = rStream.Read( pBuf, nPSSize );
-if ( nBytesRead == nPSSize )
+sal_uInt32 nSecurityCount = 32;
+// if there is no tiff/wmf preview, we will parse for an preview in
+// the eps prolog
+if (!bHasPreview  nBytesRead = nSecurityCount)
 {
-int nSecurityCount = 32;
-if ( !bHasPreview ) // if there is no tiff/wmf preview, we 
will parse for an preview in the eps prolog
+sal_uInt8* pDest = ImplSearchEntry( pBuf, 
reinterpret_castsal_uInt8 const *(%%BeginPreview:), nBytesRead - 
nSecurityCount, 15 );
+if ( pDest  )
 {
-sal_uInt8* pDest = ImplSearchEntry( pBuf, 
(sal_uInt8*)%%BeginPreview:, nBytesRead - 32, 15 );
-if ( pDest  )
+pDest += 15;
+long nWidth = ImplGetNumber( pDest, nSecurityCount );
+long nHeight = ImplGetNumber( pDest, nSecurityCount );
+long nBitDepth = ImplGetNumber( pDest, nSecurityCount );
+long nScanLines = ImplGetNumber( pDest, nSecurityCount );
+pDest = ImplSearchEntry( pDest, (sal_uInt8*)%, 16, 1 );  
 // go to the first Scanline
+if ( nSecurityCount  pDest  nWidth  nHeight  ( ( 
nBitDepth == 1 ) || ( nBitDepth == 8 ) )  nScanLines )
 {
-pDest += 15;
-long nWidth = ImplGetNumber( pDest, nSecurityCount );
-long nHeight = ImplGetNumber( pDest, nSecurityCount );
-long nBitDepth = ImplGetNumber( pDest, nSecurityCount 
);
-long nScanLines = ImplGetNumber( pDest, 
nSecurityCount );
-pDest = ImplSearchEntry( pDest, (sal_uInt8*)%, 16, 1 
);   // go to the first Scanline
-if ( nSecurityCount  pDest  nWidth

[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/qa filter/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/tiff/fail/hang-1.tiff |binary
 filter/source/graphicfilter/itiff/itiff.cxx  |7 +--
 2 files changed, 5 insertions(+), 2 deletions(-)

New commits:
commit 94a6a1b5ab728bbafa8b880b07e1f4da48d87e8b
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 09:45:26 2015 +0100

test that nNumStripOffsets value is within bounds of file

Change-Id: I1483ea3671420be5349692374641e10b344d
(cherry picked from commit feedb957310fc3282ca47d5ffc1482dbb944a36e)
Reviewed-on: https://gerrit.libreoffice.org/17152
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/filter/qa/cppunit/data/tiff/fail/hang-1.tiff 
b/filter/qa/cppunit/data/tiff/fail/hang-1.tiff
new file mode 100644
index 000..9cd2aa2
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/hang-1.tiff differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index 0474c5b..92d7a3c 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -383,14 +383,17 @@ void TIFFReader::ReadTagData( sal_uInt16 nTagType, 
sal_uInt32 nDataLen)
 nNumStripOffsets = 0;
 nOldNumSO = nNumStripOffsets;
 nDataLen += nOldNumSO;
-if ( ( nDataLen  nOldNumSO )  ( nDataLen  SAL_MAX_UINT32 / 
sizeof( sal_uInt32 ) ) )
+size_t nMaxAllocAllowed = SAL_MAX_UINT32 / sizeof(sal_uInt32);
+size_t nMaxRecordsAvailable = pTIFF-remainingSize() / 
DataTypeSize();
+if (nDataLen  nOldNumSO  nDataLen  nMaxAllocAllowed 
+(nDataLen - nOldNumSO) = nMaxRecordsAvailable)
 {
 nNumStripOffsets = nDataLen;
 try
 {
 pStripOffsets = new sal_uLong[ nNumStripOffsets ];
 }
-catch (const std::bad_alloc )
+catch (const std::bad_alloc )
 {
 pStripOffsets = NULL;
 nNumStripOffsets = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/source

2015-07-17 Thread Caolán McNamara

 filter/source/msfilter/msdffimp.cxx |   10 --
 1 file changed, 4 insertions(+), 6 deletions(-)

New commits:
commit cc51edd792359b78fc55260506ce087ade3dc2fa
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Thu Jul 16 14:53:37 2015 +0100

Resolves: tdf#92772 missing shape bg color

regression from dcad3ac445980740b6a39761cdd1f1bd0b3e6e34

coverity#1242624 Untrusted loop bound

Change-Id: Idf52c09828c2bab767e9ff0d07b61befd6bfc64b

The original code read 8 bytes on the nElemSizeVert == 8
branch and always 4 otherwise. I assumed that nElemSizeVert had
to be read as 4 on that branch, but apparently not. So if its
not 4, set it to 4 and we get the same behaviour as originally
and continue to ensure we bounds check the loop

Change-Id: Ica8ab7cc3bbebee93216766a2e1279a579494840
(cherry picked from commit b3cd47bd562f98ec5fcff1a9d7609353506b5083)
Reviewed-on: https://gerrit.libreoffice.org/17134
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com

diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index 9e88ceb..ba0aae0 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -2154,12 +2154,10 @@ void 
DffPropertyReader::ApplyCustomShapeGeometryAttributes( SvStream rIn, SfxIt
 sal_uInt16 nNumElemMemVert = 0;
 rIn.ReadUInt16( nNumElemVert ).ReadUInt16( nNumElemMemVert 
).ReadUInt16( nElemSizeVert );
 }
-bool bImport = false;
-if (nElemSizeVert == 8 || nElemSizeVert == 4)
-{
-//sanity check that the stream is long enough to fulfill 
nNumElem * nElemSize;
-bImport = rIn.remainingSize() / nElemSizeVert = nNumElemVert;
-}
+if (nElemSizeVert != 8)
+nElemSizeVert = 4;
+//sanity check that the stream is long enough to fulfill nNumElem 
* nElemSize;
+bool bImport = rIn.remainingSize() / nElemSizeVert = nNumElemVert;
 if (bImport)
 {
 aCoordinates.realloc( nNumElemVert );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basctl/source

2015-07-17 Thread Noel Grandin

 basctl/source/basicide/basicbox.hxx|4 -
 basctl/source/basicide/basicrenderable.cxx |2 
 basctl/source/basicide/basicrenderable.hxx |   22 ++---
 basctl/source/basicide/baside2.hxx |   18 ++--
 basctl/source/basicide/baside3.cxx |6 -
 basctl/source/basicide/basides1.cxx|2 
 basctl/source/basicide/basidesh.cxx|4 -
 basctl/source/basicide/doceventnotifier.cxx|2 
 basctl/source/basicide/documentenumeration.cxx |6 -
 basctl/source/basicide/localizationmgr.cxx |2 
 basctl/source/basicide/moduldl2.cxx|2 
 basctl/source/basicide/moduldlg.hxx|4 -
 basctl/source/basicide/unomodel.hxx|   38 +-
 basctl/source/dlged/dlged.cxx  |   18 ++--
 basctl/source/dlged/dlgedfac.cxx   |4 -
 basctl/source/dlged/dlgedlist.cxx  |   12 +--
 basctl/source/dlged/dlgedobj.cxx   |   16 ++--
 basctl/source/dlged/propbrw.cxx|6 -
 basctl/source/inc/accessibledialogcontrolshape.hxx |   66 -
 basctl/source/inc/accessibledialogwindow.hxx   |   78 ++---
 basctl/source/inc/baside3.hxx  |6 -
 basctl/source/inc/basidectrlr.hxx  |8 +-
 basctl/source/inc/basidesh.hxx |8 +-
 basctl/source/inc/basobj.hxx   |   10 +-
 basctl/source/inc/bastypes.hxx |6 -
 basctl/source/inc/dlged.hxx|   28 +++
 basctl/source/inc/dlgedclip.hxx|   18 ++--
 basctl/source/inc/dlgedfac.hxx |4 -
 basctl/source/inc/dlgedlist.hxx|   16 ++--
 basctl/source/inc/dlgedobj.hxx |   30 
 basctl/source/inc/doceventnotifier.hxx |2 
 basctl/source/inc/localizationmgr.hxx  |   64 -
 basctl/source/inc/managelang.hxx   |   10 +-
 basctl/source/inc/propbrw.hxx  |   24 ++
 basctl/source/inc/scriptdocument.hxx   |   26 +++
 35 files changed, 283 insertions(+), 289 deletions(-)

New commits:
commit 9cde33eba193f23cf501acb108992bfcc5c16f52
Author: Noel Grandin n...@peralex.com
Date:   Fri Jul 17 15:49:35 2015 +0200

com::sun::star-css in basctl

Change-Id: If0013cdd734a58397ab4972f9cca5584f05d1715
Reviewed-on: https://gerrit.libreoffice.org/17164
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com

diff --git a/basctl/source/basicide/basicbox.hxx 
b/basctl/source/basicide/basicbox.hxx
index 3e4cc80..0ff594c 100644
--- a/basctl/source/basicide/basicbox.hxx
+++ b/basctl/source/basicide/basicbox.hxx
@@ -77,7 +77,7 @@ private:
 OUStringaCurText;
 boolbIgnoreSelect;
 boolbFillBox;
-com::sun::star::uno::Reference ::com::sun::star::frame::XFrame  m_xFrame;
+css::uno::Reference css::frame::XFrame  m_xFrame;
 
 static void ReleaseFocus();
 voidInsertEntries( const ScriptDocument rDocument, 
LibraryLocation eLocation );
@@ -94,7 +94,7 @@ protected:
 
 public:
 LibBox( vcl::Window* pParent,
- const com::sun::star::uno::Reference 
::com::sun::star::frame::XFrame  rFrame );
+const css::uno::Reference css::frame::XFrame  
rFrame );
 virtual ~LibBox();
 virtual voiddispose() SAL_OVERRIDE;
 
diff --git a/basctl/source/basicide/basicrenderable.cxx 
b/basctl/source/basicide/basicrenderable.cxx
index 61b7d2f..93f1acd 100644
--- a/basctl/source/basicide/basicrenderable.cxx
+++ b/basctl/source/basicide/basicrenderable.cxx
@@ -34,7 +34,7 @@ using namespace com::sun::star;
 using namespace com::sun::star::uno;
 
 Renderable::Renderable (BaseWindow* pWin)
-: cppu::WeakComponentImplHelper com::sun::star::view::XRenderable ( maMutex )
+: cppu::WeakComponentImplHelper css::view::XRenderable ( maMutex )
 , mpWindow( pWin )
 {
 ResStringArray aStrings( IDEResId( RID_PRINTDLG_STRLIST )  );
diff --git a/basctl/source/basicide/basicrenderable.hxx 
b/basctl/source/basicide/basicrenderable.hxx
index dba38c8..9fce279 100644
--- a/basctl/source/basicide/basicrenderable.hxx
+++ b/basctl/source/basicide/basicrenderable.hxx
@@ -30,7 +30,7 @@ namespace basctl
 class BaseWindow;
 
 class Renderable :
-public cppu::WeakComponentImplHelper com::sun::star::view::XRenderable ,
+public cppu::WeakComponentImplHelper css::view::XRenderable ,
 public vcl::PrinterOptionsHelper
 {
 VclPtrBaseWindow  mpWindow;
@@ -43,21 +43,21 @@ public:
 
 // XRenderable
 virtual sal_Int32 SAL_CALL getRendererCount (
-const com::sun::star::uno::Any aSelection,
-const

[Libreoffice-bugs] [Bug 92804] New: Style information not updating

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92804

Bug ID: 92804
   Summary: Style information not updating
   Product: LibreOffice
   Version: 5.0.0.3 rc
  Hardware: Other
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kermit.sa...@gmail.com

With text document having multiple styles open and properties pane displayed.
Moving the cursor through the document text does not correctly update the
corresponding styles in the property pane. ie. font color is always default or
as last modified. 

To reproduce: 

Select text in document and apply style. 
Change font color in style. 
Update Style. 
Move cursor do other location in document with different style. 

Result: Font property in property pane remains as per changes made in previous
step.

Expected result: Font property changes as per corresponding style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - sw/source vcl/unx

2015-07-17 Thread Caolán McNamara

 sw/source/uibase/docvw/edtwin.cxx  |2 +-
 vcl/unx/gtk/app/gtkdata.cxx|2 +-
 vcl/unx/gtk/window/gtksalframe.cxx |   11 ++-
 3 files changed, 12 insertions(+), 3 deletions(-)

New commits:
commit d9b2105e14b7f84c24ced4faea1795e32d8e21d1
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 13:51:16 2015 +0100

wayland: actually show something

Change-Id: Icd081c38de1374c6bfd6fb04d7765e07ff5d1aff

diff --git a/vcl/unx/gtk/app/gtkdata.cxx b/vcl/unx/gtk/app/gtkdata.cxx
index b1e552b..c42c68d 100644
--- a/vcl/unx/gtk/app/gtkdata.cxx
+++ b/vcl/unx/gtk/app/gtkdata.cxx
@@ -52,7 +52,7 @@
 # endif
 #else
 # define GDK_WINDOWING_X11
-# define GDK_IS_X11_DISPLAY(foo) true
+# define GDK_IS_X11_DISPLAY(foo) (true)
 #endif
 
 using namespace vcl_sal;
diff --git a/vcl/unx/gtk/window/gtksalframe.cxx 
b/vcl/unx/gtk/window/gtksalframe.cxx
index 3bedf78..bdb360a 100644
--- a/vcl/unx/gtk/window/gtksalframe.cxx
+++ b/vcl/unx/gtk/window/gtksalframe.cxx
@@ -105,6 +105,12 @@
 #define IS_WIDGET_MAPPED   GTK_WIDGET_MAPPED
 #endif
 
+#if !GTK_CHECK_VERSION(3,10,0)
+#define GDK_WINDOWING_X11
+#define GDK_IS_X11_DISPLAY(foo) (true)
+#endif
+
+
 using namespace com::sun::star;
 
 int GtkSalFrame::m_nFloats = 0;
@@ -1093,7 +1099,10 @@ void GtkSalFrame::InitCommon()
 m_nHudAwarenessId   = 0;
 
 gtk_widget_set_app_paintable( m_pWindow, TRUE );
-gtk_widget_set_double_buffered( m_pWindow, FALSE );
+/*non-X11 displays won't show anything at all without double-buffering
+  enabled*/
+if (GDK_IS_X11_DISPLAY(getGdkDisplay()))
+gtk_widget_set_double_buffered( m_pWindow, FALSE );
 gtk_widget_set_redraw_on_allocate( m_pWindow, FALSE );
 
 gtk_widget_add_events( m_pWindow,
commit e5a17569366188420394fd9461c821c0d83e98e7
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 14:32:41 2015 +0100

ignore long press after all in writer

it appears on a long press on anything not just the document,
e.g. on scrollbars etc, which isn't that useful after all

Change-Id: Ic6ccacecdad5db100d2f2768ad6b7ce5e36b80a3

diff --git a/sw/source/uibase/docvw/edtwin.cxx 
b/sw/source/uibase/docvw/edtwin.cxx
index 510518e..1ca2bf9 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -5123,7 +5123,6 @@ void SwEditWin::Command( const CommandEvent rCEvt )
 switch ( rCEvt.GetCommand() )
 {
 case CommandEventId::ContextMenu:
-case CommandEventId::LongPress:
 {
 const sal_uInt16 nId = SwInputChild::GetChildWindowId();
 SwInputChild* pChildWin = 
static_castSwInputChild*(GetView().GetViewFrame()-
@@ -5208,6 +5207,7 @@ void SwEditWin::Command( const CommandEvent rCEvt )
 bCallBase = !m_rView.HandleWheelCommands( rCEvt );
 break;
 
+case CommandEventId::LongPress:
 case CommandEventId::Swipe: //nothing yet
 break;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: avmedia/source

2015-07-17 Thread Noel Grandin

 avmedia/source/framework/mediaitem.cxx|4 -
 avmedia/source/opengl/oglframegrabber.hxx |   12 ++---
 avmedia/source/opengl/oglmanager.hxx  |3 -
 avmedia/source/opengl/oglplayer.hxx   |   39 +-
 avmedia/source/opengl/oglwindow.hxx   |   63 ++
 5 files changed, 59 insertions(+), 62 deletions(-)

New commits:
commit ad0c0f685b14119e2e564fe0074f5f0c557a5e5f
Author: Noel Grandin n...@peralex.com
Date:   Fri Jul 17 15:20:15 2015 +0200

com::sun::star-css in avmedia

Change-Id: Iab0a96e929002c587f6fb7baa75ab206feede119
Reviewed-on: https://gerrit.libreoffice.org/17163
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com

diff --git a/avmedia/source/framework/mediaitem.cxx 
b/avmedia/source/framework/mediaitem.cxx
index cc7f22d..758c334 100644
--- a/avmedia/source/framework/mediaitem.cxx
+++ b/avmedia/source/framework/mediaitem.cxx
@@ -137,7 +137,7 @@ bool MediaItem::GetPresentation( SfxItemPresentation,
 return false;
 }
 
-bool MediaItem::QueryValue( com::sun::star::uno::Any rVal, sal_uInt8 ) const
+bool MediaItem::QueryValue( css::uno::Any rVal, sal_uInt8 ) const
 {
 uno::Sequence uno::Any  aSeq( 10 );
 
@@ -157,7 +157,7 @@ bool MediaItem::QueryValue( com::sun::star::uno::Any rVal, 
sal_uInt8 ) const
 return true;
 }
 
-bool MediaItem::PutValue( const com::sun::star::uno::Any rVal, sal_uInt8 )
+bool MediaItem::PutValue( const css::uno::Any rVal, sal_uInt8 )
 {
 uno::Sequence uno::AnyaSeq;
 boolbRet = false;
diff --git a/avmedia/source/opengl/oglframegrabber.hxx 
b/avmedia/source/opengl/oglframegrabber.hxx
index bcb7e22..30c621e 100644
--- a/avmedia/source/opengl/oglframegrabber.hxx
+++ b/avmedia/source/opengl/oglframegrabber.hxx
@@ -18,8 +18,8 @@
 
 namespace avmedia { namespace ogl {
 
-typedef ::cppu::WeakImplHelper com::sun::star::media::XFrameGrabber,
-com::sun::star::lang::XServiceInfo  
FrameGrabber_BASE;
+typedef ::cppu::WeakImplHelper css::media::XFrameGrabber,
+css::lang::XServiceInfo  FrameGrabber_BASE;
 
 class OGLFrameGrabber : public FrameGrabber_BASE
 {
@@ -29,12 +29,12 @@ public:
 virtual ~OGLFrameGrabber();
 
 // XFrameGrabber
-virtual com::sun::star::uno::Reference com::sun::star::graphic::XGraphic 
 SAL_CALL grabFrame( double fMediaTime ) throw 
(com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
+virtual css::uno::Reference css::graphic::XGraphic  SAL_CALL grabFrame( 
double fMediaTime ) throw (css::uno::RuntimeException, std::exception) 
SAL_OVERRIDE;
 
 // XServiceInfo
-virtual OUString SAL_CALL getImplementationName() throw 
(com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
-virtual sal_Bool SAL_CALL supportsService( const OUString rServiceName ) 
throw (com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
-virtual com::sun::star::uno::Sequence OUString  SAL_CALL 
getSupportedServiceNames() throw (com::sun::star::uno::RuntimeException, 
std::exception) SAL_OVERRIDE;
+virtual OUString SAL_CALL getImplementationName() throw 
(css::uno::RuntimeException, std::exception) SAL_OVERRIDE;
+virtual sal_Bool SAL_CALL supportsService( const OUString rServiceName ) 
throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE;
+virtual css::uno::Sequence OUString  SAL_CALL getSupportedServiceNames() 
throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE;
 
 private:
 libgltf::glTFHandle m_rHandle;
diff --git a/avmedia/source/opengl/oglmanager.hxx 
b/avmedia/source/opengl/oglmanager.hxx
index 8b77661..c9823b7 100644
--- a/avmedia/source/opengl/oglmanager.hxx
+++ b/avmedia/source/opengl/oglmanager.hxx
@@ -17,8 +17,7 @@
 
 namespace avmedia { namespace ogl {
 
-class OGLManager : public ::cppu::WeakImplHelper 
com::sun::star::media::XManager,
-  
com::sun::star::lang::XServiceInfo 
+class OGLManager : public ::cppu::WeakImplHelper css::media::XManager, 
css::lang::XServiceInfo 
 {
 public:
 
diff --git a/avmedia/source/opengl/oglplayer.hxx 
b/avmedia/source/opengl/oglplayer.hxx
index a8bf92d..64f8540 100644
--- a/avmedia/source/opengl/oglplayer.hxx
+++ b/avmedia/source/opengl/oglplayer.hxx
@@ -26,8 +26,7 @@ namespace avmedia { namespace ogl {
 
 class OGLWindow;
 
-typedef ::cppu::WeakComponentImplHelper com::sun::star::media::XPlayer,
- com::sun::star::lang::XServiceInfo  
Player_BASE;
+typedef ::cppu::WeakComponentImplHelper css::media::XPlayer, 
css::lang::XServiceInfo  Player_BASE;
 
 class OGLPlayer : public cppu::BaseMutex,
   public Player_BASE
@@ -41,25 +40,25 @@ public:
 void releaseInputFiles();
 
 // XPlayer
-virtual void SAL_CALL start() throw 
(com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
-

[Libreoffice-commits] core.git: accessibility/inc accessibility/source

2015-07-17 Thread Noel Grandin

 accessibility/inc/accessibility/extended/AccessibleBrowseBox.hxx   
|   90 ++---
 accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx   
|  147 
 accessibility/inc/accessibility/extended/AccessibleBrowseBoxCheckBoxCell.hxx   
|   26 -
 accessibility/inc/accessibility/extended/AccessibleBrowseBoxHeaderBar.hxx  
|  118 +++
 accessibility/inc/accessibility/extended/AccessibleBrowseBoxHeaderCell.hxx 
|   16 
 accessibility/inc/accessibility/extended/AccessibleBrowseBoxTable.hxx  
|   73 ++--
 accessibility/inc/accessibility/extended/AccessibleBrowseBoxTableBase.hxx  
|   71 ++--
 accessibility/inc/accessibility/extended/AccessibleBrowseBoxTableCell.hxx  
|   71 ++--
 accessibility/inc/accessibility/extended/AccessibleGridControl.hxx 
|   71 +---
 accessibility/inc/accessibility/extended/AccessibleGridControlBase.hxx 
|  117 +++
 accessibility/inc/accessibility/extended/AccessibleGridControlHeader.hxx   
|   84 ++---
 accessibility/inc/accessibility/extended/AccessibleGridControlHeaderCell.hxx   
|   26 -
 accessibility/inc/accessibility/extended/AccessibleGridControlTable.hxx
|  110 +++---
 accessibility/inc/accessibility/extended/AccessibleGridControlTableBase.hxx
|   83 ++---
 accessibility/inc/accessibility/extended/AccessibleGridControlTableCell.hxx
|   69 ++--
 accessibility/inc/accessibility/extended/AccessibleToolPanelDeck.hxx   
|   16 
 accessibility/inc/accessibility/extended/AccessibleToolPanelDeckTabBar.hxx 
|   14 
 accessibility/inc/accessibility/extended/AccessibleToolPanelDeckTabBarItem.hxx 
|   34 +-
 accessibility/inc/accessibility/extended/accessiblebrowseboxcell.hxx   
|6 
 accessibility/inc/accessibility/extended/accessibleeditbrowseboxcell.hxx   
|   54 +--
 accessibility/inc/accessibility/extended/accessibleiconchoicectrl.hxx  
|   48 +-
 accessibility/inc/accessibility/extended/accessibleiconchoicectrlentry.hxx 
|  126 +++
 accessibility/inc/accessibility/extended/accessiblelistbox.hxx 
|   52 +--
 accessibility/inc/accessibility/extended/accessiblelistboxentry.hxx
|  165 --
 accessibility/inc/accessibility/extended/accessibletabbar.hxx  
|   50 +--
 accessibility/inc/accessibility/extended/accessibletabbarpage.hxx  
|   52 +--
 accessibility/inc/accessibility/extended/accessibletabbarpagelist.hxx  
|   66 ++--
 accessibility/inc/accessibility/extended/accessibletablistbox.hxx  
|   19 -
 accessibility/inc/accessibility/extended/accessibletablistboxtable.hxx 
|   22 -
 accessibility/inc/accessibility/extended/listboxaccessible.hxx 
|2 
 accessibility/inc/accessibility/extended/textwindowaccessibility.hxx   
|   25 -
 accessibility/inc/accessibility/helper/IComboListBoxHelper.hxx 
|2 
 accessibility/inc/accessibility/helper/characterattributeshelper.hxx   
|6 
 accessibility/inc/accessibility/helper/listboxhelper.hxx   
|2 
 accessibility/inc/accessibility/standard/accessiblemenubasecomponent.hxx   
|   20 -
 accessibility/inc/accessibility/standard/accessiblemenucomponent.hxx   
|   50 +--
 accessibility/inc/accessibility/standard/accessiblemenuitemcomponent.hxx   
|   34 +-
 accessibility/inc/accessibility/standard/vclxaccessiblebox.hxx 
|   58 +--
 accessibility/inc/accessibility/standard/vclxaccessiblebutton.hxx  
|   26 -
 accessibility/inc/accessibility/standard/vclxaccessiblecheckbox.hxx
|   24 -
 accessibility/inc/accessibility/standard/vclxaccessiblecombobox.hxx
|6 
 accessibility/inc/accessibility/standard/vclxaccessibledropdowncombobox.hxx
|6 
 accessibility/inc/accessibility/standard/vclxaccessibledropdownlistbox.hxx 
|6 
 accessibility/inc/accessibility/standard/vclxaccessibleedit.hxx
|   70 ++--
 accessibility/inc/accessibility/standard/vclxaccessiblefixedhyperlink.hxx  
|6 
 accessibility/inc/accessibility/standard/vclxaccessiblefixedtext.hxx   
|6 
 accessibility/inc/accessibility/standard/vclxaccessiblelist.hxx
|   67 ++--
 accessibility/inc/accessibility/standard/vclxaccessiblelistbox.hxx 
|6 
 accessibility/inc/accessibility/standard/vclxaccessiblelistitem.hxx
|  125 +++
 accessibility/inc/accessibility/standard/vclxaccessiblemenu.hxx
|   30 -
 accessibility/inc/accessibility/standard/vclxaccessiblemenubar.hxx 
|   10 
 accessibility/inc/accessibility/standard/vclxaccessiblemenuitem.hxx
|   66 ++--
 accessibility/inc/accessibility/standard/vclxaccessiblemenuseparator.hxx   
|6 
 accessibility/inc/accessibility/standard/vclxaccessiblepopupmenu.hxx   
|   10

[Libreoffice-commits] core.git: sc/inc sc/source

2015-07-17 Thread Eike Rathke

 sc/inc/document.hxx  |8 
 sc/inc/global.hxx|7 ---
 sc/source/core/data/documen2.cxx |2 ++
 sc/source/core/data/document.cxx |   11 +++
 sc/source/core/tool/dbdata.cxx   |   22 +-
 sc/source/ui/docshell/docsh5.cxx |   16 +++-
 sc/source/ui/view/dbfunc.cxx |2 +-
 7 files changed, 62 insertions(+), 6 deletions(-)

New commits:
commit 8eadeb91cde9709f006e8c5e19e98bff44dbd177
Author: Eike Rathke er...@redhat.com
Date:   Fri Jul 17 15:21:48 2015 +0200

Resolves: tdf#77479 do not reset AutoFilter range for temporary operations

Change-Id: I22f5e74ca91eb188ce669762927dd25604a256ff

diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 0e6c7e3..74f25b8 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -319,6 +319,7 @@ private:
 ScScriptTypeData*   pScriptTypeData;
 ScRefreshTimerControl* pRefreshTimerControl;
 rtl::ReferenceSvxForbiddenCharactersTable xForbiddenCharacters;
+ScDBData*   mpAnonymousDBData;
 
 ScFieldEditEngine*  pCacheFieldEditEngine;
 
@@ -612,6 +613,13 @@ public:
 SC_DLLPUBLIC void SetAnonymousDBData(SCTAB nTab, ScDBData* pDBData);
 SC_DLLPUBLIC ScDBData* GetAnonymousDBData(SCTAB nTab);
 
+/** One document global anonymous database range for temporary operations,
+used if the corresponding sheet-local anonymous database range is
+already used with AutoFilter and range differs. Not stored in document
+files. */
+SC_DLLPUBLIC void SetAnonymousDBData(ScDBData* pDBData);
+SC_DLLPUBLIC ScDBData* GetAnonymousDBData();
+
 SC_DLLPUBLIC SCTAB GetTableCount() const;
 SvNumberFormatterIndexTable* GetFormatExchangeList() const { return 
pFormatExchangeList; }
 
diff --git a/sc/inc/global.hxx b/sc/inc/global.hxx
index 1691745..c7e250f 100644
--- a/sc/inc/global.hxx
+++ b/sc/inc/global.hxx
@@ -408,9 +408,10 @@ enum ScAnchorType   // anchor of a 
character object
 
 enum ScGetDBMode
 {
-SC_DB_MAKE, // create untitled (if necessary)
-SC_DB_IMPORT,   // create Importx (if necessary)
-SC_DB_OLD   // don't create
+SC_DB_MAKE, /// create untitled (if necessary)
+SC_DB_AUTOFILTER,   /// force use of sheet-local instead of document 
global anonymous range
+SC_DB_IMPORT,   /// create Importx (if necessary)
+SC_DB_OLD   /// don't create
 };
 
 /// For ScDBFunc::GetDBData()
diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx
index 8d3e4e3..5b02cf7 100644
--- a/sc/source/core/data/documen2.cxx
+++ b/sc/source/core/data/documen2.cxx
@@ -156,6 +156,7 @@ ScDocument::ScDocument( ScDocumentMode eMode, 
SfxObjectShell* pDocShell ) :
 pUnoRefUndoList( NULL ),
 pChangeViewSettings( NULL ),
 pScriptTypeData( NULL ),
+mpAnonymousDBData( NULL ),
 pCacheFieldEditEngine( NULL ),
 pViewOptions( NULL ),
 pDocOptions( NULL ),
@@ -427,6 +428,7 @@ ScDocument::~ScDocument()
 pVirtualDevice_100th_mm.disposeAndClear();
 
 delete pDPCollection;
+delete mpAnonymousDBData;
 
 // delete the EditEngine before destroying the xPoolHelper
 delete pCacheFieldEditEngine;
diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index 95655f2..c0f83ca 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -302,6 +302,17 @@ void ScDocument::SetAnonymousDBData(SCTAB nTab, ScDBData* 
pDBData)
 maTabs[nTab]-SetAnonymousDBData(pDBData);
 }
 
+void ScDocument::SetAnonymousDBData( ScDBData* pDBData )
+{
+delete mpAnonymousDBData;
+mpAnonymousDBData = pDBData;
+}
+
+ScDBData* ScDocument::GetAnonymousDBData()
+{
+return mpAnonymousDBData;
+}
+
 bool ScDocument::ValidTabName( const OUString rName )
 {
 if (rName.isEmpty())
diff --git a/sc/source/core/tool/dbdata.cxx b/sc/source/core/tool/dbdata.cxx
index e91f2b1..92c47e5 100644
--- a/sc/source/core/tool/dbdata.cxx
+++ b/sc/source/core/tool/dbdata.cxx
@@ -945,6 +945,8 @@ const ScDBData* ScDBCollection::GetDBAtCursor(SCCOL nCol, 
SCROW nRow, SCTAB nTab
 if (pData)
 return pData;
 
+// Do NOT check for the document global temporary anonymous db range here.
+
 return NULL;
 }
 
@@ -967,6 +969,8 @@ ScDBData* ScDBCollection::GetDBAtCursor(SCCOL nCol, SCROW 
nRow, SCTAB nTab, bool
 if (pData)
 return const_castScDBData*(pData);
 
+// Do NOT check for the document global temporary anonymous db range here.
+
 return NULL;
 }
 
@@ -986,7 +990,17 @@ const ScDBData* ScDBCollection::GetDBAtArea(SCTAB nTab, 
SCCOL nCol1, SCROW nRow1
 return pNoNameData;
 
 // Lastly, check the global anonymous db ranges.
-return maAnonDBs.findByRange(aRange);
+const ScDBData* pData = maAnonDBs.findByRange(aRange);
+if (pData)
+return pData;
+
+// As a last resort, check for the document global temporary

[Libreoffice-bugs] [Bug 92803] Bad quality generated pdf and a very large file sizes

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92803

--- Comment #1 from Tomas Kralik krali...@gmail.com ---
Created attachment 117294
  -- https://bugs.documentfoundation.org/attachment.cgi?id=117294action=edit
generated pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92767] Autofilter on date is locale dependent

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92767

GerardF gerard.farg...@orange.fr changed:

   What|Removed |Added

 CC||gerard.farg...@orange.fr

--- Comment #3 from GerardF gerard.farg...@orange.fr ---
Error happens when Locale use M/D and cell is formatted with D/M. (or
vice-versa)
When both cell formatting and cell format use the same Month/Day order, there
is no problem.

Filtering on June is correct with French locale. (As both French and Autralian
use D/M)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75025] LibreOffice 4.3 most annoying bugs

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=75025
Bug 75025 depends on bug 77479, which changed state.

Bug 77479 Summary: Calc: State of AutoFilter lost after sorting
https://bugs.documentfoundation.org/show_bug.cgi?id=77479

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92803] Bad quality generated pdf and a very large file sizes

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92803

--- Comment #2 from Tomas Kralik krali...@gmail.com ---
Created attachment 117295
  -- https://bugs.documentfoundation.org/attachment.cgi?id=117295action=edit
inputDocument

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77479] Calc: State of AutoFilter lost after sorting

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=77479

Eike Rathke er...@redhat.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92803] Bad quality generated pdf and a very large file sizes

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92803

--- Comment #3 from Tomas Kralik krali...@gmail.com ---
Created attachment 117296
  -- https://bugs.documentfoundation.org/attachment.cgi?id=117296action=edit
OpenOffice_3.2.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 75025] LibreOffice 4.3 most annoying bugs

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=75025
Bug 75025 depends on bug 77479, which changed state.

Bug 77479 Summary: Calc: State of AutoFilter lost after sorting
https://bugs.documentfoundation.org/show_bug.cgi?id=77479

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 92803] Bad quality generated pdf and a very large file sizes

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92803

--- Comment #4 from Tomas Kralik krali...@gmail.com ---
Created attachment 117297
  -- https://bugs.documentfoundation.org/attachment.cgi?id=117297action=edit
LibreOffice_4.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92803] Bad quality generated pdf and a very large file sizes

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92803

--- Comment #6 from Tomas Kralik krali...@gmail.com ---
Created attachment 117299
  -- https://bugs.documentfoundation.org/attachment.cgi?id=117299action=edit
OO_3.2.1-pdf_picture_8x_zoom

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92803] Bad quality generated pdf and a very large file sizes

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92803

--- Comment #5 from Tomas Kralik krali...@gmail.com ---
Created attachment 117298
  -- https://bugs.documentfoundation.org/attachment.cgi?id=117298action=edit
LibreOffice_5.0.0.3_RC

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92803] Bad quality generated pdf and a very large file sizes

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92803

--- Comment #9 from Tomas Kralik krali...@gmail.com ---
Files Input_odt_document_for_generated_pdf.odt and generated.pdf are
unnecessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92802] New: Calc file with large ods file slow on FILEOPEN FILESAVE REGRESSION

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92802

Bug ID: 92802
   Summary: Calc file with large ods file slow on FILEOPEN
FILESAVE REGRESSION
   Product: LibreOffice
   Version: 4.2.0.4 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: msrame...@gmail.com

Created attachment 117292
  -- https://bugs.documentfoundation.org/attachment.cgi?id=117292action=edit
file used in tests

Loading and saving of large but simple (16 lines, 7 columns, no equations)
ods files has been since version 4.2.0.0 significantly slower.

version   load  save
3.6.7.2   20s5s
4.1.6 14s5s
4.2.0.0.beta1 33s1:26 min
4.4.0.1   40s3:24 min
5.0.0.3-3 45s2:30 min


--
Milos

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/unx

2015-07-17 Thread Caolán McNamara

 vcl/unx/gtk/app/gtkdata.cxx |   22 +-
 1 file changed, 17 insertions(+), 5 deletions(-)

New commits:
commit 9dd4b06304a615d2d600d6b1cdf0d6d445311b0d
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 12:02:00 2015 +0100

presumably XSetIOErrorHandler is meaningless on wayland

Change-Id: I72247a38021b11a521d785f7565c218a425a857f

diff --git a/vcl/unx/gtk/app/gtkdata.cxx b/vcl/unx/gtk/app/gtkdata.cxx
index 6e0f711..b1e552b 100644
--- a/vcl/unx/gtk/app/gtkdata.cxx
+++ b/vcl/unx/gtk/app/gtkdata.cxx
@@ -47,9 +47,12 @@
 #include vcl/svapp.hxx
 
 #if GTK_CHECK_VERSION(3,10,0)
-#ifdef GDK_WINDOWING_X11
-#include gdk/gdkx.h
-#endif
+# ifdef GDK_WINDOWING_X11
+#  include gdk/gdkx.h
+# endif
+#else
+# define GDK_WINDOWING_X11
+# define GDK_IS_X11_DISPLAY(foo) true
 #endif
 
 using namespace vcl_sal;
@@ -525,6 +528,7 @@ GtkData::GtkData( SalInstance *pInstance )
 m_aDispatchCondition = osl_createCondition();
 }
 
+#if defined(GDK_WINDOWING_X11)
 XIOErrorHandler aOrigXIOErrorHandler = NULL;
 
 extern C {
@@ -538,6 +542,7 @@ static int XIOErrorHdl(Display *)
 }
 
 }
+#endif
 
 GtkData::~GtkData()
 {
@@ -558,7 +563,10 @@ GtkData::~GtkData()
 osl_destroyCondition( m_aDispatchCondition );
 osl_releaseMutex( m_aDispatchMutex );
 osl_destroyMutex( m_aDispatchMutex );
-XSetIOErrorHandler(aOrigXIOErrorHandler);
+#if defined(GDK_WINDOWING_X11)
+if (GDK_IS_X11_DISPLAY(gdk_display_get_default()))
+XSetIOErrorHandler(aOrigXIOErrorHandler);
+#endif
 }
 
 void GtkData::Dispose()
@@ -679,7 +687,6 @@ void GtkData::Init()
 // init gtk/gdk
 gtk_init_check( nParams, pCmdLineAry );
 gdk_error_trap_push();
-aOrigXIOErrorHandler = XSetIOErrorHandler(XIOErrorHdl);
 
 for (i = 0; i  nParams; i++ )
 g_free( pCmdLineAry[i] );
@@ -709,6 +716,11 @@ void GtkData::Init()
 exit(0);
 }
 
+#if defined(GDK_WINDOWING_X11)
+if (GDK_IS_X11_DISPLAY(pGdkDisp))
+aOrigXIOErrorHandler = XSetIOErrorHandler(XIOErrorHdl);
+#endif
+
 /*
  * if a -display switch was used, we need
  * to set the environment accoringly since
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 92803] New: Bad quality generated pdf and a very large file sizes

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92803

Bug ID: 92803
   Summary: Bad quality generated pdf and a very large file sizes
   Product: LibreOffice
   Version: 5.0.0.3 rc
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: major
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: krali...@gmail.com

Created attachment 117293
  -- https://bugs.documentfoundation.org/attachment.cgi?id=117293action=edit
Input odt document for generated pdf

Generating PDF to LibreOffice headless mode running on an application server.
I have three distribution office:
- Libreoffice_5.0.0.3_RC
- Libreoffice_4.4.2
- Openoffice_3.2.1
Running through LibreOffice (or OpenOffice) API Java code, which will send the
document processing odt, getting back to pdf.

With newer versions of the LO (or OO) comes these Defects:
- Lower resolution images
- Bigger size pdf file

File for generating the Annex as inputDocument.odt.

There are three pdf named according to package LO (or OO) version.

Included are three pictures that show deteriorating quality of conversion,
again named after release.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77479] Calc: State of AutoFilter lost after sorting

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=77479

--- Comment #16 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Eike Rathke committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8eadeb91cde9709f006e8c5e19e98bff44dbd177

Resolves: tdf#77479 do not reset AutoFilter range for temporary operations

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77479] Calc: State of AutoFilter lost after sorting

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=77479

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|| target:5.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92803] Bad quality generated pdf and a very large file sizes

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92803

--- Comment #8 from Tomas Kralik krali...@gmail.com ---
Created attachment 117301
  -- https://bugs.documentfoundation.org/attachment.cgi?id=117301action=edit
LO_5.0.0.3-pdf_picture_8x_zoom

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92803] Bad quality generated pdf and a very large file sizes

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92803

--- Comment #7 from Tomas Kralik krali...@gmail.com ---
Created attachment 117300
  -- https://bugs.documentfoundation.org/attachment.cgi?id=117300action=edit
LO_4.4.2- pdf_picture_8x_zoom

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91495] Style preview in Styles and Formatting sidebar should be optional

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91495

--- Comment #10 from Cor Nouws c...@nouenoff.nl ---
@stuart:

Thanks for your detailed testing!

(In reply to V Stuart Foote from comment #9)

 Also, the Formatting toolbar Apply Style dropdown, continues to render its
 list of defined styles, which might also annoy folks for Styles that do not
 show complete fidelity.

That feature already exists for much longer. So if people would be annoyed by
that, I expect that to be expressed by a separate issue.

@tomaz: 

thanks for the option!
Is it possible to push to 5.0.0 too (with tripple review prolly)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58831] Embeded pictures in doc file incorrect size in PDF export. Works fine with OO 3.2.0

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=58831

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=92
   ||803

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92803] Bad quality generated pdf and a very large file sizes

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92803

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 CC||c...@nouenoff.nl
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=58
   ||831

--- Comment #10 from Cor Nouws c...@nouenoff.nl ---
Thanks for filing Tomas,

I have no change to confirm, however:

(In reply to Tomas Kralik from comment #0)

 With newer versions of the LO (or OO) comes these Defects:
 - Lower resolution images

See issue 58831
 - Bigger size pdf file

Heard people about that. Thought that there was an issue for that already, but
cannot find it.

Ciao - Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svx/source

2015-07-17 Thread Carlos Luque

 svx/source/xml/xmlgrhlp.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 4d84153e22bdda33b23deb4c32afcace4c1264f7
Author: Carlos Luque josecarlos.ruizlu...@cib.de
Date:   Thu Jul 16 11:59:37 2015 +0200

tdf#92571: add mime types for several image file formats

The new mime types were added the followings:
   - eps - image/x-eps
   - wmf - image/x-wmf
   - bmp - image/bmp
   - pct - image/x-pct
These new mime types are written in the attribute media-type
of each image in the file manifest.xml

Change-Id: I16edb625e331d3f917c6e8929df004191e317acc
Reviewed-on: https://gerrit.libreoffice.org/17123
Reviewed-by: Thorsten Behrens thorsten.behr...@cib.de
Tested-by: Thorsten Behrens thorsten.behr...@cib.de

diff --git a/svx/source/xml/xmlgrhlp.cxx b/svx/source/xml/xmlgrhlp.cxx
index a4daaac..ffb5c40 100644
--- a/svx/source/xml/xmlgrhlp.cxx
+++ b/svx/source/xml/xmlgrhlp.cxx
@@ -471,7 +471,11 @@ OUString SvXMLGraphicHelper::ImplGetGraphicMimeType( const 
OUString rFileName )
 { png, image/png },
 { jpg, image/jpeg },
 { tif, image/tiff },
-{ svg, image/svg+xml }
+{ svg, image/svg+xml },
+{ wmf, image/x-wmf },
+{ eps, image/eps },
+{ bmp, image/bmp },
+{ pct, image/x-pict }
 };
 
 OUString aMimeType;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 92571] Error mime type in Manifest.xml with picture.wmf and picture.emf

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92571

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|| target:5.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92571] Error mime type in Manifest.xml with picture.wmf and picture.emf

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92571

--- Comment #1 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Carlos Luque committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4d84153e22bdda33b23deb4c32afcace4c1264f7

tdf#92571: add mime types for several image file formats

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92380] Style Preview broken some styles in Styles Pane on V5.0

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92380

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
 Whiteboard||target:5.1.0

--- Comment #21 from V Stuart Foote vstuart.fo...@utsa.edu ---
Working on Windows 7 sp1, 64-bit en-US with
Version: 5.1.0.0.alpha1+ (x64)
Build ID: 14257152b19c08618a107c6eb0f684de11483da8
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-17_03:23:36
Locale: en-US (en_US)

The broken style previews for the smaller sizes being unreadable, and the
larger size preview not expanding beyond some fixed percentage for inclusion on
the list is also present in Windows, and remains.  But it seems most
troublesome in the toggle between font size settings done as percentages rather
than points. And of course getting consistent OS X behavior is always a
minefield for the devs.

But not sure it is really a bug? Some bounds have to be set or the actual
graphical representation of styles on a list becomes useless. And expecting a
style with a font formatted white to show against a white panel would be
strange.

Anyway ttoggle now provided Expert Configuration org.openoffice.Office.Common
StylesAndFormatting provides reasonable work around for any customized styles
that do not render correctly as folks would like as previews. With disabled
previews it shows as simple listings of Style (LO system default) in the
Sidebar Style and Formatting content panels.

Hope it will be backported early in the 5.0 release.

=-ref-=
http://cgit.freedesktop.org/libreoffice/core/commit/?id=210f42a318cbac62de835ccacbc1fc0e36f713f6

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92767] Autofilter on date is locale dependent

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92767

raal r...@post.cz changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #2 from raal r...@post.cz ---
confirmed in comment 1, setting as new

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source include/filter sc/source sw/source

2015-07-17 Thread Noel Grandin

 filter/source/config/cache/cacheitem.hxx   |   17 --
 filter/source/flash/swfexporter.hxx|3 --
 filter/source/flash/swfwriter.hxx  |3 --
 filter/source/graphicfilter/icgm/actimpr.cxx   |8 --
 filter/source/graphicfilter/icgm/bundles.hxx   |7 ++---
 filter/source/graphicfilter/icgm/outact.hxx|2 -
 filter/source/msfilter/escherex.cxx|5 
 filter/source/msfilter/eschesdo.hxx|   11 +++--
 filter/source/msfilter/msdffimp.cxx|5 
 filter/source/msfilter/mstoolbar.cxx   |   12 --
 filter/source/msfilter/svdfppt.cxx |   25 -
 filter/source/msfilter/viscache.hxx|3 --
 filter/source/svg/svgwriter.hxx|   14 ---
 filter/source/xsltdialog/xmlfiltertabpagebasic.hxx |3 --
 include/filter/msfilter/escherex.hxx   |7 -
 include/filter/msfilter/mscodec.hxx|6 -
 include/filter/msfilter/msdffimp.hxx   |   20 
 include/filter/msfilter/msoleexp.hxx   |2 -
 include/filter/msfilter/mstoolbar.hxx  |3 --
 include/filter/msfilter/svdfppt.hxx|   10 
 sc/source/filter/excel/xiescher.cxx|2 -
 sw/source/filter/ww8/ww8par.cxx|2 -
 22 files changed, 10 insertions(+), 160 deletions(-)

New commits:
commit a90c6eb99c8c2167c4b1ec75a21a30a344bfea43
Author: Noel Grandin n...@peralex.com
Date:   Thu Jul 16 16:52:26 2015 +0200

loplugin:unusedmethods filter

Change-Id: Ie33a5ebda9337cf123b39ae18a8d7b4ef12b6991
Reviewed-on: https://gerrit.libreoffice.org/17131
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com

diff --git a/filter/source/config/cache/cacheitem.hxx 
b/filter/source/config/cache/cacheitem.hxx
index 788036a..56a5052 100644
--- a/filter/source/config/cache/cacheitem.hxx
+++ b/filter/source/config/cache/cacheitem.hxx
@@ -121,23 +121,6 @@ class CacheItem : public ::comphelper::SequenceAsHashMap
 
 
 
-/** @short  check, if the given properties dont exists
-at this item.
-
-@descr  All properties are compared in its minimum.
-E.g: string lists = only the specified items
-are checked. Additional existing items are ignored.
-
-@param  lProps
-contains all properties, which should be checked.
-
-@return sal_True if all given properties dont exists
-at this item; sal_False otherwise.
- */
-bool excludeProps(const CacheItem lProps) const;
-
-
-
 /** @short  because we know two UIName properties
 (a list with all locales and the value
 for the current locale only), we must be sure
diff --git a/filter/source/flash/swfexporter.hxx 
b/filter/source/flash/swfexporter.hxx
index 2e78abd..5c05b62 100644
--- a/filter/source/flash/swfexporter.hxx
+++ b/filter/source/flash/swfexporter.hxx
@@ -188,9 +188,6 @@ private:
 sal_uInt32 ActionSummer(::com::sun::star::uno::Reference 
::com::sun::star::drawing::XShape  xShape);
 sal_uInt32 ActionSummer(::com::sun::star::uno::Reference 
::com::sun::star::drawing::XShapes  xShapes);
 
-void animateShape( ShapeAnimationInfo rAnimInfo );
-void animatePage( PageInfo* pPageInfo );
-
 bool getMetaFile( ::com::sun::star::uno::Reference 
::com::sun::star::lang::XComponent xComponent, GDIMetaFile rMtf, bool 
bOnlyBackground = false, bool bExportAsJPEG = false );
 
 Writer* mpWriter;
diff --git a/filter/source/flash/swfwriter.hxx 
b/filter/source/flash/swfwriter.hxx
index be08fb2..76d25d8 100644
--- a/filter/source/flash/swfwriter.hxx
+++ b/filter/source/flash/swfwriter.hxx
@@ -210,9 +210,6 @@ public:
 ~Sprite();
 
 void write( SvStream out );
-
-sal_uInt16 getId() const { return mnId; }
-
 void addTag( Tag* pNewTag );
 
 private:
diff --git a/filter/source/graphicfilter/icgm/actimpr.cxx 
b/filter/source/graphicfilter/icgm/actimpr.cxx
index 206a546..d643c0a 100644
--- a/filter/source/graphicfilter/icgm/actimpr.cxx
+++ b/filter/source/graphicfilter/icgm/actimpr.cxx
@@ -913,14 +913,6 @@ void CGMImpressOutAct::AppendText( char* pString, 
sal_uInt32 /*nSize*/, FinalFla
 }
 
 
-// nCount != 0 - Append Text
-sal_uInt32 CGMImpressOutAct::DrawText( TextEntry* /*pTextEntry*/, 
NodeFrameSet /*rNodeFrameSet*/, sal_uInt32 /*nObjCount*/ )
-{
-return 0;
-}
-
-
-
 void CGMImpressOutAct::DrawChart()
 {
 }
diff --git a/filter/source/graphicfilter/icgm/bundles.hxx 
b/filter/source/graphicfilter/icgm/bundles.hxx
index 5e5ed00..d04cb36 100644
--- a/filter/source/graphicfilter/icgm/bundles.hxx
+++ b/filter/source/graphicfilter/icgm/bundles.hxx
@@ -152,14 +152,13 @@ public:
 class FontEntry
 {
 public:
-

[Libreoffice-commits] core.git: compilerplugins/clang slideshow/source

2015-07-17 Thread Noel Grandin

 compilerplugins/clang/unusedmethods.cxx  |   92 
++
 slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.hxx |   16 -
 slideshow/source/engine/animationnodes/animationbasenode.hxx |3 
 slideshow/source/engine/animationnodes/basenode.hxx  |6 
 slideshow/source/engine/pointersymbol.hxx|7 
 slideshow/source/engine/rehearsetimingsactivity.cxx  |   14 -
 slideshow/source/engine/shapes/viewshape.hxx |   10 -
 slideshow/source/engine/slide/shapemanagerimpl.cxx   |   23 --
 slideshow/source/engine/slide/shapemanagerimpl.hxx   |6 
 slideshow/source/engine/slide/userpaintoverlay.cxx   |   23 --
 slideshow/source/engine/transitions/slidechangebase.hxx  |3 
 slideshow/source/engine/usereventqueue.cxx   |2 
 slideshow/source/inc/activitiesqueue.hxx |7 
 slideshow/source/inc/doctreenode.hxx |7 
 slideshow/source/inc/listenercontainer.hxx   |1 
 slideshow/source/inc/mouseeventhandler.hxx   |   30 ---
 slideshow/source/inc/shapemanager.hxx|8 
 slideshow/source/inc/slidebitmap.hxx |1 
 slideshow/source/inc/unoviewcontainer.hxx|4 
 slideshow/source/inc/viewupdate.hxx  |7 
 20 files changed, 58 insertions(+), 212 deletions(-)

New commits:
commit 5a7bf1b32c3699c9ca40d60e61403a3b587f35ff
Author: Noel Grandin n...@peralex.com
Date:   Thu Jul 16 14:45:53 2015 +0200

loplugin:unusedmethods slideshow

Change-Id: I66b6cddb638a9fc1228d3ea9df5d112300a00eb3
Reviewed-on: https://gerrit.libreoffice.org/17128
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com

diff --git a/compilerplugins/clang/unusedmethods.cxx 
b/compilerplugins/clang/unusedmethods.cxx
index 6d0303d..a137a21 100644
--- a/compilerplugins/clang/unusedmethods.cxx
+++ b/compilerplugins/clang/unusedmethods.cxx
@@ -35,9 +35,6 @@ to get it to work :-)
 
 TODO deal with calls to superclass/member constructors from other 
constructors, so
  we can find unused constructors
-TODO deal with free functions and static methods
-TODO track instantiations of template class constructor methods
-TODO track instantiation of overridden methods when a template class is 
instantiated
 */
 
 namespace {
@@ -71,18 +68,20 @@ public:
 }
 
 bool VisitCallExpr(CallExpr* );
-bool VisitCXXMethodDecl( const CXXMethodDecl* decl );
+bool VisitFunctionDecl( const FunctionDecl* decl );
 bool VisitDeclRefExpr( const DeclRefExpr* );
-bool TraverseCXXMethodDecl(CXXMethodDecl * decl) { return 
RecursiveASTVisitor::TraverseCXXMethodDecl(decl); }
+bool VisitCXXConstructExpr( const CXXConstructExpr* );
 };
 
-static std::string niceName(const CXXMethodDecl* functionDecl)
+static std::string niceName(const FunctionDecl* functionDecl)
 {
 std::string s =
 compat::getReturnType(*functionDecl).getCanonicalType().getAsString()
-+   + functionDecl-getParent()-getQualifiedNameAsString()
-+ :: + functionDecl-getNameAsString()
-+ (;
++  ;
+if (isaCXXMethodDecl(functionDecl)) {
+s += 
dyn_castCXXMethodDecl(functionDecl)-getParent()-getQualifiedNameAsString() 
+ ::;
+}
+s += functionDecl-getNameAsString() + (;
 bool bFirst = true;
 for (const ParmVarDecl *pParmVarDecl : functionDecl-params()) {
 if (bFirst)
@@ -92,27 +91,30 @@ static std::string niceName(const CXXMethodDecl* 
functionDecl)
 s += pParmVarDecl-getType().getCanonicalType().getAsString();
 }
 s += );
-if (functionDecl-isConst()) {
+if (isaCXXMethodDecl(functionDecl)  
dyn_castCXXMethodDecl(functionDecl)-isConst()) {
 s +=  const;
 }
 return s;
 }
 
-static void logCallToRootMethods(const CXXMethodDecl* decl)
+static void logCallToRootMethods(const FunctionDecl* functionDecl)
 {
-// For virtual/overriding methods, we need to pretend we called the root 
method(s),
-// so that they get marked as used.
-decl = decl-getCanonicalDecl();
+functionDecl = functionDecl-getCanonicalDecl();
 bool bPrinted = false;
-for(CXXMethodDecl::method_iterator it = decl-begin_overridden_methods();
-it != decl-end_overridden_methods(); ++it)
-{
-logCallToRootMethods(*it);
-bPrinted = true;
+if (isaCXXMethodDecl(functionDecl)) {
+// For virtual/overriding methods, we need to pretend we called the 
root method(s),
+// so that they get marked as used.
+const CXXMethodDecl* methodDecl = 
dyn_castCXXMethodDecl(functionDecl);
+for(CXXMethodDecl::method_iterator it =

[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - svtools/source

2015-07-17 Thread Szymon Kłos

 svtools/source/dialogs/PlaceEditDialog.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit e969fc9842d5f1e6090913b95d9c6b232f139e77
Author: Szymon KÅos eszka...@gmail.com
Date:   Fri Jul 17 09:34:06 2015 +0200

Separator should not be the default selection

Change-Id: Id879e795d3b6722ca0d86f8f6a8a32b0ef6f12bd

diff --git a/svtools/source/dialogs/PlaceEditDialog.cxx 
b/svtools/source/dialogs/PlaceEditDialog.cxx
index 482b763..15034dd 100644
--- a/svtools/source/dialogs/PlaceEditDialog.cxx
+++ b/svtools/source/dialogs/PlaceEditDialog.cxx
@@ -140,7 +140,6 @@ void PlaceEditDialog::InitDetails( )
 bool bSkipOneDrive= OUString( ONEDRIVE_CLIENT_ID ).isEmpty() ||
OUString( ONEDRIVE_CLIENT_SECRET ).isEmpty();
 
-
 Sequence OUString  aTypesUrlsList( 
officecfg::Office::Common::Misc::CmisServersUrls::get( xContext ) );
 Sequence OUString  aTypesNamesList( 
officecfg::Office::Common::Misc::CmisServersNames::get( xContext ) );
 
@@ -182,6 +181,10 @@ void PlaceEditDialog::InitDetails( )
 
 // Set default to first value
 m_pLBServerType-SelectEntryPos( 0 );
+
+if ( m_pLBServerType-GetSelectEntry() ==  )
+m_pLBServerType-SelectEntryPos( 1 );
+
 SelectTypeHdl( m_pLBServerType );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: connectivity/source

2015-07-17 Thread Caolán McNamara

 connectivity/source/drivers/evoab2/NPreparedStatement.hxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 747ee55b1a0842982833a9a8a9e54ee40958e339
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 08:53:26 2015 +0100

fix evoab2 build

Change-Id: I944494af60b9805d53a2f1c507b9eb99fd935e9c

diff --git a/connectivity/source/drivers/evoab2/NPreparedStatement.hxx 
b/connectivity/source/drivers/evoab2/NPreparedStatement.hxx
index ddf6041..e9bf635 100644
--- a/connectivity/source/drivers/evoab2/NPreparedStatement.hxx
+++ b/connectivity/source/drivers/evoab2/NPreparedStatement.hxx
@@ -29,6 +29,7 @@
 #include com/sun/star/sdbc/XResultSetMetaDataSupplier.hpp
 #include com/sun/star/sdbc/XPreparedBatchExecution.hpp
 #include com/sun/star/io/XInputStream.hpp
+#include cppuhelper/compbase5.hxx
 
 namespace connectivity
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Section Break Code

2015-07-17 Thread Jack

Hello,



I am new to LibreOffice development, can somebody tell my where to find the code

for the following elements:


-
section breaks

-
formatting


Regards,

jack___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 92799] New: formatting cells

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92799

Bug ID: 92799
   Summary: formatting cells
   Product: LibreOffice
   Version: 4.3.7.2 release
  Hardware: x86 (IA32)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: marc.du...@orange.fr

When trying to format a lot of cells like date, the paintbrush doesn't always
work. The same appears as I try to use French language, which is not taken into
consideration to the next cells (money : euros, french) It happens the same
as I close after saving and reopen the spreadsheet : no more formatting ! It
has gone again on english(usa) Even more it seems to be random behavior...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang cui/source desktop/inc desktop/source

2015-07-17 Thread Noel Grandin

 compilerplugins/clang/unusedmethodsremove.cxx |7 +++
 cui/source/customize/cfgutil.cxx  |1 
 cui/source/dialogs/SpellAttrib.hxx|7 ---
 cui/source/dialogs/SpellDialog.cxx|   11 -
 cui/source/inc/SpellDialog.hxx|1 
 cui/source/inc/acccfg.hxx |2 -
 cui/source/inc/cfg.hxx|   27 +-
 cui/source/inc/cfgutil.hxx|3 -
 cui/source/inc/cuigaldlg.hxx  |1 
 cui/source/inc/cuigrfflt.hxx  |1 
 cui/source/inc/cuitabarea.hxx |4 --
 cui/source/inc/cuitabline.hxx |6 +--
 cui/source/inc/dbregister.hxx |1 
 cui/source/inc/dstribut.hxx   |2 -
 cui/source/inc/grfpage.hxx|3 -
 cui/source/inc/hangulhanjadlg.hxx |1 
 cui/source/inc/hldocntp.hxx   |2 -
 cui/source/inc/hltpbase.hxx   |1 
 cui/source/inc/iconcdlg.hxx   |   17 +---
 cui/source/inc/linkdlg.hxx|2 -
 cui/source/inc/macroass.hxx   |   13 --
 cui/source/inc/numpages.hxx   |   10 -
 cui/source/inc/optdict.hxx|6 ---
 cui/source/inc/optpath.hxx|1 
 cui/source/inc/postdlg.hxx|   12 --
 cui/source/inc/scriptdlg.hxx  |2 -
 cui/source/inc/selector.hxx   |1 
 cui/source/inc/textanim.hxx   |2 -
 cui/source/inc/thesdlg.hxx|1 
 cui/source/inc/transfrm.hxx   |3 -
 cui/source/inc/treeopt.hxx|1 
 cui/source/options/doclinkdialog.hxx  |1 
 cui/source/options/fontsubs.hxx   |3 -
 cui/source/tabpages/dstribut.cxx  |   12 --
 cui/source/tabpages/transfrm.cxx  |1 
 desktop/inc/app.hxx   |4 --
 desktop/source/app/dispatchwatcher.hxx|5 --
 desktop/source/deployment/gui/dp_gui.h|1 
 desktop/source/deployment/gui/dp_gui_dialog2.cxx  |2 -
 desktop/source/deployment/gui/dp_gui_dialog2.hxx  |8 
 desktop/source/deployment/gui/dp_gui_extlistbox.hxx   |3 -
 desktop/source/deployment/gui/dp_gui_updatedialog.cxx |2 -
 desktop/source/deployment/gui/dp_gui_updatedialog.hxx |3 -
 desktop/source/deployment/manager/dp_extensionmanager.hxx |3 -
 desktop/source/deployment/registry/inc/dp_backend.h   |   13 --
 desktop/source/migration/migration_impl.hxx   |1 
 46 files changed, 13 insertions(+), 201 deletions(-)

New commits:
commit 89ef4dea325a11c706ff9619ff4717124260f864
Author: Noel Grandin n...@peralex.com
Date:   Fri Jul 17 10:34:58 2015 +0200

loplugin:unusedmethods cui

Change-Id: I8a4cb855054c487d7a8307ad219f10b06db3248b

diff --git a/compilerplugins/clang/unusedmethodsremove.cxx 
b/compilerplugins/clang/unusedmethodsremove.cxx
index 01b71b1..758b8a1 100644
--- a/compilerplugins/clang/unusedmethodsremove.cxx
+++ b/compilerplugins/clang/unusedmethodsremove.cxx
@@ -121,11 +121,16 @@ bool UnusedMethodsRemove::VisitCXXMethodDecl( const 
CXXMethodDecl* functionDecl
 if(!(found  mmappedData + mmapFilesize)) {
 return true;
 }
-// sometimes the declaration has a semicolon just after it, and it's much 
neater to remove that too.
 SourceRange replaceRange(functionDecl-getSourceRange());
+// sometimes the declaration has a semicolon just after it, and it's much 
neater to remove that too.
 if (rewriter-getRewrittenText(SourceRange(replaceRange.getEnd(), 
replaceRange.getEnd().getLocWithOffset(1))) == ;) {
 replaceRange.setEnd(replaceRange.getEnd().getLocWithOffset(1));
 }
+// remove leading spaces
+while 
(rewriter-getRewrittenText(SourceRange(replaceRange.getBegin().getLocWithOffset(-1),
 replaceRange.getBegin())) ==  )
+{
+replaceRange.setBegin(replaceRange.getBegin().getLocWithOffset(-1));
+}
 if (!replaceText(replaceRange, )) {
 report(
 DiagnosticsEngine::Warning,
diff --git a/cui/source/customize/cfgutil.cxx b/cui/source/customize/cfgutil.cxx
index f554062..5f86a6e 100644
--- a/cui/source/customize/cfgutil.cxx
+++ b/cui/source/customize/cfgutil.cxx
@@ -251,7 +251,6 @@ void SfxStylesInfo_Impl::getLabel4Style(SfxStyleInfo_Impl 
aStyle)

[Libreoffice-bugs] [Bug 92789] FILEOPEN embedded graphic of format pct is not displayed.

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92789

--- Comment #5 from osnola alo...@loria.fr ---
Hello,
I just take a quick look, I do not not understand the two lines of ipict.cxx
(and the following lines):
const size_t nMinRowWidth = nWidth * nMinRecordSize;
for me there only make sense if the bitmap is not packed, i.e. :
- line 912: only when (nRowBytes  8 || nPackType == 1)
- line 1072: never

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92800] New: Reporter code errors

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92800

Bug ID: 92800
   Summary: Reporter code errors
   Product: LibreOffice
   Version: unspecified
  Hardware: Other
OS: other
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: roelandb...@hotmail.com

This article contains a list of small code errors in the LibreOffice code.
Maybe someone is interested in fixing them? Should I attach a PDF of this
article? http://www.viva64.com/en/b/0308/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34965] Make Impress slides editable during presentation

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34965

Samuel Mehrbrodt s.mehrbr...@gmail.com changed:

   What|Removed |Added

 CC||rolandi...@gmail.com

--- Comment #16 from Samuel Mehrbrodt s.mehrbr...@gmail.com ---
*** Bug 92781 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 34965] Make Impress slides editable during presentation

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34965

Samuel Mehrbrodt s.mehrbr...@gmail.com changed:

   What|Removed |Added

 CC||rolandi...@gmail.com

--- Comment #16 from Samuel Mehrbrodt s.mehrbr...@gmail.com ---
*** Bug 92781 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=88206

--- Comment #12 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a175788dcd3edd4c82f70458f0fa6e7b44d86526

tdf#88206 replace cppu::WeakImplHelper* etc.

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=88206

--- Comment #12 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a175788dcd3edd4c82f70458f0fa6e7b44d86526

tdf#88206 replace cppu::WeakImplHelper* etc.

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Approximating a missing platform with gerrit

2015-07-17 Thread Norbert Thiebaud

On Thu, Jul 16, 2015 at 2:26 AM, Stephan Bergmann sberg...@redhat.com wrote:

 * Sometimes, a build fails for spurious reasons midway through, and you need
 to start another build.  But the only way to re-trigger a build is to rebase
 the change.

This is a way to get an automatic trigger.. but it _is_ possible to
manually re-trigger a build within jenkins, without rebasing.
It is just not something generally available, but something that I use
to try to re-mediate infra issues where a bunch of build got drop on
the floor due to some outage.

It should be possible to have a parametrize manual build available
where one can specify a ref to build and a platform to build...
I suppose that _could_ be tied in with David's proposal to work on a
gerrit plugin for that... The plug in would just be triggering a
jenkins job using rest or some other mechanism

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

RE: visual studio 2013 express

2015-07-17 Thread Vasily Melenchuk


Hello Michael,
 
On 07/14/2015 03:42 PM, Michael Stahl  wrote:
 
 anybody has $SUBJECT installed?  /me doesn't, hence this mail...
 on master configure fails with Express since commit
 98a61f5b8da500fcefd2e7f0dfb1231bfb87f2fb  due to a check for devenv.exe,
 which does not exist in  Express but there is a different executable,
 probably vcexpress.exe.

Yes. I've updated locally configure.ac to use WDExpress.exe and not 
devenv.exe. Seems everything works.

 does that executable support an /Upgrade switch to upgrade project and
 solution files?  if not we'll have to drop support for VS Express at
 some point and require VS Community.

VS 2013 Expression Edition does not have this switch:

Command:
C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\IDE\WDExpress.exe 
LibreOffice.sln  /Upgrade

reports back to me:
Invalid Command Line. Unknown Switch : Upgrade.

Best regards, Vasily

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: forms/source

2015-07-17 Thread Noel Grandin

 forms/source/component/CheckBox.hxx |1 
 forms/source/component/DatabaseForm.hxx |7 -
 forms/source/component/Date.hxx |7 -
 forms/source/component/GroupManager.hxx |1 
 forms/source/component/RadioButton.hxx  |6 
 forms/source/component/Time.hxx |7 -
 forms/source/component/entrylisthelper.hxx  |2 -
 forms/source/component/imgprod.hxx  |1 
 forms/source/inc/FormComponent.hxx  |5 +--
 forms/source/inc/formnavigation.hxx |4 ---
 forms/source/inc/property.hxx   |2 -
 forms/source/inc/propertybaghelper.hxx  |8 --
 forms/source/richtext/attributedispatcher.hxx   |   11 
 forms/source/xforms/binding.hxx |   15 ---
 forms/source/xforms/computedexpression.hxx  |6 
 forms/source/xforms/datatypes.hxx   |4 ---
 forms/source/xforms/submission.hxx  |   11 
 forms/source/xforms/submission/serialization.hxx|   16 
 forms/source/xforms/submission/serialization_app_xml.hxx|1 
 forms/source/xforms/submission/serialization_urlencoded.hxx |1 
 20 files changed, 2 insertions(+), 114 deletions(-)

New commits:
commit 771d9ef3f65785092267f6068384e8cdda17f883
Author: Noel Grandin n...@peralex.com
Date:   Fri Jul 17 11:01:29 2015 +0200

loplugin:unusedmethods forms

Change-Id: I6b7938e948fb1422f83e2175fee5fcabe0a0b83f

diff --git a/forms/source/component/CheckBox.hxx 
b/forms/source/component/CheckBox.hxx
index 2819ee3..c27e0b2 100644
--- a/forms/source/component/CheckBox.hxx
+++ b/forms/source/component/CheckBox.hxx
@@ -29,7 +29,6 @@ namespace frm
 class OCheckBoxModel:public OReferenceValueComponent
 {
 protected:
-sal_Int16   getState(const ::com::sun::star::uno::Any rValue);
 boolDbUseBool();
 
 public:
diff --git a/forms/source/component/DatabaseForm.hxx 
b/forms/source/component/DatabaseForm.hxx
index 2bcf96e..5e6c4ab 100644
--- a/forms/source/component/DatabaseForm.hxx
+++ b/forms/source/component/DatabaseForm.hxx
@@ -436,8 +436,6 @@ public:
 // XCloneable
 virtual ::com::sun::star::uno::Reference 
::com::sun::star::util::XCloneable  SAL_CALL createClone(  ) throw 
(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
 
-inline void submitNBC( const ::com::sun::star::uno::Reference 
::com::sun::star::awt::XControl Control, const 
::com::sun::star::awt::MouseEvent MouseEvt );
-
 protected:
 // OPropertySetAggregationHelper overridables
 virtual void forwardingPropertyValue( sal_Int32 _nHandle ) SAL_OVERRIDE;
@@ -542,11 +540,6 @@ protected:
 using OPropertySetHelper::getPropertyValues;
 };
 
-inline void ODatabaseForm::submitNBC(const ::com::sun::star::uno::Reference 
::com::sun::star::awt::XControl Control, const 
::com::sun::star::awt::MouseEvent MouseEvt)
-{
-submit_impl(Control, MouseEvt, false);
-}
-
 
 }   // namespace frm
 
diff --git a/forms/source/component/Date.hxx b/forms/source/component/Date.hxx
index 572f51b..2971008 100644
--- a/forms/source/component/Date.hxx
+++ b/forms/source/component/Date.hxx
@@ -90,13 +90,6 @@ protected:
 
 protected:
 virtual css::uno::Reference css::util::XCloneable  SAL_CALL createClone( 
 ) throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE;
-
-private:
-/** translates the control value (the VCL-internal integer representation 
of a date) into
-a UNO-Date.
-*/
-voidimpl_translateControlValueToUNODate(
-::com::sun::star::uno::Any _rUNOValue ) const;
 };
 
 class ODateControl: public OBoundControl
diff --git a/forms/source/component/GroupManager.hxx 
b/forms/source/component/GroupManager.hxx
index 01d8c60..4a07fae 100644
--- a/forms/source/component/GroupManager.hxx
+++ b/forms/source/component/GroupManager.hxx
@@ -108,7 +108,6 @@ public:
 
 sal_Int32   GetPos() const { return m_nPos; }
 sal_Int16   GetTabIndex() const { return m_nTabIndex; }
-OUString GetName() const { return m_aName; }
 };
 
 typedef std::vectorOGroupComp OGroupCompArr;
diff --git a/forms/source/component/RadioButton.hxx 
b/forms/source/component/RadioButton.hxx
index d8660c0..e57e672 100644
--- a/forms/source/component/RadioButton.hxx
+++ b/forms/source/component/RadioButton.hxx
@@ -71,12 +71,6 @@ protected:
 virtual css::uno::Reference css::util::XCloneable  SAL_CALL createClone( 
 ) throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE;
 
 private:
-/** sets the given value as new State at the aggregate
-@precond
-our mutex is acquired exactly once
-*/
-void

[Libreoffice-bugs] [Bug 92786] FILESAVE: wrong table of content page numbers alignment after .docx export

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92786

tommy27 ba...@quipo.it changed:

   What|Removed |Added

Version|5.0.0.3 rc  |4.2.6.2 release

--- Comment #7 from tommy27 ba...@quipo.it ---
I adjust the version field. It has to indicate the earliest version the bug has
been reproduced. in this case: 4.2.6.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/qa filter/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/tiff/fail/loop.tif   |binary
 filter/source/graphicfilter/itiff/itiff.cxx |   12 +++-
 2 files changed, 11 insertions(+), 1 deletion(-)

New commits:
commit 290465b0effecb6d620adc20ca279f8057eeab9a
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 09:23:17 2015 +0100

detect loop in tif format

Change-Id: I27645566cd9fc0ac8cf753f0217ae6cf0fa9929e

diff --git a/filter/qa/cppunit/data/tiff/fail/loop.tif 
b/filter/qa/cppunit/data/tiff/fail/loop.tif
new file mode 100644
index 000..6d8cee7
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/loop.tif differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index 84bff73..9ae2a06 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -1210,9 +1210,19 @@ bool TIFFReader::ReadTIFF(SvStream  rTIFF, Graphic  
rGraphic )
 }
 while( nOffset );
 
+std::vectorsal_uInt32 aSeenIfds;
+
 for ( sal_uInt32 nNextIfd = nFirstIfd; nNextIfd  bStatus; )
 {
-pTIFF-Seek( nOrigPos + nNextIfd );
+if (std::find(aSeenIfds.begin(), aSeenIfds.end(), nNextIfd) != 
aSeenIfds.end())
+{
+SAL_WARN(filter.tiff, Parsing error:   nNextIfd 
+  already processed, format loop);
+bStatus = false;
+break;
+}
+pTIFF-Seek(nOrigPos + nNextIfd);
+aSeenIfds.push_back(nNextIfd);
 {
 bByteSwap = false;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: filter/qa filter/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/tiff/fail/hang-1.tiff |binary
 filter/source/graphicfilter/itiff/itiff.cxx  |7 +--
 2 files changed, 5 insertions(+), 2 deletions(-)

New commits:
commit feedb957310fc3282ca47d5ffc1482dbb944a36e
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 09:45:26 2015 +0100

test that nNumStripOffsets value is within bounds of file

Change-Id: I1483ea3671420be5349692374641e10b344d

diff --git a/filter/qa/cppunit/data/tiff/fail/hang-1.tiff 
b/filter/qa/cppunit/data/tiff/fail/hang-1.tiff
new file mode 100644
index 000..9cd2aa2
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/hang-1.tiff differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index 9ae2a06..e132fab 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -373,14 +373,17 @@ void TIFFReader::ReadTagData( sal_uInt16 nTagType, 
sal_uInt32 nDataLen)
 nNumStripOffsets = 0;
 nOldNumSO = nNumStripOffsets;
 nDataLen += nOldNumSO;
-if ( ( nDataLen  nOldNumSO )  ( nDataLen  SAL_MAX_UINT32 / 
sizeof( sal_uInt32 ) ) )
+size_t nMaxAllocAllowed = SAL_MAX_UINT32 / sizeof(sal_uInt32);
+size_t nMaxRecordsAvailable = pTIFF-remainingSize() / 
DataTypeSize();
+if (nDataLen  nOldNumSO  nDataLen  nMaxAllocAllowed 
+(nDataLen - nOldNumSO) = nMaxRecordsAvailable)
 {
 nNumStripOffsets = nDataLen;
 try
 {
 pStripOffsets = new sal_uLong[ nNumStripOffsets ];
 }
-catch (const std::bad_alloc )
+catch (const std::bad_alloc )
 {
 pStripOffsets = NULL;
 nNumStripOffsets = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmlsecurity/inc xmlsecurity/source

2015-07-17 Thread Noel Grandin

 xmlsecurity/inc/xmlsecurity/certificateviewer.hxx |4 
 xmlsecurity/inc/xmlsecurity/macrosecurity.hxx |5 -
 xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.hxx|3 ---
 xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx |5 -
 xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.hxx |1 -
 5 files changed, 18 deletions(-)

New commits:
commit 64fe684368bd54f54f6838c7d8a59c9efeaa0965
Author: Noel Grandin n...@peralex.com
Date:   Fri Jul 17 10:41:19 2015 +0200

loplugin:unusedmethods xmlsecurity

Change-Id: I7b0a6521168dab13e87fc39920fdaef70943961e

diff --git a/xmlsecurity/inc/xmlsecurity/certificateviewer.hxx 
b/xmlsecurity/inc/xmlsecurity/certificateviewer.hxx
index 3f61891..2a0134a 100644
--- a/xmlsecurity/inc/xmlsecurity/certificateviewer.hxx
+++ b/xmlsecurity/inc/xmlsecurity/certificateviewer.hxx
@@ -71,10 +71,6 @@ public:
 const OUString rUIXMLDescription, CertificateViewer* _pDlg );
 virtual ~CertificateViewerTP();
 virtual void dispose() SAL_OVERRIDE;
-void SetTabDlg( CertificateViewer* _pTabDlg )
-{
-mpDlg = _pTabDlg;
-}
 };
 
 class CertificateViewerGeneralTP : public CertificateViewerTP
diff --git a/xmlsecurity/inc/xmlsecurity/macrosecurity.hxx 
b/xmlsecurity/inc/xmlsecurity/macrosecurity.hxx
index 8f0edfd..1d0b18a 100644
--- a/xmlsecurity/inc/xmlsecurity/macrosecurity.hxx
+++ b/xmlsecurity/inc/xmlsecurity/macrosecurity.hxx
@@ -85,11 +85,6 @@ public:
 virtual ~MacroSecurityTP();
 virtual void dispose() SAL_OVERRIDE;
 
-void SetTabDlg(MacroSecurity* pTabDlg)
-{
-mpDlg = pTabDlg;
-}
-
 virtual voidClosePage() = 0;
 };
 
diff --git a/xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.hxx 
b/xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.hxx
index 463b524..7ccfb64 100644
--- a/xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.hxx
+++ b/xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.hxx
@@ -55,9 +55,6 @@ class SanExtensionImpl : public ::cppu::WeakImplHelper1
 //Methods from XSanExtension
 
 virtual ::com::sun::star::uno::Sequence 
com::sun::star::security::CertAltNameEntry  SAL_CALL getAlternativeNames() 
throw( ::com::sun::star::uno::RuntimeException, std::exception ) SAL_OVERRIDE ;
-
-//Helper method
-void setCertExtn( unsigned char* value, unsigned int vlen, unsigned 
char* id, unsigned int idlen, bool critical ) ;
 } ;
 
 #endif // INCLUDED_XMLSECURITY_SOURCE_XMLSEC_NSS_SANEXTENSION_NSSIMPL_HXX
diff --git a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx 
b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
index bf0eb19..349874d 100644
--- a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
@@ -480,11 +480,6 @@ Reference XCertificate  SecurityEnvironment_NssImpl :: 
getCertificate( const O
 return xcert ;
 }
 
-Reference XCertificate  SecurityEnvironment_NssImpl :: getCertificate( const 
OUString issuerName, const OUString serialNumber ) throw( SecurityException , 
RuntimeException ) {
-Sequence sal_Int8  serial = numericStringToBigInteger( serialNumber ) ;
-return getCertificate( issuerName, serial ) ;
-}
-
 Sequence Reference  XCertificate   SecurityEnvironment_NssImpl :: 
buildCertificatePath( const Reference XCertificate  begin ) throw( 
SecurityException , RuntimeException, std::exception ) {
 const X509Certificate_NssImpl* xcert ;
 const CERTCertificate* cert ;
diff --git a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.hxx 
b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.hxx
index dd294fb..b35661b 100644
--- a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.hxx
+++ b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.hxx
@@ -121,7 +121,6 @@ private :
 virtual ::com::sun::star::uno::Sequence 
::com::sun::star::uno::Reference ::com::sun::star::security::XCertificate   
SAL_CALL getPersonalCertificates() throw(  
::com::sun::star::uno::SecurityException , 
::com::sun::star::uno::RuntimeException, std::exception ) SAL_OVERRIDE ;
 
 virtual ::com::sun::star::uno::Reference 
::com::sun::star::security::XCertificate  SAL_CALL getCertificate( const 
OUString issuerName, const ::com::sun::star::uno::Sequence sal_Int8  
serialNumber ) throw( ::com::sun::star::uno::SecurityException , 
::com::sun::star::uno::RuntimeException, std::exception ) SAL_OVERRIDE ;
-::com::sun::star::uno::Reference 
::com::sun::star::security::XCertificate  SAL_CALL getCertificate( const 
OUString issuerName, const OUString serialNumber ) throw( 
::com::sun::star::uno::SecurityException , 
::com::sun::star::uno::RuntimeException ) ;
 
 virtual ::com::sun::star::uno::Sequence 
::com::sun::star::uno::Reference ::com::sun::star::security::XCertificate   
SAL_CALL buildCertificatePath( const ::com::sun::star::uno::Reference

[Libreoffice-commits] core.git: 2 commits - filter/qa filter/source

2015-07-17 Thread Caolán McNamara

 dev/null |binary
 filter/qa/cppunit/data/tiff/fail/hang-2.tiff |binary
 filter/qa/cppunit/data/tiff/fail/hang-3.tiff |binary
 filter/source/graphicfilter/itiff/itiff.cxx  |   11 ++-
 4 files changed, 10 insertions(+), 1 deletion(-)

New commits:
commit 64cc2d775c0b2347a55e563c362c37e033ffd68d
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 10:00:21 2015 +0100

rename test case

Change-Id: I76d35955a1d024d05a94ffdfdcf8e4076de24975

diff --git a/filter/qa/cppunit/data/tiff/fail/loop.tif 
b/filter/qa/cppunit/data/tiff/fail/hang-3.tiff
similarity index 100%
rename from filter/qa/cppunit/data/tiff/fail/loop.tif
rename to filter/qa/cppunit/data/tiff/fail/hang-3.tiff
commit 49bf2c6700d8f0fc9155ac2d06bf0a7bd84915d8
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 09:59:23 2015 +0100

detect another loop in tif format

Change-Id: I950f751277d9080b4fc00c38f63453cce81bcc32

diff --git a/filter/qa/cppunit/data/tiff/fail/hang-2.tiff 
b/filter/qa/cppunit/data/tiff/fail/hang-2.tiff
new file mode 100644
index 000..28ec8c0
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/hang-2.tiff differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index e132fab..aed15f6 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -1181,10 +1181,19 @@ bool TIFFReader::ReadTIFF(SvStream  rTIFF, Graphic  
rGraphic )
 {
 sal_uInt32 nOffset = nFirstIfd;
 
+std::vectorsal_uInt32 aSeenOffsets;
 // calculate length of TIFF file
 do
 {
-pTIFF-Seek( nOrigPos + nOffset );
+if (std::find(aSeenOffsets.begin(), aSeenOffsets.end(), nOffset) 
!= aSeenOffsets.end())
+{
+SAL_WARN(filter.tiff, Parsing error:   nOffset 
+  already processed, format loop);
+bStatus = false;
+break;
+}
+pTIFF-Seek(nOrigPos + nOffset);
+aSeenOffsets.push_back(nOffset);
 
 if( pTIFF-GetError() )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Approximating a missing platform with gerrit

2015-07-17 Thread David Ostrovsky

On Mon, Thu Jul 16 00:26:35 PDT 2015, Stephan Bergmann wrote:

 But when you try to (mis-)use it to modify a change 
 request [...] the situation is not that ideal.

As you noticed, these are two entirely different use cases:

1. automatic ready-to-go gerrit change verification on all platforms
with standard configure settings and make command invocation

2. platform specific verification with custom configuration options and
make command invocation

Whatever we could do for use case 2. (later more on this) we should
first polish and understand the limitation of 1. Sorry for abusing your
thread for that.

I learned yesterday, that our Jenkins/Gerrit Trigger Plugin/Gerrit
integration has one problem: 

Sets build current patches only mode. option, that does this:

If this is enabled, all currently running or scheduled builds for
previous patchsets will be canceled before a new build is scheduled for
the new patchset.

wasn't activated in out setup. The reason for that is that there are
intermittent problem with canceling build on windows platform.

However, until we can find out how to overcome these problems and
activate the option we must understand the consequences this option not
being set:

a) Don't upload to Gerrit non-ready vanilla changes
b) Don't upload to Gerrit non-ready vanilla patch sets

Because pushing to gerrit immediately triggers 3 verification jobs.
Uploading new patch set re-triggers new 3 verification jobs, *without*
canceling already running (and thus obsolete) jobs for now outdated
patch sets.

Simple example calculation: pushing 5 patch set within 20 min. as I did
yesterday: [1], triggers 5 x 3 = 15 jobs. Given that all these patches
weren't ready yet, and all I wanted is to share my discovering and
thoughts with reviewers of this change, this was incredible waste of
resources. To make it clear, my intention was *not* to spawn 15 Jenkins
jobs for non ready change.

That rises the question how should a contributor to share her thoughts
(and code) with core developers, for non-ready (aka Work In Progress or
just WIP) changes, without spamming developer mailing list with
attachments (that get removed) or not to mention sending them private
mails (that would end up in spam folder and get ignored)? IOW How to
hide WIP changes from the our Jenkins/Gerrit verification tool chain,
and avoid wasting of real world resources, and keep our planet green?

One feature that Jenkins/Gerrit integration offers you is use DRAFT
changes and DRAFT patch sets (those are not the same).

The easiest way to grasp this non trivial concept, is imagine two
database tables in Gerrit with two DRAFT columns:

CHANGES
===
DRAFT: boolean
[...]

PATCH_SETS
==
DRAFT: boolean
[...]

It should be clear from this, that there can be a DRAFT patch for no
DRAFT change. When a change is in status DRAFT, then all patch sets are
DRAFTs as well.

There can be many different DRAFT workflows:

I. change is WIP from the beginning (non ready):

  $ git push HEAD:refs/drafts/master

or alternatively magic branch option can be used

  $ git push HEAD:refs/for/master%draft

This way created change has status DRAFT, and is not seen by Jenkins
and is not get verified.

II. draft patch set should be uploaded for non DRAFT change.

Command is identical as above. New patch set has status draft.

Note, that DRAFT changes an patch sets must be published (and can be
even deleted) to be promoted to regular changes.

Also note, that pushing follow-up patch sets *without* marking them as
DRAFT would effectively publish them. So just keep pushing with DRAFT
marker as explain above to make DRAFT status sticky.

Now back to your original question, after explanation of DRAFT workflow.

What we could do to cover the second use cases you mentioned is to
combine Jenkins/Trigger plugin automatic verification for regular
changes/patch sets with manual triggering of DRAFT patch set per
platform with Gerrit Buildbot plugin.

Gerrit buildbot plugin could be adapted to only consider DRAFT
changes/patch sets and offer a Schedule button on change screen for
each platform (another option is to use one button, and offer check
boxes on popup window per platform that should be built). Clicking on it
would open a popup dialog, where custom configure and make file options
could be provided. The same tinderboxes could be run in mixed Jenkins
Trigger Plugin/Gerrit Buildbot plugin mode and verify regular patch sets
in Jenkins/Trigger plugin mode and DRAFT patch set in Gerrit buildbot
plugin mode.

To summarize your workflow would be:

* upload regular (optionally as DRAFT, abd even avoid building you
intermediate change on all three platforms) change that is verified by
regular Jenkins/Trigge rplugi integration
* upload 42 new DRAFT patch sets, and trigger verification with Buildbot
plugin schedule button manually for interesting platform. This would
schedule dedicated build on specific platform you selected with custom
settings (of course TB must know and

[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - fpicker/source include/vcl

2015-07-17 Thread Szymon Kłos

 fpicker/source/office/RemoteFilesDialog.cxx |   29 
 fpicker/source/office/iodlg.src |5 
 include/vcl/fpicker.hrc |1 
 3 files changed, 23 insertions(+), 12 deletions(-)

New commits:
commit d001d8ac4086cc98d27771ec5dba83e1852cfbc0
Author: Szymon KÅos eszka...@gmail.com
Date:   Fri Jul 17 08:46:31 2015 +0200

question if delete the service

Change-Id: I49e5a93ba1d58b898ec1c7b9a4682c9e86302bd0

diff --git a/fpicker/source/office/RemoteFilesDialog.cxx 
b/fpicker/source/office/RemoteFilesDialog.cxx
index 716c229..da25b9d 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -579,21 +579,26 @@ IMPL_LINK_TYPED ( RemoteFilesDialog, EditServiceMenuHdl, 
MenuButton *, pButton,
 
 if( nPos = 0 )
 {
-// TODO: Confirm dialog
-
-m_aServices.erase( m_aServices.begin() + nPos );
-m_pServices_lb-RemoveEntry( nSelected );
+OUString sMsg = ResId( STR_SVT_DELETESERVICE, 
*ResMgrHolder::getOrCreate() );
+sMsg = sMsg.replaceFirst( $servicename$, 
m_pServices_lb-GetSelectEntry() );
+ScopedVclPtrInstance MessageDialog  aBox( this, sMsg, 
VCL_MESSAGE_QUESTION, VCL_BUTTONS_YES_NO );
 
-if( m_pServices_lb-GetEntryCount()  0 )
+if( aBox-Execute() == RET_YES )
 {
-m_pServices_lb-SelectEntryPos( 0 );
-}
-else
-{
-m_pServices_lb-SetNoSelection();
-}
+m_aServices.erase( m_aServices.begin() + nPos );
+m_pServices_lb-RemoveEntry( nSelected );
 
-m_bIsUpdated = true;
+if( m_pServices_lb-GetEntryCount()  0 )
+{
+m_pServices_lb-SelectEntryPos( 0 );
+}
+else
+{
+m_pServices_lb-SetNoSelection();
+}
+
+m_bIsUpdated = true;
+}
 }
 }
 
diff --git a/fpicker/source/office/iodlg.src b/fpicker/source/office/iodlg.src
index e09fe0b..bc43b98 100644
--- a/fpicker/source/office/iodlg.src
+++ b/fpicker/source/office/iodlg.src
@@ -105,6 +105,11 @@ String STR_SVT_ALREADYEXISTOVERWRITE
 Text [ en-US ] = A file named \$filename$\ already exists.\n\nDo you 
want to replace it? ;
 };
 
+String STR_SVT_DELETESERVICE
+{
+Text [ en-US ] = Are you sure you want to delete the 
service?\n\$servicename$\ ;
+};
+
 String STR_SVT_NEW_FOLDER
 {
 Text [ en-US ] = Folder ;
diff --git a/include/vcl/fpicker.hrc b/include/vcl/fpicker.hrc
index 387b389..7d4bd16 100644
--- a/include/vcl/fpicker.hrc
+++ b/include/vcl/fpicker.hrc
@@ -27,6 +27,7 @@
 #define STR_SVT_FOLDERPICKER_DEFAULT_TITLE  
(STR_SVT_FILEPICKER_START+12)
 #define STR_SVT_FOLDERPICKER_DEFAULT_DESCRIPTION
(STR_SVT_FILEPICKER_START+13)
 #define STR_SVT_ALREADYEXISTOVERWRITE   
(STR_SVT_FILEPICKER_START+14)
+#define STR_SVT_DELETESERVICE   
(STR_SVT_FILEPICKER_START+15)
 
 #endif
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: dbaccess/source include/dbaccess

2015-07-17 Thread Takeshi Abe

 dbaccess/source/core/api/CacheSet.hxx  |4 -
 dbaccess/source/core/api/PrivateRow.hxx|4 -
 dbaccess/source/core/api/resultset.hxx |4 -
 dbaccess/source/core/dataaccess/ComponentDefinition.cxx|4 -
 dbaccess/source/core/dataaccess/ModelImpl.cxx  |5 +-
 dbaccess/source/core/dataaccess/SharedConnection.hxx   |6 +-
 dbaccess/source/core/dataaccess/bookmarkcontainer.hxx  |   18 
 dbaccess/source/core/dataaccess/dataaccessdescriptor.cxx   |   13 ++---
 dbaccess/source/core/dataaccess/databasecontext.cxx|6 +-
 dbaccess/source/core/dataaccess/databasecontext.hxx|   10 ++--
 dbaccess/source/core/dataaccess/datasource.cxx |5 +-
 dbaccess/source/core/dataaccess/datasource.hxx |   26 +--
 dbaccess/source/core/dataaccess/documentdefinition.cxx |   13 +++--
 dbaccess/source/core/dataaccess/documentevents.hxx |6 +-
 dbaccess/source/core/dataaccess/intercept.hxx  |8 +--
 dbaccess/source/core/inc/ContainerMediator.hxx |4 -
 dbaccess/source/core/inc/ContentHelper.hxx |   22 -
 dbaccess/source/core/inc/DatabaseDataProvider.hxx  |   10 ++--
 dbaccess/source/core/inc/PropertyForward.hxx   |6 +-
 dbaccess/source/core/inc/TableDeco.hxx |   20 
 dbaccess/source/core/inc/column.hxx|9 +---
 dbaccess/source/core/inc/veto.hxx  |6 +-
 dbaccess/source/core/recovery/subcomponentloader.hxx   |6 +-
 dbaccess/source/core/recovery/subcomponentrecovery.cxx |5 +-
 dbaccess/source/ext/macromigration/progresscapture.hxx |6 +-
 dbaccess/source/filter/xml/dbloader2.cxx   |6 +-
 dbaccess/source/sdbtools/connection/connectiontools.hxx|   10 ++--
 dbaccess/source/sdbtools/connection/datasourcemetadata.hxx |6 +-
 dbaccess/source/sdbtools/connection/objectnames.hxx|6 +-
 dbaccess/source/sdbtools/connection/tablename.hxx  |6 +-
 dbaccess/source/ui/app/subcomponentmanager.hxx |6 +-
 dbaccess/source/ui/browser/dbloader.cxx|4 -
 dbaccess/source/ui/control/dbtreelistbox.cxx   |6 +-
 dbaccess/source/ui/control/sqledit.cxx |3 -
 dbaccess/source/ui/dlg/dbwizsetup.cxx  |5 +-
 dbaccess/source/ui/dlg/finteraction.hxx|6 +-
 dbaccess/source/ui/inc/TokenWriter.hxx |4 -
 dbaccess/source/ui/inc/formadapter.hxx |   29 ++---
 dbaccess/source/ui/inc/singledoccontroller.hxx |8 +--
 dbaccess/source/ui/misc/controllerframe.cxx|6 +-
 dbaccess/source/ui/uno/copytablewizard.cxx |8 +--
 dbaccess/source/ui/uno/dbinteraction.hxx   |8 +--
 dbaccess/source/ui/uno/textconnectionsettings_uno.cxx  |   10 ++--
 include/dbaccess/dbsubcomponentcontroller.hxx  |   10 ++--
 include/dbaccess/genericcontroller.hxx |   26 +--
 45 files changed, 202 insertions(+), 197 deletions(-)

New commits:
commit 7fa29ecc727c04159cee92aebc14fc5b1037a965
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Fri Jul 17 11:59:26 2015 +0900

tdf#88206 replace cppu::WeakImplHelper* etc.

with the variadic variants, for dbaccess.

Change-Id: I60921b1b1d3b65fb9087552ed118c60dc9f89032
Reviewed-on: https://gerrit.libreoffice.org/17146
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com

diff --git a/dbaccess/source/core/api/CacheSet.hxx 
b/dbaccess/source/core/api/CacheSet.hxx
index 30b4352..5897949 100644
--- a/dbaccess/source/core/api/CacheSet.hxx
+++ b/dbaccess/source/core/api/CacheSet.hxx
@@ -29,14 +29,14 @@
 #include com/sun/star/sdbcx/XDeleteRows.hpp
 #include com/sun/star/sdbcx/CompareBookmark.hpp
 #include RowSetRow.hxx
-#include cppuhelper/implbase1.hxx
+#include cppuhelper/implbase.hxx
 
 #include list
 namespace com{ namespace sun { namespace star{namespace sdbc{ class 
XParameters; } } } }
 
 namespace dbaccess
 {
-class OCacheSet : public ::cppu::WeakImplHelper1 
::com::sun::star::sdbc::XRow
+class OCacheSet : public ::cppu::WeakImplHelper 
::com::sun::star::sdbc::XRow
 {
 protected:
 ::com::sun::star::uno::Reference ::com::sun::star::sdbc::XResultSet  
 m_xDriverSet;
diff --git a/dbaccess/source/core/api/PrivateRow.hxx 
b/dbaccess/source/core/api/PrivateRow.hxx
index 99583b7..e949904 100644
--- a/dbaccess/source/core/api/PrivateRow.hxx
+++ b/dbaccess/source/core/api/PrivateRow.hxx
@@ -19,13 +19,13 @@
 #ifndef INCLUDED_DBACCESS_SOURCE_CORE_API_PRIVATEROW_HXX
 #define INCLUDED_DBACCESS_SOURCE_CORE_API_PRIVATEROW_HXX
 
-#include cppuhelper/implbase1.hxx
+#include cppuhelper/implbase.hxx

[Libreoffice-bugs] [Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=88206

--- Comment #11 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7fa29ecc727c04159cee92aebc14fc5b1037a965

tdf#88206 replace cppu::WeakImplHelper* etc.

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cppcanvas/source cpputools/source cui/source

2015-07-17 Thread Takeshi Abe

 cppcanvas/source/uno/uno_mtfrenderer.hxx  |4 ++--
 cpputools/source/unoexe/unoexe.cxx|6 +++---
 cui/source/dialogs/colorpicker.cxx|4 ++--
 cui/source/options/personasdochandler.hxx |4 ++--
 4 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit a175788dcd3edd4c82f70458f0fa6e7b44d86526
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Thu Jul 16 17:43:53 2015 +0900

tdf#88206 replace cppu::WeakImplHelper* etc.

with the variadic variants, in cppcanvas / cpputools / cui.

Change-Id: Ic28d0830ab86555494004c27b1468de2ea6825dc
Reviewed-on: https://gerrit.libreoffice.org/17119
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com

diff --git a/cppcanvas/source/uno/uno_mtfrenderer.hxx 
b/cppcanvas/source/uno/uno_mtfrenderer.hxx
index 821cf4f..428e9b3 100644
--- a/cppcanvas/source/uno/uno_mtfrenderer.hxx
+++ b/cppcanvas/source/uno/uno_mtfrenderer.hxx
@@ -13,11 +13,11 @@
 #include com/sun/star/rendering/XBitmapCanvas.hpp
 #include com/sun/star/uno/XComponentContext.hpp
 #include com/sun/star/beans/XFastPropertySet.hpp
-#include cppuhelper/compbase2.hxx
+#include cppuhelper/compbase.hxx
 #include cppuhelper/basemutex.hxx
 #include vcl/gdimtf.hxx
 
-typedef 
cppu::WeakComponentImplHelper2com::sun::star::rendering::XMtfRenderer, 
com::sun::star::beans::XFastPropertySet MtfRendererBase;
+typedef cppu::WeakComponentImplHelpercom::sun::star::rendering::XMtfRenderer, 
com::sun::star::beans::XFastPropertySet MtfRendererBase;
 
 class MtfRenderer : private cppu::BaseMutex, public MtfRendererBase
 {
diff --git a/cpputools/source/unoexe/unoexe.cxx 
b/cpputools/source/unoexe/unoexe.cxx
index b292deb..a898763 100644
--- a/cpputools/source/unoexe/unoexe.cxx
+++ b/cpputools/source/unoexe/unoexe.cxx
@@ -30,7 +30,7 @@
 #include rtl/ustrbuf.hxx
 
 #include cppuhelper/bootstrap.hxx
-#include cppuhelper/implbase1.hxx
+#include cppuhelper/implbase.hxx
 
 #include com/sun/star/lang/XMain.hpp
 #include com/sun/star/lang/XInitialization.hpp
@@ -252,7 +252,7 @@ static Reference XInterface  loadComponent(
 }
 
 class OInstanceProvider
-: public WeakImplHelper1 XInstanceProvider 
+: public WeakImplHelper XInstanceProvider 
 {
 Reference XComponentContext  _xContext;
 
@@ -348,7 +348,7 @@ Reference XInterface  OInstanceProvider::getInstance( 
const OUString  rName )
 no such element \ + rName + \! );
 }
 
-struct ODisposingListener : public WeakImplHelper1 XEventListener 
+struct ODisposingListener : public WeakImplHelper XEventListener 
 {
 Condition cDisposed;
 
diff --git a/cui/source/dialogs/colorpicker.cxx 
b/cui/source/dialogs/colorpicker.cxx
index 6e1979b..148f9a2 100644
--- a/cui/source/dialogs/colorpicker.cxx
+++ b/cui/source/dialogs/colorpicker.cxx
@@ -25,7 +25,7 @@
 #include com/sun/star/datatransfer/XTransferable.hpp
 #include com/sun/star/datatransfer/clipboard/XClipboard.hpp
 #include com/sun/star/awt/XWindow.hpp
-#include cppuhelper/compbase4.hxx
+#include cppuhelper/compbase.hxx
 #include cppuhelper/supportsservice.hxx
 #include comphelper/broadcasthelper.hxx
 #include vcl/dialog.hxx
@@ -1508,7 +1508,7 @@ void ColorPickerDialog::setColorComponent( sal_uInt16 
nComp, double dValue )
 }
 }
 
-typedef ::cppu::WeakComponentImplHelper4 XServiceInfo, XExecutableDialog, 
XInitialization, XPropertyAccess  ColorPickerBase;
+typedef ::cppu::WeakComponentImplHelper XServiceInfo, XExecutableDialog, 
XInitialization, XPropertyAccess  ColorPickerBase;
 
 class ColorPicker : protected ::comphelper::OBaseMutex,// Struct for right 
initalization of mutex member! Must be first of baseclasses.
 public ColorPickerBase
diff --git a/cui/source/options/personasdochandler.hxx 
b/cui/source/options/personasdochandler.hxx
index 2383452..94c69f4 100644
--- a/cui/source/options/personasdochandler.hxx
+++ b/cui/source/options/personasdochandler.hxx
@@ -10,12 +10,12 @@
 #ifndef INCLUDED_CUI_SOURCE_OPTIONS_PERSONASDOCHANDLER_HXX
 #define INCLUDED_CUI_SOURCE_OPTIONS_PERSONASDOCHANDLER_HXX
 
-#include cppuhelper/implbase1.hxx
+#include cppuhelper/implbase.hxx
 #include com/sun/star/xml/sax/XAttributeList.hpp
 #include com/sun/star/xml/sax/XParser.hpp
 #include vector
 
-class PersonasDocHandler : public ::cppu::WeakImplHelper1 
css::xml::sax::XDocumentHandler 
+class PersonasDocHandler : public ::cppu::WeakImplHelper 
css::xml::sax::XDocumentHandler 
 {
 private:
 std::vectorOUString m_vLearnmoreURLs;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=88206

--- Comment #11 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7fa29ecc727c04159cee92aebc14fc5b1037a965

tdf#88206 replace cppu::WeakImplHelper* etc.

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 3 commits - chart2/source

2015-07-17 Thread Markus Mohrhard

 chart2/source/controller/sidebar/Chart2PanelFactory.cxx |   26 ---
 chart2/source/controller/sidebar/ChartElementsPanel.cxx |   18 --
 chart2/source/controller/sidebar/ChartElementsPanel.hxx |7 
 chart2/source/controller/sidebar/ChartSeriesPanel.cxx   |  122 +++-
 chart2/source/controller/sidebar/ChartSeriesPanel.hxx   |   10 -
 5 files changed, 75 insertions(+), 108 deletions(-)

New commits:
commit 7ea6f476cb4f3a21904db5a5d7170e8dbae804a1
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Fri Jul 17 10:24:53 2015 +0200

remove duplicated code

Change-Id: I4a5dcb9d05446dc938f978cb30428c70c70d6914

diff --git a/chart2/source/controller/sidebar/ChartSeriesPanel.cxx 
b/chart2/source/controller/sidebar/ChartSeriesPanel.cxx
index 7d15a96..483ae91 100644
--- a/chart2/source/controller/sidebar/ChartSeriesPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartSeriesPanel.cxx
@@ -261,6 +261,25 @@ OUString 
getSeriesLabel(css::uno::Referencecss::frame::XModel xModel, const OU
 return DataSeriesHelper::getDataSeriesLabel(xSeries, 
xChartType-getRoleOfSequenceForSeriesLabel());
 }
 
+OUString getCID(css::uno::Referencecss::frame::XModel xModel)
+{
+css::uno::Referencecss::frame::XController 
xController(xModel-getCurrentController());
+css::uno::Referencecss::view::XSelectionSupplier 
xSelectionSupplier(xController, css::uno::UNO_QUERY);
+if (!xSelectionSupplier.is())
+return OUString();
+
+uno::Any aAny = xSelectionSupplier-getSelection();
+assert(aAny.hasValue());
+OUString aCID;
+aAny = aCID;
+#ifdef DBG_UTIL
+ObjectType eType = ObjectIdentifier::getObjectType(aCID);
+assert(eType == OBJECTTYPE_DATA_SERIES);
+#endif
+
+return aCID;
+}
+
 }
 
 ChartSeriesPanel::ChartSeriesPanel(
@@ -334,19 +353,7 @@ void ChartSeriesPanel::Initialize()
 
 void ChartSeriesPanel::updateData()
 {
-css::uno::Referencecss::frame::XController 
xController(mxModel-getCurrentController());
-css::uno::Referencecss::view::XSelectionSupplier 
xSelectionSupplier(xController, css::uno::UNO_QUERY);
-if (!xSelectionSupplier.is())
-return;
-
-uno::Any aAny = xSelectionSupplier-getSelection();
-assert(aAny.hasValue());
-OUString aCID;
-aAny = aCID;
-#ifdef DBG_UTIL
-ObjectType eType = ObjectIdentifier::getObjectType(aCID);
-assert(eType == OBJECTTYPE_DATA_SERIES);
-#endif
+OUString aCID = getCID(mxModel);
 SolarMutexGuard aGuard;
 bool bLabelVisible = isDataLabelVisible(mxModel, aCID);
 mpCBLabel-Check(bLabelVisible);
@@ -406,19 +413,7 @@ void ChartSeriesPanel::modelInvalid()
 IMPL_LINK(ChartSeriesPanel, CheckBoxHdl, CheckBox*, pCheckBox)
 {
 bool bChecked = pCheckBox-IsChecked();
-css::uno::Referencecss::frame::XController 
xController(mxModel-getCurrentController());
-css::uno::Referencecss::view::XSelectionSupplier 
xSelectionSupplier(xController, css::uno::UNO_QUERY);
-if (!xSelectionSupplier.is())
-return 0;
-
-uno::Any aAny = xSelectionSupplier-getSelection();
-assert(aAny.hasValue());
-OUString aCID;
-aAny = aCID;
-#ifdef DBG_UTIL
-ObjectType eType = ObjectIdentifier::getObjectType(aCID);
-assert(eType == OBJECTTYPE_DATA_SERIES);
-#endif
+OUString aCID = getCID(mxModel);
 if (pCheckBox == mpCBLabel.get())
 setDataLabelVisible(mxModel, aCID, bChecked);
 else if (pCheckBox == mpCBTrendline.get())
@@ -433,20 +428,7 @@ IMPL_LINK(ChartSeriesPanel, CheckBoxHdl, CheckBox*, 
pCheckBox)
 
 IMPL_LINK_NOARG(ChartSeriesPanel, RadioBtnHdl)
 {
-css::uno::Referencecss::frame::XController 
xController(mxModel-getCurrentController());
-css::uno::Referencecss::view::XSelectionSupplier 
xSelectionSupplier(xController, css::uno::UNO_QUERY);
-if (!xSelectionSupplier.is())
-return 0;
-
-uno::Any aAny = xSelectionSupplier-getSelection();
-assert(aAny.hasValue());
-OUString aCID;
-aAny = aCID;
-#ifdef DBG_UTIL
-ObjectType eType = ObjectIdentifier::getObjectType(aCID);
-assert(eType == OBJECTTYPE_DATA_SERIES);
-#endif
-
+OUString aCID = getCID(mxModel);
 bool bChecked = mpRBPrimaryAxis-IsChecked();
 
 setAttachedAxisType(mxModel, aCID, bChecked);
@@ -456,19 +438,7 @@ IMPL_LINK_NOARG(ChartSeriesPanel, RadioBtnHdl)
 
 IMPL_LINK_NOARG(ChartSeriesPanel, ListBoxHdl)
 {
-css::uno::Referencecss::frame::XController 
xController(mxModel-getCurrentController());
-css::uno::Referencecss::view::XSelectionSupplier 
xSelectionSupplier(xController, css::uno::UNO_QUERY);
-if (!xSelectionSupplier.is())
-return 0;
-
-uno::Any aAny = xSelectionSupplier-getSelection();
-assert(aAny.hasValue());
-OUString aCID;
-aAny = aCID;
-#ifdef DBG_UTIL
-ObjectType eType = ObjectIdentifier::getObjectType(aCID);
-assert(eType == OBJECTTYPE_DATA_SERIES);
-#endif
+OUString aCID = getCID(mxModel);
 
 sal_Int32 nPos = mpLBLabelPlacement-GetSelectEntryPos();

[Libreoffice-bugs] [Bug 92781] No way to edit content during slide show

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92781

Samuel Mehrbrodt s.mehrbr...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||s.mehrbr...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Samuel Mehrbrodt s.mehrbr...@gmail.com ---


*** This bug has been marked as a duplicate of bug 34965 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: connectivity/source connectivity/workben include/connectivity

2015-07-17 Thread Takeshi Abe

 connectivity/source/commontools/TTableHelper.cxx|3 
-
 connectivity/source/commontools/dbtools.cxx |4 
-
 connectivity/source/cpool/ZConnectionPool.hxx   |4 
-
 connectivity/source/cpool/ZConnectionWrapper.hxx|6 
+-
 connectivity/source/cpool/ZDriverWrapper.hxx|6 
+-
 connectivity/source/cpool/ZPoolCollection.hxx   |   12 
++--
 connectivity/source/cpool/ZPooledConnection.hxx |6 
+-
 connectivity/source/drivers/evoab2/NDriver.hxx  |4 
-
 connectivity/source/drivers/evoab2/NResultSet.hxx   |   20 
+++
 connectivity/source/drivers/evoab2/NResultSetMetaData.hxx   |4 
-
 connectivity/source/drivers/evoab2/NStatement.hxx   |   10 
+--
 connectivity/source/drivers/firebird/Blob.hxx   |6 
+-
 connectivity/source/drivers/firebird/Connection.hxx |   12 
++--
 connectivity/source/drivers/firebird/DatabaseMetaData.hxx   |4 
-
 connectivity/source/drivers/firebird/Driver.hxx |8 
+--
 connectivity/source/drivers/firebird/ResultSet.hxx  |   18 
+++---
 connectivity/source/drivers/firebird/ResultSetMetaData.hxx  |4 
-
 connectivity/source/drivers/firebird/StatementCommonBase.hxx|   10 
+--
 connectivity/source/drivers/hsqldb/HTerminateListener.hxx   |4 
-
 connectivity/source/drivers/kab/KConnection.hxx |4 
-
 connectivity/source/drivers/kab/KDatabaseMetaData.hxx   |4 
-
 connectivity/source/drivers/kab/KDriver.hxx |8 
+--
 connectivity/source/drivers/kab/KPreparedStatement.hxx  |   12 
++--
 connectivity/source/drivers/kab/KResultSet.hxx  |   26 
+-
 connectivity/source/drivers/kab/KResultSetMetaData.hxx  |4 
-
 connectivity/source/drivers/kab/KStatement.hxx  |   14 
++---
 connectivity/source/drivers/macab/MacabConnection.hxx   |4 
-
 connectivity/source/drivers/macab/MacabDatabaseMetaData.hxx |4 
-
 connectivity/source/drivers/macab/MacabDriver.hxx   |8 
+--
 connectivity/source/drivers/macab/MacabPreparedStatement.hxx|   12 
++--
 connectivity/source/drivers/macab/MacabResultSet.hxx|   26 
+-
 connectivity/source/drivers/macab/MacabResultSetMetaData.hxx|4 
-
 connectivity/source/drivers/macab/MacabStatement.hxx|   14 
++---
 connectivity/source/drivers/mork/MDriver.hxx|4 
-
 connectivity/source/drivers/mork/MResultSet.hxx |   26 
+-
 connectivity/source/drivers/mork/MResultSetMetaData.hxx |4 
-
 connectivity/source/drivers/mork/MStatement.hxx |8 
+--
 connectivity/source/drivers/mozab/MDriver.hxx   |6 
+-
 connectivity/source/drivers/mozab/MResultSet.hxx|   26 
+-
 connectivity/source/drivers/mozab/MResultSetMetaData.hxx|4 
-
 connectivity/source/drivers/mozab/MStatement.hxx|8 
+--
 connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.hxx   |6 
+-
 connectivity/source/drivers/mozab/mozillasrc/MNSMozabProxy.hxx  |4 
-
 connectivity/source/drivers/mozab/mozillasrc/MNSTerminateListener.hxx   |4 
-
 connectivity/source/drivers/postgresql/pq_array.hxx |4 
-
 connectivity/source/drivers/postgresql/pq_connection.cxx|4 
-
 connectivity/source/drivers/postgresql/pq_connection.hxx|4 
-
 connectivity/source/drivers/postgresql/pq_databasemetadata.hxx  |4 
-
 connectivity/source/drivers/postgresql/pq_driver.cxx|9 
+--
 connectivity/source/drivers/postgresql/pq_driver.hxx|7 
+-
 connectivity/source/drivers/postgresql/pq_resultsetmetadata.hxx |4 
-
 connectivity/source/drivers/postgresql/pq_sequenceresultsetmetadata.hxx |4 
-
 connectivity/source/drivers/postgresql/pq_statement.hxx |   15 
+++--
 connectivity/source/drivers/postgresql/pq_xcolumns.cxx  |4 
-
 connectivity/source/drivers/postgresql/pq_xcontainer.cxx|4 
-
 connectivity/source/drivers/postgresql/pq_xcontainer.hxx|4 
-
 connectivity/source/inc/FDatabaseMetaDataResultSet.hxx  |   20 
+++
 connectivity/source/inc/FDatabaseMetaDataResultSetMetaData.hxx  |4 
-
 connectivity/source/inc/ParameterSubstitution.hxx   |8 
+--

[Libreoffice-bugs] [Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=88206

--- Comment #13 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1a24285dd55c5c85272decc00dc8f93c9a917b8f

tdf#88206 replace cppu::WeakImplHelper* etc.

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=88206

--- Comment #13 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1a24285dd55c5c85272decc00dc8f93c9a917b8f

tdf#88206 replace cppu::WeakImplHelper* etc.

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 92749] VLOOKUP not calculated correctly in the large file from Calc 4.4 (hard recalc helps)

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92749

--- Comment #4 from Laurie a...@wycliffe.org ---
Is the hard recalc ctrl+shift+F9 a toggle in that it remains in effect? It
seems to have the same effect as my changing the number of steps did.

I looked at bug 87142. Might be related but I was unable to duplicate this one
in a small file like that one shows in.

I am happy with the workarounds.
File submitted in the hope that it may help the development team or somebody
else who is having problems.

Thanks.
Laurie.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2015-07-17 Thread Caolán McNamara

 sw/source/core/layout/layact.cxx |   17 -
 1 file changed, 17 deletions(-)

New commits:
commit 5f9cde384aa213cf8cf6c84a005647e59bc58ae6
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 08:28:21 2015 +0100

BreakPoint isn't really useful

merge branches to fix OSL_DEBUG_LEVEL  1 build

Change-Id: If4a81287bc41d7caa1240293d34e5186f293

diff --git a/sw/source/core/layout/layact.cxx b/sw/source/core/layout/layact.cxx
index a0c057b..f5d265a 100644
--- a/sw/source/core/layout/layact.cxx
+++ b/sw/source/core/layout/layact.cxx
@@ -65,22 +65,6 @@
 #define IS_INVAFLY (pPage-IsInvalidFly())
 
 // Save some typing work to avoid accessing destroyed pages.
-#if OSL_DEBUG_LEVEL  1
-
-static void BreakPoint()
-{
-return;
-}
-
-#define XCHECKPAGE \
-{   if ( IsAgain() ) \
-{   BreakPoint(); \
-if( bNoLoop ) \
-pLayoutAccess-GetLayouter()-EndLoopControl(); \
-return; \
-} \
-}
-#else
 #define XCHECKPAGE \
 {   if ( IsAgain() ) \
 { \
@@ -89,7 +73,6 @@ static void BreakPoint()
 return; \
 } \
 }
-#endif
 
 #define RESCHEDULE \
 { \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/inc chart2/source chart2/workbench

2015-07-17 Thread Takeshi Abe

 chart2/inc/ChartView.hxx|4 ++--
 chart2/inc/pch/precompiled_chartcore.hxx|2 +-
 chart2/inc/pch/precompiled_chartopengl.hxx  |2 +-
 chart2/source/controller/accessibility/AccessibleChartElement.hxx   |4 ++--
 chart2/source/controller/accessibility/AccessibleChartShape.hxx |4 ++--
 chart2/source/controller/chartapiwrapper/AreaWrapper.hxx|4 ++--
 chart2/source/controller/chartapiwrapper/AxisWrapper.hxx|4 ++--
 chart2/source/controller/chartapiwrapper/ChartDataWrapper.hxx   |4 ++--
 chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx |4 ++--
 chart2/source/controller/chartapiwrapper/GridWrapper.hxx|4 ++--
 chart2/source/controller/chartapiwrapper/LegendWrapper.hxx  |4 ++--
 chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.hxx  |4 ++--
 chart2/source/controller/chartapiwrapper/TitleWrapper.hxx   |4 ++--
 chart2/source/controller/chartapiwrapper/UpDownBarWrapper.hxx   |4 ++--
 chart2/source/controller/chartapiwrapper/WallFloorWrapper.hxx   |4 ++--
 chart2/source/controller/inc/AccessibleBase.hxx |4 ++--
 chart2/source/controller/inc/AccessibleChartView.hxx|4 ++--
 chart2/source/controller/inc/AccessibleTextHelper.hxx   |4 ++--
 chart2/source/controller/inc/ChartDocumentWrapper.hxx   |4 ++--
 chart2/source/controller/inc/RangeSelectionListener.hxx |4 ++--
 chart2/source/controller/main/ChartFrameloader.hxx  |4 ++--
 chart2/source/controller/main/CommandDispatch.hxx   |4 ++--
 chart2/source/controller/main/ControllerCommandDispatch.hxx |4 ++--
 chart2/source/controller/main/StatusBarCommandDispatch.hxx  |4 ++--
 chart2/source/controller/main/UndoActions.hxx   |6 
+++---
 chart2/source/controller/sidebar/ChartSeriesPanel.cxx   |2 +-
 chart2/source/inc/CachedDataSequence.hxx|4 ++--
 chart2/source/inc/ConfigColorScheme.hxx |4 ++--
 chart2/source/inc/DataSource.hxx|4 ++--
 chart2/source/inc/ErrorBar.hxx  |4 ++--
 chart2/source/inc/ExplicitCategoriesProvider.hxx|2 --
 chart2/source/inc/InternalDataProvider.hxx  |4 ++--
 chart2/source/inc/LabeledDataSequence.hxx   |4 ++--
 chart2/source/inc/ModifyListenerHelper.hxx  |5 
++---
 chart2/source/inc/NameContainer.hxx |4 ++--
 chart2/source/inc/RangeHighlighter.hxx  |4 ++--
 chart2/source/inc/RegressionCurveCalculator.hxx |4 ++--
 chart2/source/inc/Scaling.hxx   |   10 
+-
 chart2/source/inc/UncachedDataSequence.hxx  |4 ++--
 chart2/source/inc/WeakListenerAdapter.hxx   |4 ++--
 chart2/source/inc/WrappedPropertySet.hxx|4 ++--
 chart2/source/model/inc/BaseCoordinateSystem.hxx|4 ++--
 chart2/source/model/inc/ChartTypeManager.hxx|4 ++--
 chart2/source/model/inc/DataSeries.hxx  |4 ++--
 chart2/source/model/inc/Diagram.hxx |4 ++--
 chart2/source/model/inc/StockBar.hxx|4 ++--
 chart2/source/model/inc/XMLFilter.hxx   |4 ++--
 chart2/source/model/main/Axis.hxx   |4 ++--
 chart2/source/model/main/DataPoint.hxx  |4 ++--
 chart2/source/model/main/FormattedString.hxx|4 ++--
 chart2/source/model/main/GridProperties.hxx |4 ++--
 chart2/source/model/main/Legend.hxx |4 ++--
 chart2/source/model/main/PageBackground.hxx |4 ++--
 chart2/source/model/main/Title.hxx  |4 ++--
 chart2/source/model/main/Wall.hxx   |4 ++--
 chart2/source/model/template/ChartType.hxx  |4 ++--
 chart2/source/model/template/ChartTypeTemplate.hxx  |4 ++--
 chart2/source/model/template/DataInterpreter.hxx|4 ++--
 chart2/source/tools/ModifyListenerCallBack.cxx  |4 ++--
 chart2/source/tools/ModifyListenerHelper.cxx|2 +-
 chart2/source/tools/RegressionCurveModel.hxx|4 ++--
 chart2/source/tools/RegressionEquation.hxx

[Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=88206

--- Comment #14 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5c420fcdf9f36852df793b9944db4491271d23cf

tdf#88206 replace cppu::WeakImplHelper* etc.

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=88206

--- Comment #14 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5c420fcdf9f36852df793b9944db4491271d23cf

tdf#88206 replace cppu::WeakImplHelper* etc.

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92805] New: Field type chapter is not updated correctly if its actual level has not been used yet

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92805

Bug ID: 92805
   Summary: Field type chapter is not updated correctly if its
actual level has not been used yet
   Product: LibreOffice
   Version: 4.4.4.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: michael.fiedle...@gmx.de

Created attachment 117302
  -- https://bugs.documentfoundation.org/attachment.cgi?id=117302action=edit
minimal test case

Steps to reproduce:

Open the attached document: The header of a left page contains the current
level 1 heading by using a field of type chapter, e. g. chapter name.  On
the right page, it is the current level 2 heading.  On every page, a level 2
heading is used.  The field for current heading 1 uses the value of a heading 2
if there was no heading 1 yet.


Actual behaviour:

Go to page 4 or page 6: Although the current (level 2) heading is already at
number 3, the heading 1 field still uses the heading (level 2) number 1 from
the beginning of the document.


Expected behaviour:

The field for current heading level 1 should use the value of the current
heading level 2, if there was no heading of level 1 yet.  It should NOT use a
heading level 2 from the beginning which is not valid any more.


See the attached PDF file which shows a real world example (Goethe: Faust 1)
that suffers from this problem.  E. g. on page 18 and 19, the headings should
be the same: A level 1 heading has not occured yet (comes on page 22) and the
current heading level 2 is Prolog im Himmel.  However, on page 18 the header
still contains Zueignung from the beginning.


Environment used:

LibreOffice 4.4.4.3-3
Debian GNU/Linux 7.8 (wheezy) (x86)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2015-07-17 Thread Eike Rathke

 sc/source/core/data/column3.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 3e17ed1fc2845da5a279d21ffa3ea51d637e515e
Author: Eike Rathke er...@redhat.com
Date:   Fri Jul 17 18:14:27 2015 +0200

Resolves: tdf#92767 use ISO 8601 for internal date string representation

Change-Id: I481bf3295feb64827de2122234a9300d0b8ced40

diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx
index 521ccb3..d5558e5 100644
--- a/sc/source/core/data/column3.cxx
+++ b/sc/source/core/data/column3.cxx
@@ -2020,6 +2020,10 @@ class FilterEntriesHandler
 fVal = rtl::math::approxFloor(fVal);
 mbHasDates = true;
 bDate = true;
+// Convert string representation to ISO 8601 date to eliminate
+// locale dependent behaviour later when filtering for dates.
+sal_uInt32 nIndex = pFormatter-GetFormatIndex( 
NF_DATE_DIN_MMDD);
+pFormatter-GetInputLineString( fVal, nIndex, aStr);
 }
 // maybe extend ScTypedStrData enum is also an option here
 mrStrings.push_back(ScTypedStrData(aStr, fVal, 
ScTypedStrData::Value,bDate));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 92571] Error mime type in Manifest.xml with picture.wmf and picture.emf

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92571

Adolfo Jayme f...@libreoffice.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - include/svl svl/source svx/source

2015-07-17 Thread Michael Stahl

 include/svl/currencytable.hxx|8 ---
 svl/source/numbers/currencytable.cxx |8 +++
 svl/source/numbers/zforlist.cxx  |   39 +++
 svx/source/xml/xmlgrhlp.cxx  |2 -
 4 files changed, 32 insertions(+), 25 deletions(-)

New commits:
commit 5351f621d5eb599757af95213c4b391c0f34df2e
Author: Michael Stahl mst...@redhat.com
Date:   Fri Jul 17 17:27:56 2015 +0200

svx: this was supposed to be image/x-eps

Change-Id: Ieb9d7f23a0ef1e4546c488a678dbfde085156216

diff --git a/svx/source/xml/xmlgrhlp.cxx b/svx/source/xml/xmlgrhlp.cxx
index ffb5c40..b193887 100644
--- a/svx/source/xml/xmlgrhlp.cxx
+++ b/svx/source/xml/xmlgrhlp.cxx
@@ -473,7 +473,7 @@ OUString SvXMLGraphicHelper::ImplGetGraphicMimeType( const 
OUString rFileName )
 { tif, image/tiff },
 { svg, image/svg+xml },
 { wmf, image/x-wmf },
-{ eps, image/eps },
+{ eps, image/x-eps },
 { bmp, image/bmp },
 { pct, image/x-pict }
 };
commit 50cf52bd0eb45a2f8ca91bbd64def942ef191f2f
Author: Michael Stahl mst...@redhat.com
Date:   Fri Jul 17 13:11:32 2015 +0200

svl: replace boost::ptr_vector with std::vectorstd::unique_ptr

Change-Id: Ie1174d57b696f49c05010ece1b721185b0904fd6

diff --git a/include/svl/currencytable.hxx b/include/svl/currencytable.hxx
index 44ead72..b7a074b 100644
--- a/include/svl/currencytable.hxx
+++ b/include/svl/currencytable.hxx
@@ -12,11 +12,13 @@
 
 #include svl/svldllapi.h
 #include svl/zforlist.hxx
-#include boost/ptr_container/ptr_vector.hpp
+
+#include vector
+#include memory
 
 class SVL_DLLPUBLIC NfCurrencyTable
 {
-typedef boost::ptr_vectorNfCurrencyEntry DataType;
+typedef std::vectorstd::unique_ptrNfCurrencyEntry DataType;
 DataType maData;
 public:
 typedef DataType::iterator iterator;
@@ -29,7 +31,7 @@ public:
 
 size_t size() const;
 
-void insert( iterator it, NfCurrencyEntry* p );
+void insert(iterator it, std::unique_ptrNfCurrencyEntry p);
 };
 
 #endif
diff --git a/svl/source/numbers/currencytable.cxx 
b/svl/source/numbers/currencytable.cxx
index 91be75e..17e362d 100644
--- a/svl/source/numbers/currencytable.cxx
+++ b/svl/source/numbers/currencytable.cxx
@@ -16,12 +16,12 @@ NfCurrencyTable::iterator NfCurrencyTable::begin()
 
 NfCurrencyEntry NfCurrencyTable::operator[] ( size_t i )
 {
-return maData[i];
+return *maData[i];
 }
 
 const NfCurrencyEntry NfCurrencyTable::operator[] ( size_t i ) const
 {
-return maData[i];
+return *maData[i];
 }
 
 size_t NfCurrencyTable::size() const
@@ -29,9 +29,9 @@ size_t NfCurrencyTable::size() const
 return maData.size();
 }
 
-void NfCurrencyTable::insert( iterator it, NfCurrencyEntry* p )
+void NfCurrencyTable::insert(iterator it, std::unique_ptrNfCurrencyEntry p)
 {
-maData.insert(it, p);
+maData.insert(it, std::move(p));
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx
index afca600..38bdce0 100644
--- a/svl/source/numbers/zforlist.cxx
+++ b/svl/source/numbers/zforlist.cxx
@@ -3615,11 +3615,12 @@ void SvNumberFormatter::ImpInitCurrencyTable()
 aConfiguredCurrencyAbbrev, eConfiguredCurrencyLanguage );
 sal_uInt16 nSecondarySystemCurrencyPosition = 0;
 sal_uInt16 nMatchingSystemCurrencyPosition = 0;
-NfCurrencyEntry* pEntry;
-
+std::unique_ptrNfCurrencyEntry pEntry(
 // first entry is SYSTEM
-pEntry = new NfCurrencyEntry( *pLocaleData, LANGUAGE_SYSTEM );
-theCurrencyTable::get().insert( theCurrencyTable::get().begin(), pEntry );
+new NfCurrencyEntry( *pLocaleData, LANGUAGE_SYSTEM ));
+
+theCurrencyTable::get().insert(
+theCurrencyTable::get().begin(), std::move(pEntry));
 sal_uInt16 nCurrencyPos = 1;
 
 ::com::sun::star::uno::Sequence ::com::sun::star::lang::Locale  xLoc =
@@ -3649,28 +3650,29 @@ void SvNumberFormatter::ImpInitCurrencyTable()
 }
 if ( nDefault  nCurrencyCount )
 {
-pEntry = new NfCurrencyEntry( pCurrencies[nDefault], *pLocaleData, 
eLang );
+pEntry.reset(new NfCurrencyEntry(pCurrencies[nDefault], 
*pLocaleData, eLang));
 }
 else
-{
-pEntry = new NfCurrencyEntry( *pLocaleData, eLang );// first 
or ShellsAndPebbles
+{   // first or ShellsAndPebbles
+pEntry.reset(new NfCurrencyEntry(*pLocaleData, eLang));
 }
 if (LocaleDataWrapper::areChecksEnabled())
 {
 lcl_CheckCurrencySymbolPosition( *pEntry );
 }
-rCurrencyTable.insert( rCurrencyTable.begin() + nCurrencyPos++, pEntry 
);
 if ( !nSystemCurrencyPosition  !aConfiguredCurrencyAbbrev.isEmpty() 

  pEntry-GetBankSymbol() == aConfiguredCurrencyAbbrev 
  pEntry-GetLanguage() == eConfiguredCurrencyLanguage )
 {
-nSystemCurrencyPosition = nCurrencyPos-1;
+

[Libreoffice-commits] core.git: connectivity/source

2015-07-17 Thread Caolán McNamara

 connectivity/source/drivers/mozab/MColumnAlias.cxx |6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit 7fbadc4db37e02d78fde34d6fd52feb73cc5dd1f
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 16:47:23 2015 +0100

error C2065: Â´bFoundÂ´ : undeclared identifier

Change-Id: Ibf72f77458d837849fe20361ca751dce2989830c

diff --git a/connectivity/source/drivers/mozab/MColumnAlias.cxx 
b/connectivity/source/drivers/mozab/MColumnAlias.cxx
index 2a28ef5..89ba2d6 100644
--- a/connectivity/source/drivers/mozab/MColumnAlias.cxx
+++ b/connectivity/source/drivers/mozab/MColumnAlias.cxx
@@ -125,9 +125,7 @@ void OColumnAlias::initialize( const 
::com::sun::star::uno::Reference ::com::su
 
 OString sAsciiProgrammaticName( OUStringToOString( 
*pProgrammaticNames, RTL_TEXTENCODING_ASCII_US ) );
 
-#if OSL_DEBUG_LEVEL  0
 bool bFound = false;
-#endif
 for (   AliasMap::iterator search = m_aAliasMap.begin();
 ( search != m_aAliasMap.end() );
 ++search
@@ -139,15 +137,13 @@ void OColumnAlias::initialize( const 
::com::sun::star::uno::Reference ::com::su
 m_aAliasMap.erase( search );
 m_aAliasMap[ sAssignedAlias ] = entry;
 
-#if OSL_DEBUG_LEVEL  0
 bFound = true;
-#endif
 
 break;
 }
 }
 
-OSL_ENSURE( bFound, OColumnAlias::setAlias: did not find a 
programmatic name which exists in the configuration! );
+OSL_ENSURE( bFound, OColumnAlias::setAlias: did not find a 
programmatic name which exists in the configuration! ); (void)bFound;
 }
 }
 catch( const Exception )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2015-07-17 Thread Caolán McNamara

 vcl/source/window/accel.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d368a613fe756a6f1992425078d99e9c72fc39ed
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jul 17 16:57:58 2015 +0100

WaE: -Wmaybe-uninitialized

Change-Id: I295ef24b8d524e152c85b90548d8a7753347dacd

diff --git a/vcl/source/window/accel.cxx b/vcl/source/window/accel.cxx
index 5f8dc36..6905142 100644
--- a/vcl/source/window/accel.cxx
+++ b/vcl/source/window/accel.cxx
@@ -88,7 +88,7 @@ sal_uInt16 ImplAccelEntryGetIndex( ImplAccelList* pList, 
sal_uInt16 nId,
 
 static void ImplAccelEntryInsert( ImplAccelList* pList, ImplAccelEntry* pEntry 
)
 {
-sal_uInt16  nInsIndex;
+sal_uInt16  nInsIndex(0);
 sal_uInt16  nIndex = ImplAccelEntryGetIndex( pList, pEntry-mnId, 
nInsIndex );
 
 if ( nIndex != ACCELENTRY_NOTFOUND )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 92767] Autofilter on date is locale dependent

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92767

--- Comment #4 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Eike Rathke committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3e17ed1fc2845da5a279d21ffa3ea51d637e515e

Resolves: tdf#92767 use ISO 8601 for internal date string representation

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92767] Autofilter on date is locale dependent

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92767

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|| target:5.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92801] EDITING FILEOPEN FILESAVE Bug which allows removing read-only password protection from presentations

2015-07-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92801

raal r...@post.cz changed:

   What|Removed |Added

 CC||r...@post.cz
  Component|Impress |LibreOffice
Version|unspecified |3.5.0 release

--- Comment #1 from raal r...@post.cz ---
The same in LibreOffice 3.5.0 Build ID: d6cde02, Impress and other components,
changing component and version.
Not sure if it's a bug, leaving unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[GSoC] Improve user experience with CMIS – Weekly report #8

2015-07-17 Thread Szymon Kłos

This week I had to do some important things, what caused that, I didn't
do so much.

* I've added separator between groups (apps, services, protocols) in
service type listbox
* Splitted the code and moved folder tree class to new file, dialog's
code to the fpicker directory
* added question which appears when user want to overwrite existing file
* now the last successful used service is selected by default
* rebase and push to the master
* open/save remote entries in menus ( File  … )
* question to confirm delete of service
* wrote blog post about work results:
http://eszkadev.blogspot.com/2015/07/gsoc-15-remote-files-dialog.html

TODO:
- change expanded folder icon in the folder tree
- my proposal: New folder button in the save mode // this and other
points from my blog I must discuss in #libreoffice-design
- testing

Regards,
Szymon

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/qa filter/source

2015-07-17 Thread Caolán McNamara

 filter/qa/cppunit/data/pict/fail/exception-1.pct |binary
 filter/source/graphicfilter/ipict/ipict.cxx  |5 +
 2 files changed, 5 insertions(+)

New commits:
commit e5aae767d634ba7efc8a5ecf2889678176babeb8
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Thu Jul 16 10:01:24 2015 +0100

exception on div by 0

Change-Id: Id33d6a5e3df5812babd28ebfc65b95ce97219ad3
(cherry picked from commit cf4159e16c13a13d0bedccebb50bb08f1662bc1c)
Reviewed-on: https://gerrit.libreoffice.org/17121
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com

diff --git a/filter/qa/cppunit/data/pict/fail/exception-1.pct 
b/filter/qa/cppunit/data/pict/fail/exception-1.pct
new file mode 100644
index 000..f9cd85a
Binary files /dev/null and b/filter/qa/cppunit/data/pict/fail/exception-1.pct 
differ
diff --git a/filter/source/graphicfilter/ipict/ipict.cxx 
b/filter/source/graphicfilter/ipict/ipict.cxx
index 6621edd..4f0c39b 100644
--- a/filter/source/graphicfilter/ipict/ipict.cxx
+++ b/filter/source/graphicfilter/ipict/ipict.cxx
@@ -1859,6 +1859,7 @@ sal_uLong PictReader::ReadData(sal_uInt16 nOpcode)
 
 void PictReader::ReadPict( SvStream  rStreamPict, GDIMetaFile  rGDIMetaFile )
 {
+try {
 sal_uInt16  nOpcode;
 sal_uInt8   nOneByteOpcode;
 sal_uLong   nSize, nPercent, nLastPercent;
@@ -1950,6 +1951,10 @@ void PictReader::ReadPict( SvStream  rStreamPict, 
GDIMetaFile  rGDIMetaFile )
 pPict-SetEndian(nOrigNumberFormat);
 
 if (pPict-GetError()) pPict-Seek(nOrigPos);
+} catch (...)
+{
+rStreamPict.SetError(SVSTREAM_FILEFORMAT_ERROR);
+}
 }
 
 namespace pict {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

1 2 >

1 - 100 of 186 matches

Mail list logo