[Libreoffice-commits] core.git: sc/source
sc/source/filter/orcus/interface.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit 3554d0a48a05206b894c3dec2f8c65e3b3c5119c
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Aug 28 08:45:42 2015 +0200
Work around loplugin:staticmethods
(...in what appears to be work in progress code)
Change-Id: Ibc30383e7a25b642db63cf022b3fae953c8fee50
diff --git a/sc/source/filter/orcus/interface.cxx
b/sc/source/filter/orcus/interface.cxx
index c65324a..c1551f9 100644
--- a/sc/source/filter/orcus/interface.cxx
+++ b/sc/source/filter/orcus/interface.cxx
@@ -751,6 +751,7 @@ ScOrcusStyles::protection::protection():
void ScOrcusStyles::protection::applyToItemSet(SfxItemSet /*rSet*/) const
{
+(void)this; // loplugin:staticmethods
}
ScOrcusStyles::border::border()
@@ -759,10 +760,12 @@ ScOrcusStyles::border::border()
void ScOrcusStyles::border::applyToItemSet(SfxItemSet /*rSet*/) const
{
+(void)this; // loplugin:staticmethods
}
void ScOrcusStyles::number_format::applyToItemSet(SfxItemSet /*rSet*/) const
{
+(void)this; // loplugin:staticmethods
}
ScOrcusStyles::xf::xf():
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: What autogen.sh for an alternative ContentProvider for dav:// scheme?
On 08/27/2015 07:34 PM, Giuseppe Castagno wrote:
I wonder if in INetURLObject I can put a single method like this:
bool INetURLObject::IsWebDAV()
{
return ( hasScheme( http ) ||
hasScheme( https ) ||
hasScheme( vnd.sun.start.webdav ) ||
hasScheme( vnd.sun.start.webdavs ) );
}
to have this test in a single place? Currently I repeat it four times.
Sure, or maybe something more descriptive like isAnyWebDavScheme (so
casual readers don't erroneously assume it only checks for
vnd.sun.star.webdav). Also, for schemes known in INetProtocol, feel
free to use the hasScheme(INetProtocol) overload, which should be
slightly faster (which is likely negligible) and less prone to typos.
Finally, looking at the code in INetURLObject I noticed this comment:
http://opengrok.libreoffice.org/xref/core/tools/source/fsys/urlobj.cxx#114
and this chunk of code:
http://opengrok.libreoffice.org/xref/core/tools/source/fsys/urlobj.cxx#335
should vnd.sun.star.webdavs be added as well?
No, all that is only about those schemes that INetURLObject has intimate
knowledge of. Traditionally, for any URL scheme to be usable in LO it
needed to be added to INetURLObject, with scheme-specific parsing
support and all (and that is how the rather random collection of schemes
in INetProtocol came about over time). But that is largely unnecessary
today.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93530] menu non-rendering on click ...
https://bugs.documentfoundation.org/show_bug.cgi?id=93530 --- Comment #7 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Meeks committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a7f07e4dfe0acdec7386d28b23e65a5c0efa9d80 Revert tdf#93530 - the VCL GDI flushing abstraction should glFlush too. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77277] PRINTING: #10 Envelope changes to 6 x 9 envelope (Brother printers)
https://bugs.documentfoundation.org/show_bug.cgi?id=77277 tommy27 ba...@quipo.it changed: What|Removed |Added OS|Linux (All) |All --- Comment #28 from tommy27 ba...@quipo.it --- (In reply to tommy27 from comment #27) *** Bug 93718 has been marked as a duplicate of this bug. *** issue was confirmed under Windows as well. hardware -- ALL -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/unotools unotools/source
include/unotools/atom.hxx |4 ++--
unotools/source/misc/atom.cxx | 10 ++
2 files changed, 8 insertions(+), 6 deletions(-)
New commits:
commit 1b9c3a17e8496aedfb80528c5275e6658154789d
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Aug 28 09:46:57 2015 +0200
Revert Simplify MultiAtomProvider::getString
This reverts commit 625c93a8daa2d23bfd42908e6fbba428d5967e84,
causes problems in (Linux-only) callers.
diff --git a/include/unotools/atom.hxx b/include/unotools/atom.hxx
index d59f67a..fdc656e 100644
--- a/include/unotools/atom.hxx
+++ b/include/unotools/atom.hxx
@@ -47,7 +47,7 @@ namespace utl {
~AtomProvider();
int getAtom( const OUString, bool bCreate = false );
-OUString getString( int ) const;
+const OUString getString( int ) const;
};
class UNOTOOLS_DLLPUBLIC MultiAtomProvider
@@ -59,7 +59,7 @@ namespace utl {
int getAtom( int atomClass, const OUString rString, bool bCreate =
false );
-OUString getString( int atomClass, int atom ) const;
+const OUString getString( int atomClass, int atom ) const;
};
}
diff --git a/unotools/source/misc/atom.cxx b/unotools/source/misc/atom.cxx
index 44ad756..85ddad4 100644
--- a/unotools/source/misc/atom.cxx
+++ b/unotools/source/misc/atom.cxx
@@ -45,11 +45,12 @@ int AtomProvider::getAtom( const OUString rString, bool
bCreate )
return m_nAtoms-1;
}
-OUString AtomProvider::getString( int nAtom ) const
+const OUString AtomProvider::getString( int nAtom ) const
{
+static OUString aEmpty;
std::unordered_mapint, OUString::const_iterator it = m_aStringMap.find(
nAtom );
-return it == m_aStringMap.end() ? OUString() : it-second;
+return it == m_aStringMap.end() ? aEmpty : it-second;
}
MultiAtomProvider::MultiAtomProvider()
@@ -78,14 +79,15 @@ int MultiAtomProvider::getAtom( int atomClass, const
OUString rString, bool bCr
return INVALID_ATOM;
}
-OUString MultiAtomProvider::getString( int atomClass, int atom ) const
+const OUString MultiAtomProvider::getString( int atomClass, int atom ) const
{
std::unordered_mapint, AtomProvider*::const_iterator it =
m_aAtomLists.find( atomClass );
if( it != m_aAtomLists.end() )
return it-second-getString( atom );
-return OUString();
+static OUString aEmpty;
+return aEmpty;
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93423] Memory leak in SbMethod::Broadcast
https://bugs.documentfoundation.org/show_bug.cgi?id=93423 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=50 ||572 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93530] menu non-rendering on click ...
https://bugs.documentfoundation.org/show_bug.cgi?id=93530 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93529] OpenGL tracker bug ...
https://bugs.documentfoundation.org/show_bug.cgi?id=93529 Bug 93529 depends on bug 93530, which changed state. Bug 93530 Summary: menu non-rendering on click ... https://bugs.documentfoundation.org/show_bug.cgi?id=93530 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82370] PRINTING: incorrect orientation of #10 envelope (Brother printer)
https://bugs.documentfoundation.org/show_bug.cgi?id=82370 tommy27 ba...@quipo.it changed: What|Removed |Added OS|Linux (All) |All --- Comment #11 from tommy27 ba...@quipo.it --- issue was confirmed under Windows as well. see: https://bugs.documentfoundation.org/show_bug.cgi?id=93718#c0 hardware -- ALL -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 43cb629de1ecc41f702f14209ba8199dfe57c3a2
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Aug 28 09:26:41 2015 +0200
Make sure nEnd-nIndex-1 is valid arg to OUString::copy
Change-Id: Ie646ae781bcd54be81173db42fe10f61b31ac628
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index b47d870..2a8621a 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -2974,7 +2974,7 @@ void DomainMapper_Impl::handleRubyEQField(
FieldContextPtr pContext)
nIndex = 0;
OUString sPart1 = sRubyParts.getToken(0, ',', nIndex);
OUString sPart2 = sRubyParts.getToken(0, ',', nIndex);
-if ((nIndex = sPart1.indexOf('(')) != -1 (nEnd =
sPart1.lastIndexOf(')'))!=-1 )
+if ((nIndex = sPart1.indexOf('(')) != -1 (nEnd =
sPart1.lastIndexOf(')'))!=-1 nEnd nIndex)
{
aInfo.sRubyText = sPart1.copy(nIndex+1,nEnd-nIndex-1);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93725] 觸控很不友善
https://bugs.documentfoundation.org/show_bug.cgi?id=93725 --- Comment #1 from raal r...@post.cz --- *** Bug 93726 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93725] 觸控很不友善
https://bugs.documentfoundation.org/show_bug.cgi?id=93725 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #2 from raal r...@post.cz --- Please translate to english language. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93726] 觸控很不友善
https://bugs.documentfoundation.org/show_bug.cgi?id=93726 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||r...@post.cz Resolution|--- |DUPLICATE --- Comment #1 from raal r...@post.cz --- *** This bug has been marked as a duplicate of bug 93725 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93461] Caption of images are hidden behind the image
https://bugs.documentfoundation.org/show_bug.cgi?id=93461 --- Comment #1 from Jan Bart jb...@tempress.nl --- Captions disappear when a sub-document is embedded in a master-document and a PDF is generated from the master-doc. But a PDF created from the sub-document alone shows the figure captions. This happens in LO 5.0.0.5 win7 and xubuntu version. The same setup in 4.0.5 works beautifully (i do not use newer versions due to other issues with templates (https://bugs.documentfoundation.org/show_bug.cgi?id=93421) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93710] Allow special character as separator for numbered headings (and similar)
https://bugs.documentfoundation.org/show_bug.cgi?id=93710 Ulrich Windl ulrich.wi...@rz.uni-regensburg.de changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED CC||ulrich.wi...@rz.uni-regensb ||urg.de Ever confirmed|1 |0 --- Comment #2 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de --- (In reply to Cor Nouws from comment #1) (...) When I look at Tools Outline numbering, I can set the Separator before and After. (...) Does that help for you? (...) You are right, it seems I was looking at the wrong tab: I had the Position (in German) tab, not the Numbering tab open. In the latter things are as described. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93725] 觸控很不友善
https://bugs.documentfoundation.org/show_bug.cgi?id=93725 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||ba...@quipo.it Ever confirmed|0 |1 --- Comment #3 from tommy27 ba...@quipo.it --- status NEEDINFO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: starmath/source
starmath/source/dialog.cxx | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
New commits:
commit a206b04ceb4108fdd1414dd70addcfcd42a8c29a
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Aug 28 09:40:36 2015 +0200
Simplify SmFontStyles::GetStyleName
Change-Id: I2df721af0eb60e28cd9882195f68a034a5fa802e
diff --git a/starmath/source/dialog.cxx b/starmath/source/dialog.cxx
index 57ab5ba..7fe760c 100644
--- a/starmath/source/dialog.cxx
+++ b/starmath/source/dialog.cxx
@@ -17,6 +17,10 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
+#include sal/config.h
+
+#include cassert
+
#include tools/rcid.h
#include comphelper/string.hxx
#include svl/eitem.hxx
@@ -77,7 +81,6 @@ class SmFontStyles
OUString aBold;
OUString aItalic;
OUString aBoldItalic;
-OUString aEmpty;
public:
SmFontStyles();
@@ -118,17 +121,14 @@ const OUString SmFontStyles::GetStyleName( sal_uInt16
nIdx ) const
// 0 = normal, 1 = italic,
// 2 = bold,3 = bold italic
-#if OSL_DEBUG_LEVEL 1
-OSL_ENSURE( nIdx GetCount(), index out of range );
-#endif
+assert( nIdx GetCount() );
switch (nIdx)
{
case 0 : return aNormal;
case 1 : return aItalic;
case 2 : return aBold;
-case 3 : return aBoldItalic;
+default: /*case 3:*/ return aBoldItalic;
}
-return aEmpty;
}
const SmFontStyles GetFontStyles()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl vcl/osx vcl/source vcl/unx vcl/win
include/vcl/opengl/OpenGLHelper.hxx |3 ---
vcl/osx/salframe.cxx|5 -
vcl/source/opengl/OpenGLHelper.cxx |9 -
vcl/unx/generic/window/salframe.cxx |3 ---
vcl/unx/gtk/window/gtksalframe.cxx |3 ---
vcl/win/source/window/salframe.cxx |3 ---
6 files changed, 26 deletions(-)
New commits:
commit a7f07e4dfe0acdec7386d28b23e65a5c0efa9d80
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Aug 28 08:03:59 2015 +0100
Revert tdf#93530 - the VCL GDI flushing abstraction should glFlush too.
This reverts commit e16e64dd862c8f386f80de43ad68e831e169d49d.
I somehow forgot that glFlush is context specific, (gl always gets
me that way).
diff --git a/include/vcl/opengl/OpenGLHelper.hxx
b/include/vcl/opengl/OpenGLHelper.hxx
index d14df0d..95c23c8 100644
--- a/include/vcl/opengl/OpenGLHelper.hxx
+++ b/include/vcl/opengl/OpenGLHelper.hxx
@@ -67,9 +67,6 @@ public:
*/
static bool isVCLOpenGLEnabled();
-/// flush the OpenGL command queue - if OpenGL is enabled.
-static void flush();
-
#if defined UNX !defined MACOSX !defined IOS !defined ANDROID
!defined(LIBO_HEADLESS)
static bool GetVisualInfo(Display* pDisplay, int nScreen, XVisualInfo
rVI);
static GLXFBConfig GetPixmapFBConfig( Display* pDisplay, bool bInverted );
diff --git a/vcl/osx/salframe.cxx b/vcl/osx/salframe.cxx
index 8f5fbfd..3882c40 100644
--- a/vcl/osx/salframe.cxx
+++ b/vcl/osx/salframe.cxx
@@ -28,7 +28,6 @@
#include vcl/window.hxx
#include vcl/syswin.hxx
#include vcl/settings.hxx
-#include vcl/opengl/OpenGLHelper.hxx
#include osx/saldata.hxx
#include quartz/salgdi.h
@@ -39,7 +38,6 @@
#include osx/a11yfactory.h
#include quartz/utils.h
-
#include salwtype.hxx
#include premac.h
@@ -883,7 +881,6 @@ void AquaSalFrame::Flush()
{
[mpNSView display];
}
-OpenGLHelper::flush();
}
void AquaSalFrame::Flush( const Rectangle rRect )
@@ -905,7 +902,6 @@ void AquaSalFrame::Flush( const Rectangle rRect )
{
[mpNSView display];
}
-OpenGLHelper::flush();
}
void AquaSalFrame::Sync()
@@ -918,7 +914,6 @@ void AquaSalFrame::Sync()
[mpNSView setNeedsDisplay: YES];
[mpNSView display];
}
-OpenGLHelper::flush();
}
void AquaSalFrame::SetInputContext( SalInputContext* pContext )
diff --git a/vcl/source/opengl/OpenGLHelper.cxx
b/vcl/source/opengl/OpenGLHelper.cxx
index f669fba..2e0dcfd 100644
--- a/vcl/source/opengl/OpenGLHelper.cxx
+++ b/vcl/source/opengl/OpenGLHelper.cxx
@@ -707,13 +707,4 @@ GLXFBConfig OpenGLHelper::GetPixmapFBConfig( Display*
pDisplay, bool bInverted
#endif
-void OpenGLHelper::flush()
-{
-if (!isVCLOpenGLEnabled())
-return;
-
-glFlush();
-CHECK_GL_ERROR();
-}
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/generic/window/salframe.cxx
b/vcl/unx/generic/window/salframe.cxx
index 43189003..8dacdd8 100644
--- a/vcl/unx/generic/window/salframe.cxx
+++ b/vcl/unx/generic/window/salframe.cxx
@@ -35,7 +35,6 @@
#include vcl/settings.hxx
#include vcl/bmpacc.hxx
#include vcl/opengl/OpenGLContext.hxx
-#include vcl/opengl/OpenGLHelper.hxx
#include prex.h
#include X11/Xatom.h
@@ -2455,13 +2454,11 @@ void X11SalFrame::SetTitle( const OUString rTitle )
void X11SalFrame::Flush()
{
XFlush( GetDisplay()-GetDisplay() );
-OpenGLHelper::flush();
}
void X11SalFrame::Sync()
{
XSync( GetDisplay()-GetDisplay(), False );
-OpenGLHelper::flush();
}
// Keyboard
diff --git a/vcl/unx/gtk/window/gtksalframe.cxx
b/vcl/unx/gtk/window/gtksalframe.cxx
index b911378..6bc25f3 100644
--- a/vcl/unx/gtk/window/gtksalframe.cxx
+++ b/vcl/unx/gtk/window/gtksalframe.cxx
@@ -37,7 +37,6 @@
#include vcl/svapp.hxx
#include vcl/window.hxx
#include vcl/settings.hxx
-#include vcl/opengl/OpenGLHelper.hxx
#if !GTK_CHECK_VERSION(3,0,0)
# include unx/x11/xlimits.hxx
@@ -2935,13 +2934,11 @@ void GtkSalFrame::Flush()
#else
XFlush (GDK_DISPLAY_XDISPLAY (getGdkDisplay()));
#endif
-OpenGLHelper::flush();
}
void GtkSalFrame::Sync()
{
gdk_display_sync( getGdkDisplay() );
-OpenGLHelper::flush();
}
#ifndef GDK_Open
diff --git a/vcl/win/source/window/salframe.cxx
b/vcl/win/source/window/salframe.cxx
index 8dc8076..4268173 100644
--- a/vcl/win/source/window/salframe.cxx
+++ b/vcl/win/source/window/salframe.cxx
@@ -46,7 +46,6 @@
#include vcl/window.hxx
#include vcl/wrkwin.hxx
#include vcl/svapp.hxx
-#include vcl/opengl/OpenGLHelper.hxx
// Warning in SDK header
#ifdef _MSC_VER
@@ -2202,13 +2201,11 @@ void WinSalFrame::SetPointerPos( long nX, long nY )
void WinSalFrame::Flush()
{
GdiFlush();
-OpenGLHelper::flush();
}
void WinSalFrame::Sync()
{
GdiFlush();
-OpenGLHelper::flush();
}
static void ImplSalFrameSetInputContext( HWND hWnd, const SalInputContext*
pContext )
___
Libreoffice-commits mailing list
[Libreoffice-bugs] [Bug 77277] PRINTING: #10 Envelope changes to 6 x 9 envelope (Brother printers)
https://bugs.documentfoundation.org/show_bug.cgi?id=77277 tommy27 ba...@quipo.it changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=93 ||718 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93718] PRINTING: Envelopes #10 Brother Printer changes to C5
https://bugs.documentfoundation.org/show_bug.cgi?id=93718 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=77 ||277 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93701] crash running StarDesktop.getPropertySetInfo().getProperties()
https://bugs.documentfoundation.org/show_bug.cgi?id=93701 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|REOPENED|UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from Cor Nouws c...@nouenoff.nl --- Thanks for reopening! I had a little doubt already when commenting. Sorry for not understanding you well enough. I cannot reproduce the crash on Linux 32 bits. (But it's not exceptional that something crashes on one platform and returns an error on the other, see e.g. tdf#92446) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/qa
vcl/qa/cppunit/timer.cxx | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
New commits:
commit 87c33ab18f747fdfeb56079e723982e11fd97c5f
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Aug 28 08:00:20 2015 +0100
Disable the higher frequency timer tests more effectively.
Change-Id: Ibd832d85ce4b7e6747f95297d3c96d071aff41e2
diff --git a/vcl/qa/cppunit/timer.cxx b/vcl/qa/cppunit/timer.cxx
index 1c08ff9..c6daa16 100644
--- a/vcl/qa/cppunit/timer.cxx
+++ b/vcl/qa/cppunit/timer.cxx
@@ -22,7 +22,8 @@
#include salinst.hxx
// #define TEST_WATCHDOG
-// Comment if UT fails randomly.
+
+// Enables timer tests that appear to provoke windows under load unduly.
//#define TEST_TIMERPRECISION
/// Avoid our timer tests just wedging the build if they fail.
@@ -61,8 +62,10 @@ public:
void testWatchdog();
#endif
void testDurations();
+#ifdef TEST_TIMERPRECISION
void testAutoTimer();
void testMultiAutoTimers();
+#endif
void testRecursiveTimer();
void testSlowTimerCallback();
@@ -73,8 +76,10 @@ public:
CPPUNIT_TEST(testWatchdog);
#endif
CPPUNIT_TEST(testDurations);
+#ifdef TEST_TIMERPRECISION
CPPUNIT_TEST(testAutoTimer);
CPPUNIT_TEST(testMultiAutoTimers);
+#endif
CPPUNIT_TEST(testRecursiveTimer);
CPPUNIT_TEST(testSlowTimerCallback);
@@ -195,6 +200,8 @@ public:
}
};
+#ifdef TEST_TIMERPRECISION
+
void TimerTest::testAutoTimer()
{
const sal_Int32 nDurationMs = 30;
@@ -231,9 +238,7 @@ void TimerTest::testAutoTimer()
}
}
-#ifdef TEST_TIMERPRECISION
CPPUNIT_FAIL(msg.str().c_str());
-#endif
}
void TimerTest::testMultiAutoTimers()
@@ -295,10 +300,9 @@ void TimerTest::testMultiAutoTimers()
}
}
-#ifdef TEST_TIMERPRECISION
CPPUNIT_FAIL(msg.str().c_str());
-#endif
}
+#endif // TEST_TIMERPRECISION
//
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 86838] Portrait printing prints rotated 90 degrees in OS X with Letter page format (Brother printers)
https://bugs.documentfoundation.org/show_bug.cgi?id=86838 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it Summary|Portrait printing prints|Portrait printing prints |rotated 90 degrees in OSX |rotated 90 degrees in OS X |with Letter page format |with Letter page format ||(Brother printers) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93614] Detect hanging OpenGL drivers disable GL ...
https://bugs.documentfoundation.org/show_bug.cgi?id=93614 --- Comment #12 from Michael Meeks michael.me...@collabora.com --- Hi Regina - as Markus says, I think you have a different bug related to gltf rendering in impress (which is FWIW not protected by an OpenGLZone guard); so - I guess if it is not hanging, but simply failing to render for you, then that is reasonbly good news; worth filing another issue I think. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/unotools unotools/source
include/unotools/atom.hxx |4 ++--
unotools/source/misc/atom.cxx | 10 --
2 files changed, 6 insertions(+), 8 deletions(-)
New commits:
commit 625c93a8daa2d23bfd42908e6fbba428d5967e84
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Aug 28 09:29:18 2015 +0200
Simplify MultiAtomProvider::getString
Change-Id: I3ba6f9c829200349a6404c2a155182b5c5c12cd7
diff --git a/include/unotools/atom.hxx b/include/unotools/atom.hxx
index fdc656e..d59f67a 100644
--- a/include/unotools/atom.hxx
+++ b/include/unotools/atom.hxx
@@ -47,7 +47,7 @@ namespace utl {
~AtomProvider();
int getAtom( const OUString, bool bCreate = false );
-const OUString getString( int ) const;
+OUString getString( int ) const;
};
class UNOTOOLS_DLLPUBLIC MultiAtomProvider
@@ -59,7 +59,7 @@ namespace utl {
int getAtom( int atomClass, const OUString rString, bool bCreate =
false );
-const OUString getString( int atomClass, int atom ) const;
+OUString getString( int atomClass, int atom ) const;
};
}
diff --git a/unotools/source/misc/atom.cxx b/unotools/source/misc/atom.cxx
index 85ddad4..44ad756 100644
--- a/unotools/source/misc/atom.cxx
+++ b/unotools/source/misc/atom.cxx
@@ -45,12 +45,11 @@ int AtomProvider::getAtom( const OUString rString, bool
bCreate )
return m_nAtoms-1;
}
-const OUString AtomProvider::getString( int nAtom ) const
+OUString AtomProvider::getString( int nAtom ) const
{
-static OUString aEmpty;
std::unordered_mapint, OUString::const_iterator it = m_aStringMap.find(
nAtom );
-return it == m_aStringMap.end() ? aEmpty : it-second;
+return it == m_aStringMap.end() ? OUString() : it-second;
}
MultiAtomProvider::MultiAtomProvider()
@@ -79,15 +78,14 @@ int MultiAtomProvider::getAtom( int atomClass, const
OUString rString, bool bCr
return INVALID_ATOM;
}
-const OUString MultiAtomProvider::getString( int atomClass, int atom ) const
+OUString MultiAtomProvider::getString( int atomClass, int atom ) const
{
std::unordered_mapint, AtomProvider*::const_iterator it =
m_aAtomLists.find( atomClass );
if( it != m_aAtomLists.end() )
return it-second-getString( atom );
-static OUString aEmpty;
-return aEmpty;
+return OUString();
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93728] New: INSTALLATION: file extensions default to opening Archive Manager
https://bugs.documentfoundation.org/show_bug.cgi?id=93728 Bug ID: 93728 Summary: INSTALLATION: file extensions default to opening Archive Manager Product: LibreOffice Version: 5.0.0.5 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: duane...@hotmail.com I removed the Linux Mint repository version of LibO 4.2.8, then installed 5.0.0.5 from LibreOffice_5.0.0_Linux_x86-64_deb.tar.gz with dpkg. Install was successful. However, afterwards the file extensions (ODT, ODS, etc.) in Nemo file manager would not open the respective program (Writer, Calc, etc.), but instead the program defaults (seen in right-clicking a filename) were set to Archive Manager. All LibO extensions pointed to the same wrong application. THERE IS A WORKAROUND Pursuing the right click, Open With Other Application. Opens the Open With dialogue. if I set each extension type, with the Set to default in the Open With dialogue, then select the Reset to system defaults button, the default Open With reverted to Archive Manager. This appears to be temporary behavior. I set all defaults to the correct application. After a reboot (I wonder if log out would accomplish the same), the Reset to system defaults button kept the new, correct, default application, e.g., clicking on a file.odt opened it in Writer. The new 5.0 installation retained the previous installation's .config/libreoffice/4/ user configuration files. Changing the default application for each extension type appears to be a permanent workaround. When I checked the condition for ANOTHER USER in the same Mint installation, the extensions were ALREADY POINTING TO the corrected applications. That indicates that Open With, Set as Default was not changing a local /home/user file but more probably, /usr/share/applications/defaults.list (a link to /etc/gnome/defaults.list). I would think that if file associations were removed when a previous version was uninstalled, that installing the new version (5.0) would re-establish the file associations -- but it didn't happen in my case. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93711] Translation error (German: Leerezeichen) in chapter numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=93711 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it, ||gautier.sop...@gmail.com Component|Writer |Localization --- Comment #1 from tommy27 ba...@quipo.it --- @Sophie would you please ping the german l10n team to check this one? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93539] FILEOPEN: crash when loading an .odg file created by LibO 4.x
https://bugs.documentfoundation.org/show_bug.cgi?id=93539 --- Comment #3 from raanan.bar...@sfr.fr --- This happens on Windows 7 Service Pack 1. The installation is totally new (reinstall of Windows 7 applications after a catastrophic Windows 10 update) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - vcl/Module_vcl.mk vcl/qa
vcl/Module_vcl.mk|6 -- vcl/qa/cppunit/timer.cxx |3 ++- 2 files changed, 2 insertions(+), 7 deletions(-) New commits: commit f45183fcdef53237af6aff62211751c6b4f542c0 Author: Tor Lillqvist t...@collabora.com Date: Fri Aug 28 09:40:02 2015 +0300 Add a newline and fflush so that it actually shows up in the output Change-Id: Iea123118614ecf038883a0d51337042574ebc6b2 diff --git a/vcl/qa/cppunit/timer.cxx b/vcl/qa/cppunit/timer.cxx index 64a1ab9..1c08ff9 100644 --- a/vcl/qa/cppunit/timer.cxx +++ b/vcl/qa/cppunit/timer.cxx @@ -42,7 +42,8 @@ public: aWait.Seconds = mnSeconds; aWait.Nanosec = 100; // +1ms osl::Thread::wait( aWait ); -fprintf(stderr, ERROR: WatchDog timer thread expired, failing the test!); +fprintf(stderr, ERROR: WatchDog timer thread expired, failing the test!\n); +fflush(stderr); CPPUNIT_ASSERT_MESSAGE(watchdog triggered, false); } }; commit 6e8ec907dce656b81486889bf27489ad866cebd2 Author: Tor Lillqvist t...@collabora.com Date: Fri Aug 28 09:29:31 2015 +0300 CppunitTest_vcl_timer always fails on Windows for me Change-Id: I73f0771a09d3e74242b25922007c00ff77b37f8a diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk index c949f42..4706bdb 100644 --- a/vcl/Module_vcl.mk +++ b/vcl/Module_vcl.mk @@ -124,10 +124,4 @@ $(eval $(call gb_Module_add_check_targets,vcl,\ )) endif -# Is any configuration missing? -ifeq ($(OS),WNT) -$(eval $(call gb_Module_add_check_targets,vcl,\ - CppunitTest_vcl_timer \ -)) -endif # vim: set noet sw=4 ts=4: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93723] Zoom and page icons not visible
https://bugs.documentfoundation.org/show_bug.cgi?id=93723 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it Component|Writer |UI --- Comment #1 from tommy27 ba...@quipo.it --- LibO 5.0.1.2 released today. try upgrading. also give more details about your Linux version. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/Module_vcl.mk
vcl/Module_vcl.mk |6 ++ 1 file changed, 6 insertions(+) New commits: commit 02d87840558523370d552ef452f1660300d161b5 Author: Tor Lillqvist t...@collabora.com Date: Fri Aug 28 10:43:46 2015 +0300 Revert CppunitTest_vcl_timer always fails on Windows for me Now it works for me on Windows. This reverts commit 6e8ec907dce656b81486889bf27489ad866cebd2. diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk index 4706bdb..c949f42 100644 --- a/vcl/Module_vcl.mk +++ b/vcl/Module_vcl.mk @@ -124,4 +124,10 @@ $(eval $(call gb_Module_add_check_targets,vcl,\ )) endif +# Is any configuration missing? +ifeq ($(OS),WNT) +$(eval $(call gb_Module_add_check_targets,vcl,\ + CppunitTest_vcl_timer \ +)) +endif # vim: set noet sw=4 ts=4: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93715] Open Excel Pivot Table in LO Calc causes Excel to crash.
https://bugs.documentfoundation.org/show_bug.cgi?id=93715 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||r...@post.cz Resolution|--- |DUPLICATE --- Comment #1 from raal r...@post.cz --- Hello, Thank you for submitting the bug. The bug has previously been reported, so this bug will be added as a duplicate of it. You will automatically be CCed to updates made to the other bug. *** This bug has been marked as a duplicate of bug 78614 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78614] PIVOTTABLE: pivot table not saved in xlsx
https://bugs.documentfoundation.org/show_bug.cgi?id=78614 raal r...@post.cz changed: What|Removed |Added CC||kjor...@lkjcpa.com --- Comment #11 from raal r...@post.cz --- *** Bug 93715 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77277] PRINTING: #10 Envelope changes to 6 x 9 envelope (Brother printers)
https://bugs.documentfoundation.org/show_bug.cgi?id=77277 tommy27 ba...@quipo.it changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=93 | |718 | CC||gail...@phuhque.com --- Comment #27 from tommy27 ba...@quipo.it --- *** Bug 93718 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93718] PRINTING: Envelopes #10 Brother Printer changes to C5
https://bugs.documentfoundation.org/show_bug.cgi?id=93718 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=77 | |277 | Resolution|--- |DUPLICATE --- Comment #1 from tommy27 ba...@quipo.it --- this is a duplicate of Bug 77277 and Bug 82370 (next time just type Bug without ID to have this automatically linked). thanks for confirming that both issues affect Windows systems as well. I'll update the platform to ALL in those reports. *** This bug has been marked as a duplicate of bug 77277 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Error while pushing commits for bug 93240
Hi, I'm unable to figure out why my commits are not being pushed. *$ git push --set-upstream origin my_93240 * Counting objects: 61, done. Delta compression using up to 4 threads. Compressing objects: 100% (10/10), done. Writing objects: 100% (11/11), 1.15 KiB | 0 bytes/s, done. Total 11 (delta 8), reused 0 (delta 0) remote: Resolving deltas: 100% (8/8) remote: Processing changes: refs: 1, done To ssh://logerrit/core ! [remote rejected] my_93240 - my_93240 (prohibited by Gerrit) error: failed to push some refs to 'ssh://logerrit/core' How do I fix this? Regards, Shreyansh -- Regards, Shreyansh Gandhi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93719] MAILMERGE: Freezes On Step 5: Adjust Layout in OS X Or Does Not Show Preview on Windows 7
https://bugs.documentfoundation.org/show_bug.cgi?id=93719 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Keywords||regression Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93719] MAILMERGE: Freezes On Step 5: Adjust Layout in OS X Or Does Not Show Preview on Windows 7
https://bugs.documentfoundation.org/show_bug.cgi?id=93719 --- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk --- I can reproduce this issue on Version: 5.0.0.5 Build ID: 1b1a90865e348b492231e1c451437d7a15bb262b Locale : fr-FR (fr.UTF-8) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93719] MAILMERGE: Freezes On Step 5: Adjust Layout in OS X Or Does Not Show Preview on Windows 7
https://bugs.documentfoundation.org/show_bug.cgi?id=93719 --- Comment #4 from Alex Thurgood ipla...@yahoo.co.uk --- Tested on OSX 10.10.5 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: About liststore in areatabpage.ui (cui module)
On Wed, 2015-08-26 at 22:52 -0700, julien2412 wrote: Hello, By giving a try to tdf#31488 (pptx import: blue background, save/reopen as .odp changes to gray), I noticed that each value of liststore LB_AREA_TYPE was at 0, see http://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui/areatabpage .ui#23 Comparing with other liststore, I wonder if it's correct or not. Checking the original conversion of ad0c6359dc044c659160a6a51c1647607c58979a the original src also had the same Default id for all None to Bitmap entries, so the value there of 0 is correct from that context. Sometimes the code uses the ids and sometimes the code uses the positions. Checking that commit show that GetSelectEntryPos/SelectEntryPos are the things used here and nothing that uses the ids. So all is well in the .ui file apparently. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93656] Unable to organize forms in subfolders
https://bugs.documentfoundation.org/show_bug.cgi?id=93656 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #6 from Adolfo Jayme f...@libreoffice.org --- The FIXED status is reserved to issues closed with a commit. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/source sd/qa
filter/source/msfilter/msdffimp.cxx | 26 ++
sd/qa/unit/data/ppt/pass/hang-11.ppt |binary
sd/qa/unit/data/ppt/pass/hang-12.ppt |binary
3 files changed, 22 insertions(+), 4 deletions(-)
New commits:
commit a50be4ba133d2a92af37dd7b78b70377a05d716d
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 27 15:59:46 2015 +0100
check returns of SeekToEndOfRecord
Change-Id: Ia593dd0e2239a97f17bb03f005d22028da482445
(cherry picked from commit d400f155fdc3867ad4a067c2bf85588fc0fbb2a2)
Reviewed-on: https://gerrit.libreoffice.org/18096
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/filter/source/msfilter/msdffimp.cxx
b/filter/source/msfilter/msdffimp.cxx
index ba0aae0..09458f8 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -3253,12 +3253,19 @@ bool SvxMSDffManager::SeekToRec( SvStream rSt,
sal_uInt16 nRecId, sal_uLong nMa
if ( pRecHd != NULL )
*pRecHd = aHd;
else
-aHd.SeekToBegOfRecord( rSt );
+{
+bool bSeekSuccess = aHd.SeekToBegOfRecord(rSt);
+if (!bSeekSuccess)
+{
+bRet = false;
+break;
+}
+}
}
}
if ( !bRet )
{
-bool bSeekSuccess = aHd.SeekToEndOfRecord( rSt );
+bool bSeekSuccess = aHd.SeekToEndOfRecord(rSt);
if (!bSeekSuccess)
break;
}
@@ -3287,11 +3294,22 @@ bool SvxMSDffManager::SeekToRec2( sal_uInt16 nRecId1,
sal_uInt16 nRecId2, sal_uL
if ( pRecHd )
*pRecHd = aHd;
else
-aHd.SeekToBegOfRecord( rStCtrl );
+{
+bool bSeekSuccess = aHd.SeekToBegOfRecord(rStCtrl);
+if (!bSeekSuccess)
+{
+bRet = false;
+break;
+}
+}
}
}
if ( !bRet )
-aHd.SeekToEndOfRecord( rStCtrl );
+{
+bool bSeekSuccess = aHd.SeekToEndOfRecord(rStCtrl);
+if (!bSeekSuccess)
+break;
+}
}
while ( rStCtrl.good() rStCtrl.Tell() nMaxFilePos !bRet );
if ( !bRet )
diff --git a/sd/qa/unit/data/ppt/pass/hang-11.ppt
b/sd/qa/unit/data/ppt/pass/hang-11.ppt
new file mode 100644
index 000..2d9ef18
Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/hang-11.ppt differ
diff --git a/sd/qa/unit/data/ppt/pass/hang-12.ppt
b/sd/qa/unit/data/ppt/pass/hang-12.ppt
new file mode 100644
index 000..921481c
Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/hang-12.ppt differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93736] Bottom stroke line of a rectangle is half-drawn when using OpenGL
https://bugs.documentfoundation.org/show_bug.cgi?id=93736 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93739] New: Clarify ambiguity in help file for adding a control
https://bugs.documentfoundation.org/show_bug.cgi?id=93739 Bug ID: 93739 Summary: Clarify ambiguity in help file for adding a control Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: da...@cluley.co.uk In the Form Controls help file it says: To add a control to a document On the Form Controls toolbar, click the icon of the control that you want to add. In the document, drag to create the control. Coming from being a long time windows user I was used to dragging a component from the component palate and th en clicking where I wanted it; then resizing it as a separate action. It took me ages and help from others before I realized that the location and sizing of the component was a single drag operation on the Worksheet. A small adjustment to the wording to clarify this would be helpful. Suggestion is: In the document, click to locate the top left corner of the required location and drag to size the component as needed. This then makes more sense of the next sentence in the help file about square components. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sd/qa sd/source
sd/qa/unit/data/ppt/pass/hang-10.ppt |binary
sd/source/filter/ppt/pptin.cxx |6 --
2 files changed, 4 insertions(+), 2 deletions(-)
New commits:
commit 15c185132f8c425722c6cdb380857e70a0ce04fd
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 27 14:28:35 2015 +0100
check status of SeekTo
(cherry picked from commit 932f6de91904f86f38d2914b9ce07b94dfadac0c)
Change-Id: Ia2bb397c3fdd783cab77a6b0dbc31c9e3d19326b
Reviewed-on: https://gerrit.libreoffice.org/18094
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/sd/qa/unit/data/ppt/pass/hang-10.ppt
b/sd/qa/unit/data/ppt/pass/hang-10.ppt
new file mode 100644
index 000..99a81c4
Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/hang-10.ppt differ
diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx
index 7565fd4..0b2c0c8 100644
--- a/sd/source/filter/ppt/pptin.cxx
+++ b/sd/source/filter/ppt/pptin.cxx
@@ -780,7 +780,8 @@ bool ImplSdPPTImport::Import()
if ( nObjCount++ ) //
skipping the first object
{
Rectangle aEmpty;
-
aHd2.SeekToBegOfRecord( rStCtrl );
+if
(!aHd2.SeekToBegOfRecord( rStCtrl ))
+break;
SdrObject* pImpObj =
ImportObj( rStCtrl, (void*)aProcessData, aEmpty, aEmpty );
if ( pImpObj )
{
@@ -789,7 +790,8 @@ bool ImplSdPPTImport::Import()
}
}
}
-aHd2.SeekToEndOfRecord(
rStCtrl );
+if
(!aHd2.SeekToEndOfRecord(rStCtrl))
+break;
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - 2 commits - sd/qa sd/source
sd/qa/unit/data/ppt/pass/hang-4.ppt |binary
sd/qa/unit/data/ppt/pass/hang-7.ppt |binary
sd/source/filter/ppt/propread.cxx | 31 ---
3 files changed, 20 insertions(+), 11 deletions(-)
New commits:
commit 61542931de7abe69a459f3e59513e330ecf47211
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 27 13:00:36 2015 +0100
check for stream status after a read, not after a seek
Change-Id: I984e99c1a1484547aa4d60bf301167f3cbc9f716
(cherry picked from commit eea399ddd52a0de368321963bb828bc15632dd0b)
Reviewed-on: https://gerrit.libreoffice.org/18088
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/sd/qa/unit/data/ppt/pass/hang-4.ppt
b/sd/qa/unit/data/ppt/pass/hang-4.ppt
new file mode 100644
index 000..f5aa247
Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/hang-4.ppt differ
diff --git a/sd/source/filter/ppt/propread.cxx
b/sd/source/filter/ppt/propread.cxx
index 036f1f9..d738eb8 100644
--- a/sd/source/filter/ppt/propread.cxx
+++ b/sd/source/filter/ppt/propread.cxx
@@ -319,7 +319,7 @@ bool Section::GetDictionary( Dictionary rDict )
void Section::Read( SotStorageStream *pStrm )
{
-sal_uInt32 i, nSecOfs, nPropType, nPropSize, nCurrent, nVectorCount,
nTemp, nStrmSize;
+sal_uInt32 i, nSecOfs, nPropSize, nStrmSize;
nSecOfs = pStrm-Tell();
pStrm-Seek( STREAM_SEEK_TO_END );
@@ -329,16 +329,20 @@ void Section::Read( SotStorageStream *pStrm )
mnTextEnc = RTL_TEXTENCODING_MS_1252;
sal_uInt32 nSecSize(0), nPropCount(0);
pStrm-ReadUInt32( nSecSize ).ReadUInt32( nPropCount );
-while (nPropCount-- pStrm-good())
+while (nPropCount--)
{
sal_uInt32 nPropId(0), nPropOfs(0);
-pStrm-ReadUInt32( nPropId ).ReadUInt32( nPropOfs );
-nCurrent = pStrm-Tell();
-pStrm-Seek( nPropOfs + nSecOfs );
+pStrm-ReadUInt32(nPropId).ReadUInt32(nPropOfs);
+if (!pStrm-good())
+break;
+auto nCurrent = pStrm-Tell();
+sal_uInt64 nOffset = nPropOfs + nSecOfs;
+if (nOffset != pStrm-Seek(nOffset))
+break;
if ( nPropId ) // do not read dictionary
{
-
-pStrm-ReadUInt32( nPropType );
+sal_uInt32 nPropType(0), nVectorCount(0);
+pStrm-ReadUInt32(nPropType);
nPropSize = 4;
@@ -360,6 +364,7 @@ void Section::Read( SotStorageStream *pStrm )
pStrm-ReadUInt32( nPropType );
nPropSize += 4;
}
+sal_uInt32 nTemp(0);
switch( nPropType )
{
case VT_UI1 :
@@ -457,11 +462,11 @@ void Section::Read( SotStorageStream *pStrm )
PropItem aPropItem;
if ( GetProperty( 1, aPropItem ) )
{
-sal_uInt16 nCodePage;
aPropItem.ReadUInt32( nPropType );
if ( nPropType == VT_I2 )
{
-aPropItem.ReadUInt16( nCodePage );
+sal_uInt16 nCodePage(0);
+aPropItem.ReadUInt16(nCodePage);
if ( nCodePage == 1200 )
{
@@ -503,7 +508,7 @@ void Section::Read( SotStorageStream *pStrm )
AddProperty( 0x, pBuf, nSize );
delete[] pBuf;
}
-pStrm-Seek( nCurrent );
+pStrm-Seek(nCurrent);
}
pStrm-Seek( nSecOfs + nSecSize );
}
commit a7fd3a06834900c449448f21624f03edc7b27dda
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 27 13:58:48 2015 +0100
check seek for success
Change-Id: I02420ffb3af009d08ce54a0932e2c7a287703a72
(cherry picked from commit 1830b4f2e324090962a993315ce76752d24d4088)
Reviewed-on: https://gerrit.libreoffice.org/18091
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/sd/qa/unit/data/ppt/pass/hang-7.ppt
b/sd/qa/unit/data/ppt/pass/hang-7.ppt
new file mode 100644
index 000..8c05271
Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/hang-7.ppt differ
diff --git a/sd/source/filter/ppt/propread.cxx
b/sd/source/filter/ppt/propread.cxx
index 75a4bcc..036f1f9 100644
--- a/sd/source/filter/ppt/propread.cxx
+++ b/sd/source/filter/ppt/propread.cxx
@@ -427,7 +427,11 @@ void Section::Read( SotStorageStream *pStrm )
if ( nPropSize )
{
if ( ( nVectorCount - i ) 1 )
-pStrm-Seek( nPropOfs + nSecOfs + nPropSize );
+{
+nOffset = nPropOfs + nSecOfs + nPropSize;
+if (nOffset != pStrm-Seek(nOffset))
+break;
+}
}
[Libreoffice-commits] core.git: basic/source
basic/source/sbx/sbxscan.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 9e318c09778f0416143f211c5817536d5f1db3b7
Author: Damjan Jovanovic dam...@apache.org
Date: Wed Aug 26 18:10:02 2015 +
Resolves: #i112383# CLng(H) fails on 64-bits...
rather than returning -1
Found-by: andrew
Patch-by: Damjan Jovanovic
(cherry picked from commit 175afdcb151d9ce1238dc9fec59f2dfc2eb07345)
Change-Id: I996bbfa82b10716318944f390ea53e0a5ae7c89c
diff --git a/basic/source/sbx/sbxscan.cxx b/basic/source/sbx/sbxscan.cxx
index 329d4c2..2d8daf7 100644
--- a/basic/source/sbx/sbxscan.cxx
+++ b/basic/source/sbx/sbxscan.cxx
@@ -236,7 +236,7 @@ SbxError ImpScan( const OUString rWSrc, double nVal,
SbxDataType rType,
p++;
}
OUString aBufStr( aBuf.makeStringAndClear());
-long l = 0;
+sal_Int32 l = 0;
for( const sal_Unicode* q = aBufStr.getStr(); bRes *q; q++ )
{
int i = *q - '0';
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93719] MAILMERGE: Freezes On Step 5: Adjust Layout in OS X Or Does Not Show Preview on Windows 7
https://bugs.documentfoundation.org/show_bug.cgi?id=93719 --- Comment #7 from Alex Thurgood ipla...@yahoo.co.uk --- Wizard also completes correctly in Version: 5.0.0.2 Build ID: a26d58f11b99b6aeddf7f7884effea188cc6e512 Locale: fr-FR (fr.UTF-8) so bibisect range between 5.0.0.2 and 5.0.0.5 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Error while pushing commits for bug 93240
This is the output of ./logerrit submit master ./logerrit submit master Counting objects: 64, done. Delta compression using up to 4 threads. Compressing objects: 100% (10/10), done. Writing objects: 100% (11/11), 1.15 KiB | 0 bytes/s, done. Total 11 (delta 8), reused 0 (delta 0) remote: Resolving deltas: 100% (8/8) remote: Processing changes: refs: 1, done To ssh://logerrit/core ! [remote rejected] HEAD - refs/for/master (change 9724 closed) error: failed to push some refs to 'ssh://logerrit/core' -- Regards, Shreyansh Gandhi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Changes to 'private/mcecchetti/bitmapcrc64'
New branch 'private/mcecchetti/bitmapcrc64' available with the following commits: commit 066d5579fd521d442dac152a43cf49b9880d2546 Author: Marco Cecchetti marco.cecche...@collabora.com Date: Thu Aug 27 22:57:15 2015 +0200 switch to 64-bit checksum: conversion from BitmapChecksum to an octet array Defined BitmapChecksumOctetArray which is an array of bytes whose size is the same of BitmapChecksum. Defined a routine for converting a BitmapChecksum into a BitmapChecksumOctetArray. Change-Id: I70d17ab8b841795ae27c60b418d6b090bff604bb commit 200180aba280d5299bcd2dd36ea520b8e712c686 Author: Marco Cecchetti marco.cecche...@collabora.com Date: Thu Aug 27 17:09:36 2015 +0200 vcl_get_checksum wraps the call to the real checksum function Change-Id: I72916f18966756ecc99e77f1b164e99377eb456e commit 4d4674929b386d773998351f58744eb9ae0c3925 Author: Marco Cecchetti marco.cecche...@collabora.com Date: Thu Aug 27 15:25:11 2015 +0200 Switching to 64-bit checksum: substituted sal_uLong with BitmapChecksum A typedef sal_uLong BitmapChecksum; has been added to include/vcl/checksum.hxx Wherever needed sal_uLong and sal_Int32 has been substituted with BitmapChecksum. A BITMAP_CHECKSUM_BITS constant equal to the amount of bits used by the BitmapChecksum type has been defined and used in `GraphicID::GetIDString` (vstools/source/graphic/grfcache.cxx). Change-Id: I74bd285089e58a8b18c06233d75b87023c7bf31b commit 52405b362675e52f80d07ccbf9b7e09cb6a9d3f9 Author: Marco Cecchetti marco.cecche...@collabora.com Date: Thu Aug 27 12:12:52 2015 +0200 moved chechsum.hxx in include/vcl Change-Id: I70f82f16d5907ce0bbe2d838c4acee226886aab2 commit acf5479a920e75999fb0c58c7a2206ea83575195 Author: Marco Cecchetti marco.cecche...@collabora.com Date: Wed Aug 26 13:50:57 2015 +0200 Added support for computing 64-bit checksum of bitmap in OpenGL Added a C++ and a GLSL implementation of a 64-bit CRC algorithm. Changed hardcoded checksum value in ooxmlimport unit test (testN777345). Change-Id: I16bb985a14866775efda49e21fe033ff64645896 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93529] OpenGL tracker bug ...
https://bugs.documentfoundation.org/show_bug.cgi?id=93529 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Idea] Add files from SVG Test Suite Overview to get-bugzilla-attachments-by-mimetype (crashtest)
On Wed, 2015-08-26 at 16:59 +0200, Xisco Faulí wrote: Hello, Reviewing some issues in bugzilla, I found that some of them make mention of files in the SVG Test Suite Overview(1), so I thought it could be a good a idea to include the files from the different test suite editions into get-bugzilla-attachments-by-mimetype. What I've done is to take the suite archive and just add it manually to the crashtesting archive rather than hack the downloader, which is more for scraping documents out of bugzillas. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93735] should use GL debug messages to help API tracing
https://bugs.documentfoundation.org/show_bug.cgi?id=93735 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED CC||markus.mohrhard@googlemail. ||com Resolution|--- |FIXED --- Comment #1 from Michael Meeks michael.me...@collabora.com --- Review needed for -5-0: https://gerrit.libreoffice.org/18103 tdf#93529 - add glDebugMessageInsert wrappers to help with API tracing. https://gerrit.libreoffice.org/18104 tdf#93529 - use debug messages while rendering to break up the trace. This makes API tracing hugely easier =) and it'd be good to keep the branches in sync too. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93610] cannot flip .PNG properly in Writer and Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=93610 Viruch Hemapanpairo zh...@linux.com changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|WORKSFORME |--- --- Comment #14 from Viruch Hemapanpairo zh...@linux.com --- Still have this problem on Lubuntu 14.04.3 Version: 5.1.0.0.alpha1+ Build ID: b2363e98af7b0281279617e43b8fec5b898b9120 TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2015-08-26_00:58:14 Locale: en-US (en_US.UTF-8) Anyway, since LibO 4.4.3 doesn't affect from this problem. Is there any clue to solve this? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93124] PPT import: slide titles are misplaced
https://bugs.documentfoundation.org/show_bug.cgi?id=93124 Andras Timar tima...@gmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=41 ||245 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93737] New: Cannot insert page numbers using Libre Office 5.0.0
https://bugs.documentfoundation.org/show_bug.cgi?id=93737 Bug ID: 93737 Summary: Cannot insert page numbers using Libre Office 5.0.0 Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: critical Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: paolaxpire...@gmail.com Even though I follow instructions on how to insert Page numbers, these do not appear on the toolbar menu. It is impossible to add page numbers on Text documents. Please rectify. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93738] New: Menu Entry for File Templates not translated
https://bugs.documentfoundation.org/show_bug.cgi?id=93738 Bug ID: 93738 Summary: Menu Entry for File Templates not translated Product: LibreOffice Version: 5.0.0.5 release Hardware: Other OS: All Status: UNCONFIRMED Severity: trivial Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: phax...@gmx.ch -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/source sd/qa
filter/source/msfilter/svdfppt.cxx |4 +++- sd/qa/unit/data/ppt/pass/hang-6.ppt |binary 2 files changed, 3 insertions(+), 1 deletion(-) New commits: commit 8ccabcc0c0c70bdcc6632c6758723f591677371d Author: Caolán McNamara caol...@redhat.com Date: Thu Aug 27 13:49:00 2015 +0100 check SeekToEndOfRecord for success Change-Id: I7413a4e9e491b65122eaadb38ad574161f1aa943 (cherry picked from commit d417ffb7dd93306be7c89526a75acab53dbd8831) Reviewed-on: https://gerrit.libreoffice.org/18090 Reviewed-by: Michael Meeks michael.me...@collabora.com Tested-by: Michael Meeks michael.me...@collabora.com diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx index d3bb6b7..29f0b36 100644 --- a/filter/source/msfilter/svdfppt.cxx +++ b/filter/source/msfilter/svdfppt.cxx @@ -2880,7 +2880,9 @@ void SdrPowerPointImport::ImportPage( SdrPage* pRet, const PptSlidePersistEntry* insertShapeId( nShapeId, pObj ); } } -aShapeHd.SeekToEndOfRecord( rStCtrl ); +bool bSuccess = aShapeHd.SeekToEndOfRecord(rStCtrl); +if (!bSuccess) +break; } } } diff --git a/sd/qa/unit/data/ppt/pass/hang-6.ppt b/sd/qa/unit/data/ppt/pass/hang-6.ppt new file mode 100644 index 000..f5aa247 Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/hang-6.ppt differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sd/qa sd/source
sd/qa/unit/data/ppt/pass/hang-4.ppt |binary
sd/source/filter/ppt/propread.cxx | 25 +++--
2 files changed, 15 insertions(+), 10 deletions(-)
New commits:
commit ca9cbc1aa3458de7ce4893668476aa4433e6b0e0
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 27 13:00:36 2015 +0100
check for stream status after a read, not after a seek
Change-Id: I984e99c1a1484547aa4d60bf301167f3cbc9f716
(cherry picked from commit eea399ddd52a0de368321963bb828bc15632dd0b)
Reviewed-on: https://gerrit.libreoffice.org/18075
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/sd/qa/unit/data/ppt/pass/hang-4.ppt
b/sd/qa/unit/data/ppt/pass/hang-4.ppt
new file mode 100644
index 000..f5aa247
Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/hang-4.ppt differ
diff --git a/sd/source/filter/ppt/propread.cxx
b/sd/source/filter/ppt/propread.cxx
index 1e71044..8f376fd 100644
--- a/sd/source/filter/ppt/propread.cxx
+++ b/sd/source/filter/ppt/propread.cxx
@@ -319,7 +319,7 @@ bool Section::GetDictionary( Dictionary rDict )
void Section::Read( SvStorageStream *pStrm )
{
-sal_uInt32 i, nSecOfs, nPropType, nPropSize, nCurrent, nVectorCount,
nTemp, nStrmSize;
+sal_uInt32 i, nSecOfs, nPropSize, nStrmSize;
nSecOfs = pStrm-Tell();
pStrm-Seek( STREAM_SEEK_TO_END );
@@ -329,16 +329,20 @@ void Section::Read( SvStorageStream *pStrm )
mnTextEnc = RTL_TEXTENCODING_MS_1252;
sal_uInt32 nSecSize(0), nPropCount(0);
pStrm-ReadUInt32( nSecSize ).ReadUInt32( nPropCount );
-while (nPropCount-- pStrm-good())
+while (nPropCount--)
{
sal_uInt32 nPropId(0), nPropOfs(0);
-pStrm-ReadUInt32( nPropId ).ReadUInt32( nPropOfs );
-nCurrent = pStrm-Tell();
-pStrm-Seek( nPropOfs + nSecOfs );
+pStrm-ReadUInt32(nPropId).ReadUInt32(nPropOfs);
+if (!pStrm-good())
+break;
+auto nCurrent = pStrm-Tell();
+sal_uInt64 nOffset = nPropOfs + nSecOfs;
+if (nOffset != pStrm-Seek(nOffset))
+break;
if ( nPropId ) // do not read dictionary
{
-
-pStrm-ReadUInt32( nPropType );
+sal_uInt32 nPropType(0), nVectorCount(0);
+pStrm-ReadUInt32(nPropType);
nPropSize = 4;
@@ -360,6 +364,7 @@ void Section::Read( SvStorageStream *pStrm )
pStrm-ReadUInt32( nPropType );
nPropSize += 4;
}
+sal_uInt32 nTemp(0);
switch( nPropType )
{
case VT_UI1 :
@@ -457,11 +462,11 @@ void Section::Read( SvStorageStream *pStrm )
PropItem aPropItem;
if ( GetProperty( 1, aPropItem ) )
{
-sal_uInt16 nCodePage;
aPropItem.ReadUInt32( nPropType );
if ( nPropType == VT_I2 )
{
-aPropItem.ReadUInt16( nCodePage );
+sal_uInt16 nCodePage(0);
+aPropItem.ReadUInt16(nCodePage);
if ( nCodePage == 1200 )
{
@@ -503,7 +508,7 @@ void Section::Read( SvStorageStream *pStrm )
AddProperty( 0x, pBuf, nSize );
delete[] pBuf;
}
-pStrm-Seek( nCurrent );
+pStrm-Seek(nCurrent);
}
pStrm-Seek( nSecOfs + nSecSize );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/vba-export' - oox/source
oox/source/ole/vbaexport.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit cc6eacd2bca5ab3c3e49fbac80ae80e0a00f3c82 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Aug 28 13:34:43 2015 +0200 also dump the module source code diff --git a/oox/source/ole/vbaexport.cxx b/oox/source/ole/vbaexport.cxx index d9d4871..06dc8aa 100644 --- a/oox/source/ole/vbaexport.cxx +++ b/oox/source/ole/vbaexport.cxx @@ -641,6 +641,11 @@ void VbaExport::exportVBA(SotStorage* pRootStorage) SAL_DEBUG(aElementNames[i]); css::script::ModuleInfo aModuleInfo = xModuleInfo-getModuleInfo(aElementNames[i]); SAL_DEBUG(aModuleInfo.ModuleType); + +css::uno::Any aCode = xNameContainer-getByName(aElementNames[i]); +OUString aSourceCode; +aCode = aSourceCode; +SAL_DEBUG(aSourceCode); } pVBAProjectStream-Commit(); pDirStream-Commit(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93740] New: Special object in unit test media_embedding makes that LO does not respond in presentation mode
https://bugs.documentfoundation.org/show_bug.cgi?id=93740 Bug ID: 93740 Summary: Special object in unit test media_embedding makes that LO does not respond in presentation mode Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 118243 -- https://bugs.documentfoundation.org/attachment.cgi?id=118243action=edit File which makes LO hang in presentation mode Open attached document. It is derived from file media_embedding.odp from sd/qa/unit/da. I removed the unused presentation objects and the sound object. Start presentation. Click on background. Expected behavior: Because the presentation has only this one slide Click to exit presentation should appear. Observed behavior: LibreOffice does not respond. Only when you call task manager, it will leave the abnormal state. I use a self-built debug build on 32-bit Windows 7. Version: 5.1.0.0.alpha1+ Build ID: d3de490437df4c9093f32e97fc185066d64c0f46 Locale: de-DE (de_DE) The options Use OpenGL for all rendering and Allow use of OpenCL are off. Find informations about my graphic card in attachments https://bugs.documentfoundation.org/attachment.cgi?id=118112 and https://bugs.documentfoundation.org/attachment.cgi?id=118113 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91488] [META] RenderContext related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=91488 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added Depends on||92145 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93729] New: Styles and Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=93729 Bug ID: 93729 Summary: Styles and Formatting Product: LibreOffice Version: 4.4.5.2 release Hardware: Other OS: Mac OS X (All) Status: UNCONFIRMED Severity: blocker Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: appsbugzi...@gmail.com No option comes up when I select this option. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93731] New: Chart export legend contains hidden lines
https://bugs.documentfoundation.org/show_bug.cgi?id=93731 Bug ID: 93731 Summary: Chart export legend contains hidden lines Product: LibreOffice Version: 4.4.4.3 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: m...@heikowoehrle.de if lines are hidden in the data selection of a diagramm, they don't show up in diagramm or legend, but if the diagramm is copypasted into eg writer the hidden lines appear. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93728] INSTALLATION: file extensions default to opening Archive Manager
https://bugs.documentfoundation.org/show_bug.cgi?id=93728 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTOURBUG --- Comment #1 from Adolfo Jayme f...@libreoffice.org --- That would be a bug in shared-mime-info, not ours. The point of distro-built packages is to avoid issues like this one. You should stick to Mint packages, and use a Ubuntu PPA to get updated versions. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93734] FULLSCREEN Ubuntu unity
https://bugs.documentfoundation.org/show_bug.cgi?id=93734 --- Comment #1 from tichun...@gmail.com --- Fullscreen works good after alt-tab to another program and alt-tab back to Calc. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93529] OpenGL tracker bug ...
https://bugs.documentfoundation.org/show_bug.cgi?id=93529 --- Comment #3 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Meeks committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=43cb8fe05bff630331c6137dc6c2b3f2d9df9e64 tdf#93529 - use debug messages while rendering to break up the trace. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sd/qa sd/source
sd/qa/unit/data/ppt/pass/hang-5.ppt |binary
sd/source/filter/ppt/pptin.cxx |2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 5015596b795931eeb328666ec2c99dd372bf6c34
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 27 13:35:37 2015 +0100
avoid hang in certain ppts
Change-Id: Iedba71b72fc815b274ca5e0da0903a558947cb06
(cherry picked from commit 90dc4e38928fffc3ed5fcbed40109712eb97e203)
Reviewed-on: https://gerrit.libreoffice.org/18076
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/sd/qa/unit/data/ppt/pass/hang-5.ppt
b/sd/qa/unit/data/ppt/pass/hang-5.ppt
new file mode 100644
index 000..cfaa8f4
Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/hang-5.ppt differ
diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx
index 57f1c23..b22372a 100644
--- a/sd/source/filter/ppt/pptin.cxx
+++ b/sd/source/filter/ppt/pptin.cxx
@@ -2541,7 +2541,7 @@ SdrObject* ImplSdPPTImport::ProcessObj( SvStream rSt,
DffObjData rObjData, voi
DffRecordHeader rHdClientData = *maShapeRecords.Current();
while( true )
{
-sal_uInt32 nClientDataLen = rHdClientData.GetRecEndFilePos();
+sal_uInt32 nClientDataLen = SanitizeEndPos(rSt,
rHdClientData.GetRecEndFilePos());
DffRecordHeader aHd;
do
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93736] Bottom stroke line of a rectangle is half-drawn when using OpenGL
https://bugs.documentfoundation.org/show_bug.cgi?id=93736 --- Comment #1 from Tomaz Vajngerl qui...@gmail.com --- Related: when drawing a circle or ellipse the stroke hairline is drawn only on four coordinates - forming a square. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - 2 commits - include/vcl sd/qa sd/source vcl/source
include/vcl/opengl/OpenGLHelper.hxx | 23 -
sd/qa/unit/data/ppt/pass/hang-18.ppt |binary
sd/source/filter/ppt/propread.cxx| 25 +--
vcl/source/opengl/OpenGLContext.cxx |2 +
vcl/source/opengl/OpenGLHelper.cxx | 38 +++
5 files changed, 81 insertions(+), 7 deletions(-)
New commits:
commit 7d50c8250c7fb916137c9e687ee0ceed7d96758d
Author: Caolán McNamara caol...@redhat.com
Date: Fri Aug 28 09:15:04 2015 +0100
clip strings to max available size
Change-Id: Icc1378c9c27b9b6d229bcffc6a63017f82be70d4
(cherry picked from commit 580d3837b26f09ed02fe3583de40fa045a3fde0f)
Reviewed-on: https://gerrit.libreoffice.org/18100
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/sd/qa/unit/data/ppt/pass/hang-18.ppt
b/sd/qa/unit/data/ppt/pass/hang-18.ppt
new file mode 100644
index 000..3b3e9f7
Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/hang-18.ppt differ
diff --git a/sd/source/filter/ppt/propread.cxx
b/sd/source/filter/ppt/propread.cxx
index 374ecbb..75a4bcc 100644
--- a/sd/source/filter/ppt/propread.cxx
+++ b/sd/source/filter/ppt/propread.cxx
@@ -73,7 +73,7 @@ static sal_Int32 lcl_getMaxSafeStrLen(sal_uInt32 nSize)
bool PropItem::Read( OUString rString, sal_uInt32 nStringType, bool bAlign )
{
-sal_uInt32 i, nItemSize, nType, nItemPos;
+sal_uInt32 nType, nItemPos;
boolbRetValue = false;
nItemPos = Tell();
@@ -86,8 +86,8 @@ bool PropItem::Read( OUString rString, sal_uInt32
nStringType, bool bAlign )
else
nType = nStringType VT_TYPEMASK;
-nItemSize = 0; // Initialize in case stream fails.
-ReadUInt32( nItemSize );
+sal_uInt32 nItemSize(0); // Initialize in case stream fails.
+ReadUInt32(nItemSize);
switch( nType )
{
@@ -95,6 +95,12 @@ bool PropItem::Read( OUString rString, sal_uInt32
nStringType, bool bAlign )
{
if ( nItemSize )
{
+auto nMaxSizePossible = remainingSize();
+if (nItemSize nMaxSizePossible)
+{
+SAL_WARN(sd.filter, String of Len nItemSize
claimed, only nMaxSizePossible possible);
+nItemSize = nMaxSizePossible;
+}
try
{
sal_Char* pString = new sal_Char[ nItemSize ];
@@ -104,7 +110,7 @@ bool PropItem::Read( OUString rString, sal_uInt32
nStringType, bool bAlign )
if ( nItemSize 1 )
{
sal_Unicode* pWString =
reinterpret_castsal_Unicode*(pString);
-for ( i = 0; i nItemSize; i++ )
+for (sal_uInt32 i = 0; i nItemSize; ++i)
ReadUInt16( pWString[ i ] );
rString = OUString(pWString,
lcl_getMaxSafeStrLen(nItemSize));
}
@@ -140,12 +146,19 @@ bool PropItem::Read( OUString rString, sal_uInt32
nStringType, bool bAlign )
{
if ( nItemSize )
{
+auto nMaxSizePossible = remainingSize() / sizeof(sal_Unicode);
+if (nItemSize nMaxSizePossible)
+{
+SAL_WARN(sd.filter, String of Len nItemSize
claimed, only nMaxSizePossible possible);
+nItemSize = nMaxSizePossible;
+}
+
try
{
sal_Unicode* pString = new sal_Unicode[ nItemSize ];
-for ( i = 0; i nItemSize; i++ )
+for (sal_uInt32 i = 0; i nItemSize; ++i)
ReadUInt16( pString[ i ] );
-if ( pString[ i - 1 ] == 0 )
+if ( pString[ nItemSize - 1 ] == 0 )
{
if ( (sal_uInt16)nItemSize 1 )
rString = OUString(pString,
lcl_getMaxSafeStrLen(nItemSize));
commit c04099922c2fb177dd310b7aefe5c0b7d3a40fbf
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Aug 28 11:28:13 2015 +0100
tdf#93529 - add glDebugMessageInsert wrappers to help with API tracing.
Change-Id: Icf75e0e477be1b2bbbe5095aee33e681d212be0b
Reviewed-on: https://gerrit.libreoffice.org/18103
Reviewed-by: Tor Lillqvist t...@collabora.com
Tested-by: Tor Lillqvist t...@collabora.com
diff --git a/include/vcl/opengl/OpenGLHelper.hxx
b/include/vcl/opengl/OpenGLHelper.hxx
index 95c23c8..f2fb214 100644
--- a/include/vcl/opengl/OpenGLHelper.hxx
+++ b/include/vcl/opengl/OpenGLHelper.hxx
@@ -11,6 +11,7 @@
#define INCLUDED_VCL_OPENGL_OPENGLHELPER_HXX
#include GL/glew.h
+#include sal/log.hxx
#include vcl/dllapi.h
#include vcl/bitmapex.hxx
@@ -22,6 +23,18 @@
# include postx.h
#endif
+/// Helper to do a SAL_INFO as well as
[Libreoffice-bugs] [Bug 93529] OpenGL tracker bug ...
https://bugs.documentfoundation.org/show_bug.cgi?id=93529 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard| target:5.1.0 | target:5.1.0 target:5.0.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93529] OpenGL tracker bug ...
https://bugs.documentfoundation.org/show_bug.cgi?id=93529 --- Comment #5 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Meeks committed a patch related to this issue. It has been pushed to libreoffice-5-0: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7614b918f441442cac7e76d1707e05a1fb72951h=libreoffice-5-0 tdf#93529 - use debug messages while rendering to break up the trace. It will be available in 5.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93741] Flickering Text During Autocomplete
https://bugs.documentfoundation.org/show_bug.cgi?id=93741 dmdcare...@care2.com changed: What|Removed |Added Priority|medium |high Hardware|Other |x86-64 (AMD64) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93713] Unable to Unprotect Protected cells in Writer Tables from 'Table' menu
https://bugs.documentfoundation.org/show_bug.cgi?id=93713 --- Comment #9 from Charles tansta...@libertytrek.org --- @Maxim Thank you! Now at least I won't have to revert the 10 or so people I've already upgraded... But I just noticed another cosmetic bug... can you confirm before I go open another bug report? 1. Add a new Writer Table with 5+ columns... 2. Click inside a cell 3. Protect the cell Note that the cursor jumps to an adjacent cell. Unprotecting a cell does not cause the cursor to jump to another cell. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93741] New: Flickering Text During Autocomplete
https://bugs.documentfoundation.org/show_bug.cgi?id=93741 Bug ID: 93741 Summary: Flickering Text During Autocomplete Product: LibreOffice Version: 5.0.1.2 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dmdcare...@care2.com Windows 10, LibreOffice 5.0.1.2 When autocomplete is used to complete an entry which already exists in the column, the text flickers. This happens even in very short lists. For example, type in separate rows: Potato Corn Bread Then in the next blank row type 'C'. Another example, type 'This is is a typing test' in a row and then type 'This is' is the next blank row. This really shows how bad the flickering is. Whilst the flickering in itself does not seem much of an issue, it is an important issue to people like myself who have a sensitivity to flickering. The flickering causes me a headache even after a short time. The flickering did not exist in LibreOffice 5.0.0.5. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93614] Detect hanging OpenGL drivers disable GL ...
https://bugs.documentfoundation.org/show_bug.cgi?id=93614 --- Comment #13 from Regina Henschel rb.hensc...@t-online.de --- I have written a new bug report https://bugs.documentfoundation.org/show_bug.cgi?id=93740 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93729] Styles and Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=93729 Samuel Mehrbrodt s.mehrbr...@gmail.com changed: What|Removed |Added CC||s.mehrbr...@gmail.com --- Comment #1 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- Try disabling and enabling the sidebar (view menu). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93729] Styles and Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=93729 Samuel Mehrbrodt s.mehrbr...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- *** This bug has been marked as a duplicate of bug 83546 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 83546] SIDEBAR: content panels in tray don't open with accelerators when sidebar is enabled but fully hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=83546 Samuel Mehrbrodt s.mehrbr...@gmail.com changed: What|Removed |Added CC||appsbugzi...@gmail.com --- Comment #14 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- *** Bug 93729 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 83546] SIDEBAR: content panels in tray don't open with accelerators when sidebar is enabled but fully hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=83546 Samuel Mehrbrodt s.mehrbr...@gmail.com changed: What|Removed |Added CC||appsbugzi...@gmail.com --- Comment #14 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- *** Bug 93729 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93719] MAILMERGE: Freezes On Step 5: Adjust Layout in OS X Or Does Not Show Preview on Windows 7
https://bugs.documentfoundation.org/show_bug.cgi?id=93719 --- Comment #6 from Alex Thurgood ipla...@yahoo.co.uk --- Wizard does indeed go to completion on Version: 4.4.5.2 Build ID: a22f674fd25a3b6f45bdebf25400ed2adff0ff99 Locale: fr.UTF-8 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/source
filter/source/graphicfilter/itiff/lzwdecom.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 5e3b4e302afd36b382a1d177c434fcada21ed2d4
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 27 14:40:37 2015 +0100
crashtesting: tiff loop detection too slow
moz323894-1.tiff and moz456356-1.tiff take too long to load
Change-Id: Iaafa064fd05e4a4152004e7ceb6256af68aeef01
(cherry picked from commit 7e373e92fc02393732422d05264dd5115076183f)
Reviewed-on: https://gerrit.libreoffice.org/18082
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/filter/source/graphicfilter/itiff/lzwdecom.cxx
b/filter/source/graphicfilter/itiff/lzwdecom.cxx
index 5fb7514..dc437e2 100644
--- a/filter/source/graphicfilter/itiff/lzwdecom.cxx
+++ b/filter/source/graphicfilter/itiff/lzwdecom.cxx
@@ -20,7 +20,7 @@
#include lzwdecom.hxx
#include algorithm
-#include vector
+#include set
#define MAX_TABLE_SIZE 4096
@@ -163,16 +163,16 @@ void LZWDecompressor::AddToTable(sal_uInt16 nPrevCode,
sal_uInt16 nCodeFirstData
return;
}
-std::vectorsal_uInt16 aSeenIndexes;
+unsigned char aSeenIndexes[MAX_TABLE_SIZE] = {0};
while (pTable[nCodeFirstData].nDataCount1)
{
-if (std::find(aSeenIndexes.begin(), aSeenIndexes.end(),
nCodeFirstData) != aSeenIndexes.end())
+if (aSeenIndexes[nCodeFirstData])
{
SAL_WARN(filter.tiff, Loop in chain);
bEOIFound = true;
return;
}
-aSeenIndexes.push_back(nCodeFirstData);
+aSeenIndexes[nCodeFirstData] = 1;
nCodeFirstData=pTable[nCodeFirstData].nPrevCode;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/source
filter/source/graphicfilter/itiff/lzwdecom.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit a6ea269296089b43dd5810f418e8e1239f30a565
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 27 14:40:37 2015 +0100
crashtesting: tiff loop detection too slow
moz323894-1.tiff and moz456356-1.tiff take too long to load
Change-Id: Iaafa064fd05e4a4152004e7ceb6256af68aeef01
(cherry picked from commit 7e373e92fc02393732422d05264dd5115076183f)
Reviewed-on: https://gerrit.libreoffice.org/18095
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/filter/source/graphicfilter/itiff/lzwdecom.cxx
b/filter/source/graphicfilter/itiff/lzwdecom.cxx
index 5fb7514..dc437e2 100644
--- a/filter/source/graphicfilter/itiff/lzwdecom.cxx
+++ b/filter/source/graphicfilter/itiff/lzwdecom.cxx
@@ -20,7 +20,7 @@
#include lzwdecom.hxx
#include algorithm
-#include vector
+#include set
#define MAX_TABLE_SIZE 4096
@@ -163,16 +163,16 @@ void LZWDecompressor::AddToTable(sal_uInt16 nPrevCode,
sal_uInt16 nCodeFirstData
return;
}
-std::vectorsal_uInt16 aSeenIndexes;
+unsigned char aSeenIndexes[MAX_TABLE_SIZE] = {0};
while (pTable[nCodeFirstData].nDataCount1)
{
-if (std::find(aSeenIndexes.begin(), aSeenIndexes.end(),
nCodeFirstData) != aSeenIndexes.end())
+if (aSeenIndexes[nCodeFirstData])
{
SAL_WARN(filter.tiff, Loop in chain);
bEOIFound = true;
return;
}
-aSeenIndexes.push_back(nCodeFirstData);
+aSeenIndexes[nCodeFirstData] = 1;
nCodeFirstData=pTable[nCodeFirstData].nPrevCode;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/htmlexport/data/tdf90905.odt |binary
sw/qa/extras/htmlexport/htmlexport.cxx|3 ++-
sw/source/filter/html/wrthtml.cxx |3 ++-
3 files changed, 4 insertions(+), 2 deletions(-)
New commits:
commit fd3468024e1ac199f4a2f4108321ef8100d58414
Author: Vasily Melenchuk vasily.melenc...@cib.de
Date: Tue Aug 25 17:45:11 2015 +0300
tdf#93449 Internal hyperlinks are not exported corectly in HTML
InetURLObject class does not work correctly with internal document
links, containing not full url, but just a fragment. This case added
as an exception for HTML link export.
Change-Id: I44496a1cf186836d4194fc65ce7bf9aeb2f79b65
Reviewed-on: https://gerrit.libreoffice.org/17993
Reviewed-by: Thorsten Behrens thorsten.behr...@cib.de
Tested-by: Thorsten Behrens thorsten.behr...@cib.de
diff --git a/sw/qa/extras/htmlexport/data/tdf90905.odt
b/sw/qa/extras/htmlexport/data/tdf90905.odt
index cab8a04..19a51bd 100644
Binary files a/sw/qa/extras/htmlexport/data/tdf90905.odt and
b/sw/qa/extras/htmlexport/data/tdf90905.odt differ
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx
b/sw/qa/extras/htmlexport/htmlexport.cxx
index 77db88b..2ce1040 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -250,7 +250,8 @@ DECLARE_HTMLEXPORT_TEST(testExportInternalUrl,
tdf90905.odt)
CPPUNIT_ASSERT(pDoc);
// Internal url should be valid
-assertXPath(pDoc, /html/body/p/a, href, #0.0.1.Text|outline);
+assertXPath(pDoc, /html/body/p[1]/a, href, #0.0.1.Text|outline);
+assertXPath(pDoc, /html/body/p[2]/a, href, #bookmark);
}
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/filter/html/wrthtml.cxx
b/sw/source/filter/html/wrthtml.cxx
index 1502441..4e5d57b 100644
--- a/sw/source/filter/html/wrthtml.cxx
+++ b/sw/source/filter/html/wrthtml.cxx
@@ -1198,8 +1198,9 @@ OUString SwHTMLWriter::convertHyperlinkHRefValue(const
OUString rURL)
}
}
}
-else
+else if (!sURL.isEmpty() sURL[0] != '#')
{
+// Link is not started from #, so looks like external link. Encode
this URL.
INetURLObject aURL(sURL);
sURL = aURL.GetMainURL(INetURLObject::NO_DECODE);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93732] Startcenter window does not have a title
https://bugs.documentfoundation.org/show_bug.cgi?id=93732 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Version|5.0.1.2 release |5.0.0.5 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93732] Startcenter window does not have a title
https://bugs.documentfoundation.org/show_bug.cgi?id=93732 --- Comment #2 from Alex Thurgood ipla...@yahoo.co.uk --- The problem goes back further, but no time to test at the moment. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93736] Bottom stroke line of a rectangle is half-drawn when using OpenGL
https://bugs.documentfoundation.org/show_bug.cgi?id=93736 Tomaz Vajngerl qui...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Blocks||93529 Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93529] OpenGL tracker bug ...
https://bugs.documentfoundation.org/show_bug.cgi?id=93529 Tomaz Vajngerl qui...@gmail.com changed: What|Removed |Added Depends on||93736 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93736] New: Bottom stroke line of a rectangle is half-drawn when using OpenGL
https://bugs.documentfoundation.org/show_bug.cgi?id=93736 Bug ID: 93736 Summary: Bottom stroke line of a rectangle is half-drawn when using OpenGL Product: LibreOffice Version: 5.0.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: qui...@gmail.com When OpenGL is enabled and a rectangle is shown in the document, the bottom stroke line is drawn only until half of the rectangle. Appears only when drawing hairlines - size of the line is set to 0.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - 2 commits - filter/source sd/qa
filter/source/msfilter/msdffimp.cxx |6 --
filter/source/msfilter/svdfppt.cxx | 15 ++-
sd/qa/unit/data/ppt/pass/hang-13.ppt |binary
sd/qa/unit/data/ppt/pass/hang-14.ppt |binary
4 files changed, 14 insertions(+), 7 deletions(-)
New commits:
commit 1bfbdeb07c0d4059f08bf1c295a465482e9ef3a5
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 27 20:16:58 2015 +0100
check seek
Change-Id: I358758999bb918e73cdee2224e575e72c2131453
(cherry picked from commit 0c713e45f9831073e34777f50abf9b5801f08ed9)
Reviewed-on: https://gerrit.libreoffice.org/18085
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/filter/source/msfilter/msdffimp.cxx
b/filter/source/msfilter/msdffimp.cxx
index 4748cb9..47a89e0 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -399,7 +399,8 @@ SvStream ReadSvxMSDffSolverContainer( SvStream rIn,
SvxMSDffSolverContainer r
if ( aHd.nRecType == DFF_msofbtSolverContainer )
{
DffRecordHeader aCRule;
-while ( ( rIn.GetError() == 0 ) ( rIn.Tell()
aHd.GetRecEndFilePos() ) )
+auto nEndPos = DffPropSet::SanitizeEndPos(rIn, aHd.GetRecEndFilePos());
+while ( ( rIn.GetError() == 0 ) ( rIn.Tell() nEndPos ) )
{
ReadDffRecordHeader( rIn, aCRule );
if ( aCRule.nRecType == DFF_msofbtConnectorRule )
@@ -408,7 +409,8 @@ SvStream ReadSvxMSDffSolverContainer( SvStream rIn,
SvxMSDffSolverContainer r
rIn *pRule;
rContainer.aCList.push_back( pRule );
}
-aCRule.SeekToEndOfRecord( rIn );
+if (!aCRule.SeekToEndOfRecord(rIn))
+break;
}
}
return rIn;
diff --git a/sd/qa/unit/data/ppt/pass/hang-13.ppt
b/sd/qa/unit/data/ppt/pass/hang-13.ppt
new file mode 100644
index 000..04fbdc5
Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/hang-13.ppt differ
commit a9a09a49a86776575f78289a9023ed024dffdcf5
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 27 20:32:28 2015 +0100
check seeks and offsets
Change-Id: I2b6ded138b9101415fc49e93e1ec3ebcd3a9d2ae
(cherry picked from commit 5ed690a3e8a575784ca25048e0229ebc52e6fccd)
Reviewed-on: https://gerrit.libreoffice.org/18086
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/filter/source/msfilter/svdfppt.cxx
b/filter/source/msfilter/svdfppt.cxx
index b6693086..8c41446 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -6507,10 +6507,12 @@ PPTTextObj::PPTTextObj( SvStream rIn,
SdrPowerPointImport rSdrPowerPointImport
bStatus = false;
else
{
-rIn.Seek( pE-nSlidePersistStartOffset );
+auto nOffset(pE-nSlidePersistStartOffset);
+bStatus = (nOffset == rIn.Seek(nOffset));
// now we got the right page and are searching for
the right
// TextHeaderAtom
-while ( rIn.Tell() pE-nSlidePersistEndOffset )
+auto nEndRecPos = DffPropSet::SanitizeEndPos(rIn,
pE-nSlidePersistEndOffset);
+while (bStatus rIn.Tell() nEndRecPos)
{
ReadDffRecordHeader( rIn, aClientTextBoxHd );
if ( aClientTextBoxHd.nRecType ==
PPT_PST_TextHeaderAtom )
@@ -6521,7 +6523,8 @@ PPTTextObj::PPTTextObj( SvStream rIn,
SdrPowerPointImport rSdrPowerPointImport
break;
}
}
-aClientTextBoxHd.SeekToEndOfRecord( rIn );
+if (!aClientTextBoxHd.SeekToEndOfRecord(rIn))
+break;
}
if ( rIn.Tell() pE-nSlidePersistEndOffset )
bStatus = false;
@@ -6534,12 +6537,14 @@ PPTTextObj::PPTTextObj( SvStream rIn,
SdrPowerPointImport rSdrPowerPointImport
// we have to calculate the correct record len
DffRecordHeader aTmpHd;
-while ( rIn.Tell()
pE-nSlidePersistEndOffset )
+nEndRecPos = DffPropSet::SanitizeEndPos(rIn,
pE-nSlidePersistEndOffset);
+while (rIn.Tell() nEndRecPos)
{
ReadDffRecordHeader( rIn, aTmpHd );
if ( ( aTmpHd.nRecType ==
PPT_PST_SlidePersistAtom ) || (
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - 2 commits - editeng/source include/editeng include/tools tools/source vcl/qa vcl/source
editeng/source/editeng/editattr.cxx |6 --
editeng/source/items/textitem.cxx | 38 +-
include/editeng/colritem.hxx | 10 ++--
include/tools/color.hxx |4 -
tools/source/generic/color.cxx|2
vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-3.wmf |binary
vcl/source/filter/wmf/enhwmf.cxx | 19 ++---
7 files changed, 34 insertions(+), 45 deletions(-)
New commits:
commit 27f6ddefd4b845f3d51221681c864490fa9b580b
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 27 12:21:37 2015 +0100
don't write SvxBackgroundColorItem via inherited SvxColorItem::Store
SvxBackgroundColorItem inherits from SvxColorItem and for backwards
compatibility with the StarOffice 5 binary file format (yes, really)
writes/reads only rgb and not the transparency value, so copying and pasting
text from a sidebar comment in writer to itself or another one results in a
black character background as the default COL_AUTO turns into black
(cherry picked from commit 3bc69b1d0d8620afd89a993b5f6bc46a2ff5267f)
Change-Id: I18b5105dd8e060b9e49dda6026e26d3a0f00d8f5
Reviewed-on: https://gerrit.libreoffice.org/18074
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/editeng/source/editeng/editattr.cxx
b/editeng/source/editeng/editattr.cxx
index 85676ab..66e664f 100644
--- a/editeng/source/editeng/editattr.cxx
+++ b/editeng/source/editeng/editattr.cxx
@@ -221,7 +221,6 @@ void EditCharAttribColor::SetFont( SvxFont rFont,
OutputDevice* )
{
Color aColor = static_castconst SvxColorItem*(GetItem())-GetValue();
rFont.SetColor( aColor);
-//fprintf(stderr, Called SetFont with Color %d\n, aColor.GetColor());
}
// class EditCharAttribBackgroundColor
@@ -238,14 +237,11 @@
EditCharAttribBackgroundColor::EditCharAttribBackgroundColor(
void EditCharAttribBackgroundColor::SetFont( SvxFont rFont, OutputDevice* )
{
Color aColor = static_castconst
SvxBackgroundColorItem*(GetItem())-GetValue();
-rFont.SetFillColor( aColor);
rFont.SetTransparent(false);
-
+rFont.SetFillColor(aColor);
}
-
// class EditCharAttribLanguage
-
EditCharAttribLanguage::EditCharAttribLanguage( const SvxLanguageItem rAttr,
sal_uInt16 _nStart, sal_uInt16 _nEnd )
: EditCharAttrib( rAttr, _nStart, _nEnd )
{
diff --git a/editeng/source/items/textitem.cxx
b/editeng/source/items/textitem.cxx
index b55d9ad..587e253 100644
--- a/editeng/source/items/textitem.cxx
+++ b/editeng/source/items/textitem.cxx
@@ -1809,9 +1809,12 @@ SvxBackgroundColorItem::SvxBackgroundColorItem( const
Color rCol,
{
}
-SvxBackgroundColorItem:: SvxBackgroundColorItem( SvStream rStrm, const
sal_uInt16 Id ) :
-SvxColorItem( rStrm, Id )
+SvxBackgroundColorItem::SvxBackgroundColorItem(SvStream rStrm, const
sal_uInt16 nId)
+: SvxColorItem(nId)
{
+Color aColor;
+aColor.Read(rStrm);
+SetValue(aColor);
}
SvxBackgroundColorItem::SvxBackgroundColorItem( const SvxBackgroundColorItem
rCopy ) :
@@ -1821,9 +1824,14 @@ SvxBackgroundColorItem::SvxBackgroundColorItem( const
SvxBackgroundColorItem rC
SfxPoolItem* SvxBackgroundColorItem::Clone( SfxItemPool * ) const
{
-return new SvxBackgroundColorItem( *this );
+return new SvxBackgroundColorItem(*this);
}
+SvStream SvxBackgroundColorItem::Store(SvStream rStrm, sal_uInt16) const
+{
+GetValue().Write(rStrm);
+return rStrm;
+}
SfxPoolItem* SvxBackgroundColorItem::Create(SvStream rStrm, sal_uInt16 ) const
{
@@ -1877,23 +1885,18 @@ bool SvxBackgroundColorItem::PutValue( const uno::Any
rVal, sal_uInt8 nMemberId
}
// class SvxColorItem
-
SvxColorItem::SvxColorItem( const sal_uInt16 nId ) :
SfxPoolItem( nId ),
mColor( COL_BLACK )
{
}
-
-
SvxColorItem::SvxColorItem( const Color rCol, const sal_uInt16 nId ) :
SfxPoolItem( nId ),
mColor( rCol )
{
}
-
-
SvxColorItem::SvxColorItem( SvStream rStrm, const sal_uInt16 nId ) :
SfxPoolItem( nId )
{
@@ -1902,21 +1905,16 @@ SvxColorItem::SvxColorItem( SvStream rStrm, const
sal_uInt16 nId ) :
mColor = aColor;
}
-
-
SvxColorItem::SvxColorItem( const SvxColorItem rCopy ) :
SfxPoolItem( rCopy ),
mColor( rCopy.mColor )
{
}
-
-
SvxColorItem::~SvxColorItem()
{
}
-
sal_uInt16 SvxColorItem::GetVersion( sal_uInt16 nFFVer ) const
{
DBG_ASSERT( SOFFICE_FILEFORMAT_31==nFFVer ||
@@ -1926,8 +1924,6 @@ sal_uInt16 SvxColorItem::GetVersion( sal_uInt16 nFFVer )
const
return SOFFICE_FILEFORMAT_50 = nFFVer ? VERSION_USEAUTOCOLOR : 0;
}
-
-
bool SvxColorItem::operator==( const SfxPoolItem rAttr ) const
{
DBG_ASSERT( SfxPoolItem::operator==(rAttr), unequal types );
@@ -1935,16 +1931,12 @@ bool SvxColorItem::operator==(
[Libreoffice-bugs] [Bug 93317] Document has been modified Dialog does not have the focus on GTK3.
https://bugs.documentfoundation.org/show_bug.cgi?id=93317 chry...@web.de chry...@web.de changed: What|Removed |Added Version|5.0.0.5 release |5.0.1.2 release --- Comment #1 from chry...@web.de chry...@web.de --- Here some additional information: this seems only to happen if i try to close lo with alt + F4. if i Press the X in the window bar, the Document has been modified dialog has the focus. if i press alt + F4 the Document has been modified does not have the focus and you are not able to focus it with the keyboard. I can also see this in the most current 5.0.1 version. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93704] App crash when load any .ods files
https://bugs.documentfoundation.org/show_bug.cgi?id=93704 steve -_- st...@openmailbox.org changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93704] App crash when load any .ods files
https://bugs.documentfoundation.org/show_bug.cgi?id=93704 --- Comment #3 from steve -_- st...@openmailbox.org --- Ok so this is not about LO desktop but LO Android viewer. That changes a lot. Could you attach the log to this bug and re-open if you are still seeing the problem? (set it to UNCONFIRMED please) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93704] App crash when load any .ods files
https://bugs.documentfoundation.org/show_bug.cgi?id=93704 steve -_- st...@openmailbox.org changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: ahelp/ahelp - Extended tips in Helpcontent VCL + Glade
Hi all, Thanks a lot for your work and explanations, I jump to the end: Le 26/08/2015 18:35, Markus Mohrhard a écrit : Hey Olivier, [...] At least my patches to move the tooltips extracts them to simple java like property files. You can easily process them from there. That format at least easily allows us to keep all the existing translations and handle all the corner cases that are currently not covered by ui files. Additionally the agreement with the translators asks us to make sure that the extended tooltips can be extracted into an own pootle project to keep them independent of the normal UI translations. I hope my points explain why all this is less of an technical problem and more a social one where before you can do any work you need to convince the people affected by your change to come to a common understanding. At least your current proposal goes against the current agreement betwee Kendy, Sophi, me and the translators. (It already took a long time to get that far). I think we could go further now if we plan the changes largely in advance and if it would be possible to make the changes in 3 or 4 steps instead of a big one. Knowing it in advance will allow translators to organize their work between the different open source projects they contribute to. Olivier, we will discuss the help topic during the l10n workshop at LibOCon, would it be possible that you explain the process to the group during Tuesday afternoon? Then I'll discuss with the team to push the project further. Cheers Sophie -- Sophie Gautier sophie.gaut...@documentfoundation.org GSM: +33683901545 IRC: sophi Co-founder - Release coordinator The Document Foundation ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93711] Translation error (German: Leerezeichen) in chapter numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=93711 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added CC|gautier.sop...@gmail.com|ku...@libreoffice.org --- Comment #2 from Adolfo Jayme f...@libreoffice.org --- @Kü: can you have a look, please? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93711] Translation error (German: Leerezeichen) in chapter numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=93711 sophie gautier.sop...@gmail.com changed: What|Removed |Added CC||gautier.sop...@gmail.com --- Comment #3 from sophie gautier.sop...@gmail.com --- I've sent a mail to the l10n list earlier this morning, the team will come back to the issue - Sophie -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 93558] Preview of Bullets is hard to see with a dark theme
https://bugs.documentfoundation.org/show_bug.cgi?id=93558 --- Comment #16 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Maxim Monastirsky committed a patch related to this issue. It has been pushed to libreoffice-5-0: http://cgit.freedesktop.org/libreoffice/core/commit/?id=4a305d029116793f1e73019fa1242ded5f5236f2h=libreoffice-5-0 tdf#93558 Hardcode black text on white background It will be available in 5.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 93558] Preview of Bullets is hard to see with a dark theme
https://bugs.documentfoundation.org/show_bug.cgi?id=93558 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard| target:5.1.0 | target:5.1.0 target:5.0.2 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
