[Libreoffice-bugs] [Bug 97506] Do not appear Object's submenu

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97506

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #1 from Maxim Monastirsky  ---
Hi,

Edit->Object menu is for OLE objects. It's OK if it's empty when no OLE object
selected. Closing as NOTABUG. Feel free to reopen the bug if it's still empty
after creating & selecting OLE object (Insert->Object->OLE Object...).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97516] New: Botoon

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97516

Bug ID: 97516
   Summary: Botoon
   Product: LibreOffice
   Version: 5.2.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: wolace.hardware.re...@gmail.com

Created attachment 122337
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122337=edit
error in button

Hello good afternoon.

Help like for an error found in Calc.

The update interval button is not working I export a query in the database and
import the spreadsheet.

I would help with this tool.

Data> Refresh Interval.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - extras/source

2016-02-02 Thread Marco A . G . Pinto 
 extras/source/autocorr/lang/pt/DocumentList.xml | 2690 
 1 file changed, 1430 insertions(+), 1260 deletions(-)

New commits:
commit 21f66a09625c207adab459287df5a84b00be017d
Author: Marco A. G. Pinto 
Date:   Tue Feb 2 08:44:39 2016 -0200

tdf#97439 Enhance pt-PT autocorrect file

This patch adds 168 new entries to the pt-PT autocorrection.

Change-Id: I8a9233cd0d1a2eeca5861c6ca51f3d2121053085
Reviewed-on: https://gerrit.libreoffice.org/22024
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 
(cherry picked from commit 33003d0fed4a5aaef4b631fcc3c0941f0eca34c9)
Reviewed-on: https://gerrit.libreoffice.org/22061
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/extras/source/autocorr/lang/pt/DocumentList.xml 
b/extras/source/autocorr/lang/pt/DocumentList.xml
index 22c55b9..5bd26e5 100644
--- a/extras/source/autocorr/lang/pt/DocumentList.xml
+++ b/extras/source/autocorr/lang/pt/DocumentList.xml
@@ -1,1261 +1,1431 @@
-
-http://openoffice.org/2001/block-list;>
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-

[Libreoffice-bugs] [Bug 95405] Kill focus-stealing search and replace dialog and make functionality available in a sidebar deck

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=95405

Akshay Deep  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|akshaydeepi...@gmail.com|libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 95405] Kill focus-stealing search and replace dialog and make functionality available in a sidebar deck

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=95405

Akshay Deep  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|akshaydeepi...@gmail.com|libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1-0' - officecfg/registry

2016-02-02 Thread Caolán McNamara 
 officecfg/registry/data/org/openoffice/Office/Accelerators.xcu |   12 
--
 1 file changed, 12 deletions(-)

New commits:
commit 78d3ba011b8866416b59c2fdffa9ab0c16da9ed2
Author: Caolán McNamara 
Date:   Tue Feb 2 12:52:10 2016 +

Related: tdf#91909 home/end don't work in impress text boxes anymore

partial revert of

commit 9149dbf17329180e2c9e2fb39243c65acc07a182
Author: Yousuf Philips 
Date:   Fri Nov 20 09:40:59 2015 +0400

tdf#91909 Add shortcuts to slide navigation

to get home/end working in text boxes again

Change-Id: I9960b94077c4c00d63483d3105d73f418cbcef0e
(cherry picked from commit 758a50110aae8c0b339e3230b39f8d8343ce6bbc)
Reviewed-on: https://gerrit.libreoffice.org/22032
Reviewed-by: Samuel Mehrbrodt 
Reviewed-by: Michael Stahl 
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu 
b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
index 44b5271..ab773b6 100644
--- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
@@ -2712,12 +2712,6 @@
 .uno:SelectAll
   
 
-
-  
-I10N SHORTCUTS - NO 
TRANSLATE
-.uno:LastPage
-  
-
 
   
 I10N SHORTCUTS - NO 
TRANSLATE
@@ -2852,12 +2846,6 @@
 .uno:SuperScript
   
 
-
-  
-I10N SHORTCUTS - NO 
TRANSLATE
-.uno:FirstPage
-  
-
 
   
 I10N SHORTCUTS - NO 
TRANSLATE
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97439] Update (merge) Autocorrect pt_PT to 2016-01-29

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97439

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:5.2.0   | target:5.2.0 target:5.1.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97439] Update (merge) Autocorrect pt_PT to 2016-01-29

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97439

--- Comment #2 from Commit Notification 
 ---
Marco A. G. Pinto committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=21f66a09625c207adab459287df5a84b00be017d=libreoffice-5-1

tdf#97439 Enhance pt-PT autocorrect file

It will be available in 5.1.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 40534] slide tearing or not shown in LARGE screens (high resolution) with hardware acceleration enabled and dual screen (presenting)

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=40534

--- Comment #52 from David REBOUL  ---
I just confirmed that turning off hardware acceleration is fixing the problem.
Thanks for all

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97505] From Print Preview mode, Print dialog "Pages" field not adjusted when blank pages are suppressed

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97505

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97505] From Print Preview mode, Print dialog "Pages" field not adjusted when blank pages are suppressed

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97505

--- Comment #4 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bb01d7bc50e59eb30c0826a000ede52b93074f75

tdf#97505 Account empty pages for print preview

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97510] Let Ctrl+ e Ctrl- be mapped to Zoom+ resp. Zoom- by default.

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97510

Olivier Hallot  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||olivier.hallot@documentfoun
   ||dation.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97514] New: Problem in Images legends

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97514

Bug ID: 97514
   Summary: Problem in Images legends
   Product: LibreOffice
   Version: 5.0.2.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lposan...@gmail.com

Hello.

I had this file wrote in olders versions of LibreOffice.

So I change my Linux and that come with version 5.

This is amazing, extremal FASTER, nice view, very good.

Opened the document file with no problems in formatting. Perfect.

BUT: The images legends I had inserted exists (I can see that in the summary),
but below the image disapear (or stay invisible).

When I export in PDF the legends does not appear too.

I can see the legend when I "send to back" the image, but some moments after
stay invisible again.

Is it some bug or new setting I need to activate?

I sent the file "incorporating" the TTFs I use. So this size.

Thanks.

Luiz

PS: Image in portuguese language means FIGURA.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91992] LO50b3: Images are not shown in local Help

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=91992

--- Comment #11 from Yan Pashkovsky  ---
No, the bug still exists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: android/source

2016-02-02 Thread AlexF 
 android/source/AndroidManifest.xml 
|   10 
 android/source/res/drawable/ic_menu_back.png   
|binary
 android/source/res/layout/activity_directory_browser.xml   
|6 
 android/source/res/layout/fragment_directory_browser.xml   
|   71 +++
 android/source/res/values/strings.xml  
|   18 
 android/source/res/xml/documentprovider_preferences.xml
|   13 
 android/source/src/java/org/libreoffice/storage/DocumentProviderFactory.java   
|   19 
 
android/source/src/java/org/libreoffice/storage/DocumentProviderSettingsActivity.java
  |   41 +-
 android/source/src/java/org/libreoffice/storage/IOUtils.java   
|   59 ++
 
android/source/src/java/org/libreoffice/storage/external/BrowserSelectorActivity.java
  |  152 +++
 
android/source/src/java/org/libreoffice/storage/external/DirectoryBrowserActivity.java
 |   42 ++
 
android/source/src/java/org/libreoffice/storage/external/DirectoryBrowserFragment.java
 |  199 ++
 android/source/src/java/org/libreoffice/storage/external/ExternalFile.java 
|  149 +++
 
android/source/src/java/org/libreoffice/storage/external/ExtsdDocumentsProvider.java
   |  152 +++
 
android/source/src/java/org/libreoffice/storage/external/IExternalDocumentProvider.java
|   19 
 
android/source/src/java/org/libreoffice/storage/external/LegacyExtSDDocumentsProvider.java
 |   97 
 
android/source/src/java/org/libreoffice/storage/external/OTGDocumentsProvider.java
 |   84 
 17 files changed, 1125 insertions(+), 6 deletions(-)

New commits:
commit 1dfb68debb01dcc0aa5902f41bc17c7a97e47b26
Author: AlexF 
Date:   Wed Dec 16 22:53:08 2015 +0800

tdf#88389 - android document browser: external storage access

Background:
External SD cards are only partially supported by the Android system,
with a great deal of fragmentation on implementation across manufacturers
and android versions. There is no official support for OTG devices.

This commit adds:
1) External SD card support
2) OTG device support

Caveats:
1) Not tested on Android 6. Emulator crashes when opening
files on Android 6, using an unmodified build of the master branch.

2) OTG support currently works only if there is write access
to the OTG directory. The user must be aware of exact OTG directory
path or be able to navigate to it as well.

3) External SD card provider currently lacks file filtering.

Approach:
-
Added new document providers.

External SD cards:
There are 2 different document providers external sd cards,
one for Android 4.4 and above, and the other for older versions.

1) New
Android 4.4 and above require usage of the DocumentFile wrapper class
to access files in external storage. Actual file paths are no longer
obtainable. As such, the underlying file will be cloned in a cache,
allowing us to get an actual file path and use LOK.
Some differences exist between 4.4 & 5+. The document provider handles
each case separately.

2) Legacy
Android 4.3 and below do not support the DocumentFile wrapper.
File object can be used in these versions, allowing actual file paths
to be obtained. The document provider guesses the root directory of
the SD card. If the guessing fails, the user is to navigate to
this directory himself.

OTG:
The OTG document provider resembles the legacy external SD card
document provider, requiring the user to locate the directory himself.
The document provider does not guess the root directory of the OTG
device as the location varies with manufacturer implementation.
-

Supplementary Notes:
Attempting to use the internal app cache as the file cache like in
the ownCloud document provider did not work. Using the external app
cache works fine though. It could be because initializing LOK wipes
the internal app cache.

Would be good to test the ownCloud document provider to confirm if it
works.

Change-Id: Ie727cca265107bc49ca7e7b57130470f7fc52e06
Reviewed-on: https://gerrit.libreoffice.org/20738
Reviewed-by: Tomaž Vajngerl 
Tested-by: Miklos Vajna 

diff --git a/android/source/AndroidManifest.xml 
b/android/source/AndroidManifest.xml
index d49771a..25e8240 100644
--- a/android/source/AndroidManifest.xml
+++ b/android/source/AndroidManifest.xml
@@ -113,6 +113,16 @@
 
 
 
+
+
+
+
+
+
 
 
 
diff --git a/android/source/res/drawable/ic_menu_back.png

[Libreoffice-commits] core.git: sw/source

2016-02-02 Thread Jan-Marek Glogowski 
 sw/source/uibase/uno/unotxdoc.cxx |   13 +
 1 file changed, 9 insertions(+), 4 deletions(-)

New commits:
commit bb01d7bc50e59eb30c0826a000ede52b93074f75
Author: Jan-Marek Glogowski 
Date:   Tue Feb 2 18:38:09 2016 +0100

tdf#97505 Account empty pages for print preview

Commit 1296f9dc9e502abd8422dfeee1ac7747a82aee17 was just a workaround
to fix the crash, while I couldn't find a way to get the layout from
the print preview, as all shells seemed empty. Took me a while to
realize the SwViewShell also has a layout, which is available, so we
can account for the empty pages correctly.

Change-Id: Icf0e9fdc0c1eeb6cadc48482595482545fd553e7

diff --git a/sw/source/uibase/uno/unotxdoc.cxx 
b/sw/source/uibase/uno/unotxdoc.cxx
index c42bcca..9c64773 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -189,30 +189,35 @@ static SwPrintUIOptions * lcl_GetPrintUIOptions(
 
 // Get current page number
 sal_uInt16 nCurrentPage = 1;
-SwWrtShell* pSh = pDocShell->GetWrtShell();
+const SwWrtShell* pSh = pDocShell->GetWrtShell();
+const SwRootFrame *pFrame = nullptr;
 if (pSh)
 {
 SwPaM* pShellCursor = pSh->GetCursor();
 nCurrentPage = pShellCursor->GetPageNum();
+pFrame = pSh->GetLayout();
 }
 else if (!bSwSrcView)
 {
 const SwPagePreview* pPreview = dynamic_cast< const SwPagePreview* 
>(pView);
 OSL_ENSURE(pPreview, "Unexpected type of the view shell");
 if (pPreview)
+{
 nCurrentPage = pPreview->GetSelectedPage();
+pFrame = pPreview->GetViewShell()->GetLayout();
+}
 }
 
 // If blanks are skipped, account for them in initial page range value
-if (pSh && !rPrintData.IsPrintEmptyPages())
+if (pFrame && !rPrintData.IsPrintEmptyPages())
 {
 sal_uInt16 nMax = nCurrentPage;
-SwPageFrame *pPage = 
dynamic_cast(pSh->GetLayout()->Lower());
+const SwPageFrame *pPage = dynamic_cast(pFrame->Lower());
 for ( ; nMax-- > 0; )
 {
 if (pPage->Frame().Height() == 0)
 nCurrentPage--;
-pPage = static_cast(pPage->GetNext());
+pPage = static_cast(pPage->GetNext());
 }
 }
 return new SwPrintUIOptions( nCurrentPage, bWebDoc, bSwSrcView, 
bHasSelection, bHasPostIts, rPrintData );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97514] Problem in Images legends

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97514

--- Comment #1 from LUIZ PAULO O SANTOS  ---
Created attachment 122335
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122335=edit
The First time error in sent. The ODT is inside it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97515] New: FILEOPEN XLSX cell backgrounds shift

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97515

Bug ID: 97515
   Summary: FILEOPEN XLSX cell backgrounds shift
   Product: LibreOffice
   Version: 5.0.4.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ag...@freemail.hu

Created attachment 122336
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122336=edit
sample xlsx file and two screenshots

I received an xlsx file. When I opened it in LO, the gray background of the
cells were shifted by one row downwards compared to what I get in MS Excel
2013.
I prepared a reduced file to show the situation, please find it in enclosed
zip: XLS3.xlsx
I also enlosed screenshots of Excel 2013 on Windows 8.1 and LibreOffice
5.0.4002 on Mac OS X 10.10.5.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 96414] Remove feature to show Navigator during slideshow

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96414

--- Comment #6 from Bryan Quigley  ---
(In reply to Samuel Mehrbrodt from comment #4)
> (In reply to Jean-Baptiste Faure from comment #3)
> > Does this removing will concern the slides list available from the
> > right-click menu in slideshow mode?
> 
> That part should be retained.

It is retained in the code I just posted -
https://gerrit.libreoffice.org/#/c/22062/

One thing I did notice (but it's in stable too). Is that the Navigator Pen
doesn't work.  Should that just be removed too?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 51132] After one success, PRINTING of #10 ENVELOPES failed to print properly, apparently due to incorrect formatting of the envelope document by the 'Insert Envelope' wizard.

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=51132

--- Comment #13 from m...@michaels.demon.co.uk ---
I've also been having problems with envelopes. LO Writer 5.04, Win7/64. I don't
actually try to print; if I did the printer would be a Brother HL-L2340DW
laser.

I choose the envelope option and choose DL as the envelope size (22x11cm;
customs size 22.1x11.1 behaves the same. A DL envelope takes a sheet of A4
folded in 3). Address positions are not particularly relevant as they always
misbehave, but address 11.05cm from left, 5.55cm from top; return address 1.0,
1.0. Envelope is displayed sensibly on the Envelope window preview, starting
top left and halfway down right. Save as New Document. In the document windows
the envelope displays in a different format, basically the correct format with
several cm of white space above. LO rulers show the width to be 22cm, but the
height is 16cm; the top 5cm of the ruler are grey. 

To replicate:
- New text document. Insert/Envelope.
- Enter addressee and sender in Envelope tab.
- Format tab, from top, in cm: 100.05, 5.55, 1.00, 1.00, User-defined, 22.10,
11.10 (DL behaves the same). Display shows envelope twice as long as high with
addresses well-placed: correct.
- Printer tab, 5th option, Print from top, no shift. Printer is set to Brother
HL-L2340D series.
- Click New Document. First 5 cm of new document are unwriteable header,
followed by 11cm of envelope. Would be correct if top cropped.
- Print Preview is visibly 22:16 aspect ratio, not 22:11

- Repeat with Foxit Reader PDF Printer, same result.
- Repeat with Microsft XPS Document Printer, same result (changed Format to DL
Envelope and changed positions by 0.1cm just for variety)

I hope this is of some use.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-5' - i18nlangtag/qa i18nlangtag/source

2016-02-02 Thread Eike Rathke 
 i18nlangtag/qa/cppunit/test_languagetag.cxx |1 +
 i18nlangtag/source/isolang/isolang.cxx  |1 +
 2 files changed, 2 insertions(+)

New commits:
commit edc44d944a3465c4387548d2ddd69ba1f67970fe
Author: Eike Rathke 
Date:   Fri Jan 22 22:30:39 2016 +0100

tdf#97315 forward compatibility for [eu-ES] mapping to [eu]

Commit 72c5e230f9cda8e18f63f7bbc6567487b4c5a5e0 maps [eu] to [eu-ES] for
5.2 (cherry-picked to 5.1), enable 5.0.5 to read that but still save
[eu].

Change-Id: I2aa82023a1ffb411c034beceb0bc999885adb026
Reviewed-on: https://gerrit.libreoffice.org/21728
Reviewed-by: Michael Stahl 
Reviewed-by: Markus Mohrhard 
Reviewed-by: David Ostrovsky 
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/i18nlangtag/qa/cppunit/test_languagetag.cxx 
b/i18nlangtag/qa/cppunit/test_languagetag.cxx
index b76547c..f13863c 100644
--- a/i18nlangtag/qa/cppunit/test_languagetag.cxx
+++ b/i18nlangtag/qa/cppunit/test_languagetag.cxx
@@ -665,6 +665,7 @@ static bool checkMapping( const OUString& rStr1, const 
OUString& rStr2 )
 if (rStr1 == "ku-SY"   ) return rStr2 == "kmr-Latn-SY";
 if (rStr1 == "ku-IQ"   ) return rStr2 == "ckb-IQ";
 if (rStr1 == "ku-IR"   ) return rStr2 == "ckb-IR";
+if (rStr1 == "eu-ES"   ) return rStr2 == "eu";
 return rStr1 == rStr2;
 }
 
diff --git a/i18nlangtag/source/isolang/isolang.cxx 
b/i18nlangtag/source/isolang/isolang.cxx
index ee8406c..c56e14b 100644
--- a/i18nlangtag/source/isolang/isolang.cxx
+++ b/i18nlangtag/source/isolang/isolang.cxx
@@ -240,6 +240,7 @@ static IsoLanguageCountryEntry const aImplIsoLangEntries[] =
 { LANGUAGE_USER_ARABIC_SUDAN,   "ar", "SD", 0 },
 { LANGUAGE_ARABIC_PRIMARY_ONLY, "ar", ""  , 0 },
 { LANGUAGE_BASQUE,  "eu", ""  , 0 },
+{ LANGUAGE_BASQUE,  "eu", "ES", kSAME },
 { LANGUAGE_BULGARIAN,   "bg", "BG", 0 },
 { LANGUAGE_CZECH,   "cs", "CZ", 0 },
 { LANGUAGE_CZECH,   "cz", ""  , kSAME },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 96414] Remove feature to show Navigator during slideshow

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96414

--- Comment #7 from Jean-Baptiste Faure  ---
(In reply to Bryan Quigley from comment #6)
> [...]
> One thing I did notice (but it's in stable too). Is that the Navigator Pen
> doesn't work.  Should that just be removed too?

What do you mean by "Navigator Pen"? The "Mouse pointer as pen" in the
slideshow settings? It allows to write/draw on the slide during slideshow and
it works as expected.

Best regards. JBF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96414] Remove feature to show Navigator during slideshow

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96414

--- Comment #9 from Jean-Baptiste Faure  ---
(In reply to Bryan Quigley from comment #8)
> (In reply to Jean-Baptiste Faure from comment #7)
> > (In reply to Bryan Quigley from comment #6)
> > > [...]
> > > One thing I did notice (but it's in stable too). Is that the Navigator Pen
> > > doesn't work.  Should that just be removed too?
> > 
> > What do you mean by "Navigator Pen"? The "Mouse pointer as pen" in the
> > slideshow settings? It allows to write/draw on the slide during slideshow
> > and it works as expected.
> > 
> > Best regards. JBF
> 
> If you open the Navigator (not in SlideShow mode) the first button in it is
> "Pointer".  I haven't been able to figure out what it should do or in what
> case it's enabled.

It seems it is another mean to activate the mouse pointer as pen. Indeed if you
check the corresponding checkbox in the slideshow settings, then the button in
the navigator become pressed or activated (not clear for me). To see that you
should check the checkbox, launch the slideshow and exit it, then the button
state has changed.

Best regards. JBF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 91093] EMF with alpha blend bitmap

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=91093

Andras Timar  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Andras Timar  ---


*** This bug has been marked as a duplicate of bug 91017 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-5' - sc/source

2016-02-02 Thread Tor Lillqvist 
 sc/source/core/opencl/formulagroupcl.cxx |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit 320246d24d8a07cdb6b8400e8afa48696cc39343
Author: Tor Lillqvist 
Date:   Sun Oct 18 22:57:47 2015 +0300

tdf#97150: tdf#94924: If we can't handle strings, don't try to then

Fixes the VLOOKUP problem reported in tdf#94540 by falling back to
non-OpenCL for such a case, where one of the columns passed to the
VLOOKUP contained strings. And since a while, we don't claim to handle
strings in VLOOKUP. Which is true.

(cherry picked from commit 476bef70f1d9fd58b29a1f6fb95e54567b031acf)

Change-Id: I4140c86bf8166beb8201aa90c075d9f4432d9173
Reviewed-on: https://gerrit.libreoffice.org/21875
Reviewed-by: Markus Mohrhard 
Reviewed-by: Michael Stahl 
Reviewed-by: David Ostrovsky 
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/sc/source/core/opencl/formulagroupcl.cxx 
b/sc/source/core/opencl/formulagroupcl.cxx
index 2667f5d..4b8b50e 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -2659,6 +2659,13 @@ 
DynamicKernelSoPArguments::DynamicKernelSoPArguments(const ScCalcConfig& config,
 new 
DynamicKernelMixedSlidingArgument(mCalcConfig,
 ts, ft->Children[i], mpCodeGen, 
j)));
 }
+else if 
(!AllStringsAreNull(pDVR->GetArrays()[j].mpStringArray, pDVR->GetArrayLength()) 
&&
+ !pCodeGen->takeString())
+{
+// Can't handle
+SAL_INFO("sc.opencl", "Strings but can't do 
that.");
+throw UnhandledToken(pChild, ("unhandled 
operand " + StackVarEnumToString(pChild->GetType()) + " for ocPush").c_str());
+}
 else
 {
 // Not sure I can figure out what case this 
exactly is;)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97481] DPI scaling doesn't work with export to png or jpg

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97481

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||rb.hensc...@t-online.de
 Resolution|--- |DUPLICATE

--- Comment #3 from Regina Henschel  ---
You have to set first the resolution and then the size. Then correct number of
pixels is generated. The dpi information in the png-file is correct for me. The
dpi information in the jpeg-file is wrong. That is already tracked in bug
85761.

*** This bug has been marked as a duplicate of bug 85761 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85761] Exporting jpeg format from DRAW, resolution does not follow options setting

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=85761

Regina Henschel  changed:

   What|Removed |Added

 CC||yanp...@gmail.com

--- Comment #4 from Regina Henschel  ---
*** Bug 97481 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87813] SIDEBAR: Incorporating the effects list into the animation tab

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=87813

Akshay Deep  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |akshaydeepi...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 87813] SIDEBAR: Incorporating the effects list into the animation tab

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=87813

Akshay Deep  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |akshaydeepi...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97512] LO5.0.1RC3 About box not fully localizable

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97512

Andras Timar  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |tima...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97502] calc crashes while insert huge columns

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97502

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Hi @andreas, thanks for reporting.

Have you test, pasting as unformatted text?, click on the righ-arrow of the
paste icon or trough Menu/Edit/Paste special.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-5' - include/xmloff sw/qa xmloff/source

2016-02-02 Thread Michael Stahl 
 include/xmloff/txtprmap.hxx|7 +-
 sw/qa/extras/globalfilter/globalfilter.cxx |   80 +
 xmloff/source/text/txtexppr.cxx|   10 +++
 xmloff/source/text/txtprmap.cxx|4 -
 4 files changed, 96 insertions(+), 5 deletions(-)

New commits:
commit 89aa74dd903a7919b33982bc2efc74c8ec902fdc
Author: Michael Stahl 
Date:   Tue Feb 2 14:10:02 2016 +0100

xmloff: tdf#96147: ODF export: fix duplicate fo:background-color

... attributes that happen if both CharHighlight and CharBackColor
properties are used, because the CharBackTransparent property wasn't
taken into account, and combining the CharBackColor and
CharBackTransparent properties happens *after*
XMLTextExportPropertySetMapper::ContextFilter() runs.

Also, it looks like a transparent highlight wouldn't export properly but
apparently DomainMapper::getColorFromId() won't create such.

(regression from f880962f5bf26bfaef06bd3f9e67e2d901a2e74c)

(cherry picked from commit 8dadefc35f8b33648fb6adbdaca75ea52b2705db)

Change-Id: Ib628ef8bb377482f74fadb97c81afb95fbbf7184
Reviewed-on: https://gerrit.libreoffice.org/22046
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 
(cherry picked from commit e92dcab1407fa26fc5ee68d0b626b87bc04f1b3b)
Reviewed-on: https://gerrit.libreoffice.org/22054
Reviewed-by: Markus Mohrhard 
Reviewed-by: David Ostrovsky 
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/include/xmloff/txtprmap.hxx b/include/xmloff/txtprmap.hxx
index 5fa8e3c..79baf8b 100644
--- a/include/xmloff/txtprmap.hxx
+++ b/include/xmloff/txtprmap.hxx
@@ -197,9 +197,10 @@
 #define CTF_RELWIDTHREL (XML_TEXT_CTF_START + 168)
 #define CTF_RELHEIGHTREL(XML_TEXT_CTF_START + 169)
 #define CTF_CHAR_BACKGROUND (XML_TEXT_CTF_START + 170)
-#define CTF_CHAR_HIGHLIGHT  (XML_TEXT_CTF_START + 171)
-#define CTF_FILLSTYLE   (XML_TEXT_CTF_START + 172)
-#define CTF_FILLCOLOR   (XML_TEXT_CTF_START + 173)
+#define CTF_CHAR_BACKGROUND_TRANSPARENCY(XML_TEXT_CTF_START + 171)
+#define CTF_CHAR_HIGHLIGHT  (XML_TEXT_CTF_START + 172)
+#define CTF_FILLSTYLE   (XML_TEXT_CTF_START + 173)
+#define CTF_FILLCOLOR   (XML_TEXT_CTF_START + 174)
 
 
 enum class TextPropMap {
diff --git a/sw/qa/extras/globalfilter/globalfilter.cxx 
b/sw/qa/extras/globalfilter/globalfilter.cxx
index f2a7cf2..18e17e3 100644
--- a/sw/qa/extras/globalfilter/globalfilter.cxx
+++ b/sw/qa/extras/globalfilter/globalfilter.cxx
@@ -30,6 +30,7 @@ public:
 void testImageWithSpecialID();
 void testGraphicShape();
 void testCharHighlight();
+void testCharHighlightODF();
 void testCharHighlightBody();
 void testMSCharBackgroundEditing();
 void testCharBackgroundToHighlighting();
@@ -41,6 +42,7 @@ public:
 CPPUNIT_TEST(testImageWithSpecialID);
 CPPUNIT_TEST(testGraphicShape);
 CPPUNIT_TEST(testCharHighlight);
+CPPUNIT_TEST(testCharHighlightODF);
 CPPUNIT_TEST(testMSCharBackgroundEditing);
 CPPUNIT_TEST(testCharBackgroundToHighlighting);
 #if !defined(WNT)
@@ -471,6 +473,84 @@ void Test::testCharHighlight()
 testCharHighlightBody();
 }
 
+void Test::testCharHighlightODF()
+{
+mxComponent = 
loadFromDesktop(getURLFromSrc("/sw/qa/extras/globalfilter/data/char_background_editing.docx"),
+  "com.sun.star.text.TextDocument");
+
+// don't check import, testMSCharBackgroundEditing already does that
+
+uno::Reference xPara = getParagraph(1);
+for (int i = 1; i <= 4; ++i)
+{
+uno::Reference xRun(getRun(xPara,i), 
uno::UNO_QUERY);
+switch (i)
+{
+case 1: // non-transparent highlight
+xRun->setPropertyValue("CharBackColor", 
uno::makeAny(static_cast(128)));
+xRun->setPropertyValue("CharBackTransparent", uno::makeAny(true));
+xRun->setPropertyValue("CharHighlight", 
uno::makeAny(static_cast(64)));
+break;
+
+case 2: // transparent backcolor
+xRun->setPropertyValue("CharBackColor", 
uno::makeAny(static_cast(128)));
+xRun->setPropertyValue("CharBackTransparent", uno::makeAny(true));
+xRun->setPropertyValue("CharHighlight", 
uno::makeAny(static_cast(COL_TRANSPARENT)));
+break;
+
+case 3: // non-transparent backcolor
+xRun->setPropertyValue("CharBackColor", 
uno::makeAny(static_cast(128)));
+xRun->setPropertyValue("CharBackTransparent", uno::makeAny(false));
+xRun->setPropertyValue("CharHighlight",

[Libreoffice-bugs] [Bug 97517] FILEOPEN: DOCX import flips line incorrectly

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97517

--- Comment #1 from Tim van der Meij  ---
Created attachment 122338
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122338=edit
Reduced test case (line)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 96414] Remove feature to show Navigator during slideshow

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96414

--- Comment #8 from Bryan Quigley  ---
(In reply to Jean-Baptiste Faure from comment #7)
> (In reply to Bryan Quigley from comment #6)
> > [...]
> > One thing I did notice (but it's in stable too). Is that the Navigator Pen
> > doesn't work.  Should that just be removed too?
> 
> What do you mean by "Navigator Pen"? The "Mouse pointer as pen" in the
> slideshow settings? It allows to write/draw on the slide during slideshow
> and it works as expected.
> 
> Best regards. JBF

If you open the Navigator (not in SlideShow mode) the first button in it is
"Pointer".  I haven't been able to figure out what it should do or in what case
it's enabled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97517] New: FILEOPEN: DOCX import flips line incorrectly

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97517

Bug ID: 97517
   Summary: FILEOPEN: DOCX import flips line incorrectly
   Product: LibreOffice
   Version: 5.1.0.3 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: timvanderm...@gmail.com

LibreOffice Writer fails to correctly import a DOCX document with a line in it.
The line is flipped incorrectly.

Steps to reproduce:
- Open the attached reduced test case with LibreOffice Writer.

Expected behavior:
- The line is drawn from the bottom left to the top right.

Actual behavior:
- The line is drawn from the top left to the bottom right.

Initial research:
- The `document.xml` file inside the DOCX file contains a `v:line` element. I
noticed that this has `style="flip:x"`, which might explain why this is
imported incorrectly. LibreOffice Writer probably does not take this property
into account, as the line is not flipped in the x-axis in LibreOffice Writer.
Hopefully this makes triaging and fixing this issue a bit easier.

You have my permission to use the attached reduced test case in any of your
test suites.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-5' - editeng/source

2016-02-02 Thread Caolán McNamara 
 editeng/source/editeng/impedit3.cxx |7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

New commits:
commit 1d5a1f06c33bea1dd05fa6b03a02dce178578980
Author: Caolán McNamara 
Date:   Tue Feb 2 11:50:51 2016 +

Resolves: tdf#97375 use Invalidate in all modes

makes the crash/hangs go away

(cherry picked from commit ab5c427784fb72d52042b8122ffc5a0fd7108c6b)

(cherry picked from commit c3f09ae629b349c52a4a7954e3017ceb8d7afeaf)

Change-Id: I91a4391190ec7aa0ffa5e41a8c1eb86b4bb9c484
Reviewed-on: https://gerrit.libreoffice.org/22026
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 
(cherry picked from commit 1b49e14c82af691fe1ec5aa5de8392350bce11a1)
Reviewed-on: https://gerrit.libreoffice.org/22056
Reviewed-by: David Ostrovsky 
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index fb071e0..98e3d51 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -289,12 +289,7 @@ void ImpEditEngine::UpdateViews( EditView* pCurView )
 {
 // convert to window coordinates 
 aClipRect = pView->pImpEditView->GetWindowPos( aClipRect );
-
-// For tiled rendering, we have to always go via Invalidate().
-if ( pView == pCurView && !pView->isTiledRendering())
-Paint( pView->pImpEditView, aClipRect, 0, true );
-else
-pView->GetWindow()->Invalidate( aClipRect );
+pView->GetWindow()->Invalidate( aClipRect );
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-5' - svx/source

2016-02-02 Thread Caolán McNamara 
 svx/source/sdr/contact/viewcontactofsdrpathobj.cxx |8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

New commits:
commit b10af3417cb3cf8d99f30ff67661fa615f3bd56c
Author: Caolán McNamara 
Date:   Tue Jan 26 15:33:40 2016 +

Resolves: tdf#97276 don't clip out line if the underlying page size is 
unknown

Change-Id: I77d88d8020e9ac26bd6b7277e6d8afefed5e3ee7
(cherry picked from commit ad99c633908f7c70d06812ebfb4e069f0158)
(cherry picked from commit 38b362c58abd0df654665956ffc751d40cfb67ab)
Reviewed-on: https://gerrit.libreoffice.org/21814
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 
(cherry picked from commit 5f9a61e877d79cce1f99c05a9c1598a029bf2c1c)
Reviewed-on: https://gerrit.libreoffice.org/22058
Reviewed-by: Markus Mohrhard 
Reviewed-by: David Ostrovsky 
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 

diff --git a/svx/source/sdr/contact/viewcontactofsdrpathobj.cxx 
b/svx/source/sdr/contact/viewcontactofsdrpathobj.cxx
index c44c6a2..f09a78d 100644
--- a/svx/source/sdr/contact/viewcontactofsdrpathobj.cxx
+++ b/svx/source/sdr/contact/viewcontactofsdrpathobj.cxx
@@ -91,15 +91,17 @@ namespace sdr
 if(bIsLine)
 {
 const SdrPage* pPage = GetPathObj().GetPage();
-if (pPage)
+double fPageWidth = pPage ? pPage->GetWdt() : 0.0;
+double fPageHeight = pPage ? pPage->GetHgt() : 0.0;
+if (fPageWidth && fPageHeight)
 {
 //tdf#63955 if we have an extremely long line then clip it
 //to a very generous range of -1 page width/height vs +1
 //page width/height to avoid oom and massive churn
 //generating a huge polygon chain to cover the length in
 //applyLineDashing if this line is dashed
-double fPageWidth = pPage->GetWdt();
-double fPageHeight = pPage->GetHgt();
+//tdf#97276 don't clip if the underlying page dimension
+//is unknown
 basegfx::B2DRange aClipRange(-fPageWidth, -fPageHeight,
  fPageWidth*2, fPageHeight*2);
 aUnitPolyPolygon = 
basegfx::tools::clipPolyPolygonOnRange(aUnitPolyPolygon,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97502] calc crashes while insert huge columns

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97502

--- Comment #2 from andreas.j...@gmail.com ---
Hi, it happens when I insert a column of numbers in a text column:

10.2
2.5
...

replaced by 

10,2
2,5
...

I copy the column, insert it in a text editor, replace dot by comma and then
back to calc. If I clear the column first and then insert, there is no problem.
But if I try to "overwrite" it, calc crashes...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97517] FILEOPEN: DOCX import flips line incorrectly

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97517

--- Comment #3 from Tim van der Meij  ---
Hm, looking at
https://www.mail-archive.com/libreoffice-commits@lists.freedesktop.org/msg06787.html
the "flip" option seems implemented, also with "x" and "y" options. So either
there is a bug there or something else is causing this effect. I'll leave
further triage to you; you know the codebase much better than I do!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97150] OPENCL: VLOOKUP returns wrong data when it is used at many cells

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97150

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:5.0.6   | target:5.0.6 target:5.0.5

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97150] OPENCL: VLOOKUP returns wrong data when it is used at many cells

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97150

--- Comment #13 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "libreoffice-5-0-5":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=320246d24d8a07cdb6b8400e8afa48696cc39343=libreoffice-5-0-5

tdf#97150: tdf#94924: If we can't handle strings, don't try to then

It will be available in 5.0.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97517] FILEOPEN: DOCX import flips line incorrectly

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97517

--- Comment #2 from Tim van der Meij  ---
Created attachment 122339
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122339=edit
Reduced test case (arrow head)

I'm attaching another reduced test case, this time an arrow head, that is also
flipped incorrectly, this time in the y-axis. And again, there is
`style="flip:y"` in the file's `document.xml`, which might confirm my thought
about this property being ignored by LibreOffice Writer. Taking this into
account will resolve both reduced test cases and probably some more files I
have.

Of course you also have my full permission to use this file in any way you want
for any test suite.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97496] HELP doesn't open to a usable page

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97496

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||rb.hensc...@t-online.de
 Ever confirmed|0   |1

--- Comment #1 from Regina Henschel  ---
The help is context sensitive. So you have to describe very exact, in which
situation you get a wrong page. What part of the UI has currently the focus,
what is selected and where is the mouse pointer. Cite the output, when you do
not press F1 but Shift-F1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97469] Ctrl F, Ctrl H shortcuts no longer work

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97469

--- Comment #4 from Dylan Knowles  ---
Forgive my naivete: what is "profile.closing", and if it's a file, where is it
located?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 96132] Enabling Experimental Features in the UI doesn't inform the user that LibO needs to be restarted

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96132

Akshay Deep  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |akshaydeepi...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 96132] Enabling Experimental Features in the UI doesn't inform the user that LibO needs to be restarted

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96132

Akshay Deep  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |akshaydeepi...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

2016-02-02 Thread Chris Sherlock 
 vcl/source/filter/wmf/wmfwr.cxx |7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit 145a569fb15b77f3e85ce5029551bb1d8adc
Author: Chris Sherlock 
Date:   Wed Feb 3 10:14:26 2016 +1100

vcl: cosmetic change - it appears some newlines were missing in wmfwr.cxx

Change-Id: I1c1678c96d5b2f4a88299b9b3da317fa28ba96c4

diff --git a/vcl/source/filter/wmf/wmfwr.cxx b/vcl/source/filter/wmf/wmfwr.cxx
index 4ab9868..72830fb 100644
--- a/vcl/source/filter/wmf/wmfwr.cxx
+++ b/vcl/source/filter/wmf/wmfwr.cxx
@@ -802,7 +802,12 @@ void WMFWriter::WMFRecord_StretchDIB( const Point & 
rPoint, const Size & rSize,
 }
 }
 
-pWMF->WriteUInt32( nROP ). WriteInt16( 0 ). 
WriteInt16( rBitmap.GetSizePixel().Height() ). WriteInt16( 
rBitmap.GetSizePixel().Width() ). WriteInt16( 0 ). 
WriteInt16( 0 );
+pWMF->WriteUInt32( nROP ).
+WriteInt16( 0 ).
+WriteInt16( rBitmap.GetSizePixel().Height() ).
+WriteInt16( rBitmap.GetSizePixel().Width() ).
+WriteInt16( 0 ).
+WriteInt16( 0 );
 
 WriteHeightWidth(rSize);
 WritePointYX(rPoint);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 96132] Enabling Experimental Features in the UI doesn't inform the user that LibO needs to be restarted

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96132

--- Comment #5 from Markus Mohrhard (retired)  
---
That is actually not completely true.

There are many experimental features that work without a restart. The better
question is which ones don't and then check if they can't be made to work
without it. Especially as we now have a configuration change listener.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97518] Diagonal lines on embedded image after PDF export

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97518

--- Comment #1 from David  ---
Also affects 5.1.0.3 (64bit linux)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97518] Diagonal lines on embedded image after PDF export

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97518

--- Comment #3 from David  ---
Created attachment 122341
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122341=edit
expended output (LO 5.0.4.2)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97502] calc crashes while insert huge columns

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97502

--- Comment #3 from m.a.riosv  ---
Sorry, but I don't see an answer to my question.

On the other side, you don't need use a text editor for change dot by comma.

The simple way is Menu/Data/Text to column, click on the column head and in the
column type select English US.

With the search and replaee [Ctrl+H] you can replace dot by comma, only verify
that regular expression are not marked.

Calc documentation:
https://wiki.documentfoundation.org/Documentation/Publications#LibreOffice_Calc_Guide

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

DPI and screen resolution on OS X

2016-02-02 Thread Chris Sherlock 
Hi all, 

I’ve mentioned this briefly to Tor on IRC, but thought I’d email the mailing 
list and a general enquiry. 

I noticed that we don’t actually get the “true” DPI for OS X, nor the actual 
resolution - at least on high resolution screens (Retina in particular). 

That’s because Apple have a concept of logical points, where each point scales 
depending on the resolution of the screen. To get the actual resolution, you 
need to get the NSScreen’s backing coordinate system into an NSRect, then get 
the actual resolution - at which point you can calculate the PPI (I’ll use PPI 
from now on, it’s more accurate than DPI). 

I figured out how to get this out of OS X and I submitted to patches to Gerrit 
for review:

1. https://gerrit.libreoffice.org/#/c/21948/ - vcl: (quartz) get the actual DPI 
on OS X
2. https://gerrit.libreoffice.org/#/c/21973/ - vcl: (quartz) get the actual 
pixel height and width of OS X

It’s actually pretty simple - you just use:

NSRect aFrame = [pScreen convertRectToBacking:[pScreen frame]];

This gives the actual resolution in pixels, not logical points (backing 
coordinates are always in pixels). 

However, whilst everything renders correctly - the size of things obviously 
double (or change to whatever scale the screen resolution makes it). 

I guess I was wondering what the impact is, or what challenges have we had with 
not getting the *actual* DPI and screen resolution on OS X builds? Has anyone 
noticed anything odd when they are using a Mac, or developing for it?

The other question is: why would we not want to the actual DPI and screen 
resolution? 

Thanks,
Chris

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97518] New: Diagonal lines on embedded image after PDF export

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97518

Bug ID: 97518
   Summary: Diagonal lines on embedded image after PDF export
   Product: LibreOffice
   Version: 5.0.5.1 rc
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: slumber...@gmail.com

Created attachment 122340
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122340=edit
diagonal lines appearing over images

After exporting A LibreOffice Draw document to pdf, diagonal lines have been
added to the embedded pngs/jpgs in the document.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - toolkit/source

2016-02-02 Thread Chris Sherlock 
 toolkit/source/helper/vclunohelper.cxx |9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

New commits:
commit 32096592fcf067d50e22090135b542325f5e3e62
Author: Chris Sherlock 
Date:   Wed Feb 3 10:57:51 2016 +1100

toolkit: remove some comment cruft from vclunohelper.cxx

Change-Id: I1670e8d1adccd2123d41e51b7d7ee5228c555280

diff --git a/toolkit/source/helper/vclunohelper.cxx 
b/toolkit/source/helper/vclunohelper.cxx
index 20bcae5..9c0f76f 100644
--- a/toolkit/source/helper/vclunohelper.cxx
+++ b/toolkit/source/helper/vclunohelper.cxx
@@ -57,9 +57,6 @@
 using namespace ::com::sun::star;
 
 
-//  class VCLUnoHelper
-
-
 uno::Reference< css::awt::XToolkit> VCLUnoHelper::CreateToolkit()
 {
 uno::Reference< uno::XComponentContext > xContext = 
::comphelper::getProcessComponentContext();
@@ -514,8 +511,6 @@ sal_Int32 VCLUnoHelper::VCL2UnoEmbedMapUnit( MapUnit 
nVCLMapUnit )
 using namespace ::com::sun::star::util;
 
 
-//= file-local helpers
-
 namespace
 {
 enum UnitConversionDirection
commit 9c77bb8fde80d7f35676cb1e41e5b122ac96b6a4
Author: Chris Sherlock 
Date:   Wed Feb 3 10:56:40 2016 +1100

tdf#39468 toolkit: translate some German comments in the VCL UNO helper file

Change-Id: Ib432f2cbfc71ebfec0ef1ecae99ae3fde1a4d946

diff --git a/toolkit/source/helper/vclunohelper.cxx 
b/toolkit/source/helper/vclunohelper.cxx
index ddab490..20bcae5 100644
--- a/toolkit/source/helper/vclunohelper.cxx
+++ b/toolkit/source/helper/vclunohelper.cxx
@@ -381,7 +381,7 @@ css::awt::FontDescriptor 
VCLUnoHelper::CreateFontDescriptor( const vcl::Font& rF
 aFD.Orientation = rFont.GetOrientation();
 aFD.Kerning = rFont.IsKerning();
 aFD.WordLineMode = rFont.IsWordLineMode();
-aFD.Type = 0;   // ??? => Nur an Metric...
+aFD.Type = 0;   // ??? => Only in Metric...
 return aFD;
 }
 
@@ -411,7 +411,7 @@ vcl::Font VCLUnoHelper::CreateFont( const 
css::awt::FontDescriptor& rDescr, cons
 if ( (FontStrikeout)rDescr.Strikeout != STRIKEOUT_DONTKNOW )
 aFont.SetStrikeout( (FontStrikeout)rDescr.Strikeout );
 
-// Kein DONTKNOW
+// Not DONTKNOW
 aFont.SetOrientation( (short)rDescr.Orientation );
 aFont.SetKerning( static_cast(rDescr.Kerning) );
 aFont.SetWordLineMode( rDescr.WordLineMode );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLKit.cpp

2016-02-02 Thread Henry Castro 
 loolwsd/LOOLKit.cpp |   18 ++
 1 file changed, 10 insertions(+), 8 deletions(-)

New commits:
commit 647d7c778390625798dd83f470ac307d6e59803d
Author: Henry Castro 
Date:   Tue Feb 2 20:07:15 2016 -0400

loolwsd: first, establish pipe connection

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index f57c7ad..763e21d 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -530,13 +530,7 @@ void lokit_main(const std::string , const 
std::string& jailId, const s
 #else
 ("/" + loSubPath + "/program");
 #endif
-
-LibreOfficeKit* loKit(lok_init_2(instdir_path.c_str(), "file:///user"));
-if (loKit == nullptr)
-{
-Log::error("Error: LibreOfficeKit initialization failed. Exiting.");
-exit(Application::EXIT_SOFTWARE);
-}
+LibreOfficeKit* loKit = nullptr;
 
 try
 {
@@ -555,6 +549,13 @@ void lokit_main(const std::string , const 
std::string& jailId, const s
 exit(Application::EXIT_SOFTWARE);
 }
 
+loKit = lok_init_2(instdir_path.c_str(), "file:///user");
+if (loKit == nullptr)
+{
+Log::error("Error: LibreOfficeKit initialization failed. 
Exiting.");
+exit(Application::EXIT_SOFTWARE);
+}
+
 Log::info("loolkit [" + std::to_string(Process::id()) + "] is ready.");
 
 std::string aResponse;
@@ -677,7 +678,8 @@ void lokit_main(const std::string , const 
std::string& jailId, const s
 
 // Destroy LibreOfficeKit
 Log::debug("Destroying LibreOfficeKit.");
-loKit->pClass->destroy(loKit);
+if (loKit)
+loKit->pClass->destroy(loKit);
 
 Log::info("Process [" + process_name + "] finished.");
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97518] Diagonal lines on embedded image after PDF export

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97518

--- Comment #2 from David  ---
The problem is not present in version 5.0.4.2 64bit Linux
see no_banding.png

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 94269] Replace "n" prefix for bool variables with "b"

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94269

--- Comment #7 from dan...@fearnley.net ---
This issue seems to have been resolved and git grep -E 'bool n[A-Z]'
 returns no results. IS it ok to be marked as resolved?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97150] OPENCL: VLOOKUP returns wrong data when it is used at many cells

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97150

Adolfo Jayme  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |t...@iki.fi
   |desktop.org |
 Whiteboard| target:5.0.6 target:5.0.5  |target:5.0.5

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94269] Replace "n" prefix for bool variables with "b"

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94269

--- Comment #7 from dan...@fearnley.net ---
This issue seems to have been resolved and git grep -E 'bool n[A-Z]'
 returns no results. IS it ok to be marked as resolved?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97439] Update (merge) Autocorrect pt_PT to 2016-01-29

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97439

Adolfo Jayme  changed:

   What|Removed |Added

URL|https://bz.apache.org/ooo/s |
   |how_bug.cgi?id=126815   |
   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=126815
   Assignee|libreoffice-b...@lists.free |marcoagpinto@mail.telepac.p
   |desktop.org |t

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Draw Templates: arrowhd.soe and standard.soe

2016-02-02 Thread HillHobbit 
Is there a way to include custom arrowhd.soe and standard.soe files with a
Draw Template?

I was surprised when custom line endings were not retained in an ERD
template.

Is there a way to include custom arrows in a template?

thanks.



--
View this message in context: 
http://nabble.documentfoundation.org/Draw-Templates-arrowhd-soe-and-standard-soe-tp4173939.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 95857] Sort out German plurals ...

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=95857

dan...@fearnley.net changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |dan...@fearnley.net
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 95857] Sort out German plurals ...

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=95857

dan...@fearnley.net changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |dan...@fearnley.net
   |desktop.org |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 95857] Sort out German plurals ...

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=95857

--- Comment #2 from dan...@fearnley.net ---
I plan to have a go at this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Jochen Nitschke license statement

2016-02-02 Thread j.nitsc...@ok.de 
Hello,

All of my past & future contributions to LibreOffice may be licensed under the 
MPLv2/LGPLv3+ dual license and Apache License version 2.0.

First Name: Jochen
Last Name:  Nitschke
Git Email:  j.nitschke+loger...@ok.de

Regards
Jochen Nitschke




signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 83522] getTransferable copy content to system clipboard when content is removed

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=83522

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||jbfa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #4 from Jean-Baptiste Faure  ---
Please, could you be more explicit and describe what is the current behavior
and what would be the expected behavior?

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83299] Format > Sections is disabled when the cursor is inside a protected section

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=83299

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |NOTOURBUG

--- Comment #16 from Jean-Baptiste Faure  ---
(In reply to Mohammed Sameer from comment #15)
> Created attachment 116204 [details]
> docx document
> 
> This is a docx document which causes libreoffice to show a disabled sections
> entry.

There is no problem to modify this document in LO 5.0. The entry Section in the
Format menu is indeed disabled but that does not mean there is a defect.

Closing again as NotOurBug.
Feel free to reopen if you are able to provide a clear step by step scenario to
reproduce an unexpected behavior.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93967] LibreOffice Crash always after try to save

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=93967

--- Comment #30 from rao...@comcast.net ---
Is there any progress on this?  This prevents LibreOffice from being a
trustworthy application - one can never tell if one is going to lose their data
or not.

Thanks in advance for any information!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90886] UNO: Adding additional paste special commands

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=90886

--- Comment #7 from Maxim Monastirsky  ---
(In reply to Yousuf (Jay) Philips from comment #6)
> while here we only need a limited number of commonly used paste
> special options
OK, makes sense then.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: dbaccess/source sc/source

2016-02-02 Thread Markus Mohrhard 
 dbaccess/source/filter/xml/xmlfilter.cxx |4 +---
 sc/source/filter/xml/xmldpimp.cxx|2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

New commits:
commit 3d3204be2c1c8c3aded94cdf3d2ead7958c8b2f1
Author: Markus Mohrhard 
Date:   Wed Feb 3 05:25:10 2016 +0100

fix previous commit

Change-Id: I3e3b0cf703162b5f01148aced9a1d5faabb5d50d

diff --git a/dbaccess/source/filter/xml/xmlfilter.cxx 
b/dbaccess/source/filter/xml/xmlfilter.cxx
index 5453f39..6401113 100644
--- a/dbaccess/source/filter/xml/xmlfilter.cxx
+++ b/dbaccess/source/filter/xml/xmlfilter.cxx
@@ -700,9 +700,7 @@ const SvXMLTokenMap& ODBFilter::GetColumnElemTokenMap() 
const
 SvXMLImportContext* ODBFilter::CreateStylesContext(sal_uInt16 _nPrefix,const 
OUString& rLocalName,
  const uno::Reference< XAttributeList>& 
xAttrList, bool bIsAutoStyle )
 {
-SvXMLImportContext *pContext;
-
-pContext = new OTableStylesContext(*this, _nPrefix, rLocalName, xAttrList, 
bIsAutoStyle);
+SvXMLImportContext *pContext = new OTableStylesContext(*this, _nPrefix, 
rLocalName, xAttrList, bIsAutoStyle);
 if (bIsAutoStyle)
 SetAutoStyles(static_cast(pContext));
 else
diff --git a/sc/source/filter/xml/xmldpimp.cxx 
b/sc/source/filter/xml/xmldpimp.cxx
index 891db22..56d7340 100644
--- a/sc/source/filter/xml/xmldpimp.cxx
+++ b/sc/source/filter/xml/xmldpimp.cxx
@@ -732,7 +732,7 @@ SvXMLImportContext 
*ScXMLDPSourceQueryContext::CreateChildContext( sal_uInt16 nP
 const OUString& rLName,
 const 
css::uno::Reference& /* xAttrList */ )
 {
-return pContext = new SvXMLImportContext( GetImport(), nPrefix, rLName );
+return new SvXMLImportContext( GetImport(), nPrefix, rLName );
 }
 
 void ScXMLDPSourceQueryContext::EndElement()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97519] New: Track changes not adjusting numbering

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97519

Bug ID: 97519
   Summary: Track changes not adjusting numbering
   Product: LibreOffice
   Version: 5.0.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: saxyw...@gmail.com

When an entire numbered section is being deleted, the next numbered section
still continues the numbering rather then repeating the number.  The number of
the deleted section does not indicate it is being removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81629] Named cell ranges corruption

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=81629

Arul Michael(ldcs.co.in)  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|arul7...@gmail.com  |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95505] Dump usage stats to text file in user profile rather than std error

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=95505

--- Comment #28 from Commit Notification 
 ---
aybuke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2db74425208033f848ddb5bac7277d30d72afcad

tdf#95505  Dump usage stats to text file.

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/source

2016-02-02 Thread aybuke 
 sfx2/source/control/unoctitm.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2db74425208033f848ddb5bac7277d30d72afcad
Author: aybuke 
Date:   Sat Jan 30 14:13:10 2016 +0200

tdf#95505  Dump usage stats to text file.

Creating file's content reformatted for csv.

Change-Id: Ifefdddcae1265ad1e68e192981d6435712a9f607
Reviewed-on: https://gerrit.libreoffice.org/21920
Tested-by: Jenkins 
Reviewed-by: Yousuf Philips 
Tested-by: Yousuf Philips 
Reviewed-by: jan iversen 

diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx
index 78bd160..9fa0887 100644
--- a/sfx2/source/control/unoctitm.cxx
+++ b/sfx2/source/control/unoctitm.cxx
@@ -667,7 +667,7 @@ void UsageInfo::save()
 
 if( file.open(osl_File_OpenFlag_Read | osl_File_OpenFlag_Write | 
osl_File_OpenFlag_Create) == osl::File::E_None )
 {
-OString aUsageInfoMsg = "Document Type,Command,Count";
+OString aUsageInfoMsg = "Document Type;Command;Count";
 
 for (UsageMap::const_iterator it = maUsage.begin(); it != 
maUsage.end(); ++it)
 aUsageInfoMsg += "\n" + it->first.toUtf8() + ";" + 
OString::number(it->second);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97369] SUM formulas, in the cell below one with the same formula (and maybe more?) are not calculate correctly in 5.1 (with more then ~100 rows)

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97369

Tor Lillqvist  changed:

   What|Removed |Added

 Attachment #122327|0   |1
is obsolete||

--- Comment #36 from Tor Lillqvist  ---
Created attachment 122344
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122344=edit
Even simpler example, now with unique numbers in the cells to make debugging
easier

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97195] Impress slide transition Shape group -- Diamond effect fatal error crash

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97195

raal  changed:

   What|Removed |Added

   Keywords||regression
 CC||r...@post.cz

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97195] Impress slide transition Shape group -- Diamond effect fatal error crash

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97195

raal  changed:

   What|Removed |Added

 CC||philip...@hotmail.com

--- Comment #2 from raal  ---
*** Bug 97489 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97495] Tooltip is not aligned with its UI element

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97495

Samuel Mehrbrodt  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||caol...@redhat.com,
   ||samuel.mehrbr...@cib.de
   Hardware|x86-64 (AMD64)  |All
 Ever confirmed|0   |1

--- Comment #1 from Samuel Mehrbrodt  ---
Seems to be a GTK3 issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [Bug 32364] Add a "filter" to Insert > Field > Other > Cross reference tab

2016-02-02 Thread jan iversen 


Sent from my iPad, please excuse any misspellings 

> On 01 Feb 2016, at 22:11, Chris Sherlock  wrote:
> 
> Hi all, 
> 
> Quick ping to the mailing list - if anyone here has expertise around this 
> area, it would be great for the submitter to get some feedback :-)

This involves the UI, so we should have an opinion from the UI team, patch 
updated.

rgds
jan i.

> 
> Chris
> 
>> On 2 Feb 2016, at 7:52 AM, bugzilla-dae...@bugs.documentfoundation.org wrote:
>> 
>> 
>> Comment # 9 on bug 32364 from Chris Sherlock
>> Hi all, a decent stab at resolving this has been made in gerrit, I don't know
>> the codebase well enough to confirm the enhancement though. If someone more
>> knowledgeable than myself could review this, it would be greatly appreciated
>> :-)
>> 
>> https://gerrit.libreoffice.org/#/c/21856/
>> 
>> You are receiving this mail because:
>> You are on the CC list for the bug.
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sd/source

2016-02-02 Thread Oliver Specht 
 sd/source/ui/app/sdmod2.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 90dfa7cbcaf32aab6005b94b393c7c409ff1af8f
Author: Oliver Specht 
Date:   Mon Feb 1 16:06:33 2016 +0100

tdf#97374: prevent crash while updating SvxPageTitleField

with commit 2970ec843820a72d73a91cc11fc353e5b9fde5fd the check for
a valid pDoc had been removed

Change-Id: I644ee82a46ec4f047f1a1b6bff68c4b67e96c3d8
Reviewed-on: https://gerrit.libreoffice.org/22006
Reviewed-by: Oliver Specht 
Tested-by: Oliver Specht 

diff --git a/sd/source/ui/app/sdmod2.cxx b/sd/source/ui/app/sdmod2.cxx
index f8f2d57..1f51811 100644
--- a/sd/source/ui/app/sdmod2.cxx
+++ b/sd/source/ui/app/sdmod2.cxx
@@ -271,7 +271,8 @@ IMPL_LINK_TYPED(SdModule, CalcFieldValueHdl, 
EditFieldInfo*, pInfo, void)
 }
 else
 {
-aRepresentation = ( ( pDoc->GetDocumentType() == 
DOCUMENT_TYPE_IMPRESS )
+DocumentType eDocType = pDoc ? pDoc->GetDocumentType() : 
DOCUMENT_TYPE_IMPRESS;
+aRepresentation = ( ( eDocType == DOCUMENT_TYPE_IMPRESS )
 ? 
SdResId(STR_FIELD_PLACEHOLDER_SLIDENAME).toString()
 : 
SdResId(STR_FIELD_PLACEHOLDER_PAGENAME).toString() );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97497] New: Autocorrect Replace term works only every second time

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97497

Bug ID: 97497
   Summary: Autocorrect Replace term works only every second time
   Product: LibreOffice
   Version: 5.0.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tsc...@googlemail.com

Created attachment 122324
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122324=edit
autocorrect dialog with affected replace line marked

Hey Guys

I made a new automatic replace shortcut to replace every ,, with :
I want this to insert times in cells easier. 

After finding the correct format for these shortcut

.*,,.* 

Calc replaces the inserted value 15,,55 only every second time to 15:55. The
first time the value is not replaced and the cell contains 15,,55 as value.


So, i think replacing does not work at all time and want to file these with
this report. 


If i should do anything or test anything to clarify the situation please let me
know. I will watch this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97498] New: Insert additional data series in chart with Copy and Paste / Paste special

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97498

Bug ID: 97498
   Summary: Insert additional data series in chart with Copy and
Paste / Paste special
   Product: LibreOffice
   Version: unspecified
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Chart
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: burnu...@gmail.com

You can add new data series one by one with the chart right click menu. (Not
very comfortable.)
It is also possible to add additional data series in a chart with drag,
holding [Ctrl] key. But that is not obvious (there is no such menu command in
LO) and does not work if the chart is not on the same sheet as the data table.

So it would be really helpful, if new data series could also be added to a
chart with Copy and Paste / Paste special like in Excel.
(In LO in the moment Paste inserts the copied cells in the chart as a picture
like a screenshot!)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97374

--- Comment #13 from Commit Notification 
 ---
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=90dfa7cbcaf32aab6005b94b393c7c409ff1af8f

tdf#97374: prevent crash while updating SvxPageTitleField

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97374

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sd/source

2016-02-02 Thread Maxim Monastirsky 
 sd/source/ui/view/drviews7.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 0086461be280ee1d77d7811c6d930812f6adb33a
Author: Maxim Monastirsky 
Date:   Sun Jan 24 22:36:46 2016 +0200

tdf#86609 sd: Fill Paste Special on initial update too

Regression of:

commit d51d59296d65e8ace8f2d898e757267d25f871b2
Date:   Tue Nov 8 08:06:05 2005 +

INTEGRATION: CWS impress73 (1.59.32); FILE MERGED

Change-Id: I1a10957d36c38d559d69224ec744dbd8d446b8c2
(cherry picked from commit 12f11aa2ff0fd2ec8ecccf47501b9a6b1636b4ba)
Reviewed-on: https://gerrit.libreoffice.org/21772
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/sd/source/ui/view/drviews7.cxx b/sd/source/ui/view/drviews7.cxx
index 1740fa6..c916960 100644
--- a/sd/source/ui/view/drviews7.cxx
+++ b/sd/source/ui/view/drviews7.cxx
@@ -619,6 +619,7 @@ void DrawViewShell::GetMenuState( SfxItemSet  )
 // get initial state
 TransferableDataHelper aDataHelper( 
TransferableDataHelper::CreateFromSystemClipboard( GetActiveWindow() ) );
 mbPastePossible = ( aDataHelper.GetFormatCount() != 0 );
+mpCurrentClipboardFormats = GetSupportedClipboardFormats( 
aDataHelper );
 }
 else
 mbPastePossible = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/svx svx/source

2016-02-02 Thread Miklos Vajna 
 include/svx/svdetc.hxx   |   30 +-
 svx/source/svdraw/svdetc.cxx |   48 +--
 2 files changed, 39 insertions(+), 39 deletions(-)

New commits:
commit ef59f096a5c2c835cdfef380943d29943ed1bd2d
Author: Miklos Vajna 
Date:   Tue Feb 2 09:16:56 2016 +0100

svx: prefix members of SvdProgressInfo

Change-Id: I23fa86080c001d3a78c3b7d7c49274f01444d9be

diff --git a/include/svx/svdetc.hxx b/include/svx/svdetc.hxx
index 17f3f3d..1184d02 100644
--- a/include/svx/svdetc.hxx
+++ b/include/svx/svdetc.hxx
@@ -130,17 +130,17 @@ sal_uInt16* RemoveWhichRange(const sal_uInt16* 
pOldWhichTable, sal_uInt16 nRange
 class SVX_DLLPUBLIC SvdProgressInfo
 {
 private:
-sal_uIntPtr nSumActionCount; // Sum of all Actions
-sal_uIntPtr nSumCurAction;   // Sum of all handled Actions
+sal_uIntPtr m_nSumActionCount; // Sum of all Actions
+sal_uIntPtr m_nSumCurAction;   // Sum of all handled Actions
 
-sal_uIntPtr nActionCount;   // Count of Actions in the current object
-sal_uIntPtr nCurAction; // Count of handled Actions in the current 
object
+sal_uIntPtr m_nActionCount;   // Count of Actions in the current object
+sal_uIntPtr m_nCurAction; // Count of handled Actions in the current 
object
 
-sal_uIntPtr nInsertCount;   // Count of to-be-inserted Actions in the 
current object
-sal_uIntPtr nCurInsert; // Count of already inserted Actions
+sal_uIntPtr m_nInsertCount;   // Count of to-be-inserted Actions in the 
current object
+sal_uIntPtr m_nCurInsert; // Count of already inserted Actions
 
-sal_uIntPtr nObjCount;  // Count of selected objects
-sal_uIntPtr nCurObj;// Current object
+sal_uIntPtr m_nObjCount;  // Count of selected objects
+sal_uIntPtr m_nCurObj;// Current object
 
 Link  maLink;
 
@@ -157,15 +157,15 @@ public:
 bool ReportActions( sal_uIntPtr nActionCount );
 void ReportInserts( sal_uIntPtr nInsertCount );
 
-sal_uIntPtr GetSumCurAction() const { return nSumCurAction; };
-sal_uIntPtr GetObjCount() const { return nObjCount; };
-sal_uIntPtr GetCurObj() const { return nCurObj; };
+sal_uIntPtr GetSumCurAction() const { return m_nSumCurAction; };
+sal_uIntPtr GetObjCount() const { return m_nObjCount; };
+sal_uIntPtr GetCurObj() const { return m_nCurObj; };
 
-sal_uIntPtr GetActionCount() const { return nActionCount; };
-sal_uIntPtr GetCurAction() const { return nCurAction; };
+sal_uIntPtr GetActionCount() const { return m_nActionCount; };
+sal_uIntPtr GetCurAction() const { return m_nCurAction; };
 
-sal_uIntPtr GetInsertCount() const { return nInsertCount; };
-sal_uIntPtr GetCurInsert() const { return nCurInsert; };
+sal_uIntPtr GetInsertCount() const { return m_nInsertCount; };
+sal_uIntPtr GetCurInsert() const { return m_nCurInsert; };
 
 void ReportRescales( sal_uIntPtr nRescaleCount );
 };
diff --git a/svx/source/svdraw/svdetc.cxx b/svx/source/svdraw/svdetc.cxx
index 437e674..424b1ef 100644
--- a/svx/source/svdraw/svdetc.cxx
+++ b/svx/source/svdraw/svdetc.cxx
@@ -554,68 +554,68 @@ sal_uInt16* RemoveWhichRange(const sal_uInt16* 
pOldWhichTable, sal_uInt16 nRange
 SvdProgressInfo::SvdProgressInfo( const Link&_rLink )
 {
 maLink = _rLink;
-nSumActionCount = 0;
-nSumCurAction   = 0;
+m_nSumActionCount = 0;
+m_nSumCurAction   = 0;
 
-nObjCount = 0;
-nCurObj   = 0;
+m_nObjCount = 0;
+m_nCurObj   = 0;
 
-nActionCount = 0;
-nCurAction   = 0;
+m_nActionCount = 0;
+m_nCurAction   = 0;
 
-nInsertCount = 0;
-nCurInsert   = 0;
+m_nInsertCount = 0;
+m_nCurInsert   = 0;
 }
 
 void SvdProgressInfo::Init( sal_uIntPtr _nSumActionCount, sal_uIntPtr 
_nObjCount )
 {
-nSumActionCount = _nSumActionCount;
-nObjCount = _nObjCount;
+m_nSumActionCount = _nSumActionCount;
+m_nObjCount = _nObjCount;
 }
 
 bool SvdProgressInfo::ReportActions( sal_uIntPtr nAnzActions )
 {
-nSumCurAction += nAnzActions;
-nCurAction += nAnzActions;
-if(nCurAction > nActionCount)
-nCurAction = nActionCount;
+m_nSumCurAction += nAnzActions;
+m_nCurAction += nAnzActions;
+if(m_nCurAction > m_nActionCount)
+m_nCurAction = m_nActionCount;
 
 return maLink.Call(nullptr);
 }
 
 void SvdProgressInfo::ReportInserts( sal_uIntPtr nAnzInserts )
 {
-nSumCurAction += nAnzInserts;
-nCurInsert += nAnzInserts;
+m_nSumCurAction += nAnzInserts;
+m_nCurInsert += nAnzInserts;
 
 maLink.Call(nullptr);
 }
 
 void SvdProgressInfo::ReportRescales( sal_uIntPtr nAnzRescales )
 {
-nSumCurAction += nAnzRescales;
+m_nSumCurAction += nAnzRescales;
 maLink.Call(nullptr);
 }
 
 void SvdProgressInfo::SetActionCount( sal_uIntPtr _nActionCount )
 {
-nActionCount = _nActionCount;
+m_nActionCount = _nActionCount;
 }
 
 void

[Libreoffice-bugs] [Bug 97489] Crash on setting shape slide transition

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97489

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||r...@post.cz
 Resolution|--- |DUPLICATE

--- Comment #1 from raal  ---


*** This bug has been marked as a duplicate of bug 97195 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97487] Comments badly anchored when commenting the last word in a text

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97487

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||r...@post.cz
Summary|Comments badly anchored |Comments badly anchored
   ||when commenting the last
   ||word in a text
 Ever confirmed|0   |1
 OS|Linux (All) |All

--- Comment #3 from raal  ---

Bug 64731 - Feature Request - Make text selection for comments moveable /
editable 

Reproducible with Version: 5.2.0.0.alpha0+
Build ID: f4e703aa39e9c294441b6dd86189d8aff32db8bf
CPU Threads: 4; OS Version: Windows 6.1; UI Render: GL;

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97491] Styles with "Title" anywhere in stylename import from OOo as not named, buggy

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97491

--- Comment #6 from Diane Kistner  ---
Thanks for checking into this. It may well be a Mac/El Capitan issue (although
I wasn't having that issue with Apache OpenOffice, which I uninstalled
yesterday before I installed LibreOffice). I'll go have a look at that other
bug report and see if there's anything there I can try. I don't think it's a
sizing issue, though, because I have other large fonts in my styles that render
fine. But I'm relieved to know that you see the font. My main concern is that
my PDF files render appropriately and that they not bounce as corrupted when I
submit them to my book printer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/source

2016-02-02 Thread Oliver Specht 
 sfx2/source/dialog/styledlg.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 869c73d0d2512e483ceedcc895b7cb86e0974ab2
Author: Oliver Specht 
Date:   Tue Feb 2 10:44:40 2016 +0100

tdf#97051: prevent duplicate copy of SfxItemSet

the patch f7424ed710e54bb2437a28380b03ed7c26290edc introduced copying of
the input item set of SfxTabDialog so now the item set of the style must
not be copied anymore.

Change-Id: If4155ee5999f0c5cd2ac754578a2c1b5ec33b14b
Reviewed-on: https://gerrit.libreoffice.org/22022
Reviewed-by: Oliver Specht 
Tested-by: Oliver Specht 

diff --git a/sfx2/source/dialog/styledlg.cxx b/sfx2/source/dialog/styledlg.cxx
index ecf57a6..e2ed267 100644
--- a/sfx2/source/dialog/styledlg.cxx
+++ b/sfx2/source/dialog/styledlg.cxx
@@ -43,7 +43,7 @@ SfxStyleDialog::SfxStyleDialog
 */
 
 : SfxTabDialog(pParent, rID, rUIXMLDescription,
-  rStyle.GetItemSet().Clone(), true)
+  (), true)
 , pStyle(  )
 
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: B2DLineJoin::Middle, drawPolyLine etc

2016-02-02 Thread Armin Le Grand 

Hi Caolan,

no, not an error, another simple LineJoin method which just takes the 
'middle' of the points to be joined. LineJoins are for fat lines, so you 
have an inner and outer edge of the current and next segment. To join 
the points of the inner edges, these are added and divided by two, same 
for outer.
I do not remember where that came from, but it was used in some graphic 
system and seemed a nice method for doing line joins. It should in 
practise not be used much and did not make it into current/modern 
systems, but is handled correctly e.g. in the primitive decomposition of 
fat lines.
There are always exceptions in different systems, e.g. for DirectDraw on 
Win there is no B2DLineJoin::NONE, so this has to be painted by painting 
the single line segments.
For a primitive renderer this means if there is no support for that 
style for the renderer you currently feed, use the decomposition :-)
In practise I know of no current usages - even on the UI that flag is 
missing. If it can be removed (UNO API, ODF, ...), remove it.


HTH!

Am 02.02.2016 um 12:27 schrieb Caolán McNamara:

What is B2DLineJoin::Middle supposed to be ?

I see that the vcl pdf, windows and quartz backends treat ::Middle the
same as ::Mitre (so I made the cairo one do the same)

On the the other hand I see cppcanvas...setupStrokeAttributes and
filter...ImplWriteLineInfo would default ::Middle to the same as ::NONE

while

cui...SvxLineTabPage::Reset and
svx...LinePropertyPanelBase::updateLineJoint treat LineJoin_MIDDLE the
same as ROUND but
filter...EscherPropertyContainer::CreateLineProperties and
oox...DrawingML::WriteOutline the same as BEVEL

Is ::Middle a "mistake" and we should just treat it as ::Mitre
everywhere ? Especially as that's what it turns into for the windows
vcl drawPolyLine. Or is there some subtlety here ?

C.


--
--
ALG (PGP Key: EE1C 4B3F E751 D8BC C485 DEC1 3C59 F953 D81C F4A2)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 94547] Include a default set of fill patterns

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94547

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 CC||fridrich.st...@bluewin.ch
 Resolution|FIXED   |---

--- Comment #5 from Yousuf (Jay) Philips  ---
@Fridrich: Looking at your patches, they are for import support of patterns,
but not on having a default set of patterns for use, which this bug is
intending to do.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/headless vcl/unx

2016-02-02 Thread Caolán McNamara 
 vcl/headless/svpcairotextrender.cxx  |4 +++-
 vcl/unx/generic/gdi/cairotextrender.cxx  |2 --
 vcl/unx/generic/gdi/openglx11cairotextrender.cxx |6 ++
 vcl/unx/generic/gdi/x11cairotextrender.cxx   |3 ++-
 4 files changed, 11 insertions(+), 4 deletions(-)

New commits:
commit 1a1ee2f6e5b8215ad5f7bcdcb13f5fdce5784b2e
Author: Caolán McNamara 
Date:   Mon Feb 1 12:08:43 2016 +

move CairoTextRender cleanup to callers

so releaseCairoContext is a mirror of getCairoContext, so callers that don't
need to flush can drop that explicit call

Not sure, now that I see it, how there's been no sign of any problem with no
damage of the affected text area under gtk3

Change-Id: I8e508160be4102c64a0ecdf5591b6999f9171c36

diff --git a/vcl/headless/svpcairotextrender.cxx 
b/vcl/headless/svpcairotextrender.cxx
index 3109a75..9468793 100644
--- a/vcl/headless/svpcairotextrender.cxx
+++ b/vcl/headless/svpcairotextrender.cxx
@@ -9,6 +9,7 @@
 
 #include "headless/svpcairotextrender.hxx"
 #include "headless/svpgdi.hxx"
+#include 
 
 SvpCairoTextRender::SvpCairoTextRender(SvpSalGraphics& rParent)
 : mrParent(rParent)
@@ -36,8 +37,9 @@ void SvpCairoTextRender::clipRegion(cairo_t* cr)
 mrParent.clipRegion(cr);
 }
 
-void SvpCairoTextRender::releaseCairoContext(cairo_t*)
+void SvpCairoTextRender::releaseCairoContext(cairo_t* cr)
 {
+mrParent.releaseCairoContext(cr, false, basegfx::B2DRange());
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/generic/gdi/cairotextrender.cxx 
b/vcl/unx/generic/gdi/cairotextrender.cxx
index 3c95849..747791d 100644
--- a/vcl/unx/generic/gdi/cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/cairotextrender.cxx
@@ -344,9 +344,7 @@ void CairoTextRender::DrawServerFontLayout( const 
ServerFontLayout& rLayout )
 aI = aNext;
 }
 
-cairo_surface_flush(cairo_get_target(cr));
 releaseCairoContext(cr);
-cairo_destroy(cr);
 }
 
 const FontCharMapPtr CairoTextRender::GetFontCharMap() const
diff --git a/vcl/unx/generic/gdi/openglx11cairotextrender.cxx 
b/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
index d5350e9..0c8ac0d 100644
--- a/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
@@ -60,11 +60,15 @@ void OpenGLX11CairoTextRender::releaseCairoContext(cairo_t* 
cr)
 // XXX: lfrb: GLES 2.0 doesn't support GL_UNSIGNED_INT_8_8_8_8_REV
 OpenGLSalGraphicsImpl *pImpl = dynamic_cast< OpenGLSalGraphicsImpl* 
>(mrParent.GetImpl());
 if(!pImpl)
+{
+cairo_destroy(cr);
 return;
+}
 
 cairo_surface_t* pSurface = cairo_get_target(cr);
 int nWidth = cairo_image_surface_get_width( pSurface );
 int nHeight = cairo_image_surface_get_height( pSurface );
+cairo_surface_flush(pSurface);
 unsigned char *pSrc = cairo_image_surface_get_data( pSurface );
 
 // XXX: lfrb: GLES 2.0 doesn't support GL_UNSIGNED_INT_8_8_8_8_REV
@@ -78,6 +82,8 @@ void OpenGLX11CairoTextRender::releaseCairoContext(cairo_t* 
cr)
 pImpl->PreDraw();
 pImpl->DrawAlphaTexture( aTexture, aRect, true, true );
 pImpl->PostDraw();
+
+cairo_destroy(cr);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/generic/gdi/x11cairotextrender.cxx 
b/vcl/unx/generic/gdi/x11cairotextrender.cxx
index dc1797f..5a2b095 100644
--- a/vcl/unx/generic/gdi/x11cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/x11cairotextrender.cxx
@@ -146,8 +146,9 @@ size_t X11CairoTextRender::GetHeight() const
 return 1;
 }
 
-void X11CairoTextRender::releaseCairoContext(cairo_t* /*cr*/)
+void X11CairoTextRender::releaseCairoContext(cairo_t* cr)
 {
+cairo_destroy(cr);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: B2DLineJoin::Middle, drawPolyLine etc

2016-02-02 Thread Armin Le Grand 

Hi Caolan,

checked once again: B2DLineJoin::Middle is sometimes mapped to 
B2DLineJoin::NONE, sometimes to B2DLineJoin::Miter, both are nearly 
equally often used. This should be unified, I would prefer mapping to 
B2DLineJoin::Miter due to being graphically 'closer' to 
B2DLineJoin::Middle than B2DLineJoin::NONE.


Also checked: Canvas in HTML5 also e.g. knows no 'none' state. With 
LineJoin probably all GraphicSystems are slightly different.


Am 02.02.2016 um 15:46 schrieb Armin Le Grand:

Hi Caolan,

no, not an error, another simple LineJoin method which just takes the 
'middle' of the points to be joined. LineJoins are for fat lines, so 
you have an inner and outer edge of the current and next segment. To 
join the points of the inner edges, these are added and divided by 
two, same for outer.
I do not remember where that came from, but it was used in some 
graphic system and seemed a nice method for doing line joins. It 
should in practise not be used much and did not make it into 
current/modern systems, but is handled correctly e.g. in the primitive 
decomposition of fat lines.
There are always exceptions in different systems, e.g. for DirectDraw 
on Win there is no B2DLineJoin::NONE, so this has to be painted by 
painting the single line segments.
For a primitive renderer this means if there is no support for that 
style for the renderer you currently feed, use the decomposition :-)
In practise I know of no current usages - even on the UI that flag is 
missing. If it can be removed (UNO API, ODF, ...), remove it.


HTH!

Am 02.02.2016 um 12:27 schrieb Caolán McNamara:

What is B2DLineJoin::Middle supposed to be ?

I see that the vcl pdf, windows and quartz backends treat ::Middle the
same as ::Mitre (so I made the cairo one do the same)

On the the other hand I see cppcanvas...setupStrokeAttributes and
filter...ImplWriteLineInfo would default ::Middle to the same as ::NONE

while

cui...SvxLineTabPage::Reset and
svx...LinePropertyPanelBase::updateLineJoint treat LineJoin_MIDDLE the
same as ROUND but
filter...EscherPropertyContainer::CreateLineProperties and
oox...DrawingML::WriteOutline the same as BEVEL

Is ::Middle a "mistake" and we should just treat it as ::Mitre
everywhere ? Especially as that's what it turns into for the windows
vcl drawPolyLine. Or is there some subtlety here ?

C.




--
--
ALG (PGP Key: EE1C 4B3F E751 D8BC C485 DEC1 3C59 F953 D81C F4A2)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/headless vcl/quartz

2016-02-02 Thread Caolán McNamara 
 vcl/headless/svpgdi.cxx |7 ---
 vcl/quartz/salgdicommon.cxx |7 ---
 2 files changed, 14 deletions(-)

New commits:
commit 4cbd8e7bf3e69cfda3d84e86f1adedac636a055e
Author: Caolán McNamara 
Date:   Mon Feb 1 18:19:32 2016 +

windows impl doesn't care if drawPolyLine LineWidth y != x

so I don't see that it makes much of a difference then
if the quartz or cairo one's don't either

Change-Id: Iabd65d617437aa747b910fcd2e84421413ed7db6

diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 24220b7..fb7a0695 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -690,13 +690,6 @@ bool SvpSalGraphics::drawPolyLine(
 return true;
 }
 
-// reject requests that cannot be handled yet
-if (rLineWidths.getX() != rLineWidths.getY())
-{
-SAL_WARN("vcl.gdi", "unsupported SvpSalGraphics::drawPolyLine case");
-return false;
-}
-
 // #i104886# linejoin-mode and thus the above only applies to "fat" lines
 bool bNoJoin = (basegfx::B2DLineJoin::NONE == eLineJoin && 
rLineWidths.getX() > 1.3);
 
diff --git a/vcl/quartz/salgdicommon.cxx b/vcl/quartz/salgdicommon.cxx
index 8a94e19..cf99909 100644
--- a/vcl/quartz/salgdicommon.cxx
+++ b/vcl/quartz/salgdicommon.cxx
@@ -973,13 +973,6 @@ bool AquaSalGraphics::drawPolyLine( const 
basegfx::B2DPolygon& rPolyLine,
 return true;
 }
 
-// reject requests that cannot be handled yet
-if( rLineWidths.getX() != rLineWidths.getY() )
-{
-DBG_DRAW_OPERATION_EXIT_EARLY("drawPolyLine");
-return false;
-}
-
 #ifdef IOS
 if( !CheckContext() )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 88502] User selection of Firefox theme by pasting URL in UI is not possible

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=88502

--- Comment #22 from Yousuf (Jay) Philips  ---
Created attachment 122330
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122330=edit
patch attempt

This was a patch i attempted to create to solve this issue but never got around
to test it but believe it needs more work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 88502] User selection of Firefox theme by pasting URL in UI is not possible

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=88502

--- Comment #22 from Yousuf (Jay) Philips  ---
Created attachment 122330
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122330=edit
patch attempt

This was a patch i attempted to create to solve this issue but never got around
to test it but believe it needs more work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/unx

2016-02-02 Thread Caolán McNamara 
 vcl/headless/svpcairotextrender.cxx  |2 +-
 vcl/inc/headless/svpcairotextrender.hxx  |2 +-
 vcl/inc/unx/cairotextrender.hxx  |2 +-
 vcl/unx/generic/gdi/cairotextrender.cxx  |2 +-
 vcl/unx/generic/gdi/openglx11cairotextrender.cxx |2 +-
 vcl/unx/generic/gdi/openglx11cairotextrender.hxx |2 +-
 vcl/unx/generic/gdi/x11cairotextrender.cxx   |2 +-
 vcl/unx/generic/gdi/x11cairotextrender.hxx   |2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 11389cff11723c9f69317228cd2d6b1fef34b9aa
Author: Caolán McNamara 
Date:   Mon Feb 1 11:44:05 2016 +

rename drawSurface to releaseCairoContext

Change-Id: Ie5aac4a8b11daa2aba092923286fbbb2d76d4651

diff --git a/vcl/headless/svpcairotextrender.cxx 
b/vcl/headless/svpcairotextrender.cxx
index 035a9cd..3109a75 100644
--- a/vcl/headless/svpcairotextrender.cxx
+++ b/vcl/headless/svpcairotextrender.cxx
@@ -36,7 +36,7 @@ void SvpCairoTextRender::clipRegion(cairo_t* cr)
 mrParent.clipRegion(cr);
 }
 
-void SvpCairoTextRender::drawSurface(cairo_t*)
+void SvpCairoTextRender::releaseCairoContext(cairo_t*)
 {
 }
 
diff --git a/vcl/inc/headless/svpcairotextrender.hxx 
b/vcl/inc/headless/svpcairotextrender.hxx
index 9e3c837..dbd69b3 100644
--- a/vcl/inc/headless/svpcairotextrender.hxx
+++ b/vcl/inc/headless/svpcairotextrender.hxx
@@ -26,7 +26,7 @@ public:
 virtual cairo_t* getCairoContext() override;
 virtual void getSurfaceOffset(double& nDX, double& nDY) override;
 virtual void clipRegion(cairo_t* cr) override;
-virtual void drawSurface(cairo_t* cr) override;
+virtual void releaseCairoContext(cairo_t* cr) override;
 };
 
 #endif
diff --git a/vcl/inc/unx/cairotextrender.hxx b/vcl/inc/unx/cairotextrender.hxx
index 2402050..2de9b11 100644
--- a/vcl/inc/unx/cairotextrender.hxx
+++ b/vcl/inc/unx/cairotextrender.hxx
@@ -74,7 +74,7 @@ protected:
 virtual GlyphCache& getPlatformGlyphCache() = 0;
 virtual cairo_t*getCairoContext() = 0;
 virtual voidgetSurfaceOffset(double& nDX, double& nDY) = 0;
-virtual voiddrawSurface(cairo_t* cr) = 0;
+virtual voidreleaseCairoContext(cairo_t* cr) = 0;
 
 boolsetFont( const FontSelectPattern *pEntry, int 
nFallbackLevel );
 
diff --git a/vcl/unx/generic/gdi/cairotextrender.cxx 
b/vcl/unx/generic/gdi/cairotextrender.cxx
index 5ea9d3e..3c95849 100644
--- a/vcl/unx/generic/gdi/cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/cairotextrender.cxx
@@ -345,7 +345,7 @@ void CairoTextRender::DrawServerFontLayout( const 
ServerFontLayout& rLayout )
 }
 
 cairo_surface_flush(cairo_get_target(cr));
-drawSurface(cr);
+releaseCairoContext(cr);
 cairo_destroy(cr);
 }
 
diff --git a/vcl/unx/generic/gdi/openglx11cairotextrender.cxx 
b/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
index 885145c..d5350e9 100644
--- a/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
@@ -55,7 +55,7 @@ void OpenGLX11CairoTextRender::getSurfaceOffset( double& nDX, 
double& nDY )
 }
 }
 
-void OpenGLX11CairoTextRender::drawSurface(cairo_t* cr)
+void OpenGLX11CairoTextRender::releaseCairoContext(cairo_t* cr)
 {
 // XXX: lfrb: GLES 2.0 doesn't support GL_UNSIGNED_INT_8_8_8_8_REV
 OpenGLSalGraphicsImpl *pImpl = dynamic_cast< OpenGLSalGraphicsImpl* 
>(mrParent.GetImpl());
diff --git a/vcl/unx/generic/gdi/openglx11cairotextrender.hxx 
b/vcl/unx/generic/gdi/openglx11cairotextrender.hxx
index 9c6bd4d..46a11cb 100644
--- a/vcl/unx/generic/gdi/openglx11cairotextrender.hxx
+++ b/vcl/unx/generic/gdi/openglx11cairotextrender.hxx
@@ -19,7 +19,7 @@ public:
 
 virtual cairo_t* getCairoContext() override;
 virtual void getSurfaceOffset(double& nDX, double& nDY) override;
-virtual void drawSurface(cairo_t* cr) override;
+virtual void releaseCairoContext(cairo_t* cr) override;
 };
 
 #endif
diff --git a/vcl/unx/generic/gdi/x11cairotextrender.cxx 
b/vcl/unx/generic/gdi/x11cairotextrender.cxx
index 17cb462..dc1797f 100644
--- a/vcl/unx/generic/gdi/x11cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/x11cairotextrender.cxx
@@ -146,7 +146,7 @@ size_t X11CairoTextRender::GetHeight() const
 return 1;
 }
 
-void X11CairoTextRender::drawSurface(cairo_t* /*cr*/)
+void X11CairoTextRender::releaseCairoContext(cairo_t* /*cr*/)
 {
 }
 
diff --git a/vcl/unx/generic/gdi/x11cairotextrender.hxx 
b/vcl/unx/generic/gdi/x11cairotextrender.hxx
index 0c66738..f614a4d 100644
--- a/vcl/unx/generic/gdi/x11cairotextrender.hxx
+++ b/vcl/unx/generic/gdi/x11cairotextrender.hxx
@@ -43,7 +43,7 @@ public:
 virtual cairo_t* getCairoContext() override;
 virtual void getSurfaceOffset(double& nDX, double& nDY) override;
 virtual void clipRegion(cairo_t* cr) override;
-virtual void drawSurface(cairo_t* cr) override;
+virtual void

[Libreoffice-bugs] [Bug 97505] Print dialog "Pages" field not cleared when blank pages are suppressed

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97505

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from V Stuart Foote  ---
The other case--Print dialog launched from "Normal" Writer view--does not pass
through the blank page counts.

So if on page 11 of the document, print dialog opens with "Pages" field showing
9.

Similar adjustment for automatic blank pages is not made for "Print Preview"
mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57987] Start Center appears in front of (and hides) document recovery window.

2016-02-02 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=57987

--- Comment #9 from Shad Sterling  ---
Still happens with 5.0.4.2 on OS X 10.11.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

  1   2   3   4   >