[Libreoffice-commits] online.git: loolwsd/test

2016-02-20 Thread Henry Castro
 loolwsd/test/data/insert-delete.odp |binary
 loolwsd/test/httpwstest.cpp |  150 +++-
 2 files changed, 148 insertions(+), 2 deletions(-)

New commits:
commit cdc0ffb0cb28424f1a15646090cdd3542b3ae408
Author: Henry Castro 
Date:   Sat Feb 20 17:13:35 2016 -0400

loolwsd: add cppunit test partscountchanged

diff --git a/loolwsd/test/data/insert-delete.odp 
b/loolwsd/test/data/insert-delete.odp
new file mode 100644
index 000..d4541ff
Binary files /dev/null and b/loolwsd/test/data/insert-delete.odp differ
diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index 8e52976..5694d20 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -17,7 +17,9 @@
 #include 
 #include 
 #include 
-
+#include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -37,12 +39,14 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testLargePaste);
 CPPUNIT_TEST(testRenderingOptions);
 CPPUNIT_TEST(testPasswordProtectedDocument);
+CPPUNIT_TEST(testImpressPartCountChanged);
 CPPUNIT_TEST_SUITE_END();
 
 void testPaste();
 void testLargePaste();
 void testRenderingOptions();
 void testPasswordProtectedDocument();
+void testImpressPartCountChanged();
 
 static
 void sendTextFrame(Poco::Net::WebSocket& socket, const std::string& 
string);
@@ -50,6 +54,11 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 static
 bool isDocumentLoaded(Poco::Net::WebSocket& socket);
 
+static
+void getResponseMessage(Poco::Net::WebSocket& socket,
+const std::string& prefix,
+std::string& response,
+const bool isLine);
 public:
 HTTPWSTest()
 : _uri("http://127.0.0.1:"; + std::to_string(ClientPortNumber)),
@@ -284,6 +293,100 @@ void HTTPWSTest::testPasswordProtectedDocument()
 }
 }
 
+void HTTPWSTest::testImpressPartCountChanged()
+{
+try
+{
+Poco::Net::WebSocket socket(_session, _request, _response);
+
+// Load a document
+const std::string documentPath = TDOC "/insert-delete.odp";
+const std::string documentURL = "file://" + 
Poco::Path(documentPath).makeAbsolute().toString();
+
+sendTextFrame(socket, "load url=" + documentURL);
+sendTextFrame(socket, "status");
+CPPUNIT_ASSERT_MESSAGE("cannot load the document " + documentURL, 
isDocumentLoaded(socket));
+
+std::string response;
+
+// check total slides 1
+sendTextFrame(socket, "status");
+getResponseMessage(socket, "status:", response, true);
+CPPUNIT_ASSERT_MESSAGE("failed command status: ", !response.empty());
+{
+Poco::StringTokenizer tokens(response, " ", 
Poco::StringTokenizer::TOK_IGNORE_EMPTY | Poco::StringTokenizer::TOK_TRIM);
+CPPUNIT_ASSERT_EQUAL(static_cast(5), tokens.count());
+
+// Expected format is something like 'type= parts= current= width= 
height='.
+const std::string prefix = "parts=";
+const int totalParts = std::stoi(tokens[1].substr(prefix.size()));
+CPPUNIT_ASSERT_EQUAL(totalParts, 1);
+}
+
+// insert 10 slides
+for(unsigned it = 1; it <= 10; it++)
+{
+sendTextFrame(socket, "uno .uno:InsertPage");
+getResponseMessage(socket, "partscountchanged:", response, false);
+CPPUNIT_ASSERT_MESSAGE("failed command partscountchanged: ", 
!response.empty());
+{
+Poco::JSON::Parser parser;
+Poco::Dynamic::Var result = parser.parse(response);
+Poco::DynamicStruct values = 
*result.extract();
+CPPUNIT_ASSERT(values["action"] == "PartInserted");
+}
+}
+
+// delete 10 slides
+for(unsigned it = 1; it <= 10; it++)
+{
+sendTextFrame(socket, "uno .uno:DeletePage");
+getResponseMessage(socket, "partscountchanged:", response, false);
+CPPUNIT_ASSERT_MESSAGE("failed command partscountchanged: ", 
!response.empty());
+{
+Poco::JSON::Parser parser;
+Poco::Dynamic::Var result = parser.parse(response);
+Poco::DynamicStruct values = 
*result.extract();
+CPPUNIT_ASSERT(values["action"] == "PartDeleted");
+}
+}
+
+// undo delete slides
+for(unsigned it = 1; it <= 10; it++)
+{
+sendTextFrame(socket, "uno .uno:Undo");
+getResponseMessage(socket, "partscountchanged:", response, false);
+CPPUNIT_ASSERT_MESSAGE("failed command partscountchanged: ", 
!response.empty());
+{
+Poco::JSON::Parser parser;
+Poco::Dynamic::Var result = parser.parse(response);
+Poco::DynamicStruct values = 
*result.extract();
+CPPUNIT_ASSERT

Re: Bug ?

2016-02-20 Thread Chris Sherlock
Heya,

Didn't even know we used to do this!

Probably best to file a bug though - the bug tracker is at 
https://bugs.documentfoundation.org

Sent from my iPad

> On 19 Feb 2016, at 12:15 AM, T. Nannes  wrote:
> 
> Hi There,
> 
> Don't know if this is the right place the report it,
> but since version 5.0.4 LibreOfficedoes not generat
> the euro-character ( € ) anymore, if you use the keys
> Ctrl+Alt+5.
> Very anoying.
> Don't know if you call this a bug.
> 
> Greetings
> A. Nannes.
> 
> 
> -- 
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 3 commits - distro-configs/Jenkins include/vcl qadevOOo/runner vcl/source

2016-02-20 Thread Caolán McNamara
 distro-configs/Jenkins/Linux_ubsan_master.conf |1 -
 include/vcl/menubtn.hxx|2 +-
 qadevOOo/runner/base/java_fat.java |6 +-
 vcl/source/control/menubtn.cxx |6 --
 4 files changed, 6 insertions(+), 9 deletions(-)

New commits:
commit 05618e74c77658da76f467a1ab328cb310a19e84
Author: Caolán McNamara 
Date:   Sat Feb 20 20:54:04 2016 +

packagekit is implied by dbus now

Change-Id: Ic29f55a846c48a3ddb6151d60e612d6b35a0ef3a

diff --git a/distro-configs/Jenkins/Linux_ubsan_master.conf 
b/distro-configs/Jenkins/Linux_ubsan_master.conf
index 0c23236..bcb3c24 100644
--- a/distro-configs/Jenkins/Linux_ubsan_master.conf
+++ b/distro-configs/Jenkins/Linux_ubsan_master.conf
@@ -23,7 +23,6 @@
 --enable-extra-sample
 --enable-extra-template
 --enable-gstreamer-1-0
---enable-packagekit
 --enable-python=fully-internal
 --enable-release-build
 --enable-vlc
commit 60bb689cd43ea89b4e1886d0f2a15ef366c6dce8
Author: Caolán McNamara 
Date:   Sat Feb 20 20:51:43 2016 +

StarOffice 5.1 was released in 1999, fixing this now

Change-Id: I0b6bf947f7d309820334ed1ac6eae5a29b5c69fb

diff --git a/include/vcl/menubtn.hxx b/include/vcl/menubtn.hxx
index d7dead7..5f791cb 100644
--- a/include/vcl/menubtn.hxx
+++ b/include/vcl/menubtn.hxx
@@ -66,7 +66,7 @@ public:
 
 voidExecuteMenu();
 
-voidSetMenuMode( sal_uInt16 nMode );
+voidSetMenuMode(sal_uInt16 nMode) { mnMenuMode = nMode; }
 
 voidSetPopupMenu( PopupMenu* pNewMenu );
 PopupMenu*  GetPopupMenu() const { return mpMenu; }
diff --git a/vcl/source/control/menubtn.cxx b/vcl/source/control/menubtn.cxx
index 773d439..9863950 100644
--- a/vcl/source/control/menubtn.cxx
+++ b/vcl/source/control/menubtn.cxx
@@ -160,12 +160,6 @@ void MenuButton::Select()
 maSelectHdl.Call( this );
 }
 
-void MenuButton::SetMenuMode( sal_uInt16 nMode )
-{
-// FIXME: It's better to not inline this for 5.1; in 6.0 we can make it 
inline, however
-mnMenuMode = nMode;
-}
-
 void MenuButton::SetPopupMenu( PopupMenu* pNewMenu )
 {
 if (pNewMenu == mpMenu)
commit f14628438d70f621a48e5ab00a4fa76e8229d831
Author: Caolán McNamara 
Date:   Sat Feb 20 20:42:45 2016 +

coverity#1326436 Dereference null return value

Change-Id: I40f73b48757e81ac4e1b5374bef4fea334ca8d0a

diff --git a/qadevOOo/runner/base/java_fat.java 
b/qadevOOo/runner/base/java_fat.java
index a0426fd..2fa1d05 100644
--- a/qadevOOo/runner/base/java_fat.java
+++ b/qadevOOo/runner/base/java_fat.java
@@ -360,7 +360,11 @@ public class java_fat implements TestBase {
 
 try {
 tCase.initializeTestCase(param);
-return tCase.getTestEnvironment(param);
+TestEnvironment tEnv = tCase.getTestEnvironment(param);
+if (tEnv == null) {
+throw new Exception("Could not get env for '" + 
entry.entryName + "'");
+}
+return tEnv;
 } catch (com.sun.star.lang.DisposedException de) {
 System.out.println("Office disposed");
 closeExistingOffice();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/protocol.txt

2016-02-20 Thread Henry Castro
 loolwsd/ChildProcessSession.cpp |1 +
 loolwsd/protocol.txt|   12 
 2 files changed, 13 insertions(+)

New commits:
commit c2413998be2bf2980f2e27a591a450d67005dfd5
Author: Henry Castro 
Date:   Sat Feb 20 16:45:40 2016 -0400

loolwsd: add partscountchanged protocol

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 5bfd320..d503695 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -244,6 +244,7 @@ public:
 }
 break;
 case LOK_CALLBACK_PARTS_COUNT_CHANGED:
+_session.sendTextFrame("partscountchanged: " + rPayload);
 break;
 }
 }
diff --git a/loolwsd/protocol.txt b/loolwsd/protocol.txt
index 3b35bde..cf08bb4 100644
--- a/loolwsd/protocol.txt
+++ b/loolwsd/protocol.txt
@@ -235,6 +235,18 @@ unocommandresult: 
 Callback that an UNO command has finished.
 See LOK_CALLBACK_UNO_COMMAND_RESULT for details.
 
+partscountchanged: action= part=
+
+Callback action performed:
+
+PartInserted. The document parts has changed by the action
+Insert.
+
+PartDeleted. The document parts has changed by the action
+Delete.
+
+ The index of the part 
+
 child -> parent
 ===
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 71/de3699a30267d989ef78096477d9ecca329974

2016-02-20 Thread Caolán McNamara
 71/de3699a30267d989ef78096477d9ecca329974 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 0bdcdc5b3bdbbfb02aa6b7eae8e6cae13e8f2de8
Author: Caolán McNamara 
Date:   Sat Feb 20 20:30:03 2016 +

Notes added by 'git notes add'

diff --git a/71/de3699a30267d989ef78096477d9ecca329974 
b/71/de3699a30267d989ef78096477d9ecca329974
new file mode 100644
index 000..8a2345e
--- /dev/null
+++ b/71/de3699a30267d989ef78096477d9ecca329974
@@ -0,0 +1 @@
+ignore: fixed
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - sd/qa sd/source

2016-02-20 Thread Henry Castro
 sd/qa/unit/tiledrendering/tiledrendering.cxx|   72 
 sd/source/core/drawdoc2.cxx |   26 +
 sd/source/ui/inc/SlideSorterViewShell.hxx   |3 
 sd/source/ui/inc/ViewShell.hxx  |3 
 sd/source/ui/slidesorter/inc/model/SlideSorterModel.hxx |4 
 sd/source/ui/slidesorter/model/SlideSorterModel.cxx |   36 +---
 6 files changed, 56 insertions(+), 88 deletions(-)

New commits:
commit c6fe577cc579cc0ae5f0a7d63bc86b1718eddeeb
Author: Henry Castro 
Date:   Sat Feb 20 09:57:52 2016 -0400

sd lok: re-work LOK_CALLBACK_PARTS_COUNT_CHANGED callback

In the tiled rendering case, slide sorted view is not created.

This revert some portion commit 80d7c5859b9e7a834a915d7e8bbbe9bc2130108a

Change-Id: Ifc2b7535f36ca69268de3e462bdd50ade9ec3853
Reviewed-on: https://gerrit.libreoffice.org/22542
Tested-by: Jenkins 
Reviewed-by: Henry Castro 

diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx 
b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index 0c037f8..8d19021 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -31,9 +31,6 @@
 #include 
 #include 
 
-#include 
-#include 
-#include 
 #include 
 #include 
 #include 
@@ -55,7 +52,7 @@ public:
 virtual void tearDown() SAL_OVERRIDE;
 
 #if !defined(WNT) && !defined(MACOSX)
-void testInsertPage();
+void testInsertDeletePage();
 void testRegisterCallback();
 void testPostKeyEvent();
 void testPostMouseEvent();
@@ -72,7 +69,7 @@ public:
 
 CPPUNIT_TEST_SUITE(SdTiledRenderingTest);
 #if !defined(WNT) && !defined(MACOSX)
-CPPUNIT_TEST(testInsertPage);
+CPPUNIT_TEST(testInsertDeletePage);
 CPPUNIT_TEST(testRegisterCallback);
 CPPUNIT_TEST(testPostKeyEvent);
 CPPUNIT_TEST(testPostMouseEvent);
@@ -518,95 +515,67 @@ void SdTiledRenderingTest::testSearchAllFollowedBySearch()
 CPPUNIT_ASSERT_EQUAL(OString("match"), 
pXImpressDocument->getTextSelection("text/plain;charset=utf-8", aUsedFormat));
 }
 
-void SdTiledRenderingTest::testInsertPage()
+void SdTiledRenderingTest::testInsertDeletePage()
 {
-uno::Sequence aFilterOptions;
-uno::Reference xLoader(mxDesktop, uno::UNO_QUERY);
-CPPUNIT_ASSERT(xLoader.is());
-
-uno::Reference xComponent;
-xComponent = xLoader->loadComponentFromURL(
-getURLFromSrc(DATA_DIRECTORY) + OUString("insert-delete.odp"),
-"_blank",
-0,
-aFilterOptions);
-CPPUNIT_ASSERT(xComponent.is());
-
-SfxObjectShell* pFoundShell = 
SfxObjectShell::GetShellFromComponent(xComponent);
-CPPUNIT_ASSERT(pFoundShell);
-
-::sd::DrawDocShell* xDocSh = dynamic_cast(pFoundShell);
-CPPUNIT_ASSERT(xDocSh);
-
-sd::ViewShell* pViewShell = xDocSh->GetViewShell();
-CPPUNIT_ASSERT(pViewShell);
-
-Application::Reschedule(true);
-Scheduler::ProcessTaskScheduling(true);
-sd::slidesorter::SlideSorterViewShell* pSSVS =
-
sd::slidesorter::SlideSorterViewShell::GetSlideSorter(pViewShell->GetViewShellBase());
-CPPUNIT_ASSERT(pSSVS);
-
 comphelper::LibreOfficeKit::setActive();
-SdXImpressDocument* pXImpressDocument = 
SdXImpressDocument::getImplementation(xDocSh->GetModel());
-CPPUNIT_ASSERT(pXImpressDocument);
+SdXImpressDocument* pXImpressDocument = createDoc("insert-delete.odp");
+pXImpressDocument->registerCallback(&SdTiledRenderingTest::callback, this);
+
 SdDrawDocument *pDoc = pXImpressDocument->GetDocShell()->GetDoc();
 CPPUNIT_ASSERT(pDoc);
 
 // the document has 1 slide
 CPPUNIT_ASSERT(pDoc->GetSdPageCount(PK_STANDARD) == 1);
 
-pXImpressDocument->registerCallback(&SdTiledRenderingTest::callback, this);
-
 uno::Sequence aArgs;
 
 // Insert slides
-for(unsigned nIterator=1; nIterator <= 10; nIterator++)
+for(unsigned it = 1; it <= 10; it++)
 comphelper::dispatchCommand(".uno:InsertPage", aArgs);
 
 // Verify inserted slides
-for(unsigned nIterator=0; nIterator < m_aPageList.size(); nIterator++)
+for(auto i: m_aPageList)
 {
-SdPage* pPage = pDoc->GetSdPage(m_aPageList[nIterator], PK_STANDARD);
+SdPage* pPage = pDoc->GetSdPage(i, PK_STANDARD);
 CPPUNIT_ASSERT(pPage);
 }
 
 m_aPageList.clear();
 
 // Delete slides
-for(unsigned nIterator=1; nIterator <= 10; nIterator++)
+for(unsigned it = 1; it <= 10; it++)
 comphelper::dispatchCommand(".uno:DeletePage", aArgs);
 
 // Verify deleted slides
-for(unsigned nIterator=0; nIterator < m_aPageList.size(); nIterator++)
+for(auto i: m_aPageList)
 {
-SdPage* pPage = pDoc->GetSdPage(m_aPageList[nIterator], PK_STANDARD);
+SdPage* pPage = pDoc->GetSdPage(i, PK_STANDARD);
 CPPUNIT_ASSERT(pPage == nullptr);
 }
 
 m_aPageList.clear();
 
 // Undo deleted slides
-for(unsigned nIterator=1; nIterator <= 10; nIterator++)
+

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 98/25e795eca5a633a169e8e8511b9215be102762

2016-02-20 Thread Caolán McNamara
 98/25e795eca5a633a169e8e8511b9215be102762 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 58511fc2846a1aa0d82d6e05eddc87df4eff3b12
Author: Caolán McNamara 
Date:   Sat Feb 20 20:22:58 2016 +

Notes added by 'git notes add'

diff --git a/98/25e795eca5a633a169e8e8511b9215be102762 
b/98/25e795eca5a633a169e8e8511b9215be102762
new file mode 100644
index 000..8ebbe55
--- /dev/null
+++ b/98/25e795eca5a633a169e8e8511b9215be102762
@@ -0,0 +1 @@
+ignore: obsolete
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - bc/f075eb572f1595b0144097877ad787e16edf99

2016-02-20 Thread Caolán McNamara
 bc/f075eb572f1595b0144097877ad787e16edf99 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 0562f0a35db4f5ea2738b5b9e8746064fd594997
Author: Caolán McNamara 
Date:   Sat Feb 20 20:22:16 2016 +

Notes added by 'git notes add'

diff --git a/bc/f075eb572f1595b0144097877ad787e16edf99 
b/bc/f075eb572f1595b0144097877ad787e16edf99
new file mode 100644
index 000..8ebbe55
--- /dev/null
+++ b/bc/f075eb572f1595b0144097877ad787e16edf99
@@ -0,0 +1 @@
+ignore: obsolete
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: configure.ac

2016-02-20 Thread Thorsten Behrens
 configure.ac |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit c37c82319f88e75ba28fd4b7bf26b5ea01846c17
Author: Thorsten Behrens 
Date:   Sat Feb 20 19:05:16 2016 +0100

wget: don't break on CentOS6 baseline

Where this fancy new no-use-server-timestamps is not yet known.

Change-Id: I481c44bb977620400a3dede6191889bbbe5ec74a
Reviewed-on: https://gerrit.libreoffice.org/22546
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/configure.ac b/configure.ac
index b6f6f37..0a200e6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -12010,9 +12010,9 @@ if test "$enable_fetch_external" != "no"; then
 CURL=`which curl 2>/dev/null`
 
 for i in wget /usr/bin/wget /usr/local/bin/wget /usr/sfw/bin/wget 
/opt/sfw/bin/wget /opt/local/bin/wget; do
-eval "$i --version" > /dev/null 2>&1
-ret=$?
-if test $ret -eq 0; then
+# wget new enough?
+$i --help 2> /dev/null | $GREP no-use-server-timestamps 2>&1 > /dev/null
+if test $? -eq 0; then
 WGET=$i
 break
 fi
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: stoc/source

2016-02-20 Thread Caolán McNamara
 stoc/source/inspect/introspection.cxx |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit f92f7efead4d6d41955a3e14aa2fc20f95ac
Author: Caolán McNamara 
Date:   Sat Feb 20 20:17:51 2016 +

coverity#1353440 Argument cannot be negative

Change-Id: I0576264c006a70a6783e31fb77b380928558cf45

diff --git a/stoc/source/inspect/introspection.cxx 
b/stoc/source/inspect/introspection.cxx
index 80e742d..67a7095 100644
--- a/stoc/source/inspect/introspection.cxx
+++ b/stoc/source/inspect/introspection.cxx
@@ -335,7 +335,7 @@ sal_Int32 IntrospectionAccessStatic_Impl::getMethodIndex( 
const OUString& aMetho
 // Could be the right method, type has to be checked
 iHashResult = (*aIt).second;
 
-const Reference xMethod = maAllMethodSeq[ 
iHashResult ];
+const Reference xMethod = 
maAllMethodSeq.at(iHashResult);
 
 Reference< XIdlClass > xMethClass = 
xMethod->getDeclaringClass();
 if( xClass->equals( xMethClass ) )
@@ -348,8 +348,8 @@ sal_Int32 IntrospectionAccessStatic_Impl::getMethodIndex( 
const OUString& aMetho
 
 // Could also be another method with the same name
 // Iterate over all methods
-sal_Int32 nLen = (sal_Int32)maAllMethodSeq.size();
-for( int i = 0 ; i < nLen ; ++i )
+size_t nLen = maAllMethodSeq.size();
+for (size_t i = 0; i < nLen; ++i)
 {
 const Reference xMethod2 = 
maAllMethodSeq[ i ];
 if( xMethod2->getName() == aPureMethodName )
@@ -2380,7 +2380,7 @@ css::uno::Reference 
Implementation::inspect(
 {
 sal_Int32 iHashResult = (*aIt).second;
 
-Reference xExistingMethod = 
pAccess->maAllMethodSeq[ iHashResult ];
+Reference xExistingMethod = 
pAccess->maAllMethodSeq.at(iHashResult);
 
 Reference< XIdlClass > xExistingMethClass =
 xExistingMethod->getDeclaringClass();
@@ -2389,7 +2389,7 @@ css::uno::Reference 
Implementation::inspect(
 continue;
 }
 
-pAccess->maAllMethodSeq[ iAllExportedMethod ] = 
rxMethod;
+pAccess->maAllMethodSeq.at(iAllExportedMethod) = 
rxMethod;
 
 // If a concept has been set, is the method 
"normal"?
 sal_Int32& rMethodConcept_i = 
pLocalMethodConcepts[ i ];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: XSLT help

2016-02-20 Thread Olivier Hallot
Hi Regina

Em 20/02/2016 10:14, Regina Henschel escreveu:
> Hi Olivier,
> 
> Olivier Hallot schrieb:
(snip)

> 
> Do you look for an "elegant solution" or do you look for a solution at all?

As short as the one exisitng, but that will not happen, I think.

> 
> Browser Seamonkey 2.39 has no problem with attribute
> 'disable-output-escaping'.

In firefox this attribute is inocuous, and googling around, it is said
it will not be implemented.

> 
> What is your global goal?
- Learn xslt
- display xhp pages in browser for quick view.

Kind regards

-- 
Olivier Hallot
Comunidade LibreOffice
http://ask.libreoffice.org/pt-br
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 2 commits - include/unotools sc/inc sc/source

2016-02-20 Thread Eike Rathke
 include/unotools/textsearch.hxx  |   15 ---
 sc/inc/docoptio.hxx  |   36 +---
 sc/source/core/tool/docoptio.cxx |2 ++
 3 files changed, 43 insertions(+), 10 deletions(-)

New commits:
commit 49d289475167ab21682bc8dbf26a7f67d5902ded
Author: Eike Rathke 
Date:   Sat Feb 20 18:41:11 2016 +0100

let ConvertToSearchType() also adapt the regex bool, tdf#72196

Change-Id: I6d9c438873f3f26418e6b27884207106ccaea148

diff --git a/include/unotools/textsearch.hxx b/include/unotools/textsearch.hxx
index 67c440a..07d2527 100644
--- a/include/unotools/textsearch.hxx
+++ b/include/unotools/textsearch.hxx
@@ -50,11 +50,20 @@ public:
 enum SearchType{ SRCH_NORMAL, SRCH_REGEXP, SRCH_LEVDIST, SRCH_WILDCARD };
 
 /** Convert configuration and document boolean settings to SearchType.
-If bWildcard is true it takes precedence over bRegExp.
+If bWildcard is true it takes precedence over rbRegExp.
+@param  rbRegExp
+If true and bWildcard is also true, rbRegExp is set to false to
+adapt the caller's settings.
  */
-static SearchType ConvertToSearchType( bool bWildcard, bool bRegExp )
+static SearchType ConvertToSearchType( bool bWildcard, bool & rbRegExp )
 {
-return bWildcard ? SRCH_WILDCARD : (bRegExp ? SRCH_REGEXP : 
SRCH_NORMAL);
+if (bWildcard)
+{
+if (rbRegExp)
+rbRegExp = false;
+return SRCH_WILDCARD;
+}
+return rbRegExp ? SRCH_REGEXP : SRCH_NORMAL;
 }
 
 /** Convert SearchType to configuration and document boolean settings.
diff --git a/sc/inc/docoptio.hxx b/sc/inc/docoptio.hxx
index 9335394..a5f3bbf 100644
--- a/sc/inc/docoptio.hxx
+++ b/sc/inc/docoptio.hxx
@@ -98,12 +98,7 @@ public:
 utl::SearchParam::SearchType GetFormulaSearchType() const
 {
 if (eFormulaSearchType == eSearchTypeUnknown)
-{
 eFormulaSearchType = utl::SearchParam::ConvertToSearchType( 
bFormulaWildcardsEnabled, bFormulaRegexEnabled);
-if (bFormulaWildcardsEnabled && bFormulaRegexEnabled)
-// Mutually exclusive, straighten out.
-bFormulaRegexEnabled = false;
-}
 return eFormulaSearchType;
 }
 
commit 1b6b4ffbd9608eff245deb87da5f193f5d955e51
Author: Eike Rathke 
Date:   Sat Feb 20 18:34:44 2016 +0100

implement wildcards precedence at ScDocOptions, tdf#72196

Change-Id: I3a8f880479ee2d0621e10b3c9d405948cadabeaf

diff --git a/sc/inc/docoptio.hxx b/sc/inc/docoptio.hxx
index cd7effa..9335394 100644
--- a/sc/inc/docoptio.hxx
+++ b/sc/inc/docoptio.hxx
@@ -21,6 +21,7 @@
 #define INCLUDED_SC_INC_DOCOPTIO_HXX
 
 #include 
+#include 
 #include 
 #include 
 #include "scdllapi.h"
@@ -39,15 +40,19 @@ class SC_DLLPUBLIC ScDocOptions
 sal_uInt16 nYear;
 sal_uInt16 nYear2000;   ///< earlier 19YY is assumed, 20YY 
otherwise (if only YY of year is given)
 sal_uInt16 nTabDistance;///< distance of standard tabs
+mutable utl::SearchParam::SearchType eFormulaSearchType; ///< wildcards or 
regular expressions or normal search
 bool   bIsIgnoreCase;   ///< ignore case for comparisons?
 bool   bIsIter; ///< iterations for circular refs
 bool   bCalcAsShown;///< calculate as shown (wrt precision)
 bool   bMatchWholeCell; ///< search criteria must match the 
whole cell
 bool   bDoAutoSpell;///< auto-spelling
 bool   bLookUpColRowNames;  ///< determine column-/row titles 
automagically
-bool   bFormulaRegexEnabled;///< regular expressions in formulas 
enabled
-bool   bFormulaWildcardsEnabled;///< wildcards in formulas enabled
+mutable bool bFormulaRegexEnabled;///< regular expressions in formulas 
enabled, only when reading settings
+mutable bool bFormulaWildcardsEnabled;///< wildcards in formulas enabled, 
only when reading settings
 bool   bWriteCalcConfig;///< (subset of) Calc config will be 
written to user's profile
+
+const utl::SearchParam::SearchType eSearchTypeUnknown = 
static_cast(-1);
+
 public:
 ScDocOptions();
 ScDocOptions( const ScDocOptions& rCpy );
@@ -90,11 +95,31 @@ public:
 voidSetYear2000( sal_uInt16 nVal )  { nYear2000 = nVal; }
 sal_uInt16  GetYear2000() const { return nYear2000; }
 
-voidSetFormulaRegexEnabled( bool bVal ) { bFormulaRegexEnabled = bVal; 
}
-boolIsFormulaRegexEnabled() const   { return bFormulaRegexEnabled; 
}
-
-voidSetFormulaWildcardsEnabled( bool bVal ) { bFormulaWildcardsEnabled 
= bVal; }
-boolIsFormulaWildcardsEnabled() const   { return 
bFormulaWildcardsEnabled; }
+utl::SearchParam::SearchType GetFormulaSearchType() const
+{
+if (eFormulaSearchType == eSearchTypeUnknown)
+{
+

[Libreoffice-commits] core.git: sd/qa sd/source

2016-02-20 Thread Henry Castro
 sd/qa/unit/tiledrendering/tiledrendering.cxx|   62 ++--
 sd/source/core/drawdoc2.cxx |   26 ++
 sd/source/ui/slidesorter/inc/model/SlideSorterModel.hxx |4 -
 sd/source/ui/slidesorter/model/SlideSorterModel.cxx |   36 ++---
 4 files changed, 46 insertions(+), 82 deletions(-)

New commits:
commit 286adeb032df8ab30930b6f76f75b342a3fa314b
Author: Henry Castro 
Date:   Sat Feb 20 09:57:52 2016 -0400

sd lok: re-work LOK_CALLBACK_PARTS_COUNT_CHANGED callback

In the tiled rendering case, slide sorted view is not created.

This revert some portion commit 80d7c5859b9e7a834a915d7e8bbbe9bc2130108a

Change-Id: Ifc2b7535f36ca69268de3e462bdd50ade9ec3853
Reviewed-on: https://gerrit.libreoffice.org/22542
Tested-by: Jenkins 
Reviewed-by: Henry Castro 

diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx 
b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index 9554251..baeb36b 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -25,9 +25,6 @@
 #include 
 #include 
 
-#include 
-#include 
-#include 
 #include 
 #include 
 #include 
@@ -48,7 +45,7 @@ public:
 virtual void tearDown() override;
 
 #if !defined(_WIN32) && !defined(MACOSX)
-void testInsertPage();
+void testInsertDeletePage();
 void testRegisterCallback();
 void testPostKeyEvent();
 void testPostMouseEvent();
@@ -65,7 +62,7 @@ public:
 
 CPPUNIT_TEST_SUITE(SdTiledRenderingTest);
 #if !defined(_WIN32) && !defined(MACOSX)
-CPPUNIT_TEST(testInsertPage);
+CPPUNIT_TEST(testInsertDeletePage);
 CPPUNIT_TEST(testRegisterCallback);
 CPPUNIT_TEST(testPostKeyEvent);
 CPPUNIT_TEST(testPostMouseEvent);
@@ -519,56 +516,22 @@ void SdTiledRenderingTest::testSearchAllFollowedBySearch()
 CPPUNIT_ASSERT_EQUAL(OString("match"), 
pXImpressDocument->getTextSelection("text/plain;charset=utf-8", aUsedFormat));
 }
 
-void SdTiledRenderingTest::testInsertPage()
+void SdTiledRenderingTest::testInsertDeletePage()
 {
-uno::Sequence aFilterOptions;
-uno::Reference xLoader(mxDesktop, uno::UNO_QUERY);
-CPPUNIT_ASSERT(xLoader.is());
-
-uno::Reference xComponent;
-xComponent = xLoader->loadComponentFromURL(
-getURLFromSrc(DATA_DIRECTORY) + "insert-delete.odp",
-"_blank",
-0,
-aFilterOptions);
-CPPUNIT_ASSERT(xComponent.is());
-
-SfxObjectShell* pFoundShell = 
SfxObjectShell::GetShellFromComponent(xComponent);
-CPPUNIT_ASSERT(pFoundShell);
-
-::sd::DrawDocShell* xDocSh = dynamic_cast(pFoundShell);
-CPPUNIT_ASSERT(xDocSh);
-
-sd::ViewShell* pViewShell = xDocSh->GetViewShell();
-CPPUNIT_ASSERT(pViewShell);
-
-sd::slidesorter::SlideSorterViewShell* pSSVS = nullptr;
-for (int i = 0; i < 1000; i++)
-{
-// Process all Tasks - slide sorter is created here
-while (Scheduler::ProcessTaskScheduling(true));
-if ((pSSVS = 
sd::slidesorter::SlideSorterViewShell::GetSlideSorter(pViewShell->GetViewShellBase()))
 != nullptr)
-break;
-TimeValue aSleep(0, 100 * 100); // 100 msec
-osl::Thread::wait(aSleep);
-}
-CPPUNIT_ASSERT(pSSVS);
-
 comphelper::LibreOfficeKit::setActive();
-SdXImpressDocument* pXImpressDocument = 
SdXImpressDocument::getImplementation(xDocSh->GetModel());
-CPPUNIT_ASSERT(pXImpressDocument);
+SdXImpressDocument* pXImpressDocument = createDoc("insert-delete.odp");
+pXImpressDocument->registerCallback(&SdTiledRenderingTest::callback, this);
+
 SdDrawDocument *pDoc = pXImpressDocument->GetDocShell()->GetDoc();
 CPPUNIT_ASSERT(pDoc);
 
 // the document has 1 slide
 CPPUNIT_ASSERT(pDoc->GetSdPageCount(PK_STANDARD) == 1);
 
-pXImpressDocument->registerCallback(&SdTiledRenderingTest::callback, this);
-
 uno::Sequence aArgs;
 
 // Insert slides
-for(unsigned nIterator=1; nIterator <= 10; nIterator++)
+for(unsigned it = 1; it <= 10; it++)
 comphelper::dispatchCommand(".uno:InsertPage", aArgs);
 
 // Verify inserted slides
@@ -581,7 +544,7 @@ void SdTiledRenderingTest::testInsertPage()
 m_aPageList.clear();
 
 // Delete slides
-for(unsigned nIterator=1; nIterator <= 10; nIterator++)
+for(unsigned it = 1; it <= 10; it++)
 comphelper::dispatchCommand(".uno:DeletePage", aArgs);
 
 // Verify deleted slides
@@ -594,7 +557,7 @@ void SdTiledRenderingTest::testInsertPage()
 m_aPageList.clear();
 
 // Undo deleted slides
-for(unsigned nIterator=1; nIterator <= 10; nIterator++)
+for(unsigned it = 1; it <= 10; it++)
 comphelper::dispatchCommand(".uno:Undo", aArgs);
 
 // Verify inserted slides
@@ -607,7 +570,7 @@ void SdTiledRenderingTest::testInsertPage()
 m_aPageList.clear();
 
 // Redo deleted slides
-for(unsigned nIterator=1; nIterator <= 10; nIterator++)
+for(unsigned it = 1; it <= 10; it++)
 c

New Defects reported by Coverity Scan for LibreOffice

2016-02-20 Thread scan-admin

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
38 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1353440:(REVERSE_NEGATIVE)
/stoc/source/inspect/introspection.cxx: 367 in 
::IntrospectionAccessStatic_Impl::getMethodIndex(const rtl::OUString 
&) const()
/stoc/source/inspect/introspection.cxx: 367 in 
::IntrospectionAccessStatic_Impl::getMethodIndex(const rtl::OUString 
&) const()



*** CID 1353440:(REVERSE_NEGATIVE)
/stoc/source/inspect/introspection.cxx: 367 in 
::IntrospectionAccessStatic_Impl::getMethodIndex(const rtl::OUString 
&) const()
361 iHashResult = i;
362 break;
363 }
364 }
365 }
366 
>>> CID 1353440:(REVERSE_NEGATIVE)
>>> You might be using variable "iHashResult" before verifying that it is 
>>> >= 0.
367 if( iHashResult != -1 )
368 break;
369 }
370 }
371 }
372 
/stoc/source/inspect/introspection.cxx: 367 in 
::IntrospectionAccessStatic_Impl::getMethodIndex(const rtl::OUString 
&) const()
361 iHashResult = i;
362 break;
363 }
364 }
365 }
366 
>>> CID 1353440:(REVERSE_NEGATIVE)
>>> You might be using variable "iHashResult" before verifying that it is 
>>> >= 0.
367 if( iHashResult != -1 )
368 break;
369 }
370 }
371 }
372 

** CID 1353439:  Possible Control flow issues  (DEADCODE)
/sc/source/core/tool/interpr1.cxx: 8542 in 
ScInterpreter::DetectSearchType(const rtl::OUString &, const ScDocument *)()



*** CID 1353439:  Possible Control flow issues  (DEADCODE)
/sc/source/core/tool/interpr1.cxx: 8542 in 
ScInterpreter::DetectSearchType(const rtl::OUString &, const ScDocument *)()
8536 utl::SearchParam::SearchType ScInterpreter::DetectSearchType( const 
OUString& rStr, const ScDocument* pDoc )
8537 {
8538 if (pDoc)
8539 {
8540 bool bWildcardEnabled = false;  /* TODO: obtain doc option */
8541 if (bWildcardEnabled)
>>> CID 1353439:  Possible Control flow issues  (DEADCODE)
>>> Execution cannot reach the expression 
>>> "ScInterpreter::MayBeWildcard(rStr, NULL)" inside this statement: "return 
>>> ScInterpreter::MayBe...".
8542 return MayBeWildcard( rStr, nullptr) ? 
utl::SearchParam::SRCH_WILDCARD : utl::SearchParam::SRCH_NORMAL;
8543 if (pDoc->GetDocOptions().IsFormulaRegexEnabled())
8544 return MayBeRegExp( rStr, nullptr) ? 
utl::SearchParam::SRCH_REGEXP : utl::SearchParam::SRCH_NORMAL;
8545 }
8546 else
8547 {

** CID 1353438:  Control flow issues  (DEADCODE)
/idl/source/prj/parser.cxx: 429 in 
SvIdlParser::ReadInterfaceOrShellMethodOrAttribute(SvMetaAttribute &)()



*** CID 1353438:  Control flow issues  (DEADCODE)
/idl/source/prj/parser.cxx: 429 in 
SvIdlParser::ReadInterfaceOrShellMethodOrAttribute(SvMetaAttribute &)()
423 if( bOk && ReadIf( '[' ) )
424 {
425 Read( ']' );
426 }
427 
428 if( !bOk )
>>> CID 1353438:  Control flow issues  (DEADCODE)
>>> Execution cannot reach this statement: "this->rInStm->Seek(nTokPos);".
429 rInStm.Seek( nTokPos );
430 return bOk;
431 }
432 
433 SvMetaClass * SvIdlParser::ReadKnownClass()
434 {



To view the defects in Coverity Scan visit, 
https://scan.coverity.com/projects/libreoffice?tab=overview

To manage Coverity Scan email notifications for 
"libreoffice@lists.freedesktop.org", click 
https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: framework/source

2016-02-20 Thread irem
 framework/source/uifactory/uielementfactorymanager.cxx |7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

New commits:
commit 4bb148e74495b02f65483bd460cab762114177ea
Author: irem 
Date:   Tue Feb 2 17:28:32 2016 +0200

tdf#57950 Replace chained O(U)StringBuffer::append() with operator+

Change-Id: I6e428222bfb3045b6a379716586aa5e37a3cae35
Reviewed-on: https://gerrit.libreoffice.org/22052
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/framework/source/uifactory/uielementfactorymanager.cxx 
b/framework/source/uifactory/uielementfactorymanager.cxx
index 23c68f8..dea4253 100644
--- a/framework/source/uifactory/uielementfactorymanager.cxx
+++ b/framework/source/uifactory/uielementfactorymanager.cxx
@@ -56,12 +56,7 @@ namespace framework
 // global function needed by both implementations
 static OUString getHashKeyFromStrings( const OUString& aType, const OUString& 
aName, const OUString& aModuleName )
 {
-OUStringBuffer aKey( aType );
-aKey.append( "^" );
-aKey.append( aName );
-aKey.append( "^" );
-aKey.append( aModuleName );
-return aKey.makeStringAndClear();
+return aType + "^" + aName + "^" + aModuleName;
 }
 
 ConfigurationAccess_FactoryManager::ConfigurationAccess_FactoryManager( const 
Reference< XComponentContext >& rxContext, const OUString& _sRoot ) :
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Are vcl Global Shortcuts and localized accelerators diverging?

2016-02-20 Thread V Stuart Foote
Hey "Devs", 

Please excuse me for poking in here out of turn... 

But, seems like there is some divergence and loss of function for Global
short-cuts as defined in  keycod.cxx
  
and behavior of Accelerators assigned in Accelerators.xcu

A bit unclear to me what the hierarchy is supposed to resolve, but it seems
like some of the vcl assigned short-cuts are becoming non-functional in
elements of the GUI.   It seems like assignments Global or per Module made
in Accelerators.xcu for function or localization assert, but that actions on
the Main menu do not.

Are short-cuts on the menu drawn from vcl? Or do they have to be fully
assigned in the .xcu?  And are they?

And, is there some OpenGL context or GTK+3 facet to some of this apparent
loss of short-cut control of the GUI?

This is kind of an open question--more because I am not sure exactly how
this is supposed to work. So,  rather than opening a specific BZ report, the
selection ref'd below should suffice as examples of what seems to be an
issue.

Stuart

=-ref-=
tdf#92516   
tdf#95410   
tdf#97511   

even   tdf#97942  
, but this is not a vcl assignment--more a mystery as to where the global
went missing in the dialog. 



--
View this message in context: 
http://nabble.documentfoundation.org/Are-vcl-Global-Shortcuts-and-localized-accelerators-diverging-tp4176098.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: icon-themes/galaxy

2016-02-20 Thread Yousuf Philips
 icon-themes/galaxy/cmd/lc_accepttrackedchange.png|binary
 icon-themes/galaxy/cmd/lc_accepttrackedchanges.png   |binary
 icon-themes/galaxy/cmd/lc_commentchangetracking.png  |binary
 icon-themes/galaxy/cmd/lc_comparedocuments.png   |binary
 icon-themes/galaxy/cmd/lc_comparedocuments.xcf.bz2   |binary
 icon-themes/galaxy/cmd/lc_insertbookmark.png |binary
 icon-themes/galaxy/cmd/lc_nexttrackedchange.png  |binary
 icon-themes/galaxy/cmd/lc_previoustrackedchange.png  |binary
 icon-themes/galaxy/cmd/lc_protecttracechangemode.png |binary
 icon-themes/galaxy/cmd/lc_rejecttrackedchange.png|binary
 icon-themes/galaxy/cmd/lc_showtrackedchanges.png |binary
 icon-themes/galaxy/cmd/lc_trackchanges.png   |binary
 icon-themes/galaxy/cmd/lc_trackchangesall.xcf.bz2|binary
 icon-themes/galaxy/cmd/lc_trackchangesbar.png|binary
 icon-themes/galaxy/cmd/lc_webhtml.png|binary
 icon-themes/galaxy/cmd/lc_webhtml.xcf.bz2|binary
 icon-themes/galaxy/cmd/sc_insertbookmark.png |binary
 17 files changed

New commits:
commit 5101743e62980a1f6e1212116d20bbfaf9e86149
Author: Yousuf Philips 
Date:   Fri Feb 19 05:40:51 2016 +0400

Galaxy: Add icons for track changes, bookmark, and browser preview

Change-Id: I11143967720c9cfa310c6a32f679894d15b94204
Reviewed-on: https://gerrit.libreoffice.org/22495
Tested-by: Jenkins 
Reviewed-by: Yousuf Philips 

diff --git a/icon-themes/galaxy/cmd/lc_accepttrackedchange.png 
b/icon-themes/galaxy/cmd/lc_accepttrackedchange.png
index d57502f..8dfd998 100644
Binary files a/icon-themes/galaxy/cmd/lc_accepttrackedchange.png and 
b/icon-themes/galaxy/cmd/lc_accepttrackedchange.png differ
diff --git a/icon-themes/galaxy/cmd/lc_accepttrackedchanges.png 
b/icon-themes/galaxy/cmd/lc_accepttrackedchanges.png
index 7b7b173..71c1301 100644
Binary files a/icon-themes/galaxy/cmd/lc_accepttrackedchanges.png and 
b/icon-themes/galaxy/cmd/lc_accepttrackedchanges.png differ
diff --git a/icon-themes/galaxy/cmd/lc_commentchangetracking.png 
b/icon-themes/galaxy/cmd/lc_commentchangetracking.png
index 8769eed..f846996 100644
Binary files a/icon-themes/galaxy/cmd/lc_commentchangetracking.png and 
b/icon-themes/galaxy/cmd/lc_commentchangetracking.png differ
diff --git a/icon-themes/galaxy/cmd/lc_comparedocuments.png 
b/icon-themes/galaxy/cmd/lc_comparedocuments.png
index 41aad0b..84cc8d2 100644
Binary files a/icon-themes/galaxy/cmd/lc_comparedocuments.png and 
b/icon-themes/galaxy/cmd/lc_comparedocuments.png differ
diff --git a/icon-themes/galaxy/cmd/lc_comparedocuments.xcf.bz2 
b/icon-themes/galaxy/cmd/lc_comparedocuments.xcf.bz2
new file mode 100644
index 000..40112db
Binary files /dev/null and b/icon-themes/galaxy/cmd/lc_comparedocuments.xcf.bz2 
differ
diff --git a/icon-themes/galaxy/cmd/lc_insertbookmark.png 
b/icon-themes/galaxy/cmd/lc_insertbookmark.png
index 83dacab..6507485 100644
Binary files a/icon-themes/galaxy/cmd/lc_insertbookmark.png and 
b/icon-themes/galaxy/cmd/lc_insertbookmark.png differ
diff --git a/icon-themes/galaxy/cmd/lc_nexttrackedchange.png 
b/icon-themes/galaxy/cmd/lc_nexttrackedchange.png
index 41240ac..d668198 100644
Binary files a/icon-themes/galaxy/cmd/lc_nexttrackedchange.png and 
b/icon-themes/galaxy/cmd/lc_nexttrackedchange.png differ
diff --git a/icon-themes/galaxy/cmd/lc_previoustrackedchange.png 
b/icon-themes/galaxy/cmd/lc_previoustrackedchange.png
index c08810e..d232343 100644
Binary files a/icon-themes/galaxy/cmd/lc_previoustrackedchange.png and 
b/icon-themes/galaxy/cmd/lc_previoustrackedchange.png differ
diff --git a/icon-themes/galaxy/cmd/lc_protecttracechangemode.png 
b/icon-themes/galaxy/cmd/lc_protecttracechangemode.png
index 0ec89a7..5aba79f 100644
Binary files a/icon-themes/galaxy/cmd/lc_protecttracechangemode.png and 
b/icon-themes/galaxy/cmd/lc_protecttracechangemode.png differ
diff --git a/icon-themes/galaxy/cmd/lc_rejecttrackedchange.png 
b/icon-themes/galaxy/cmd/lc_rejecttrackedchange.png
index e032af7..ba761c0 100644
Binary files a/icon-themes/galaxy/cmd/lc_rejecttrackedchange.png and 
b/icon-themes/galaxy/cmd/lc_rejecttrackedchange.png differ
diff --git a/icon-themes/galaxy/cmd/lc_showtrackedchanges.png 
b/icon-themes/galaxy/cmd/lc_showtrackedchanges.png
index 77c6a75..e7e460b 100644
Binary files a/icon-themes/galaxy/cmd/lc_showtrackedchanges.png and 
b/icon-themes/galaxy/cmd/lc_showtrackedchanges.png differ
diff --git a/icon-themes/galaxy/cmd/lc_trackchanges.png 
b/icon-themes/galaxy/cmd/lc_trackchanges.png
index 71b7d1a..1923301 100644
Binary files a/icon-themes/galaxy/cmd/lc_trackchanges.png and 
b/icon-themes/galaxy/cmd/lc_trackchanges.png differ
diff --git a/icon-themes/galaxy/cmd/lc_trackchangesall.xcf.bz2 
b/icon-themes/galaxy/cmd/lc_trackchangesall.xcf.bz2
new file mode 100644
index 000..8d2e31c
Binary files /dev/null and b/icon-themes/galaxy/cmd/lc_trackchangesall.xcf.bz2 
differ
diff --git a/icon-themes/galaxy/cmd/lc_trackchangesbar.png 
b/icon-themes/

[Libreoffice-commits] core.git: Branch 'feature/breakpad' - 29 commits - bin/symbolstore.py bin/upload_symbols.py config_host/config_features.h.in config_host.mk.in configure.ac desktop/Executable_min

2016-02-20 Thread Markus Mohrhard
Rebased ref, commits from common ancestor:
commit f2f5b7a3ed2504b93957800875afd6484505aee6
Author: Markus Mohrhard 
Date:   Sun Feb 7 16:21:13 2016 +0100

fix indetation

Change-Id: Iea12f654d737cfdadae99461ff996220fcb7901c

diff --git a/sc/source/filter/lotus/filter.cxx 
b/sc/source/filter/lotus/filter.cxx
index 06e9ba2..bc87806 100644
--- a/sc/source/filter/lotus/filter.cxx
+++ b/sc/source/filter/lotus/filter.cxx
@@ -47,12 +47,12 @@ generate_Opcodes(LotusContext &rContext, SvStream& aStream,
 {
 case eWK_1:
 case eWK_2:
-pOps = rContext.pOpFkt;
-nOps = FKT_LIMIT;
+pOps = rContext.pOpFkt;
+nOps = FKT_LIMIT;
 break;
 case eWK123:
-pOps = rContext.pOpFkt123;
-nOps = FKT_LIMIT123;
+pOps = rContext.pOpFkt123;
+nOps = FKT_LIMIT123;
 break;
 case eWK3:  return eERR_NI;
 case eWK_Error: return eERR_FORMAT;
commit 73587b69902e3d9e79b327a92a9d0af8f987ef19
Author: Markus Mohrhard 
Date:   Wed Feb 3 20:28:40 2016 +0100

tdf#93300, handle hard formatting with cond format correct

For number formats we always applied the conditional format above the
hard formatting.

Now we handle styles, conditional formatting and hard formatting
correctly.

Change-Id: I52dbeeb848b982985d6b17dad920baedffb218e4

diff --git a/sc/source/core/data/patattr.cxx b/sc/source/core/data/patattr.cxx
index eead1a6..fccfb43 100644
--- a/sc/source/core/data/patattr.cxx
+++ b/sc/source/core/data/patattr.cxx
@@ -1291,12 +1291,24 @@ bool ScPatternAttr::IsSymbolFont() const
 return false;
 }
 
+namespace {
+
+sal_uInt32 getNumberFormatKey(const SfxItemSet& rSet)
+{
+return static_cast(rSet.Get(ATTR_VALUE_FORMAT)).GetValue();
+}
+
+LanguageType getLanguageType(const SfxItemSet& rSet)
+{
+return static_cast(rSet.Get(ATTR_LANGUAGE_FORMAT)).GetLanguage();
+}
+
+}
+
 sal_uLong ScPatternAttr::GetNumberFormat( SvNumberFormatter* pFormatter ) const
 {
-sal_uLong nFormat =
-static_cast(&GetItemSet().Get( ATTR_VALUE_FORMAT 
))->GetValue();
-LanguageType eLang =
-static_cast(&GetItemSet().Get( 
ATTR_LANGUAGE_FORMAT ))->GetLanguage();
+sal_uLong nFormat = getNumberFormatKey(GetItemSet());
+LanguageType eLang = getLanguageType(GetItemSet());
 if ( nFormat < SV_COUNTRY_LANGUAGE_OFFSET && eLang == LANGUAGE_SYSTEM )
 ;   // it remains as it is
 else if ( pFormatter )
@@ -1313,17 +1325,33 @@ sal_uLong ScPatternAttr::GetNumberFormat( 
SvNumberFormatter* pFormatter,
 if (!pCondSet)
 return GetNumberFormat(pFormatter);
 
+/* In the case of a conditional format we need to overwrite a cell style
+ * but leave a hard cell formatting alone. So check first if the number
+ * format is set in the cell format, then the conditional format and
+ * finally in the style.
+ *
+ * The style is represented here if the name is empty.
+ */
+
 const SfxPoolItem* pFormItem;
-if ( pCondSet->GetItemState(ATTR_VALUE_FORMAT,true,&pFormItem) != 
SfxItemState::SET )
-pFormItem = &GetItemSet().Get(ATTR_VALUE_FORMAT);
+sal_uLong nFormat = 0;
+if (GetItemSet().GetItemState(ATTR_VALUE_FORMAT, false, &pFormItem) == 
SfxItemState::SET)
+nFormat = static_cast(pFormItem)->GetValue();
+else if (pCondSet->GetItemState(ATTR_VALUE_FORMAT, true, &pFormItem) == 
SfxItemState::SET )
+nFormat = getNumberFormatKey(*pCondSet);
+else
+nFormat = getNumberFormatKey(GetItemSet());
 
 const SfxPoolItem* pLangItem;
-if ( pCondSet->GetItemState(ATTR_LANGUAGE_FORMAT,true,&pLangItem) != 
SfxItemState::SET )
-pLangItem = &GetItemSet().Get(ATTR_LANGUAGE_FORMAT);
+LanguageType eLang;
+if (GetItemSet().GetItemState(ATTR_LANGUAGE_FORMAT, false, &pLangItem) == 
SfxItemState::SET)
+eLang = static_cast(pLangItem)->GetLanguage();
+else if (pCondSet->GetItemState(ATTR_LANGUAGE_FORMAT, true, &pLangItem) == 
SfxItemState::SET)
+eLang = getLanguageType(*pCondSet);
+else
+eLang = getLanguageType(GetItemSet());
 
-return pFormatter->GetFormatForLanguageIfBuiltIn(
-static_cast(pFormItem)->GetValue(),
-static_cast(pLangItem)->GetLanguage() );
+return pFormatter->GetFormatForLanguageIfBuiltIn(nFormat, eLang);
 }
 
 const SfxPoolItem& ScPatternAttr::GetItem( sal_uInt16 nWhich, const 
SfxItemSet& rItemSet, const SfxItemSet* pCondSet )
commit cfd8c58d4750610c018b2af11102ea9fa27e9e16
Author: Markus Mohrhard 
Date:   Wed Feb 3 05:02:41 2016 +0100

simplify code a bit

Change-Id: Iffc3fa3240750892e40393c147acc6ba32cec117

diff --git a/sc/source/core/data/patattr.cxx b/sc/source/core/data/patattr.cxx
index 61d8879..eead1a6 100644
--- a/sc/source/core/data/patattr.cxx
+++ b/sc/source/core/data/patattr.cxx
@@ -1309,14 +1309,16 @@ sal_uLong ScPatternAttr::GetNumberFormat( 
SvNumberForma

[Libreoffice-commits] core.git: 0 commits -

2016-02-20 Thread Henry Castro
Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/README

2016-02-20 Thread Chris Sherlock
 vcl/README |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 1acf8bb1d82414d1fb97adfe6eebfc27a9cd4ae0
Author: Chris Sherlock 
Date:   Sun Feb 21 00:39:30 2016 +1100

vcl: README update - generic was moved some time ago to unx

Change-Id: I463db3f1e0d00fba6e2b83d2e29d381e7df4bd25

diff --git a/vcl/README b/vcl/README
index c162b15..ebf8ee4 100644
--- a/vcl/README
+++ b/vcl/README
@@ -8,9 +8,6 @@ source/
 inc/
+ cross-platform abstraction headers
 
-generic/
-   + shared helper code for *some* of the backends, actually built into 
vcl.
-
 headless/
+ a backend renderer that draws to bitmaps
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-5-1-1' - slideshow/source

2016-02-20 Thread Michael Meeks
 slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx |8 

 1 file changed, 8 insertions(+)

New commits:
commit 8dd8bee8059da1243b20b47349fcd20ebf93df8a
Author: Michael Meeks 
Date:   Thu Feb 11 17:17:28 2016 +

tdf#97197 - GL transitions should use their context not VCL's.

Change-Id: Ifab7da221e73e068ebe0856a4224ec4ca4d611b5
Reviewed-on: https://gerrit.libreoffice.org/22293
Tested-by: Jenkins 
Reviewed-by: Jan Holesovsky 
(cherry picked from commit a00e445565d0cd92b32aef2bca33d054b8da1e45)
Reviewed-on: https://gerrit.libreoffice.org/22294
Reviewed-by: Tomaž Vajngerl 
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git 
a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx 
b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx
index 6aa726b..393675b 100644
--- a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx
+++ b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx
@@ -374,7 +374,9 @@ bool OGLTransitionerImpl::initWindowFromSlideShowView( 
const Reference< presenta
 }
 SAL_INFO("slideshow", "created the context");
 
+mpContext->makeCurrent();
 CHECK_GL_ERROR();
+
 awt::Rectangle aCanvasArea = mxView->getCanvasArea();
 mpContext->setWinPosAndSize(Point(aCanvasArea.X, aCanvasArea.Y), 
Size(aCanvasArea.Width, aCanvasArea.Height));
 SAL_INFO("slideshow.opengl", "canvas area: " << aCanvasArea.X << "," << 
aCanvasArea.Y << " - " << aCanvasArea.Width << "x" << aCanvasArea.Height);
@@ -551,6 +553,9 @@ bool OGLTransitionerImpl::setTransition( 
std::shared_ptr pTra
 
 mpTransition = pTransition;
 
+mpContext->makeCurrent();
+CHECK_GL_ERROR();
+
 bool succeeded = impl_prepareTransition();
 if (!succeeded) {
 mpTransition = nullptr;
@@ -1288,6 +1293,9 @@ void OGLTransitionerImpl::disposeTextures()
 
 void OGLTransitionerImpl::impl_dispose()
 {
+mpContext->makeCurrent();
+CHECK_GL_ERROR();
+
 impl_finishTransition();
 disposeTextures();
 if( mpContext.is() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Remote File Acess

2016-02-20 Thread Jim Cobley

1Mb up & 4Mb down - Remote NAS - LO 5.0.4.2
Using LO was v.slow until I set the temp folder to a local drive - now 
it is "within expectations" for remote file access.

In my case I need the remote lock for multi-system/user access

On startup selecting "File-Recent" takes ages presumably while remote 
files (many) are checked to see if they are there - this is what should 
be spun off. I already know if my network is up or down and if the file 
is likely to have been removed or not so a recent file can still be 
listed as recent. It was initially very unnerving to see many missing 
from the recent list when the Internet link was down at system startup 
(!?@ NFS & Mount)
Better to just be told "Can't find file" when and if an inaccessible 
file is selected but continue to list as recent if it really was.



On 18/02/16 06:22, Steven Howe wrote:

I use DSL. I have 128K bits up, 1 mbits down. This is not uncommon.

Some issue with 'remote' file mode.
1) saving takes forever. The lock state is not good for remote file 
save. Spin that task off. That's what multithreading is for.
2) local temp storage vs network. Use local for recovery. Not everyone 
has gigibit bandwidth. Image I start the program and has to connect to 
google drive to even finish starting up? What If my network is down? 
Local lock files please.


I'd like to type 'ctrl-s' and get back to work, not wait for my Google 
Drive to release me, if ever. I wait minutes the first time I use this 
version. Let that process run in the background. Get back to typing.




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Newcomer to the community, Interested in GSoC 2016

2016-02-20 Thread Satyaki Upadhyay
Hi


My name is Satyaki and I'm a newcomer to the libreoffice community. I want
to contribute to this project. I have been an active participator in
programming contests like ACM-ICPC and on online judges over the last two
years (am comfortable in C++).
Codeforces -http://codeforces.com/profile/satyaki3794
Topcoder -   https://www.topcoder.com/members/satyaki3794/
SPOJ - http://www.spoj.com/users/satyaki3794/


I am new to open source development and want to get involved using Google
Summer of Code 2016. I went through the GSoC ideas page of past editions
and the projects looked fascinating.
Is this org likely to be involved in GSoC 2016? If yes, can someone please
give me some pointers as to how I could get started?



Regards
Satyaki
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Bug 45168 - Add Option to crop (reduce size of) Images in PDF Export

2016-02-20 Thread Dipankar Niranjan
Hi,
Any code pointers on where to look and how to get the changes from
updateGraphicsState() to reflect in the storing of the image..?
Which classes would I have to look at to get the data stored by
updateGraphicsState() ?
Also code pointers to where I should insert UI toggles for this would be
helpful too.

-- 
REGARDS,
DIP
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Bug ?

2016-02-20 Thread T. Nannes

Hi There,

Don't know if this is the right place the report it,
but since version 5.0.4 LibreOfficedoes not generat
the euro-character ( € ) anymore, if you use the keys
Ctrl+Alt+5.
Very anoying.
Don't know if you call this a bug.

Greetings
A. Nannes.


--


smime.p7s
Description: S/MIME-cryptografische ondertekening
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: XSLT help

2016-02-20 Thread Regina Henschel

Hi Olivier,

Olivier Hallot schrieb:

Hi

The expression below is supposed to generate an output like , ,
... depending on the value of $level [1]



However, per [2] the expression will not work for Nestcape 6, and indeed
does not work on Firefox, but work in Rekonq (KHTML engine).

I am running short ideas to output the string '', '' that
overcomes the limitation of firefox on the elegant solution above with
$level

Any ideas appreciated.


Do you look for an "elegant solution" or do you look for a solution at all?

Browser Seamonkey 2.39 has no problem with attribute 
'disable-output-escaping'.


What is your global goal?

Kind regards
Regina


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: sc/source

2016-02-20 Thread Markus Mohrhard
 sc/source/ui/cctrl/checklistmenu.cxx |   27 ++-
 1 file changed, 22 insertions(+), 5 deletions(-)

New commits:
commit 7967e5e51e5210b8c3d3dc63502bd7d875eb36b7
Author: Markus Mohrhard 
Date:   Sat Feb 20 09:29:08 2016 +0100

use O(n) algorithm to change all autofilter entries

Change-Id: Iae80c0c23b15a9c2ba0cd4913d6e22dc4c3a1816
Reviewed-on: https://gerrit.libreoffice.org/22516
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/source/ui/cctrl/checklistmenu.cxx 
b/sc/source/ui/cctrl/checklistmenu.cxx
index 553babd..865fb7b 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -1131,13 +1131,30 @@ void ScCheckListMenuWindow::packWindow()
 void ScCheckListMenuWindow::setAllMemberState(bool bSet)
 {
 size_t n = maMembers.size();
-OUString aLabel;
+std::set maParents;
 for (size_t i = 0; i < n; ++i)
 {
-aLabel = maMembers[i].maName;
-if (aLabel.isEmpty())
-aLabel = ScGlobal::GetRscString(STR_EMPTYDATA);
-maChecks->ShowCheckEntry( aLabel, maMembers[i].mpParent, true, bSet);
+maParents.insert(maMembers[i].mpParent);
+}
+for (auto itr = maParents.begin(), itrEnd = maParents.end(); itr != 
itrEnd; ++itr)
+{
+if (!(*itr))
+{
+sal_uInt16 nCount = maChecks->GetEntryCount();
+for( sal_uInt16 i = 0; i < nCount; ++i)
+{
+SvTreeListEntry* pEntry = maChecks->GetEntry(i);
+maChecks->CheckEntry(pEntry, bSet);
+}
+}
+else
+{
+SvTreeListEntries& rEntries = (*itr)->GetChildEntries();
+for (auto it = rEntries.begin(), itEnd = rEntries.end(); it != 
itEnd; ++ it)
+{
+maChecks->CheckEntry(*itr, bSet);
+}
+}
 }
 
 if (!maConfig.mbAllowEmptySet)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2016-02-20 Thread Markus Mohrhard
 sc/source/ui/cctrl/checklistmenu.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 7381cef88cccd2b35a83cd4842c73e4e69a47547
Author: Markus Mohrhard 
Date:   Sat Feb 20 09:04:53 2016 +0100

use calc brace style

Change-Id: I96d05359308f38d6952137bc0b326505bba47c89
Reviewed-on: https://gerrit.libreoffice.org/22515
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/ui/cctrl/checklistmenu.cxx 
b/sc/source/ui/cctrl/checklistmenu.cxx
index bf1e638..553babd 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -1132,7 +1132,8 @@ void ScCheckListMenuWindow::setAllMemberState(bool bSet)
 {
 size_t n = maMembers.size();
 OUString aLabel;
-for (size_t i = 0; i < n; ++i) {
+for (size_t i = 0; i < n; ++i)
+{
 aLabel = maMembers[i].maName;
 if (aLabel.isEmpty())
 aLabel = ScGlobal::GetRscString(STR_EMPTYDATA);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Problem Building Libreoffice on Linux

2016-02-20 Thread David Tardon
Hi,

On Sat, Feb 20, 2016 at 02:52:45PM +1100, Chris Sherlock wrote:
> Is it worthwhile asking the RHEL guys to consider creating a Harfbuzz package?
> 
> From a comment in that bug I believe the only reason we now statically link 
> Harfbuzz is because RHEL doesn't have a package. Previously we also did it 
> was because of ABI stability issues, but these are apparently no longer a 
> problem.

That would not help, even if it were likely to happen. Our builds do not
target RHEL-6 specifically, they just use RHEL-6 as a baseline. Any
other few years old linux system will likely either not have harfbuzz or
it will have an old incompatible version.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[libreoffice-projects] minutes of ESC call ...

2016-02-20 Thread Chris Sherlock

> + Doxygen API generation ? (Bjoern)
>+ done by Miklos just now - would like to hand it to sysadmin
>+ assuming it will get run regularly.
>+ http://docs.libreoffice.org/
>+ some multi-GB doxygen output - lots of images.

Just a quick comment: I made an update to the doxygen config file to generate 
SVGs, and also now use a doxygen controlled scroll and zoom UI. 

I don't think that has increased file sizes.

However, with the way things work currently what I have noticed is actually the 
thing that is using most space are the tag files. I don't quite know how to do 
things much better (have experimented a bit) but the script currently generates 
tag files and html for each module, then as each module is built it references 
the previously generated tag files for the previous modules. After the clew 
module is built I noticed that we start getting massive tag files, over 450MB 
of text.

I was thinking maybe there might be a way of reworking the script to generate a 
tag file for each module first, then do another pass that generates the html 
from the tag files.

I don't know if this is feasible: I'm no doxygen expert unfortunately. I got 
this idea from a comment from the doxygen creator though, which detailed on 
Stack Overflow:

http://stackoverflow.com/questions/8247189/doxygen-is-slow/8247993#8247993

Chris

P.S. There seems to be some issue in doxygen preventing it from matching 
function declarations and definitions due to it not picking up correct 
namespaces, in VCL I fixed this by ensuring that we use the css namespace 
alias, but this is not appropriate for other modules.

Was going to try to make a reduced test case, but found it hard to reproduce. I 
wonder if we should reach out to the doxygen guys?___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice