[Libreoffice-bugs] [Bug 99421] EDITING a Date cell contents disappear

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99421

--- Comment #6 from Buovjaga  ---
We are not developers either, we are just users.

You can test with this method without affecting your existing installation:
https://wiki.documentfoundation.org/Installing_in_parallel/Linux

It seems otherwise you would have to update your whole operating system.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 8 commits - helpcontent2 include/svx sd/source svx/source translations

[David Tardon]

 helpcontent2|2 
 include/svx/svdundo.hxx |9 
 sd/source/ui/dlg/unchss.cxx |   50 ++
 sd/source/ui/func/undoback.cxx  |   56 -
 sd/source/ui/inc/unchss.hxx |   11 ++---
 sd/source/ui/inc/undoback.hxx   |   15 --
 svx/source/svdraw/svdobj.cxx|7 +--
 svx/source/svdraw/svdundo.cxx   |   70 
 svx/source/unodraw/UnoNameItemTable.cxx |   17 ++-
 svx/source/unodraw/UnoNameItemTable.hxx |3 -
 translations|2 
 11 files changed, 175 insertions(+), 67 deletions(-)

New commits:
commit c4ed5807bda4d100c3fc053fbb3f738d3c2d24e3
Author: David Tardon 
Date:   Thu Apr 28 14:22:50 2016 +0200

drop cruft

Change-Id: Ib3364e97407061ee7710cb87f1f33a2736ed9c0e

diff --git a/sd/source/ui/inc/undoback.hxx b/sd/source/ui/inc/undoback.hxx
index 4d06781..4fd35e2 100644
--- a/sd/source/ui/inc/undoback.hxx
+++ b/sd/source/ui/inc/undoback.hxx
@@ -29,7 +29,6 @@ class SdPage;
 class SfxItemSet;
 class SfxPoolItem;
 
-// SdBackgroundObjUndoAction
 class SdBackgroundObjUndoAction : public SdUndoAction
 {
 private:
@@ -44,8 +43,6 @@ private:
 voidrestoreFillBitmap(SfxItemSet );
 
 public:
-
-
 SdBackgroundObjUndoAction(
 SdDrawDocument& rDoc,
 SdPage& rPage,
commit ee4f35090657fdce572c5bc6238aceb4098a6e4e
Author: David Tardon 
Date:   Thu Apr 28 14:21:52 2016 +0200

use unique_ptr

Change-Id: I55ff9ae568a0d44c8ee8be922adf40e12038e436

diff --git a/sd/source/ui/func/undoback.cxx b/sd/source/ui/func/undoback.cxx
index b1e0310..08ff102 100644
--- a/sd/source/ui/func/undoback.cxx
+++ b/sd/source/ui/func/undoback.cxx
@@ -18,6 +18,7 @@
  */
 
 #include "undoback.hxx"
+
 #include "sdpage.hxx"
 #include "sdresid.hxx"
 #include "strings.hrc"
@@ -36,7 +37,7 @@ SdBackgroundObjUndoAction::SdBackgroundObjUndoAction(
 const SfxItemSet& rItemSet)
 :   SdUndoAction(),
 mrPage(rPage),
-mpItemSet(new SfxItemSet(rItemSet)),
+mpItemSet(o3tl::make_unique(rItemSet)),
 mbHasFillBitmap(false)
 {
 OUString aString( SdResId( STR_UNDO_CHANGE_PAGEFORMAT ) );
@@ -44,22 +45,16 @@ SdBackgroundObjUndoAction::SdBackgroundObjUndoAction(
 saveFillBitmap(*mpItemSet);
 }
 
-SdBackgroundObjUndoAction::~SdBackgroundObjUndoAction()
-{
-delete mpItemSet;
-}
-
 void SdBackgroundObjUndoAction::ImplRestoreBackgroundObj()
 {
-SfxItemSet* pNew = new 
SfxItemSet(mrPage.getSdrPageProperties().GetItemSet());
+std::unique_ptr pNew = 
o3tl::make_unique(mrPage.getSdrPageProperties().GetItemSet());
 mrPage.getSdrPageProperties().ClearItem();
 if (bool(mpFillBitmapItem))
 restoreFillBitmap(*mpItemSet);
 mpFillBitmapItem.reset();
 mbHasFillBitmap = false;
 mrPage.getSdrPageProperties().PutItemSet(*mpItemSet);
-delete mpItemSet;
-mpItemSet = pNew;
+mpItemSet = std::move(pNew);
 saveFillBitmap(*mpItemSet);
 
 // tell the page that it's visualization has changed
diff --git a/sd/source/ui/inc/undoback.hxx b/sd/source/ui/inc/undoback.hxx
index 36df9f8..4d06781 100644
--- a/sd/source/ui/inc/undoback.hxx
+++ b/sd/source/ui/inc/undoback.hxx
@@ -21,6 +21,7 @@
 #define INCLUDED_SD_SOURCE_UI_INC_UNDOBACK_HXX
 
 #include 
+
 #include "sdundo.hxx"
 
 class SdDrawDocument;
@@ -34,7 +35,7 @@ class SdBackgroundObjUndoAction : public SdUndoAction
 private:
 
 SdPage& mrPage;
-SfxItemSet* mpItemSet;
+std::unique_ptr mpItemSet;
 std::unique_ptr mpFillBitmapItem;
 boolmbHasFillBitmap;
 
@@ -49,7 +50,6 @@ public:
 SdDrawDocument& rDoc,
 SdPage& rPage,
 const SfxItemSet& rItemSet);
-virtual ~SdBackgroundObjUndoAction();
 
 virtual voidUndo() override;
 virtual voidRedo() override;
commit a084962e8c3deaeb3c1b6b9119215b48cf27e76e
Author: David Tardon 
Date:   Thu Apr 28 14:14:53 2016 +0200

fix typo

Change-Id: I841a9c12664950b2f1fe8cdf43e3d815f292eb3d

diff --git a/sd/source/ui/func/undoback.cxx b/sd/source/ui/func/undoback.cxx
index 704b551..b1e0310 100644
--- a/sd/source/ui/func/undoback.cxx
+++ b/sd/source/ui/func/undoback.cxx
@@ -33,10 +33,10 @@
 SdBackgroundObjUndoAction::SdBackgroundObjUndoAction(
 SdDrawDocument& rDoc,
 SdPage& rPage,
-const SfxItemSet& rItenSet)
+const SfxItemSet& rItemSet)
 :   SdUndoAction(),
 mrPage(rPage),
-mpItemSet(new SfxItemSet(rItenSet)),
+mpItemSet(new SfxItemSet(rItemSet)),
 mbHasFillBitmap(false)
 {
 OUString aString( SdResId( STR_UNDO_CHANGE_PAGEFORMAT ) );
diff --git a/sd/source/ui/inc/undoback.hxx 

[Libreoffice-bugs] [Bug 47148] image caching / management is utterly shambolic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47148

tommy27  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||612

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99612] Loss of all images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99612

tommy27  changed:

   What|Removed |Added

 CC||ba...@quipo.it
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=47
   ||148

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47148] image caching / management is utterly shambolic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47148

Michael Meeks  changed:

   What|Removed |Added

 Depends on||99612

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99612] Loss of all images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99612

Michael Meeks  changed:

   What|Removed |Added

 Blocks||47148

--- Comment #2 from Michael Meeks  ---
Hi Julien - so - yes, in a nut-shell we need a similar work to the VclPtr
cleanup here - so we have hard references on images instead of the current
truck-load of lame heuristics and workarounds - with all the fragility they
bring =)

For my part, the image loss problems I experienced in the past around impress
are gone in ~5.0+ I think - so I'm interested to see a more recent duplicate
here.

Bill - sorry about that; and thanks for filing - this is an inherited legacy
issue we need to nail.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99618] F5 / Menu opens new Navigator when using sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99618

V Stuart Foote  changed:

   What|Removed |Added

 Depends on|89505   |85905

--- Comment #2 from V Stuart Foote  ---
oops tranposed the 89505, that of course is dependency on bug 85905 - Allow
undocking of Sidebar decks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85905] Allow undocking of Sidebar decks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85905

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||99618

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89505] FORMATTING Tab Handling in automatic table of contents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89505

V Stuart Foote  changed:

   What|Removed |Added

 Blocks|99618   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99141] Text written in AndikaFrenchTight-R Font disappears when printing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99141

Tim Eves  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=99 |
   |207 |
 Resolution|DUPLICATE   |FIXED

--- Comment #6 from Tim Eves  ---
(In reply to tomaskeb from comment #5)
> 
> *** This bug has been marked as a duplicate of bug 99207 ***
Whilst this bug is in the same body og new code that bug 99207 is in, it's not
caused by the same error, so I'm removing it as a duplicate. In addition it has
already been fixed in commit 0eea1465a06119903fca5f5b6dfe5b05a80546ba tagged
for libreoffice-5.2.0.0.alpha1. I'll ask for it to be applied to 5.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99207] Graphite fonts render in negative colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99207

Tim Eves  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=99 |
   |141 |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89505] FORMATTING Tab Handling in automatic table of contents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89505

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||99618

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65138

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||99618

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65138
Bug 65138 depends on bug 99618, which changed state.

Bug 99618 Summary: F5 / Menu opens new Navigator when using sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=99618

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99618] F5 / Menu opens new Navigator when using sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99618

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Blocks||65138
 Depends on||89505
 Resolution|--- |NOTABUG

--- Comment #1 from V Stuart Foote  ---
By design.

As agreed while implementing bug 73151, until bug 89505 is implemented the
Navigator dialog and the Navigator content panel deck of the sidebar will
continue to display in their respective frames.  This allows work flows where
both Navigator (F5) and Style & Formatting sidebar deck (F11) are used
concurrently.

Functionally the two instances are the same code--but the two frames can be out
of sync.

Implementing bug 89505 will allow the current "dialog" based Navigator to be
removed for the sidebar deck content panel. Until then, it is a minor
annoyance.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp loolwsd/DocumentBroker.hpp loolwsd/LOOLWSD.cpp

[Ashod Nakashian]

 loolwsd/DocumentBroker.cpp |   30 ++
 loolwsd/DocumentBroker.hpp |   20 +++-
 loolwsd/LOOLWSD.cpp|1 +
 3 files changed, 50 insertions(+), 1 deletion(-)

New commits:
commit 10417c9447ec1d34a8a599daf28ac4339a37930a
Author: Ashod Nakashian 
Date:   Sun May 1 20:39:36 2016 -0400

loolwsd: establish communication with child from DocumentBroker

The WebSocket that each child created with WSD is not used
except to request the child to load the document a client
requests. Beyond this point, it was not utilized for anything.

In fact, there are no handlers in WSD for messages coming
from the child; it is a one-way communication.

That is until now. With the move to unify communication
between WSD and each child, DocumentBroker can now
receive and handle messages from its ChildProcess.

Change-Id: Ie7f030a92db8303cd7087fff2325f136a49bc7fc
Reviewed-on: https://gerrit.libreoffice.org/24581
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index 8f50e32..52e30f0 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -17,6 +17,27 @@
 #include "LOOLWSD.hpp"
 #include "Storage.hpp"
 #include "TileCache.hpp"
+#include "LOOLProtocol.hpp"
+
+using namespace LOOLProtocol;
+
+void ChildProcess::socketProcessor()
+{
+IoUtil::SocketProcessor(_ws,
+[this](const std::vector& payload)
+{
+auto docBroker = this->_docBroker.lock();
+if (docBroker)
+{
+return docBroker->handleInput(payload);
+}
+
+Log::warn("No DocumentBroker to handle child message: [" + 
LOOLProtocol::getAbbreviatedMessage(payload) + "].");
+return true;
+},
+[]() { },
+[this]() { return !!this->_stop; });
+}
 
 namespace
 {
@@ -79,6 +100,7 @@ DocumentBroker::DocumentBroker(const Poco::URI& uriPublic,
 {
 assert(!_docKey.empty());
 assert(!_childRoot.empty());
+
 Log::info("DocumentBroker [" + _uriPublic.toString() + "] created. DocKey: 
[" + _docKey + "]");
 }
 
@@ -359,6 +381,14 @@ size_t DocumentBroker::removeSession(const std::string& id)
 return _sessions.size();
 }
 
+bool DocumentBroker::handleInput(const std::vector& payload)
+{
+Log::trace("DocumentBroker got child message: [" + 
LOOLProtocol::getAbbreviatedMessage(payload) + "].");
+
+//TODO: Handle message.
+return true;
+}
+
 bool DocumentBroker::canDestroy()
 {
 std::unique_lock lock(_mutex);
diff --git a/loolwsd/DocumentBroker.hpp b/loolwsd/DocumentBroker.hpp
index 965ced3..efdedc3 100644
--- a/loolwsd/DocumentBroker.hpp
+++ b/loolwsd/DocumentBroker.hpp
@@ -17,6 +17,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -39,8 +40,10 @@ public:
 /// @param ws is the control WebSocket to the child.
 ChildProcess(const Poco::Process::PID pid, const 
std::shared_ptr& ws) :
 _pid(pid),
-_ws(ws)
+_ws(ws),
+_stop(false)
 {
+_thread = std::thread([this]() { this->socketProcessor(); });
 Log::info("ChildProcess ctor [" + std::to_string(_pid) + "].");
 }
 
@@ -57,8 +60,15 @@ public:
 }
 }
 
+void setDocumentBroker(const std::shared_ptr& docBroker)
+{
+_docBroker = docBroker;
+}
+
 void close(const bool rude)
 {
+_stop = true;
+_thread.join();
 _ws.reset();
 if (_pid != -1)
 {
@@ -95,8 +105,14 @@ public:
 }
 
 private:
+void socketProcessor();
+
+private:
 Poco::Process::PID _pid;
 std::shared_ptr _ws;
+std::weak_ptr _docBroker;
+std::thread _thread;
+std::atomic _stop;
 };
 
 /// DocumentBroker is responsible for setting up a document
@@ -184,6 +200,8 @@ public:
 bool canDestroy();
 bool isMarkedToDestroy() const { return _markToDestroy; }
 
+bool handleInput(const std::vector& payload);
+
 private:
 
 /// Sends the .uno:Save command to LoKit.
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 5de9afc..1266417 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -533,6 +533,7 @@ private:
 // Set one we just created.
 Log::debug("New DocumentBroker for docKey [" + docKey + "].");
 docBroker = std::make_shared(uriPublic, docKey, 
LOOLWSD::ChildRoot, child);
+child->setDocumentBroker(docBroker);
 }
 
 // Validate the broker.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/TileCache.cpp

[Ashod Nakashian]

 loolwsd/TileCache.cpp |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

New commits:
commit c913e8e135e871d58d21fa4b1f5b707d746c44fa
Author: Ashod Nakashian 
Date:   Sun May 1 20:34:39 2016 -0400

loolwsd: assert when we should be called with lock acquired

Change-Id: If784dbbfe6ca687fff181f623e413e9b86d51807
Reviewed-on: https://gerrit.libreoffice.org/24580
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/TileCache.cpp b/loolwsd/TileCache.cpp
index 39bc587..6d42158 100644
--- a/loolwsd/TileCache.cpp
+++ b/loolwsd/TileCache.cpp
@@ -89,8 +89,9 @@ std::shared_ptr 
TileCache::findTileBeingRendered(i
 {
 const std::string cachedName = cacheFileName(part, width, height, 
tilePosX, tilePosY, tileWidth, tileHeight);
 
-const auto tile = _tilesBeingRendered.find(cachedName);
+assert(!_tilesBeingRenderedMutex.try_lock());
 
+const auto tile = _tilesBeingRendered.find(cachedName);
 return (tile != _tilesBeingRendered.end() ? tile->second : nullptr);
 }
 
@@ -98,8 +99,9 @@ void TileCache::forgetTileBeingRendered(int part, int width, 
int height, int til
 {
 const std::string cachedName = cacheFileName(part, width, height, 
tilePosX, tilePosY, tileWidth, tileHeight);
 
-assert(_tilesBeingRendered.find(cachedName) != _tilesBeingRendered.end());
+assert(!_tilesBeingRenderedMutex.try_lock());
 
+assert(_tilesBeingRendered.find(cachedName) != _tilesBeingRendered.end());
 _tilesBeingRendered.erase(cachedName);
 }
 
@@ -109,6 +111,7 @@ std::unique_ptr TileCache::lookupTile(int 
part, int width, int hei
 
 std::unique_ptr result(new std::fstream(fileName, 
std::ios::in));
 UnitWSD::get().lookupTile(part, width, height, tilePosX, tilePosY, 
tileWidth, tileHeight, result);
+
 if (result && result->is_open())
 {
 Log::trace("Found cache tile: " + fileName);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLProtocol.hpp

[Ashod Nakashian]

 loolwsd/LOOLProtocol.hpp |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit c75725393991998ad38ec4a73fbb970feb0c99d0
Author: Ashod Nakashian 
Date:   Sun May 1 20:31:40 2016 -0400

loolwsd: getAbbreviatedMessage from std::vector

Change-Id: Ib901fb786839d48604a99a0eab0c7dd048e2004d
Reviewed-on: https://gerrit.libreoffice.org/24578
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLProtocol.hpp b/loolwsd/LOOLProtocol.hpp
index 673e75f..05cc4b4 100644
--- a/loolwsd/LOOLProtocol.hpp
+++ b/loolwsd/LOOLProtocol.hpp
@@ -110,6 +110,12 @@ namespace LOOLProtocol
 {
 return getAbbreviatedMessage(message.data(), message.size());
 }
+
+inline
+std::string getAbbreviatedMessage(const std::vector& message)
+{
+return getAbbreviatedMessage(message.data(), message.size());
+}
 };
 
 #endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLSession.hpp

[Ashod Nakashian]

 loolwsd/LOOLSession.hpp |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 1117be07c4a9b92f79d3faa7294a4249d4365fa5
Author: Ashod Nakashian 
Date:   Sun May 1 20:32:59 2016 -0400

loolwsd: expose sending binary frame on Sessions

Change-Id: I5e81ced0511e44dc5f3445dae42f4354da164b3a
Reviewed-on: https://gerrit.libreoffice.org/24579
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLSession.hpp b/loolwsd/LOOLSession.hpp
index 575dcf3..9864562 100644
--- a/loolwsd/LOOLSession.hpp
+++ b/loolwsd/LOOLSession.hpp
@@ -40,6 +40,7 @@ public:
 bool isDisconnected() const { return _disconnected; }
 
 void sendTextFrame(const std::string& text);
+void sendBinaryFrame(const char *buffer, int length);
 
 virtual bool getStatus(const char *buffer, int length) = 0;
 
@@ -81,8 +82,6 @@ protected:
 _name = _kindString + '-' + id;
 }
 
-void sendBinaryFrame(const char *buffer, int length);
-
 /// Parses the options of the "load" command, shared between 
MasterProcessSession::loadDocument() and ChildProcessSession::loadDocument().
 void parseDocOptions(const Poco::StringTokenizer& tokens, int& part, 
std::string& timestamp);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.hpp

[Ashod Nakashian]

 loolwsd/DocumentBroker.hpp |   25 ++---
 1 file changed, 2 insertions(+), 23 deletions(-)

New commits:
commit 3dc72cab18a5fdc3b623dc18740e5143d40c7618
Author: Ashod Nakashian 
Date:   Sun May 1 20:30:52 2016 -0400

loolwsd: ChildProcess cleanup

Change-Id: I1ae4911d3f5d527af86f39ed2723bbceef12cffe
Reviewed-on: https://gerrit.libreoffice.org/24577
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.hpp b/loolwsd/DocumentBroker.hpp
index 9bf290b..965ced3 100644
--- a/loolwsd/DocumentBroker.hpp
+++ b/loolwsd/DocumentBroker.hpp
@@ -35,11 +35,6 @@ class TileCache;
 class ChildProcess
 {
 public:
-ChildProcess() :
-_pid(-1)
-{
-}
-
 /// @param pid is the process ID of the child.
 /// @param ws is the control WebSocket to the child.
 ChildProcess(const Poco::Process::PID pid, const 
std::shared_ptr& ws) :
@@ -49,25 +44,9 @@ public:
 Log::info("ChildProcess ctor [" + std::to_string(_pid) + "].");
 }
 
-ChildProcess(ChildProcess&& other) :
-_pid(other._pid),
-_ws(other._ws)
-{
-Log::info("ChildProcess move ctor [" + std::to_string(_pid) + "].");
-other._pid = -1;
-other._ws.reset();
-}
-
-const ChildProcess& operator=(ChildProcess&& other)
-{
-Log::info("ChildProcess assign [" + std::to_string(_pid) + "].");
-_pid = other._pid;
-other._pid = -1;
-_ws = other._ws;
-other._ws.reset();
+ChildProcess(ChildProcess&& other) = delete;
 
-return *this;
-}
+const ChildProcess& operator=(ChildProcess&& other) = delete;
 
 ~ChildProcess()
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp |1 -
 loolwsd/ChildProcessSession.hpp |2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 713cf3c067e0ff90a9a285ca228fee9cc52ceb1b
Author: Ashod Nakashian 
Date:   Sun May 1 20:28:54 2016 -0400

loolwsd: return static data via static members

Change-Id: I083cdc921062ef518c9b39bae219caba6c99ee60
Reviewed-on: https://gerrit.libreoffice.org/24576
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index a912798..bf9b8d2 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -725,7 +725,6 @@ namespace {
 }
 }
 
-
 void ChildProcessSession::sendTile(const char* /*buffer*/, int /*length*/, 
StringTokenizer& tokens)
 {
 int part, width, height, tilePosX, tilePosY, tileWidth, tileHeight;
diff --git a/loolwsd/ChildProcessSession.hpp b/loolwsd/ChildProcessSession.hpp
index 77710fe..6f295ab 100644
--- a/loolwsd/ChildProcessSession.hpp
+++ b/loolwsd/ChildProcessSession.hpp
@@ -60,7 +60,7 @@ public:
 
 void loKitCallback(const int nType, const char* pPayload);
 
-std::unique_lock getLock() { return 
std::unique_lock(Mutex); }
+static std::unique_lock getLock() { return 
std::unique_lock(Mutex); }
 
 void setDocState(const int type, const std::string& payload) { 
_lastDocStates[type] = payload; }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99619] New: Base crash when undo redo

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99619

Bug ID: 99619
   Summary: Base crash when undo redo
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tadan...@netscape.net

Created attachment 124775
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124775=edit
procedure

Hellow,

I use LibreOffice_5.1.2_Win_x86.msi, Win7 SP1

on Base 
1.Create database
2.Create table
3.Insert join
4.Undo
5.Redo
6.Crash

For more detaile procedurr, please see the attached file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: starmath/source

[Takeshi Abe]

 starmath/source/parse.cxx |   10 +++---
 1 file changed, 3 insertions(+), 7 deletions(-)

New commits:
commit 07a641b110beee4f7c76617fcd6ed558025321a2
Author: Takeshi Abe 
Date:   Thu Apr 28 16:51:07 2016 +0900

Reduce scope of variables

Change-Id: I0018a6601f48f32736d10fd1eab58e926d97f91b
Reviewed-on: https://gerrit.libreoffice.org/24458
Tested-by: Jenkins 
Reviewed-by: Takeshi Abe 

diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx
index 6a7d76b..a541893 100644
--- a/starmath/source/parse.cxx
+++ b/starmath/source/parse.cxx
@@ -1420,8 +1420,7 @@ void SmParser::DoTerm(bool bGroupNumberIdent)
 {
 // We have several concatenated identifiers and numbers.
 // Let's group them into one SmExpressionNode.
-SmNodeArray nodeArray;
-nodeArray.resize(nTokens);
+SmNodeArray nodeArray(nTokens);
 while (nTokens > 0)
 {
 nodeArray[nTokens-1] = popOrZero(m_aNodeStack);
@@ -2178,7 +2177,6 @@ void SmParser::DoBinom()
 
 void SmParser::DoStack()
 {
-SmNodeArray  ExpressionArray;
 NextToken();
 if (m_aCurToken.eType == TLGROUP)
 {
@@ -2192,7 +2190,7 @@ void SmParser::DoStack()
 }
 while (m_aCurToken.eType == TPOUND);
 
-ExpressionArray.resize(n);
+SmNodeArray ExpressionArray(n);
 
 for (sal_uInt16 i = 0; i < n; i++)
 {
@@ -2218,8 +2216,6 @@ void SmParser::DoStack()
 
 void SmParser::DoMatrix()
 {
-SmNodeArray  ExpressionArray;
-
 NextToken();
 if (m_aCurToken.eType == TLGROUP)
 {
@@ -2257,7 +2253,7 @@ void SmParser::DoMatrix()
 
 size_t nRC = static_cast(r) * c;
 
-ExpressionArray.resize(nRC);
+SmNodeArray ExpressionArray(nRC);
 
 for (size_t i = 0; i < (nRC); ++i)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99601] Conflicting keyboard shortcuts in Portuguese translation - Spellchecker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99601

--- Comment #3 from Leo  ---
Thanks for your attention! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99618] New: F5 / Menu opens new Navigator when using sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99618

Bug ID: 99618
   Summary: F5 / Menu opens new Navigator when using sidebar
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hamilton@gmail.com

Created attachment 124774
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124774=edit
Screenshot of two Navigator windows.

When opening the Navigator in Writer using the menu or F5 shortcut it opens a
floating / docked Navigator window. This is correct if the Sidebar is not also
in use.

If the Sidebar is in use the menu / F5 opens an additional Navigator window and
not the the Navigator deck included as part of the Sidebar. This can lead to
having two Navigator windows open on a workspace.

Correct function should be to switch to the already open Navigator deck on the
Sidebar instead of opening a new Navigator window. It also means that the F5
shortcut key does not close the Sidebar Navigator deck if it is open.

This is inconsistent with F11 which opens and closes the Styles and Formatting
deck of the Sidebar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99615] No way to accept autocomplete and keep writing using keyboard only

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99615

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|UNCONFIRMED |NEW
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1
   Severity|normal  |enhancement

--- Comment #1 from V Stuart Foote  ---
OK, to new.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99595] Improve a couple of keyboard shortcuts.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99595

--- Comment #2 from Hillie  ---
(In reply to V Stuart Foote from comment #1)
> F3 and F4 both have assigned uses already, in general we gain little by
> simply shuffling short-cuts.
> 
> Repeat and Print-preview are possibly useful keys to reassign a single key
> shortcut, but there are others with equal merit.
> 
> But, chasing conformity with UIs of Microsoft applications is not a very
> rational approach to managing LibreOffice's accelerators/short-cuts.
> 
> Design & UX is already looking at facets of this as bug 98255 for Calc to be
> able to establish shortcut compatibility mappings for different spreadsheet
> program.
> 
> =-ref-=
> https://docs.google.com/spreadsheets/d/
> 1AmDXLkQiFK5OcOrtuGn7iAcqp2Yhc_eNNnlADk-ji-U/edit#gid=0

V Stuart Foote,

Thanks for the information.  There may well be keys of equal merit, but having
used spreadsheets for many years and Libreoffice for a nice while now, those
are the only two that I personally noticed as an issue in Libreoffice and
repeat is really the main one from my perspective.  Personally I like to be
able to move around Calc with the mouse or arrow keys while hitting the repeat
key with the other hand.  With the type of work I do, I never miss the original
commands assigned to F3 and F4.  To me the main thing is that it is not a three
key combination for repeat.

This is not an issue for myself as I just customize but I thought it might be a
small help with adoption of other users and improve the ease of use without too
much work.

Shortcut compatibility mappings for different spreadsheet programs seems like a
great way to deal with these type of issues.  Thanks again for the info.

Much appreciated,

Hillie

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Still able to copy text after disabling command

[Maxim Monastirsky]

Hi,

On Fri, 2016-04-29 at 14:31 +, Lucas da Cunha wrote:
> I'm trying to disable Copy (ctrl + C) using java UNO API.

> The problem with Copy is that even the command not being in menu, I
> am still able to Copy text using Ctrl + C.
> 
> Is this a bug?
Well, sw/source/uibase/docvw/edtwin.cxx has this:

2322  // Because Sfx accelerators are only called when they were
2323  // enabled at the last status update, copy has to called
2324  // 'forcefully' by us if necessary.
2325  if( rKeyCode.GetFunction() == KeyFuncType::COPY )
2326  GetView().GetViewFrame()->GetBindings().Execute(SID_COPY);

So this is "by design".

Maxim
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 99601] Conflicting keyboard shortcuts in Portuguese translation - Spellchecker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99601

--- Comment #2 from Olivier Hallot  ---
Related strings in Pootle are : 8CcFA, Z54PM. 

Corrected in 5.0, 5.1 and Master.

Thanks for reporting.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56738] Wrong encoding in comments for file edited by Mac OS MS Word

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56738

--- Comment #8 from Luiz Angelo Daros de Luca  ---
Still present on 5.1.2.2 ubuntu 16.04

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71149] SPELL: Objects inline with text ignored by spellchecks, leading to double space warnings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71149

--- Comment #7 from Luiz Angelo Daros de Luca  ---
Still present on 5.1.2.2 ubuntu 16.04

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71462] VIEWING: Strange blank line in table appear at random

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71462

--- Comment #5 from Luiz Angelo Daros de Luca  ---
Still present on 5.1.2.2 ubuntu 16.04

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71737] FILESAVE: illustration index hyperlink is lost on save

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71737

--- Comment #5 from Luiz Angelo Daros de Luca  ---
It still happens on 5.1.2.2 ubuntu 16.06

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92902] Enhancement Request: Auto-Layout for flowcharts and automatic flowcharts from Calc / Excel

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92902

--- Comment #3 from mrmister001  ---
Hi Heiko,
Thanks for your reply.
However I don't know if you understood the feature very well. You cannot
compare this with templates or Smart Art, because it is not.
To understand how an auntomatic flowchart works you must think in two columns,
from a spreadsheet.
Think in column A and column B.
The idea behind this is that you draw boxes according the data provided in the
column A
And you link this data with the results provided in the column B
If some data from column A (Source) is repeated... and match new data from
column B (Tarfet), then we draw multiple boxes
For example, let's imagine in column A (Source) we have a list of names, and in
the column B (Target) we have a list of departments.

Source Target
John   Sales
Mike   R+D
Peter  Sales
Dana   Accounting
RichardSales
John   Customer Service
Peter  Customer Service

What will happen is due John is related to the Sales and also to the Customer
Service, Draw will create two boxes, one indicating Sales and the other
Customer Service, and both boxes will be connected to John, which will be
represented also in a box.
Mike for example, will be inside a box and will be connected with R+D which
will be also inside a box. Mike won't have more connections because is not
connected more new data.
Peter will experience the same behavior as John, because he works in Sales and
also in the Customer Service, so we will see how draw create a Box for Peter,
and connect this box with two new boxes, one indicating Sales and the other
Customer Service. Peter will be connected to these new boxes, thru lines.
That is the sense behind automatic flowcharting.

THERE IS A VERY IMPORTANT PROGRAM THAT ALREADY DO THIS: YED (FROM YWORKS).
It is made in Jave, and free to download.

I really encourage everyone to understand how YED works and apply the same
philoshopy to Draw.

I remind also that Visio don't have this feature, so basically if this is
implemented inside Draw, it would make Visio bleed deeply.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99613] optional Paramaters for IF is optional

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99613

m.a.riosv  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from m.a.riosv  ---
Sorry I can't understand what it's exactly bad in the help, sure my non
English.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99613] optional Paramaters for IF is optional

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99613

--- Comment #4 from Dennis Roczek  ---
the problem is not the function itself, it is the documentation!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99613] optional Paramaters for IF is optional

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99613

--- Comment #3 from m.a.riosv  ---
Created attachment 124773
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124773=edit
Screenshot without error

I can't see the error, perhaps I miss something.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99258] Windows builds of master 5.2.0alpha1+ failing in Extension Manager on launch

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99258

--- Comment #42 from V Stuart Foote  ---
On windows 10 Pro 64-bit en-US with special build

http://dev-builds.libreoffice.org/daily/master/Win-x86@62-merge-TDF/gerrit_24509_2/

Version: 5.2.0.0.alpha1+
Build ID: d8f73e1da3f799b004dec3875f433aa44685fc23
CPU Threads: 8; OS Version: Windows 6.2; UI Render: GL; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-05-01_13:08:56
Locale: en-US (en_US)

Clean initial launch of splash panel and StartCenter opens with OpenGL enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99613] optional Paramaters for IF is optional

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99613

Dennis Roczek  changed:

   What|Removed |Added

 CC||dennisroc...@libreoffice.or
   ||g

--- Comment #2 from Dennis Roczek  ---
Hi miguel,
well it doesn't matter if it return 0 or FALSE (depending on the ; or the
formatting of the cell): the complete sentence is wrong: the sentence imply
that an ERR:501 appear similar to =ACOS()

so, simplest "solution" would be to remove the complete sentence as it is
untrue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99613] optional Paramaters for IF is optional

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99613

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Hi @Dennis, it returns zero, it's not right?

The only thing could be that the cell is not auto-formatted as Boolean, but
there is not calculation in the parameters to forces it, and an IF can returns
any type of result not necessarily a Boolean.

Suppressing both parameters =IF("a"="b") then returns FALSE, inheriting from
the comparison inside the function.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99220] Export to html with 2 image (picture) on each other

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99220

--- Comment #2 from vit  ---
libreoffice displayed overlapped in the image.
The generated html version displayed is not overlapped.
Why are there no errors?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99338] Crash when opening border style and arrowhead style dropdown selector in Calc and Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99338

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |momonas...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svx/source

[Maxim Monastirsky]

 svx/source/tbxctrls/linectrl.cxx |3 ++-
 svx/source/tbxctrls/tbcontrl.cxx |3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 097bf754c09e8b1ba57e3367baa010898611b61b
Author: Maxim Monastirsky 
Date:   Mon May 2 00:19:50 2016 +0300

tdf#99338 Fix GrabFocus during dispose crashes

Change-Id: I309e1e5f0d28c408c8a95190bf645abf680491b6

diff --git a/svx/source/tbxctrls/linectrl.cxx b/svx/source/tbxctrls/linectrl.cxx
index 6b7fc9d..a69693f 100644
--- a/svx/source/tbxctrls/linectrl.cxx
+++ b/svx/source/tbxctrls/linectrl.cxx
@@ -581,7 +581,8 @@ void SvxLineEndWindow::GetFocus()
 SfxPopupWindow::GetFocus();
 // Grab the focus to the line ends value set so that it can be controlled
 // with the keyboard.
-aLineEndSet->GrabFocus();
+if ( aLineEndSet )
+aLineEndSet->GrabFocus();
 }
 
 SvxLineEndToolBoxControl::SvxLineEndToolBoxControl( sal_uInt16 nSlotId, 
sal_uInt16 nId, ToolBox  ) :
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 46538e2..d672e3d 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -2037,7 +2037,8 @@ bool SvxLineWindow_Impl::Close()
 
 void SvxLineWindow_Impl::GetFocus()
 {
-m_aLineStyleLb->GrabFocus();
+if ( m_aLineStyleLb )
+m_aLineStyleLb->GrabFocus();
 }
 
 SfxStyleControllerItem_Impl::SfxStyleControllerItem_Impl(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/quartz

[Jochen Nitschke]

 vcl/quartz/salbmp.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 438f2db139dfee1036da3baae85c82c9a14448b5
Author: Jochen Nitschke 
Date:   Sun May 1 14:43:38 2016 +0200

fix copy error

since commit 4cab94239be70bd5800a8808652514f14501d303

Change-Id: I8fbd55977bdf8531a66123948c0c4d23657713d4
Reviewed-on: https://gerrit.libreoffice.org/24558
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/vcl/quartz/salbmp.cxx b/vcl/quartz/salbmp.cxx
index 8603f26..4a1a9f0 100644
--- a/vcl/quartz/salbmp.cxx
+++ b/vcl/quartz/salbmp.cxx
@@ -605,7 +605,7 @@ void QuartzSalBitmap::ConvertBitmapData( sal_uInt32 nWidth, 
sal_uInt32 nHeight,
 BitmapBuffer aDstBuf;
 aDstBuf.mnFormat = BMP_FORMAT_32BIT_TC_ARGB;
 aDstBuf.mpBits = pDestData;
-aSrcBuf.mnBitCount = nDestBits;
+aDstBuf.mnBitCount = nDestBits;
 aDstBuf.mnScanlineSize = nDestBytesPerRow;
 
 aSrcBuf.mnWidth = aDstBuf.mnWidth = nWidth;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98124] Crash on copying cells (openCL)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98124

--- Comment #20 from mail.geschaeftl...@arcor.de ---
Sorry it's my my first contribution to a bug, and so I'm not familiar with
bugzilla. I also had the problem (crash) but only after cutting and paste a
text in a table. When I disabled OpenCL as described in commetn 10, no crash
occured. So I attached the file as discribed in comment 12

Kind regards

Dieter

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98124] Crash on copying cells (openCL)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98124

--- Comment #19 from mail.geschaeftl...@arcor.de ---
Created attachment 124772
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124772=edit
see comment 12

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: LibreOffice for android

[Alekhya Vellanki]

Hello everybody,

Kindly let me know if there's anybody working on this project already for
GSoc 2016. :)

Thanks.

On Sun, May 1, 2016 at 5:34 PM, Alekhya Vellanki 
wrote:

> Hello everybody,
>
> I want to contribute to LibreOffice for android project.How do I begin?
>
> Please guide me right from the scratch as this is my first open source
> project. :)
>
> Thanks in advance.
>
>
>
> --
> Alekhya Vellanki
>



-- 
Alekhya Vellanki
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

LibreOffice for android

[Alekhya Vellanki]

Hello everybody,

I want to contribute to LibreOffice for android project.How do I begin?

Please guide me right from the scratch as this is my first open source
project. :)

Thanks in advance.



-- 
Alekhya Vellanki
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 99417] Effect of sort does not propagate to other column (not included in sort) without hard recalc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99417

--- Comment #6 from Peter Smulders  ---
reverted to 4.4.7.2
works fine, the bug is not there

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99617] New: FILEOPEN pptx animation "rotate" is wrongly converted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99617

Bug ID: 99617
   Summary: FILEOPEN pptx animation "rotate" is wrongly converted
   Product: LibreOffice
   Version: 4.2.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 124771
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124771=edit
Wrong import of rotate animation

Open the attached file and play the presentation. Click on the arrow. In
PowerPoint it rotates 1 1/4 times. The setting in PowerPoint is rotate 360°
clockwise in 1s, repeat it 1.25 times. The result is an arrow pointing
downwards.

In LibreOffice it rotates very very often. It seems that the rotating angle or
the repeat value is interpreted totally wrong.

PowerPoint has the value  in this file. Because 1
"PowerPoint-angle-unit" = 1/6 degree and svg/smil unit is degree, it has to
be imported as 360 degree.

PowerPoint sets . That means 1.25 times. As
LibreOffice currently cannot use noninteger smil:repeatCount, I expect that it
is rounded to 1 or 2.

The missing feature of noninteger repeatCount in ODF is tracked in
https://issues.oasis-open.org/browse/OFFICE-2129. But that problem is different
from the too much rotating.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99607] High CPU load on filter activation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99607

Johnny_M  changed:

   What|Removed |Added

   Hardware|x86-64 (AMD64)  |All

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99607] High CPU load on filter activation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99607

--- Comment #4 from Johnny_M  ---
Created attachment 124770
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124770=edit
Screenshot with filter active, Debian 32bit

(In reply to raal from comment #3)
> No repro Version: 5.2.0.0.alpha0+

Thanks for testing!

I can reproduce it with current master on Debian 32-bit though (same machine,
liveUSB):
Version: 5.2.0.0.alpha1+
Build ID: 039b75d6cdc26dcce03e37c67115405e6f2a8ebe
CPU Threads: 2; OS Version: Linux 4.3; UI Render: default; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2016-05-01_01:31:14
Locale: en-US (en_US.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99616] FORMATTING & VIEWING: long text in 1-cell table in a DOCX file is showing only 2 lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99616

--- Comment #2 from Steven Li  ---
Created attachment 124769
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124769=edit
Screen shot of how the doc looks in MSWORD

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99616] FORMATTING & VIEWING: long text in 1-cell table in a DOCX file is showing only 2 lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99616

--- Comment #1 from Steven Li  ---
Created attachment 124768
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124768=edit
Screen shot of how the doc looks in LO Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99616] New: FORMATTING & VIEWING: long text in 1-cell table in a DOCX file is showing only 2 lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99616

Bug ID: 99616
   Summary: FORMATTING & VIEWING: long text in 1-cell table in a
DOCX file is showing only 2 lines
   Product: LibreOffice
   Version: 5.1.0.3 release
  Hardware: x86 (IA32)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stev...@gmail.com

Created attachment 124767
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124767=edit
DOCX file, with a single-cell table, containing long text

I received a rather simple document, with text written in a single-cell table.
I supposed it is a crude way to apply paragraph border, but the format itself
is legitimate.

The long text is showing up in LOWriter with a much shorter table, displaying
only 2 lines of text.

Enclosed please find the original DOCX file, and the screen shots of how it
looks in MSWORD and LOWriter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99615] New: No way to accept autocomplete and keep writing using keyboard only

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99615

Bug ID: 99615
   Summary: No way to accept autocomplete and keep writing using
keyboard only
   Product: LibreOffice
   Version: 5.0.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: teo8...@gmail.com

Steps to reproduce:
1 - Have some cell that contains a given string, e.g. "foo bar"
2 - Start typing into another cell: start by typing the first few characters of
that string, in this example "fo"
=> the string "foo bar" is proposed as autocomplete

Expected behavior:
You should be able, by using either the TAB key or the right arrow, to "accept"
the proposed autocomplete without leaving the cell, for example to continue
typing or delete a few characters and finish entering a slightly different
string. This is how practically EVERY other software that has autocomplete
works, it's a well established UI convention.

Observed behavior:
there's no keystroke that can give you that. If you hit tab, the right arrow
(or any arrow for that matter), or the Enter key, you "accept" the autocomplete
but you also leave the cell. The only way to go on editing it is by
DOUBLE-CLICKING on it, that is, you have to move your hand away from the
keyboard and grab the mouse, and then go back to the keyboard. This is
extremely annoying.

I know this is consistent with the behavior of calc in general, BUT, again, in
every conventional UI, autocomplete behavior usually overrides the generic
behavior of keys. For example, in browsers, the tab key while typing into an
input field usually moves focus to the next input field, but if you are being
offered an autocomplete, the tab key instead accepts it and does not move
focus; the same for the Enter key, which usually sends the entire form, but
when you are being offered an autocomplete just accepts it without performing
the default action.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99338] Crash when opening border style and arrowhead style dropdown selector in Calc and Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99338

--- Comment #10 from Robert Gonzalez MX  ---
Hi to all.

Just tested it again with Version: 5.2.0.0.alpha1+
Build ID: 2e2781d0541dcbf3104973068905a55752c358e5
CPU Threads: 8; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-04-28_15:13:18
Locale: es-MX (es_MX)
On Windows 10 and Windows XP SP3 and is still reproducible.

Also tested it with Version: 5.2.0.0.alpha1+
Build ID: 039b75d6cdc26dcce03e37c67115405e6f2a8ebe
CPU Threads: 8; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-05-01_00:34:51
Locale: es-MX (es_MX)
On Windows 10 and it is still reproducible.

In Calc, when the drop panel of the border line style opens, if it is undocked
from the toolbar, it is usable, but closing the window with the X at the upper
right corner, still crashes.

In Writer, the same happens with the arrow style drop down selector.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99614] New: Rotated text are not rotated in windows edition formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99614

Bug ID: 99614
   Summary: Rotated text are not rotated in windows edition
formatting
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bugzi...@lonelydragon.org

Created attachment 124766
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124766=edit
my affected document.

The formatting of some section of text are not working.  i added a text box
with a comments in a letter.  rotated the content and it looked good on my
linux machine.   open that same document recently on my windows PC so I could
print it.  and the text was horizontal and cut off.   which was annoying.   

Also.  editing this text box has always been challenging. i try to save the
same letter with new content.  and this text box that is rotated is a challenge
to edit with it being rotated 90 degrees

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99613] New: optional Paramaters for IF is optional

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99613

Bug ID: 99613
   Summary: optional Paramaters for IF is optional
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dennisroc...@libreoffice.org
Blocks: 80430

"In the LibreOffice Calc functions, parameters marked as "optional" can be left
out only when no parameter follows. For example, in a function with four
parameters, where the last two parameters are marked as "optional", you can
leave out parameter 4 or parameters 3 and 4, but you cannot leave out parameter
3 alone."
Quoted from IF function at
https://help.libreoffice.org/Calc/Logical_Functions#IF
http://vm173.documentfoundation.org/text/scalc/01/04060105.xhp

This is simply untrue in the case of IF, try it yourself with:
=IF("a"="b";;)

(If that makes sense is totally different, but it works, same useful as
=FALSE())

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80430] [META] LOCALHELP: Features x Documentation gap

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80430

Dennis Roczek  changed:

   What|Removed |Added

 Depends on||99613

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 37932] Smart art support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=37932

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||needsUXEval
  Component|LibreOffice |Draw
 Blocks||99563

--- Comment #11 from Heiko Tietze  ---
DUPLICATE of tdf#92902 (or vice versa) but both tickets have valueable
information

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 99563] META: Enhance Draw's block diagram capabilities

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99563

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||37932

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 37932] Smart art support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=37932

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=92
   ||902

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92902] Enhancement Request: Auto-Layout for flowcharts and automatic flowcharts from Calc / Excel

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92902

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=37
   ||932

--- Comment #2 from Heiko Tietze  ---
See also
https://wiki.documentfoundation.org/Development/Crazy_Ideas#Intelligent_groups_.28alias_SmartArt.29

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99421] EDITING a Date cell contents disappear

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99421

--- Comment #5 from Craig  ---
Hi, I'm just a user, not a developer. If you think it's been fixed on a more up
to date version then fine, I'll wait to be updated in due course with the OS. 
My full version details are.

Version: 5.0.3.2
Build ID: 1:5.0.3~rc2-0ubuntu1~trusty2
Locale: en-GB (en_GB.UTF-8)

It's just an annoyance as I'm working on a 32" 4K screen so while the cells are
physically big enough, the date cells blank out when clicked into, whereas
plain text cells of the same size don't.

Thanks for looking into it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99226] PDF export of ODP with EMF image: crashes or (headless mode) the table misses text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99226

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #5 from Julien Nabet  ---
What option do you use in PDF export?

For the test, could you rename your LO directory profile (see
https://wiki.documentfoundation.org/UserProfile#GNU.2FLinux) and give a new
try?

Also, could you test on 1 machine only for the moment, then with other machines
with ssh?

Finally, 1 bugtracker must correspond to 1 bug to avoid complicate bug
management.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99612] Loss of all images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99612

Julien Nabet  changed:

   What|Removed |Added

 CC||michael.me...@collabora.com
   ||, serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
Michael: Could it be related to tdf#47148?
BTW, is there some project (like vclptr) to refactor images management?
Indeed, there are still many bugs linked to images.
So if it's not already the case, it should be an high priority.
Badfully, I'm not C++ expert but if I can contribute with janitorial/simple
prepare work, no problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99601] Conflicting keyboard shortcuts in Portuguese translation - Spellchecker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99601

Adolfo Jayme  changed:

   What|Removed |Added

  Component|UI  |Localization

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99601] Conflicting keyboard shortcuts in Portuguese translation - Spellchecker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99601

Adolfo Jayme  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||f...@libreoffice.org,
   ||olivier.hallot@documentfoun
   ||dation.org
  Component|Writer  |UI
 Ever confirmed|0   |1

--- Comment #1 from Adolfo Jayme  ---
@Olivier, can you help here? =)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99421] EDITING a Date cell contents disappear

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99421

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
Version|unspecified |5.0.3.2 release
 Ever confirmed|0   |1

--- Comment #4 from raal  ---
I can not confirm with Version: 5.2.0.0.alpha0+
Build ID: 170a473597534cf59887b1d817538322e7039862
CPU Threads: 4; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-04-19_00:41:06

Craig, please test with newer version.
http://www.libreoffice.org/download/libreoffice-fresh/  or
http://dev-builds.libreoffice.org/daily/master/

Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99607] High CPU load on filter activation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99607

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #3 from raal  ---
No repro Version: 5.2.0.0.alpha0+
Build ID: 170a473597534cf59887b1d817538322e7039862
CPU Threads: 4; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-04-19_00:41:06

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99610] Multiple selection of diagrams

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99610

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||r...@post.cz
 Resolution|--- |NOTABUG

--- Comment #1 from raal  ---
Hello Denis,
use shift+click.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99612] New: Loss of all images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99612

Bug ID: 99612
   Summary: Loss of all images
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vchrysafi...@gmail.com

It started with version 5.1.2.2 in win 10 x64 and continues to the 5.1.3.1
Loss of images in the document.
I am working on a long document, It started with text of 85 pages. I started to
add png photos. About 30 photos,were included,  anchored to page, to paragraph,
to character. Some with borders, and the majority with test written around
them.
despite the difficulty on positioning, sticking mainly to the right side, not
moving to the correct set position, they disappeared 4 times in the updated
versions of the document as progressing. The relevant box in settings, is
always checked, but the file from 18 mb was reduced to 500 kb, only with the
frames of the photos appearing, but not including the photos.At least I did not
have to import and re-calibrate each photo manually!I had to re-enter the
photos using for comparison an older file,  but with not the same full content!
This happened 4 times.

I had the same problem with impress as well. At an international conference in
Germany, where I was also suggesting the use of open source software, all my
photos disappeared from my presentation. Only blank border lines, but no
photos, I had to do the same work 3 times, including the legends of the photos
that were lost!

I see on the net that a lot of people have the same problem for quite sometime.
As the documents are sheared with other colleagues, they also loose photos.
using other software, but also the photos are changing positions, making it
very hard to use Libreoffice. Already I am asked to use the MS Office, for
safety of not repeating the same job already done


The problem must be fixed as soon as possible. Otherwise a turn to the stupid
Office will not be avoided!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99338] Crash when opening border style and arrowhead style dropdown selector in Calc and Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99338

--- Comment #9 from Peter  ---
To add to my previous comment:
I found bug report I mentioned. It's Bug 93487.
It's been closed, and I can confirm that it is fixed. But it is very similar to
this bug. (Back then I thought that problem with applying borders and problem
with setting border style are the same bug.) Comments on Bug 93487 doesn't
mention explicitly i3wm, but it looks like problem was dependent on window
manager used.

(I'm not saying that current bug is definitely dependent on window manager. I'm
just guessing. If it is already fixed I would be happy.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99338] Crash when opening border style and arrowhead style dropdown selector in Calc and Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99338

--- Comment #8 from Julien Nabet  ---
I reproduce neither with gtk3 (by default) nor with SAL_USE_VCLPLUGIN=gen

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99449] icons was corrupted when I focused on a text area

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99449

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #2 from Buovjaga  ---
Same with LibO 5.1.2?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 40187] FILESAVE Math Object formula changed causing resize saving .odt to .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=40187

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #7 from Buovjaga  ---


*** This bug has been marked as a duplicate of bug 45284 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45284] formulas in writer file exported to word are sized incorrectly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45284

Buovjaga  changed:

   What|Removed |Added

 CC||christopher.m.penalver@gmai
   ||l.com

--- Comment #21 from Buovjaga  ---
*** Bug 40187 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99338] Crash when opening border style and arrowhead style dropdown selector in Calc and Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99338

--- Comment #7 from Peter  ---
Those, who are on Linux, what desktop environment are you using? I had similar
problem (Calc crashed after I applied borders do cells.) with older versions of
LibreOffice. If I remember correctly, problem showed up mostly/only on i3wm. (I
can't find that report.) Maybe it's worth trying newest version of LO on i3wm.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45284] formulas in writer file exported to word are sized incorrectly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45284

--- Comment #20 from Yury  ---
(In reply to Buovjaga from comment #19)
> Yury: is this the same as bug 40187 ?

Yes, the very same. The source of .DOC, be it Word or LO, affects nothing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99444] calc copies region from wrong sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99444

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #4 from Buovjaga  ---
No repro.

64-bit, KDE Plasma 5
Build ID: 5.1.2.2 Arch Linux build-1
CPU Threads: 8; OS Version: Linux 4.5; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80430] [META] LOCALHELP: Features x Documentation gap

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80430

Dennis Roczek  changed:

   What|Removed |Added

 Depends on||99611

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99611] New: improve function AND() documentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99611

Bug ID: 99611
   Summary: improve function AND() documentation
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dennisroc...@libreoffice.org
Blocks: 80430

https://help.libreoffice.org/Calc/Logical_Functions#AND needs to mention that 0
and '' (empty string) is also considered as a FALSE statement.

Very likely these has to be mentioned at other logical functions

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/Makefile.am|   14 -
 loolwsd/test/TileCacheTests.cpp |  107 
 2 files changed, 119 insertions(+), 2 deletions(-)

New commits:
commit 516bad1942e007aed15e81544e57d1600e6a2996
Author: Ashod Nakashian 
Date:   Sun May 1 12:35:42 2016 -0400

loolwsd: TileCache whitebox tests

New unittests to verify TileCache logic on the unit level.

Change-Id: Ia36181e850b349abb88ba5f04f1e5244771bacc6
Reviewed-on: https://gerrit.libreoffice.org/24574
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/Makefile.am b/loolwsd/test/Makefile.am
index d46d336..2587cec 100644
--- a/loolwsd/test/Makefile.am
+++ b/loolwsd/test/Makefile.am
@@ -14,8 +14,18 @@ MAGIC_TO_FORCE_SHLIB_CREATION = -rpath /dummy
 AM_LDFLAGS = -pthread -module $(MAGIC_TO_FORCE_SHLIB_CREATION)
 AM_CPPFLAGS = -pthread -I$(top_srcdir)
 
-test_CPPFLAGS = -DTDOC=\"$(top_srcdir)/test/data\"
-test_SOURCES = WhiteBoxTests.cpp integration-http-server.cpp httpwstest.cpp 
httpcrashtest.cpp test.cpp ../LOOLProtocol.cpp
+wsd_sources = \
+../IoUtil.cpp \
+../Log.cpp \
+../LOOLProtocol.cpp \
+../TileCache.cpp \
+../MessageQueue.cpp \
+../Unit.cpp \
+../Util.cpp
+
+test_CPPFLAGS = -DTDOC=\"$(top_srcdir)/test/data\" -I$(top_srcdir)
+test_SOURCES = TileCacheTests.cpp WhiteBoxTests.cpp 
integration-http-server.cpp \
+   httpwstest.cpp httpcrashtest.cpp test.cpp $(wsd_sources)
 test_LDADD = $(CPPUNIT_LIBS)
 
 # unit test modules:
diff --git a/loolwsd/test/TileCacheTests.cpp b/loolwsd/test/TileCacheTests.cpp
new file mode 100644
index 000..8667efb
--- /dev/null
+++ b/loolwsd/test/TileCacheTests.cpp
@@ -0,0 +1,107 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include "config.h"
+
+#include 
+
+#include 
+#include "Unit.hpp"
+#include "Util.hpp"
+
+/// TileCache unit-tests.
+class TileCacheTests : public CPPUNIT_NS::TestFixture
+{
+CPPUNIT_TEST_SUITE(TileCacheTests);
+
+CPPUNIT_TEST(test);
+
+CPPUNIT_TEST_SUITE_END();
+
+void test();
+
+static
+std::vector genRandomData(const size_t size)
+{
+std::vector v(size);
+v.resize(size);
+auto data = v.data();
+for (size_t i = 0; i < size; ++i)
+{
+data[i] = static_cast(Util::rng::getNext());
+}
+
+return v;
+}
+
+static
+std::vector readDataFromFile(std::unique_ptr& file)
+{
+file->seekg(0, std::ios_base::end);
+const std::streamsize size = file->tellg();
+
+std::vector v;
+v.resize(size);
+
+file->seekg(0, std::ios_base::beg);
+file->read(v.data(), size);
+
+return v;
+}
+
+public:
+TileCacheTests()
+{
+if (!UnitWSD::init(UnitWSD::UnitType::TYPE_WSD, ""))
+{
+throw std::runtime_error("Failed to load wsd unit test library.");
+}
+}
+};
+
+void TileCacheTests::test()
+{
+// Create TileCache and pretend the file was modified as recently as
+// now, so it discards the cached data.
+TileCache tc("doc.ods", Poco::Timestamp(), "/tmp/tile_cache_tests");
+
+int part = 0;
+int width = 256;
+int height = 256;
+int tilePosX = 0;
+int tilePosY = 0;
+int tileWidth = 3840;
+int tileHeight = 3840;
+
+// No Cache
+auto file = tc.lookupTile(part, width, height, tilePosX, tilePosY, 
tileWidth, tileHeight);
+CPPUNIT_ASSERT_MESSAGE("found tile when none was expected", !file);
+
+// Cache Tile
+const auto size = 1024;
+const auto data = genRandomData(size);
+tc.saveTile(part, width, height, tilePosX, tilePosY, tileWidth, 
tileHeight, data.data(), size);
+
+// Find Tile
+file = tc.lookupTile(part, width, height, tilePosX, tilePosY, tileWidth, 
tileHeight);
+CPPUNIT_ASSERT_MESSAGE("tile not found when expected", file && 
file->is_open());
+const auto tileData = readDataFromFile(file);
+CPPUNIT_ASSERT_MESSAGE("cached tile corrupted", data == tileData);
+
+// Invalidate Tiles
+tc.invalidateTiles("invalidatetiles: EMPTY");
+
+// No Cache
+file = tc.lookupTile(part, width, height, tilePosX, tilePosY, tileWidth, 
tileHeight);
+CPPUNIT_ASSERT_MESSAGE("found tile when none was expected", !file);
+}
+
+CPPUNIT_TEST_SUITE_REGISTRATION(TileCacheTests);
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/Makefile.am |1 +
 1 file changed, 1 insertion(+)

New commits:
commit b916543eefd2927ef1ca995fb1699dd9ba54bbc3
Author: Ashod Nakashian 
Date:   Sun May 1 11:57:43 2016 -0400

loolwsd: tests can be built with running using 'make'

Indeed, tests are built when invoking make in loolwsd
directory, thereby helping catch build errors in test
before committing.

Change-Id: I34cffcb5d0aed6485e578cf20f64217bee337d23
Reviewed-on: https://gerrit.libreoffice.org/24573
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/Makefile.am b/loolwsd/test/Makefile.am
index 90d2c5f..d46d336 100644
--- a/loolwsd/test/Makefile.am
+++ b/loolwsd/test/Makefile.am
@@ -1,6 +1,7 @@
 AUTOMAKE_OPTION = serial-tests
 
 check_PROGRAMS = test
+bin_PROGRAMS = test
 
 AM_CXXFLAGS = $(CPPUNIT_CFLAGS)
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: 2 commits - loolwsd/test loolwsd/TileCache.hpp

[Ashod Nakashian]

 loolwsd/TileCache.hpp  |1 +
 loolwsd/test/Makefile.am   |1 +
 loolwsd/test/UnitTileCache.cpp |   30 ++
 loolwsd/test/helpers.hpp   |1 +
 4 files changed, 33 insertions(+)

New commits:
commit a800d366ba0fcc4408bef2d3a8733869be3763b5
Author: Ashod Nakashian 
Date:   Sun May 1 11:53:37 2016 -0400

loolwsd: missing header

Change-Id: Ib03f6fa048b0b38c0cba4216c4ca9b60f663f3f4
Reviewed-on: https://gerrit.libreoffice.org/24572
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/TileCache.hpp b/loolwsd/TileCache.hpp
index 1d523db..1cf2cbe 100644
--- a/loolwsd/TileCache.hpp
+++ b/loolwsd/TileCache.hpp
@@ -12,6 +12,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
commit 461fd40b49e35c663d90f0369ab1148b0531bc04
Author: Ashod Nakashian 
Date:   Sun May 1 11:20:41 2016 -0400

loolwsd: more support for TileCache unittest

Change-Id: I7b09fdde8179c855bbb1545f3a2188be1c929d20
Reviewed-on: https://gerrit.libreoffice.org/24571
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/Makefile.am b/loolwsd/test/Makefile.am
index 5ec0722..90d2c5f 100644
--- a/loolwsd/test/Makefile.am
+++ b/loolwsd/test/Makefile.am
@@ -25,6 +25,7 @@ unit_timeout_la_SOURCES = UnitTimeout.cpp
 unit_prefork_la_SOURCES = UnitPrefork.cpp
 unit_storage_la_SOURCES = UnitStorage.cpp
 unit_tilecache_la_SOURCES = UnitTileCache.cpp
+unit_tilecache_la_CPPFLAGS = -DTDOC=\"$(top_srcdir)/test/data\"
 
 if HAVE_LO_PATH
 SYSTEM_STAMP = @SYSTEMPLATE_PATH@/system_stamp
diff --git a/loolwsd/test/UnitTileCache.cpp b/loolwsd/test/UnitTileCache.cpp
index 6ebf377..00898f2 100644
--- a/loolwsd/test/UnitTileCache.cpp
+++ b/loolwsd/test/UnitTileCache.cpp
@@ -12,14 +12,21 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "Util.hpp"
 #include "Unit.hpp"
 #include "UnitHTTP.hpp"
+#include "helpers.hpp"
 
 class UnitTileCache: public UnitWSD
 {
 public:
+UnitTileCache() :
+_retValue(0)
+{
+}
+
 virtual void lookupTile(int part, int width, int height, int tilePosX, int 
tilePosY,
 int tileWidth, int tileHeight, 
std::unique_ptr& cacheFile)
 {
@@ -30,6 +37,11 @@ public:
 cacheFile.reset();
 }
 
+virtual void returnValue(int & retValue)
+{
+retValue = _retValue;
+}
+
 virtual void invokeTest()
 {
 // FIXME: push through to the right place to exercise this.
@@ -39,6 +51,24 @@ public:
 UnitWSD::testHandleRequest(TestRequest::TEST_REQ_PRISONER,
request, response);
 }
+
+private:
+void clientThread()
+{
+std::thread t([&]()
+{
+try
+{
+}
+catch (const Poco::Exception& exc)
+{
+_retValue = 1;
+}
+});
+}
+
+private:
+int _retValue;
 };
 
 UnitBase *unit_create_wsd(void)
diff --git a/loolwsd/test/helpers.hpp b/loolwsd/test/helpers.hpp
index b7dae3d..9da8e69 100644
--- a/loolwsd/test/helpers.hpp
+++ b/loolwsd/test/helpers.hpp
@@ -36,6 +36,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test loolwsd/TileCache.cpp loolwsd/Unit.cpp loolwsd/Unit.hpp

[Ashod Nakashian]

 loolwsd/TileCache.cpp  |2 +
 loolwsd/Unit.cpp   |   15 
 loolwsd/Unit.hpp   |   16 +
 loolwsd/test/Makefile.am   |5 ++--
 loolwsd/test/UnitTileCache.cpp |   49 +
 5 files changed, 85 insertions(+), 2 deletions(-)

New commits:
commit d16f44d7a223841a2db9929a8245fd97851502bb
Author: Ashod Nakashian 
Date:   Sun May 1 10:24:31 2016 -0400

loolwsd: TileCache unittest, hooks, and events

Change-Id: Id9e0539d2f920f15b0d0cb8e5924e480ed6d1e87
Reviewed-on: https://gerrit.libreoffice.org/24570
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/TileCache.cpp b/loolwsd/TileCache.cpp
index c02eb7e..39bc587 100644
--- a/loolwsd/TileCache.cpp
+++ b/loolwsd/TileCache.cpp
@@ -34,6 +34,7 @@
 #include "TileCache.hpp"
 #include "Util.hpp"
 #include "MasterProcessSession.hpp"
+#include "Unit.hpp"
 
 using Poco::DirectoryIterator;
 using Poco::File;
@@ -107,6 +108,7 @@ std::unique_ptr TileCache::lookupTile(int 
part, int width, int hei
 const std::string fileName = _cacheDir + "/" + cacheFileName(part, width, 
height, tilePosX, tilePosY, tileWidth, tileHeight);
 
 std::unique_ptr result(new std::fstream(fileName, 
std::ios::in));
+UnitWSD::get().lookupTile(part, width, height, tilePosX, tilePosY, 
tileWidth, tileHeight, result);
 if (result && result->is_open())
 {
 Log::trace("Found cache tile: " + fileName);
diff --git a/loolwsd/Unit.cpp b/loolwsd/Unit.cpp
index 1c4f5fa..b8661a4 100644
--- a/loolwsd/Unit.cpp
+++ b/loolwsd/Unit.cpp
@@ -10,6 +10,8 @@
 #include 
 #include 
 #include 
+#include 
+
 #include "Util.hpp"
 #include "Unit.hpp"
 
@@ -126,6 +128,19 @@ UnitWSD::~UnitWSD()
 {
 }
 
+void UnitWSD::lookupTile(int part, int width, int height, int tilePosX, int 
tilePosY,
+ int tileWidth, int tileHeight, 
std::unique_ptr& cacheFile)
+{
+if (cacheFile && cacheFile->is_open())
+{
+onTileCacheHit(part, width, height, tilePosX, tilePosY, tileWidth, 
tileHeight);
+}
+else
+{
+onTileCacheMiss(part, width, height, tilePosX, tilePosY, tileWidth, 
tileHeight);
+}
+}
+
 UnitKit::UnitKit()
 {
 }
diff --git a/loolwsd/Unit.hpp b/loolwsd/Unit.hpp
index 05d5696..6dc3045 100644
--- a/loolwsd/Unit.hpp
+++ b/loolwsd/Unit.hpp
@@ -133,12 +133,28 @@ public:
  Poco::Net::HTTPServerResponse& /* response */)
 { return false; }
 
+//  TileCache hooks 
+/// Called before the lookupTile call returns. Should always be called to 
fire events.
+virtual void lookupTile(int part, int width, int height, int tilePosX, int 
tilePosY,
+int tileWidth, int tileHeight, 
std::unique_ptr& cacheFile);
+
 //  WSD events 
 virtual void onChildConnected(const int /* pid */, const std::string& /* 
sessionId */) {}
 /// When admin notify message is sent
 virtual void onAdminNotifyMessage(const std::string& /* message */) {}
 /// When admin message is sent in response to a query
 virtual void onAdminQueryMessage(const std::string& /* message */) {}
+
+//  TileCache events 
+virtual void onTileCacheHit(int /*part*/, int /*width*/, int /*height*/,
+int /*tilePosX*/, int /*tilePosY*/,
+int /*tileWidth*/, int /*tileHeight*/) {}
+virtual void onTileCacheMiss(int /*part*/, int /*width*/, int /*height*/,
+ int /*tilePosX*/, int /*tilePosY*/,
+ int /*tileWidth*/, int /*tileHeight*/) {}
+virtual void onTileCacheSubscribe(int /*part*/, int /*width*/, int 
/*height*/,
+  int /*tilePosX*/, int /*tilePosY*/,
+  int /*tileWidth*/, int /*tileHeight*/) {}
 };
 
 /// Derive your Kit unit test / hooks from me.
diff --git a/loolwsd/test/Makefile.am b/loolwsd/test/Makefile.am
index 7b64b9d..5ec0722 100644
--- a/loolwsd/test/Makefile.am
+++ b/loolwsd/test/Makefile.am
@@ -7,7 +7,7 @@ AM_CXXFLAGS = $(CPPUNIT_CFLAGS)
 noinst_LTLIBRARIES = \
 unit-timeout.la unit-prefork.la \
 unit-storage.la unit-fonts.la \
-unit-admin.la
+unit-admin.la unit-tilecache.la
 
 MAGIC_TO_FORCE_SHLIB_CREATION = -rpath /dummy
 AM_LDFLAGS = -pthread -module $(MAGIC_TO_FORCE_SHLIB_CREATION)
@@ -24,6 +24,7 @@ unit_fonts_la_SOURCES = UnitFonts.cpp
 unit_timeout_la_SOURCES = UnitTimeout.cpp
 unit_prefork_la_SOURCES = UnitPrefork.cpp
 unit_storage_la_SOURCES = UnitStorage.cpp
+unit_tilecache_la_SOURCES = UnitTileCache.cpp
 
 if HAVE_LO_PATH
 SYSTEM_STAMP = @SYSTEMPLATE_PATH@/system_stamp
@@ -34,7 +35,7 @@ endif
 if HAVE_LO_PATH
 check-local:
./run_unit.sh --log-file 

[Libreoffice-bugs] [Bug 99220] Export to html with 2 image (picture) on each other

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99220

Buovjaga  changed:

   What|Removed |Added

   Keywords||needAdvice

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45284] formulas in writer file exported to word are sized incorrectly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45284

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #19 from Buovjaga  ---
Yury: is this the same as bug 40187 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99255] Calc crashing on Undo after Spell Correction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99255

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99255] Calc crashing on Undo after Spell Correction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99255

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #3 from Julien Nabet  ---
Created attachment 124765
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124765=edit
bt with symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this.

I attached a bt with symbols.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Fix for Bug 98940

[Matteo Casalin]

On 04/29/2016 06:52 PM, Matteo Casalin wrote:

Hi everybody,
 I submitted to gerrit a one-line fix for bug 98940, a regression 
introduced by a previous commit of mine.
I think it's quite safe to push it to master, and I will do that in a few days 
unless someone reviews/pushes it in the meantime.

The aforementioned bug, however, affects the 5.1 branch and should be evaluated 
for backporting: what is the best approach to be followed for this?

Thanks in advance and kind regards
Matteo



As an addition, the bug reporter originally asked for two fixes:

1. allow again -1 as a valid value, that should be fixed by my patch at:
   https://gerrit.libreoffice.org/#/c/24268/

2. allow a maximum "maximum length" positive value higher than 32767. I
   see two issues with this:
   * that value is set by VCLXMultilineEdit::setProperty, that uses a
 sal_Int16:


http://opengrok.libreoffice.org/xref/core/svtools/source/uno/unoiface.cxx#443

 and I have no idea if this can be changed or if it is stable api
   * The control widget can takes values higher than the aforementioned
 32767, and this besides being misleading can also be a source of
 undesired behavior (is the chosen value truncated, saturated or
 what?).

Any comment is much appreciated.

Kind regards
Matteo
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 99338] Crash when opening border style and arrowhead style dropdown selector in Calc and Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99338

Julien Nabet  changed:

   What|Removed |Added

   Keywords||wantBacktrace
 CC||serval2...@yahoo.fr

--- Comment #6 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I don't reproduce this.
Perhaps already fixed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Fix for Bug 98940

[Matteo Casalin]

Hi Christian

On 05/01/2016 12:23 PM, Christian Lohmaier wrote:

Hi Matteo,

On Fri, Apr 29, 2016 at 6:52 PM, Matteo Casalin
 wrote:

using yahoo address with mailing lists is unfortunate, as yahoo uses
DMARC policy that make receiving mail providers flag the mail as spam
or reject them

"Why is this message in Spam? It has a from address in yahoo.com but
has failed yahoo.com's required tests for authentication."


Thanks for reporting - I will ask for a libreoffice.org one, hoping that 
it will work fine.
It would be great to have a list of account providers that are known to 
work fine with LO online services, besides reducing the number of 
required accounts themselves: I already had to switch both openid and 
e-mail provider for a similar reason, finally choosing yahoo as a 
all-in-one solution. I honestly would prefer not to have to change again 
due to a new poor choice.



Hi everybody,
 I submitted to gerrit a one-line fix for bug 98940, a regression 
introduced by a previous commit of mine.


then it would help greatly to also include the appropriate link to gerrit


Sorry, that was my idea but clearly missed it. Here it is:

https://gerrit.libreoffice.org/24268




The aforementioned bug, however, affects the 5.1 branch and should be evaluated 
for backporting: what is the best approach to be followed for this?


Cherry pick to gerrit and amend with any fixup necessary, so it ends
up in 5.1 as one single commit.


I'm not familiar with this flow, is this equivalent to:
* Switch my local copy to 5.1 branch
* Implement the same fix, plus any other modification needed to compile
* Submit to gerrit, specifying 5.1 branch

Thanks and kind regards
Matteo



ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: loolwsd/IoUtil.cpp

[Ashod Nakashian]

 loolwsd/IoUtil.cpp |6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit b0eed75f05e3b6252559e3c5828ded7109366128
Author: Ashod Nakashian 
Date:   Sun May 1 09:36:37 2016 -0400

loolwsd: differntiating Poco and std exceptions in logs adds little value

Change-Id: I1c571ef46d58b1f007cba58506a3fbfd460fb0f0
Reviewed-on: https://gerrit.libreoffice.org/24569
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/IoUtil.cpp b/loolwsd/IoUtil.cpp
index 5e58a23..5df6dd0 100644
--- a/loolwsd/IoUtil.cpp
+++ b/loolwsd/IoUtil.cpp
@@ -170,13 +170,9 @@ void SocketProcessor(const std::shared_ptr& ws,
   " bytes) will not be processed: [" + msg + "].");
 }
 }
-catch (const Poco::Exception& exc)
-{
-Log::error("SocketProcessor: Exception: " + exc.message());
-}
 catch (const std::exception& exc)
 {
-Log::error("SocketProcessor: std::exception: " + 
std::string(exc.what()));
+Log::error("SocketProcessor: exception: " + std::string(exc.what()));
 }
 
 Log::info("SocketProcessor finished.");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/TileCache.hpp

[Ashod Nakashian]

 loolwsd/TileCache.hpp |   15 +++
 1 file changed, 7 insertions(+), 8 deletions(-)

New commits:
commit e311e26641df25451ac058059a17a7f135c52ee6
Author: Ashod Nakashian 
Date:   Sun May 1 09:30:31 2016 -0400

loolwsd: private better than public

Change-Id: Ie4e9abf160a0a9d9c7de8e31358468ce154a30cd
Reviewed-on: https://gerrit.libreoffice.org/24568
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/TileCache.hpp b/loolwsd/TileCache.hpp
index 7919a47..1d523db 100644
--- a/loolwsd/TileCache.hpp
+++ b/loolwsd/TileCache.hpp
@@ -27,8 +27,7 @@ class TileCache
 {
 struct TileBeingRendered;
 
-std::shared_ptr findTileBeingRendered(int part, int 
width, int height, int tilePosX, int tilePosY, int tileWidth, int tileHeight)
-;
+std::shared_ptr findTileBeingRendered(int part, int 
width, int height, int tilePosX, int tilePosY, int tileWidth, int tileHeight);
 
 public:
 /// When the docURL is a non-file:// url, the timestamp has to be provided 
by the caller.
@@ -41,8 +40,6 @@ public:
 
 bool isTileBeingRenderedIfSoSubscribe(int part, int width, int height, int 
tilePosX, int tilePosY, int tileWidth, int tileHeight, const 
std::shared_ptr );
 
-void forgetTileBeingRendered(int part, int width, int height, int 
tilePosX, int tilePosY, int tileWidth, int tileHeight);
-
 std::unique_ptr lookupTile(int part, int width, int height, 
int tilePosX, int tilePosY, int tileWidth, int tileHeight);
 
 void saveTile(int part, int width, int height, int tilePosX, int tilePosY, 
int tileWidth, int tileHeight, const char *data, size_t size);
@@ -66,21 +63,23 @@ public:
 // The tiles parameter is an invalidatetiles: message as sent by the child 
process
 void invalidateTiles(const std::string& tiles);
 
+/// Store the timestamp to modtime.txt.
+void saveLastModified(const Poco::Timestamp& timestamp);
+
+private:
 void invalidateTiles(int part, int x, int y, int width, int height);
 
 // Removes the given file from the cache
 void removeFile(const std::string& fileName);
 
-/// Store the timestamp to modtime.txt.
-void saveLastModified(const Poco::Timestamp& timestamp);
-
-private:
 std::string cacheFileName(int part, int width, int height, int tilePosX, 
int tilePosY, int tileWidth, int tileHeight);
 bool parseCacheFileName(const std::string& fileName, int& part, int& 
width, int& height, int& tilePosX, int& tilePosY, int& tileWidth, int& 
tileHeight);
 
 /// Extract location from fileName, and check if it intersects with [x, y, 
width, height].
 bool intersectsTile(const std::string& fileName, int part, int x, int y, 
int width, int height);
 
+void forgetTileBeingRendered(int part, int width, int height, int 
tilePosX, int tilePosY, int tileWidth, int tileHeight);
+
 /// Load the timestamp from modtime.txt.
 Poco::Timestamp getLastModified();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99610] New: Multiple selection of diagrams

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99610

Bug ID: 99610
   Summary: Multiple selection of diagrams
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ia12...@mail.ru

Multiple selection of diagrams with CTRL doesn't work - selects only last
clicked diagram

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 60251] ACCESSIBILITY: Tracking Metabug for Windows OS accessibility and AT issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=60251

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||99609

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 36549] ACCESSIBILITY: Tracking bug for issues affecting a11y ATK and GNOME Orca screen reader support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=36549

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||99609

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 55571] ACCESSIBILITY: Tracking bug for important issues related to the Mac OS X Accessibility API

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=55571

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||99609

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs