[Libreoffice-bugs] [Bug 91698] [si-gui] Internet connection with proxy: unhandled exception

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91698

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #7 from Aron Budea  ---
Reproduced in 5.0.0.3.
I had to set a proxy as described at the end of Comment 4 to finally not have
connection (I did it in IE, but it's the same thing as in CP).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92024] Text Alignment is Changed when we change language

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92024

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #6 from Aron Budea  ---
Muthu, can you try if the issue remains if you use different non-English
languages, maybe those that don't require the mentioned eKalappai software to
see if it's related to the interaction between LibreOffice and eKalappai?

Also, Ctrl-L is not pressed when switching languages, right? (this might be
obvious, but who knows)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93239] Install LibreOffice with Windows 10-A64, installed on Windows 8.1-A64

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93239

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||ba...@caesar.elte.hu
 Resolution|--- |NOTOURBUG

--- Comment #2 from Aron Budea  ---
Since several months passed, I assume the uninstall issue got resolved with
Buovjaga's suggestion or some other way. Closing this as NOTOURBUG.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94192] Table and Cell does not work when add new row

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94192

Aron Budea  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||ba...@caesar.elte.hu

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 94192] Table and Cell does not work when add new row

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94192

Aron Budea  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||ba...@caesar.elte.hu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 79933] Insert Hyperlink shortcut is wrong in spanish UI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79933

Adolfo Jayme  changed:

   What|Removed |Added

   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=101699

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Collabora Online 1.0 Engine License

[Adam Saunders]

Hi all,

I understand that the Collabora Online Development Edition (CODE) is 
fully free-and-open-source, but what about the "production-grade" 
version, Collabora Online 1.0 "Engine" that was just recently released 
(https://www.collaboraoffice.com/press-releases/collabora-productivity-releases-collabora-online-cool-1-0-engine-for-hosters-and-clouds/#comment-17242)? 
I ask because CODE contains, in part, permissively-licensed source code.


Thanks!
Adam

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 93738] Shortcuts next to menu entries don' t always correspond to UI language ( appear in language of keyboard layout instead)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93738

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG
Summary|Menu Entry for Shortcuts|Shortcuts next to menu
   |not translated  |entries don't always
   ||correspond to UI language
   ||(appear in language of
   ||keyboard layout instead)

--- Comment #12 from Aron Budea  ---
Thanks for the valuable insights, Maxim.

This actually seems to be intended, because normally the keyboard layout
corresponds to what appears on your keyboard, and it makes sense to display
what the keyboard reads. Of course people often have multiple keyboard layouts
installed, but as a general principle this seems correct.

Thus closing as NOTABUG. Ooome, if you have any further comments on this, let
us know.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96099] Reduce number of typedefs used for trivial container types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96099

--- Comment #27 from Commit Notification 
 ---
krishna keshav committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b2abb97a6545096d6952430f7ff37cadb1a23707

tdf#96099 Reduce number of typedefs used for trivial container types

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source

[krishna keshav]

 filter/source/msfilter/msvbahelper.cxx |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit b2abb97a6545096d6952430f7ff37cadb1a23707
Author: krishna keshav 
Date:   Thu Jun 2 21:55:44 2016 +0530

tdf#96099 Reduce number of typedefs used for trivial container types

Change-Id: Iecf8052d3f7ec5593205184622d53550e6a52161
Reviewed-on: https://gerrit.libreoffice.org/25836
Tested-by: Jenkins 
Reviewed-by: Akshay Deep 

diff --git a/filter/source/msfilter/msvbahelper.cxx 
b/filter/source/msfilter/msvbahelper.cxx
index d831ed0..a06eb5c 100644
--- a/filter/source/msfilter/msvbahelper.cxx
+++ b/filter/source/msfilter/msvbahelper.cxx
@@ -624,8 +624,6 @@ bool getModifier( char c, sal_uInt16& mod )
 return false;
 }
 
-typedef std::map< OUString, sal_uInt16 > MSKeyCodeMap;
-
 sal_uInt16 parseChar( char c ) throw ( uno::RuntimeException )
 {
 sal_uInt16 nVclKey = 0;
@@ -692,7 +690,7 @@ KeyCodeEntry aMSKeyCodesData[] = {
 
 awt::KeyEvent parseKeyEvent( const OUString& Key ) throw ( 
uno::RuntimeException )
 {
-static MSKeyCodeMap s_KeyCodes;
+static std::map< OUString, sal_uInt16 > s_KeyCodes;
 if ( s_KeyCodes.empty() )
 {
 for (KeyCodeEntry & i : aMSKeyCodesData)
@@ -731,7 +729,7 @@ awt::KeyEvent parseKeyEvent( const OUString& Key ) throw ( 
uno::RuntimeException
 nVclKey |= parseChar( (char)( sKeyCode[ 0 ] ) );
 else
 {
-MSKeyCodeMap::iterator it = s_KeyCodes.find( sKeyCode );
+auto it = s_KeyCodes.find( sKeyCode );
 if ( it == s_KeyCodes.end() ) // unknown or unsupported
 throw uno::RuntimeException();
 nVclKey |= it->second;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 94090] User Interface in multiple languages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94090

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0208

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100208] UI languages mixed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100208

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=94
   ||090

--- Comment #2 from Aron Budea  ---
Adolfo, I'm not sure the two bugs are related (bug 94090 looks like a
candidate, though). This seems to be a corrupt installation/upgrade, as
normally the texts are translated in that dialog.
I did an 5.0.5.2 install, and then upgraded to 5.0.6.3, but the particular
dialog appeared properly translated.

My assumption is if the user profile is fine, then something must be wrong with
the installed files. Timur, can you look into it what is different in those
installs where the language is wrong compared to where it's right? Comparing
checksums of all the installed files in the Program Files directory to find
differences should give some clues.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 100195] StartCenter keyboard navigation for the new Template Manager

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100195

--- Comment #3 from Commit Notification 
 ---
Akshay Deep committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=90e3e04841081b9c03ea54f1d5ca439a7a9ce1dd=libreoffice-5-2

tdf#100195 Enable Keyboard Navigation in Template Manager and Start Center

It will be available in 5.2.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 100195] StartCenter keyboard navigation for the new Template Manager

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100195

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0|target:5.3.0 target:5.2.0.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - include/sfx2 sfx2/source

[Akshay Deep]

 include/sfx2/templateabstractview.hxx|2 +-
 sfx2/source/control/templateabstractview.cxx |   14 --
 sfx2/source/control/templatelocalview.cxx|4 ++--
 sfx2/source/control/templatesearchview.cxx   |2 ++
 sfx2/source/dialog/backingwindow.cxx |   21 +
 sfx2/source/doc/templatedlg.cxx  |4 ++--
 6 files changed, 36 insertions(+), 11 deletions(-)

New commits:
commit 90e3e04841081b9c03ea54f1d5ca439a7a9ce1dd
Author: Akshay Deep 
Date:   Fri Jun 3 03:43:09 2016 +0530

tdf#100195 Enable Keyboard Navigation in Template Manager and Start Center

Reviewed-on: https://gerrit.libreoffice.org/25848
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

Conflicts:
sfx2/source/control/templateabstractview.cxx

Change-Id: Ic5447a4af091a4e3dcab4d909fc6bfb9e559defb
Reviewed-on: https://gerrit.libreoffice.org/25881
Reviewed-by: Akshay Deep 
Tested-by: Jenkins 

diff --git a/include/sfx2/templateabstractview.hxx 
b/include/sfx2/templateabstractview.hxx
index 64c696a..c9f1a33 100644
--- a/include/sfx2/templateabstractview.hxx
+++ b/include/sfx2/templateabstractview.hxx
@@ -76,7 +76,7 @@ public:
 void insertItem (const TemplateItemProperties );
 
 // Fill view with new item list
-void insertItems (const std::vector );
+void insertItems (const std::vector , 
bool isRegionSelected = true);
 
 // Fill view with template folders thumbnails
 virtual void Populate () { }
diff --git a/sfx2/source/control/templateabstractview.cxx 
b/sfx2/source/control/templateabstractview.cxx
index acbc2d3..2d6409b 100644
--- a/sfx2/source/control/templateabstractview.cxx
+++ b/sfx2/source/control/templateabstractview.cxx
@@ -127,14 +127,21 @@ void TemplateAbstractView::insertItem(const 
TemplateItemProperties )
 Invalidate();
 }
 
-void TemplateAbstractView::insertItems(const 
std::vector )
+void TemplateAbstractView::insertItems(const 
std::vector , bool isRegionSelected)
 {
+mItemList.clear();
+
 std::vector aItems(rTemplates.size());
 for (size_t i = 0, n = rTemplates.size(); i < n; ++i )
 {
 const TemplateItemProperties *pCur = [i];
 
-TemplateViewItem *pChild = new TemplateViewItem(*this, pCur->nId);
+TemplateViewItem *pChild;
+if(isRegionSelected)
+pChild = new TemplateViewItem(*this, pCur->nId);
+else
+pChild = new TemplateViewItem(*this, i+1);
+
 pChild->mnDocId = pCur->nDocId;
 pChild->mnRegionId = pCur->nRegionId;
 pChild->maTitle = pCur->aName;
@@ -163,8 +170,11 @@ void TemplateAbstractView::updateThumbnailDimensions(long 
itemMaxSize)
 
 void TemplateAbstractView::MouseButtonDown( const MouseEvent& rMEvt )
 {
+GrabFocus();
+
 if (rMEvt.IsRight())
 {
+deselectItems();
 size_t nPos = ImplGetItem(rMEvt.GetPosPixel());
 Point aPosition (rMEvt.GetPosPixel());
 maPosition = aPosition;
diff --git a/sfx2/source/control/templatelocalview.cxx 
b/sfx2/source/control/templatelocalview.cxx
index 6c826bf..c2df6bf 100644
--- a/sfx2/source/control/templatelocalview.cxx
+++ b/sfx2/source/control/templatelocalview.cxx
@@ -143,7 +143,7 @@ void TemplateLocalView::showAllTemplates()
 mnCurRegionId = 0;
 maCurRegionName.clear();
 
-insertItems(maAllTemplates);
+insertItems(maAllTemplates, false);
 maOpenRegionHdl.Call(nullptr);
 }
 
@@ -586,7 +586,7 @@ bool TemplateLocalView::moveTemplates(const std::setnDocId == pViewItem->mnDocId)
 {
 pPropIter = pSrc->maTemplates.erase(pPropIter);
-aItemIds.push_back(pViewItem->mnId);
+aItemIds.push_back(pViewItem->mnDocId + 1);//mnid
 }
 else
 {
diff --git a/sfx2/source/control/templatesearchview.cxx 
b/sfx2/source/control/templatesearchview.cxx
index 9f85171..3075d40 100644
--- a/sfx2/source/control/templatesearchview.cxx
+++ b/sfx2/source/control/templatesearchview.cxx
@@ -33,8 +33,10 @@ VCL_BUILDER_FACTORY(TemplateSearchView)
 
 void TemplateSearchView::MouseButtonDown( const MouseEvent& rMEvt )
 {
+GrabFocus();
 if (rMEvt.IsRight())
 {
+deselectItems();
 size_t nPos = ImplGetItem(rMEvt.GetPosPixel());
 Point aPosition (rMEvt.GetPosPixel());
 maPosition = aPosition;
diff --git a/sfx2/source/dialog/backingwindow.cxx 
b/sfx2/source/dialog/backingwindow.cxx
index 5c81eb8..20e97a7 100644
--- a/sfx2/source/dialog/backingwindow.cxx
+++ b/sfx2/source/dialog/backingwindow.cxx
@@ -392,7 +392,7 @@ bool BackingWindow::PreNotify( NotifyEvent& rNEvt )
 {
 if( rKeyCode.IsShift() ) // Shift + F6
 {
- 

[Libreoffice-bugs] [Bug 100203] Windows MSI packaged upgrade from 64-bit version to a newer 32-bit version does not uninstall or alert to prior instance

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100203

V Stuart Foote  changed:

   What|Removed |Added

Summary|Upgrading 64-bit version to |Windows MSI packaged
   |a newer 32-bit version does |upgrade from 64-bit version
   |not delete old files|to a newer 32-bit version
   ||does not uninstall or alert
   ||to prior instance

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100203] Upgrading 64-bit version to a newer 32-bit version does not delete old files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100203

V Stuart Foote  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 CC||tima...@gmail.com
 Ever confirmed|0   |1
   Severity|normal  |enhancement

--- Comment #3 from V Stuart Foote  ---
Sure, we can call it an enhancement.

@Andras, any thoughts on a custom action in the MSI installer for checking
existence of both 64-bit as well as 32-bit installations when installing
either.

Probably fine to abort the install and have the user manually remove the prior
version. But not unreasonable to provide some check to prevent orphaned 32 or
64 bit installation cut off from APPWIZ.exe add/remove.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70565] FORMATTING: Loss of number and date formatting in XLSX files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70565

Bartosz Kosiorek  changed:

   What|Removed |Added

 CC||gan...@poczta.onet.pl
   Hardware|Other   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100189] copy paste in writer inserts unwanted leading space

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100189

V Stuart Foote  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
Version|5.0.6.2 release |Inherited From OOo
 Resolution|--- |NOTABUG

--- Comment #6 from V Stuart Foote  ---
(In reply to Dr. Matthias Weisser from comment #5)
> 
> What in fact I am getting is: test test test test test. This is clearly not
> what I am expecting here. Why is there a white space added around the word
> "test" which I do not want to have?
> 
> It seems to be hard inserting a word without spaces in between. Even if I
> delete the last space with each paste an unwanted space comes up each time.
> This does not happen when I use "Inhalte einfügen" "unformatierter Text"
> which costs much more time because of using the pull down menu.

Yes, believe this is intended behavior of the edit engine and is correct. 

Set up this simple test case:

Test test test

mist mist mist


So, IIUC if you double click select the center "test" the entire word is
selected because it has "protected" word boundaries. If you position the edit
cursor between the "mi" and "st" of the center mist and +V it will paste
with white space boundaries intact.

You can directly paste unformatted text "test" by using the
+V short cut to avoid the GUI paste special.

Conversely, if you select the initial "Test" or the ending "test" (so its ^Test
or test$) the word boundaries are not protected and when you paste between "mi"
and "st" you'll get either "miTestst" or "mitestst".

Likewise if you select "est" from the center test, it is does not consider 
word boundaries so when you insert between "mi" and "st" you'll get "miestst"
and so on.

Again I believe this is as intended and is inherited from OOo.

Version: 5.1.3.2 (x64)
Build ID: 644e4637d1d8544fd9f56425bd6cec110e49301b

Version: 4.4.1.2
Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432

Version: 4.1.5.2
Build ID: a02f36998a4af5e2f9fbec2b7e9f70a8b0bc934

LibreOffice 3.5.7.2 
Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

=-ref-=
http://opengrok.libreoffice.org/xref/core/vcl/source/edit/textview.cxx#789
http://opengrok.libreoffice.org/xref/core/vcl/source/edit/texteng.cxx#2405

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - include/sfx2 sfx2/source

[Akshay Deep]

 include/sfx2/templateabstractview.hxx|2 ++
 include/sfx2/templatedefaultview.hxx |2 ++
 sfx2/source/control/templateabstractview.cxx |   23 +++
 sfx2/source/control/templatedefaultview.cxx  |5 +
 4 files changed, 32 insertions(+)

New commits:
commit 5cc822b9be6b69cc5a03e92144620b25d7872775
Author: Akshay Deep 
Date:   Fri Jun 3 16:51:05 2016 +0530

Template Manager: Ctrl + A to select all templates

Change-Id: I8398268752c78a30d5fc076d6f2b6249cbf89ec2
Reviewed-on: https://gerrit.libreoffice.org/25860
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 
(cherry picked from commit 74f6f03f55eb6d641d2b26aae883943c69683563)
Reviewed-on: https://gerrit.libreoffice.org/25882
Reviewed-by: Akshay Deep 
Tested-by: Jenkins 

diff --git a/include/sfx2/templateabstractview.hxx 
b/include/sfx2/templateabstractview.hxx
index 903c997..64c696a 100644
--- a/include/sfx2/templateabstractview.hxx
+++ b/include/sfx2/templateabstractview.hxx
@@ -85,6 +85,8 @@ public:
 
 virtual void MouseButtonDown( const MouseEvent& rMEvt ) override;
 
+virtual void KeyInput( const KeyEvent& rKEvt ) override;
+
 virtual void showAllTemplates () = 0;
 
 virtual void showRegion (TemplateContainerItem *pItem) = 0;
diff --git a/include/sfx2/templatedefaultview.hxx 
b/include/sfx2/templatedefaultview.hxx
index 24157a1..6d2fcdf 100644
--- a/include/sfx2/templatedefaultview.hxx
+++ b/include/sfx2/templatedefaultview.hxx
@@ -19,6 +19,8 @@ public:
 
 virtual void reload() override;
 
+virtual void KeyInput( const KeyEvent& rKEvt ) override;
+
 void createContextMenu();
 
 DECL_LINK_TYPED(ContextMenuSelectHdl, Menu*, void);
diff --git a/sfx2/source/control/templateabstractview.cxx 
b/sfx2/source/control/templateabstractview.cxx
index 8f08f58..acbc2d3 100644
--- a/sfx2/source/control/templateabstractview.cxx
+++ b/sfx2/source/control/templateabstractview.cxx
@@ -181,6 +181,29 @@ void TemplateAbstractView::MouseButtonDown( const 
MouseEvent& rMEvt )
 ThumbnailView::MouseButtonDown(rMEvt);
 }
 
+void TemplateAbstractView::KeyInput( const KeyEvent& rKEvt )
+{
+vcl::KeyCode aKeyCode = rKEvt.GetKeyCode();
+
+if(aKeyCode == ( KEY_MOD1 | KEY_A ) )
+{
+for (ThumbnailViewItem* pItem : mItemList)
+{
+if (!pItem->isSelected())
+{
+pItem->setSelection(true);
+maItemStateHdl.Call(pItem);
+}
+}
+
+if (IsReallyVisible() && IsUpdateMode())
+Invalidate();
+return;
+}
+
+ThumbnailView::KeyInput(rKEvt);
+}
+
 
 void TemplateAbstractView::setOpenRegionHdl(const Link )
 {
diff --git a/sfx2/source/control/templatedefaultview.cxx 
b/sfx2/source/control/templatedefaultview.cxx
index 76e08ea..d6ffb63 100644
--- a/sfx2/source/control/templatedefaultview.cxx
+++ b/sfx2/source/control/templatedefaultview.cxx
@@ -48,6 +48,11 @@ void TemplateDefaultView::reload()
 set_width_request(mnTextHeight + mnItemMaxSize + 2*mnItemPadding);
 }
 
+void TemplateDefaultView::KeyInput( const KeyEvent& rKEvt )
+{
+ThumbnailView::KeyInput(rKEvt);
+}
+
 void TemplateDefaultView::createContextMenu()
 {
 std::unique_ptr pItemMenu(new PopupMenu);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100209] crash: select Master Slide for Master Slide in Slide Background

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100209

JoNi  changed:

   What|Removed |Added

   Keywords||haveBacktrace
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100209] New: crash: select Master Slide for Master Slide in Slide Background

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100209

Bug ID: 100209
   Summary: crash: select Master Slide for Master Slide in Slide
Background
   Product: LibreOffice
   Version: 5.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j.nitschke+td...@ok.de

Created attachment 125478
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125478=edit
backtrace

selecting a master slide for a master slide cashes impress

to reproduce:
* open a new impress document
* in the standard toolbar click Display Modes
* select Master Modes, Notes
* open sidebar - properties, if it's not open
* Slide Background has a listbox Master Slide, open the list
* select default
-> crash

guess this should have been disabled for masters in first place

also note the warn right before the crash and the argument in #1 of the
backtrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - include/sfx2 sfx2/source sfx2/uiconfig

[Akshay Deep]

 include/sfx2/templatedlg.hxx|1 
 sfx2/source/doc/templatedlg.cxx |   48 ++--
 sfx2/uiconfig/ui/templatedlg.ui |   60 +++-
 3 files changed, 38 insertions(+), 71 deletions(-)

New commits:
commit b1cfb6622a415e042af27f04d6c85dba9cf02286
Author: Akshay Deep 
Date:   Thu Jun 2 20:37:42 2016 +0530

Reduce duplicate code in Template Manager

Remove ViewBar and put contents in ActionBar

Change-Id: I6551d36503f659f076ecf2b6766c6a14db771a1d
Reviewed-on: https://gerrit.libreoffice.org/25833
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 
(cherry picked from commit f402a06a6abd011b2be024ce3b847edfbcb82908)
Reviewed-on: https://gerrit.libreoffice.org/25876
Reviewed-by: Akshay Deep 
Tested-by: Akshay Deep 

diff --git a/include/sfx2/templatedlg.hxx b/include/sfx2/templatedlg.hxx
index 440c153..97fd3e5 100644
--- a/include/sfx2/templatedlg.hxx
+++ b/include/sfx2/templatedlg.hxx
@@ -154,7 +154,6 @@ private:
 VclPtr mpExportButton;
 VclPtr mpImportButton;
 VclPtr mpLinkButton;
-VclPtr mpViewBar;
 VclPtr mpActionBar;
 VclPtr mpSearchView;
 VclPtr mpCurView;
diff --git a/sfx2/source/doc/templatedlg.cxx b/sfx2/source/doc/templatedlg.cxx
index 4d23086..07811cf 100644
--- a/sfx2/source/doc/templatedlg.cxx
+++ b/sfx2/source/doc/templatedlg.cxx
@@ -67,7 +67,7 @@ const char TM_SETTING_LASTAPPLICATION[] = "LastApplication";
 
 const char SERVICENAME_CFGREADACCESS[] = 
"com.sun.star.configuration.ConfigurationAccess";
 
-const char VIEWBAR_REPOSITORY[] = "repository";
+const char ACTIONBAR_REPOSITORY[] = "repository";
 const char ACTIONBAR_ACTION[] = "action_menu";
 
 #define MNI_ACTION_NEW_FOLDER 1
@@ -170,7 +170,6 @@ SfxTemplateManagerDlg::SfxTemplateManagerDlg(vcl::Window 
*parent)
 get(mpSearchFilter, "search_filter");
 get(mpCBApp, "filter_application");
 get(mpCBFolder, "filter_folder");
-get(mpViewBar, "action_view");
 get(mpActionBar, "action_action");
 get(mpLocalView, "template_view");
 get(mpSearchView, "search_view");
@@ -205,14 +204,13 @@ SfxTemplateManagerDlg::SfxTemplateManagerDlg(vcl::Window 
*parent)
 mpActionMenu->SetPopupMenu(MNI_ACTION_DEFAULT,mpTemplateDefaultMenu);
 
 // Set toolbox styles
-mpViewBar->SetButtonType(ButtonType::SYMBOLTEXT);
+mpActionBar->SetButtonType(ButtonType::SYMBOLTEXT);
 
 // Set toolbox button bits
-mpViewBar->SetItemBits(mpViewBar->GetItemId(VIEWBAR_REPOSITORY), 
ToolBoxItemBits::DROPDOWNONLY);
+mpActionBar->SetItemBits(mpActionBar->GetItemId(ACTIONBAR_REPOSITORY), 
ToolBoxItemBits::DROPDOWNONLY);
 mpActionBar->SetItemBits(mpActionBar->GetItemId(ACTIONBAR_ACTION), 
ToolBoxItemBits::DROPDOWNONLY);
 
 // Set toolbox handlers
-
mpViewBar->SetDropdownClickHdl(LINK(this,SfxTemplateManagerDlg,TBXDropdownHdl));
 
mpActionBar->SetDropdownClickHdl(LINK(this,SfxTemplateManagerDlg,TBXDropdownHdl));
 
 mpLocalView->SetStyle(mpLocalView->GetStyle() | WB_VSCROLL);
@@ -267,11 +265,10 @@ SfxTemplateManagerDlg::SfxTemplateManagerDlg(vcl::Window 
*parent)
 SvtMiscOptions aMiscOptions;
 if ( !aMiscOptions.IsExperimentalMode() )
 {
-sal_uInt16 nPos = 
mpViewBar->GetItemPos(mpViewBar->GetItemId(VIEWBAR_REPOSITORY));
-mpViewBar->RemoveItem(nPos);
+sal_uInt16 nPos = 
mpActionBar->GetItemPos(mpActionBar->GetItemId(ACTIONBAR_REPOSITORY));
+mpActionBar->RemoveItem(nPos);
 }
 
-mpViewBar->Show();
 mpActionBar->Show();
 
 switchMainView(true);
@@ -331,7 +328,6 @@ void SfxTemplateManagerDlg::dispose()
 mpSearchFilter.clear();
 mpCBApp.clear();
 mpCBFolder.clear();
-mpViewBar.clear();
 mpActionBar.clear();
 mpSearchView.clear();
 mpCurView.clear();
@@ -527,30 +523,19 @@ IMPL_LINK_NOARG_TYPED(SfxTemplateManagerDlg, 
SelectRegionHdl, ListBox&, void)
 SearchUpdateHdl(*mpSearchFilter);
 }
 
-IMPL_LINK_TYPED(SfxTemplateManagerDlg, TBXDropdownHdl, ToolBox*, pBox, void)
+IMPL_LINK_NOARG_TYPED(SfxTemplateManagerDlg, TBXDropdownHdl, ToolBox*, void)
 {
-const sal_uInt16 nCurItemId = pBox->GetCurItemId();
+const sal_uInt16 nCurItemId = mpActionBar->GetCurItemId();
+mpActionBar->SetItemDown( nCurItemId, true );
 
-if (pBox == mpActionBar && nCurItemId == 
mpActionBar->GetItemId(ACTIONBAR_ACTION))
-{
-pBox->SetItemDown( nCurItemId, true );
-
-mpActionMenu->Execute(pBox, pBox->GetItemRect(nCurItemId), 
PopupMenuFlags::ExecuteDown);
-
-pBox->SetItemDown( nCurItemId, false );
-pBox->EndSelection();
-pBox->Invalidate();
-}
-else if (pBox == mpViewBar && nCurItemId == 
mpViewBar->GetItemId(VIEWBAR_REPOSITORY))
-{
-pBox->SetItemDown( nCurItemId, true );
+if (nCurItemId == 

[Libreoffice-bugs] [Bug 96942] Dialog’s buttons localized to operating system language and do not match LibreOffice’s UI language

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96942

Adolfo Jayme  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
  Component|Installation|UI
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100208] UI languages mixed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100208

Adolfo Jayme  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Adolfo Jayme  ---


*** This bug has been marked as a duplicate of bug 96942 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96942] Dialog’s buttons localized to operating system language and do not match LibreOffice’s UI language

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96942

Adolfo Jayme  changed:

   What|Removed |Added

 CC||gti...@gmail.com

--- Comment #4 from Adolfo Jayme  ---
*** Bug 100208 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96942] Dialog’s buttons localized to operating system language and do not match LibreOffice’s UI language

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96942

Adolfo Jayme  changed:

   What|Removed |Added

Summary|Installer is localized to   |Dialog’s buttons localized
   |operating system language   |to operating system
   |and does not match the  |language and do not match
   |language of the downloaded  |LibreOffice’s UI language
   |package |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100203] Upgrading 64-bit version to a newer 32-bit version does not delete old files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100203

Aron Budea  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|INVALID |---

--- Comment #2 from Aron Budea  ---
I consider it an issue that now there's an orphaned LibreOffice in the system
that has no shortcuts, no uninstall function (what was there is taken over by
the new version's), and the only option to get rid of it is manual deletion.

I'd expect the installer to first uninstall the old version, and then install
the new one. Note that it happens correctly, with no leftover files, in a
32-bit -> 64-bit upgrade, but not vice versa.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100201] FORMATTING: LO 5.3 alpha0 crashes when custom color applied to cell.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100201

Julien Nabet  changed:

   What|Removed |Added

   Keywords||regression

--- Comment #3 from Julien Nabet  ---
I don't reproduce this with LO Debian package 5.1.3.2 => regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99864] trying to change column width in table affects only single row - no way to handle more than one row at a time.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99864

Heinrich Hartl  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|NOTABUG |---

--- Comment #8 from Heinrich Hartl  ---
uploaded documents should be more precise for reproducing the problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99864] trying to change column width in table affects only single row - no way to handle more than one row at a time.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99864

--- Comment #7 from Heinrich Hartl  ---
Created attachment 125477
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125477=edit
Step by Step doku for reprodcing bug using small document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99864] trying to change column width in table affects only single row - no way to handle more than one row at a time.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99864

--- Comment #6 from Heinrich Hartl  ---
Created attachment 125476
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125476=edit
small document for reproducing the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100201] FORMATTING: LO 5.3 alpha0 crashes when custom color applied to cell.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100201

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #2 from Julien Nabet  ---
Created attachment 125475
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125475=edit
bt with symbols

On pc Debian x86-64 with master sources updated today, I could reproduce the
crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100201] FORMATTING: LO 5.3 alpha0 crashes when custom color applied to cell.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100201

Julien Nabet  changed:

   What|Removed |Added

   Priority|medium  |high
 Status|UNCONFIRMED |NEW
Version|unspecified |5.2.0.0.alpha0+ Master
   Keywords||haveBacktrace
   Hardware|Other   |All
 Ever confirmed|0   |1
   Severity|normal  |major
 OS|Mac OS X (All)  |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97579] Unable to link Access 2010 database causing LireOffice to freeze and requiring force kill

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97579

--- Comment #13 from Elie  ---
Well, Alex,
I run on Win7 SP1  64bits  AMD10 quad.
Versie LibO: 5.0.5.2 (x64)
Build ID: 55b006a02d247b5f7215fc6ea0fde844b30035b3
Locale: nl-BE (nl_BE)
As said: can't open .mdb (so not .accdb but .mdb).  (I converted the file on
another computer to .accdb, but same result).
The .mdb file opens with MDB Plus.
My original comment:
< 'repairs' ('succeeds') -->
crashes again, repairs, etc.  Until infinity.>>

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100189] copy paste in writer inserts unwanted leading space

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100189

Dr. Matthias Weisser  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---
 Ever confirmed|0   |1

--- Comment #5 from Dr. Matthias Weisser  ---
thank you very much Stewart for your comment.

just to clarify:
as can be seen the word that I choose to copy "test" does not contain any
space.

I would expect that LO just pastes what I had copied. Because I did not want to
copy a space I do not expect to see an additional space.

If I copy "test" and paste this 5 times I would expect getting:
testtesttesttesttest.

What in fact I am getting is: test test test test test. This is clearly not
what I am expecting here. Why is there a white space added around the word
"test" which I do not want to have?

It seems to be hard inserting a word without spaces in between. Even if I
delete the last space with each paste an unwanted space comes up each time.
This does not happen when I use "Inhalte einfügen" "unformatierter Text" which
costs much more time because of using the pull down menu.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sal/qa

[Caolán McNamara]

 sal/qa/osl/file/osl_File.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 411e7e88030d86e64339a53462d2fb06180c3538
Author: Caolán McNamara 
Date:   Fri Jun 3 21:15:08 2016 +0100

fix 32bit linux build

Change-Id: Ib42627c04b2c06e34f2dd108f8a04eaea916488a

diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index 79d46cc..155dfec 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -1734,7 +1734,7 @@ namespace osl_FileStatus
 test_Attributes &= rFileStatus.getAttributes();
 
 CPPUNIT_ASSERT_EQUAL_MESSAGE( "test for getAttributes function: 
Hidden files( Solaris version )",
-osl_File_Attribute_Hidden, test_Attributes 
);
+
static_cast(osl_File_Attribute_Hidden), test_Attributes );
 }
 #else//Windows version
 void getAttributes_004()
@@ -2608,14 +2608,14 @@ namespace osl_File
 nError1 = testFile.setPos( osl_Pos_Current, 1 );
 CPPUNIT_ASSERT_EQUAL( nError1, ::osl::FileBase::E_None );
 }
- nError1 = testFile.getPos( nFilePointer );
+nError1 = testFile.getPos( nFilePointer );
 CPPUNIT_ASSERT_EQUAL( nError1, ::osl::FileBase::E_None );
 
 nError1 = testFile.close();
 CPPUNIT_ASSERT_EQUAL( nError1, ::osl::FileBase::E_None );
 
 CPPUNIT_ASSERT_EQUAL_MESSAGE( "test for isEndOfFile function: use 
isEndOfFile to move pointer step by step",
-  nFilePointer, sizeof( pBuffer_Char ) + 1 
);
+  nFilePointer, 
static_cast(sizeof( pBuffer_Char ) + 1) );
 }
 CPPUNIT_TEST_SUITE( isEndOfFile );
 CPPUNIT_TEST( isEndOfFile_001 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

two types of tear-off menus ?

[Caolán McNamara]

We seem to have two types of tear-off menus. e.g. in impress the basic
shapes and connector etc menus have the tear off area at the bottom
with a little line effect. I like this (a) set because they don't have
any focus issues for me under gtk3 :-).

The other (b) set has examples like line color and fill color. They
have their tear-off concealed at the top, cause focus trouble when the
popup under gtk3. Every time I've tried to do anything with this type
of menu in the past something has gone wrong on one platform or
another. i.e. they're fragile and system dependent.

Anyway, is there any existing plans to move the b types to be a types ?
Or any thoughts about what might be involved there ?

C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 96745] Crash when close the Background- or Font-Color-Dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96745

--- Comment #12 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a779d979b9dd87589f00cfcb245f70c6b26d8c2c

accidentially reverted fix for tdf#96745

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96745] Crash when close the Background- or Font-Color-Dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96745

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:5.2.0   | target:5.2.0 target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara]

 vcl/source/window/brdwin.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit a779d979b9dd87589f00cfcb245f70c6b26d8c2c
Author: Caolán McNamara 
Date:   Fri Jun 3 21:08:45 2016 +0100

accidentially reverted fix for tdf#96745

Change-Id: I52380248002f6c41f0c6f154f913b05ef32b93d3

diff --git a/vcl/source/window/brdwin.cxx b/vcl/source/window/brdwin.cxx
index dd8a8ae..28583f5 100644
--- a/vcl/source/window/brdwin.cxx
+++ b/vcl/source/window/brdwin.cxx
@@ -957,9 +957,9 @@ bool ImplStdBorderWindowView::Tracking( const 
TrackingEvent& rTEvt )
 {
 // dispatch to correct window type (why is Close() not 
virtual ??? )
 // TODO: make Close() virtual
-vcl::Window *pWin = 
pBorderWindow->ImplGetClientWindow()->ImplGetWindow();
-SystemWindow  *pSysWin  = dynamic_cast(pWin);
-DockingWindow *pDockWin = 
dynamic_cast(pWin);
+VclPtr pWin = 
pBorderWindow->ImplGetClientWindow()->ImplGetWindow();
+SystemWindow  *pSysWin  = dynamic_cast(pWin.get());
+DockingWindow *pDockWin = 
dynamic_cast(pWin.get());
 if ( pSysWin )
 pSysWin->Close();
 else if ( pDockWin )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100182] Writer Version 5.2.x and above : index

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100182

wolff-ohlenb...@t-online.de changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 CC||wolff-ohlenb...@t-online.de
   Assignee|libreoffice-b...@lists.free |wolff-ohlenb...@t-online.de
   |desktop.org |
 Ever confirmed|1   |0

--- Comment #2 from wolff-ohlenb...@t-online.de ---
Created attachment 125474
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125474=edit
With Writer-Version 5.1.4.1 I have no Problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100189] copy paste in writer inserts unwanted leading space

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100189

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100189] copy paste in writer inserts unwanted leading space

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100189

--- Comment #4 from V Stuart Foote  ---
@Matthias,

Notice in your sample document and inserted clip that the location receiving
the pasted text already has a "space" prior to the Pilcrow for the paragraph
end.

In fact all paragraphs are ending with a "space" prior to the Pilcrow.

Meaning when you copy paste to that spot you'll have the existing space, plus
the white space surrounding the word paste.

Not sure why or how you are inserting a space prior to ending a paragraph. But
the insert is correct, the inclusion of a space preceeding the copied text is
expected behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100203] Upgrading 64-bit version to a newer 32-bit version does not delete old files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100203

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |INVALID

--- Comment #1 from V Stuart Foote  ---
Of course they remain, the "upgrade" you performed is a new complete
installation into a different location. For the time being until an incremental
update mechanism is implemented bug 54242 (and related) the Windows installer
is full install package.

If you'd wanted to "upgrade" in place you needed to select the 64-bit installer
for download, and even then "all" it would do is overwrite the existing DLLs.

If there is an issue, it would be that the "update" notification sends you to
the download page, but does not adjust the landing location for the
32-bit/64-bit instance and localization already in place.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100189] copy paste in writer inserts unwanted leading space

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100189

Dr. Matthias Weisser  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100189] copy paste in writer inserts unwanted leading space

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100189

Dr. Matthias Weisser  changed:

   What|Removed |Added

 CC||matthias.weis...@gmx.de

--- Comment #3 from Dr. Matthias Weisser  ---
Created attachment 125473
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125473=edit
test file with pictures showing bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86277] Filesave: Libreoffice vs Excel 2010 worksheet saved as .xlsx not opened correctly in (python) pandas/xlrd: hidden column information

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86277

--- Comment #8 from douwe van der veen  ---
For reference:
For information only:

the python-excel package people appears to have fixed this issue, see
https://github.com/python-excel/xlrd/issues/56

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100151] crash pptx file at the end of the presentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100151

Timur  changed:

   What|Removed |Added

   Keywords|wantBacktrace   |haveBacktrace

--- Comment #5 from Timur  ---
Also not repro in Win. Please try another computer, graphics..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100208] New: UI languages mixed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100208

Bug ID: 100208
   Summary: UI languages mixed
   Product: LibreOffice
   Version: 5.0.6.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: major
  Priority: medium
 Component: Localization
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gti...@gmail.com

Created attachment 125472
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125472=edit
UI languages mixed

As shown in the attachment, there are at least 3 UI languages in the same
dialog in Writer 5.0.6: English, Bosnian, and some unknown.
In a "better" case, there are 2 languages mixed: English, Bosnian.
Deleting profile doesn't help.
Installation was a centralized upgrade to dozen of various Windows computers
(XP, 7, 10) from LO 5.0.5 to LO 5.0.6. Only some have this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92117] Crash/ hang after deleting column in XLSX or deleting and saving

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92117

Timur  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100202] FILEOPEN: Paragraph White Fill added to cell in DOCX import

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100202

Luke  changed:

   What|Removed |Added

   Keywords||bisected, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/source

[Markus Mohrhard]

 desktop/source/minidump/minidump_upload.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit f2d18f8a7125f4f4d1d72be11fb3fb6637f25fde
Author: Markus Mohrhard 
Date:   Thu Jun 2 17:04:27 2016 +0200

add some more error checking to minidump uploader

Change-Id: Ia06fec80ea67e88b8c26cdeb5bfc9cee2459ad4a
Reviewed-on: https://gerrit.libreoffice.org/25861
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/desktop/source/minidump/minidump_upload.cxx 
b/desktop/source/minidump/minidump_upload.cxx
index 3f17c04..30e 100644
--- a/desktop/source/minidump/minidump_upload.cxx
+++ b/desktop/source/minidump/minidump_upload.cxx
@@ -100,6 +100,12 @@ bool uploadContent(std::map& 
parameters)
 if (url.empty())
 return false;
 
+if (file.empty())
+return false;
+
+if (version.empty())
+return false;
+
 curl_easy_setopt(curl, CURLOPT_URL, url.c_str());
 curl_easy_setopt(curl, CURLOPT_USERAGENT, kUserAgent);
 // Set proxy information if necessary.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99265] If done after cropping, compress displays image stretched

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99265

--- Comment #7 from Gérald Maruccia  ---
Bug still present in 5.1.3.2

Ubuntu 14.04 and 16.04

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99909] Dump which temporary freezes Writer, no crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99909

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0207

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100207] New: Another dump which temporary freezes Writer, no crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100207

Bug ID: 100207
   Summary: Another dump which temporary freezes Writer, no crash
   Product: LibreOffice
   Version: 5.0.6.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: major
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gti...@gmail.com

While using Writer 5.0.6.2, full profile with extensions, I got procdump.
Writer didn't crash. I think I was sending the document to print. 
Lately I get a crash rather frequently. New profile is not a solution for me. 


Microsoft (R) Windows Debugger Version 6.3.9600.16384 X86
Copyright (c) Microsoft Corporation. All rights reserved.


Loading Dump File [soffice.bin.dmp]
Comment: '
*** procdump.exe  soffice.bin -h  soffice.bin.dmp
*** Hung window detected: 70c6c'
User Mini Dump File: Only registers, stack and portions of memory are available


* Symbol Path validation summary **
Response Time (ms) Location
Deferred   CACHE*C:\symbols
Deferred  
SRV*http://dev-builds.libreoffice.org/daily/master/Win-x86@39/symbols
Deferred  
SRV*http://dev-downloads.libreoffice.org/symstore/symbols
Deferred  
SRV*http://msdl.microsoft.com/download/symbols
Symbol search path is:
CACHE*C:\symbols;SRV*http://dev-builds.libreoffice.org/daily/master/Win-x86@39/symbols;SRV*http://dev-downloads.libreoffice.org/symstore/symbols;SRV*http://msdl.microsoft.com/download/symbols
Executable search path is: 
Windows 7 Version 7601 (Service Pack 1) MP (8 procs) Free x86 compatible
Product: WinNt, suite: SingleUserTS
Machine Name:
Debug session time: Fri Jun  3 19:30:53.000 2016 (UTC + 2:00)
System Uptime: not available
Process Uptime: 0 days 0:13:33.000


...
Loading unloaded module list
.
eax= ebx=068697b0 ecx= edx= esi=066863b0 edi=1080a0a8
eip=771605a2 esp=00c6e9e0 ebp=00c6ea14 iopl=0 nv up ei pl zr na pe nc
cs=0023  ss=002b  ds=002b  es=002b  fs=0053  gs=002b efl=00200246
ntdll!ZwAlpcSendWaitReceivePort+0x12:
771605a2 83c404  add esp,4

* Symbol Path validation summary **
Response Time (ms) Location
Deferred   CACHE*C:\symbols
Deferred  
SRV*http://dev-builds.libreoffice.org/daily/master/Win-x86@39/symbols
Deferred  
SRV*http://dev-downloads.libreoffice.org/symstore/symbols
Deferred  
SRV*http://msdl.microsoft.com/download/symbols
0:000> !analyze -v
***
* *
*Exception Analysis   *
* *
***

*** ERROR: Symbol file could not be found.  Defaulted to export symbols for
soffice.bin - 
GetUrlPageData2 (WinHttp) failed: 12029.

FAULTING_IP: 
+14d2a7006fdc
 ??  ???

EXCEPTION_RECORD:   -- (.exr 0x)
ExceptionAddress: 
   ExceptionCode: 8003 (Break instruction exception)
  ExceptionFlags: 
NumberParameters: 0

CONTEXT:   -- (.cxr 0x0;r)
eax= ebx=068697b0 ecx= edx= esi=066863b0 edi=1080a0a8
eip=771605a2 esp=00c6e9e0 ebp=00c6ea14 iopl=0 nv up ei pl zr na pe nc
cs=0023  ss=002b  ds=002b  es=002b  fs=0053  gs=002b efl=00200246
ntdll!ZwAlpcSendWaitReceivePort+0x12:
771605a2 83c404  add esp,4

FAULTING_THREAD:  146c

DEFAULT_BUCKET_ID:  STATUS_BREAKPOINT

PROCESS_NAME:  soffice.bin

ERROR_CODE: (NTSTATUS) 0x8003 - {EXCEPTION}  Breakpoint  A breakpoint has
been reached.

EXCEPTION_CODE: (HRESULT) 0x8003 (2147483651) - One or more arguments are
invalid

NTGLOBALFLAG:  0

APPLICATION_VERIFIER_FLAGS:  0

APP:  soffice.bin

ANALYSIS_VERSION: 6.3.9600.16384 (debuggers(dbg).130821-1623) x86fre

PRIMARY_PROBLEM_CLASS:  STATUS_BREAKPOINT

BUGCHECK_STR:  APPLICATION_FAULT_STATUS_BREAKPOINT

LAST_CONTROL_TRANSFER:  from 75827647 to 771605a2

STACK_TEXT:  
00c6e9e0 75827647 03e4 4002 1080a0a8
ntdll!ZwAlpcSendWaitReceivePort+0x12
00c6ea14 75827ae7 0002 1080a0a8 068697b0
rpcrt4!LRPC_CASSOCIATION::AlpcSendWaitReceivePort+0x5d
00c6ea6c 758279ea 00c6eadc 068696f8 00c6eefc

[Libreoffice-commits] core.git: config_host/config_firebird.h.in configure.ac dbaccess/qa

[Michal Kubecek]

 config_host/config_firebird.h.in   |   10 ++
 configure.ac   |   16 +---
 dbaccess/qa/unit/data/firebird_integer_x64le_ods12.odb |binary
 dbaccess/qa/unit/firebird.cxx  |5 +
 4 files changed, 28 insertions(+), 3 deletions(-)

New commits:
commit de899f0b350e51b1932fa4674f7ce2ae386cd1ce
Author: Michal Kubecek 
Date:   Thu Jun 2 11:56:10 2016 +0200

connectivity: firebird: use ODS12 test database for Firebird 3

Firebird 3.0 uses new database file format (ODS, On Disk Structure) so
that we need to use either ODS11 or ODS12 version of test database for
dbaccess_firebird test, depending on whether building against Firebird
2.5 or 3.0 libraries.

Change-Id: Idecdc35b0ac87ab7f46cb79b5c044c65423a2c7e
Reviewed-on: https://gerrit.libreoffice.org/25846
Reviewed-by: jan iversen 
Tested-by: jan iversen 

diff --git a/config_host/config_firebird.h.in b/config_host/config_firebird.h.in
new file mode 100644
index 000..c6aa43a
--- /dev/null
+++ b/config_host/config_firebird.h.in
@@ -0,0 +1,10 @@
+/*
+Settings for Firebird
+*/
+
+#ifndef CONFIG_FIREBIRD_H
+#define CONFIG_FIREBIRD_H
+
+#define HAVE_FIREBIRD_30 0
+
+#endif
diff --git a/configure.ac b/configure.ac
index 0c4b677..0a1e137 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8675,8 +8675,10 @@ if test "$enable_firebird_sdbc" = "yes" ; then
 if test -n "${FIREBIRD_VERSION}"; then
 FIREBIRD_MAJOR=`echo $FIREBIRD_VERSION | cut -d"." -f1`
 FIREBIRD_MINOR=`echo $FIREBIRD_VERSION | cut -d"." -f2`
-if test "$FIREBIRD_MAJOR" -eq "2" -a "$FIREBIRD_MINOR" -eq "5" -o \
-"$FIREBIRD_MAJOR" -eq "3" -a "$FIREBIRD_MINOR" -eq "0"; 
then
+if test "$FIREBIRD_MAJOR" -eq "2" -a "$FIREBIRD_MINOR" -eq "5"; 
then
+AC_MSG_RESULT([OK])
+elif test "$FIREBIRD_MAJOR" -eq "3" -a "$FIREBIRD_MINOR" -eq "0"; 
then
+AC_DEFINE(HAVE_FIREBIRD_30, 1)
 AC_MSG_RESULT([OK])
 else
 AC_MSG_ERROR([Ensure firebird 2.5.x or 3.0.x is installed])
@@ -8685,10 +8687,16 @@ if test "$enable_firebird_sdbc" = "yes" ; then
 __save_CFLAGS="${CFLAGS}"
 CFLAGS="${CFLAGS} ${FIREBIRD_CFLAGS}"
 AC_COMPILE_IFELSE([AC_LANG_SOURCE([[#include 
-#if defined(FB_API_VER) && (FB_API_VER == 25 || FB_API_VER == 30)
+#if defined(FB_API_VER) && FB_API_VER == 25
+int fb_api_is_25(void) { return 0; }
+#elif defined(FB_API_VER) && FB_API_VER == 30
+int fb_api_is_30(void) { return 0; }
 #else
 #error "Wrong Firebird API version"
 #endif]])],AC_MSG_RESULT([OK]),AC_MSG_ERROR([Ensure firebird 2.5.x or 3.0.x is 
installed]))
+if nm conftest.$OBJEXT | grep fb_api_is_30; then
+AC_DEFINE(HAVE_FIREBIRD_30, 1)
+fi
 CFLAGS="${__save_CFLAGS}"
 fi
 ENABLE_FIREBIRD_SDBC="TRUE"
@@ -8731,6 +8739,7 @@ AC_SUBST(LIBATOMIC_OPS_LIBS)
 AC_SUBST(SYSTEM_FIREBIRD)
 AC_SUBST(FIREBIRD_CFLAGS)
 AC_SUBST(FIREBIRD_LIBS)
+AC_SUBST(HAVE_FIREBIRD_30)
 dnl AC_SUBST([TOMMATH_CFLAGS])
 dnl AC_SUBST([TOMMATH_LIBS])
 
@@ -12938,6 +12947,7 @@ AC_CONFIG_HEADERS([config_host/config_cairo_canvas.h])
 AC_CONFIG_HEADERS([config_host/config_cxxabi.h])
 AC_CONFIG_HEADERS([config_host/config_dbus.h])
 AC_CONFIG_HEADERS([config_host/config_features.h])
+AC_CONFIG_HEADERS([config_host/config_firebird.h])
 AC_CONFIG_HEADERS([config_host/config_folders.h])
 AC_CONFIG_HEADERS([config_host/config_gio.h])
 AC_CONFIG_HEADERS([config_host/config_global.h])
diff --git a/dbaccess/qa/unit/data/firebird_integer_x64le_ods12.odb 
b/dbaccess/qa/unit/data/firebird_integer_x64le_ods12.odb
new file mode 100644
index 000..95691ed
Binary files /dev/null and 
b/dbaccess/qa/unit/data/firebird_integer_x64le_ods12.odb differ
diff --git a/dbaccess/qa/unit/firebird.cxx b/dbaccess/qa/unit/firebird.cxx
index c9ee575..da0bed7 100644
--- a/dbaccess/qa/unit/firebird.cxx
+++ b/dbaccess/qa/unit/firebird.cxx
@@ -16,6 +16,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::sdb;
@@ -65,7 +66,11 @@ void FirebirdTest::testEmptyDBConnection()
 void FirebirdTest::testIntegerDatabase()
 {
 uno::Reference< XOfficeDatabaseDocument > xDocument =
+#if HAVE_FIREBIRD_30
+getDocumentForFileName("firebird_integer_x64le_ods12.odb");
+#else
 getDocumentForFileName("firebird_integer_x64le.odb");
+#endif
 
 uno::Reference< XConnection > xConnection =
 getConnectionForDocument(xDocument);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100188] Lost of CONDITIONAL FORMATTING with formula on refresh by macro with cell link with an another file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100188

raal  changed:

   What|Removed |Added

   Keywords||regression
 Status|UNCONFIRMED |NEEDINFO
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #1 from raal  ---
Please attach test document with macro. Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100151] crash pptx file at the end of the presentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100151

--- Comment #4 from raal  ---
Created attachment 125471
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125471=edit
backtrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91474] [a11y] Crash invoking "press" accessibility action in " Pivot Table Layout" dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91474

Buovjaga  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

--- Comment #4 from Buovjaga  ---
Thanks, let's set to WFM as this is a mystery fix :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100182] Writer Version 5.2.x and above : index

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100182

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #1 from raal  ---
No repro with Version: 5.3.0.0.alpha0+
Build ID: 86d84ae4bba0d4c45bc13232645318291a8aed75
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-05-26_14:33:24

Please attach test file and write steps how to reproduce. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100204] HYPERLINK does not work with the file names containing number sign '#'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100204

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #1 from raal  ---
Hello, I have not problem with path "/tmp/MyFile - #1234 - Report.ods"
tested with 5.1.2.2 and Version: 5.3.0.0.alpha0+ in Linux.

Please upgrade your version of LO and retest.
http://www.libreoffice.org/download/libreoffice-fresh/
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100206] Hangs when try to open a document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100206

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #1 from raal  ---
Hello,

Thank you for filing the bug. Please send us a sample document, as this makes
it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO', so please do change it back to
'UNCONFIRMED' once you have attached a document.
(Please note that the attachment will be public, remove any sensitive
information before attaching it.)
How can I eliminate confidential data from a sample document?
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100206] New: Hangs when try to open a document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100206

Bug ID: 100206
   Summary: Hangs when try to open a document
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j20...@gmail.com

Writer is often hanging when I try to open an existing document.  It seems to
be getting worse.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91333] EDITING / FORMATTING: Crash when formatting header / footer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91333

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #13 from Caolán McNamara  ---
hmm, I can't reproduce anywhere, but the last frame is ScHFEditPage::ClickHdl
and the call on SetCharAttributes.

The SetCharAttributes used to be called on the result of ::GetScEditWindow and
is now called on a m_pEditFocus member since...

commit 5fe66069010e9afc3a16d238592c3b672850514c
Author: Michael Stahl 
Date:   Thu Nov 12 23:37:12 2015 +0100

sc: loplugin:badstatics: remove pActiveEdWnd global variable

because that was a particularly dubious piece of code. I suspect that the focus
never got set into the dialog editboxes of the current dialog so this should
have been null, but that the focus got set in some earlier dialog and so was
still pointing to something now dead or something of that nature.

So I'm reasonably confident that mstahl happened to fix this problem with that
commit which is available in 5-1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93421] EDITING, FORMATTING: template changes do not propagate to existing documents when template is imported in newer version of LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93421

--- Comment #18 from Cor Nouws  ---
So ...

(In reply to Cor Nouws from comment #13)

> - Started 4.0.6.2 again and changed template and opened file.
>  > Indeed asked for updating
> 
> - Started 5.1.3.2 again and opened file from 4.0.6.2 again.
>  > Now it does ask for updating..
> So restarting seems to solve the problem.

Nope. It was the template in the 4.0.6.2 installation that still was referred
in the document, that made the question appear. 
Sorry for the confusion.

Now, when working in 5.1.3.2, changing the linked template from a document
created in 4.0.5.2 to the 5.1.3 path, does not make the update-question being
triggered after changing the linked template in 5.1.3.2.
Doing the same with a file from 4.0.6.2, doe trigger the update-question.

So there lies probably the problem, that needs to be looked at in more detail.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63256] [Template Manager][UI] missing option to show available templates as list (not preview/icons) in new template manager

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63256

--- Comment #11 from Al Maloney  ---
(In reply to Heiko Tietze from comment #10)
> (In reply to Al Maloney from comment #9)
> > How do the icons make searching and choosing better than a list?
> 
> If you search by description the list together with a preview is the perfect
> control. But most people would have the picture in mind how the template
> look. And that's better supported by several images - the icon view. So I'd
> say either the developers allow to switch from icon to list view or WONTFIX.
> 
> Have you taken a look at the latest build? The filter and search options are
> very handy and may help you as well.

Yes. I have looked at it in the version noted in my post.
The changes are promising.
Although not what I had in mind, they are an improvement if I am using them
properly.

First I select the application eg Document=Writer, Spreadsheet=Calc, etc.
Then I select a Category.
This produces a screen with fewer items which is easier to navigate.

I think this is workable for me.

One suggestion - If a category is empty for a given application, then it is
suppressed from the list of choices for that application.

Thank you to all who are working on this!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99733] CALC EDITING: Crash when moving range of cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99733

Caolán McNamara  changed:

   What|Removed |Added

 CC||yer...@gmail.com

--- Comment #15 from Caolán McNamara  ---
*** Bug 90689 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 63256] [Template Manager][UI] missing option to show available templates as list (not preview/icons) in new template manager

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63256

--- Comment #11 from Al Maloney  ---
(In reply to Heiko Tietze from comment #10)
> (In reply to Al Maloney from comment #9)
> > How do the icons make searching and choosing better than a list?
> 
> If you search by description the list together with a preview is the perfect
> control. But most people would have the picture in mind how the template
> look. And that's better supported by several images - the icon view. So I'd
> say either the developers allow to switch from icon to list view or WONTFIX.
> 
> Have you taken a look at the latest build? The filter and search options are
> very handy and may help you as well.

Yes. I have looked at it in the version noted in my post.
The changes are promising.
Although not what I had in mind, they are an improvement if I am using them
properly.

First I select the application eg Document=Writer, Spreadsheet=Calc, etc.
Then I select a Category.
This produces a screen with fewer items which is easier to navigate.

I think this is workable for me.

One suggestion - If a category is empty for a given application, then it is
suppressed from the list of choices for that application.

Thank you to all who are working on this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 90689] EDITING: Calc crash when modifying multiple cells of formulas

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90689

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #10 from Caolán McNamara  ---


*** This bug has been marked as a duplicate of bug 99733 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94777] Base Reports to Multi-User (MariaDB) not locking to user

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94777

--- Comment #8 from rob...@familiegrosskopf.de ---
Could be the reporter will have a report, which is special for the user with
the actual CONNECTION_ID(). Or should it be filtered by the USER()?

This isn't a Base-problem. This must be defined by the query, which defines the
data for the report.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91474] [a11y] Crash invoking "press" accessibility action in " Pivot Table Layout" dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91474

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Caolán McNamara  ---
Confirmed crash in lo-linux-dbgutil-daily-till50, confirmed no crash in current
5-1 so closing as fixed (somehow or other)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66953] PDF: import PDF does not present the image poperly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66953

--- Comment #10 from Daniël van Vuuren  ---
Created attachment 125470
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125470=edit
Screenshot Draw Linux from original pdf

Doesn't show correctly here.
All images in import from pdf attachment 82472 are flipped vertically.

Version: 5.3.0.0.alpha0+
Build ID: 6b3b352b06d92ef20194b9a992a521af2ef07b48
CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2016-06-03_01:35:48

Same result in these versions:
Version: 5.2.0.0.beta1+
Build ID: b6230835b927e0053687fae6026fa3603600f321
CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:libreoffice-5-2, Time:
2016-06-03_02:09:38

Version: 5.1.5.0.0+
Build ID: 1245bead3a68c9495a870f194f3c523b3b78cf87
CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:libreoffice-5-1, Time:
2016-06-02_04:43:39

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: xmloff/source

[krishna keshav]

 xmloff/source/text/txtimp.cxx |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit faaacb997b3c404048bd986caf9e4b5f5263cb3c
Author: krishna keshav 
Date:   Thu Jun 2 21:40:05 2016 +0530

tdf#96099 Reduce number of typedefs used for trivial container types

Change-Id: I1ec93e281d7c2648a150c98144905f1158502dcc
Reviewed-on: https://gerrit.libreoffice.org/25835
Reviewed-by: Akshay Deep 
Tested-by: Akshay Deep 

diff --git a/xmloff/source/text/txtimp.cxx b/xmloff/source/text/txtimp.cxx
index 08dafaf..5d6abd9 100644
--- a/xmloff/source/text/txtimp.cxx
+++ b/xmloff/source/text/txtimp.cxx
@@ -532,8 +532,7 @@ struct XMLTextImportHelper::Impl
 /// start ranges for open bookmarks
 std::map< OUString, BookmarkMapEntry_t > m_BookmarkStartRanges;
 
-typedef std::vector< OUString > BookmarkVector_t;
-BookmarkVector_t m_BookmarkVector;
+std::vector< OUString > m_BookmarkVector;
 
 /// name of the last 'open' redline that started between paragraphs
 OUString m_sOpenRedlineIdentifier;
@@ -2516,7 +2515,7 @@ bool XMLTextImportHelper::FindAndRemoveBookmarkStartRange(
 o_rXmlId = std::get<1>(rEntry);
 o_rpRDFaAttributes = std::get<2>(rEntry);
 m_xImpl->m_BookmarkStartRanges.erase(sName);
-Impl::BookmarkVector_t::iterator it(m_xImpl->m_BookmarkVector.begin());
+auto it(m_xImpl->m_BookmarkVector.begin());
 while (it != m_xImpl->m_BookmarkVector.end() && 
it->compareTo(sName)!=0)
 {
 ++it;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96099] Reduce number of typedefs used for trivial container types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96099

--- Comment #26 from Commit Notification 
 ---
krishna keshav committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=faaacb997b3c404048bd986caf9e4b5f5263cb3c

tdf#96099 Reduce number of typedefs used for trivial container types

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 50821] [FILEOPEN] Bad RTF Document formating/ margins

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=50821

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk
   |desktop.org |

--- Comment #10 from Miklos Vajna  ---
I can reproduce the table cell margin problem: both left and right margins
should be 0.19cm, but they are 0. That's why the line below the "No" character
overlaps with the black border. I'll take care of this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

[Akshay Deep]

 include/sfx2/templateabstractview.hxx|2 ++
 include/sfx2/templatedefaultview.hxx |2 ++
 sfx2/source/control/templateabstractview.cxx |   23 +++
 sfx2/source/control/templatedefaultview.cxx  |5 +
 4 files changed, 32 insertions(+)

New commits:
commit 74f6f03f55eb6d641d2b26aae883943c69683563
Author: Akshay Deep 
Date:   Fri Jun 3 16:51:05 2016 +0530

Template Manager: Ctrl + A to select all templates

Change-Id: I8398268752c78a30d5fc076d6f2b6249cbf89ec2
Reviewed-on: https://gerrit.libreoffice.org/25860
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/include/sfx2/templateabstractview.hxx 
b/include/sfx2/templateabstractview.hxx
index 5b70fe1..5a7 100644
--- a/include/sfx2/templateabstractview.hxx
+++ b/include/sfx2/templateabstractview.hxx
@@ -83,6 +83,8 @@ public:
 
 virtual void MouseButtonDown( const MouseEvent& rMEvt ) override;
 
+virtual void KeyInput( const KeyEvent& rKEvt ) override;
+
 virtual void showAllTemplates () = 0;
 
 virtual void showRegion (TemplateContainerItem *pItem) = 0;
diff --git a/include/sfx2/templatedefaultview.hxx 
b/include/sfx2/templatedefaultview.hxx
index 24157a1..6d2fcdf 100644
--- a/include/sfx2/templatedefaultview.hxx
+++ b/include/sfx2/templatedefaultview.hxx
@@ -19,6 +19,8 @@ public:
 
 virtual void reload() override;
 
+virtual void KeyInput( const KeyEvent& rKEvt ) override;
+
 void createContextMenu();
 
 DECL_LINK_TYPED(ContextMenuSelectHdl, Menu*, void);
diff --git a/sfx2/source/control/templateabstractview.cxx 
b/sfx2/source/control/templateabstractview.cxx
index 7bfd0a2..cf0f497 100644
--- a/sfx2/source/control/templateabstractview.cxx
+++ b/sfx2/source/control/templateabstractview.cxx
@@ -168,6 +168,29 @@ void TemplateAbstractView::MouseButtonDown( const 
MouseEvent& rMEvt )
 ThumbnailView::MouseButtonDown(rMEvt);
 }
 
+void TemplateAbstractView::KeyInput( const KeyEvent& rKEvt )
+{
+vcl::KeyCode aKeyCode = rKEvt.GetKeyCode();
+
+if(aKeyCode == ( KEY_MOD1 | KEY_A ) )
+{
+for (ThumbnailViewItem* pItem : mItemList)
+{
+if (!pItem->isSelected())
+{
+pItem->setSelection(true);
+maItemStateHdl.Call(pItem);
+}
+}
+
+if (IsReallyVisible() && IsUpdateMode())
+Invalidate();
+return;
+}
+
+ThumbnailView::KeyInput(rKEvt);
+}
+
 
 void TemplateAbstractView::setOpenRegionHdl(const Link )
 {
diff --git a/sfx2/source/control/templatedefaultview.cxx 
b/sfx2/source/control/templatedefaultview.cxx
index 76e08ea..d6ffb63 100644
--- a/sfx2/source/control/templatedefaultview.cxx
+++ b/sfx2/source/control/templatedefaultview.cxx
@@ -48,6 +48,11 @@ void TemplateDefaultView::reload()
 set_width_request(mnTextHeight + mnItemMaxSize + 2*mnItemPadding);
 }
 
+void TemplateDefaultView::KeyInput( const KeyEvent& rKEvt )
+{
+ThumbnailView::KeyInput(rKEvt);
+}
+
 void TemplateDefaultView::createContextMenu()
 {
 std::unique_ptr pItemMenu(new PopupMenu);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98880] LO crashes when making too many calls of a user-defined function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98880

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98880] LO crashes when making too many calls of a user-defined function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98880

--- Comment #8 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fb433b7909d049f12e848ad56ae8b406f91e1cc2=libreoffice-5-1

Resolves: tdf#98880 ensure backing context of DoubleVectorRefToken...

It will be available in 5.1.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98880] LO crashes when making too many calls of a user-defined function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98880

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0 target:5.2.0.1 |target:5.3.0 target:5.2.0.1
   ||target:5.1.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sc/inc sc/source

[Caolán McNamara]

 sc/inc/document.hxx |4 ++--
 sc/source/core/data/column2.cxx |2 +-
 sc/source/core/data/document.cxx|4 ++--
 sc/source/core/data/grouptokenconverter.cxx |   18 ++
 sc/source/core/inc/grouptokenconverter.hxx  |1 +
 5 files changed, 24 insertions(+), 5 deletions(-)

New commits:
commit fb433b7909d049f12e848ad56ae8b406f91e1cc2
Author: Caolán McNamara 
Date:   Thu Jun 2 11:18:02 2016 +0100

Resolves: tdf#98880 ensure backing context of DoubleVectorRefToken...

exists for the lifetime of the ScGroupTokenConverter

otherwise in tdf#98880 ScDocument::InterpretDirtyCells releases
that backing storage that the DoubleVectorRefToken relies on, and
the ScVectorRefMatrix relies on that, so...

when sc/source/core/tool/interpr4.cxx calls ::IsString on the 
ScVectorRefMatrix
which calls ensureFullMatrix. That makes use of rArray.mpStringArray where
rArray's mpStringArray is set to that rArray by
FormulaGroupContext::ensureStrArray and the storage of mpStringArray 
belongs to
the FormulaGroupContext, but that context was reset and destroyed up the 
stack
in ScDocument::InterpretDirtyCells so the data is now invalid

We could turn the unique_ptr into a shared_ptr and have the 
ScGroupTokenConverter
take a ref to the currently active FormulaGroupContext to ensure any 
generated
DoubleVectorRefToken/SingleVectorRefToken point to valid data during the
lifetime of the ScGroupTokenConverter

Change-Id: Id457934cdff18570961cb261cf5c46b6ef8ea083
Reviewed-on: https://gerrit.libreoffice.org/25815
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 
(cherry picked from commit dc78e5c6f5f55b0289012f4c4e6013d2935b1cc6)
Reviewed-on: https://gerrit.libreoffice.org/25867
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 194fc7d..16db763 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -290,7 +290,7 @@ private:
 rtl::Reference xPoolHelper;
 
 std::shared_ptr mpCellStringPool;
-std::unique_ptr mpFormulaGroupCxt;
+std::shared_ptr mpFormulaGroupCxt;
 mutable std::unique_ptr mpDocLinkMgr;
 
 ScCalcConfigmaCalcConfig;
@@ -924,7 +924,7 @@ public:
 
 svl::SharedString GetSharedString( const ScAddress& rPos ) const;
 
-sc::FormulaGroupContext& GetFormulaGroupContext();
+std::shared_ptr& GetFormulaGroupContext();
 
 SC_DLLPUBLIC void GetInputString( SCCOL nCol, SCROW nRow, SCTAB nTab, 
OUString& rString );
 sal_uInt16 GetStringForFormula( const ScAddress& rPos, OUString& rString );
diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index 8c15aae..2287b3b 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -2550,7 +2550,7 @@ formula::VectorRefArray ScColumn::FetchVectorRefArray( 
SCROW nRow1, SCROW nRow2
 return formula::VectorRefArray(formula::VectorRefArray::Invalid);
 
 // See if the requested range is already cached.
-sc::FormulaGroupContext& rCxt = pDocument->GetFormulaGroupContext();
+sc::FormulaGroupContext& rCxt = *(pDocument->GetFormulaGroupContext());
 sc::FormulaGroupContext::ColArray* pColArray = 
rCxt.getCachedColArray(nTab, nCol, nRow2+1);
 if (pColArray)
 {
diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index c0f4fa3..721877f 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -3442,12 +3442,12 @@ svl::SharedString ScDocument::GetSharedString( const 
ScAddress& rPos ) const
 return maTabs[rPos.Tab()]->GetSharedString(rPos.Col(), rPos.Row());
 }
 
-sc::FormulaGroupContext& ScDocument::GetFormulaGroupContext()
+std::shared_ptr& ScDocument::GetFormulaGroupContext()
 {
 if (!mpFormulaGroupCxt)
 mpFormulaGroupCxt.reset(new sc::FormulaGroupContext);
 
-return *mpFormulaGroupCxt;
+return mpFormulaGroupCxt;
 }
 
 void ScDocument::GetInputString( SCCOL nCol, SCROW nRow, SCTAB nTab, OUString& 
rString )
diff --git a/sc/source/core/data/grouptokenconverter.cxx 
b/sc/source/core/data/grouptokenconverter.cxx
index de3fbf2..7b31e35 100644
--- a/sc/source/core/data/grouptokenconverter.cxx
+++ b/sc/source/core/data/grouptokenconverter.cxx
@@ -135,6 +135,15 @@ bool ScGroupTokenConverter::convert(ScTokenArray& rCode, 
std::vector mxFormulaGroupContext;
 ScFormulaCell& mrCell;
 const ScAddress& mrPos;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98880] LO crashes when making too many calls of a user-defined function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98880

--- Comment #7 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=57f8094fd312114d670ac4cdbdfd18b80b2c67e5=libreoffice-5-2

Resolves: tdf#98880 ensure backing context of DoubleVectorRefToken...

It will be available in 5.2.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/inc sc/source

[Caolán McNamara]

 sc/inc/document.hxx |4 ++--
 sc/source/core/data/column2.cxx |2 +-
 sc/source/core/data/document.cxx|4 ++--
 sc/source/core/data/grouptokenconverter.cxx |   18 ++
 sc/source/core/inc/grouptokenconverter.hxx  |1 +
 5 files changed, 24 insertions(+), 5 deletions(-)

New commits:
commit 57f8094fd312114d670ac4cdbdfd18b80b2c67e5
Author: Caolán McNamara 
Date:   Thu Jun 2 11:18:02 2016 +0100

Resolves: tdf#98880 ensure backing context of DoubleVectorRefToken...

exists for the lifetime of the ScGroupTokenConverter

otherwise in tdf#98880 ScDocument::InterpretDirtyCells releases
that backing storage that the DoubleVectorRefToken relies on, and
the ScVectorRefMatrix relies on that, so...

when sc/source/core/tool/interpr4.cxx calls ::IsString on the 
ScVectorRefMatrix
which calls ensureFullMatrix. That makes use of rArray.mpStringArray where
rArray's mpStringArray is set to that rArray by
FormulaGroupContext::ensureStrArray and the storage of mpStringArray 
belongs to
the FormulaGroupContext, but that context was reset and destroyed up the 
stack
in ScDocument::InterpretDirtyCells so the data is now invalid

We could turn the unique_ptr into a shared_ptr and have the 
ScGroupTokenConverter
take a ref to the currently active FormulaGroupContext to ensure any 
generated
DoubleVectorRefToken/SingleVectorRefToken point to valid data during the
lifetime of the ScGroupTokenConverter

Change-Id: Id457934cdff18570961cb261cf5c46b6ef8ea083
Reviewed-on: https://gerrit.libreoffice.org/25815
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 
(cherry picked from commit dc78e5c6f5f55b0289012f4c4e6013d2935b1cc6)
Reviewed-on: https://gerrit.libreoffice.org/25866
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 5696f26..b17296e 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -299,7 +299,7 @@ private:
 rtl::Reference xPoolHelper;
 
 std::shared_ptr mpCellStringPool;
-std::unique_ptr mpFormulaGroupCxt;
+std::shared_ptr mpFormulaGroupCxt;
 mutable std::unique_ptr mpDocLinkMgr;
 
 ScCalcConfigmaCalcConfig;
@@ -1050,7 +1050,7 @@ public:
 
 svl::SharedString GetSharedString( const ScAddress& rPos ) const;
 
-sc::FormulaGroupContext& GetFormulaGroupContext();
+std::shared_ptr& GetFormulaGroupContext();
 
 SC_DLLPUBLIC void GetInputString( SCCOL nCol, SCROW nRow, SCTAB nTab, 
OUString& rString );
 sal_uInt16 GetStringForFormula( const ScAddress& rPos, OUString& rString );
diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index 19a7aed..a32b2f7 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -2560,7 +2560,7 @@ formula::VectorRefArray ScColumn::FetchVectorRefArray( 
SCROW nRow1, SCROW nRow2
 return formula::VectorRefArray(formula::VectorRefArray::Invalid);
 
 // See if the requested range is already cached.
-sc::FormulaGroupContext& rCxt = pDocument->GetFormulaGroupContext();
+sc::FormulaGroupContext& rCxt = *(pDocument->GetFormulaGroupContext());
 sc::FormulaGroupContext::ColArray* pColArray = 
rCxt.getCachedColArray(nTab, nCol, nRow2+1);
 if (pColArray)
 {
diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index f5ad18c..1ae8454 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -3443,12 +3443,12 @@ svl::SharedString ScDocument::GetSharedString( const 
ScAddress& rPos ) const
 return maTabs[rPos.Tab()]->GetSharedString(rPos.Col(), rPos.Row());
 }
 
-sc::FormulaGroupContext& ScDocument::GetFormulaGroupContext()
+std::shared_ptr& ScDocument::GetFormulaGroupContext()
 {
 if (!mpFormulaGroupCxt)
 mpFormulaGroupCxt.reset(new sc::FormulaGroupContext);
 
-return *mpFormulaGroupCxt;
+return mpFormulaGroupCxt;
 }
 
 void ScDocument::GetInputString( SCCOL nCol, SCROW nRow, SCTAB nTab, OUString& 
rString )
diff --git a/sc/source/core/data/grouptokenconverter.cxx 
b/sc/source/core/data/grouptokenconverter.cxx
index da3964c..22b89a6 100644
--- a/sc/source/core/data/grouptokenconverter.cxx
+++ b/sc/source/core/data/grouptokenconverter.cxx
@@ -135,6 +135,15 @@ bool ScGroupTokenConverter::convert(ScTokenArray& rCode)
 
 formula::SingleVectorRefToken aTok(aArray, nLen, nTrimLen);
 mrGroupTokens.AddToken(aTok);
+
+if (nTrimLen && !mxFormulaGroupContext)
+{
+//tdf#98880 if the SingleVectorRefToken relies on the
+//underlying storage provided by the Document
+   

[Libreoffice-bugs] [Bug 98880] LO crashes when making too many calls of a user-defined function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98880

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0|target:5.3.0 target:5.2.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96008] LibO Writer crashes when an extension is installed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96008

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96008] LibO Writer crashes when an extension is installed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96008

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0|target:5.3.0 target:5.2.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96008] LibO Writer crashes when an extension is installed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96008

--- Comment #10 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=89d38b8e0201861edbdad826e28f993aba8786be=libreoffice-5-2

Resolves: tdf#96008 crash when an extension with legacy decks is installed

It will be available in 5.2.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - include/sfx2 sfx2/source

[Caolán McNamara]

 include/sfx2/sidebar/ResourceManager.hxx  |   15 +--
 include/sfx2/sidebar/TabBar.hxx   |   14 +-
 sfx2/source/sidebar/ResourceManager.cxx   |  144 +-
 sfx2/source/sidebar/Sidebar.cxx   |   18 +--
 sfx2/source/sidebar/SidebarController.cxx |   57 +--
 sfx2/source/sidebar/TabBar.cxx|   42 
 sfx2/source/sidebar/UnoDeck.cxx   |   41 
 sfx2/source/sidebar/UnoPanel.cxx  |   36 +++
 8 files changed, 174 insertions(+), 193 deletions(-)

New commits:
commit 89d38b8e0201861edbdad826e28f993aba8786be
Author: Caolán McNamara 
Date:   Fri Jun 3 14:04:44 2016 +0100

Resolves: tdf#96008 crash when an extension with legacy decks is installed

ReadLegacyAddons modifies its vectors of maDecks and maPanels in this case, 
but
a load of things have (c++) references contents of the original contents.

Its such a rats nest that the easiest thing seems to be to make them
vectors of shared_ptrs and hold DeckDescriptor and PanelDescriptor
by shared_ptr and it all works out

Change-Id: I3f628e12c7d5f4224d14d5e0769e450ce893fb54
(cherry picked from commit fce299fc64fcfe5280966631613edda7e6031c16)

diff --git a/include/sfx2/sidebar/ResourceManager.hxx 
b/include/sfx2/sidebar/ResourceManager.hxx
index 3cf0df9..c545652 100644
--- a/include/sfx2/sidebar/ResourceManager.hxx
+++ b/include/sfx2/sidebar/ResourceManager.hxx
@@ -43,11 +43,8 @@ public:
  ResourceManager();
 ~ResourceManager();
 
-const DeckDescriptor* GetDeckDescriptor(const OUString& rsDeckId) const;
-DeckDescriptor* GetDeckDescriptor(const OUString& rsDeckId);
-
-const PanelDescriptor* GetPanelDescriptor(const OUString& rsPanelId) const;
-PanelDescriptor* GetPanelDescriptor(const OUString& rsPanelId);
+std::shared_ptr GetDeckDescriptor(const OUString& 
rsDeckId) const;
+std::shared_ptr GetPanelDescriptor(const OUString& 
rsPanelId) const;
 
 void UpdateModel(const css::uno::Reference& xModel);
 
@@ -96,10 +93,10 @@ public:
 private:
 
 
-typedef std::vector DeckContainer;
+typedef std::vector DeckContainer;
 DeckContainer maDecks;
 
-typedef std::vector PanelContainer;
+typedef std::vector PanelContainer;
 PanelContainer maPanels;
 mutable std::set maProcessedApplications;
 
@@ -119,8 +116,8 @@ private:
const Context& rContext,
const css::uno::Reference& 
rxController);
 
-const DeckDescriptor* ImplGetDeckDescriptor(const OUString& rsDeckId) 
const;
-const PanelDescriptor* ImplGetPanelDescriptor(const OUString& rsPanelId) 
const;
+std::shared_ptr ImplGetDeckDescriptor(const OUString& 
rsDeckId) const;
+std::shared_ptr ImplGetPanelDescriptor(const OUString& 
rsPanelId) const;
 };
 
 } } // end of namespace sfx2::sidebar
diff --git a/include/sfx2/sidebar/TabBar.hxx b/include/sfx2/sidebar/TabBar.hxx
index 0115896..5a8c0cd 100644
--- a/include/sfx2/sidebar/TabBar.hxx
+++ b/include/sfx2/sidebar/TabBar.hxx
@@ -55,8 +55,8 @@ public:
 class DeckMenuData
 {
 public:
-::rtl::OUString msDisplayName;
-::rtl::OUString msDeckId;
+OUString msDisplayName;
+OUString msDeckId;
 bool mbIsCurrentDeck;
 bool mbIsActive;
 bool mbIsEnabled;
@@ -67,7 +67,7 @@ public:
 TabBar (
 vcl::Window* pParentWindow,
 const css::uno::Reference& rxFrame,
-const ::std::function& 
rDeckActivationFunctor,
+const ::std::function& 
rDeckActivationFunctor,
 const PopupMenuProvider& rPopupMenuProvider,
 SidebarController* rParentSidebarController);
 
@@ -82,9 +82,9 @@ public:
 
 void SetDecks (
 const ResourceManager::DeckContextDescriptorContainer& rDecks);
-void HighlightDeck (const ::rtl::OUString& rsDeckId);
+void HighlightDeck (const OUString& rsDeckId);
 void RemoveDeckHighlight ();
-const ::rtl::OUString GetDeckIdForIndex (const sal_Int32 nIndex) const;
+const OUString GetDeckIdForIndex (const sal_Int32 nIndex) const;
 void ToggleHideFlag (const sal_Int32 nIndex);
 void RestoreHideFlags();
 
@@ -99,13 +99,13 @@ private:
 DECL_LINK_TYPED(HandleClick, Button*, void);
 VclPtr mpButton;
 OUString msDeckId;
-::std::function 
maDeckActivationFunctor;
+::std::function 
maDeckActivationFunctor;
 bool mbIsHidden;
 bool mbIsHiddenByDefault;
 };
 typedef ::std::vector ItemContainer;
 ItemContainer maItems;
-const ::std::function 
maDeckActivationFunctor;
+const ::std::function 
maDeckActivationFunctor;
 sal_Int32 mnMenuSeparatorY;
 PopupMenuProvider maPopupMenuProvider;
 
diff --git a/sfx2/source/sidebar/ResourceManager.cxx 
b/sfx2/source/sidebar/ResourceManager.cxx
index 6951f7c..8958f3b 100644
--- a/sfx2/source/sidebar/ResourceManager.cxx
+++ 

[Libreoffice-ux-advise] [Bug 100195] StartCenter keyboard navigation for the new Template Manager

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100195

--- Comment #2 from Commit Notification 
 ---
Akshay Deep committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9b7bf60536bfab26445c0165f50392c1258c4cda

tdf#100195 Enable Keyboard Navigation in Template Manager and Start Center

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 100195] StartCenter keyboard navigation for the new Template Manager

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100195

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

[Akshay Deep]

 include/sfx2/templateabstractview.hxx|2 +-
 sfx2/source/control/templateabstractview.cxx |   14 --
 sfx2/source/control/templatelocalview.cxx|4 ++--
 sfx2/source/control/templatesearchview.cxx   |2 ++
 sfx2/source/dialog/backingwindow.cxx |   21 +
 sfx2/source/doc/templatedlg.cxx  |4 ++--
 6 files changed, 36 insertions(+), 11 deletions(-)

New commits:
commit 9b7bf60536bfab26445c0165f50392c1258c4cda
Author: Akshay Deep 
Date:   Fri Jun 3 03:43:09 2016 +0530

tdf#100195 Enable Keyboard Navigation in Template Manager and Start Center

Change-Id: Ic5447a4af091a4e3dcab4d909fc6bfb9e559defb
Reviewed-on: https://gerrit.libreoffice.org/25848
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/include/sfx2/templateabstractview.hxx 
b/include/sfx2/templateabstractview.hxx
index 9d368c6..5b70fe1 100644
--- a/include/sfx2/templateabstractview.hxx
+++ b/include/sfx2/templateabstractview.hxx
@@ -74,7 +74,7 @@ public:
 virtual void dispose() override;
 
 // Fill view with new item list
-void insertItems (const std::vector );
+void insertItems (const std::vector , 
bool isRegionSelected = true);
 
 // Fill view with template folders thumbnails
 virtual void Populate () { }
diff --git a/sfx2/source/control/templateabstractview.cxx 
b/sfx2/source/control/templateabstractview.cxx
index 27dd8ff..7bfd0a2 100644
--- a/sfx2/source/control/templateabstractview.cxx
+++ b/sfx2/source/control/templateabstractview.cxx
@@ -104,14 +104,21 @@ void TemplateAbstractView::dispose()
 ThumbnailView::dispose();
 }
 
-void TemplateAbstractView::insertItems(const 
std::vector )
+void TemplateAbstractView::insertItems(const 
std::vector , bool isRegionSelected)
 {
+mItemList.clear();
+
 std::vector aItems(rTemplates.size());
 for (size_t i = 0, n = rTemplates.size(); i < n; ++i )
 {
 const TemplateItemProperties *pCur = [i];
 
-TemplateViewItem *pChild = new TemplateViewItem(*this, pCur->nId);
+TemplateViewItem *pChild;
+if(isRegionSelected)
+pChild = new TemplateViewItem(*this, pCur->nId);
+else
+pChild = new TemplateViewItem(*this, i+1);
+
 pChild->mnDocId = pCur->nDocId;
 pChild->mnRegionId = pCur->nRegionId;
 pChild->maTitle = pCur->aName;
@@ -140,8 +147,11 @@ void TemplateAbstractView::updateThumbnailDimensions(long 
itemMaxSize)
 
 void TemplateAbstractView::MouseButtonDown( const MouseEvent& rMEvt )
 {
+GrabFocus();
+
 if (rMEvt.IsRight())
 {
+deselectItems();
 size_t nPos = ImplGetItem(rMEvt.GetPosPixel());
 Point aPosition (rMEvt.GetPosPixel());
 maPosition = aPosition;
diff --git a/sfx2/source/control/templatelocalview.cxx 
b/sfx2/source/control/templatelocalview.cxx
index 14d5c39..5174778 100644
--- a/sfx2/source/control/templatelocalview.cxx
+++ b/sfx2/source/control/templatelocalview.cxx
@@ -143,7 +143,7 @@ void TemplateLocalView::showAllTemplates()
 mnCurRegionId = 0;
 maCurRegionName.clear();
 
-insertItems(maAllTemplates);
+insertItems(maAllTemplates, false);
 maOpenRegionHdl.Call(nullptr);
 }
 
@@ -575,7 +575,7 @@ bool TemplateLocalView::moveTemplates(const std::setnDocId == pViewItem->mnDocId)
 {
 pPropIter = pSrc->maTemplates.erase(pPropIter);
-aItemIds.push_back(pViewItem->mnId);
+aItemIds.push_back(pViewItem->mnDocId + 1);//mnid
 }
 else
 {
diff --git a/sfx2/source/control/templatesearchview.cxx 
b/sfx2/source/control/templatesearchview.cxx
index 9f85171..3075d40 100644
--- a/sfx2/source/control/templatesearchview.cxx
+++ b/sfx2/source/control/templatesearchview.cxx
@@ -33,8 +33,10 @@ VCL_BUILDER_FACTORY(TemplateSearchView)
 
 void TemplateSearchView::MouseButtonDown( const MouseEvent& rMEvt )
 {
+GrabFocus();
 if (rMEvt.IsRight())
 {
+deselectItems();
 size_t nPos = ImplGetItem(rMEvt.GetPosPixel());
 Point aPosition (rMEvt.GetPosPixel());
 maPosition = aPosition;
diff --git a/sfx2/source/dialog/backingwindow.cxx 
b/sfx2/source/dialog/backingwindow.cxx
index 5c81eb8..20e97a7 100644
--- a/sfx2/source/dialog/backingwindow.cxx
+++ b/sfx2/source/dialog/backingwindow.cxx
@@ -392,7 +392,7 @@ bool BackingWindow::PreNotify( NotifyEvent& rNEvt )
 {
 if( rKeyCode.IsShift() ) // Shift + F6
 {
-if( mpAllRecentThumbnails->HasFocus() )
+if( mpAllRecentThumbnails->HasFocus() || 
mpLocalView->HasFocus())
 {
 mpOpenButton->GrabFocus();
 return true;
@@ -400,16 +400,29 @@ bool 

[Libreoffice-bugs] [Bug 100205] Libre 5- Pivot is not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100205

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
Please provide more information:
- Environment
- Version
- Description of the problem
- Steps to reproduce, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - desktop/source

[Stephan Bergmann]

 desktop/source/app/officeipcthread.cxx |   63 +
 1 file changed, 48 insertions(+), 15 deletions(-)

New commits:
commit 97c62e9c9a589d15a8ac05ad949857503ac7e7f4
Author: Stephan Bergmann 
Date:   Fri Jun 3 16:20:31 2016 +0200

A slightly better DbusIpcThread

...that doesn't burn CPU by always directly returning again from a
dbus_connection_read_write call with zero timeout.  But still doesn't look 
like
it uses DBus the way it's intended to.  Help appreciated.

Change-Id: I0d130adfb921409a27a847053b0b3646dc566a86
(cherry picked from commit a4740c8ea92cc50c1dc6e87d06db190800269a5d)
Reviewed-on: https://gerrit.libreoffice.org/25869
Reviewed-by: Stephan Bergmann 
Tested-by: Stephan Bergmann 

diff --git a/desktop/source/app/officeipcthread.cxx 
b/desktop/source/app/officeipcthread.cxx
index c067a92..8b446d20 100644
--- a/desktop/source/app/officeipcthread.cxx
+++ b/desktop/source/app/officeipcthread.cxx
@@ -46,6 +46,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -405,20 +406,17 @@ struct DbusConnectionHolder {
 connection(theConnection)
 {}
 
-~DbusConnectionHolder() { clear(); }
+DbusConnectionHolder(DbusConnectionHolder && other): connection(nullptr)
+{ std::swap(connection, other.connection); }
 
-void clear() {
+~DbusConnectionHolder() {
 if (connection != nullptr) {
+dbus_connection_close(connection);
 dbus_connection_unref(connection);
 }
-connection = nullptr;
 }
 
 DBusConnection * connection;
-
-private:
-DbusConnectionHolder(DbusConnectionHolder &) = delete;
-void operator =(DbusConnectionHolder) = delete;
 };
 
 struct DbusMessageHolder {
@@ -447,8 +445,8 @@ public:
 static RequestHandler::Status enable(rtl::Reference * thread);
 
 private:
-explicit DbusIpcThread(DBusConnection * connection):
-IpcThread("DbusIPC"), connection_(connection)
+explicit DbusIpcThread(DbusConnectionHolder && connection):
+IpcThread("DbusIPC"), connection_(std::move(connection))
 {}
 
 virtual ~DbusIpcThread() {}
@@ -469,12 +467,13 @@ RequestHandler::Status 
DbusIpcThread::enable(rtl::Reference * thread)
 }
 DBusError e;
 dbus_error_init();
-DbusConnectionHolder con(dbus_bus_get(DBUS_BUS_SESSION, ));
+DbusConnectionHolder con(dbus_bus_get_private(DBUS_BUS_SESSION, ));
 assert((con.connection == nullptr) == bool(dbus_error_is_set()));
 if (con.connection == nullptr) {
 SAL_WARN(
 "desktop.app",
-"dbus_bus_get failed with: " << e.name << ": " << e.message);
+"dbus_bus_get_private failed with: " << e.name << ": "
+<< e.message);
 dbus_error_free();
 return RequestHandler::IPC_STATUS_BOOTSTRAP_ERROR;
 }
@@ -492,8 +491,7 @@ RequestHandler::Status 
DbusIpcThread::enable(rtl::Reference * thread)
 dbus_error_free();
 return RequestHandler::IPC_STATUS_BOOTSTRAP_ERROR;
 case DBUS_REQUEST_NAME_REPLY_PRIMARY_OWNER:
-*thread = new DbusIpcThread(con.connection);
-con.connection = nullptr;
+*thread = new DbusIpcThread(std::move(con));
 return RequestHandler::IPC_STATUS_OK;
 case DBUS_REQUEST_NAME_REPLY_EXISTS:
 {
@@ -569,12 +567,17 @@ void DbusIpcThread::execute()
 break;
 }
 }
-dbus_connection_read_write(connection_.connection, 0);
+dbus_connection_read_write_dispatch(connection_.connection, -1);
 DbusMessageHolder msg(
 dbus_connection_pop_message(connection_.connection));
 if (msg.message == nullptr) {
 continue;
 }
+if (dbus_message_is_method_call(
+msg.message, "org.libreoffice.LibreOfficeIpcIfc0", "Close"))
+{
+break;
+}
 if (!dbus_message_is_method_call(
 msg.message, "org.libreoffice.LibreOfficeIpcIfc0", "Execute"))
 {
@@ -622,6 +625,37 @@ void DbusIpcThread::close() {
 assert(connection_.connection != nullptr);
 DBusError e;
 dbus_error_init();
+{
+// Let DbusIpcThread::execute return from dbus_connection_read_write;
+// for now, just abort on failure (the process would otherwise block,
+// with DbusIpcThread::execute hanging in dbus_connection_read_write);
+// this apparently needs a more DBus-y design anyway:
+DbusConnectionHolder con(dbus_bus_get_private(DBUS_BUS_SESSION, ));
+assert((con.connection == nullptr) == bool(dbus_error_is_set()));
+if (con.connection == nullptr) {
+SAL_WARN(
+"desktop.app",
+"dbus_bus_get_private failed with: " << e.name << ": "
+<< e.message);
+dbus_error_free();
+  

[Libreoffice-commits] core.git: desktop/source

[Stephan Bergmann]

 desktop/source/app/officeipcthread.cxx |   63 +
 1 file changed, 48 insertions(+), 15 deletions(-)

New commits:
commit a4740c8ea92cc50c1dc6e87d06db190800269a5d
Author: Stephan Bergmann 
Date:   Fri Jun 3 16:20:31 2016 +0200

A slightly better DbusIpcThread

...that doesn't burn CPU by always directly returning again from a
dbus_connection_read_write call with zero timeout.  But still doesn't look 
like
it uses DBus the way it's intended to.  Help appreciated.

Change-Id: I0d130adfb921409a27a847053b0b3646dc566a86

diff --git a/desktop/source/app/officeipcthread.cxx 
b/desktop/source/app/officeipcthread.cxx
index 31635e8..3990944 100644
--- a/desktop/source/app/officeipcthread.cxx
+++ b/desktop/source/app/officeipcthread.cxx
@@ -46,6 +46,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -405,20 +406,17 @@ struct DbusConnectionHolder {
 connection(theConnection)
 {}
 
-~DbusConnectionHolder() { clear(); }
+DbusConnectionHolder(DbusConnectionHolder && other): connection(nullptr)
+{ std::swap(connection, other.connection); }
 
-void clear() {
+~DbusConnectionHolder() {
 if (connection != nullptr) {
+dbus_connection_close(connection);
 dbus_connection_unref(connection);
 }
-connection = nullptr;
 }
 
 DBusConnection * connection;
-
-private:
-DbusConnectionHolder(DbusConnectionHolder &) = delete;
-void operator =(DbusConnectionHolder) = delete;
 };
 
 struct DbusMessageHolder {
@@ -447,8 +445,8 @@ public:
 static RequestHandler::Status enable(rtl::Reference * thread);
 
 private:
-explicit DbusIpcThread(DBusConnection * connection):
-IpcThread("DbusIPC"), connection_(connection)
+explicit DbusIpcThread(DbusConnectionHolder && connection):
+IpcThread("DbusIPC"), connection_(std::move(connection))
 {}
 
 virtual ~DbusIpcThread() {}
@@ -469,12 +467,13 @@ RequestHandler::Status 
DbusIpcThread::enable(rtl::Reference * thread)
 }
 DBusError e;
 dbus_error_init();
-DbusConnectionHolder con(dbus_bus_get(DBUS_BUS_SESSION, ));
+DbusConnectionHolder con(dbus_bus_get_private(DBUS_BUS_SESSION, ));
 assert((con.connection == nullptr) == bool(dbus_error_is_set()));
 if (con.connection == nullptr) {
 SAL_WARN(
 "desktop.app",
-"dbus_bus_get failed with: " << e.name << ": " << e.message);
+"dbus_bus_get_private failed with: " << e.name << ": "
+<< e.message);
 dbus_error_free();
 return RequestHandler::IPC_STATUS_BOOTSTRAP_ERROR;
 }
@@ -492,8 +491,7 @@ RequestHandler::Status 
DbusIpcThread::enable(rtl::Reference * thread)
 dbus_error_free();
 return RequestHandler::IPC_STATUS_BOOTSTRAP_ERROR;
 case DBUS_REQUEST_NAME_REPLY_PRIMARY_OWNER:
-*thread = new DbusIpcThread(con.connection);
-con.connection = nullptr;
+*thread = new DbusIpcThread(std::move(con));
 return RequestHandler::IPC_STATUS_OK;
 case DBUS_REQUEST_NAME_REPLY_EXISTS:
 {
@@ -569,12 +567,17 @@ void DbusIpcThread::execute()
 break;
 }
 }
-dbus_connection_read_write(connection_.connection, 0);
+dbus_connection_read_write_dispatch(connection_.connection, -1);
 DbusMessageHolder msg(
 dbus_connection_pop_message(connection_.connection));
 if (msg.message == nullptr) {
 continue;
 }
+if (dbus_message_is_method_call(
+msg.message, "org.libreoffice.LibreOfficeIpcIfc0", "Close"))
+{
+break;
+}
 if (!dbus_message_is_method_call(
 msg.message, "org.libreoffice.LibreOfficeIpcIfc0", "Execute"))
 {
@@ -622,6 +625,37 @@ void DbusIpcThread::close() {
 assert(connection_.connection != nullptr);
 DBusError e;
 dbus_error_init();
+{
+// Let DbusIpcThread::execute return from dbus_connection_read_write;
+// for now, just abort on failure (the process would otherwise block,
+// with DbusIpcThread::execute hanging in dbus_connection_read_write);
+// this apparently needs a more DBus-y design anyway:
+DbusConnectionHolder con(dbus_bus_get_private(DBUS_BUS_SESSION, ));
+assert((con.connection == nullptr) == bool(dbus_error_is_set()));
+if (con.connection == nullptr) {
+SAL_WARN(
+"desktop.app",
+"dbus_bus_get_private failed with: " << e.name << ": "
+<< e.message);
+dbus_error_free();
+std::abort();
+}
+DbusMessageHolder msg(
+dbus_message_new_method_call(
+"org.libreoffice.LibreOfficeIpc0",
+"/org/libreoffice/LibreOfficeIpc0",
+

[Libreoffice-commits] core.git: include/sfx2 sfx2/source sfx2/uiconfig

[Akshay Deep]

 include/sfx2/templatedlg.hxx|1 
 sfx2/source/doc/templatedlg.cxx |   48 ++--
 sfx2/uiconfig/ui/templatedlg.ui |   60 +++-
 3 files changed, 38 insertions(+), 71 deletions(-)

New commits:
commit f402a06a6abd011b2be024ce3b847edfbcb82908
Author: Akshay Deep 
Date:   Thu Jun 2 20:37:42 2016 +0530

Reduce duplicate code in Template Manager

Remove ViewBar and put contents in ActionBar

Change-Id: I6551d36503f659f076ecf2b6766c6a14db771a1d
Reviewed-on: https://gerrit.libreoffice.org/25833
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/include/sfx2/templatedlg.hxx b/include/sfx2/templatedlg.hxx
index e404e88..d9730d1 100644
--- a/include/sfx2/templatedlg.hxx
+++ b/include/sfx2/templatedlg.hxx
@@ -148,7 +148,6 @@ protected:
 VclPtr mpExportButton;
 VclPtr mpImportButton;
 VclPtr mpLinkButton;
-VclPtr mpViewBar;
 VclPtr mpActionBar;
 VclPtr mpSearchView;
 VclPtr mpCurView;
diff --git a/sfx2/source/doc/templatedlg.cxx b/sfx2/source/doc/templatedlg.cxx
index 907e4c8..a05a304 100644
--- a/sfx2/source/doc/templatedlg.cxx
+++ b/sfx2/source/doc/templatedlg.cxx
@@ -67,7 +67,7 @@ const char TM_SETTING_LASTAPPLICATION[] = "LastApplication";
 
 const char SERVICENAME_CFGREADACCESS[] = 
"com.sun.star.configuration.ConfigurationAccess";
 
-const char VIEWBAR_REPOSITORY[] = "repository";
+const char ACTIONBAR_REPOSITORY[] = "repository";
 const char ACTIONBAR_ACTION[] = "action_menu";
 
 #define MNI_ACTION_NEW_FOLDER 1
@@ -170,7 +170,6 @@ SfxTemplateManagerDlg::SfxTemplateManagerDlg(vcl::Window 
*parent)
 get(mpSearchFilter, "search_filter");
 get(mpCBApp, "filter_application");
 get(mpCBFolder, "filter_folder");
-get(mpViewBar, "action_view");
 get(mpActionBar, "action_action");
 get(mpLocalView, "template_view");
 get(mpSearchView, "search_view");
@@ -205,14 +204,13 @@ SfxTemplateManagerDlg::SfxTemplateManagerDlg(vcl::Window 
*parent)
 mpActionMenu->SetPopupMenu(MNI_ACTION_DEFAULT,mpTemplateDefaultMenu);
 
 // Set toolbox styles
-mpViewBar->SetButtonType(ButtonType::SYMBOLTEXT);
+mpActionBar->SetButtonType(ButtonType::SYMBOLTEXT);
 
 // Set toolbox button bits
-mpViewBar->SetItemBits(mpViewBar->GetItemId(VIEWBAR_REPOSITORY), 
ToolBoxItemBits::DROPDOWNONLY);
+mpActionBar->SetItemBits(mpActionBar->GetItemId(ACTIONBAR_REPOSITORY), 
ToolBoxItemBits::DROPDOWNONLY);
 mpActionBar->SetItemBits(mpActionBar->GetItemId(ACTIONBAR_ACTION), 
ToolBoxItemBits::DROPDOWNONLY);
 
 // Set toolbox handlers
-
mpViewBar->SetDropdownClickHdl(LINK(this,SfxTemplateManagerDlg,TBXDropdownHdl));
 
mpActionBar->SetDropdownClickHdl(LINK(this,SfxTemplateManagerDlg,TBXDropdownHdl));
 
 mpLocalView->SetStyle(mpLocalView->GetStyle() | WB_VSCROLL);
@@ -267,11 +265,10 @@ SfxTemplateManagerDlg::SfxTemplateManagerDlg(vcl::Window 
*parent)
 SvtMiscOptions aMiscOptions;
 if ( !aMiscOptions.IsExperimentalMode() )
 {
-sal_uInt16 nPos = 
mpViewBar->GetItemPos(mpViewBar->GetItemId(VIEWBAR_REPOSITORY));
-mpViewBar->RemoveItem(nPos);
+sal_uInt16 nPos = 
mpActionBar->GetItemPos(mpActionBar->GetItemId(ACTIONBAR_REPOSITORY));
+mpActionBar->RemoveItem(nPos);
 }
 
-mpViewBar->Show();
 mpActionBar->Show();
 
 switchMainView(true);
@@ -331,7 +328,6 @@ void SfxTemplateManagerDlg::dispose()
 mpSearchFilter.clear();
 mpCBApp.clear();
 mpCBFolder.clear();
-mpViewBar.clear();
 mpActionBar.clear();
 mpSearchView.clear();
 mpCurView.clear();
@@ -527,30 +523,19 @@ IMPL_LINK_NOARG_TYPED(SfxTemplateManagerDlg, 
SelectRegionHdl, ListBox&, void)
 SearchUpdateHdl(*mpSearchFilter);
 }
 
-IMPL_LINK_TYPED(SfxTemplateManagerDlg, TBXDropdownHdl, ToolBox*, pBox, void)
+IMPL_LINK_NOARG_TYPED(SfxTemplateManagerDlg, TBXDropdownHdl, ToolBox*, void)
 {
-const sal_uInt16 nCurItemId = pBox->GetCurItemId();
+const sal_uInt16 nCurItemId = mpActionBar->GetCurItemId();
+mpActionBar->SetItemDown( nCurItemId, true );
 
-if (pBox == mpActionBar && nCurItemId == 
mpActionBar->GetItemId(ACTIONBAR_ACTION))
-{
-pBox->SetItemDown( nCurItemId, true );
-
-mpActionMenu->Execute(pBox, pBox->GetItemRect(nCurItemId), 
PopupMenuFlags::ExecuteDown);
-
-pBox->SetItemDown( nCurItemId, false );
-pBox->EndSelection();
-pBox->Invalidate();
-}
-else if (pBox == mpViewBar && nCurItemId == 
mpViewBar->GetItemId(VIEWBAR_REPOSITORY))
-{
-pBox->SetItemDown( nCurItemId, true );
+if (nCurItemId == mpActionBar->GetItemId(ACTIONBAR_ACTION))
+mpActionMenu->Execute(mpActionBar, 
mpActionBar->GetItemRect(nCurItemId), PopupMenuFlags::ExecuteDown);
+else if (nCurItemId == mpActionBar->GetItemId(ACTIONBAR_REPOSITORY))
+

[Libreoffice-bugs] [Bug 98880] LO crashes when making too many calls of a user-defined function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98880

--- Comment #6 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc78e5c6f5f55b0289012f4c4e6013d2935b1cc6

Resolves: tdf#98880 ensure backing context of DoubleVectorRefToken...

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98880] LO crashes when making too many calls of a user-defined function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98880

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/inc sc/source

[Caolán McNamara]

 sc/inc/document.hxx |4 ++--
 sc/source/core/data/column2.cxx |2 +-
 sc/source/core/data/document.cxx|4 ++--
 sc/source/core/data/grouptokenconverter.cxx |   18 ++
 sc/source/core/inc/grouptokenconverter.hxx  |1 +
 5 files changed, 24 insertions(+), 5 deletions(-)

New commits:
commit dc78e5c6f5f55b0289012f4c4e6013d2935b1cc6
Author: Caolán McNamara 
Date:   Thu Jun 2 11:18:02 2016 +0100

Resolves: tdf#98880 ensure backing context of DoubleVectorRefToken...

exists for the lifetime of the ScGroupTokenConverter

otherwise in tdf#98880 ScDocument::InterpretDirtyCells releases
that backing storage that the DoubleVectorRefToken relies on, and
the ScVectorRefMatrix relies on that, so...

when sc/source/core/tool/interpr4.cxx calls ::IsString on the 
ScVectorRefMatrix
which calls ensureFullMatrix. That makes use of rArray.mpStringArray where
rArray's mpStringArray is set to that rArray by
FormulaGroupContext::ensureStrArray and the storage of mpStringArray 
belongs to
the FormulaGroupContext, but that context was reset and destroyed up the 
stack
in ScDocument::InterpretDirtyCells so the data is now invalid

We could turn the unique_ptr into a shared_ptr and have the 
ScGroupTokenConverter
take a ref to the currently active FormulaGroupContext to ensure any 
generated
DoubleVectorRefToken/SingleVectorRefToken point to valid data during the
lifetime of the ScGroupTokenConverter

Change-Id: Id457934cdff18570961cb261cf5c46b6ef8ea083
Reviewed-on: https://gerrit.libreoffice.org/25815
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index e0237ac..f860dbc 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -299,7 +299,7 @@ private:
 rtl::Reference xPoolHelper;
 
 std::shared_ptr mpCellStringPool;
-std::unique_ptr mpFormulaGroupCxt;
+std::shared_ptr mpFormulaGroupCxt;
 mutable std::unique_ptr mpDocLinkMgr;
 
 ScCalcConfigmaCalcConfig;
@@ -1050,7 +1050,7 @@ public:
 
 svl::SharedString GetSharedString( const ScAddress& rPos ) const;
 
-sc::FormulaGroupContext& GetFormulaGroupContext();
+std::shared_ptr& GetFormulaGroupContext();
 
 SC_DLLPUBLIC void GetInputString( SCCOL nCol, SCROW nRow, SCTAB nTab, 
OUString& rString );
 sal_uInt16 GetStringForFormula( const ScAddress& rPos, OUString& rString );
diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index 19a7aed..a32b2f7 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -2560,7 +2560,7 @@ formula::VectorRefArray ScColumn::FetchVectorRefArray( 
SCROW nRow1, SCROW nRow2
 return formula::VectorRefArray(formula::VectorRefArray::Invalid);
 
 // See if the requested range is already cached.
-sc::FormulaGroupContext& rCxt = pDocument->GetFormulaGroupContext();
+sc::FormulaGroupContext& rCxt = *(pDocument->GetFormulaGroupContext());
 sc::FormulaGroupContext::ColArray* pColArray = 
rCxt.getCachedColArray(nTab, nCol, nRow2+1);
 if (pColArray)
 {
diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index f9f3933..2fcce07 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -3443,12 +3443,12 @@ svl::SharedString ScDocument::GetSharedString( const 
ScAddress& rPos ) const
 return maTabs[rPos.Tab()]->GetSharedString(rPos.Col(), rPos.Row());
 }
 
-sc::FormulaGroupContext& ScDocument::GetFormulaGroupContext()
+std::shared_ptr& ScDocument::GetFormulaGroupContext()
 {
 if (!mpFormulaGroupCxt)
 mpFormulaGroupCxt.reset(new sc::FormulaGroupContext);
 
-return *mpFormulaGroupCxt;
+return mpFormulaGroupCxt;
 }
 
 void ScDocument::GetInputString( SCCOL nCol, SCROW nRow, SCTAB nTab, OUString& 
rString )
diff --git a/sc/source/core/data/grouptokenconverter.cxx 
b/sc/source/core/data/grouptokenconverter.cxx
index da3964c..22b89a6 100644
--- a/sc/source/core/data/grouptokenconverter.cxx
+++ b/sc/source/core/data/grouptokenconverter.cxx
@@ -135,6 +135,15 @@ bool ScGroupTokenConverter::convert(ScTokenArray& rCode)
 
 formula::SingleVectorRefToken aTok(aArray, nLen, nTrimLen);
 mrGroupTokens.AddToken(aTok);
+
+if (nTrimLen && !mxFormulaGroupContext)
+{
+//tdf#98880 if the SingleVectorRefToken relies on the
+//underlying storage provided by the Document
+//FormulaGroupContext, take a reference to it here to
+//ensure that backing storage exists for our lifetime
+mxFormulaGroupContext = mrDoc.GetFormulaGroupContext();
+   

Feature branch request

[Akash Jain]

Hi everyone,

This is in relation to my GSoC project.

I have almost finished writing the new Layout class which uses
HarfBuzz solely and will work for all platforms. Now I need to
integrate it with the existing code. This may involve changing
existing code frequently and may break master making things messy.
Therefore I request a feature branch with commit access so I can push
code faster then the current work flow will allow.

I will be careful to only commit to my feature branch and not commit
to any other branch.

Regards,
autoit
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 63256] [Template Manager][UI] missing option to show available templates as list (not preview/icons) in new template manager

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63256

--- Comment #10 from Heiko Tietze  ---
(In reply to Al Maloney from comment #9)
> How do the icons make searching and choosing better than a list?

If you search by description the list together with a preview is the perfect
control. But most people would have the picture in mind how the template look.
And that's better supported by several images - the icon view. So I'd say
either the developers allow to switch from icon to list view or WONTFIX.

Have you taken a look at the latest build? The filter and search options are
very handy and may help you as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs