date:20160626

[Libreoffice-bugs] [Bug 100537] Table width and Relative checkbox disabled

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100537

--- Comment #2 from Elmar  ---
OK. but seems counter-intuitive, especially as there seems to be no other way
to do this than via
1. select table
2. click on optimize size icon in table toolbar

Is one of those things that I am likely to forget how it is done and thus have
to waste time trying to figure it out again.

better would be if the tick boxes in table properties were enabled all the
time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/LOOLWSD.cpp

2016-06-26 Thread Andras Timar

 loolwsd/LOOLWSD.cpp |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 8b074036293edf77233df061a2a6fe72849d6a93
Author: Andras Timar 
Date:   Mon Jun 27 07:37:04 2016 +0200

loolwsd: use LOOLWSD_CONFIGDIR and LOOLWSD_CACHEDIR in default config

diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 8e87bde..903dad3 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -1227,7 +1227,7 @@ void LOOLWSD::initialize(Application& self)
 
 // Add default values of new entries here.
 static const std::map DefAppConfig = {
-{ "tile_cache_path", "/usr/local/var/cache/loolwsd" },
+{ "tile_cache_path", LOOLWSD_CACHEDIR },
 { "sys_template_path", "systemplate" },
 { "lo_template_path", "/opt/collaboraoffice5.0" },
 { "child_root_path", "jails" },
@@ -1239,9 +1239,9 @@ void LOOLWSD::initialize(Application& self)
 { "loleaflet_html", "loleaflet.html" },
 { "logging.color", "true" },
 { "logging.level", "trace" },
-{ "ssl.cert_file_path", "/etc/loolwsd/cert.pem" },
-{ "ssl.key_file_path", "/etc/loolwsd/key.pem" },
-{ "ssl.ca_file_path", "/etc/loolwsd/ca-chain.cert.pem" },
+{ "ssl.cert_file_path", LOOLWSD_CONFIGDIR "/cert.pem" },
+{ "ssl.key_file_path", LOOLWSD_CONFIGDIR "/key.pem" },
+{ "ssl.ca_file_path", LOOLWSD_CONFIGDIR "/ca-chain.cert.pem" },
 { "storage.filesystem[@allow]", "false" },
 { "storage.wopi[@allow]", "true" },
 { "storage.wopi.host[0][@allow]", "true" },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/inc sw/source

2016-06-26 Thread Noel Grandin

 sw/inc/dbmgr.hxx  |2 --
 sw/inc/doc.hxx|2 --
 sw/inc/fmtclds.hxx|4 
 sw/inc/ndarr.hxx  |1 -
 sw/inc/redline.hxx|3 +--
 sw/inc/tox.hxx|1 -
 sw/source/core/access/accdoc.cxx  |7 +--
 sw/source/core/doc/docnew.cxx |1 -
 sw/source/core/doc/docredln.cxx   |8 
 sw/source/core/docnode/nodes.cxx  |2 +-
 sw/source/core/layout/atrfrm.cxx  |   10 +++---
 sw/source/core/layout/colfrm.cxx  |4 ++--
 sw/source/core/tox/tox.cxx|2 --
 sw/source/uibase/dbui/dbmgr.cxx   |4 ++--
 sw/source/uibase/uno/unomailmerge.cxx |1 -
 15 files changed, 14 insertions(+), 38 deletions(-)

New commits:
commit 82644f5952fa8780ffd590d23b194bf1866ed099
Author: Noel Grandin 
Date:   Sun Jun 26 15:25:14 2016 +0200

loplugin:singlevalfields in sw(part4)

Change-Id: I73d94ae89edb2e6f37cfa087a0d85b5a90df4a8a
Reviewed-on: https://gerrit.libreoffice.org/26679
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/dbmgr.hxx b/sw/inc/dbmgr.hxx
index 81f32d3..113f33d 100644
--- a/sw/inc/dbmgr.hxx
+++ b/sw/inc/dbmgr.hxx
@@ -193,7 +193,6 @@ struct SwMergeDescriptor
  * @defgroup print Mail merge to Printer
  * @addtogroup print
  * @{ */
-boolbPrintAsync;
 css::uno::Sequence<  css::beans::PropertyValue >aPrintOptions;
 /** @} */
 
@@ -208,7 +207,6 @@ struct SwMergeDescriptor
 bCreateSingleFile( false ),
 bSendAsHTML( true ),
 bSendAsAttachment( false ),
-bPrintAsync( false ),
 pMailMergeConfigItem( nullptr )
 {
 if( nType == DBMGR_MERGE_SHELL )
diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index 1fb0514..edf54f9 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -446,7 +446,6 @@ private:
 SwFormat *MakeTextFormatColl_(const OUString &, SwFormat *, bool, bool );
 
 private:
-bool mbReadOnly;
 OUString msDocAccTitle;
 
 void InitTOXTypes();
@@ -589,7 +588,6 @@ public:
 
 //End of Interfaces
 
-bool getDocReadOnly() const { return mbReadOnly; }
 void setDocAccTitle( const OUString& rTitle ) { msDocAccTitle = rTitle; }
 const OUString& getDocAccTitle() const { return msDocAccTitle; }
 
diff --git a/sw/inc/fmtclds.hxx b/sw/inc/fmtclds.hxx
index 89327b5..9f6a289 100644
--- a/sw/inc/fmtclds.hxx
+++ b/sw/inc/fmtclds.hxx
@@ -34,8 +34,6 @@ class SwColumn
 sal_uInt16 m_nWish;   /**< Desired width, borders included.
  It is inversely proportional to the ratio of
  desired width environment / current width column. */
-sal_uInt16 m_nUpper;  ///< Top border.
-sal_uInt16 m_nLower;  ///< Bottom border.
 sal_uInt16 m_nLeft;   ///< Left border.
 sal_uInt16 m_nRight;  ///< Right border.
 
@@ -49,8 +47,6 @@ public:
 void SetRight( sal_uInt16  nNew ) { m_nRight = nNew; }
 
 sal_uInt16 GetWishWidth() const { return m_nWish;  }
-sal_uInt16 GetUpper() const { return m_nUpper; }
-sal_uInt16 GetLower() const { return m_nLower; }
 sal_uInt16 GetLeft () const { return m_nLeft; }
 sal_uInt16 GetRight() const { return m_nRight; }
 
diff --git a/sw/inc/ndarr.hxx b/sw/inc/ndarr.hxx
index abbf27e..0d766ce 100644
--- a/sw/inc/ndarr.hxx
+++ b/sw/inc/ndarr.hxx
@@ -111,7 +111,6 @@ class SW_DLLPUBLIC SwNodes
 bool m_bInNodesDel : 1;   /**< In Case of recursive calling.
Do not update Num/Outline. */
 bool m_bInDelUpdOutline : 1; ///< Flag for updating of Outline.
-bool m_bInDelUpdNum : 1;  ///< Flag for updating of Outline.
 
 // Actions on the nodes.
 static void SectionUpDown( const SwNodeIndex & aStart, const SwNodeIndex & 
aEnd );
diff --git a/sw/inc/redline.hxx b/sw/inc/redline.hxx
index 1033a56..0adc5c9 100644
--- a/sw/inc/redline.hxx
+++ b/sw/inc/redline.hxx
@@ -184,7 +184,6 @@ class SW_DLLPUBLIC SwRangeRedline : public SwPaM
 SwRedlineData* pRedlineData;
 SwNodeIndex* pContentSect;
 bool bDelLastPara : 1;
-bool bIsLastParaDelete : 1;
 bool bIsVisible : 1;
 
 void MoveToSection();
@@ -200,7 +199,7 @@ public:
 SwRangeRedline(SwRedlineData* pData, const SwPosition& rPos,
bool bDelLP) :
 SwPaM( rPos ), pRedlineData( pData ), pContentSect( nullptr ),
-bDelLastPara( bDelLP ), bIsLastParaDelete( false ), bIsVisible( true )
+bDelLastPara( bDelLP ), bIsVisible( true )
 {}
 SwRangeRedline( const SwRangeRedline& );
 virtual ~SwRangeRedline();
diff --git a/sw/inc/tox.hxx b/sw/inc/tox.hxx
index 569cd06..91d19be 100644
--- a/sw/inc/tox.hxx
+++ b/sw/inc/tox.hxx
@@ -282,7 +282,6 @@ class SW_DLLPUBLIC SwForm
 TOXTypesm_eType;

[Libreoffice-commits] core.git: sw/source

2016-06-26 Thread Noel Grandin

 sw/source/core/doc/docbm.cxx|   48 ++--
 sw/source/core/doc/tblrwcl.cxx  |8 +---
 sw/source/core/inc/SwXMLTextBlocks.hxx  |1 
 sw/source/core/inc/flyfrm.hxx   |7 ---
 sw/source/core/inc/flyfrms.hxx  |   17 
 sw/source/core/inc/frmtool.hxx  |2 -
 sw/source/core/inc/layact.hxx   |1 
 sw/source/core/inc/mvsave.hxx   |2 -
 sw/source/core/inc/objectformatter.hxx  |9 
 sw/source/core/inc/swfont.hxx   |4 --
 sw/source/core/inc/unoflatpara.hxx  |2 -
 sw/source/core/layout/fly.cxx   |8 
 sw/source/core/layout/flyincnt.cxx  |2 -
 sw/source/core/layout/frmtool.cxx   |   27 -
 sw/source/core/layout/layact.cxx|4 --
 sw/source/core/layout/objectformatter.cxx   |9 
 sw/source/core/layout/objectformattertxtfrm.cxx |8 
 sw/source/core/layout/wsfrm.cxx |2 -
 sw/source/core/swg/SwXMLTextBlocks.cxx  |   13 +-
 sw/source/core/text/inftxt.cxx  |2 -
 sw/source/core/text/inftxt.hxx  |1 
 sw/source/core/text/pordrop.hxx |1 
 sw/source/core/text/portxt.cxx  |   21 --
 sw/source/core/text/portxt.hxx  |5 --
 sw/source/core/text/txtdrop.cxx |4 --
 sw/source/core/txtnode/swfont.cxx   |4 --
 sw/source/core/unocore/unoflatpara.cxx  |8 +---
 27 files changed, 27 insertions(+), 193 deletions(-)

New commits:
commit f384ae4c81c2459f9955697ecc36412f7409b936
Author: Noel Grandin 
Date:   Sun Jun 26 12:24:25 2016 +0200

loplugin:singlevalfields in sw(part3)

Change-Id: Ie971a1483f4fedda61c81a097399d3d562862891
Reviewed-on: https://gerrit.libreoffice.org/26677
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx
index 7fb4fdcf..3e7919f 100644
--- a/sw/source/core/doc/docbm.cxx
+++ b/sw/source/core/doc/docbm.cxx
@@ -1199,8 +1199,6 @@ SaveBookmark::SaveBookmark(
 : m_aName(rBkmk.GetName())
 , m_aShortName()
 , m_aCode()
-, m_bSavePos(true)
-, m_bSaveOtherPos(true)
 , m_eOrigBkmType(IDocumentMarkAccess::GetType(rBkmk))
 {
 const IBookmark* const pBookmark = dynamic_cast< const IBookmark* 
>();
@@ -1219,24 +1217,18 @@ SaveBookmark::SaveBookmark(
 m_nNode1 = rBkmk.GetMarkPos().nNode.GetIndex();
 m_nContent1 = rBkmk.GetMarkPos().nContent.GetIndex();
 
-if(m_bSavePos)
-{
-m_nNode1 -= rMvPos.GetIndex();
-if(pIdx && !m_nNode1)
-m_nContent1 -= pIdx->GetIndex();
-}
+m_nNode1 -= rMvPos.GetIndex();
+if(pIdx && !m_nNode1)
+m_nContent1 -= pIdx->GetIndex();
 
 if(rBkmk.IsExpanded())
 {
 m_nNode2 = rBkmk.GetOtherMarkPos().nNode.GetIndex();
 m_nContent2 = rBkmk.GetOtherMarkPos().nContent.GetIndex();
 
-if(m_bSaveOtherPos)
-{
-m_nNode2 -= rMvPos.GetIndex();
-if(pIdx && !m_nNode2)
-m_nContent2 -= pIdx->GetIndex();
-}
+m_nNode2 -= rMvPos.GetIndex();
+if(pIdx && !m_nNode2)
+m_nContent2 -= pIdx->GetIndex();
 }
 else
 {
@@ -1258,35 +1250,19 @@ void SaveBookmark::SetInDoc(
 {
 aPam.SetMark();
 
-if(m_bSaveOtherPos)
-{
-aPam.GetMark()->nNode += m_nNode2;
-if(pIdx && !m_nNode2)
-aPam.GetMark()->nContent += m_nContent2;
-else
-aPam.GetMark()->nContent.Assign(aPam.GetContentNode(false), 
m_nContent2);
-}
+aPam.GetMark()->nNode += m_nNode2;
+if(pIdx && !m_nNode2)
+aPam.GetMark()->nContent += m_nContent2;
 else
-{
-aPam.GetMark()->nNode = m_nNode2;
 aPam.GetMark()->nContent.Assign(aPam.GetContentNode(false), 
m_nContent2);
-}
 }
 
-if(m_bSavePos)
-{
-aPam.GetPoint()->nNode += m_nNode1;
+aPam.GetPoint()->nNode += m_nNode1;
 
-if(pIdx && !m_nNode1)
-aPam.GetPoint()->nContent += m_nContent1;
-else
-aPam.GetPoint()->nContent.Assign(aPam.GetContentNode(), 
m_nContent1);
-}
+if(pIdx && !m_nNode1)
+aPam.GetPoint()->nContent += m_nContent1;
 else
-{
-aPam.GetPoint()->nNode = m_nNode1;
 aPam.GetPoint()->nContent.Assign(aPam.GetContentNode(), m_nContent1);
-}
 
 if(!aPam.HasMark()
 || CheckNodesRange(aPam.GetPoint()->nNode, aPam.GetMark()->nNode, 
true))
diff --git a/sw/source/core/doc/tblrwcl.cxx b/sw/source/core/doc/tblrwcl.cxx
index c719389..e1d8c3a 100644
--- a/sw/source/core/doc/tblrwcl.cxx
+++

[Libreoffice-commits] core.git: sw/source

2016-06-26 Thread Noel Grandin

 sw/source/filter/html/swhtml.cxx|   15 +--
 sw/source/filter/html/swhtml.hxx|2 --
 sw/source/filter/ww8/rtfattributeoutput.cxx |6 +-
 sw/source/filter/ww8/rtfattributeoutput.hxx |5 -
 sw/source/filter/ww8/ww8par.cxx |5 +
 sw/source/filter/ww8/ww8par.hxx |5 -
 sw/source/filter/ww8/ww8par6.cxx|1 -
 sw/source/filter/xml/xmlimp.cxx |3 +--
 sw/source/filter/xml/xmlimp.hxx |1 -
 sw/source/ui/envelp/label1.cxx  |2 --
 sw/source/ui/envelp/swuilabimp.hxx  |2 --
 sw/source/ui/vba/vbaaddin.cxx   |4 ++--
 sw/source/ui/vba/vbaaddin.hxx   |1 -
 13 files changed, 6 insertions(+), 46 deletions(-)

New commits:
commit 19c3aac98f756f6a9cda44a4cc70a2a924fa85df
Author: Noel Grandin 
Date:   Sat Jun 25 23:21:36 2016 +0200

loplugin:singlevalfields in sw(part2)

Change-Id: Ic1b186c82a6b37ae0cd8028a60e2ad09233d8e5d
Reviewed-on: https://gerrit.libreoffice.org/26665
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sw/source/filter/html/swhtml.cxx b/sw/source/filter/html/swhtml.cxx
index 0556c6f..0f8c49a 100644
--- a/sw/source/filter/html/swhtml.cxx
+++ b/sw/source/filter/html/swhtml.cxx
@@ -299,11 +299,9 @@ SwHTMLParser::SwHTMLParser( SwDoc* pD, SwPaM& rCursor, 
SvStream& rIn,
 m_pTempViewFrame(nullptr)
 {
 m_nEventId = nullptr;
-m_bUpperSpace = m_bViewCreated = m_bChkJumpMark =
-m_bSetCursor = false;
+m_bUpperSpace = m_bViewCreated = m_bChkJumpMark = false;
 
 m_eScriptLang = HTML_SL_UNKNOWN;
-m_bAnyStarBasic = true;
 
 rCursor.DeleteMark();
 m_pPam =  // re-use existing cursor: avoids spurious ~SwIndexReg 
assert
@@ -2583,17 +2581,6 @@ SwViewShell *SwHTMLParser::CallEndAction( bool 
bChkAction, bool bChkPtr )
 if( !m_pActionViewShell || (bChkAction && 
!m_pActionViewShell->ActionPend()) )
 return m_pActionViewShell;
 
-if( m_bSetCursor )
-{
-// set the cursor to the doc begin in all CursorEditShells
-for(SwViewShell& rSh : m_pActionViewShell->GetRingContainer())
-{
-if( dynamic_cast() != nullptr )
-static_cast()->SttEndDoc(true);
-}
-
-m_bSetCursor = false;
-}
 if( dynamic_cast< const SwEditShell *>( m_pActionViewShell ) !=  nullptr )
 {
 //Schon gescrollt?, dann dafuer sorgen, dass die View sich nicht 
bewegt!
diff --git a/sw/source/filter/html/swhtml.hxx b/sw/source/filter/html/swhtml.hxx
index c82ba95..0ad3007 100644
--- a/sw/source/filter/html/swhtml.hxx
+++ b/sw/source/filter/html/swhtml.hxx
@@ -436,7 +436,6 @@ class SwHTMLParser : public SfxHTMLParser, public SwClient
 // Flag um doppeltes init durch Rekursion
 // zu verhindern.
 bool m_bViewCreated : 1;  // die View wurde schon erzeugt (asynchron)
-bool m_bSetCursor : 1;  // Cursor wieder auf den Anfang setzen
 bool m_bSetModEnabled : 1;
 
 bool m_bInFloatingFrame : 1;  // Wir sind in einen Floating Frame
@@ -453,7 +452,6 @@ class SwHTMLParser : public SfxHTMLParser, public SwClient
 bool m_bNoParSpace : 1;
 // 16
 
-bool m_bAnyStarBasic : 1; // gibt es ueberhaupt ein StarBasic-Modul
 bool m_bInNoEmbed : 1;// Wir sind in einem NOEMBED-Bereich
 
 bool m_bInTitle : 1;  // Wir sind im Titel
diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx 
b/sw/source/filter/ww8/rtfattributeoutput.cxx
index 4e87ecb..e74fbcf 100644
--- a/sw/source/filter/ww8/rtfattributeoutput.cxx
+++ b/sw/source/filter/ww8/rtfattributeoutput.cxx
@@ -2206,10 +2206,7 @@ void RtfAttributeOutput::CharCrossedOut(const 
SvxCrossedOutItem& rCrossedOut)
 switch (rCrossedOut.GetStrikeout())
 {
 case STRIKEOUT_NONE:
-if (!m_bStrikeDouble)
-m_aStyles.append(OOO_STRING_SVTOOLS_RTF_STRIKE);
-else
-m_aStyles.append(OOO_STRING_SVTOOLS_RTF_STRIKED);
+m_aStyles.append(OOO_STRING_SVTOOLS_RTF_STRIKE);
 m_aStyles.append((sal_Int32)0);
 break;
 case STRIKEOUT_DOUBLE:
@@ -3484,7 +3481,6 @@ RtfAttributeOutput::RtfAttributeOutput(RtfExport& rExport)
 : m_rExport(rExport),
   m_nStyleId(0),
   m_nListId(0),
-  m_bStrikeDouble(false),
   m_nNextAnnotationMarkId(0),
   m_nCurrentAnnotationMarkId(-1),
   m_bTableCellOpen(false),
diff --git a/sw/source/filter/ww8/rtfattributeoutput.hxx 
b/sw/source/filter/ww8/rtfattributeoutput.hxx
index baa3cce..303e333 100644
--- a/sw/source/filter/ww8/rtfattributeoutput.hxx
+++ b/sw/source/filter/ww8/rtfattributeoutput.hxx
@@ -507,11 +507,6 @@ private:
  */
 OStringBuffer m_aStylesEnd;
 
-/*
- * We just get a "end of strike" mark at the end of strike, store here 
what to finish: single

[Libreoffice-commits] core.git: sw/source

2016-06-26 Thread Noel Grandin

 sw/source/ui/config/optpage.cxx|8 
 sw/source/ui/frmdlg/frmpage.cxx|4 --
 sw/source/uibase/cctrl/swlbox.cxx  |   19 ++
 sw/source/uibase/docvw/AnchorOverlayObject.cxx |   45 -
 sw/source/uibase/docvw/srcedtw.cxx |3 -
 sw/source/uibase/inc/bmpwin.hxx|1 
 sw/source/uibase/inc/content.hxx   |3 -
 sw/source/uibase/inc/optpage.hxx   |1 
 sw/source/uibase/inc/redlndlg.hxx  |1 
 sw/source/uibase/inc/srcedtw.hxx   |1 
 sw/source/uibase/inc/swlbox.hxx|1 
 sw/source/uibase/inc/tablemgr.hxx  |1 
 sw/source/uibase/inc/unomod.hxx|2 -
 sw/source/uibase/misc/redlndlg.cxx |8 +---
 sw/source/uibase/table/tablemgr.cxx|8 
 sw/source/uibase/uno/unomod.cxx|   16 +++-
 sw/source/uibase/utlui/content.cxx |   24 ++---
 17 files changed, 23 insertions(+), 123 deletions(-)

New commits:
commit 1bf97d99e7529f1a69688522ac271636059a3391
Author: Noel Grandin 
Date:   Sat Jun 25 23:03:53 2016 +0200

loplugin:singlevalfields in sw(part1)

Change-Id: I0c6f545a8818da1f226c3958580abeeff0dc87b7
Reviewed-on: https://gerrit.libreoffice.org/26664
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sw/source/ui/config/optpage.cxx b/sw/source/ui/config/optpage.cxx
index 84c3cf2..2369aa0 100644
--- a/sw/source/ui/config/optpage.cxx
+++ b/sw/source/ui/config/optpage.cxx
@@ -549,7 +549,6 @@ SwStdFontTabPage::SwStdFontTabPage( vcl::Window* pParent,
 m_bSetLabelDefault(true),
 m_bIdxDefault(false),
 m_bSetIdxDefault(true),
-m_bDeletePrinter(false),
 
 m_bListHeightDefault(false),
 m_bSetListHeightDefault (false),
@@ -611,8 +610,6 @@ SwStdFontTabPage::~SwStdFontTabPage()
 void SwStdFontTabPage::dispose()
 {
 delete m_pFontList;
-if (m_bDeletePrinter)
-m_pPrt.disposeAndClear();
 m_pLabelFT.clear();
 m_pStandardBox.clear();
 m_pStandardHeightLB.clear();
@@ -802,11 +799,6 @@ void SwStdFontTabPage::Reset( const SfxItemSet* rSet)
 
 const SfxPoolItem* pItem;
 
-if (m_bDeletePrinter)
-{
-m_pPrt.disposeAndClear();
-}
-
 if(SfxItemState::SET == rSet->GetItemState(FN_PARAM_PRINTER, false, 
))
 {
 m_pPrt = static_cast(static_cast(pItem)->GetValue());
diff --git a/sw/source/ui/frmdlg/frmpage.cxx b/sw/source/ui/frmdlg/frmpage.cxx
index df4760d..7f90f17 100644
--- a/sw/source/ui/frmdlg/frmpage.cxx
+++ b/sw/source/ui/frmdlg/frmpage.cxx
@@ -2627,7 +2627,6 @@ BmpWindow::BmpWindow(vcl::Window* pPar, WinBits nStyle)
 , bHorz(false)
 , bVert(false)
 , bGraphic(false)
-, bLeftAlign(false)
 {
 }
 
@@ -2675,8 +2674,7 @@ void BmpWindow::Paint(vcl::RenderContext& rRenderContext, 
const Rectangle&)
 else
 aPntSz.Width() = aPntSz.Height() * nRelGrf /100;
 
-if (!bLeftAlign)
-aPntPos.X() += nWidth - aPntSz.Width() ;
+aPntPos.X() += nWidth - aPntSz.Width() ;
 }
 
 // #i119307# clear window background, the graphic might have transparency
diff --git a/sw/source/uibase/cctrl/swlbox.cxx 
b/sw/source/uibase/cctrl/swlbox.cxx
index 9b42902..9ee1e32 100644
--- a/sw/source/uibase/cctrl/swlbox.cxx
+++ b/sw/source/uibase/cctrl/swlbox.cxx
@@ -23,19 +23,16 @@
 #include 
 
 // Description: ListboxElement
-SwBoxEntry::SwBoxEntry() :
-bNew(false)
+SwBoxEntry::SwBoxEntry()
 {
 }
 
 SwBoxEntry::SwBoxEntry(const OUString& aNam) :
-bNew(false),
 aName(aNam)
 {
 }
 
 SwBoxEntry::SwBoxEntry(const SwBoxEntry& rOld) :
-bNew(rOld.bNew),
 aName(rOld.aName)
 {
 }
@@ -78,20 +75,12 @@ void SwComboBox::RemoveEntryAt(sal_Int32 const nPos)
 return;
 
 // Remove old element
-SwBoxEntry const& rEntry = m_EntryList[nPos];
 ComboBox::RemoveEntryAt(nPos);
 
 // Don't add new entries to the list
-if (rEntry.bNew)
-{
-m_EntryList.erase(m_EntryList.begin() + nPos);
-}
-else
-{
-// add to DelEntryLst
-m_DelEntryList.push_back(m_EntryList[nPos]);
-m_EntryList.erase(m_EntryList.begin() + nPos);
-}
+// add to DelEntryLst
+m_DelEntryList.push_back(m_EntryList[nPos]);
+m_EntryList.erase(m_EntryList.begin() + nPos);
 }
 
 const SwBoxEntry& SwComboBox::GetSwEntry(sal_Int32 const nPos) const
diff --git a/sw/source/uibase/docvw/AnchorOverlayObject.cxx 
b/sw/source/uibase/docvw/AnchorOverlayObject.cxx
index 4f8d0e1..850228e 100644
--- a/sw/source/uibase/docvw/AnchorOverlayObject.cxx
+++ b/sw/source/uibase/docvw/AnchorOverlayObject.cxx
@@ -48,7 +48,6 @@ private:
 double  mfDiscreteLineWidth;
 
 // bitfield
-boolmbShadow : 1;
 bool

[Libreoffice-commits] core.git: sdext/source

2016-06-26 Thread Noel Grandin

 sdext/source/pdfimport/tree/pdfiprocessor.cxx |9 
 sdext/source/pdfimport/tree/pdfiprocessor.hxx |2 
 sdext/source/presenter/PresenterController.cxx|6 --
 sdext/source/presenter/PresenterPaneContainer.cxx |6 --
 sdext/source/presenter/PresenterPaneContainer.hxx |1 
 sdext/source/presenter/PresenterSprite.cxx|3 -
 sdext/source/presenter/PresenterSprite.hxx|1 
 sdext/source/presenter/PresenterTextView.cxx  |5 --
 sdext/source/presenter/PresenterTextView.hxx  |2 
 sdext/source/presenter/PresenterToolBar.cxx   |   47 +-
 10 files changed, 14 insertions(+), 68 deletions(-)

New commits:
commit b1225d201f8c23c75e31e09a0f5e9ff838866776
Author: Noel Grandin 
Date:   Sat Jun 25 18:41:51 2016 +0200

loplugin:singlevalfields in sdext

Change-Id: I9bf194fb58b3bd37071647a83a629b6782836890
Reviewed-on: https://gerrit.libreoffice.org/26659
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sdext/source/pdfimport/tree/pdfiprocessor.cxx 
b/sdext/source/pdfimport/tree/pdfiprocessor.cxx
index 2551bf4..69c9066 100644
--- a/sdext/source/pdfimport/tree/pdfiprocessor.cxx
+++ b/sdext/source/pdfimport/tree/pdfiprocessor.cxx
@@ -68,7 +68,6 @@ namespace pdfi
 m_aIdToGC(),
 m_aGCToId(),
 m_aImages(),
-m_eTextDirection( LrTb ),
 m_nPages(0),
 m_nNextZOrder( 1 ),
 m_xStatusIndicator( xStat ),
@@ -706,13 +705,7 @@ void PDFIProcessor::sortElements( Element* pEle, bool 
bDeep )
 aChildren.push_back( pEle->Children.front() );
 pEle->Children.pop_front();
 }
-switch( m_eTextDirection )
-{
-case LrTb:
-default:
-std::stable_sort( aChildren.begin(), aChildren.end(), lr_tb_sort );
-break;
-}
+std::stable_sort( aChildren.begin(), aChildren.end(), lr_tb_sort );
 int nChildren = aChildren.size();
 for( int i = 0; i < nChildren; i++ )
 pEle->Children.push_back( aChildren[i] );
diff --git a/sdext/source/pdfimport/tree/pdfiprocessor.hxx 
b/sdext/source/pdfimport/tree/pdfiprocessor.hxx
index 21197bf..672b333 100644
--- a/sdext/source/pdfimport/tree/pdfiprocessor.hxx
+++ b/sdext/source/pdfimport/tree/pdfiprocessor.hxx
@@ -191,8 +191,6 @@ namespace pdfi
 
 ImageContainer m_aImages;
 
-DocumentTextDirecion   m_eTextDirection;
-
 sal_Int32  m_nPages;
 sal_Int32  m_nNextZOrder;
 css::uno::Reference<
diff --git a/sdext/source/presenter/PresenterController.cxx 
b/sdext/source/presenter/PresenterController.cxx
index b90b396..5a8235c 100644
--- a/sdext/source/presenter/PresenterController.cxx
+++ b/sdext/source/presenter/PresenterController.cxx
@@ -744,12 +744,6 @@ void SAL_CALL 
PresenterController::notifyConfigurationChange (
 {
 PresenterPaneContainer::SharedPaneDescriptor pDescriptor (
 mpPaneContainer->FindPaneId(xPane->getResourceId()));
-
-// When there is a call out anchor location set then tell 
the
-// window about it.
-if (pDescriptor->mbHasCalloutAnchor)
-pDescriptor->mxPane->SetCalloutAnchor(
-pDescriptor->maCalloutAnchorLocation);
 }
 }
 else if 
(rEvent.ResourceId->isBoundTo(mxMainPaneId,AnchorBindingMode_INDIRECT))
diff --git a/sdext/source/presenter/PresenterPaneContainer.cxx 
b/sdext/source/presenter/PresenterPaneContainer.cxx
index 81be293..d226163 100644
--- a/sdext/source/presenter/PresenterPaneContainer.cxx
+++ b/sdext/source/presenter/PresenterPaneContainer.cxx
@@ -95,7 +95,6 @@ void PresenterPaneContainer::PreparePane (
 pDescriptor->maSpriteProvider = PaneDescriptor::SpriteProvider();
 pDescriptor->mbIsSprite = false;
 pDescriptor->maCalloutAnchorLocation = awt::Point(-1,-1);
-pDescriptor->mbHasCalloutAnchor = false;
 
 maPanes.push_back(pDescriptor);
 }
@@ -135,11 +134,6 @@ PresenterPaneContainer::SharedPaneDescriptor
 pDescriptor->mxPane = rxPane;
 pDescriptor->mxPane->SetTitle(pDescriptor->msTitle);
 
-// When there is a call out anchor location set then tell the
-// window about it.
-if (pDescriptor->mbHasCalloutAnchor)
-
pDescriptor->mxPane->SetCalloutAnchor(pDescriptor->maCalloutAnchorLocation);
-
 if (xWindow.is())
 xWindow->addEventListener(this);
 }
diff --git a/sdext/source/presenter/PresenterPaneContainer.hxx 
b/sdext/source/presenter/PresenterPaneContainer.hxx
index 84fb3b5..7e7bc12 100644
--- a/sdext/source/presenter/PresenterPaneContainer.hxx
+++ b/sdext/source/presenter/PresenterPaneContainer.hxx
@@ -104,7 +104,6 @@ public:

[Libreoffice-commits] core.git: drawinglayer/source include/drawinglayer

2016-06-26 Thread Noel Grandin

 drawinglayer/source/primitive2d/pagepreviewprimitive2d.cxx  |   65 
 drawinglayer/source/processor2d/hittestprocessor2d.cxx  |6 -
 drawinglayer/source/processor3d/cutfindprocessor3d.cxx  |   20 ---
 include/drawinglayer/primitive2d/pagepreviewprimitive2d.hxx |5 
 include/drawinglayer/processor2d/hittestprocessor2d.hxx |9 -
 include/drawinglayer/processor3d/cutfindprocessor3d.hxx |6 -
 6 files changed, 29 insertions(+), 82 deletions(-)

New commits:
commit db39c653e5de92bc371040a3f81cc5c4ea6dedf3
Author: Noel Grandin 
Date:   Sat Jun 25 14:55:09 2016 +0200

loplugin:singlevalfields in drawinglayer

Change-Id: I19f50b0afa624391bd0d8ada7afca822298e10cc
Reviewed-on: https://gerrit.libreoffice.org/26655
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/drawinglayer/source/primitive2d/pagepreviewprimitive2d.cxx 
b/drawinglayer/source/primitive2d/pagepreviewprimitive2d.cxx
index 3c2db2f..5cb7232 100644
--- a/drawinglayer/source/primitive2d/pagepreviewprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/pagepreviewprimitive2d.cxx
@@ -66,48 +66,37 @@ namespace drawinglayer
 // create a mapping from content to object.
 basegfx::B2DHomMatrix aPageTrans;
 
-if(getKeepAspectRatio())
+// #i101075# when keeping the aspect ratio is wanted, it 
is necessary to calculate
+// an equidistant scaling in X and Y and a corresponding 
translation to
+// center the output. Calculate needed scale factors
+const double fScaleX(aScale.getX() / getContentWidth());
+const double fScaleY(aScale.getY() / getContentHeight());
+
+// to keep the aspect, use the smaller scale and adapt 
missing size by translation
+if(fScaleX < fScaleY)
 {
-// #i101075# when keeping the aspect ratio is wanted, 
it is necessary to calculate
-// an equidistant scaling in X and Y and a 
corresponding translation to
-// center the output. Calculate needed scale factors
-const double fScaleX(aScale.getX() / 
getContentWidth());
-const double fScaleY(aScale.getY() / 
getContentHeight());
-
-// to keep the aspect, use the smaller scale and adapt 
missing size by translation
-if(fScaleX < fScaleY)
-{
-// height needs to be adapted
-const double fNeededHeight(aScale.getY() / 
fScaleX);
-const double fSpaceToAdd(fNeededHeight - 
getContentHeight());
-
-aPageTrans.translate(0.0, fSpaceToAdd * 0.5);
-aPageTrans.scale(fScaleX, aScale.getY() / 
fNeededHeight);
-}
-else
-{
-// width needs to be adapted
-const double fNeededWidth(aScale.getX() / fScaleY);
-const double fSpaceToAdd(fNeededWidth - 
getContentWidth());
-
-aPageTrans.translate(fSpaceToAdd * 0.5, 0.0);
-aPageTrans.scale(aScale.getX() / fNeededWidth, 
fScaleY);
-}
-
-// add the missing object transformation aspects
-const basegfx::B2DHomMatrix 
aCombined(basegfx::tools::createShearXRotateTranslateB2DHomMatrix(
-fShearX, fRotate, aTranslate.getX(), 
aTranslate.getY()));
-aPageTrans = aCombined * aPageTrans;
+// height needs to be adapted
+const double fNeededHeight(aScale.getY() / fScaleX);
+const double fSpaceToAdd(fNeededHeight - 
getContentHeight());
+
+aPageTrans.translate(0.0, fSpaceToAdd * 0.5);
+aPageTrans.scale(fScaleX, aScale.getY() / 
fNeededHeight);
 }
 else
 {
-// completely scale to PageObject size. Scale to unit 
size.
-aPageTrans.scale(1.0/ getContentWidth(), 1.0 / 
getContentHeight());
+// width needs to be adapted
+const double fNeededWidth(aScale.getX() / fScaleY);
+const double fSpaceToAdd(fNeededWidth - 
getContentWidth());
 
-// apply object matrix
-aPageTrans *= getTransform();
+aPageTrans.translate(fSpaceToAdd * 0.5, 0.0);
+aPageTrans.scale(aScale.getX() / fNeededWidth, 
fScaleY);

[Libreoffice-commits] core.git: sd/inc sd/source

2016-06-26 Thread Noel Grandin

 sd/inc/drawdoc.hxx  |6 
 sd/source/core/drawdoc.cxx  |1 
 sd/source/filter/eppt/eppt.cxx  |   36 +--
 sd/source/filter/eppt/eppt.hxx  |1 
 sd/source/filter/eppt/epptso.cxx|   12 -
 sd/source/filter/eppt/pptx-text.cxx |2 
 sd/source/ui/dlg/prltempl.cxx   |   25 --
 sd/source/ui/dlg/tabtempl.cxx   |   23 --
 sd/source/ui/func/fusel.cxx |   13 -
 sd/source/ui/func/unoaprms.cxx  |2 
 sd/source/ui/inc/ViewShell.hxx  |2 
 sd/source/ui/inc/Window.hxx |1 
 sd/source/ui/inc/fusel.hxx  |1 
 sd/source/ui/inc/prltempl.hxx   |9 
 sd/source/ui/inc/tabtempl.hxx   |6 
 sd/source/ui/inc/unoaprms.hxx   |4 
 sd/source/ui/sidebar/MasterPageContainer.cxx|   10 -
 sd/source/ui/slidesorter/controller/SlideSorterController.cxx   |1 
 sd/source/ui/slidesorter/controller/SlsFocusManager.cxx |   46 -
 sd/source/ui/slidesorter/controller/SlsProperties.cxx   |1 
 sd/source/ui/slidesorter/controller/SlsSelectionManager.cxx |6 
 sd/source/ui/slidesorter/controller/SlsSlotManager.cxx  |   91 
--
 sd/source/ui/slidesorter/inc/controller/SlsFocusManager.hxx |6 
 sd/source/ui/slidesorter/inc/controller/SlsProperties.hxx   |7 
 sd/source/ui/slidesorter/inc/controller/SlsSelectionManager.hxx |   10 -
 sd/source/ui/slidesorter/inc/model/SlideSorterModel.hxx |2 
 sd/source/ui/slidesorter/inc/model/SlsVisualState.hxx   |2 
 sd/source/ui/slidesorter/inc/view/SlideSorterView.hxx   |1 
 sd/source/ui/slidesorter/model/SlideSorterModel.cxx |9 
 sd/source/ui/slidesorter/model/SlsVisualState.cxx   |   10 -
 sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx |2 
 sd/source/ui/slidesorter/view/SlideSorterView.cxx   |5 
 sd/source/ui/view/sdwindow.cxx  |7 
 sd/source/ui/view/viewshel.cxx  |3 
 34 files changed, 85 insertions(+), 278 deletions(-)

New commits:
commit 19bacff27bd2201fb136963e11e865b8a31d849e
Author: Noel Grandin 
Date:   Sat Jun 25 16:00:41 2016 +0200

loplugin:singlevalfields in sd

Change-Id: Idde7bdbd57080518fc416ce97a062ab979393d8e
Reviewed-on: https://gerrit.libreoffice.org/26656
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sd/inc/drawdoc.hxx b/sd/inc/drawdoc.hxx
index 476be4d..a7bdff1 100644
--- a/sd/inc/drawdoc.hxx
+++ b/sd/inc/drawdoc.hxx
@@ -135,16 +135,12 @@ namespace sd
 // SdDrawDocument
 class SD_DLLPUBLIC SdDrawDocument : public FmFormModel
 {
-private:
-OUString msDocAccTitle;
 public:
 SAL_DLLPRIVATE void setDocAccTitle( const OUString& rTitle ) { 
msDocAccTitle = rTitle; }
 SAL_DLLPRIVATE const OUString& getDocAccTitle() const { return 
msDocAccTitle; }
-private:
-bool bReadOnly;
-public:
 SAL_DLLPRIVATE bool getDocReadOnly() const { return bReadOnly; }
 private:
+OUStringmsDocAccTitle;
 ::sd::Outliner* mpOutliner;  ///< local outliner for outline 
mode
 ::sd::Outliner* mpInternalOutliner;  ///< internal outliner for 
creation of text objects
 Timer*  mpWorkStartupTimer;
diff --git a/sd/source/core/drawdoc.cxx b/sd/source/core/drawdoc.cxx
index 2bf77d9..a507402 100644
--- a/sd/source/core/drawdoc.cxx
+++ b/sd/source/core/drawdoc.cxx
@@ -152,7 +152,6 @@ PresentationSettings::PresentationSettings( const 
PresentationSettings& r )
 
 SdDrawDocument::SdDrawDocument(DocumentType eType, SfxObjectShell* pDrDocSh)
 : FmFormModel( !utl::ConfigManager::IsAvoidConfig() ? 
SvtPathOptions().GetPalettePath() : OUString(), nullptr, pDrDocSh )
-, bReadOnly(false)
 , mpOutliner(nullptr)
 , mpInternalOutliner(nullptr)
 , mpWorkStartupTimer(nullptr)
diff --git a/sd/source/filter/eppt/eppt.cxx b/sd/source/filter/eppt/eppt.cxx
index 27184fd..b3f57a8 100644
--- a/sd/source/filter/eppt/eppt.cxx
+++ b/sd/source/filter/eppt/eppt.cxx
@@ -76,7 +76,6 @@ PPTWriter::PPTWriter( tools::SvRef& rSvStorage,
 PPTWriterBase   ( rXModel, rXStatInd ),
 mnCnvrtFlags( nCnvrtFlags ),
 mbStatus( false ),
-mbUseNewAnimations  ( true ),
 mnStatMaxValue  ( 0 ),
 mnLatestStatValue   ( 0 ),
 mnTextStyle( 0 ),
@@ -320,27 +319,24 @@ void PPTWriter::ImplWriteSlide( sal_uInt32 nPageNum, 
sal_uInt32

[Libreoffice-commits] core.git: include/svx svx/source

2016-06-26 Thread Noel Grandin

 include/svx/svdmodel.hxx|   21 -
 include/svx/svdmrkv.hxx |5 +
 include/svx/svdobj.hxx  |2 --
 include/svx/svdoedge.hxx|6 +-
 include/svx/svdogrp.hxx |1 -
 svx/source/svdraw/svdmodel.cxx  |   14 --
 svx/source/svdraw/svdmrkv.cxx   |3 ---
 svx/source/svdraw/svdobj.cxx|6 ++
 svx/source/svdraw/svdoedge.cxx  |4 
 svx/source/svdraw/svdogrp.cxx   |2 --
 svx/source/unodraw/unoshap4.cxx |8 +---
 11 files changed, 5 insertions(+), 67 deletions(-)

New commits:
commit c47d85be7839d0721a09f2eb100c4ab0abb7a985
Author: Noel Grandin 
Date:   Fri Jun 24 15:21:03 2016 +0200

loplugin:singlevalfields in svx(part2)

Change-Id: I1a1db1bdd446879a3abba3cb76a4ca575f859c1f
Reviewed-on: https://gerrit.libreoffice.org/26640
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx
index 709844d..3f617c2 100644
--- a/include/svx/svdmodel.hxx
+++ b/include/svx/svdmodel.hxx
@@ -168,9 +168,6 @@ protected:
 SdrOutliner*pChainingOutliner; // an Outliner for chaining overflowing 
text
 sal_uIntPtr   nDefTextHgt;// Default text height in logical 
units
 VclPtr  pRefOutDev; // ReferenceDevice for the EditEngine
-sal_uIntPtr   nProgressAkt;   // for the
-sal_uIntPtr   nProgressMax;   // ProgressBar-
-sal_uIntPtr   nProgressOfs;   // -Handler
 rtl::Reference< SfxStyleSheetBasePool > mxStyleSheetPool;
 SfxStyleSheet*  pDefaultStyleSheet;
 SfxStyleSheet* mpDefaultStyleSheetForSdrGrafObjAndSdrOle2Obj; // #i119287#
@@ -179,26 +176,18 @@ protected:
 std::deque* pRedoStack;
 SdrUndoGroup*   pAktUndoGroup;  // for deeper
 sal_uInt16  nUndoLevel; // undo nesting
-sal_uInt16  nProgressPercent; // for the ProgressBar-Handler
-sal_uInt16  nLoadVersion;   // version number of the loaded file
 boolbMyPool:1;// to clean up pMyPool from 303a
 boolbUIOnlyKomma:1; // see eUIUnit
 boolmbUndoEnabled:1;  // If false no undo is recorded or 
we are during the execution of an undo action
 boolbExtColorTable:1; // ne separate ColorTable
 boolmbChanged:1;
-boolbInfoChanged:1;
 boolbPagNumsDirty:1;
 boolbMPgNumsDirty:1;
 boolbTransportContainer:1;  // doc is temporary object 
container, no display (e.g. clipboard)
-boolbSavePortable:1;  // save metafiles portably
-boolbNoBitmapCaching:1;   // cache bitmaps for screen 
output
 boolbReadOnly:1;
 boolbTransparentTextFrames:1;
-boolbSaveCompressed:1;
 boolbSwapGraphics:1;
 boolbPasteResize:1; // Objects are being resized due to 
Paste with different MapMode
-boolbSaveOLEPreview:1;  // save preview metafile of 
OLE objects
-boolbSaveNative:1;
 boolbStarDrawPreviewMode:1;
 boolmbDisableTextEditUsesCommonUndoManager:1;
 SvStreamEndian  nStreamNumberFormat;
@@ -208,12 +197,6 @@ protected:
 TextChain*  pTextChain;
 
 
-// sdr::Comment interface
-private:
-// the next unique comment ID, used for counting added comments. 
Initialized
-// to 0. UI shows one more due to the fact that 0 is a no-no for users.
-sal_uInt32  mnUniqueCommentID;
-
 public:
 sal_uInt16  nStarDrawPreviewMasterPageNum;
 rtl::Reference mpForbiddenCharactersTable;
@@ -225,8 +208,6 @@ public:
 std::unique_ptr   mpImpl;
 sal_uInt16  mnCharCompressType;
 sal_uInt16  mnHandoutPageCount;
-sal_uInt16  nReserveUInt6;
-sal_uInt16  nReserveUInt7;
 boolmbModelLocked;
 boolmbKernAsianPunctuation;
 boolmbAddExtLeading;
@@ -428,8 +409,6 @@ public:
 voidSetSwapGraphicsMode(SdrSwapGraphicsMode nMode) { 
nSwapGraphicsMode = nMode; }
 SdrSwapGraphicsMode GetSwapGraphicsMode() const { return 
nSwapGraphicsMode; }
 
-boolIsSaveOLEPreview() const  { return 
bSaveOLEPreview; }
-
 // Text frames without filling can be select with a mouse click by default 
(sal_False).
 // With this flag set to true you can hit them only in the area in which 
text is to be
 // found.
diff --git a/include/svx/svdmrkv.hxx b/include/svx/svdmrkv.hxx
index 2a62ec8..7cc230a 100644
--- a/include/svx/svdmrkv.hxx
+++ b/include/svx/svdmrkv.hxx
@@ -117,16 +117,14 @@ protected:
 Rectangle   maMarkedPointsRect;

[Libreoffice-commits] core.git: include/svx svx/source

2016-06-26 Thread Noel Grandin

 include/svx/svddrgv.hxx|   40 
 include/svx/svdedtv.hxx|2 -
 include/svx/svdedxv.hxx|4 ---
 include/svx/svdetc.hxx |7 ++
 svx/source/svdraw/svdcrtv.cxx  |   45 +++--
 svx/source/svdraw/svddrgmt.cxx |   14 
 svx/source/svdraw/svddrgv.cxx  |6 -
 svx/source/svdraw/svdedtv.cxx  |2 -
 svx/source/svdraw/svdedxv.cxx  |1 
 svx/source/svdraw/svdetc.cxx   |1 
 svx/source/svdraw/svdoedge.cxx |   14 +++-
 svx/source/svdraw/svdview.cxx  |9 ++--
 12 files changed, 32 insertions(+), 113 deletions(-)

New commits:
commit 78ca0ce54a2cd79736247ea8cf69ad5fc797ee1a
Author: Noel Grandin 
Date:   Fri Jun 24 15:56:44 2016 +0200

loplugin:singlevalfields in svx(part3)

Change-Id: I6b7a33b5f1297309a7225cac8150dbf1175506b6
Reviewed-on: https://gerrit.libreoffice.org/26642
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/svddrgv.hxx b/include/svx/svddrgv.hxx
index 91fd524..b96fb27 100644
--- a/include/svx/svddrgv.hxx
+++ b/include/svx/svddrgv.hxx
@@ -48,9 +48,7 @@ protected:
 boolmbDragLimit : 1;  // Limit on SnapRect 
instead of BoundRect
 boolmbDragHdl : 1;// TRUE: RefPt is slid
 boolmbDragStripes : 1;// Persistent
-boolmbMirrRefDragObj : 1; // Persistent - During 
the drag, show the mirror axis of the mirrored objects as Xor
 boolmbSolidDragging : 1;  // allow solid 
create/drag of objects
-boolmbMouseHideWhileDraggingPoints : 1;
 boolmbResizeAtCenter : 1;
 boolmbCrookAtCenter : 1;
 boolmbDragWithCopy : 1;
@@ -58,10 +56,6 @@ protected:
 boolmbInsObjPointMode : 1;
 boolmbInsGluePointMode : 1;
 boolmbNoDragXorPolys : 1;
-boolmbAutoVertexCon : 1;  // automatic generation 
of connectors at the vertices
-boolmbAutoCornerCon : 1;  // automatic generation 
of connectors at the corners
-boolmbRubberEdgeDragging : 1;
-boolmbDetailedEdgeDragging : 1;
 
 private:
 SVX_DLLPRIVATE void ImpClearVars();
@@ -145,14 +139,6 @@ public:
 void SetDragStripes(bool bOn);
 bool IsDragStripes() const { return mbDragStripes; }
 
-// hide handles during dragging
-//HMHvoid SetDragHdlHide(bool bOn);
-//HMHBOOL IsDragHdlHide() const { return bNoDragHdl; }
-
-// Hide the mouse when dragging polygon points or glue points.
-// Default=false
-bool IsMouseHideWhileDraggingPoints() const { return 
mbMouseHideWhileDraggingPoints; }
-
 // As a general rule, the contours of the selected objects
 // are displayed as Xor-polygons. If this flag is set, only one
 // Xor-Frame is drawn (e.g. in case of multiple selection).
@@ -178,32 +164,6 @@ public:
 void SetSolidDragging(bool bOn);
 bool IsSolidDragging() const;
 
-// Dragging/Creation of connectors:
-// ~
-// Stick Connectors to vertices
-// Default=true=Yes
-bool IsAutoVertexConnectors() const { return mbAutoVertexCon; }
-
-// Stick Connectors to Corners
-// Default=false=No
-bool IsAutoCornerConnectors() const { return mbAutoCornerCon; }
-
-// Dragging of connected objects (Nodes):
-// ~~
-// DetailedEdgeDraggingLimit: like RubberEdgeDraggingLimit,
-// but this limit refers to the detailed depiction, i.e. not
-// only rubber bands but total recalculations are visible while
-// dragging. This detailed depiction is only possible in MoveDrag.
-// Default value: 10
-bool IsDetailedEdgeDragging() const { return mbDetailedEdgeDragging; }
-
-// EdgeDraggingLimit: If more than nEdgeObjCount edges are affected,
-// they are not shown in the interactive dragging.
-// This here talks about the "rubber bands", which take less computing time
-// than the complete recalculations in the DetailedEdgeDragging.
-// default value: 100
-bool IsRubberEdgeDragging() const { return mbRubberEdgeDragging; }
-
 // Connector handling is thus as follows (when using default settings):
 // - If at most 10 Connectors are affected, they are recalculated
 //   on each MouseMove.
diff --git a/include/svx/svdedtv.hxx b/include/svx/svdedtv.hxx
index 6b5caa9..71c1fd2 100644
--- a/include/svx/svdedtv.hxx
+++ b/include/svx/svdedtv.hxx
@@ -96,8 +96,6 @@ protected:
 boolbOneOrMoreMovable : 1;// at least one 
object is moveable
 bool

[Libreoffice-commits] core.git: include/svx svx/source

2016-06-26 Thread Noel Grandin

 include/svx/svdotext.hxx   |8 ---
 include/svx/svdpntv.hxx|7 ---
 include/svx/svdsnpv.hxx|1 
 include/svx/svdtrans.hxx   |8 ---
 include/svx/svdviter.hxx   |2 
 include/svx/tbxcolor.hxx   |1 
 include/svx/textchainflow.hxx  |2 
 include/svx/view3d.hxx |2 
 include/svx/viewpt3d.hxx   |7 ---
 svx/source/engine3d/scene3d.cxx|3 -
 svx/source/engine3d/view3d.cxx |1 
 svx/source/engine3d/viewpt3d2.cxx  |   44 ---
 svx/source/sdr/contact/objectcontact.cxx   |2 
 svx/source/sdr/contact/objectcontactofpageview.cxx |3 -
 svx/source/sdr/primitive2d/sdrattributecreator.cxx |3 -
 svx/source/svdraw/svdotext.cxx |   27 
 svx/source/svdraw/svdpagv.cxx  |   11 +---
 svx/source/svdraw/svdpntv.cxx  |4 -
 svx/source/svdraw/svdsnpv.cxx  |   28 +---
 svx/source/svdraw/svdtrans.cxx |   47 -
 svx/source/svdraw/svdviter.cxx |2 
 svx/source/svdraw/textchainflow.cxx|1 
 svx/source/table/svdotable.cxx |1 
 svx/source/tbxctrls/tbxcolor.cxx   |8 ---
 24 files changed, 22 insertions(+), 201 deletions(-)

New commits:
commit d6d1fc2683eeb88a569795e6bd27ad5db035f511
Author: Noel Grandin 
Date:   Fri Jun 24 14:48:36 2016 +0200

loplugin:singlevalfields in svx(part1)

Change-Id: I9f655f0573ea301faa6cb54733832c26864eae4f
Reviewed-on: https://gerrit.libreoffice.org/26639
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/svdotext.hxx b/include/svx/svdotext.hxx
index 2adf994..0b29fba 100644
--- a/include/svx/svdotext.hxx
+++ b/include/svx/svdotext.hxx
@@ -227,9 +227,6 @@ protected:
 SdrTextObj *mpNextInChain = nullptr;
 SdrTextObj *mpPrevInChain = nullptr;
 
-// indicating the for its text to be chained to another text box
-bool mbToBeChained : 1;
-
 // Fuer beschriftete Zeichenobjekte ist bTextFrame=FALSE. Der Textblock
 // wird dann hoizontal und vertikal an aRect zentriert. Bei bTextFrame=
 // sal_True wird der Text in aRect hineinformatiert. Der eigentliche 
Textrahmen
@@ -237,7 +234,6 @@ protected:
 boolbTextFrame : 1;
 boolbPortionInfoChecked : 1; // Fuer Optimierung 
von Textobjekten
 boolbNoShear : 1;// Obj darf nicht 
gesheart werden   (->Graf+Ole+TextFrame)
-boolbNoRotate : 1;   // Obj darf nicht 
gedreht werden(->Ole)
 boolbNoMirror : 1;   // Obj darf nicht 
gespiegelt werden (->Ole,TextFrame)
 boolbTextSizeDirty : 1;
 
@@ -254,9 +250,6 @@ protected:
 // - Positions+Groesse Dialog
 boolbDisableAutoWidthOnDragging : 1;
 
-// Allow text suppression
-boolmbTextHidden : 1;
-
 // Flag for allowing text animation. Default is sal_true.
 boolmbTextAnimationAllowed : 1;
 
@@ -356,7 +349,6 @@ public:
 bool IsFitToSize() const;
 
 // Chaining
-bool IsToBeChained() const;
 SdrTextObj *GetNextLinkInChain() const;
 void SetNextLinkInChain(SdrTextObj *);
 SdrTextObj *GetPrevLinkInChain() const;
diff --git a/include/svx/svdpntv.hxx b/include/svx/svdpntv.hxx
index 1d91468..7c21f60 100644
--- a/include/svx/svdpntv.hxx
+++ b/include/svx/svdpntv.hxx
@@ -169,16 +169,12 @@ protected:
 boolmbGlueVisible2 : 1;   // Also show glue points 
for GluePointEdit
 boolmbGlueVisible3 : 1;   // Also show glue points 
for EdgeTool
 boolmbGlueVisible4 : 1;   // Show glue points, if 
one edge is selected
-boolmbRestoreColors : 1;  // Pens and Brushes are 
reset
 boolmbSomeObjChgdFlag : 1;
 boolmbSwapAsynchron : 1;
 boolmbPrintPreview : 1;
 
 // These bools manage, the status that is displayed
 //
-// Enter/Leave group: default is true, but is set to false in
-// e.g. Chart, where we'd get Ghost effects when rendering
-boolmbVisualizeEnteredGroup : 1;
 boolmbAnimationPause : 1;
 
 // Flag which decides if buffered output for this view is allowed. When
@@ -294,9 +290,6 @@ public:
 // Data read access on logic HitTolerance and MinMoveTolerance
 sal_uInt16

[Libreoffice-commits] core.git: cui/source

2016-06-26 Thread Noel Grandin

 cui/source/customize/macropg.cxx |1 
 cui/source/dialogs/iconcdlg.cxx  |   82 +
 cui/source/inc/cuitabarea.hxx|4 
 cui/source/inc/iconcdlg.hxx  |5 
 cui/source/inc/macropg.hxx   |2 
 cui/source/inc/treeopt.hxx   |1 
 cui/source/options/treeopt.cxx   |5 
 cui/source/tabpages/tpcolor.cxx  |1 
 cui/source/tabpages/tpshadow.cxx |  331 ++-
 9 files changed, 173 insertions(+), 259 deletions(-)

New commits:
commit 98747742b20c82382ed16b193e7bec175e905978
Author: Noel Grandin 
Date:   Fri Jun 24 13:12:25 2016 +0200

loplugin:singlevalfields in cui

Change-Id: Iead1e313077951eccf91556816724afcaa66
Reviewed-on: https://gerrit.libreoffice.org/26635
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/cui/source/customize/macropg.cxx b/cui/source/customize/macropg.cxx
index 0c32d0b..ad8517c 100644
--- a/cui/source/customize/macropg.cxx
+++ b/cui/source/customize/macropg.cxx
@@ -229,7 +229,6 @@ SvxMacroTabPage_::SvxMacroTabPage_(vcl::Window* pParent, 
const OString& rID,
 : SfxTabPage( pParent, rID, rUIXMLDescription,  ),
 m_xAppEvents(nullptr),
 m_xDocEvents(nullptr),
-bReadOnly(false),
 bDocModified(false),
 bAppEvents(false),
 bInitialized(false)
diff --git a/cui/source/dialogs/iconcdlg.cxx b/cui/source/dialogs/iconcdlg.cxx
index 5f13d48..1a89730 100644
--- a/cui/source/dialogs/iconcdlg.cxx
+++ b/cui/source/dialogs/iconcdlg.cxx
@@ -165,10 +165,7 @@ IconChoiceDialog::IconChoiceDialog ( vcl::Window* pParent, 
const OUString& rID,
 pExampleSet ( nullptr ),
 pRanges ( nullptr ),
 
-bHideResetBtn   ( false ),
-bModal  ( false ),
-bInOK   ( false ),
-bItemsReset ( false )
+bInOK   ( false )
 {
 get(m_pOKBtn, "ok");
 get(m_pApplyBtn, "apply");
@@ -232,8 +229,6 @@ void IconChoiceDialog::dispose()
 //SetViewOptUserItem( aTabPageOpt, aPageData );
 }
 
-if ( pData->bOnDemand )
-delete >pPage->GetItemSet();
 pData->pPage.disposeAndClear();
 }
 delete pData;
@@ -283,7 +278,6 @@ SvxIconChoiceCtrlEntry* IconChoiceDialog::AddTabPage(
 maPageList.push_back( pData );
 
 pData->fnGetRanges = nullptr;
-pData->bOnDemand = false;
 
 sal_uInt16 *pId = new sal_uInt16 ( nId );
 SvxIconChoiceCtrlEntry* pEntry = m_pIconCtrl->InsertEntry( rIconText, 
rChoiceIcon );
@@ -370,13 +364,8 @@ IMPL_LINK_NOARG_TYPED(IconChoiceDialog, OkHdl, Button*, 
void)
 
 if ( OK_Impl() )
 {
-if ( bModal )
-EndDialog( Ok() );
-else
-{
-Ok();
-Close();
-}
+Ok();
+Close();
 }
 }
 
@@ -387,13 +376,8 @@ IMPL_LINK_NOARG_TYPED(IconChoiceDialog, ApplyHdl, Button*, 
void)
 
 if ( OK_Impl() )
 {
-if ( bModal )
-EndDialog( Ok() );
-else
-{
-Ok();
-Close();
-}
+Ok();
+Close();
 }
 }
 
@@ -404,14 +388,7 @@ IMPL_LINK_NOARG_TYPED(IconChoiceDialog, ResetHdl, Button*, 
void)
 IconChoicePageData* pData = GetPageData ( mnCurrentPageId );
 DBG_ASSERT( pData, "Id nicht bekannt" );
 
-if ( pData->bOnDemand )
-{
-// CSet on AIS has problems here, therefore separated
-const SfxItemSet* _pSet = &( pData->pPage->GetItemSet() );
-pData->pPage->Reset( *const_cast(_pSet) );
-}
-else
-pData->pPage->Reset( *pSet );
+pData->pPage->Reset( *pSet );
 }
 
 
@@ -431,30 +408,13 @@ void IconChoiceDialog::ActivatePageImpl ()
 DBG_ASSERT( !maPageList.empty(), "keine Pages angemeldet" );
 IconChoicePageData* pData = GetPageData ( mnCurrentPageId );
 DBG_ASSERT( pData, "Id nicht bekannt" );
-bool bReadOnly = false;
 if ( pData )
 {
 if ( !pData->pPage )
 {
-const SfxItemSet* pTmpSet = nullptr;
-
-if ( pSet )
-{
-if ( bItemsReset && pSet->GetParent() )
-pTmpSet = pSet->GetParent();
-else
-pTmpSet = pSet;
-}
+pData->pPage = (pData->fnCreatePage)( m_pTabContainer, this, 
*CreateInputItemSet( mnCurrentPageId ) );
 
-if ( pTmpSet && !pData->bOnDemand )
-pData->pPage = (pData->fnCreatePage)( m_pTabContainer, this, 
*pTmpSet );
-else
-pData->pPage = (pData->fnCreatePage)( m_pTabContainer, this, 
*CreateInputItemSet( mnCurrentPageId ) );
-
-if ( pData->bOnDemand )
-pData->pPage->Reset( (SfxItemSet &)pData->pPage->GetItemSet() 
);
-else
-pData->pPage->Reset( *pSet );
+pData->pPage->Reset( *pSet );
 
 PageCreated( mnCurrentPageId, *pData->pPage );
 }
@@

[Libreoffice-commits] core.git: dbaccess/source desktop/source

2016-06-26 Thread Noel Grandin

 dbaccess/source/ui/control/SqlNameEdit.cxx |2 
 dbaccess/source/ui/control/VertSplitView.cxx   |   81 +++--
 dbaccess/source/ui/control/dbtreelistbox.cxx   |3 
 dbaccess/source/ui/dlg/dbfindex.cxx|   15 --
 dbaccess/source/ui/dlg/dbfindex.hxx|3 
 dbaccess/source/ui/inc/SqlNameEdit.hxx |2 
 dbaccess/source/ui/inc/TableDesignControl.hxx  |3 
 dbaccess/source/ui/inc/VertSplitView.hxx   |1 
 dbaccess/source/ui/inc/dbtreelistbox.hxx   |2 
 dbaccess/source/ui/tabledesign/TableDesignControl.cxx  |3 
 desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx |   25 +---
 desktop/source/splash/splash.cxx   |5 
 12 files changed, 38 insertions(+), 107 deletions(-)

New commits:
commit 22864b44fd00b5a778ef597f8dfcb407d4166306
Author: Noel Grandin 
Date:   Fri Jun 24 12:57:04 2016 +0200

loplugin:singlevalfields in dbaccess

Change-Id: I5c8990187b2b488eb75369c2a3e3dc7f855ce06a
Reviewed-on: https://gerrit.libreoffice.org/26633
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/dbaccess/source/ui/control/SqlNameEdit.cxx 
b/dbaccess/source/ui/control/SqlNameEdit.cxx
index 5c025af..4f89d37 100644
--- a/dbaccess/source/ui/control/SqlNameEdit.cxx
+++ b/dbaccess/source/ui/control/SqlNameEdit.cxx
@@ -41,7 +41,7 @@ namespace dbaui
 sal_Int32 nMatch = 0;
 for (sal_Int32 i = nMatch; i < _sToCheck.getLength(); ++i)
 {
-if ( !isCharOk( _sToCheck[i], i == 0, m_bOnlyUpperCase, 
m_sAllowedChars ) )
+if ( !isCharOk( _sToCheck[i], i == 0, false/*bOnlyUpperCase*/, 
m_sAllowedChars ) )
 {
 _rsCorrected += _sToCheck.copy(nMatch, i - nMatch);
 bCorrected = true;
diff --git a/dbaccess/source/ui/control/VertSplitView.cxx 
b/dbaccess/source/ui/control/VertSplitView.cxx
index bf9dd11..4b79daa 100644
--- a/dbaccess/source/ui/control/VertSplitView.cxx
+++ b/dbaccess/source/ui/control/VertSplitView.cxx
@@ -32,7 +32,6 @@ OSplitterView::OSplitterView(vcl::Window* _pParent) : 
Window(_pParent,WB_DIALOGC
 ,m_pSplitter( nullptr )
 ,m_pLeft(nullptr)
 ,m_pRight(nullptr)
-,m_bVertical(false)
 {
 ImplInitSettings();
 }
@@ -53,13 +52,7 @@ void OSplitterView::dispose()
 IMPL_LINK_NOARG_TYPED( OSplitterView, SplitHdl, Splitter*, void )
 {
 OSL_ENSURE(m_pSplitter, "Splitter is NULL!");
-if ( m_bVertical )
-{
-long nPosY = m_pSplitter->GetPosPixel().Y();
-m_pSplitter->SetPosPixel( Point( m_pSplitter->GetSplitPosPixel(), 
nPosY ) );
-}
-else
-m_pSplitter->SetPosPixel( Point( 
m_pSplitter->GetPosPixel().X(),m_pSplitter->GetSplitPosPixel() ) );
+m_pSplitter->SetPosPixel( Point( 
m_pSplitter->GetPosPixel().X(),m_pSplitter->GetSplitPosPixel() ) );
 
 Resize();
 }
@@ -123,61 +116,31 @@ void OSplitterView::Resize()
 {
 aSplitPos   = m_pSplitter->GetPosPixel();
 aSplitSize  = m_pSplitter->GetOutputSizePixel();
-if ( m_bVertical )
-{
-// calculate the splitter pos and size
-aSplitPos.Y() = aPlaygroundPos.Y();
-aSplitSize.Height() = aPlaygroundSize.Height();
-
-if( ( aSplitPos.X() + aSplitSize.Width() ) > ( 
aPlaygroundSize.Width() ))
-aSplitPos.X() = aPlaygroundSize.Width() - aSplitSize.Width();
-
-if( aSplitPos.X() <= aPlaygroundPos.X() )
-aSplitPos.X() = aPlaygroundPos.X() + 
sal_Int32(aPlaygroundSize.Width() * 0.3);
-
-// the tree pos and size
-Point   aTreeViewPos( aPlaygroundPos );
-SizeaTreeViewSize( aSplitPos.X(), aPlaygroundSize.Height() );
-
-// set the size of treelistbox
-m_pLeft->SetPosSizePixel( aTreeViewPos, aTreeViewSize );
-
-//set the size of the splitter
-m_pSplitter->SetPosSizePixel( aSplitPos, Size( aSplitSize.Width(), 
aPlaygroundSize.Height() ) );
-m_pSplitter->SetDragRectPixel( 
Rectangle(aPlaygroundPos,aPlaygroundSize) );
-}
-else
-{
-aSplitPos.X() = aPlaygroundPos.X();
-aSplitSize.Width() = aPlaygroundSize.Width();
-
-if( ( aSplitPos.Y() + aSplitSize.Height() ) > ( 
aPlaygroundSize.Height() ))
-aSplitPos.Y() = aPlaygroundSize.Height() - aSplitSize.Height();
-
-if( aSplitPos.Y() <= aPlaygroundPos.Y() )
-aSplitPos.Y() = aPlaygroundPos.Y() + 
sal_Int32(aPlaygroundSize.Height() * 0.3);
-
-// the tree pos and size
-Point   aTreeViewPos( aPlaygroundPos );
-SizeaTreeViewSize( aPlaygroundSize.Width() ,aSplitPos.Y());
-
-// set the size of treelistbox
-

[Libreoffice-commits] core.git: basic/inc basic/qa basic/source

2016-06-26 Thread Noel Grandin

 basic/inc/sbprop.hxx|1 -
 basic/qa/cppunit/basic_coverage.cxx |4 +---
 basic/source/basmgr/basmgr.cxx  |   17 -
 basic/source/classes/sbxmod.cxx |1 -
 basic/source/comp/scanner.cxx   |1 -
 basic/source/inc/scanner.hxx|1 -
 6 files changed, 5 insertions(+), 20 deletions(-)

New commits:
commit cea4c1afdf4ae0cbda8ae531f2e26d911d0fd6e1
Author: Noel Grandin 
Date:   Fri Jun 24 12:08:25 2016 +0200

loplugin:singlevalfields in basic and fix leak

And fix leak in BasicManagerImpl where it would never have freed
the streams.

Change-Id: I1e99c2c6a70a8cac27dd5c86a7042efc3de7a578
Reviewed-on: https://gerrit.libreoffice.org/26632
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/basic/inc/sbprop.hxx b/basic/inc/sbprop.hxx
index 09138ae..fbeb138 100644
--- a/basic/inc/sbprop.hxx
+++ b/basic/inc/sbprop.hxx
@@ -32,7 +32,6 @@ class BASIC_DLLPUBLIC SbProperty : public SbxProperty
 friend class SbModule;
 friend class SbProcedureProperty;
 SbModule* pMod;
-bool bInvalid;
 BASIC_DLLPRIVATE SbProperty( const OUString&, SbxDataType, SbModule* );
 virtual ~SbProperty();
 public:
diff --git a/basic/qa/cppunit/basic_coverage.cxx 
b/basic/qa/cppunit/basic_coverage.cxx
index 275fdb9..39a8ebc 100644
--- a/basic/qa/cppunit/basic_coverage.cxx
+++ b/basic/qa/cppunit/basic_coverage.cxx
@@ -21,7 +21,6 @@ class Coverage : public test::BootstrapFixture
 {
 private:
 int  m_nb_tests_ok;
-int  m_nb_tests_skipped;
 OUString m_sCurrentTest;
 void process_directory(const OUString& sDirName);
 void run_test(const OUString& sFileName);
@@ -48,13 +47,12 @@ public:
 Coverage::Coverage()
 : BootstrapFixture(true, false)
 , m_nb_tests_ok(0)
-, m_nb_tests_skipped(0)
 {
 }
 
 Coverage::~Coverage()
 {
-fprintf(stderr,"basic coverage Summary : skipped:%d pass:%d\n", 
m_nb_tests_skipped, m_nb_tests_ok );
+fprintf(stderr,"basic coverage Summary : pass:%d\n", m_nb_tests_ok );
 }
 
 void Coverage::test_failed()
diff --git a/basic/source/basmgr/basmgr.cxx b/basic/source/basmgr/basmgr.cxx
index 918d61d..aeba2e6 100644
--- a/basic/source/basmgr/basmgr.cxx
+++ b/basic/source/basmgr/basmgr.cxx
@@ -34,6 +34,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -107,16 +108,13 @@ struct BasicManagerImpl
 
 // Save stream data
 SvMemoryStream*  mpManagerStream;
-SvMemoryStream** mppLibStreams;
-sal_Int32mnLibStreamCount;
+std::vector maLibStreams;
 
 std::vector aLibs;
 OUString aBasicLibPath;
 
 BasicManagerImpl()
 : mpManagerStream( nullptr )
-, mppLibStreams( nullptr )
-, mnLibStreamCount( 0 )
 {}
 ~BasicManagerImpl();
 };
@@ -124,12 +122,6 @@ struct BasicManagerImpl
 BasicManagerImpl::~BasicManagerImpl()
 {
 delete mpManagerStream;
-if( mppLibStreams )
-{
-for( sal_Int32 i = 0 ; i < mnLibStreamCount ; i++ )
-delete mppLibStreams[i];
-delete[] mppLibStreams;
-}
 }
 
 
@@ -539,13 +531,12 @@ BasicManager::BasicManager( SotStorage& rStorage, const 
OUString& rBaseURL, Star
 if( xBasicStorage.Is() && !xBasicStorage->GetError() )
 {
 sal_uInt16 nLibs = GetLibCount();
-mpImpl->mppLibStreams = new SvMemoryStream*[ nLibs ];
 for( sal_uInt16 nL = 0; nL < nLibs; nL++ )
 {
 BasicLibInfo& rInfo = *mpImpl->aLibs[nL];
 tools::SvRef xBasicStream = 
xBasicStorage->OpenSotStream( rInfo.GetLibName(), eStreamReadMode );
-mpImpl->mppLibStreams[nL] = new SvMemoryStream();
-xBasicStream->ReadStream( *( mpImpl->mppLibStreams[nL] ) );
+
mpImpl->maLibStreams.push_back(o3tl::make_unique());
+xBasicStream->ReadStream( *mpImpl->maLibStreams.back() );
 }
 }
 }
diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index 7970f04..f36b9bf 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -2719,7 +2719,6 @@ SbUserFormModule::Find( const OUString& rName, 
SbxClassType t )
 SbProperty::SbProperty( const OUString& r, SbxDataType t, SbModule* p )
 : SbxProperty( r, t ), pMod( p )
 {
-bInvalid = false;
 }
 
 SbProperty::~SbProperty()
diff --git a/basic/source/comp/scanner.cxx b/basic/source/comp/scanner.cxx
index 6dfe2c5..968458f 100644
--- a/basic/source/comp/scanner.cxx
+++ b/basic/source/comp/scanner.cxx
@@ -31,7 +31,6 @@ SbiScanner::SbiScanner( const OUString& rBuf, StarBASIC* p ) 
: aBuf( rBuf )
 eScanType = SbxVARIANT;
 nErrors  = 0;
 nBufPos  = 0;
-nCurCol1 = 0;
 nSavedCol1 = 0;
 nColLock = 0;
 nLine= 0;
diff --git a/basic/source/inc/scanner.hxx b/basic/source/inc/scanner.hxx
index

[Libreoffice-commits] core.git: vcl/inc vcl/osx vcl/source vcl/unx vcl/win

2016-06-26 Thread Noel Grandin

 vcl/inc/fontattributes.hxx   |2 --
 vcl/inc/salwtype.hxx |2 --
 vcl/inc/unx/gtk/gtkframe.hxx |2 --
 vcl/inc/unx/printergfx.hxx   |6 +-
 vcl/inc/unx/saldata.hxx  |1 -
 vcl/inc/unx/salframe.h   |3 ---
 vcl/inc/unx/wmadaptor.hxx|8 
 vcl/inc/window.h |3 ---
 vcl/osx/salframeview.mm  |6 --
 vcl/source/edit/vclmedit.cxx |5 -
 vcl/source/filter/wmf/winmtf.hxx |1 -
 vcl/source/filter/wmf/winwmf.cxx |2 --
 vcl/source/font/fontattributes.cxx   |2 --
 vcl/source/fontsubset/cff.cxx|   24 
 vcl/source/gdi/pdfwriter_impl.cxx|   32 
 vcl/source/gdi/pdfwriter_impl.hxx|7 +--
 vcl/source/outdev/font.cxx   |4 ++--
 vcl/source/window/menubarwindow.cxx  |   34 ++
 vcl/source/window/menubarwindow.hxx  |1 -
 vcl/source/window/settings.cxx   |4 ++--
 vcl/source/window/window.cxx |   11 ---
 vcl/unx/generic/app/i18n_cb.cxx  |2 --
 vcl/unx/generic/app/i18n_ic.cxx  |6 --
 vcl/unx/generic/app/saldata.cxx  |1 -
 vcl/unx/generic/app/wmadaptor.cxx|3 ---
 vcl/unx/generic/print/bitmap_gfx.cxx |   22 +++---
 vcl/unx/generic/print/common_gfx.cxx |3 ---
 vcl/unx/generic/print/text_gfx.cxx   |2 +-
 vcl/unx/generic/window/salframe.cxx  |   24 ++--
 vcl/unx/gtk/gtksalframe.cxx  |   19 ++-
 vcl/unx/gtk/salnativewidgets-gtk.cxx |4 
 vcl/unx/gtk3/gtk3gtkframe.cxx|7 ---
 vcl/win/window/salframe.cxx  |4 
 33 files changed, 36 insertions(+), 221 deletions(-)

New commits:
commit 1ac18c60bb280855cfcc8d92886709cd6db35118
Author: Noel Grandin 
Date:   Thu Jun 23 14:10:31 2016 +0200

loplugin:singlevalfields in vcl(part2)

Change-Id: I4782c6f6d3d090ba0f9e29af8afdd7d88aa2d382
Reviewed-on: https://gerrit.libreoffice.org/26598
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/vcl/inc/fontattributes.hxx b/vcl/inc/fontattributes.hxx
index faca6a8..fcd2fa8 100644
--- a/vcl/inc/fontattributes.hxx
+++ b/vcl/inc/fontattributes.hxx
@@ -42,7 +42,6 @@ public:
 FontItalic  GetItalic() const   { return 
meItalic; }
 FontPitch   GetPitch() const{ return 
mePitch; }
 FontWidth   GetWidthType() const{ return 
meWidthType; }
-TextAlign   GetAlignment() const{ return 
meAlign; }
 rtl_TextEncodingGetCharSet() const  { return 
meCharSet; }
 
 boolIsSymbolFont() const{ return 
mbSymbolFlag; }
@@ -86,7 +85,6 @@ private:
 FontPitch   mePitch;// Pitch Type
 FontWidth   meWidthType;// Width Type
 FontItalic  meItalic;   // Slant Type
-TextAlign   meAlign;// Text alignment
 rtl_TextEncodingmeCharSet;  // RTL_TEXTENCODING_SYMBOL 
or RTL_TEXTENCODING_UNICODE
 boolmbSymbolFlag;   // Is font a symbol?
 
diff --git a/vcl/inc/salwtype.hxx b/vcl/inc/salwtype.hxx
index 2a45616..75fae73 100644
--- a/vcl/inc/salwtype.hxx
+++ b/vcl/inc/salwtype.hxx
@@ -161,12 +161,10 @@ struct SalWheelMouseEvent
 
 struct SalExtTextInputEvent
 {
-sal_uInt64  mnTime; // Time in ms, when event is created
 OUStringmaText; // Text
 const ExtTextInputAttr* mpTextAttr; // Text-Attribute
 sal_Int32   mnCursorPos;// Cursor-Position
 sal_uInt8   mnCursorFlags;  // EXTTEXTINPUT_CURSOR_xxx
-boolmbOnlyCursor;   // true: Only Cursor-Position has been 
changed
 };
 
 struct SalExtTextInputPosEvent
diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index ff5c454..30c0743 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -180,7 +180,6 @@ class GtkSalFrame : public SalFrame
 GdkNativeWindow m_aForeignParentWindow;
 GdkWindow*  m_pForeignTopLevel;
 GdkNativeWindow m_aForeignTopLevelWindow;
-Pixmap  m_hBackgroundPixmap;
 SalFrameStyleFlags  m_nStyle;
 SalExtStyle m_nExtStyle;
 GtkSalFrame*m_pParent;
@@ -381,7 +380,6 @@ public:
 GdkNativeWindow getForeignParentWindow() const { return 
m_aForeignParentWindow; }
 GdkWindow*  getForeignTopLevel() const { return m_pForeignTopLevel; }
 GdkNativeWindow getForeignTopLevelWindow() const { return

[Libreoffice-bugs] [Bug 100633] New: Cannot turn on grid lines if turned off by Microsoft Excel.

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100633

Bug ID: 100633
   Summary: Cannot turn on grid lines if turned off by Microsoft
Excel.
   Product: LibreOffice
   Version: 5.0.6.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: akashpau...@gmail.com

I recently switched to Libre office and had all my documents previously edited
using Office, in a particular .xlsx file in which i had turned off grid lines
in Excel, i couldn't turn it back on in Calc. i had to open the file in excel
and then turn on the grid lines and then save and exit to see them again in
calc. now that it had been turned on in Excel, i can switch on and off it in
calc too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=44282

abhilash300si...@gmail.com changed:

   What|Removed |Added

   Assignee|abhilash300si...@gmail.com  |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=44282

abhilash300si...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |abhilash300si...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Quick update about crash reporting and some open issues

2016-06-26 Thread Markus Mohrhard

Hey,

so here is a quick update about the crash reporting and a few questions
about open issues. It would be good if people who are going to use the
service to have a quick look through the items and tell me their opinion
about the open items.

So starting with the update:

I just fixed the signature generation and started the work on the 64bit
Windows system library support. All reports have been reprocessed and the
signature no longer contains an offset. This finally merges x64 and x86
reports under the the same signature.
The summary view in the signature page has a basic implementation and just
needs some extending to other things that are useful. A few that are on my
list are OpenGL device, OpenGL vendor, better windows version summaries and
generic metadata support.

What still needs to be implemented and is quite high on the issue list is
to add a reference from the crash details page back to bugzilla.



Then a few open questions about process around the crash reporting:


Do we want some way for the ESC to get a list of the 10 most frequent
crashes of the last week or something like that?

Do we want to notify the crash reporter if there was a commit referencing a
crash report? Similar to how bugzilla is automatically updated we could do
something like this for the crash reporter. That might help with keeping
track if there was already a fix for a crash and we are only seeing more
reports because it is not yet in a released version.
What would be the format of the reference?

How do we want to handle stuff that requires user interaction? Examples are
adding new versions, adding references to bug reports and possibly export
of crash reports to bugzilla.
For the bugzilla to crash report direction we had planned to handle it with
a bot monitoring the crash report field in bugzilla and update the crash
reporter website.
There are maybe more tasks in the future that will require some actions
that cause DB changes by users. Duplicating the login system from bugzilla
seems like a horrible concept and will just cause us to have even more
logins that nobody remembers.

How do we want to handle old crash reports? We can't keep the reports
forever and will most likely delete them as soon as a branch becomes EOL.
The question is whether there is value in exporting them to some format
(most likely json) and archive them or just forget completely about old
reports.

There is an exploitability feature in breakpad that can do an automatic
assessment but I have no idea how good the reports are. I know that it is
enabled but only visible in the Mozilla version. Do we want something like
that and if we want it do we want to hide it?


I'll have most likely a few more items that will come up after the release.
I hope that the current service is already useful. If there is anything
else missing please let me know.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 100545] Calc 5.0.6 crashes with file made in Calc 4

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100545

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu,
   ||qui...@gmail.com
Version|unspecified |5.0.6.3 release

--- Comment #7 from Aron Budea  ---
Thanks for the trace. Could you also attach 'cache/opencl_devices.log' from
5.3.0.0.alpha0's user profile?


Adding Tomaz to CC. Since it crashes in a clGetExtensionFunctionAddress() call,
could it be an extension not supported by the device?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99088] SVG coming from Inkscape is exported with incorrect size

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99088

Aron Budea  changed:

   What|Removed |Added

Summary|Editing single fill color   |SVG coming from Inkscape is
   |in SVG distorts image   |exported with incorrect
   ||size

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100632] SIDEBAR, FILEOPEN: Certain Position & Size fields in Sidebar are not filled for this SVG

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100632

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||088

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99088] Editing single fill color in SVG distorts image

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99088

Aron Budea  changed:

   What|Removed |Added

   Keywords||bibisectRequest,
   ||filter:svgOpen, regression
 Status|UNCONFIRMED |NEW
Version|5.1.1.3 release |5.2.0.1 rc
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0632
 Ever confirmed|0   |1

--- Comment #14 from Aron Budea  ---
Thanks for testing, Heiko!

For the issues with Sidebar's numbers, I've opened bug 100632.

Regarding the size change, what is displayed upon reopening is a regression,
but I wonder about the width/height in the exported SVG, 9.88mm/1.41mm
corresponds to 28px/4px at 72 DPI, which isn't correct, and it's been like that
since 3.3 (though there the exported SVG was a lot different). If that was
rectified, that might affect GIMP's default behavior as well.

To have the exact regression in a single comment (pruned the part that belongs
to the other bug report, disregard the incorrect 0 values):
> Open orig.svg in 5.1.4.2 (LibO fresh)
> 0.07/0.00/0.84/0.08 (Sidebar Ho/V/W/He)

> Export to new.svg, restart Draw and open new.svg
> 0.07/0.00/0.84/0.08 (Sidebar)

> Open orig.svg in 5.3.0.0 (Build ID: 7000e1a0640156645252d15d505949bff3d1eb4a) 
> <= or 5.2.0.1
> 0.07/0.00/0.84/0.00

> new.svg
> 0.09/0.00/1.07/0.00 <- Regression issue confirmed

(0.07 -> 0.09, 0.84 -> 1.07)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - external/breakpad

2016-06-26 Thread Markus Mohrhard

 external/breakpad/ExternalProject_breakpad.mk |2 +-
 external/breakpad/breakpad-stackwalk.patch.1  |4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 3f22898c157995eecf5dbd610591d378820cf992
Author: Markus Mohrhard 
Date:   Mon Jun 27 04:42:22 2016 +0200

I screwed up with the breakpad minidump_stackwalk patch

This does not affect normal LibreOffice and is only important for the
server side.

Change-Id: I270262ed6e1b22c3ef41099fda19fa386f386203

diff --git a/external/breakpad/breakpad-stackwalk.patch.1 
b/external/breakpad/breakpad-stackwalk.patch.1
index 9a3ce95..8df1fa3 100644
--- a/external/breakpad/breakpad-stackwalk.patch.1
+++ b/external/breakpad/breakpad-stackwalk.patch.1
@@ -24,9 +24,9 @@ diff -ur breakpad.org/src/processor/stackwalk_common.cc 
breakpad/src/processor/s
 kOutputSeparator, base_address + module->size() - 1,
 kOutputSeparator,
 -   main_module != NULL && base_address == main_address ? 1 : 0);
-+   main_module != NULL && base_address == main_address ? 1 : 0),
++   main_module != NULL && base_address == main_address ? 1 : 0,
 +   kOutputSeparator,
-+   
StripSeparator(PathnameStripper::File(module->code_identifier())).c_str();
++   
StripSeparator(PathnameStripper::File(module->code_identifier())).c_str());
}
  }
  
commit e54b208df3ee037a21c4d36678c5561c0f4718ae
Author: Markus Mohrhard 
Date:   Mon Jun 27 04:41:57 2016 +0200

always compile breakpad with O2

Change-Id: I4cda93fee47244cf3eb7b13bb6cb2a3eab007cf0

diff --git a/external/breakpad/ExternalProject_breakpad.mk 
b/external/breakpad/ExternalProject_breakpad.mk
index 70df68e..10fa6ce 100644
--- a/external/breakpad/ExternalProject_breakpad.mk
+++ b/external/breakpad/ExternalProject_breakpad.mk
@@ -20,7 +20,7 @@ else # !ifeq($(COM),MSC)
 
 $(call gb_ExternalProject_get_state_target,breakpad,build) :
$(call gb_ExternalProject_run,build,\
-   ./configure \
+   CXX_FLAGS="-O2" ./configure \
&& $(MAKE) \
)
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[ANN] mdds 1.2.1 on master

2016-06-26 Thread Kohei Yoshida

Hi there,

This news is actually a few days old, but the master branch now builds
with mdds 1.2.1, which includes one crasher bug fix for Calc (patch
submitted from Caolan).

ATB,

Kohei

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 100628] FILEOPEN LibreOffice marketing flyer looks badly when opened in LibreOffice

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100628

--- Comment #2 from Oliver Sander  ---
Ah, thanks!  May I propose to mention this issue on the Gallery_Flyers page?

May I also propose to add pdf versions of the localized flyers, too?  Most
people will (like me) not be interested in actually editing the flyer, but the
missing font is apparently nontrivial to install on a Debian machine.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100632] SIDEBAR, FILEOPEN: Certain Position & Size fields in Sidebar are not filled for this SVG

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100632

Aron Budea  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Severity|normal  |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100632] New: SIDEBAR, FILEOPEN: Certain Position & Size fields in Sidebar are not filled for this SVG

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100632

Bug ID: 100632
   Summary: SIDEBAR, FILEOPEN: Certain Position & Size fields in
Sidebar are not filled for this SVG
   Product: LibreOffice
   Version: 5.0.0.5 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu

Open this attachment from bug 99088 in Draw:
https://bugs.documentfoundation.org/attachment.cgi?id=124072

Select the rectangle. You will see the following Horizontal/Vertical
positions/Width/Height in the Sidebar:
-4.4.0.3: 0.07/0.07/0.84/0.08
-5.0.0.5 & 5.1.4.2: 0.07/0.00/0.84/0.08
-5.2.0.1: 0.07/0.00/0.84/0.00

=> regression
There was a fix to bug 82616, which might be related (pushed for 4.5/5.0).
Bug 99711 might also be a distant relative.


There is an additional, related issue that existed from the introduction of the
Sidebar.
Sidebar's Position and Size doesn't display the exact same values as right
click -> Position and Size...
In 4.3.0.4:
-Sidebar: 0.07/0.07/0.84/0.08
-Dialog: 0.07/0.07/0.85/0.07

(note a naming inconsistency: Position X/Position Y in dialog vs.
Horizontal/Vertical in Sidebar)

Setting confirmed based on Heiko's reply:
https://bugs.documentfoundation.org/show_bug.cgi?id=99088#c13

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100631] New: Numbered Headings pick up bulleting instead of numbers

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100631

Bug ID: 100631
   Summary: Numbered Headings pick up bulleting instead of numbers
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: timchamb...@environmentalstrategies.com.au

Created attachment 125933
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125933=edit
example file with outline headings and numbering set

Hi

I originally filed this under Bug 100577
https://bugs.documentfoundation.org/show_bug.cgi?id=100577, but it may be a
separate issue.

I have headings set up as outline numbering, and if I right click on a heading
and select "continue previous numbering" to force it to the correct number and
there is a bulleted list between the heading I am changing and the previous
heading, the heading I am changing becomes bulleted instead of following the
outline numbering sequence. Clicking back on numbered list instead of bulleted
list does not return to the outline numbering sequence.

This makes outline numbering fragile in a way that it should not be.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100577] outline numbering subheadings do not automatically have the correct number

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100577

--- Comment #3 from Tim Chambers  
---
New bug raised in connection with this bug

https://bugs.documentfoundation.org/show_bug.cgi?id=100631

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Build failure while experimenting with LTO

2016-06-26 Thread Davide Italiano

On Sun, Jun 26, 2016 at 6:48 PM, Davide Italiano  wrote:
> Hi,
> I'm experimenting a bit with LTO using clang and lld (the new LLVM linker).
> I'm able to build a decent fraction of libreoffice if I invoke
> autogen.sh like this:
>
> ./autogen.sh CC=~/work/llvm/build-release/bin/clang
> CXX=~/work/llvm/build-release/bin/clang++
> AR=~/work/llvm/build-release/bin/llvm-ar RANLIB=/usr/bin/true
> LDFLAGS="-fuse-ld=lld" CFLAGS="-flto" CXXFLAGS="-flto" --without-java
> --without-help --without-myspell-dicts --disable-liblangtag
> --with-system-curl --with-system-lcms2
>
> (please note that as long as I'm using the LLVM tools I don't need
> plugin(s) as binutils does).
>
> I set up my PATH so that ld symlinks to lld.
>
> $ ld --version
> LLD 3.9 (https://llvm.org/svn/llvm-project/lld/trunk 273771)
>
> After some librabries/executables are built/linked successfully I hit
> the following:
>
> [build DEP] LNK:Library/libbiblo.so
> [build LNK] Library/libbiblo.so
> /home/davide/lto_experiments/libreoffice/external/coinmp/ExternalPackage_coinmp.mk:31:
> *** file 
> /home/davide/lto_experiments/libreoffice/workdir/UnpackedTarball/coinmp/Cbc/src/.libs/libCbc.so.3.8.8
> does not exist in the tarball.  Stop.
> make[1]: *** Waiting for unfinished jobs
> Makefile:254: recipe for target 'build' failed
> make: *** [build] Error 2
> ```
>
> $ find . -name "libCbc.so*"
> $
>
> So I decided to build libCbc by myself going in the correct directory
> and invoking make:
>
> $ cd ./workdir/UnpackedTarball/coinmp/Cbc/ && ./configure && make
> [...]
>
> but still the build fails with the same error.
> Any ideas why the library is not built? Is this a bug in LLVM or in
> the build system?
>
> As a side note, I'm able to finish successfully a non-LTO build with 
> clang+lld.
>
> Thanks!
>
> --
> Davide

Also, FWIW this is the revision I'm at:

commit 63f15b36f7a196edb20ce7a0aba6f6b3d28dd652
Author: Ashod Nakashian 
Date:   Sun Jun 12 22:04:50 2016 -0400

--
Davide
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 100577] outline numbering subheadings do not automatically have the correct number

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100577

--- Comment #2 from Tim Chambers  
---
OK - Will file a new bug report - I put them together as I thought they may be
connected

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Build failure while experimenting with LTO

2016-06-26 Thread Davide Italiano

Hi,
I'm experimenting a bit with LTO using clang and lld (the new LLVM linker).
I'm able to build a decent fraction of libreoffice if I invoke
autogen.sh like this:

./autogen.sh CC=~/work/llvm/build-release/bin/clang
CXX=~/work/llvm/build-release/bin/clang++
AR=~/work/llvm/build-release/bin/llvm-ar RANLIB=/usr/bin/true
LDFLAGS="-fuse-ld=lld" CFLAGS="-flto" CXXFLAGS="-flto" --without-java
--without-help --without-myspell-dicts --disable-liblangtag
--with-system-curl --with-system-lcms2

(please note that as long as I'm using the LLVM tools I don't need
plugin(s) as binutils does).

I set up my PATH so that ld symlinks to lld.

$ ld --version
LLD 3.9 (https://llvm.org/svn/llvm-project/lld/trunk 273771)

After some librabries/executables are built/linked successfully I hit
the following:

[build DEP] LNK:Library/libbiblo.so
[build LNK] Library/libbiblo.so
/home/davide/lto_experiments/libreoffice/external/coinmp/ExternalPackage_coinmp.mk:31:
*** file 
/home/davide/lto_experiments/libreoffice/workdir/UnpackedTarball/coinmp/Cbc/src/.libs/libCbc.so.3.8.8
does not exist in the tarball.  Stop.
make[1]: *** Waiting for unfinished jobs
Makefile:254: recipe for target 'build' failed
make: *** [build] Error 2
```

$ find . -name "libCbc.so*"
$

So I decided to build libCbc by myself going in the correct directory
and invoking make:

$ cd ./workdir/UnpackedTarball/coinmp/Cbc/ && ./configure && make
[...]

but still the build fails with the same error.
Any ideas why the library is not built? Is this a bug in LLVM or in
the build system?

As a side note, I'm able to finish successfully a non-LTO build with clang+lld.

Thanks!

--
Davide
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: external/breakpad

2016-06-26 Thread Markus Mohrhard

 external/breakpad/breakpad-stackwalk.patch.1 |   30 ---
 1 file changed, 23 insertions(+), 7 deletions(-)

New commits:
commit 74c01bb89faa1c900fb9b63a04c469a8166996d9
Author: Markus Mohrhard 
Date:   Mon Jun 27 02:14:58 2016 +0200

better use a backward compatible way to change the output

Change-Id: If5829e321db8af1f09cccafaf34a18343492f514

diff --git a/external/breakpad/breakpad-stackwalk.patch.1 
b/external/breakpad/breakpad-stackwalk.patch.1
index 26803f1..9a3ce95 100644
--- a/external/breakpad/breakpad-stackwalk.patch.1
+++ b/external/breakpad/breakpad-stackwalk.patch.1
@@ -1,16 +1,32 @@
 diff -ur breakpad.org/src/processor/stackwalk_common.cc 
breakpad/src/processor/stackwalk_common.cc
 breakpad.org/src/processor/stackwalk_common.cc 2016-06-25 
01:38:53.282302964 +0200
-+++ breakpad/src/processor/stackwalk_common.cc 2016-06-25 01:42:58.463821357 
+0200
-@@ -767,9 +767,11 @@
+--- breakpad.org/src/processor/stackwalk_common.cc 2016-06-27 
02:06:43.304932691 +0200
 breakpad/src/processor/stackwalk_common.cc 2016-06-27 02:10:22.815642476 
+0200
+@@ -750,7 +750,7 @@
+ // one per line, in the following machine-readable pipe-delimited
+ // text format:
+ // Module|{Module Filename}|{Version}|{Debug Filename}|{Debug Identifier}|
+-// {Base Address}|{Max Address}|{Main}
++// {Base Address}|{Max Address}|{Main}|{Code Identifier}
+ static void PrintModulesMachineReadable(const CodeModules *modules) {
+   if (!modules)
+ return;
+@@ -767,7 +767,7 @@
 ++module_sequence) {
  const CodeModule *module = modules->GetModuleAtSequence(module_sequence);
  uint64_t base_address = module->base_address();
 -printf("Module%c%s%c%s%c%s%c%s%c0x%08" PRIx64 "%c0x%08" PRIx64 "%c%d\n",
-+printf("Module%c%s%c%s%c%s%c%s%c%s%c0x%08" PRIx64 "%c0x%08" PRIx64 
"%c%d\n",
++printf("Module%c%s%c%s%c%s%c%s%c0x%08" PRIx64 "%c0x%08" PRIx64 
"%c%d%c%s\n",
 kOutputSeparator,
 
StripSeparator(PathnameStripper::File(module->code_file())).c_str(),
-+   kOutputSeparator,
-+   
StripSeparator(PathnameStripper::File(module->code_identifier())).c_str(),
 kOutputSeparator, StripSeparator(module->version()).c_str(),
+@@ -778,7 +778,9 @@
+kOutputSeparator, base_address,
+kOutputSeparator, base_address + module->size() - 1,
 kOutputSeparator,
-
StripSeparator(PathnameStripper::File(module->debug_file())).c_str(),
+-   main_module != NULL && base_address == main_address ? 1 : 0);
++   main_module != NULL && base_address == main_address ? 1 : 0),
++   kOutputSeparator,
++   
StripSeparator(PathnameStripper::File(module->code_identifier())).c_str();
+   }
+ }
+ 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100630] New: Listboxes don't function

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100630

Bug ID: 100630
   Summary: Listboxes don't function
   Product: LibreOffice
   Version: 5.0.6.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: basil...@gmail.com

Listboxes in Base forms are greyed out and no longer function.  Information
previously entered displays, but is likewise greyed out and cannot be modified.

This affects Manjaro Linux, and possibly Arch and other Arch-based distros.

It does not affect Fedora.  I discovered the issue when switching distros, so
it could possibly affect earlier versions of LibreOffice Base as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 41063] Saving/Autosaving (Save/Autosave) while in table causes view to jump to cursor position

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=41063

--- Comment #56 from V Stuart Foote  ---
(In reply to evan from comment #55)
> I can confirm this behavior in 5.0.4.2.
> 
> This happens regardless of whether the cursor is in a table.
> 
> I can understand the jump to the last cursor position upon opening, but
> doing this during save/autosave is definitely not desirable for me.
> 
> For example, if my cursor is at the bottom of the document and I scroll up
> to review something I typed on a previous page, it is very annoying for
> Libreoffice to move me away from what I was reading.

That is bug 95797, now resolved fixed for 5.2.0, which was split from this
issue. This issue is restricted to scroll view behavior when edit cursor is in
table on Save/Auto-save.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2016-06-26 Thread Ashod Nakashian

 sc/source/ui/view/tabview.cxx |   52 +++---
 1 file changed, 29 insertions(+), 23 deletions(-)

New commits:
commit 3464bb16e667d6cabcb02eaaeb07c6938eb9d7a5
Author: Ashod Nakashian 
Date:   Sun Jun 19 12:13:35 2016 -0400

bccu#1893 - [PERFORMANCE] .uno:ViewRowColumnHeaders too slow

For very large spreadsheets, the boost json generator
(property_tree) is extremely slow and memory-inefficient.

There is little need for generic json generator, however,
since there are exactly two nodes (rows and columns)
and each is an array of size/text pairs.

The new logic uses a string with reserved capacity
to accomodate the output and generates it in one
step.

The speed improvement is orders of magnitude (hours to seconds)
for very large spreadsheets.

Reviewed-on: https://gerrit.libreoffice.org/26480
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit c9d5ff919c87566fdbc6a2ddde0bcd30d471c425)

Change-Id: Ifaf316c270ed6e4b923ec44189a315f69e7e9b0e
Reviewed-on: https://gerrit.libreoffice.org/26485
Tested-by: Jenkins 
Reviewed-by: Ashod Nakashian 

diff --git a/sc/source/ui/view/tabview.cxx b/sc/source/ui/view/tabview.cxx
index e4671f6..be17b1f 100644
--- a/sc/source/ui/view/tabview.cxx
+++ b/sc/source/ui/view/tabview.cxx
@@ -2313,15 +2313,20 @@ OUString ScTabView::getRowColumnHeaders(const 
Rectangle& rRectangle)
 SCROW nEndRow = 0;
 pDoc->GetTiledRenderingArea(aViewData.GetTabNo(), nEndCol, nEndRow);
 
-boost::property_tree::ptree aRows;
+rtl::OUStringBuffer aBuffer(256 + (50 * nEndRow) + (50 * nEndCol));
+
+aBuffer.append("{ \"commandName\": \".uno:ViewRowColumnHeaders\",\n");
+aBuffer.append("\"rows\": [\n");
+
 long nTotal = 0;
 long nTotalPixels = 0;
+bool bFirstRow = true;
 for (SCROW nRow = 0; nRow <= nEndRow; ++nRow)
 {
 // nSize will be 0 for hidden rows.
-sal_uInt16 nSize = pDoc->GetRowHeight(nRow, aViewData.GetTabNo());
-long nSizePixels = ScViewData::ToPixel(nSize, aViewData.GetPPTY());
-OUString aText = pRowBar[SC_SPLIT_BOTTOM]->GetEntryText(nRow);
+const sal_uInt16 nSize = pDoc->GetRowHeight(nRow, 
aViewData.GetTabNo());
+const long nSizePixels = ScViewData::ToPixel(nSize, 
aViewData.GetPPTY());
+const OUString aText = pRowBar[SC_SPLIT_BOTTOM]->GetEntryText(nRow);
 
 bool bSkip = false;
 if (!rRectangle.IsEmpty())
@@ -2334,23 +2339,27 @@ OUString ScTabView::getRowColumnHeaders(const 
Rectangle& rRectangle)
 }
 if (!bSkip)
 {
-boost::property_tree::ptree aRow;
-aRow.put("size", OString::number((nTotalPixels + nSizePixels) / 
aViewData.GetPPTY()).getStr());
-aRow.put("text", aText.toUtf8().getStr());
-aRows.push_back(std::make_pair("", aRow));
+if (!bFirstRow)
+aBuffer.append(", ");
+
+aBuffer.append("{ \"text\": \"").append(aText).append("\", ");
+aBuffer.append("\"size\": 
\"").append(OUString::number((nTotalPixels + nSizePixels) / 
aViewData.GetPPTY())).append("\" }");
+bFirstRow = false;
 }
 nTotal += nSize;
 nTotalPixels += nSizePixels;
 }
 
-boost::property_tree::ptree aCols;
+aBuffer.append("],\n\"columns\":\n[");
+
 nTotal = 0;
 nTotalPixels = 0;
+bFirstRow = true;
 for (SCCOL nCol = 0; nCol <= nEndCol; ++nCol)
 {
-sal_uInt16 nSize = pDoc->GetColWidth(nCol, aViewData.GetTabNo());
-long nSizePixels = ScViewData::ToPixel(nSize, aViewData.GetPPTX());
-OUString aText = pColBar[SC_SPLIT_LEFT]->GetEntryText(nCol);
+const sal_uInt16 nSize = pDoc->GetColWidth(nCol, aViewData.GetTabNo());
+const long nSizePixels = ScViewData::ToPixel(nSize, 
aViewData.GetPPTX());
+const OUString aText = pColBar[SC_SPLIT_LEFT]->GetEntryText(nCol);
 
 bool bSkip = false;
 if (!rRectangle.IsEmpty())
@@ -2363,22 +2372,19 @@ OUString ScTabView::getRowColumnHeaders(const 
Rectangle& rRectangle)
 }
 if (!bSkip)
 {
-boost::property_tree::ptree aCol;
-aCol.put("size", OString::number((nTotalPixels + nSizePixels) / 
aViewData.GetPPTX()).getStr());
-aCol.put("text", aText.toUtf8().getStr());
-aCols.push_back(std::make_pair("", aCol));
+if (!bFirstRow)
+aBuffer.append(", ");
+
+aBuffer.append("{ \"text\": \"").append(aText).append("\", ");
+aBuffer.append("\"size\": 
\"").append(OUString::number((nTotalPixels + nSizePixels) / 
aViewData.GetPPTX())).append("\" }");
+bFirstRow = false;
 }
 nTotal += nSize;
 nTotalPixels +=

[Libreoffice-bugs] [Bug 100626] From an initial LO Start Center session-- creating new Writer document doesn 't result in edit focus to the canvas of the new document

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100626

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
   Hardware|x86-64 (AMD64)  |All
Version|5.0.6.3 release |5.0.5.2 release

--- Comment #5 from Aron Budea  ---
I tried, and could not reproduce this at first, not even with the steps Stuart
mentioned. However, these are consistent reproduction steps for me:

1. open to Start Center
2. press and release Alt, then Down, then Right, then Enter. (this will lead to
the same menu item as Alt+F, N, T)

Still okay with 5.0.0.5.
Issue is reproducible with 5.0.5.2, 5.1.3.2, 5.2.0.1, master build
(32-bit/64-bit versions mixed).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 50026] Calc does not save heights for empty rows in XLS or XLSX

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=50026

Bartosz Kosiorek  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Bartosz Kosiorek  ---
This bug was already fixed in LibreOffice 5.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100620] Wrong result with COUNTA or COUNT in formula

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100620

--- Comment #4 from m.a.riosv  ---
I did my test with:
Win10x64
Version: 5.1.4.2 (x64)
Build ID: f99d75f39f1c57ebdd7ffc5f42867c12031db97a
CPU Threads: 1; OS Version: Windows 6.19; UI Render: GL

The matter it's the same with:
Version: 5.0.6.2 (x64)
Build ID: b3fbfa99158a1030fb79f0ba72b6851afc3c7895-GL
Version: 5.3.0.0.alpha0+
Build ID: 757f221bceb74ccc2af8a9d4de149076280f29fb
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-06-23_23:54:55

Err:522 it's there, and it is a 'circular reference' error, if 'Iterative
references' it's not enable.

The only bug could be if there wasn't circular references, but C4 calls B4,
while B4 has COUNTA($B4:$T4) where C4 is part of the range.

So for not a bug, you can ask for help in ask.libreoffice.org or in mailing
list http://nabble.documentfoundation.org/Users-f1639498.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 68282] FILESAVE: Pasted Cells Format (Numbers) to blank cells for a whole row not preserved in .xlsx

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=68282

--- Comment #6 from Bartosz Kosiorek  ---
Could you please check if you:
1. Create xlsx document with MS Excel with this example (it should work there
2. Open xlsx document created by MS Exce, and save it as xlsx
3. Check if this bug is reproducible with that scenario

It will be much easier to compare these two files (Original Excel and converted
by LibreOffice) and fix that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100618] Missing weeknum() in Libreoffice 5.1.3.2 (Debian)

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100618

Llogic  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Llogic  ---

This is embarrassing.

Received files created in openSUSE's Libreoffice with  =weeknum(number,mode)
where mode=0 that looks okay in openSUSE but reported as an error in Debian.

Long story short , its our mistake taking and too much coffee.

Please close this report, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100565] Graphic redraw problems with multiple windows

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100565

--- Comment #9 from welli...@yahoo.co.uk ---
Just checked the settings, one was still on multipage view, but having
confirmed both were changed to single page view the problem remains. I should
note I both did this with switching from multi page view to single page view
and also making sure the single page view was active, saving the document and
then restarting so it, loaded in single page view on one screen, then opening
new window.

I'll have a go at editing this document down to a length I can upload, although
I'm pressed for time at the moment so it may not be until next weekend. I've
had this occur in a few documents, however (virtually everytime I try and use
two windows).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 100596] Would like to be able to create and edit block arcs numerically.

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100596

--- Comment #3 from Bill  ---
Created attachment 125932
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125932=edit
shows preliminary idea for solution GUI for creting/editing block arcs.

The top half of the attached image shows my preliminary rough idea of what the
GUI for creating and editing block arcs should look like.  The bottom half is a
rough drawing of the block arc created by the GUI in the top half.  I've also
shown additional lines and the axis to help people correctly understand.  I
assume that the origin of Draw's axes are in the upper left corner of the page
area enclosed by the page margins.  The actual operational GUI should work both
in metric units and in "American" units.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 100596] Would like to be able to create and edit block arcs numerically.

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100596

--- Comment #3 from Bill  ---
Created attachment 125932
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125932=edit
shows preliminary idea for solution GUI for creting/editing block arcs.

The top half of the attached image shows my preliminary rough idea of what the
GUI for creating and editing block arcs should look like.  The bottom half is a
rough drawing of the block arc created by the GUI in the top half.  I've also
shown additional lines and the axis to help people correctly understand.  I
assume that the origin of Draw's axes are in the upper left corner of the page
area enclosed by the page margins.  The actual operational GUI should work both
in metric units and in "American" units.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100624] number keypad not working

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100624

--- Comment #2 from MM  ---
(In reply to Charles Pederson from comment #0)
> The number keypad will not enter any number except 0. The keypad does work
> with
> Wordpad and several other programs.  Google results did not help when
> implemented.

You don't give much info about which system you're using and which version of
LO you have.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100629] [FILEOPEN]: view of formula from files .doc imports not correctly

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100629

--- Comment #1 from MM  ---
Unconfirmed with v5.1.4.2 under windows 7 x64.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100620] Wrong result with COUNTA or COUNT in formula

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100620

andis.lazd...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
Version|5.0.5.2 release |5.1.4.2 release
 Resolution|NOTABUG |---
 Ever confirmed|0   |1

--- Comment #3 from andis.lazd...@gmail.com ---
Thank you for advice in solving this problem! 

I find mistake in the initial report - it applies to 5.1.4.2!

Iterative references is not really solution, because it is possible to get more
compatibility and calculation result related problems in future by activating
the Iterative references function.

Formulas in attached file works well in Libreoffice 5.0.x, Openoffice.org 4.1.2
and Microsoft Excel and Iterative references are not activated in Libreoffice
5.0.x and Openoffice.org 4.1.2. Therefore to my understanding, keeping in mind
hundreds or thousands of files, which now shows error instead of result in
5.1.x, it is serious regression in basic calc functions.

I reopened the report, because I messed up versions of Libeoffice at the
beginning.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 41063] Saving/Autosaving (Save/Autosave) while in table causes view to jump to cursor position

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=41063

--- Comment #55 from e...@evanw.org ---
I can confirm this behavior in 5.0.4.2.

This happens regardless of whether the cursor is in a table.

I can understand the jump to the last cursor position upon opening, but doing
this during save/autosave is definitely not desirable for me.

For example, if my cursor is at the bottom of the document and I scroll up to
review something I typed on a previous page, it is very annoying for
Libreoffice to move me away from what I was reading.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100565] Graphic redraw problems with multiple windows

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100565

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #8 from V Stuart Foote  ---
Setting NEW, but still need reliable STR.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2016-06-26 Thread Zdeněk Crhonek

 sc/qa/unit/data/functions/fods/acosh.fods | 2309 +
 sc/qa/unit/data/functions/fods/acot.fods  | 2328 +
 sc/qa/unit/data/functions/fods/acoth.fods | 2335 ++
 3 files changed, 6972 insertions(+)

New commits:
commit c8a94cae37029b037507ce86d149ba56ca341f11
Author: ZdenÄk Crhonek 
Date:   Sun Jun 26 21:54:28 2016 +0200

add ACOSH, ACOT, ACOTH test case

Change-Id: I52ebf882df64813fd11d07b945c153ad5cf11d1b
Reviewed-on: https://gerrit.libreoffice.org/26681
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/qa/unit/data/functions/fods/acosh.fods 
b/sc/qa/unit/data/functions/fods/acosh.fods
new file mode 100644
index 000..8f52cc5
--- /dev/null
+++ b/sc/qa/unit/data/functions/fods/acosh.fods
@@ -0,0 +1,2309 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2016-06-25T07:16:38.437590147P0D1LibreOfficeDev/5.3.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/0325b22a2a2b537a71f53b7c5d3e6c13fef68911
+ 
+  
+   0
+   0
+   28650
+   9031
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   100
+   60
+   true
+  
+  
+   3
+   17
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   100
+   60
+   true
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 100
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ false
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ en
+ US
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   qQH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMAzwAEAAhSAAAEdAAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkE0AElucHV0U2xvdDpUcmF5MQBEdXBsZXg6Tm9uZQAAEgBDT01QQVRfRFVQTEVYX01PREUKAERVUExFWF9PRkY=
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+
+   KÄ
+  
+  
+   
+   -
+   
+
+   KÄ
+   
+  
+  
+$
+   
+
+  
+  
+$(
+   
+   )
+  
+  
+$-
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   Â£
+   
+  
+  
+   -
+   Â£
+   
+   
+  
+  
+   Â£
+   
+  
+  
+   -
+   Â£
+   
+   
+  
+  
+   Â£
+   
+  
+  
+   
+   -
+   Â£
+   
+

[Libreoffice-bugs] [Bug 100565] Graphic redraw problems with multiple windows

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100565

--- Comment #7 from V Stuart Foote  ---
Looking at the video, can see you are ending up in Multi-page view mode,
jumping back and forth to Single-page view mode. I can't reproduce that!

A session in Single-page view mode would be centered on the screen.

Check the selection in both frames with the document open, down on the status
bar.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98732] Export sheet from calc to pdf creates weird characters

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98732

tbu...@gmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #13 from tbu...@gmail.com ---
I have just checked and the bug is gone. It is a most surprising event to have
happened, because I haven't upgraded neither the Libreoffice itself nor the
adobe reader.
I have gone through all my downloaded file since the last unsuccessful attemp
and found out that the only thing that could have something to do with making
things right was that I installed java 8 on my box lately.
I don't know if this could caus anything but you guys can certainly tell.

Thanks for all you effort anyways!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100626] From an initial LO Start Center session-- creating new Writer document doesn 't result in edit focus to the canvas of the new document

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100626

--- Comment #4 from k...@kenbeal.com ---
Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100616] Standard Toolbar customization can not pin vertical Text button to toolbar

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100616

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #3 from V Stuart Foote  ---
OK, Thanks Maxim!

Verified the button can be added and functions once the CJK checkbox is enabled
on the Languages panel.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100628] FILEOPEN LibreOffice marketing flyer looks badly when opened in LibreOffice

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100628

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #1 from Regina Henschel  ---
You need to install the font family "Source Sans Pro".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100629] New: [FILEOPEN]: view of formula from files .doc imports not correctly

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100629

Bug ID: 100629
   Summary: [FILEOPEN]: view of formula from files .doc imports
not correctly
   Product: LibreOffice
   Version: 5.1.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

Created attachment 125931
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125931=edit
file with formula math type in format .doc

Subj.

file in attach

see screenshot http://imgur.com/m1KpYoM (left Word, right LibreOffice)

character "SUM" was replaced on "e"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100626] From an initial LO Start Center session-- creating new Writer document doesn 't result in edit focus to the canvas of the new document

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100626

V Stuart Foote  changed:

   What|Removed |Added

Version|5.1.2.2 release |5.0.6.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100626] From an initial LO Start Center session-- creating new Writer document doesn 't result in edit focus to the canvas of the new document

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100626

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
Summary|New document doesn't have   |From an initial LO Start
   |focus   |Center session-- creating
   ||new Writer document doesn't
   ||result in edit focus to the
   ||canvas of the new document

--- Comment #3 from V Stuart Foote  ---
On Windows 10 Pro 64-bit en-US with
Version: 5.2.0.1 (x64)
Build ID: fcbcb4963bda8633ba72bd2108ca1e802aad557d
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; 
Locale: en-US (en_US)

Version: 5.1.2.2 (x64)
Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f
CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; 
Locale: en-US (en_US)

Version: 5.0.6.3 (x64)
Build ID: 490fc03b25318460cfc54456516ea2519c11d1aa
Locale: en-US (en_US)

Version: 4.4.6.3
Build ID: e8938fd3328e95dcf59dd64e7facd2c7d67c704d
Locale: en_US

Actually just compared launch in the earlier builds, and seems that starting
with the 5.0 branch there is a subtle regression against 4.4.6 builds.

STR.

1. open to Start Center
2. +F to open main menu
3. N to open new menu
4. T to open new text document

Expected:
document frame active, and edit cursor in the document canvas with keyboard
control (behavior through 4.4.6.3)

Result:
document frame active, no visible element has focus--keyboard movements not
possible. *Keyboard trapped*. Mouse movement responds to position and GUI
element--but a mouse click or + away from the frame is needed.

Same related behavior as OP reports is -- a +N, or + + N + T,
opens new document and frame is active, but no visible element has focus.
Keyboard trapped--have to use mouse, or move to another window and back to gain
focus.

And, once launched one time from Start Center with a mouse action, subsequent
document launch from Start Center will have edit cursor focus. 

The +n, or +F + N + T may, or may not gain edit cursor focus--seems
erratic. But something is amiss...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100620] Wrong result with COUNTA or COUNT in formula

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100620

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |NOTABUG

--- Comment #2 from m.a.riosv  ---
Hi @andis,

Err:522 as you can see in the status bar means a "circular reference", it
happens when a cell is included in the calculation of their formula (directly
or indirectly)

There is an option to allow calculate with circular references:
Menu/Tools/Options/LibreOffice calc/Calculate - Iterative references.
that avoid the errors.

Closed as not a bug, please if you are not agree, reopen it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89626] Print to form letter silently fails at final step

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=89626

Tim Abell  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |---

--- Comment #5 from Tim Abell  ---
I have what appears to be the same issue. Let me know if you need more
information.

Because there's no errors I've recorded a video to prove to you the behaviour:
https://vimeo.com/172328499

This is a fairly clean install of Ubuntu 16.04 LTS with all updates applied.

LibreOffice version info (from help/about):

Version: 5.1.3.2
Build ID: 1:5.1.3-0ubuntu1
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
Locale: en-GB (en_GB.UTF-8)

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100565] Graphic redraw problems with multiple windows

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100565

--- Comment #6 from welli...@yahoo.co.uk ---
I've uploaded a video of the problem in a larger document (hopefully it is
clear enough). Closing the formatting side bar causes the cursor to jump to a
random document location and stop responding (have to relocate the cursor to
the right place again).

I had switched the page on the main window to single page only, multiple page
doesn't seem to make much change. Jumping does stop if both windows are the
same scale, but this would not be the case if like me you have to different
sized monitors, where the window sizes are different by necessity.

I forgot to mention that I'm using Windows 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100565] Graphic redraw problems with multiple windows

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100565

--- Comment #5 from welli...@yahoo.co.uk ---
Created attachment 125930
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125930=edit
Video of 'bug'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97391] [META] Tracker bug for OpenCL and "Software Interpreter" issues in Calc

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97391
Bug 97391 depends on bug 100222, which changed state.

Bug 100222 Summary: No message to restart LO when disabling OpenCL, but keeping 
software interpreter enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=100222

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100222] No message to restart LO when disabling OpenCL, but keeping software interpreter enabled

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100222

Aron Budea  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #6 from Aron Budea  ---
I tested this now with a master daily build from two days ago, and there is a
tiny little remaining issue: if both checkboxes are changed at the same time,
there are two popups.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100571] PRINTING: LibreOffice does NOT see my printer

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100571

--- Comment #3 from id22...@yahoo.com ---
(In reply to Buovjaga from comment #1)
> Did a previous LibreOffice version see it?
> Did you arrive at Windows 10 through an upgrade from a previous Windows
> version?
> 
> Set to NEEDINFO.
> Change back to UNCONFIRMED after you have provided the information.

Yes previous LibreOffice version have shown the same problem. I have used
LibreOffice in the past to print information, but as sometimes happens with
these machines, it has stopped working, due to windows patch perhaps, I could
not say why, But a computer expert, who is basically a windows technical
specialist could not get LibreOffice to work on aforesaid printer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100571] PRINTING: LibreOffice does NOT see my printer

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100571

--- Comment #2 from id22...@yahoo.com ---
(In reply to Buovjaga from comment #1)
> Did a previous LibreOffice version see it?
> Did you arrive at Windows 10 through an upgrade from a previous Windows
> version?
> 
> Set to NEEDINFO.
> Change back to UNCONFIRMED after you have provided the information.

Yes previous LibreOffice version have shown the same problem. I have used
LibreOffice in the past to print information, but as sometimes happens with
these machines, it has stopped working, due to windows patch perhaps, I could
not say why, But a computer expert, who is basically a windows technical
specialist could not get LibreOffice to work on aforesaid printer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100616] Standard Toolbar customization can not pin vertical Text button to toolbar

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100616

--- Comment #2 from Maxim Monastirsky  ---
That's by design. You have to turn on CJK features for this (Tools > Options...
> Language Settings > Languages > Asian), and restart Writer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/test

2016-06-26 Thread Ashod Nakashian

 loolwsd/test/UnitPrefork.cpp |   12 ++--
 loolwsd/test/run_unit.sh.in  |   28 
 2 files changed, 26 insertions(+), 14 deletions(-)

New commits:
commit e8cd9e35d3628ffb6689a4b40e5171cb7f6be8dc
Author: Ashod Nakashian 
Date:   Sun Jun 26 16:36:19 2016 -0400

bccu#1909 - loolwsd command line options vs. config file and package 
upgrades

Unit tests updated with new command-line arguments.

Change-Id: I1a391255c44d4d22b8304129634ef7d16b606bce
Reviewed-on: https://gerrit.libreoffice.org/26683
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/UnitPrefork.cpp b/loolwsd/test/UnitPrefork.cpp
index 4bedaaa..2b804ee 100644
--- a/loolwsd/test/UnitPrefork.cpp
+++ b/loolwsd/test/UnitPrefork.cpp
@@ -88,7 +88,7 @@ public:
 return true;
 }
 
-void getMemory(const std::shared_ptr ,
+bool getMemory(const std::shared_ptr ,
size_t , size_t )
 {
 std::unique_lock lock(_mutex);
@@ -100,10 +100,12 @@ public:
 {
 _failure = "Timed out waiting for child to respond to 
unit-memdump.";
 Log::error(_failure);
+return false;
 }
 
 totalPSS = _totalPSS;
 totalDirty = _totalDirty;
+return true;
 }
 
 virtual void newChild(const std::shared_ptr ) 
override
@@ -121,7 +123,12 @@ public:
 // Skip the last one as it's not completely initialized yet.
 for (size_t i = 0; i < _childSockets.size() - 1; ++i)
 {
-getMemory(_childSockets[i], totalPSSKb, totalDirtyKb);
+Log::info() << "Getting memory of child #" << i + 1 << " of " 
<< _childSockets.size() << Log::end;
+if (!getMemory(_childSockets[i], totalPSSKb, totalDirtyKb))
+{
+exitTest(TestResult::TEST_FAILED);
+return;
+}
 }
 
 Log::info() << "Memory use total   " << totalPSSKb << "k shared "
@@ -143,6 +150,7 @@ public:
 }
 else
 {
+Log::error("UnitPrefork success.");
 exitTest(TestResult::TEST_OK);
 }
 }
diff --git a/loolwsd/test/run_unit.sh.in b/loolwsd/test/run_unit.sh.in
index 20b4ae7..88bfca0 100755
--- a/loolwsd/test/run_unit.sh.in
+++ b/loolwsd/test/run_unit.sh.in
@@ -50,10 +50,12 @@ echo > $test_output
 if test "z$tst" == "z"; then
  echo "executing external tests"
  ${valgrind} \
- ${abs_top_builddir}/loolwsd --systemplate="$systemplate_path" \
- --lotemplate="$lo_path" \
- --childroot="$jails_path" \
- --allowlocalstorage > "$tst_log" 2>&1 &
+ ${abs_top_builddir}/loolwsd --o:sys_template_path="$systemplate_path" \
+ --o:lo_template_path="$lo_path" \
+ --o:child_root_path="$jails_path" \
+ --o:storage.filesystem[@allow]=true \
+ --o:admin_console.username=admin 
--o:admin_console.password=admin \
+ > "$tst_log" 2>&1 &
 
  echo "  executing test"
 
@@ -78,11 +80,11 @@ if test "z$tst" == "z"; then
 else # newer unit tests.
 echo "Running $tst | $tst_log ...";
if ${valgrind} \
-${abs_top_builddir}/loolwsd --systemplate="$systemplate_path" \
-   --lotemplate="$lo_path" \
-   --childroot="$jails_path" \
-   --allowlocalstorage \
-   --admincreds="admin/admin" \
+   ${abs_top_builddir}/loolwsd --o:sys_template_path="$systemplate_path" \
+   --o:lo_template_path="$lo_path" \
+   --o:child_root_path="$jails_path" \
+   --o:storage.filesystem[@allow]=true \
+   --o:admin_console.username=admin 
--o:admin_console.password=admin \
--unitlib=".libs/$tst.so" > "$tst_log" 
2>&1; then
 echo "Test $tst passed."
 echo ":test-result: PASS $tst" >> $test_output
@@ -90,9 +92,11 @@ else # newer unit tests.
 cat "$tst_log"
 echo "="
 echo "Test failed on unit: $tst re-run with:"
-echo "   $ gdb --args ../loolwsd --systemplate=\"$systemplate_path\" 
\\"
-echo " --lotemplate=\"$lo_path\" \\"
-echo " --childroot=\"$jails_path\" --allowlocalstorage 
--admincreds="admin/admin" \\"
+echo "   $ gdb ${abs_top_builddir}/loolwsd 
--o:sys_template_path=\"$systemplate_path\" \\"
+echo "

[Libreoffice-bugs] [Bug 100602] EDITING: Expressions with global scope shouldn' t be copied to a local scope, when a sheet is copied. Released notes 5.2

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100602

--- Comment #2 from m.a.riosv  ---
Sorry, why highest and critical?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100628] New: FILEOPEN LibreOffice marketing flyer looks badly when opened in LibreOffice

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100628

Bug ID: 100628
   Summary: FILEOPEN LibreOffice marketing flyer looks badly when
opened in LibreOffice
   Product: LibreOffice
   Version: 5.1.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: oliver.san...@tu-dresden.de

Created attachment 125929
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125929=edit
Screenshot

The document foundation recently published a set of marketing flyers at

https://wiki.documentfoundation.org/Gallery_Flyers

The odg files do not look right when opened in LibreOffice itself.  See the
attached screenshot of DE_Endbenutzer.odg opened in 

LibreOffice 5.1.4.2 10m0(Build:2)
Debian Testing

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100626] New document doesn't have focus

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100626

k...@kenbeal.com changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|NOTABUG |---
 Ever confirmed|0   |1

--- Comment #2 from k...@kenbeal.com ---
Why is this not seen as an issue?

My workflow involves primarily the keyboard, and I rarely touch the mouse.

If I have a thought and want to start a new document, I hit Ctrl+N and start
typing.

Your mention of F10 or clicking is immaterial.  OpenOffice behaved the correct
way, but I switched to LibreOffice when I found that the bug they had ignored
for years had been fixed by your team (that being, a Ctrl+Backspace eats the
space after the previous word, so I always had to hit the space bar after
Ctrl+Backspace, unlike any other interface).

It sounds like you're saying that I should just get used to an extra keystroke
or mouse click for the LibreOffice interface.  I don't think that's providing
good service.

Perhaps my initial description was too short.  I don't want a method of getting
focus, I want this to behave the same way OpenOffice does -- the cursor should
be sitting there blinking in the document right after I hit Ctrl+N.

Reopening.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa

2016-06-26 Thread Justin Luth

 sw/qa/extras/ooxmlimport/ooxmlimport.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit aa06a33946951e872b5e81d1c2bc8b7f60c861e1
Author: Justin Luth 
Date:   Sat Jun 25 19:43:35 2016 +0300

n#766487 additional docx testcase

This testcase has been a real thorn and adding this test
for the first page style will make it even worse.

original testcase commit b776233cba128bd7610834691da612b2b1a438a0

Change-Id: Ic9401da31849604c5afa1a511c128071bc562808
Reviewed-on: https://gerrit.libreoffice.org/26660
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index f29304f..cdac7d0 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -991,6 +991,10 @@ DECLARE_OOXMLIMPORT_TEST(testN780843, "n780843.docx")
 uno::Reference 
xPageStyle(getStyles("PageStyles")->getByName(aStyleName), uno::UNO_QUERY);
 uno::Reference xFooter = getProperty< 
uno::Reference >(xPageStyle, "FooterText");
 CPPUNIT_ASSERT_EQUAL(OUString("shown footer"), xFooter->getString());
+
+xPara = getParagraph(1);
+aStyleName = getProperty(xPara, "PageStyleName");
+CPPUNIT_ASSERT_EQUAL(OUString("First Page"), aStyleName);
 }
 
 DECLARE_OOXMLIMPORT_TEST(testShadow, "imgshadow.docx")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: starmath/inc starmath/source

2016-06-26 Thread Takeshi Abe

 starmath/inc/node.hxx|6 +++---
 starmath/source/node.cxx |2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit b075882016d8388d20cc7490eb0733a9d0d97a5f
Author: Takeshi Abe 
Date:   Sun Jun 26 18:25:36 2016 +0900

starmath: Fix invalid static_cast

It was an undefined behavior that static_cast'ing a pointer to
SmVisibleNode to SmStructureNode's.

Change-Id: Ic391175a5535cec84bd7f9ec58fa13a411398331
Reviewed-on: https://gerrit.libreoffice.org/26676
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/starmath/inc/node.hxx b/starmath/inc/node.hxx
index fa79f55..72da13b 100644
--- a/starmath/inc/node.hxx
+++ b/starmath/inc/node.hxx
@@ -114,13 +114,12 @@ class SmNode : public SmRect
 FontAttribute   mnAttributes;
 boolmbIsPhantom;
 boolmbIsSelected;
+// index in accessible text; -1 if not (yet) applicable
+sal_Int32   mnAccIndex;
 
 protected:
 SmNode(SmNodeType eNodeType, const SmToken );
 
-// index in accessible text -1 if not (yet) applicable
-sal_Int32   mnAccIndex;
-
 public:
 SmNode(const SmNode&) = delete;
 SmNode& operator=(const SmNode&) = delete;
@@ -174,6 +173,7 @@ public:
 
 virtual voidGetAccessibleText( OUStringBuffer  ) const = 0;
 sal_Int32   GetAccessibleIndex() const { return mnAccIndex; }
+voidSetAccessibleIndex(sal_Int32 nAccIndex) { mnAccIndex = 
nAccIndex; }
 const SmNode *  FindNodeWithAccessibleIndex(sal_Int32 nAccIndex) const;
 
 sal_uInt16  GetRow() const{ return 
sal::static_int_cast(maNodeToken.nRow); }
diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx
index f378e4d..8300752 100644
--- a/starmath/source/node.cxx
+++ b/starmath/source/node.cxx
@@ -429,7 +429,7 @@ void SmStructureNode::GetAccessibleText( OUStringBuffer 
 ) const
[](SmNode *pNode)
 {
 if (pNode->IsVisible())
-static_cast(pNode)->mnAccIndex = 
rText.getLength();
+pNode->SetAccessibleIndex(rText.getLength());
 pNode->GetAccessibleText( rText );
 });
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100411] With OpenGL rendering enabled tool-tips are blank frame with no text

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100411

--- Comment #5 from Commit Notification 
 ---
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=24c3838b5fd2005d9df902c9a7d03fcba78adbe4=libreoffice-5-1

tdf#100411 start the flush timer when batching (PostBatchDraw)

It will be available in 5.1.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100222] No message to restart LO when disabling OpenCL, but keeping software interpreter enabled

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100222

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0 target:5.2.0.2 |target:5.3.0 target:5.2.0.2
   ||target:5.1.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100222] No message to restart LO when disabling OpenCL, but keeping software interpreter enabled

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100222

--- Comment #5 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6d3a5d8aa07e575c153316a9725f36c43abd0bca=libreoffice-5-1

tdf#100222: Inform user that a restart is needed after toggling OpenCL use

It will be available in 5.1.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100626] New document doesn't have focus

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100626

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |NOTABUG

--- Comment #1 from V Stuart Foote  ---
Actually the new frame holding the new document does have focus. 

But to position edit cursor into the document  is the more certain
keyboard movement once to the main menu and again to enter document canvas. A
mouse click into the document canvas works as well.

Don't see this as an issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100411] With OpenGL rendering enabled tool-tips are blank frame with no text

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100411

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0 target:5.2.0.2 |target:5.3.0 target:5.2.0.2
   ||target:5.1.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - vcl/inc vcl/opengl

2016-06-26 Thread Tomaž Vajngerl

 vcl/inc/openglgdiimpl.hxx |2 ++
 vcl/opengl/gdiimpl.cxx|   10 ++
 2 files changed, 12 insertions(+)

New commits:
commit 24c3838b5fd2005d9df902c9a7d03fcba78adbe4
Author: TomaÅ¾ Vajngerl 
Date:   Fri Jun 24 16:42:45 2016 +0800

tdf#100411 start the flush timer when batching (PostBatchDraw)

When we batch a draw command we need to start the flush timer
(if not already started) as otherwise it could happen that we
won't flush the offscreen texture at the correct time or at all.
This fixes a problem with drawing of pop-up "help" text.

(cherry picked from commit e1296e295e7d4f1104d2c90b1f51d52251358bea)

Change-Id: I6afcf173c3ac517ed0612cd413d95e28c19faa81
Reviewed-on: https://gerrit.libreoffice.org/26630
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/vcl/inc/openglgdiimpl.hxx b/vcl/inc/openglgdiimpl.hxx
index df7b9e9..2037268 100644
--- a/vcl/inc/openglgdiimpl.hxx
+++ b/vcl/inc/openglgdiimpl.hxx
@@ -169,6 +169,8 @@ public:
 // operations to do after painting
 void PostDraw();
 
+void PostBatchDraw();
+
 protected:
 bool AcquireContext(bool bForceCreate = false);
 bool ReleaseContext();
diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx
index 188db65..1422c6a 100644
--- a/vcl/opengl/gdiimpl.cxx
+++ b/vcl/opengl/gdiimpl.cxx
@@ -249,6 +249,15 @@ void OpenGLSalGraphicsImpl::PostDraw()
 OpenGLZone::leave();
 }
 
+void OpenGLSalGraphicsImpl::PostBatchDraw()
+{
+if (IsOffscreen())
+return;
+
+if (!mpFlush->IsActive())
+mpFlush->Start();
+}
+
 void OpenGLSalGraphicsImpl::ApplyProgramMatrices(float fPixelOffset)
 {
 mpProgram->ApplyMatrix(GetWidth(), GetHeight(), fPixelOffset);
@@ -1519,6 +1528,7 @@ void OpenGLSalGraphicsImpl::DrawMask( OpenGLTexture& 
rMask, SalColor nMaskColor,
 void OpenGLSalGraphicsImpl::DeferredTextDraw(OpenGLTexture& rTexture, SalColor 
aMaskColor, const SalTwoRect& rPosAry)
 {
 mpAccumulatedTextures->insert(rTexture, aMaskColor, rPosAry);
+PostBatchDraw();
 }
 
 void OpenGLSalGraphicsImpl::FlushDeferredDrawing()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100222] No message to restart LO when disabling OpenCL, but keeping software interpreter enabled

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100222

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0|target:5.3.0 target:5.2.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100222] No message to restart LO when disabling OpenCL, but keeping software interpreter enabled

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100222

--- Comment #4 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=169e9fb16f025bc5791d3ea5242596e3dcc4f023=libreoffice-5-2

tdf#100222: Inform user that a restart is needed after toggling OpenCL use

It will be available in 5.2.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - cui/source

2016-06-26 Thread Tor Lillqvist

 cui/source/options/optopencl.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 6d3a5d8aa07e575c153316a9725f36c43abd0bca
Author: Tor Lillqvist 
Date:   Thu Jun 23 17:40:30 2016 +0300

tdf#100222: Inform user that a restart is needed after toggling OpenCL use

(cherry picked from commit c7c27b9b191291cf36e4940aef3e3e7371855797)

Change-Id: Ic33cb02440276bc0601c86f2c9eab7d74a6b9874
Reviewed-on: https://gerrit.libreoffice.org/26611
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/cui/source/options/optopencl.cxx b/cui/source/options/optopencl.cxx
index db1470e..f055ed0 100644
--- a/cui/source/options/optopencl.cxx
+++ b/cui/source/options/optopencl.cxx
@@ -167,6 +167,9 @@ bool SvxOpenCLTabPage::FillItemSet( SfxItemSet* )
 {
 maConfig.set();
 bModified = true;
+
+ScopedVclPtrInstance aWarnBox(this, 
CUI_RES(RID_SVXSTR_OPTIONS_RESTART), VCL_MESSAGE_INFO);
+aWarnBox->Execute();
 }
 
 if (bModified)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - cui/source

2016-06-26 Thread Tor Lillqvist

 cui/source/options/optopencl.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 169e9fb16f025bc5791d3ea5242596e3dcc4f023
Author: Tor Lillqvist 
Date:   Thu Jun 23 17:40:30 2016 +0300

tdf#100222: Inform user that a restart is needed after toggling OpenCL use

(cherry picked from commit c7c27b9b191291cf36e4940aef3e3e7371855797)

Change-Id: Ic33cb02440276bc0601c86f2c9eab7d74a6b9874
Reviewed-on: https://gerrit.libreoffice.org/26610
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/cui/source/options/optopencl.cxx b/cui/source/options/optopencl.cxx
index 250cae9..6f01523 100644
--- a/cui/source/options/optopencl.cxx
+++ b/cui/source/options/optopencl.cxx
@@ -167,6 +167,9 @@ bool SvxOpenCLTabPage::FillItemSet( SfxItemSet* )
 {
 maConfig.set();
 bModified = true;
+
+ScopedVclPtrInstance aWarnBox(this, 
CUI_RES(RID_SVXSTR_OPTIONS_RESTART), VCL_MESSAGE_INFO);
+aWarnBox->Execute();
 }
 
 if (bModified)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sfx2/classification sfx2/Package_classification.mk

2016-06-26 Thread Andras Timar

 sfx2/Package_classification.mk|1 
 sfx2/classification/example_sl-SI.xml |   71 ++
 2 files changed, 72 insertions(+)

New commits:
commit 3d1d706414fff4484b043f5a6e4ee3c60ad5670e
Author: Andras Timar 
Date:   Thu Jun 23 14:05:44 2016 +0200

Slovenian example.xml (related: tdf#100352)

Change-Id: I2538b3d1b0197abb07d76b903b824ebbd36695c3
Reviewed-on: https://gerrit.libreoffice.org/26597
Tested-by: Jenkins 
Reviewed-by: Andras Timar 
(cherry picked from commit 9b6a02d8d48c135103aaa980fd27eec07b9223b6)
Reviewed-on: https://gerrit.libreoffice.org/26678
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sfx2/Package_classification.mk b/sfx2/Package_classification.mk
index a2dbb3e..0cca6f6 100644
--- a/sfx2/Package_classification.mk
+++ b/sfx2/Package_classification.mk
@@ -11,6 +11,7 @@ $(eval $(call 
gb_Package_Package,sfx2_classification,$(SRCDIR)/sfx2))
 
 $(eval $(call 
gb_Package_add_files,sfx2_classification,$(LIBO_SHARE_FOLDER)/classification,\
classification/example.xml \
+   classification/example_sl-SI.xml \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/sfx2/classification/example_sl-SI.xml 
b/sfx2/classification/example_sl-SI.xml
new file mode 100644
index 000..822ca6d
--- /dev/null
+++ b/sfx2/classification/example_sl-SI.xml
@@ -0,0 +1,71 @@
+
+
+Avtoriteta primera politike 
TSCP
+Primer politike TSCP
+
+urn:example:tscp:1
+
+
+
+
+
+Vlada RS
+0
+
+
+
+
+
+Dokument: glava
+Stopnja zaupnosti: sploÅ¡no 
poslovanje
+
+
+
+Vlada RS
+1
+
+
+
+
+
+Dokument: glava
+Stopnja zaupnosti: zaupno
+
+
+Dokument: noga
+Ta vsebina ima oznako zaupno. Ne razÅ¡irjajte 
je zunaj brez  poslovne odobritve.
+
+
+Dokument: vodni Å¾ig
+Zaupno
+
+
+
+Vlada RS
+2
+
+
+
+
+
+Dokument: glava
+Stopnja zaupnosti: interno
+
+
+Dokument: noga
+Ta vsebina ima oznako interno. Ne razÅ¡irjajte 
je izven podjetja.
+
+
+Dokument: vodni Å¾ig
+Interno
+
+
+
+Vlada RS
+3
+
+
+
+
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source

2016-06-26 Thread Michael Stahl

 sc/source/ui/unoobj/scdetect.cxx |   23 +++
 1 file changed, 23 insertions(+)

New commits:
commit eb7364fffe39c1aecddcab6b9cf238475fa2013c
Author: Michael Stahl 
Date:   Fri Jun 24 18:24:24 2016 +0200

tdf#84834 sc: stricter type detection for dBASE files

The detection is rather sloppy, the bugdoc gets erroneously detected as
dBASE because it starts with '0', has a not-too-large header size at offset 
4,
and a '\r' at a 32-byte alignment towards the start of the the not-too-large
header.

Add a plausibility check for the number of records in the file, which
helps for this bugdoc.

Change-Id: I466dfae18aa32fd62b79b9f524f22bea719721be
(cherry picked from commit 4e3ff19b33c84557fd20e68960499933b4e52638)
Reviewed-on: https://gerrit.libreoffice.org/26644
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sc/source/ui/unoobj/scdetect.cxx b/sc/source/ui/unoobj/scdetect.cxx
index 3bd8ffc..bb2c407 100644
--- a/sc/source/ui/unoobj/scdetect.cxx
+++ b/sc/source/ui/unoobj/scdetect.cxx
@@ -219,14 +219,37 @@ static bool lcl_MayBeDBase( SvStream& rStream )
 if ( nSize < nEmptyDbf )
 return false;
 
+// count of records at 4
+rStream.Seek(4);
+sal_uInt32 nRecords(0);
+rStream.ReadUInt32(nRecords);
+
 // length of header starts at 8
 rStream.Seek(8);
 sal_uInt16 nHeaderLen;
 rStream.ReadUInt16( nHeaderLen );
 
+// size of record at 10
+sal_uInt16 nRecordSize(0);
+rStream.ReadUInt16(nRecordSize);
+
 if ( nHeaderLen < nEmptyDbf || nSize < nHeaderLen )
 return false;
 
+// see DTable.cxx ODbaseTable::readHeader()
+if (0 == nRecordSize)
+return false;
+
+// see DTable.cxx ODbaseTable::construct() line 546
+if (0 == nRecords)
+{
+nRecords = (nSize - nHeaderLen) / nRecordSize;
+}
+
+// tdf#84834 sanity check of size
+if (0 == nRecords || nSize < nHeaderLen + nRecords * 
sal_uInt64(nRecordSize))
+return false;
+
 // Last byte of header must be 0x0d, this is how it's specified.
 // #i9581#,#i26407# but some applications don't follow the specification
 // and pad the header with one byte 0x00 to reach an
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 95797] Current display of the document moves away (jumps) when saving or when autorecovery information is saved

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95797

V Stuart Foote  changed:

   What|Removed |Added

 CC||k...@kenbeal.com

--- Comment #14 from V Stuart Foote  ---
*** Bug 100625 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100625] Auto-save scrolls to the cursor, annoying the user

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100625

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---
Duplicate of bug 95797 which has been fixed--available with 5.2.0

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4fabfb654bc65a564da1162f10f441efce167706=libreoffice-5-2

tdf#95797: Don't jump to the cursor position after auto-save.

*** This bug has been marked as a duplicate of bug 95797 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100619] Crash when cancel Tools/Customize/Toolbars ( kde4 and gen rendering only + debug mode)

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100619

Caolán McNamara  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100619] Crash when cancel Tools/Customize/Toolbars ( kde4 and gen rendering only + debug mode)

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100619

--- Comment #5 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2184b08dd185f3f20d8b2098d3f652aed629b51f

Resolves: tdf#100619 vclptr assert with menu set to menubutton

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100627] New: Create a table, and the cursor disappears

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100627

Bug ID: 100627
   Summary: Create a table, and the cursor disappears
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: k...@kenbeal.com

Whether I create the table with the keyboard (my preference) or the mouse (to
provide a more comprehensive bug report), the cursor disappears until I switch
away and then back.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100619] Crash when cancel Tools/Customize/Toolbars ( kde4 and gen rendering only + debug mode)

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100619

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source

2016-06-26 Thread Caolán McNamara

 cui/source/customize/cfg.cxx |   19 +++
 cui/source/inc/cfg.hxx   |3 +++
 2 files changed, 14 insertions(+), 8 deletions(-)

New commits:
commit 2184b08dd185f3f20d8b2098d3f652aed629b51f
Author: CaolÃ¡n McNamara 
Date:   Sun Jun 26 21:01:36 2016 +0100

Resolves: tdf#100619 vclptr assert with menu set to menubutton

Change-Id: I2e621567e3bbc01d6f52844014dba9e46fe79f41

diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index 1b08c29..346a2cf 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -3090,6 +3090,8 @@ bool SvxConfigEntry::IsRenamable()
 
 SvxToolbarConfigPage::SvxToolbarConfigPage(vcl::Window *pParent, const 
SfxItemSet& rSet)
 : SvxConfigPage(pParent, rSet)
+, m_pMenu(CUI_RES(MODIFY_TOOLBAR))
+, m_pEntry(CUI_RES(MODIFY_TOOLBAR_CONTENT))
 {
 SetHelpId( HID_SVX_CONFIG_TOOLBAR );
 
@@ -3134,19 +3136,17 @@ SvxToolbarConfigPage::SvxToolbarConfigPage(vcl::Window 
*pParent, const SfxItemSe
 m_pMoveDownButton->Enable();
 m_pMoveUpButton->Enable();
 
-VclPtrInstance pMenu( CUI_RES( MODIFY_TOOLBAR ) );
-pMenu->SetMenuFlags(
-pMenu->GetMenuFlags() | MenuFlags::AlwaysShowDisabledEntries );
+m_pMenu->SetMenuFlags(
+m_pMenu->GetMenuFlags() | MenuFlags::AlwaysShowDisabledEntries );
 
-m_pModifyTopLevelButton->SetPopupMenu( pMenu );
+m_pModifyTopLevelButton->SetPopupMenu( m_pMenu );
 m_pModifyTopLevelButton->SetSelectHdl(
 LINK( this, SvxToolbarConfigPage, ToolbarSelectHdl ) );
 
-VclPtrInstance pEntry( CUI_RES( MODIFY_TOOLBAR_CONTENT ) );
-pEntry->SetMenuFlags(
-pEntry->GetMenuFlags() | MenuFlags::AlwaysShowDisabledEntries );
+m_pEntry->SetMenuFlags(
+m_pEntry->GetMenuFlags() | MenuFlags::AlwaysShowDisabledEntries );
 
-m_pModifyCommandButton->SetPopupMenu( pEntry );
+m_pModifyCommandButton->SetPopupMenu(m_pEntry);
 m_pModifyCommandButton->SetSelectHdl(
 LINK( this, SvxToolbarConfigPage, EntrySelectHdl ) );
 
@@ -3184,6 +3184,9 @@ void SvxToolbarConfigPage::dispose()
 }
 m_pSaveInListBox->Clear();
 
+m_pEntry.disposeAndClear();
+m_pMenu.disposeAndClear();
+
 SvxConfigPage::dispose();
 }
 
diff --git a/cui/source/inc/cfg.hxx b/cui/source/inc/cfg.hxx
index 9ca82b4..b9ca0d5 100644
--- a/cui/source/inc/cfg.hxx
+++ b/cui/source/inc/cfg.hxx
@@ -575,6 +575,9 @@ private:
 voidDeleteSelectedContent() override;
 voidDeleteSelectedTopLevel() override;
 
+VclPtrInstance  m_pMenu;
+VclPtrInstance  m_pEntry;
+
 public:
 SvxToolbarConfigPage( vcl::Window *pParent, const SfxItemSet& rItemSet );
 virtual ~SvxToolbarConfigPage();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100626] New document doesn't have focus

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100626

k...@kenbeal.com changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100621] Libreoffice window looses focus when entering/ leaving full screen

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100621

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #2 from V Stuart Foote  ---
Can not reproduce on Windows 10 Pro 64-bit en-US with
Version: 5.2.0.1 (x64)
Build ID: fcbcb4963bda8633ba72bd2108ca1e802aad557d
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; 
Locale: en-US (en_US)

With focus and edit cursor present in a cell, cycle between full screen mode ->
desktop and back leaves focus in that cell in both modes.

Any improvement with a clean user profile?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100625] Auto-save scrolls to the cursor, annoying the user

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100625

k...@kenbeal.com changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100626] New: New document doesn't have focus

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100626

Bug ID: 100626
   Summary: New document doesn't have focus
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: k...@kenbeal.com

I hit Ctrl+N to open a new document.  It opens, but doesn't have focus.  I can
hit Alt+Tab twice (i.e., switch away and back with the keyboard) and then focus
will be correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100625] New: Auto-save scrolls to the cursor, annoying the user

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100625

Bug ID: 100625
   Summary: Auto-save scrolls to the cursor, annoying the user
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: k...@kenbeal.com

This is a major UI breakage/annoyance.

Steps

1. Configure auto-save to the lowest value (1 minute, I believe).
2. Open or author a document that is larger than the viewable window.
3. Put the cursor at the beginning of the document, and press the space bar (so
there's an edit it will auto-save).
4. Scroll to the end of the document using the mouse and the scroll bar.
5. Wait until the auto-save interval.


Expected Results

The document should auto-save and whatever was on screen remains as-is.


Actual Results

The document auto-saves, AND ALSO scrolls to where the cursor is.  This is
almost NEVER desired behavior.  In fact, I can't think of any time I would want
it to do that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100624] number keypad not working

2016-06-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100624

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Can not reproduce.

Windows 10 Pro 64-bit en-US with
Version: 5.3.0.0.alpha0+
Build ID: 757f221bceb74ccc2af8a9d4de149076280f29fb
CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-06-23_23:54:55
Locale: en-US (en_US)

nor with
Version: 5.2.0.1 (x64)
Build ID: fcbcb4963bda8633ba72bd2108ca1e802aad557d
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; 
Locale: en-US (en_US)

Is your Numlock engaged?

Also, please clear you LibreOffice user profile by deleting or renaming
%APPDATA%\LibreOffice and testing again.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

1 2 3 >

1 - 100 of 281 matches

Mail list logo