[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts (accelerators)

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=98259

Aron Budea  changed:

   What|Removed |Added

 Depends on||100622


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100622
[Bug 100622] Menu shortcuts don't work with right ALT key
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100622] Menu shortcuts don't work with right ALT key

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100622

Aron Budea  changed:

   What|Removed |Added

 Blocks||98259


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
[Bug 98259] [META] Keyboard shortcuts (accelerators)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts (accelerators)

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=98259

Aron Budea  changed:

   What|Removed |Added

 Depends on||97768


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97768
[Bug 97768] working with onscreen-keyboard LO misunderstands AltGr+E (Euro) as
Alt+E
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97768] working with onscreen-keyboard LO misunderstands AltGr+E (Euro ) as Alt+E

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97768

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu,
   ||juergen.funk...@cib.de
 Blocks||98259
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Confirmed in Windows 7 with on-screen keyboard. In 5.2.0.2 and master builds it
brings up extension manager, but that isn't correct, either.

It's interesting how the behavior is somewhat opposite compared to bug 100622
(it seems that the keyboard and on-screen keyboard are treated differently). I
wonder if the changes in bug 95761 are related. Juergen, can you take a look?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
[Bug 98259] [META] Keyboard shortcuts (accelerators)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: extras/source

2016-07-11 Thread Samuel Mehrbrodt 
 extras/source/templates/presnt/Vivid.otp |binary
 1 file changed

New commits:
commit 0168bdc2310223fd8b7035a73d0fc850ecf07827
Author: Samuel Mehrbrodt 
Date:   Tue Jul 12 07:49:30 2016 +0200

Vivid Template: Thumbnail image with english text

Instead of German

Change-Id: I9ea57164f5daf1daef578b05a982cc4ed3259a90

diff --git a/extras/source/templates/presnt/Vivid.otp 
b/extras/source/templates/presnt/Vivid.otp
index 22b90bb..5b7c227 100644
Binary files a/extras/source/templates/presnt/Vivid.otp and 
b/extras/source/templates/presnt/Vivid.otp differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: extras/source

2016-07-11 Thread Samuel Mehrbrodt 
 extras/source/templates/presnt/Metropolis.otp |binary
 1 file changed

New commits:
commit 96c4ef44ae7b86edc5b7b20d88ee5caf2ddf5a45
Author: Samuel Mehrbrodt 
Date:   Tue Jul 12 07:10:38 2016 +0200

Metropolis template: Change color to white

Black color on blue background is not very readable.

Change-Id: Idd23ba21cea036e8b660f98c10f9ab527ef95937

diff --git a/extras/source/templates/presnt/Metropolis.otp 
b/extras/source/templates/presnt/Metropolis.otp
index d84cbc6..8669454 100644
Binary files a/extras/source/templates/presnt/Metropolis.otp and 
b/extras/source/templates/presnt/Metropolis.otp differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100668] FileOpen: Multiple instances of soffice.bin

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100668

--- Comment #4 from AS  ---
Oops, it doesn't work. The file is too large.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100668] FileOpen: Multiple instances of soffice.bin

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100668

--- Comment #3 from AS  ---
Thanks for your answer. 

I have attached a dumpfile (hanging process). Maybe it helps?
In next time we will test  LO 5.1.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100819] Can't save my file

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100819

Aron Budea  changed:

   What|Removed |Added

   Keywords||needAdvice
  Component|LibreOffice |Writer

--- Comment #5 from Aron Budea  ---
When you say nondeterministically, does it mean the exact same steps sometimes
cause error, the other times don't? Or it's just so far there were no clear-cut
identifiable steps that caused the error?

Very little can be done without a sample document and proper reproduction
steps. How complex is the document, what could be the incriminating
subdocument? Could you try copying the content into a new document, seeing if
maybe that gets rid of this issue?

You could also copy the document with .zip extension, unzip it, and look into
the XML files for anomalies, but I don't really know what to look for (plus the
file could be correct in its saved state).

Adding needAdvice keyword, hoping a developer can give some directions.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100860] Suggest modify lump process bar to smooth process bar

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100860

--- Comment #1 from odinatlas  ---
Created attachment 126175
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126175=edit
process bar

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 83054] Add "Go to Page" Entry in Edit Menu

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=83054

--- Comment #28 from Yousuf (Jay) Philips  ---
Sent in patch to have Ctrl + G open the dialog.
https://gerrit.libreoffice.org/27132

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 100860] New: Suggest modify lump process bar to smooth process bar

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100860

Bug ID: 100860
   Summary: Suggest modify lump process bar to smooth process bar
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: odinat...@gmail.com

Suggest modify lump process bar to smooth process bar,
libreoffice maybe feel more dexterous.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99999] Thesaurus in LO does not handle antonyms

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=9

--- Comment #6 from V Stuart Foote  ---
(In reply to Yousuf (Jay) Philips from comment #5)
> Stanislav: I maybe confused but we dont close old bugs as duplicates of new
> bugs.

Yeah, I was leaning toward saying the same, but then I realized that I'd
provided the correct details regards the WordNet 2.1 shortcomings on this
issue. The topic is better handled and on point here.  Stanislav, has it right
and the others are correctly dup'ed to this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100839] Tables in forms - cannot enter new values

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100839

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #5 from Aron Budea  ---
Thanks for the analysis! If you suspect this is an issue with MariaDB, have you
reported it there?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100812] Application close after insert graph

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100812

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #3 from Aron Budea  ---
I can't reproduce with LibreOffice 5.1.4.2 32-bit/ Windows 7 64-bit.

Can you try getting a backtrace of the crash?
https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/kendy/testcl' - desktop/inc desktop/Library_sofficeapp.mk desktop/source opencl/inc opencl/source Repository.mk sc/Module_sc.mk sc/Package_opencl.mk sc/

2016-07-11 Thread Michael Meeks 
Rebased ref, commits from common ancestor:
commit c5caed66544c11596ba190722873ed0591d7d251
Author: Michael Meeks 
Date:   Mon Jul 11 15:12:38 2016 +0100

desktop: validate OpenCL drivers before use.

OpenCL validation needs to happen before drivers are used in
anger. This should isolate any crashes, and/or mis-behavior to
We use app version, CL driver version and file time-stamp to
trigger re-testing the device. If anything fails: hard disable
OpenCL.

We use an opencl validation sheet (cl-test.ods) and install it.
It is a minimal CL set - it requires a very short formula group
length, and combines several CL functions into few formulae to
test more.

The sheet structure, in particular the manual squaring / SQRT - is
necessary to stick within the default CL subset, and ensure that
formulae are CL enabled from the root of the dependency tree up.

Change-Id: I18682dbdf9a8ba9c16d52bad4447e9acce97f0a3

diff --git a/Repository.mk b/Repository.mk
index a07f758..4dcd930 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -837,6 +837,7 @@ $(eval $(call gb_Helper_register_packages_for_install,ooo,\
Pyuno/mailmerge \
)) \
sfx2_classification \
+$(if $(filter OPENCL,$(BUILD_TYPE)),sc_opencl_runtimetest) \
 ))
 
 $(eval $(call gb_Helper_register_packages_for_install,ogltrans,\
diff --git a/desktop/Library_sofficeapp.mk b/desktop/Library_sofficeapp.mk
index 04bc491..a5cf82b 100644
--- a/desktop/Library_sofficeapp.mk
+++ b/desktop/Library_sofficeapp.mk
@@ -24,6 +24,7 @@ $(eval $(call gb_Library_add_libs,sofficeapp,\
 ))
 
 $(eval $(call gb_Library_use_externals,sofficeapp, \
+   $(if $(filter OPENCL,$(BUILD_TYPE)),clew) \
 boost_headers \
 dbus \
 ))
@@ -57,6 +58,7 @@ $(eval $(call gb_Library_use_libraries,sofficeapp,\
 deploymentmisc \
 editeng \
 i18nlangtag \
+$(if $(filter OPENCL,$(BUILD_TYPE)),opencl) \
 sal \
 salhelper \
 sb \
@@ -102,6 +104,7 @@ $(eval $(call gb_Library_add_exception_objects,sofficeapp,\
 desktop/source/app/langselect \
 desktop/source/app/lockfile2 \
 desktop/source/app/officeipcthread \
+desktop/source/app/opencl \
 desktop/source/app/sofficemain \
 desktop/source/app/userinstall \
 desktop/source/migration/migration \
diff --git a/desktop/inc/app.hxx b/desktop/inc/app.hxx
index 1905cf0..c90bfdb 100644
--- a/desktop/inc/app.hxx
+++ b/desktop/inc/app.hxx
@@ -84,6 +84,7 @@ class Desktop : public Application
 
 static void OpenClients();
 static void OpenDefault();
+static void CheckOpenCLCompute(const 
css::uno::Reference &);
 
 DECL_STATIC_LINK_TYPED( Desktop, EnableAcceptors_Impl, void*, void);
 
diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index fab48e1..7628c7a 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -1605,6 +1605,11 @@ int Desktop::Main()
 FatalError( MakeStartupErrorMessage(e.Message) );
 }
 
+// FIXME: move this somewhere sensible.
+#if HAVE_FEATURE_OPENCL
+CheckOpenCLCompute(xDesktop);
+#endif
+
 // Release solar mutex just before we wait for our client to connect
 {
 SolarMutexReleaser aReleaser;
diff --git a/desktop/source/app/opencl.cxx b/desktop/source/app/opencl.cxx
new file mode 100644
index 000..4c47767
--- /dev/null
+++ b/desktop/source/app/opencl.cxx
@@ -0,0 +1,173 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+/*
+ * This module exists to validate the OpenCL implementation,
+ * where necessary during startup; and before we load or
+ * calculate using OpenCL.
+ */
+
+#include "app.hxx"
+
+#include 
+#include 
+
+#include 
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+#include 
+
+using namespace ::osl;
+using namespace ::com::sun::star::uno;
+using namespace ::com::sun::star::frame;
+
+namespace desktop {
+
+#if HAVE_FEATURE_OPENCL
+
+bool testOpenCLCompute(const Reference< XDesktop2 > , const OUString 
)
+{
+bool bSuccess = false;
+css::uno::Reference< css::lang::XComponent > xComponent;
+
+SAL_INFO("opencl", "Starting CL test spreadsheet");
+
+try {
+css::uno::Reference< css::frame::XComponentLoader > xLoader(xDesktop, 
css::uno::UNO_QUERY_THROW);
+
+css::uno::Sequence< css::beans::PropertyValue > aArgs(1);
+aArgs[0].Name = "Hidden";
+aArgs[0].Value = makeAny(true);
+
+xComponent.set(xLoader->loadComponentFromURL(rURL, "_blank", 0, 
aArgs));
+
+// What an

[Libreoffice-bugs] [Bug 99999] Thesaurus in LO does not handle antonyms

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=9

--- Comment #5 from Yousuf (Jay) Philips  ---
Stanislav: I maybe confused but we dont close old bugs as duplicates of new
bugs.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100851] Menu change results in duplicate "n" selection

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100851

Aron Budea  changed:

   What|Removed |Added

 Blocks||98259


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
[Bug 98259] [META] Keyboard shortcuts (accelerators)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts (accelerators)

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=98259

Aron Budea  changed:

   What|Removed |Added

 Depends on||100851


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100851
[Bug 100851] Menu change results in duplicate "n" selection
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100824] Dowload from https://www.libreoffice.org/ download use unsecure http protocol

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100824

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #5 from Aron Budea  ---
Since this is related to the website, and not LibreOffice itself, could you
open a ticket at https://redmine.documentfoundation.org/ ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100845] "Find Record" crashes if cancelled without search

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100845

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@caesar.elte.hu
Version|unspecified |5.1.4.2 release
Summary|"find record" crashes if|"Find Record" crashes if
   |escaped with empty search   |cancelled without search
   |on dBase file   |
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Would you mind testing with most recent versions (5.1.4.2 fresh and/or 5.2.0.2
pre-release)? Instructions on installing in parallel with the existing version
are available at [1].
If the issue persists, could you attach a minimal example database file?

I could not reproduce the issue in 5.1.2.2/Windows 7 with a whatever database.
Find Record could be closed normally with ESC key.

[1] https://wiki.documentfoundation.org/Installing_in_parallel/Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100851] Menu change results in duplicate "n" selection

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100851

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||ba...@caesar.elte.hu
   Hardware|x86-64 (AMD64)  |All
 Resolution|--- |WORKSFORME
 Whiteboard||backportRequest:5.1
 OS|Windows (All)   |All

--- Comment #1 from Aron Budea  ---
Indeed. The duplicated accelerator is fixed in 5.2.0.2 (Alig[n] is unchanged,
Pri[n]t Ranges has been changed to Prin[t] Ranges), and there are a couple of
other differences as well ([T]ext -> Te[x]t, [R]ow -> Ro[w] etc.), and I only
checked the Format menu, there could be more.

Since it's fixed in the current version, closing this as WORKSFORME. Requesting
backport to 5.1. Note that because Alig[n] has a submenu, it's difficult to
reach the other item with "n" accelerator.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100859] New: Windows close window shortcut overridden (Alt-F4)

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100859

Bug ID: 100859
   Summary: Windows close window shortcut overridden (Alt-F4)
   Product: LibreOffice
   Version: 5.1.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: zane.s...@gmail.com

When using the standard Windows keyboard shortcut to close a window/application
(Alt-F4), Libre Office Calc and Writer do not close. This may also happen with
the other Libre Office apps, but I do not use them. When hitting the Alt-F4
combo, Calc and Writer just do what they are configured to do when someone hits
F4 (i.e. for calc, alternates between relative and absolute references, and for
writer, shows the data sources pane). Some Linux distros use Alt-F4 as a close
window shortcut as well, but I haven't tried the 5.1+ on them to see if it
suffers from the same problem.

This shortcut is used by people who do not use the mouse as much (such as
visually impaired users) and should be available.

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100841] Dragging a cell's frame to Fill Series, etc - no longer shows a tooltip indicating currently reached value

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100841

Aron Budea  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi
 OS|All |Linux (All)

--- Comment #4 from Aron Budea  ---
Thanks for testing with different DEs. Yes, I'm using Unity.
Giving 5.2.0.2 would certainly be worth a try, it's available at [1]. Another
option would be to verify if the same version as your stable box shows the
tooltip (to see if it could be related to something else in the system). You
will find instructions on installing LibreOffice in parallel with the existing
version at [2]. 

Are other tooltips visible normally? The ones for toolbar buttons for example.

I'm afraid I'm not proficient with Linux insides. Buovjaga, can you take a
look?

[1] http://dev-builds.libreoffice.org/pre-releases/
[2] https://wiki.documentfoundation.org/Installing_in_parallel/Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100857] Animations only "appear". Don't work as described.

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100857

MM  changed:

   What|Removed |Added

 OS|Windows (All)   |All

--- Comment #1 from MM  ---
Unconfirmed with v5.0.6.3 under mint 17.3 x64.
Confirmed with v5.1.4.2 under ubuntu 16.04 x64.
Unconfirmed with v5.2.0.1 under ubuntu 16.04 x64.

Seems already fixed, but not backported to v5.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2016-07-11 Thread Marco Cecchetti 
 sc/qa/perf/scperfobj.cxx |  147 ---
 1 file changed, 138 insertions(+), 9 deletions(-)

New commits:
commit 83d5a4a9c256eaef4c04f799db38b373d9cff4d5
Author: Marco Cecchetti 
Date:   Mon Jul 11 23:22:07 2016 +0200

calc - perf test for formula group S/W interpreter

Change-Id: Ifebfbff0a1d0ee9ceb801bb6b647a26573254b28
Reviewed-on: https://gerrit.libreoffice.org/27129
Tested-by: Jenkins 
Reviewed-by: Michael Meeks 

diff --git a/sc/qa/perf/scperfobj.cxx b/sc/qa/perf/scperfobj.cxx
index eb9e888..99521d8 100644
--- a/sc/qa/perf/scperfobj.cxx
+++ b/sc/qa/perf/scperfobj.cxx
@@ -12,6 +12,10 @@
 #include 
 #include "cppunit/extensions/HelperMacros.h"
 
+#include 
+#include 
+#include 
+
 #include 
 #include 
 #include 
@@ -40,6 +44,10 @@
 
 #include 
 
+#include "calcconfig.hxx"
+#include "docsh.hxx"
+#include "tabvwsh.hxx"
+
 using namespace css;
 using namespace css::uno;
 
@@ -59,7 +67,7 @@ public:
 CPPUNIT_TEST_SUITE(ScPerfObj);
 CPPUNIT_TEST(testSheetFindAll);
 CPPUNIT_TEST(testFixedSum);
-CPPUNIT_TEST(testVariableSum);
+CPPUNIT_TEST(testFormulaGroupSWInterpreter);
 CPPUNIT_TEST(testSheetNamedRanges);
 CPPUNIT_TEST(testSheets);
 CPPUNIT_TEST(testSum);
@@ -97,7 +105,7 @@ private:
 void testSubTotalWithoutFormulas();
 void testLoadingFileWithSingleBigSheet();
 void testFixedSum();
-void testVariableSum();
+void testFormulaGroupSWInterpreter();
 void testMatConcatSmall();
 void testMatConcatLarge();
 };
@@ -134,6 +142,111 @@ void ScPerfObj::tearDown()
 CalcUnoApiTest::tearDown();
 }
 
+namespace {
+
+class SpreadsheetDoc
+{
+public:
+SpreadsheetDoc();
+~SpreadsheetDoc();
+
+void copyRange( const OUString& rSrcRange, const OUString& rDstRange );
+
+ScDocument& GetDocument() { return *pDoc; }
+ScModelObj* GetModel() { return pModel; }
+
+private:
+uno::Reference< lang::XComponent > xComponent;
+ScDocument* pDoc;
+ScModelObj* pModel;
+ScTabViewShell* pViewShell;
+bool bOpenCLState;
+};
+
+SpreadsheetDoc::SpreadsheetDoc()
+: xComponent()
+, pDoc(nullptr)
+, pModel(nullptr)
+, pViewShell(nullptr)
+, bOpenCLState(ScCalcConfig::isOpenCLEnabled())
+{
+uno::Reference< frame::XDesktop2 > xDesktop = 
frame::Desktop::create(::comphelper::getProcessComponentContext());
+CPPUNIT_ASSERT( xDesktop.is() );
+
+// create a frame
+Reference< frame::XFrame > xTargetFrame = xDesktop->findFrame( "_blank", 0 
);
+CPPUNIT_ASSERT( xTargetFrame.is() );
+
+// Create spreadsheet
+uno::Sequence< beans::PropertyValue > aEmptyArgList;
+xComponent = xDesktop->loadComponentFromURL(
+"private:factory/scalc",
+"_blank",
+0,
+aEmptyArgList );
+CPPUNIT_ASSERT( xComponent.is() );
+
+// Get the document model
+SfxObjectShell* pFoundShell = 
SfxObjectShell::GetShellFromComponent(xComponent);
+CPPUNIT_ASSERT_MESSAGE("Failed to access document shell", pFoundShell);
+
+ScDocShellRef xDocSh = dynamic_cast(pFoundShell);
+CPPUNIT_ASSERT(xDocSh != nullptr);
+
+uno::Reference< frame::XModel2 > xModel2 ( xDocSh->GetModel(), UNO_QUERY );
+CPPUNIT_ASSERT( xModel2.is() );
+
+Reference< frame::XController2 > xController ( 
xModel2->createDefaultViewController( xTargetFrame ), UNO_QUERY );
+CPPUNIT_ASSERT( xController.is() );
+
+// introduce model/view/controller to each other
+xController->attachModel( xModel2.get() );
+xModel2->connectController( xController.get() );
+xTargetFrame->setComponent( xController->getComponentWindow(), 
xController.get() );
+xController->attachFrame( xTargetFrame );
+xModel2->setCurrentController( xController.get() );
+
+pDoc = &(xDocSh->GetDocument());
+
+// Get the document controller
+pViewShell = xDocSh->GetBestViewShell(false);
+CPPUNIT_ASSERT(pViewShell != nullptr);
+
+pModel = ScModelObj::getImplementation(pFoundShell->GetModel());
+CPPUNIT_ASSERT(pModel != nullptr);
+}
+
+SpreadsheetDoc::~SpreadsheetDoc()
+{
+// Close the document (Ctrl-W)
+if (pModel)
+pModel->enableOpenCL(bOpenCLState);
+if (xComponent.is())
+xComponent->dispose();
+}
+
+void SpreadsheetDoc::copyRange( const OUString& rSrcRange, const OUString& 
rDstRange )
+{
+
+   ScDocument aClipDoc(SCDOCMODE_CLIP);
+
+// 1. Copy
+ScRange aSrcRange;
+ScRefFlags nRes = aSrcRange.Parse(rSrcRange, pDoc, 
pDoc->GetAddressConvention());
+CPPUNIT_ASSERT_MESSAGE("Failed to parse.", (nRes & ScRefFlags::VALID));
+pViewShell->GetViewData().GetMarkData().SetMarkArea(aSrcRange);
+pViewShell->GetViewData().GetView()->CopyToClip(, false, false, 
false, false);
+
+// 2. Paste
+ScRange aDstRange;
+nRes = aDstRange.Parse(rDstRange, pDoc, pDoc->GetAddressConvention());
+

[Libreoffice-bugs] [Bug 100824] Dowload from https://www.libreoffice.org/ download use unsecure http protocol

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100824

--- Comment #4 from tdel...@gmail.com ---
(In reply to MM from comment #3)
> 
> I see. But it's not a bug, as the link is working normally. You might wanna
> set it as enhancement.
> 

You can call that an enhancement. I call the current situation a security hole.
A MitM can use that to install malware. Some rogue tor node did it, it's not
science fiction.

Using only https mirrors is one solution. Another one could be a small
downloader, downloaded from the https official website, that download from
mirrors/torrent and check the checksum before install.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100824] Dowload from https://www.libreoffice.org/ download use unsecure http protocol

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100824

--- Comment #3 from MM  ---
(In reply to tdelmas from comment #2)

> http://donate.libreoffice.org/fr/dl/win-x86/5.1.4/fr/LibreOffice_5.1.
> 4_Win_x86.msi
> 

> It then redirect to the secure page
> https://donate.libreoffice.org/fr/dl/win-x86/5.1.4/fr/LibreOffice_5.1.
> 4_Win_x86.msi
>

Well, atleast it's redirecting to a secure page. Which is a good thing.

> So the final download is NOT using https.

I see. But it's not a bug, as the link is working normally. You might wanna set
it as enhancement.

This download site is secure:
https://download.documentfoundation.org/libreoffice/ , but notice that a lot of
ftp mirrors which distribute LO (including the ones on universities) across the
world also aren't. Wanna make them all secure ?!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/kendy/testcl' - desktop/source

2016-07-11 Thread Michael Meeks 
 desktop/source/app/opencl.cxx |  162 ++
 1 file changed, 162 insertions(+)

New commits:
commit bb519630683ad720e2f1d17defc27016a4a0d86d
Author: Michael Meeks 
Date:   Mon Jul 11 23:20:27 2016 +0100

Re-work opencl / desktop testing pieces.

Split opencl validation pieces into their own module to avoid cl
header spread. Use app version, and CL driver version to trigger
re-testing the device. Hard disable, should cleanup existing CL
device too.

Change-Id: I3893351b6f3845538c74b3b5bf46724cd9bde62d

diff --git a/desktop/source/app/opencl.cxx b/desktop/source/app/opencl.cxx
new file mode 100644
index 000..405e824
--- /dev/null
+++ b/desktop/source/app/opencl.cxx
@@ -0,0 +1,162 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+/*
+ * This module exists to validate the OpenCL implementation,
+ * where necessary during startup; and before we load or
+ * calculate using OpenCL.
+ */
+
+
+#include "app.hxx"
+
+#include 
+#include 
+
+#include 
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+using namespace ::com::sun::star::uno;
+using namespace ::com::sun::star::frame;
+
+namespace desktop {
+
+#if HAVE_FEATURE_OPENCL
+
+bool testOpenCLCompute(const Reference< XDesktop2 > )
+{
+bool bSuccess = false;
+css::uno::Reference< css::lang::XComponent > xComponent;
+
+SAL_INFO("opencl", "Starting CL test spreadsheet");
+
+try {
+css::uno::Reference< css::frame::XComponentLoader > xLoader(xDesktop, 
css::uno::UNO_QUERY_THROW);
+
+css::uno::Sequence< css::beans::PropertyValue > aArgs(1);
+aArgs[0].Name = "Hidden";
+aArgs[0].Value = makeAny(true);
+
+OUString aUrl("$BRAND_BASE_DIR/" LIBO_ETC_FOLDER 
"/opencl/cl-test.ods");
+rtl::Bootstrap::expandMacros(aUrl);
+
+xComponent.set(xLoader->loadComponentFromURL(aUrl, "_blank", 0, 
aArgs));
+
+// What an unpleasant API to use.
+css::uno::Reference< css::sheet::XCalculatable > xCalculatable( 
xComponent, css::uno::UNO_QUERY_THROW);
+css::uno::Reference< css::sheet::XSpreadsheetDocument > xSpreadDoc( 
xComponent, css::uno::UNO_QUERY_THROW );
+css::uno::Reference< css::sheet::XSpreadsheets > xSheets( 
xSpreadDoc->getSheets(), css::uno::UNO_QUERY_THROW );
+css::uno::Reference< css::container::XIndexAccess > xIndex( xSheets, 
css::uno::UNO_QUERY_THROW );
+css::uno::Reference< css::sheet::XSpreadsheet > xSheet( 
xIndex->getByIndex(0), css::uno::UNO_QUERY_THROW);
+
+// So we insert our MAX call at the end on a named range.
+css::uno::Reference< css::table::XCell2 > xThresh( 
xSheet->getCellByPosition(1,1), css::uno::UNO_QUERY_THROW ); // B2
+double fThreshold = xThresh->getValue();
+
+// We need pure OCL formulae all the way through the
+// dependency chain, or we fall-back.
+xCalculatable->calculateAll();
+
+// So we insert our MAX call at the end on a named range.
+css::uno::Reference< css::table::XCell2 > xCell( 
xSheet->getCellByPosition(1,0), css::uno::UNO_QUERY_THROW );
+xCell->setFormula("=MAX(results)");
+double fResult = xCell->getValue();
+
+// Ensure the maximum variance is below our tolerance.
+if (fResult > fThreshold)
+{
+SAL_WARN("opencl", "OpenCL results unstable - disabling; result: "
+ << fResult << " vs. " << fThreshold);
+}
+else
+{
+SAL_INFO("opencl", "calculating smoothly; result: " << fResult);
+bSuccess = true;
+}
+}
+catch (const css::uno::Exception )
+{
+(void)e;
+SAL_WARN("opencl", "OpenCL testing failed - disabling: " << e.Message);
+}
+
+if (!bSuccess)
+OpenCLZone::hardDisable();
+if (xComponent.is())
+xComponent->dispose();
+
+return bSuccess;
+}
+
+void Desktop::CheckOpenCLCompute(const Reference< XDesktop2 > )
+{
+if (getenv("SAL_DISABLE_OPENCL") ||
+!officecfg::Office::Common::Misc::UseOpenCL::get())
+return;
+
+SAL_INFO("opencl", "Initiating test of OpenCL device");
+OpenCLZone aZone;
+
+OUString aDevice = 
officecfg::Office::Calc::Formula::Calculation::OpenCLDevice::get();
+OUString aSelectedCLDeviceVersionID;
+if (!opencl::switchOpenCLDevice(
+,
+
officecfg::Office::Calc::Formula::Calculation::OpenCLAutoSelect::get(),
+false /* bForceEvaluation */,
+aSelectedCLDeviceVersionID))
+{
+SAL_WARN("opencl", "Failed to initialize

[Libreoffice-commits] core.git: Branch 'private/kendy/testcl' - desktop/inc desktop/Library_sofficeapp.mk desktop/source opencl/inc opencl/source sc/source

2016-07-11 Thread Michael Meeks 
 desktop/Library_sofficeapp.mk|2 
 desktop/inc/app.hxx  |1 
 desktop/source/app/app.cxx   |   75 ---
 opencl/inc/opencl_device.hxx |3 +
 opencl/source/OpenCLZone.cxx |4 +
 opencl/source/openclwrapper.cxx  |6 ++
 sc/source/core/tool/formulagroup.cxx |   10 
 7 files changed, 16 insertions(+), 85 deletions(-)

New commits:
commit 624df9d568b78a792b247b3f6daf5b51d479a25e
Author: Michael Meeks 
Date:   Mon Jul 11 23:20:27 2016 +0100

Re-work opencl / desktop testing pieces.

Split opencl validation pieces into their own module to avoid cl
header spread. Use app version, and CL driver version to trigger
re-testing the device. Hard disable, should cleanup existing CL
device too.

Change-Id: I3893351b6f3845538c74b3b5bf46724cd9bde62d

diff --git a/desktop/Library_sofficeapp.mk b/desktop/Library_sofficeapp.mk
index 3154a7b..a5cf82b 100644
--- a/desktop/Library_sofficeapp.mk
+++ b/desktop/Library_sofficeapp.mk
@@ -24,6 +24,7 @@ $(eval $(call gb_Library_add_libs,sofficeapp,\
 ))
 
 $(eval $(call gb_Library_use_externals,sofficeapp, \
+   $(if $(filter OPENCL,$(BUILD_TYPE)),clew) \
 boost_headers \
 dbus \
 ))
@@ -103,6 +104,7 @@ $(eval $(call gb_Library_add_exception_objects,sofficeapp,\
 desktop/source/app/langselect \
 desktop/source/app/lockfile2 \
 desktop/source/app/officeipcthread \
+desktop/source/app/opencl \
 desktop/source/app/sofficemain \
 desktop/source/app/userinstall \
 desktop/source/migration/migration \
diff --git a/desktop/inc/app.hxx b/desktop/inc/app.hxx
index 1905cf0..c90bfdb 100644
--- a/desktop/inc/app.hxx
+++ b/desktop/inc/app.hxx
@@ -84,6 +84,7 @@ class Desktop : public Application
 
 static void OpenClients();
 static void OpenDefault();
+static void CheckOpenCLCompute(const 
css::uno::Reference &);
 
 DECL_STATIC_LINK_TYPED( Desktop, EnableAcceptors_Impl, void*, void);
 
diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index cc05d74..7628c7a 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -75,12 +75,6 @@
 #include 
 #include 
 
-#include 
-#include 
-#include 
-#include 
-#include 
-
 #include 
 #include 
 #include 
@@ -115,7 +109,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #include "langselect.hxx"
 
@@ -1333,72 +1326,6 @@ void Desktop::DoExecute()
 #endif
 }
 
-#if HAVE_FEATURE_OPENCL
-void testOpenCLCompute(const Reference< XDesktop2 > )
-{
-if (getenv("SAL_DISABLE_OPENCL"))
-return;
-
-css::uno::Reference< css::lang::XComponent > xComponent;
-
-SAL_INFO("opencl", "Initiating test of OpenCL device");
-try {
-OpenCLZone aZone;
-css::uno::Reference< css::frame::XComponentLoader > xLoader(xDesktop, 
css::uno::UNO_QUERY_THROW);
-
-// FIXME: invisible, read-only etc.
-css::uno::Sequence< css::beans::PropertyValue > aArgs(1);
-aArgs[0].Name = "Hidden";
-aArgs[0].Value = makeAny(true);
-
-OUString aUrl("$BRAND_BASE_DIR/" LIBO_ETC_FOLDER 
"/opencl/cl-test.ods");
-rtl::Bootstrap::expandMacros(aUrl);
-
-xComponent.set(xLoader->loadComponentFromURL(aUrl, "_blank", 0, 
aArgs));
-
-// What an unpleasant API to use.
-css::uno::Reference< css::sheet::XCalculatable > xCalculatable( 
xComponent, css::uno::UNO_QUERY_THROW);
-css::uno::Reference< css::sheet::XSpreadsheetDocument > xSpreadDoc( 
xComponent, css::uno::UNO_QUERY_THROW );
-css::uno::Reference< css::sheet::XSpreadsheets > xSheets( 
xSpreadDoc->getSheets(), css::uno::UNO_QUERY_THROW );
-css::uno::Reference< css::container::XIndexAccess > xIndex( xSheets, 
css::uno::UNO_QUERY_THROW );
-css::uno::Reference< css::sheet::XSpreadsheet > xSheet( 
xIndex->getByIndex(0), css::uno::UNO_QUERY_THROW);
-
-// So we insert our MAX call at the end on a named range.
-css::uno::Reference< css::table::XCell2 > xThresh( 
xSheet->getCellByPosition(1,1), css::uno::UNO_QUERY_THROW ); // B2
-double fThreshold = xThresh->getValue();
-
-// We need pure OCL formulae all the way through the
-// dependency chain, or we fall-back.
-xCalculatable->calculateAll();
-
-// So we insert our MAX call at the end on a named range.
-css::uno::Reference< css::table::XCell2 > xCell( 
xSheet->getCellByPosition(1,0), css::uno::UNO_QUERY_THROW );
-xCell->setFormula("=MAX(results)");
-double fResult = xCell->getValue();
-
-// Ensure the maximum variance is below our tolerance.
-if (fResult > fThreshold)
-{
-SAL_WARN("opencl", "OpenCL results unstable - disabling; result: "
- << fResult << " vs. " << fThreshold);
-OpenCLZone::hardDisable();
-}
-else
-{

Macro encryption different in between 4.2 and 5.1

2016-07-11 Thread SOS 
A extension made with password protected Basic Libraries using LO 5.1  
do not "load" properly the libraries under LO 4.2


We load a  password protected library using the folowing code.
If (Not GlobalScope.BasicLibraries.isLibraryLoaded("DbUtils")) Then
GlobalScope.BasicLibraries.LoadLibrary("DbUtils")
End If
extension Build and used in 4.2  makes all functions and sub's available 
in memory.
extension Build and used in 5.1  makes all functions and sub's available 
in memory.
extension Build in 4.2 and used in 5.1: the functions and Sub's in the 
libraries are not available,  its only after opening the library  
"manualy" and after entering the password that make the functions and 
the sub's available in memory.


The extensions are build under Windows
There is a difference in size between the extension build in 5.1 and 4.2
5.1 gives 69 KB
4.2 gives 67 KB
There is no error after "GlobalScope.BasicLibraries.LoadLibrary("DbUtils")
once the librarie is opened with the password, then 
"GlobalScope.BasicLibraries.LoadLibrary("DbUtils")"  is working fine 
even after closing LO !!


Can someone confirm this behavior and sould i filled a issue ?

Thanks

Fernand

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 88991] VIEWING: Kerning issues with certain fonts like Arial

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=88991

--- Comment #8 from MarjaE  ---
Created attachment 126174
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126174=edit
OpenDyslexic at 100% 5.1.2.2 on OS X.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78755] [FILEOPEN]: DOCX import filter - the 2nd table is placed on the page incorrectly

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=78755

Michael Stahl  changed:

   What|Removed |Added

  Attachment #99124|application/vnd.oasis.opend |application/vnd.openxmlform
  mime type|ocument.text|ats-officedocument.wordproc
   ||essingml.document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77858] FORMATTING: Writer Does Not Save New "Next style"

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=77858

Michael Stahl  changed:

   What|Removed |Added

  Attachment #97854|application/vnd.oasis.opend |application/vnd.openxmlform
  mime type|ocument.text|ats-officedocument.wordproc
   ||essingml.document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77854] EDITING: Converting from DOCX, saving ODT does not save images

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=77854

Michael Stahl  changed:

   What|Removed |Added

  Attachment #97849|application/vnd.oasis.opend |application/vnd.openxmlform
  mime type|ocument.text|ats-officedocument.wordproc
   ||essingml.document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100854] persian and arabic diacritics are not accessible by using arrow keys on keyboard.

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100854

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||accessibility
 CC||vstuart.fo...@utsa.edu

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72806] FILESAVE: docx: simple shapes lost on export

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=72806

Michael Stahl  changed:

   What|Removed |Added

  Attachment #90895|application/vnd.oasis.opend |application/vnd.openxmlform
  mime type|ocument.text|ats-officedocument.wordproc
   ||essingml.document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 49819] FILEOPEN error when loading a particular .docx file.

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=49819

Michael Stahl  changed:

   What|Removed |Added

  Attachment #61470|application/vnd.oasis.opend |application/vnd.openxmlform
  mime type|ocument.text|ats-officedocument.wordproc
   ||essingml.document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100858] New: Installer will not download correctly (Win10) freezes other browser (Mozilla) functions

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100858

Bug ID: 100858
   Summary: Installer will not download correctly (Win10) freezes
other browser (Mozilla) functions
   Product: LibreOffice
   Version: 5.1.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: efgoldma...@gmail.com

Version 5.1.4 will not download completely, will not install correctly. 
Previous versions thru  5.0.6.3 have downloaded and installed quickly, easily,
no problems. 
This version fails to d/l completely or install on two different computers, one
running Win7 and one running Win10. 
Browser Mozilla Firefox version 47.0 on both machines.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90330] Corruption of saved file when comment is deleted with track changes

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=90330

Michael Stahl  changed:

   What|Removed |Added

 CC||mst...@redhat.com
 Resolution|WORKSFORME  |DUPLICATE

--- Comment #4 from Michael Stahl  ---


*** This bug has been marked as a duplicate of bug 89615 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89615] ODF export: Writer saves invalid XML when there are multiple annotation ranges ( style tag has two office:name attributes)

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=89615

Michael Stahl  changed:

   What|Removed |Added

   Priority|medium  |highest
 Status|UNCONFIRMED |RESOLVED
Version|4.3.3.2 release |4.3.0.4 release
   Keywords||regression
 CC||mst...@redhat.com
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 Resolution|--- |FIXED
Summary|FILESAVE: Writer saves  |ODF export: Writer saves
   |invalid XML (style tag has  |invalid XML when there are
   |two office:name attributes) |multiple annotation ranges
   ||(style tag has two
   ||office:name attributes)
 Whiteboard||odf odf_validation
   ||target:4.4.4 target:5.0.0
   Severity|normal  |critical

--- Comment #5 from Michael Stahl  ---
a regression from the AOO imported range annotation feature,
commit 0761f81643a6890457e9ef7d913ab5c88c2593a4

this was fixed in LO 4.4.4 by

commit 804ec2289115a65c74ddff478b7469801debf7e4
Author: Caolán McNamara 
AuthorDate: Wed Apr 22 14:10:38 2015 +0100

fix assert on export of ooo63141-1.doc to odt

if bAutoStyles is true then the mbDoSomething of the SvXMLElementExport is
false, and the ctor/dtor doesn't do anything so any attributes added to the
exporter are not cleared by the SvXMLElementExport dtor

so only add the attribute if bAutoStyles if false and might as well extend
the  
block to cover the use of SvXMLElementExport and use the other ctor which
defaults mbDoSomething on

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

GSoC Weekly Report #7 - Table Styles

2016-07-11 Thread Jakub Trzebiatowski 

Dear community,

This week I was looking how to export paragraph and char attributes of a 
cell
style. Finally found it out. The export, import and exports tests code 
can be

found at gerrit:
https://gerrit.libreoffice.org/#/c/27115/

Next I will have to implement XPropertyState for a the remaining cell style
attributes.

If everything goes fine I would like to start working on table autoformat
dialog.
I have the following Design Meeting paper:
https://docs.google.com/document/d/1FPkf9fn79dXJ5tHpc-meMYxaQpj3nV5sEN6u9HOo2GQ/
edit
However I don't know which table autoformat dialog design would be the 
best to

implement.

Or maybe would it be better to start from table styles panel, or table
styles toolbar?

Looking forward to your reply.

Regards,
Jakub Trzebiatowski, ubap
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: extras/Package_tplpresnt.mk extras/source

2016-07-11 Thread Samuel Mehrbrodt 
 extras/Package_tplpresnt.mk   |1 +
 extras/source/templates/presnt/Pencil.otp |binary
 2 files changed, 1 insertion(+)

New commits:
commit 38f7902f4551cbd2770e84f6df45e3c78271b800
Author: Samuel Mehrbrodt 
Date:   Mon Jul 11 22:26:12 2016 +0200

Impress: Add new template "Pencil"

* From 
https://wiki.documentfoundation.org/Design/Whiteboards/Templates_for_LibreOffice_5.0
* Submitted under CC0
* Slightly modified by me

Change-Id: Ie5d3b0ba5561f8ac679a2c522acd71c3f0fe

diff --git a/extras/Package_tplpresnt.mk b/extras/Package_tplpresnt.mk
index d86082f..6c7c36b 100644
--- a/extras/Package_tplpresnt.mk
+++ b/extras/Package_tplpresnt.mk
@@ -25,6 +25,7 @@ $(eval $(call 
gb_Package_add_files,extras_tplpresnt,$(LIBO_SHARE_FOLDER)/templat
Impress.otp \
Midnightblue.otp \
Vivid.otp \
+   Pencil.otp \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/extras/source/templates/presnt/Pencil.otp 
b/extras/source/templates/presnt/Pencil.otp
new file mode 100644
index 000..1ef4d13
Binary files /dev/null and b/extras/source/templates/presnt/Pencil.otp differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100793] FORMATTING - conditional formatting gets corrupted upon copy/ paste/insert

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100793

Thomas Maeder  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100793] FORMATTING - conditional formatting gets corrupted upon copy/ paste/insert

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100793

--- Comment #2 from Thomas Maeder  ---
Created attachment 126173
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126173=edit
demo file

This is not exactly the original file (private), but an equivalent that also
has the problem.
1) Open file
2) Go to sheet "plan"
3) Open the conditional formatting management dialog
-> The indicated range should be G18:K29,F18,F20:F29
3) Click Edit & try to change to intended one, F18:K33
-> (LibreOffice 5.1.4.2 Mac OS X)change impossible

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: extras/Module_extras.mk extras/Package_tpllayoutimpr.mk extras/Package_tplpresnt.mk extras/source

2016-07-11 Thread Samuel Mehrbrodt 
 dev/null  |binary
 extras/Module_extras.mk   |1 
 extras/Package_tpllayoutimpr.mk   |   25 --
 extras/Package_tplpresnt.mk   |   10 
 extras/source/templates/presnt/AbstractGreen.otp  |binary
 extras/source/templates/presnt/AbstractRed.otp|binary
 extras/source/templates/presnt/AbstractYellow.otp |binary
 extras/source/templates/presnt/BrightBlue.otp |binary
 extras/source/templates/presnt/DNA.otp|binary
 extras/source/templates/presnt/Inspiration.otp|binary
 extras/source/templates/presnt/LushGreen.otp  |binary
 extras/source/templates/presnt/Metropolis.otp |binary
 extras/source/templates/presnt/Sunset.otp |binary
 extras/source/templates/presnt/Vintage.otp|binary
 14 files changed, 10 insertions(+), 26 deletions(-)

New commits:
commit 24e2ee04ff33bebd7ce426f8d927f43ad8497b22
Author: Samuel Mehrbrodt 
Date:   Mon Jul 11 21:46:54 2016 +0200

Move all Impress Templates in one folder

Change-Id: Ifad82946403f11a44147d2569063bb4af635393c
Reviewed-on: https://gerrit.libreoffice.org/27126
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/extras/Module_extras.mk b/extras/Module_extras.mk
index 3a8fe3d..b08c47a 100644
--- a/extras/Module_extras.mk
+++ b/extras/Module_extras.mk
@@ -31,7 +31,6 @@ $(eval $(call gb_Module_add_targets,extras,\
Package_labels \
$(if $(filter WNT,$(OS)),Package_newfiles) \
Package_palettes \
-   Package_tpllayoutimpr \
Package_tplofficorr \
Package_tploffimisc \
Package_tplpresnt \
diff --git a/extras/Package_tpllayoutimpr.mk b/extras/Package_tpllayoutimpr.mk
deleted file mode 100644
index 32c3bd5..000
--- a/extras/Package_tpllayoutimpr.mk
+++ /dev/null
@@ -1,25 +0,0 @@
-# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-
-$(eval $(call 
gb_Package_Package,extras_tpllayoutimpr,$(SRCDIR)/extras/source/templates/layout))
-
-$(eval $(call 
gb_Package_add_files,extras_tpllayoutimpr,$(LIBO_SHARE_FOLDER)/template/common/layout,\
-   AbstractGreen.otp \
-   AbstractRed.otp \
-   AbstractYellow.otp \
-   BrightBlue.otp \
-   DNA.otp \
-   Inspiration.otp \
-   LushGreen.otp \
-   Metropolis.otp \
-   Sunset.otp \
-   Vintage.otp \
-))
-
-# vim: set noet sw=4 ts=4:
diff --git a/extras/Package_tplpresnt.mk b/extras/Package_tplpresnt.mk
index 5f36a8c..d86082f 100644
--- a/extras/Package_tplpresnt.mk
+++ b/extras/Package_tplpresnt.mk
@@ -10,6 +10,16 @@
 $(eval $(call 
gb_Package_Package,extras_tplpresnt,$(SRCDIR)/extras/source/templates/presnt))
 
 $(eval $(call 
gb_Package_add_files,extras_tplpresnt,$(LIBO_SHARE_FOLDER)/template/common/presnt,\
+   AbstractGreen.otp \
+   AbstractRed.otp \
+   AbstractYellow.otp \
+   BrightBlue.otp \
+   DNA.otp \
+   Inspiration.otp \
+   LushGreen.otp \
+   Metropolis.otp \
+   Sunset.otp \
+   Vintage.otp \
Alizarin.otp \
Focus.otp \
Impress.otp \
diff --git a/extras/source/templates/layout/AbstractGreen.otp 
b/extras/source/templates/presnt/AbstractGreen.otp
similarity index 100%
rename from extras/source/templates/layout/AbstractGreen.otp
rename to extras/source/templates/presnt/AbstractGreen.otp
diff --git a/extras/source/templates/layout/AbstractRed.otp 
b/extras/source/templates/presnt/AbstractRed.otp
similarity index 100%
rename from extras/source/templates/layout/AbstractRed.otp
rename to extras/source/templates/presnt/AbstractRed.otp
diff --git a/extras/source/templates/layout/AbstractYellow.otp 
b/extras/source/templates/presnt/AbstractYellow.otp
similarity index 100%
rename from extras/source/templates/layout/AbstractYellow.otp
rename to extras/source/templates/presnt/AbstractYellow.otp
diff --git a/extras/source/templates/layout/BrightBlue.otp 
b/extras/source/templates/presnt/BrightBlue.otp
similarity index 100%
rename from extras/source/templates/layout/BrightBlue.otp
rename to extras/source/templates/presnt/BrightBlue.otp
diff --git a/extras/source/templates/layout/DNA.otp 
b/extras/source/templates/presnt/DNA.otp
similarity index 100%
rename from extras/source/templates/layout/DNA.otp
rename to extras/source/templates/presnt/DNA.otp
diff --git a/extras/source/templates/layout/Inspiration.otp 
b/extras/source/templates/presnt/Inspiration.otp
similarity index 100%
rename from extras/source/templates/layout/Inspiration.otp
rename to extras/source/templates/presnt/Inspiration.otp
diff --git

[Libreoffice-commits] core.git: extras/Package_tplpresnt.mk extras/source

2016-07-11 Thread Samuel Mehrbrodt 
 extras/Package_tplpresnt.mk  |1 +
 extras/source/templates/presnt/Vivid.otp |binary
 2 files changed, 1 insertion(+)

New commits:
commit e75d38367a7b502a6f98fceb2a9cdc0ab52902f3
Author: Samuel Mehrbrodt 
Date:   Mon Jul 11 21:44:11 2016 +0200

Impress: Add new template "Vivid"

* From 
https://wiki.documentfoundation.org/Design/Whiteboards/Templates_for_LibreOffice_5.0
* Submitted under CC0
* Slightly modified by me

Change-Id: I4eab5a2a7314d355c20a13bb8ece8e005f31ab35
Reviewed-on: https://gerrit.libreoffice.org/27125
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/extras/Package_tplpresnt.mk b/extras/Package_tplpresnt.mk
index 1f76e59..5f36a8c 100644
--- a/extras/Package_tplpresnt.mk
+++ b/extras/Package_tplpresnt.mk
@@ -14,6 +14,7 @@ $(eval $(call 
gb_Package_add_files,extras_tplpresnt,$(LIBO_SHARE_FOLDER)/templat
Focus.otp \
Impress.otp \
Midnightblue.otp \
+   Vivid.otp \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/extras/source/templates/presnt/Vivid.otp 
b/extras/source/templates/presnt/Vivid.otp
new file mode 100644
index 000..22b90bb
Binary files /dev/null and b/extras/source/templates/presnt/Vivid.otp differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 42092] SVG vector graphics exported as bitmaps to PDF

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=42092

Michael Stahl  changed:

   What|Removed |Added

  Attachment #71094|application/vnd.oasis.opend |application/pdf
  mime type|ocument.text|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47267] LibreOffice crashes on opening file saved in OpenOffice

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=47267

Michael Stahl  changed:

   What|Removed |Added

  Attachment #58361|application/vnd.oasis.opend |application/octet-stream
  mime type|ocument.text|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62310] ODT that crashes Writer

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=62310

Michael Stahl  changed:

   What|Removed |Added

  Attachment #76499|application/vnd.oasis.opend |text/html
  mime type|ocument.text|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78260] VIEWING: The file seems corrupted

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=78260

Michael Stahl  changed:

   What|Removed |Added

  Attachment #98420|application/vnd.oasis.opend |application/octet-stream
  mime type|ocument.text|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100857] New: Animations only "appear". Don't work as described.

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100857

Bug ID: 100857
   Summary: Animations only "appear". Don't work as described.
   Product: LibreOffice
   Version: 5.1.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: treehaven2...@hotmail.com

Created attachment 126172
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126172=edit
Presentation showing the bug

Seen this on 2 machines, one running 5.1.3.2, the other 5.1.2.4. Had a nice
demo of "before" and "after" when I updated a machine which had been running
5.0.6 (I think) to 5.1.4.2. The animations worked fine before updating.

A demo file is attached.

Recently read about the the PR about the 92,000 documents used in automated
testing. However I'm not sure it is very feasible to test automatically for 
bugs like the one reported here. As a regular user of Impress, I have run into
a few bugs now, all of which are about failures in the rendering of the
presentation. Is there a weakness in the test procedure relying too much on
automation? I would think there ought to be a test presentation containing all
the effects users might employ, including all the animations, or at least a
reresentative sample.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100841] Dragging a cell's frame to Fill Series, etc - no longer shows a tooltip indicating currently reached value

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100841

--- Comment #3 from db0...@gmail.com ---
hello - still occurs on XFCE and KDE. also isn't affected by theme or anything
in the Options I've found (incl h/w accel, etc.)

did aptitude reinstall -calc and -core also to no avail.

What can I do to help diagnose this? e.g. any configs/logs that might be useful
to upload. don't really want to have to do a full reinstall but will if needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100538] Find & Replace makes replacement when it shouldn't, and Close button stops working

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100538

Caolán McNamara  changed:

   What|Removed |Added

 CC||vmik...@collabora.co.uk

--- Comment #8 from Caolán McNamara  ---
I imagine the dialog doesn't close because its close button calls
rBindings.Execute( SID_SEARCH_DLG ); and the same reason that you can't launch
the search and replace dialog from inside the drawing box means you can't
cancel it when the cursor is in there.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/kendy/testcl' - Repository.mk sc/source

2016-07-11 Thread Michael Meeks 
 Repository.mk |1 +
 sc/source/core/opencl/cl-test.ods |binary
 2 files changed, 1 insertion(+)

New commits:
commit c6cce7de6dc8fdddf1a307e26a65b387ffa92b84
Author: Michael Meeks 
Date:   Mon Jul 11 20:33:00 2016 +0100

Add initial cl validation / sheet.

The concept here is that we test OpenCL's stability and accuracy
before we start to use it for a given driver version. This sheet
is a minimal set of that - it requires a very short formula group
length, and combines many CL functions into formulae to test more.

The structure, in particular the manual squaring / SQRT - is
necessary to stick within the default CL subset, and ensure that
formulae are CL enabled from the root of the dependency tree up.

Change-Id: I5000b08cf0436ad8c0acf7f890f7bef0e514b201

diff --git a/Repository.mk b/Repository.mk
index a07f758..4dcd930 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -837,6 +837,7 @@ $(eval $(call gb_Helper_register_packages_for_install,ooo,\
Pyuno/mailmerge \
)) \
sfx2_classification \
+$(if $(filter OPENCL,$(BUILD_TYPE)),sc_opencl_runtimetest) \
 ))
 
 $(eval $(call gb_Helper_register_packages_for_install,ogltrans,\
diff --git a/sc/source/core/opencl/cl-test.ods 
b/sc/source/core/opencl/cl-test.ods
new file mode 100644
index 000..8380e0b
Binary files /dev/null and b/sc/source/core/opencl/cl-test.ods differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang

2016-07-11 Thread Stephan Bergmann 
 compilerplugins/clang/literaltoboolconversion.cxx |   33 --
 1 file changed, 30 insertions(+), 3 deletions(-)

New commits:
commit 3510a48794ebe5d34364301a0bdaca10e66258dd
Author: Stephan Bergmann 
Date:   Mon Jul 11 21:30:34 2016 +0200

loplugin:literaltoboolconversion: Better heuristic...

to determine code shared between C and C++

Change-Id: Ib1f3892b388ebd6a67cc88831a99dfb4ccdfbc2f

diff --git a/compilerplugins/clang/literaltoboolconversion.cxx 
b/compilerplugins/clang/literaltoboolconversion.cxx
index 26a661e..973527d 100644
--- a/compilerplugins/clang/literaltoboolconversion.cxx
+++ b/compilerplugins/clang/literaltoboolconversion.cxx
@@ -7,6 +7,9 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include 
+#include 
+
 #include "clang/Lex/Lexer.h"
 
 #include "plugin.hxx"
@@ -26,11 +29,17 @@ public:
 
 bool VisitImplicitCastExpr(ImplicitCastExpr const * expr);
 
+bool TraverseLinkageSpecDecl(LinkageSpecDecl * decl);
+
 private:
 bool isFromCIncludeFile(SourceLocation spellingLocation) const;
 
+bool isSharedCAndCppCode(SourceLocation location) const;
+
 void handleImplicitCastSubExpr(
 ImplicitCastExpr const * castExpr, Expr const * subExpr);
+
+unsigned int externCContexts_ = 0;
 };
 
 bool LiteralToBoolConversion::VisitImplicitCastExpr(
@@ -46,6 +55,15 @@ bool LiteralToBoolConversion::VisitImplicitCastExpr(
 return true;
 }
 
+bool LiteralToBoolConversion::TraverseLinkageSpecDecl(LinkageSpecDecl * decl) {
+assert(externCContexts_ != std::numeric_limits::max()); 
//TODO
+++externCContexts_;
+bool ret = RecursiveASTVisitor::TraverseLinkageSpecDecl(decl);
+assert(externCContexts_ != 0);
+--externCContexts_;
+return ret;
+}
+
 bool LiteralToBoolConversion::isFromCIncludeFile(
 SourceLocation spellingLocation) const
 {
@@ -56,6 +74,17 @@ bool LiteralToBoolConversion::isFromCIncludeFile(
 .endswith(".h"));
 }
 
+bool LiteralToBoolConversion::isSharedCAndCppCode(SourceLocation location) 
const
+{
+// Assume that code is intended to be shared between C and C++ if it comes
+// from an include file ending in .h, and is either in an extern "C" 
context
+// or the body of a macro definition:
+return
+
isFromCIncludeFile(compiler.getSourceManager().getSpellingLoc(location))
+&& (externCContexts_ != 0
+|| compiler.getSourceManager().isMacroBodyExpansion(location));
+}
+
 void LiteralToBoolConversion::handleImplicitCastSubExpr(
 ImplicitCastExpr const * castExpr, Expr const * subExpr)
 {
@@ -99,9 +128,7 @@ void LiteralToBoolConversion::handleImplicitCastSubExpr(
 loc = compiler.getSourceManager().getImmediateExpansionRange(
 loc).first;
 }
-if (isFromCIncludeFile(
-compiler.getSourceManager().getSpellingLoc(loc)))
-{
+if (isSharedCAndCppCode(loc)) {
 return;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - framework/source

2016-07-11 Thread Caolán McNamara 
 framework/source/dispatch/closedispatcher.cxx |9 +
 1 file changed, 9 insertions(+)

New commits:
commit 1bb21a08054d6909725ac46be8a4d6d7e5141d7c
Author: Caolán McNamara 
Date:   Sat Jul 9 21:28:44 2016 +0100

Resolves: tdf#100732 hang closing Print Preview with X-icon on menubar

triggered by change...

commit f9bb13419549d621ffd55d9d81e0732a89560e2e
Author: Juergen Funk 
Date:   Fri May 13 10:42:17 2016 +0200

tdf#99815 use XNotifyingDispatch in sfx2

which allowed the problem introduced by...

commit d0c3c24da2506bff1719a276f2eff34589fa7663
Author: Kohei Yoshida 
Date:   Wed Jun 6 01:28:55 2012 -0400

Check if the system window has a close handler, and if yes, call it.

This allows the close event in the preview window to be handled in a
custom fashion, instead of having it call the normal "close window"
command.

to show up

Change-Id: I5c46fb7a49ae44fd748b5b7192aeb951c7d65191
(cherry picked from commit 903e60753f4cf8fb03e27ed312a699f72ac1649a)
Reviewed-on: https://gerrit.libreoffice.org/27077
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/framework/source/dispatch/closedispatcher.cxx 
b/framework/source/dispatch/closedispatcher.cxx
index a09018f..aa15c28 100644
--- a/framework/source/dispatch/closedispatcher.cxx
+++ b/framework/source/dispatch/closedispatcher.cxx
@@ -186,6 +186,15 @@ void SAL_CALL 
CloseDispatcher::dispatchWithNotification(const css::util::URL&
 {
 // The closing frame has its own close handler.  Call it instead.
 m_pSysWindow->GetCloseHdl().Call(*m_pSysWindow);
+
+aWriteLock.clear();
+// <- SAFE --
+
+implts_notifyResultListener(
+xListener,
+css::frame::DispatchResultState::SUCCESS,
+css::uno::Any());
+
 return;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

2016-07-11 Thread Caolán McNamara 
 svx/source/tbxctrls/tbunosearchcontrollers.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 27ca06cbca5a483695009089a1107dbf55b3b9f5
Author: Caolán McNamara 
Date:   Mon Jul 11 20:21:19 2016 +0100

Fix a SolarMutex assert

take the document of 
https://bugs.documentfoundation.org/attachment.cgi?id=125819
select the text shape and use file->edit and the solarmutex assert happens
inside SetTextToSelected_Impl

so move the mutex up a little

Change-Id: I972c4886a200a87ed10f49e36937defdbf5d9525

diff --git a/svx/source/tbxctrls/tbunosearchcontrollers.cxx 
b/svx/source/tbxctrls/tbunosearchcontrollers.cxx
index 77c7474..dfce497 100644
--- a/svx/source/tbxctrls/tbunosearchcontrollers.cxx
+++ b/svx/source/tbxctrls/tbunosearchcontrollers.cxx
@@ -1166,10 +1166,10 @@ void SAL_CALL FindbarDispatcher::dispatch( const 
css::util::URL& aURL, const css
 vcl::Window* pItemWin = pToolBox->GetItemWindow( i );
 if ( pItemWin )
 {
+SolarMutexGuard aSolarMutexGuard;
 FindTextFieldControl* pFindTextFieldControl = 
dynamic_cast(pItemWin);
 if ( pFindTextFieldControl )
 pFindTextFieldControl->SetTextToSelected_Impl();
-SolarMutexGuard aSolarMutexGuard;
 pItemWin->GrabFocus();
 return;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - vcl/inc vcl/unx

2016-07-11 Thread Caolán McNamara 
 vcl/inc/unx/gtk/gtkframe.hxx  |2 ++
 vcl/unx/gtk/gtksalmenu.cxx|2 +-
 vcl/unx/gtk3/gtk3gtkframe.cxx |9 +++--
 3 files changed, 10 insertions(+), 3 deletions(-)

New commits:
commit 264a254efd60e147c4e6580f950307478f9a593f
Author: Caolán McNamara 
Date:   Mon Jun 27 11:12:20 2016 +0100

Resolves: rhbz#1342823 toolbar menus popdown immediately

Change-Id: I9cecf50fb85d84e108ccc23d22bf97d2ac510a9b
(cherry picked from commit f7c888994db744396c69aa1be720c2089ada5798)
Reviewed-on: https://gerrit.libreoffice.org/26698
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index 4677923..2b5dc55 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -538,6 +538,8 @@ public:
 
 static void KeyCodeToGdkKey(const vcl::KeyCode& rKeyCode,
 guint* pGdkKeyCode, GdkModifierType *pGdkModifiers);
+
+static guint32  GetLastInputEventTime();
 };
 
 #define OOO_TYPE_FIXED ooo_fixed_get_type()
diff --git a/vcl/unx/gtk/gtksalmenu.cxx b/vcl/unx/gtk/gtksalmenu.cxx
index 2e44f76..873ce39 100644
--- a/vcl/unx/gtk/gtksalmenu.cxx
+++ b/vcl/unx/gtk/gtksalmenu.cxx
@@ -360,7 +360,7 @@ bool GtkSalMenu::ShowNativePopupMenu(FloatingWindow* pWin, 
const Rectangle& rRec
 else
 {
 nButton = 0;
-nTime = gtk_get_current_event_time();
+nTime = GtkSalFrame::GetLastInputEventTime();
 }
 
 VclPtr xParent = pWin->ImplGetWindowImpl()->mpRealParent;
diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index 2320356..e8d12e3 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -2018,6 +2018,11 @@ void GtkSalFrame::SetAlwaysOnTop( bool bOnTop )
 
 static guint32 nLastUserInputTime = GDK_CURRENT_TIME;
 
+guint32 GtkSalFrame::GetLastInputEventTime()
+{
+return nLastUserInputTime;
+}
+
 static void UpdateLastInputEventTime(guint32 nUserInputTime)
 {
 nLastUserInputTime = nUserInputTime;
@@ -2032,9 +2037,9 @@ void GtkSalFrame::ToTop( SalFrameToTop nFlags )
 else if( IS_WIDGET_MAPPED( m_pWindow ) )
 {
 if (!(nFlags & SalFrameToTop::GrabFocusOnly))
-gtk_window_present_with_time(GTK_WINDOW(m_pWindow), 
nLastUserInputTime);
+gtk_window_present_with_time(GTK_WINDOW(m_pWindow), 
GetLastInputEventTime());
 else
-gdk_window_focus(widget_get_window(m_pWindow), 
nLastUserInputTime);
+gdk_window_focus(widget_get_window(m_pWindow), 
GetLastInputEventTime());
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - cui/source

2016-07-11 Thread Caolán McNamara 
 cui/source/options/optpath.cxx |   19 +--
 1 file changed, 9 insertions(+), 10 deletions(-)

New commits:
commit 18b904faafb756fd28d40467153d191122f6a731
Author: Caolán McNamara 
Date:   Tue Jul 5 10:16:51 2016 +0100

Resolves: rhbz#1352835 path options doesn't promptly destroy folder picker

Change-Id: I5133f63fd92f384221fa2812c6e2a0e7f3b37ac1
(cherry picked from commit 3bbc0574d78d129359638b74612de2f93419eeb0)
Reviewed-on: https://gerrit.libreoffice.org/26941
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/cui/source/options/optpath.cxx b/cui/source/options/optpath.cxx
index 2a52540..7c2de67 100644
--- a/cui/source/options/optpath.cxx
+++ b/cui/source/options/optpath.cxx
@@ -633,11 +633,12 @@ IMPL_LINK_NOARG_TYPED(SvxPathTabPage, PathHdl_Impl, 
Button*, void)
 else
 {
 short nRet = xFolderPicker->execute();
-if ( ExecutableDialogResults::OK != nRet )
-return;
-
-OUString sFolder( xFolderPicker->getDirectory() );
-ChangeCurrentEntry( sFolder );
+if (nRet == ExecutableDialogResults::OK)
+{
+OUString sFolder(xFolderPicker->getDirectory());
+ChangeCurrentEntry(sFolder);
+}
+xFolderPicker.clear();
 }
 }
 catch( Exception& )
@@ -721,19 +722,17 @@ IMPL_LINK_TYPED( SvxPathTabPage, HeaderEndDrag_Impl, 
HeaderBar*, pBar, void )
 }
 }
 
-
 IMPL_LINK_TYPED( SvxPathTabPage, DialogClosedHdl, DialogClosedEvent*, pEvt, 
void )
 {
-if ( RET_OK == pEvt->DialogResult )
+assert(xFolderPicker.is() && "SvxPathTabPage::DialogClosedHdl(): no folder 
picker");
+if (RET_OK == pEvt->DialogResult)
 {
-DBG_ASSERT( xFolderPicker.is(), "SvxPathTabPage::DialogClosedHdl(): no 
folder picker" );
-
 OUString sURL = xFolderPicker->getDirectory();
 ChangeCurrentEntry( sURL );
 }
+xFolderPicker.clear();
 }
 
-
 void SvxPathTabPage::GetPathList(
 sal_uInt16 _nPathHandle, OUString& _rInternalPath,
 OUString& _rUserPath, OUString& _rWritablePath, bool& _rReadOnly )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100856] New: "More..." menu item in the language menus shows the global preferences dialog instead of a simple dedicated dialog , which is confusing

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100856

Bug ID: 100856
   Summary: "More..." menu item in the language menus shows the
global preferences dialog instead of a simple
dedicated dialog, which is confusing
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nekoh...@gmail.com

On a related but different note from bug #100855 and bug #96988, if you select
"Tools > Language > For all text > More..." you end up with LibreOffice
Writer's global preferences dialog... which is quite confusing because I
instantly recognize it as the global preferences dialog, with its zillion
options irrelevant to the task at hand, and think "but I don't want to set
global preferences, I just want to pick a language for this particular
document!"

There's a checkbox "For the current document only" but it's buried under a
header that says "Langues par défaut des documents" in French, which
semantically translates to "Default language for [new] documents", so when you
see that, your eyes just ignore the whole section.

The thing is needlessly complex overall. What would be helpful instead is just
a very simple dedicated language picker dialog, like this:

--
| Choose a language X|
--
||
| [ Search...  ] |
||
| || |
| || |
| || |
| || |
| || |
| || |
| || |
| || |
| || |
| || |
| || |
||
|  ( Cancel ) ( OK ) |
||
--

Bonus point: this same dialog could then also be used for:

- Tools > Language > For selection > More...
- Tools > Language > For paragraph > More...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100573] Display scrolls when opening Auto Filter

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100573

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0|target:5.3.0 target:5.2.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/kendy/testcl' - 3 commits - desktop/Library_sofficeapp.mk desktop/source opencl/source sc/Module_sc.mk sc/Package_opencl.mk

2016-07-11 Thread Jan Holesovsky 
 desktop/Library_sofficeapp.mk   |1 
 desktop/source/app/app.cxx  |   78 
 opencl/source/openclwrapper.cxx |2 -
 sc/Module_sc.mk |1 
 sc/Package_opencl.mk|   16 
 5 files changed, 97 insertions(+), 1 deletion(-)

New commits:
commit 0bf3eac65602dae1cd6c6df77d22c53b5c37a1a2
Author: Jan Holesovsky 
Date:   Mon Jul 11 19:16:47 2016 +0200

Make this conditional.

Change-Id: I93adf7c2acdc8fab8bbe0c92d841b81455caf89a

diff --git a/desktop/Library_sofficeapp.mk b/desktop/Library_sofficeapp.mk
index 046da38..3154a7b 100644
--- a/desktop/Library_sofficeapp.mk
+++ b/desktop/Library_sofficeapp.mk
@@ -57,7 +57,7 @@ $(eval $(call gb_Library_use_libraries,sofficeapp,\
 deploymentmisc \
 editeng \
 i18nlangtag \
-opencl \
+$(if $(filter OPENCL,$(BUILD_TYPE)),opencl) \
 sal \
 salhelper \
 sb \
commit e392afd0842b091190f6c6e0707ea0b72c69f467
Author: Jan Holesovsky 
Date:   Mon Jul 11 17:43:51 2016 +0200

Install the cl-test.ods to program/opencl and use it for the test.

Change-Id: I1ee619a8ac3eee92912d37b47bb82d4550e4c42b

diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index b5fe0ca..cc05d74 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -1351,8 +1351,10 @@ void testOpenCLCompute(const Reference< XDesktop2 > 
)
 aArgs[0].Name = "Hidden";
 aArgs[0].Value = makeAny(true);
 
-xComponent.set(xLoader->loadComponentFromURL("file:///tmp/cl-test.ods",
- "_blank", 0, aArgs));
+OUString aUrl("$BRAND_BASE_DIR/" LIBO_ETC_FOLDER 
"/opencl/cl-test.ods");
+rtl::Bootstrap::expandMacros(aUrl);
+
+xComponent.set(xLoader->loadComponentFromURL(aUrl, "_blank", 0, 
aArgs));
 
 // What an unpleasant API to use.
 css::uno::Reference< css::sheet::XCalculatable > xCalculatable( 
xComponent, css::uno::UNO_QUERY_THROW);
diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index 9c331bb..392fbe0 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -15,6 +15,7 @@ $(eval $(call gb_Module_add_targets,sc,\
Library_scd \
Library_scfilt \
$(call gb_Helper_optional,DESKTOP,Library_scui) \
+   $(call gb_Helper_optional,OPENCL,Package_opencl) \
 ))
 
 $(eval $(call gb_Module_add_l10n_targets,sc,\
diff --git a/sc/Package_opencl.mk b/sc/Package_opencl.mk
new file mode 100644
index 000..ef1579f
--- /dev/null
+++ b/sc/Package_opencl.mk
@@ -0,0 +1,16 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call 
gb_Package_Package,sc_opencl_runtimetest,$(SRCDIR)/sc/source/core/opencl))
+
+$(eval $(call 
gb_Package_add_files,sc_opencl_runtimetest,$(LIBO_ETC_FOLDER)/opencl,\
+   cl-test.ods \
+))
+
+# vim: set noet sw=4 ts=4:
commit cbd73306dd02aa65329d98160210160f6fef1ad1
Author: Michael Meeks 
Date:   Mon Jul 11 15:12:38 2016 +0100

First cut of startup test OpenCL compute ...

Change-Id: I4c42585f8b9553c39265a4d73568ce51114ea396
FIXME: needs to:
   a) only do this on driver / version change.
   b) actually work ;-)

diff --git a/desktop/Library_sofficeapp.mk b/desktop/Library_sofficeapp.mk
index 04bc491..046da38 100644
--- a/desktop/Library_sofficeapp.mk
+++ b/desktop/Library_sofficeapp.mk
@@ -57,6 +57,7 @@ $(eval $(call gb_Library_use_libraries,sofficeapp,\
 deploymentmisc \
 editeng \
 i18nlangtag \
+opencl \
 sal \
 salhelper \
 sb \
diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index fab48e1..b5fe0ca 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -75,6 +75,12 @@
 #include 
 #include 
 
+#include 
+#include 
+#include 
+#include 
+#include 
+
 #include 
 #include 
 #include 
@@ -109,6 +115,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "langselect.hxx"
 
@@ -1326,6 +1333,70 @@ void Desktop::DoExecute()
 #endif
 }
 
+#if HAVE_FEATURE_OPENCL
+void testOpenCLCompute(const Reference< XDesktop2 > )
+{
+if (getenv("SAL_DISABLE_OPENCL"))
+return;
+
+css::uno::Reference< css::lang::XComponent > xComponent;
+
+SAL_INFO("opencl", "Initiating test of OpenCL device");
+try {
+OpenCLZone aZone;
+css::uno::Reference< css::frame::XComponentLoader > xLoader(xDesktop, 
css::uno::UNO_QUERY_THROW);
+
+// FIXME: invisible, read-only etc.
+css::uno::Sequence< css::beans::PropertyValue > aArgs(1);
+aArgs[0].Name = "Hidden";
+aArgs[0].Value = makeAny(true);
+
+

[Libreoffice-bugs] [Bug 100573] Display scrolls when opening Auto Filter

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100573

--- Comment #10 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9bf8a970176b16d6bbd00199fd1d9ba6e73b35b5=libreoffice-5-2

Resolves: tdf#100573 revert original attempt to resolves tdf#46637

It will be available in 5.2.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source

2016-07-11 Thread Caolán McNamara 
 sc/source/ui/view/tabvwsh3.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9bf8a970176b16d6bbd00199fd1d9ba6e73b35b5
Author: Caolán McNamara 
Date:   Mon Jul 11 16:22:19 2016 +0100

Resolves: tdf#100573 revert original attempt to resolves tdf#46637

Revert "tdf#46637 - Make partially visible cells fully visible on mouse 
click"

this can be safely backported to 5-2 series as a standalone revert

This reverts commit 08f6107edf3021c31571769e45f7c4b5267d6924.

(cherry picked from commit 829dc5ddc53bf0c8e371dd5dd32a7edbf24cdbbf)

Change-Id: I08838aee18a31fee2f7c50eb63bff01714429e62
Reviewed-on: https://gerrit.libreoffice.org/27118
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/sc/source/ui/view/tabvwsh3.cxx b/sc/source/ui/view/tabvwsh3.cxx
index 3a1d101..fd8246e 100644
--- a/sc/source/ui/view/tabvwsh3.cxx
+++ b/sc/source/ui/view/tabvwsh3.cxx
@@ -376,7 +376,7 @@ void ScTabViewShell::Execute( SfxRequest& rReq )
 if( bUnmark )
 {
 MoveCursorAbs( nCol, nRow,
-SC_FOLLOW_LINE, false, false );
+SC_FOLLOW_NONE, false, false );
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100855] New: If the document's text is selected, choices to set the " whole document" 's spellchecking language are not the same

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100855

Bug ID: 100855
   Summary: If the document's text is selected, choices to set the
"whole document" 's spellchecking language are not the
same
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nekoh...@gmail.com

Created attachment 126171
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126171=edit
demonstration of the problem

My system's locale is fr_CA.UTF8 (French Canadian).

In Writer, if I select text before going into "Tools > Language > For entire
text", there will be no menu entry for "English (U.S.A.)", only French (Canada)
and French (France).

However, if I don't select anything, "English (U.S.A.)" magically appears in
the available choices.

See the attached screencast with the latest LibreOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100854] New: persian and arabic diacritics are not accessible by using arrow keys on keyboard.

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100854

Bug ID: 100854
   Summary: persian and arabic diacritics are not accessible by
using arrow keys on keyboard.
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nasrinkhaks...@gmail.com

hi every one. 
i have a very critical problem in using libreoffice. 
i became familiar with your project two years ago. 
i am realy advocater of opensource projects, 
but i am blind, i can only use keyboard and unfortunately diacritics in persian
and arabic is not accessible by using left and right arrow keys. 
this problem occurs with libreoffice, openoffice, mozilla firefox and also
windows notepad. 
it does not happen with internet explorer, wordpad and also microsoft word. 
when i use the arrow keys to navigate letter by letter, unfortunately these
opensource projects dont consider diacritics and my screen reader nvda only
reads the letters, not diacritics. 
please for example copy this word and try to use the arrow keys with both
libreoffice writer and also microsoft word to see the result. 
i cant buy microsoft office and i hate its ribon menus. 
for the sanctions in iran and some other countries, we cant buy microsoft
office legally. 
and also, i love libreoffice and i dont want to use other programs. 
i invoke you and sincerely i request you the developers and programmers of
libreoffice to guide me in this regard. 
i strove very hard trying to change settings and asked help from many peoples. 
but unfortunately without any result. 
it becomes a great desire and wish for me to read and write documents with
diacritics without this problem and i dont know what should i do and how to
achieve this goal.
i pray for you and request devine mercy and blessings for you. please help me
for the solution!
here you are two words for example

شُكر

الْغَفورُ

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96505] Get rid of cargo cult "long" integer literals

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96505

--- Comment #15 from Nadith Malinda  ---
is this still open..if so i can fix this.
can you show me good starting pointers

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/uiconfig

2016-07-11 Thread Szymon Kłos 
 sw/uiconfig/swriter/ui/notebookbar.ui | 1315 +++---
 1 file changed, 760 insertions(+), 555 deletions(-)

New commits:
commit 0240927c82822059e2a8e42f29b2766f2ff6c73d
Author: Szymon Kłos 
Date:   Mon Jul 11 19:38:52 2016 +0200

GSoC notebookbar: added priorities in all Writer tabs

Change-Id: Ib9ac09392f0e50cdd5577b579e5f19d362a53a0e

diff --git a/sw/uiconfig/swriter/ui/notebookbar.ui 
b/sw/uiconfig/swriter/ui/notebookbar.ui
index 964075e..107289a 100644
--- a/sw/uiconfig/swriter/ui/notebookbar.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar.ui
@@ -219,7 +219,7 @@
 True
 True
 
-  
+  
 True
 False
 6
@@ -288,14 +288,28 @@
   
 
 
-  
+  
 True
-True
-True
-.uno:ExportTo
-ExportToImg
-none
-top
+False
+
+  
+True
+True
+True
+.uno:ExportTo
+ExportToImg
+none
+top
+  
+  
+False
+True
+0
+  
+
+
+  
+
   
   
 False
@@ -304,14 +318,28 @@
   
 
 
-  
+  
 True
-True
-True
-.uno:ExportToPDF
-ExportToPDFImg
-none
-top
+False
+
+  
+True
+True
+True
+.uno:ExportToPDF
+ExportToPDFImg
+none
+top
+  
+  
+False
+True
+0
+  
+
+
+  
+
   
   
 False
@@ -336,13 +364,27 @@
   
 
 
-  
+  
 True
-True
-True
-.uno:Signature
-none
-top
+False
+
+  
+True
+True
+True
+.uno:Signature
+none
+top
+  
+  
+False
+True
+0
+  
+
+
+  
+
   
   
 False
@@ -1419,7 +1461,7 @@
   
 
 
-  
+  
 True
 False
 
@@ -1457,6 +1499,9 @@
 2
   
 
+
+  
+
   
   
 False
@@ -1506,27 +1551,27 @@
   
 
 
-  
+  
+True
+True
+True
+.uno:InsertGraphic
+InsertGraphicImg
+none
+top
+True
+  
+  
+False
+True
+4
+  
+
+
+  
 True
 False
 
-  
-True
-True
-True
-.uno:InsertGraphic
-InsertGraphicImg
-none
-top
-True
-  
-  
-False
-

[Libreoffice-bugs] [Bug 100726] Improve readability of OUString concatanations

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100726

--- Comment #5 from Nadith Malinda  ---
Is there still the bug is there.or all the places are fully readable and
efficient coded...if not i would like to join also to fix this bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100853] Improving the quality of checkboxes in the menu

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100853

--- Comment #2 from kompilainenn <79045_79...@mail.ru> ---
Created attachment 126170
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126170=edit
new-new-checkbox-fjr-menu-LO

2 example of checkbox is normal size

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96923] Criteria evaluation of COUNTIF, COUNTIFS, SUMIF, SUMIFS, AVERAGEIF, AVERAGEIFS

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96923

Eike Rathke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Hardware|x86 (IA32)  |All
Version|5.0.3.1 rc  |Inherited From OOo
Summary|Function SUMIFS |Criteria evaluation of
   ||COUNTIF, COUNTIFS, SUMIF,
   ||SUMIFS, AVERAGEIF,
   ||AVERAGEIFS
 Ever confirmed|0   |1
 OS|Windows (All)   |All

--- Comment #14 from Eike Rathke  ---
That at least seems to be consistent among all related functions, COUNTIF,
COUNTIFS, SUMIF, SUMIFS, AVERAGEIF, AVERAGEIFS.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100853] Improving the quality of checkboxes in the menu

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100853

--- Comment #1 from kompilainenn <79045_79...@mail.ru> ---
Created attachment 126169
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126169=edit
new_checkbox_for_menu_LO

in attach new checkbox for menu in LO. format of file is .svg

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96923] Function SUMIFS

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96923

--- Comment #13 from Eike Rathke  ---
Brilliant.. in the sum-range only numeric content is taken (same as in SUM, so
at least consistent there), but in the condition it does not care about numeric
or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Changes to 'private/kendy/testcl'

2016-07-11 Thread Jan Holesovsky 
New branch 'private/kendy/testcl' available with the following commits:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100853] New: Improving the quality of checkboxes in the menu

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100853

Bug ID: 100853
   Summary: Improving the quality of checkboxes in the menu
   Product: LibreOffice
   Version: 5.3.0.0.alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

Created attachment 126168
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126168=edit
Example of bad quality checkboxes in menu LO

see screenshot in attach. Checkboxes is very bad quality in GUI LO on Windows.

I propose to change the look of these checkboxes to a higher quality. probably
only need to replace one image file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98414] Writer 5.0: Crash on exit in mergedlo.dll (with debug, no file or steps)

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=98414

Volko Neitmann  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||volk...@gmx.net
 Resolution|INSUFFICIENTDATA|---
 Ever confirmed|0   |1

--- Comment #5 from Volko Neitmann  ---
I can confirm the bug having happened on my PC (Win 7 Professional x64, LO
5.1.3.2 and LO 5.1.4.2, German localization) twice exactly the same way like
initially reported by Timur.
As on my system the bug also has happened only very occasionally I currently
cannot provide steps to reproduce it.
Interestingly on my machine I can only see that the bug happened by checking
the windows event log, there were no visible error messages popping up the two
times the crash has appeared so far.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96923] Function SUMIFS

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96923

--- Comment #12 from Eike Rathke  ---
Excel in itself is iconsistent. Take for example the formula
=SUMIF($B$3:$B$6,1,$C$3:$C$6) in B16. This apparently evaluates every B3:B6=1
as TRUE and thus sums all values in C3:C6 to 10. But, for
=SUMIF($B$3:$B$6,1,$B$3:$B$6) the result is 2 and not 4 so it either sums only
the numeric values in B3:B6 or only evaluates the numeric values in B3:B6 in
the condition as TRUE. Same for =SUMIF($B$3:$B$6,1)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: extras/source sc/uiconfig sd/uiconfig sw/uiconfig

2016-07-11 Thread Szymon Kłos 
 extras/source/glade/libreoffice-catalog.xml.in |3 
 sc/uiconfig/scalc/ui/notebookbar.ui|  188 ++-
 sd/uiconfig/simpress/ui/notebookbar.ui |  204 +++--
 sw/uiconfig/swriter/ui/notebookbar.ui  |  178 +
 4 files changed, 462 insertions(+), 111 deletions(-)

New commits:
commit 855007f94c28735c954b0ce007e97fe7e26d9203
Author: Szymon Kłos 
Date:   Mon Jul 11 17:41:38 2016 +0200

GSoC notebookbar: File tab

Change-Id: I98640b0b4585b2fe1088b13b07dce82a185fd8bf

diff --git a/extras/source/glade/libreoffice-catalog.xml.in 
b/extras/source/glade/libreoffice-catalog.xml.in
index 71305a0..4d8be37 100644
--- a/extras/source/glade/libreoffice-catalog.xml.in
+++ b/extras/source/glade/libreoffice-catalog.xml.in
@@ -833,5 +833,8 @@
 
+
   
 
diff --git a/sc/uiconfig/scalc/ui/notebookbar.ui 
b/sc/uiconfig/scalc/ui/notebookbar.ui
index 3c1752c..990fcc9 100644
--- a/sc/uiconfig/scalc/ui/notebookbar.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar.ui
@@ -33,6 +33,16 @@
 False
 cmd/lc_editprintarea.png
   
+  
+True
+False
+cmd/lc_exportto.png
+  
+  
+True
+False
+cmd/lc_exportdirecttopdf.png
+  
   
 True
 False
@@ -93,6 +103,16 @@
 False
 cmd/lc_insertsymbol.png
   
+  
+True
+False
+cmd/lc_open.png
+  
+  
+True
+False
+cmd/lc_openremote.png
+  
   
 True
 False
@@ -103,11 +123,26 @@
 False
 cmd/lc_paste.png
   
+  
+True
+False
+cmd/lc_print.png
+  
   
 True
 False
 cmd/lc_protect.png
   
+  
+True
+False
+cmd/lc_saveas.png
+  
+  
+True
+False
+cmd/lc_save.png
+  
   
 True
 False
@@ -168,40 +203,46 @@
 False
 6
 
-  
+  
 True
-False
-vertical
-
-  
-True
-True
-True
-.uno:Open
-none
-0
-  
-  
-False
-True
-0
-  
-
-
-  
-True
-True
-True
-.uno:Save
-none
-0
-  
-  
-False
-True
-1
-  
-
+True
+True
+.uno:OpenFromCalc
+OpenImg
+none
+top
+  
+  
+False
+True
+0
+  
+
+
+  
+True
+True
+True
+.uno:Save
+SaveImg
+none
+top
+  
+  
+False
+True
+1
+  
+
+
+  
+True
+True
+True
+.uno:SaveAs
+SaveAsImg
+none
+top
   
   
 False
@@ -209,6 +250,85 @@
 2
   
 
+
+  
+True
+True
+True
+.uno:OpenRemote
+OpenRemoteImg
+none
+top
+  
+  
+False
+True
+3
+  
+
+
+  
+True
+True
+True
+.uno:ExportTo
+ExportToImg
+none
+top
+  
+  
+False
+True
+4
+  
+
+
+  
+True
+True
+True
+.uno:ExportToPDF
+ExportToPDFImg
+none
+top
+  
+  
+False
+True
+

[Libreoffice-commits] core.git: compilerplugins/clang

2016-07-11 Thread Stephan Bergmann 
 compilerplugins/clang/vclwidgets.cxx |   18 +++---
 1 file changed, 11 insertions(+), 7 deletions(-)

New commits:
commit 744c924754accf77514599f660af52480999c144
Author: Stephan Bergmann 
Date:   Mon Jul 11 18:09:55 2016 +0200

Adapt to Clang 3.4 again

Change-Id: I33c1cee01593b06efca6e1aae283ce80d5cd77be

diff --git a/compilerplugins/clang/vclwidgets.cxx 
b/compilerplugins/clang/vclwidgets.cxx
index ba0c007..ce2bb55 100644
--- a/compilerplugins/clang/vclwidgets.cxx
+++ b/compilerplugins/clang/vclwidgets.cxx
@@ -379,8 +379,10 @@ static void findDisposeAndClearStatements(std::set& aVclPtrFie
 return;
 if (isa(pStmt)) {
 const CompoundStmt *pCompoundStatement = dyn_cast(pStmt);
-for(const Stmt* pStmt : pCompoundStatement->body()) {
-findDisposeAndClearStatements(aVclPtrFields, pStmt);
+for (auto i = pCompoundStatement->body_begin();
+ i != pCompoundStatement->body_end(); ++i)
+{
+findDisposeAndClearStatements(aVclPtrFields, *i);
 }
 return;
 }
@@ -459,22 +461,24 @@ bool VCLWidgets::VisitFunctionDecl( const FunctionDecl* 
functionDecl )
 return true;
 
 std::set aVclPtrFields;
-for(const auto& fieldDecl : pMethodDecl->getParent()->fields()) {
-auto const type = loplugin::TypeCheck(fieldDecl->getType());
+for (auto i = pMethodDecl->getParent()->field_begin();
+ i != pMethodDecl->getParent()->field_end(); ++i)
+{
+auto const type = loplugin::TypeCheck((*i)->getType());
 if (type.Class("VclPtr").GlobalNamespace()) {
-   aVclPtrFields.insert(fieldDecl);
+   aVclPtrFields.insert(*i);
 } else if (type.Class("vector").StdNamespace()
|| type.Class("map").StdNamespace()
|| type.Class("list").StdNamespace()
|| type.Class("set").StdNamespace())
 {
-const RecordType* recordType = 
dyn_cast_or_null(fieldDecl->getType()->getUnqualifiedDesugaredType());
+const RecordType* recordType = 
dyn_cast_or_null((*i)->getType()->getUnqualifiedDesugaredType());
 if (recordType) {
 auto d = 
dyn_cast(recordType->getDecl());
 if (d && d->getTemplateArgs().size()>0) {
 auto const type = 
loplugin::TypeCheck(d->getTemplateArgs()[0].getAsType());
 if (type.Class("VclPtr").GlobalNamespace()) {
-aVclPtrFields.insert(fieldDecl);
+aVclPtrFields.insert(*i);
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100805] FILEOPEN Image shows on a different page

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100805

ekari  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |nadmali...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100844] FILEOPEN Outlines are wrong

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100844

ekari  changed:

   What|Removed |Added

 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100678] FILEOPEN Makes my computer unresponsive when opening

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100678

ekari  changed:

   What|Removed |Added

 Whiteboard||security

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100636] FILEOPEN Opening DOC File displays a page break not existing on original file

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100636

ekari  changed:

   What|Removed |Added

 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100638] FILEOPEN MS word renders 32 pages, LO 36

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100638

ekari  changed:

   What|Removed |Added

 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100639] FILEOPEN Page number doesn't display (MS Publisher)

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100639

ekari  changed:

   What|Removed |Added

 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100673] FILEOPEN Page breaks on the document leading to bad result

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100673

ekari  changed:

   What|Removed |Added

 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100675] FILEOPEN Header image hides a bit of the text

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100675

ekari  changed:

   What|Removed |Added

 Whiteboard|TooBusyNowNeedsFurtherTesti |TooBusyNowNeedsFurtherTesti
   |ngForPossibleRegressionAndP |ngForPossibleRegressionAndP
   |ossibleDuplicates   |ossibleDuplicates,interoper
   ||ability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100679] FILEOPEN Bad formating

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100679

ekari  changed:

   What|Removed |Added

 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100676] FILEOPEN DOC Positions of tables incorrect

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100676

ekari  changed:

   What|Removed |Added

 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100680] FILEOPEN Header is malformed

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100680

ekari  changed:

   What|Removed |Added

 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100704] FILEOPEN Bad rendering on all pages

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100704

ekari  changed:

   What|Removed |Added

 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100805] FILEOPEN Image shows on a different page

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100805

Nadith Malinda  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Nadith Malinda  ---
Hello I'm Nadith,I would like to fix this bug.
I'm new to libreoffice.
I have already built the libreoffice which
"Version: 5.3.0.0.alpha0+
Build ID: d945e97d8f85465f04f59fd197ded2edb56caac3
CPU Threads: 4; OS Version: Linux 4.2; UI Render: default; 
Locale: en-US (en_US.UTF-8) "
So,This will be my first hack if i was assigned
Can someone help me out to pick good starting point to fix this bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100852] crash undoing deletion of a column ...

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100852

--- Comment #3 from Caolán McNamara  ---
despite the horror template foo these tend to be "mundane" bugs FWIW e.g.
2511e272481172b439d167fd8b09d14c755f223d and
dd7a2c95b86d158be8d0637bdff13b9a0ed9954b

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2-0' - sfx2/classification

2016-07-11 Thread Adolfo Jayme Barrientos 
 sfx2/classification/example_sl-SI.xml |   30 +++---
 1 file changed, 15 insertions(+), 15 deletions(-)

New commits:
commit 5179eeacb2c1a96395ce5a0ba988e3e16129fbf1
Author: Adolfo Jayme Barrientos 
Date:   Sun Jun 26 21:32:07 2016 -0500

tdf#100352 Make the watermarks and colored infobar work in Slovenian

The elements  and  must match the values
set in sfx2/source/view/classificationhelper.cxx to work. I moved the
translated words to their proper place.

Change-Id: Id860a375654e371742ba15435d3e73506ef5ef0e
Reviewed-on: https://gerrit.libreoffice.org/26685
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 
(cherry picked from commit 30f81c01d247cdffa0de86367d5f2be80887a251)
Reviewed-on: https://gerrit.libreoffice.org/27076
Tested-by: Jenkins 
Reviewed-by: Andras Timar 
(cherry picked from commit 463fe57dc9527602bc92b0ba74505a1934949dd5)
Reviewed-on: https://gerrit.libreoffice.org/27082
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sfx2/classification/example_sl-SI.xml 
b/sfx2/classification/example_sl-SI.xml
index 822ca6d..1d19836 100644
--- a/sfx2/classification/example_sl-SI.xml
+++ b/sfx2/classification/example_sl-SI.xml
@@ -6,62 +6,62 @@
 urn:example:tscp:1
 
 
-
+
 
 
-Vlada RS
+UK-Cabinet
 0
 
 
-
+
 
 
-Dokument: glava
+Document: Header
 Stopnja zaupnosti: splošno 
poslovanje
 
 
 
-Vlada RS
+UK-Cabinet
 1
 
 
-
+
 
 
-Dokument: glava
+Document: Header
 Stopnja zaupnosti: zaupno
 
 
-Dokument: noga
+Document: Footer
 Ta vsebina ima oznako zaupno. Ne razširjajte 
je zunaj brez  poslovne odobritve.
 
 
-Dokument: vodni žig
+Document: Watermark
 Zaupno
 
 
 
-Vlada RS
+UK-Cabinet
 2
 
 
-
+
 
 
-Dokument: glava
+Document: Header
 Stopnja zaupnosti: interno
 
 
-Dokument: noga
+Document: Footer
 Ta vsebina ima oznako interno. Ne razširjajte 
je izven podjetja.
 
 
-Dokument: vodni žig
+Document: Watermark
 Interno
 
 
 
-Vlada RS
+UK-Cabinet
 3
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100573] Display scrolls when opening Auto Filter

2016-07-11 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100573

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Caolán McNamara  ---
split this into reverting the original code and that's in the queue for 5-2 and
5-2-0 in gerrit then a follow up fix which is an attempt to restore the intent
of the original fix which I'm not 100% confident is safe for 5-2, but it does
seem to work fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2-0' - vcl/source

2016-07-11 Thread Markus Mohrhard 
 vcl/source/opengl/OpenGLContext.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a1caaddab66634c434aadd85ecb75f53d7411c79
Author: Markus Mohrhard 
Date:   Fri Jul 8 09:49:08 2016 +0200

if mpCurrentProgram and pProgram are NULL this crashes

See

http://crashreport.libreoffice.org/stats/signature/OpenGLProgram::Reuse%28%29

Change-Id: I2d1c9d9faff05d0d57a2c217a9ee594b1c22b61d
Reviewed-on: https://gerrit.libreoffice.org/27043
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 
(cherry picked from commit 5d1865293a66eb902237e70877226b7cec31105c)
Reviewed-on: https://gerrit.libreoffice.org/27046
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit d9b6c4878198a1d7582cd98f7affb1d7a57863b9)
Reviewed-on: https://gerrit.libreoffice.org/27072

diff --git a/vcl/source/opengl/OpenGLContext.cxx 
b/vcl/source/opengl/OpenGLContext.cxx
index 86a61e3..ffe5f36 100644
--- a/vcl/source/opengl/OpenGLContext.cxx
+++ b/vcl/source/opengl/OpenGLContext.cxx
@@ -815,7 +815,7 @@ OpenGLProgram* OpenGLContext::UseProgram( const OUString& 
rVertexShader, const O
 
 OpenGLProgram* pProgram = GetProgram( rVertexShader, rFragmentShader, 
preamble );
 
-if (pProgram == mpCurrentProgram)
+if (pProgram && pProgram == mpCurrentProgram)
 {
 VCL_GL_INFO("Context::UseProgram: Reusing existing program " << 
pProgram->Id());
 pProgram->Reuse();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2-0' - sw/source

2016-07-11 Thread Markus Mohrhard 
 sw/source/uibase/app/apphdl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ffda41f416012ed8bc84d71fdd205755a33ce2d6
Author: Markus Mohrhard 
Date:   Sat Jul 9 07:18:06 2016 +0200

tdf#100820: missing nullptr check in writer's apphdl.cxx

Change-Id: I32c22b1e2c6ee23ca712bde7b7f86dada654b802
Reviewed-on: https://gerrit.libreoffice.org/27067
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 
(cherry picked from commit 81889ab4ce49e83ef4914dbff403b839c718a08a)
Reviewed-on: https://gerrit.libreoffice.org/27068
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit 95b3286e2a7f22ab75d63c83e83b874e8b85dd1c)
Reviewed-on: https://gerrit.libreoffice.org/27073

diff --git a/sw/source/uibase/app/apphdl.cxx b/sw/source/uibase/app/apphdl.cxx
index 9bc5ec1..3090ceb 100644
--- a/sw/source/uibase/app/apphdl.cxx
+++ b/sw/source/uibase/app/apphdl.cxx
@@ -239,7 +239,7 @@ void SwModule::StateOther(SfxItemSet )
 case FN_MAILMERGE_EMAIL_DOCUMENTS:
 {
 SwView* pView = ::GetActiveView();
-SwMailMergeConfigItem* pConfigItem = 
pView->GetMailMergeConfigItem();
+SwMailMergeConfigItem* pConfigItem = pView ? 
pView->GetMailMergeConfigItem() : nullptr;
 
 // #i51949# hide e-Mail option if e-Mail is not supported
 // #i63267# printing might be disabled
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sd/source

2016-07-11 Thread David Tardon 
 sd/source/ui/framework/tools/FrameworkHelper.cxx |   57 ---
 1 file changed, 40 insertions(+), 17 deletions(-)

New commits:
commit 570ad81bcbc56b1d20378c6342c27458fcee430c
Author: David Tardon 
Date:   Mon Jul 11 11:59:41 2016 +0200

rhbz#1351292 correctly set edit mode

... when switching between different shells, e.g., from Outline to Slide
master.

Change-Id: I22ef6f6cac73c52fb1bedd97e653b4b57c5a7a24
(cherry picked from commit b0535f3944975c1f6cdadc149d70502843331f86)
Reviewed-on: https://gerrit.libreoffice.org/27110
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sd/source/ui/framework/tools/FrameworkHelper.cxx 
b/sd/source/ui/framework/tools/FrameworkHelper.cxx
index 842df16..ed74b7e 100644
--- a/sd/source/ui/framework/tools/FrameworkHelper.cxx
+++ b/sd/source/ui/framework/tools/FrameworkHelper.cxx
@@ -518,6 +518,41 @@ OUString FrameworkHelper::GetViewURL (ViewShell::ShellType 
eType)
 }
 }
 
+namespace
+{
+
+void updateEditMode(const Reference , FrameworkHelper* const 
pHelper, const EditMode eEMode, bool updateFrameView)
+{
+// Ensure we have the expected edit mode
+// The check is only for DrawViewShell as OutlineViewShell
+// and SlideSorterViewShell have no master mode
+const ::std::shared_ptr pCenterViewShell 
(pHelper->GetViewShell(xView));
+DrawViewShell* pDrawViewShell
+= dynamic_cast(pCenterViewShell.get());
+if (pDrawViewShell != nullptr)
+{
+pCenterViewShell->Broadcast (
+ViewShellHint(ViewShellHint::HINT_CHANGE_EDIT_MODE_START));
+
+pDrawViewShell->ChangeEditMode(eEMode, 
pDrawViewShell->IsLayerModeActive());
+if (updateFrameView)
+pDrawViewShell->WriteFrameViewData();
+
+pCenterViewShell->Broadcast (
+ViewShellHint(ViewShellHint::HINT_CHANGE_EDIT_MODE_END));
+}
+}
+
+void asyncUpdateEditMode(FrameworkHelper* const pHelper, const EditMode eEMode)
+{
+Reference xPaneId (
+
FrameworkHelper::CreateResourceId(framework::FrameworkHelper::msCenterPaneURL));
+Reference xView (pHelper->GetView(xPaneId));
+updateEditMode(xView, pHelper, eEMode, true);
+}
+
+}
+
 void FrameworkHelper::HandleModeChangeSlot (
 sal_uLong nSlotId,
 SfxRequest& rRequest)
@@ -552,7 +587,6 @@ void FrameworkHelper::HandleModeChangeSlot (
 Reference xPaneId (
 CreateResourceId(framework::FrameworkHelper::msCenterPaneURL));
 Reference xView (GetView(xPaneId));
-::std::shared_ptr pCenterViewShell (GetViewShell(xView));
 
 // Compute requested view
 OUString sRequestedView;
@@ -595,26 +629,15 @@ void FrameworkHelper::HandleModeChangeSlot (
 if (!(xView.is() && 
xView->getResourceId()->getResourceURL().equals(sRequestedView)))
 
 {
+const auto xId = CreateResourceId(sRequestedView, msCenterPaneURL);
 mxConfigurationController->requestResourceActivation(
-CreateResourceId(sRequestedView, msCenterPaneURL),
+xId,
 ResourceActivationMode_REPLACE);
+RunOnResourceActivation(xId, std::bind(, this, 
eEMode));
 }
-
-// Ensure we have the expected edit mode
-// The check is only for DrawViewShell as OutlineViewShell
-// and SlideSorterViewShell have no master mode
-DrawViewShell* pDrawViewShell
-= dynamic_cast(pCenterViewShell.get());
-if (pDrawViewShell != nullptr)
+else
 {
-pCenterViewShell->Broadcast (
-ViewShellHint(ViewShellHint::HINT_CHANGE_EDIT_MODE_START));
-
-pDrawViewShell->ChangeEditMode (
-eEMode, pDrawViewShell->IsLayerModeActive());
-
-pCenterViewShell->Broadcast (
-ViewShellHint(ViewShellHint::HINT_CHANGE_EDIT_MODE_END));
+updateEditMode(xView, this, eEMode, false);
 }
 }
 catch (RuntimeException&)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sd/source

2016-07-11 Thread David Tardon 
 sd/source/ui/framework/tools/FrameworkHelper.cxx |   57 ---
 1 file changed, 40 insertions(+), 17 deletions(-)

New commits:
commit 8c319b414ed7b4f9a67077f4b1497dc8975536bc
Author: David Tardon 
Date:   Mon Jul 11 11:59:41 2016 +0200

rhbz#1351292 correctly set edit mode

... when switching between different shells, e.g., from Outline to Slide
master.

Change-Id: I22ef6f6cac73c52fb1bedd97e653b4b57c5a7a24
(cherry picked from commit b0535f3944975c1f6cdadc149d70502843331f86)
Reviewed-on: https://gerrit.libreoffice.org/27108
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sd/source/ui/framework/tools/FrameworkHelper.cxx 
b/sd/source/ui/framework/tools/FrameworkHelper.cxx
index 6b08f37..15740f0 100644
--- a/sd/source/ui/framework/tools/FrameworkHelper.cxx
+++ b/sd/source/ui/framework/tools/FrameworkHelper.cxx
@@ -518,6 +518,41 @@ OUString FrameworkHelper::GetViewURL (ViewShell::ShellType 
eType)
 }
 }
 
+namespace
+{
+
+void updateEditMode(const Reference , FrameworkHelper* const 
pHelper, const EditMode eEMode, bool updateFrameView)
+{
+// Ensure we have the expected edit mode
+// The check is only for DrawViewShell as OutlineViewShell
+// and SlideSorterViewShell have no master mode
+const ::std::shared_ptr pCenterViewShell 
(pHelper->GetViewShell(xView));
+DrawViewShell* pDrawViewShell
+= dynamic_cast(pCenterViewShell.get());
+if (pDrawViewShell != nullptr)
+{
+pCenterViewShell->Broadcast (
+ViewShellHint(ViewShellHint::HINT_CHANGE_EDIT_MODE_START));
+
+pDrawViewShell->ChangeEditMode(eEMode, 
pDrawViewShell->IsLayerModeActive());
+if (updateFrameView)
+pDrawViewShell->WriteFrameViewData();
+
+pCenterViewShell->Broadcast (
+ViewShellHint(ViewShellHint::HINT_CHANGE_EDIT_MODE_END));
+}
+}
+
+void asyncUpdateEditMode(FrameworkHelper* const pHelper, const EditMode eEMode)
+{
+Reference xPaneId (
+
FrameworkHelper::CreateResourceId(framework::FrameworkHelper::msCenterPaneURL));
+Reference xView (pHelper->GetView(xPaneId));
+updateEditMode(xView, pHelper, eEMode, true);
+}
+
+}
+
 void FrameworkHelper::HandleModeChangeSlot (
 sal_uLong nSlotId,
 SfxRequest& rRequest)
@@ -552,7 +587,6 @@ void FrameworkHelper::HandleModeChangeSlot (
 Reference xPaneId (
 CreateResourceId(framework::FrameworkHelper::msCenterPaneURL));
 Reference xView (GetView(xPaneId));
-::std::shared_ptr pCenterViewShell (GetViewShell(xView));
 
 // Compute requested view
 OUString sRequestedView;
@@ -595,26 +629,15 @@ void FrameworkHelper::HandleModeChangeSlot (
 if (!(xView.is() && 
xView->getResourceId()->getResourceURL().equals(sRequestedView)))
 
 {
+const auto xId = CreateResourceId(sRequestedView, msCenterPaneURL);
 mxConfigurationController->requestResourceActivation(
-CreateResourceId(sRequestedView, msCenterPaneURL),
+xId,
 ResourceActivationMode_REPLACE);
+RunOnResourceActivation(xId, std::bind(, this, 
eEMode));
 }
-
-// Ensure we have the expected edit mode
-// The check is only for DrawViewShell as OutlineViewShell
-// and SlideSorterViewShell have no master mode
-DrawViewShell* pDrawViewShell
-= dynamic_cast(pCenterViewShell.get());
-if (pDrawViewShell != nullptr)
+else
 {
-pCenterViewShell->Broadcast (
-ViewShellHint(ViewShellHint::HINT_CHANGE_EDIT_MODE_START));
-
-pDrawViewShell->ChangeEditMode (
-eEMode, pDrawViewShell->IsLayerModeActive());
-
-pCenterViewShell->Broadcast (
-ViewShellHint(ViewShellHint::HINT_CHANGE_EDIT_MODE_END));
+updateEditMode(xView, this, eEMode, false);
 }
 }
 catch (RuntimeException&)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

  1   2   3   >