date:20160831

[Libreoffice-bugs] [Bug 96263] Formatting DOC version missing top part and splitted on two pages vs PDF

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96263

--- Comment #10 from Aron Budea  ---
*** Bug 96277 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96277] [FORMATTING] spacing above and below a table incorrect in specific .doc-file

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96277

Aron Budea  changed:

   What|Removed |Added

   Keywords||bisected
 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #8 from Aron Budea  ---
Closing this, as it was caused by the same commit as bug 96263.

*** This bug has been marked as a duplicate of bug 96263 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96277] [FORMATTING] spacing above and below a table incorrect in specific .doc-file

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96277

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||263

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97037] Rendering of particular Word document with table, frames and backgound graphics completely broken, missing text etc

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97037

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||263

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81263] FILEOPEN: wrong image and shapes position in .doc

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=81263

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||263

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96263] Formatting DOC version missing top part and splitted on two pages vs PDF

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96263

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=81
   ||263,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=97
   ||037,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||277

--- Comment #9 from Aron Budea  ---
Adding 3 other bug reports as related, where bibisection points to the very
same commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96263] Formatting DOC version missing top part and splitted on two pages vs PDF

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96263

Aron Budea  changed:

   What|Removed |Added

   Keywords||bisected
 CC||vmik...@collabora.co.uk
Version|4.5.0.0.alpha0+ Master  |4.4.0.3 release
 Whiteboard||interoperability
   Severity|minor   |normal

--- Comment #8 from Aron Budea  ---
First bad commit verified, adding bisected keyword. Bug still present in
v5.2.1.2. Readjusting severity to normal, as the header table in the document
is missing.
Adding Miklos to CC, please take a look.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97977

jan iversen  changed:

   What|Removed |Added

   Assignee|manuel.defranceschi@studios |libreoffice-b...@lists.free
   |torti.com   |desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95027] Numbered paragraphs applied incorrectly

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95027

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
Version|4.3.0.0.alpha1  |4.0.0.3 release

--- Comment #9 from Aron Budea  ---
Adjusting earliest version, based on bibisect it's probably 3.6, but I tested
with 4.0.0.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101818] Add pasting options similar to Microsoft products

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101818

--- Comment #3 from Marco A.G.Pinto  ---
(In reply to V Stuart Foote from comment #1)
> Created attachment 127104 [details]
> The LibreOffice Paste Special dialog GUI
> 
> Because our existing Paste Special dialog is not "graphical" enough?
> 
> No, this is silly everything does not have to have Icons.

Ahhh... with a right-click... but why not CTR+V as well?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101818] Add pasting options similar to Microsoft products

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101818

--- Comment #2 from Marco A.G.Pinto  ---
(In reply to V Stuart Foote from comment #1)
> Created attachment 127104 [details]
> The LibreOffice Paste Special dialog GUI
> 
> Because our existing Paste Special dialog is not "graphical" enough?
> 
> No, this is silly everything does not have to have Icons.

How do I make the dialogue to appear?

I pressed CTR+V (paste) and it didn't appear.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91332] Saving XLSX File Removes textbox Linked to Other Tabs

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91332

Aron Budea  changed:

   What|Removed |Added

   Keywords||bisected, filter:xlsx
   Priority|medium  |high
 CC||ba...@caesar.elte.hu,
   ||markus.mohrhard@googlemail.
   ||com
 Whiteboard||interoperability

--- Comment #5 from Aron Budea  ---
Based on Markus's comment, it seems like this should be fixed (reversed) as
soon as possible. Raising priority to high.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93579] Formulas Don't Update After Removing Content of Related Cells

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93579

Aron Budea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||ba...@caesar.elte.hu
 Resolution|--- |WORKSFORME

--- Comment #8 from Aron Budea  ---
Seems to be fixed in recent releases of both fresh and still versions (like
5.1.4.2 and 5.2.1.2). Please verify.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96307] FILEOPEN DOC: Incorrect Frame wrapping ( should be None instead of Parallel)

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96307

Aron Budea  changed:

   What|Removed |Added

   Keywords||bisected
 CC||ba...@caesar.elte.hu

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78727] FILEOPEN: DrawingML import/ export filter does not fully work as stated in 4.3 Release Notes

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=78727

Aron Budea  changed:

   What|Removed |Added

   Keywords||bisected

--- Comment #9 from Aron Budea  ---
First bad commit verified, adding bisected keyword. Bug still present in
v5.2.1.2.
The bibisection was done for the second issue, when no spiral is shown.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101795] GTK3: It seems to be impossible to link section to another

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101795

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||jbfa...@libreoffice.org,
   ||momonas...@gmail.com
Version|unspecified |5.2.0.4 release
Summary|It seems to be impossible   |GTK3: It seems to be
   |to link section to another  |impossible to link section
   ||to another
 Ever confirmed|0   |1

--- Comment #2 from Jean-Baptiste Faure  ---
Reproducible in LO 5.2 with the GTK3 vclplugin but not with the GTK2 plugin.
We have the same problem in Calc when inserting a sheet from a csv file. Seems
to be a filepicker related bug.

Maxim, does that ring a bell for you?

@Ludovic: the command 
SAL_USE_VCLPLUGIN="gtk" && libreoffice
I gave you on irc does not work well with LO 5.2.0.4. To switch to vclplugin
GTK2, you need to do 
export SAL_USE_VCLPLUGIN="gtk"
libreoffice
in a terminal.


Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81263] FILEOPEN: wrong image and shapes position in .doc

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=81263

Aron Budea  changed:

   What|Removed |Added

   Keywords||bisected
 CC||ba...@caesar.elte.hu,
   ||vmik...@collabora.co.uk

--- Comment #8 from Aron Budea  ---
First bad commit verified, adding bisected keyword. Bug still present in
v5.2.1.2.
Adding Miklos to CC, please take a look.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101639] [FILEOPEN] Rectangle shown instead of EMF+ image + areas with dotted pattern aren' t filled

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101639

Aron Budea  changed:

   What|Removed |Added

   Keywords||bisected
 CC||mst...@redhat.com

--- Comment #7 from Aron Budea  ---
Since both of the commits are related to Michael Stahl, CC-ing him.
Michael, please take a look.

The commits don't look much related, but the bibisection/bisection clearly
points there.

Commits:
"SchLayoutTabPage: that ctor wants a pointer"
https://cgit.freedesktop.org/libreoffice/core/commit/?id=2d226f4c0b3f95bfdfe7bdcd3fd0ab87a806f4c3

"Repository.mk: cluster the mobile-only stuff together"
https://cgit.freedesktop.org/libreoffice/core/commit/?id=8d3fc64066b157d2e24df57635000f121915793a

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/test

2016-08-31 Thread Ashod Nakashian

 loolwsd/test/TileCacheTests.cpp |   10 +++---
 1 file changed, 3 insertions(+), 7 deletions(-)

New commits:
commit 151d1ff955927d7770337e95d7b464136aa3c9e4
Author: Ashod Nakashian 
Date:   Wed Aug 31 23:55:54 2016 -0400

loolwsd: unittest fixes

Change-Id: I7096b6dabfa59a536809c4e997168c8fce5791f0
Reviewed-on: https://gerrit.libreoffice.org/28578
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/TileCacheTests.cpp b/loolwsd/test/TileCacheTests.cpp
index f3d9564..d2bfa5e 100644
--- a/loolwsd/test/TileCacheTests.cpp
+++ b/loolwsd/test/TileCacheTests.cpp
@@ -443,16 +443,13 @@ void TileCacheTests::testTileInvalidateWriter()
 for (char ch : text)
 {
 sendChar(socket, ch); // Send ordinary characters and wait for 
response -> one tile invalidation for each
-auto response = getResponseMessage(socket, "invalidatetiles:");
-CPPUNIT_ASSERT_MESSAGE("did not receive a invalidatetiles: message as 
expected", !response.empty());
+assertResponseLine(socket, "invalidatetiles:");
 }
 
 text = "\n\n\n";
 for (char ch : text)
 {
-sendChar(socket, ch, skCtrl); // Send 3 Ctrl+Enter -> 3 new pages; I 
see 3 tiles invalidated for each
-assertResponseLine(socket, "invalidatetiles:");
-assertResponseLine(socket, "invalidatetiles:");
+sendChar(socket, ch, skCtrl); // Send 3 Ctrl+Enter -> 3 new pages
 assertResponseLine(socket, "invalidatetiles:");
 }
 
@@ -460,8 +457,7 @@ void TileCacheTests::testTileInvalidateWriter()
 for (char ch : text)
 {
 sendChar(socket, ch);
-auto response = getResponseMessage(socket, "invalidatetiles:");
-CPPUNIT_ASSERT_MESSAGE("did not receive a invalidatetiles: message as 
expected", !response.empty());
+assertResponseLine(socket, "invalidatetiles:");
 }
 
 // While extra invalidates are not desirable, they are inevitable at the 
moment.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp loolwsd/test

2016-08-31 Thread Ashod Nakashian

 loolwsd/DocumentBroker.cpp  |4 ++--
 loolwsd/test/TileCacheTests.cpp |   17 -
 loolwsd/test/httpwstest.cpp |1 +
 3 files changed, 19 insertions(+), 3 deletions(-)

New commits:
commit 534ab15d2fa3fa49740d0fb595232b7d90b39220
Author: Ashod Nakashian 
Date:   Wed Aug 31 23:41:09 2016 -0400

loolwsd: more aggressive test for unresponsive clients

Change-Id: I9daf81661cf03be2ea38b5bc4d9688039912bd8a
Reviewed-on: https://gerrit.libreoffice.org/28577
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index afa8460..2ae259f 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -491,7 +491,7 @@ void DocumentBroker::handleTileRequest(TileDesc& tile,
 #if ENABLE_DEBUG
 const std::string response = tile.serialize("tile:") + " 
renderid=cached\n";
 #else
-const std::string response = tile.serialize("tile:") + "\n";
+const std::string response = tile.serialize("tile:") + '\n';
 #endif
 
 std::vector output;
@@ -501,7 +501,7 @@ void DocumentBroker::handleTileRequest(TileDesc& tile,
 
 assert(cachedTile->is_open());
 cachedTile->seekg(0, std::ios_base::end);
-size_t pos = output.size();
+const auto pos = output.size();
 std::streamsize size = cachedTile->tellg();
 output.resize(pos + size);
 cachedTile->seekg(0, std::ios_base::beg);
diff --git a/loolwsd/test/TileCacheTests.cpp b/loolwsd/test/TileCacheTests.cpp
index 5a2749d..f3d9564 100644
--- a/loolwsd/test/TileCacheTests.cpp
+++ b/loolwsd/test/TileCacheTests.cpp
@@ -234,8 +234,23 @@ void TileCacheTests::testUnresponsiveClient()
 // Pathologically request tiles and fail to read (say slow connection).
 // Meanwhile, verify that others can get all tiles fine.
 // TODO: Track memory consumption to verify we don't buffer too much.
-for (auto x = 0; x < 5; ++x)
+
+std::ostringstream oss;
+for (auto i = 0; i < 1000; ++i)
+{
+oss << Util::encodeId(Util::rng::getNext(), 6);
+}
+
+const auto documentContents = oss.str();
+for (auto x = 0; x < 8; ++x)
 {
+// Invalidate to force re-rendering.
+sendTextFrame(socket2, "uno .uno:SelectAll");
+sendTextFrame(socket2, "uno .uno:Delete");
+assertResponseLine(socket2, "invalidatetiles:", "client2 ");
+sendTextFrame(socket2, "paste mimetype=text/html\n" + 
documentContents);
+assertResponseLine(socket2, "invalidatetiles:", "client2 ");
+
 // Ask for tiles and don't read!
 sendTextFrame(socket1, "tilecombine part=0 width=256 height=256 
tileposx=0,3840,7680,11520,0,3840,7680,11520 
tileposy=0,0,0,0,3840,3840,3840,3840 tilewidth=3840 tileheight=3840");
 
diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index 1dae4c3..f28c5d1 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -689,6 +689,7 @@ void HTTPWSTest::testLargePaste()
 {
 oss << Util::encodeId(Util::rng::getNext(), 6);
 }
+
 const auto documentContents = oss.str();
 std::cerr << "Pasting " << documentContents.size() << " characters 
into document." << std::endl;
 sendTextFrame(socket, "paste mimetype=text/html\n" + documentContents);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101639] [FILEOPEN] Rectangle shown instead of EMF+ image + areas with dotted pattern aren' t filled

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101639

--- Comment #6 from Aron Budea  ---
# bad: [cf6ea17155fabb2a120ba07c150735591ac861d7]
source-hash-3f94c9e9ddfd807b449f3bb9b232cf2041fa12d2
# good: [fc71ac001f16209654d15ef8c1c4018aa55769f5]
source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
git bisect start 'latest' 'oldest'
# bad: [8cf60cc706948588e2f33a6d98b7c55d454e362a]
source-hash-f340f0454627939f1830826fb5cc53a90e6c62a4
git bisect bad 8cf60cc706948588e2f33a6d98b7c55d454e362a
# good: [d9885f526fc7a09cc8f9f8ee643af1b966be24bb]
source-hash-d1465c64c6f64ad8dd25e40cdc69649b24b305ea
git bisect good d9885f526fc7a09cc8f9f8ee643af1b966be24bb
# bad: [c779cf7967f4d14c5e649a5c696b07279d550efd]
source-hash-e9c5022580f14c0ca97503f8b3cc56b530fff174
git bisect bad c779cf7967f4d14c5e649a5c696b07279d550efd
# good: [030e0477638f9d9110ad62f88fd4b881521e0541]
source-hash-1a6e47e3fda10e6d220b67d766ec6fbdfd852b80
git bisect good 030e0477638f9d9110ad62f88fd4b881521e0541
# bad: [c9e7f255b30a0410226b2074702aeba9b49dce13]
source-hash-2d5a7c36ee9ae7ff39d8415f81fb911ff822548e
git bisect bad c9e7f255b30a0410226b2074702aeba9b49dce13
# good: [d0dbfc8071785ec97868d0a98dec934d9eb81e5c]
source-hash-24b6add3774f5f0807c907d5a233ba8ac6f4
git bisect good d0dbfc8071785ec97868d0a98dec934d9eb81e5c
# bad: [eeedb01370e2ca815d6ca73731471c8dd8c7aceb]
source-hash-7f15d2612d450dd430a1288052bc408f3bb1fcd9
git bisect bad eeedb01370e2ca815d6ca73731471c8dd8c7aceb
# good: [fc35228eadbc20de2c2f495e025cb290c1a0f03d]
source-hash-83291976786c9bdf2839c902999d6d4090a5165f
git bisect good fc35228eadbc20de2c2f495e025cb290c1a0f03d
# bad: [d861d5b48f23343069137d4c967452b967a5b997]
source-hash-2b8528a2745bec7909bfe2265d6110a9964eef47
git bisect bad d861d5b48f23343069137d4c967452b967a5b997
# good: [de1324367457e565722f7caca68763dc984e73c1]
source-hash-46cea34638b371570073c0e86f79969753c543ed
git bisect good de1324367457e565722f7caca68763dc984e73c1
# good: [eb40699cbbe85b112be4af03294e3b998a84db83]
source-hash-d7374d4812316a79916956f03c8bd4a281fdbdec
git bisect good eb40699cbbe85b112be4af03294e3b998a84db83
# skip: [defa73f7cca3f65d36e472bf91665c57640009d6]
source-hash-8d3fc64066b157d2e24df57635000f121915793a
git bisect skip defa73f7cca3f65d36e472bf91665c57640009d6
# bad: [37f77f77319e96379ad439deebe8f78453afb79b]
source-hash-2d226f4c0b3f95bfdfe7bdcd3fd0ab87a806f4c3
git bisect bad 37f77f77319e96379ad439deebe8f78453afb79b
# good: [10ccf925651718665cb365d492352ef0bfd496f1]
source-hash-f19b91445546223cb3eacaec2925e51171cb0c85
git bisect good 10ccf925651718665cb365d492352ef0bfd496f1
# only skipped commits left to test
# possible first bad commit: [37f77f77319e96379ad439deebe8f78453afb79b]
source-hash-2d226f4c0b3f95bfdfe7bdcd3fd0ab87a806f4c3
# possible first bad commit: [defa73f7cca3f65d36e472bf91665c57640009d6]
source-hash-8d3fc64066b157d2e24df57635000f121915793a

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/Common.hpp loolwsd/LOOLWSD.cpp

2016-08-31 Thread Ashod Nakashian

 loolwsd/Common.hpp  |1 +
 loolwsd/LOOLWSD.cpp |3 +++
 2 files changed, 4 insertions(+)

New commits:
commit 9b3343aad49637afe944da3ee83062e55217ee48
Author: Ashod Nakashian 
Date:   Wed Aug 31 23:40:42 2016 -0400

loolwsd: Don't block on client sockets and timeout in 1 second

Change-Id: I7fec1054cef25704f898a7a5211abfb398d61bee
Reviewed-on: https://gerrit.libreoffice.org/28576
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/Common.hpp b/loolwsd/Common.hpp
index f76b823..3e5d5e9 100644
--- a/loolwsd/Common.hpp
+++ b/loolwsd/Common.hpp
@@ -20,6 +20,7 @@ constexpr int WSD_SLEEP_SECS = 2;
 constexpr int CHILD_TIMEOUT_SECS = 4;
 constexpr int POLL_TIMEOUT_MS = 1000;
 constexpr int COMMAND_TIMEOUT_MS = 5000;
+constexpr int WS_SEND_TIMEOUT_MICROSECS = 100; // 1 second.
 
 /// Pipe and Socket read buffer size.
 /// Should be large enough for ethernet packets
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 5efbd39..0637bf3 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -905,6 +905,9 @@ public:
 responded = true; // After upgrading to WS we should not set 
HTTP response.
 try
 {
+// First, setup WS options.
+ws->setBlocking(false);
+ws->setSendTimeout(WS_SEND_TIMEOUT_MICROSECS);
 handleGetRequest(request, ws, id);
 }
 catch (const WebSocketErrorMessageException& exc)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ClientSession.cpp loolwsd/ClientSession.hpp loolwsd/DocumentBroker.cpp loolwsd/LOOLWSD.cpp loolwsd/test loolwsd/TileCache.cpp

2016-08-31 Thread Ashod Nakashian

 loolwsd/ClientSession.cpp  |2 --
 loolwsd/ClientSession.hpp  |9 -
 loolwsd/DocumentBroker.cpp |7 ---
 loolwsd/LOOLWSD.cpp|   28 ++--
 loolwsd/TileCache.cpp  |   27 ---
 loolwsd/test/Makefile.am   |1 +
 6 files changed, 31 insertions(+), 43 deletions(-)

New commits:
commit 59eaacd2f87f46c4c4d2963ef54f4d20d346b2d0
Author: Ashod Nakashian 
Date:   Wed Aug 31 23:34:41 2016 -0400

loolwsd: remove tile queue and simplify tile response

Tile queue was used to process canceltiles commands.
Since those are handled by TileCache, there is no need
for queues and the threads that pump them.

But because these queues were also used to buffer between
WSD internals and clients, such that a slow client wouldn't
block WSD while sending back tiles, it is necessary
to reword that logic.
In subsequent commits that will change as well.

With this change not only do we save a thread per client,
but we also reduce latency of tile, and improve typing
responsiveness, by almost 3x or more! Latencies are
down to ~15ms from almost 50ms.

Change-Id: I9bb5856efed28caea9d4e6f94f77b093779e5241
Reviewed-on: https://gerrit.libreoffice.org/28575
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ClientSession.cpp b/loolwsd/ClientSession.cpp
index 40d..c61c574 100644
--- a/loolwsd/ClientSession.cpp
+++ b/loolwsd/ClientSession.cpp
@@ -37,11 +37,9 @@ using Poco::StringTokenizer;
 ClientSession::ClientSession(const std::string& id,
  std::shared_ptr ws,
  std::shared_ptr docBroker,
- std::shared_ptr queue,
  bool readOnly) :
 LOOLSession(id, Kind::ToClient, ws),
 _docBroker(std::move(docBroker)),
-_queue(std::move(queue)),
 _haveEditLock(std::getenv("LOK_VIEW_CALLBACK")),
 _isReadOnly(readOnly),
 _loadFailed(false),
diff --git a/loolwsd/ClientSession.hpp b/loolwsd/ClientSession.hpp
index dc531c8..3a9b1a1 100644
--- a/loolwsd/ClientSession.hpp
+++ b/loolwsd/ClientSession.hpp
@@ -23,7 +23,6 @@ public:
 ClientSession(const std::string& id,
   std::shared_ptr ws,
   std::shared_ptr docBroker,
-  std::shared_ptr queue,
   bool isReadOnly = false);
 
 virtual ~ClientSession();
@@ -60,11 +59,6 @@ public:
 _loadFailed = true;
 }
 
-void sendToInputQueue(const std::string& message)
-{
-_queue->put(message);
-}
-
 std::shared_ptr getDocumentBroker() const { return 
_docBroker; }
 
 private:
@@ -85,9 +79,6 @@ private:
 
 std::shared_ptr _docBroker;
 
-/// The incoming message queue.
-std::shared_ptr _queue;
-
 // If this document holds the edit lock.
 // An edit lock will only allow the current session to make edits,
 // while other session opening the same document can only see
diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index 1e82696..afa8460 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -317,7 +317,6 @@ bool DocumentBroker::sendUnoSave(const bool 
dontSaveIfUnmodified)
 _lastFileModifiedTime.fromEpochTime(0);
 
 // We do not want save to terminate editing mode if we are in edit 
mode now
-
 std::ostringstream oss;
 // arguments init
 oss << "{";
@@ -343,8 +342,10 @@ bool DocumentBroker::sendUnoSave(const bool 
dontSaveIfUnmodified)
 // arguments end
 oss << "}";
 
-Log::debug(".uno:Save arguments: " + oss.str());
-sessionIt.second->sendToInputQueue("uno .uno:Save " + oss.str());
+const auto saveArgs = oss.str();
+Log::trace(".uno:Save arguments: " + saveArgs);
+const auto command = "uno .uno:Save " + saveArgs;
+sessionIt.second->handleInput(command.data(), command.size());
 return true;
 }
 }
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 4d1628b..5efbd39 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -399,7 +399,7 @@ private:
 
 // Load the document.
 std::shared_ptr ws;
-auto session = std::make_shared(id, ws, 
docBroker, nullptr);
+auto session = std::make_shared(id, ws, 
docBroker);
 
 // Request the child to connect to us and add this session.
 auto sessionsCount = docBroker->addSession(session);
@@ -662,10 +662,7 @@ private:
 std::shared_ptr session;
 try
 {
-// For ToClient sessions, we store incoming messages in a queue 
and have a separate
-// thread to pump them. This is to empty

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp

2016-08-31 Thread Ashod Nakashian

 loolwsd/DocumentBroker.cpp |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit ce2309edd814e17be8c148e235d39df3d337ea8d
Author: Ashod Nakashian 
Date:   Wed Aug 31 20:23:56 2016 -0400

loolwsd: log errors while getting file info

Change-Id: I076da575f553f3199fa302f32e8c399b6339fe2c
Reviewed-on: https://gerrit.libreoffice.org/28574
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index a2f1d12..1e82696 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -124,21 +124,24 @@ DocumentBroker::DocumentBroker(const Poco::URI& uriPublic,
 
 const StorageBase::FileInfo DocumentBroker::validate(const Poco::URI& uri)
 {
-Log::info("Validating: " + uri.toString());
+const auto uriString = uri.toString();
+Log::info("Validating: " + uriString);
 try
 {
 auto storage = StorageBase::create("", "", uri);
 auto fileinfo = storage->getFileInfo(uri);
-Log::info("After checkfileinfo: " + fileinfo._filename);
+Log::info("After checkfileinfo: " + uriString + " -> " + 
fileinfo._filename);
 if (!fileinfo.isValid())
 {
+Log::error("Invalid file info for uri " + uriString);
 throw BadRequestException("Invalid URI or access denied.");
 }
 
 return fileinfo;
 }
-catch (const std::exception&)
+catch (const std::exception& ex)
 {
+Log::error("Exception while getting file info for uri " + uriString + 
": " + ex.what());
 throw BadRequestException("Invalid URI or access denied.");
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/Storage.cpp

2016-08-31 Thread Ashod Nakashian

 loolwsd/Storage.cpp |8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

New commits:
commit 93082681441cfb4c073601bc7ae4b71449d5cd69
Author: Ashod Nakashian 
Date:   Wed Aug 31 19:38:27 2016 -0400

loolwsd: tolerate missing WOPI username

Change-Id: Ied24b5562f63ecdd96ee6ac7fd312b3bb5599573
Reviewed-on: https://gerrit.libreoffice.org/28573
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/Storage.cpp b/loolwsd/Storage.cpp
index e066f6f..3b71f16 100644
--- a/loolwsd/Storage.cpp
+++ b/loolwsd/Storage.cpp
@@ -291,9 +291,11 @@ StorageBase::FileInfo WopiStorage::getFileInfo(const 
Poco::URI& uri)
 const auto result = parser.parse(stringJSON);
 const auto& object = result.extract();
 filename = object->get("BaseFileName").toString();
-size = std::stoul (object->get("Size").toString(), nullptr, 0);
-userId = object->get("UserId").toString();
-userName = object->get("UserFriendlyName").toString();
+size = std::stoul(object->get("Size").toString(), nullptr, 0);
+const auto userIdVar = object->get("UserId");
+userId = (userIdVar.isString() ? userIdVar.toString() : "");
+const auto userNameVar = object->get("UserFriendlyName");
+userName = (userNameVar.isString() ? userNameVar.toString() : 
"anonymous");
 }
 
 // WOPI doesn't support file last modified time.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2016-08-31 Thread Henry Castro

 loleaflet/src/control/Control.ColumnHeader.js |   20 ++--
 loleaflet/src/control/Control.MetricInput.js  |   31 ++
 loleaflet/src/control/Control.RowHeader.js|   18 ---
 loleaflet/src/layer/tile/CalcTileLayer.js |4 +++
 4 files changed, 58 insertions(+), 15 deletions(-)

New commits:
commit 1370c42afa95cbc276aaade460202aed352202ee
Author: Henry Castro 
Date:   Wed Aug 31 23:34:45 2016 -0400

loleaflet: update extra width/height for optimal column/row

diff --git a/loleaflet/src/control/Control.ColumnHeader.js 
b/loleaflet/src/control/Control.ColumnHeader.js
index 74949ab..ef67d60 100644
--- a/loleaflet/src/control/Control.ColumnHeader.js
+++ b/loleaflet/src/control/Control.ColumnHeader.js
@@ -49,7 +49,7 @@ L.Control.ColumnHeader = L.Control.Header.extend({
}
},
'optimalwidth': {
-   name: _('Optimal Width'),
+   name: _('Optimal Width') + '...',
callback: function(key, options) {
var colAlpha = 
options.$trigger.attr('rel').split('spreadsheet-column-')[1];

colHeaderObj.optimalWidth.call(colHeaderObj, colAlpha);
@@ -62,11 +62,14 @@ L.Control.ColumnHeader = L.Control.Header.extend({
 
optimalWidth: function(colAlpha) {
if (!this._dialog) {
-   this._dialog = 
L.control.metricInput(this._onDialogResult, this, {title: _('Optimal Column 
Width')});
+   this._dialog = 
L.control.metricInput(this._onDialogResult, this,
+
this._map._docLayer.twipsToHMM(this._map._docLayer.STD_EXTRA_WIDTH),
+{title: _('Optimal 
Column Width')});
}
+   this._selectColumn(colAlpha, 0);
this._dialog.addTo(this._map);
this._map.enable(false);
-   this._dialog.update();
+   this._dialog.show();
},
 
insertColumn: function(colAlpha) {
@@ -194,6 +197,17 @@ L.Control.ColumnHeader = L.Control.Header.extend({
},
 
_onDialogResult: function (e) {
+   if (e.type === 'submit' && !isNaN(e.value)) {
+   var extra = {
+   aExtraWidth: {
+   type: 'unsigned short',
+   value: e.value
+   }
+   };
+
+   this._map.sendUnoCommand('.uno:SetOptimalColumnWidth', 
extra);
+   }
+
this._map.enable(true);
},
 
diff --git a/loleaflet/src/control/Control.MetricInput.js 
b/loleaflet/src/control/Control.MetricInput.js
index 88d3f69..df616d5 100644
--- a/loleaflet/src/control/Control.MetricInput.js
+++ b/loleaflet/src/control/Control.MetricInput.js
@@ -8,11 +8,12 @@ L.Control.MetricInput = L.Control.extend({
title: ''
},
 
-   initialize: function (callback, context, options) {
+   initialize: function (callback, context, value, options) {
L.setOptions(this, options);
 
this._callback = callback;
this._context = context;
+   this._default = value;
},
 
onAdd: function (map) {
@@ -34,7 +35,7 @@ L.Control.MetricInput = L.Control.extend({
var wrapper = L.DomUtil.create('div', 
'leaflet-popup-content-wrapper', container);
var content = L.DomUtil.create('div', 'leaflet-popup-content', 
wrapper);
var labelTitle = document.createElement('span');
-   labelTitle.innerHTML = '' + this.options.title + '';
+   labelTitle.innerHTML = '' + this.options.title + ' ' + 
_('(100th/mm)') + '';
content.appendChild(labelTitle);
content.appendChild(document.createElement('br'));
content.appendChild(document.createElement('br'));
@@ -43,8 +44,9 @@ L.Control.MetricInput = L.Control.extend({
labelAdd.innerHTML = _('Add: ');
content.appendChild(labelAdd);
 
-   var inputMetric = document.createElement('input');
+   var inputMetric = this._input = document.createElement('input');
inputMetric.type = 'text';
+   inputMetric.value = this._default;
content.appendChild(inputMetric);
content.appendChild(document.createElement('br'));
content.appendChild(document.createElement('br'));
@@ -52,6 +54,7 @@ L.Control.MetricInput = L.Control.extend({
var inputValue = document.createElement('input');

[Libreoffice-bugs] [Bug 93085] Application window is too high, status bar is not visible ( 1024x600 resolution), size of module launch inherited from the StartCenter which gets a fixed minimum height

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93085

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Attachment #127040|image/png   |application/zip
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89120] Writer is very slow at saving this file with svg images

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=89120

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
Version|4.3.3.2 release |4.0.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101257] calc CTRL+V pastes from clipboard outdated CTRL+C content

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101257

--- Comment #4 from bordma...@gmail.com ---
I can confirm I'm using Microsoft Edge when this happens, in Windows10 32bit

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - basebmp/inc formula/inc vcl/source

2016-08-31 Thread Don Lewis

 basebmp/inc/basebmp/packedpixeliterator.hxx |2 +-
 formula/inc/formula/grammar.hxx |4 ++--
 vcl/source/gdi/bmpfast.cxx  |2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 6aaac1afdebb39de5b5c43760c13bb64b429f1c8
Author: Don Lewis 
Date:   Thu Sep 1 00:14:50 2016 +

Fix -Wshift-negative-value compiler warnings.  The result of shifting

negative integer values is undefined, so change the operand to be
unsigned.

diff --git a/basebmp/inc/basebmp/packedpixeliterator.hxx 
b/basebmp/inc/basebmp/packedpixeliterator.hxx
index 18bfaea..a06b092 100644
--- a/basebmp/inc/basebmp/packedpixeliterator.hxx
+++ b/basebmp/inc/basebmp/packedpixeliterator.hxx
@@ -51,7 +51,7 @@ inline value_type get_mask( difference_type d )
 const unsigned int nIntraWordPositions( sizeof(value_type)*8 / 
bits_per_pixel );
 
 //  create bits_per_pixel 1s  shift to intra-word position
-return ((~(~0 << bits_per_pixel)) << bits_per_pixel*(MsbFirst ?
+return ((~(~0u << bits_per_pixel)) << bits_per_pixel*(MsbFirst ?
  
(nIntraWordPositions-1 - (d % nIntraWordPositions)) :
  (d % 
nIntraWordPositions)));
 }
diff --git a/formula/inc/formula/grammar.hxx b/formula/inc/formula/grammar.hxx
index 05debbd..65f97fb 100644
--- a/formula/inc/formula/grammar.hxx
+++ b/formula/inc/formula/grammar.hxx
@@ -56,9 +56,9 @@ public:
 // Room for 32k hypothetical languages plus EXTERNAL.
 static const int kConventionShift  = 16;
 // Room for 256 reference conventions.
-static const int kEnglishBit   = (1 << (kConventionShift + 8));
+static const int kEnglishBit   = (1u << (kConventionShift + 8));
 // Mask off all non-language bits.
-static const int kFlagMask = ~((~int(0)) << kConventionShift);
+static const int kFlagMask = ~((~0u) << kConventionShift);
 
 /** Values encoding the formula language plus address reference convention
 plus English parsing/formatting
diff --git a/vcl/source/gdi/bmpfast.cxx b/vcl/source/gdi/bmpfast.cxx
index 5cd4bcf..9d7ea9c 100644
--- a/vcl/source/gdi/bmpfast.cxx
+++ b/vcl/source/gdi/bmpfast.cxx
@@ -354,7 +354,7 @@ inline void ImplBlendPixels( const 
TrueColorPixelPtr& rDst,
 {
 if( !nAlphaVal )
 ImplConvertPixel( rDst, rSrc );
-else if( nAlphaVal != ~(~0 << ALPHABITS) )
+else if( nAlphaVal != ~(~0u << ALPHABITS) )
 {
 static const unsigned nAlphaShift = (ALPHABITS > 8) ? 8 : ALPHABITS;
 if( ALPHABITS > nAlphaShift )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101835] New: UI request for 'Merge Cells' control in 'Format - Cells' window

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101835

Bug ID: 101835
   Summary: UI request for 'Merge Cells' control in 'Format -
Cells' window
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bruceh...@gmail.com

Created attachment 127107
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127107=edit
Screen shots of Format Cells (LO & MSO) and Side bar.

This is an enhancement request to add a 'Merge Cells' control within the
Alignment tab of the 'Format Cells' window (Format > Cells).

The addition would make LO Format Cell/Alignment equivalent to (1) another
popular spreadsheet tool, and (2) the LO Sidebar/Properties. 

Screen shots attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

feedback for the xlsx import improvements

2016-08-31 Thread Markus Mohrhard

Hey Maarten,

thanks a lot for the two awesome XLSX import improvements. If possible it
would be nice to have test cases for the two.

For the bug fix this would be  a simple test document that can be used in
one of the automated tests. For the performance improvement it would be a
document showing the problem but not taking too long. The perf documents
are run under callgrind which means they take around 50 to 100 times the
normal import time during the test. So ideally the document already shows
the problem but still opens in less than 30 seconds.

Do have any other XLSX import issues that you are looking into? Don't
hesitate to contact Eike or me if you have any questions. We can be easily
reached by email or through IRC (erack and moggi in the freenode
#libreoffice-dev channel).

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 55168] Writer functionality request: add options for improving reading of text in Fullscreen Mode

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=55168

--- Comment #10 from Zenaan Harkness  ---
That requires a developer. I hope to become a developer who would be able to
implement this. That will take some substantial time for me personally.
Hopefully some other develope will like this feature. I certainly retract my
"duplicate of" suggestion (looks like an obvious mistake on my part - this is a
genuine feature enhancemnt request - I was cross referencing 20+ bugs at the
time, so to me, looks like I clearly mixed this one up; anyway, learning,
sorry).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101115] TEMPLATE MANAGER: Save as form fields not labelled

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101115

--- Comment #1 from Jean-Philippe MENGUAL  ---
Hi,

Seems fixed in 5.2, isn't it?

Otherwise, please explain steps to reproduce.

Here just the edit field to enter a name of template seems not working.

Regards,

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101116] TEMPLATE MANAGER: managed template form fields are not correctly exposed to assistive technologies

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101116

--- Comment #3 from Jean-Philippe MENGUAL  ---
Hi,

Has the patch fixed this bug?

Could you be more precise please, there are not enough steps to reproduce. How
could any dev, even not knowing a11y, reproduce and see what you're
experiencing, to investigate then in the code?

Myself, to show it now, I don't know really what steps to follow. I'm unable to
test its status with so few means to try.

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101361] Cursor keys move cursor to the opposite direction in RTL text

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101361

Khaled Hosny  changed:

   What|Removed |Added

   Priority|medium  |high
 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |khaledho...@eglug.org
   |desktop.org |

--- Comment #4 from Khaled Hosny  ---
I did some digging and found a change that fixes this issue for my limited
testing:
diff --git a/sw/source/core/text/frmcrsr.cxx b/sw/source/core/text/frmcrsr.cxx
index 63d8994..1babc48 100644
--- a/sw/source/core/text/frmcrsr.cxx
+++ b/sw/source/core/text/frmcrsr.cxx
@@ -905,7 +905,7 @@ static void lcl_VisualMoveRecursion( const SwLineLayout&
rCurrLine, sal_Int32 nI
 pPor = pPor->GetPortion();
 }

-if ( bRight )
+if ( !bRight )
 {
 bool bRecurse = pPor && pPor->IsMultiPortion() &&
static_cast(pPor)->IsBidi();

However this code have not been changed since almost forever, so I’m puzzled
why it broke now. It would be very helpful if we can get a bisect here, or at
least the exact release where it broke, any one volunteering?

PS. The issue happens also without GTK, and happens only in Writer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101834] ScreenBug

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101834

Bernhard Mayer  changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
Version|unspecified |5.1.5.1 rc
 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101834] New: ScreenBug

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101834

Bug ID: 101834
   Summary: ScreenBug
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ad...@bmnet.de

Created attachment 127105
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127105=edit
Screenshot and conversion to PDF

LO 5.1.4 and higher Versions:
WYSIWG in Writer dosnt work korrekt. if one uses Fontspacing to enlarge or
tighten some Fonts one will not see it on the screen but onely after converting
to PDF-File. 
I had to downgrade to Version 5.0 because I need this Funktion verry often.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101818] Add pasting options similar to Microsoft products

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101818

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---
Created attachment 127104
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127104=edit
The LibreOffice Paste Special dialog GUI

Because our existing Paste Special dialog is not "graphical" enough?

No, this is silly everything does not have to have Icons.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101818] Add pasting options similar to Microsoft products

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101818

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101808] options in setting of cells as TEXT

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101808

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
You can do validations with Menu/Data/Validity, where i.e. you can fix a text
length, but not a mask.

There is a pattern field on Forms Toolbar - More controls, but it can't be
linked to a cell directly in a spreadsheet. Maybe registering the table
spreadsheet as database could be a way.

But not a bug. If you want a request for enhancement, if so, please change the
second field of importance to 'enhancement'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101829] XML Source Corrupts and Loses Data

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101829

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||miguelangelrv@libreoffice.o
   ||rg
Version|5.2.1.2 rc  |4.0.6.2 release
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Looks the issue is with no data on the first field in the third row.

Test file is validated on http://www.xmlvalidation.com/

First version with the issue.
Win10x64
Version 4.0.6.2 (Build ID: 2e2573268451a50806fcd60ae2d9fe01dd0ce24)
I think 4.0 was the first version with the option.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source

2016-08-31 Thread Maxim Monastirsky

 cui/source/inc/numpages.hxx  |2 +-
 cui/source/tabpages/numpages.cxx |6 ++
 2 files changed, 3 insertions(+), 5 deletions(-)

New commits:
commit c780c6726dca5e2fe33297e44f25ae3e00703294
Author: Maxim Monastirsky 
Date:   Thu Sep 1 00:27:29 2016 +0300

Gallery submenu was missing from native menus

... for both OS X and gtk3. The reason is that it was
filled in item highlight handler, which isn't implemented
for native menus. For now use the menu activation handler,
like for the similar button in SvxLineTabPage.

Change-Id: I437fd6536dbd9e6ba51282eaacc8b43c3a2d6cbf

diff --git a/cui/source/inc/numpages.hxx b/cui/source/inc/numpages.hxx
index 42bcf296..6047683 100644
--- a/cui/source/inc/numpages.hxx
+++ b/cui/source/inc/numpages.hxx
@@ -318,7 +318,7 @@ class SvxNumOptionsTabPage : public SfxTabPage
 
 DECL_LINK_TYPED( NumberTypeSelectHdl_Impl, ListBox&, void );
 DECL_LINK_TYPED( LevelHdl_Impl, ListBox&, void );
-DECL_LINK_TYPED( PopupActivateHdl_Impl, Menu *, bool);
+DECL_LINK_TYPED( PopupActivateHdl_Impl, MenuButton *, void );
 DECL_LINK_TYPED( GraphicHdl_Impl, MenuButton *, void );
 DECL_LINK_TYPED( BulletHdl_Impl, Button*, void);
 DECL_LINK_TYPED( SizeHdl_Impl, Edit&, void );
diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx
index 42e26ef..59e5d89 100644
--- a/cui/source/tabpages/numpages.cxx
+++ b/cui/source/tabpages/numpages.cxx
@@ -1153,6 +1153,7 @@ SvxNumOptionsTabPage::SvxNumOptionsTabPage(vcl::Window* 
pParent,
 m_pBulletPB->SetClickHdl(LINK(this, SvxNumOptionsTabPage, BulletHdl_Impl));
 m_pFmtLB->SetSelectHdl(LINK(this, SvxNumOptionsTabPage, 
NumberTypeSelectHdl_Impl));
 m_pBitmapMB->SetSelectHdl(LINK(this, SvxNumOptionsTabPage, 
GraphicHdl_Impl));
+m_pBitmapMB->SetActivateHdl(LINK(this, SvxNumOptionsTabPage, 
PopupActivateHdl_Impl));
 m_pLevelLB->EnableMultiSelection(true);
 m_pLevelLB->SetSelectHdl(LINK(this, SvxNumOptionsTabPage, LevelHdl_Impl));
 m_pCharFmtLB->SetSelectHdl(LINK(this, SvxNumOptionsTabPage, 
CharFmtHdl_Impl));
@@ -1171,8 +1172,6 @@ SvxNumOptionsTabPage::SvxNumOptionsTabPage(vcl::Window* 
pParent,
 aInvalidateTimer.SetTimeout(50);
 
 Menu *pBitmapMenu = m_pBitmapMB->GetPopupMenu();
-
-pBitmapMenu->SetHighlightHdl(LINK(this, SvxNumOptionsTabPage, 
PopupActivateHdl_Impl));
 m_nGalleryId = pBitmapMenu->GetItemId("gallery");
 assert(m_nGalleryId != MENU_ITEM_NOTFOUND);
 VclPtrInstance pPopup;
@@ -2051,7 +2050,7 @@ IMPL_LINK_TYPED( SvxNumOptionsTabPage, GraphicHdl_Impl, 
MenuButton *, pButton, v
 }
 }
 
-IMPL_LINK_NOARG_TYPED(SvxNumOptionsTabPage, PopupActivateHdl_Impl, Menu *, 
bool)
+IMPL_LINK_NOARG_TYPED(SvxNumOptionsTabPage, PopupActivateHdl_Impl, MenuButton 
*, void)
 {
 if(!bMenuButtonInitialized)
 {
@@ -2103,7 +2102,6 @@ IMPL_LINK_NOARG_TYPED(SvxNumOptionsTabPage, 
PopupActivateHdl_Impl, Menu *, bool)
 }
 LeaveWait();
 }
-return false;
 }
 
 IMPL_LINK_NOARG_TYPED(SvxNumOptionsTabPage, BulletHdl_Impl, Button*, void)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: LibreOffice's New Area Dialog Box crashes when compiled with Clang

2016-08-31 Thread slacka

Here is the backtrace made with $ instdir/program/soffice --backtrace, and
the steps listed in my first post. Is there anything else I can do?




--
View this message in context: 
http://nabble.documentfoundation.org/LibreOffice-s-New-Area-Dialog-Box-crashes-when-compiled-with-Clang-tp4191943p4192269.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 101833] New: Calc WORKDAYS.INTL miscalculation

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101833

Bug ID: 101833
   Summary: Calc WORKDAYS.INTL miscalculation
   Product: LibreOffice
   Version: 5.2.0.4 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: olivier.hal...@documentfoundation.org

Created attachment 127103
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127103=edit
file with case showing calculation error

It seems that when the last computed workday coincides with a holiday,
WORKDAYS.INTL seems to ignore it.

The file attached has this situation

Start date: 8/31/2016
Number of days : 5
Holliday: 9/7/2016

Calculated value: 9/7/2016

Expected value: 9/8/2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100632] SIDEBAR, FILEOPEN: Certain Position & Size fields in Sidebar are not filled for this SVG

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100632

Aron Budea  changed:

   What|Removed |Added

   Keywords||bibisectRequest
 Whiteboard|target:5.3.0|target:5.3.0
   ||bibisectRequest:5.2

--- Comment #5 from Aron Budea  ---
Xisco, the bibisectRequest is still valid for this change, since I only
bibisected the one between 4.4 and 5.0:
-5.0.0.5 & 5.1.4.2: 0.07/0.00/0.84/0.08
-5.2.0.1: 0.07/0.00/0.84/0.00

I don't know if there's a protocol for that, but I added an extra whiteboard
tag for clarification.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sfx2 sc/source sd/source sfx2/source sw/source

2016-08-31 Thread Michael Stahl

 include/sfx2/templdlg.hxx   |8 
 sc/source/ui/view/formatsh.cxx  |4 +-
 sd/source/ui/view/drviewsf.cxx  |   10 ++---
 sd/source/ui/view/outlnvsh.cxx  |2 -
 sd/source/ui/view/viewshe3.cxx  |4 +-
 sfx2/source/dialog/templdlg.cxx |   73 +---
 sfx2/source/dialog/tplcitem.cxx |4 +-
 sfx2/source/inc/templdgi.hxx|2 -
 sw/source/uibase/app/docst.cxx  |2 -
 9 files changed, 55 insertions(+), 54 deletions(-)

New commits:
commit 75c39b903f06b656293edf20ec4a5173a0755fb6
Author: Michael Stahl 
Date:   Wed Aug 31 23:36:19 2016 +0200

let's make Impress crash less - SfxStyleFamily edition

Commit bcb41235deaf4b7ca90522bda3ba21a686819e6e - in addition to
introducing the enum SfxStyleFamily - inconsistently converted one
call of DrawDocShell::SetStyleFamily to use enum SfxStyleFamily
instead of a mysterious "5", but did not adapt all of the code that
extracts the SfxUInt16Item that subsequently extracts this value and
expects a number 0-5.

Since it's clearly inexcusably stupid to have 2 different public sets
of integers identifying styles, make the usage of the second "array
index" integers private to templdlg.cxx; the SfxUInt16 item now always
contains enum SfxStyleFamily.

(regression from bcb41235deaf4b7ca90522bda3ba21a686819e6e)

Change-Id: I333575c504277c2046f8f5a6b36ae3f86b3b3201

diff --git a/include/sfx2/templdlg.hxx b/include/sfx2/templdlg.hxx
index 94d2134..9ffded7 100644
--- a/include/sfx2/templdlg.hxx
+++ b/include/sfx2/templdlg.hxx
@@ -28,14 +28,6 @@
 #include 
 #include 
 
-namespace SfxTemplate
-{
-// converts from SFX_STYLE_FAMILY Ids to 1-5
-sal_uInt16 SFX2_DLLPUBLIC SfxFamilyIdToNId(SfxStyleFamily nFamily);
-// converts from 1-5 to SFX_STYLE_FAMILY Ids
-SfxStyleFamily SFX2_DLLPUBLIC NIdToSfxFamilyId(sal_uInt16 nId);
-}
-
 class SfxTemplateDialog_Impl;
 
 class SFX2_DLLPUBLIC SfxTemplatePanelControl : public vcl::Window
diff --git a/sc/source/ui/view/formatsh.cxx b/sc/source/ui/view/formatsh.cxx
index 569b04f..2fcce12 100644
--- a/sc/source/ui/view/formatsh.cxx
+++ b/sc/source/ui/view/formatsh.cxx
@@ -217,7 +217,7 @@ void ScFormatShell::GetStyleState( SfxItemSet& rSet )
 
pTabViewShell->GetViewFrame()->GetBindings().QueryState(SID_STYLE_FAMILY, 
pItem);
 SfxUInt16Item* pFamilyItem = 
dynamic_cast(pItem.get());
 
-bool bPage = pFamilyItem && SfxStyleFamily::Page == 
SfxTemplate::NIdToSfxFamilyId(pFamilyItem->GetValue());
+bool bPage = pFamilyItem && SfxStyleFamily::Page == 
static_cast(pFamilyItem->GetValue());
 
 if ( bProtected || bPage )
 rSet.DisableItem( nSlotId );
@@ -232,7 +232,7 @@ void ScFormatShell::GetStyleState( SfxItemSet& rSet )
 std::unique_ptr pItem;
 
pTabViewShell->GetViewFrame()->GetBindings().QueryState(SID_STYLE_FAMILY, 
pItem);
 SfxUInt16Item* pFamilyItem = 
dynamic_cast(pItem.get());
-bool bPage = pFamilyItem && SfxStyleFamily::Page == 
SfxTemplate::NIdToSfxFamilyId(pFamilyItem->GetValue());
+bool bPage = pFamilyItem && SfxStyleFamily::Page == 
static_cast(pFamilyItem->GetValue());
 
 if ( bProtected && !bPage )
 rSet.DisableItem( nSlotId );
diff --git a/sd/source/ui/view/drviewsf.cxx b/sd/source/ui/view/drviewsf.cxx
index e75001f..12f7ac8 100644
--- a/sd/source/ui/view/drviewsf.cxx
+++ b/sd/source/ui/view/drviewsf.cxx
@@ -491,7 +491,7 @@ void DrawViewShell::GetAttrState( SfxItemSet& rSet )
 std::unique_ptr pItem;
 GetViewFrame()->GetBindings().QueryState(SID_STYLE_FAMILY, 
pItem);
 SfxUInt16Item* pFamilyItem = 
dynamic_cast(pItem.get());
-if (pFamilyItem && 
SfxTemplate::NIdToSfxFamilyId(pFamilyItem->GetValue()) == 
SD_STYLE_FAMILY_PSEUDO)
+if (pFamilyItem && 
static_cast(pFamilyItem->GetValue()) == SD_STYLE_FAMILY_PSEUDO)
 rSet.Put(SfxBoolItem(nWhich,false));
 else
 {
@@ -506,7 +506,7 @@ void DrawViewShell::GetAttrState( SfxItemSet& rSet )
 std::unique_ptr pItem;
 GetViewFrame()->GetBindings().QueryState(SID_STYLE_FAMILY, 
pItem);
 SfxUInt16Item* pFamilyItem = 
dynamic_cast(pItem.get());
-if (pFamilyItem && 
SfxTemplate::NIdToSfxFamilyId(pFamilyItem->GetValue()) == 
SD_STYLE_FAMILY_PSEUDO)
+if (pFamilyItem && 
static_cast(pFamilyItem->GetValue()) == SD_STYLE_FAMILY_PSEUDO)
 {
 rSet.DisableItem(nWhich);
 }
@@ -518,7 +518,7 @@ void DrawViewShell::GetAttrState( SfxItemSet& rSet )
 std::unique_ptr pItem;

[Libreoffice-bugs] [Bug 100620] Wrong result with COUNTA or COUNT in formula

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100620

Aron Budea  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98500] Multiple animated GIFs cause 100% CPU utilization in Impress

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98500

--- Comment #8 from Dwokfur  ---
(In reply to Armin Le Grand (CIB) from comment #6)
> @Dwokfur: AOO uses the same code - it's from me. Please confirm that it is
> faster.

Update to the bug based on Armin's questions:
It only occurs in presentation mode and not in edit mode. So something must be
off in the presentation engine...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101790] I open a doc (.odt or .ods), make changes and it doesn' t let me save it

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101790

--- Comment #3 from Aron Budea  ---
Okay, so I tried with a random jpeg image (like the error image in the
attachment), then tried adding a table with different ways, but could always
save the file.

If the table is coming from Calc, a simple paste produces an embedded Calc
object, pasting as formatted text (RTF) looked the closest to what's in the
attached image. Still, didn't get any errors during saving (I used LO 5.2.0.4).

Since I'm obviously doing something differently, could you give more detailed
steps?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100182] Index entries lost on save (see comment 17)

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100182

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected
 CC||aniste...@gmail.com

--- Comment #20 from Xisco Faulí  ---
Issue introduced in range
7289a140fc68dc898ba2b2357cc960968195f236..766524b13b3e69cc16cf19b826f6d7f15ea5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101828] formatting lost on paste from pdf

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101828

--- Comment #2 from John Schuetz  ---
I'm seeing this as well in writer 5.2 copying from pdf to writer and from Logos
6 to writer.  Also, in these cases Paste Special only gives the option of
unformatted text.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/LOOLWSD.cpp

2016-08-31 Thread Michael Meeks

 loolwsd/LOOLWSD.cpp |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit f56d96229df69fe730b3f22f516a764c07a994ca
Author: Michael Meeks 
Date:   Wed Aug 31 22:05:02 2016 +0100

Avoid profiling CL devices during jail setup.

diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 1e090ab..4d1628b 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -1452,6 +1452,9 @@ void LOOLWSD::initialize(Application& self)
 setenv("MAX_CONCURRENCY", std::to_string(maxConcurrency).c_str(), 1);
 }
 
+// Otherwise we profile the soft-device at jail creation time.
+setenv ("SAL_DISABLE_OPENCL", "true", 1);
+
 // In Trial Versions we might want to set some limits.
 LOOLWSD::NumDocBrokers = 0;
 LOOLWSD::NumConnections = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-1-0' - loolwsd/LOOLWSD.cpp

2016-08-31 Thread Michael Meeks

 loolwsd/LOOLWSD.cpp |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 275624284ec9db360135ac4e387c7be06f7b5f7d
Author: Michael Meeks 
Date:   Wed Aug 31 22:05:02 2016 +0100

Avoid profiling CL devices during jail setup.

diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index e5853dc..240064b 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -1359,6 +1359,9 @@ void LOOLWSD::initialize(Application& self)
 Log::warn("Launch this in your browser:");
 Log::warn(lcl_getLaunchURI());
 
+// Otherwise we profile the soft-device at jail creation time.
+setenv ("SAL_DISABLE_OPENCL", "true", 1);
+
 // In Trial Versions we might want to set some limits.
 LOOLWSD::NumDocBrokers = 0;
 LOOLWSD::NumConnections = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101828] formatting lost on paste from pdf

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101828

--- Comment #1 from mike  ---
also when i copy/paste from MS Wordpad to writer 5.2 it loses bold and italics.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101725] various autotext from Standard missing

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101725

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bisected
 CC||azeemmys...@gmail.com

--- Comment #5 from Xisco Faulí  ---
Issue introduced by 4ccd991f6a6ca680ac2b7513ab3853e1ba9c71a3.

@Mohammed, Could you please take a look at it whenever you have some time?
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101809] Collabora Online Development Edition docker image DNS fault causes 20 second delay

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101809

Andras Timar  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |tima...@gmail.com
   |desktop.org |

--- Comment #1 from Andras Timar  ---
Thanks for the hint, I pushed a new image to docker hub today, which contains
this fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

2016-08-31 Thread Alex McMurchy


Hi All

I've pulled from git and git branch says I'm on

* master

first line of AutoGen is
Running ./configure with '--disable-ccache --disable-gtk3 
--with-parallelism=3 --without-junit --without-gssapi --without-krb5 
--srcdir=/home/master/master --enable-option-checking=fatal'


When compiling LibreOffice I get a failed Unit test. The problem occurs 
in  sc/qa/unit/functions_test.cxx with



CPPUNIT_ASSERT_DOUBLES_EQUAL(1.0, rDoc.GetValue(1, 2, 0), 1e-14);


whilst testing sc/qa/unit/data/functions/fods/chiinv.fods. The code 
sc/qa/unit/functions_test.cxx looks to me as though it's performed for 
all these .fods test files so why it should fail on one and not the rest 
is strange indeed.



Any suggestions on how I can resolve this problem will be appreciated.

Alex

The error is

Testing 
file:///home/master/master/sc/qa/unit/data/functions/fods/chidist.fods:
Tested 
file:///home/master/master/sc/qa/unit/data/functions/fods/chidist.fods: 
Pass (491ms)
Testing 
file:///home/master/master/sc/qa/unit/data/functions/fods/chiinv.fods:

/home/master/master/sc/qa/unit/functions_test.cxx:80:FunctionsTest::testFormulasFODS
double equality assertion failed
- Expected: 1
- Actual  : 0
- Delta   : 1e-14

FunctionsTest::testFormulasFODS finished in: 18129ms
functions_test.cxx:80:Assertion
Test name: FunctionsTest::testFormulasFODS
double equality assertion failed
- Expected: 1
- Actual  : 0
- Delta   : 1e-14

Failures !!!
Run: 1   Failure total: 1   Failures: 1   Errors: 0

Error: a unit test failed, please do one of:
make CppunitTest_sc_functions_test CPPUNITTRACE="gdb --args"
# for interactive debugging on Linux
make CppunitTest_sc_functions_test VALGRIND=memcheck
# for memory checking
make CppunitTest_sc_functions_test DEBUGCPPUNIT=TRUE
# for exception catching

make[1]: *** 
[/home/master/master/workdir/CppunitTest/sc_functions_test.test] Error 1

make[1]: *** Waiting for unfinished jobs
make: *** [build] Error 2
Compilation of libreoffice failed with 2 at Wed Aug 31 09:29:33 BST 2016


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/qa

2016-08-31 Thread Zdeněk Crhonek

 sc/qa/unit/data/functions/fods/covariance.s.fods | 3836 +++
 1 file changed, 3836 insertions(+)

New commits:
commit 80ed9726c0fc0aa8952fdf600f5336791c19bd7e
Author: ZdenÄk Crhonek 
Date:   Wed Aug 31 20:34:16 2016 +0200

add COVARIANCE.S test case

Change-Id: Ib7f716c76ea9f56c70045b9b6cc2fcbd0cab8d77
Reviewed-on: https://gerrit.libreoffice.org/28560
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/qa/unit/data/functions/fods/covariance.s.fods 
b/sc/qa/unit/data/functions/fods/covariance.s.fods
new file mode 100644
index 000..5ba1135
--- /dev/null
+++ b/sc/qa/unit/data/functions/fods/covariance.s.fods
@@ -0,0 +1,3836 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2016-08-31T20:33:08.718995739P0D1LibreOfficeDev/5.3.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/139d3b3e8b157c1f365f888126269f0902acbaa2
+ 
+  
+   0
+   0
+   51980
+   8584
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+  
+   4
+   1
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 75
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ false
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ de
+ DE
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   kQH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMAtwAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkxldHRlcgAAEgBDT01QQVRfRFVQTEVYX01PREUKAERVUExFWF9PRkY=
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+
+   KÄ
+  
+  
+   
+   -
+   
+
+   KÄ
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+  
+  
+   
+
+   KÄ
+  
+  
+   -
+   
+
+   KÄ
+   
+  
+  
+   
+
+   KÄ
+  
+  
+   -
+   
+
+   KÄ
+   
+

[Libreoffice-commits] core.git: 2 commits - sc/qa

2016-08-31 Thread Zdeněk Crhonek

 sc/qa/unit/data/functions/fods/confidence.t.fods | 3898 
 sc/qa/unit/data/functions/fods/countif.fods  | 4472 +++
 2 files changed, 8370 insertions(+)

New commits:
commit 575b8be566243288ae35263087ced2049c35bb0c
Author: ZdenÄk Crhonek 
Date:   Wed Aug 31 20:42:26 2016 +0200

add CONFIDENCE.T test case

Change-Id: Ibd7b84360a27642dc9f9210876f514e9dc109c2d
Reviewed-on: https://gerrit.libreoffice.org/28562
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/qa/unit/data/functions/fods/confidence.t.fods 
b/sc/qa/unit/data/functions/fods/confidence.t.fods
new file mode 100644
index 000..b113185
--- /dev/null
+++ b/sc/qa/unit/data/functions/fods/confidence.t.fods
@@ -0,0 +1,3898 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2016-08-31T20:41:18.009584134P0D1LibreOfficeDev/5.3.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/139d3b3e8b157c1f365f888126269f0902acbaa2
+ 
+  
+   0
+   0
+   45150
+   7076
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+  
+   4
+   1
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 75
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ false
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   kQH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMAtwAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkxldHRlcgAAEgBDT01QQVRfRFVQTEVYX01PREUKAERVUExFWF9PRkY=
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+
+   KÄ
+  
+  
+   
+   -
+   
+
+   KÄ
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+  
+  
+   
+
+   KÄ
+  
+  
+   -
+   
+
+   KÄ
+   
+  
+  
+   
+
+

[Libreoffice-bugs] [Bug 98999] Check for Updates does not work correctly

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98999

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu,
   ||cl...@documentfoundation.or
   ||g
 Ever confirmed|0   |1

--- Comment #6 from Aron Budea  ---
5.1.5 not being offered is a bug, I CCed Christian, he's taking care of it.

Your thoughts on how this feature should be extended/reworked should probably
go in bug 97302.
If you're curious, this is the current update script:
https://cgit.freedesktop.org/libreoffice/website/tree/check.php?h=update

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - basegfx/StaticLibrary_basegfx_s.mk

2016-08-31 Thread Don Lewis

 basegfx/StaticLibrary_basegfx_s.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 6e3596887a07e85cf0b821baf748980ba86e7d25
Author: Don Lewis 
Date:   Wed Aug 31 18:16:14 2016 +

Add a missing file to the basegfx static library to unbreak the

pdf import extension build.

diff --git a/basegfx/StaticLibrary_basegfx_s.mk 
b/basegfx/StaticLibrary_basegfx_s.mk
index e355e36..17c646f 100755
--- a/basegfx/StaticLibrary_basegfx_s.mk
+++ b/basegfx/StaticLibrary_basegfx_s.mk
@@ -62,6 +62,7 @@ $(eval $(call 
gb_StaticLibrary_add_generated_exception_objects,basegfx_s,\
CustomTarget/basegfx/source/tools/unopolypolygon \
CustomTarget/basegfx/source/tools/tools \
CustomTarget/basegfx/source/tools/b2dclipstate \
+   CustomTarget/basegfx/source/tools/stringconversiontools \
CustomTarget/basegfx/source/numeric/ftools \
CustomTarget/basegfx/source/tuple/b3ituple \
CustomTarget/basegfx/source/tuple/b3dtuple \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2016-08-31 Thread Henry Castro

 loleaflet/src/control/Control.Header.js|2 +-
 loleaflet/src/control/Control.RowHeader.js |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 947f1d3d86d5fe73f61542c9d0d6352b94b4669d
Author: Henry Castro 
Date:   Wed Aug 31 15:52:23 2016 -0400

loleaflet: fix extra height for optimal row

Also increase setTimeout to 400 for dblclick auto fit

diff --git a/loleaflet/src/control/Control.Header.js 
b/loleaflet/src/control/Control.Header.js
index cbd8b53..24ed4f7 100644
--- a/loleaflet/src/control/Control.Header.js
+++ b/loleaflet/src/control/Control.Header.js
@@ -70,7 +70,7 @@ L.Control.Header = L.Control.extend({
this._clicks = 0;
} else {
this.onDragClick(this._item, ++this._clicks, e);
-   setTimeout(L.bind(this.initialize, this), 200);
+   setTimeout(L.bind(this.initialize, this), 400);
}
 
this._target = this._cursor = this._item = this._start = 
this._offset = null;
diff --git a/loleaflet/src/control/Control.RowHeader.js 
b/loleaflet/src/control/Control.RowHeader.js
index c88cf6b..2395d3e 100644
--- a/loleaflet/src/control/Control.RowHeader.js
+++ b/loleaflet/src/control/Control.RowHeader.js
@@ -246,7 +246,7 @@ L.Control.RowHeader = L.Control.Header.extend({
var extra = {
aExtraHeight: {
type: 'unsigned short',
-   value: 
this._map._docLayer.STD_EXTRA_WIDTH
+   value: 0
}
};
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101827] Contour Editor dialog maxes out a cpu core at 100%

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101827

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
It seems like a thread is constantly repainting the image (profiling shows
GdipCreateSolidFill calls in a thread taking up a significant amount of time).

Confirmed in master build.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 55168] Writer functionality request: add options for improving reading of text in Fullscreen Mode

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=55168

--- Comment #9 from BrendaEM  ---
Zenaan,

No, I don't think that you caused me to perceive the wrong thing, I just didn't
want a useful feature to be ignored which is very likely to happen if this
feature request is marked a duplicate.

Wouldn't it be useful to drag a page while you are reading it?
Adobe thought so. Most of our phones and tablets can do this.

Respectfully, after 4 years and several releases of Libreoffice, please help
affirm to me that this forum is a useful venue for submitting ideas by action
instead or words.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

New Defects reported by Coverity Scan for LibreOffice

2016-08-31 Thread scan-admin


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

34 new defect(s) introduced to LibreOffice found with Coverity Scan.
76 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 20 of 34 defect(s)


** CID 1372406:(UNCAUGHT_EXCEPT)
/connectivity/source/commontools/dbtools.cxx: 1789 in 
dbtools::setObjectWithInfo(const 
com::sun::star::uno::Reference &, int, const 
connectivity::ORowSetValue &, int, int)()
/connectivity/source/commontools/dbtools.cxx: 1789 in 
dbtools::setObjectWithInfo(const 
com::sun::star::uno::Reference &, int, const 
connectivity::ORowSetValue &, int, int)()
/connectivity/source/commontools/dbtools.cxx: 1789 in 
dbtools::setObjectWithInfo(const 
com::sun::star::uno::Reference &, int, const 
connectivity::ORowSetValue &, int, int)()



*** CID 1372406:(UNCAUGHT_EXCEPT)
/connectivity/source/commontools/dbtools.cxx: 1789 in 
dbtools::setObjectWithInfo(const 
com::sun::star::uno::Reference &, int, const 
connectivity::ORowSetValue &, int, int)()
1783 {
1784 ORowSetValue aVal;
1785 aVal.fill(x);
1786 setObjectWithInfo(_xParams,parameterIndex,aVal,sqlType,scale);
1787 }
1788 
>>> CID 1372406:(UNCAUGHT_EXCEPT)
>>> An exception of type "std::length_error" is thrown but the throw list 
>>> "throw(com::sun::star::uno::RuntimeException, 
>>> com::sun::star::sdbc::SQLException)" doesn't allow it to be thrown. This 
>>> will cause a call to unexpected() which usually calls terminate().
1789 void setObjectWithInfo(const Reference& _xParams,
1790sal_Int32 parameterIndex,
1791const ::connectivity::ORowSetValue& _rValue,
1792sal_Int32 sqlType,
1793sal_Int32 scale)  throw(SQLException, 
RuntimeException)
1794 {
/connectivity/source/commontools/dbtools.cxx: 1789 in 
dbtools::setObjectWithInfo(const 
com::sun::star::uno::Reference &, int, const 
connectivity::ORowSetValue &, int, int)()
1783 {
1784 ORowSetValue aVal;
1785 aVal.fill(x);
1786 setObjectWithInfo(_xParams,parameterIndex,aVal,sqlType,scale);
1787 }
1788 
>>> CID 1372406:(UNCAUGHT_EXCEPT)
>>> An exception of type "std::length_error" is thrown but the throw list 
>>> "throw(com::sun::star::uno::RuntimeException, 
>>> com::sun::star::sdbc::SQLException)" doesn't allow it to be thrown. This 
>>> will cause a call to unexpected() which usually calls terminate().
1789 void setObjectWithInfo(const Reference& _xParams,
1790sal_Int32 parameterIndex,
1791const ::connectivity::ORowSetValue& _rValue,
1792sal_Int32 sqlType,
1793sal_Int32 scale)  throw(SQLException, 
RuntimeException)
1794 {
/connectivity/source/commontools/dbtools.cxx: 1789 in 
dbtools::setObjectWithInfo(const 
com::sun::star::uno::Reference &, int, const 
connectivity::ORowSetValue &, int, int)()
1783 {
1784 ORowSetValue aVal;
1785 aVal.fill(x);
1786 setObjectWithInfo(_xParams,parameterIndex,aVal,sqlType,scale);
1787 }
1788 
>>> CID 1372406:(UNCAUGHT_EXCEPT)
>>> An exception of type "std::length_error" is thrown but the throw list 
>>> "throw(com::sun::star::uno::RuntimeException, 
>>> com::sun::star::sdbc::SQLException)" doesn't allow it to be thrown. This 
>>> will cause a call to unexpected() which usually calls terminate().
1789 void setObjectWithInfo(const Reference& _xParams,
1790sal_Int32 parameterIndex,
1791const ::connectivity::ORowSetValue& _rValue,
1792sal_Int32 sqlType,
1793sal_Int32 scale)  throw(SQLException, 
RuntimeException)
1794 {

** CID 1372405:  Error handling issues  (UNCAUGHT_EXCEPT)
/dbaccess/source/core/api/WrappedResultSet.cxx: 95 in 
dbaccess::WrappedResultSet::updateRow(const 
rtl::Reference &, const 
rtl::Reference &, const 
com::sun::star::uno::Reference &)()



*** CID 1372405:  Error handling issues  (UNCAUGHT_EXCEPT)
/dbaccess/source/core/api/WrappedResultSet.cxx: 95 in 
dbaccess::WrappedResultSet::updateRow(const 
rtl::Reference &, const 
rtl::Reference &, const 
com::sun::star::uno::Reference &)()
89 updateColumn(i,m_xUpdRow,*aIter);
90 }
91 m_xUpd->insertRow();
92 (*_rInsertRow->get().begin()) = getBookmark();
93 }
94 
>>> CID 1372405:

[Libreoffice-bugs] [Bug 100995] Toolbar icons display incorrect zoom factor and pixellation on OSX Sierra

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100995

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 CC||qui...@gmail.com
Summary|UI : on OSX Sierra  |Toolbar icons display
   |application UI toolbar  |incorrect zoom factor and
   |icons display incorrect |pixellation on OSX Sierra
   |zoom factor and pixellation |

--- Comment #5 from Yousuf (Jay) Philips  ---
>From the screenshot in comment 2, i would guess that there is a problem with
the hidpi rescaling, so CCing Tomaz for his thoughts.

On a different note, the screenshot also shows that the document area hasnt
been rendered, so parts of the start center are showing in that area. Or was
the screenshot taken during the time it was transitioning from start center to
writer?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87422] Buttons in 'Contour Editor' dialog dont function correctly

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87422

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Blocks||101831


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101831
[Bug 101831] [META] Contour editor bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101831] [META] Contour editor bugs and enhancements

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101831

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Depends on||101832


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101832
[Bug 101832] Contour Editor no longer centers image in the dialog
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101832] New: Contour Editor no longer centers image in the dialog

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101832

Bug ID: 101832
   Summary: Contour Editor no longer centers image in the dialog
   Product: LibreOffice
   Version: 5.2.0.4 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisectRequest, regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Blocks: 101831

Created attachment 127102
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127102=edit
sample

Steps:
1) Open attached doc
2) Select each of the three images and open up the contour editor on each
3) With the gray arrow, the contour editor will appear blank when opened but
stretching the width of the dialog will eventually show the image
4) With the blue arrow, the contour editor will crop the bottom of the image
and stretching its height will further crop more of the image
5) With the mockup image, it doesnt center the image in the window

Regression as this all worked fine in 5.1.

Version: 5.3.0.0.alpha0+
Build ID: 139d3b3e8b157c1f365f888126269f0902acbaa2
CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-08-26_00:01:39
Locale: en-US (en_US.UTF-8); Calc: group


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101831
[Bug 101831] [META] Contour editor bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101827] Contour Editor dialog maxes out a cpu core at 100%

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101827

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Blocks||101831


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101831
[Bug 101831] [META] Contour editor bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101831] [META] Contour editor bugs and enhancements

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101831

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Depends on||101827, 100463, 87422
 Ever confirmed|0   |1


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87422
[Bug 87422] Buttons in 'Contour Editor' dialog dont function correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=100463
[Bug 100463] Pipette in Contour Editor does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=101827
[Bug 101827] Contour Editor dialog maxes out a cpu core at 100%
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101831] New: [META] Contour editor bugs and enhancements

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101831

Bug ID: 101831
   Summary: [META] Contour editor bugs and enhancements
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101830] Empty input fields completely invisible

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101830

--- Comment #2 from Jan-Marek Glogowski  ---
Created attachment 127101
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127101=edit
New LO game: find the input field

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101830] Empty input fields completely invisible

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101830

--- Comment #1 from Jan-Marek Glogowski  ---
Probably I'll create a meta bug for an overall review of field handling in
Writer. bug 101625 and bug 73386 are also related.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101830] New: Empty input fields completely invisible

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101830

Bug ID: 101830
   Summary: Empty input fields completely invisible
   Product: LibreOffice
   Version: 5.0.6.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: glo...@fbihome.de

Since the merge of the editable input fields in 4.x times, empty input fields
completely vanish in the editor. Enabling the "field names" doesn't work for
them anymore, and if they are empty we even miss the little gray indicator box,
even with "field shadings" enabled.

Lucky you, if you're navigating into the input field via cursor movement, so
you can expand it.

Hint: the "secret" key combo "Ctrl+Shift+F9" for the input field edit dialog
finds it, even if it always starts at the beginning of the document.

Overall the fields part of Writer definitely needs some love.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - cpputools/source crashrep/source extensions/source fpicker/source icc/makefile.mk icc/SampleICC-1.3.2.format-security.patch icu/icu-for

2016-08-31 Thread Don Lewis

 cpputools/source/unoexe/unoexe.cxx|4 +-
 crashrep/source/unx/main.cxx  |4 +-
 extensions/source/logging/consolehandler.cxx  |4 +-
 fpicker/source/unx/gnome/SalGtkFilePicker.cxx |1 
 icc/SampleICC-1.3.2.format-security.patch |   21 ++
 icc/makefile.mk   |2 -
 icu/icu-format-security.patch |   12 
 icu/makefile.mk   |3 +-
 rsc/source/prj/start.cxx  |2 -
 svtools/bmpmaker/bmp.cxx  |2 -
 svtools/bmpmaker/bmpsum.cxx   |2 -
 svtools/bmpmaker/g2g.cxx  |2 -
 vcl/source/fontsubset/cff.cxx |4 +-
 vcl/source/fontsubset/sft.cxx |   38 +-
 vcl/unx/generic/plugadapt/salplug.cxx |2 -
 15 files changed, 69 insertions(+), 34 deletions(-)

New commits:
commit 7204bffa5c633d7bc2064e3c643dbacfab79e281
Author: Don Lewis 
Date:   Wed Aug 31 16:12:32 2016 +

Fix -Wformat-security warnings.

There are a number of instances where the code calls *printf() to
print arbitrary strings and the string is passed as the format
argument to *printf().  Since these strings might contain %
conversion sequences, this is a security hazard.  Fix the problem
by printing the strings with a "%s" format.

diff --git a/cpputools/source/unoexe/unoexe.cxx 
b/cpputools/source/unoexe/unoexe.cxx
index 34c237b..a842676 100644
--- a/cpputools/source/unoexe/unoexe.cxx
+++ b/cpputools/source/unoexe/unoexe.cxx
@@ -127,7 +127,7 @@ static sal_Bool s_quiet = false;
 static inline void out( const sal_Char * pText )
 {
 if (! s_quiet)
-fprintf( stderr, pText );
+fprintf( stderr, "%s", pText );
 }
 
//--
 static inline void out( const OUString & rText )
@@ -135,7 +135,7 @@ static inline void out( const OUString & rText )
 if (! s_quiet)
 {
 OString aText( OUStringToOString( rText, RTL_TEXTENCODING_ASCII_US ) );
-fprintf( stderr, aText.getStr() );
+fprintf( stderr, "%s", aText.getStr() );
 }
 }
 
diff --git a/crashrep/source/unx/main.cxx b/crashrep/source/unx/main.cxx
index 28c4052..52505b3 100644
--- a/crashrep/source/unx/main.cxx
+++ b/crashrep/source/unx/main.cxx
@@ -364,7 +364,7 @@ bool SendHTTPRequest(
 if ( g_bDebugMode )
 {
 printf( "*** Sending HTTP request ***\n\n" );
-printf( buffer );
+printf( "%s", buffer );
 }
 
 if ( SOCKET_ERROR != send( s, buffer, strlen(buffer), 0 ) )
@@ -401,7 +401,7 @@ bool SendHTTPRequest(
 if ( g_bDebugMode )
 do
 {
-printf( buffer );
+printf( "%s", buffer );
 memset( buffer, 0, sizeof(buffer) );
 } while ( 0 < recv( s, buffer, sizeof(buffer), 0 ) 
);
 }
diff --git a/extensions/source/logging/consolehandler.cxx 
b/extensions/source/logging/consolehandler.cxx
index d2c0877..60440bd 100644
--- a/extensions/source/logging/consolehandler.cxx
+++ b/extensions/source/logging/consolehandler.cxx
@@ -245,9 +245,9 @@ namespace logging
 return sal_False;
 
 if ( _rRecord.Level >= m_nThreshold )
-fprintf( stderr, sEntry.getStr() );
+fprintf( stderr, "%s", sEntry.getStr() );
 else
-fprintf( stdout, sEntry.getStr() );
+fprintf( stdout, "%s", sEntry.getStr() );
 
 return sal_True;
 }
diff --git a/fpicker/source/unx/gnome/SalGtkFilePicker.cxx 
b/fpicker/source/unx/gnome/SalGtkFilePicker.cxx
index e613d71..d9e42ed 100644
--- a/fpicker/source/unx/gnome/SalGtkFilePicker.cxx
+++ b/fpicker/source/unx/gnome/SalGtkFilePicker.cxx
@@ -1047,6 +1047,7 @@ sal_Int16 SAL_CALL SalGtkFilePicker::execute() throw( 
uno::RuntimeException )
 GTK_DIALOG_MODAL,
 GTK_MESSAGE_QUESTION,
 GTK_BUTTONS_YES_NO,
+  "%s",
   OUStringToOString(
 aResProvider.getResString( 
FILE_PICKER_OVERWRITE ),
 RTL_TEXTENCODING_UTF8 ).getStr() );
diff --git a/icc/SampleICC-1.3.2.format-security.patch 
b/icc/SampleICC-1.3.2.format-security.patch
new file mode 100644
index 000..d6bd7f8
--- /dev/null
+++ b/icc/SampleICC-1.3.2.format-security.patch
@@ -0,0 +1,21 @@
+diff -ur misc/SampleICC-1.3.2/IccProfLib/IccProfile.cpp 
misc/build/SampleICC-1.3.2/IccProfLib/IccProfile.cpp
+--- misc/SampleICC-1.3.2/IccProfLib/IccProfile.cpp

[Libreoffice-bugs] [Bug 101625] continue fulfilling input fields

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101625

Jan-Marek Glogowski  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Jan-Marek Glogowski  ---
Thanks for your comments and the attached design ideas document.

Personally I would like to merge the input field edit and the edit dialog. Main
problem: there are many more different fields, and the edit dialog adapts to
them. And I just realized you can just navigate through the same type of field
using the edit window - hmmm...

OTOH most time you would just change the input fields manually, so the input
field edit dialog is much more convenient here.

And there seems to be no way to get any overview of the fields in the document,
so probably it's time to expand the edit dialog - it already wastes a lot of
space in the left column. Fields are also missing from the normal navigator
(F5).

It should be easy to add a "previous" button in the "input field" edit dialog.
And I just realized "Ok" does the same the "Next", or am I missing something?

BTW: since some 4.x (x >= 2) release, you can edit the input fields directly. A
single click marks the content off the field and puts the cursor at the end of
the field, so you can directly replace the content. A 2nd click allows you to
place the cursor anywhere in the field, or just use the arrows. Tab and
Shift+Tab can be used to go to the next or previous input field, as long as you
are inside. Inside is indicated by a black margin around the field.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2016-08-31 Thread Maarten Bosmans

 sc/source/filter/oox/sheetdatabuffer.cxx |   59 ---
 1 file changed, 24 insertions(+), 35 deletions(-)

New commits:
commit 4a63c145dcce8411c5707f6b99877cc87a4f6c5d
Author: Maarten Bosmans 
Date:   Wed Aug 24 21:14:57 2016 +0200

Resolves tdf#100709 Optimize SheetDataBuffer::addColXfStyle

The insertion of RowRanges into the sorted set was done by iterating 
through the
set until the correct insertion point was found.  By using 
set.lower_bound(),
the complexity goes from O(N) to (log N) for a single insert.

Regarding tdf#100709: the import time for the attached example document 
reduces by 12x.

Change-Id: Ifb03d58a0e46a936ab61a5f0b512e956c87e5e2b
Reviewed-on: https://gerrit.libreoffice.org/28510
Reviewed-by: Eike Rathke 
Tested-by: Jenkins 

diff --git a/sc/source/filter/oox/sheetdatabuffer.cxx 
b/sc/source/filter/oox/sheetdatabuffer.cxx
index d5f29af..1ebf76c 100644
--- a/sc/source/filter/oox/sheetdatabuffer.cxx
+++ b/sc/source/filter/oox/sheetdatabuffer.cxx
@@ -370,59 +370,48 @@ void SheetDataBuffer::addColXfStyle( sal_Int32 nXfId, 
sal_Int32 nFormatId, const
 maStylesPerColumn[ nCol ].insert( aStyleRows );
 else
 {
-RowStyles& rRowStyles =  maStylesPerColumn[ nCol ];
+RowStyles& rRowStyles = maStylesPerColumn[ nCol ];
 // Reset row range for each column
 aStyleRows.mnStartRow = rAddress.StartRow;
 aStyleRows.mnEndRow = rAddress.EndRow;
 
-// If the rowrange style includes rows already
-// allocated to a style then we need to split
-// the range style Rows into sections ( to
-// occupy only rows that have no style definition )
+// If aStyleRows includes rows already allocated to a style
+// in rRowStyles, then we need to split it into parts.
+// ( to occupy only rows that have no style definition)
 
-// We don't want to set any rowstyle 'rows'
-// for rows where there is an existing 'style' )
-std::vector< RowRangeStyle > aRangeRowsSplits;
-
-RowStyles::iterator rows_it = rRowStyles.begin();
+// Start iterating at the first element that is not completely 
before aStyleRows
+RowStyles::iterator rows_it = rRowStyles.lower_bound(aStyleRows);
 RowStyles::iterator rows_end = rRowStyles.end();
 bool bAddRange = true;
 for ( ; rows_it != rows_end; ++rows_it )
 {
 const RowRangeStyle& r = *rows_it;
-// if row is completely within existing style, discard it
-if ( aStyleRows.mnStartRow >= r.mnStartRow && 
aStyleRows.mnEndRow <= r.mnEndRow )
-bAddRange = false;
-else if ( aStyleRows.mnStartRow <= r.mnStartRow )
+
+// Add the part of aStyleRows that does not overlap with r
+if ( aStyleRows.mnStartRow < r.mnStartRow )
+{
+RowRangeStyle aSplit = aStyleRows;
+aSplit.mnEndRow = std::min(aStyleRows.mnEndRow, 
r.mnStartRow - 1);
+// Insert with hint that aSplit comes directly before the 
current position
+rRowStyles.insert( rows_it, aSplit );
+}
+
+// Done if no part of aStyleRows extends beyond r
+if ( aStyleRows.mnEndRow <= r.mnEndRow )
 {
-// not intersecting at all?, if so finish as none left
-// to check ( row ranges are in ascending order
-if ( aStyleRows.mnEndRow < r.mnStartRow )
-break;
-else if ( aStyleRows.mnEndRow <= r.mnEndRow )
-{
-aStyleRows.mnEndRow = r.mnStartRow - 1;
-break;
-}
-if ( aStyleRows.mnStartRow < r.mnStartRow )
-{
-RowRangeStyle aSplit = aStyleRows;
-aSplit.mnEndRow = r.mnStartRow - 1;
-aRangeRowsSplits.push_back( aSplit );
-}
+bAddRange = false;
+break;
 }
-if ( aStyleRows.mnStartRow <= r.mnEndRow && r.mnEndRow < 
aStyleRows.mnEndRow )
-aStyleRows.mnStartRow = r.mnEndRow + 1;
+
+// Cut off the part aStyleRows that was handled above
+aStyleRows.mnStartRow = r.mnEndRow + 1;
 }
-std::vector< RowRangeStyle >::iterator splits_it = 
aRangeRowsSplits.begin();
-std::vector< RowRangeStyle >::iterator splits_end = 
aRangeRowsSplits.end();
-for ( ; splits_it != splits_end; ++splits_it )
-rRowStyles.insert(

[Libreoffice-bugs] [Bug 101829] New: XML Source Corrupts and Loses Data

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101829

Bug ID: 101829
   Summary: XML Source Corrupts and Loses Data
   Product: LibreOffice
   Version: 5.2.1.2 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: d...@ued.net

Created attachment 127100
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127100=edit
Test XML File Looses Line 3 and Corrupts Line 2

The attached test file has 1 header row and 5 data lines.  When imported using
XML Source the data is converted into 1 header row with 4 data lines. 
Information for the third line is merged into the data for the second.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101828] New: formatting lost on paste from pdf

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101828

Bug ID: 101828
   Summary: formatting lost on paste from pdf
   Product: LibreOffice
   Version: 5.2.0.4 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: chops...@comcast.net

in writer 5.2 when i copy and paste from a pdf to writer in loses formatting
for bold and italics
this worked on 5.1 (I just upgraded)
i can paste the same text into MS wordpad and see the correct formatting

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101779] Templates window: line break not working in tooltip

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101779

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |momonas...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101435] [META] Template manager bugs and enhancements

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101435
Bug 101435 depends on bug 101779, which changed state.

Bug 101779 Summary: Templates window: line break not working in tooltip
https://bugs.documentfoundation.org/show_bug.cgi?id=101779

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101440] Tooltips text cramped on a single line in Template Manager

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101440

--- Comment #3 from Commit Notification 
 ---
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=89a0365082e6ba9c255c2f7d69b537bb9936d848

Revert "tdf#101440 Better rendering of tooltip in gtk2 and windows"

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101827] New: Contour Editor dialog maxes out a cpu core at 100%

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101827

Bug ID: 101827
   Summary: Contour Editor dialog maxes out a cpu core at 100%
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisectRequest, perf, regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
CC: michael.me...@collabora.com

Steps:
1) Open Writer
2) Insert an image
3) Right-click > Wrap > Edit Contour
4) Notice that 1 cpu core is at 100%

Regression as this doesnt happen in 5.0.

Version: 5.3.0.0.alpha0+
Build ID: 139d3b3e8b157c1f365f888126269f0902acbaa2
CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-08-26_00:01:39
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101779] Templates window: line break not working in tooltip

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101779

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101779] Templates window: line break not working in tooltip

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101779

--- Comment #8 from Commit Notification 
 ---
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2decee2ccd9a4167949843da0db99edaebe6acd8

tdf#101779 Allow multiline tooltips in template manager

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - include/sfx2 sfx2/source

2016-08-31 Thread Maxim Monastirsky

 include/sfx2/thumbnailview.hxx|2 ++
 sfx2/source/control/thumbnailview.cxx |   13 +
 sfx2/source/doc/doc.src   |2 +-
 3 files changed, 16 insertions(+), 1 deletion(-)

New commits:
commit 2decee2ccd9a4167949843da0db99edaebe6acd8
Author: Maxim Monastirsky 
Date:   Wed Aug 31 19:14:27 2016 +0300

tdf#101779 Allow multiline tooltips in template manager

Change-Id: Ia3dc45fc35aeeabfabc119bb84847c479ed32fda

diff --git a/include/sfx2/thumbnailview.hxx b/include/sfx2/thumbnailview.hxx
index bd08a57..13621cb 100644
--- a/include/sfx2/thumbnailview.hxx
+++ b/include/sfx2/thumbnailview.hxx
@@ -187,6 +187,8 @@ public:
 
 virtual void MouseMove(const MouseEvent& rMEvt) override;
 
+virtual void RequestHelp(const HelpEvent& rHEvt) override;
+
 void AppendItem(ThumbnailViewItem *pItem);
 
 void RemoveItem(sal_uInt16 nItemId);
diff --git a/sfx2/source/control/thumbnailview.cxx 
b/sfx2/source/control/thumbnailview.cxx
index a6a48e8..c0d4c37 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -109,6 +109,19 @@ void ThumbnailView::MouseMove(const MouseEvent& rMEvt)
 SetQuickHelpText(aHelp);
 }
 
+void ThumbnailView::RequestHelp( const HelpEvent& rHEvt )
+{
+if ( rHEvt.GetMode() & HelpEventMode::QUICK )
+{
+// Force balloon mode, to be able to use line break.
+HelpEvent aNewEvent( rHEvt.GetMousePosPixel(), HelpEventMode::BALLOON 
);
+Control::RequestHelp( aNewEvent );
+return;
+}
+
+Control::RequestHelp( rHEvt );
+}
+
 void ThumbnailView::AppendItem(ThumbnailViewItem *pItem)
 {
 if (maFilterFunc(pItem))
commit 89a0365082e6ba9c255c2f7d69b537bb9936d848
Author: Maxim Monastirsky 
Date:   Wed Aug 31 20:21:04 2016 +0300

Revert "tdf#101440 Better rendering of tooltip in gtk2 and windows"

See tdf#101779 for a proper fix.

This reverts commit c505ec78ddf97fbcb6e39b7865df5a455d41bf38.

Change-Id: Ie825c1d2d8b4ab5696078da95c1b7f3fc699b2cb

diff --git a/sfx2/source/doc/doc.src b/sfx2/source/doc/doc.src
index 644bfa9..ef60bff 100644
--- a/sfx2/source/doc/doc.src
+++ b/sfx2/source/doc/doc.src
@@ -86,7 +86,7 @@ String STR_RENAME_TEMPLATE
 };
 String STR_TEMPLATE_TOOLTIP
 {
-Text [ en-US ] = "Title: $1 \nCategory: $2" ;
+Text [ en-US ] = "Title: $1\nCategory: $2" ;
 };
 String STR_TEMPLATE_SELECTION
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/dist

2016-08-31 Thread Jan Holesovsky

 dev/null  |binary
 loleaflet/dist/images/lc_backward.png |binary
 loleaflet/dist/toolbar.css|2 +-
 3 files changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c3a3d8136504283b2f81675057d44058332c6fd7
Author: Jan Holesovsky 
Date:   Wed Aug 31 19:26:23 2016 +0200

Breeze icon for the 'Document repair'.

diff --git a/loleaflet/dist/images/document-properties.png 
b/loleaflet/dist/images/document-properties.png
deleted file mode 100644
index 0eadfbf..000
Binary files a/loleaflet/dist/images/document-properties.png and /dev/null 
differ
diff --git a/loleaflet/dist/images/lc_backward.png 
b/loleaflet/dist/images/lc_backward.png
new file mode 100644
index 000..4a0bc32
Binary files /dev/null and b/loleaflet/dist/images/lc_backward.png differ
diff --git a/loleaflet/dist/toolbar.css b/loleaflet/dist/toolbar.css
index dfb9de3..aef6e23 100644
--- a/loleaflet/dist/toolbar.css
+++ b/loleaflet/dist/toolbar.css
@@ -268,7 +268,7 @@ button.leaflet-control-search-next
 .w2ui-icon.sortascending{ background: 
url('/loleaflet/dist/images/lc_sortascending.png') no-repeat center !important; 
}
 .w2ui-icon.sortdescending{ background: 
url('/loleaflet/dist/images/lc_sortdescending.png') no-repeat center 
!important; }
 .w2ui-icon.selected{ background: url('/loleaflet/dist/images/lc_ok.png') 
no-repeat center !important; }
-.w2ui-icon.repair{ background: 
url('/loleaflet/dist/images/document-properties.png') no-repeat center 
!important; }
+.w2ui-icon.repair{ background: url('/loleaflet/dist/images/lc_backward.png') 
no-repeat center !important; }
 
 .inserttable-pop {
 z-index: 10;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

Justin L  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||filter:doc
 CC||jl...@mail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] New: textbox background fill lost when round-tripping in .doc

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

Bug ID: 101826
   Summary: textbox background fill lost when round-tripping in
.doc
   Product: LibreOffice
   Version: 4.3.0.4 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jl...@mail.com

Created attachment 127099
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127099=edit
textboxMargins.doc: should have a gray background when round-tripped

LibreOffice reads the original word document fine, but when saving and
re-opening, the gray background on the textbox is lost.

Tested and bisected on Linux 16.04 with bibisect-43max

Bibisected to the huge patch (Files 119, -1182/+4572 lines)
commit 6e61ecd09679a66060f932835622821d39e92f01
Author: Armin Le Grand 
CommitDate: Fri Mar 28 14:31:08 2014 +0100

Merge back branch alg_writerframes to trunk

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sfx2 sfx2/source sw/inc sw/source

2016-08-31 Thread Miklos Vajna

 include/sfx2/lokhelper.hxx  |2 ++
 include/sfx2/viewsh.hxx |2 ++
 sfx2/source/view/lokhelper.cxx  |   26 +++---
 sfx2/source/view/viewsh.cxx |9 ++---
 sw/inc/crsrsh.hxx   |3 +++
 sw/inc/view.hxx |2 ++
 sw/inc/viscrs.hxx   |4 ++--
 sw/source/core/crsr/crsrsh.cxx  |5 +
 sw/source/core/crsr/viscrs.cxx  |   18 ++
 sw/source/uibase/uiview/viewprt.cxx |5 +
 10 files changed, 56 insertions(+), 20 deletions(-)

New commits:
commit 7167c2b6548830b82280f2f3943d445e9afd6f5e
Author: Miklos Vajna 
Date:   Wed Aug 31 17:19:13 2016 +0200

sfx2 lok: introduce SfxViewShell::NotifyCursor()

It allows removing the hide/show cursor hack in
SfxViewShell::registerLibreOfficeKitViewCallback() introduced in commit
4d211384f048b689f20e46d4d586f342b110cb5c (sfx2 lok: fix missing view
cursors in a new view, 2016-06-20), and instead let the application code
in sw/sc/sd implement the best way to show existing cursors in a new
view.

This way the per-app cleanup of view cursors introduced in commit
bc9b4fd4c83af3532204237157821d4884c42d8e (lok::Document::destroyView:
clean up view cursors/selections, 2016-07-15) has matching per-app init
code.

This commit just adds the API + adapts existing sw code to use it, sc/sd
still has to be implemented.

Based on a patch by Marco Cecchetti, thanks!

Change-Id: I38510fa4962f405b1b96a79024206c9e7f33cad2
Reviewed-on: https://gerrit.libreoffice.org/28557
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/include/sfx2/lokhelper.hxx b/include/sfx2/lokhelper.hxx
index e7dfed4..852aa79 100644
--- a/include/sfx2/lokhelper.hxx
+++ b/include/sfx2/lokhelper.hxx
@@ -32,6 +32,8 @@ public:
 
 /// Invoke the LOK callback of all views except pThisView, with a payload 
of rKey-rPayload.
 static void notifyOtherViews(SfxViewShell* pThisView, int nType, const 
OString& rKey, const OString& rPayload);
+/// Same as notifyOtherViews(), but works on a selected "other" view, not 
on all of them.
+static void notifyOtherView(SfxViewShell* pThisView, SfxViewShell* 
pOtherView, int nType, const OString& rKey, const OString& rPayload);
 };
 
 #endif
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index d20d4e3..1c7266a 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -342,6 +342,8 @@ public:
 sal_uInt32 GetViewShellId() const override;
 /// See OutlinerViewShell::NotifyOtherViews().
 void NotifyOtherViews(int nType, const OString& rKey, const OString& 
rPayload) override;
+/// Ask this view to send its cursor position to pViewShell.
+virtual void NotifyCursor(SfxViewShell* /*pViewShell*/) const;
 };
 
 
diff --git a/sfx2/source/view/lokhelper.cxx b/sfx2/source/view/lokhelper.cxx
index 7a23e1b..c5fb171 100644
--- a/sfx2/source/view/lokhelper.cxx
+++ b/sfx2/source/view/lokhelper.cxx
@@ -92,6 +92,19 @@ std::size_t SfxLokHelper::getViews()
 return rViewArr.size();
 }
 
+void SfxLokHelper::notifyOtherView(SfxViewShell* pThisView, SfxViewShell* 
pOtherView, int nType, const OString& rKey, const OString& rPayload)
+{
+boost::property_tree::ptree aTree;
+aTree.put("viewId", SfxLokHelper::getView(pThisView));
+aTree.put(rKey.getStr(), rPayload.getStr());
+aTree.put("part", pThisView->getPart());
+aTree.put(rKey.getStr(), rPayload.getStr());
+std::stringstream aStream;
+boost::property_tree::write_json(aStream, aTree);
+OString aPayload = aStream.str().c_str();
+pOtherView->libreOfficeKitViewCallback(nType, aPayload.getStr());
+}
+
 void SfxLokHelper::notifyOtherViews(SfxViewShell* pThisView, int nType, const 
OString& rKey, const OString& rPayload)
 {
 if (SfxLokHelper::getViews() <= 1)
@@ -101,17 +114,8 @@ void SfxLokHelper::notifyOtherViews(SfxViewShell* 
pThisView, int nType, const OS
 while (pViewShell)
 {
 if (pViewShell != pThisView)
-{
-boost::property_tree::ptree aTree;
-aTree.put("viewId", SfxLokHelper::getView(pThisView));
-aTree.put(rKey.getStr(), rPayload.getStr());
-aTree.put("part", pThisView->getPart());
-aTree.put(rKey.getStr(), rPayload.getStr());
-std::stringstream aStream;
-boost::property_tree::write_json(aStream, aTree);
-OString aPayload = aStream.str().c_str();
-pViewShell->libreOfficeKitViewCallback(nType, aPayload.getStr());
-}
+notifyOtherView(pThisView, pViewShell, nType, rKey, rPayload);
+
 pViewShell = SfxViewShell::GetNext(*pViewShell);
 }
 }
diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index f2d8e48..710c9cb 100644
--- a/sfx2/source/view/viewsh.cxx
+++

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer: moving up and down with selection different objects

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

Yousuf (Jay) Philips  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||1825

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101825] New: Contextual toolbar switching causes UI jerk

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101825

Bug ID: 101825
   Summary: Contextual toolbar switching causes UI jerk
   Product: LibreOffice
   Version: 5.0.6.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com

Similar to bug 99383, I noticed that if you insert an image from the gallery
into a document in writer, the formatting toolbar would disappear before the
frame and image toolbars appear, causing a jerking of the UI.

Regression as i wasnt able to reproduce this in 4.4.

Version: 5.3.0.0.alpha0+
Build ID: 139d3b3e8b157c1f365f888126269f0902acbaa2
CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-08-26_00:01:39
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101823] New: Formatting

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101823

Bug ID: 101823
   Summary: Formatting
   Product: LibreOffice
   Version: 4.1.4.2 release
  Hardware: Other
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: paulhoro...@hotmail.com

Italic text in Times New Roman is either suppressed (returning to 'Normal')or
spreads to incorporate surrounding text when page this is on is not currently
viewed

Repeated re-formatting or shut down and restart does not solve problem which
persists across multiple copies of the same document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101824] New: Rasterizing vector images in compress dialog dont take resized size into account

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101824

Bug ID: 101824
   Summary: Rasterizing vector images in compress dialog dont take
resized size into account
   Product: LibreOffice
   Version: 5.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com

Steps:
1) Open writer
2) Insert an arrow svg from the gallery
3) Resize it to a larger size
4) Right-click > Compress
5) Set it to png compression and 600 dpi
6) Rasterized image isnt crisp

Version: 5.3.0.0.alpha0+
Build ID: 139d3b3e8b157c1f365f888126269f0902acbaa2
CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-08-26_00:01:39
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp loolwsd/Storage.cpp

2016-08-31 Thread Jan Holesovsky

 loolwsd/DocumentBroker.cpp |2 +-
 loolwsd/Storage.cpp|2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 2090f121b61c34a2285430f495aee88c24ebc2e4
Author: Jan Holesovsky 
Date:   Wed Aug 31 17:05:10 2016 +0200

Don't check for nullptr after dereferencing.

StorageBase::create() is supposed to throw when there are trouble.

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index e583279..a2f1d12 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -130,7 +130,7 @@ const StorageBase::FileInfo DocumentBroker::validate(const 
Poco::URI& uri)
 auto storage = StorageBase::create("", "", uri);
 auto fileinfo = storage->getFileInfo(uri);
 Log::info("After checkfileinfo: " + fileinfo._filename);
-if (storage == nullptr || !fileinfo.isValid())
+if (!fileinfo.isValid())
 {
 throw BadRequestException("Invalid URI or access denied.");
 }
diff --git a/loolwsd/Storage.cpp b/loolwsd/Storage.cpp
index 7deba6a..e066f6f 100644
--- a/loolwsd/Storage.cpp
+++ b/loolwsd/Storage.cpp
@@ -138,6 +138,8 @@ std::unique_ptr StorageBase::create(const 
std::string& jailRoot, co
 if (UnitWSD::get().createStorage(jailRoot, jailPath, uri, storage))
 {
 Log::info("Storage load hooked.");
+if (storage)
+return storage;
 }
 else if (uri.isRelative() || uri.getScheme() == "file")
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: rsc/inc rsc/source

2016-08-31 Thread Jochen Nitschke

 rsc/inc/rscarray.hxx|6 +++---
 rsc/inc/rscclass.hxx|2 +-
 rsc/inc/rscconst.hxx|3 +--
 rsc/inc/rsccont.hxx |6 +++---
 rsc/inc/rscflag.hxx |4 ++--
 rsc/inc/rscmgr.hxx  |2 +-
 rsc/inc/rscrange.hxx|9 +++--
 rsc/inc/rscstr.hxx  |3 +--
 rsc/inc/rsctop.hxx  |2 +-
 rsc/source/res/rscarray.cxx |9 -
 rsc/source/res/rscclass.cxx |7 +++
 rsc/source/res/rscclobj.cxx |9 -
 rsc/source/res/rscconst.cxx |4 +---
 rsc/source/res/rsccont.cxx  |   14 ++
 rsc/source/res/rscflag.cxx  |6 ++
 rsc/source/res/rscmgr.cxx   |2 +-
 rsc/source/res/rscrange.cxx |   12 
 rsc/source/res/rscstr.cxx   |3 +--
 rsc/source/res/rsctop.cxx   |2 +-
 19 files changed, 43 insertions(+), 62 deletions(-)

New commits:
commit f322c52b89f514b792179c4d7e6ee2c3aa893a4e
Author: Jochen Nitschke 
Date:   Wed Aug 31 14:14:50 2016 +0200

use initializer list ctors for res types

make nSize and nOffInstData const,
let Size() return fixed sizes

Change-Id: I7e2792e1cd990e65582020353054087f94856151
Reviewed-on: https://gerrit.libreoffice.org/28545
Reviewed-by: Jochen Nitschke 
Tested-by: Jochen Nitschke 

diff --git a/rsc/inc/rscarray.hxx b/rsc/inc/rscarray.hxx
index c917db5..a7bf2c4 100644
--- a/rsc/inc/rscarray.hxx
+++ b/rsc/inc/rscarray.hxx
@@ -54,8 +54,8 @@ class RscArray : public RscTop
 {
 protected:
 RscEnum *   pTypeClass; // type of entries
-sal_uInt32  nSize;  // size of this class instance data with super 
class
-sal_uInt32  nOffInstData;// Offset of self instance data
+const sal_uInt32 nOffInstData;// Offset of self instance data
+const sal_uInt32 nSize;  // size of this class instance data with 
super class
 voidWriteSrcArray( const RSCINST & rInst, FILE * fOutput,
RscTypCont * pTC, sal_uInt32 nTab, const 
char * );
 public:
@@ -75,7 +75,7 @@ public:
  RSCINST * pGetInst ) override;
 
 // gives the size of the class in bytes
-sal_uInt32  Size() override { return nSize; }
+sal_uInt32  Size() const override { return nSize; }
 
 boolIsConsistent( const RSCINST & rInst ) override;
 virtual voidSetToDefault( const RSCINST & rInst ) override;
diff --git a/rsc/inc/rscclass.hxx b/rsc/inc/rscclass.hxx
index 1b78859..46fe526 100644
--- a/rsc/inc/rscclass.hxx
+++ b/rsc/inc/rscclass.hxx
@@ -82,7 +82,7 @@ public:
 RSCINST GetCopyVar( const RSCINST & rInst, Atom nVarName ) 
override;
 
 // gives the class size in bytes
-sal_uInt32  Size() override { return nSize; }
+sal_uInt32  Size() const override { return nSize; }
 
 boolIsConsistent( const RSCINST & rInst ) override;
 voidSetToDefault( const RSCINST & rInst ) override;
diff --git a/rsc/inc/rscconst.hxx b/rsc/inc/rscconst.hxx
index 275996f..ec3d362 100644
--- a/rsc/inc/rscconst.hxx
+++ b/rsc/inc/rscconst.hxx
@@ -52,11 +52,10 @@ class RscEnum : public RscConst
 sal_uInt32  nValue; // constant position in the array
 boolbDflt;  // is default
 };
-sal_uInt32  nSize;
 public:
 RscEnum( Atom nId, sal_uInt32 nTypId );
 RSCINST Create( RSCINST * pInst, const RSCINST & rDfltInst, bool 
bOwnClass = false ) override;
-sal_uInt32  Size() override { return nSize; }
+sal_uInt32  Size() const override { return 
ALIGNED_SIZE(sizeof(RscEnumInst)); }
 
 virtual voidSetToDefault( const RSCINST & rInst ) override
 {
diff --git a/rsc/inc/rsccont.hxx b/rsc/inc/rsccont.hxx
index 36aa2cf..f72f1ae 100644
--- a/rsc/inc/rsccont.hxx
+++ b/rsc/inc/rsccont.hxx
@@ -43,8 +43,8 @@ protected:
 RscTop *pTypeClass; // type of entries
 RscTop *pTypeClass1;// two different types may exist
 boolbNoId;  // whether there is no identifier
-sal_uInt32  nSize;  // size of this class and super classes 
instance data
-sal_uInt32  nOffInstData;// offset of own instance data
+const sal_uInt32 nOffInstData;// offset of own instance data
+const sal_uInt32 nSize;  // size of this class and super classes 
instance data
 static void DestroyElements( RscBaseContInst * pClassData );
 RSCINST SearchElePos( const RSCINST & rInst, const RscId & 
rEleName,
   RscTop * pClass, sal_uInt32 nPos );
@@ -86,7 +86,7 @@ public:
 ERRTYPE SetRef( const RSCINST & rInst, const RscId & rRefId ) 
override;
 
 // returns the class size in bytes
-sal_uInt32  Size() override { return nSize; }
+sal_uInt32  Size() const override { return

[Libreoffice-bugs] [Bug 101822] glxtest zombie process on all non-Gtk+ X11 VCL platforms

2016-08-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101822

--- Comment #1 from Jan-Marek Glogowski  ---
Created attachment 127097
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127097=edit
GDB session from a Gtk+ based LO start and shutdown

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: rsc/source

2016-08-31 Thread Jochen Nitschke

 rsc/source/parser/rscdb.cxx |   23 ++-
 1 file changed, 14 insertions(+), 9 deletions(-)

New commits:
commit 2a1431208e4292e8563935f5e8cd0107113f65ea
Author: Jochen Nitschke 
Date:   Wed Aug 31 11:39:59 2016 +0200

cppcheck:noConstructor for RscEnumerateObj

use initializer lists for ctors

Change-Id: I1ac13d4178d070e02223cb70d8dc80d229a5fa7b
Reviewed-on: https://gerrit.libreoffice.org/28543
Tested-by: Jenkins 
Reviewed-by: Jochen Nitschke 

diff --git a/rsc/source/parser/rscdb.cxx b/rsc/source/parser/rscdb.cxx
index 53855fc..05638fb 100644
--- a/rsc/source/parser/rscdb.cxx
+++ b/rsc/source/parser/rscdb.cxx
@@ -42,6 +42,8 @@ RscTypCont::RscTypCont( RscError * pErrHdl,
 : nSourceCharSet( RTL_TEXTENCODING_UTF8 )
 , nByteOrder( nOrder )
 , aSearchPath( rSearchPath )
+, nUniqueId(256)
+, nPMId(RSC_VERSIONCONTROL +1) // at least one more
 , aBool( pHS->getID( "sal_Bool" ), RSC_NOTYPE )
 , aShort( pHS->getID( "short" ), RSC_NOTYPE )
 , aUShort( pHS->getID( "sal_uInt16" ), RSC_NOTYPE )
@@ -57,11 +59,9 @@ RscTypCont::RscTypCont( RscError * pErrHdl,
 , aLangType()
 , aLangString( pHS->getID( "Lang_Chars" ), RSC_NOTYPE, , 
 )
 , aLangShort( pHS->getID( "Lang_short" ), RSC_NOTYPE, ,  )
+, pEH(pErrHdl)
 , nFlags( nFlagsP )
 {
-nUniqueId = 256;
-nPMId = RSC_VERSIONCONTROL +1; // at least one more
-pEH = pErrHdl;
 Init();
 }
 
@@ -290,6 +290,14 @@ private:
 sal_uLong   lFileKey;   // what source file
 RscTop *pClass;
 
+RscEnumerateObj(RscTypCont* pTC, FILE* pOutputFile)
+:pTypCont(pTC)
+,fOutput(pOutputFile)
+,lFileKey(0)
+,pClass(nullptr)
+{
+}
+
 DECL_LINK_TYPED( CallBackWriteRc, const NameNode&, void );
 DECL_LINK_TYPED( CallBackWriteSrc, const NameNode&, void );
 
@@ -388,12 +396,9 @@ private:
 public:
 RscEnumerateObj aEnumObj;
 
-RscEnumerateRef( RscTypCont * pTC, RscTop * pR,
- FILE * fOutput )
+RscEnumerateRef(RscTypCont* pTC, RscTop* pR, FILE* fOutput)
+: pRoot(pR), aEnumObj(pTC, fOutput)
 {
-aEnumObj.pTypCont = pTC;
-aEnumObj.fOutput  = fOutput;
-pRoot = pR;
 }
 ERRTYPE const & WriteRc()
 {
@@ -475,8 +480,8 @@ public:
 
 
 inline RscDel::RscDel( RscTop * pRoot, sal_uLong lKey )
+: lFileKey(lKey)
 {
-lFileKey = lKey;
 pRoot->EnumNodes( LINK( this, RscDel, Delete ) );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

1 2 3 4 >

1 - 100 of 304 matches

Mail list logo