[Libreoffice-bugs] [Bug 102924] Ortography error spanish version of " Importing_and_Exporting_Data_in_Base"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102924

--- Comment #1 from gmoll...@us.es ---
Más errores en la misma página:
Pli eraroj en la sama paĝo:
More errors on the same page:

1) " de datos utiliza Calc como" -> " de datos utiliza a Calc como"
2) "Cuando importa texto de un documento de hoja de calculo" ->"de"->"en"->
"Cuando importa texto en un documento de hoja de calculo"
3) "en la primer fila de" -> "en la primera fila de"
4) "se perdera" -> "se perderá"
5) "cuando se importa a Base." -> "cuando se importe a Base."
6) " la primer columna" -> " la primera columna"
7) "tiene un formato de texto" -> "tenga formato de texto"
8) "de la primer fila" -> "de la primera fila"
9) "toda la columna esta establecida" -> "toda la columna será establecida"
10) "Abre el archivo Calc que " -> "Abra el archivo Calc que "

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: 3 commits - loleaflet/src loolwsd/LOOLWSD.cpp

[Pranav Kant]

 loleaflet/src/layer/tile/TileLayer.js |8 +++--
 loolwsd/LOOLWSD.cpp   |   54 --
 2 files changed, 45 insertions(+), 17 deletions(-)

New commits:
commit 7e57ae5dce1a3ed7e1f8951b4fc73f2fee5c10ec
Author: Pranav Kant 
Date:   Mon Oct 3 11:16:09 2016 +0530

loleaflet: Don't add these layers in readonly mode

Change-Id: I17437f53921dc3d5036be4a9650213a7eb0895dd

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 061db21..62ee1a9 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -144,11 +144,15 @@ L.TileLayer = L.GridLayer.extend({
this._initContainer();
this._getToolbarCommandsValues();
this._selections = new L.LayerGroup();
-   map.addLayer(this._selections);
+   if (this.options.permission !== 'readonly') {
+   map.addLayer(this._selections);
+   }
 
// This layergroup contains all the layers corresponding to 
other's view
this._viewLayerGroup = new L.LayerGroup();
-   map.addLayer(this._viewLayerGroup);
+   if (this.options.permission !== 'readonly') {
+   map.addLayer(this._viewLayerGroup);
+   }
 
this._debug = map.options.debug;
this._debugInit();
commit 3fa2115fa18ca8b53a9f3f4659eb0f280c0f5125
Author: Pranav Kant 
Date:   Mon Oct 3 10:51:20 2016 +0530

loolwsd: security: Cleanup HTTP download request

Sanitize for some funny inputs.

Change-Id: I450cb5ed6e03e9809308e8f763af2c2a66fcecb0

diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 5372b19..77a0399 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -555,15 +555,8 @@ private:
 {
 Log::info("File download request.");
 //TODO: Check that the user in question has access to this file!
-const std::string dirPath = LOOLWSD::ChildRoot + tokens[3]
-  + JAILED_DOCUMENT_ROOT + tokens[4];
-std::string fileName;
-URI::decode(tokens[5], fileName);
-const std::string filePath = dirPath + "/" + fileName;
-Log::info("HTTP request for: " + filePath);
-File file(filePath);
 
-// Validate the dockey
+// 1. Validate the dockey
 std::string decodedUri;
 URI::decode(tokens[2], decodedUri);
 const auto docKey = 
DocumentBroker::getDocKey(DocumentBroker::sanitizeURI(decodedUri));
@@ -573,24 +566,55 @@ private:
 {
 throw BadRequestException("DocKey [" + docKey + "] is 
invalid.");
 }
+
+// 2. Cross-check if received child id is correct
+if (docBrokerIt->second->getJailId() != tokens[3])
+{
+throw BadRequestException("ChildId does not correspond to 
docKey");
+}
+
+// 3. Don't let user download the file in main doc directory 
containing
+// the document being edited otherwise we will end up deleting 
main directory
+// after download finishes
+if (docBrokerIt->second->getJailId() == tokens[4])
+{
+throw BadRequestException("RandomDir cannot be equal to 
ChildId");
+}
 docBrokersLock.unlock();
 
-if (file.exists())
+std::string fileName;
+bool responded = false;
+URI::decode(tokens[5], fileName);
+const Path filePath(LOOLWSD::ChildRoot + tokens[3]
++ JAILED_DOCUMENT_ROOT + tokens[4] + "/" + 
fileName);
+Log::info("HTTP request for: " + filePath.toString());
+if (filePath.isAbsolute() && File(filePath).exists())
 {
 response.set("Access-Control-Allow-Origin", "*");
 HTMLForm form(request);
 const std::string mimeType = form.has("mime_type")
? form.get("mime_type")
: "application/octet-stream";
-response.sendFile(filePath, mimeType);
-//TODO: Cleanup on error.
-Util::removeFile(dirPath, true);
-return true;
+try
+{
+response.sendFile(filePath.toString(), mimeType);
+responded = true;
+}
+catch (const Exception& exc)
+{
+Log::error() << "Error sending file to client. 
PocoException: " << exc.displayText()
+ << (exc.nested() ? " (" + 
exc.nested()->displayText() + ")" : "")
+ << Log::end;
+   

[Libreoffice-bugs] [Bug 102924] New: Ortography error spanish version of " Importing_and_Exporting_Data_in_Base"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102924

Bug ID: 102924
   Summary: Ortography error spanish version of
"Importing_and_Exporting_Data_in_Base"
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gmoll...@us.es

Español, Esperanto, English:
Español:
En la dirección web:
https://help.libreoffice.org/Common/Importing_and_Exporting_Data_in_Base/es

Falta la tilde en "nÚmeros", buscar el texto "y solo numeros se", y cambiar por
"y solo números se". Gracias.

Esperanto:
En la TTT-adreson:
https://help.libreoffice.org/Common/Importing_and_Exporting_Data_in_Base/es

Supersigno mankas en "nÚmeros", vi serĉu por "y solo numeros se" kaj vi ŝanĝu
ĝin al "y solo números se", mi petas. Dankon!

English:
In url:
https://help.libreoffice.org/Common/Importing_and_Exporting_Data_in_Base/es

A diacritical mark or acute accent:
Search "y solo numeros se", change to "y solo números se". Thanks.

English serves to discriminate by income and nationality, generating classism
and racism. Esperanto language is better to avoid it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46200] [RFE] Use the Scroll Lock key as a toggling lock key like Excel

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46200

abhilash300si...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |abhilash300si...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/TileCacheTests.cpp |   53 
 1 file changed, 53 insertions(+)

New commits:
commit dba4d840103ed71b3205fdf706757155c7c1b835
Author: Ashod Nakashian 
Date:   Sun Oct 2 20:34:04 2016 -0400

loolwsd: new per-part tile invalidation unittest

Change-Id: I70c1b3d339bdd6dc017b3e09132e32ea0a2133ec
Reviewed-on: https://gerrit.libreoffice.org/29469
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/TileCacheTests.cpp b/loolwsd/test/TileCacheTests.cpp
index 96ae662..d5e18c9 100644
--- a/loolwsd/test/TileCacheTests.cpp
+++ b/loolwsd/test/TileCacheTests.cpp
@@ -64,6 +64,8 @@ class TileCacheTests : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testLoad12ods);
 CPPUNIT_TEST(testTileInvalidateWriter);
 CPPUNIT_TEST(testTileInvalidateCalc);
+CPPUNIT_TEST(testTileInvalidatePartCalc);
+CPPUNIT_TEST(testTileInvalidatePartImpress);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -81,6 +83,10 @@ class TileCacheTests : public CPPUNIT_NS::TestFixture
 void testTileInvalidateWriter();
 void testWriterAnyKey();
 void testTileInvalidateCalc();
+void testTileInvalidatePartCalc();
+void testTileInvalidatePartImpress();
+
+void tileInvalidatePart(const std::string& filename, const std::string& 
testname);
 
 void checkTiles(Poco::Net::WebSocket& socket,
 const std::string& type,
@@ -635,6 +641,53 @@ void TileCacheTests::testTileInvalidateCalc()
 }
 }
 
+void TileCacheTests::tileInvalidatePart(const std::string& filename, const 
std::string& testname)
+{
+const std::string testname1 = testname + "-1 ";
+const std::string testname2 = testname + "-2 ";
+
+std::string documentPath, documentURL;
+getDocumentPathAndURL(filename, documentPath, documentURL);
+auto socket1 = *loadDocAndGetSocket(_uri, documentURL);
+
+sendTextFrame(socket1, "setclientpart part=2", testname1);
+assertResponseLine(socket1, "setpart:", testname1);
+sendTextFrame(socket1, "mouse type=buttondown x=7886 y=8929 count=1 
buttons=1 modifier=0", testname1);
+
+auto socket2 = *loadDocAndGetSocket(_uri, documentURL);
+sendTextFrame(socket2, "setclientpart part=5", testname2);
+assertResponseLine(socket2, "setpart:", testname2);
+sendTextFrame(socket2, "mouse type=buttondown x=7886 y=8929 count=1 
buttons=1 modifier=0", testname2);
+
+std::string text = "Some test";
+for (char ch : text)
+{
+sendChar(socket1, ch);
+sendChar(socket2, ch);
+
+const auto response1 = assertResponseLine(socket1, "invalidatetiles:", 
testname1);
+int value1;
+LOOLProtocol::getTokenIntegerFromMessage(response1, "part", value1);
+CPPUNIT_ASSERT_EQUAL(2, value1);
+
+const auto response2 = assertResponseLine(socket2, "invalidatetiles:", 
testname2);
+int value2;
+LOOLProtocol::getTokenIntegerFromMessage(response2, "part", value2);
+CPPUNIT_ASSERT_EQUAL(5, value2);
+}
+}
+
+
+void TileCacheTests::testTileInvalidatePartCalc()
+{
+tileInvalidatePart("setclientpart.ods", "tileInvalidatePartCalc");
+}
+
+void TileCacheTests::testTileInvalidatePartImpress()
+{
+tileInvalidatePart("setclientpart.odp", "tileInvalidatePartImpress");
+}
+
 void TileCacheTests::checkTiles(Poco::Net::WebSocket& socket, const 
std::string& docType, const std::string& name)
 {
 const std::string current = "current=";
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/TileCacheTests.cpp |   26 ++
 1 file changed, 6 insertions(+), 20 deletions(-)

New commits:
commit 23f7560bf1a40ccd22a828c5910dcdcc58339e3e
Author: Ashod Nakashian 
Date:   Sun Oct 2 18:55:37 2016 -0400

loolwsd: fix and enable tile invalidation test for Calc

Change-Id: I105857026507ff3dedd798f66bcebcc111e6c072
Reviewed-on: https://gerrit.libreoffice.org/29468
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/TileCacheTests.cpp b/loolwsd/test/TileCacheTests.cpp
index c469395..96ae662 100644
--- a/loolwsd/test/TileCacheTests.cpp
+++ b/loolwsd/test/TileCacheTests.cpp
@@ -63,7 +63,7 @@ class TileCacheTests : public CPPUNIT_NS::TestFixture
 #endif
 CPPUNIT_TEST(testLoad12ods);
 CPPUNIT_TEST(testTileInvalidateWriter);
-//CPPUNIT_TEST(testTileInvalidateCalc);
+CPPUNIT_TEST(testTileInvalidateCalc);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -609,44 +609,30 @@ void TileCacheTests::testWriterAnyKey()
 
 void TileCacheTests::testTileInvalidateCalc()
 {
-std::string documentPath, documentURL;
-getDocumentPathAndURL("empty.ods", documentPath, documentURL);
-Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
-
-auto socket = *loadDocAndGetSocket(_uri, documentURL);
+const std::string testname = "tileInvalidateCalc ";
+auto socket = *loadDocAndGetSocket("empty.ods", _uri, testname);
 
 std::string text = "Test. Now go 3 \"Enters\": Now after the enters, goes 
this text";
 for (char ch : text)
 {
 sendChar(socket, ch); // Send ordinary characters -> one tile 
invalidation for each
 auto response = getResponseMessage(socket, "invalidatetiles:");
-//CPPUNIT_ASSERT_MESSAGE("did not receive a invalidatetiles: message 
as expected", !response.empty());
 }
 
+std::cerr << "Sending enters" << std::endl;
 text = "\n\n\n";
 for (char ch : text)
 {
 sendChar(socket, ch, skCtrl); // Send 3 Ctrl+Enter -> 3 new pages; I 
see 3 tiles invalidated for each
-auto response1 = getResponseMessage(socket, "invalidatetiles:");
-CPPUNIT_ASSERT_MESSAGE("did not receive a invalidatetiles: message as 
expected", !response1.empty());
-auto response2 = getResponseMessage(socket, "invalidatetiles:");
-CPPUNIT_ASSERT_MESSAGE("did not receive a invalidatetiles: message as 
expected", !response2.empty());
-auto response3 = getResponseMessage(socket, "invalidatetiles:");
-CPPUNIT_ASSERT_MESSAGE("did not receive a invalidatetiles: message as 
expected", !response3.empty());
+assertResponseLine(socket, "invalidatetiles:", testname);
 }
 
 text = "abcde";
 for (char ch : text)
 {
 sendChar(socket, ch);
-auto response = getResponseMessage(socket, "invalidatetiles:");
-CPPUNIT_ASSERT_MESSAGE("did not receive a invalidatetiles: message as 
expected", !response.empty());
+assertResponseLine(socket, "invalidatetiles:", testname);
 }
-
-// While extra invalidates are not desirable, they are inevitable at the 
moment.
-//CPPUNIT_ASSERT_MESSAGE("received unexpected invalidatetiles: message", 
getResponseMessage(socket, "invalidatetiles:").empty());
-
-socket.shutdown();
 }
 
 void TileCacheTests::checkTiles(Poco::Net::WebSocket& socket, const 
std::string& docType, const std::string& name)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildSession.cpp loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/ChildSession.cpp |   12 ++--
 loolwsd/LOOLKit.cpp  |3 ++-
 2 files changed, 8 insertions(+), 7 deletions(-)

New commits:
commit ce832fbc114b7ddcf8fc7802a6a42d6a62254cd5
Author: Ashod Nakashian 
Date:   Sun Oct 2 16:44:11 2016 -0400

loolwsd: get the invalidated part from the callback directly

By default LOK doesn't provide the part where the invalidated
tile is. The part # is found using API, but due to the fact
that callbacks are processed asynchronously, the part #
may well have changed by the time the invalidation is
processed. This could result in buggy invalidations
where no modification took place.

With the new API flag LOK_FEATURE_PART_IN_INVALIDATION_CALLBACK
the part # is included in the callback, which is parsed
and used to inform the client with the correct part #.

Change-Id: Ibd85764bfdc41ebf1aae490df335bd503284ae91
Reviewed-on: https://gerrit.libreoffice.org/29467
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildSession.cpp b/loolwsd/ChildSession.cpp
index 1d39b17..81e5c8d 100644
--- a/loolwsd/ChildSession.cpp
+++ b/loolwsd/ChildSession.cpp
@@ -977,18 +977,17 @@ void ChildSession::loKitCallback(const int nType, const 
std::string& rPayload)
 {
 case LOK_CALLBACK_INVALIDATE_TILES:
 {
-const auto curPart = _loKitDocument->getPart();
-
-StringTokenizer tokens(rPayload, " ", 
StringTokenizer::TOK_IGNORE_EMPTY | StringTokenizer::TOK_TRIM);
-if (tokens.count() == 4)
+StringTokenizer tokens(rPayload, ",", 
StringTokenizer::TOK_IGNORE_EMPTY | StringTokenizer::TOK_TRIM);
+if (tokens.count() == 5)
 {
-int x, y, width, height;
+int part, x, y, width, height;
 try
 {
 x = std::stoi(tokens[0]);
 y = std::stoi(tokens[1]);
 width = std::stoi(tokens[2]);
 height = std::stoi(tokens[3]);
+part = std::stoi(tokens[4]);
 }
 catch (const std::out_of_range&)
 {
@@ -998,10 +997,11 @@ void ChildSession::loKitCallback(const int nType, const 
std::string& rPayload)
 y = 0;
 width = INT_MAX;
 height = INT_MAX;
+part = 0;
 }
 
 sendTextFrame("invalidatetiles:"
-  " part=" + std::to_string(curPart) +
+  " part=" + std::to_string(part) +
   " x=" + std::to_string(x) +
   " y=" + std::to_string(y) +
   " width=" + std::to_string(width) +
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index f73de13..33a4921 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -1105,7 +1105,8 @@ private:
 {
 _loKit->get()->pClass->registerCallback(_loKit->get(), 
GlobalCallback, this);
 const auto flags = LOK_FEATURE_DOCUMENT_PASSWORD
- | LOK_FEATURE_DOCUMENT_PASSWORD_TO_MODIFY;
+ | LOK_FEATURE_DOCUMENT_PASSWORD_TO_MODIFY
+ | LOK_FEATURE_PART_IN_INVALIDATION_CALLBACK;
 _loKit->setOptionalFeatures(flags);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 46200] [RFE] Use the Scroll Lock key as a toggling lock key like Excel

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46200

--- Comment #22 from abhilash300si...@gmail.com ---
(In reply to Markus Mohrhard from comment #13)
> The best method to start debugging is ScTabView::MoveCursorKeyInput.

All of the events inside this function move the current selected cell by
different amounts. We need the function which is called when MouseWheelDown/Up
event happens so that the current selected cell remains as it is and only the
page moves up & down. Is there a way I can check the functions called when
MouseWheelDown/Up event occurs? Or in case you know that function, please
mention the same. Till then, I'd keep looking in the related files. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp loolwsd/PrisonerSession.cpp loolwsd/TileCache.cpp

[Ashod Nakashian]

 loolwsd/DocumentBroker.cpp  |3 ---
 loolwsd/PrisonerSession.cpp |   18 +-
 loolwsd/TileCache.cpp   |   12 ++--
 3 files changed, 11 insertions(+), 22 deletions(-)

New commits:
commit 2907d802a55ec5f4e83650adba9bbb7e7f134e1a
Author: Ashod Nakashian 
Date:   Sun Oct 2 15:30:59 2016 -0400

loolwsd: cleanup and logs

Change-Id: I46eafb970ca144e7eb0837c80d790433cf1e151a
Reviewed-on: https://gerrit.libreoffice.org/29466
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index aeafaa3..d6aba21 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -499,9 +499,6 @@ void DocumentBroker::invalidateTiles(const std::string& 
tiles)
 
 // Remove from cache.
 _tileCache->invalidateTiles(tiles);
-
-//TODO: Re-issue the tiles again to avoid races.
-
 }
 
 void DocumentBroker::handleTileRequest(TileDesc& tile,
diff --git a/loolwsd/PrisonerSession.cpp b/loolwsd/PrisonerSession.cpp
index c2ea47f..cff555e 100644
--- a/loolwsd/PrisonerSession.cpp
+++ b/loolwsd/PrisonerSession.cpp
@@ -56,16 +56,6 @@ bool PrisonerSession::_handleInput(const char *buffer, int 
length)
 
 LOOLWSD::dumpOutgoingTrace(_docBroker->getJailId(), getId(), firstLine);
 
-if (LOOLProtocol::tokenIndicatesUserInteraction(tokens[0]))
-{
-// Keep track of timestamps of incoming client messages that indicate 
user activity.
-updateLastActivityTime();
-}
-
-// Note that this handles both forwarding requests from the client to the 
child process, and
-// forwarding replies from the child process to the client. Or does it?
-
-// Snoop at some messages and manipulate tile cache information as needed
 auto peer = _peer.lock();
 if (!peer)
 {
@@ -139,9 +129,7 @@ bool PrisonerSession::_handleInput(const char *buffer, int 
length)
 return false;
 }
 
-// Save as completed, inform the other (Kind::ToClient)
-// PrisonerSession about it.
-
+// Save-as completed, inform the ClientSession.
 const std::string filePrefix("file:///");
 if (url.find(filePrefix) == 0)
 {
@@ -253,6 +241,10 @@ bool PrisonerSession::_handleInput(const char *buffer, int 
length)
 _docBroker->tileCache().saveRendering(font, "font", buffer + 
firstLine.size() + 1, length - firstLine.size() - 1);
 }
 }
+else
+{
+Log::info("Ignoring notification on password protected document: " + 
firstLine);
+}
 
 // Detect json messages, since we must send those as text even though they 
are multiline.
 // If not, the UI will read the first line of a binary payload, assuming 
that's the only
diff --git a/loolwsd/TileCache.cpp b/loolwsd/TileCache.cpp
index ca8a82a..ddceca8 100644
--- a/loolwsd/TileCache.cpp
+++ b/loolwsd/TileCache.cpp
@@ -331,15 +331,11 @@ void TileCache::invalidateTiles(const std::string& tiles)
 {
 invalidateTiles(-1, 0, 0, INT_MAX, INT_MAX);
 }
-else if (tokens.count() != 6)
-{
-Log::error("Unexpected invalidatetiles request: " + tiles);
-return;
-}
 else
 {
 int part, x, y, width, height;
-if (getTokenInteger(tokens[1], "part", part) &&
+if (tokens.count() == 6 &&
+getTokenInteger(tokens[1], "part", part) &&
 getTokenInteger(tokens[2], "x", x) &&
 getTokenInteger(tokens[3], "y", y) &&
 getTokenInteger(tokens[4], "width", width) &&
@@ -347,6 +343,10 @@ void TileCache::invalidateTiles(const std::string& tiles)
 {
 invalidateTiles(part, x, y, width, height);
 }
+else
+{
+Log::error("Unexpected invalidatetiles request: " + tiles);
+}
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 89546] Single column Autofilter with "Not empty" shows empty cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89546

--- Comment #7 from Kari Salminen  ---
(In reply to Markus Mohrhard from comment #6)
> At least with the test file everything works ok.
> 
> So the autofilter range on the "BAD" sheet only covers the range until D14.
> ANd that part seems to work fine with the "Not empty" flag.

  Ah, so that explains part of this bug. But what about the part where the
filtering doesn't work even after redoing the autofilter completely from
scratch so that its range does encompass all the rows? (Mentioned in comments 1
and 3) That results in this erroneous output:

 # Label
 3 A
 4 B
 6 C
 8 X
10 0
12 1
13

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 44888] "Interaction > Go to page or object" doesn' t work for grouped objects (after save / load)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=44888

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||1992

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101992] Links are missing in exported pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101992

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=44
   ||888
 Ever confirmed|0   |1

--- Comment #6 from Aron Budea  ---
So this is a different issue than the first, right? Can you provide a simple
example for the first one?

The second issue seems to be the same as described in bug 44888.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102923] New: Doubles on startup and in libreoffice menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102923

Bug ID: 102923
   Summary: Doubles on startup and in libreoffice menu
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hh.christ...@royaltransylvania.org

User-Agent:   Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/52.0.2743.116 YaBrowser/16.9.1.1192 Yowser/2.5
Safari/537.36
Build Identifier: LibreOffice 5.2.1.2

upon launching LibreOffice I see the green logo only after a long wait. once
the program is opened (usually from the quick launch icon on the taskbar), my
document is shown. Once i close the document and am taken to the office menu
(what i call it. i do not know what you call it.) the menu flashes.
upon closing the menu and reopening, the LibreOffice green logo shows then
flashes and a second logo pops on top of it.
when opening a document from within the maim menu (where the thumbnails of
documents are shown) and then closing it, the main menu flashes twice.


Reproducible: Always

Steps to Reproduce:
1.open program
2.open document
3.close document
Actual Results:  
same as in summary

Expected Results:  
perform normally with no flashes

[Information automatically included from LibreOffice]
Locale: en-US
Module: StartModule
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: yes


Reset User Profile?No

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102916] every word on a line starts at the beginning of the line, Graphite font rendering on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102916

--- Comment #12 from Jim Brase  ---
(In reply to V Stuart Foote from comment #7)
> So is this a Graphite shaping based font? What was the last build of
> LibreOffice that the fonts rendered correctly for you?

I had to go back and check. It worked OK in 5.0.5.2 Build ID:
55b006a02d247b5f7215fc6ea0fde844b30035b3

It failed in 5.1.0.3 Build ID: 5e3e00a007d9b3b6efb6797a8b8e57b51ab1f737

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102730] EDITING: Image in slide shifts when selected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102730

--- Comment #6 from David F Smith  ---
Aha, I think I found something.  I can make it work properly (no shift on
selection of the image) by disabling the Picture toolbar.  That toolbar (if
selected) appears and disappears when a picture is selected and deselected, and
on my copy it appears on a second toolbar line, below the Standard toolbar.  It
seems that that is what makes my picture shift.

To be specific: 
1. With the image not selected, choose View > Toolbars > Picture.  The Picture
toolbar appears above the slide frame.  If necessary, move the Picture toolbar
to a separate line, so that when it appears there are more lines of toolbars.
2. Select the image.  No problem (no image shift), because the frame is already
sized for the extra toolbar line.
3. Unselect the image.  The Picture toolbar disappears, and the frame expands
to recover the extra space.
4. Select the image again.  The Picture toolbar appears, and the image shifts.
5. Choose View > Toolbars, and uncheck Picture.
6. Unselect the image.
7. Select the image again.  The Picture toolbar does not appear, and the image
does not shift.
8. Choose View > Toolbars, and check Picture.  When the toolbar appears, drag
it to the same line as the Standard toolbar, so that it does not take up any
more vertical space.
9. Unselect and select the image.  The Picture toolbar appears and disappears
as before, but the image does not shift.

If I'm right about the cause of this, and if it's reproducible by somebody
else, then I would phrase my complaint in this way: if the slide frame needs to
be resized because a new toolbar has appeared, the selected image and all other
objects in the slide should stay together and aligned.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102730] EDITING: Image in slide shifts when selected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102730

--- Comment #5 from David F Smith  ---
Here's another couple of observations.

I usually display the slides (Normal View) at the maximum size for the window,
by clicking the four-headed arrow next to the Zoom Level slider.  I'm looking
at one now, in a maximized LO window, and the zoom is at 78%.  When I click on
the photo, so that it shifts its position, the zoom changes to 74%.  When I
unselect the photo by clicking somewhere else, the zoom changes back to 78%.

So can I keep the shift from happening by starting at a smaller zoom?  Nope.  I
set the zoom level at 65% and click on the photo.  It shifts, but the zoom is
unchanged.  Then I unselect it, and the zoom is still 65%.

What happens if the zoom is larger?  I set it to 90%, so that I can't see the
edges of my photo, and click.  The photo shifts, but the zoom stays at 90%.  I
unselect it, and the zoom is still 90%.

Why does the zoom change, if it's at "fit to window"?  Here's a possibility. 
When I click the photo, the Picture toolbar appears above the slide frame, so
there's less room for the slide.  When I unselect, the Picture toolbar goes
away.

For what it's worth.  This is still 100% reproducible for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80731] Incorrect syntax does compile, MID without end bracket

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80731

Pierre Lepage  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |pierrelepa...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102779] Notebookbar: Add spacing/padding around tab labels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102779

--- Comment #2 from General Kutuzov  ---
This is really useful when LO 5.3 interface will be translated into Chinese,
Japanese and Korean.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102779] Notebookbar: Add spacing/padding around tab labels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102779

--- Comment #2 from General Kutuzov  ---
This is really useful when LO 5.3 interface will be translated into Chinese,
Japanese and Korean.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 85951] slow loading of My Macros list while assigning a macro to a toolbar button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85951

Pierre Lepage  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85951] slow loading of My Macros list while assigning a macro to a toolbar button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85951

--- Comment #4 from Pierre Lepage  ---
There are a short time, but nothing major. Given that it has been two years
that the bug was open, I change the status of the bug to RESOLVED-WORKSFORME.

Pierre

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102922] Password fields should use “•” as masking character instead of “*”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102922

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
OK, a reasonable change.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102922] Password fields should use “•” as masking character instead of “*”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102922

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
OK, a reasonable change.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 102922] New: Password fields should use “•” as masking character instead of “*”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102922

Bug ID: 102922
   Summary: Password fields should use “•” as masking character
instead of “*”
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: needsUXEval
  Severity: trivial
  Priority: medium
 Component: UI
  Assignee: libreoffice-b...@lists.freedesktop.org
  Reporter: f...@libreoffice.org
CC: libreoffice-ux-advise@lists.freedesktop.org
Blocks: 102019

Asterisks have long been replaced by bullets in password fields in most
software out there, at least since the Windows XP era. LibreOffice’s
authentication dialogs (e.g., Remote Files) still use asterisks though,
contributing to an outdated look.

I was reminded of this due to the latest logo update by LastPass, in which they
do this exact change due to apparent associations with profanity censoring,
something people use asterisks for. [1]

The Unicode value for the password bullet (from GNOME) is U+2022. This
character is well supported in UI fonts from every platform we run on.

[1]
http://www.underconsideration.com/brandnew/archives/new_logo_for_lastpass.php


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102019
[Bug 102019] [META] Dialog bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102019] [META] Dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102019

Adolfo Jayme  changed:

   What|Removed |Added

 Depends on||102922


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102922
[Bug 102922] Password fields should use “•” as masking character instead of “*”
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102922] New: Password fields should use “•” as masking character instead of “*”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102922

Bug ID: 102922
   Summary: Password fields should use “•” as masking character
instead of “*”
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: needsUXEval
  Severity: trivial
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: f...@libreoffice.org
CC: libreoffice-ux-adv...@lists.freedesktop.org
Blocks: 102019

Asterisks have long been replaced by bullets in password fields in most
software out there, at least since the Windows XP era. LibreOffice’s
authentication dialogs (e.g., Remote Files) still use asterisks though,
contributing to an outdated look.

I was reminded of this due to the latest logo update by LastPass, in which they
do this exact change due to apparent associations with profanity censoring,
something people use asterisks for. [1]

The Unicode value for the password bullet (from GNOME) is U+2022. This
character is well supported in UI fonts from every platform we run on.

[1]
http://www.underconsideration.com/brandnew/archives/new_logo_for_lastpass.php


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102019
[Bug 102019] [META] Dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102916] every word on a line starts at the beginning of the line, Graphite font rendering on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102916

Khaled Hosny  changed:

   What|Removed |Added

 Depends on||89870


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89870
[Bug 89870] Unify text layout to use HarfBuzz on all platforms
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100304] Dual HiDPI monitors, menu and cascading sub-menus display for a second then blank out on secondary screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100304

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102377] FILESAVE: Saving as XLSX resulted in Corrupted file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102377

Luke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Luke  ---
Verified working in Version: 5.3.0.0.alpha0+ (x64)
Build ID: 06f319937187f76ee402d53b3baa78c391c2af19

Jaskaran,
It appears that 06f319937187f76ee402d53b3baa78c391c2af19 has fixed the issue.
Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102916] every word on a line starts at the beginning of the line, Graphite font rendering on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102916

--- Comment #11 from Jim Brase  ---
(In reply to Joel Madero from comment #2)
> Are you 100% sure that the font complies with international standards? Does
> it work right in other software?
> 
> Also can you please attach an actual document and include the font in the
> file. Probably you'll have to upload to a third party and then link. Embed
> Fonts: https://help.libreoffice.org/Common/Embedding_Fonts
> 
> Set to UNCONFIRMED once you attach.

Sorry for the delay. Here's a link to a data file with embedded font.
https://drive.google.com/open?id=0By5sfkbjuePFOG1VTE5jUDlaUTg

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80087] FILESAVE: File Corruption: Roundtrip file gets corrupted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80087

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest, regression |

--- Comment #8 from Xisco Faulí  ---
This doesn't seem to be a regression. I've just tested it in

Version: 4.4.0.0.alpha0+
Build ID: eadc132d5fa339b6fe5b2f8bb482ed30dbd2314

which is the build from  2014-10-13 as in comment 1 and the file is corrupted
when it's opened in office 2010.

Removing keywords bibisectRequest and regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

[Markus Mohrhard]

 sc/qa/unit/data/ods/hyperlink_frame.ods |binary
 sc/qa/unit/subsequent_export-test.cxx   |   26 ++
 2 files changed, 26 insertions(+)

New commits:
commit d0349556c3d045d325d511d8ca4e6ddcac666cf2
Author: Markus Mohrhard 
Date:   Sun Oct 2 19:51:47 2016 +0200

add test for tdf#77873

Change-Id: Ifd16c51029d2aa4deda0370f4d2867ed9c9e53d9
Reviewed-on: https://gerrit.libreoffice.org/29461
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/qa/unit/data/ods/hyperlink_frame.ods 
b/sc/qa/unit/data/ods/hyperlink_frame.ods
new file mode 100644
index 000..cc05949
Binary files /dev/null and b/sc/qa/unit/data/ods/hyperlink_frame.ods differ
diff --git a/sc/qa/unit/subsequent_export-test.cxx 
b/sc/qa/unit/subsequent_export-test.cxx
index 0b78c56..0f19e59 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -57,6 +57,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -175,6 +176,7 @@ public:
 void testNatNumInNumberFormatXLSX();
 
 void testHiddenRepeatedRowsODS();
+void testHyperlinkTargetFrameODS();
 
 CPPUNIT_TEST_SUITE(ScExportTest);
 CPPUNIT_TEST(test);
@@ -258,6 +260,7 @@ public:
 CPPUNIT_TEST(testNatNumInNumberFormatXLSX);
 
 CPPUNIT_TEST(testHiddenRepeatedRowsODS);
+CPPUNIT_TEST(testHyperlinkTargetFrameODS);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -3679,6 +3682,29 @@ void ScExportTest::testHiddenRepeatedRowsODS()
 CPPUNIT_ASSERT_EQUAL((SCROW)20, nLastRow);
 }
 
+void ScExportTest::testHyperlinkTargetFrameODS()
+{
+ScDocShellRef xDocSh = loadDoc("hyperlink_frame.", FORMAT_ODS);
+CPPUNIT_ASSERT(xDocSh.Is());
+
+ScDocument& rDoc = xDocSh->GetDocument();
+const EditTextObject* pEditText = rDoc.GetEditText(ScAddress(2, 5, 0));
+CPPUNIT_ASSERT(pEditText);
+
+const SvxFieldData* pData = pEditText->GetFieldData(0, 0, 
text::textfield::Type::URL);
+CPPUNIT_ASSERT_MESSAGE("Failed to get the URL data.", pData && 
pData->GetClassId() == text::textfield::Type::URL);
+
+const SvxURLField* pURLData = static_cast(pData);
+OUString aTargetFrame = pURLData->GetTargetFrame();
+CPPUNIT_ASSERT_EQUAL(OUString("_blank"), aTargetFrame);
+
+xmlDocPtr pDoc = XPathHelper::parseExport(*xDocSh, m_xSFactory, 
"content.xml", FORMAT_ODS);
+CPPUNIT_ASSERT(pDoc);
+OUString aTargetFrameExport = getXPath(pDoc,
+
"/office:document-content/office:body/office:spreadsheet/table:table/table:table-row[2]/table:table-cell[2]/text:p/text:a",
 "target-frame-name");
+CPPUNIT_ASSERT_EQUAL(OUString("_blank"), aTargetFrameExport);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(ScExportTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Markus Mohrhard]

 sc/source/filter/xml/celltextparacontext.cxx |9 ++---
 sc/source/filter/xml/celltextparacontext.hxx |3 ++-
 sc/source/filter/xml/xmlcelli.cxx|6 --
 sc/source/filter/xml/xmlcelli.hxx|2 +-
 sc/source/filter/xml/xmlexprt.cxx|6 +-
 sc/source/filter/xml/xmlimprt.cxx|1 +
 sc/source/filter/xml/xmlimprt.hxx|1 +
 7 files changed, 20 insertions(+), 8 deletions(-)

New commits:
commit b11ad787372c4b833cc58a3738e375af26309b8d
Author: Markus Mohrhard 
Date:   Sun Oct 2 18:27:32 2016 +0200

support TargetFrame in url field import/export code, tdf#77873

Change-Id: Id09ecbd10b8ee60371f223d62f2dd6fe1c2296ca
Reviewed-on: https://gerrit.libreoffice.org/29459
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/filter/xml/celltextparacontext.cxx 
b/sc/source/filter/xml/celltextparacontext.cxx
index 3f6c64b..dc89e14 100644
--- a/sc/source/filter/xml/celltextparacontext.cxx
+++ b/sc/source/filter/xml/celltextparacontext.cxx
@@ -94,9 +94,9 @@ void ScXMLCellTextParaContext::PushFieldTitle(const OUString& 
rStyleName)
 }
 
 void ScXMLCellTextParaContext::PushFieldURL(
-const OUString& rURL, const OUString& rRep, const OUString& rStyleName)
+const OUString& rURL, const OUString& rRep, const OUString& rStyleName, 
const OUString& rTargetFrame)
 {
-mrParentCxt.PushParagraphFieldURL(rURL, rRep, rStyleName);
+mrParentCxt.PushParagraphFieldURL(rURL, rRep, rStyleName, rTargetFrame);
 }
 
 ScXMLCellTextSpanContext::ScXMLCellTextSpanContext(
@@ -325,6 +325,9 @@ void ScXMLCellFieldURLContext::StartElement(const 
uno::ReferenceSetTargetFrame(rTargetFrame);
+PushParagraphField(pURLField, rStyleName);
 }
 
 void ScXMLTableRowCellContext::PushParagraphEnd()
diff --git a/sc/source/filter/xml/xmlcelli.hxx 
b/sc/source/filter/xml/xmlcelli.hxx
index 2c54516..21a9f21 100644
--- a/sc/source/filter/xml/xmlcelli.hxx
+++ b/sc/source/filter/xml/xmlcelli.hxx
@@ -145,7 +145,7 @@ public:
 void PushParagraphFieldDate(const OUString& rStyleName);
 void PushParagraphFieldSheetName(const OUString& rStyleName);
 void PushParagraphFieldDocTitle(const OUString& rStyleName);
-void PushParagraphFieldURL(const OUString& rURL, const OUString& rRep, 
const OUString& rStyleName);
+void PushParagraphFieldURL(const OUString& rURL, const OUString& rRep, 
const OUString& rStyleName, const OUString& rTargetFrame);
 void PushParagraphEnd();
 
 void SetAnnotation( const ScAddress& rPosition );
diff --git a/sc/source/filter/xml/xmlexprt.cxx 
b/sc/source/filter/xml/xmlexprt.cxx
index 4853373..d28fea3 100644
--- a/sc/source/filter/xml/xmlexprt.cxx
+++ b/sc/source/filter/xml/xmlexprt.cxx
@@ -3007,9 +3007,13 @@ void writeContent(
 {
 // value
 
-OUString aURL = static_cast(pField)->GetURL();
+const SvxURLField* pURLField = static_cast(pField);
+OUString aURL = pURLField->GetURL();
 rExport.AddAttribute(XML_NAMESPACE_XLINK, XML_HREF, 
rExport.GetRelativeReference(aURL));
 rExport.AddAttribute(XML_NAMESPACE_XLINK, XML_TYPE, "simple");
+OUString aTargetFrame = pURLField->GetTargetFrame();
+if (!aTargetFrame.isEmpty())
+rExport.AddAttribute(XML_NAMESPACE_OFFICE, 
XML_TARGET_FRAME_NAME, aTargetFrame);
 
 OUString aElemName = rExport.GetNamespaceMap().GetQNameByKey(
 XML_NAMESPACE_TEXT, GetXMLToken(XML_A));
diff --git a/sc/source/filter/xml/xmlimprt.cxx 
b/sc/source/filter/xml/xmlimprt.cxx
index 018b56e..e972a15 100644
--- a/sc/source/filter/xml/xmlimprt.cxx
+++ b/sc/source/filter/xml/xmlimprt.cxx
@@ -1890,6 +1890,7 @@ const SvXMLTokenMap& 
ScXMLImport::GetCellTextURLAttrTokenMap()
 {
 { XML_NAMESPACE_XLINK, XML_HREF, XML_TOK_CELL_TEXT_URL_ATTR_UREF },
 { XML_NAMESPACE_XLINK, XML_TYPE, XML_TOK_CELL_TEXT_URL_ATTR_TYPE },
+{ XML_NAMESPACE_OFFICE, XML_TARGET_FRAME_NAME, 
XML_TOK_CELL_TEXT_URL_TARGET_FRAME },
 XML_TOKEN_MAP_END
 };
 
diff --git a/sc/source/filter/xml/xmlimprt.hxx 
b/sc/source/filter/xml/xmlimprt.hxx
index 4f8d32b..0e10678 100644
--- a/sc/source/filter/xml/xmlimprt.hxx
+++ b/sc/source/filter/xml/xmlimprt.hxx
@@ -720,6 +720,7 @@ enum ScXMLCellTextURLAttrTokens
 {
 XML_TOK_CELL_TEXT_URL_ATTR_UREF,
 XML_TOK_CELL_TEXT_URL_ATTR_TYPE,
+XML_TOK_CELL_TEXT_URL_TARGET_FRAME
 };
 
 /**
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101150] Formatting: absence of ability to paste from Visual Studio VS as RTF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101150

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #5 from Xisco Faulí  ---
Adding Cc: to Oliver Specht

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70641] No connection to KDE4 address book possible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70641

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Blocks||102495


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96753] KDE: big file opening and navigating is slow vs. 4.3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96753

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Blocks||102495


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78924] UI: Regression: toolbars have different heights

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78924

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Blocks||102495


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70287] Saving a document as certain file types does not populate " Recently Used" in KDE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70287

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Blocks||102495


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102495] [META] KDE bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102495

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Depends on|86472   |96753, 70641, 78924, 70287

--- Comment #1 from Jan-Marek Glogowski  ---
FYI: some bugs have the whiteboard keyword needsKDE.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=70287
[Bug 70287] Saving a document as certain file types does not populate "Recently
Used" in KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=70641
[Bug 70641] No connection to KDE4 address book possible
https://bugs.documentfoundation.org/show_bug.cgi?id=78924
[Bug 78924] UI: Regression: toolbars have different heights
https://bugs.documentfoundation.org/show_bug.cgi?id=86472
[Bug 86472] Borders overlay widget barely readable with dark themes
https://bugs.documentfoundation.org/show_bug.cgi?id=96753
[Bug 96753] KDE: big file opening and navigating is slow vs. 4.3
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97981] cannot select printer options

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97981

Jan-Marek Glogowski  changed:

   What|Removed |Added

 CC||caol...@redhat.com,
   ||glo...@fbihome.de

--- Comment #1 from Jan-Marek Glogowski  ---
The Gtk+ backend implements it's own printer handling. Probably there are some
conflicts when used with KDE, not that I can imagine, how that's possible?!

As the reporter stated, the KDE VCL backend works, as it relies on LO own
printer handling.

As an additional info to the reporter: the icon set can be changed independent
of the backend via Tools -> Options -> LibreOffice -> View -> Icon style.

Not sure, if we want / can to fix Gtk+ VCL. Let's see, if Caolan has an idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

[Henry Castro]

 loleaflet/src/layer/tile/TileLayer.js |   20 
 1 file changed, 12 insertions(+), 8 deletions(-)

New commits:
commit 4074587a128587c9f535dbaac4b98e0ccf628823
Author: Henry Castro 
Date:   Sun Oct 2 16:46:30 2016 -0400

loleaflet: the cell view cursor displays user name

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index b2b1790..061db21 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -665,19 +665,23 @@ L.TileLayer = L.GridLayer.extend({
if (!this._cellViewCursors[viewId] || 
!this._cellViewCursors[viewId].bounds)
return;
 
-   var cellViewCursorsMarker = 
this._cellViewCursors[viewId].marker;
+   var cellViewCursorMarker = this._cellViewCursors[viewId].marker;
var viewPart = this._cellViewCursors[viewId].part;
 
if 
(!this._isEmptyRectangle(this._cellViewCursors[viewId].bounds) && 
this._selectedPart === viewPart) {
-   if (!cellViewCursorsMarker) {
-   cellViewCursorsMarker = 
L.rectangle(this._cellViewCursors[viewId].bounds, {fill: false, color: 
L.LOUtil.getViewIdHexColor(viewId), weight: 2});
-   this._cellViewCursors[viewId].marker = 
cellViewCursorsMarker;
+   if (!cellViewCursorMarker) {
+   var borderColor = 
L.LOUtil.getViewIdHexColor(viewId);
+   cellViewCursorMarker = 
L.rectangle(this._cellViewCursors[viewId].bounds, {fill: false, color: 
borderColor, weight: 2});
+   this._cellViewCursors[viewId].marker = 
cellViewCursorMarker;
+   
cellViewCursorMarker.bindPopup(this._map.getViewName(viewId), {autoClose: 
false, autoPan: false, borderColor: borderColor});
}
-   
cellViewCursorsMarker.setBounds(this._cellViewCursors[viewId].bounds);
-   this._viewLayerGroup.addLayer(cellViewCursorsMarker);
+   else {
+   
cellViewCursorMarker.setBounds(this._cellViewCursors[viewId].bounds);
+   }
+   this._viewLayerGroup.addLayer(cellViewCursorMarker);
}
-   else if (cellViewCursorsMarker) {
-   this._viewLayerGroup.removeLayer(cellViewCursorsMarker);
+   else if (cellViewCursorMarker) {
+   this._viewLayerGroup.removeLayer(cellViewCursorMarker);
}
},
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100604] Should "Clear Direct Formatting" uno: ResetAttribute always be enabled?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100604

--- Comment #5 from Heiko Tietze  ---
(In reply to V Stuart Foote from comment #4)
> Why would they be disabled?

Would be a nice indicator if the object is formatted directly, not necessary
but a nice to have. However, it sounds not that simple to implement.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 100604] Should "Clear Direct Formatting" uno: ResetAttribute always be enabled?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100604

--- Comment #5 from Heiko Tietze  ---
(In reply to V Stuart Foote from comment #4)
> Why would they be disabled?

Would be a nice indicator if the object is formatted directly, not necessary
but a nice to have. However, it sounds not that simple to implement.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #19 from Heiko Tietze  ---
(In reply to V Stuart Foote from comment #14)
> @Jay, Heiko, Samuel, Kendy

You argumentation to focus on styles make sense. Likewise tagezi's concerns of
missing functionality. Let's ask the LibO community to get an impression.

https://plus.google.com/107566594492891737454/posts/T9RpbhVM2cS

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #19 from Heiko Tietze  ---
(In reply to V Stuart Foote from comment #14)
> @Jay, Heiko, Samuel, Kendy

You argumentation to focus on styles make sense. Likewise tagezi's concerns of
missing functionality. Let's ask the LibO community to get an impression.

https://plus.google.com/107566594492891737454/posts/T9RpbhVM2cS

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #18 from kompilainenn <79045_79...@mail.ru> ---
tagezi: do it yourself =) this is easy patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #18 from kompilainenn <79045_79...@mail.ru> ---
tagezi: do it yourself =) this is easy patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102921] Pasting of RTF documents fails.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102921

b...@completegp.ie changed:

   What|Removed |Added

  Component|LibreOffice |Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102921] New: Pasting of RTF documents fails.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102921

Bug ID: 102921
   Summary: Pasting of RTF documents fails.
   Product: LibreOffice
   Version: 5.2.2.2 rc
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: b...@completegp.ie

Pasting of data copied to the clipboard in "Rich Text Format" is not
recognised.
Opening the Clipboard and adding data of type "Rich Text Format" is recognised
by ALL other editors but not LibreOffice (5.x) [4.x worked]. It has even gotten
worse in 5.2.2.2 that a copy of formatted data in WordPad only pastes the Text,
not the formated text (ie. Bold, Font all missing). It can be pasted as an
embedded wordpad document but not as normal formatted text. Many applications
including CompleteGP copy formatted text to the clipboard as "Rich Text Format"
and it can be pasted into Microsoft Word, OpenOffice, LibreOffice 4.x, wordpad,
Adobe and most every other word processor, but not LibreOffice 5.x

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102920] New: shortcut Ctrl+F8 for Calc don't work on Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102920

Bug ID: 102920
   Summary: shortcut Ctrl+F8 for Calc don't work on Linux
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

User-Agent:   Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101
Firefox/50.0
Build Identifier: 

subj

on Windows this shortcut is works

repro on Ubuntu 16.04.1 in LO 5.2.2.2 from official PPA

Reproducible: Always

Steps to Reproduce:
1. open Calc
2. type number in 2-3 cells
3. type text in any cell
4. push Ctrl+F8 (this shortcut for menu item View-Value Highlighting)
Actual Results:  
nothing changed

Expected Results:  
must the numbers to change the color to blue




Reset User Profile?No

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94600] LOOL UX: Resizing images / shapes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94600

Andras Timar  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Andras Timar  ---
Yes, it's fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97041] "Adding Comments" button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97041

Andras Timar  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Andras Timar  ---
Insert Comments button is there long ago, as well as a menu item.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101581] Files with names containing diacritics can' t be opened in LOOL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101581

Andras Timar  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Andras Timar  ---
I fixed collabora/code a few weeks ago. The bug was caused by missing locales.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

V Stuart Foote  changed:

   What|Removed |Added

   Priority|medium  |low
Summary|The item Clear Direct   |Restore Clear Direct
   |Formatting is missing from  |Formatting (an
   |the context menu|uno:ResetAttributes
   ||command) to the context
   ||menu
   Severity|normal  |enhancement

--- Comment #17 from V Stuart Foote  ---
Well, clearly not a bug as it was done intentionally and functions as intended.
At most an enhancment--if ill advised.

Adjusting summary.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

V Stuart Foote  changed:

   What|Removed |Added

   Priority|medium  |low
Summary|The item Clear Direct   |Restore Clear Direct
   |Formatting is missing from  |Formatting (an
   |the context menu|uno:ResetAttributes
   ||command) to the context
   ||menu
   Severity|normal  |enhancement

--- Comment #17 from V Stuart Foote  ---
Well, clearly not a bug as it was done intentionally and functions as intended.
At most an enhancment--if ill advised.

Adjusting summary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 101593] Columns width resizing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101593

Andras Timar  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #1 from Andras Timar  ---
It works for me. I don't know what LibreOffice and LibreOffice Online versions
the reporter tried. Next time, it'd be helpful to include this piece of
information. Help - About menu in LibreOffice Online shows version numbers and
when available, git hashes.

I tried LOOLWSD 1.8.3 and LOKit Collabora Office 5.1-5 (git hash: 455b38e).
Currently LibreOffice Online works well with Collabora Office 5.1 and
LibreOffice from master branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101901] Segmentation Fault when using Libre Office headless SDK 5.2 to create new application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101901

Andras Timar  changed:

   What|Removed |Added

  Component|LibreOffice |sdk
Version|unspecified |5.2.0.4 release
Product|LibreOffice Online  |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102919] AutoCorrect text by applying a style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102919

--- Comment #2 from Leandro Martín Drudi  ---
[ES]
Perdón, pero no sabía que soportaba también el formato.
De todos modos es bastante complicado su uso pues debo entrar a los menús, la
opción Autotexto y buscar lo que quiero insertar. La autocorrección mientras
escribe no funciona con eso o no encuentro la forma.
[EN]
Sorry, but he knew also supported format.
Anyway it's quite complicated because I use to enter the menus, the AutoText
option and look for what I want to insert. The AutoCorrect as you type does not
work with that or not find the way.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101789] FIREBIRD 3 - fails to build on OSX 10.11.6 with clang

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101789

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #6 from Julien Nabet  ---
(In reply to Alex Thurgood from comment #5)
> @Lionel : unfortunately, everytime I apply a patch in my git repo, I screw
> it up and don't know how to back out of it. The last time I tried Tamas'
> build patch, I ended up having to re-clone the repo.

To revert the Lionel's patch for example, you can type these (from core):
git checkout -- external/firebird/ExternalProject_firebird.mk
git checkout -- external/firebird/firebird-macosx.patch.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732

Adolfo Jayme  changed:

   What|Removed |Added

 Depends on||91400


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=91400
[Bug 91400] LibreOffice doesn’t use system font in OS X 10.10+ (Helvetica Neue
in Yosemite, San Francisco in El Capitán)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91400] LibreOffice doesn’t use system font in =?UTF-8?Q?OS=20X=2010=2E10=2B=20?=(Helvetica Neue in Yosemite, San Francisco in El =?UTF-8?Q?Capit=C3=A1n?=)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91400

Adolfo Jayme  changed:

   What|Removed |Added

 Blocks||71732


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
[Bug 71732] [META] Bugs related to text rendering, typography and font features
in LO
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #16 from tagezi  ---
(In reply to V Stuart Foote from comment #14)
> @Jay, Heiko, Samuel, Kendy
> 
> Personally, I don't think so as I find that between the +M global
> shortcut, the Formatting toolbar and the Format menu entry there is more
> than sufficient coverage without needing an item on the context menu(s).

Following your logic, we can remove all the context menu.

Since I use two hands when editing documents, one on the keyboard, and the
other on the mouse, I'll lose up to 3 seconds in any other mode. It can be up
to 3-4 minutes on a document page, just to wave a hand. For me, the most
convenient to use the context menu.

The context menu has a lot of other useless functions (such as copy (Ctrl+C),
cut (Ctrl+X), paste (Ctrl+V), paragraph (because it has to be done through
styles)). Why Clear Direct Formatting?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #16 from tagezi  ---
(In reply to V Stuart Foote from comment #14)
> @Jay, Heiko, Samuel, Kendy
> 
> Personally, I don't think so as I find that between the +M global
> shortcut, the Formatting toolbar and the Format menu entry there is more
> than sufficient coverage without needing an item on the context menu(s).

Following your logic, we can remove all the context menu.

Since I use two hands when editing documents, one on the keyboard, and the
other on the mouse, I'll lose up to 3 seconds in any other mode. It can be up
to 3-4 minutes on a document page, just to wave a hand. For me, the most
convenient to use the context menu.

The context menu has a lot of other useless functions (such as copy (Ctrl+C),
cut (Ctrl+X), paste (Ctrl+V), paragraph (because it has to be done through
styles)). Why Clear Direct Formatting?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

minimal dialog width/size ?

[Cor Nouws]

Hi,

I  notice that an extension, that shows dialogs of which the width/size
is set according to som variables, now produces dialogs with a minimal
height/width..

I think to remember that I have seen something (?) about minimal
width/size of dialogs. Can't find anything in cgit log however.

Anyone a hint?

thanks!
Cor

-- 
Cor Nouws
GPD key ID: 0xB13480A6 - 591A 30A7 36A0 CE3C 3D28  A038 E49D 7365 B134 80A6
- vrijwilliger http://nl.libreoffice.org
- volunteer http://www.libreoffice.org
- The Document Foundation Membership Committee Member
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sd/source

[Markus Mohrhard]

 sd/source/ui/framework/factories/BasicViewFactory.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 5961d5a0e543d7af7c2bd269b2627c6f8d67d036
Author: Markus Mohrhard 
Date:   Sat Oct 1 18:15:55 2016 +0200

uitest: annotate slidesorter window

Change-Id: Ie8c0cf79b8b92908a001271934a81fa2a2d6e693
Reviewed-on: https://gerrit.libreoffice.org/29447
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sd/source/ui/framework/factories/BasicViewFactory.cxx 
b/sd/source/ui/framework/factories/BasicViewFactory.cxx
index ceb65bc..5e16842 100644
--- a/sd/source/ui/framework/factories/BasicViewFactory.cxx
+++ b/sd/source/ui/framework/factories/BasicViewFactory.cxx
@@ -404,6 +404,7 @@ std::shared_ptr 
BasicViewFactory::CreateViewShell (
 ,
 pFrameView,
 bIsCenterPane);
+pViewShell->GetContentWindow()->set_id("slidesorter");
 }
 
 return pViewShell;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102862] Margins of exported PDF are wrong

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102862

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Attachment #127747|video/x-fl  |application/pdf
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102918] Table of contents: document file 'idxexample.odt' is locked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102918

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #2 from Jean-Baptiste Faure  ---
Known problem; see bug 101536.

Best regards. JBF

*** This bug has been marked as a duplicate of bug 101536 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #15 from Cor Nouws  ---
(In reply to V Stuart Foote from comment #14)
> @Jay, Heiko, Samuel, Kendy

> Personally, I don't think so as I find that between the +M global
> ...

and for your convenience: comment 7, comment 11 and comment 12 give arguments
for the other view ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #15 from Cor Nouws  ---
(In reply to V Stuart Foote from comment #14)
> @Jay, Heiko, Samuel, Kendy

> Personally, I don't think so as I find that between the +M global
> ...

and for your convenience: comment 7, comment 11 and comment 12 give arguments
for the other view ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102919] AutoCorrect text by applying a style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102919

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||jbfa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Jean-Baptiste Faure  ---
Did you try autotext ? If not you should because autotext does what you want.
Please give it a try and tell us if that solves this issue for you.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102909] VCL gtk3 menubar not themed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102909

Hanno Meyer-Thurow  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---
 Ever confirmed|0   |1

--- Comment #3 from Hanno Meyer-Thurow  ---
Well, Gentoo builds from source and I know I build against gtk+3.20.x.

And if you had looked at the source you would be enlightened. It is the native
gtk+3.20 themeing introduced by Caolon McNamara in February. And he especially
disabled native menubar themeing for no known reason other than "it does not
work for him on Fedora".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102312] Rendering in v5 is terrible, a bit in v4, non-existant in v3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102312

--- Comment #13 from Aprax  ---
I had some trouble with Windows Update but finaly got completely up-to-date.
I installed the Intel and AMD as you suggested and LO 5.2.2.2 64 bit but still
have rendering issues both with OpenGL Enabled and Disabled. In the end I
unticked all the boxes covering "Use hardware acceleration" down to "Force
OpenGL" and still had problems so I've reverted to LO 4.4.4.3 again.
Here's the list which you asked for earlier showing the new AMD stuff...
==
NameIntel(R) HD Graphics
PNP Device ID   PCI\VEN_8086_0102_D0001458_09\3&13C0B0C5&0&10
Adapter TypeIntel(R) HD Graphics Family, Intel Corporation compatible
Adapter Description Intel(R) HD Graphics
Adapter RAM (2,084,569,088) bytes
Installed Drivers  
igdumd64.dll,igd10umd64.dll,igd10umd64.dll,igdumd32,igd10umd32,igd10umd32
Driver Version  9.17.10.4229
INF Fileoem48.inf (iSNBD0 section)
Color PlanesNot Available
Color Table Entries 4294967296
Resolution  1920 x 1080 x 60 hertz
Bits/Pixel  32
Memory Address  0xFB40-0xFB7F
Memory Address  0xD000-0xDFFF
I/O Port0xFF00-0xFF3F
IRQ Channel IRQ 4294967291
Driver  c:\windows\system32\drivers\igdkmd64.sys (9.17.10.4229, 5.13 MB
(5,375,448 bytes), 2015-05-26 21:02)

NameAMD Radeon HD 6450
PNP Device ID   PCI\VEN_1002_6779_25471458_00\4&2D68EC9A&0&0008
Adapter TypeAMD Radeon Graphics Processor (0x6779), Advanced Micro Devices,
Inc. compatible
Adapter Description AMD Radeon HD 6450
Adapter RAM 1.00 GB (1,073,741,824 bytes)
Installed Drivers  
aticfx64.dll,aticfx64.dll,aticfx64.dll,aticfx32,aticfx32,aticfx32,atiumd64.dll,atidxx64.dll,atidxx64.dll,atiumdag,atidxx32,atidxx32,atiumdva,atiumd6a.cap,atitmm64.dll
Driver Version  15.200.1062.1004
INF Fileoem25.inf (ati2mtag_NI section)
Color PlanesNot Available
Color Table Entries Not Available
Resolution  Not Available
Bits/Pixel  Not Available
Memory Address  0xE000-0xEFFF
Memory Address  0xFBAC-0xFBAD
I/O Port0xCE00-0xCEFF
IRQ Channel IRQ 4294967290
I/O Port0x03B0-0x03BB
I/O Port0x03C0-0x03DF
Memory Address  0xA-0xB
Driver  c:\windows\system32\drivers\atikmpag.sys (8.14.1.6463, 649.50 KB
(665,088 bytes), 2016-10-02 13:47)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102904] Calc crashes when filtering dates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102904

Jean-Baptiste Faure  changed:

   What|Removed |Added

 OS|Windows (All)   |All

--- Comment #7 from Jean-Baptiste Faure  ---
>From French QA ML : reproduced on Linux too.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102904] Calc crashes when filtering dates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102904

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||jbfa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #6 from Jean-Baptiste Faure  ---
this bug has been confirmed -> set back to NEW.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102052] Print Directly printer string should only appear in the tooltip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102052

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #1 from Buovjaga  ---
Let's set to NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102049] Changing decimal places in DRAW measurements and displaying dimensions.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102049

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
Version|unspecified |5.1.0.3 release
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Note for testers: Decimal places are under Dimensioning tab.

I do not reproduce the problem.

Please try with 5.2.

Set to NEEDINFO.
Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED
WORKSFORME, if the problem went away.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.2.2.2.0+
Build ID: 5.2.2-1
CPU Threads: 8; OS Version: Linux 4.7; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #14 from V Stuart Foote  ---
@Jay, Heiko, Samuel, Kendy

Did Maxim overshoot during conversion of the context menus for customization?
Should a "Clear Direct Formatting" be included by default on the context menu?

Personally, I don't think so as I find that between the +M global
shortcut, the Formatting toolbar and the Format menu entry there is more than
sufficient coverage without needing an item on the context menu(s).

Stuart

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #14 from V Stuart Foote  ---
@Jay, Heiko, Samuel, Kendy

Did Maxim overshoot during conversion of the context menus for customization?
Should a "Clear Direct Formatting" be included by default on the context menu?

Personally, I don't think so as I find that between the +M global
shortcut, the Formatting toolbar and the Format menu entry there is more than
sufficient coverage without needing an item on the context menu(s).

Stuart

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 92657] Questionable Default for Bullet Sizing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92657

Buovjaga  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 92657] Questionable Default for Bullet Sizing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92657

Buovjaga  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102035] When attempting to change a non-standard font, the system goes woozy, hangs for 2~3 minutes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102035

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
I tried with the Masala Mix heading in
http://www.babas.com.my/index.php/business/product-masala-mix but LibreOffice
pastes it as Liberation Serif. I see no problem.

Maybe try with LibreOffice 5.2.

Set to NEEDINFO.
Change back to UNCONFIRMED, if the problem persists with 5.2. Change to
RESOLVED WORKSFORME, if the problem went away.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.2.2.2.0+
Build ID: 5.2.2-1
CPU Threads: 8; OS Version: Linux 4.7; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.0.0.alpha0+
Build ID: dc41255dc725dfa912326cc5d9e420bd66471c64
CPU Threads: 8; OS Version: Linux 4.7; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on October 1st 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102022] Sidebar properties style dropdown font is unreadably tiny

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102022

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #2 from Buovjaga  ---
So these are with documents with custom styles? The style preview shows it like
it is, so if the font size is tiny, it is shown tiny. There is discussion in
some report about this problem, the design team knows it.

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102916] every word on a line starts at the beginning of the line, Graphite font rendering on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102916

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
Summary|every word on a line starts |every word on a line starts
   |at the beginning of the |at the beginning of the
   |line|line, Graphite font
   ||rendering on Windows

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

Cor Nouws  changed:

   What|Removed |Added

 Status|REOPENED|NEW

--- Comment #13 from Cor Nouws  ---
Maybe looking at this specific commend in a UX-meeting (again?) is useful?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102919] New: AutoCorrect text by applying a style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102919

Bug ID: 102919
   Summary: AutoCorrect text by applying a style
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sanipache...@outlook.com.ar

Created attachment 127780
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127780=edit
LibreOffice with self-correction in green and small caps

[ES]
Actualmente debemos escribir un texto y aplicarle un estilo manualmente. Si se
desea escribir una palabra o frase específica y aplicarle siempre un mismo
formato, uno debe hacerlo manualmente en cada aparición.
Crear una forma de aplicar formato específico o un estilo completo a cierto
texto especificado sería una excelente mejora.
Esta herramienta existe en, por ejemplo, Adobe IdDesign como Estilos GREP.

[EN]
Today we must write a text and apply a style manually. If you want to write a
specific word or phrase and always apply the same format, you must do it
manually at each occurrence.
Create a way to apply specific format or a complete style to a specified text
would be a great improvement.
This tool exists, for example, Adobe IdDesign as GREP Styles.

(In the Screen capture):
[ES]
Al escribir LibreOffice debo aplicar el estilo manualmente. Pero con esta
mejora, sólo escribo LO y se autocorrige a LibreOffice y se aplica el estilo de
colore verde y versalitas.
[EN]
When writing LibreOffice should I apply the style manually. But with this
improvement, just write LO and self-corrects to LibreOffice and style green and
small caps colore applies.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

Cor Nouws  changed:

   What|Removed |Added

 Status|REOPENED|NEW

--- Comment #13 from Cor Nouws  ---
Maybe looking at this specific commend in a UX-meeting (again?) is useful?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

Cor Nouws  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---

--- Comment #12 from Cor Nouws  ---
Hi Stuart,

Thanks for the new arguments. However, to me it looks that this command has
been removed maybe in a slip..

(In reply to V Stuart Foote from comment #8)
> @Cor, *
> 
> It was removed during Maxim's work on making all src based context menus
> user customizable implementing XML configuration for bug 93837 

For now, I have see no argumentation to remove that specific command.

> Followed recommended simplifications of the context menu per Design UX
> decision as argued in bug 81132 and bug 86606

Which is a good thing in general.

> With XML based customization now supported--no reason to keep unhelpful
> defaults in the context menus.

I don't think it's unhelpful at all.
Copy/Cut/Paste are in the context menu, main menu, toolbars and have shortcuts.
Clear Direct Formatting is maybe not that often used, but at least as
important.

See also my arguments in comment 7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

Cor Nouws  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---

--- Comment #12 from Cor Nouws  ---
Hi Stuart,

Thanks for the new arguments. However, to me it looks that this command has
been removed maybe in a slip..

(In reply to V Stuart Foote from comment #8)
> @Cor, *
> 
> It was removed during Maxim's work on making all src based context menus
> user customizable implementing XML configuration for bug 93837 

For now, I have see no argumentation to remove that specific command.

> Followed recommended simplifications of the context menu per Design UX
> decision as argued in bug 81132 and bug 86606

Which is a good thing in general.

> With XML based customization now supported--no reason to keep unhelpful
> defaults in the context menus.

I don't think it's unhelpful at all.
Copy/Cut/Paste are in the context menu, main menu, toolbars and have shortcuts.
Clear Direct Formatting is maybe not that often used, but at least as
important.

See also my arguments in comment 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101983] Crash when auto file saving

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101983

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Do you mean the file is open in OwnCloud? With the WebODF editor or LibreOffice
Online?

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96753] KDE: big file opening and navigating is slow vs. 4.3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96753

Jan-Marek Glogowski  changed:

   What|Removed |Added

 CC||glo...@fbihome.de

--- Comment #27 from Jan-Marek Glogowski  ---
Master got the commit 9f4af777a832d8a0b9a21d793d421fa6228131e0 for slow loading
in non-double-buffering backends, like KDE4.

Author: Jan-Marek Glogowski 
AuthorDate: Mon Jul 18 13:21:14 2016 +0200
Commit: Noel Grandin 
CommitDate: Wed Jul 27 06:47:03 2016 +

Don't Update() and Flush() status bar draws

From reading the code of vcl::Window::Update, this already calls
Invalidate and Flush in case of top-level widgets and also handles
child windows.

And there is no need to invalidate the progress bar text, if we
just update the progress value.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/master/ . More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

The general performance regression is IMHO due to the new VCL scheduler. There
is currently a feature branch feature/new-vcl-scheduler, but some LOK unit
tests still fail, so it's WIP.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89537] Undo and redo dropdowns do not work very well on KDE Plasma 5

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89537

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Blocks||102495


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47709] Writer does not respect the KDE system setting paper size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47709

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Blocks||102495


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102495] [META] KDE bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102495

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Depends on||89537, 47709


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=47709
[Bug 47709] Writer does not respect the KDE system setting paper size
https://bugs.documentfoundation.org/show_bug.cgi?id=89537
[Bug 89537] Undo and redo dropdowns do not work very well on KDE Plasma 5
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102377] FILESAVE: Saving as XLSX resulted in Corrupted file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102377

--- Comment #5 from Luke  ---
Jaskaran,
You don't need excel to verify this bug, just go to 
https://onedrive.live.com/
If you try to upload the file, you'll get the following error:
"We're sorry we could not open your workbook. It may be corrupt or use a format
the we do not support"


Also I tried to narrow down the exact commit, but I kept getting build errors.
I was able to reduce the rage to this:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=e28d52387383d5b9b3554f364e885a20f4292d81..3287bc2f91438085b7604773d5e0346fc3c3f452
Would it help for me to try to whittle the range down more?

I'll try a recent build tonight and report back if it's fixed or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #11 from tagezi  ---
(In reply to V Stuart Foote from comment #10)
> (In reply to tagezi from comment #9)
> > Could you give a link to studies that suggest that this item is not needed?
> > Or is it the opinion of 5 people who decide that the 2-million people are
> > needed and what is not?
> 
> See also, and we meet continually
> http://webchat.freenode.net/?channels=libreoffice-design
> 
> and hold Weekly meeting in-person via Google Hangouts
> 
> https://wiki.documentfoundation.org/Design/Meetings
> 
> feel free to drop in and contribute.

I'm sorry, but that you have indicated there is no new information. Removing
the item is not only logical, but also harmful. And the fact that the design
team did not see such a simple thing very frustrating. I feel that with this
approach, the design team will create us something like MSO - absolutely not
usability thing.

Moreover, I have already said:

(In reply to V Stuart Foote from comment #10)
> (In reply to tagezi from comment #9)
> I tried to add this item to the menu. But when installing the new version,
> he disappears again. Also, I will have to add it each time when the user
> profile reset , if the bug is associated with it. So, I add it for the third
> time in the menu for the last 2 months.

In addition, I can say that I am in a chat under the same nickname almost
constantly (24/7/365).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #11 from tagezi  ---
(In reply to V Stuart Foote from comment #10)
> (In reply to tagezi from comment #9)
> > Could you give a link to studies that suggest that this item is not needed?
> > Or is it the opinion of 5 people who decide that the 2-million people are
> > needed and what is not?
> 
> See also, and we meet continually
> http://webchat.freenode.net/?channels=libreoffice-design
> 
> and hold Weekly meeting in-person via Google Hangouts
> 
> https://wiki.documentfoundation.org/Design/Meetings
> 
> feel free to drop in and contribute.

I'm sorry, but that you have indicated there is no new information. Removing
the item is not only logical, but also harmful. And the fact that the design
team did not see such a simple thing very frustrating. I feel that with this
approach, the design team will create us something like MSO - absolutely not
usability thing.

Moreover, I have already said:

(In reply to V Stuart Foote from comment #10)
> (In reply to tagezi from comment #9)
> I tried to add this item to the menu. But when installing the new version,
> he disappears again. Also, I will have to add it each time when the user
> profile reset , if the bug is associated with it. So, I add it for the third
> time in the menu for the last 2 months.

In addition, I can say that I am in a chat under the same nickname almost
constantly (24/7/365).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102917] Insert and edit comments options causes problem with format toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102917

--- Comment #10 from Robert Gonzalez MX  ---
Tested and reproduced with Version: 5.3.0.0.alpha0+
Build ID: 55c30b56ed9bfe44ab2a2a6861aa3d9ad2d16601
CPU Threads: 8; OS Version: Linux 4.1; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-10-01_23:22:27
Locale: es-MX (es_MX.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #10 from V Stuart Foote  ---
(In reply to tagezi from comment #9)
> Could you give a link to studies that suggest that this item is not needed?
> Or is it the opinion of 5 people who decide that the 2-million people are
> needed and what is not?

See also, and we meet continually
http://webchat.freenode.net/?channels=libreoffice-design

and hold Weekly meeting in-person via Google Hangouts

https://wiki.documentfoundation.org/Design/Meetings

feel free to drop in and contribute.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102915] The item Clear Direct Formatting is missing from the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #10 from V Stuart Foote  ---
(In reply to tagezi from comment #9)
> Could you give a link to studies that suggest that this item is not needed?
> Or is it the opinion of 5 people who decide that the 2-million people are
> needed and what is not?

See also, and we meet continually
http://webchat.freenode.net/?channels=libreoffice-design

and hold Weekly meeting in-person via Google Hangouts

https://wiki.documentfoundation.org/Design/Meetings

feel free to drop in and contribute.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 86606] CONTEXT MENU: Removal of remaining direct formatting entries

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86606

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2915

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise