date:20161212

Re: Build Problem with Lode

2016-12-12 Thread Yossi Zahn




On 11/12/2016 11:30 PM, Jason Marshall wrote:
I have tried to get some understanding of JScript and have inferred 
that for the purpose of building LibreOffice that it would require 
'JScript .NET' as opposed to simply 'JScript', where the latter is for 
hosting JScript inside a webpage.  I have therefore checked the 
installation status of '.NET Framework' and can report that the 
following items are installed:

AFAIK the windows scripting host does not require .net framework at all.
Do you get the same error when creating a text file containing the 
following single line:

var fso = new ActiveXObject("Scripting.FileSystemObject");
and running it as such:
cscript /e:javascript path/to/file
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 99677] Opentype ligatures and context alternatives no longer work

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99677

tommy27  changed:

   What|Removed |Added

 CC||ba...@quipo.it
 Resolution|FIXED   |WORKSFORME

--- Comment #23 from tommy27  ---
@Volga
did you effectively test this in 5.3.x?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96221] Crash during open CSV file - SEH Exception ( when UTF character set selected)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96221

Timur  changed:

   What|Removed |Added

   Priority|high|low

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92950] No support for sqlite relations via Relations menu

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92950

--- Comment #16 from Alex Thurgood  ---
Still present in master 5400 alpha

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104573] Assertion failed: SolarMutex not locked when trying to bring up File Open... dialog ( debug build)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104573

--- Comment #11 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f04ec99f5e6a543b8191ced61db4710c3c0de356

tdf#104573 - Assertion failed: SolarMutex not locked

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/vcl vcl/source

2016-12-12 Thread Noel Grandin

 include/vcl/event.hxx   |1 +
 vcl/source/window/event.cxx |6 ++
 vcl/source/window/mouse.cxx |3 +++
 3 files changed, 10 insertions(+)

New commits:
commit f04ec99f5e6a543b8191ced61db4710c3c0de356
Author: Noel Grandin 
Date:   Tue Dec 13 09:48:52 2016 +0200

tdf#104573 - Assertion failed: SolarMutex not locked

Change-Id: Ie46f0e2b60b99aea1c322c7891a41a2e7603c9e9

diff --git a/include/vcl/event.hxx b/include/vcl/event.hxx
index 9737bac..a5820c1 100644
--- a/include/vcl/event.hxx
+++ b/include/vcl/event.hxx
@@ -317,6 +317,7 @@ public:
 NotifyEvent( MouseNotifyEvent nEventType,
  vcl::Window* pWindow,
  const void* pEvent = nullptr );
+~NotifyEvent();
 
 MouseNotifyEventGetType() const { return mnEventType; }
 vcl::Window*GetWindow() const { return mpWindow; }
diff --git a/vcl/source/window/event.cxx b/vcl/source/window/event.cxx
index 38815a3..8feb212 100644
--- a/vcl/source/window/event.cxx
+++ b/vcl/source/window/event.cxx
@@ -658,4 +658,10 @@ NotifyEvent::NotifyEvent( MouseNotifyEvent nEventType, 
vcl::Window* pWindow,
 mnEventType  = nEventType;
 }
 
+NotifyEvent::~NotifyEvent()
+{
+SolarMutexGuard aVclGuard;
+mpWindow.clear();
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/window/mouse.cxx b/vcl/source/window/mouse.cxx
index d1cc051..b769a83 100644
--- a/vcl/source/window/mouse.cxx
+++ b/vcl/source/window/mouse.cxx
@@ -161,7 +161,10 @@ void Window::ImplCallMouseMove( sal_uInt16 nMouseCode, 
bool bModChanged )
 void Window::ImplGenerateMouseMove()
 {
 if ( !mpWindowImpl->mpFrameData->mnMouseMoveId )
+{
+SolarMutexGuard aVclGuard;
 mpWindowImpl->mpFrameData->mnMouseMoveId = Application::PostUserEvent( 
LINK( mpWindowImpl->mpFrameWindow, Window, ImplGenerateMouseMoveHdl ), nullptr, 
true );
+}
 }
 
 IMPL_LINK_NOARG(Window, ImplGenerateMouseMoveHdl, void*, void)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104510] Go to page dialog (Ctrl-g) should appear in the top right corner

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104510

--- Comment #8 from Buovjaga  ---
(In reply to Pr410 from comment #7)
> Hi Buovjaga,
> I agree with you; it's not a big deal. However, if design team can try this
> and we all can compare the difference. If not I am fine with that.

Btw. you are encouraged to join the team:
https://wiki.documentfoundation.org/Design
Check "Get in contact" section.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46941] FORMATTING: Saving .doc to .docx changes placement of text inside columns.

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=46941

--- Comment #12 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ede1a83e110ce7bc7d3560f415d6269ea3feb947

tdf#46941 docx: don't balance columns before page-break-section

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46941] FORMATTING: Saving .doc to .docx changes placement of text inside columns.

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=46941

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|interoperability|interoperability
   ||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97736] Wrong display Thai language for some release version

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97736

--- Comment #12 from Buovjaga  ---
(In reply to Teeravut from comment #10)
> Created attachment 129561 [details]
> Thai character after English character
> 
> I still found problem on Version 5.2.3.3. If I typed Thai Character on
> field, It worked fine. But If I type first character with English and type
> Thai Character after that. It still display wrong. I noticed that It has
> problem with Tone (Thai language has tone)

This should be fixed in 5.3: bug 99677

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa writerfilter/source

2016-12-12 Thread Justin Luth

 sw/qa/extras/ooxmlexport/data/tdf46940_dontEquallyDistributeColumns.docx 
|binary
 sw/qa/extras/ooxmlexport/ooxmlexport9.cxx|   
10 
 writerfilter/source/dmapper/PropertyMap.cxx  |   
21 +-
 writerfilter/source/dmapper/PropertyMap.hxx  |
2 
 4 files changed, 32 insertions(+), 1 deletion(-)

New commits:
commit ede1a83e110ce7bc7d3560f415d6269ea3feb947
Author: Justin Luth 
Date:   Sat Dec 10 09:35:09 2016 +0300

tdf#46941 docx: don't balance columns before page-break-section

Pleasantly surprised to see we already don't balance before
regular page-breaks or at the end of the document. This adds
not balancing before a page-break-section.

Change-Id: Ifedff5cc45b154a005f13b3212154c443727e286
Reviewed-on: https://gerrit.libreoffice.org/31826
Tested-by: Jenkins 
Reviewed-by: Justin Luth 
Reviewed-by: Miklos Vajna 

diff --git 
a/sw/qa/extras/ooxmlexport/data/tdf46940_dontEquallyDistributeColumns.docx 
b/sw/qa/extras/ooxmlexport/data/tdf46940_dontEquallyDistributeColumns.docx
new file mode 100644
index 000..657da5e
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf46940_dontEquallyDistributeColumns.docx 
differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
index 606510f..1c73850 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
@@ -67,6 +67,16 @@ DECLARE_OOXMLEXPORT_TEST(testTdf41542_borderlessPadding, 
"tdf41542_borderlessPad
 CPPUNIT_ASSERT_EQUAL( 3, getPages() );
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf46940_dontEquallyDistributeColumns, 
"tdf46940_dontEquallyDistributeColumns.docx")
+{
+uno::Reference 
xTextSectionsSupplier(mxComponent, uno::UNO_QUERY);
+uno::Reference 
xTextSections(xTextSectionsSupplier->getTextSections(), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(false, 
getProperty(xTextSections->getByIndex(0), "DontBalanceTextColumns"));
+// This was false, columns before a section-page-break were balanced.
+CPPUNIT_ASSERT_EQUAL(true, getProperty(xTextSections->getByIndex(2), 
"DontBalanceTextColumns"));
+CPPUNIT_ASSERT_EQUAL(true, getProperty(xTextSections->getByIndex(3), 
"DontBalanceTextColumns"));
+}
+
 DECLARE_OOXMLEXPORT_TEST(testRhbz988516, "rhbz988516.docx")
 {
 // The problem was that the list properties of the footer leaked into body
diff --git a/writerfilter/source/dmapper/PropertyMap.cxx 
b/writerfilter/source/dmapper/PropertyMap.cxx
index 03198f3..cea2dc4 100644
--- a/writerfilter/source/dmapper/PropertyMap.cxx
+++ b/writerfilter/source/dmapper/PropertyMap.cxx
@@ -398,6 +398,7 @@ SectionPropertyMap::SectionPropertyMap(bool 
bIsFirstSection) :
 ,m_bTitlePage( false )
 ,m_nColumnCount( 0 )
 ,m_nColumnDistance( 1249 )
+,m_xColumnContainer( nullptr )
 ,m_bSeparatorLineIsOn( false )
 ,m_bEvenlySpaced( false )
 ,m_bIsLandscape( false )
@@ -698,6 +699,18 @@ void SectionPropertyMap::SetBorderDistance( 
uno::Reference< beans::XPropertySet
 xStyle->setPropertyValue( sBorderDistanceName, uno::makeAny( nDist ));
 }
 
+void SectionPropertyMap::DontBalanceTextColumns()
+{
+try
+{
+if( m_xColumnContainer.is() )
+m_xColumnContainer->setPropertyValue("DontBalanceTextColumns", 
uno::makeAny(true));
+}
+catch( const uno::Exception& )
+{
+OSL_FAIL( "Exception in SectionPropertyMap::DontBalanceTextColumns");
+}
+}
 
 uno::Reference< text::XTextColumns > SectionPropertyMap::ApplyColumnProperties(
 uno::Reference< beans::XPropertySet > const& 
xColumnContainer, DomainMapper_Impl& rDM_Impl )
@@ -757,8 +770,9 @@ uno::Reference< text::XTextColumns > 
SectionPropertyMap::ApplyColumnProperties(
 }
 xColumnContainer->setPropertyValue( sTextColumns, uno::makeAny( 
xColumns ) );
 // Set the columns to be unbalanced if that compatibility option is 
set or this is the last section.
+m_xColumnContainer = xColumnContainer;
 if (rDM_Impl.GetSettingsTable()->GetNoColumnBalance() || 
rDM_Impl.GetIsLastSectionGroup())
-xColumnContainer->setPropertyValue("DontBalanceTextColumns", 
uno::makeAny(true));
+DontBalanceTextColumns();
 }
 catch( const uno::Exception& )
 {
@@ -1236,6 +1250,11 @@ void SectionPropertyMap::CloseSectionGroup( 
DomainMapper_Impl& rDM_Impl )
 if( m_nColumnCount > 0 )
 xColumns = ApplyColumnProperties( xFollowPageStyle, rDM_Impl );
 
+// these BreakTypes are effectively page-breaks: don't evenly 
distribute text in columns before a page break;
+SectionPropertyMap* pLastContext = rDM_Impl.GetLastSectionContext();
+if( pLastContext && pLastContext->ColumnCount() )
+

[Libreoffice-bugs] [Bug 46892] Provide stacktraces for crashes

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=46892

--- Comment #11 from Vidhey PV  ---
can anyone please explain what needs to be done here??(in some detail please)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 69651] FILEOPEN: .DOC file with tables mangled

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=69651

Buovjaga  changed:

   What|Removed |Added

   Keywords||filter:doc
Version|4.1.1.2 release |4.0.0.3 release
 Whiteboard|BSA |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97736] Wrong display Thai language for some release version

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97736

--- Comment #11 from tommy27  ---
open a new clean bug report about this latest issue.

you don't need to upload again the screenshot.
you may just cite them along with their attachement numbers

i.e. type attachment 129561  and the link will be automatically highlighted

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104606] Left-to-right (vertical) direction not available in Calc and Impress

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104606

--- Comment #1 from Volga  ---
Created attachment 129563
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129563=edit
Full text of the standard

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104606] Left-to-right (vertical) direction not available in Calc and Impress

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104606

Volga  changed:

   What|Removed |Added

URL|http://down.bzwxw.com/21/GB |http://www.bzwxw.com/html/2
   |_T%2026233-2010.pdf |1/5970.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103735] Text box always be nestled on the left edge of the page in LTR (vertical) direction

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103735

--- Comment #5 from Volga  ---
This problem also affect fontworks, you can get attachment 129509 to test.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - svx/source

2016-12-12 Thread Julien Nabet

 svx/source/table/tablecontroller.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 41fc6366c53323c46769f2c367d8f8d6cf02878b
Author: Julien Nabet 
Date:   Sun Nov 20 10:22:56 2016 +0100

tdf#88351: Revert "coverity#704341 Logically dead code"

This reverts commit 7b1f5cc16fdbc0c53d0b7f9e3f45decd1136f4fa.

Change-Id: I85d4c45025817914d6b78458f24a343f3b05879c
Reviewed-on: https://gerrit.libreoffice.org/31017
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 
(cherry picked from commit 5507b741ccf018c06fb29694d13837abcac4486a)
Reviewed-on: https://gerrit.libreoffice.org/31023
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/svx/source/table/tablecontroller.cxx 
b/svx/source/table/tablecontroller.cxx
index 5119b88..0115331 100644
--- a/svx/source/table/tablecontroller.cxx
+++ b/svx/source/table/tablecontroller.cxx
@@ -2728,7 +2728,7 @@ bool SvxTableController::ApplyFormatPaintBrush( 
SfxItemSet& rFormatSet, bool bNo
 {
 if( (*pRanges != EE_PARA_START) && (*pRanges != EE_CHAR_START) )
 {
-bTextOnly = false;
+bTextOnly = true;
 break;
 }
 pRanges += 2;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: desktop/source include/sfx2 sfx2/source svx/source

2016-12-12 Thread Samuel Mehrbrodt

 desktop/source/app/app.cxx   |5 -
 include/sfx2/safemode.hxx|   24 +++-
 sfx2/source/safemode/safemode.cxx|   35 ++-
 svx/source/dialog/SafeModeDialog.cxx |1 +
 4 files changed, 58 insertions(+), 7 deletions(-)

New commits:
commit 0fda52cc4a5c78c55f96850faa734ea66891808c
Author: Samuel Mehrbrodt 
Date:   Mon Dec 12 17:29:28 2016 +0100

SafeMode: Restart goes into safe mode again

Looks like the XRestartManager keeps all command line arguments when
restarting, so it also keeps --safe-mode.

Solution is to add a flag file when restarting from safe mode,
to prevent going into safe mode again.

Change-Id: I9820d3ccbddf98b0bf6132f254c989f52ea5e808
Reviewed-on: https://gerrit.libreoffice.org/31913
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index eba8bf6..437ff51 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -560,7 +560,10 @@ void Desktop::Init()
 
 // Check whether safe mode is enabled
 CommandLineArgs& rCmdLine = GetCommandLineArgs();
-if (rCmdLine.IsSafeMode() || sfx2::SafeMode::hasFlag())
+// Check if we are restarting from safe mode - in that case we don't want 
to enter it again
+if (sfx2::SafeMode::hasRestartFlag())
+sfx2::SafeMode::removeRestartFlag();
+else if (rCmdLine.IsSafeMode() || sfx2::SafeMode::hasFlag())
 Application::EnableSafeMode();
 
 // When we are in SafeMode we need to do changes before the configuration
diff --git a/include/sfx2/safemode.hxx b/include/sfx2/safemode.hxx
index 03f8590..47034f6 100644
--- a/include/sfx2/safemode.hxx
+++ b/include/sfx2/safemode.hxx
@@ -40,9 +40,31 @@ public:
  */
 static bool removeFlag();
 
+/**
+ * Write a flag to the user profile indicating that we are currently 
restarting from safe mode -
+ * that means we don't want to enter safe mode again.
+ *
+ * @return Whether the file could be written successfully
+ */
+static bool putRestartFlag();
+
+/**
+ * Check the existence of the restart flag file.
+ *
+ * @return Whether the restart flag file exists
+ */
+static bool hasRestartFlag();
+
+/**
+ * Remove the restart flag file.
+ *
+ * @return Whether the flag file could be removed successfully
+ */
+static bool removeRestartFlag();
+
 private:
 /** Returns the path of the safe mode flag file.*/
-static OUString getFileName();
+static OUString getFilePath(const OUString& sFilename);
 };
 
 }
diff --git a/sfx2/source/safemode/safemode.cxx 
b/sfx2/source/safemode/safemode.cxx
index 3e84f7e..6d8dcf9 100644
--- a/sfx2/source/safemode/safemode.cxx
+++ b/sfx2/source/safemode/safemode.cxx
@@ -20,7 +20,7 @@ namespace sfx2 {
 
 bool SafeMode::putFlag()
 {
-File safeModeFile(getFileName());
+File safeModeFile(getFilePath("safemode"));
 if (safeModeFile.open(osl_File_OpenFlag_Create) == FileBase::E_None)
 {
 safeModeFile.close();
@@ -30,7 +30,7 @@ bool SafeMode::putFlag()
 }
 bool SafeMode::hasFlag()
 {
-File safeModeFile(getFileName());
+File safeModeFile(getFilePath("safemode"));
 if (safeModeFile.open(osl_File_OpenFlag_Read) == FileBase::E_None)
 {
 safeModeFile.close();
@@ -40,17 +40,42 @@ bool SafeMode::hasFlag()
 }
 bool SafeMode::removeFlag()
 {
-return File::remove(getFileName()) == FileBase::E_None;
+return File::remove(getFilePath("safemode")) == FileBase::E_None;
 }
 
-OUString SafeMode::getFileName()
+bool SafeMode::putRestartFlag()
+{
+File restartFile(getFilePath("safemode_restart"));
+if (restartFile.open(osl_File_OpenFlag_Create) == FileBase::E_None)
+{
+restartFile.close();
+return true;
+}
+return false;
+}
+bool SafeMode::hasRestartFlag()
+{
+File restartFile(getFilePath("safemode_restart"));
+if (restartFile.open(osl_File_OpenFlag_Read) == FileBase::E_None)
+{
+restartFile.close();
+return true;
+}
+return false;
+}
+bool SafeMode::removeRestartFlag()
+{
+return File::remove(getFilePath("safemode_restart")) == FileBase::E_None;
+}
+
+OUString SafeMode::getFilePath(const OUString& sFilename)
 {
 OUString url("${$BRAND_BASE_DIR/" LIBO_ETC_FOLDER "/" 
SAL_CONFIGFILE("bootstrap") ":UserInstallation}/");
 rtl::Bootstrap::expandMacros(url);
 
 OUString aProfilePath;
 FileBase::getSystemPathFromFileURL(url, aProfilePath);
-FileBase::getAbsoluteFileURL(url, "safemode", aProfilePath);
+FileBase::getAbsoluteFileURL(url, sFilename, aProfilePath);
 return aProfilePath;
 }
 
diff --git a/svx/source/dialog/SafeModeDialog.cxx 
b/svx/source/dialog/SafeModeDialog.cxx
index ac9c494..b77b83f 100644
--- a/svx/source/dialog/SafeModeDialog.cxx
+++

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - vcl/qa vcl/source

2016-12-12 Thread Caolán McNamara

 vcl/qa/cppunit/graphicfilter/data/wmf/fail/facename-1.wmf |binary
 vcl/qa/cppunit/graphicfilter/data/wmf/fail/seek-1.wmf |binary
 vcl/source/filter/wmf/winwmf.cxx  |3 ++-
 3 files changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 28ed3227267f7a00273595a60206744fd3c78b96
Author: CaolÃ¡n McNamara 
Date:   Sat Dec 10 20:51:58 2016 +

oss-fuzz: handle W_META_CREATEFONTINDIRECT like EMR_EXTCREATEFONTINDIRECTW

Change-Id: Iaa142d5d0ac0f00e89e8b7d7ffdef8137157cec9
(cherry picked from commit e718ac0ae415bba2988c96c36995755bbfd9df7f)
(cherry picked from commit d3ea20e55ca7d82b6121f7ed3db5fd170fcac94f)
Reviewed-on: https://gerrit.libreoffice.org/31839
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/vcl/qa/cppunit/graphicfilter/data/wmf/fail/facename-1.wmf 
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/facename-1.wmf
new file mode 100644
index 000..29c534f
Binary files /dev/null and 
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/facename-1.wmf differ
diff --git a/vcl/qa/cppunit/graphicfilter/data/wmf/fail/seek-1.wmf 
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/seek-1.wmf
new file mode 100644
index 000..e2fac15
Binary files /dev/null and 
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/seek-1.wmf differ
diff --git a/vcl/source/filter/wmf/winwmf.cxx b/vcl/source/filter/wmf/winwmf.cxx
index 1c65342..c4f7e78 100644
--- a/vcl/source/filter/wmf/winwmf.cxx
+++ b/vcl/source/filter/wmf/winwmf.cxx
@@ -885,7 +885,8 @@ void WMFReader::ReadRecordParams( sal_uInt16 nFunc )
 case W_META_CREATEFONTINDIRECT:
 {
 Size aFontSize;
-char lfFaceName[LF_FACESIZE];
+char lfFaceName[LF_FACESIZE+1];
+lfFaceName[LF_FACESIZE] = 0;
 sal_Int16 lfEscapement = 0;
 sal_Int16 lfOrientation = 0;
 sal_Int16 lfWeight = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sal/osl

2016-12-12 Thread Noel Grandin

 sal/osl/w32/profile.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 19650d0e27be97a4485998f3e8863c09a6f5cc74
Author: Noel Grandin 
Date:   Tue Dec 13 09:23:25 2016 +0200

fix windows build after OSL_TRACE->SAL changes

Change-Id: I345343f84f66299e8b91b31af0290ed0c622bf8d

diff --git a/sal/osl/w32/profile.cxx b/sal/osl/w32/profile.cxx
index 22ac01f..6928c61 100644
--- a/sal/osl/w32/profile.cxx
+++ b/sal/osl/w32/profile.cxx
@@ -354,7 +354,7 @@ static bool writeProfileImpl(osl_TFile* pFile)
 if ( bRet == 0 || BytesWritten == 0 )
 {
 OSL_ENSURE(bRet,"WriteFile failed!!!");
-SAL_INFO("sal", "write failed '%s'",strerror(errno));
+SAL_WARN("sal", "write failed " << strerror(errno));
 
 return false;
 }
@@ -1031,7 +1031,7 @@ static osl_TFile* openFileImpl(rtl_uString * strFileName, 
oslProfileOption Profi
 else
 {
 #ifdef DEBUG_OSL_PROFILE
-SAL_INFO("sal", "opening '%s' read/write",pszFilename);
+SAL_INFO("sal", "opening read/write " << pszFilename);
 #endif
 
 if ((pFile->m_Handle = CreateFileW( 
reinterpret_cast(rtl_uString_getStr( strFileName )), GENERIC_READ | 
GENERIC_WRITE,
@@ -1051,7 +1051,7 @@ static osl_TFile* openFileImpl(rtl_uString * strFileName, 
oslProfileOption Profi
 if ( ProfileFlags & (osl_Profile_WRITELOCK | osl_Profile_READLOCK ) )
 {
 #ifdef DEBUG_OSL_PROFILE
-SAL_INFO("sal", "locking '%s' file",pszFilename);
+SAL_INFO("sal", "locking file " << pszFilename);
 #endif
 
 lockFile(pFile, bWriteable ? write_lock : read_lock);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104510] Go to page dialog (Ctrl-g) should appear in the top right corner

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104510

--- Comment #7 from Pr410  ---
Hi Buovjaga,
I agree with you; it's not a big deal. However, if design team can try this and
we all can compare the difference. If not I am fine with that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64789] enhancement requests: non-rectangular images, more shadow types (perspective)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=64789

--- Comment #16 from Justin L  ---
Created attachment 129562
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129562=edit
ABC TAXUS fita_LO53beta.pdf: It looks presentable at least in LO5.3beta

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64789] enhancement requests: non-rectangular images, more shadow types (perspective)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=64789

Justin L  changed:

   What|Removed |Added

   Keywords|regression  |
   Priority|high|medium
 CC||jl...@mail.com
Summary|FILEOPEN: docx opening with |enhancement requests:
   |images containing drop  |non-rectangular images,
   |shadows |more shadow types
   ||(perspective)

--- Comment #15 from Justin L  ---
removing regression as per comment 1 and thus lowering importance to medium.

LibreOffice simply has never had the wealth of drop-shadow types that MSOffice
2007+ has.  For example, the FITA symbol has a perspective shadow (it is not
the black border line around the image, but that little coin shadow a
centimetre below it).  In addition, MSOffice considers the FITA image as a
circle, while LO treats it as a rectangle.

So this is currently more of an enhancement request than a bug report (at least
from the current perspective of LO5.4 [the cropping of the FITA image has been
fixed, and the shadows are much softer]). Modified the subject accordingly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97736] Wrong display Thai language for some release version

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97736

--- Comment #10 from Teeravut  ---
Created attachment 129561
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129561=edit
Thai character after English character

I still found problem on Version 5.2.3.3. If I typed Thai Character on field,
It worked fine. But If I type first character with English and type Thai
Character after that. It still display wrong. I noticed that It has problem
with Tone (Thai language has tone)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104052] Add LibreColour HLC palette

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104052

--- Comment #56 from Christoph Schäfer  ---
(In reply to Stephan Bergmann from comment #45)
> (See the discussion at
>  html> "Allow extensions to provide color palettes" for a potential way of
> providing this palette as a .oxt extension.)

Hi Samuel,

Thanks for your support!

We might find another solution, but since you were at it, do you think you
could create an Extension that includes the next version of the Open Colour
Systems Collection 2.0, a huge collection of mostly commercial colour systems,
i.e. 376 SOC palettes?

OCSC 2.0 will probably be released during the next few days, and freieFarbe /
freeColour would be glad if someone could volunteer to create an Extension with
all those CC-licensed palettes.

OCSC also has its own logo (SVG).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104052] Add LibreColour HLC palette

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104052

--- Comment #55 from Christoph Schäfer  ---
(In reply to Taylor Jenkins from comment #54)
> Created attachment 129558 [details]
> Comparison between hlcfaecher.pdf & LO Writer w/ librecolour.soc
> 
> This is a screenshot with the hlcfaecher.pdf color swatch on the left, the
> corresponding color in LO from librecolour.soc in the the middle, and the
> color in LO using the hex value shown in the pdf, on the right. When the two
> different hex values are shown side by side in LO, they are not noticeably
> different on my monitor. Curious why the pdf was noticeably different, I
> used a color picker to determine the actual color value, which is shown
> overlaid on the pdf color swatch.

Colour pickers aren't reliable. 

We are aware of minor differences between the sRGB/Hex values in the fans and
the SOC files. That's a problem of the algorithms and colour management systems
used for the conversion from CIELAB to sRGB. The colour fans have been produced
with Photoshop on Windows, hence the values according to Adobe's native CMS.
The converter we used to create the SOC files, however, was using littleCMS2,
which is much more precise than Adobe's outdated CMS.

In practice it doesn't matter much, though, because in RGB values, the
deviation isn't huge, one or two digits in one or two channels at most, which
is within the acceptable error margin, given the diversity of devices or output
targets.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104206] Allow Paragraph Styles to bind to List Styles' levels, like with Outline Numbering

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104206

--- Comment #3 from Mike Kaganski  ---
(In reply to Regina Henschel from comment #2)

Thank you for considerations!

> Please examine ODF and its concepts of outline and lists and discuss file
> format solutions very early.

You are absolutely right.
However, I hope, and my vision is, that my proposal can be implemented without
modifying the ODF standard at all.

I must say that I see this as UI-only concept. From the user PoV, the binding
between a paragraph style and a list style is what program does when user sets
the style or changes list level. I suppose that the bond may be defined in ODF
by using application-specific extended tags in corresponding styles, and then
modifying the app behavior in relevant places. The ODF output should stay
unmodified (modulo the extended style properties to keep the bond between
sessions).

So, the output file should have normal list and outline structure, so it will
be open with any previous version, or with other ODF viewer, without problems;
the only missing thing in those older/alien versions will be the bond loss and,
thus, need to make all style-to-level adjustments manually.

> >I suppose that it could be made a GSoC project task.
> Do you will mentor it?

It would be an honor for me. I may only hope that I can succeed in this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Request For Comments: Hebrew numbering in Libreoffice

2016-12-12 Thread Yossi Zahn




On 08/12/2016 07:50 PM, Eike Rathke wrote:

The UI visible strings are obtained from
cui/uiconfig/ui/numberingoptionspage.ui
It seems that the numbering options that appear in 
numberingoptionspage.ui will always be higher up in the list than those 
that are added dynamically in cui/source/tabpages/numpages.cxx. The 
dynamically added numbering options seem to appear in the order that 
they are defined in aSupportedTypes[] in defaultnumberingprovider.cxx. 
I'm wondering if it should be that way?


yossi
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: avmedia/source basic/source canvas/source editeng/source odk/examples sal/osl scripting/source sc/source sdext/source

2016-12-12 Thread Noel Grandin

 avmedia/source/macavf/framegrabber.mm |5 -
 avmedia/source/macavf/manager.mm  |3 -
 avmedia/source/macavf/player.mm   |   29 +-
 avmedia/source/macavf/window.mm   |7 --
 basic/source/basmgr/basmgr.cxx|1 
 basic/source/classes/errobject.cxx|2 
 basic/source/classes/sb.cxx   |7 --
 basic/source/classes/sbunoobj.cxx |2 
 basic/source/comp/codegen.cxx |3 -
 basic/source/comp/parser.cxx  |1 
 basic/source/comp/scanner.cxx |1 
 basic/source/runtime/dllmgr-x64.cxx   |2 
 basic/source/runtime/dllmgr-x86.cxx   |2 
 basic/source/sbx/sbxscan.cxx  |2 
 basic/source/uno/scriptcont.cxx   |2 
 canvas/source/cairo/cairo_canvashelper_text.cxx   |3 -
 canvas/source/tools/surface.cxx   |6 --
 editeng/source/accessibility/AccessibleContextBase.cxx|3 -
 odk/examples/cpp/complextoolbarcontrols/MyProtocolHandler.cxx |2 
 sal/osl/all/loadmodulerelative.cxx|4 -
 sc/source/ui/vba/vbaglobals.cxx   |2 
 sc/source/ui/vba/vbahelper.cxx|   10 ---
 scripting/source/provider/URIHelper.cxx   |5 -
 sdext/source/pdfimport/tree/genericelements.cxx   |   18 +++---
 24 files changed, 22 insertions(+), 100 deletions(-)

New commits:
commit 3a705ab40597f7cb584bdeaef06701b289f911f1
Author: Noel Grandin 
Date:   Tue Dec 13 08:07:40 2016 +0200

OSL_TRACE->SAL in avmedia..canvas

Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9

diff --git a/avmedia/source/macavf/framegrabber.mm 
b/avmedia/source/macavf/framegrabber.mm
index d951209..b4022caf 100644
--- a/avmedia/source/macavf/framegrabber.mm
+++ b/avmedia/source/macavf/framegrabber.mm
@@ -51,7 +51,7 @@ bool FrameGrabber::create( const ::rtl::OUString& rURL )
 AVAsset* pMovie = [AVURLAsset URLAssetWithURL:pNSURL options:nil];
 if( !pMovie )
 {
-OSL_TRACE( "AVGrabber::create() cannot load url=\"%s\"", [pNSStr 
UTF8String] );
+SAL_WARN("avmedia", "AVGrabber::create() cannot load url=" << [pNSStr 
UTF8String] );
 return false;
 }
 
@@ -63,7 +63,7 @@ bool FrameGrabber::create( AVAsset* pMovie )
 {
 if( [[pMovie tracksWithMediaType:AVMediaTypeVideo] count] == 0)
 {
-OSL_TRACE( "AVGrabber::create() found no video content!" );
+SAL_WARN("avmedia", "AVGrabber::create() found no video content!" );
 return false;
 }
 
@@ -79,7 +79,6 @@ uno::Reference< graphic::XGraphic > SAL_CALL 
FrameGrabber::grabFrame( double fMe
 uno::Reference< graphic::XGraphic > xRet;
 if( !mpImageGen )
 return xRet;
-OSL_TRACE( "AVPlayer::grabFrame( %.3fsec)", fMediaTime );
 
 // get the requested image from the movie
 CGImage* pCGImage = [mpImageGen 
copyCGImageAtTime:CMTimeMakeWithSeconds(fMediaTime,1000) actualTime:nullptr 
error:nullptr];
diff --git a/avmedia/source/macavf/manager.mm b/avmedia/source/macavf/manager.mm
index a8ff2ec..5df4af8 100644
--- a/avmedia/source/macavf/manager.mm
+++ b/avmedia/source/macavf/manager.mm
@@ -29,7 +29,6 @@ namespace avmedia { namespace macavf {
 Manager::Manager( const uno::Reference< lang::XMultiServiceFactory >& rxMgr ) :
 mxMgr( rxMgr )
 {
-OSL_TRACE( "Constructing avmedia::macavf::Manager" );
 }
 
 
@@ -44,8 +43,6 @@ uno::Reference< media::XPlayer > SAL_CALL 
Manager::createPlayer( const ::rtl::OU
 uno::Reference< media::XPlayer >xRet( pPlayer );
 INetURLObject   aURL( rURL );
 
-OSL_TRACE( "avmediamacavf: Manager::createPlayer" );
-
 if( !pPlayer->create( aURL.GetMainURL( 
INetURLObject::DecodeMechanism::Unambiguous ) )  )
 xRet.clear();
 
diff --git a/avmedia/source/macavf/player.mm b/avmedia/source/macavf/player.mm
index 48be439..7bf7494 100644
--- a/avmedia/source/macavf/player.mm
+++ b/avmedia/source/macavf/player.mm
@@ -31,7 +31,6 @@ using namespace ::com::sun::star;
 {
 (void) pObject;
 NSString* pDictStr = [NSString stringWithFormat:@"%@", pChangeDict];
-OSL_TRACE( "MacAVObserver::onKeyChange k=\"%s\" c=%s", [pKeyPath 
UTF8String], [pDictStr UTF8String]);
 avmedia::macavf::MacAVObserverHandler* pHandler = 
static_cast(pContext);
 pHandler->handleObservation( pKeyPath );
 }
@@ -39,7 +38,6 @@ using namespace ::com::sun::star;
 - (void)onNotification:(NSNotification*)pNotification
 {
 NSString* pNoteName = (NSString*)[pNotification name];
-

[Libreoffice-commits] core.git: chart2/source cli_ure/source comphelper/source connectivity/source connectivity/workben cppuhelper/source cppu/source cui/source dbaccess/source desktop/source editeng/

2016-12-12 Thread Noel Grandin

 chart2/source/controller/dialogs/dlg_DataEditor.cxx   |1 
 chart2/source/model/main/ChartModel.cxx   |9 -
 chart2/source/model/main/ChartModel_Persistence.cxx   |2 
 chart2/source/tools/LifeTime.cxx  |2 
 cli_ure/source/climaker/climaker_app.cxx  |   12 -
 comphelper/source/misc/asyncnotification.cxx  |4 
 comphelper/source/misc/numbers.cxx|4 
 connectivity/source/drivers/dbase/dindexnode.cxx  |   18 +-
 connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx  |1 
 connectivity/source/drivers/evoab2/NResultSet.cxx |   13 --
 connectivity/source/drivers/file/quotedstring.cxx |1 
 connectivity/source/drivers/hsqldb/HStorageMap.cxx|2 
 connectivity/source/drivers/hsqldb/StorageFileAccess.cxx  |3 
 connectivity/source/drivers/kab/KStatement.cxx|2 
 connectivity/source/drivers/macab/MacabStatement.cxx  |2 
 connectivity/source/drivers/mork/MConnection.cxx  |2 
 connectivity/source/drivers/mork/MPreparedStatement.cxx   |8 -
 connectivity/source/drivers/mork/MQueryHelper.cxx |4 
 connectivity/source/drivers/mork/MResultSet.cxx   |   55 
 connectivity/source/drivers/mork/MStatement.cxx   |   23 ---
 connectivity/source/drivers/mozab/bootstrap/MNSINIParser.cxx  |   14 --
 connectivity/source/drivers/postgresql/pq_connection.cxx  |2 
 connectivity/workben/iniParser/main.cxx   |   17 --
 cppu/source/typelib/typelib.cxx   |2 
 cppu/source/uno/lbenv.cxx |2 
 cppuhelper/source/component.cxx   |2 
 cppuhelper/source/tdmgr.cxx   |   10 -
 cui/source/customize/cfg.cxx  |   64 --
 cui/source/dialogs/scriptdlg.cxx  |   19 --
 cui/source/options/optinet2.cxx   |   42 ++
 cui/source/options/optupdt.cxx|3 
 dbaccess/source/core/dataaccess/databasedocument.cxx  |4 
 dbaccess/source/ui/app/AppControllerDnD.cxx   |2 
 desktop/source/deployment/misc/dp_misc.cxx|1 
 desktop/source/deployment/registry/component/dp_component.cxx |9 -
 editeng/source/accessibility/AccessibleEditableTextPara.cxx   |   15 --
 editeng/source/accessibility/AccessibleImageBullet.cxx|   10 -
 editeng/source/items/textitem.cxx |2 
 extensions/source/config/ldap/ldapuserprofilebe.cxx   |8 -
 extensions/source/propctrlr/browserlistbox.cxx|6 
 extensions/source/update/check/updatecheck.cxx|6 
 extensions/source/update/check/updatecheckjob.cxx |6 
 extensions/source/update/check/updateprotocol.cxx |2 
 extensions/source/update/feed/test/updatefeedtest.cxx |6 
 extensions/source/update/feed/updatefeed.cxx  |4 
 filter/source/msfilter/mstoolbar.cxx  |5 
 filter/source/msfilter/msvbahelper.cxx|5 
 filter/source/svg/parserfragments.cxx |5 
 filter/source/svg/svgreader.cxx   |   34 -
 filter/source/svg/test/parsertest.cxx |   22 ---
 filter/source/svg/test/svg2odf.cxx|6 
 filter/source/svg/units.cxx   |2 
 forms/source/richtext/richtextcontrol.cxx |   17 --
 fpicker/source/aqua/FilterHelper.mm   |   24 ---
 fpicker/source/win32/filepicker/FPentry.cxx   |2 
 include/sal/log-areas.dox |3 
 mysqlc/source/mysqlc_connection.cxx   |   16 --
 oox/source/drawingml/textfield.cxx|1 
 oox/source/drawingml/textparagraphproperties.cxx  |1 
 oox/source/ole/axcontrol.cxx  |3 
 60 files changed, 110 insertions(+), 462 deletions(-)

New commits:
commit c3586b684c58e06cd80dea87d7681354acfec80b
Author: Noel Grandin 
Date:   Mon Dec 12 16:31:57 2016 +0200

OSL_TRACE->SAL in chart2..oox

Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/chart2/source/controller/dialogs/dlg_DataEditor.cxx 
b/chart2/source/controller/dialogs/dlg_DataEditor.cxx
index 40f854d..14aed53 100644
---

[Libreoffice-commits] core.git: framework/source include/canvas include/sal io/source javaunohelper/source l10ntools/source mysqlc/source oox/source registry/source registry/tools reportdesign/source

2016-12-12 Thread Noel Grandin

 framework/source/uielement/genericstatusbarcontroller.cxx |1 
 framework/source/uielement/macrosmenucontroller.cxx   |3 
 framework/source/uielement/recentfilesmenucontroller.cxx  |2 
 include/canvas/canvastools.hxx|   13 -
 include/canvas/debug.hxx  |   59 
 include/sal/log-areas.dox |2 
 io/source/acceptor/acceptor.cxx   |9 
 io/source/connector/connector.cxx |   12 
 javaunohelper/source/bootstrap.cxx|4 
 l10ntools/source/merge.cxx|1 
 mysqlc/source/mysqlc_connection.cxx   |   36 --
 mysqlc/source/mysqlc_databasemetadata.cxx |   37 --
 mysqlc/source/mysqlc_driver.cxx   |   11 
 mysqlc/source/mysqlc_preparedstatement.cxx|   41 ---
 mysqlc/source/mysqlc_resultset.cxx|   91 ---
 mysqlc/source/mysqlc_resultsetmetadata.cxx|   23 -
 mysqlc/source/mysqlc_statement.cxx|   32 --
 oox/source/drawingml/customshapegeometry.cxx  |2 
 oox/source/drawingml/diagram/datamodelcontext.cxx |3 
 oox/source/drawingml/diagram/diagram.cxx  |4 
 oox/source/drawingml/diagram/diagramdefinitioncontext.cxx |1 
 oox/source/drawingml/diagram/diagramlayoutatoms.cxx   |   27 --
 oox/source/drawingml/diagram/layoutnodecontext.cxx|6 
 oox/source/drawingml/hyperlinkcontext.cxx |2 
 oox/source/drawingml/textfield.cxx|8 
 oox/source/drawingml/textparagraphproperties.cxx  |2 
 oox/source/drawingml/textparagraphpropertiescontext.cxx   |4 
 oox/source/drawingml/textrun.cxx  |8 
 oox/source/export/drawingml.cxx   |2 
 oox/source/export/shapes.cxx  |4 
 oox/source/ole/axcontrol.cxx  |4 
 oox/source/ppt/pptimport.cxx  |2 
 oox/source/ppt/slidepersist.cxx   |1 
 oox/source/ppt/slidetransition.cxx|2 
 oox/source/ppt/timenodelistcontext.cxx|9 
 registry/source/regimpl.cxx   |1 
 registry/tools/options.cxx|1 
 reportdesign/source/core/api/ReportDefinition.cxx |1 
 reportdesign/source/ui/report/ReportSection.cxx   |3 
 reportdesign/source/ui/report/ViewsWindow.cxx |1 
 rsc/source/rsc/rsc.cxx|8 
 sal/osl/unx/process.cxx   |   16 -
 sal/osl/unx/signal.cxx|2 
 sal/osl/w32/profile.cxx   |  182 +-
 sal/osl/w32/socket.cxx|2 
 45 files changed, 64 insertions(+), 621 deletions(-)

New commits:
commit a005fbeddc4e615cfff56a9bd84355f8d42c1c8c
Author: Noel Grandin 
Date:   Mon Dec 12 15:05:28 2016 +0200

OSL_TRACE->SAL in framework..sal

Change-Id: I9a897af88aa9f6f7ca98ce521c69b5a4ee8462e9
Reviewed-on: https://gerrit.libreoffice.org/31903
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/framework/source/uielement/genericstatusbarcontroller.cxx 
b/framework/source/uielement/genericstatusbarcontroller.cxx
index 7432e8c..2ab0694 100644
--- a/framework/source/uielement/genericstatusbarcontroller.cxx
+++ b/framework/source/uielement/genericstatusbarcontroller.cxx
@@ -126,7 +126,6 @@ void SAL_CALL GenericStatusbarController::paint(
 ::sal_Int32 /*nStyle*/ )
 throw ( RuntimeException, std::exception )
 {
-OSL_TRACE("framework::GenericStatusbarController::paint");
 SolarMutexGuard aGuard;
 
 const Reference< awt::XGraphics2 > xGraphics2(xGraphics, UNO_QUERY);
diff --git a/framework/source/uielement/macrosmenucontroller.cxx 
b/framework/source/uielement/macrosmenucontroller.cxx
index 03dfe6d..bbfaf0e 100644
--- a/framework/source/uielement/macrosmenucontroller.cxx
+++ b/framework/source/uielement/macrosmenucontroller.cxx
@@ -64,7 +64,6 @@ MacrosMenuController::MacrosMenuController( const 
css::uno::Reference< css::uno:
 
 MacrosMenuController::~MacrosMenuController()
 {
-OSL_TRACE("calling dtor");
 }
 
 // private function
@@ -98,7 +97,6 @@ void SAL_CALL MacrosMenuController::disposing( const 
EventObject& ) throw ( Runt
 Reference< css::awt::XMenuListener > xHolder(static_cast(this), UNO_QUERY );
 
 osl::MutexGuard aLock( m_aMutex );
-OSL_TRACE("disposing");
 m_xFrame.clear();
 m_xDispatch.clear();
 m_xContext.clear();
@@ -106,7 +104,6 @@ void SAL_CALL

[Libreoffice-commits] core.git: scripting/source sc/source

2016-12-12 Thread Noel Grandin

 sc/source/core/data/document.cxx|8 +++---
 sc/source/core/tool/interpr1.cxx|2 -
 sc/source/core/tool/scmatrix.cxx|2 -
 sc/source/core/tool/token.cxx   |2 -
 sc/source/filter/excel/read.cxx |8 --
 sc/source/filter/excel/xeescher.cxx |2 -
 sc/source/filter/excel/xiescher.cxx |   20 ++-
 sc/source/filter/excel/xipivot.cxx  |2 -
 sc/source/filter/excel/xistream.cxx |2 -
 sc/source/filter/excel/xlpivot.cxx  |2 -
 sc/source/filter/excel/xlstyle.cxx  |4 +--
 sc/source/filter/excel/xltoolbar.cxx|3 --
 sc/source/filter/excel/xltools.cxx  |4 +--
 sc/source/filter/xcl97/xcl97esc.cxx |4 +--
 sc/source/ui/docshell/macromgr.cxx  |1 
 sc/source/ui/drawfunc/fusel.cxx |1 
 sc/source/ui/unoobj/docuno.cxx  |4 +--
 sc/source/ui/unoobj/servuno.cxx |4 ---
 sc/source/ui/unoobj/tokenuno.cxx|2 -
 sc/source/ui/vba/vbaapplication.cxx |3 --
 sc/source/ui/vba/vbachartobjects.cxx|2 -
 sc/source/ui/vba/vbaeventshelper.cxx|2 -
 sc/source/ui/vba/vbaglobals.cxx |   19 ++
 sc/source/ui/vba/vbahelper.cxx  |6 ++--
 sc/source/ui/vba/vbaoleobject.cxx   |2 -
 sc/source/ui/vba/vbarange.cxx   |6 
 sc/source/ui/vba/vbaworkbooks.cxx   |1 
 sc/source/ui/vba/vbaworksheet.cxx   |7 +
 sc/source/ui/vba/vbawsfunction.cxx  |1 
 scripting/source/basprov/basprov.cxx|4 ---
 scripting/source/protocolhandler/scripthandler.cxx  |   15 ---
 scripting/source/provider/BrowseNodeFactoryImpl.cxx |3 --
 scripting/source/provider/MasterScriptProvider.cxx  |7 +
 scripting/source/provider/ProviderCache.cxx |2 -
 scripting/source/provider/URIHelper.cxx |6 ++--
 scripting/source/vbaevents/eventhelper.cxx  |   26 ++--
 36 files changed, 60 insertions(+), 129 deletions(-)

New commits:
commit 81f2a9f46451492d4d879573bc9ac7f2e44abedb
Author: Noel Grandin 
Date:   Mon Dec 12 13:33:14 2016 +0200

OSL_TRACE->SAL in sc..scripting

Change-Id: I389d8cb733a5ee24d3119a1ebac5a5b70daff04e
Reviewed-on: https://gerrit.libreoffice.org/31900
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index 429eff0..da23524 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -238,7 +238,7 @@ bool ScDocument::SetCodeName( SCTAB nTab, const OUString& 
rName )
 return true;
 }
 }
-OSL_TRACE( " can't set code name %s", OUStringToOString( rName, 
RTL_TEXTENCODING_UTF8 ).getStr() );
+SAL_WARN("sc",  "can't set code name " << rName );
 return false;
 }
 
@@ -2147,7 +2147,7 @@ void ScDocument::CopyToClip(const ScClipParam& rClipParam,
 
 if (!pClipDoc)
 {
-OSL_TRACE("CopyToClip: no ClipDoc");
+SAL_WARN("sc", "CopyToClip: no ClipDoc");
 pClipDoc = ScModule::GetClipDoc();
 }
 
@@ -2247,7 +2247,7 @@ void ScDocument::CopyTabToClip(SCCOL nCol1, SCROW nRow1,
 {
 if (!pClipDoc)
 {
-OSL_TRACE("CopyTabToClip: no ClipDoc");
+SAL_WARN("sc", "CopyTabToClip: no ClipDoc");
 pClipDoc = ScModule::GetClipDoc();
 }
 
@@ -2355,7 +2355,7 @@ void ScDocument::TransposeClip( ScDocument* pTransClip, 
InsertDeleteFlags nFlags
 }
 else
 {
-OSL_TRACE("TransposeClip: Too big");
+SAL_WARN("sc", "TransposeClip: Too big");
 }
 
 // This happens only when inserting...
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index eec366d..7fe7b81 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -1030,7 +1030,7 @@ sc::RangeMatrix ScInterpreter::CompareMat( ScQueryOp eOp, 
sc::CompareOptions* pO
 aRes.mpMat->CompareNotEqual();
 break;
 default:
-OSL_TRACE( "ScInterpreter::QueryMat: unhandled comparison 
operator: %d", (int)eOp);
+SAL_WARN("sc",  "ScInterpreter::QueryMat: unhandled comparison 
operator: " << (int)eOp);
 aRes.mpMat.reset();
 return aRes;
 }
diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index 273a5fb..8ed28f4 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx

[Libreoffice-commits] core.git: accessibility/inc accessibility/source

2016-12-12 Thread Arnaud Versini

 accessibility/inc/extended/AccessibleBrowseBoxBase.hxx|   27 
++-
 accessibility/source/extended/AccessibleBrowseBox.cxx |   10 +-
 accessibility/source/extended/AccessibleBrowseBoxBase.cxx |   32 

 accessibility/source/extended/AccessibleBrowseBoxCheckBoxCell.cxx |6 -
 accessibility/source/extended/AccessibleBrowseBoxHeaderBar.cxx|   32 

 accessibility/source/extended/AccessibleBrowseBoxHeaderCell.cxx   |6 -
 accessibility/source/extended/AccessibleBrowseBoxTable.cxx|   26 
+++
 accessibility/source/extended/AccessibleBrowseBoxTableBase.cxx|   16 ++--
 accessibility/source/extended/AccessibleBrowseBoxTableCell.cxx|   36 
+-
 accessibility/source/extended/accessibletablistbox.cxx|2 
 accessibility/source/extended/accessibletablistboxtable.cxx   |   14 +--
 11 files changed, 99 insertions(+), 108 deletions(-)

New commits:
commit ba6b35fc68a01aff72b39eb7809bacb326068668
Author: Arnaud Versini 
Date:   Mon Dec 12 18:42:08 2016 +0100

accessibility: cleanup AccessibleBrowseBoxBase implementation

Change-Id: I5c9b96e2ebd2ac98dfa610346c1da89fbf56e2d2
Reviewed-on: https://gerrit.libreoffice.org/31916
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/accessibility/inc/extended/AccessibleBrowseBoxBase.hxx 
b/accessibility/inc/extended/AccessibleBrowseBoxBase.hxx
index cce60b7..a3f0575 100644
--- a/accessibility/inc/extended/AccessibleBrowseBoxBase.hxx
+++ b/accessibility/inc/extended/AccessibleBrowseBoxBase.hxx
@@ -283,10 +283,6 @@ protected:
 
 // internal helper methods
 
-/** @throws DisposedException  If the object is not alive. */
-void ensureIsAlive() const
-throw ( css::lang::DisposedException );
-
 /** @return  The osl::Mutex member provided by the class BaseMutex. */
 inline ::osl::Mutex& getOslMutex();
 
@@ -309,11 +305,13 @@ protected:
 void setClientId(::comphelper::AccessibleEventNotifier::TClientId 
_aNewClientId) { m_aClientId = _aNewClientId; }
 
 public:
-// public versions of internal helper methods, with access control
-struct AccessControl { friend class SolarMethodGuard; private: 
AccessControl() { } };
+/** @return  The osl::Mutex member provided by the class BaseMutex. */
+inline ::osl::Mutex&getMutex( ) { return m_aMutex; }
+
+/** @throws DisposedException  If the object is not alive. */
+void ensureIsAlive() const
+throw ( css::lang::DisposedException );
 
-inline ::osl::Mutex&getMutex( const AccessControl& ) { return 
getOslMutex(); }
-inline void ensureIsAlive( const AccessControl& ) { 
ensureIsAlive(); }
 
 protected:
 // members
@@ -408,17 +406,15 @@ protected:
 
 // a helper class for protecting methods which need to lock the solar mutex in 
addition to the own mutex
 
-typedef ::osl::MutexGuard OslMutexGuard;
-
-class SolarMethodGuard : public SolarMutexGuard, public OslMutexGuard
+class SolarMethodGuard : public SolarMutexGuard, public osl::MutexGuard
 {
 public:
 inline SolarMethodGuard( AccessibleBrowseBoxBase& _rOwner, bool 
_bEnsureAlive = true )
 :SolarMutexGuard( )
-,OslMutexGuard( _rOwner.getMutex( 
AccessibleBrowseBoxBase::AccessControl() ) )
+,osl::MutexGuard( _rOwner.getMutex( ) )
 {
 if ( _bEnsureAlive )
-_rOwner.ensureIsAlive( AccessibleBrowseBoxBase::AccessControl() );
+_rOwner.ensureIsAlive( );
 }
 };
 
@@ -429,11 +425,6 @@ inline ::svt::AccessibleBrowseBoxObjType 
AccessibleBrowseBoxBase::getType() cons
 return meObjType;
 }
 
-inline ::osl::Mutex& AccessibleBrowseBoxBase::getOslMutex()
-{
-return m_aMutex;
-}
-
 inline void AccessibleBrowseBoxBase::implSetName(
 const OUString& rName )
 {
diff --git a/accessibility/source/extended/AccessibleBrowseBox.cxx 
b/accessibility/source/extended/AccessibleBrowseBox.cxx
index 73e9823..fea9965 100644
--- a/accessibility/source/extended/AccessibleBrowseBox.cxx
+++ b/accessibility/source/extended/AccessibleBrowseBox.cxx
@@ -85,7 +85,7 @@ AccessibleBrowseBox::~AccessibleBrowseBox()
 
 void SAL_CALL AccessibleBrowseBox::disposing()
 {
-::osl::MutexGuard aGuard( getOslMutex() );
+::osl::MutexGuard aGuard( getMutex() );
 
 m_xImpl->m_pTable   = nullptr;
 m_xImpl->m_pColumnHeaderBar = nullptr;
@@ -113,7 +113,7 @@ sal_Int32 SAL_CALL 
AccessibleBrowseBox::getAccessibleChildCount()
 throw ( uno::RuntimeException, std::exception )
 {
 SolarMutexGuard aSolarGuard;
-::osl::MutexGuard aGuard( getOslMutex() );
+::osl::MutexGuard aGuard( getMutex() );
 ensureIsAlive();
 return BBINDEX_FIRSTCONTROL + mpBrowseBox->GetAccessibleControlCount();
 }
@@ -124,7 +124,7 @@ AccessibleBrowseBox::getAccessibleChild( sal_Int32 
nChildIndex )
 throw ( lang::IndexOutOfBoundsException,

[Libreoffice-bugs] [Bug 38844] Reduce XOR rendering

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=38844

charan  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |harisaicharan111.challa@gma
   |desktop.org |il.com

--- Comment #13 from charan  ---
i want to work on this

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79965] Error with Links in imagemap when exporting to PDF

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=79965

Lehonti Ramos  changed:

   What|Removed |Added

   Keywords||dataLoss,
   ||implementationError

--- Comment #3 from Lehonti Ramos  ---
Confirmed with LibreOffice 5.1.4.2 under Ubuntu MATE 16.04 x64. It is
reasonable to expect that the bug remains under all platforms.

The original poster says that the exported link points to the current folder.
In my case, the behavior holds true for LibreOffice Writer, but in LibreOffice
Impress there aren't hyperlinks at all. I also observed that the location it
points to doesn't change even if you move the PDF to another folder.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104533] Text disappears when selecting Script font

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104533

Khaled Hosny  changed:

   What|Removed |Added

 Blocks||103729


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103729
[Bug 103729] [META] tracker HarfBuzz based common text layout regressions
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104623] Import issues with MS Publisher 98 files

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104623

Christoph Schäfer  changed:

   What|Removed |Added

  Component|filters and storage |General
Version|Inherited From OOo  |unspecified
Product|LibreOffice |libmspub

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: common/IoUtil.cpp common/Log.hpp

2016-12-12 Thread Ashod Nakashian

 common/IoUtil.cpp |9 ++---
 common/Log.hpp|2 ++
 2 files changed, 4 insertions(+), 7 deletions(-)

New commits:
commit 4bc318fb8848490c0306ab9a5089a0a57c9ea6ba
Author: Ashod Nakashian 
Date:   Mon Dec 12 23:31:00 2016 -0500

loolwsd: LOG_CHECK to replace assertion when logging suffices

Change-Id: I077c6394579f432c0aa9da053d20ccb9c6d31907
Reviewed-on: https://gerrit.libreoffice.org/31934
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/IoUtil.cpp b/common/IoUtil.cpp
index 9958bfe..cc62244 100644
--- a/common/IoUtil.cpp
+++ b/common/IoUtil.cpp
@@ -110,7 +110,7 @@ void SocketProcessor(const std::shared_ptr& 
ws,
 continue;
 }
 
-assert(n > 0);
+LOG_CHECK(n > 0);
 
 const std::string firstLine = LOOLProtocol::getFirstLine(payload);
 if ((flags & WebSocket::FrameFlags::FRAME_FLAG_FIN) != 
WebSocket::FrameFlags::FRAME_FLAG_FIN)
@@ -164,12 +164,7 @@ void SocketProcessor(const std::shared_ptr& 
ws,
 }
 }
 
-if (n <= 0 || (flags & WebSocket::FRAME_OP_BITMASK) == 
WebSocket::FRAME_OP_CLOSE)
-{
-closeFrame();
-LOG_WRN("SocketProcessor [" << name << "]: Connection 
closed.");
-break;
-}
+LOG_CHECK(n > 0);
 
 // Call the handler.
 const auto success = handler(payload);
diff --git a/common/Log.hpp b/common/Log.hpp
index ebd0ba4..ee7dc55 100644
--- a/common/Log.hpp
+++ b/common/Log.hpp
@@ -180,6 +180,8 @@ namespace Log
 #define LOG_FTL(X) if (Log::fatalEnabled()) { LOG_BODY("FTL", X); 
Log::logger().fatal(oss_.str()); }
 #define LOG_SFL(X) if (Log::errorEnabled()) { LOG_BODY("FTL", X << " (errno: " 
<< std::strerror(errno) << ")"); Log::logger().fatal(oss_.str()); }
 
+#define LOG_CHECK(X) if (!(X)) { LOG_ERR("Check failed. Expected (" #X ")."); }
+
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/LOOLWebSocket.hpp

2016-12-12 Thread Ashod Nakashian

 wsd/LOOLWebSocket.hpp |   53 +++---
 1 file changed, 42 insertions(+), 11 deletions(-)

New commits:
commit aa1d721444c757e84db6c64a1082773483bdf2a1
Author: Ashod Nakashian 
Date:   Mon Dec 12 23:08:01 2016 -0500

loolwsd: harden against socket errors and lock while receiving

Change-Id: I402d387272e0e30d2fe035842c50f40c3806e20d
Reviewed-on: https://gerrit.libreoffice.org/31933
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWebSocket.hpp b/wsd/LOOLWebSocket.hpp
index d29d429..3f86acd 100644
--- a/wsd/LOOLWebSocket.hpp
+++ b/wsd/LOOLWebSocket.hpp
@@ -32,7 +32,7 @@ private:
 std::mutex _mutex;
 
 #if ENABLE_DEBUG
-std::chrono::milliseconds getWebSocketDelay()
+static std::chrono::milliseconds getWebSocketDelay()
 {
 unsigned long baseDelay = 0;
 unsigned long jitter = 0;
@@ -89,20 +89,33 @@ public:
 // Delay receiving the frame
 std::this_thread::sleep_for(getWebSocketDelay());
 #endif
-// Timeout given is in microseconds.
-static const Poco::Timespan waitTime(POLL_TIMEOUT_MS * 1000);
+// Timeout is in microseconds. We don't need this, except to yield the 
cpu.
+static const Poco::Timespan waitTime(POLL_TIMEOUT_MS * 1000 / 10);
+static const Poco::Timespan waitZero(0);
+std::unique_lock lock(_mutex);
 
 while (poll(waitTime, Poco::Net::Socket::SELECT_READ))
 {
 const int n = Poco::Net::WebSocket::receiveFrame(buffer, length, 
flags);
+
 LOG_TRC("Got frame: " << 
LOOLProtocol::getAbbreviatedFrameDump(buffer, n, flags));
-if ((flags & WebSocket::FRAME_OP_BITMASK) == 
WebSocket::FRAME_OP_PING)
+
+if ((flags & WebSocket::FRAME_OP_BITMASK) == 
WebSocket::FRAME_OP_PING &&
+(flags & WebSocket::FRAME_OP_BITMASK) != 
WebSocket::FRAME_OP_CLOSE)
 {
-sendFrame(buffer, n, WebSocket::FRAME_FLAG_FIN | 
WebSocket::FRAME_OP_PONG);
+// Echo back the ping message.
+if (poll(waitZero, Socket::SelectMode::SELECT_ERROR) ||
+!poll(waitZero, Socket::SelectMode::SELECT_WRITE) ||
+Poco::Net::WebSocket::sendFrame(buffer, n, 
WebSocket::FRAME_FLAG_FIN | WebSocket::FRAME_OP_PONG) != n)
+{
+LOG_WRN("Sending Pong failed.");
+return -1;
+}
 }
-else if ((flags & WebSocket::FRAME_OP_BITMASK) == 
WebSocket::FRAME_OP_PONG)
+else if ((flags & WebSocket::FRAME_OP_BITMASK) == 
WebSocket::FRAME_OP_PONG &&
+ (flags & WebSocket::FRAME_OP_BITMASK) != 
WebSocket::FRAME_OP_CLOSE)
 {
-// In case we do send pongs in the future.
+// In case we do send pings in the future.
 }
 else
 {
@@ -110,6 +123,7 @@ public:
 }
 }
 
+// Not ready for read.
 return -1;
 }
 
@@ -120,23 +134,40 @@ public:
 // Delay sending the frame
 std::this_thread::sleep_for(getWebSocketDelay());
 #endif
+static const Poco::Timespan waitZero(0);
 std::unique_lock lock(_mutex);
 
 if (length >= LARGE_MESSAGE_SIZE)
 {
 const std::string nextmessage = "nextmessage: size=" + 
std::to_string(length);
-Poco::Net::WebSocket::sendFrame(nextmessage.data(), 
nextmessage.size());
-LOG_TRC("Message is long, sent " + nextmessage);
+const int size = nextmessage.size();
+
+if (!poll(waitZero, Socket::SelectMode::SELECT_ERROR) &&
+poll(waitZero, Socket::SelectMode::SELECT_WRITE) &&
+Poco::Net::WebSocket::sendFrame(nextmessage.data(), size) == 
size)
+{
+LOG_TRC("Sent long message preample: " + nextmessage);
+}
+else
+{
+LOG_WRN("Failed to send long message preample.");
+return -1;
+}
 }
 
-const int result = Poco::Net::WebSocket::sendFrame(buffer, length, 
flags);
+int result = -1;
+if (!poll(waitZero, Socket::SelectMode::SELECT_ERROR) &&
+poll(waitZero, Socket::SelectMode::SELECT_WRITE))
+{
+result = Poco::Net::WebSocket::sendFrame(buffer, length, flags);
+}
 
 lock.unlock();
 
 if (result != length)
 {
 LOG_ERR("Sent incomplete message, expected " << length << " bytes 
but sent " << result <<
-" while sending: " << 
LOOLProtocol::getAbbreviatedFrameDump(buffer, length, flags));
+" for: " << LOOLProtocol::getAbbreviatedFrameDump(buffer, 
length, flags));
 }
 else
 {

[Libreoffice-bugs] [Bug 104624] New: Import issues with Pagemaker 6.5 files

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104624

Bug ID: 104624
   Summary: Import issues with Pagemaker 6.5 files
   Product: libpagemaker
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: christoph-schae...@gmx.de

Created attachment 129560
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129560=edit
P65 files and PDF versions

I have attached an archive with p65 files as well as PDF versions for control
purposes.

The issues are too numerous to list here, but the comparison between the PDFs
and LO's Pagemaker import should make it clear where the problems lie.

Note that mot all test files are in RGB. I also used CMYK and spot colours, but
libpagemaker doesn't seem to recognise these colour models.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: common/IoUtil.cpp

2016-12-12 Thread Ashod Nakashian

 common/IoUtil.cpp |   31 ++-
 1 file changed, 22 insertions(+), 9 deletions(-)

New commits:
commit 6b8ed0dac64dd08fab947f6b6c0af5ddbdc65a9c
Author: Ashod Nakashian 
Date:   Mon Dec 12 21:48:42 2016 -0500

loolwsd: handle socket error and close better

If the socket is in error, SELECT_READ returns
immediatly as failure. In this case we sit
in a tight loop polling read over and over.
We now check for SELECT_ERROR when SElECT_READ
fails to properly close the socket and break.

When receiveFrame returns -1, we should first
check the flags for socket close, as that
is a legitimate case of returning -ve.

Change-Id: I7bbc948638a8395d28990ba92eddb9a1a9f1e6f2
Reviewed-on: https://gerrit.libreoffice.org/31932
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/IoUtil.cpp b/common/IoUtil.cpp
index a8cd003..9958bfe 100644
--- a/common/IoUtil.cpp
+++ b/common/IoUtil.cpp
@@ -72,6 +72,14 @@ void SocketProcessor(const std::shared_ptr& 
ws,
 if (!ws->poll(waitTime, Poco::Net::Socket::SELECT_READ) ||
 stopPredicate())
 {
+// If SELECT_READ fails, it might mean the socket is in error.
+if (ws->poll(Poco::Timespan(0), 
Poco::Net::Socket::SELECT_ERROR))
+{
+LOG_WRN("SocketProcessor [" << name << "]: Socket error.");
+closeFrame();
+break;
+}
+
 // Wait some more.
 continue;
 }
@@ -79,7 +87,7 @@ void SocketProcessor(const std::shared_ptr& ws,
 try
 {
 payload.resize(payload.capacity());
-n = -1; // In case receiveFrame throws we log dropped data.
+n = -1; // In case receiveFrame throws we log dropped data 
below.
 (void)n;
 n = ws->receiveFrame(payload.data(), payload.size(), flags);
 payload.resize(std::max(n, 0));
@@ -90,17 +98,17 @@ void SocketProcessor(const std::shared_ptr& 
ws,
 continue;
 }
 
-if (n == -1)
-{
-LOG_DBG("SocketProcessor [" << name << "]: was not an 
interesting frame, nothing to do here");
-continue;
-}
-else if (n == 0 || ((flags & WebSocket::FRAME_OP_BITMASK) == 
WebSocket::FRAME_OP_CLOSE))
+if (n == 0 || ((flags & WebSocket::FRAME_OP_BITMASK) == 
WebSocket::FRAME_OP_CLOSE))
 {
 LOG_WRN("SocketProcessor [" << name << "]: Connection 
closed.");
 closeFrame();
 break;
 }
+else if (n < 0)
+{
+LOG_DBG("SocketProcessor [" << name << "]: was not an 
interesting frame, nothing to do here");
+continue;
+}
 
 assert(n > 0);
 
@@ -109,17 +117,22 @@ void SocketProcessor(const 
std::shared_ptr& ws,
 {
 // One WS message split into multiple frames.
 // TODO: Is this even possible with Poco if we never construct 
such messages outselves?
-LOG_WRN("SocketProcessor [" << name << "]: Receiving 
multi-parm frame.");
+LOG_WRN("SocketProcessor [" << name << "]: Receiving 
multi-part frame.");
 while (true)
 {
 char buffer[READ_BUFFER_SIZE];
 n = ws->receiveFrame(buffer, sizeof(buffer), flags);
-if (n <= 0 || (flags & WebSocket::FRAME_OP_BITMASK) == 
WebSocket::FRAME_OP_CLOSE)
+if (n == 0 || (flags & WebSocket::FRAME_OP_BITMASK) == 
WebSocket::FRAME_OP_CLOSE)
 {
 LOG_WRN("SocketProcessor [" << name << "]: Connection 
closed while reading multiframe message.");
 closeFrame();
 break;
 }
+else if (n < 0)
+{
+LOG_DBG("SocketProcessor [" << name << "]: was not an 
interesting frame, nothing to do here");
+continue;
+}
 
 payload.insert(payload.end(), buffer, buffer + n);
 if ((flags & WebSocket::FrameFlags::FRAME_FLAG_FIN) == 
WebSocket::FrameFlags::FRAME_FLAG_FIN)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Session.cpp common/Session.hpp kit/ChildSession.cpp kit/ChildSession.hpp wsd/ClientSession.cpp wsd/PrisonerSession.cpp wsd/TileCache.cpp

2016-12-12 Thread Ashod Nakashian

 common/Session.cpp  |   10 +++---
 common/Session.hpp  |   39 +--
 kit/ChildSession.cpp|2 +-
 kit/ChildSession.hpp|8 ++--
 wsd/ClientSession.cpp   |2 +-
 wsd/PrisonerSession.cpp |2 +-
 wsd/TileCache.cpp   |4 +---
 7 files changed, 10 insertions(+), 57 deletions(-)

New commits:
commit 477ca6f414090941d66392d0b3081eb2d8b1f6c2
Author: Ashod Nakashian 
Date:   Mon Dec 12 20:18:25 2016 -0500

loolwsd: cleanup the Sessions

Change-Id: I3cd065ab84e17f943fa7de7e094db574ff6fde07
Reviewed-on: https://gerrit.libreoffice.org/31931
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/Session.cpp b/common/Session.cpp
index f2c68ec..0e51de5 100644
--- a/common/Session.cpp
+++ b/common/Session.cpp
@@ -49,14 +49,10 @@ using Poco::Net::Socket;
 using Poco::Net::WebSocket;
 using Poco::StringTokenizer;
 
-Session::Session(const std::string& id, const Kind kind,
- std::shared_ptr ws) :
+Session::Session(const std::string& name, const std::string& id, const 
std::shared_ptr& ws) :
 _id(id),
-_kind(kind),
-_kindString(kind == Kind::ToClient ? "ToClient" :
-kind == Kind::ToMaster ? "ToMaster" : "ToPrisoner"),
-_name(_kindString + '-' + id),
-_ws(std::move(ws)),
+_name(name),
+_ws(ws),
 _disconnected(false),
 _isActive(true),
 _lastActivityTime(std::chrono::steady_clock::now()),
diff --git a/common/Session.hpp b/common/Session.hpp
index 617348a..8277c5e 100644
--- a/common/Session.hpp
+++ b/common/Session.hpp
@@ -32,17 +32,6 @@
 class Session
 {
 public:
-/// We have three kinds of Websocket sessions
-/// 1) Between the master loolwsd server to the end-user LOOL client
-/// 2) Between the master loolwsd server and a jailed child process, in 
the master process
-/// 3) Ditto, in the jailed process
-enum class Kind
-{
-ToClient,
-ToPrisoner,
-ToMaster
-};
-
 const std::string& getId() const { return _id; }
 const std::string& getName() const { return _name; }
 bool isDisconnected() const { return _disconnected; }
@@ -77,13 +66,10 @@ public:
 void closeFrame() { _isCloseFrame = true; };
 bool isCloseFrame() const { return _isCloseFrame; }
 
-Kind getKind() const { return _kind; }
-
 bool isHeadless() const { return _ws == nullptr; }
 
 protected:
-Session(const std::string& id, const Kind kind,
-std::shared_ptr ws);
+Session(const std::string& name, const std::string& id, const 
std::shared_ptr& ws);
 virtual ~Session();
 
 /// Parses the options of the "load" command, shared between 
MasterProcessSession::loadDocument() and ChildProcessSession::loadDocument().
@@ -107,12 +93,6 @@ private:
 /// A session ID specific to an end-to-end connection (from user to lokit).
 const std::string _id;
 
-// Our kind signifies to what we are connected to.
-const Kind _kind;
-
-// The kind cached as a string.
-const std::string _kindString;
-
 /// A readable name that identifies our peer and ID.
 const std::string _name;
 
@@ -158,23 +138,6 @@ protected:
 std::string _userName;
 };
 
-template 
-inline std::basic_ostream& operator<<(std::basic_ostream& stream, Session::Kind kind)
-{
-switch (kind)
-{
-case Session::Kind::ToClient:
-return stream << "TO_CLIENT";
-case Session::Kind::ToPrisoner:
-return stream << "TO_PRISONER";
-case Session::Kind::ToMaster:
-return stream << "TO_MASTER";
-default:
-assert(false);
-return stream << "UNK_" + std::to_string(static_cast(kind));
-}
-}
-
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index 9df2b56..cd1f404 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -37,7 +37,7 @@ std::recursive_mutex ChildSession::Mutex;
 ChildSession::ChildSession(const std::string& id,
const std::string& jailId,
IDocumentManager& docManager) :
-Session(id, Kind::ToMaster, nullptr),
+Session("ToMaster-" + id, id, nullptr),
 _jailId(jailId),
 _docManager(docManager),
 _viewId(-1),
diff --git a/kit/ChildSession.hpp b/kit/ChildSession.hpp
index 19005ac..c41426a 100644
--- a/kit/ChildSession.hpp
+++ b/kit/ChildSession.hpp
@@ -35,8 +35,7 @@ public:
 const std::string& userName,
 const std::string& docPassword,
 const std::string& renderOpts,
-const bool haveDocPassword)
-= 0;
+const bool haveDocPassword) = 0;
 
 /// Unload a client session, which unloads the document
 /// if it is the last and only.
@@ -94,10

[Libreoffice-commits] online.git: common/Session.cpp common/Session.hpp common/Unit.hpp kit/ChildSession.cpp kit/ChildSession.hpp test/UnitFuzz.cpp wsd/ClientSession.cpp wsd/ClientSession.hpp wsd/Pris

2016-12-12 Thread Ashod Nakashian

 common/Session.cpp  |   30 +++---
 common/Session.hpp  |   18 +-
 common/Unit.hpp |4 ++--
 kit/ChildSession.cpp|4 ++--
 kit/ChildSession.hpp|2 +-
 test/UnitFuzz.cpp   |2 +-
 wsd/ClientSession.cpp   |2 +-
 wsd/ClientSession.hpp   |2 +-
 wsd/PrisonerSession.cpp |2 +-
 wsd/PrisonerSession.hpp |3 ++-
 wsd/QueueHandler.hpp|4 ++--
 wsd/SenderQueue.hpp |4 ++--
 wsd/TileCache.cpp   |2 +-
 13 files changed, 40 insertions(+), 39 deletions(-)

New commits:
commit e60bc28a0059c25f3c30bd06dcdae8a391641ecc
Author: Ashod Nakashian 
Date:   Mon Dec 12 19:53:58 2016 -0500

loolwsd: LOOLSession -> Session

Change-Id: I94369480fb0a6789375dfe5610ada300e94b80eb
Reviewed-on: https://gerrit.libreoffice.org/31930
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/Session.cpp b/common/Session.cpp
index 5ead325..f2c68ec 100644
--- a/common/Session.cpp
+++ b/common/Session.cpp
@@ -49,7 +49,7 @@ using Poco::Net::Socket;
 using Poco::Net::WebSocket;
 using Poco::StringTokenizer;
 
-LOOLSession::LOOLSession(const std::string& id, const Kind kind,
+Session::Session(const std::string& id, const Kind kind,
  std::shared_ptr ws) :
 _id(id),
 _kind(kind),
@@ -67,11 +67,11 @@ LOOLSession::LOOLSession(const std::string& id, const Kind 
kind,
 {
 }
 
-LOOLSession::~LOOLSession()
+Session::~Session()
 {
 }
 
-bool LOOLSession::sendTextFrame(const char* buffer, const int length)
+bool Session::sendTextFrame(const char* buffer, const int length)
 {
 LOG_TRC(getName() << ": Send: " << getAbbreviatedMessage(buffer, length));
 try
@@ -89,14 +89,14 @@ bool LOOLSession::sendTextFrame(const char* buffer, const 
int length)
 }
 catch (const Exception& exc)
 {
-LOG_ERR("LOOLSession::sendTextFrame: Exception: " << exc.displayText() 
<<
+LOG_ERR("Session::sendTextFrame: Exception: " << exc.displayText() <<
 (exc.nested() ? "( " + exc.nested()->displayText() + ")" : 
""));
 }
 
 return false;
 }
 
-bool LOOLSession::sendBinaryFrame(const char *buffer, int length)
+bool Session::sendBinaryFrame(const char *buffer, int length)
 {
 LOG_TRC(getName() << ": Send: " << std::to_string(length) << " bytes.");
 try
@@ -114,14 +114,14 @@ bool LOOLSession::sendBinaryFrame(const char *buffer, int 
length)
 }
 catch (const Exception& exc)
 {
-LOG_ERR("LOOLSession::sendBinaryFrame: Exception: " << 
exc.displayText() <<
+LOG_ERR("Session::sendBinaryFrame: Exception: " << exc.displayText() <<
 (exc.nested() ? "( " + exc.nested()->displayText() + ")" : 
""));
 }
 
 return false;
 }
 
-void LOOLSession::parseDocOptions(const StringTokenizer& tokens, int& part, 
std::string& timestamp)
+void Session::parseDocOptions(const StringTokenizer& tokens, int& part, 
std::string& timestamp)
 {
 // First token is the "load" command itself.
 size_t offset = 1;
@@ -178,7 +178,7 @@ void LOOLSession::parseDocOptions(const StringTokenizer& 
tokens, int& part, std:
 }
 }
 
-void LOOLSession::disconnect()
+void Session::disconnect()
 {
 try
 {
@@ -190,19 +190,19 @@ void LOOLSession::disconnect()
 }
 catch (const IOException& exc)
 {
-LOG_ERR("LOOLSession::disconnect: Exception: " << exc.displayText() <<
+LOG_ERR("Session::disconnect: Exception: " << exc.displayText() <<
 (exc.nested() ? " (" + exc.nested()->displayText() + ")" : 
""));
 }
 }
 
-bool LOOLSession::handleDisconnect()
+bool Session::handleDisconnect()
 {
 _disconnected = true;
 IoUtil::shutdownWebSocket(_ws);
 return false;
 }
 
-void LOOLSession::shutdown(Poco::UInt16 statusCode, const std::string& 
statusMessage)
+void Session::shutdown(Poco::UInt16 statusCode, const std::string& 
statusMessage)
 {
 if (_ws)
 {
@@ -213,13 +213,13 @@ void LOOLSession::shutdown(Poco::UInt16 statusCode, const 
std::string& statusMes
 }
 catch (const Poco::Exception )
 {
-LOG_WRN("LOOLSession::shutdown LOOLWebSocket: Exception: " <<
+LOG_WRN("Session::shutdown LOOLWebSocket: Exception: " <<
 exc.displayText() << (exc.nested() ? " (" + 
exc.nested()->displayText() + ")" : ""));
 }
 }
 }
 
-bool LOOLSession::handleInput(const char *buffer, int length)
+bool Session::handleInput(const char *buffer, int length)
 {
 assert(buffer != nullptr);
 
@@ -238,14 +238,14 @@ bool LOOLSession::handleInput(const char *buffer, int 
length)
 }
 catch (const Exception& exc)
 {
-LOG_ERR("LOOLSession::handleInput: Exception while handling [" <<
+LOG_ERR("Session::handleInput: Exception while handling [" <<
 getAbbreviatedMessage(buffer, length) <<

[Libreoffice-bugs] [Bug 104623] Import issues with MS Publisher 98 files

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104623

--- Comment #1 from Christoph Schäfer  ---
I forgot: Both LO and Scribus add an empty page at the beginning of the
imported doc, where in the original and the PDF there is none.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104623] New: Import issues with MS Publisher 98 files

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104623

Bug ID: 104623
   Summary: Import issues with MS Publisher 98 files
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: filters and storage
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: christoph-schae...@gmx.de

Created attachment 129559
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129559=edit
Publisher 98 test files + PDFs

I have attached 2 PUB files with PDF versions for control purposes. The filter
currently doesn't recognise any graphical elements, only text, which is badly
placed and formatted due to a lack of an obligatory font substitution upon
import. Scribus does slightly better but doesn't find any graphical elements
either.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96221] Crash during open CSV file - SEH Exception ( when UTF character set selected)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96221

Takeshi Abe  changed:

   What|Removed |Added

 CC||t...@fixedpoint.jp

--- Comment #9 from Takeshi Abe  ---
I cannot reproduce this issue with LibO 5.1.6 on Windows 10.
Could you try LibO 5.1 or 5.2?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104621] Formatting toolbar closes and cannot be reopened after converting text to Math object

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104621

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||mst...@redhat.com,
   ||s.mehrbr...@gmail.com,
   ||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Confirmed On Windows build with STR as given.

the Formatting toolbar returns in 

Version: 5.4.0.0.alpha0+
Build ID: cb598029835477326b190bc99abd31a487cc5a91
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-12-09_00:51:51
Locale: en-US (en_US); Calc: C

but goes missing, on return from OLE math object, with

Version: 5.4.0.0.alpha0+
Build ID: b894104a0b02a9b074c76feb925389d7bee6a493
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-12-10_01:00:52
Locale: en-US (en_US); Calc: CL

https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=cb598029835477326b190bc99abd31a487cc5a91..b894104a0b02a9b074c76feb925389d7bee6a493

This looks kind of suspect... 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=84f2ff67a7e404febf710b1dc7f66d06745c503f

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104206] Allow Paragraph Styles to bind to List Styles' levels, like with Outline Numbering

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104206

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
Please examine ODF and its concepts of outline and lists and discuss file
format solutions very early.

(In reply to Mike Kaganski from comment #0)

> When a paragraph style is associated with Outline Numbering level, its
> "Outline & Numbering" property page controls for Numbering style and Outline
> level become disabled.
More exact, if it gets the default outline numbering via Tools > Outline
Numbering.

> 
> OTOH, any paragraph, that is not used in Outline Numbering, may be
> associated with a list style using controls on that property page. This
> allows paragraphs with that paragraph style to become numbered using
> selected list style, and retain the paragraph style on changing list's level.
"associated with a list style" is not exact enough. You need to distinguish,
whether the paragraph has got an outline level or not on that property page.


> 
> The proposal is the following: to allow paragraph style to optionally
> specify selected list style's level at the Outline & Numbering property
> page.

I'm not sure about this. In case of the default outline, the  has the
text:outline-level attribute. In case of a user outline it has already the same
text:outline-level attribute.

Currently in case of user outline, not the numbering-style is used, which has
the same text:level value. In case of the default outline this binding between
text:outline-level and text:level is done.


I see an additional problem: Currently a  is written, whether an
outline level is set or not. So there exists a "level" given by the 
nesting and a setting of the numbering style by the . On the other
hand, the paragraph style has a list-style-name attribute and a
default-outline-level attribute.


>I suppose that it could be made a GSoC project task.
Do you will mentor it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104052] Add LibreColour HLC palette

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104052

--- Comment #54 from Taylor Jenkins  ---
Created attachment 129558
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129558=edit
Comparison between hlcfaecher.pdf & LO Writer w/ librecolour.soc

This is a screenshot with the hlcfaecher.pdf color swatch on the left, the
corresponding color in LO from librecolour.soc in the the middle, and the color
in LO using the hex value shown in the pdf, on the right. When the two
different hex values are shown side by side in LO, they are not noticeably
different on my monitor. Curious why the pdf was noticeably different, I used a
color picker to determine the actual color value, which is shown overlaid on
the pdf color swatch.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95844] Refactor CommandInfoProvider

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95844

Rohan Kumar  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rohankanojia...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56963] FILEOPEN, EDITING: Stability degrades with large document

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=56963

--- Comment #26 from David  ---
The test files are no longer publicly available.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100100] Emoji toolbar control

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100100

Akshay Deep  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4622

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104622] Add duplicate node entry to elements in emoji.json database

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104622

Akshay Deep  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104622] New: Add duplicate node entry to elements in emoji.json database

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104622

Bug ID: 104622
   Summary: Add duplicate node entry to elements in emoji.json
database
   Product: LibreOffice
   Version: 5.3.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: difficultyBeginner, easyHack, topicCleanup
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: akshaydeepi...@gmail.com
QA Contact: akshaydeepi...@gmail.com
CC: s.mehrbr...@gmail.com

In the file sfx2/emojiconfig/emoji.json
(http://opengrok.libreoffice.org/xref/core/sfx2/emojiconfig/emoji.json), there
are certain entries which representes an emoji but with different color(skin
tone). The task is to find such emojis and add a boolean field such as:

"duplicate" : true

Add these entries to all the emoji nodes which represents same emoji with
different tone. Leave the first instance as it is, i.e. if there are 5 tones of
an emoji, add duplicate field on all instances except the first instance.

"angel_tone1" <--{No need to add boolean field}
"angel_tone2" <--add boolean field
"angel_tone3" <--add boolean field
"angel_tone4" <--add boolean field
"angel_tone5" <--add boolean field

Reason: Emojis are rendered using font glyphs. We don’t support fonts with SVG
table on Linux or Mac. Fonts with SVG tables are so far only supported on
Windows 10 with anniversary update. "EmojiOne" font which is used in the Emoji
toolbar control provides for black and white fallback glyphs, which leaves
different tones of emoji appear same.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 100100] Emoji toolbar control

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100100

Akshay Deep  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4622

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 104617] Writer encounters a read error on opening its own saved ODT file

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104617

MM  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from MM  ---
1) LO V4 is EOL for some time now, so there's no more support for it.

2) Are you sure your xml works ? When I check it with a validator I get:

Error on->  Line :1 Column :24
Message :Namespace prefix text for style-name on p is not defined

Error on->  Line :1 Column :24
Message :Namespace prefix text on p is not defined

Error on->  Line :1 Column :55
Message :Namespace prefix office for name on annotation is not defined

Error on->  Line :1 Column :55
Message :Namespace prefix office on annotation is not defined

Error on->  Line :1 Column :67
Message :Namespace prefix dc on creator is not defined

Error on->  Line :1 Column :95
Message :Namespace prefix dc on date is not defined

Error on->  Line :1 Column :144
Message :Namespace prefix text for style-name on list is not defined

Error on->  Line :1 Column :144
Message :Namespace prefix text on list is not defined

Error on->  Line :1 Column :160
Message :Namespace prefix text on list-item is not defined

Error on->  Line :1 Column :168
Message :Namespace prefix text on p is not defined

Error on->  Line :1 Column :357
Message :Namespace prefix text on s is not defined

Error on->  Line :2 Column :7
Message :Extra content at the end of the document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104052] Add LibreColour HLC palette

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104052

--- Comment #53 from Taylor Jenkins  ---
(In reply to V Stuart Foote from comment #52)
> 
> Unfortunately, I've noticed there are considerable differences between the
> sRGB Hex values used in your .soc palette, and the sRGB Hex values indicated
> on the PDF of the freieFARBE HLCColors fan [1].
> 
> =-ref-=
> [1] http://dtpstudio.de/cielab/downloads/hlcfaecher.pdf

I agree, it appears that none of the hex values in the pdf match the hex values
in the .soc. For example, here is a line from the .soc:



The corresponding color on the pdf shows the following information:

HLC 090 90 60
Lab 90 0 60
sRGB 253 225 107 * HEX #FDE16B
CMYK 0 5 65 0

Notice how for the color name "HLC 090 90 60", the hex values do not match.
Though they are very similar, when the colors are placed side by side, they are
perceptibly different.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2016-12-12 Thread Zdeněk Crhonek

 sc/qa/unit/data/functions/fods/arabic.fods   |  982 
 sc/qa/unit/data/functions/fods/asc.fods  | 2579 ---
 sc/qa/unit/data/functions/fods/base.fods | 2129 -
 sc/qa/unit/data/functions/fods/char.fods | 4308 ---
 sc/qa/unit/data/functions/fods/clean.fods| 2088 -
 sc/qa/unit/data/functions/fods/code.fods | 3082 -
 sc/qa/unit/data/functions/fods/concat.fods   | 1373 --
 sc/qa/unit/data/functions/fods/concatenate.fods  | 1316 -
 sc/qa/unit/data/functions/fods/decimal.fods  | 1719 ---
 sc/qa/unit/data/functions/fods/dollar.fods   | 1360 -
 sc/qa/unit/data/functions/fods/exact.fods| 2968 -
 sc/qa/unit/data/functions/fods/find.fods | 1291 -
 sc/qa/unit/data/functions/fods/fixed.fods| 1177 -
 sc/qa/unit/data/functions/fods/left.fods | 1198 -
 sc/qa/unit/data/functions/fods/leftb.fods| 1195 -
 sc/qa/unit/data/functions/fods/len.fods  | 1235 -
 sc/qa/unit/data/functions/fods/lenb.fods | 1235 -
 sc/qa/unit/data/functions/fods/lower.fods| 1270 -
 sc/qa/unit/data/functions/fods/mid.fods  | 1133 
 sc/qa/unit/data/functions/fods/midb.fods | 1133 
 sc/qa/unit/data/functions/fods/numbervalue.fods  | 1181 -
 sc/qa/unit/data/functions/fods/proper.fods   | 1214 -
 sc/qa/unit/data/functions/fods/replace.fods  | 1213 -
 sc/qa/unit/data/functions/fods/rept.fods | 1179 -
 sc/qa/unit/data/functions/fods/rightb.fods   | 1492 --
 sc/qa/unit/data/functions/fods/roman.fods| 1330 -
 sc/qa/unit/data/functions/text/fods/arabic.fods  |  982 
 sc/qa/unit/data/functions/text/fods/asc.fods | 2579 +++
 sc/qa/unit/data/functions/text/fods/base.fods| 2129 +
 sc/qa/unit/data/functions/text/fods/char.fods| 4308 +++
 sc/qa/unit/data/functions/text/fods/clean.fods   | 2088 +
 sc/qa/unit/data/functions/text/fods/code.fods| 3082 +
 sc/qa/unit/data/functions/text/fods/concat.fods  | 1373 ++
 sc/qa/unit/data/functions/text/fods/concatenate.fods | 1316 +
 sc/qa/unit/data/functions/text/fods/decimal.fods | 1719 +++
 sc/qa/unit/data/functions/text/fods/dollar.fods  | 1360 +
 sc/qa/unit/data/functions/text/fods/exact.fods   | 2968 +
 sc/qa/unit/data/functions/text/fods/find.fods| 1291 +
 sc/qa/unit/data/functions/text/fods/fixed.fods   | 1177 +
 sc/qa/unit/data/functions/text/fods/left.fods| 1198 +
 sc/qa/unit/data/functions/text/fods/leftb.fods   | 1195 +
 sc/qa/unit/data/functions/text/fods/len.fods | 1235 +
 sc/qa/unit/data/functions/text/fods/lenb.fods| 1235 +
 sc/qa/unit/data/functions/text/fods/lower.fods   | 1270 +
 sc/qa/unit/data/functions/text/fods/mid.fods | 1133 
 sc/qa/unit/data/functions/text/fods/midb.fods| 1133 
 sc/qa/unit/data/functions/text/fods/numbervalue.fods | 1181 +
 sc/qa/unit/data/functions/text/fods/proper.fods  | 1214 +
 sc/qa/unit/data/functions/text/fods/replace.fods | 1213 +
 sc/qa/unit/data/functions/text/fods/rept.fods| 1179 +
 sc/qa/unit/data/functions/text/fods/rightb.fods  | 1492 ++
 sc/qa/unit/data/functions/text/fods/roman.fods   | 1330 +
 52 files changed, 42380 insertions(+), 42380 deletions(-)

New commits:
commit 08fa2e9307c9e4a49e18ecb0b4e9461492122fe3
Author: ZdenÄk Crhonek 
Date:   Mon Dec 12 22:20:49 2016 +0100

Calc function tests - move text function to new dir

Change-Id: I3a47c0e90e93050419326303c175cdc2adef6796
Reviewed-on: https://gerrit.libreoffice.org/31925
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/qa/unit/data/functions/fods/arabic.fods 
b/sc/qa/unit/data/functions/text/fods/arabic.fods
similarity index 100%
rename from sc/qa/unit/data/functions/fods/arabic.fods
rename to sc/qa/unit/data/functions/text/fods/arabic.fods
diff --git a/sc/qa/unit/data/functions/fods/asc.fods 
b/sc/qa/unit/data/functions/text/fods/asc.fods
similarity index 100%
rename from sc/qa/unit/data/functions/fods/asc.fods
rename to sc/qa/unit/data/functions/text/fods/asc.fods
diff --git a/sc/qa/unit/data/functions/fods/base.fods 
b/sc/qa/unit/data/functions/text/fods/base.fods
similarity index 100%
rename from sc/qa/unit/data/functions/fods/base.fods
rename to sc/qa/unit/data/functions/text/fods/base.fods
diff --git a/sc/qa/unit/data/functions/fods/char.fods 
b/sc/qa/unit/data/functions/text/fods/char.fods
similarity index 100%
rename from sc/qa/unit/data/functions/fods/char.fods
rename to

[Libreoffice-bugs] [Bug 104616] FILEOPEN DOC: Regression in layout between LibO4.3 and LibO4.4

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104616

Telesto  changed:

   What|Removed |Added

   Keywords|bibisected  |bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104413] Area tab: tooltips missing

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104413

--- Comment #4 from V Stuart Foote  ---
@Jay, *

To be honest the reworked Area dialog, or the Frame dialog in general and their
Help--i.e. tooltips & extended tooltips--have really diverged from
description(s) we provide in the local and on-line help--and in the published
guides.

For these areas of the UI that have changed so much, providing a corrected
tooltips for each widget really should be the norm--it is the least we should
do for the users.

And of course the extended tool-tips from help are a component of our a11y AT
support. When we lack a specific tool-tip/extended tool-tip for each widget the
a11y assistance becomes annoyingly repetitive using a generic.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104621] New: Formatting toolbar closes and cannot be reopened after converting text to Math object

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104621

Bug ID: 104621
   Summary: Formatting toolbar closes and cannot be reopened after
converting text to Math object
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Keywords: regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Open Writer. You should see the Formatting toolbar.
Enable the "Insert Formula" icon in the Standard toolbar, in case you have not
done yet.
Write a text, which can be a formula. For example write a^2+b^2=c^2.
Mark this text and click on "Insert Formula". The text should be converted to a
Math object without opening the UI of Math. Click in text to leave object mode.

Notice, that this action has closed the Formatting toolbar and it does not open
again. That should not happen and did not happen in older Versions.
Go to menu View > Toolbars and try to reopen the Formatting toolbar. It is not
possible.

To repair the state of LibreOffice double click the formula to open the Math
UI, click into the Writer text to leave the Math UI, and click again into the
Writer text. Now the Formatting toolbar should be open again. Otherwise restart
LibreOffice.

I use version 5.4 on Windows 7. Converting to Math this way works in version
5.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: dbaccess/qa

2016-12-12 Thread Michael Stahl

 dbaccess/qa/complex/dbaccess/RowSet.java |7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit ae8bd4267ac2da58f9e476d24e1e894202e92dea
Author: Michael Stahl 
Date:   Mon Dec 12 23:17:51 2016 +0100

dbaccess: fix testCloneMovesPlusDeletions test

JunitTest_dbaccess_complex spuriously fails 1% of the time with:

1) testCloneMovesPlusDeletions(complex.dbaccess.RowSet)
java.lang.AssertionError: moving to the next record after |deleteRow| and 
clone moves failed
at complex.dbaccess.RowSet.testCloneMovesPlusDeletions(RowSet.java:756)

The problem is that line RowSet.java:750 deleteRow() manages to delete
the last row in the set, because the positionRandom() is tricked to
position itself on the last row (which it tries not to do), becuase the
RowSet is currently positioned past-the-end on a deleted row and the
ORowSetBase::impl_getRowCount() is a lying bastard that adds 1 to the
result in this special case.

Funnily both the ORowSetBase::impl_getRowCount() and the test using
positionRandom() were added in CWS rowsetdel.  Yay for randomized
tests!

Change-Id: Ic8c7bfa190f6a5269604cf5b3c338f2d0b64205e

diff --git a/dbaccess/qa/complex/dbaccess/RowSet.java 
b/dbaccess/qa/complex/dbaccess/RowSet.java
index 2cbf942..e617d25 100644
--- a/dbaccess/qa/complex/dbaccess/RowSet.java
+++ b/dbaccess/qa/complex/dbaccess/RowSet.java
@@ -528,7 +528,12 @@ public class RowSet extends TestCase
  */
 private int positionRandom() throws SQLException, 
UnknownPropertyException, WrappedTargetException
 {
-final int position = (new Random()).nextInt(currentRowCount() - 2) + 2;
+// note: obviously this should subtract 2 but actually subtract 3
+// because if we have just deleted the current row then
+// ORowSetBase::impl_getRowCount() will lie and currentRowCount()
+// returns 1 more than the actual number of rows and then
+// positionRandom() followed by deleteRow() deletes *last* row
+final int position = (new Random()).nextInt(currentRowCount() - 3) + 2;
 assertTrue("sub task failed: could not position to row no. " + 
(Integer.valueOf(position)).toString(),
 m_resultSet.absolute(position));
 return m_resultSet.getRow();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104607] CRASH: Writer crashes closing a document (GTK+/GTK3)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104607

Xisco Faulí  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #5 from Xisco Faulí  ---
Caolán, would you mind to take a look at this one whenever you have time?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104620] CRASH: Writer crashes scrolling down a document (GTK+/GTK3)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104620

Xisco Faulí  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #2 from Xisco Faulí  ---
I can't reproduce it in

Version: 5.3.0.0.alpha1+
Build ID: ada8a2123ea655142be74a11c23e042a0109d5f8
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Layout
Engine: new; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

Caolán, would you mind to take a look whenever you have time?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104620] CRASH: Writer crashes scrolling down a document (GTK+/GTK3)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104620

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Confirmed with 5.4 daily build (2016-12-10_00:00:32) / Ubuntu 16.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104620] CRASH: Writer crashes scrolling down a document (GTK+/GTK3)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104620

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
   Priority|medium  |highest
   Severity|normal  |critical

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104620] CRASH: Writer crashes scrolling down a document (GTK+/GTK3)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104620

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 OS|All |Linux (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104620] New: CRASH: Writer crashes scrolling down a document (GTK+/ GTK3)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104620

Bug ID: 104620
   Summary: CRASH: Writer crashes scrolling down a document
(GTK+/GTK3)
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps:
1. Open attachment 86269
2. Scroll down

Observed behaviour: LibreOffice crashes right away

Reproduced in:

Version: 5.4.0.0.alpha0+
Build ID: 634589b340316ba64b731b4d923c1056be415494
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

and

Version: 5.4.0.0.alpha0+
Build ID: 634589b340316ba64b731b4d923c1056be415494
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

but not in

Version: 5.4.0.0.alpha0+
Build ID: 634589b340316ba64b731b4d923c1056be415494
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: x11; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2016-12-12 Thread Tor Lillqvist

 vcl/inc/unx/gtk/gtkgdi.hxx|7 +++
 vcl/inc/unx/salgdi.h  |3 ++-
 vcl/unx/generic/gdi/font.cxx  |4 
 vcl/unx/generic/gdi/salgdi.cxx|8 +++-
 vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx |6 ++
 5 files changed, 26 insertions(+), 2 deletions(-)

New commits:
commit b5f0c82393d88b81ea1f75fcc4cafc2aa947e206
Author: Tor Lillqvist 
Date:   Mon Dec 12 19:53:42 2016 +0200

Fix lossage with --disable-cairo-canvas

Change-Id: I9e822cfc1447fcd49c80c56df8ba37959555396a

diff --git a/vcl/inc/unx/gtk/gtkgdi.hxx b/vcl/inc/unx/gtk/gtkgdi.hxx
index e7169e9..f780964 100644
--- a/vcl/inc/unx/gtk/gtkgdi.hxx
+++ b/vcl/inc/unx/gtk/gtkgdi.hxx
@@ -20,6 +20,8 @@
 #ifndef INCLUDED_VCL_INC_UNX_GTK_GTKGDI_HXX
 #define INCLUDED_VCL_INC_UNX_GTK_GTKGDI_HXX
 
+#include 
+
 #include 
 #include 
 #include 
@@ -112,9 +114,14 @@ public:
 const OUString& rCaption,
 Rectangle 
,
 Rectangle 
 ) override;
+#if ENABLE_CAIRO_CANVAS
+
 virtual boolSupportsCairo() const override;
 virtual cairo::SurfaceSharedPtr CreateSurface(const 
cairo::CairoSurfaceSharedPtr& rSurface) const override;
 virtual cairo::SurfaceSharedPtr CreateSurface(const OutputDevice& 
rRefDevice, int x, int y, int width, int height) const override;
+
+#endif
+
 void WidgetQueueDraw() const;
 
 void updateSettings( AllSettings& rSettings );
diff --git a/vcl/inc/unx/salgdi.h b/vcl/inc/unx/salgdi.h
index 5eb9172..ef7ad2c 100644
--- a/vcl/inc/unx/salgdi.h
+++ b/vcl/inc/unx/salgdi.h
@@ -249,6 +249,8 @@ public:
 long nHeight, sal_uInt8 nTransparency 
) override;
 
 virtual SystemGraphicsData  GetGraphicsData() const override;
+
+#if ENABLE_CAIRO_CANVAS
 virtual boolSupportsCairo() const override;
 virtual cairo::SurfaceSharedPtr CreateSurface(const 
cairo::CairoSurfaceSharedPtr& rSurface) const override;
 virtual cairo::SurfaceSharedPtr CreateSurface(const OutputDevice& 
rRefDevice, int x, int y, int width, int height) const override;
@@ -256,7 +258,6 @@ public:
 virtual css::uno::Any   
GetNativeSurfaceHandle(cairo::SurfaceSharedPtr& rSurface, const 
basegfx::B2ISize& rSize) const override;
 virtual SystemFontData  GetSysFontData( int nFallbackLevel ) const 
override;
 
-#if ENABLE_CAIRO_CANVAS
 void clipRegion(cairo_t* cr);
 #endif // ENABLE_CAIRO_CANVAS
 
diff --git a/vcl/unx/generic/gdi/font.cxx b/vcl/unx/generic/gdi/font.cxx
index 37a3846..b4141e0 100644
--- a/vcl/unx/generic/gdi/font.cxx
+++ b/vcl/unx/generic/gdi/font.cxx
@@ -122,11 +122,15 @@ SalLayout* X11SalGraphics::GetTextLayout( ImplLayoutArgs& 
rArgs, int nFallbackLe
 return mxTextRenderImpl->GetTextLayout(rArgs, nFallbackLevel);
 }
 
+#if ENABLE_CAIRO_CANVAS
+
 SystemFontData X11SalGraphics::GetSysFontData( int nFallbackLevel ) const
 {
 return mxTextRenderImpl->GetSysFontData(nFallbackLevel);
 }
 
+#endif
+
 bool X11SalGraphics::CreateFontSubset(
const OUString& rToFile,
const PhysicalFontFace* pFont,
diff --git a/vcl/unx/generic/gdi/salgdi.cxx b/vcl/unx/generic/gdi/salgdi.cxx
index a7c7df8..63de2b43 100644
--- a/vcl/unx/generic/gdi/salgdi.cxx
+++ b/vcl/unx/generic/gdi/salgdi.cxx
@@ -356,7 +356,9 @@ void X11SalGraphics::ResetClipRegion()
 
 bool X11SalGraphics::setClipRegion( const vcl::Region& i_rClip )
 {
+#if ENABLE_CAIRO_CANVAS
 maClipRegion = i_rClip;
+#endif
 return mxImpl->setClipRegion( i_rClip );
 }
 
@@ -499,6 +501,8 @@ SystemGraphicsData X11SalGraphics::GetGraphicsData() const
 return aRes;
 }
 
+#if ENABLE_CAIRO_CANVAS
+
 bool X11SalGraphics::SupportsCairo() const
 {
 Display *pDisplay = GetXDisplay();
@@ -571,6 +575,8 @@ css::uno::Any 
X11SalGraphics::GetNativeSurfaceHandle(cairo::SurfaceSharedPtr& rS
 return css::uno::Any(args);
 }
 
+#endif // ENABLE_CAIRO_CANVAS
+
 // draw a poly-polygon
 bool X11SalGraphics::drawPolyPolygon( const basegfx::B2DPolyPolygon& 
rOrigPolyPoly, double fTransparency )
 {
@@ -586,12 +592,12 @@ bool X11SalGraphics::drawPolyPolygon( const 
basegfx::B2DPolyPolygon& rOrigPolyPo
 return true;
 }
 
+#if ENABLE_CAIRO_CANVAS
 if(SALCOLOR_NONE == mnFillColor && SALCOLOR_NONE == mnPenColor)
 {
 return true;
 }
 
-#if ENABLE_CAIRO_CANVAS
 static bool bUseCairoForPolygons = false;
 
 if (!m_bOpenGL && bUseCairoForPolygons && SupportsCairo())
diff --git a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx 
b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
index 8b654d9..98c385f 100644
--- a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
@@ -9,6 +9,8 @@
 
 #include 
 
+#include 
+
 #include 
 #include 
 #include 
@@

[Libreoffice-bugs] [Bug 104604] FILESAVE DOCX: Drawing shrinks and is broken down into parts after RT

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104604

--- Comment #3 from Telesto  ---
Or should it be marked as dupe of bug 104603 (?)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104554] Pasting columns between tables have unexpected behaviours

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104554

Aron Budea  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #6 from Aron Budea  ---
(In reply to Noel Grandin from comment #4)
> That commit was reverted in 
>1a583283d6b58c8951cb52faac82ecb24fdbf1b3
> and then re-applied (in a fixed form) in 
>f0fa43ea99ac7564f2cc7ca1d997831808056b68
> 
> So this should be fixed already? Unless we have more than one cause.

I'd assume the bibisect jumped through that commit range. I just checked with
the commit in the repo corresponding to
f0fa43ea99ac7564f2cc7ca1d997831808056b68 and the preceding one, and the
observation is:
-f0fa43ea99ac7564f2cc7ca1d997831808056b68: exhibits the bug,
-4c62de279a6783236a5e0811d0733e107c127fe3 (preceding commit): doesn't exhibit
the bug.

So the fix must've been for a different issue.
Julien, are you interested in this one?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104614] FILESAVE DOC: Only one page in Word Viewer ( regression between LibO4.3 and LibO4.4)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104614

--- Comment #4 from Telesto  ---
Seems to be a legacy software (Word 2003) issue. Nearly all online doc
converters can handle the 'new' doc-format. But when saving as 'doc' LibO
states: Microsoft Word 97-2003 (.doc), so I suppose it should be working on
Word 2003 too? Or not?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104571] Opening an ODS document is slow when OpenCL is enabled

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104571

--- Comment #6 from Roland Illig  ---
First, thank you very much for making my computer much faster. After installing
the updated graphics driver, Windows boots in 20 seconds instead of 200.

The downside is that my graphics card is quite old and seems to be unsupported
by now. After installing the Windows 7 drivers on Windows 10 (which worked
flawlessly, I still wonder why), running "OpenCL info.exe" does not work
anymore since it crashes before writing anything to the log file. But at least,
when I disable OpenCL in LibreOffice, it starts up quickly now.

So for my particular case, I'm happy enough with the workaround, but if you
want to research this for other users, I'm fine with that. Though there are
probably more important things to do. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: editeng/source

2016-12-12 Thread Julien Nabet

 editeng/source/accessibility/AccessibleContextBase.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b5ae4ccf462da85ec87e953212135871fd98bfbb
Author: Julien Nabet 
Date:   Mon Dec 12 20:22:36 2016 +0100

tdf#104540: AccessibleEventNotifier AccessibleBase (editeng)

See https://bugs.documentfoundation.org/attachment.cgi?id=129537 for bt
For the remind, it follows a replace of OSL_ENSURE by an assert, see:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8228227168a7eb3ebf14629bec87f01536c23970

Change-Id: Id05eeb6e6669232e9b5cc2ef2989827fef3025d0
Reviewed-on: https://gerrit.libreoffice.org/31918
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/editeng/source/accessibility/AccessibleContextBase.cxx 
b/editeng/source/accessibility/AccessibleContextBase.cxx
index e43433d..eea5451 100644
--- a/editeng/source/accessibility/AccessibleContextBase.cxx
+++ b/editeng/source/accessibility/AccessibleContextBase.cxx
@@ -401,7 +401,7 @@ void SAL_CALL 
AccessibleContextBase::removeAccessibleEventListener (
 throw (uno::RuntimeException, std::exception)
 {
 ThrowIfDisposed ();
-if (rxListener.is())
+if (rxListener.is() && mnClientId)
 {
 sal_Int32 nListenerCount = 
comphelper::AccessibleEventNotifier::removeEventListener( mnClientId, 
rxListener );
 if ( !nListenerCount )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104573] Assertion failed: SolarMutex not locked when trying to bring up File Open... dialog ( debug build)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104573

Mike Kaganski  changed:

   What|Removed |Added

 Attachment #129551|0   |1
is obsolete||

--- Comment #10 from Mike Kaganski  ---
Created attachment 129557
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129557=edit
The second assertion after the first was said to "Break"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104573] Assertion failed: SolarMutex not locked when trying to bring up File Open... dialog ( debug build)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104573

Mike Kaganski  changed:

   What|Removed |Added

 Attachment #129547|0   |1
is obsolete||

--- Comment #9 from Mike Kaganski  ---
Created attachment 129556
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129556=edit
Assertion dragging to StartCenter - call stack from VS

Sorry, didn't notice that Only my code is not unchecked

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104619] New: invisible icon

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104619

Bug ID: 104619
   Summary: invisible icon
   Product: LibreOffice
   Version: 5.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: phylr...@comcast.net

Since my recent Libre office update the icons for the LO components pinned to
my Windows 10 taskbar are invisible.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104618] VIEWING: In Writer missing text at 100% zoom in DOCX file

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104618

--- Comment #1 from greizde...@gmail.com ---
Created attachment 129553
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129553=edit
missing text lines with specific font in size 15

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104413] Area tab: tooltips missing

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104413

--- Comment #3 from Jean-Baptiste Faure  ---
(In reply to Yousuf Philips (jay) from comment #2)
> All these fields have been there since LO 3.3 and they never had tooltips.
> 
> @Heiko, @Stuart: Any thoughts of whether they are needed or not, as for me i
> dont think they are needed, as it looks self explanatory to me with all the
> labels we already have?

Really ? I guess nobody uses these functionalities because nobody understand
how each parameter acts to modify the result.
A label is not an explanation, it is only a name that is useless without a
descriptive tooltip.

Size: how do you know the original size when you have only percents ?
Percents: percents of what ? The original size or the size of the object?
Original size: I guess it is the size of the pattern. What is the unit? cm or
pixel?

Without explanation, the user can only randomly play with parameters until she
obtains almost what she want.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104618] VIEWING: In Writer missing text at 100% zoom in DOCX file

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104618

--- Comment #3 from greizde...@gmail.com ---
Created attachment 129555
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129555=edit
the .docx test file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104618] VIEWING: In Writer missing text at 100% zoom in DOCX file

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104618

--- Comment #2 from greizde...@gmail.com ---
Created attachment 129554
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129554=edit
font size 16 renders correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104613] FILEOPEN ODT: Rendering has changed in LibO5.3 compared to previous versions

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104613

--- Comment #4 from Telesto  ---
Pag 1 one at the bottom right: "the JOC on 0861 571" is missing in LibO5300,
but not in 5.2.2.1. Same at the bottom right on page 2 '082 911' isn't
'visible'

It could be Harfbuzz, but shouldn't happen in this way

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104618] New: VIEWING: In Writer missing text at 100% zoom in DOCX file

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104618

Bug ID: 104618
   Summary: VIEWING: In Writer missing text at 100% zoom in DOCX
file
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: greizde...@gmail.com

Created attachment 129552
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129552=edit
correctly rendered view at 90% zoom level

Hi,

I've a .docx file that has missing text at 100% zoom level. If change the zoom
to e.g. 90% it is displayed correctly (see attachment "render bug screenshot 90
perc zoom.PNG" and "render bug screenshot 100 perc zoom.PNG")

The particular lines that are not displayed are in a font called "Courier" with
size 15 for which Writer says it is not available and is substituted (see mouse
hovering message in attachment "render bug screenshot 100 perc zoom.PNG").

However, at 100% zoom level, if I change the font size of e.g. the first line
that's missing from 15 to e.g. 16 it suddenly appears correctly (see attachment
"render bug screenshot 100 perc zoom 16 font.PNG").

So it looks like it's just a specific combination of unavailable font at a
particular size that's causing the problem.

The original .docx file is also provided in the attachment.


Hope that's enough info for you guys.


Thanks a lot.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 40929] Restart numbering is not saved for the first list in a sub-document ( when viewed from master)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=40929

--- Comment #12 from bug.reporter.21  ---
A simpler workaround that works for me, with no extra open/close
Given the numbered list below

1) bla bla bla
2) bla bla bla

place the cursor after the "1)", press enter, then right click restart
numbering.
place the cursor after the "1)" (up arrow), then press suppr
now save

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104573] Assertion failed: SolarMutex not locked when trying to bring up File Open... dialog ( debug build)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104573

--- Comment #8 from Mike Kaganski  ---
Created attachment 129551
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129551=edit
The second assertion after the first was said to "Break"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104617] Writer encounters a read error on opening its own saved ODT file

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104617

--- Comment #1 from benjamin melançon  ---
Created attachment 129550
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129550=edit
A document that will trigger the error

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104617] New: Writer encounters a read error on opening its own saved ODT file

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104617

Bug ID: 104617
   Summary: Writer encounters a read error on opening its own
saved ODT file
   Product: LibreOffice
   Version: 4.3.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: b...@agaric.com

Description:
When opening a large (475 page) document with many tables and comments
(annotations), a read error is given and the application closes.

This is with LibreOffice 4.3.3.2 430m0(Build:2) on Debian; the same behavior
was experienced (and the file was originally written by LibreOffice on Ubuntu).

Steps to Reproduce:
1. Create a new or get an existing, functioning .odt document
2. Unzip and edit the content.xml file to add the XML included in Additional
Information and rezip the document with the updated content.xml (i used XML
Copy Editor to pretty print the XML to be able to easily add it)
3. Try to open the document

This is not how the error happened initially of course.  LibreOffice stopped
being able to open a document it had written.  By painstakingly going through a
diff of content.xml from the last working version to the broken version, i
identified this section as triggering the failure.  That is, the very same
document, removing just this section, began working again.

Actual Results:  
A small pop-up window opens with the text:

LibreOffice 4.3.3.2
Read-Error.
Error reading file.
[ OK ]

Expected Results:
The writer document opens.  Any problems with the XML that Writer has written
is dealt with in a way that, at the very least, allows the rest of the document
to open, and identifies the problematic content.


Reproducible: Always

User Profile Reset: No

Additional Info:
This XML, which is valid XML according to xmllint, and was produced by a
(perhaps older) version of Writer, can be added to the  section of
a fresh or otherwise working LibreOffice Writer document's content.xml file and
you'll get the same error (unzip reproducereaderror.odt content.xml, zip
reproducereaderror.odt content.xml, libreoffice reproducereaderror.odt)

  Bridget
Harrison2016-10-11T11:54:07Add information types from NICHQ SSP
information types
list.Customer data is
contained in applications that customers build upon NICHQ Collaboratory Data
Site services. Information types and security impact levels are
therefore determined by each customer as part of their own application security
plan. 
  
  
The table below provides SCDTDP data
type categorization based on FIPS 199 and 

NIST 800-60 guidance and the system
owner's recommendations.
  
  




  

  Name

  
  

  Information
Category

  
  

  Information Type

  
  

  Confidentiality

  
  

  Integrity

  
  

  Availability

  
  

  Justification

  


  

  D.14.4 Health: Health Care
Delivery Services

  
  

  Health

  
  

  Health Care Delivery
Services

  
  

  Low

  
  

  Moderate

  
  

  Low

  
  

  Data entered on the NICHQ
Collaboratory Data Site
   is from medical claims data,
completely de-identified, and not stored as part of patient health
records.

Integrity has been lowered from high
to Moderate because sickle cell anemia
is not a fatal disease, so loss
of life is not a concern in the treatment of patients and
management of their medical problems. Medicine errors could always result from
a loss of data integrity; the
medicines used in the Sickle Cell Disease
Treatment Demonstration Program have a very, very low level of risk
of adverse reactions, and if such adverse effects occur they are likely to
cause serious but not fatal outcomes.
  


  

  D.14.5 Health: Health Care

  
  Research and Practitioner
Education

  
  

  Health

  
  

  Health Care Research and

  
  Practitioner
Education

[Libreoffice-bugs] [Bug 93977] FILEOPEN: MS Word .doc file looks different in LibO

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93977

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
Version|5.0.1.2 release |4.1.0.4 release

--- Comment #8 from Telesto  ---
Also confirming with:
Version: 4.3.0.4
Build ID: 62ad5818884a2fc2e5780dd45466868d41009ec0

Versie: 4.1.0.4 
Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28

LibreOffice 3.5.7.2 
Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

TOC looks quite good (but not perfect) in:
Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89)

Could a bibisect be useful?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93977] FILEOPEN: MS Word .doc file looks different in LibO

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93977

--- Comment #7 from Telesto  ---
Created attachment 129549
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129549=edit
Layout LO5400Alpha

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93977] FILEOPEN: MS Word .doc file looks different in LibO

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93977

--- Comment #6 from Telesto  ---
Created attachment 129548
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129548=edit
Layout LO4003

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: Branch 'libreoffice-5-3' - source/text

2016-12-12 Thread tagezi

 source/text/shared/guide/start_parameters.xhp |  843 --
 1 file changed, 535 insertions(+), 308 deletions(-)

New commits:
commit 10f89a1accd555be0555e5e17c777012edc48430
Author: tagezi 
Date:   Sun Dec 4 12:30:34 2016 +0200

tdf#100836 "Starting the LibreOffice Software With Parameters" help update

rewritten cmdHelp in accordance with the attached document in bug tdf#100836

Change-Id: I6061dab2ed83a2be0653fbbd422e3193386d9d98
Reviewed-on: https://gerrit.libreoffice.org/31595
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 
(cherry picked from commit 47ad5a2f2102740bda4cf02dcd73562da79f67a9)
Reviewed-on: https://gerrit.libreoffice.org/31919
Reviewed-by: Mike Kaganski 
Tested-by: Mike Kaganski 

diff --git a/source/text/shared/guide/start_parameters.xhp 
b/source/text/shared/guide/start_parameters.xhp
index c03c0bf..f54de06 100644
--- a/source/text/shared/guide/start_parameters.xhp
+++ b/source/text/shared/guide/start_parameters.xhp
@@ -1,6 +1,5 @@
 
 
-
 
-   
+
 
-
-
-Starting the $[officename] Software With 
Parameters
-/text/shared/guide/start_parameters.xhp
-
-
+
+
+Starting $[officename] Software 
With Parameters
+/text/shared/guide/start_parameters.xhp
+
+
 
-
-start parameters
-command line parameters
-parameters;command line
-arguments in command line
-
-Starting the $[officename] Software With 
Parameters
-By starting the $[officename] software from the command line you can 
assign various parameters, with which you can influence the performance. The 
use of command line parameters is only recommended for experienced 
users.
-For normal handling, the use of command line parameters is not 
necessary. A few of the parameters require a deeper knowledge of the technical 
background of the $[officename] software technology.
-Starting the $[officename] Software From the Command 
Line
-
-
-Under Windows, select Run from the Windows Start menu, 
or open a shell under Linux, *BSD, or Mac OS X platforms.
-
-
-Under Windows, type the following text in the Open text 
field and click OK. 
-
-
-Under UNIX-like systems, type the following line of text, then 
press Return:
-{install}\program\soffice.exe {parameter} 
-{install}/program/soffice {parameter} 
-
-Replace {install} with the path to your installation of 
the $[officename] software (for example, C:\Program Files\Office, 
or ~/office)
-Where required, replace {parameter} with one or more of 
the following command line parameters.
-
-
-Valid Command Line Parameters
-
-
-
-Parameter
-
-
-Meaning
-
-
-
-
---help / -h / -?
-
-
-Lists the available command line parameters in a dialog box
-to the 
console.
-
-
-
-
---version
-
-
-Displays the version information.
-
-
-
-
---writer
-
-
-Starts with an empty Writer document.
-
-
-
-
---calc
-
-
-Starts with an empty Calc document.
-
-
-
-
---draw
-
-
-Starts with an empty Draw document.
-
-
-
-
---impress
-
-
-Starts with an empty Impress document.
-
-
-
-
---math
-
-
-Starts with an empty Math document.
-
-
-
-
---global
-
-
-Starts with an empty Writer master document.
-
-
-
-
---web
-
-
-Starts with an empty HTML document.
-
-
-
-
---show {filename.odp}
-
-
-Starts with the Impress file {filename.odp} and starts 
the presentation. Enters edit mode after the presentation.
-
-
-
-
---minimized
-
-
-Starts minimized. The splash screen is not displayed.
-
-
-
-
---invisible
-
-
-Starts in invisible mode.
-Neither the start-up logo nor the initial program window will be 
visible. However, the $[officename] software can be controlled and documents 
and dialogs opened via the http://api.libreoffice.org; 
name="API">API. 
-When the $[officename] software has been started with this 
parameter, it can only be ended using the taskmanager (Windows) or the 
kill command (UNIX-like systems).
-It cannot be used in conjunction with 
-quickstart.
-More information is found in the $[officename] Developer's 
Guide.
-
-
-
-
---norestore
-
-
-Disables restart and file recovery after a system crash.
-
-
-
-
---nofirststartwizard
-
-
-Disables the Welcome Wizard.
-
-
-
-
---quickstart
-
-
-Activates the Quickstarter.now on UNIX 
too
-
-
-
-
---accept={UNO string}
-
-
-Notifies the $[officename] software that upon the creation of "UNO 
Acceptor Threads", a "UNO Accept String" will be used.
-More information is found in the $[officename] Developer's 
Guide.
-
-
-
-
---unaccept={UNO string}
-
-
-Closes an acceptor that was created with --accept={UNO string}. Use 
--unaccept=all to close all open acceptors.
-
-
-
-
--p {filename1} {filename2} ...
-
-
-Prints the files {filename1} {filename2} ... to the 
default printer and ends. The splash screen does not appear.
-If the file name contains spaces, then it must be enclosed in 
quotation marks.
-
-
-
-
---pt

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - helpcontent2

2016-12-12 Thread tagezi

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6cac8655e372bfceb011fc382fac156c8fae64d7
Author: tagezi 
Date:   Sun Dec 4 12:30:34 2016 +0200

Updated core
Project: help  10f89a1accd555be0555e5e17c777012edc48430

tdf#100836 "Starting the LibreOffice Software With Parameters" help update

rewritten cmdHelp in accordance with the attached document in bug tdf#100836

Change-Id: I6061dab2ed83a2be0653fbbd422e3193386d9d98
Reviewed-on: https://gerrit.libreoffice.org/31595
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 
(cherry picked from commit 47ad5a2f2102740bda4cf02dcd73562da79f67a9)
Reviewed-on: https://gerrit.libreoffice.org/31919
Reviewed-by: Mike Kaganski 
Tested-by: Mike Kaganski 

diff --git a/helpcontent2 b/helpcontent2
index 90b439d..10f89a1 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 90b439d73faed542e01ae08e973ddb5b3dcc0bf2
+Subproject commit 10f89a1accd555be0555e5e17c777012edc48430
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104573] Assertion failed: SolarMutex not locked when trying to bring up File Open... dialog ( debug build)

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104573

--- Comment #7 from Mike Kaganski  ---
Created attachment 129547
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129547=edit
Assertion dragging to StartCenter - call stack from VS

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93977] FILEOPEN: MS Word .doc file looks different in LibO

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93977

--- Comment #5 from Telesto  ---
Still repro with:
Version: 5.4.0.0.alpha0+
Build ID: 33f5bc54aaa7fe7aa9335726e30f9c349155e04d
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-12-01_23:21:05
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93977] FILEOPEN: MS Word .doc file looks different in LibO

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93977

--- Comment #4 from Telesto  ---
Created attachment 129546
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129546=edit
File in MS Word Viewer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 52316] WRITER Page count in Status bar does not respect setting " Print automatically inserted blank pages"; Incorrect value for page count field

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=52316

--- Comment #14 from Julien  ---
Hi,
Bug still present in LibreOffice 5.2.3.2 (on ubuntu yakkety, Build ID:
1:5.2.3~rc2-0ubuntu1~yakkety1)
Regards, Julien

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 52316] WRITER Page count in Status bar does not respect setting " Print automatically inserted blank pages"; Incorrect value for page count field

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=52316

--- Comment #14 from Julien  ---
Hi,
Bug still present in LibreOffice 5.2.3.2 (on ubuntu yakkety, Build ID:
1:5.2.3~rc2-0ubuntu1~yakkety1)
Regards, Julien

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 75281] FILEOPEN: table cell text missing in .DOC and .RTF

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=75281

--- Comment #8 from Telesto  ---
Still repro with:
Version: 5.4.0.0.alpha0+
Build ID: 33f5bc54aaa7fe7aa9335726e30f9c349155e04d
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-12-01_23:21:05
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101588] FORMATTING: Format Cells > Background > No Fill fails with non-continuous selection of colored cells

2016-12-12 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101588

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
   Hardware|x86-64 (AMD64)  |All
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |

--- Comment #11 from Eike Rathke  ---
Pending
review https://gerrit.libreoffice.org/31923 for 5-2
build https://gerrit.libreoffice.org/31922 for 5-3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

1 2 3 4 >

1 - 100 of 377 matches

Mail list logo