date:20170108

[Libreoffice-ux-advise] [Bug 87933] Easier visibility of automatic page breaks

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 87933] Easier visibility of automatic page breaks

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87933

--- Comment #28 from Commit Notification 
 ---
George Korepanov committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c695869fd83c516d63330f352d63c9b601999f20

tdf#87933: made pagebreak lines dashed

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: sc/source

2017-01-08 Thread George Korepanov

 sc/source/ui/inc/gridmerg.hxx  |4 +-
 sc/source/ui/view/gridmerg.cxx |   56 +
 sc/source/ui/view/output.cxx   |   39 ++--
 3 files changed, 84 insertions(+), 15 deletions(-)

New commits:
commit c695869fd83c516d63330f352d63c9b601999f20
Author: George Korepanov 
Date:   Fri Jan 6 15:39:27 2017 +0500

tdf#87933: made pagebreak lines dashed

Change-Id: I0067ef7bc672e159b739d6fd588f1427827e91a8
Reviewed-on: https://gerrit.libreoffice.org/32779
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/sc/source/ui/inc/gridmerg.hxx b/sc/source/ui/inc/gridmerg.hxx
index 89be9ff..a6c484a 100644
--- a/sc/source/ui/inc/gridmerg.hxx
+++ b/sc/source/ui/inc/gridmerg.hxx
@@ -42,8 +42,8 @@ public:
 ScGridMerger( OutputDevice* pOutDev, long nOnePixelX, long 
nOnePixelY );
 ~ScGridMerger();
 
-voidAddHorLine(bool bWorksInPixels, long nX1, long nX2, long nY);
-voidAddVerLine(bool bWorksInPixels, long nX, long nY1, long nY2);
+voidAddHorLine(bool bWorksInPixels, long nX1, long nX2, long nY, 
bool bDashed = false);
+voidAddVerLine(bool bWorksInPixels, long nX, long nY1, long nY2, 
bool bDashed = false);
 voidFlush();
 };
 
diff --git a/sc/source/ui/view/gridmerg.cxx b/sc/source/ui/view/gridmerg.cxx
index c7cf899..abb6493 100644
--- a/sc/source/ui/view/gridmerg.cxx
+++ b/sc/source/ui/view/gridmerg.cxx
@@ -21,6 +21,10 @@
 
 #include "gridmerg.hxx"
 
+#define PAGEBREAK_LINE_DISTANCE_PIXEL 5
+#define PAGEBREAK_LINE_DASH_LEN_PIXEL 5
+#define PAGEBREAK_LINE_DASH_COUNT 1
+
 ScGridMerger::ScGridMerger( OutputDevice* pOutDev, long nOnePixelX, long 
nOnePixelY )
 : pDev(pOutDev)
 , nOneX(nOnePixelX)
@@ -86,9 +90,9 @@ void ScGridMerger::AddLine( long nStart, long nEnd, long nPos 
)
 }
 }
 
-void ScGridMerger::AddHorLine(bool bWorksInPixels, long nX1, long nX2, long nY)
+void ScGridMerger::AddHorLine(bool bWorksInPixels, long nX1, long nX2, long 
nY, bool bDashed)
 {
-if (bWorksInPixels)
+if ( bWorksInPixels )
 {
 Point aPoint(pDev->PixelToLogic(Point(nX1, nY)));
 nX1 = aPoint.X();
@@ -96,7 +100,28 @@ void ScGridMerger::AddHorLine(bool bWorksInPixels, long 
nX1, long nX2, long nY)
 nX2 = pDev->PixelToLogic(Point(nX2, 0)).X();
 }
 
-if ( bOptimize )
+if ( bDashed )
+{
+// If there are some unflushed lines they must be flushed since
+// new line is of different style
+if (bOptimize) {
+Flush();
+bVertical = false;
+}
+
+LineInfo aLineInfo(LineStyle::Dash, 1);
+aLineInfo.SetDashCount( PAGEBREAK_LINE_DASH_COUNT );
+
+// Calculating logic values of DashLen and Distance from fixed pixel 
values
+Size aDashDistanceLen( pDev->PixelToLogic( Size( 
PAGEBREAK_LINE_DISTANCE_PIXEL,
+ 
PAGEBREAK_LINE_DASH_LEN_PIXEL )));
+
+aLineInfo.SetDistance( aDashDistanceLen.Width() );
+aLineInfo.SetDashLen( aDashDistanceLen.Height() );
+
+pDev->DrawLine( Point( nX1, nY ), Point( nX2, nY ), aLineInfo );
+}
+else if ( bOptimize )
 {
 if ( bVertical )
 {
@@ -109,7 +134,7 @@ void ScGridMerger::AddHorLine(bool bWorksInPixels, long 
nX1, long nX2, long nY)
 pDev->DrawLine( Point( nX1, nY ), Point( nX2, nY ) );
 }
 
-void ScGridMerger::AddVerLine(bool bWorksInPixels, long nX, long nY1, long nY2)
+void ScGridMerger::AddVerLine(bool bWorksInPixels, long nX, long nY1, long 
nY2, bool bDashed)
 {
 if (bWorksInPixels)
 {
@@ -119,7 +144,28 @@ void ScGridMerger::AddVerLine(bool bWorksInPixels, long 
nX, long nY1, long nY2)
 nY2 = pDev->PixelToLogic(Point(0, nY2)).Y();
 }
 
-if ( bOptimize )
+if ( bDashed )
+{
+// If there are some unflushed lines they must be flushed since
+// new line is of different style
+if (bOptimize) {
+Flush();
+bVertical = false;
+}
+
+LineInfo aLineInfo(LineStyle::Dash, 1);
+aLineInfo.SetDashCount( PAGEBREAK_LINE_DASH_COUNT );
+
+// Calculating logic values of DashLen and Distance from fixed pixel 
values
+Size aDashDistanceLen( pDev->PixelToLogic( Size( 
PAGEBREAK_LINE_DISTANCE_PIXEL,
+ 
PAGEBREAK_LINE_DASH_LEN_PIXEL )));
+
+aLineInfo.SetDistance( aDashDistanceLen.Width() );
+aLineInfo.SetDashLen( aDashDistanceLen.Height() );
+
+pDev->DrawLine( Point( nX, nY1 ), Point( nX, nY2 ), aLineInfo);
+}
+else if ( bOptimize )
 {
 if ( !bVertical )
 {
diff --git a/sc/source/ui/view/output.cxx b/sc/source/ui/view/output.cxx
index 78d351b..519bdbd 100644
--- a/sc/source/ui/view/output.cxx
+++

[Libreoffice-ux-advise] [Bug 104008] Extension removed from document title in print

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104008

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 104008] Extension removed from document title in print

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104008

--- Comment #21 from Commit Notification 
 ---
thvallois committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cb8b05eb486d1def2d6332bcad221c7de333d67d

tdf#104008: whole file name (file extension) for print job

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: sfx2/source

2017-01-08 Thread thvallois

 sfx2/source/view/viewprn.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cb8b05eb486d1def2d6332bcad221c7de333d67d
Author: thvallois 
Date:   Tue Jan 3 01:55:52 2017 +0100

tdf#104008: whole file name (file extension) for print job

Added parameter SFX_TITLE_FILENAME on getTitle method
in order to have the full name for print job.

Change-Id: I7a4722b93763f89424b6c6c4c247d658d57a249b
Reviewed-on: https://gerrit.libreoffice.org/32664
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/sfx2/source/view/viewprn.cxx b/sfx2/source/view/viewprn.cxx
index dfe49c1..8ae4c73 100644
--- a/sfx2/source/view/viewprn.cxx
+++ b/sfx2/source/view/viewprn.cxx
@@ -600,7 +600,7 @@ void SfxViewShell::StartPrint( const uno::Sequence < 
beans::PropertyValue >& rPr
 
 SfxObjectShell *pObjShell = GetObjectShell();
 xNewController->setValue( "JobName",
-makeAny( OUString( pObjShell->GetTitle() ) ) );
+makeAny( OUString( pObjShell->GetTitle(1) ) ) );
 xNewController->setPrinterModified( mbPrinterSettingsModified );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104175] LibO crashes when adding remote Windows/SMB share

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104175

baffclan  changed:

   What|Removed |Added

Crash report or|c708f39a-24e9-4502-8f2d-07d |["INetURLObject::decode(rtl
crash signature|4afd712cf   |::OUStringBuffer const
   ||&,INetURLObject::DecodeMech
   ||anism,unsigned short)"]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Fakabbir Amin - License Statement

2017-01-08 Thread Jan Iversen

WELCOME
Thanks for your license statement.

We suggest you add yourself to our wiki (remark this is not a demand)
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved

rgds
Jan Iversen.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Vedic Sharma license statement

2017-01-08 Thread Jan Iversen

WELCOME
Thanks for your license statement.

We suggest you add yourself to our wiki (remark this is not a demand)
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved

rgds
Jan Iversen.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: George Korepanov license statement

2017-01-08 Thread Jan Iversen

WELCOME
Thanks for your license statement.

We suggest you add yourself to our wiki (remark this is not a demand)
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved

rgds
Jan Iversen.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: #tdf104008 : patch gerrit 32664

2017-01-08 Thread Jan Iversen

WELCOME
Thanks for your license statement, I have updated the aliases as well, so no 
problem.

We suggest you add yourself to our wiki (remark this is not a demand)
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved

rgds
Jan Iversen.

> On 6 Jan 2017, at 14:20, Thibault Vallois  
> wrote:
> 
> Hi,
> 
> I have used an another email address to submit patch. As Jan ask me to do, i 
> inform you by the way of this email.
> 
> Kind regards,
> 
> -- 
> Thibault VALLOIS
> All of my past & future contributions to LibreOffice may be
> licensed under the MPLv2/LGPLv3+ dual license.
> 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: test/TileCacheTests.cpp

2017-01-08 Thread Ashod Nakashian

 test/TileCacheTests.cpp |   31 +++
 1 file changed, 31 insertions(+)

New commits:
commit f861a9e1a7f2ad0c3bd58b4be3fce4cff5a98d6c
Author: Ashod Nakashian 
Date:   Sun Jan 8 23:31:51 2017 -0500

wsd: new unittest for multiview tiles when disconnecting

When there are many views requesting tiles,
disconnecting any should not cancel tiles
for other views.

Change-Id: I6029432c4b9ab931811dcb3b03b0441b413a9971
Reviewed-on: https://gerrit.libreoffice.org/32872
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index 44a3484..42f72c4 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -56,6 +56,7 @@ class TileCacheTests : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testPerformance);
 CPPUNIT_TEST(testCancelTiles);
 CPPUNIT_TEST(testCancelTilesMultiView);
+CPPUNIT_TEST(testDisconnectMultiView);
 CPPUNIT_TEST(testUnresponsiveClient);
 CPPUNIT_TEST(testImpressTiles);
 CPPUNIT_TEST(testClientPartImpress);
@@ -79,6 +80,7 @@ class TileCacheTests : public CPPUNIT_NS::TestFixture
 void testPerformance();
 void testCancelTiles();
 void testCancelTilesMultiView();
+void testDisconnectMultiView();
 void testUnresponsiveClient();
 void testImpressTiles();
 void testClientPartImpress();
@@ -321,6 +323,35 @@ void TileCacheTests::testCancelTilesMultiView()
 }
 }
 
+void TileCacheTests::testDisconnectMultiView()
+{
+std::string documentPath, documentURL;
+getDocumentPathAndURL("setclientpart.ods", documentPath, documentURL, 
"cancelTilesMultiView ");
+
+const size_t repeat = 4;
+for (size_t j = 1; j <= repeat; ++j)
+{
+std::cerr << "cancelTilesMultiView try #" << j << std::endl;
+
+// Request a huge tile, and cancel immediately.
+auto socket1 = loadDocAndGetSocket(_uri, documentURL, 
"cancelTilesMultiView-1 ");
+auto socket2 = loadDocAndGetSocket(_uri, documentURL, 
"cancelTilesMultiView-2 ", true);
+
+sendTextFrame(socket1, "tilecombine part=0 width=256 height=256 
tileposx=0,3840,7680,11520,0,3840,7680,11520 
tileposy=0,0,0,0,3840,3840,3840,3840 tilewidth=3840 tileheight=3840", 
"cancelTilesMultiView-1 ");
+sendTextFrame(socket2, "tilecombine part=0 width=256 height=256 
tileposx=0,3840,7680,0 tileposy=0,0,0,22520 tilewidth=3840 tileheight=3840", 
"cancelTilesMultiView-2 ");
+
+socket1->shutdown();
+
+for (auto i = 0; i < 4; ++i)
+{
+getTileMessage(*socket2, "cancelTilesMultiView-2 ");
+}
+
+// Should never get more than 4 tiles on socket2.
+const auto res2 = getResponseString(socket2, "tile:", 
"cancelTilesMultiView-2 ", 1000);
+}
+}
+
 void TileCacheTests::testUnresponsiveClient()
 {
 std::string documentPath, documentURL;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/httpwstest.cpp

2017-01-08 Thread Ashod Nakashian

 test/httpwstest.cpp |  114 ++--
 1 file changed, 66 insertions(+), 48 deletions(-)

New commits:
commit a775f5e585b27f0e673551d3e8e2c86e472c3bb7
Author: Ashod Nakashian 
Date:   Sun Jan 8 23:28:46 2017 -0500

wsd: split testStateUnoCommand one for each app

Change-Id: I4f6275e289c1a64a05df5b5e4c2708b8ab5b3f83
Reviewed-on: https://gerrit.libreoffice.org/32871
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 309055b..e533959 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -88,7 +88,9 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testInsertAnnotationCalc);
 CPPUNIT_TEST(testCalcEditRendering);
 CPPUNIT_TEST(testFontList);
-CPPUNIT_TEST(testStateUnoCommand);
+CPPUNIT_TEST(testStateUnoCommandWriter);
+CPPUNIT_TEST(testStateUnoCommandCalc);
+CPPUNIT_TEST(testStateUnoCommandImpress);
 CPPUNIT_TEST(testColumnRowResize);
 CPPUNIT_TEST(testOptimalResize);
 CPPUNIT_TEST(testInvalidateViewCursor);
@@ -136,7 +138,9 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 void testInsertAnnotationCalc();
 void testCalcEditRendering();
 void testFontList();
-void testStateUnoCommand();
+void testStateUnoCommandWriter();
+void testStateUnoCommandCalc();
+void testStateUnoCommandImpress();
 void testColumnRowResize();
 void testOptimalResize();
 void testInvalidateViewCursor();
@@ -175,7 +179,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
  const std::string& testname);
 
 std::string getFontList(const std::string& message);
-void testStateChanged(const std::string& filename, 
std::vector& vecComands);
+void testStateChanged(const std::string& filename, std::set& 
vecComands);
 double getColRowSize(const std::string& property, const std::string& 
message, int index);
 double getColRowSize(const std::shared_ptr& socket, const 
std::string& item, int index, const std::string& testname);
 void testEachView(const std::string& doc, const std::string& type, const 
std::string& protocol, const std::string& view, const std::string& testname);
@@ -1592,56 +1596,53 @@ void HTTPWSTest::testFontList()
 }
 }
 
-void HTTPWSTest::testStateChanged(const std::string& filename, 
std::vector& vecCommands)
+void HTTPWSTest::testStateChanged(const std::string& filename, 
std::set& commands)
 {
-const auto testname = "stateChanged ";
+const auto testname = "stateChanged_" + filename + " ";
+
+Poco::RegularExpression reUno("\\.[a-zA-Z]*\\:[a-zA-Z]*\\=");
 
 auto socket = loadDocAndGetSocket(filename, _uri, testname);
 SocketProcessor(testname, socket,
 [&](const std::string& msg)
 {
 Poco::RegularExpression::MatchVec matches;
-Poco::RegularExpression reUno("\\.[a-zA-Z]*\\:[a-zA-Z]*\\=");
-
 if (reUno.match(msg, 0, matches) > 0 && matches.size() == 1)
 {
-const auto str = msg.substr(matches[0].offset, 
matches[0].length);
-auto result = std::find(std::begin(vecCommands), 
std::end(vecCommands), str);
-
-if (result != std::end(vecCommands))
-{
-vecCommands.erase(result);
-}
+commands.erase(msg.substr(matches[0].offset, 
matches[0].length));
 }
 
-if (vecCommands.size() == 0)
-return false;
-
-return true;
+return !commands.empty();
 });
 
-if (vecCommands.size() > 0 )
+if (!commands.empty())
 {
 std::ostringstream ostr;
-
 ostr << filename << " : Missing Uno Commands: " << std::endl;
-for (auto & itUno : vecCommands)
+for (auto & itUno : commands)
+{
 ostr << itUno << std::endl;
+}
 
 CPPUNIT_FAIL(ostr.str());
 }
 }
 
-void HTTPWSTest::testStateUnoCommand()
+void HTTPWSTest::testStateUnoCommandWriter()
 {
-std::vector calcCommands
+std::set writerCommands
 {
+".uno:BackColor=",
 ".uno:BackgroundColor=",
 ".uno:Bold=",
 ".uno:CenterPara=",
 ".uno:CharBackColor=",
+".uno:CharBackgroundExt=",
 ".uno:CharFontName=",
 ".uno:Color=",
+".uno:DefaultBullet=",
+".uno:DefaultNumbering=",
+".uno:FontColor=",
 ".uno:FontHeight=",
 ".uno:Italic=",
 ".uno:JustifyPara=",
@@ -1668,33 +1669,41 @@ void HTTPWSTest::testStateUnoCommand()
 ".uno:InsertColumnsAfter=",
 ".uno:DeleteRows=",
 ".uno:DeleteColumns=",
-".uno:StatusDocPos=",
-".uno:RowColSelCount=",
-".uno:StatusPageStyle=",
+".uno:DeleteTable=",
+".uno:SelectTable=",
+".uno:EntireRow=",

[Libreoffice-commits] online.git: test/httpwstest.cpp

2017-01-08 Thread Ashod Nakashian

 test/httpwstest.cpp |   22 +++---
 1 file changed, 15 insertions(+), 7 deletions(-)

New commits:
commit b8949715e89591c3c24b2e87da8dd3606e6e6acb
Author: Ashod Nakashian 
Date:   Sun Jan 8 21:28:43 2017 -0500

wsd: split testGraphicViewSelection one for each app

Change-Id: I8da3470d4ad9cd666bb4cd18cb8d66a0f6b0c8cb
Reviewed-on: https://gerrit.libreoffice.org/32870
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 99abe35..309055b 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -94,7 +94,9 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testInvalidateViewCursor);
 CPPUNIT_TEST(testViewCursorVisible);
 CPPUNIT_TEST(testCellViewCursor);
-CPPUNIT_TEST(testGraphicViewSelection);
+CPPUNIT_TEST(testGraphicViewSelectionWriter);
+CPPUNIT_TEST(testGraphicViewSelectionCalc);
+CPPUNIT_TEST(testGraphicViewSelectionImpress);
 CPPUNIT_TEST(testGraphicInvalidate);
 CPPUNIT_TEST(testCursorPosition);
 CPPUNIT_TEST(testAlertAllUsers);
@@ -140,7 +142,9 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 void testInvalidateViewCursor();
 void testViewCursorVisible();
 void testCellViewCursor();
-void testGraphicViewSelection();
+void testGraphicViewSelectionWriter();
+void testGraphicViewSelectionCalc();
+void testGraphicViewSelectionImpress();
 void testGraphicInvalidate();
 void testCursorPosition();
 void testAlertAllUsers();
@@ -2089,17 +2093,21 @@ void HTTPWSTest::testCellViewCursor()
 testEachView("empty.ods", "spreadsheet", "cellcursor:", "cellviewcursor:", 
"cellViewCursor");
 }
 
-void HTTPWSTest::testGraphicViewSelection()
+void HTTPWSTest::testGraphicViewSelectionWriter()
 {
-testEachView("graphicviewselection.odp", "presentation", 
"graphicselection:", "graphicviewselection:", "graphicViewSelection-odp ");
-
-CPPUNIT_ASSERT_EQUAL(InitialLoolKitCount, 
countLoolKitProcesses(InitialLoolKitCount));
 testEachView("graphicviewselection.odt", "text", "graphicselection:", 
"graphicviewselection:", "graphicViewSelection-odt ");
+}
 
-CPPUNIT_ASSERT_EQUAL(InitialLoolKitCount, 
countLoolKitProcesses(InitialLoolKitCount));
+void HTTPWSTest::testGraphicViewSelectionCalc()
+{
 testEachView("graphicviewselection.ods", "spreadsheet", 
"graphicselection:", "graphicviewselection:", "graphicViewSelection-ods ");
 }
 
+void HTTPWSTest::testGraphicViewSelectionImpress()
+{
+testEachView("graphicviewselection.odp", "presentation", 
"graphicselection:", "graphicviewselection:", "graphicViewSelection-odp ");
+}
+
 void HTTPWSTest::testGraphicInvalidate()
 {
 const auto testname = "graphicInvalidate ";
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/TileCacheTests.cpp

2017-01-08 Thread Ashod Nakashian

 test/TileCacheTests.cpp |9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

New commits:
commit 92ac46e5f1988adf5458a97e089d18ef13dff6ca
Author: Ashod Nakashian 
Date:   Sun Jan 8 21:28:20 2017 -0500

wsd: no need to render all tiles of all parts in unittests

Change-Id: I4d2eadf64f0c86e4b83af2f25a772f4b88d6a987
Reviewed-on: https://gerrit.libreoffice.org/32869
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index 78e54c5..44a3484 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -981,8 +981,9 @@ void 
TileCacheTests::checkTiles(std::shared_ptr& socket, const st
 
 // random setclientpart
 std::srand(std::time(nullptr));
-std::vector vParts = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9};
+std::vector vParts = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 };
 std::random_shuffle(vParts.begin(), vParts.end());
+int requests = 0;
 for (auto it : vParts)
 {
 if (currentPart != it)
@@ -996,6 +997,12 @@ void 
TileCacheTests::checkTiles(std::shared_ptr& socket, const st
 assertResponseString(socket, "setpart:", name);
 
 requestTiles(socket, it, docWidth, docHeight, name);
+
+if (++requests >= 3)
+{
+// No need to test all parts.
+break;
+}
 }
 
 currentPart = it;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/countloolkits.hpp test/httpwstest.cpp

2017-01-08 Thread Ashod Nakashian

 test/countloolkits.hpp |8 
 test/httpwstest.cpp|6 --
 2 files changed, 12 insertions(+), 2 deletions(-)

New commits:
commit e232ffcdf9f57f019438ab3a95b154f629dfa554
Author: Ashod Nakashian 
Date:   Sun Jan 8 21:11:50 2017 -0500

wsd: log unittest duration

Change-Id: I12ed5b3bb776e0dc562dfdddb1d6ffc7f0aedf31
Reviewed-on: https://gerrit.libreoffice.org/32868
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/countloolkits.hpp b/test/countloolkits.hpp
index a746024..a652bfd 100644
--- a/test/countloolkits.hpp
+++ b/test/countloolkits.hpp
@@ -119,17 +119,25 @@ static int countLoolKitProcesses(const int expected)
 // it will cause testNoExtraLoolKitsLeft to
 // wait unnecessarily and fail.
 static int InitialLoolKitCount = 1;
+static std::chrono::steady_clock::time_point TestStartTime;
 
 static void testCountHowManyLoolkits()
 {
 InitialLoolKitCount = countLoolKitProcesses(InitialLoolKitCount);
 CPPUNIT_ASSERT(InitialLoolKitCount > 0);
+
+TestStartTime = std::chrono::steady_clock::now();
 }
 
 static void testNoExtraLoolKitsLeft()
 {
 const auto countNow = countLoolKitProcesses(InitialLoolKitCount);
 CPPUNIT_ASSERT_EQUAL(InitialLoolKitCount, countNow);
+
+const auto duration = (std::chrono::steady_clock::now() - TestStartTime);
+const auto durationMs = 
std::chrono::duration_cast(duration).count();
+
+std::cout << " (" << durationMs << " ms)";
 }
 
 #endif
diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 552f085..99abe35 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -2072,8 +2072,6 @@ void HTTPWSTest::testEachView(const std::string& doc, 
const std::string& type,
 {
 CPPUNIT_FAIL(exc.displayText());
 }
-
-testNoExtraLoolKitsLeft();
 }
 
 void HTTPWSTest::testInvalidateViewCursor()
@@ -2094,7 +2092,11 @@ void HTTPWSTest::testCellViewCursor()
 void HTTPWSTest::testGraphicViewSelection()
 {
 testEachView("graphicviewselection.odp", "presentation", 
"graphicselection:", "graphicviewselection:", "graphicViewSelection-odp ");
+
+CPPUNIT_ASSERT_EQUAL(InitialLoolKitCount, 
countLoolKitProcesses(InitialLoolKitCount));
 testEachView("graphicviewselection.odt", "text", "graphicselection:", 
"graphicviewselection:", "graphicViewSelection-odt ");
+
+CPPUNIT_ASSERT_EQUAL(InitialLoolKitCount, 
countLoolKitProcesses(InitialLoolKitCount));
 testEachView("graphicviewselection.ods", "spreadsheet", 
"graphicselection:", "graphicviewselection:", "graphicViewSelection-ods ");
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/httpwstest.cpp

2017-01-08 Thread Ashod Nakashian

 test/httpwstest.cpp |1 +
 1 file changed, 1 insertion(+)

New commits:
commit bd65ed2f88a44c97a3fe938f5efe1a350cd1c02c
Author: Ashod Nakashian 
Date:   Sun Jan 8 20:42:11 2017 -0500

wsd: testInsertAnnotationWriter made more stable

Change-Id: I72a531118054b055a997e50168cbd503ea25b9c8
Reviewed-on: https://gerrit.libreoffice.org/32867
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index badeed8..552f085 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -1317,6 +1317,7 @@ void HTTPWSTest::testInsertAnnotationWriter()
 
 // Insert comment.
 sendTextFrame(socket, "uno .uno:InsertAnnotation", testname);
+assertResponseString(socket, "invalidatetiles:", testname);
 
 // Paste some text.
 sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\nxxx yyy 
", testname);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/httpwstest.cpp

2017-01-08 Thread Ashod Nakashian

 test/httpwstest.cpp |  138 ++--
 1 file changed, 69 insertions(+), 69 deletions(-)

New commits:
commit 2a57df30186bc8fd16749673ead12ab14c8ef476
Author: Ashod Nakashian 
Date:   Sun Jan 8 17:17:06 2017 -0500

wsd: log the test name in unittests

Change-Id: I2e83699f80ad35c475452b90fa20b46e4e95f450
Reviewed-on: https://gerrit.libreoffice.org/32866
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 8f84686..badeed8 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -1316,46 +1316,46 @@ void HTTPWSTest::testInsertAnnotationWriter()
 auto socket = loadDocAndGetSocket(_uri, documentURL, testname);
 
 // Insert comment.
-sendTextFrame(socket, "uno .uno:InsertAnnotation");
+sendTextFrame(socket, "uno .uno:InsertAnnotation", testname);
 
 // Paste some text.
-sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\nxxx yyy 
");
+sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\nxxx yyy 
", testname);
 
 // Read it back.
-sendTextFrame(socket, "uno .uno:SelectAll");
-sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8");
-auto res = getResponseString(socket, "textselectioncontent:", 
"insertAnnotationWriter ");
+sendTextFrame(socket, "uno .uno:SelectAll", testname);
+sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8", testname);
+auto res = getResponseString(socket, "textselectioncontent:", testname);
 CPPUNIT_ASSERT_EQUAL(std::string("textselectioncontent: xxx yyy "), 
res);
 // Can we edit the coment?
-sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\naaa bbb 
ccc");
-sendTextFrame(socket, "uno .uno:SelectAll");
-sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8");
-res = getResponseString(socket, "textselectioncontent:", 
"insertAnnotationWriter ");
+sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\naaa bbb 
ccc", testname);
+sendTextFrame(socket, "uno .uno:SelectAll", testname);
+sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8", testname);
+res = getResponseString(socket, "textselectioncontent:", testname);
 CPPUNIT_ASSERT_EQUAL(std::string("textselectioncontent: aaa bbb ccc"), 
res);
 
 // Confirm that the text is in the comment and not doc body.
 // Click in the body.
-sendTextFrame(socket, "mouse type=buttondown x=1600 y=1600 count=1 
buttons=1 modifier=0");
-sendTextFrame(socket, "mouse type=buttonup x=1600 y=1600 count=1 buttons=1 
modifier=0");
+sendTextFrame(socket, "mouse type=buttondown x=1600 y=1600 count=1 
buttons=1 modifier=0", testname);
+sendTextFrame(socket, "mouse type=buttonup x=1600 y=1600 count=1 buttons=1 
modifier=0", testname);
 // Read body text.
-sendTextFrame(socket, "uno .uno:SelectAll");
-sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8");
-res = getResponseString(socket, "textselectioncontent:", 
"insertAnnotationWriter ");
+sendTextFrame(socket, "uno .uno:SelectAll", testname);
+sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8", testname);
+res = getResponseString(socket, "textselectioncontent:", testname);
 CPPUNIT_ASSERT_EQUAL(std::string("textselectioncontent: Hello world"), 
res);
 
 // Confirm that the comment is still intact.
-sendTextFrame(socket, "mouse type=buttondown x=13855 y=1893 count=1 
buttons=1 modifier=0");
-sendTextFrame(socket, "mouse type=buttonup x=13855 y=1893 count=1 
buttons=1 modifier=0");
-sendTextFrame(socket, "uno .uno:SelectAll");
-sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8");
-res = getResponseString(socket, "textselectioncontent:", 
"insertAnnotationWriter ");
+sendTextFrame(socket, "mouse type=buttondown x=13855 y=1893 count=1 
buttons=1 modifier=0", testname);
+sendTextFrame(socket, "mouse type=buttonup x=13855 y=1893 count=1 
buttons=1 modifier=0", testname);
+sendTextFrame(socket, "uno .uno:SelectAll", testname);
+sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8", testname);
+res = getResponseString(socket, "textselectioncontent:", testname);
 CPPUNIT_ASSERT_EQUAL(std::string("textselectioncontent: aaa bbb ccc"), 
res);
 
 // Can we still edit the coment?
-sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\nand now 
for something completely different");
-sendTextFrame(socket, "uno .uno:SelectAll");
-sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8");
-res = getResponseString(socket, "textselectioncontent:", 
"insertAnnotationWriter ");
+sendTextFrame(socket, "paste

[Libreoffice-commits] online.git: kit/ForKit.cpp

2017-01-08 Thread Ashod Nakashian

 kit/ForKit.cpp |   29 +++--
 1 file changed, 11 insertions(+), 18 deletions(-)

New commits:
commit f242865c3df107ae1de4d0ed4358871b07b719d1
Author: Ashod Nakashian 
Date:   Sun Jan 8 15:17:47 2017 -0500

wsd: simplify kit forking

Change-Id: I49338fbd2ccf944493f94a8f2c98750711733f1a
Reviewed-on: https://gerrit.libreoffice.org/32865
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/kit/ForKit.cpp b/kit/ForKit.cpp
index f0fe536..ba3d548 100644
--- a/kit/ForKit.cpp
+++ b/kit/ForKit.cpp
@@ -207,8 +207,8 @@ static int createLibreOfficeKit(const std::string& 
childRoot,
 {
 LOG_DBG("Forking a loolkit process.");
 
-Process::PID pid;
-if (!(pid = fork()))
+const Process::PID pid = fork();
+if (!pid)
 {
 // Child
 
@@ -412,31 +412,24 @@ int main(int argc, char** argv)
 break;
 }
 
+// Cleanup first, to reduce disk load.
+cleanupChildren();
+
 if (ForkCounter > 0)
 {
 // Create as many as requested.
-int spawn = ForkCounter;
-LOG_INF("Creating " << spawn << " new child.");
-size_t newInstances = 0;
-do
+const size_t count = ForkCounter;
+LOG_INF("Spawning " << count << " new child" << (count == 1 ? "." 
: "ren."));
+const size_t retry = count * 2;
+for (size_t i = 0; ForkCounter > 0 && i < retry; ++i)
 {
-if (createLibreOfficeKit(childRoot, sysTemplate, loTemplate, 
loSubPath) < 0)
+if (ForkCounter-- <= 0 || createLibreOfficeKit(childRoot, 
sysTemplate, loTemplate, loSubPath) < 0)
 {
 LOG_ERR("Failed to create a kit process.");
-}
-else
-{
-++newInstances;
+++ForkCounter;
 }
 }
-while (--spawn > 0);
-
-// If we need to spawn more, retry later.
-ForkCounter = (newInstances >= ForkCounter ? 0 : ForkCounter - 
newInstances);
 }
-
-// We virtually always fork when a child exits.
-cleanupChildren();
 }
 
 int returnValue = Application::EXIT_OK;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/TileCacheTests.cpp

2017-01-08 Thread Ashod Nakashian

 test/TileCacheTests.cpp |   56 
 1 file changed, 42 insertions(+), 14 deletions(-)

New commits:
commit 93c66eeb9bad244e57555d5fe01a4d573922677e
Author: Ashod Nakashian 
Date:   Thu Jan 5 11:09:44 2017 -0500

wsd: fixup tileInvalidatePartImpress

Since the Impress slides use large fonts, we end up
overflowing the part bounds with this test.

Luckily the top row of text has smaller font, and
more vertical space within the slide, so now
we edit the top-left textbox and this test
doesn't fail anymore (tested 50 times) when
it failed ~1 in 4 previously.

Change-Id: I13d8cc4462d48b128578a9d3fdde90a79c607c4b
Reviewed-on: https://gerrit.libreoffice.org/32862
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index 2c235dc..78e54c5 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -94,8 +94,6 @@ class TileCacheTests : public CPPUNIT_NS::TestFixture
 void testTileInvalidatePartCalc();
 void testTileInvalidatePartImpress();
 
-void tileInvalidatePart(const std::string& filename, const std::string& 
testname);
-
 void checkTiles(std::shared_ptr& socket,
 const std::string& type,
 const std::string& name = "checkTiles ");
@@ -860,8 +858,10 @@ void TileCacheTests::testTileInvalidateCalc()
 }
 }
 
-void TileCacheTests::tileInvalidatePart(const std::string& filename, const 
std::string& testname)
+void TileCacheTests::testTileInvalidatePartCalc()
 {
+const std::string filename = "setclientpart.ods";
+const std::string testname = "tileInvalidatePartCalc";
 const std::string testname1 = testname + "-1 ";
 const std::string testname2 = testname + "-2 ";
 
@@ -871,14 +871,14 @@ void TileCacheTests::tileInvalidatePart(const 
std::string& filename, const std::
 
 sendTextFrame(socket1, "setclientpart part=2", testname1);
 assertResponseString(socket1, "setpart:", testname1);
-sendTextFrame(socket1, "mouse type=buttondown x=7886 y=8929 count=1 
buttons=1 modifier=0", testname1);
+sendTextFrame(socket1, "mouse type=buttondown x=1500 y=1500 count=1 
buttons=1 modifier=0", testname1);
 
-auto socket2 = loadDocAndGetSocket(_uri, documentURL);
+auto socket2 = loadDocAndGetSocket(_uri, documentURL, testname2);
 sendTextFrame(socket2, "setclientpart part=5", testname2);
 assertResponseString(socket2, "setpart:", testname2);
-sendTextFrame(socket2, "mouse type=buttondown x=7886 y=8929 count=1 
buttons=1 modifier=0", testname2);
+sendTextFrame(socket2, "mouse type=buttondown x=1500 y=1500 count=1 
buttons=1 modifier=0", testname2);
 
-std::string text = "Some test";
+static const std::string text = "Some test";
 for (char ch : text)
 {
 sendChar(socket1, ch);
@@ -896,15 +896,43 @@ void TileCacheTests::tileInvalidatePart(const 
std::string& filename, const std::
 }
 }
 
-
-void TileCacheTests::testTileInvalidatePartCalc()
-{
-tileInvalidatePart("setclientpart.ods", "tileInvalidatePartCalc");
-}
-
 void TileCacheTests::testTileInvalidatePartImpress()
 {
-tileInvalidatePart("setclientpart.odp", "tileInvalidatePartImpress");
+const std::string filename = "setclientpart.odp";
+const std::string testname = "tileInvalidatePartImpress";
+const std::string testname1 = testname + "-1 ";
+const std::string testname2 = testname + "-2 ";
+
+std::string documentPath, documentURL;
+getDocumentPathAndURL(filename, documentPath, documentURL, testname);
+auto socket1 = loadDocAndGetSocket(_uri, documentURL, testname1);
+
+sendTextFrame(socket1, "setclientpart part=2", testname1);
+assertResponseString(socket1, "setpart:", testname1);
+sendTextFrame(socket1, "mouse type=buttondown x=1500 y=1500 count=1 
buttons=1 modifier=0", testname1);
+
+auto socket2 = loadDocAndGetSocket(_uri, documentURL, testname2);
+sendTextFrame(socket2, "setclientpart part=5", testname2);
+assertResponseString(socket2, "setpart:", testname2);
+sendTextFrame(socket2, "mouse type=buttondown x=1500 y=1500 count=1 
buttons=1 modifier=0", testname2);
+
+// This should be short, as in odp the font is large and we leave the page 
otherwise.
+static const std::string text = "Some test";
+for (char ch : text)
+{
+sendChar(socket1, ch);
+sendChar(socket2, ch);
+
+const auto response1 = assertResponseString(socket1, 
"invalidatetiles:", testname1);
+int value1;
+LOOLProtocol::getTokenIntegerFromMessage(response1, "part", value1);
+CPPUNIT_ASSERT_EQUAL(2, value1);
+
+const auto response2 = assertResponseString(socket2, 
"invalidatetiles:", testname2);
+int value2;
+LOOLProtocol::getTokenIntegerFromMessage(response2, "part",

[Libreoffice-commits] online.git: 2 commits - common/Log.cpp kit/ForKit.cpp kit/Kit.cpp wsd/DocumentBroker.cpp

2017-01-08 Thread Ashod Nakashian

 common/Log.cpp |   10 --
 kit/ForKit.cpp |2 +-
 kit/Kit.cpp|5 -
 wsd/DocumentBroker.cpp |6 +-
 4 files changed, 18 insertions(+), 5 deletions(-)

New commits:
commit b2160ee3a736fa57481280bdbb815c1315748440
Author: Ashod Nakashian 
Date:   Sun Jan 8 12:22:21 2017 -0500

wsd: improved logging

Change-Id: I9c10803f451b6226c6a15d89acd4758c04042f28
Reviewed-on: https://gerrit.libreoffice.org/32864
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/kit/ForKit.cpp b/kit/ForKit.cpp
index 115a2df..f0fe536 100644
--- a/kit/ForKit.cpp
+++ b/kit/ForKit.cpp
@@ -97,7 +97,7 @@ public:
 const auto count = std::stoi(tokens[1]);
 if (count > 0)
 {
-LOG_INF("Spawning " << tokens[1] << ' ' << (count == 1 ? 
"child" : "children") << " per request.");
+LOG_INF("Setting to spawn " << tokens[1] << " child" << (count 
== 1 ? "" : "ren") << " per request.");
 ForkCounter = count;
 }
 else
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index e840210..cd15e77 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -1220,9 +1220,12 @@ private:
 if (size == disconnect.size() &&
 strncmp(data, disconnect.data(), disconnect.size()) == 0)
 {
-LOG_DBG("Removing ChildSession " << sessionId);
+LOG_DBG("Removing ChildSession [" << sessionId << "].");
 _oldSessionIds[session->getViewId()] = 
UserInfo({session->getViewUserId(), session->getViewUserName()});
 _sessions.erase(it);
+const auto count = _sessions.size();
+LOG_DBG("Have " << count << " child" << (count == 1 ? "" : 
"ren") <<
+" after removing ChildSession [" << sessionId << 
"].");
 
 // No longer needed, and allow session dtor to take it.
 lock.unlock();
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index a4ea62a..35448fb 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -652,6 +652,9 @@ size_t DocumentBroker::removeSession(const std::string& id)
 
 try
 {
+LOG_INF("Removing session [" << id << "] on docKey [" << _docKey <<
+"]. Have " << _sessions.size() << " sessions.");
+
 Admin::instance().rmDoc(_docKey, id);
 
 auto it = _sessions.find(id);
@@ -672,7 +675,8 @@ size_t DocumentBroker::removeSession(const std::string& id)
 }
 else
 {
-LOG_TRC("Session [" << id << "] not found to remove from docKey [" 
<< _docKey << "]");
+LOG_TRC("Session [" << id << "] not found to remove from docKey [" 
<<
+_docKey << "]. Have " << _sessions.size() << " sessions.");
 }
 }
 catch (const std::exception& ex)
commit fe9e95dfa3ed04c142110e88a071e63afadb7da7
Author: Ashod Nakashian 
Date:   Sun Jan 8 12:21:14 2017 -0500

wsd: log the time when initializing the logger

Change-Id: I785c2a6a13dedbecf10a96a593f05e13980ea1e6
Reviewed-on: https://gerrit.libreoffice.org/32863
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/Log.cpp b/common/Log.cpp
index c263975..3141abd 100644
--- a/common/Log.cpp
+++ b/common/Log.cpp
@@ -11,6 +11,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -154,8 +155,13 @@ namespace Log
 
 logger.setLevel(logLevel.empty() ? std::string("trace") : logLevel);
 
-info("Initializing " + name);
-info("Log level is [" + std::to_string(logger.getLevel()) + "].");
+const std::time_t t = std::time(nullptr);
+oss.str("");
+oss.clear();
+oss << "Initializing " << name << ". Local time: " << 
std::put_time(std::localtime(), "%c %Z")
+<< ". UTC: " << std::put_time(std::gmtime(), "%c %Z")
+<<  ". Log level is [" << logger.getLevel() << "].";
+info(oss.str());
 }
 
 Poco::Logger& logger()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/FileUtil.cpp common/FileUtil.hpp test/helpers.hpp test/httpwserror.cpp test/TileCacheTests.cpp

2017-01-08 Thread Ashod Nakashian

 common/FileUtil.cpp |   10 --
 common/FileUtil.hpp |3 +++
 test/TileCacheTests.cpp |   33 ++---
 test/helpers.hpp|5 +++--
 test/httpwserror.cpp|4 ++--
 5 files changed, 34 insertions(+), 21 deletions(-)

New commits:
commit 4580ed4e275b0d0889c7a73a129be758e41b150b
Author: Ashod Nakashian 
Date:   Thu Jan 5 22:46:00 2017 -0500

wsd: prefix the test docs with the test name

This makes debugging much easier as one can
readily match WSD logs with a given test.

Change-Id: I8f2c83d67189038699af3f24dee205bc7efb5c28
Reviewed-on: https://gerrit.libreoffice.org/32860
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/FileUtil.cpp b/common/FileUtil.cpp
index 0127c1a..8973d72 100644
--- a/common/FileUtil.cpp
+++ b/common/FileUtil.cpp
@@ -44,15 +44,21 @@ namespace FileUtil
 return name;
 }
 
-std::string getTempFilePath(const std::string& srcDir, const std::string& 
srcFilename)
+std::string getTempFilePath(const std::string& srcDir, const std::string& 
srcFilename, const std::string& dstFilenamePrefix)
 {
 const std::string srcPath = srcDir + '/' + srcFilename;
-const std::string dstPath = Poco::Path::temp() + 
Util::encodeId(Util::rng::getNext()) + '_' + srcFilename;
+const std::string dstFilename = dstFilenamePrefix + 
Util::encodeId(Util::rng::getNext()) + '_' + srcFilename;
+const std::string dstPath = Poco::Path(Poco::Path::temp(), 
dstFilename).toString();
 Poco::File(srcPath).copyTo(dstPath);
 Poco::TemporaryFile::registerForDeletion(dstPath);
 return dstPath;
 }
 
+std::string getTempFilePath(const std::string& srcDir, const std::string& 
srcFilename)
+{
+return getTempFilePath(srcDir, srcFilename, "");
+}
+
 bool saveDataToFileSafely(const std::string& fileName, const char *data, 
size_t size)
 {
 const auto tempFileName = fileName + ".temp";
diff --git a/common/FileUtil.hpp b/common/FileUtil.hpp
index e018691..c8e7a3f 100644
--- a/common/FileUtil.hpp
+++ b/common/FileUtil.hpp
@@ -86,6 +86,9 @@ namespace FileUtil
 /// Returns the created file path.
 std::string getTempFilePath(const std::string& srcDir, const std::string& 
srcFilename);
 
+/// Make a temp copy of a file, and prepend it with a prefix.
+std::string getTempFilePath(const std::string& srcDir, const std::string& 
srcFilename, const std::string& dstFilenamePrefix);
+
 } // end namespace FileUtil
 
 #endif
diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index 17bf6da..935a8c4 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -179,8 +179,9 @@ void TileCacheTests::testSimple()
 
 void TileCacheTests::testSimpleCombine()
 {
+const auto testname = "simpleCombine ";
 std::string documentPath, documentURL;
-getDocumentPathAndURL("hello.odt", documentPath, documentURL);
+getDocumentPathAndURL("hello.odt", documentPath, documentURL, testname);
 
 // First.
 auto socket1 = loadDocAndGetSocket(_uri, documentURL, "simpleCombine-1 ");
@@ -265,7 +266,7 @@ void TileCacheTests::testCancelTiles()
 void TileCacheTests::testCancelTilesMultiView()
 {
 std::string documentPath, documentURL;
-getDocumentPathAndURL("setclientpart.ods", documentPath, documentURL);
+getDocumentPathAndURL("setclientpart.ods", documentPath, documentURL, 
"cancelTilesMultiView ");
 
 // The tile response can race past the canceltiles,
 // so be forgiving to avoid spurious failures.
@@ -313,7 +314,7 @@ void TileCacheTests::testCancelTilesMultiView()
 void TileCacheTests::testUnresponsiveClient()
 {
 std::string documentPath, documentURL;
-getDocumentPathAndURL("hello.odt", documentPath, documentURL);
+getDocumentPathAndURL("hello.odt", documentPath, documentURL, 
"unresponsiveClient ");
 
 std::cerr << "Connecting first client." << std::endl;
 auto socket1 = loadDocAndGetSocket(_uri, documentURL, 
"unresponsiveClient-1 ");
@@ -473,7 +474,7 @@ void TileCacheTests::testTilesRenderedJustOnceMultiClient()
 const auto testname4 = testname + "-4 ";
 
 std::string documentPath, documentURL;
-getDocumentPathAndURL("with_comment.odt", documentPath, documentURL);
+getDocumentPathAndURL("with_comment.odt", documentPath, documentURL, 
testname);
 
 std::cerr << "Connecting first client." << std::endl;
 auto socket = loadDocAndGetSocket(_uri, documentURL, testname1);
@@ -563,7 +564,7 @@ void TileCacheTests::testTilesRenderedJustOnceMultiClient()
 void TileCacheTests::testSimultaneousTilesRenderedJustOnce()
 {
 std::string documentPath, documentURL;
-getDocumentPathAndURL("hello.odt", documentPath, documentURL);
+getDocumentPathAndURL("hello.odt", documentPath, documentURL, 
"simultaneousTilesrenderedJustOnce ");
 
 std::cerr <<

[Libreoffice-commits] online.git: test/countloolkits.hpp test/httpcrashtest.cpp test/httpwserror.cpp test/httpwstest.cpp test/integration-http-server.cpp test/TileCacheTests.cpp

2017-01-08 Thread Ashod Nakashian

 test/TileCacheTests.cpp  |   12 +++
 test/countloolkits.hpp   |   41 +++
 test/httpcrashtest.cpp   |   18 -
 test/httpwserror.cpp |   18 -
 test/httpwstest.cpp  |   20 ---
 test/integration-http-server.cpp |   20 ---
 6 files changed, 46 insertions(+), 83 deletions(-)

New commits:
commit 4e9e0195642f6b09a3d99fb2afb5a169ecd4c086
Author: Ashod Nakashian 
Date:   Fri Jan 6 10:54:19 2017 -0500

wsd: refactor/dedup the lokit process counting tests

Change-Id: Iebf7756c6a5c2bc581a0ade4fe13fad752eb7d20
Reviewed-on: https://gerrit.libreoffice.org/32861
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index 935a8c4..2c235dc 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -19,6 +19,8 @@
 #include "TileCache.hpp"
 #include "Unit.hpp"
 #include "Util.hpp"
+
+#include "countloolkits.hpp"
 #include "helpers.hpp"
 
 using namespace helpers;
@@ -132,6 +134,16 @@ public:
 Poco::Net::uninitializeSSL();
 }
 #endif
+
+void setUp()
+{
+testCountHowManyLoolkits();
+}
+
+void tearDown()
+{
+testNoExtraLoolKitsLeft();
+}
 };
 
 void TileCacheTests::testSimple()
diff --git a/test/countloolkits.hpp b/test/countloolkits.hpp
index 4338a2f..a746024 100644
--- a/test/countloolkits.hpp
+++ b/test/countloolkits.hpp
@@ -10,9 +10,18 @@
 #ifndef INCLUDED_COUNTLOOLKITPROCESSES_HPP
 #define INCLUDED_COUNTLOOLKITPROCESSES_HPP
 
+#include 
+#include 
+
+#include 
+
 #include 
+#include 
+#include 
 #include 
 
+#include 
+
 /// Counts the number of LoolKit process instances without wiating.
 static int getLoolKitProcessCount()
 {
@@ -33,6 +42,7 @@ static int getLoolKitProcessCount()
 {
 pid = 0;
 }
+
 if (pid > 1 && endPos == fileName.length())
 {
 Poco::FileInputStream stat(procEntry.toString() + "/stat");
@@ -70,16 +80,11 @@ static int getLoolKitProcessCount()
 
 static int countLoolKitProcesses(const int expected)
 {
-std::cerr << "Waiting to have " << expected << " loolkit processes. 
Loolkits: ";
-
-// We have to wait at least for the time the call 
docBroker->autoSave(forceSave,
-// COMMAND_TIMEOUT_MS)) in ClientRequestHandler:::handleGetRequest() can 
take to wait for
-// information about a successful auto-save. In the 
HTTPWSTest::testConnectNoLoad() there is
-// nothing to auto-save, so it waits in vain.
+std::cerr << "Waiting until loolkit processes are exactly " << expected << 
". Loolkits: ";
 
 // This does not need to depend on any constant from Common.hpp.
 // The shorter the better (the quicker the test runs).
-const auto sleepMs = 100;
+const auto sleepMs = 50;
 
 // This has to cause waiting for at least COMMAND_TIMEOUT_MS. Add one 
second for safety.
 const size_t repeat = ((COMMAND_TIMEOUT_MS + 1000) / sleepMs);
@@ -93,7 +98,7 @@ static int countLoolKitProcesses(const int expected)
 }
 
 // Give polls in the lool processes time to time out etc
-Poco::Thread::sleep(sleepMs);
+std::this_thread::sleep_for(std::chrono::milliseconds(sleepMs));
 
 count = getLoolKitProcessCount();
 }
@@ -107,6 +112,26 @@ static int countLoolKitProcesses(const int expected)
 return count;
 }
 
+// FIXME: we probably should make this extern
+// and reuse it. As it stands now, it is per
+// translation unit, which isn't desirable if
+// (in the non-ideal event that) it's not 1,
+// it will cause testNoExtraLoolKitsLeft to
+// wait unnecessarily and fail.
+static int InitialLoolKitCount = 1;
+
+static void testCountHowManyLoolkits()
+{
+InitialLoolKitCount = countLoolKitProcesses(InitialLoolKitCount);
+CPPUNIT_ASSERT(InitialLoolKitCount > 0);
+}
+
+static void testNoExtraLoolKitsLeft()
+{
+const auto countNow = countLoolKitProcesses(InitialLoolKitCount);
+CPPUNIT_ASSERT_EQUAL(InitialLoolKitCount, countNow);
+}
+
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/test/httpcrashtest.cpp b/test/httpcrashtest.cpp
index 3db2dc0..16105a7 100644
--- a/test/httpcrashtest.cpp
+++ b/test/httpcrashtest.cpp
@@ -52,7 +52,6 @@ class HTTPCrashTest : public CPPUNIT_NS::TestFixture
 {
 const Poco::URI _uri;
 Poco::Net::HTTPResponse _response;
-static int InitialLoolKitCount;
 
 CPPUNIT_TEST_SUITE(HTTPCrashTest);
 
@@ -62,11 +61,9 @@ class HTTPCrashTest : public CPPUNIT_NS::TestFixture
 
 CPPUNIT_TEST_SUITE_END();
 
-void testCountHowManyLoolkits();
 void testBarren();
 void testCrashKit();
 void testCrashForkit();
-void testNoExtraLoolKitsLeft();
 
 static
 void killLoKitProcesses(const char* exec_filename);

[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

2017-01-08 Thread Ashod Nakashian

 wsd/LOOLWSD.cpp |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 731bfb08c5a2937f0833f7e657e616ff1470c8c3
Author: Ashod Nakashian 
Date:   Thu Jan 5 10:26:04 2017 -0500

wsd: don't wait on the DocBrokers lock when prespawning children

Prespawning proactively is optimistic, but is not critical.
When getting a space child, more will be spawn perforce,
so prespawnChildren shouldn't block.

Change-Id: I60cc8c1ab87cba384ebc9aca9e79b89f69a99252
Reviewed-on: https://gerrit.libreoffice.org/32858
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index b9467bd..0c60114 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -411,7 +411,13 @@ static void preForkChildren()
 static bool prespawnChildren(const bool force)
 {
 // First remove dead DocBrokers, if possible.
-std::unique_lock docBrokersLock(DocBrokersMutex);
+std::unique_lock docBrokersLock(DocBrokersMutex, 
std::defer_lock);
+if (!docBrokersLock.try_lock())
+{
+// Busy, try again later.
+return false;
+}
+
 cleanupDocBrokers();
 
 std::unique_lock lock(NewChildrenMutex, std::defer_lock);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/httpwstest.cpp

2017-01-08 Thread Ashod Nakashian

 test/httpwstest.cpp |   64 ++--
 1 file changed, 32 insertions(+), 32 deletions(-)

New commits:
commit 496fbda659febc944d29f0f90557448fde1d7869
Author: Ashod Nakashian 
Date:   Thu Jan 5 22:35:01 2017 -0500

wsd: cleanup ColumnRowSize and OptimalResize unittests

Change-Id: I1e4681aeb0ac51df34ca585ddecd53cad47f3fda
Reviewed-on: https://gerrit.libreoffice.org/32859
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 9347f4e..3e69bf0 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -177,7 +177,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 std::string getFontList(const std::string& message);
 void testStateChanged(const std::string& filename, 
std::vector& vecComands);
 double getColRowSize(const std::string& property, const std::string& 
message, int index);
-double getColRowSize(const std::shared_ptr& socket, const 
std::string& item, int index);
+double getColRowSize(const std::shared_ptr& socket, const 
std::string& item, int index, const std::string& testname);
 void testEachView(const std::string& doc, const std::string& type, const 
std::string& protocol, const std::string& view, const std::string& testname);
 
 public:
@@ -1829,10 +1829,10 @@ double HTTPWSTest::getColRowSize(const std::string& 
property, const std::string&
 return item->getValue("size");
 }
 
-double HTTPWSTest::getColRowSize(const std::shared_ptr& socket, 
const std::string& item, int index)
+double HTTPWSTest::getColRowSize(const std::shared_ptr& socket, 
const std::string& item, int index, const std::string& testname)
 {
 std::vector response;
-response = getResponseMessage(socket, "commandvalues:", 
"testColumnRowResize ");
+response = getResponseMessage(socket, "commandvalues:", testname);
 CPPUNIT_ASSERT_MESSAGE("did not receive a commandvalues: message as 
expected", !response.empty());
 std::vector json(response.begin() + 
std::string("commandvalues:").length(), response.end());
 json.push_back(0);
@@ -1841,6 +1841,7 @@ double HTTPWSTest::getColRowSize(const 
std::shared_ptr& socket, c
 
 void HTTPWSTest::testColumnRowResize()
 {
+const auto testname = "columnRowResize ";
 try
 {
 std::vector response;
@@ -1848,13 +1849,11 @@ void HTTPWSTest::testColumnRowResize()
 double oldHeight, oldWidth;
 
 getDocumentPathAndURL("setclientpart.ods", documentPath, documentURL);
-Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
-
-auto socket = loadDocAndGetSocket(_uri, documentURL, 
"testColumnRowResize ");
+auto socket = loadDocAndGetSocket(_uri, documentURL, testname);
 
 const std::string commandValues = "commandvalues 
command=.uno:ViewRowColumnHeaders";
 sendTextFrame(socket, commandValues);
-response = getResponseMessage(socket, "commandvalues:", 
"testColumnRowResize ");
+response = getResponseMessage(socket, "commandvalues:", testname);
 CPPUNIT_ASSERT_MESSAGE("did not receive a commandvalues: message as 
expected", !response.empty());
 {
 std::vector json(response.begin() + 
std::string("commandvalues:").length(), response.end());
@@ -1883,9 +1882,9 @@ void HTTPWSTest::testColumnRowResize()
 objJSON.set("Width", objWidth);
 
 Poco::JSON::Stringifier::stringify(objJSON, oss);
-sendTextFrame(socket, "uno .uno:ColumnWidth " + oss.str());
-sendTextFrame(socket, commandValues);
-response = getResponseMessage(socket, "commandvalues:", 
"testColumnRowResize ");
+sendTextFrame(socket, "uno .uno:ColumnWidth " + oss.str(), 
testname);
+sendTextFrame(socket, commandValues, testname);
+response = getResponseMessage(socket, "commandvalues:", testname);
 CPPUNIT_ASSERT_MESSAGE("did not receive a commandvalues: message 
as expected", !response.empty());
 std::vector json(response.begin() + 
std::string("commandvalues:").length(), response.end());
 json.push_back(0);
@@ -1910,9 +1909,9 @@ void HTTPWSTest::testColumnRowResize()
 objJSON.set("Height", objHeight);
 
 Poco::JSON::Stringifier::stringify(objJSON, oss);
-sendTextFrame(socket, "uno .uno:RowHeight " + oss.str());
-sendTextFrame(socket, commandValues);
-response = getResponseMessage(socket, "commandvalues:", 
"testColumnRowResize ");
+sendTextFrame(socket, "uno .uno:RowHeight " + oss.str(), testname);
+sendTextFrame(socket, commandValues, testname);
+response = getResponseMessage(socket, "commandvalues:", testname);
 CPPUNIT_ASSERT_MESSAGE("did not receive a commandvalues: message 
as expected", !response.empty());

[Libreoffice-commits] online.git: test/httpwstest.cpp wsd/LOOLWSD.cpp

2017-01-08 Thread Ashod Nakashian

 test/httpwstest.cpp |   10 +++---
 wsd/LOOLWSD.cpp |3 +--
 2 files changed, 4 insertions(+), 9 deletions(-)

New commits:
commit e6ee7c2756d0898782dd2ad9b13752fcdd367d21
Author: Ashod Nakashian 
Date:   Wed Jan 4 14:57:54 2017 -0500

wsd: MAX_DOCUMENT is now always defined as positive

Change-Id: I06018eeaab88bb3ede896bf7d74e1a7ce6f84325
Reviewed-on: https://gerrit.libreoffice.org/32857
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 02e66d1..9347f4e 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -2048,8 +2048,7 @@ void HTTPWSTest::testEachView(const std::string& doc, 
const std::string& type,
 
 // Check document size
 sendTextFrame(socket, "status", Poco::format(view, itView));
-auto response = getResponseString(socket, "status:", 
Poco::format(view, itView));
-CPPUNIT_ASSERT_MESSAGE(Poco::format(error, itView, 
std::string("status:")), !response.empty());
+auto response = assertResponseString(socket, "status:", 
Poco::format(view, itView));
 int docPart = -1;
 int docParts = 0;
 int docHeight = 0;
@@ -2070,11 +2069,8 @@ void HTTPWSTest::testEachView(const std::string& doc, 
const std::string& type,
 
 // Connect and load 0..N Views, where N<=limit
 std::vector views;
-#if MAX_DOCUMENTS > 0
-const auto limit = std::min(5, MAX_DOCUMENTS - 1); // +1 connection 
above
-#else
-constexpr auto limit = 5;
-#endif
+static_assert(MAX_DOCUMENTS >= 2, "MAX_DOCUMENTS must be at least 2");
+const auto limit = std::max(2, MAX_DOCUMENTS - 1); // +1 connection 
above
 for (itView = 0; itView < limit; ++itView)
 {
 views.emplace_back(loadDocAndGetSocket(_uri, documentURL, 
Poco::format(view, itView)));
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 1eed34d..b9467bd 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -964,14 +964,13 @@ private:
 
 if (!docBroker)
 {
-#if MAX_DOCUMENTS > 0
+static_assert(MAX_DOCUMENTS > 0, "MAX_DOCUMENTS must be positive");
 if (DocBrokers.size() + 1 > MAX_DOCUMENTS)
 {
 LOG_ERR("Maximum number of open documents reached.");
 shutdownLimitReached(*ws);
 return nullptr;
 }
-#endif
 
 // Request a kit process for this doc.
 auto child = getNewChild();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 32531] Incorrect cursor key movement between table cells of different directionality

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=32531

tommy27  changed:

   What|Removed |Added

 CC||ba...@quipo.it

--- Comment #23 from tommy27  ---
@Khaled
I've seen you have already fixed Bug 101361.
Are you still working on a better fix for the current report?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: kit/Kit.cpp test/TileQueueTests.cpp wsd/DocumentBroker.cpp wsd/TileDesc.hpp

2017-01-08 Thread Ashod Nakashian

 kit/Kit.cpp |4 +--
 test/TileQueueTests.cpp |8 +++---
 wsd/DocumentBroker.cpp  |5 +---
 wsd/TileDesc.hpp|   58 +---
 4 files changed, 44 insertions(+), 31 deletions(-)

New commits:
commit dfcada64b8112b25d3c3629e04749c7c25669e28
Author: Ashod Nakashian 
Date:   Mon Jan 2 00:30:27 2017 -0500

wsd: tilecombine now includes the versions of the tiles

Previously tilecombine had its own version, which is
nonesensical, since it's not really a tile.

Now it passes the version to the tiles when
parsing and serializes version per-tile.

Change-Id: I5db8d94880431e3d2a40b6787c6fe51a05771305
Reviewed-on: https://gerrit.libreoffice.org/32633
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index bfe75de..e840210 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -683,7 +683,7 @@ public:
 }
 
 LOG_DBG("+paintTile (combined) at (" << renderArea.getLeft() << ", " 
<< renderArea.getTop() << "), (" <<
-renderArea.getWidth() << ", " << renderArea.getHeight() << ") 
ver: " << tileCombined.getVersion());
+renderArea.getWidth() << ", " << renderArea.getHeight() << 
").");
 Timestamp timestamp;
 _loKitDocument->paintPartTile(pixmap.data(), tileCombined.getPart(),
   pixmapWidth, pixmapHeight,
@@ -691,7 +691,7 @@ public:
   renderArea.getWidth(), 
renderArea.getHeight());
 const auto elapsed = timestamp.elapsed();
 LOG_DBG("paintTile (combined) at (" << renderArea.getLeft() << ", " << 
renderArea.getTop() << "), (" <<
-renderArea.getWidth() << ", " << renderArea.getHeight() << ") 
ver: " << tileCombined.getVersion() <<
+renderArea.getWidth() << ", " << renderArea.getHeight() << ") 
" <<
 " rendered in " << (elapsed/1000.) << " ms (" << area / 
elapsed << " MP/s).");
 const auto mode = 
static_cast(_loKitDocument->getTileMode());
 
diff --git a/test/TileQueueTests.cpp b/test/TileQueueTests.cpp
index 0e12f48..8f7b575 100644
--- a/test/TileQueueTests.cpp
+++ b/test/TileQueueTests.cpp
@@ -114,11 +114,11 @@ void TileQueueTests::testTileCombinedRendering()
 const std::string req3 = "tile part=0 width=256 height=256 tileposx=0 
tileposy=3840 tilewidth=3840 tileheight=3840";
 const std::string req4 = "tile part=0 width=256 height=256 tileposx=3840 
tileposy=3840 tilewidth=3840 tileheight=3840";
 
-const std::string resHor = "tilecombine part=0 width=256 height=256 
tileposx=0,3840 tileposy=0,0 imgsize=0,0 tilewidth=3840 tileheight=3840";
+const std::string resHor = "tilecombine part=0 width=256 height=256 
tileposx=0,3840 tileposy=0,0 imgsize=0,0 tilewidth=3840 tileheight=3840 
ver=-1,-1,";
 const TileQueue::Payload payloadHor(resHor.data(), resHor.data() + 
resHor.size());
-const std::string resVer = "tilecombine part=0 width=256 height=256 
tileposx=0,0 tileposy=0,3840 imgsize=0,0 tilewidth=3840 tileheight=3840";
+const std::string resVer = "tilecombine part=0 width=256 height=256 
tileposx=0,0 tileposy=0,3840 imgsize=0,0 tilewidth=3840 tileheight=3840 
ver=-1,-1,";
 const TileQueue::Payload payloadVer(resVer.data(), resVer.data() + 
resVer.size());
-const std::string resFull = "tilecombine part=0 width=256 height=256 
tileposx=0,3840,0 tileposy=0,0,3840 imgsize=0,0,0 tilewidth=3840 
tileheight=3840";
+const std::string resFull = "tilecombine part=0 width=256 height=256 
tileposx=0,3840,0 tileposy=0,0,3840 imgsize=0,0,0 tilewidth=3840 
tileheight=3840 ver=-1,-1,-1,";
 const TileQueue::Payload payloadFull(resFull.data(), resFull.data() + 
resFull.size());
 
 TileQueue queue;
@@ -162,7 +162,7 @@ void TileQueueTests::testTileRecombining()
 // but when we later extract that, it is just one "tilecombine" message
 std::string message(payloadAsString(queue.get()));
 
-CPPUNIT_ASSERT_EQUAL(std::string("tilecombine part=0 width=256 height=256 
tileposx=7680,0,3840 tileposy=0,0,0 imgsize=0,0,0 tilewidth=3840 
tileheight=3840"), message);
+CPPUNIT_ASSERT_EQUAL(std::string("tilecombine part=0 width=256 height=256 
tileposx=7680,0,3840 tileposy=0,0,0 imgsize=0,0,0 tilewidth=3840 
tileheight=3840 ver=-1,-1,-1,"), message);
 
 // and nothing remains in the queue
 CPPUNIT_ASSERT_EQUAL(0, static_cast(queue._queue.size()));
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 232b109..a4ea62a 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -751,7 +751,7 @@ void DocumentBroker::handleTileRequest(TileDesc& tile,
 
 tile.setVersion(++_tileVersion);
 const auto tileMsg = tile.serialize();
-LOG_TRC("Tile request for " << tile.serialize());
+LOG_TRC("Tile request for " << tileMsg);

[Libreoffice-bugs] [Bug 105200] LibO installation aborted

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105200

tommy27  changed:

   What|Removed |Added

Summary|The Installation does not   |LibO installation aborted
   |complete|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105200] The Installation does not complete

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105200

tommy27  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@quipo.it
 Ever confirmed|0   |1

--- Comment #1 from tommy27  ---
which exact Windows version do you use?

did you try uninstalling the old LibO version first, then download again the
5.2.4 installation file and do a clean new install?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78143] FILEOPEN: font styles not retained in DOC saved by Kingsoft Writer - part 2

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=78143

--- Comment #11 from tommy27  ---
still present in LibO 5.4.0.0.alpha0+
Build ID: 215cbfb460326010737433c2020638e9388a88a4
CPU Threads: 4; OS Version: Windows 6.29; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-02_23:58:32
Locale: it-IT (it_IT); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78142] FILEOPEN: font styles not retained in DOC saved by Kingsoft Writer - part 1

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=78142

--- Comment #11 from tommy27  ---
still present in LibO 5.4.0.0.alpha0+
Build ID: 215cbfb460326010737433c2020638e9388a88a4
CPU Threads: 4; OS Version: Windows 6.29; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-02_23:58:32
Locale: it-IT (it_IT); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105103] typing after hitting 'Insert' key crashes LO

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105103

--- Comment #4 from Pranav Kant  ---
FWIW, can notice this on 

LibreOfficeDev 4.4.0.0.alpha2 d273a60bfdbf9bb7623bed38667ec0647753157c

too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105200] New: The Installation does not complete

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105200

Bug ID: 105200
   Summary: The Installation does not complete
   Product: LibreOffice
   Version: 5.2.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gregor.shap...@gmail.com

Description:
Immediately after choosing "Nästa" (Next - my computer is in Sweden) the
Installation Guide informs me (my translation from Swedish: "The Guide was
terminated before the installation of LibreOffice was finished. The System was
not changed. You can run the installation program again later to finish the
installation. Click on Finish to close the guide"
But running the installation again gives the same result.

Steps to Reproduce:
1.Download the LibreOffice_5.2.4_Win_x86.msi 
2.Run the Installation
3.Be surprised when it does not install

Actual Results:  
No installation

Expected Results:
Installed LibreOffice 5.2.4.2


Reproducible: Always

User Profile Reset: No

Additional Info:
I have an earlier version : Version: 4.4.7.2
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: sv_SE
Installed


User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/55.0.2883.87 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104399] Crash in: TransformItems(unsigned short, SfxItemSet const &, com::sun::star::uno::Sequence &, SfxSlot const *)

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104399

Markus Mohrhard  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #7 from Markus Mohrhard  ---


*** This bug has been marked as a duplicate of bug 104830 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104830] Crash when exiting Writer after copying to clipboard

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104830

Markus Mohrhard  changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #8 from Markus Mohrhard  ---
*** Bug 104399 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Fakabbir Amin - License Statement

2017-01-08 Thread Fakabbir Amin

All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.

Sincerely,

Fakabbir Amin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 101313] Copy-paste a Table With Merged Cells: Loss of formatting ( Cells Placed in Wrong Position)

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101313

Kevin Suo  changed:

   What|Removed |Added

   Keywords||bibisectRequest

--- Comment #3 from Kevin Suo  ---
Added another "bibisectRequest" keyword, we need someone with the old "43all"
bibisect repo to narrow down the range.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101313] Copy-paste a Table With Merged Cells: Loss of formatting ( Cells Placed in Wrong Position)

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101313

Kevin Suo  changed:

   What|Removed |Added

Version|5.2.0.3 rc  |4.0.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101313] Copy-paste a Table With Merged Cells: Loss of formatting ( Cells Placed in Wrong Position)

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101313

Kevin Suo  changed:

   What|Removed |Added

   Keywords||bibisected, regression

--- Comment #2 from Kevin Suo  ---
bibisect-release bibisect results suggests that the bug started from
libreoffice-4.0.0.0.beta1. Added keyword "regression".

4f2186cd72652db35eebe5b1b9d3693723433b85 is the first bad commit
commit 4f2186cd72652db35eebe5b1b9d3693723433b85
Author: Matthew Francis 
Date:   Tue Apr 14 22:40:46 2015 +0800

libreoffice-4.0.0.0.beta1

LibO-Dev_4.0.0.0.beta1_Linux_x86-64_install-deb_en-US.tar.gz

:04 04 e6812e3e351d23e270d6424988196d6208d95b5d
34c7fa1c93970d74dd4dc1bd5706704ffb0b0a9e M  opt

git bisect log
# bad: [e992b5c0217fbbfaed351e4898b8c751ae2fe90e] libreoffice-4.4.7.2
# good: [52afdea50650697a791234f22d2cf2147498b06e] libreoffice-3.3.0
git bisect start 'libreoffice-4.4.7.2' 'libreoffice-3.3.0'
# bad: [33d0c0cac4bfc14221f2a665735e125f446f3251] libreoffice-4.1.3.2
git bisect bad 33d0c0cac4bfc14221f2a665735e125f446f3251
# bad: [4f2186cd72652db35eebe5b1b9d3693723433b85] libreoffice-4.0.0.0.beta1
git bisect bad 4f2186cd72652db35eebe5b1b9d3693723433b85
# good: [4a9bc438d62f90e8bf687683d854c3a044397505] libreoffice-3.5.3rc2
git bisect good 4a9bc438d62f90e8bf687683d854c3a044397505
# good: [ac15b75361b54e9d29f2ed9e3203b731fd0a0d29] libreoffice-3.6.2.2
git bisect good ac15b75361b54e9d29f2ed9e3203b731fd0a0d29
# good: [f4b2466b27f7d7d13b71213a534a8f01dfa1805b] libreoffice-3.6.6.1
git bisect good f4b2466b27f7d7d13b71213a534a8f01dfa1805b
# good: [208dc7bb206c4f313021c2fb045b165638921b9e] libreoffice-3.6.7.1
git bisect good 208dc7bb206c4f313021c2fb045b165638921b9e
# good: [2ba8a27cc4f9f01e531e73760f6c3f6505999be5] libreoffice-3.6.7.2
git bisect good 2ba8a27cc4f9f01e531e73760f6c3f6505999be5
# first bad commit: [4f2186cd72652db35eebe5b1b9d3693723433b85]
libreoffice-4.0.0.0.beta1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105191] Portions of Drop down menus that fall outside the spreadsheet boundaries are not deleted when spreadsheet is closed.

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105191

Aprax  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98074] FILESAVE: Cell formatting lost / corrupted style.xml ( reported by Excel) when saving file to XLSX

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98074

Kevin Suo  changed:

   What|Removed |Added

   Keywords|possibleRegression  |
Version|4.2.8.2 release |3.3.0 release
 OS|Windows (All)   |All

--- Comment #8 from Kevin Suo  ---
Bug exists in the old LibreOffice 3.3.0 OOO330m19 (Build:6) tag
libreoffice-3.3.0.4 linux. 

Set platform to ALL, version to 3.3.0 release.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105191] Portions of Drop down menus that fall outside the spreadsheet boundaries are not deleted when spreadsheet is closed.

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105191

--- Comment #6 from Aprax  ---
Created attachment 130270
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130270=edit
example 5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105191] Portions of Drop down menus that fall outside the spreadsheet boundaries are not deleted when spreadsheet is closed.

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105191

--- Comment #5 from Aprax  ---
Created attachment 130269
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130269=edit
example 4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105191] Portions of Drop down menus that fall outside the spreadsheet boundaries are not deleted when spreadsheet is closed.

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105191

--- Comment #4 from Aprax  ---
OK, did that, same problem with new profile.
New screenshots show the residual portion of Data Menu and the Sort Criteria
left when the Sort had completed.

When getting the first screen shot, the spreadsheet overlayed the right side of
this page and didn't go away when I closed the sheet, that's a new one I hadn't
seen before.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98700] FILESAVE: "keep with next paragraph" Wrongly Set When Save as DOCX

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98700

Kevin Suo  changed:

   What|Removed |Added

Version|4.3.7.2 release |3.4 all versions

--- Comment #5 from Kevin Suo  ---
Bug exists in the old LibreOffice 3.4.0 OOO340m1 (Build:11). Set version field
to "3.4 all versions".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62622] Cannot format individual characters of some hyperlinks

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=62622

--- Comment #8 from David  ---
Confirmed: bug still present.

Version: 5.2.3.3 (x64)
Windows 10

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81705] Export to DOC lost outline level

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=81705

Kevin Suo  changed:

   What|Removed |Added

Version|4.2.6.1 rc  |Inherited From OOo

--- Comment #6 from Kevin Suo  ---
Bug exists in the "oldest" version of the "bibisect-releases" repo. Set version
to "Inherited from Ooo".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86371] FILESAVE: Setting line spacing to "Single" not preserved in DOCX (it falls back to 120%)

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86371

Kevin Suo  changed:

   What|Removed |Added

   Keywords||bibisected, bisected
 CC||rattles2...@gmail.com

--- Comment #9 from Kevin Suo  ---
Bibisecting using the "bibisect-releases" repo, I find that the behaviour
changed start from libreoffice-4.2.0.0.beta1.

In versions before libreoffice-4.0.6.2, when set the paragraph spacing to
Single, save and reopen, it shows "At least of 6pt". Start from
libreoffice-4.2.0.0.beta1, it always shows "120%".

This means that it is broken somewhere within
https://wiki.documentfoundation.org/Releases/4.2.0/Beta1#List_of_fixed_bugs.
Added keyword "bibisected"

A rough review of the changes in 4.2.0.beta1 shows that the most suspicious
commit is:

author  Adam Co  2013-07-10 13:43:51 (GMT)
committer   Miklos Vajna   2013-07-11 08:10:09 (GMT)
commit  5bb9b70a66d7818844abfaa297893c095e03d24c (patch)
tree9f14991fc8fc93d00fc39a95b292ba636e744fd6
parent  dd3bb0aa49bbf45138d2ea594fb593729ac3b2b0 (diff)
fdo#66773: fix for line spacing default
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx

Change-Id: I7dafa709fd7dcd3df445277505468386c3f1cef2
Reviewed-on: https://gerrit.libreoffice.org/4810

Added keyword "bisected" and adding Adam Co in the cc list.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: dtrans/source editeng/source forms/source include/sot include/svtools sc/source sd/source sfx2/source sot/source svtools/source sw/source

2017-01-08 Thread Oliver Specht

 dtrans/source/win32/ftransl/ftransl.cxx   |4 +++-
 editeng/source/editeng/eeobj.cxx  |8 +---
 editeng/source/editeng/impedit2.cxx   |   11 ++-
 forms/source/richtext/clipboarddispatcher.cxx |6 --
 include/sot/formats.hxx   |3 ++-
 include/svtools/sores.hxx |4 +++-
 sc/source/ui/app/seltrans.cxx |1 +
 sc/source/ui/app/transobj.cxx |   10 +++---
 sc/source/ui/docshell/impex.cxx   |4 ++--
 sc/source/ui/drawfunc/drtxtob.cxx |8 ++--
 sc/source/ui/drawfunc/drtxtob1.cxx|1 +
 sc/source/ui/view/cellsh.cxx  |2 ++
 sc/source/ui/view/editsh.cxx  |7 +--
 sc/source/ui/view/gridwin.cxx |7 +--
 sc/source/ui/view/viewfun3.cxx|   16 
 sc/source/ui/view/viewfun4.cxx|4 
 sd/source/ui/app/sdxfer.cxx   |4 +++-
 sd/source/ui/func/fuinsert.cxx|1 +
 sd/source/ui/view/drviews7.cxx|1 +
 sd/source/ui/view/outlnvsh.cxx|2 ++
 sd/source/ui/view/sdview3.cxx |   15 +--
 sfx2/source/appl/appdde.cxx   |1 +
 sot/source/base/exchange.cxx  |1 +
 sot/source/base/formats.cxx   |6 ++
 svtools/source/dialogs/formats.src|4 
 svtools/source/dialogs/insdlg.cxx |3 ++-
 svtools/source/misc/transfer.cxx  |4 
 sw/source/core/doc/swserv.cxx |1 +
 sw/source/core/docnode/section.cxx|1 +
 sw/source/uibase/dochdl/swdtflvr.cxx  |   23 +--
 sw/source/uibase/shells/annotsh.cxx   |6 +-
 31 files changed, 134 insertions(+), 35 deletions(-)

New commits:
commit 048e30c1f8231e6cd144a9251061f6fa127b353e
Author: Oliver Specht 
Date:   Fri Dec 30 16:47:17 2016 +0100

tdf#101828 handle rtf/richtext correctly

Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0
Reviewed-on: https://gerrit.libreoffice.org/32682
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/dtrans/source/win32/ftransl/ftransl.cxx 
b/dtrans/source/win32/ftransl/ftransl.cxx
index cb62bdd..3350211 100644
--- a/dtrans/source/win32/ftransl/ftransl.cxx
+++ b/dtrans/source/win32/ftransl/ftransl.cxx
@@ -134,7 +134,7 @@ static const std::vector< FormatEntry > g_TranslTable {
 // SotClipboardFormatId::SIMPLE_FILE
 
FormatEntry("application/x-openoffice-file;windows_formatname=\"FileName\"", 
"FileName", nullptr, CF_INVALID, CPPUTYPE_DEFAULT),
 // SotClipboardFormatId::RTF
-FormatEntry("text/richtext", "Rich Text Format", nullptr, CF_INVALID, 
CPPUTYPE_DEFAULT),
+FormatEntry("text/rtf", "Rich Text Format", nullptr, CF_INVALID, 
CPPUTYPE_DEFAULT),
 // SotClipboardFormatId::DRAWING
 
FormatEntry("application/x-openoffice-drawing;windows_formatname=\"Drawing 
Format\"", "Drawing Format", nullptr, CF_INVALID, CPPUTYPE_DEFAULT),
 // SotClipboardFormatId::SVXB
@@ -352,6 +352,8 @@ static const std::vector< FormatEntry > g_TranslTable {
 
FormatEntry("application/x-openoffice-dummy3;windows_formatname=\"SO_DUMMYFORMAT_3\"",
 "SO_DUMMYFORMAT_3", nullptr, CF_INVALID, CPPUTYPE_DEFAULT),
 //SotClipboardFormatId::DUMMY4
 
FormatEntry("application/x-openoffice-dummy4;windows_formatname=\"SO_DUMMYFORMAT_4\"",
 "SO_DUMMYFORMAT_4", nullptr, CF_INVALID, CPPUTYPE_DEFAULT),
+// SotClipboardFormatId::RICHTEXT
+FormatEntry("text/richtext", "Richtext Format", nullptr, CF_INVALID, 
CPPUTYPE_DEFAULT),
 };
 
 namespace {
diff --git a/editeng/source/editeng/eeobj.cxx b/editeng/source/editeng/eeobj.cxx
index 7347fa3..c72354e 100644
--- a/editeng/source/editeng/eeobj.cxx
+++ b/editeng/source/editeng/eeobj.cxx
@@ -57,7 +57,7 @@ uno::Any EditDataObject::getTransferData( const 
datatransfer::DataFlavor& rFlavo
 {
 aAny <<= GetString();
 }
-else if ( ( nT == SotClipboardFormatId::EDITENGINE ) || ( nT == 
SotClipboardFormatId::RTF ) )
+else if ( ( nT == SotClipboardFormatId::EDITENGINE ) || ( nT == 
SotClipboardFormatId::RTF ) || ( nT == SotClipboardFormatId::RICHTEXT ) )
 {
 // No RTF on demand any more:
 // 1) Was not working, because I had to flush() the clipboard 
immediately anyway
@@ -84,10 +84,11 @@ uno::Any EditDataObject::getTransferData( const 
datatransfer::DataFlavor& rFlavo
 
 uno::Sequence< datatransfer::DataFlavor > 
EditDataObject::getTransferDataFlavors(  ) throw(uno::RuntimeException, 
std::exception)
 {
-uno::Sequence< datatransfer::DataFlavor > aDataFlavors(3);
+uno::Sequence< datatransfer::DataFlavor > aDataFlavors(4);
 SotExchange::GetFormatDataFlavor(

[Libreoffice-bugs] [Bug 105181] mailto in calc

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105181

--- Comment #2 from DearWebby  ---
Does not work with Eudora.
Might work with TB and Microsoft Office email programs, but not with Eudora.
CTRL Click on a mailto just opens Chrome.
CALC needs a method for setting the default email program to be used with CALC.
You can't expect companies to change their email programs and 25 years of
accounting mails because CALC does not have a way to deal with Eudora.
Look at how, for example, Mailwasher, deals with correctly calling Eudora. You
simply set the default email program, even if Windoze blocks setting that into
the Registry.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105199] New: Inserting images into Photo Gallery crashes when image file name contains hash (#)

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105199

Bug ID: 105199
   Summary: Inserting images into Photo Gallery crashes when image
file name contains hash (#)
   Product: LibreOffice
   Version: 5.2.3.2 rc
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: b...@oblong.com.au

Description:
Inserting images into Photo Gallery crashes when imported image file name
contains hash (#) character. 

Steps to Reproduce:
1. Name an image file as, for example, #1.jpg
2.In Impress: Insert|Media|Photo Album|Add
3.select the image
4.Open|Insert Slides

Actual Results:  
Impress closes down with no error message. Restarting Impress goes through
recovery process.

Expected Results:
Image(s) should have been imported. If for some reason the file name is deemed
to invalid, a warning to that effect should be given, instead of crashing the
program.


Reproducible: Always

User Profile Reset: No

Additional Info:
If the file name to be imported does not contain a "#", then the import works.

5.1.4.2 program crashes and disappears.

Same problem occurs in 5.2.3.3 (via Flatpak) but in that case program hangs and
does not respond. Windows 5.1.6.2 gives "Fatal error" dialog without further
explanation.


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101
Firefox/50.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105198] Two-screen presentation mode fails on Wayland

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105198

--- Comment #1 from Jonathan Corbet  ---
I forgot one (probably) important detail: the laptop has a HiDPI screen, while
the projector, needless to say, does not.  The different scaling between the
two screens may well play into what's going on here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58358] VIEWING Scrolling broken - page totally distorted [Summary: comment#38, comment#42]

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=58358

--- Comment #60 from Renato Miró  ---
Created attachment 130268
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130268=edit
Problem with anti-aliasing and subpixel rendering off

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105198] New: Two-screen presentation mode fails on Wayland

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105198

Bug ID: 105198
   Summary: Two-screen presentation mode fails on Wayland
   Product: LibreOffice
   Version: 5.2.3.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: cor...@lwn.net

Description:
When going into slideshow mode on Wayland (Fedora 25), only the upper left
quarter of the second (projector) screen is drawn.

Steps to Reproduce:
1. Run under gnome/wayland
2. Plug in an external monitor / projector
3. Enter slide-show mode

Actual Results:  
The presenter's screen on the laptop is shown as always.  The external screen
is only drawn in the upper left quadrant, showing 1/4 of the slides.



Expected Results:
Full slides displayed.

Of course, given the quality of my slides, audiences might prefer things the
way they are now, but I'd still rather see the whole thing, myself.


Reproducible: Always

User Profile Reset: No

Additional Info:
Everything works fine again if I log in using the Xorg fallback rather than
wayland.


User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:50.0) Gecko/20100101
Firefox/50.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58358] VIEWING Scrolling broken - page totally distorted [Summary: comment#38, comment#42]

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=58358

--- Comment #59 from Renato Miró  ---
I'm sorry it didn't work for you, John. In my case, I did some tests and
verified that other Xorg options (ShadowFB off, BackingStore off, Silkenmouse
off) didn't help -- while NoAccel effectively prevented problems in Libreoffice
and in other situations, both when using Xfce and KDE4 (on Mageia 5).

Perhaps this is a complex bug which results from problems both in the X11
drivers and Libreoffice's inability to deal with these driver problems.

BTW, what hardware & driver combination are you using (please describe the
machines on which the bug occurs).

If you're using an Nvidia card, have you tried Nouveau? Have you tried the VESA
or fbdev driver (if any of these works in your hardware)

It's also worth noting that maybe, in spite of symptoms being similar,
solutions might not be the same on different hardware. I'm attaching an image
of the bug happening over here with anti-aliasing turned off, which apparently
would prevent the bug on your hardware.

To test a big document, I used "WG42-WriterGuideLO.odt", available online with
480+ pages and ~14MB. With option NoAccel, no problem happened over here.

I don't know much, really, but these problems are usually associated with bad
screen handling: either two things are writing to the video memory, a buffer is
updated with the wrong content, the screen is refreshed from the buffer and
partially overwrites what Libreoffice has already written, or Libreoffice
writes to the wrong buffer, or maybe there's even a speed problem. In my case
using acceleration seemingly causes that sort of mistakes in screen updating.
Maybe if we knew details about your hardware (particularly the video card brand
and model), we could search for similar problems on that hardware.

Good luck!

PS: If you really have to live without font anti-aliasing, try to use a big
resolution. At 1920x1080 I feel less need to use sub-pixel rendering.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104967] EDITING Crash in: ScPostIt::CreateCaption(ScAddress const &, SdrCaptionObj const *)

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104967

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected
   Priority|medium  |high
   Severity|minor   |major

--- Comment #7 from Xisco Faulí  ---
Regression introduced in range
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=fb4e16c90e01aded8998ee9da50b394efc2e8fd4..2dfb8341eaf1adb3c27058ec05fef8bd52551aaa

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source

2017-01-08 Thread Eike Rathke

 sc/source/core/data/clipcontext.cxx |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit 9fa9226595958410b4ca7d790e8e3dd27345
Author: Eike Rathke 
Date:   Wed Jan 4 21:23:40 2017 +0100

handle paste special of single formula cell with error result

This apparently was never implemented, unlike in the block pasting code that
handles it fine. Formula cells with error results were always copied as is 
if
numeric was requested, even if formulas weren't requested.

Change-Id: Id550c4e757b6bb2c06aa0637328216383cdf3d6b
(cherry picked from commit 12ecd30476f17c6f6efde976f8e56d604eda0f1e)
Reviewed-on: https://gerrit.libreoffice.org/32744
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/core/data/clipcontext.cxx 
b/sc/source/core/data/clipcontext.cxx
index b0ac301..c355f9b 100644
--- a/sc/source/core/data/clipcontext.cxx
+++ b/sc/source/core/data/clipcontext.cxx
@@ -210,6 +210,13 @@ void CopyFromClipContext::setSingleCell( const ScAddress& 
rSrcPos, const ScColum
 if (!bNumeric)
 // Error code is treated as numeric value. Don't paste it.
 rSrcCell.clear();
+else
+{
+// Turn this into a formula cell with just the error code.
+ScFormulaCell* pErrCell = new ScFormulaCell(mpClipDoc, 
rSrcPos);
+pErrCell->SetErrCode(nErr);
+rSrcCell.set(pErrCell);
+}
 }
 else if (rSrcCell.mpFormula->IsValue())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source

2017-01-08 Thread Eike Rathke

 sc/source/filter/xml/xmlcelli.cxx |   19 +--
 1 file changed, 17 insertions(+), 2 deletions(-)

New commits:
commit 7f3e71d2a6e34e33d04739bdf48ea3c18beef1be
Author: Eike Rathke 
Date:   Fri Jan 6 17:16:25 2017 +0100

display error constants written by 5.3+ in the for 5.2 usual way, tdf#105024

Change-Id: I5b61ed58144ae1583d74056389478e9d5c86d2cb
Reviewed-on: https://gerrit.libreoffice.org/32794
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/filter/xml/xmlcelli.cxx 
b/sc/source/filter/xml/xmlcelli.cxx
index 5c8a4f1..4670aed 100644
--- a/sc/source/filter/xml/xmlcelli.cxx
+++ b/sc/source/filter/xml/xmlcelli.cxx
@@ -1404,11 +1404,26 @@ void ScXMLTableRowCellContext::PutFormulaCell( const 
ScAddress& rCellPos )
 sal_uInt32 nEnglish = 
pFormatter->GetStandardIndex(LANGUAGE_ENGLISH_US);
 double fVal;
 if ( pFormatter->IsNumberFormat( aText, nEnglish, fVal ) )
+{
 rDoc.setNumericCell(rCellPos, fVal);
-//the (english) number format will not be set
-//search matching local format and apply it
+//the (english) number format will not be set
+//search matching local format and apply it
+}
 else
+{
+// Error constants are stored as "#ERRxxx!" by 5.3+, error
+// numbers are sal_uInt16 so at most 5 decimal digits, no
+// other expression must be present.
+if (aText.startsWithIgnoreAsciiCase("#ERR") && 
aText.getLength() <= 10 &&
+aText[aText.getLength()-1] == '!')
+{
+// Display error constants written by 5.3+ in the for 5.2 
usual way.
+sal_uInt32 nErr = aText.copy( 4, aText.getLength() - 
5).toUInt32();
+if (0 < nErr && nErr <= SAL_MAX_UINT16)
+aText = ScGlobal::GetErrorString(nErr);
+}
 rDoc.setStringCell(rCellPos, aText);
+}
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105055] Crash in: ScPostIt::CreateCaption(ScAddress const &, SdrCaptionObj const *)

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105055

--- Comment #9 from Aron Budea  ---
Bibisected, but there are many commits in the range:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=3f6ad98c4764402dc6e876106867e49e3e888f8f..c8a94cae37029b037507ce86d149ba56ca341f11

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105055] Crash in: ScPostIt::CreateCaption(ScAddress const &, SdrCaptionObj const *)

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105055

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected

--- Comment #8 from Aron Budea  ---
40e9bb4c6d741ce94a487cfda3d3b458c231249c is the first bad commit
commit 40e9bb4c6d741ce94a487cfda3d3b458c231249c
Author: Norbert Thiebaud 
Date:   Sun Jun 26 19:49:44 2016 -0700

source sha:c8a94cae37029b037507ce86d149ba56ca341f11

source sha:c8a94cae37029b037507ce86d149ba56ca341f11
source sha:aa06a33946951e872b5e81d1c2bc8b7f60c861e1
source sha:b075882016d8388d20cc7490eb0733a9d0d97a5f
source sha:2184b08dd185f3f20d8b2098d3f652aed629b51f
source sha:d1051a203a7f89997128313f6a4f065f51f6c00d
source sha:9b6a02d8d48c135103aaa980fd27eec07b9223b6
source sha:9aadbf407b209585fbed5158c133d6ce3ca168d1
source sha:1d122bfcb1b59533711c961e0c1984c299886c69
source sha:db0650a50bc74c5644cbe096b4b223252e478589
source sha:ca97a862d0e7cd51954c11a923fabf59ce20f856
source sha:cd01a470e438ac3f25f561221ef72e29cf8e1df8
source sha:ff25ea3d5ccf3a990767cbb1ef99037d3f84b072
source sha:feb6a07259c57ab00118f197ef2b3e1d5575c48e
source sha:6402c19c9b4d51dd7feaa3129b6f15b20704d356
source sha:65979ca6ebf341a4733b2755d099e365e6dd0fa0
source sha:901aa845b7b7fe0e0f2ed483d3b8e7b7ffd8b894
source sha:0b6acf6fe6256e2b4fc2673b7b226ea2cbb011c5
source sha:97ad8133644d8eb7678aa3c180f3d8f9247a0d90
source sha:c924baf95fe47ea642924b3bc47cd81bf4e89d10
source sha:bf9fd0da729cf8250d54821219a569ff095a3435
source sha:822aac91426848ae36fb5a6bd5ee55db6b60de6a
source sha:e945944274e3dbb675e03f2a3f2303506c7c758c
source sha:59246096295ab94f9e2f47260100f83501fc1bc2
source sha:84bbe3a104e5ffca8a62c50b0fe6e2029764319a
source sha:3fd21b123fb2338b9f1ed0b483a86ae878a6d769
source sha:02f43b0ad3865ef7af17fe51bc87680ffe881dc0
source sha:c4f3c63931721d6b8a6994e4d71e88a6c9fe57c5
source sha:c717158a82bed756c4d20f6304a29600affa0f66
source sha:0325b22a2a2b537a71f53b7c5d3e6c13fef68911
source sha:46773b0b59bb9061c5f5660e65e4ebc0d455fe02
source sha:6db92434c664116eb1ec6cb127f2cd957a03bb65
source sha:c931f3a5184928bc333796362a5616a93c6ed6d7
source sha:053a843bccaef2d2323be3ddff6217c592a4c5db
source sha:b72c14f68b317b27be12a2432cdeae351537d57a
source sha:d56dc64795dcd913d5fa663275bf34b75a0c82e6
source sha:4e3ff19b33c84557fd20e68960499933b4e52638
source sha:eedc5b15fb5c9a352657edec841b6a30c408e5c8
source sha:e6daf6bfb0c3c3e3ba03c825d778436c369f19a3
source sha:81db0773fe499fd4b326925dad42a7099f19fcb3
source sha:58362bfda5e3eda4e91f0ad5a565670882bb18bb
source sha:f8a18a464eb2cd8ee7a07b8ddef0fa5d79d638ef
source sha:2ff98b560cfaa747b19e013857d89d16fe99fd76
source sha:67fccad964a1e556e762939177e588620b2a1889
source sha:88cd9dd591d7921e5bce33c170b457ae5aa871bb
source sha:65a88b51b3df8e4c2756fde4058194d892c627f1
source sha:639aa16945f1280716b3d3cb44ebf90eab416887
source sha:9325c18044a8adc852e2d1b42a5a479ab6195da8
source sha:f2f8835bfb1ec57885c94aa2aac8d1a17fc09ed3
source sha:136a2fd6c08193793d546e69108765316c96668b
source sha:7d76bb251e0c88ff17282a33b801a5d17a434af5
source sha:47443d720d5f2bee0993222fd6383a59056d8591
source sha:920d4463f6e59b815852c173e2974ffc7b4bb284
source sha:2b7109a12ab772bf53766d6e06b422c8e687d482
source sha:6247ff3fed5373a0079f899e816743909d0a62f8
source sha:19ebfdbadc214ea3f8dc27d926ce46674b1f184c
source sha:358bb8eed4383906f5b8773c57aae2325b6ff0e7
source sha:e1296e295e7d4f1104d2c90b1f51d52251358bea
source sha:d945e97d8f85465f04f59fd197ded2edb56caac3
source sha:c144288abe73262178a8fd94baef895e1744c304
source sha:17189e8e63254dbe5e4c9c755a4817664e4ee0d5
source sha:ed49818ab0af63f3246e8c27ba87aef4d9fbb829
source sha:29bea29ec1a56255455f855e2b29321553cb524c
source sha:1506b14a7ed546c3e78625eaac667bdd5e60f57f
source sha:0c73e7364b2fe4a8b24eca536f60a7a4228ddb25
source sha:0c6806b03ac6dc6d5fde8bbede57985a2cad271f
source sha:dcdcbfef61b86688eb26a3382532e324d122d747
source sha:25dafb5f83b7d3f1123690f35e540cec8df38d92
source sha:f31de94b2dfbbb74a5f9767aef66b21aa56af2cf
source sha:c0ec592ca65e844132be24b20a0c9daffe5f3a6d
source sha:11e72223f2a4ac424309bef34268b6ff5821cda8
source sha:c3cdaa39505d85d530d848128d5370f97b57a411
source sha:6a5e30d52c345cbeb89eab0722fe866db0d62fc6
source sha:24ca187b6370ca56c8acd92bc405028dd9deb5f2
source sha:db12f068f849dc0e03d43ee6688ba342e985fa04
source sha:f02c1ca61c936ad555c33c16adf0ce9674c2
source sha:f4b8affe8f4bee197bf5ffb73d52fafee3e904db
source sha:259fd2c0abd5627ac5689c752a57edc045dbfcfa
source sha:f3f943a79913db52b2c56a56a137c8601ade976c
source

[Libreoffice-bugs] [Bug 105014] Crash when Click "Add Separator" in Customize Toolbox / Crash in: SvxConfigPage::InsertEntry(SvxConfigEntry , SvTreeListEntry , bool), cuilo.dll

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105014

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected

--- Comment #5 from Xisco Faulí  ---
Regression introduced by:

author  Muhammet Kara  2016-09-05 13:36:59
(GMT)
committer   Samuel Mehrbrodt   2016-09-07
15:21:00 (GMT)
commit  3b3feeff98385bccce14b83bf32f079f624550c6 (patch)
tree726ca1e8ac6277680e322e378e3ffbf6b6eb6a30
parent  bece2e8415a9ef33bba492569c7c21e58878a836 (diff)
tdf#82840 Add 'Add Separator' button to toolbar customization
Add 'Add Separator' button to the 'Customize' dialog's
'Menus', 'Context Menus', and 'Toolbars' tabs. And remove the
'Add Separator' item from the 'Modify' menu.

In the following commits, more widgets will be added
and moved around to achieve the suggested appearance
and functionality in the related bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105181] mailto in calc

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105181

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
It works for me, with Thunderbird as default email program on windows 10.

If I enter somethink like:
 mailto:a...@a.com
in a cell, change to a link format.
And with [Ctrl+click] the email program is open with the address on To:

so neither a bug a need for enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103852] win32: clipboard deadlock.

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103852

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4969

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104969] Crash in: ScTransferObj::~ScTransferObj()

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104969

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3852

--- Comment #18 from Aron Budea  ---
Just for reference, this crash originated from the commit referenced below, a
fix for bug 103852:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c53cf1dfc5eacd8fee6b2b549ec6b59ad927e01c

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104830] Crash when exiting Writer after copying to clipboard

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104830

--- Comment #7 from Aron Budea  ---
Ok, so apparently Markus is working on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/breeze

2017-01-08 Thread Tomaž Vajngerl

 icon-themes/breeze/svx/res/marker-anchor-pressed.png  |binary
 icon-themes/breeze/svx/res/marker-anchor.png  |binary
 icon-themes/breeze/svx/res/marker-circ11-1.png|binary
 icon-themes/breeze/svx/res/marker-circ11-2.png|binary
 icon-themes/breeze/svx/res/marker-circ11-3.png|binary
 icon-themes/breeze/svx/res/marker-circ11-4.png|binary
 icon-themes/breeze/svx/res/marker-circ11-5.png|binary
 icon-themes/breeze/svx/res/marker-circ11-6.png|binary
 icon-themes/breeze/svx/res/marker-circ7-1.png |binary
 icon-themes/breeze/svx/res/marker-circ7-2.png |binary
 icon-themes/breeze/svx/res/marker-circ7-3.png |binary
 icon-themes/breeze/svx/res/marker-circ7-4.png |binary
 icon-themes/breeze/svx/res/marker-circ7-5.png |binary
 icon-themes/breeze/svx/res/marker-circ7-6.png |binary
 icon-themes/breeze/svx/res/marker-circ9-1.png |binary
 icon-themes/breeze/svx/res/marker-circ9-2.png |binary
 icon-themes/breeze/svx/res/marker-circ9-3.png |binary
 icon-themes/breeze/svx/res/marker-circ9-4.png |binary
 icon-themes/breeze/svx/res/marker-circ9-5.png |binary
 icon-themes/breeze/svx/res/marker-circ9-6.png |binary
 icon-themes/breeze/svx/res/marker-cross.png   |binary
 icon-themes/breeze/svx/res/marker-elli11x9-1.png  |binary
 icon-themes/breeze/svx/res/marker-elli11x9-2.png  |binary
 icon-themes/breeze/svx/res/marker-elli11x9-3.png  |binary
 icon-themes/breeze/svx/res/marker-elli11x9-4.png  |binary
 icon-themes/breeze/svx/res/marker-elli11x9-5.png  |binary
 icon-themes/breeze/svx/res/marker-elli11x9-6.png  |binary
 icon-themes/breeze/svx/res/marker-elli7x9-1.png   |binary
 icon-themes/breeze/svx/res/marker-elli7x9-2.png   |binary
 icon-themes/breeze/svx/res/marker-elli7x9-3.png   |binary
 icon-themes/breeze/svx/res/marker-elli7x9-4.png   |binary
 icon-themes/breeze/svx/res/marker-elli7x9-5.png   |binary
 icon-themes/breeze/svx/res/marker-elli7x9-6.png   |binary
 icon-themes/breeze/svx/res/marker-elli9x11-1.png  |binary
 icon-themes/breeze/svx/res/marker-elli9x11-2.png  |binary
 icon-themes/breeze/svx/res/marker-elli9x11-3.png  |binary
 icon-themes/breeze/svx/res/marker-elli9x11-4.png  |binary
 icon-themes/breeze/svx/res/marker-elli9x11-5.png  |binary
 icon-themes/breeze/svx/res/marker-elli9x11-6.png  |binary
 icon-themes/breeze/svx/res/marker-elli9x7-1.png   |binary
 icon-themes/breeze/svx/res/marker-elli9x7-2.png   |binary
 icon-themes/breeze/svx/res/marker-elli9x7-3.png   |binary
 icon-themes/breeze/svx/res/marker-elli9x7-4.png   |binary
 icon-themes/breeze/svx/res/marker-elli9x7-5.png   |binary
 icon-themes/breeze/svx/res/marker-elli9x7-6.png   |binary
 icon-themes/breeze/svx/res/marker-glue-selected.png   |binary
 icon-themes/breeze/svx/res/marker-glue-unselected.png |binary
 icon-themes/breeze/svx/res/marker-rect11-1.png|binary
 icon-themes/breeze/svx/res/marker-rect11-2.png|binary
 icon-themes/breeze/svx/res/marker-rect11-3.png|binary
 icon-themes/breeze/svx/res/marker-rect11-4.png|binary
 icon-themes/breeze/svx/res/marker-rect11-5.png|binary
 icon-themes/breeze/svx/res/marker-rect11-6.png|binary
 icon-themes/breeze/svx/res/marker-rect13-1.png|binary
 icon-themes/breeze/svx/res/marker-rect13-2.png|binary
 icon-themes/breeze/svx/res/marker-rect13-3.png|binary
 icon-themes/breeze/svx/res/marker-rect13-4.png|binary
 icon-themes/breeze/svx/res/marker-rect13-5.png|binary
 icon-themes/breeze/svx/res/marker-rect13-6.png|binary
 icon-themes/breeze/svx/res/marker-rect7-1.png |binary
 icon-themes/breeze/svx/res/marker-rect7-2.png |binary
 icon-themes/breeze/svx/res/marker-rect7-3.png |binary
 icon-themes/breeze/svx/res/marker-rect7-4.png |binary
 icon-themes/breeze/svx/res/marker-rect7-5.png |binary
 icon-themes/breeze/svx/res/marker-rect7-6.png |binary
 icon-themes/breeze/svx/res/marker-rect9-1.png |binary
 icon-themes/breeze/svx/res/marker-rect9-2.png |binary
 icon-themes/breeze/svx/res/marker-rect9-3.png |binary
 icon-themes/breeze/svx/res/marker-rect9-4.png |binary
 icon-themes/breeze/svx/res/marker-rect9-5.png |binary
 icon-themes/breeze/svx/res/marker-rect9-6.png |binary
 icon-themes/breeze/svx/res/marker-rectplus11-1.png|binary
 icon-themes/breeze/svx/res/marker-rectplus11-2.png|binary
 icon-themes/breeze/svx/res/marker-rectplus11-3.png|binary
 icon-themes/breeze/svx/res/marker-rectplus11-4.png|binary
 icon-themes/breeze/svx/res/marker-rectplus11-5.png|binary
 icon-themes/breeze/svx/res/marker-rectplus11-6.png|binary
 icon-themes/breeze/svx/res/marker-rectplus7-1.png |binary
 icon-themes/breeze/svx/res/marker-rectplus7-2.png |binary

[Libreoffice-bugs] [Bug 92825] [META] Update help for all menu changes

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92825
Bug 92825 depends on bug 105070, which changed state.

Bug 105070 Summary: Libreoffice help indicates wrong location of 'Compare 
Document' menu item
https://bugs.documentfoundation.org/show_bug.cgi?id=105070

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103852] win32: clipboard deadlock.

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103852

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4830

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104567] Crashing while closing LibO Writer after pasting shape from Draw, Crash in: SdTransferable::ObjectReleased()

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104567

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4830

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104830] Crash when exiting Writer after copying to clipboard

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104830

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||qui...@gmail.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4567,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3852

--- Comment #6 from Aron Budea  ---
The crash originated from the commit referenced below. Adding Cc: to Tomaž
Vajngerl, please take a look.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c53cf1dfc5eacd8fee6b2b549ec6b59ad927e01c
author  Tomaž Vajngerl  2016-11-23
16:01:46 (GMT)
committer   Tomaž Vajngerl    2016-11-24 14:26:30
(GMT)

"tdf#103852 avoid clipboard deadlock"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104830] Crash when exiting Writer after copying to clipboard

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104830

--- Comment #5 from Aron Budea  ---
e06c68b74e0c470815a67a3c784224d86ff9b85c is the first bad commit
commit e06c68b74e0c470815a67a3c784224d86ff9b85c
Author: Norbert Thiebaud 
Date:   Thu Nov 24 11:30:51 2016 -0800

source sha:c53cf1dfc5eacd8fee6b2b549ec6b59ad927e01c

# bad: [2644da24d79bd49ca52f94d8799d66da01b593cc] source
sha:987984ea21f1688eddfc124292f5e4b931d7d138
# good: [defb73f1c6e2a66dbd21ba89e684f57427e8bc4b] source
sha:5b168b3fa568e48e795234dc5fa454bf24c9805e
git bisect start '2644da2' 'oldest'
# good: [5f5e62d1edbaa85687cf957b5b530430ed7d2f58] source
sha:c06d77c5eb57c1a7f5692028b6b04132593f9156
git bisect good 5f5e62d1edbaa85687cf957b5b530430ed7d2f58
# good: [994dfbbdc4c80877a481cd02f9bce55304abc548] source
sha:92874f2f134d28b77163a21ff5d04c5234ca65b2
git bisect good 994dfbbdc4c80877a481cd02f9bce55304abc548
# good: [44f8772012ab3ec823fa9b61458aebd90213b01f] source
sha:a8aab44d75e4704327b4330b532883b59380b7d3
git bisect good 44f8772012ab3ec823fa9b61458aebd90213b01f
# good: [d548ebaa1251592c48a90027c1a988c0724b0dda] source
sha:8c12f8145388a586536b874359ad0bae37ffcc3b
git bisect good d548ebaa1251592c48a90027c1a988c0724b0dda
# good: [1eca8d755f89598c3c08d30303dc19008fdd2fba] source
sha:c80c6b5694bd14367e898f659e82013167fc7d97
git bisect good 1eca8d755f89598c3c08d30303dc19008fdd2fba
# bad: [da22ce871d82bc6a5dba828f1a19f75000681a8e] source
sha:c100e38b49512512b11a0c594f244a4937bc6d66
git bisect bad da22ce871d82bc6a5dba828f1a19f75000681a8e
# good: [7153eebbd8d1b13a9d9e62d826b5131e0eaec1ea] source
sha:4ebf1ea7cb66fc3e6b94cd38dd233aaead69f3d5
git bisect good 7153eebbd8d1b13a9d9e62d826b5131e0eaec1ea
# good: [9d823f3d5f0728c3d28dd93f80bef40a104e89ee] source
sha:2ad50c9a8c8411a57bbbd7a52734e72ffc4cc0ee
git bisect good 9d823f3d5f0728c3d28dd93f80bef40a104e89ee
# good: [8ca54bb56577903b3f715bdf08fb529611d865cb] source
sha:f69b1497f9c34562c949b2068b06ad33a3474da7
git bisect good 8ca54bb56577903b3f715bdf08fb529611d865cb
# good: [9a588433f4952ff769083c43b09d5e3f93668d31] source
sha:62e7c29476dc1f3f8d7c784209d3aa4f362dd116
git bisect good 9a588433f4952ff769083c43b09d5e3f93668d31
# good: [b48c279e6688492d60e8576a3019cd026d89d1f0] source
sha:af251ffb32e079efaadb3c787a41040fcd983fe0
git bisect good b48c279e6688492d60e8576a3019cd026d89d1f0
# good: [f2c1df4e70c54ce4ab134976530c7f93b84d6500] source
sha:93154946452fdedad9b8b536ec3d9704a4707304
git bisect good f2c1df4e70c54ce4ab134976530c7f93b84d6500
# bad: [e06c68b74e0c470815a67a3c784224d86ff9b85c] source
sha:c53cf1dfc5eacd8fee6b2b549ec6b59ad927e01c
git bisect bad e06c68b74e0c470815a67a3c784224d86ff9b85c
# first bad commit: [e06c68b74e0c470815a67a3c784224d86ff9b85c] source
sha:c53cf1dfc5eacd8fee6b2b549ec6b59ad927e01c

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

How to retrieve a backtrace when there's no stack (case tdf#105182)

2017-01-08 Thread julien2412

Hello,

I wanted to give a try to tdf#105182 but the popup error seems to prevent
from having a stacktrace.
Is it possible to disable manually this popup mechanism?
Indeed, in the quoted bugtracker, we know there's something with a vector
but don't know which file or which method.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/How-to-retrieve-a-backtrace-when-there-s-no-stack-case-tdf-105182-tp4204718.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-ux-advise] [Bug 103677] Installer image has low colour for today's standards

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103677

--- Comment #15 from Commit Notification 
 ---
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=00da8be9348cc8c4d0b5344ee58f1be37fa14165

Revert "tdf#103677 Icons Change"

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 103677] Installer image has low colour for today's standards

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103677

--- Comment #15 from Commit Notification 
 ---
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=00da8be9348cc8c4d0b5344ee58f1be37fa14165

Revert "tdf#103677 Icons Change"

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - cui/Library_cui.mk RepositoryFixes.mk

2017-01-08 Thread Damjan Jovanovic

 RepositoryFixes.mk |   26 +-
 cui/Library_cui.mk |5 -
 2 files changed, 25 insertions(+), 6 deletions(-)

New commits:
commit 21f210aaf26636e2c258cdd52478d1a6d925f921
Author: Damjan Jovanovic 
Date:   Sun Jan 8 19:57:08 2017 +

Fix a Windows naming clash between main/cui, whose library, icuin.lib,

was clashing with main/icu's icuin.lib once we started using gbuild,
which places libraries in a common directory. The main/cui library is
now just icui.lib, and main/icu's is still icuin.lib.

Also update RepositoryFixes.mk with all the main/icu libraries.

Patch by: me

diff --git a/RepositoryFixes.mk b/RepositoryFixes.mk
index 17873dd..a59ab76 100644
--- a/RepositoryFixes.mk
+++ b/RepositoryFixes.mk
@@ -70,7 +70,6 @@ ifeq ($(OS),WNT)
 ifneq ($(USE_MINGW),)
 
 gb_Library_FILENAMES := $(patsubst 
comphelper:icomphelper%,comphelper:icomphelp%,$(gb_Library_FILENAMES))
-gb_Library_FILENAMES := $(patsubst 
cui:icui%,cui:icuin%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
i18nisolang1:ii18nisolang1%,i18nisolang1:ii18nisolang%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
i18nisolang1:iii18nisolang1%,i18nisolang1:iii18nisolang%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst sb:isb%,sb:basic%,$(gb_Library_FILENAMES))
@@ -93,7 +92,10 @@ gb_Library_FILENAMES := $(patsubst 
stl:istl%,stl:msvcprt%,$(gb_Library_FILENAMES
 # all other libraries built by OOo and all platform libraries (exceptions see 
below) are used without an import library
 # we link against their dlls in gcc format directly
 gb_Library_NOILIBFILENAMES:=\
+icudt \
+icuin \
 icule \
+icutu \
 icuuc \
 uwinapi \
 winmm \
@@ -112,7 +114,10 @@ gb_Library_DLLFILENAMES := $(filter-out $(foreach 
lib,$(gb_Library_ILIBFILENAMES
 gb_Library_DLLFILENAMES += $(foreach 
lib,$(gb_Library_ILIBFILENAMES),$(lib):$(PSDK_HOME)/lib/$(lib)$(gb_Library_ILIBEXT))
 
 gb_Library_DLLFILENAMES := $(patsubst 
comphelper:comphelper%,comphelper:comphelp%,$(gb_Library_DLLFILENAMES))
+gb_Library_DLLFILENAMES := $(patsubst 
icudt:icudt%,icudt:icudt40%,$(gb_Library_DLLFILENAMES))
+gb_Library_DLLFILENAMES := $(patsubst 
icuin:icuin%,icuin:icuin40%,$(gb_Library_DLLFILENAMES))
 gb_Library_DLLFILENAMES := $(patsubst 
icule:icule%,icule:icule40%,$(gb_Library_DLLFILENAMES))
+gb_Library_DLLFILENAMES := $(patsubst 
icutu:icutu%,icutu:icutu40%,$(gb_Library_DLLFILENAMES))
 gb_Library_DLLFILENAMES := $(patsubst 
icuuc:icuuc%,icuuc:icuuc40%,$(gb_Library_DLLFILENAMES))
 gb_Library_DLLFILENAMES := $(patsubst 
jvmaccess:jvmaccess%,jvmaccess:jvmaccess$(gb_Library_MAJORVER)%,$(gb_Library_DLLFILENAMES))
 gb_Library_DLLFILENAMES := $(patsubst z:z%,z:zlib%,$(gb_Library_DLLFILENAMES))
@@ -123,7 +128,6 @@ gb_Library_TARGETS := $(filter-out 
stl,$(gb_Library_TARGETS))
 else #ifneq ($(USE_MINGW),)
 
 gb_Library_FILENAMES := $(patsubst 
comphelper:icomphelper%,comphelper:icomphelp%,$(gb_Library_FILENAMES))
-gb_Library_FILENAMES := $(patsubst 
cui:icui%,cui:icuin%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
i18nisolang1:ii18nisolang1%,i18nisolang1:ii18nisolang%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
i18nisolang1:iii18nisolang1%,i18nisolang1:iii18nisolang%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst sb:isb%,sb:basic%,$(gb_Library_FILENAMES))
@@ -143,7 +147,12 @@ gb_Library_FILENAMES := $(patsubst 
stl:istl%,stl:msvcprt%,$(gb_Library_FILENAMES
 
 # change the names of all import libraries that don't have an "i" prefix as in 
our standard naming schema
 gb_Library_NOILIBFILENAMES := $(gb_Library_PLAINLIBS_NONE)
-gb_Library_NOILIBFILENAMES += icuuc icule
+gb_Library_NOILIBFILENAMES += \
+icudt \
+icuin \
+icule \
+icutu \
+icuuc
 
 gb_Library_FILENAMES := $(filter-out $(foreach 
lib,$(gb_Library_NOILIBFILENAMES),$(lib):%),$(gb_Library_FILENAMES))
 gb_Library_FILENAMES += $(foreach 
lib,$(gb_Library_NOILIBFILENAMES),$(lib):$(lib)$(gb_Library_PLAINEXT))
@@ -154,6 +163,10 @@ gb_Library_FILENAMES := $(patsubst 
z:z%,z:zlib%,$(gb_Library_FILENAMES))
 #endif
 
 gb_Library_DLLFILENAMES := $(patsubst 
comphelper:comphelper%,comphelper:comphelp%,$(gb_Library_DLLFILENAMES))
+gb_Library_DLLFILENAMES := $(patsubst 
icudt:icudt%,icudt:icudt40%,$(gb_Library_DLLFILENAMES))
+gb_Library_DLLFILENAMES := $(patsubst 
icuin:icuin%,icuin:icuin40%,$(gb_Library_DLLFILENAMES))
+gb_Library_DLLFILENAMES := $(patsubst 
icule:icule%,icule:icule40%,$(gb_Library_DLLFILENAMES))
+gb_Library_DLLFILENAMES := $(patsubst 
icutu:icutu%,icutu:icutu40%,$(gb_Library_DLLFILENAMES))
 gb_Library_DLLFILENAMES := $(patsubst 
icuuc:icuuc%,icuuc:icuuc40%,$(gb_Library_DLLFILENAMES))
 gb_Library_DLLFILENAMES := $(patsubst z:z%,z:zlib%,$(gb_Library_DLLFILENAMES))
 
@@ -200,8 +213,11 @@ gb_Library_DLLFILENAMES := $(patsubst 
sfx:test_sfx2_metadatable%,sfx:tstsfx2m%,$
 
 gb_Library_NOILIBFILENAMES:=\
 ft2lib \
-icuuc \

[Libreoffice-commits] core.git: instsetoo_native/inc_common

2017-01-08 Thread Heiko Tietze

 instsetoo_native/inc_common/windows/msi_templates/Binary/setup.ico |binary
 1 file changed

New commits:
commit 00da8be9348cc8c4d0b5344ee58f1be37fa14165
Author: Heiko Tietze 
Date:   Thu Jan 5 12:22:52 2017 +

Revert "tdf#103677 Icons Change"

This reverts commit 1cb1cc30b5eb75483b6aaeec0192f7ee1d833461.

Setup.ico contains of three different image sizes. Furthermore, the design 
is not applied to the other setup icons (partial, complete). And please discuss 
proposal first.

Change-Id: I3cc9ad3424f85c812ae89939cabaddf38e3c41b3
Reviewed-on: https://gerrit.libreoffice.org/32751
Tested-by: Jenkins 
Reviewed-by: Heiko Tietze 

diff --git a/instsetoo_native/inc_common/windows/msi_templates/Binary/setup.ico 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/setup.ico
index 29b0e61..3580448 100644
Binary files 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/setup.ico and 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/setup.ico differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: 2 commits - source/text

2017-01-08 Thread Gabor Kelemen

 source/text/shared/explorer/database/dabawiz02spreadsheet.xhp |7 ---
 source/text/shared/explorer/database/dabawiz03auth.xhp|4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

New commits:
commit 6d0450c494e5d21fd79940ee9863353ecd70db50
Author: Gabor Kelemen 
Date:   Sat Jan 7 17:48:56 2017 +0100

Fix bookmarks on DB Wizard 'Spreadsheet connection' page

Sync the page title with the wizard page name too

Change-Id: I6cdbdea2325b914e61d8ab744cb489d14867d6bc
Reviewed-on: https://gerrit.libreoffice.org/32834
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/source/text/shared/explorer/database/dabawiz02spreadsheet.xhp 
b/source/text/shared/explorer/database/dabawiz02spreadsheet.xhp
index f61e61c..885eae5 100644
--- a/source/text/shared/explorer/database/dabawiz02spreadsheet.xhp
+++ b/source/text/shared/explorer/database/dabawiz02spreadsheet.xhp
@@ -27,11 +27,12 @@
 
 
 ** Expression is faulty **
-Spreadsheet Database Connection
-
+
+Set up Spreadsheet connection
+
 Location and file name
 Enter the path and file name to the spreadsheet 
file.
-
+
 Browse
 Click to open a file selection 
dialog.
 
commit 91536d63eed45ee12789d22b15cbfaf79135789f
Author: Gabor Kelemen 
Date:   Sat Jan 7 17:47:01 2017 +0100

Sync DB Wizard 'Authentication' page title with the UI

Change-Id: I8d00541d0d1a73cc174396a4b1c7d8a0b3c01bd6
Reviewed-on: https://gerrit.libreoffice.org/32833
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/source/text/shared/explorer/database/dabawiz03auth.xhp 
b/source/text/shared/explorer/database/dabawiz03auth.xhp
index db0b467..dc95a50 100644
--- a/source/text/shared/explorer/database/dabawiz03auth.xhp
+++ b/source/text/shared/explorer/database/dabawiz03auth.xhp
@@ -23,7 +23,7 @@
 
 
 
-Authentication
+Set up user authentication
 /text/shared/explorer/database/dabawiz03auth.xhp
 
 
@@ -31,7 +31,7 @@
 
 
 
-Authentication
+Set up user authentication
 Some 
databases require a user name and password.
 
 User name
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

2017-01-08 Thread Gabor Kelemen

 source/text/shared/explorer/database/dabawiz02text.xhp |   33 -
 1 file changed, 17 insertions(+), 16 deletions(-)

New commits:
commit fce5517eb405ef8288d4d421259716d99b817eb1
Author: Gabor Kelemen 
Date:   Sat Jan 7 18:43:03 2017 +0100

Fix bookmarks on DB Wizard 'Text file connection' page

Change-Id: I6c2881bf4e33cc9f50417c685bb7c74897ac7bb3
Reviewed-on: https://gerrit.libreoffice.org/32835
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/source/text/shared/explorer/database/dabawiz02text.xhp 
b/source/text/shared/explorer/database/dabawiz02text.xhp
index 07c0b1c..0570558 100644
--- a/source/text/shared/explorer/database/dabawiz02text.xhp
+++ b/source/text/shared/explorer/database/dabawiz02text.xhp
@@ -32,38 +32,39 @@
 
 tables in databases;importing text formats 
(Base)
 text databases (Base)
-mw changed "database tables;" to "tables in 
databases;"
-Text File Connection
+
+
+Set up a connection to text files
 Specifies the settings for importing a database in 
text format.UFI: most text copied without editing from 
shared\explorer\database\1104
 In a 
text format database, data is stored in an unformatted ASCII file, where each 
record comprises a row. The data fields are divided by separators. Text in the 
data fields is divided by quotation marks.
-
+
 Path to text files
 Enter the path to the text file or files. If you just 
want one text file, you can use any extension of the file name. If you enter a 
folder name, the text files in that folder must have the extension *.csv to be 
recognized as files of the text database.
-
+
 Browse
 Click to open a file selection 
dialog.
-
+
 Plain text files (*.txt)
 Click to access txt files.UFI: 
sorry, this is not in the spec.
-
+
 'Comma separated value' files (*.csv)
 Click to access csv files.
-
-
+
+
 Custom
 Click to access custom files. Enter the extension in 
the text box.
-
+
 Field separator
-Enter or select the 
character that separates data fields in the text file.
-
+Enter or select the character that separates data 
fields in the text file.
+
 Text separator
-Enter or select the 
character that identifies a text field in the text file. You cannot use 
the same character as the field separator.
-
+Enter or select the character that identifies a text 
field in the text file. You cannot use the same character as the field 
separator.
+
 Decimal separator
-Enter or select the 
character that is used as a decimal separator in the text file, for example, a 
period (0.5) or a comma (0,5).
-
+Enter or select the character that is used as a 
decimal separator in the text file, for example, a period (0.5) or a comma 
(0,5).
+
 Thousands separator
-Enter or select the 
character that is used as a thousands separator in the text file, for example a 
comma (1,000), or a period (1.000).
+Enter or select the character that is used as a 
thousands separator in the text file, for example a comma (1,000), or a period 
(1.000).
 Database 
Wizard
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2017-01-08 Thread Gabor Kelemen

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8320083d2299cc48e3ec92f44e387d69765f431f
Author: Gabor Kelemen 
Date:   Sat Jan 7 17:47:01 2017 +0100

Updated core
Project: help  91536d63eed45ee12789d22b15cbfaf79135789f

Sync DB Wizard 'Authentication' page title with the UI

Change-Id: I8d00541d0d1a73cc174396a4b1c7d8a0b3c01bd6
Reviewed-on: https://gerrit.libreoffice.org/32833
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/helpcontent2 b/helpcontent2
index fe71a0d..91536d6 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit fe71a0de7fa240513f58a6993d02016f1774728f
+Subproject commit 91536d63eed45ee12789d22b15cbfaf79135789f
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - helpcontent2

2017-01-08 Thread Gabor Kelemen

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 61a79f39d890e547377f1d39cd6596a9971405af
Author: Gabor Kelemen 
Date:   Sat Jan 7 18:43:03 2017 +0100

Updated core
Project: help  fce5517eb405ef8288d4d421259716d99b817eb1

Fix bookmarks on DB Wizard 'Text file connection' page

Change-Id: I6c2881bf4e33cc9f50417c685bb7c74897ac7bb3
Reviewed-on: https://gerrit.libreoffice.org/32835
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/helpcontent2 b/helpcontent2
index 6d0450c..fce5517 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 6d0450c494e5d21fd79940ee9863353ecd70db50
+Subproject commit fce5517eb405ef8288d4d421259716d99b817eb1
commit 8033e79467844f7f3d935483932ae10e4d17b827
Author: Gabor Kelemen 
Date:   Sat Jan 7 17:48:56 2017 +0100

Updated core
Project: help  6d0450c494e5d21fd79940ee9863353ecd70db50

Fix bookmarks on DB Wizard 'Spreadsheet connection' page

Sync the page title with the wizard page name too

Change-Id: I6cdbdea2325b914e61d8ab744cb489d14867d6bc
Reviewed-on: https://gerrit.libreoffice.org/32834
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/helpcontent2 b/helpcontent2
index 91536d6..6d0450c 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 91536d63eed45ee12789d22b15cbfaf79135789f
+Subproject commit 6d0450c494e5d21fd79940ee9863353ecd70db50
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

2017-01-08 Thread Gabor Kelemen

 source/text/shared/explorer/database/dabawiz02jdbc.xhp |   17 ++---
 1 file changed, 10 insertions(+), 7 deletions(-)

New commits:
commit fe71a0de7fa240513f58a6993d02016f1774728f
Author: Gabor Kelemen 
Date:   Sat Jan 7 15:51:51 2017 +0100

Fix bookmarks and ahelps on DB Wizard JDBC page

Change-Id: Id50171d63cadec967d31100dca940902f2a40029
Reviewed-on: https://gerrit.libreoffice.org/32832
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/source/text/shared/explorer/database/dabawiz02jdbc.xhp 
b/source/text/shared/explorer/database/dabawiz02jdbc.xhp
index 149de2a..2e8377d 100644
--- a/source/text/shared/explorer/database/dabawiz02jdbc.xhp
+++ b/source/text/shared/explorer/database/dabawiz02jdbc.xhp
@@ -31,7 +31,9 @@
 
 JDBC; databases (Base)
 databases; JDBC (Base)
-mw copied 2 index entries from 
shared/explorer/database/.xhpJDBC 
Connection
+
+
+JDBC Connection
 
 Specifies the options to access a JDBC 
database.copied text from 
shared\explorer\database\
 JDBC Examples
@@ -73,18 +75,19 @@
 database_name is the name of the database.
 
 
-
+
 Data source URL
-Enter the URL for the 
database. For example, for the MySQL JDBC driver, enter 
"jdbc:mysql://Servername/name of the database". For more 
information on the JDBC driver, consult the documentation that came with the 
driver.
+Enter the URL for the database. For example, for the 
MySQL JDBC driver, enter "jdbc:mysql://Servername/name of the 
database". For more information on the JDBC driver, consult the 
documentation that came with the driver.
 
-
-JDBC Driver Class
-Enter the 
name of the JDBC driver.
+
+JDBC Driver Class
+Enter the name of the JDBC driver.
 
 Before you can use a JDBC driver, you need to add its class path. 
Choose %PRODUCTNAME - 
PreferencesTools - 
Options - %PRODUCTNAME
 - Advanced, and click the Class Path button. After 
you add the path information, restart %PRODUCTNAME.
 
-Test ClassUFI: may be Test 
Connection - both strings are in spec
+
+Test 
Class
 Tests the connection with the current 
settings.
 Authentication
 Database 
Wizard
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2017-01-08 Thread Gabor Kelemen

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 14e9c0f69085de49754e2e687fe9c9c789a84617
Author: Gabor Kelemen 
Date:   Sat Jan 7 15:51:51 2017 +0100

Updated core
Project: help  fe71a0de7fa240513f58a6993d02016f1774728f

Fix bookmarks and ahelps on DB Wizard JDBC page

Change-Id: Id50171d63cadec967d31100dca940902f2a40029
Reviewed-on: https://gerrit.libreoffice.org/32832
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/helpcontent2 b/helpcontent2
index 9ce74ce..fe71a0d 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 9ce74cec5a7f95ac442c9caa22aa16839d807581
+Subproject commit fe71a0de7fa240513f58a6993d02016f1774728f
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105014] Crash when Click "Add Separator" in Customize Toolbox / Crash in: SvxConfigPage::InsertEntry(SvxConfigEntry , SvTreeListEntry , bool), cuilo.dll

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105014

Maxim Monastirsky  changed:

   What|Removed |Added

   Keywords|wantBacktrace   |regression
 CC||muhammet.k...@pardus.org.tr
   Hardware|x86-64 (AMD64)  |All
 OS|Windows (All)   |All

--- Comment #4 from Maxim Monastirsky  ---
The "Add Separator" button should be disabled when there are no menus to edit,
like how it's disabled in the Toolbars tab. Same applies to the "Add Submenu"
button. This is a regression compared to 5.2, where the single "Modify" button
was correctly disabled.

Adding Muhammet to CC, as he was working on this dialog according to the
release notes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: source/text

2017-01-08 Thread Gabor Kelemen

 source/text/shared/explorer/database/dabawiz02ado.xhp  |6 ++
 source/text/shared/explorer/database/dabawiz03auth.xhp |7 ++-
 2 files changed, 8 insertions(+), 5 deletions(-)

New commits:
commit 9ce74cec5a7f95ac442c9caa22aa16839d807581
Author: Gabor Kelemen 
Date:   Sat Jan 7 14:20:48 2017 +0100

Move bookmarks and ahelps to DB Wizard Auth page

...from the ADO connection page.
Also document the 'Test Connection' button a bit.

Change-Id: I7d5b13baeb8ffb348ffea1c9a991b4498e8f5cc9
Reviewed-on: https://gerrit.libreoffice.org/32831
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/source/text/shared/explorer/database/dabawiz02ado.xhp 
b/source/text/shared/explorer/database/dabawiz02ado.xhp
index e28ea5b..af95710 100644
--- a/source/text/shared/explorer/database/dabawiz02ado.xhp
+++ b/source/text/shared/explorer/database/dabawiz02ado.xhp
@@ -53,10 +53,8 @@
 
 Browse
 Click to open a database selection 
dialog.
-
-A user name can have a maximum of 18 characters.
-
-A password must contain 3 to 18 characters.
+A user 
name can have a maximum of 18 characters.
+A 
password must contain 3 to 18 characters.
 Database 
Wizard
 
 
diff --git a/source/text/shared/explorer/database/dabawiz03auth.xhp 
b/source/text/shared/explorer/database/dabawiz03auth.xhp
index eb5c5d7..db0b467 100644
--- a/source/text/shared/explorer/database/dabawiz03auth.xhp
+++ b/source/text/shared/explorer/database/dabawiz03auth.xhp
@@ -32,11 +32,16 @@
 
 
 Authentication
-Some databases require a user name and 
password.
+Some 
databases require a user name and password.
+
 User name
 Enter the user name to access the 
database.
+
 Password required
 Select to prompt a user for a password to access the 
database.
+
+Test 
Connection
+Check if the configured connection can be used to 
access the database.
 Save and 
proceed
 Database 
Wizard
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2017-01-08 Thread Gabor Kelemen

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ac4eb25a3405c23c5e65a10eaa618dc336fdc01e
Author: Gabor Kelemen 
Date:   Sat Jan 7 14:20:48 2017 +0100

Updated core
Project: help  9ce74cec5a7f95ac442c9caa22aa16839d807581

Move bookmarks and ahelps to DB Wizard Auth page

...from the ADO connection page.
Also document the 'Test Connection' button a bit.

Change-Id: I7d5b13baeb8ffb348ffea1c9a991b4498e8f5cc9
Reviewed-on: https://gerrit.libreoffice.org/32831
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/helpcontent2 b/helpcontent2
index 5e4b205..9ce74ce 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 5e4b205a3259f265e6dddc578d16793c1a733e9e
+Subproject commit 9ce74cec5a7f95ac442c9caa22aa16839d807581
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2017-01-08 Thread Gabor Kelemen

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 47d4fe66495a7b1839958dee6826c83b90044d55
Author: Gabor Kelemen 
Date:   Sat Jan 7 21:56:40 2017 +0100

Updated core
Project: help  5e4b205a3259f265e6dddc578d16793c1a733e9e

tdf#105070 'Compare Document' menu item has moved

From 'Edit' menu to 'Edit - Track Changes' submenu

Change-Id: I02fd05e97f989369bcee5c5ab26fdd78121c2282
Reviewed-on: https://gerrit.libreoffice.org/32836
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/helpcontent2 b/helpcontent2
index 74ab5d9..5e4b205 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 74ab5d9e81c1406229ec3075afadf2b03888f269
+Subproject commit 5e4b205a3259f265e6dddc578d16793c1a733e9e
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

2017-01-08 Thread Gabor Kelemen

 source/text/shared/00/0402.xhp|2 +-
 source/text/shared/guide/redlining_doccompare.xhp |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 5e4b205a3259f265e6dddc578d16793c1a733e9e
Author: Gabor Kelemen 
Date:   Sat Jan 7 21:56:40 2017 +0100

tdf#105070 'Compare Document' menu item has moved

From 'Edit' menu to 'Edit - Track Changes' submenu

Change-Id: I02fd05e97f989369bcee5c5ab26fdd78121c2282
Reviewed-on: https://gerrit.libreoffice.org/32836
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/source/text/shared/00/0402.xhp 
b/source/text/shared/00/0402.xhp
index d075eae..f43dba2 100644
--- a/source/text/shared/00/0402.xhp
+++ b/source/text/shared/00/0402.xhp
@@ -174,7 +174,7 @@
 
 Choose Edit - Track Changes - Merge 
Document
 
-Choose Edit - Compare Document
+Choose Edit - Track Changes - Compare 
Document
 
 
 Choose Edit - Track Changes - Comment on Change
diff --git a/source/text/shared/guide/redlining_doccompare.xhp 
b/source/text/shared/guide/redlining_doccompare.xhp
index eafc9e2..02d8d40 100644
--- a/source/text/shared/guide/redlining_doccompare.xhp
+++ b/source/text/shared/guide/redlining_doccompare.xhp
@@ -44,7 +44,7 @@
 If one of the authors has made changes to a document without 
recording them, you can compare the changed document to your original 
document.
 
 
-Open the reviewer's document and then choose Edit - Compare 
Document.changed workflow, see i72652
+Open the reviewer's document and then choose Edit - Track 
Changes - Compare Document.changed workflow, see 
i72652
 You 
should always start with opening the newer document and compare it with the 
older document.
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105188] Crash when closing LibreOffice after opening Master Pages deck in SfxModule ::GetResMgr()

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105188

Julien Nabet  changed:

   What|Removed |Added

 CC||aptit...@btconnect.com,
   ||noelgran...@gmail.com

--- Comment #3 from Julien Nabet  ---
Mark/Noel: noticing
https://cgit.freedesktop.org/libreoffice/core/commit/?id=f7b1cd66167050afecf487e3d89ea12de74200b5,
thought you might be interested in this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105188] Crash when closing LibreOffice after opening Master Pages deck in SfxModule ::GetResMgr()

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105188

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #2 from Julien Nabet  ---
Created attachment 130267
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130267=edit
bt with symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105197] Images pasted from web show up blank

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105197

--- Comment #1 from Luke  ---
Created attachment 130266
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130266=edit
Comparison Writer vs Word

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105197] New: Images pasted from web show up blank

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105197

Bug ID: 105197
   Summary: Images pasted from web show up blank
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lukebe...@hotmail.com

Created attachment 130265
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130265=edit
Sample paste from CNN news story

Steps to reproduce
1. In Chrome, Navigate to a cnn new story such as:
http://www.cnn.com/2017/01/08/us/fort-lauderdale-airport-shooting-main/index.html
2. Paste in Writer 
3. Paste in Word

In Writer some images show up as blank in both the print preview mode and the
regular editing mode. However when you go 
Properties -> Image
OR
Edit with External tool

The image shows up

So I assume this is not a pasting issue, but a problem with the viewer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105197] Images pasted from web show up blank

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105197

Luke  changed:

   What|Removed |Added

Version|Inherited From OOo  |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105014] Crash when Click "Add Separator" in Customize Toolbox / Crash in: SvxConfigPage::InsertEntry(SvxConfigEntry , SvTreeListEntry , bool), cuilo.dll

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105014

--- Comment #3 from Aron Budea  ---
I could get a backtrace with WinDbg, but am getting errors like this:
*** ERROR: Symbol file could not be found.  Defaulted to export symbols for
E:\LibreOffice\LO_5300beta2\program\mergedlo.dll -

My symbol settings are set up according to the steps here:
https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||5196

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105196] Hanging when trying to create a new gallery or to view properties of a gallery

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105196

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||5017

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105196] New: Hanging when trying to create a new gallery or to view properties of a gallery

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105196

Bug ID: 105196
   Summary: Hanging when trying to create a new gallery or to view
properties of a gallery
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: serval2...@yahoo.fr

Description:
On pc Debian x86-64 with master sources updated today, I got a hang when trying
to create a new gallery or to view properties of an existing one.
Sidebar can be detached or not, same result.
If Ctrl-C to kill LO and restart LO, the new theme has indeed been created.

I found this giving a try to tdf#105017

Steps to Reproduce:
1. Open Writer
2. Click Gallery on Sidebar
3. Click "New Theme..." button


Actual Results:  
Hangs

Expected Results:
shouldn't hang


Reproducible: Always

User Profile Reset: Yes

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Firefox/45.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104967] EDITING Crash in: ScPostIt::CreateCaption(ScAddress const &, SdrCaptionObj const *)

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104967

Telesto  changed:

   What|Removed |Added

Version|5.2.0.4 release |4.3.0.4 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105055] Crash in: ScPostIt::CreateCaption(ScAddress const &, SdrCaptionObj const *)

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105055

Telesto  changed:

   What|Removed |Added

Version|5.3.0.0.alpha0+ |5.3.0.0.alpha1+

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 77115] In the Style dialog of lists/numbering styles, the layout of controls in the "Options" tab is confusing

2017-01-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=77115

--- Comment #6 from Commit Notification 
 ---
heiko tietze committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b791297a0ce1c94031322ac534ba783f6505902

tdf#77115 Layout of options tab of bullet dialog

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

1 2 3 >

1 - 100 of 245 matches

Mail list logo