[Libreoffice-bugs] [Bug 104026] Conditional formatting is not updated when deleting a row

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104026

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
Version|unspecified |5.2.3.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105114] Conditional formatting dialog closes while editing any condition 2nd time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105114

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
   Priority|medium  |high
 CC||ba...@caesar.elte.hu,
   ||markus.mohrhard@googlemail.
   ||com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||453,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0793
   Severity|minor   |normal

--- Comment #5 from Aron Budea  ---
This started with the same commit as bug 105544 (bibisect is in the other bug
report).
Adding Cc: to Markus Mohrhard, please take a look.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5b8c22379e2eae74f7ed78326ab89483db5c6624
author  Markus Mohrhard 2016-09-18
14:14:35 (GMT)
committer   Markus Mohrhard    
2016-09-19 10:10:09 (GMT)

"tdf#96453, tdf#100793 rework transfer of data between cond format dlgs"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105544] Manage Conditional Formatting is not able to edit a condition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105544

Aron Budea  changed:

   What|Removed |Added

 CC||markus.mohrhard@googlemail.
   ||com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||453,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0793

--- Comment #4 from Aron Budea  ---
Bibisect results point to the commit referenced below. Adding Cc: to Markus
Mohrhard, please take a look.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5b8c22379e2eae74f7ed78326ab89483db5c6624
author  Markus Mohrhard 2016-09-18
14:14:35 (GMT)
committer   Markus Mohrhard    
2016-09-19 10:10:09 (GMT)

"tdf#96453, tdf#100793 rework transfer of data between cond format dlgs"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105544] Manage Conditional Formatting is not able to edit a condition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105544

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||ba...@caesar.elte.hu

--- Comment #3 from Aron Budea  ---
e95c186bc83eaea3cf81a731020ce36f7ed4b72b is the first bad commit
commit e95c186bc83eaea3cf81a731020ce36f7ed4b72b
Author: Jenkins Build User 
Date:   Fri Sep 30 08:21:44 2016 +0200

source sha:5b8c22379e2eae74f7ed78326ab89483db5c6624

# bad: [8c41dca5bdcdd16586b77dc014de74f2d17e6bdd] source
sha:843b9d5dba5098c2676491dda66bed31e57f4329
# good: [33e60eae04c889baf52713a73dc9944015408914] source
sha:5b168b3fa568e48e795234dc5fa454bf24c9805e
git bisect start '8c41dca' 'oldest'
# good: [13329e8dde9d4b8befeb35729bdb02c58a4ae324] source
sha:82ce1d2cd27f7d6fe8046a74d0b7d8866b75c458
git bisect good 13329e8dde9d4b8befeb35729bdb02c58a4ae324
# good: [e378c02823765b4028ef4c32245d27b7fad01ef8] source
sha:cc497d86e092315f78a89f3ace8b81623dad7b46
git bisect good e378c02823765b4028ef4c32245d27b7fad01ef8
# good: [64fb5be3c5095b0f89fbd425d982573088005ba4] source
sha:0f2d5db38bac64b665c6e4a127bbbd63a7ed9af5
git bisect good 64fb5be3c5095b0f89fbd425d982573088005ba4
# good: [df2850548fef1cdfaa378ce9771e4d6dbadfbcb8] source
sha:0f33526ec27a3abcfa1ca9348a46238b1432e5e4
git bisect good df2850548fef1cdfaa378ce9771e4d6dbadfbcb8
# bad: [6df02c7e421fb59485173f89bcc87bbf31e6cc33] source
sha:e58324aaca6875dbfe7c6c8333d747d2bfd9d089
git bisect bad 6df02c7e421fb59485173f89bcc87bbf31e6cc33
# good: [9dd6bd752611ef9bef3695856327fb428b1c1c82] source
sha:5fb8a050210a7cabf49daac0da8f80b94d60de2c
git bisect good 9dd6bd752611ef9bef3695856327fb428b1c1c82
# good: [1862f95176b58b1964276d02fbdd71185b78b627] source
sha:55fcc386401bca573a95bfed37a3de687f83884c
git bisect good 1862f95176b58b1964276d02fbdd71185b78b627
# good: [9925564f5043378fe0a6acaf82daff4e45902cce] source
sha:c57e7685f22c4b010a7ddb25fa896f8405e95818
git bisect good 9925564f5043378fe0a6acaf82daff4e45902cce
# good: [04181905938ef308f17ae6fa26d2666317e12ade] source
sha:c9805c52264eb99b3d73f9038da716ac94501502
git bisect good 04181905938ef308f17ae6fa26d2666317e12ade
# bad: [aa995b3c493bf8ee9c46029bdf186d041c2b272a] source
sha:2d31990ad0806e74f92841fb8f87db101e1a8fc3
git bisect bad aa995b3c493bf8ee9c46029bdf186d041c2b272a
# bad: [e95c186bc83eaea3cf81a731020ce36f7ed4b72b] source
sha:5b8c22379e2eae74f7ed78326ab89483db5c6624
git bisect bad e95c186bc83eaea3cf81a731020ce36f7ed4b72b
# good: [f507e34f7463b6f956d09f788178589ca4279d02] source
sha:96646c351e20fa6699fa368457a05ee70f76f103
git bisect good f507e34f7463b6f956d09f788178589ca4279d02
# first bad commit: [e95c186bc83eaea3cf81a731020ce36f7ed4b72b] source
sha:5b8c22379e2eae74f7ed78326ab89483db5c6624

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

New Defects reported by Coverity Scan for LibreOffice

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
13 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1399595:  Uninitialized members  (UNINIT_CTOR)
/xmloff/source/transform/TransformerBase.cxx: 203 in 
XMLTransformerBase::XMLTransformerBase(XMLTransformerActionInit *, 
xmloff::token::XMLTokenEnum *)()



*** CID 1399595:  Uninitialized members  (UNINIT_CTOR)
/xmloff/source/transform/TransformerBase.cxx: 203 in 
XMLTransformerBase::XMLTransformerBase(XMLTransformerActionInit *, 
xmloff::token::XMLTokenEnum *)()
197 GetNamespaceMap().Add( GetXMLToken(XML_NP_DC), 
GetXMLToken(XML_N_DC), XML_NAMESPACE_DC );
198 GetNamespaceMap().Add( GetXMLToken(XML_NP_MATH), 
GetXMLToken(XML_N_MATH), XML_NAMESPACE_MATH );
199 GetNamespaceMap().Add( GetXMLToken(XML_NP_OOO), 
GetXMLToken(XML_N_OOO), XML_NAMESPACE_OOO );
200 GetNamespaceMap().Add( GetXMLToken(XML_NP_DOM), 
GetXMLToken(XML_N_DOM), XML_NAMESPACE_DOM );
201 GetNamespaceMap().Add( GetXMLToken(XML_NP_OOOW), 
GetXMLToken(XML_N_OOOW), XML_NAMESPACE_OOOW );
202 GetNamespaceMap().Add( GetXMLToken(XML_NP_OOOC), 
GetXMLToken(XML_N_OOOC), XML_NAMESPACE_OOOC );
>>> CID 1399595:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member "nElement" is not initialized in this 
>>> constructor nor in any functions that it calls.
203 }
204 
205 XMLTransformerBase::~XMLTransformerBase() throw ()
206 {
207 delete m_pNamespaceMap;
208 delete m_pReplaceNamespaceMap;

** CID 1399594:  Null pointer dereferences  (FORWARD_NULL)
/xmloff/source/transform/TransformerBase.cxx: 428 in 
XMLTransformerBase::initialize(const 
com::sun::star::uno::Sequence &)()



*** CID 1399594:  Null pointer dereferences  (FORWARD_NULL)
/xmloff/source/transform/TransformerBase.cxx: 428 in 
XMLTransformerBase::initialize(const 
com::sun::star::uno::Sequence &)()
422 // document handler
423 if( cppu::UnoType::get().isAssignableFrom( 
pAny->getValueType() ) )
424 {
425 m_xHandler.set( *pAny, UNO_QUERY );
426 m_xFastHandler.set( m_xHandler.get(), UNO_QUERY );
427 if ( (dynamic_cast< SvXMLImport* >( m_xFastHandler.get() ) 
) )
>>> CID 1399594:  Null pointer dereferences  (FORWARD_NULL)
>>> Dynamic cast to pointer "dynamic_cast >> *>(this->m_xFastHandler.get())" can return "NULL".
428 m_xNamespaceHandler = (dynamic_cast< SvXMLImport* >( 
m_xFastHandler.get() ) )->getNamespaceHandler();
429 }
430 
431 // property set to transport data across
432 if( cppu::UnoType::get().isAssignableFrom( 
pAny->getValueType() ) )
433 m_xPropSet.set( *pAny, UNO_QUERY );



To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyt6jkx5vgVkh4k58ar9FnWKdxW0KceaCQDx3faqXLAhDWqlOunD4HebNZ-2BglZiGywBByk980mtBi0U8Kt6fWVhw0DBDfUP7ew6ZU82WoN28AEHErcJwU9FXQkij3moGVaMg-2Fyxn0yzJQaTVA98UmCJymgF3kOaXKmdiRDGxnM77M-3D

To manage Coverity Scan email notifications for 
"libreoffice@lists.freedesktop.org", click 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyt6jkx5vgVkh4k58ar9FnWD5ZbNQW4wAf-2FUctjXiK-2FHatwXDAglAzJvU9j-2FwX7pb8YwnDLTPEiMpk904QQ5Y-2BPXDaLXyIpka-2BAo6zfBUem-2BQ4O2S-2BAXsFmGn-2FtUwTljxJQLij-2BeOFDkS7ukaipiU5P3SUV1eUKOUuMJKZpvzUmFU-3D

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 51358] SVG: Add support for more slide transitions to svg documents exported by Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51358

--- Comment #14 from Commit Notification 
 ---
Rohan Kumar committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e901f86511bd773c1b80f5aebe435f29527e118

tdf#51358 Support for SnakeWipe transition animation in SVG support

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source

[Rohan Kumar]

 filter/source/svg/presentation_engine.js |  282 ++-
 1 file changed, 281 insertions(+), 1 deletion(-)

New commits:
commit 6e901f86511bd773c1b80f5aebe435f29527e118
Author: Rohan Kumar 
Date:   Tue Jan 24 01:40:55 2017 +0530

tdf#51358 Support for SnakeWipe transition animation in SVG support

ported the class SnakeWipe.

Change-Id: Icb41072bbd276e0edf3ef2ecea6148c81110b53e
Reviewed-on: https://gerrit.libreoffice.org/23285
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/filter/source/svg/presentation_engine.js 
b/filter/source/svg/presentation_engine.js
index 14017ab..a4f0288 100644
--- a/filter/source/svg/presentation_engine.js
+++ b/filter/source/svg/presentation_engine.js
@@ -4572,6 +4572,12 @@ SVGPathElement.prototype.appendPath = function( aPath )
 this.setAttribute( 'd', sPathData );
 };
 
+function flipOnYAxis( aPath )
+{
+var aMatrix = SVGIdentityMatrix.scaleNonUniform(-1, 1).translate(1, 0);
+aPath.matrixTransform(aMatrix);
+return aPath;
+}
 /** SVGPathElement.matrixTransform
  *  Apply the transformation defined by the passed matrix to the referenced
  *  svg  element.
@@ -5160,6 +5166,7 @@ FADE_TRANSITION = 9; // 37
 RANDOMBARWIPE_TRANSITION= 10; // 38
 CHECKERBOARDWIPE_TRANSITION = 11; // 39
 DISSOLVE_TRANSITION = 12; // 40
+SNAKEWIPE_TRANSITION= 13; // 30
 IRISWIPE_TRANSITION = 14; // 12
 
 aTransitionTypeInMap = {
@@ -5175,6 +5182,7 @@ aTransitionTypeInMap = {
 'randomBarWipe' : RANDOMBARWIPE_TRANSITION,
 'checkerBoardWipe'  : CHECKERBOARDWIPE_TRANSITION,
 'dissolve'  : DISSOLVE_TRANSITION,
+'snakeWipe' : SNAKEWIPE_TRANSITION,
 'irisWipe'  : IRISWIPE_TRANSITION
 };
 
@@ -5212,6 +5220,12 @@ THREEBLADE_TRANS_SUBTYPE= 24;
 EIGHTBLADE_TRANS_SUBTYPE= 25;
 ONEBLADE_TRANS_SUBTYPE  = 26; // 107
 ACROSS_TRANS_SUBTYPE= 27;
+TOPLEFTVERTICAL_TRANS_SUBTYPE   = 28; // 109
+TOPLEFTHORIZONTAL_TRANS_SUBTYPE = 29; // 64
+TOPLEFTDIAGONAL_TRANS_SUBTYPE   = 30; // 65
+TOPRIGHTDIAGONAL_TRANS_SUBTYPE  = 31; // 66
+BOTTOMRIGHTDIAGONAL_TRANS_SUBTYPE   = 32; // 67
+BOTTOMLEFTDIAGONAL_TRANS_SUBTYPE= 33; // 68
 RECTANGLE_TRANS_SUBTYPE = 34; // 101
 DIAMOND_TRANS_SUBTYPE   = 35; // 102
 TOPLEFT_TRANS_SUBTYPE   = 36  // 3
@@ -5223,7 +5237,6 @@ RIGHTCENTER_TRANS_SUBTYPE   = 41; // 8
 BOTTOMCENTER_TRANS_SUBTYPE  = 42; // 9
 LEFTCENTER_TRANS_SUBTYPE= 43; // 10
 
-
 aTransitionSubtypeInMap = {
 'default'   : DEFAULT_TRANS_SUBTYPE,
 'leftToRight'   : LEFTTORIGHT_TRANS_SUBTYPE,
@@ -5253,6 +5266,12 @@ aTransitionSubtypeInMap = {
 'eightBlade': EIGHTBLADE_TRANS_SUBTYPE,
 'oneBlade'  : ONEBLADE_TRANS_SUBTYPE,
 'across': ACROSS_TRANS_SUBTYPE,
+'topLeftVertical'   : TOPLEFTVERTICAL_TRANS_SUBTYPE,
+'topLeftHorizontal' : TOPLEFTHORIZONTAL_TRANS_SUBTYPE,
+'topLeftDiagonal'   : TOPLEFTDIAGONAL_TRANS_SUBTYPE,
+'topRightDiagonal'  : TOPRIGHTDIAGONAL_TRANS_SUBTYPE,
+'bottomRightDiagonal': BOTTOMRIGHTDIAGONAL_TRANS_SUBTYPE,
+'bottomLeftDiagonal': BOTTOMLEFTDIAGONAL_TRANS_SUBTYPE,
 'rectangle' : RECTANGLE_TRANS_SUBTYPE,
 'diamond'   : DIAMOND_TRANS_SUBTYPE,
 'topLeft'   : TOPLEFT_TRANS_SUBTYPE,
@@ -5314,6 +5333,68 @@ aTransitionInfoTable[0][0] =
 'scaleIsotropically' : false
 };
 
+aTransitionInfoTable[SNAKEWIPE_TRANSITION] = {};
+aTransitionInfoTable[SNAKEWIPE_TRANSITION][TOPLEFTVERTICAL_TRANS_SUBTYPE] =
+{
+'class' : TRANSITION_CLIP_POLYPOLYGON,
+'rotationAngle' : -90.0,
+'scaleX' : 1.0,
+'scaleY' : 1.0,
+'reverseMethod' : REVERSEMETHOD_ROTATE_180,
+'outInvertsSweep' : true,
+'scaleIsotropically' : false
+};
+aTransitionInfoTable[SNAKEWIPE_TRANSITION][TOPLEFTHORIZONTAL_TRANS_SUBTYPE] =
+{
+'class' : TRANSITION_CLIP_POLYPOLYGON,
+'rotationAngle' : 0.0,
+'scaleX' : 1.0,
+'scaleY' : 1.0,
+'reverseMethod' : REVERSEMETHOD_ROTATE_180,
+'outInvertSweep' : true,
+'scaleIsotropically' : false
+};
+aTransitionInfoTable[SNAKEWIPE_TRANSITION][TOPLEFTDIAGONAL_TRANS_SUBTYPE] =
+{
+'class' : TRANSITION_CLIP_POLYPOLYGON,
+'rotationAngle' : 0.0,
+'scaleX' : 1.0,
+'scaleY' : 1.0,
+'reverseMethod' : REVERSEMETHOD_ROTATE_180,
+'outInvertSweep' : true,
+'scaleIsotropically' : false
+};
+aTransitionInfoTable[SNAKEWIPE_TRANSITION][TOPRIGHTDIAGONAL_TRANS_SUBTYPE] =
+{
+'class' : TRANSITION_CLIP_POLYPOLYGON,
+'rotationAngle' : 0.0,
+'scaleX' : 1.0,
+'scaleY' : 1.0,
+'reverseMethod' : REVERSEMETHOD_ROTATE_180,
+'outInvertSweep' : true,
+'scaleIsotropically' : false
+};
+aTransitionInfoTable[SNAKEWIPE_TRANSITION][BOTTOMRIGHTDIAGONAL_TRANS_SUBTYPE] =

[Libreoffice-bugs] [Bug 104244] EDITING: current cell not indicated in calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104244

Buovjaga  changed:

   What|Removed |Added

 CC||hamidrjaf...@gmail.com

--- Comment #8 from Buovjaga  ---
JPJ and Hamid: please give us the output of the command:
lshw -C display

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99705] Active cell not highlighted / bordered when OpenGL is disabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99705

Buovjaga  changed:

   What|Removed |Added

 CC||aziz.azi...@hotmail.com

--- Comment #12 from Buovjaga  ---
(In reply to Abdellatif from comment #11)
> I confirm this issue on Ubuntu 16.10 for LibreOffice Calc 5.2.5.1 ...

Let's continue in bug 104244 as it seems appropriate for the ones who still
have problems.

I have to say that it is a real problem that these errors appear with
modesetting as many distros are switching to it. Intel is failing to release a
stable version of their driver, so it is painful for distros to package.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79069] Table edit undo failure.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79069

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:docx
 CC||ba...@caesar.elte.hu
 Blocks||10
 Whiteboard||interoperability

--- Comment #5 from Aron Budea  ---
Still repro, 5.3.0.3 / Ubuntu 16.04.

Additionally, when the docx is opened, this is shown in the console 4 times:
E: lt_string_value: assertion `string != ((void *)0)' failed


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=10
[Bug 10] [META] DOCX table related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104444] [META] DOCX table related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=10

Aron Budea  changed:

   What|Removed |Added

 Depends on||79069


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=79069
[Bug 79069] Table edit undo failure.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105579] New: After certain actions comments in Calc point to the wrong cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105579

Bug ID: 105579
   Summary: After certain actions comments in Calc point to the
wrong cell
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu

Created attachment 130732
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130732=edit
Spreadsheet with steps 1-4

1. Start a new Calc spreadsheet.
2. Resize a row, let's say row 9.
3. Insert a comment for a cell below that row, let's say D10.
4. Right click cell, select Show Comment.

Attaching a spreasheet with the steps so far.

5. Resize the same row as before (row 9) to around its original size.
6. Move the comment a large distance, quickly. Or move it to the right, and
with another move, move it back to left.

=> The comment's arrow now points to top left corner of the sheet. Or maybe
just somewhere else in the sheet, like around its original place, but not the
cell it's supposed to. What happens is not entirely consistent for me...

If it can't be confirmed easily, I'll try to create a screencast.

Observed with 5.3.0.3, 4.0.0.3, 3.3.0 / Ubuntu 16.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105414] Blank cells formatted as numbers not treated as ZERO when pulled via VLOOKUP to external file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105414

Aron Budea  changed:

   What|Removed |Added

 Status|REOPENED|UNCONFIRMED
 CC||ba...@caesar.elte.hu
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105118] Impress table cells use way too many GDI objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105118

--- Comment #4 from mdk...@hotmail.com ---
I tried installing
daily/master/Win-x86@42/current/libo-master~2017-01-26_01.50.40_LibreOfficeDev_5.4.0.0.alpha0_Win_x86.msi,
but it says it needs Vista or later, which I don't have.  Can someone please
advise whether there's a build containing this fix suitable for 32-bit XP? 
Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96477] vlookup array selection with mouse hanged Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96477

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #10 from Aron Budea  ---
Ari, did you get a chance to check with an updated version/system?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-5-2' - bin/symstore.sh

[Samuel Mehrbrodt]

 bin/symstore.sh |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 1d7f9ebb0daed7276f6f5f4eed5583a4f1186858
Author: Samuel Mehrbrodt 
Date:   Fri Jan 27 16:57:49 2017 +0100

Symstore: Also add .exe and .dlls to symstore

These are needed when analyzing the minidump.

Change-Id: Ife296c298e3b2f1ca8a47dcbaaf1947e6aefdc81
Reviewed-on: https://gerrit.libreoffice.org/33631
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 8a0416be440180d0a6cedd449307f6a9bde22eaa)

diff --git a/bin/symstore.sh b/bin/symstore.sh
index 56260c0..b368eb3 100755
--- a/bin/symstore.sh
+++ b/bin/symstore.sh
@@ -6,13 +6,17 @@ add_pdb()
 type=$2
 list=$3
 for file in $(find "${INSTDIR}/" -name "*.${extension}"); do
+# store dll/exe itself (needed for minidumps)
+if [ -f "$file" ]; then
+cygpath -w "$file" >> "$list"
+fi
+# store pdb file
 filename=$(basename "$file" ".${extension}")
 pdb="${WORKDIR}/LinkTarget/${type}/${filename}.pdb"
 if [ -f "$pdb" ]; then
 cygpath -w "$pdb" >> "$list"
 fi
 done
-
 }
 
 # check preconditions
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-5-1' - bin/symstore.sh

[Samuel Mehrbrodt]

 bin/symstore.sh |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 918078f6222d40a82d571d9833786738a92c3228
Author: Samuel Mehrbrodt 
Date:   Fri Jan 27 16:57:49 2017 +0100

Symstore: Also add .exe and .dlls to symstore

These are needed when analyzing the minidump.

Reviewed-on: https://gerrit.libreoffice.org/33631
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 8a0416be440180d0a6cedd449307f6a9bde22eaa)

Change-Id: Ife296c298e3b2f1ca8a47dcbaaf1947e6aefdc81
(cherry picked from commit cee7cb1b026cc7609f0a11c05b447f8d686a2d54)

diff --git a/bin/symstore.sh b/bin/symstore.sh
index ca5bd30..a81bdd7 100755
--- a/bin/symstore.sh
+++ b/bin/symstore.sh
@@ -6,13 +6,17 @@ add_pdb()
 type=$2
 list=$3
 for file in `find ${INSTDIR}/ -name *.${extension}`; do
+# store dll/exe itself (needed for minidumps)
+if [ -f "$file" ]; then
+cygpath -w "$file" >> "$list"
+fi
+# store pdb file
 filename=`basename $file .${extension}`
 pdb=`echo ${WORKDIR}/LinkTarget/${type}/${filename}.pdb`
 if [ -f "$pdb" ]; then
 echo `cygpath -w $pdb` >>$list
 fi
 done
-
 }
 
 # check preconditions
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-5-0' - bin/symstore.sh

[Samuel Mehrbrodt]

 bin/symstore.sh |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit cee7cb1b026cc7609f0a11c05b447f8d686a2d54
Author: Samuel Mehrbrodt 
Date:   Fri Jan 27 16:57:49 2017 +0100

Symstore: Also add .exe and .dlls to symstore

These are needed when analyzing the minidump.

Reviewed-on: https://gerrit.libreoffice.org/33631
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 8a0416be440180d0a6cedd449307f6a9bde22eaa)

Change-Id: Ife296c298e3b2f1ca8a47dcbaaf1947e6aefdc81

diff --git a/bin/symstore.sh b/bin/symstore.sh
index ca5bd30..a81bdd7 100755
--- a/bin/symstore.sh
+++ b/bin/symstore.sh
@@ -6,13 +6,17 @@ add_pdb()
 type=$2
 list=$3
 for file in `find ${INSTDIR}/ -name *.${extension}`; do
+# store dll/exe itself (needed for minidumps)
+if [ -f "$file" ]; then
+cygpath -w "$file" >> "$list"
+fi
+# store pdb file
 filename=`basename $file .${extension}`
 pdb=`echo ${WORKDIR}/LinkTarget/${type}/${filename}.pdb`
 if [ -f "$pdb" ]; then
 echo `cygpath -w $pdb` >>$list
 fi
 done
-
 }
 
 # check preconditions
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/cib_contract57' - bin/symstore.sh

[Samuel Mehrbrodt]

 bin/symstore.sh |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 125febb78e3146d95f075edc1f86adf41d021c85
Author: Samuel Mehrbrodt 
Date:   Fri Jan 27 16:57:49 2017 +0100

Symstore: Also add .exe and .dlls to symstore

These are needed when analyzing the minidump.

Change-Id: Ife296c298e3b2f1ca8a47dcbaaf1947e6aefdc81
Reviewed-on: https://gerrit.libreoffice.org/33631
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 8a0416be440180d0a6cedd449307f6a9bde22eaa)

diff --git a/bin/symstore.sh b/bin/symstore.sh
index 56260c0..b368eb3 100755
--- a/bin/symstore.sh
+++ b/bin/symstore.sh
@@ -6,13 +6,17 @@ add_pdb()
 type=$2
 list=$3
 for file in $(find "${INSTDIR}/" -name "*.${extension}"); do
+# store dll/exe itself (needed for minidumps)
+if [ -f "$file" ]; then
+cygpath -w "$file" >> "$list"
+fi
+# store pdb file
 filename=$(basename "$file" ".${extension}")
 pdb="${WORKDIR}/LinkTarget/${type}/${filename}.pdb"
 if [ -f "$pdb" ]; then
 cygpath -w "$pdb" >> "$list"
 fi
 done
-
 }
 
 # check preconditions
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: bin/symstore.sh

[Samuel Mehrbrodt]

 bin/symstore.sh |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 8a0416be440180d0a6cedd449307f6a9bde22eaa
Author: Samuel Mehrbrodt 
Date:   Fri Jan 27 16:57:49 2017 +0100

Symstore: Also add .exe and .dlls to symstore

These are needed when analyzing the minidump.

Change-Id: Ife296c298e3b2f1ca8a47dcbaaf1947e6aefdc81
Reviewed-on: https://gerrit.libreoffice.org/33631
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/bin/symstore.sh b/bin/symstore.sh
index 56260c0..b368eb3 100755
--- a/bin/symstore.sh
+++ b/bin/symstore.sh
@@ -6,13 +6,17 @@ add_pdb()
 type=$2
 list=$3
 for file in $(find "${INSTDIR}/" -name "*.${extension}"); do
+# store dll/exe itself (needed for minidumps)
+if [ -f "$file" ]; then
+cygpath -w "$file" >> "$list"
+fi
+# store pdb file
 filename=$(basename "$file" ".${extension}")
 pdb="${WORKDIR}/LinkTarget/${type}/${filename}.pdb"
 if [ -f "$pdb" ]; then
 cygpath -w "$pdb" >> "$list"
 fi
 done
-
 }
 
 # check preconditions
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105578] New: configuration of master document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105578

Bug ID: 105578
   Summary: configuration of master document
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: thef...@windstream.net

At some point during the last two years, the page numbering that had been in 
use was changed, and the new system really does not work.  I have been working
on a book for the last five or more years and had to suspend my work due to my
wifes health approx 1 and a half years ago. I recently started work again and
noticed that the page numbering was no longer in the master document.  I tried
to re-establish the numbering but was not successful.  Currently, I was only
able to get the system to number the pages in the first chapter, and the other
chapters are not numbering the pages consecutively, but trying to start each
chapter with page one.  I have also tried to number the early pages of the
master document (the first 7 pages) which describe the contents of the 
book following the instructions in the help pages, but could not get them to
number properly.  It will number the first two pages properly, and then it
keeps on using the number two for the remaining pages.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - editeng/source

[Kohei Yoshida]

 editeng/source/editeng/eerdll.cxx   |   12 ++--
 editeng/source/editeng/eerdll2.hxx  |4 
 editeng/source/editeng/impedit.hxx  |2 +-
 editeng/source/editeng/impedit2.cxx |   32 ++--
 4 files changed, 25 insertions(+), 25 deletions(-)

New commits:
commit 2cc1436430349590fcc699380997f0b65d914709
Author: Kohei Yoshida 
Date:   Mon Jan 23 22:01:37 2017 -0500

tdf#103927: Share single standard VirtualDevice instance.

To avoid creating excessive amounts of VirtualDevice instances. Also,
since we now have VclPtr, we shouldn't need this bOwnerOfRefDev flag.

This fixes tdf#102688 as well as other GDI-Limit related issues.

See tdf#105469 for other bugs this may fix.

(cherry picked from commit b41186a2fc49e440890b8c86e5367352ffaf9cd6)
(cherry picked from commit fab2f546d1fb3ceaf5ee5d4d728f1728a8f1e7f3)
(cherry picked from commit bac2baa785ffc75160de2d15da60901152da33de)

 Conflicts:
editeng/source/editeng/eerdll2.hxx
editeng/source/editeng/impedit2.cxx

Change-Id: Ieda242786c6376c7ac249a9f6d469b670f1ac177

diff --git a/editeng/source/editeng/eerdll.cxx 
b/editeng/source/editeng/eerdll.cxx
index fad7bb1..f11a3c9 100644
--- a/editeng/source/editeng/eerdll.cxx
+++ b/editeng/source/editeng/eerdll.cxx
@@ -70,6 +70,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace ::com::sun::star;
 
@@ -83,9 +84,11 @@ EditDLL& EditDLL::Get()
 return theEditDLL::get();
 }
 
-GlobalEditData::GlobalEditData()
+GlobalEditData::GlobalEditData() :
+ppDefItems(nullptr),
+mpVirDev(VclPtr::Create())
 {
-ppDefItems = nullptr;
+mpVirDev->SetMapMode(MAP_TWIP);
 }
 
 GlobalEditData::~GlobalEditData()
@@ -193,6 +196,11 @@ uno::Reference< linguistic2::XLanguageGuessing > 
GlobalEditData::GetLanguageGues
 return xLanguageGuesser;
 }
 
+VclPtr GlobalEditData::GetStdVirtualDevice()
+{
+return mpVirDev;
+}
+
 EditResId::EditResId(sal_uInt16 nId)
 : ResId(nId, *EditDLL::GetResMgr())
 {
diff --git a/editeng/source/editeng/eerdll2.hxx 
b/editeng/source/editeng/eerdll2.hxx
index 62b2b2a..f50c559 100644
--- a/editeng/source/editeng/eerdll2.hxx
+++ b/editeng/source/editeng/eerdll2.hxx
@@ -25,6 +25,7 @@
 #include 
 
 class SfxPoolItem;
+class VirtualDevice;
 
 class GlobalEditData
 {
@@ -33,6 +34,7 @@ private:
 SfxPoolItem**   ppDefItems;
 
 rtl::Reference xForbiddenCharsTable;
+VclPtr mpVirDev;
 
 public:
 GlobalEditData();
@@ -43,6 +45,8 @@ public:
 rtl::Reference GetForbiddenCharsTable();
 voidSetForbiddenCharsTable( 
rtl::Reference xForbiddenChars ) { 
xForbiddenCharsTable = xForbiddenChars; }
 css::uno::Reference< css::linguistic2::XLanguageGuessing > 
GetLanguageGuesser();
+
+VclPtr GetStdVirtualDevice();
 };
 
 #endif // INCLUDED_EDITENG_SOURCE_EDITENG_EERDLL2_HXX
diff --git a/editeng/source/editeng/impedit.hxx 
b/editeng/source/editeng/impedit.hxx
index 9a737d3..db74d61 100644
--- a/editeng/source/editeng/impedit.hxx
+++ b/editeng/source/editeng/impedit.hxx
@@ -423,6 +423,7 @@ private:
 
 VclPtr< VirtualDevice> pVirtDev;
 VclPtr< OutputDevice > pRefDev;
+VclPtr mpOwnDev;
 
 svtools::ColorConfig*   pColorConfig;
 mutable SvtCTLOptions*  pCTLOptions;
@@ -508,7 +509,6 @@ private:
 boolbIsInUndo:1;
 boolbUpdate:1;
 boolbUndoEnabled:1;
-boolbOwnerOfRefDev:1;
 boolbDowning:1;
 boolbUseAutoColor:1;
 boolbForceAutoColor:1;
diff --git a/editeng/source/editeng/impedit2.cxx 
b/editeng/source/editeng/impedit2.cxx
index 4572c71..7aaf2cc 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -95,7 +95,6 @@ ImpEditEngine::ImpEditEngine( EditEngine* pEE, SfxItemPool* 
pItemPool ) :
 bIsInUndo(false),
 bUpdate(true),
 bUndoEnabled(true),
-bOwnerOfRefDev(false),
 bDowning(false),
 bUseAutoColor(true),
 bForceAutoColor(false),
@@ -174,6 +173,7 @@ ImpEditEngine::~ImpEditEngine()
 bDowning = true;
 SetUpdateMode( false );
 
+mpOwnDev.disposeAndClear();
 pVirtDev.disposeAndClear();
 delete pEmptyItemSet;
 delete pUndoManager;
@@ -181,26 +181,15 @@ ImpEditEngine::~ImpEditEngine()
 delete mpIMEInfos;
 delete pColorConfig;
 delete pCTLOptions;
-if ( bOwnerOfRefDev )
-pRefDev.disposeAndClear();
 delete pSpellInfo;
 }
 
 void ImpEditEngine::SetRefDevice( OutputDevice* pRef )
 {
-if ( bOwnerOfRefDev )
-pRefDev.disposeAndClear();
-
-if ( !pRef )
-{
-pRefDev = VclPtr::Create();
-pRefDev->SetMapMode( MAP_TWIP );
-bOwnerOfRefDev = true;
-} else
-{
+if (pRef)
 pRefDev = pRef;
-bOwnerOfRefDev = false;
-}
+else
+pRefDev = EditDLL::Get().GetGlobalData()->GetStdVirtualDevice();
 
 

[Libreoffice-bugs] [Bug 105577] Crash when escaping checkbox control properties in a form ( enable-dbgutil)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105577

--- Comment #1 from Julien Nabet  ---
Created attachment 130731
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130731=edit
bt with debug symbols

I attached a bt when breaking in vcl/source/window/window.cxx:320

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105463] Checkbox in Base form corrupted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105463

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||5577

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105577] Crash when escaping checkbox control properties in a form ( enable-dbgutil)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105577

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||5463

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105577] New: Crash when escaping checkbox control properties in a form (enable-dbgutil )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105577

Bug ID: 105577
   Summary: Crash when escaping checkbox control properties in a
form (enable-dbgutil)
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: serval2...@yahoo.fr

Description:
On pc Debian x86-64 with master sources updated today (+enable-dbgutil), I got
a crash when escaping checkbox control properties in a form.
On console I noticed this:
warn:legacy.osl:8482:1:tools/source/rc/resmgr.cxx:896: resource stack underrun!
warn:legacy.osl:8482:1:vcl/source/window/window.cxx:320: Window (
N3pcr32ListLikeControlWithModifyHandlerI15SvxColorListBoxEE(Chartreuse Green
1)) with live SystemWindows destroyed:  25ImplListBoxFloatingWindow()
14SvxColorWindow()
Window ( N3pcr32ListLikeControlWithModifyHandlerI15SvxColorListBoxEE(Chartreuse
Green 1)) with live SystemWindows destroyed:  25ImplListBoxFloatingWindow()
14SvxColorWindow()


Steps to Reproduce:
1. Create a brand new HSQLDB file
2. Click on Forms part
3. Click on "Create a form in Design View"
4. Create a checkbox button
5. Right click on checkbox button and select Control...
=> a popup window appears
6. Close popup window

Actual Results:  
Crash

Expected Results:
No crash


Reproducible: Always

User Profile Reset: Yes

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Firefox/45.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/inc sc/source sc/uiconfig

[Abhilash Singh]

 sc/inc/globstr.hrc  |4 +++-
 sc/inc/rangenam.hxx |   10 +-
 sc/source/core/tool/rangenam.cxx|   12 ++--
 sc/source/ui/app/inputwin.cxx   |2 +-
 sc/source/ui/dbgui/dbnamdlg.cxx |2 +-
 sc/source/ui/inc/namedefdlg.hxx |1 +
 sc/source/ui/namedlg/namedefdlg.cxx |   13 +++--
 sc/source/ui/namedlg/namedlg.cxx|2 +-
 sc/source/ui/src/globstr.src|4 
 sc/source/ui/vba/vbanames.cxx   |4 ++--
 sc/uiconfig/scalc/ui/definename.ui  |2 +-
 11 files changed, 40 insertions(+), 16 deletions(-)

New commits:
commit 413232229cbfd9d49ce9d1cdbb6b6e2dbe83af38
Author: Abhilash Singh 
Date:   Sun Jan 22 14:42:15 2017 +0530

tdf#86214 User isn't warned entering a cell address not allowed

Refactored ScRangeData::IsNameValid

Change-Id: I74dd5830d13e48e8fe9a5180a819be4acdc9a1db
Reviewed-on: https://gerrit.libreoffice.org/33386
Reviewed-by: Eike Rathke 
Tested-by: Jenkins 

diff --git a/sc/inc/globstr.hrc b/sc/inc/globstr.hrc
index 68d48d9..3b3cef6 100644
--- a/sc/inc/globstr.hrc
+++ b/sc/inc/globstr.hrc
@@ -712,7 +712,9 @@
 
 #define STR_QUERY_PIVOTTABLE_DELTAB 545
 
-#define SC_GLOBSTR_STR_COUNT546 /**< the count of permanently 
resident strings */
+#define STR_ERR_NAME_INVALID_CELL_REF   546
+
+#define SC_GLOBSTR_STR_COUNT547 /**< the count of permanently 
resident strings */
 
 #endif
 
diff --git a/sc/inc/rangenam.hxx b/sc/inc/rangenam.hxx
index 19c288b..737c5e6 100644
--- a/sc/inc/rangenam.hxx
+++ b/sc/inc/rangenam.hxx
@@ -59,6 +59,13 @@ public:
 AbsPos = 0x0080
 };
 
+enum IsNameValidType
+{
+NAME_VALID,
+NAME_INVALID_CELL_REF,
+NAME_INVALID_BAD_STRING
+};
+
 private:
 OUStringaName;
 OUStringaUpperName; // #i62977# for faster searching (aName is 
never modified after ctor)
@@ -154,7 +161,8 @@ public:
 voidValidateTabRefs();
 
 static void MakeValidName( OUString& rName );
-SC_DLLPUBLIC static boolIsNameValid( const OUString& rName, 
ScDocument* pDoc );
+
+SC_DLLPUBLIC static IsNameValidType IsNameValid( const OUString& 
rName, ScDocument* pDoc );
 
 SCROW GetMaxRow() const;
 SCCOL GetMaxCol() const;
diff --git a/sc/source/core/tool/rangenam.cxx b/sc/source/core/tool/rangenam.cxx
index d7fba04..1728460 100644
--- a/sc/source/core/tool/rangenam.cxx
+++ b/sc/source/core/tool/rangenam.cxx
@@ -474,21 +474,21 @@ void ScRangeData::MakeValidName( OUString& rName )
 }
 }
 
-bool ScRangeData::IsNameValid( const OUString& rName, ScDocument* pDoc )
+ScRangeData::IsNameValidType ScRangeData::IsNameValid( const OUString& rName, 
ScDocument* pDoc )
 {
 /* XXX If changed, sc/source/filter/ftools/ftools.cxx
  * ScfTools::ConvertToScDefinedName needs to be changed too. */
 sal_Char a('.');
 if (rName.indexOf(a) != -1)
-return false;
+return NAME_INVALID_BAD_STRING;
 sal_Int32 nPos = 0;
 sal_Int32 nLen = rName.getLength();
 if ( !nLen || !ScCompiler::IsCharFlagAllConventions( rName, nPos++, 
ScCharFlags::CharName ) )
-return false;
+return NAME_INVALID_BAD_STRING;
 while ( nPos < nLen )
 {
 if ( !ScCompiler::IsCharFlagAllConventions( rName, nPos++, 
ScCharFlags::Name ) )
-return false;
+return NAME_INVALID_BAD_STRING;
 }
 ScAddress aAddr;
 ScRange aRange;
@@ -500,10 +500,10 @@ bool ScRangeData::IsNameValid( const OUString& rName, 
ScDocument* pDoc )
 if (aRange.Parse(rName, pDoc, details) != ScRefFlags::ZERO ||
  aAddr.Parse(rName, pDoc, details) != ScRefFlags::ZERO )
 {
-return false;
+return NAME_INVALID_CELL_REF;
 }
 }
-return true;
+return NAME_VALID;
 }
 
 SCROW ScRangeData::GetMaxRow() const
diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx
index 9239398..9f94098 100644
--- a/sc/source/ui/app/inputwin.cxx
+++ b/sc/source/ui/app/inputwin.cxx
@@ -1991,7 +1991,7 @@ static ScNameInputType lcl_GetInputType( const OUString& 
rText )
 eRet = SC_NAME_INPUT_ROW;
 else if ( pDoc->GetTable( rText, nNameTab ) )
 eRet = SC_NAME_INPUT_SHEET;
-else if ( ScRangeData::IsNameValid( rText, pDoc ) ) // nothing 
found, create new range?
+else if ( ScRangeData::IsNameValid( rText, pDoc ) == 
ScRangeData::NAME_VALID ) // nothing found, create new range?
 {
 if ( rViewData.GetSimpleArea( aRange ) == SC_MARK_SIMPLE )
 eRet = SC_NAME_INPUT_DEFINE;
diff --git a/sc/source/ui/dbgui/dbnamdlg.cxx b/sc/source/ui/dbgui/dbnamdlg.cxx
index 8c91758..4596729 100644
--- a/sc/source/ui/dbgui/dbnamdlg.cxx
+++ b/sc/source/ui/dbgui/dbnamdlg.cxx
@@ -416,7 +416,7 @@ IMPL_LINK_NOARG(ScDbNameDlg, 

[Libreoffice-bugs] [Bug 105574] Security alert during install + publisher name keeps changing.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105574

--- Comment #5 from Joost  ---
I found the SHA code and they are the same but it is something in the chain of
trusted people that is breaking the installation proces

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98776] FILESAVE: Exporting to PDF crashes Writer if libreoffice-kde4 installed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98776

--- Comment #15 from Ferry Toth  ---
I had disabled native dialogs because of this. Now reenabled. I'll first try to
find a doc that hit's this bug reproducibly hits this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105574] Security alert during install + publisher name keeps changing.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105574

--- Comment #4 from Joost  ---
I am using Windows Defender and it gets a daily update so a virus on my system
looks strange.
But the main point is that if I look at the certifying path I see the following
info:
Root: StartCom Certification Authority (this one has been revoked by CA)
Next step: StartCom Class 3 Primary Intermediate Object CA (is good)
Next step: The Document Foundation (is good)
And I can't find anything close to the SHA1 string I found in the mirror list

As for the digital signature of the file I have the following info

Version: V2
Provider: CN = StartCom Class 3 Primary Intermediate Object CA
OU = Secure Digital Certificate Signing
O = StartCom Ltd.
C = IL

Serialnr: ‎11 bf f1 b8 5c 2c da
Digest-algoritme: sha1
Digest-keyalgoritme: RSA
verified marks
Type contence:
06 0a 2b 06 01 04 01 82   ..+.
37 02 01 04   7...

1.3.6.1.4.1.311.2.1.11: 
30 0c 06 0a 2b 06 01 04   0...+...
01 82 37 02 01 15 ..7...

Distributionlist:
04 14 b0 d5 15 3a 7a cc   .:z.
28 b0 85 92 8b bb 5e 5a   (.^Z
e1 d7 03 bc db 80 ..

1.3.6.1.4.1.33.2.1.12:
04 14 b0 d5 15 3a 7a cc   .:z.
28 b0 85 92 8b bb 5e 5a   (.^Z
e1 d7 03 bc db 80 ..

unconfermed marks:
controlsignature:
30 82 02 8b 02 01 01 30   0..0
68 30 52 31 0b 30 09 06   h0R1.0..
03 55 04 06 13 02 42 45   .UBE
31 19 30 17 06 03 55 04   1.0...U.
0a 13 10 47 6c 6f 62 61   ...Globa
6c 53 69 67 6e 20 6e 76   lSign nv
2d 73 61 31 28 30 26 06   -sa1(0&.
03 55 04 03 13 1f 47 6c   .UGl
6f 62 61 6c 53 69 67 6e   obalSign
20 54 69 6d 65 73 74 61Timesta
6d 70 69 6e 67 20 43 41   mping CA
20 2d 20 47 32 02 12 11- G2...
21 d6 99 a7 64 97 3e f1   !...d.>.
f8 42 7e e9 19 cc 53 41   .B~...SA
14 30 09 06 05 2b 0e 03   .0...+..
02 1a 05 00 a0 81 fd 30   ...0
18 06 09 2a 86 48 86 f7   ...*.H..
0d 01 09 03 31 0b 06 09   1...
2a 86 48 86 f7 0d 01 07   *.H.
01 30 1c 06 09 2a 86 48   .0...*.H
86 f7 0d 01 09 05 31 0f   ..1.
17 0d 31 37 30 31 31 32   ..170112
31 33 35 39 32 33 5a 30   135923Z0
23 06 09 2a 86 48 86 f7   #..*.H..
0d 01 09 04 31 16 04 14   1...
6c 1b ad 23 cf 1b df 6e   l..#...n
8f a1 ae 39 c9 cc 56 19   ...9..V.
34 a4 69 49 30 81 9d 06   4.iI0...
0b 2a 86 48 86 f7 0d 01   .*.H
09 10 02 0c 31 81 8d 30   1..0
81 8a 30 81 87 30 81 84   ..0..0..
04 14 63 b8 2f ab 61 f5   ..c./.a.
83 90 96 95 05 0b 00 24   ...$
9c 50 29 33 ec 79 30 6c   .P)3.y0l
30 56 a4 54 30 52 31 0b   0V.T0R1.
30 09 06 03 55 04 06 13   0...U...
02 42 45 31 19 30 17 06   .BE1.0..
03 55 04 0a 13 10 47 6c   .UGl
6f 62 61 6c 53 69 67 6e   obalSign
20 6e 76 2d 73 61 31 28nv-sa1(
30 26 06 03 55 04 03 13   0&..U...
1f 47 6c 6f 62 61 6c 53   .GlobalS
69 67 6e 20 54 69 6d 65   ign Time
73 74 61 6d 70 69 6e 67   stamping
20 43 41 20 2d 20 47 32CA - G2
02 12 11 21 d6 99 a7 64   ...!...d
97 3e f1 f8 42 7e e9 19   .>..B~..
cc 53 41 14 30 0d 06 09   .SA.0...
2a 86 48 86 f7 0d 01 01   *.H.
01 05 00 04 82 01 00 86   
9f a9 bb 8c bf 9b 67 26   ..g&
2c 50 8b 54 9a 3b f4 7a   ,P.T.;.z
20 2b 2a 72 25 f5 22 f9+*r%.".
47 fa 71 8a 46 c2 b6 33   G.q.F..3
28 9d f0 fb 8d 20 5f ed   ( _.
e7 a3 ae a4 70 1a b4 e6   p...
21 4c 60 62 8a 21 33 2f   !L`b.!3/
58 cd 25 e0 8b d6 6f b2   X.%...o.
09 ee 86 54 73 dd 18 a1   ...Ts...
90 34 0c 32 c8 ba 01 fd   .4.2
67 d1 81 fc 9b 3a 59 07   g:Y.
5e 66 76 29 8d 7f 31 21   ^fv).1!
ab 5e 2c 7a e6 9b 20 e1   .^,z.. .
0e ec e4 da d5 62 4c 68   .bLh
41 6a d2 9d 08 c2 b6 95   Aj..
f0 3c b5 d4 07 33 67 87   .<...3g.
d8 bf 54 a2 63 47 18 53   ..T.cG.S
6a 18 ab f7 bf fc 63 f1   j.c.
c1 82 c9 67 7a be 8c 50   ...gz..P
8f 31 ca fd ce 2d b7 4e   .1...-.N
0d 98 15 db f5 dd 12 47   ...G
7c 8a a2 27 e9 8c e2 b7   |..'
0f 81 f3 fc c4 31 9e aa   .1..
5b 53 72 db 28 de fc 41   [Sr.(..A
81 c4 c3 b9 38 17 07 38   8..8
c7 78 a9 11 ec a1 86 cc   .x..
f6 fe 1c b8 4b 7d 2e ba   K}..
17 0c 53 a3 a6 56 4f 53   ..S..VOS
93 f6 28 9f 2f 49 a5 1c   ..(./I..
d0 a7 08 a0 22 67 12 1d   "g..
db 57 87 39 cf ee ad 59   .W.9...Y
bd 0c 91 a5 f7 f4 fd  ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Usage of ActiveX in Libre Office

[libroffice . dev]

Hi,

Am 27.01.2017 um 18:03 schrieb Bryan Quigley:

Looking back over my previous attempt, I think you might not be
affected.  (In any case COM/ATL support would not be dropped)



The other problem was not having good test cases for making changes to
the code.  I do note in my original release notes "We specifically
want feedback if you use ActiveX to embed LibreOffice components into
your application."  Our original intention was to remove the plugin
that allows you to embed LibreOffice inside other applications (like
IE) using ActiveX.  Without test cases that worked, we weren't able to
ensure we wouldn't break something.

Ah, maybe we were talking about different things.
Do you mean the ability i.e. to put an LO calc document as object into a 
MS word document, and when activating the object the LO menu appears and 
take over control? I was talking about the pure automation through COM, 
remotely working on LO documents or gathering information.


ActiveX is more likely a marketing buzzword used for many aspects of the 
COM technology.


So, no, we don't use that OLE stuff. I can remember from the early days 
of OLE it was slow and had poor stability, so I never used that.


Best regards
Jörgen
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 105560] "View > Grid Lines for Sheet" only affects current sheet, not all selected sheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105560

--- Comment #4 from gilward.ku...@gmail.com ---
OpenGL was already disabled although the setting "Use OpenGL for all rendering"
is enabled. Nothing changes when I disable that.

Version: 5.2.5.1
Build ID: 0312e1a284a7d50ca85a365c316c7abbf20a4d22
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default;

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105574] Security alert during install + publisher name keeps changing.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105574

--- Comment #3 from MM  ---
It -looks- like there's a virus on the machine, which makes you wanna download
& install some more insecure software. That's probably why the system won't let
you open the file.
So better check the machine first before downloading anything else.
If there is a virus, downloading from another mirror won't help either, as it
redirects the download anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105561] Entries of LibreOffice modules does not appear in context menus of corresponding MS Office files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105561

--- Comment #4 from Marcin  ---
I have found this problem appearing on 6 computers (5 desktops, 1 laptop).
Windows 10 Home or Pro, 32-bit or 64-bit, all localized - PL. Some of them have
been updates (Win7 -> Win10), some - fresh installs. On updated computers LO
modules' context menu entries disappeared, and on newly installed, there were
no such entries after LO (32-bit or 64-bit) installations.

On all the systems I needed to right-click MS Word (or MS Excel file), and
could not find LibreOffice Writer (or LibreOffice Calc respectively) in context
menu Open With. Then I've been clicking "Choose different application"; the
window has been showing up with the list of application - Writer (od Calc) was
in that window only. But I need Writer (or any app) in context menu Open
With... list. Entries exported to sent regedit files helped me to solve this
(on 32-bit and 64-bit Windows 10, respectively).

Last but not least: these regedit files are examples only (showing what have I
done to have context menu entries for LO modules), not real solutions. Entries
should be added by LO installer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104778] CPU usage spikes every time when selecting single or multiple drawing items (because immense disk query's)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104778

Telesto  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #4 from Telesto  ---
Disk access as such is probably an implementation detail. The lag (and CPU
usage) while selecting is covered by bug 104312 and bug 105500

--> Closing: NAB

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104582] Recurring opening, read, and closing of every directory config directory when an animated GIF is refreshing canvas

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104582

Telesto  changed:

   What|Removed |Added

 Blocks||103152
Summary|Relatively high DISK I/O|Recurring opening, read,
   |for Writer document |and closing of every
   |containing an animated gif  |directory config directory
   ||when an animated GIF is
   ||refreshing canvas


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
[Bug 103152] [META] Writer image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103152

Telesto  changed:

   What|Removed |Added

 Depends on||104582


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104582
[Bug 104582] Recurring opening, read, and closing of every directory config
directory when an animated GIF is refreshing canvas
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103976] FILEOPEN: DOCX: Spacing in table's header not imported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103976

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Usage of ActiveX in Libre Office

[sos]

OkAny idea how we can test the behaviour with ActiveX removed ?GreetzFernand


Sent from my Samsung Galaxy smartphone.
 Original message From: Bryan Quigley 
 Date: 27/01/2017  18:09  (GMT+01:00) To: sos 
 Cc: libreoffice@lists.freedesktop.org, libroffice@artavi.de 
Subject: Re: Usage of ActiveX in Libre Office 
I don't believe it would be affected, but it would need to be tested to be sure.

Thanks,
Bryan

On Wed, Jan 25, 2017 at 3:43 PM, sos  wrote:
> Bryan,
> Please clarify, will stuff like
>
> oShell = CreateObject("WScript.Shell")
>
> Still working after removing ActiveX?
> If not: then lots off API code will been broken and this will been a BIG
> regression ?
>
> Greetz
>
> Fernand
>
>
> Sent from my Samsung Galaxy smartphone.
>
>  Original message 
> From: Bryan Quigley 
> Date: 25/01/2017 20:43 (GMT+01:00)
> To: libreoffice@lists.freedesktop.org, libroffice@artavi.de
> Subject: re: Usage of ActiveX in Libre Office
>
> Welcome and thanks for responding to notice!
>
> You're the first person (AFAICT) who has written in response to the
> deprecation notice.   My original intention was to remove it from the
> 5.2 release if we got no responses to that notice (that obviously
> hasn't happened).
>
> At this point the soonest release we could remove it from is 5.4
> (which might be around Aug 2017).  It's far from scheduled though.
>
> We really don't have much data to base this decision on, so I'll ask
> you instead.  Knowing keeping support has an impact on LibreOffice
> development, when do you think is reasonable for ActiveX support to be
> removed?
>
> What Windows version are you running?
>
> Kind regards,
> Bryan
>
> [The whole original thread - quite long]
> https://lists.freedesktop.org/archives/libreoffice/2015-December/071580.html
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 105560] "View > Grid Lines for Sheet" only affects current sheet, not all selected sheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105560

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #3 from m.a.riosv  ---
Works for me on both ways:
Version: 5.2.5.1 (x64)
Build ID: 0312e1a284a7d50ca85a365c316c7abbf20a4d22
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
Locale: es-ES (es_ES); Calc: group

Please test disabling OpenGL
Menu/Tools/Options/LibreOffice/View

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105576] New: Recent Documents picklist size reset to 25 and list emptied on reaching 100 files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105576

Bug ID: 105576
   Summary: Recent Documents picklist size reset to 25 and list
emptied on reaching 100 files
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pnet...@f2s.com

I had been quite happy to find that the Recent Files picklist was extended to
100 under LO 5.2.  However, when I reached the magic 100, instead of dropping
off the last file when adding a fresh one to the list, the entire list was
cleared. I have since found that
org.openoffice.Office.Common.History.PickListSize was also automatically reset
to 25, instead of staying at 100.

I believe some of the offending code is at lines 2044ff here:

https://gerrit.libreoffice.org/#/c/20338/2/officecfg/registry/schema/org/openoffice/Office/Common.xcs


I picked this up from
https://bugs.documentfoundation.org/show_bug.cgi?id=74834#c11 

Incidentally, I would be in favour of some of the ideas of Johnny M here:
https://bugs.documentfoundation.org/show_bug.cgi?id=61174

I would add that it would be nice to be able to remove a specific file from the
list: I download quite a few files from the internet on spec, and sometimes
find the file isn't quite what I had hoped, and so would like to discard it,
rather than having it clog list entries.

I noted that on resetting PickListSize (I chose 150, and set 200 files for the
History.List), older entries in the history list were not actually picked up
and included - only new additional files.  I found the actual history list was
150 files, which were still present in the Histories:HistoryItem list.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105469] [META] Bugs hitting limit for GDI objects in Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105469
Bug 105469 depends on bug 101327, which changed state.

Bug 101327 Summary: Impress crashes saving a pptx doc
https://bugs.documentfoundation.org/show_bug.cgi?id=101327

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101327] Impress crashes saving a pptx doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101327

Mike Kaganski  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #25 from Mike Kaganski  ---
Confirm it fixed with current master. Thanks Kohei!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105118] Impress table cells use way too many GDI objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105118

--- Comment #3 from Kohei Yoshida  ---
Someone please test and confirm this.  If not, I'll assume it is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101327] Impress crashes saving a pptx doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101327

--- Comment #24 from Kohei Yoshida  ---
Someone please test and confirm this.  If not, I'll assume it is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88070] FILESAVE: "The File could not be written" unable to save file with 3200+ comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88070

--- Comment #15 from Kohei Yoshida  ---
Someone please test and confirm this.  If not, I'll assume it is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 6 commits - Makefile.in Repository.mk vcl/Executable_epsfuzzer.mk vcl/inc vcl/Module_vcl.mk vcl/source vcl/workben

[Caolán McNamara]

 Makefile.in |2 -
 Repository.mk   |1 
 vcl/Executable_epsfuzzer.mk |   47 ++
 vcl/Module_vcl.mk   |1 
 vcl/inc/impgraph.hxx|2 +
 vcl/source/gdi/impgraph.cxx |   68 
 vcl/workben/epsfuzzer.cxx   |   24 +++
 7 files changed, 133 insertions(+), 12 deletions(-)

New commits:
commit 3084e8f5b12e865d565278168c27c7af15282191
Author: Caolán McNamara 
Date:   Thu Jan 26 12:23:10 2017 +

add eps fuzzer

Change-Id: I7455a01076fc7c5fd16bbb90914ac93c236b2a3b

diff --git a/Makefile.in b/Makefile.in
index c56b798..5f7b215 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -426,7 +426,7 @@ $(foreach ide,\
 eclipsecdt,\
 $(eval $(call gb_Top_GbuildToIdeIntegration,$(ide
 
-fuzzers: Library_sal Library_salhelper Library_reg Library_store 
Library_unoidl codemaker Library_cppu Library_i18nlangtag Library_cppuhelper 
Library_comphelper StaticLibrary_ulingu StaticLibrary_jpeg 
StaticLibrary_findsofficepath Library_tl Rdb_services udkapi offapi 
Library_clew Library_gie Library_reflection Library_invocadapt 
Library_bootstrap Library_introspection Library_stocservices Library_xmlreader 
Library_gcc3_uno instsetoo_native more_fonts StaticLibrary_fuzzer 
Executable_wmffuzzer Executable_jpgfuzzer Executable_giffuzzer 
Executable_xbmfuzzer Executable_xpmfuzzer Executable_pngfuzzer 
Executable_bmpfuzzer Executable_svmfuzzer Executable_pcdfuzzer 
Executable_dxffuzzer Executable_metfuzzer Executable_ppmfuzzer 
Executable_psdfuzzer
+fuzzers: Library_sal Library_salhelper Library_reg Library_store 
Library_unoidl codemaker Library_cppu Library_i18nlangtag Library_cppuhelper 
Library_comphelper StaticLibrary_ulingu StaticLibrary_jpeg 
StaticLibrary_findsofficepath Library_tl Rdb_services udkapi offapi 
Library_clew Library_gie Library_reflection Library_invocadapt 
Library_bootstrap Library_introspection Library_stocservices Library_xmlreader 
Library_gcc3_uno instsetoo_native more_fonts StaticLibrary_fuzzer 
Executable_wmffuzzer Executable_jpgfuzzer Executable_giffuzzer 
Executable_xbmfuzzer Executable_xpmfuzzer Executable_pngfuzzer 
Executable_bmpfuzzer Executable_svmfuzzer Executable_pcdfuzzer 
Executable_dxffuzzer Executable_metfuzzer Executable_ppmfuzzer 
Executable_psdfuzzer Executable_epsfuzzer
 
 endif # MAKE_RESTARTS
 
diff --git a/Repository.mk b/Repository.mk
index e039a8c..d196c5c 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -106,6 +106,7 @@ $(eval $(call 
gb_Helper_register_executables_for_install,OOO,brand, \
$(call gb_Helper_optional,FUZZERS,metfuzzer) \
$(call gb_Helper_optional,FUZZERS,ppmfuzzer) \
$(call gb_Helper_optional,FUZZERS,psdfuzzer) \
+   $(call gb_Helper_optional,FUZZERS,epsfuzzer) \
$(if $(filter-out ANDROID IOS MACOSX WNT,$(OS)),oosplash) \
soffice_bin \
$(if $(filter DESKTOP,$(BUILD_TYPE)),unopkg_bin) \
diff --git a/vcl/Executable_epsfuzzer.mk b/vcl/Executable_epsfuzzer.mk
new file mode 100644
index 000..445bfc4
--- /dev/null
+++ b/vcl/Executable_epsfuzzer.mk
@@ -0,0 +1,47 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+include $(SRCDIR)/vcl/commonfuzzer.mk
+
+$(eval $(call gb_Executable_Executable,epsfuzzer))
+
+$(eval $(call gb_Executable_use_api,epsfuzzer,\
+offapi \
+udkapi \
+))
+
+$(eval $(call gb_Executable_use_externals,epsfuzzer,\
+   $(fuzzer_externals) \
+))
+
+$(eval $(call gb_Executable_set_include,epsfuzzer,\
+$$(INCLUDE) \
+-I$(SRCDIR)/vcl/inc \
+))
+
+$(eval $(call gb_Executable_use_libraries,epsfuzzer,\
+   $(fuzzer_libraries) \
+))
+
+$(eval $(call gb_Executable_use_static_libraries,epsfuzzer,\
+findsofficepath \
+ulingu \
+fuzzer \
+))
+
+$(eval $(call gb_Executable_add_exception_objects,epsfuzzer,\
+   vcl/workben/epsfuzzer \
+))
+
+$(eval $(call gb_Executable_add_libs,epsfuzzer,\
+   -lFuzzingEngine \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk
index a10236b..cd6c5ab 100644
--- a/vcl/Module_vcl.mk
+++ b/vcl/Module_vcl.mk
@@ -119,6 +119,7 @@ $(eval $(call gb_Module_add_targets,vcl,\
 Executable_metfuzzer \
 Executable_ppmfuzzer \
 Executable_psdfuzzer \
+Executable_epsfuzzer \
 ))
 endif
 
diff --git a/vcl/workben/epsfuzzer.cxx b/vcl/workben/epsfuzzer.cxx
new file mode 100644
index 000..9b03729
--- /dev/null
+++ b/vcl/workben/epsfuzzer.cxx
@@ -0,0 +1,24 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla 

[Libreoffice-bugs] [Bug 105469] [META] Bugs hitting limit for GDI objects in Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105469
Bug 105469 depends on bug 87204, which changed state.

Bug 87204 Summary: FILESAVE: PowerPoint pps causes LO to crash or freeze...
https://bugs.documentfoundation.org/show_bug.cgi?id=87204

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source

[Caolán McNamara]

 sc/source/ui/dbgui/PivotLayoutDialog.cxx|   17 +
 sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx  |   23 ---
 sc/source/ui/dbgui/PivotLayoutTreeListLabel.cxx |7 ---
 sc/source/ui/inc/PivotLayoutDialog.hxx  |5 ++---
 sc/source/ui/inc/PivotLayoutTreeListBase.hxx|3 ---
 5 files changed, 19 insertions(+), 36 deletions(-)

New commits:
commit a9b7c569652ba27ecda572a0cc8ad7a12143e903
Author: Caolán McNamara 
Date:   Thu Jan 26 09:12:24 2017 +

Resolves: tdf#104153 crash on drag and drop pivot table field

This is a combination of 2 commits.

Resolves: tdf#104153 crash on drag and drop pivot table field

now though sometimes it doesn't get removed at all, so a band aid
for the moment

(cherry picked from commit 068edb65b1dce375223d8642a01b07db3948ac03)

Resolves: tdf#104153 lookup what listbox an entry is dragged from

so we can find where its been dragged from in order to remove it from that
source, rather than relying that it comes from the previously focused 
listbox

Reviewed-on: https://gerrit.libreoffice.org/33575
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 
(cherry picked from commit 011bae55cdd24a1d3e42f0aa2fcfd98d3ddc9b14)

e6aa1a311b46e5e9ee96cab05e0705b794b5eb0b

Change-Id: I6ccbbe51fe9250af0f85c30a9d253269a18df457
Reviewed-on: https://gerrit.libreoffice.org/33633
Reviewed-by: Eike Rathke 
Tested-by: Jenkins 

diff --git a/sc/source/ui/dbgui/PivotLayoutDialog.cxx 
b/sc/source/ui/dbgui/PivotLayoutDialog.cxx
index dd8ef5d..10383f7 100644
--- a/sc/source/ui/dbgui/PivotLayoutDialog.cxx
+++ b/sc/source/ui/dbgui/PivotLayoutDialog.cxx
@@ -70,8 +70,6 @@ ScPivotLayoutDialog::ScPivotLayoutDialog(
 ScViewData* pViewData, const ScDPObject* 
pPivotTableObject, bool bNewPivotTable) :
 ScAnyRefDlg   (pSfxBindings, pChildWindow, pParent, 
"PivotTableLayout", "modules/scalc/ui/pivottablelayoutdialog.ui"),
 maPivotTableObject(*pPivotTableObject),
-mpPreviouslyFocusedListBox(nullptr),
-mpCurrentlyFocusedListBox(nullptr),
 mpViewData(pViewData),
 mpDocument(pViewData->GetDocument()),
 mbNewPivotTable   (bNewPivotTable),
@@ -189,8 +187,6 @@ ScPivotLayoutDialog::~ScPivotLayoutDialog()
 
 void ScPivotLayoutDialog::dispose()
 {
-mpPreviouslyFocusedListBox.clear();
-mpCurrentlyFocusedListBox.clear();
 mpListBoxField.clear();
 mpListBoxPage.clear();
 mpListBoxColumn.clear();
@@ -736,4 +732,17 @@ void ScPivotLayoutDialog::ToggleDestination()
 mpDestinationEdit->Enable(bSelection);
 }
 
+ScPivotLayoutTreeListBase* ScPivotLayoutDialog::FindListBoxFor(SvTreeListEntry 
*pEntry)
+{
+if (mpListBoxPage->HasEntry(pEntry))
+return mpListBoxPage.get();
+if (mpListBoxColumn->HasEntry(pEntry))
+return mpListBoxColumn.get();
+if (mpListBoxRow->HasEntry(pEntry))
+return mpListBoxRow.get();
+if (mpListBoxData->HasEntry(pEntry))
+return mpListBoxData.get();
+return nullptr;
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx 
b/sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx
index 407a3b4..0061305 100644
--- a/sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx
+++ b/sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx
@@ -124,27 +124,4 @@ void 
ScPivotLayoutTreeListBase::RemoveEntryForItem(ScItemValue* pItemValue)
 }
 }
 
-void ScPivotLayoutTreeListBase::GetFocus()
-{
-SvTreeListBox::GetFocus();
-
-if( GetGetFocusFlags() & GetFocusFlags::Mnemonic )
-{
-SvTreeListEntry* pEntry = 
mpParent->mpPreviouslyFocusedListBox->GetCurEntry();
-if (pEntry)
-InsertEntryForSourceTarget(pEntry, nullptr);
-
-if (mpParent->mpPreviouslyFocusedListBox != nullptr)
-mpParent->mpPreviouslyFocusedListBox->GrabFocus();
-}
-
-mpParent->mpCurrentlyFocusedListBox = this;
-}
-
-void ScPivotLayoutTreeListBase::LoseFocus()
-{
-SvTreeListBox::LoseFocus();
-if (mpParent)
-mpParent->mpPreviouslyFocusedListBox = this;
-}
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/dbgui/PivotLayoutTreeListLabel.cxx 
b/sc/source/ui/dbgui/PivotLayoutTreeListLabel.cxx
index 3795601..9073faa 100644
--- a/sc/source/ui/dbgui/PivotLayoutTreeListLabel.cxx
+++ b/sc/source/ui/dbgui/PivotLayoutTreeListLabel.cxx
@@ -57,10 +57,11 @@ void 
ScPivotLayoutTreeListLabel::FillLabelFields(ScDPLabelDataVector& rLabelVect
 }
 }
 
-void ScPivotLayoutTreeListLabel::InsertEntryForSourceTarget(SvTreeListEntry* 
/*pSource*/, SvTreeListEntry* /*pTarget*/)
+void ScPivotLayoutTreeListLabel::InsertEntryForSourceTarget(SvTreeListEntry* 
pSource, 

[Libreoffice-bugs] [Bug 87204] FILESAVE: PowerPoint pps causes LO to crash or freeze...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87204

Kohei Yoshida  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #17 from Kohei Yoshida  ---
There is lots of duplicate communication going on here. I'll close this as
duplicate.

*** This bug has been marked as a duplicate of bug 102688 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/source

[Caolán McNamara]

 vcl/inc/impgraph.hxx|1 -
 vcl/source/gdi/impgraph.cxx |   32 +---
 2 files changed, 13 insertions(+), 20 deletions(-)

New commits:
commit 9bf03203cdc789fb7be58e1b8bc6caa63c6dd09c
Author: Caolán McNamara 
Date:   Fri Jan 27 15:16:05 2017 +

remove weirdness of ImpGraphic assignment operator

seems to me that this hackery is to avoid the swapfile
getting pulled out from underneath it during swapin

Change-Id: I6b58d7e31731db8edc4026460beabc667204dcae
Reviewed-on: https://gerrit.libreoffice.org/33620
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/inc/impgraph.hxx b/vcl/inc/impgraph.hxx
index 6b4babd..041caf1 100644
--- a/vcl/inc/impgraph.hxx
+++ b/vcl/inc/impgraph.hxx
@@ -47,7 +47,6 @@ private:
 GraphicType  meType;
 mutable sal_uLongmnSizeBytes;
 bool mbSwapOut;
-bool mbSwapUnderway;
 bool mbDummyContext;
 SvgDataPtr   maSvgData;
 css::uno::Sequence maPdfData;
diff --git a/vcl/source/gdi/impgraph.cxx b/vcl/source/gdi/impgraph.cxx
index f96a4b2..a82e67a 100644
--- a/vcl/source/gdi/impgraph.cxx
+++ b/vcl/source/gdi/impgraph.cxx
@@ -101,7 +101,6 @@ ImpGraphic::ImpGraphic() :
 meType  ( GraphicType::NONE ),
 mnSizeBytes ( 0UL ),
 mbSwapOut   ( false ),
-mbSwapUnderway  ( false ),
 mbDummyContext  ( false )
 {
 }
@@ -113,7 +112,6 @@ ImpGraphic::ImpGraphic(const ImpGraphic& rImpGraphic)
 , meType(rImpGraphic.meType)
 , mnSizeBytes(rImpGraphic.mnSizeBytes)
 , mbSwapOut(rImpGraphic.mbSwapOut)
-, mbSwapUnderway(false)
 , mbDummyContext(rImpGraphic.mbDummyContext)
 , maSvgData(rImpGraphic.maSvgData)
 , maPdfData(rImpGraphic.maPdfData)
@@ -133,7 +131,6 @@ ImpGraphic::ImpGraphic( const Bitmap& rBitmap ) :
 meType  ( !rBitmap.IsEmpty() ? GraphicType::Bitmap : 
GraphicType::NONE ),
 mnSizeBytes ( 0UL ),
 mbSwapOut   ( false ),
-mbSwapUnderway  ( false ),
 mbDummyContext  ( false )
 {
 }
@@ -143,7 +140,6 @@ ImpGraphic::ImpGraphic( const BitmapEx& rBitmapEx ) :
 meType  ( !rBitmapEx.IsEmpty() ? GraphicType::Bitmap : 
GraphicType::NONE ),
 mnSizeBytes ( 0UL ),
 mbSwapOut   ( false ),
-mbSwapUnderway  ( false ),
 mbDummyContext  ( false )
 {
 }
@@ -152,7 +148,6 @@ ImpGraphic::ImpGraphic(const SvgDataPtr& rSvgDataPtr)
 :   meType( rSvgDataPtr.get() ? GraphicType::Bitmap : GraphicType::NONE ),
 mnSizeBytes( 0UL ),
 mbSwapOut( false ),
-mbSwapUnderway( false ),
 mbDummyContext  ( false ),
 maSvgData(rSvgDataPtr)
 {
@@ -164,7 +159,6 @@ ImpGraphic::ImpGraphic( const Animation& rAnimation ) :
 meType  ( GraphicType::Bitmap ),
 mnSizeBytes ( 0UL ),
 mbSwapOut   ( false ),
-mbSwapUnderway  ( false ),
 mbDummyContext  ( false )
 {
 }
@@ -174,7 +168,6 @@ ImpGraphic::ImpGraphic( const GDIMetaFile& rMtf ) :
 meType  ( GraphicType::GdiMetafile ),
 mnSizeBytes ( 0UL ),
 mbSwapOut   ( false ),
-mbSwapUnderway  ( false ),
 mbDummyContext  ( false )
 {
 }
@@ -188,8 +181,7 @@ ImpGraphic& ImpGraphic::operator=( const ImpGraphic& 
rImpGraphic )
 {
 if(  != this )
 {
-if( !mbSwapUnderway )
-ImplClear();
+ImplClear();
 
 maMetaFile = rImpGraphic.maMetaFile;
 meType = rImpGraphic.meType;
@@ -207,11 +199,8 @@ ImpGraphic& ImpGraphic::operator=( const ImpGraphic& 
rImpGraphic )
 maEx = rImpGraphic.maEx;
 }
 
-if( !mbSwapUnderway )
-{
-mbSwapOut = rImpGraphic.mbSwapOut;
-mpSwapFile = rImpGraphic.mpSwapFile;
-}
+mbSwapOut = rImpGraphic.mbSwapOut;
+mpSwapFile = rImpGraphic.mpSwapFile;
 
 mpGfxLink.reset();
 
@@ -1262,15 +1251,22 @@ bool ImpGraphic::ImplSwapIn( SvStream* xIStm )
 
 if( !xIStm->GetError() )
 {
-mbSwapUnderway = true;
+//keep the swap file alive, because its quite possibly the backing 
storage
+//for xIStm
+std::shared_ptr xSwapFile(std::move(mpSwapFile));
+assert(!mpSwapFile);
+
 bRet = ImplReadEmbedded( *xIStm );
-mbSwapUnderway = false;
+
+//restore ownership of the swap file
+mpSwapFile = std::move(xSwapFile);
 
 if (!bRet)
 {
 //throw away swapfile, etc.
 ImplClear();
 }
+
 mbSwapOut = false;
 }
 }
@@ -1278,7 +1274,6 @@ bool ImpGraphic::ImplSwapIn( SvStream* xIStm )
 return bRet;
 }
 
-
 void ImpGraphic::ImplSetLink( const GfxLink& rGfxLink )
 

[Libreoffice-commits] core.git: editeng/source

[Kohei Yoshida]

 editeng/source/editeng/impedit2.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit f2f6d11e35cdd09291e730429d6c876532f34328
Author: Kohei Yoshida 
Date:   Thu Jan 26 23:38:12 2017 -0500

tdf#102688: let's purge it here just in case...

In theory it would still leak without this if the map mode is set
multiple times.

Change-Id: Ie862f4d59e45b92ff75dffb787ef256337f47f84
Reviewed-on: https://gerrit.libreoffice.org/33602
Tested-by: Jenkins 
Reviewed-by: Kohei Yoshida 

diff --git a/editeng/source/editeng/impedit2.cxx 
b/editeng/source/editeng/impedit2.cxx
index 5bbb325..7c6e51c 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -208,6 +208,7 @@ void ImpEditEngine::SetRefMapMode( const MapMode& rMapMode )
 if ( GetRefDevice()->GetMapMode() == rMapMode )
 return;
 
+mpOwnDev.disposeAndClear();
 mpOwnDev = VclPtr::Create();
 pRefDev = mpOwnDev;
 pRefDev->SetMapMode( MapUnit::MapTwip );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: minutes of ESC call ...

[Jan-Marek Glogowski]

Am 27.01.2017 um 07:07 schrieb David Ostrovsky:
> It would be also cool, if you could look into new and shiny gerrit UI,
> based on JavaScript Polymer framework, and provide feedback. You can
> see the new UI in action upstream by switching in footer to new UI.
> Only change screen is implemented for now. All diffs on one page is
> already implemented:
> 
> https://gerrit-review.googlesource.com/

Generally I like the new UI - if just for the - per file expandable -
inline diff :-) But switching the "info" and "commit message" frames
produces a lot of unused / white area on the right, and uses more
precious vertical space.
Especially since the left "info" frame doesn't expand much horizontally,
so can't / won't display multiple reviewers in one row, but instead the
commit message expands, which almost ever has a fixed maximum width.

I first had a look at

https://gerrit-review.googlesource.com/c/95455/?polygerrit=1

but it's probably event better to see, if you check

https://gerrit-review.googlesource.com/c/94813/?polygerrit=1

Now there is some of the white space used by the relation chain.
Just decrease the browser horizontally.

To save some vertical space it would also help to merge Reviewers,
Code-Review and Verified into a table, so this won't duplicate name
lists, like:

Reviewer | Verified | Code
Me   |   +1 |  +1
You  |  |  -1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Usage of ActiveX in Libre Office

[Heiko Tietze]

It would be much nicer to have a Pascal bridge rather than to support
the proprietary ActiveX protocol. Some references are on the
Freepascal wiki http://wiki.freepascal.org/Office_Automation

2017-01-23 15:42 GMT+01:00  :
> We are recently switched from AOO to LO. In the release notes a possible
> removal of ActiveX is announced.
> You are asking for information about the use case so here we are:
>
> We are using in our company a selfmade ERP system which is grown for more
> than 15 years now. For historical reasons the system is written in Delphi.
> At the beginning MS Office was used as "office frontend", since about 10
> years OOo/AOO/LO. The main workflow is using calc for business calculation
> and writer as a kind of report tool. Most information from the main database
> is delivered via ActiveX to calc. After working in calc the information are
> read back and used to create documents in writer. The complete project and
> document management (and many more) is done by our ERP.
>
> I know there are others and probably more elegant ways and about once a year
> we are discussing to change that and finding the "big solution" - but this
> is a huge and expensive project.
>
> Removing ActiveX from LO will be a showstopper and nail us to the last
> supported release - or bring us back to AOO, who knows.
>
> Best regards
> Joergen Pisarz
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 104955] Check boxes in Base forms replaced by a small picture

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104955

--- Comment #26 from ribotb  ---
Hi;

It seems that I am the only one in the LO community with this problem with LO
5.3.0. 
I have modified all check boxes in my forms (3D) with LO 5.2.to use now LO
5.3.0.

As this problem does not appear in version 5.4, so I propose that this bug be
closed.

Bernard

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105575] New: Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Bug ID: 105575
   Summary: Slow rendering when using a Logo command
   Product: LibreOffice
   Version: 5.3.0.0.alpha1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
While testing bug 83801 I noticed that the Logo command "repeat 400 [ circle 10
+ repcount/10 fd 5 + repcount/10 lt 10 ]" is executed slowly (with or without
OPENGL)

Steps to Reproduce:
1. Open Writer, enable "View -> Toobars -> Logo";
2. Run the following LOGO command one by one (to run a LOGO command, paste the
command in the LOGO command line box, then hit ENTER): repeat 400 [ circle 10 +
repcount/10 fd 5 + repcount/10 lt 10 ]

Actual Results:  
The rendering is extremely slow compared to Lib5.0.2.2


Expected Results:
Same speed as in Lib5.0.2.2


Reproducible: Always

User Profile Reset: No

Additional Info:
Found in
Version: 5.4.0.0.alpha0+
Build ID: b41186a2fc49e440890b8c86e5367352ffaf9cd6
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-26_01:50:40
Locale: nl-NL (nl_NL); Calc: CL

and in
Version: 5.3.0.0.alpha1+ (x64)
Build ID: 964f4ca95baf34d21002312003453cd0e72f5832
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine:
new; 
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2016-11-18_05:19:44
Locale: nl-NL (nl_NL); Calc: CL

but not in
Version: 5.0.2.2
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: en-US (nl_NL)

Terminal output with debug build:
warn:legacy.osl:6020:4136:svx/source/sdr/contact/viewcontactofsdrpathobj.cxx:56:
PolyPolygon object without geometry detected, this should not be created (!)
warn:legacy.osl:6020:7032:svx/source/sdr/contact/viewcontactofsdrpathobj.cxx:56:
PolyPolygon object without geometry detected, this should not be created (!)
warn:sw:6020:7032:C:\cygwin\home\tinderbox\master\sw\inc\swrect.hxx:283:
SVRect() without Width or Height
warn:sw:6020:7032:C:\cygwin\home\tinderbox\master\sw\inc\swrect.hxx:283:
SVRect() without Width or Height
warn:legacy.osl:6020:4136:svx/source/sdr/contact/viewcontactofsdrpathobj.cxx:56:
PolyPolygon object without geometry detected, this should not be created (!)


User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101
Firefox/45.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99705] Active cell not highlighted / bordered when OpenGL is disabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99705

--- Comment #11 from Abdellatif  ---
I confirm this issue on Ubuntu 16.10 for LibreOffice Calc 5.2.5.1 ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62032] Outline numbering doesn' t work when defined in Paragraph Styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62032

--- Comment #7 from Smith Kennedy  ---
Still a problem in:

Version: 5.2.3.3
Build ID: d54a8868f08a7b39642414cf2c8ef2f228f780cf
CPU Threads: 8; OS Version: Mac OS X 10.12.3; UI Render: GL; 
Locale: en-US (en_US.UTF-8); Calc: group

I simply don't understand what value the "Outline level" setting in the
"Outline & Numbering" tab of the Paragraph Style settings window provides, if
not to automatically set the outline level.

For document authors of structured documents, this is quite a serious problem.
The user has the ability to define a paragraph style that includes an outline
level, which sets the expectation that if a paragraph has its style set, that
its outline level will be set accordingly.

If the Document Foundation hopes that LibreOffice and the Open Document formats
are to  become more broadly adopted as a document format in professional
organizations such as technology standards bodies (several of which I take part
in and NONE of them use ODF or LibreOffice) this issue MUST be resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: 2 commits - .gitignore kit/ChildSession.cpp kit/Kit.cpp kit/KitHelper.hpp tools/KitClient.cpp wsd/protocol.txt

[Pranav Kant]

 .gitignore   |4 
 kit/ChildSession.cpp |3 +++
 kit/Kit.cpp  |6 --
 kit/KitHelper.hpp|2 ++
 tools/KitClient.cpp  |1 +
 wsd/protocol.txt |5 +
 6 files changed, 19 insertions(+), 2 deletions(-)

New commits:
commit 440ca8e2f73d904c2abc5ac8d4803b0b38ec6252
Author: Pranav Kant 
Date:   Mon Jan 23 22:31:57 2017 +0530

Initial support for comments lok api

Change-Id: I1fc48e245a47f7b8d4260009d8c377c30d0b8820

diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index 0489bd9..4be66f2 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -1206,6 +1206,9 @@ void ChildSession::loKitCallback(const int type, const 
std::string& payload)
 case LOK_CALLBACK_REDLINE_TABLE_ENTRY_MODIFIED:
 sendTextFrame("redlinetablemodified: " + payload);
 break;
+case LOK_CALLBACK_COMMENT:
+sendTextFrame("comment: " + payload);
+break;
 default:
 LOG_ERR("Unknown callback event (" << type << "): " << payload);
 }
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 16e20ac..4401a6c 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -1154,7 +1154,8 @@ private:
 
 const auto flags = LOK_FEATURE_DOCUMENT_PASSWORD
  | LOK_FEATURE_DOCUMENT_PASSWORD_TO_MODIFY
- | LOK_FEATURE_PART_IN_INVALIDATION_CALLBACK;
+ | LOK_FEATURE_PART_IN_INVALIDATION_CALLBACK
+ | LOK_FEATURE_NO_TILED_ANNOTATIONS;
 _loKit->setOptionalFeatures(flags);
 
 // Save the provided password with us and the jailed url
@@ -1809,7 +1810,8 @@ void lokit_main(const std::string& childRoot,
 
 const auto flags = LOK_FEATURE_DOCUMENT_PASSWORD
| LOK_FEATURE_DOCUMENT_PASSWORD_TO_MODIFY
-   | LOK_FEATURE_PART_IN_INVALIDATION_CALLBACK;
+   | LOK_FEATURE_PART_IN_INVALIDATION_CALLBACK
+   | LOK_FEATURE_NO_TILED_ANNOTATIONS;
 loKit->setOptionalFeatures(flags);
 loKitDoc.reset(loKit->documentLoad(uri.c_str()));
 if (!loKitDoc || !loKitDoc->get())
diff --git a/kit/KitHelper.hpp b/kit/KitHelper.hpp
index 7afa22a..038a386 100644
--- a/kit/KitHelper.hpp
+++ b/kit/KitHelper.hpp
@@ -108,6 +108,8 @@ namespace LOKitHelper
 return "VIEW_CURSOR_VISIBLE";
 case LOK_CALLBACK_VIEW_LOCK:
 return "VIEW_LOCK";
+case LOK_CALLBACK_COMMENT:
+return "COMMENT";
 }
 
 return std::to_string(type);
diff --git a/tools/KitClient.cpp b/tools/KitClient.cpp
index dcc2ed3..33eec54 100644
--- a/tools/KitClient.cpp
+++ b/tools/KitClient.cpp
@@ -74,6 +74,7 @@ extern "C"
 CASE(VIEW_LOCK);
 CASE(REDLINE_TABLE_SIZE_CHANGED);
 CASE(REDLINE_TABLE_ENTRY_MODIFIED);
+CASE(COMMENT);
 #undef CASE
 }
 std::cout << " payload: " << payload << std::endl;
diff --git a/wsd/protocol.txt b/wsd/protocol.txt
index bb135e9..2e63de2 100644
--- a/wsd/protocol.txt
+++ b/wsd/protocol.txt
@@ -375,6 +375,11 @@ redlinetablechanged:
 Signals that the redlines table has been modified.
 Redlines are used for tracking changes.
 
+comment:
+
+Signals that comment has either been added, removed or modified. See
+LOK_CALLBACK_COMMENT for JSON structure.
+
 stats:  
 
 Contains statistical data. Eg: 'stats: wopiloadduration 5' means that
commit 8df085fbffb832ff58345b5b5698c44f5347f226
Author: Pranav Kant 
Date:   Mon Jan 23 22:25:36 2017 +0530

.gitignore: Ignore TAGS file

Change-Id: I23a1de867ea623e0355688caab6fba5b3d5d2474

diff --git a/.gitignore b/.gitignore
index adfe2e1..14fcf08 100644
--- a/.gitignore
+++ b/.gitignore
@@ -57,3 +57,7 @@ loolstress
 loolforkit-nocaps
 loadtest
 unittest
+
+# make tags
+TAGS
+test/TAGS
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/TileCacheTests.cpp

[Jan Holesovsky]

 test/TileCacheTests.cpp |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit da93cd416b2b30e569cc34651e0bc21602841b9d
Author: Jan Holesovsky 
Date:   Fri Jan 27 19:16:51 2017 +0100

Temporarily disable, these tests are affected by the order of invalidates.

Change-Id: Icd08629315417f3ca8f2c5560271a12c62309956

diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index 42f72c4..c0611a8 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -70,8 +70,9 @@ class TileCacheTests : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testTileInvalidateWriter);
 CPPUNIT_TEST(testTileInvalidateWriterPage);
 CPPUNIT_TEST(testTileInvalidateCalc);
-CPPUNIT_TEST(testTileInvalidatePartCalc);
-CPPUNIT_TEST(testTileInvalidatePartImpress);
+// temporarily disable
+//CPPUNIT_TEST(testTileInvalidatePartCalc);
+//CPPUNIT_TEST(testTileInvalidatePartImpress);
 
 CPPUNIT_TEST_SUITE_END();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105574] Security alert during install + publisher name keeps changing.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105574

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #2 from V Stuart Foote  ---
Have you verified the HASH value checksum for the installer you downloaded?

If it differs, your download is corrupt or worse tainted. We'd then need to
know the mirror site you downloaded from to have them restore a correct
installer.

http://download.documentfoundation.org/libreoffice/stable/5.2.5/win/x86/LibreOffice_5.2.5_Win_x86.msi.mirrorlist

http://download.documentfoundation.org/libreoffice/stable/5.2.5/win/x86_64/LibreOffice_5.2.5_Win_x64.msi.mirrorlist

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105574] Security alert during install + publisher name keeps changing.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105574

--- Comment #1 from Joost  ---
Created attachment 130730
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130730=edit
Screenshot of installation bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105574] New: Security alert during install + publisher name keeps changing.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105574

Bug ID: 105574
   Summary: Security alert during install + publisher name keeps
changing.
   Product: LibreOffice
   Version: 5.2.5.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sir.kieke...@gmail.com

Description:
If I try to install the LibreOffice_5.2.5_Win_x86 I keep getting a security
warning for an unknown publisher and at the same time I get a very strange name
for the publisher.
If I try it again the name will be different but the same problem persist.
Most of the time the publisher name will be made up of Chinese symbols.
I use a basic Windows 10 system with only Microsoft security programs on it.

Steps to Reproduce:
1. Download the installer from
https://nl.libreoffice.org/download/libreoffice-fris/
2. Just install it and the bug pops up.


Actual Results:  
1. Download the installer from
https://nl.libreoffice.org/download/libreoffice-fris/
2. Just install it and the bug pops up.

Expected Results:
Normal installation / upgrade from my current Libre Office suite


Reproducible: Always

User Profile Reset: No

Additional Info:
Not sure what is wrong but it feels like there is a virus in the installation
file but my anti virus program does not respond when I download it or does a
full system scan.


User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101
Firefox/51.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - include/sfx2 sc/source sfx2/source sw/source

[Caolán McNamara]

 include/sfx2/childwin.hxx   |2 ++
 sc/source/ui/inc/navipi.hxx |3 +--
 sc/source/ui/navipi/navipi.cxx  |   16 
 sc/source/ui/sidebar/ScPanelFactory.cxx |2 +-
 sfx2/source/appl/childwin.cxx   |   16 
 sw/source/uibase/inc/navipi.hxx |4 +---
 sw/source/uibase/sidebar/SwPanelFactory.cxx |2 +-
 sw/source/uibase/utlui/navipi.cxx   |   16 +++-
 8 files changed, 29 insertions(+), 32 deletions(-)

New commits:
commit 0cfda5204184fa937a948b3d273ac1083896bcc7
Author: Caolán McNamara 
Date:   Tue Jan 24 14:42:46 2017 +

Resolves: tdf#105450 calc navigator gets 0 height on toggle off/on when 
docked

Change-Id: Icd346cdf0a208ccaeddd77e6803f4f906361324c
(cherry picked from commit b37ac48935621fcc7b71f81a8b892f24e85e5b6f)
Reviewed-on: https://gerrit.libreoffice.org/33498
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/include/sfx2/childwin.hxx b/include/sfx2/childwin.hxx
index 3068d00..45d6a94 100644
--- a/include/sfx2/childwin.hxx
+++ b/include/sfx2/childwin.hxx
@@ -137,6 +137,8 @@ public:
 
 FloatingWindow* GetFloatingWindow() const;
 
+static FloatingWindow* GetFloatingWindow(vcl::Window *pParent);
+
 static void RegisterChildWindowContext(SfxModule*, sal_uInt16, 
SfxChildWinContextFactory*);
 };
 
diff --git a/sc/source/ui/inc/navipi.hxx b/sc/source/ui/inc/navipi.hxx
index ac588dd..c0dd4c7 100644
--- a/sc/source/ui/inc/navipi.hxx
+++ b/sc/source/ui/inc/navipi.hxx
@@ -194,7 +194,6 @@ private:
 OUStringaStrHidden;
 OUStringaStrActiveWin;
 
-boolbInSidebar;
 sal_uInt16  nZoomId;
 sal_uInt16  nChangeRootId;
 sal_uInt16  nDragModeId;
@@ -257,7 +256,7 @@ private:
 static void ReleaseFocus();
 
 public:
-ScNavigatorDlg(SfxBindings* pB, bool bSidebar, vcl::Window* pParent);
+ScNavigatorDlg(SfxBindings* pB, vcl::Window* pParent);
 virtual ~ScNavigatorDlg() override;
 virtual void dispose() override;
 
diff --git a/sc/source/ui/navipi/navipi.cxx b/sc/source/ui/navipi/navipi.cxx
index 4c5df44..fc96351 100644
--- a/sc/source/ui/navipi/navipi.cxx
+++ b/sc/source/ui/navipi/navipi.cxx
@@ -423,7 +423,7 @@ 
ScNavigatorDialogWrapper::ScNavigatorDialogWrapper(vcl::Window* pParent,
SfxChildWinInfo* /* pInfo 
*/)
 : SfxChildWindowContext(nId)
 {
-pNavigator = VclPtr::Create(pBind, false, pParent);
+pNavigator = VclPtr::Create(pBind, pParent);
 if (SfxNavigator* pNav = dynamic_cast(pParent))
 pNav->SetMinOutputSizePixel(pNavigator->GetOptimalSize());
 SetWindow(pNavigator);
@@ -434,13 +434,12 @@ 
ScNavigatorDialogWrapper::ScNavigatorDialogWrapper(vcl::Window* pParent,
 #define REGISTER_SLOT(i,id) \
 ppBoundItems[i]=new ScNavigatorControllerItem(id,*this,rBindings);
 
-ScNavigatorDlg::ScNavigatorDlg(SfxBindings* pB, bool bSidebar, vcl::Window* 
pParent)
+ScNavigatorDlg::ScNavigatorDlg(SfxBindings* pB, vcl::Window* pParent)
 : PanelLayout(pParent, "NavigatorPanel", 
"modules/scalc/ui/navigatorpanel.ui", nullptr)
 , rBindings(*pB)
 , aStrDragMode(ScResId(SCSTR_DRAGMODE))
 , aStrDisplay(ScResId(SCSTR_DISPLAY))
 , aStrActiveWin(ScResId(SCSTR_ACTIVEWIN))
-, bInSidebar(bSidebar)
 , pMarkArea(nullptr)
 , pViewData(nullptr )
 , eListMode(NAV_LMODE_NONE)
@@ -531,11 +530,11 @@ ScNavigatorDlg::ScNavigatorDlg(SfxBindings* pB, bool 
bSidebar, vcl::Window* pPar
 aContentIdle.SetIdleHdl( LINK( this, ScNavigatorDlg, TimeHdl ) );
 aContentIdle.SetPriority( SchedulerPriority::LOWEST );
 
-if (bInSidebar)
+if (!SfxChildWindowContext::GetFloatingWindow(GetParent()))
 {
-// When the navigator is displayed in the sidebar it has the whole deck
-// to fill. Therefore hide the button that hides all controls below
-// the top two rows of buttons.
+// When the navigator is displayed in the sidebar, or is otherwise
+// docked, it has the whole deck to fill. Therefore hide the button 
that
+// hides all controls below the top two rows of buttons.
 aTbxCmd->RemoveItem(aTbxCmd->GetItemPos(nZoomId));
 }
 aLbEntries->SetNavigatorDlgFlag(true);
@@ -841,7 +840,8 @@ void ScNavigatorDlg::SetListMode(NavListMode eMode)
 {
 if (eMode != eListMode)
 {
-bool bForceParentResize = (eMode == NAV_LMODE_NONE || eListMode == 
NAV_LMODE_NONE);
+bool bForceParentResize = 
SfxChildWindowContext::GetFloatingWindow(GetParent()) &&
+  (eMode == NAV_LMODE_NONE || eListMode == 
NAV_LMODE_NONE);
 SfxNavigator* pNav = bForceParentResize ? 
dynamic_cast(GetParent()) : nullptr;
 if (pNav && eMode == NAV_LMODE_NONE) //save last normal size on 

[Libreoffice-commits] online.git: common/MessageQueue.cpp

[Jan Holesovsky]

 common/MessageQueue.cpp |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 9d4eab1aba30a8f6bca1d0237f3cf86fe5862b14
Author: Jan Holesovsky 
Date:   Fri Jan 27 18:31:28 2017 +0100

Re-introduce the TileQueue depth logging.

Change-Id: I025aa9745d1b0a3306930323764957c6d84a0966

diff --git a/common/MessageQueue.cpp b/common/MessageQueue.cpp
index 05bdf58..5bf489d 100644
--- a/common/MessageQueue.cpp
+++ b/common/MessageQueue.cpp
@@ -423,6 +423,8 @@ void TileQueue::deprioritizePreviews()
 
 TileQueue::Payload TileQueue::get_impl()
 {
+LOG_TRC("MessageQueue depth: " << _queue.size());
+
 const auto front = _queue.front();
 
 auto msg = std::string(front.data(), front.size());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105573] PDF Export of XLSX with EMF images moves and distorts images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105573

--- Comment #8 from Rex  ---
Created attachment 130729
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130729=edit
pdf printout from libre office on laptop

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105573] PDF Export of XLSX with EMF images moves and distorts images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105573

--- Comment #7 from Rex  ---
Created attachment 130728
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130728=edit
pdf export from libre office on laptop

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105573] PDF Export of XLSX with EMF images moves and distorts images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105573

--- Comment #6 from Rex  ---
Created attachment 130727
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130727=edit
pdf printout from excel for comparison

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105573] PDF Export of XLSX with EMF images moves and distorts images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105573

--- Comment #5 from Rex  ---
Created attachment 130726
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130726=edit
pdf export from excel for comparison

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105573] PDF Export of XLSX with EMF images moves and distorts images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105573

--- Comment #4 from Rex  ---
Created attachment 130725
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130725=edit
pdf printout from libre office

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105573] PDF Export of XLSX with EMF images moves and distorts images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105573

--- Comment #3 from Rex  ---
Created attachment 130724
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130724=edit
pdf export from libre office

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105573] PDF Export of XLSX with EMF images moves and distorts images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105573

--- Comment #2 from Rex  ---
Created attachment 130723
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130723=edit
xlsx file created on laptop computer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105573] PDF Export of XLSX with EMF images moves and distorts images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105573

--- Comment #1 from Rex  ---
Created attachment 130722
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130722=edit
xlsx file created on desktop computer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sal

[Stephan Bergmann]

 include/sal/types.h |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 9ee0f108ca104ec76d2d73220686fb10c89e78e8
Author: Stephan Bergmann 
Date:   Fri Jan 27 18:04:53 2017 +0100

GCC 7 supports [[fallthrough]]

Change-Id: Ic6fb995a76a30b60b597005e714de03d43c36a7c

diff --git a/include/sal/types.h b/include/sal/types.h
index 3fc2be3..0aee648 100644
--- a/include/sal/types.h
+++ b/include/sal/types.h
@@ -448,6 +448,8 @@ namespace css = ::com::sun::star;
 #if defined LIBO_INTERNAL_ONLY
 #if defined __clang__
 #define SAL_FALLTHROUGH [[clang::fallthrough]]
+#elif defined __GNUC__ && __GNUC__ >= 7
+#define SAL_FALLTHROUGH [[fallthrough]]
 #else
 #define SAL_FALLTHROUGH
 #endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105573] New: PDF Export of XLSX with EMF images moves and distorts images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105573

Bug ID: 105573
   Summary: PDF Export of XLSX with EMF images moves and distorts
images
   Product: LibreOffice
   Version: 5.2.3.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: r...@dicad.de

Description:
An XLSX-File created in a CAD-Program (without use of Excel, LibreOffice or
OpenOffice) is opened by LibreOffice and a PDF Export (or printout) for further
propagation is made. 
Depending on computer contents of spreadsheet look acceptable (rexw10lap) or
lines are missing (rexw10) from EMF images. 
PDF export looks catastrophic. Images are moved nearly off page, sometimes text
is missing, many lines are missing.
Also simple attempt to print to PDF (using Soda PDF) delivers unsatisfactory
results.

To ensure reproducibility used two separate computers, both with Windows 10,
same CAD drawing in STRAKON (CAD-Program), same XLSX-settings, LibreOffice
5.2.3.3 and Soda PDF. Also for comparison used PDF exports and printouts from
OpenOffice and Excel.

Steps to Reproduce:
1. Open attatched bug17598_rexw10lap.xlsx
2. Export to PDF
3. Print using a PDF printer or any other printer

Actual Results:  
see PDF attatchments

Expected Results:
create PDF files similar to what is seen in LibreOffice spreadsheet on screen


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101
Firefox/50.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87700] UNO: New command to rotate image 180 degrees

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87700

--- Comment #13 from Commit Notification 
 ---
giacco committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee7e34696e3981c65dd5a13688976aead450a709

tdf#87700 command to rotate 180 degrees

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 87700] UNO: New command to rotate image 180 degrees

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87700

--- Comment #13 from Commit Notification 
 ---
giacco committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee7e34696e3981c65dd5a13688976aead450a709

tdf#87700 command to rotate 180 degrees

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: sw/source

[giacco]

 sw/source/uibase/shells/grfsh.cxx |   17 -
 1 file changed, 4 insertions(+), 13 deletions(-)

New commits:
commit ee7e34696e3981c65dd5a13688976aead450a709
Author: giacco 
Date:   Fri Jan 27 15:47:06 2017 +

tdf#87700 command to rotate 180 degrees

same things, with less code

Change-Id: Ied67277f1a48b58aba094f3ca650c08133e95d68
Reviewed-on: https://gerrit.libreoffice.org/33619
Tested-by: Jenkins 
Reviewed-by: Katarina Behrens 

diff --git a/sw/source/uibase/shells/grfsh.cxx 
b/sw/source/uibase/shells/grfsh.cxx
index 953fd25..ecbf507 100644
--- a/sw/source/uibase/shells/grfsh.cxx
+++ b/sw/source/uibase/shells/grfsh.cxx
@@ -867,20 +867,11 @@ void SwGrfShell::ExecuteRotation(SfxRequest )
 rShell.ReRead(OUString(), OUString(), const_cast());
 
 SwFlyFrameAttrMgr aManager(false, , rShell.IsFrameSelected() ? 
Frmmgr_Type::NONE : Frmmgr_Type::GRF);
-long nRotatedWidth = 0;
-long nRotatedHeight = 0;
-if(rReq.GetSlot() == SID_ROTATE_GRAPHIC_180)
-{
-   nRotatedWidth = aManager.GetSize().Width();
-   nRotatedHeight = aManager.GetSize().Height();
-
-}
-else
-{
-   nRotatedWidth = aManager.GetSize().Height();
-   nRotatedHeight = aManager.GetSize().Width();
 
-}
+long nRotatedWidth = aManager.GetSize().Height();
+long nRotatedHeight = aManager.GetSize().Width();
+if (rReq.GetSlot() == SID_ROTATE_GRAPHIC_180)
+  std::swap(nRotatedWidth, nRotatedHeight);
 Size aSize(nRotatedWidth, nRotatedHeight);
 aManager.SetSize(aSize);
 aManager.UpdateFlyFrame();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Usage of ActiveX in Libre Office

[Bryan Quigley]

Hi.

On Fri, Jan 27, 2017 at 11:07 AM,   wrote:
> Hi,
> Am 25.01.2017 um 20:43 schrieb Bryan Quigley:
>>
>> Welcome and thanks for responding to notice!
>>
>> You're the first person (AFAICT) who has written in response to the
>> deprecation notice.   My original intention was to remove it from the
>> 5.2 release if we got no responses to that notice (that obviously
>> hasn't happened).
>>
>> At this point the soonest release we could remove it from is 5.4
>> (which might be around Aug 2017).  It's far from scheduled though.
>>
>> We really don't have much data to base this decision on, so I'll ask
>> you instead.  Knowing keeping support has an impact on LibreOffice
>> development, when do you think is reasonable for ActiveX support to be
>> removed?
>
>
> IMHO ActiveX (aka COM) is a major technology in Windows, even if it will not
> be developed further because of .NET.

Looking back over my previous attempt, I think you might not be
affected.  (In any case COM/ATL support would not be dropped)

> A lot of software packages using this
> technology and I believe it will never be removed from Windows. Even if it
> disappears completely from internet services it will stay under the hood of
> Windows.
> But I also thought in the late 1970's that Pascal is the best programming
> language ever and will be the #1 in the future. Or when Java was introduced
> that this technology will die fast. So don't give too much on my opinion...
>
> So I can't answer the question. If the automation bridge is removed, we will
> stay with the last supported version of LO until we decide to get a new ERP.
>
> I didn't look into the code and I don't know how ActiveX is implemented. But
> if it doesn't need to be touched when something in UNO changes, is there a
> need to remove it?

It has been getting touched, but if I remember correctly we don't have
good coverage there.

I would suggest testing newer builds of LibreOffice to make sure it
keeps working as you expect.

The other problem was not having good test cases for making changes to
the code.  I do note in my original release notes "We specifically
want feedback if you use ActiveX to embed LibreOffice components into
your application."  Our original intention was to remove the plugin
that allows you to embed LibreOffice inside other applications (like
IE) using ActiveX.  Without test cases that worked, we weren't able to
ensure we wouldn't break something.

I don't currently have time to pursue this right now, but would be
interested in testing some custom builds to ensure that we remove the
right part of ActiveX while your use case keeps working?

Kind regards,
Bryan

>
>> What Windows version are you running?
>
>
> Windows 7
>
>>
>> Kind regards,
>> Bryan
>>
>> [The whole original thread - quite long]
>>
>> https://lists.freedesktop.org/archives/libreoffice/2015-December/071580.html
>
> Best regards
> Jörgen Pisarz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Usage of ActiveX in Libre Office

[Bryan Quigley]

I don't believe it would be affected, but it would need to be tested to be sure.

Thanks,
Bryan

On Wed, Jan 25, 2017 at 3:43 PM, sos  wrote:
> Bryan,
> Please clarify, will stuff like
>
> oShell = CreateObject("WScript.Shell")
>
> Still working after removing ActiveX?
> If not: then lots off API code will been broken and this will been a BIG
> regression ?
>
> Greetz
>
> Fernand
>
>
> Sent from my Samsung Galaxy smartphone.
>
>  Original message 
> From: Bryan Quigley 
> Date: 25/01/2017 20:43 (GMT+01:00)
> To: libreoffice@lists.freedesktop.org, libroffice@artavi.de
> Subject: re: Usage of ActiveX in Libre Office
>
> Welcome and thanks for responding to notice!
>
> You're the first person (AFAICT) who has written in response to the
> deprecation notice.   My original intention was to remove it from the
> 5.2 release if we got no responses to that notice (that obviously
> hasn't happened).
>
> At this point the soonest release we could remove it from is 5.4
> (which might be around Aug 2017).  It's far from scheduled though.
>
> We really don't have much data to base this decision on, so I'll ask
> you instead.  Knowing keeping support has an impact on LibreOffice
> development, when do you think is reasonable for ActiveX support to be
> removed?
>
> What Windows version are you running?
>
> Kind regards,
> Bryan
>
> [The whole original thread - quite long]
> https://lists.freedesktop.org/archives/libreoffice/2015-December/071580.html
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'feature/cib_contract57' - sal/osl

[Thorsten Behrens]

 sal/osl/all/log.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit c7f35d079fd364f236ce1df6ee1f32bb80d1cd22
Author: Thorsten Behrens 
Date:   Fri Jan 27 17:58:24 2017 +0100

sal: flush log-to-file, remove extra linefeeds otherwise

syslog and windows debugger console don't need explicit line feeds.
For ofstream, use endl which implies a flush.

Change-Id: Id94e07aa1ae042557052fab6483e5db75aada89d

diff --git a/sal/osl/all/log.cxx b/sal/osl/all/log.cxx
index 42fc5e8..c7ea797 100644
--- a/sal/osl/all/log.cxx
+++ b/sal/osl/all/log.cxx
@@ -346,7 +346,8 @@ void log(
   + (std::strncmp(where, SRCDIR "/", nStrLen) == 0
  ? nStrLen : 0));
 }
-s << message << '\n';
+s << message;
+
 #if defined ANDROID
 int android_log_level;
 switch (level) {
@@ -389,7 +390,7 @@ void log(
 } else {
 static std::ofstream * logFile = getLogFile();
 if (logFile) {
-*logFile << s.str();
+*logFile << s.str() << std::endl;
 }
 #if defined WNT
 else {
@@ -397,6 +398,7 @@ void log(
 }
 #else
 else {
+s << '\n';
 std::fputs(s.str().c_str(), stderr);
 std::fflush(stderr);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105560] "View > Grid Lines for Sheet" only affects current sheet, not all selected sheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105560

--- Comment #2 from gilward.ku...@gmail.com ---
Did you go to the View menu and choose "Grid Lines for Sheet"? That is what I
meant. Not the setting in Tools > Options > Calc > View.

Now I have tested it with 5.2.5.1. Same behaviour.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sal/osl

[Michael Stahl]

 sal/osl/w32/dllentry.c |   18 ++
 1 file changed, 18 insertions(+)

New commits:
commit 2fc5a65a1808ce4304ea55f06c4587a2459b5d52
Author: Michael Stahl 
Date:   Fri Jan 27 17:50:30 2017 +0100

sal: add SAL_NO_ASSERT_DIALOGS variable to redirect...

... the dialogs that pop up on assert() and abort() to stderr, which
should work better in CI builds.

Change-Id: I80ec95bae6cc21b8ac27f68ca93aa6c6cce707f4

diff --git a/sal/osl/w32/dllentry.c b/sal/osl/w32/dllentry.c
index 355c6b8..d336e70 100644
--- a/sal/osl/w32/dllentry.c
+++ b/sal/osl/w32/dllentry.c
@@ -23,6 +23,9 @@
 #include 
 #ifdef _MSC_VER
 #pragma warning(pop)
+#ifdef _DEBUG
+#include 
+#endif
 #endif
 #include 
 #include 
@@ -148,6 +151,21 @@ static BOOL WINAPI RawDllMain( HINSTANCE hinstDLL, DWORD 
fdwReason, LPVOID lpvRe
 {
 case DLL_PROCESS_ATTACH:
 {
+#ifdef _DEBUG
+WCHAR buf[64];
+DWORD const res = 
GetEnvironmentVariableW(L"SAL_NO_ASSERT_DIALOGS", buf, sizeof(buf));
+if (res && res < sizeof(buf))
+{
+// disable the dialog on abort()
+_CrtSetReportFile(_CRT_ERROR, _CRTDBG_FILE_STDERR);
+_CrtSetReportMode(_CRT_ERROR, 
(_CRTDBG_MODE_DEBUG|_CRTDBG_MODE_FILE));
+// not sure which assertions this affects
+_CrtSetReportFile(_CRT_ASSERT, _CRTDBG_FILE_STDERR);
+_CrtSetReportMode(_CRT_ASSERT, 
(_CRTDBG_MODE_DEBUG|_CRTDBG_MODE_FILE));
+// disable the dialog on assert(false)
+_set_error_mode(_OUT_TO_STDERR);
+}
+#endif
 #endif
 
 #if OSL_DEBUG_LEVEL < 2
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sc/source

[Eike Rathke]

 sc/source/ui/unoobj/appluno.cxx |   14 --
 sc/source/ui/unoobj/confuno.cxx |   56 +---
 2 files changed, 53 insertions(+), 17 deletions(-)

New commits:
commit 739353bcb420c18df6116cd645cc2226782e13cc
Author: Eike Rathke 
Date:   Thu Jan 26 17:51:17 2017 +0100

dissolve LinkUpdateMode confusion, document::Settings vs 
XGlobalSheetSettings

This is a combination of 3 commits.

this is css::sheet::XGlobalSheetSettings attribute LinkUpdateMode

... and not css::document::Settings property LinkUpdateMode.
It directly maps to ScLkUpdMode, LM_UNKNOWN isn't documented as a valid 
input value.

(cherry picked from commit 109cff60a3a18b20b2e0efefd0d49f6eab9b52fd)

remove now unused header file

(cherry picked from commit d03cacfb7b9b126e375dfeaeed2fcd74d4fa48fb)

this is the css::document::Settings property LinkUpdateMode

... not the css::sheet::XGlobalSheetSettings attribute LinkUpdateMode.

(cherry picked from commit 32d90e643e4d9285366169301af4342d871c0d94)

7a9696f07c1a6e1deec342f224343bd938078c2c
039c8d39e89e693de1c5a1a4218c2fca70a6de9f

Change-Id: I062a1fd32ad6a98db4f8e78de4724be1c8190407
Reviewed-on: https://gerrit.libreoffice.org/33600
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/ui/unoobj/appluno.cxx b/sc/source/ui/unoobj/appluno.cxx
index 2845341..989e45d 100644
--- a/sc/source/ui/unoobj/appluno.cxx
+++ b/sc/source/ui/unoobj/appluno.cxx
@@ -36,7 +36,6 @@
 #include "sc.hrc"
 #include "unonames.hxx"
 #include "funcdesc.hxx"
-#include 
 #include 
 #include 
 
@@ -263,18 +262,17 @@ void SAL_CALL ScSpreadsheetSettings::setPropertyValue(
 }
 else if (aPropertyName == SC_UNONAME_LINKUPD)
 {
+// XXX NOTE: this is not css::document::Settings property
+// LinkUpdateMode but css::sheet::XGlobalSheetSettings attribute
+// LinkUpdateMode.
 sal_Int16 n;
-if (!(aValue >>= n) || n < css::document::LinkUpdateModes::NEVER
-|| n > css::document::LinkUpdateModes::GLOBAL_SETTING)
+if (!(aValue >>= n) || n < 0 || n >= ScLkUpdMode::LM_UNKNOWN)
 {
 throw css::lang::IllegalArgumentException(
-("LinkUpdateMode property value must be a SHORT with a value 
in"
- " the range of the css.document.LinkUpdateModes constants"),
+("LinkUpdateMode property value must be a SHORT with a value 
in the range of 0--2"
+ " as documented for css::sheet::XGlobalSheetSettings 
attribute LinkUpdateMode"),
 css::uno::Reference(), -1);
 }
-//TODO: ScLkUpdMode (LM_ALWAYS=0, LM_NEVER=1, LM_ON_DEMAND=2,
-// LM_UNKNOWN=3) does not match css.document.LinkUpdateModes (NEVER=0,
-// MANUAL=1, AUTO=2, GLOBAL_SETTINGS=3):
 aAppOpt.SetLinkMode( static_cast(n) );
 bSaveApp = true;
 }
diff --git a/sc/source/ui/unoobj/confuno.cxx b/sc/source/ui/unoobj/confuno.cxx
index 7377860..b7f0c32 100644
--- a/sc/source/ui/unoobj/confuno.cxx
+++ b/sc/source/ui/unoobj/confuno.cxx
@@ -30,6 +30,7 @@
 #include "sc.hrc"
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -158,18 +159,36 @@ void SAL_CALL ScDocumentConfiguration::setPropertyValue(
 aViewOpt.SetOption(VOPT_PAGEBREAKS, 
ScUnoHelpFunctions::GetBoolFromAny( aValue ) );
 else if ( aPropertyName == SC_UNONAME_LINKUPD )
 {
+// XXX NOTE: this is the css::document::Settings property
+// LinkUpdateMode, not the css::sheet::XGlobalSheetSettings
+// attribute LinkUpdateMode.
 sal_Int16 n;
-//TODO: css.sheet.XGlobalSheetSettings LinkUpdateMode property is
-// documented to take values in the range 0--2 (always, never, on
-// demand), but appears to be routinely set to 3 here,
-// corresponding to ScLkUpdMode LM_UNKNOWN:
-if (!(aValue >>= n) || n < 0 || n > 3) {
+if (!(aValue >>= n) || n < css::document::LinkUpdateModes::NEVER ||
+n > css::document::LinkUpdateModes::GLOBAL_SETTING)
+{
 throw css::lang::IllegalArgumentException(
-("LinkUpdateMode property value must be a SHORT in the"
- " range 0--3"),
+("LinkUpdateMode property value must be a SHORT with a 
value in"
+ " the range of the css::document::LinkUpdateModes 
constants"),
 css::uno::Reference(), -1);
 }
-rDoc.SetLinkMode( static_cast(n) );
+ScLkUpdMode eMode;
+switch (n)
+{
+case css::document::LinkUpdateModes::NEVER:
+eMode = LM_NEVER;
+break;
+   

[Libreoffice-bugs] [Bug 99150] Writer freezes when changing font (gen and gtk backends)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99150

--- Comment #8 from Buovjaga  ---
(In reply to Guillaume from comment #7)
> Debug informations are not available for Debian testing amd64. Sorry, I
> can't install them. 
> 
> https://packages.debian.org/search?keywords=libreoffice-calc-dbgsym

Ok, you could try this, if you have enough disk space:
http://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@70-TDF-dbg/current/
You can just extract it with tar -xvzf and then run program/soffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sc/source

[Eike Rathke]

 sc/source/core/tool/interpr4.cxx |   51 ++-
 1 file changed, 45 insertions(+), 6 deletions(-)

New commits:
commit ea525e91338a164bbc76954869295f1e939095ae
Author: Eike Rathke 
Date:   Fri Jan 27 14:55:20 2017 +0100

Resolves: tdf#105558 accept numeric BASIC return types as numeric

... not only SbxINTEGER, SbxLONG, SbxSINGLE and SbxDOUBLE.

Change-Id: I75d892f5ae60ef1b18bd86e64777dea746e35a1f
(cherry picked from commit 9a283e44ca7de2f2fa276544b4d49cff495bd53d)
Reviewed-on: https://gerrit.libreoffice.org/33616
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 4c34994..f266491 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -3122,6 +3122,34 @@ static bool lcl_setVBARange( ScRange& aRange, 
ScDocument* pDok, SbxVariable* pPa
 return bOk;
 }
 
+static bool lcl_isNumericResult( double& fVal, const SbxVariable* pVar )
+{
+switch (pVar->GetType())
+{
+case SbxINTEGER:
+case SbxLONG:
+case SbxSINGLE:
+case SbxDOUBLE:
+case SbxCURRENCY:
+case SbxDATE:
+case SbxUSHORT:
+case SbxULONG:
+case SbxINT:
+case SbxUINT:
+case SbxSALINT64:
+case SbxSALUINT64:
+case SbxDECIMAL:
+fVal = pVar->GetDouble();
+return true;
+case SbxBOOL:
+fVal = (pVar->GetBool() ? 1.0 : 0.0);
+return true;
+default:
+;   // nothing
+}
+return false;
+}
+
 #endif
 
 void ScInterpreter::ScMacro()
@@ -3341,6 +3369,7 @@ void ScInterpreter::ScMacro()
 pMacroMgr->AddDependentCell(pModule->GetName(), pMyFormulaCell);
 }
 
+double fVal;
 SbxDataType eResType = refRes->GetType();
 if( SbxBase::GetError() )
 {
@@ -3350,9 +3379,21 @@ void ScInterpreter::ScMacro()
 {
 PushNoValue();
 }
-else if( eResType >= SbxINTEGER && eResType <= SbxDOUBLE )
+else if (lcl_isNumericResult( fVal, refRes.get()))
 {
-PushDouble( refRes->GetDouble() );
+switch (eResType)
+{
+case SbxDATE:
+nFuncFmtType = css::util::NumberFormat::DATE;
+break;
+case SbxBOOL:
+nFuncFmtType = css::util::NumberFormat::LOGICAL;
+break;
+// Do not add SbxCURRENCY, we don't know which currency.
+default:
+;   // nothing
+}
+PushDouble( fVal );
 }
 else if ( eResType & SbxARRAY )
 {
@@ -3387,7 +3428,6 @@ void ScInterpreter::ScMacro()
 if ( pMat )
 {
 SbxVariable* pV;
-SbxDataType eType;
 for ( SCSIZE j=0; j < nR; j++ )
 {
 sal_Int32 nIdx[ 2 ];
@@ -3398,10 +3438,9 @@ void ScInterpreter::ScMacro()
 {
 nIdx[ nColIdx ] = nCs + static_cast(i);
 pV = pDimArray->Get32( nIdx );
-eType = pV->GetType();
-if ( eType >= SbxINTEGER && eType <= SbxDOUBLE )
+if ( lcl_isNumericResult( fVal, pV) )
 {
-pMat->PutDouble( pV->GetDouble(), i, j );
+pMat->PutDouble( fVal, i, j );
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99150] Writer freezes when changing font (gen and gtk backends)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99150

--- Comment #7 from Guillaume  ---
Debug informations are not available for Debian testing amd64. Sorry, I can't
install them. 

https://packages.debian.org/search?keywords=libreoffice-calc-dbgsym

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105548] DATEDIF function rounding leads to a compatibility issue between calc and excel.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105548

--- Comment #5 from m.a.riosv  ---
(1)
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=4e71be498903dee5bf719a73f4976bb5356335dd
(2)
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=40c8170c5281cd7b19313a79f902ef9715351c9f

On both commits dates variables are defined as:
 double nDate2= GetDouble();
 double nDate1= GetDouble();

and days are calculate
(1) int  dd = nDate2 - nDate1; 
(2) long dd = nDate2 - nDate1;

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sc/source

[Caolán McNamara]

 sc/source/ui/dbgui/PivotLayoutDialog.cxx|   17 +
 sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx  |   23 ---
 sc/source/ui/dbgui/PivotLayoutTreeListLabel.cxx |7 ---
 sc/source/ui/inc/PivotLayoutDialog.hxx  |5 ++---
 sc/source/ui/inc/PivotLayoutTreeListBase.hxx|3 ---
 5 files changed, 19 insertions(+), 36 deletions(-)

New commits:
commit 839d9fa764921258abd48336142a1383f95f5808
Author: Caolán McNamara 
Date:   Thu Jan 26 09:12:24 2017 +

Resolves: tdf#104153 crash on drag and drop pivot table field

This is a combination of 2 commits.

Resolves: tdf#104153 crash on drag and drop pivot table field

now though sometimes it doesn't get removed at all, so a band aid
for the moment

(cherry picked from commit 068edb65b1dce375223d8642a01b07db3948ac03)

Resolves: tdf#104153 lookup what listbox an entry is dragged from

so we can find where its been dragged from in order to remove it from that
source, rather than relying that it comes from the previously focused 
listbox

Reviewed-on: https://gerrit.libreoffice.org/33575
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 
(cherry picked from commit 011bae55cdd24a1d3e42f0aa2fcfd98d3ddc9b14)

e6aa1a311b46e5e9ee96cab05e0705b794b5eb0b

Change-Id: I6ccbbe51fe9250af0f85c30a9d253269a18df457
Reviewed-on: https://gerrit.libreoffice.org/33630
Reviewed-by: Eike Rathke 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/ui/dbgui/PivotLayoutDialog.cxx 
b/sc/source/ui/dbgui/PivotLayoutDialog.cxx
index 312fdd3..5503c5e 100644
--- a/sc/source/ui/dbgui/PivotLayoutDialog.cxx
+++ b/sc/source/ui/dbgui/PivotLayoutDialog.cxx
@@ -70,8 +70,6 @@ ScPivotLayoutDialog::ScPivotLayoutDialog(
 ScViewData* pViewData, const ScDPObject* 
pPivotTableObject, bool bNewPivotTable) :
 ScAnyRefDlg   (pSfxBindings, pChildWindow, pParent, 
"PivotTableLayout", "modules/scalc/ui/pivottablelayoutdialog.ui"),
 maPivotTableObject(*pPivotTableObject),
-mpPreviouslyFocusedListBox(nullptr),
-mpCurrentlyFocusedListBox(nullptr),
 mpViewData(pViewData),
 mpDocument(pViewData->GetDocument()),
 mbNewPivotTable   (bNewPivotTable),
@@ -189,8 +187,6 @@ ScPivotLayoutDialog::~ScPivotLayoutDialog()
 
 void ScPivotLayoutDialog::dispose()
 {
-mpPreviouslyFocusedListBox.clear();
-mpCurrentlyFocusedListBox.clear();
 mpListBoxField.clear();
 mpListBoxPage.clear();
 mpListBoxColumn.clear();
@@ -736,4 +732,17 @@ void ScPivotLayoutDialog::ToggleDestination()
 mpDestinationEdit->Enable(bSelection);
 }
 
+ScPivotLayoutTreeListBase* ScPivotLayoutDialog::FindListBoxFor(SvTreeListEntry 
*pEntry)
+{
+if (mpListBoxPage->HasEntry(pEntry))
+return mpListBoxPage.get();
+if (mpListBoxColumn->HasEntry(pEntry))
+return mpListBoxColumn.get();
+if (mpListBoxRow->HasEntry(pEntry))
+return mpListBoxRow.get();
+if (mpListBoxData->HasEntry(pEntry))
+return mpListBoxData.get();
+return nullptr;
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx 
b/sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx
index 7b72f7b..1fd79e9 100644
--- a/sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx
+++ b/sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx
@@ -119,27 +119,4 @@ void 
ScPivotLayoutTreeListBase::RemoveEntryForItem(ScItemValue* pItemValue)
 }
 }
 
-void ScPivotLayoutTreeListBase::GetFocus()
-{
-SvTreeListBox::GetFocus();
-
-if( GetGetFocusFlags() & GetFocusFlags::Mnemonic )
-{
-SvTreeListEntry* pEntry = 
mpParent->mpPreviouslyFocusedListBox->GetCurEntry();
-if (pEntry)
-InsertEntryForSourceTarget(pEntry, nullptr);
-
-if (mpParent->mpPreviouslyFocusedListBox != nullptr)
-mpParent->mpPreviouslyFocusedListBox->GrabFocus();
-}
-
-mpParent->mpCurrentlyFocusedListBox = this;
-}
-
-void ScPivotLayoutTreeListBase::LoseFocus()
-{
-SvTreeListBox::LoseFocus();
-if (mpParent)
-mpParent->mpPreviouslyFocusedListBox = this;
-}
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/dbgui/PivotLayoutTreeListLabel.cxx 
b/sc/source/ui/dbgui/PivotLayoutTreeListLabel.cxx
index 3795601..9073faa 100644
--- a/sc/source/ui/dbgui/PivotLayoutTreeListLabel.cxx
+++ b/sc/source/ui/dbgui/PivotLayoutTreeListLabel.cxx
@@ -57,10 +57,11 @@ void 
ScPivotLayoutTreeListLabel::FillLabelFields(ScDPLabelDataVector& rLabelVect
 }
 }
 
-void ScPivotLayoutTreeListLabel::InsertEntryForSourceTarget(SvTreeListEntry* 
/*pSource*/, SvTreeListEntry* /*pTarget*/)
+void 

[Libreoffice-bugs] [Bug 97163] Writer: Import .docx: wrong alignment or padding with small formulas in text lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97163

Buovjaga  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #5 from Buovjaga  ---
I confirm it works now.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: 63fd4c97118a943c84ba5a666cf8c9cc54b511c7
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on January 22th 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 5 commits - basic/source libreofficekit/qa libreofficekit/source

[Stephan Bergmann]

 basic/source/comp/token.cxx |6 
 basic/source/inc/token.hxx  |1 
 libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |  209 ++--
 libreofficekit/source/gtk/lokdocview.cxx|   36 +++
 4 files changed, 225 insertions(+), 27 deletions(-)

New commits:
commit 71511385dd6b12c3a902424652087e780fd7f3ba
Author: Stephan Bergmann 
Date:   Fri Jan 27 17:27:22 2017 +0100

Just pass in OUString directly

Change-Id: Idf7d63672e8b330499e53c1395dedb92d25bb76a

diff --git a/basic/source/comp/token.cxx b/basic/source/comp/token.cxx
index 40397d3..f422147 100644
--- a/basic/source/comp/token.cxx
+++ b/basic/source/comp/token.cxx
@@ -242,12 +242,6 @@ void SbiTokenizer::Push( SbiToken t )
 else ePush = t;
 }
 
-void SbiTokenizer::Error( SbError code, const char* pMsg )
-{
-aError = OUString::createFromAscii( pMsg );
-Error( code );
-}
-
 void SbiTokenizer::Error( SbError code, const OUString  )
 {
 aError = aMsg;
diff --git a/basic/source/inc/token.hxx b/basic/source/inc/token.hxx
index 43f535b..f9d7c0d 100644
--- a/basic/source/inc/token.hxx
+++ b/basic/source/inc/token.hxx
@@ -158,7 +158,6 @@ public:
 
 void Error( SbError c ) { GenError( c ); }
 void Error( SbError, SbiToken );
-void Error( SbError, const char* );
 void Error( SbError, const OUString &);
 
 static bool IsEoln( SbiToken t )
commit 464d9249d44d2b36d5334d42ad8b38aab62c3f47
Author: Pranav Kant 
Date:   Wed Jan 25 16:22:39 2017 +0530

gtktiledviewer: Can reply, delete comments from sidebar

... and put the sidebar in a scrolled window

Change-Id: I57e982c849ed0c4dda4e8f5fdbcb0b85e46da36c

diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx 
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index 8c81b66..8286b18 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -50,6 +50,8 @@ public:
 GtkWidget* m_pViewAnnotationsButton;
 /// top level container for all comments in the sidebar
 GtkWidget* m_pCommentsVBox;
+/// scrolled window for main comments box
+GtkWidget* m_pScrolledWindow;
 
 /// Prepare and return a comment object (GtkBox)
 static GtkWidget* createCommentBox(const boost::property_tree::ptree& 
aComment);
@@ -279,6 +281,47 @@ static void userPromptDialog(GtkWidget* pDocView, const 
std::string& aTitle, std
 gtk_widget_destroy(pDialog);
 }
 
+static void replyButtonClicked(GtkWidget* pWidget, gpointer userdata)
+{
+TiledWindow& rWindow = lcl_getTiledWindow(pWidget);
+std::map aEntries;
+aEntries["Text"] = "";
+
+userPromptDialog(rWindow.m_pDocView, "Reply comment", aEntries);
+
+int *commentId = static_cast(g_object_get_data(G_OBJECT(userdata), 
"id"));
+
+boost::property_tree::ptree aTree;
+aTree.put(boost::property_tree::ptree::path_type(g_strconcat("Id", "/", 
"type", nullptr), '/'), "long");
+aTree.put(boost::property_tree::ptree::path_type(g_strconcat("Id", "/", 
"value", nullptr), '/'), std::to_string(*commentId));
+
+aTree.put(boost::property_tree::ptree::path_type(g_strconcat("Text", "/", 
"type", nullptr), '/'), "string");
+aTree.put(boost::property_tree::ptree::path_type(g_strconcat("Text", "/", 
"value", nullptr), '/'), aEntries["Text"]);
+
+std::stringstream aStream;
+boost::property_tree::write_json(aStream, aTree);
+std::string aArguments = aStream.str();
+
+lok_doc_view_post_command(LOK_DOC_VIEW(rWindow.m_pDocView), 
".uno:ReplyComment", aArguments.c_str(), false);
+}
+
+static void deleteCommentButtonClicked(GtkWidget* pWidget, gpointer userdata)
+{
+TiledWindow& rWindow = lcl_getTiledWindow(pWidget);
+
+int *commentid = static_cast(g_object_get_data(G_OBJECT(userdata), 
"id"));
+
+boost::property_tree::ptree aTree;
+aTree.put(boost::property_tree::ptree::path_type(g_strconcat("Id", "/", 
"type", nullptr), '/'), "long");
+aTree.put(boost::property_tree::ptree::path_type(g_strconcat("Id", "/", 
"value", nullptr), '/'), std::to_string(*commentid));
+
+std::stringstream aStream;
+boost::property_tree::write_json(aStream, aTree);
+std::string aArguments = aStream.str();
+
+lok_doc_view_post_command(LOK_DOC_VIEW(rWindow.m_pDocView), 
".uno:DeleteComment", aArguments.c_str(), false);
+}
+
 GtkWidget* CommentsSidebar::createCommentBox(const 
boost::property_tree::ptree& aComment)
 {
 GtkWidget* pCommentVBox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 1);
@@ -292,8 +335,13 @@ GtkWidget* CommentsSidebar::createCommentBox(const 
boost::property_tree::ptree&
 GtkWidget* pControlsHBox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 0);
 GtkWidget* pGotoButton = gtk_button_new_with_label("Goto");
 GtkWidget* pReplyButton = gtk_button_new_with_label("Reply");
+GtkWidget* pDeleteButton = 

[Libreoffice-commits] core.git: vcl/inc vcl/source

[Khaled Hosny]

 vcl/inc/sallayout.hxx|1 -
 vcl/source/gdi/sallayout.cxx |7 ---
 2 files changed, 8 deletions(-)

New commits:
commit 7c2e96a4e7733e315bf948dd89a5d804cef5e67e
Author: Khaled Hosny 
Date:   Fri Jan 27 18:16:22 2017 +0200

DisableGlyphInjection does nothing

Change-Id: Ie97eac46fde075bd74c7adb583b8be979f3af829

diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index 542eebf..16a83f8 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -187,7 +187,6 @@ public:
 virtual voidMoveGlyph( int nStart, long nNewXPos ) = 0;
 virtual voidDropGlyph( int nStart ) = 0;
 virtual voidSimplify( bool bIsBase ) = 0;
-virtual voidDisableGlyphInjection( bool /*bDisable*/ ) {}
 
 virtual std::shared_ptr
 CreateTextLayoutCache(OUString const&) const;
diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
index 6a970f9..79b3140 100644
--- a/vcl/source/gdi/sallayout.cxx
+++ b/vcl/source/gdi/sallayout.cxx
@@ -1203,9 +1203,6 @@ void MultiSalLayout::AdjustLayout( ImplLayoutArgs& rArgs )
 }
 mpLayouts[n]->AdjustLayout( aMultiArgs );
 
-// disable glyph-injection for glyph-fallback SalLayout iteration
-SalLayout::DisableGlyphInjection( true );
-
 // remove unused parts of component
 if( n > 0 )
 {
@@ -1433,10 +1430,6 @@ void MultiSalLayout::AdjustLayout( ImplLayoutArgs& rArgs 
)
 }
 
 mpLayouts[0]->Simplify( true );
-
-// reenable glyph-injection
-for( n = 0; n < mnLevel; ++n )
-SalLayout::DisableGlyphInjection( false );
 }
 
 void MultiSalLayout::InitFont() const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: desktop/qa

[Pranav Kant]

 desktop/qa/data/comments.odt|binary
 desktop/qa/desktop_lib/test_desktop_lib.cxx |  141 
 2 files changed, 141 insertions(+)

New commits:
commit 4f60b300d230fe963d133b4725eb3e93dfb500e1
Author: Pranav Kant 
Date:   Thu Jan 26 01:02:57 2017 +0530

lok: Unit test for comments api

Change-Id: Ieedb50a4d376c1214ea23b56c8cab19c96c159d0
Reviewed-on: https://gerrit.libreoffice.org/33615
Reviewed-by: pranavk 
Tested-by: pranavk 

diff --git a/desktop/qa/data/comments.odt b/desktop/qa/data/comments.odt
new file mode 100644
index 000..ee7f15f
Binary files /dev/null and b/desktop/qa/data/comments.odt differ
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 666deb4..b53461f 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -33,6 +33,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -103,6 +104,8 @@ public:
 void testPaintPartTile();
 void testWriterCommentInsertCursor();
 void testGetFontSubset();
+void testNoTiledAnnotations();
+void testCommentsCallbacks();
 
 CPPUNIT_TEST_SUITE(DesktopLOKTest);
 CPPUNIT_TEST(testGetStyles);
@@ -138,6 +141,8 @@ public:
 CPPUNIT_TEST(testPaintPartTile);
 CPPUNIT_TEST(testWriterCommentInsertCursor);
 CPPUNIT_TEST(testGetFontSubset);
+CPPUNIT_TEST(testNoTiledAnnotations);
+CPPUNIT_TEST(testCommentsCallbacks);
 CPPUNIT_TEST_SUITE_END();
 
 uno::Reference mxComponent;
@@ -159,6 +164,7 @@ public:
 // for testContextMenu{Calc, Writer}
 osl::Condition m_aContextMenuCondition;
 boost::property_tree::ptree m_aContextMenuResult;
+
 };
 
 LibLODocument_Impl* DesktopLOKTest::loadDoc(const char* pName, 
LibreOfficeKitDocumentType eType)
@@ -1686,6 +1692,7 @@ class ViewCallback
 public:
 bool m_bTilesInvalidated;
 Rectangle m_aOwnCursor;
+boost::property_tree::ptree m_aCommentCallbackResult;
 
 ViewCallback()
 : m_bTilesInvalidated(false)
@@ -1719,6 +1726,14 @@ public:
 m_aOwnCursor.setHeight(aSeq[3].toInt32());
 }
 break;
+case LOK_CALLBACK_COMMENT:
+{
+m_aCommentCallbackResult.clear();
+std::stringstream aStream(pPayload);
+boost::property_tree::read_json(aStream, m_aCommentCallbackResult);
+m_aCommentCallbackResult = 
m_aCommentCallbackResult.get_child("comment");
+}
+break;
 }
 }
 };
@@ -1833,6 +1848,132 @@ void DesktopLOKTest::testGetFontSubset()
 comphelper::LibreOfficeKit::setActive(false);
 }
 
+void DesktopLOKTest::testNoTiledAnnotations()
+{
+comphelper::LibreOfficeKit::setActive();
+// Disable tiled rendering for comments
+comphelper::LibreOfficeKit::setTiledAnnotations(false);
+
+LibLODocument_Impl* pDocument = loadDoc("comments.odt");
+pDocument->m_pDocumentClass->initializeForRendering(pDocument, nullptr);
+long nWidth, nHeight;
+pDocument->m_pDocumentClass->getDocumentSize(pDocument, , );
+
+// Document width alongwith without sidebar comes to be < 13000
+CPPUNIT_ASSERT( nWidth < 13000 );
+
+// Can we get all the comments using .uno:ViewAnnotations command ?
+boost::property_tree::ptree aTree;
+char* pJSON = pDocument->m_pDocumentClass->getCommandValues(pDocument, 
".uno:ViewAnnotations");
+std::stringstream aStream(pJSON);
+free(pJSON);
+CPPUNIT_ASSERT(!aStream.str().empty());
+boost::property_tree::read_json(aStream, aTree);
+// There are 3 comments in the document already
+CPPUNIT_ASSERT_EQUAL(static_cast(3), 
aTree.get_child("comments").size());
+
+int nComment2Id = 0;
+// Check if all comment fields have valid data
+for (boost::property_tree::ptree::value_type& rComment : 
aTree.get_child("comments"))
+{
+CPPUNIT_ASSERT(rComment.second.get("id") > 0);
+CPPUNIT_ASSERT(!rComment.second.get("author").empty());
+CPPUNIT_ASSERT(!rComment.second.get("text").empty());
+// Has a valid iso 8601 date time string
+css::util::DateTime aDateTime;
+OUString aDateTimeString = 
OUString::createFromAscii(rComment.second.get("dateTime").c_str());
+CPPUNIT_ASSERT(utl::ISO8601parseDateTime(aDateTimeString, aDateTime));
+
+// This comment has a marked text range
+if (rComment.second.get("text") == "Comment 2")
+{
+
CPPUNIT_ASSERT(!rComment.second.get("textRange").empty());
+nComment2Id = rComment.second.get("id");
+}
+// This is a reply comment
+else if (rComment.second.get("text") == "Reply to Comment 
2")
+{
+CPPUNIT_ASSERT_EQUAL(nComment2Id, 
rComment.second.get("parent"));
+}
+}
+
+comphelper::LibreOfficeKit::setActive(false);
+}
+

[Libreoffice-commits] core.git: basic/source

[Stephan Bergmann]

 basic/source/comp/parser.cxx |9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

New commits:
commit 8c78aa379f520f25aa888269f5080583b12b9e6a
Author: Stephan Bergmann 
Date:   Fri Jan 27 17:15:43 2017 +0100

Just pass in OUString directly

Change-Id: Id9bd288080fdd5ed4dfaee77b697954ad7bc2458

diff --git a/basic/source/comp/parser.cxx b/basic/source/comp/parser.cxx
index da7048d..f930a6c 100644
--- a/basic/source/comp/parser.cxx
+++ b/basic/source/comp/parser.cxx
@@ -835,19 +835,14 @@ void SbiParser::Option()
 }
 }
 
-void addStringConst( SbiSymPool& rPool, const char* pSym, const OUString& rStr 
)
+void addStringConst( SbiSymPool& rPool, const OUString& pSym, const OUString& 
rStr )
 {
-SbiConstDef* pConst = new SbiConstDef( OUString::createFromAscii( pSym ) );
+SbiConstDef* pConst = new SbiConstDef( pSym );
 pConst->SetType( SbxSTRING );
 pConst->Set( rStr );
 rPool.Add( pConst );
 }
 
-inline void addStringConst( SbiSymPool& rPool, const char* pSym, const char* 
pStr )
-{
-addStringConst( rPool, pSym, OUString::createFromAscii( pStr ) );
-}
-
 void SbiParser::AddConstants()
 {
 // #113063 Create constant RTL symbols
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99150] Writer freezes when changing font (gen and gtk backends)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99150

Buovjaga  changed:

   What|Removed |Added

   Priority|medium  |high
 Status|REOPENED|NEW
Version|5.2.4.2 release |5.0.5.2 release
Summary|Writer freezes when |Writer freezes when
   |changing font   |changing font (gen and gtk
   ||backends)
   Severity|normal  |major

--- Comment #6 from Buovjaga  ---
Guillaume: thanks. You could try getting a valgrind log of the trace:
https://wiki.documentfoundation.org/QA/BugReport/Debug_Information

Note that you need debug symbols.

To get the valgrind log, after entering the frozen state, you can kill the
soffice process.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Usage of ActiveX in Libre Office

[libroffice . dev]

Hi,

Am 25.01.2017 um 21:31 schrieb Kaganski Mike:
Just wanted to mention two (now discontinued) projects that aimed to 
provide alternative ActiveX MS Office-compatible APIs for 
OpenOffice.org: AutomateIT! 
(https://sourceforge.net/projects/automateit/) and UniOffice 
(http://wiki.etersoft.ru/UniOffice, 
http://ftp.etersoft.ru/pub/Etersoft/UniOffice@Etersoft/). They are 
open-source, and may be of some interest if someone wants to take the 
code and improve/maintain it. In Russia, there were a number of 
working solutions based on them, so they are at least working starting 
point.


Thanks for the information.
I looked into the sources. Both using ActiveX to control OOo. They are 
only translators which forms OOo-style interfaces to MSOffice-style 
interfaces.

Both will not work anymore if ActiveX support is removed.


--
Best regards,
Mike Kaganski

Best regards
Jörgen Pisarz

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: libreofficekit/qa libreofficekit/source

[Pranav Kant]

 libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |   23 +++--
 libreofficekit/source/gtk/lokdocview.cxx|   27 +++-
 2 files changed, 42 insertions(+), 8 deletions(-)

New commits:
commit 3616f875b014b7d58f81cd871ff7bbf9fd6c78d5
Author: Pranav Kant 
Date:   Tue Jan 24 17:41:54 2017 +0530

lokdocview: Separate gobject property for turning off comments

Pass --enable-tiled-annotations to gtktiledviewer on command line
to turn comments on again, by default they are turned off now.

Change-Id: I40e93ab683ec9538e088ae9aa83cda2eaaf9939e
Reviewed-on: https://gerrit.libreoffice.org/33622
Reviewed-by: pranavk 
Tested-by: pranavk 

diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx 
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index cb32cd6..c2faacd 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -288,7 +288,11 @@ gboolean CommentsSidebar::docConfigureEvent(GtkWidget* 
pDocView, GdkEventConfigu
 TiledWindow& rWindow = lcl_getTiledWindow(pDocView);
 LibreOfficeKitDocument* pDocument = 
lok_doc_view_get_document(LOK_DOC_VIEW(pDocView));
 
-if (pDocument && pDocument->pClass->getDocumentType(pDocument) == 
LOK_DOCTYPE_TEXT)
+// whether tield rendering is turned on
+gboolean bTiledAnnotations;
+g_object_get(G_OBJECT(pDocView), "tiled-annotations", , 
nullptr);
+
+if (!bTiledAnnotations && pDocument && 
pDocument->pClass->getDocumentType(pDocument) == LOK_DOCTYPE_TEXT)
 {
 if (!rWindow.m_pCommentsSidebar)
 {
@@ -933,19 +937,20 @@ static void toggleFindbar(GtkWidget* pButton, gpointer 
/*pItem*/)
 }
 
 static void
-setLOKFeatures (GtkWidget* pDocView)
+setLOKFeatures (GtkWidget* pDocView, gboolean bTiledAnnotations)
 {
 g_object_set(G_OBJECT(pDocView),
  "doc-password", TRUE,
  "doc-password-to-modify", TRUE,
+ "tiled-annotations", bTiledAnnotations,
  nullptr);
 }
 
 /// Common initialization, regardless if it's just a new view or a full init.
-static TiledWindow& setupWidgetAndCreateWindow(GtkWidget* pDocView)
+static TiledWindow& setupWidgetAndCreateWindow(GtkWidget* pDocView, gboolean 
bTiledAnnotations)
 {
 setupDocView(pDocView);
-setLOKFeatures(pDocView);
+setLOKFeatures(pDocView, bTiledAnnotations);
 TiledWindow aWindow;
 aWindow.m_pDocView = pDocView;
 GtkWidget* pWindow = createWindow(aWindow);
@@ -974,8 +979,9 @@ static void createView(GtkWidget* pButton, gpointer 
/*pItem*/)
 std::string aArguments = aStream.str();
 
 GtkWidget* pDocView = 
lok_doc_view_new_from_widget(LOK_DOC_VIEW(rWindow.m_pDocView), 
aArguments.c_str());
-
-TiledWindow& rNewWindow = setupWidgetAndCreateWindow(pDocView);
+gboolean bTiledAnnotations;
+g_object_get(G_OBJECT(rWindow.m_pDocView), "tiled-annotations", 
, nullptr);
+TiledWindow& rNewWindow = setupWidgetAndCreateWindow(pDocView, 
bTiledAnnotations);
 // Hide the unused progress bar.
 gtk_widget_show_all(rNewWindow.m_pStatusBar);
 gtk_widget_hide(rNewWindow.m_pProgressBar);
@@ -988,17 +994,20 @@ static void createView(GtkWidget* pButton, gpointer 
/*pItem*/)
 static void createModelAndView(const char* pLOPath, const char* pDocPath, 
const std::vector& rArguments)
 {
 std::string aUserProfile;
+gboolean bTiledAnnotations = FALSE;
 for (size_t i = 0; i < rArguments.size(); ++i)
 {
 const std::string& rArgument = rArguments[i];
 if (rArgument == "--user-profile" && i + 1 < rArguments.size())
 aUserProfile = std::string("vnd.sun.star.pathname:")
 + rArguments[i + 1].c_str();
+else if (rArgument == "--enable-tiled-annotations")
+bTiledAnnotations = TRUE;
 }
 const gchar* pUserProfile = aUserProfile.empty() ? nullptr : 
aUserProfile.c_str();
 GtkWidget* pDocView = lok_doc_view_new_from_user_profile(pLOPath, 
pUserProfile, nullptr, nullptr);
 
-TiledWindow& rWindow = setupWidgetAndCreateWindow(pDocView);
+TiledWindow& rWindow = setupWidgetAndCreateWindow(pDocView, 
bTiledAnnotations);
 
 boost::property_tree::ptree aTree;
 for (size_t i = 0; i < rArguments.size(); ++i)
diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index 1cd2c05..80d40f5 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -299,6 +299,7 @@ enum
 PROP_CAN_ZOOM_OUT,
 PROP_DOC_PASSWORD,
 PROP_DOC_PASSWORD_TO_MODIFY,
+PROP_TILED_ANNOTATIONS,
 
 PROP_LAST
 };
@@ -2465,6 +2466,7 @@ static void lok_doc_view_set_property (GObject* object, 
guint propId, const GVal
 LOKDocViewPrivate& priv = getPrivate(pDocView);
 gboolean bDocPasswordEnabled = priv->m_nLOKFeatures & 

[Libreoffice-commits] core.git: libreofficekit/qa

[Pranav Kant]

 libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |   98 +++-
 1 file changed, 96 insertions(+), 2 deletions(-)

New commits:
commit 99a2a1f975da68c33ec213fab0f9cf75c31b49c8
Author: Pranav Kant 
Date:   Tue Jan 24 17:08:33 2017 +0530

gtktiledviewer: Comments sidebar

Change-Id: Icf5bb78859668bfb5c43efc3e5fa9afce8458f41
Reviewed-on: https://gerrit.libreoffice.org/33621
Reviewed-by: pranavk 
Tested-by: pranavk 

diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx 
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index 03f0852..cb32cd6 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -40,6 +40,24 @@ static int help()
 return 1;
 }
 
+/// Represents the comment sidebar widget (only for text documents as of now)
+class CommentsSidebar
+{
+public:
+/// Main Vertical Box containing comments box and additional controls (eg. 
buttons)
+GtkWidget* m_pMainVBox;
+/// Button to issue a .uno:ViewAnnotations command
+GtkWidget* m_pViewAnnotationsButton;
+/// top level container for all comments in the sidebar
+GtkWidget* m_pCommentsVBox;
+
+/// Click even handler for m_pViewAnnotationsButton
+static void unoViewAnnotations(GtkWidget* pWidget, gpointer userdata);
+/// Configure event handler for window
+static gboolean docConfigureEvent(GtkWidget* pWidget, GdkEventConfigure* 
pEvent, gpointer pData);
+};
+
+
 /// Represents the row or column header widget for spreadsheets.
 class TiledRowColumnBar
 {
@@ -128,6 +146,7 @@ public:
 std::map m_aToolItemSensitivities;
 bool m_bToolItemBroadcast;
 GtkWidget* m_pVBox;
+GtkWidget* m_pMainHBox;
 GtkComboBoxText* m_pPartSelector;
 GtkWidget* m_pPartModeComboBox;
 /// Should the part selector avoid calling lok::Document::setPart()?
@@ -139,6 +158,7 @@ public:
 std::shared_ptr m_pRowBar;
 std::shared_ptr m_pColumnBar;
 std::shared_ptr m_pCornerButton;
+std::shared_ptr m_pCommentsSidebar;
 /// Rendering arguments, which are the same for all views.
 boost::property_tree::ptree m_aRenderingArguments;
 
@@ -218,6 +238,75 @@ static void lcl_registerToolItem(TiledWindow& rWindow, 
GtkToolItem* pItem, const
 rWindow.m_aToolItemSensitivities[pItem] = true;
 }
 
+void CommentsSidebar::unoViewAnnotations(GtkWidget* pWidget, gpointer 
/*userdata*/)
+{
+TiledWindow& rWindow = lcl_getTiledWindow(pWidget);
+
+LibreOfficeKitDocument* pDocument = 
lok_doc_view_get_document(LOK_DOC_VIEW(rWindow.m_pDocView));
+char* pValues = pDocument->pClass->getCommandValues(pDocument, 
".uno:ViewAnnotations");
+g_info("lok::Document::getCommandValues(%s) : %s", ".uno:ViewAnnotations", 
pValues);
+std::stringstream aStream(pValues);
+free(pValues);
+
+gtk_widget_destroy(rWindow.m_pCommentsSidebar->m_pCommentsVBox);
+
+rWindow.m_pCommentsSidebar->m_pCommentsVBox = 
gtk_box_new(GTK_ORIENTATION_VERTICAL, 2);
+gtk_container_add(GTK_CONTAINER(rWindow.m_pCommentsSidebar->m_pMainVBox), 
rWindow.m_pCommentsSidebar->m_pCommentsVBox);
+
+boost::property_tree::ptree aTree;
+boost::property_tree::read_json(aStream, aTree);
+try
+{
+for (boost::property_tree::ptree::value_type& rValue : 
aTree.get_child("comments"))
+{
+GtkWidget* pCommentVBox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 1);
+
gtk_container_add(GTK_CONTAINER(rWindow.m_pCommentsSidebar->m_pCommentsVBox), 
pCommentVBox);
+
+GtkWidget* pCommentText = 
gtk_label_new(rValue.second.get("text").c_str());
+GtkWidget* pCommentAuthor = 
gtk_label_new(rValue.second.get("author").c_str());
+GtkWidget* pCommentDate = 
gtk_label_new(rValue.second.get("dateTime").c_str());
+GtkWidget* pCommentSeparator = 
gtk_separator_new(GTK_ORIENTATION_HORIZONTAL);
+
+gtk_container_add(GTK_CONTAINER(pCommentVBox), pCommentText);
+gtk_container_add(GTK_CONTAINER(pCommentVBox), pCommentAuthor);
+gtk_container_add(GTK_CONTAINER(pCommentVBox), pCommentDate);
+gtk_container_add(GTK_CONTAINER(pCommentVBox), pCommentSeparator);
+
+gtk_label_set_line_wrap(GTK_LABEL(pCommentText), TRUE);
+gtk_label_set_max_width_chars(GTK_LABEL(pCommentText), 35);
+}
+gtk_widget_show_all(rWindow.m_pCommentsSidebar->m_pCommentsVBox);
+}
+catch(boost::property_tree::ptree_bad_path& rException)
+{
+std::cerr << "CommentsSidebar::unoViewAnnotations: failed to get 
comments" << rException.what() << std::endl;
+}
+}
+
+gboolean CommentsSidebar::docConfigureEvent(GtkWidget* pDocView, 
GdkEventConfigure* /*pEvent*/, gpointer /*userdata*/)
+{
+TiledWindow& rWindow = lcl_getTiledWindow(pDocView);
+LibreOfficeKitDocument* pDocument = 

[Libreoffice-bugs] [Bug 105561] Entries of LibreOffice modules does not appear in context menus of corresponding MS Office files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105561

V Stuart Foote  changed:

   What|Removed |Added

 CC||mikekagan...@hotmail.com,
   ||tima...@gmail.com,
   ||vstuart.fo...@utsa.edu
  Component|LibreOffice |Installation

--- Comment #3 from V Stuart Foote  ---
I have correct Windows shell OpenWith context menu entries on Windows 10 Pro
64-bit en-US with Version: 5.3.0.2 (x64)
Build ID: 5ad7b2889021c491af62f7930a4b1cb631392f16
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; Layout Engine: new; 
Locale: en-US (en_US); Calc: group

None of the HKCR\Applications you want to set are present on my install and it
functions correctly, don't beleive I've set the associations individually but
this was not a clean install.

However, believe your attached REG files are not necessary--and are actually
ill-advised as they preclude using a different path than the [INSTALLLOCATION]
of the MSI package sets. Problem lies elsewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105567] [MS Publisher] imported document absolutely unusable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105567

Paolo Benvenuto  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INVALID

--- Comment #3 from Paolo Benvenuto  ---
ok purged and reinstalled, bug invalid

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs