[Libreoffice-commits] core.git: sw/qa writerfilter/source

[Miklos Vajna]

 sw/qa/extras/rtfimport/rtfimport.cxx|   19 ++-
 writerfilter/source/rtftok/rtfdispatchvalue.cxx |4 ++--
 2 files changed, 16 insertions(+), 7 deletions(-)

New commits:
commit 481293fcf5740cbc739e1e7d7f6082acbfb0cdf6
Author: Miklos Vajna 
Date:   Mon Jan 30 08:28:17 2017 +0100

Indentation fixes

Change-Id: I22247da71d1594187c531ca5552cf75363aaddfd

diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx 
b/sw/qa/extras/rtfimport/rtfimport.cxx
index e71be6a..c574e39 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -1616,17 +1616,26 @@ DECLARE_RTFIMPORT_TEST(testCp118, "cp118.rtf")
 CPPUNIT_ASSERT_EQUAL(aExpected, xTextRange->getString());
 }
 
-class testTdf105511 : public Test {
+class testTdf105511 : public Test
+{
 protected:
-virtual OUString getTestName() override { return 
OUString("testTdf105511"); }
+virtual OUString getTestName() override
+{
+return OUString("testTdf105511");
+}
 public:
 CPPUNIT_TEST_SUITE(testTdf105511);
 CPPUNIT_TEST(Import);
 CPPUNIT_TEST_SUITE_END();
 
-void Import() {
-struct DefaultLocale : public 
comphelper::ConfigurationProperty {
-static OUString path() { return 
OUString("/org.openoffice.Office.Linguistic/General/DefaultLocale"); }
+void Import()
+{
+struct DefaultLocale : public 
comphelper::ConfigurationProperty
+{
+static OUString path()
+{
+return 
OUString("/org.openoffice.Office.Linguistic/General/DefaultLocale");
+}
 ~DefaultLocale() = delete;
 };
 auto batch = comphelper::ConfigurationChanges::create();
diff --git a/writerfilter/source/rtftok/rtfdispatchvalue.cxx 
b/writerfilter/source/rtftok/rtfdispatchvalue.cxx
index a63eee1..72833ee 100644
--- a/writerfilter/source/rtftok/rtfdispatchvalue.cxx
+++ b/writerfilter/source/rtftok/rtfdispatchvalue.cxx
@@ -394,8 +394,8 @@ RTFError RTFDocumentImpl::dispatchValue(RTFKeyword 
nKeyword, int nParam)
 case RTF_CPG:
 {
 rtl_TextEncoding nEncoding = (nParam == 0) ?
-
utl_getWinTextEncodingFromLangStr(getLODefaultLanguage().toUtf8().getStr()) :
-rtl_getTextEncodingFromWindowsCodePage(nParam);
+ 
utl_getWinTextEncodingFromLangStr(getLODefaultLanguage().toUtf8().getStr()) :
+ 
rtl_getTextEncodingFromWindowsCodePage(nParam);
 if (nKeyword == RTF_ANSICPG)
 m_aDefaultState.nCurrentEncoding = nEncoding;
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 94903] Digital Signatures are not working with 64-Bit LibreOffice 5.0.2.2 and 32-Bit LibreOffice 5.2.x in Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94903

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Depends on||89037


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89037
[Bug 89037] Enhancement: native OpenGPG support
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89037] Enhancement: native OpenGPG support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89037

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||katarina.behr...@cib.de,
   ||s.mehrbr...@gmail.com,
   ||t...@libreoffice.org
 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105566] Show InfoBar when document has invalid signature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105566

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 105566] Show InfoBar when document has invalid signature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105566

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Depends on||105566


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105566
[Bug 105566] Show InfoBar when document has invalid signature
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Depends on||83876


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83876
[Bug 83876] Digital signature: Support multiple signings / APPEND mode
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Depends on||58184


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=58184
[Bug 58184] Can not add digital signature via digital signature management
dialog
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83876] Digital signature: Support multiple signings / APPEND mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83876

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58184] Can not add digital signature via digital signature management dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58184

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77888] [basic] Macro editor: Digital Signature menu entry isn' t working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77888

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Depends on||77888


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=77888
[Bug 77888] [basic] Macro editor: Digital Signature menu entry isn't working
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Depends on||83877


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83877
[Bug 83877] Digital signature: Support visual identification / signature lines
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Depends on||98545


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98545
[Bug 98545] Digital signature with elliptic curve certificate not working
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83877] Digital signature: Support visual identification / signature lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83877

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Depends on||88927


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=88927
[Bug 88927] Trusted timestamping for digital signature
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88927] Trusted timestamping for digital signature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88927

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102276] Digital signature does not work with Windows 10

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102276

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Depends on||102277


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102277
[Bug 102277] Saving a version deletes the Digital Signature
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98545] Digital signature with elliptic curve certificate not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98545

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Depends on||102276


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102276
[Bug 102276] Digital signature does not work with Windows 10
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102277] Saving a version deletes the Digital Signature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102277

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105604] Firebird error when creating a table containing a VARCHAR with by default value 32765

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105604

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org//show_bug.cgi?id=7
   ||1251

--- Comment #1 from Julien Nabet  ---
tdf#71251 had been fixed by putting max value from 32767 to 32765. I tested
again and now the max length value is 8191 for a varchar

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105013] time of digital signature is zero in File > Properties > General

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105013

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Depends on||105013


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105013
[Bug 105013] time of digital signature is zero in File > Properties > General
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Depends on||105606


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105606
[Bug 105606] Digital Signatures Helptext missing Windows & macOS instructions
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94903] Digital Signatures are not working with 64-Bit LibreOffice 5.0.2.2 and 32-Bit LibreOffice 5.2.x in Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94903

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Depends on||94903


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=94903
[Bug 94903] Digital Signatures are not working with 64-Bit LibreOffice 5.0.2.2
and 32-Bit LibreOffice 5.2.x in Windows
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105606] New: Digital Signatures Helptext missing Windows & macOS instructions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105606

Bug ID: 105606
   Summary: Digital Signatures Helptext missing Windows & macOS
instructions
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: s.mehrbr...@gmail.com
CC: olivier.hal...@documentfoundation.org
Blocks: 105605

The help text for digital signatures has only instructions for Linux. Windows
and macOS are missing.

https://help.libreoffice.org/Common/Applying_Digital_Signatures


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] New: [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Bug ID: 105605
   Summary: [META] Digital signatures bugs and enhancements
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: s.mehrbr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||s.mehrbr...@gmail.com
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105604] New: Firebird error when creating a table containing a VARCHAR with by default value 32765

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105604

Bug ID: 105604
   Summary: Firebird error when creating a table containing a
VARCHAR with by default value 32765
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: serval2...@yahoo.fr

Description:
On pc Debian x86-64 with master sources updated 3 days ago + enable-dbgutil, I
can't create a table on Firebird with when it contains VARCHAR

Steps to Reproduce:
1. Enable experimental features (required for Firebird)
2. Launch Base
3. Create a brand new ODB file with Firebird
4. Click on Tables pane
5. Select Use Wizard to Create Table...
=> Business category is selected by default
=> Tasks table is selected by default
6. Select Notes and put it to right
7. Click Finish




Actual Results:  
=> popup error message

on console
warn:connectivity.firebird:6627:1:connectivity/source/drivers/firebird/Util.cxx:52:
firebird_sdbc error:
*Dynamic SQL Error
*SQL error code = -842
*Short integer expected
caused by
'isc_dsql_prepare'

Expected Results:
No error, table created


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Firefox/45.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: ucb/source

[Noel Grandin]

 ucb/source/ucp/tdoc/tdoc_content.cxx |   13 +
 ucb/source/ucp/tdoc/tdoc_content.hxx |2 --
 ucb/source/ucp/tdoc/tdoc_contentcaps.cxx |5 -
 3 files changed, 1 insertion(+), 19 deletions(-)

New commits:
commit b67bdae596a1f6027e8ed4150172b0ed7be3f10f
Author: Noel Grandin 
Date:   Mon Jan 30 08:49:56 2017 +0200

NO_STREAM_CREATION_WITHIN_DOCUMENT_ROOT is always true

and has been for more than a decade

Change-Id: I81dd8c6db0b3a961d2e2f2dfb4c0fb97704756d8

diff --git a/ucb/source/ucp/tdoc/tdoc_content.cxx 
b/ucb/source/ucp/tdoc/tdoc_content.cxx
index 91eb14c..aae1913 100644
--- a/ucb/source/ucp/tdoc/tdoc_content.cxx
+++ b/ucb/source/ucp/tdoc/tdoc_content.cxx
@@ -457,7 +457,6 @@ uno::Any SAL_CALL Content::execute(
 // Unreachable
 }
 
-#ifdef NO_STREAM_CREATION_WITHIN_DOCUMENT_ROOT
 if ( eType == STREAM )
 {
 Uri aUri( m_xIdentifier->getContentIdentifier() );
@@ -475,7 +474,7 @@ uno::Any SAL_CALL Content::execute(
 // Unreachable
 }
 }
-#endif
+
 ucb::InsertCommandArgument aArg;
 if ( !( aCommand.Argument >>= aArg ) )
 {
@@ -668,7 +667,6 @@ Content::createNewContent( const ucb::ContentInfo& Info )
 
 bool bCreateFolder = Info.Type == TDOC_FOLDER_CONTENT_TYPE;
 
-#ifdef NO_STREAM_CREATION_WITHIN_DOCUMENT_ROOT
 // streams cannot be created as direct children of document root
 if ( !bCreateFolder && ( m_aProps.getType() == DOCUMENT ) )
 {
@@ -676,7 +674,6 @@ Content::createNewContent( const ucb::ContentInfo& Info )
 "created as direct children of document root!" );
 return uno::Reference< ucb::XContent >();
 }
-#endif
 if ( !bCreateFolder && Info.Type != TDOC_STREAM_CONTENT_TYPE )
 {
 OSL_FAIL( "Content::createNewContent - unsupported type!" );
@@ -1563,7 +1560,6 @@ void Content::insert( const uno::Reference< 
io::XInputStream >& xData,
 
 Uri aUri( m_xIdentifier->getContentIdentifier() );
 
-#ifdef NO_STREAM_CREATION_WITHIN_DOCUMENT_ROOT
 #if OSL_DEBUG_LEVEL > 0
 if ( eType == STREAM )
 {
@@ -1573,7 +1569,6 @@ void Content::insert( const uno::Reference< 
io::XInputStream >& xData,
 "children of document root!" );
 }
 #endif
-#endif
 
 // Check, if all required properties were set.
 if ( eType == FOLDER )
@@ -1966,7 +1961,6 @@ void Content::transfer(
 }
 }
 
-#ifdef NO_STREAM_CREATION_WITHIN_DOCUMENT_ROOT
 if ( m_aProps.getType() == DOCUMENT )
 {
 bool bOK = false;
@@ -2018,7 +2012,6 @@ void Content::transfer(
 // Unreachable
 }
 }
-#endif
 
 
 // Copy data.
@@ -2887,7 +2880,6 @@ ContentProperties::getCreatableContentsInfo() const
 cppu::UnoType::get(),
 beans::PropertyAttribute::BOUND );
 
-#ifdef NO_STREAM_CREATION_WITHIN_DOCUMENT_ROOT
 if ( getType() == DOCUMENT )
 {
 // streams cannot be created as direct children of document root
@@ -2902,7 +2894,6 @@ ContentProperties::getCreatableContentsInfo() const
 }
 else
 {
-#endif
 uno::Sequence< ucb::ContentInfo > aSeq( 2 );
 
 // Folder.
@@ -2919,9 +2910,7 @@ ContentProperties::getCreatableContentsInfo() const
 aSeq.getArray()[ 1 ].Properties = aProps;
 
 return aSeq;
-#ifdef NO_STREAM_CREATION_WITHIN_DOCUMENT_ROOT
 }
-#endif
 }
 else
 {
diff --git a/ucb/source/ucp/tdoc/tdoc_content.hxx 
b/ucb/source/ucp/tdoc/tdoc_content.hxx
index 25502ba..d17f189 100644
--- a/ucb/source/ucp/tdoc/tdoc_content.hxx
+++ b/ucb/source/ucp/tdoc/tdoc_content.hxx
@@ -26,8 +26,6 @@
 #include 
 #include "tdoc_provider.hxx"
 
-#define NO_STREAM_CREATION_WITHIN_DOCUMENT_ROOT 1
-
 namespace com { namespace sun { namespace star {
 namespace sdbc  { class XRow; }
 namespace io{ class XInputStream; class XOutputStream; }
diff --git a/ucb/source/ucp/tdoc/tdoc_contentcaps.cxx 
b/ucb/source/ucp/tdoc/tdoc_contentcaps.cxx
index 254cb27..9857ec8 100644
--- a/ucb/source/ucp/tdoc/tdoc_contentcaps.cxx
+++ b/ucb/source/ucp/tdoc/tdoc_contentcaps.cxx
@@ -47,9 +47,6 @@
 transfer-   x   x   -   -   -
 createNewContent-   x   x   -   -   -
 
-#ifdef NO_STREAM_CREATION_WITHIN_DOCUMENT_ROOT
- (*) not supported by streams that are direct children of document
-#endif
 
  */
 
@@ -346,7 +343,6 @@ uno::Sequence< ucb::CommandInfo > Content::getCommands(
 
 if ( m_aProps.getType() == STREAM )
 {
-#ifdef NO_STREAM_CREATION_WITHIN_DOCUMENT_ROOT
 Uri aUri( m_xIdentifier->getContentIdentifier() );
 Uri aParentUri( aUri.getParentUri() );
 
@@ -401,7 +397,6 @@ uno::Sequence< ucb::CommandInfo > 

[Libreoffice-commits] core.git: instsetoo_native/inc_ooohelppack instsetoo_native/inc_openoffice instsetoo_native/inc_sdkoo

[fakabbir]

 instsetoo_native/inc_ooohelppack/windows/msi_templates/codes.txt|   38 
-
 instsetoo_native/inc_ooohelppack/windows/msi_templates/codes_ooodev.txt |   38 
-
 instsetoo_native/inc_openoffice/windows/msi_templates/codes.txt |   40 
+-
 instsetoo_native/inc_openoffice/windows/msi_templates/codes_ooodev.txt  |   40 
+-
 instsetoo_native/inc_sdkoo/windows/msi_templates/codes.txt  |   38 
-
 5 files changed, 97 insertions(+), 97 deletions(-)

New commits:
commit 78220c485cf9d25bd4078299b2d6e96a49bad7de
Author: fakabbir 
Date:   Sun Jan 29 19:23:04 2017 +0530

tdf#105568 Language code has to be arranged

Language code has been arranged in
alphabetical order for given files.

Change-Id: Ib2ade0857bc5dd1a77348fbec470747abae4893e
Reviewed-on: https://gerrit.libreoffice.org/33661
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/instsetoo_native/inc_ooohelppack/windows/msi_templates/codes.txt 
b/instsetoo_native/inc_ooohelppack/windows/msi_templates/codes.txt
index ed072ed..45c1acc 100644
--- a/instsetoo_native/inc_ooohelppack/windows/msi_templates/codes.txt
+++ b/instsetoo_native/inc_ooohelppack/windows/msi_templates/codes.txt
@@ -17,36 +17,36 @@
 #
 
 [PRODUCTCODE]
-en-US = "{0F961BE5-98E8-408E-9F74-23CBA0523922}"
-pt = "{2C127D50-B7E4-46C3-A845-CF6684481024}"
-ru = "{8B523028-4AAC-4607-9711-667AA6C37D45}"
+ar = "{FF72555B-A96D-49F8-8998-9359E9F9F7E1}"
+ca = "{9810C5F8-C061-4D02-AD98-049452A5DC76}"
+cs = "{781C904C-8768-4271-AA69-1A2CFA248002}"
+da = "{92CA37C8-B2E6-403F-932C-1A33E48BCD7E}"
+de = "{5014304D-99B3-4451-8EB3-97D34658E4E7}"
 el = "{F980E77E-21FD-40B8-BE66-8BC60284D24B}"
-nl = "{7FE69A49-6825-47E0-8179-72336E7B4250}"
-fr = "{3BB61EBF-5BC1-4E4D-859F-3ED5D92DD25E}"
+en-GB = "{DD0CE074-E875-4428-991B-A9B3734701F9}"
+en-US = "{0F961BE5-98E8-408E-9F74-23CBA0523922}"
 es = "{12A4616B-D51B-4013-964B-0ACCCA5E9AF2}"
+et = "{956362F1-C89B-4008-B15F-968BD4023F3F}"
 fi = "{89623507-9F44-44CF-BD4C-042F9E26F903}"
+fr = "{3BB61EBF-5BC1-4E4D-859F-3ED5D92DD25E}"
+he = "{F59C6731-12DA-4A46-BE6D-30934E7CD763}"
+hi = "{61B2E7EA-DC12-4A51-B152-2B95A4FC2ABF}"
 hu = "{2246FA05-4B7A-499B-A19E-AA6599EA28D0}"
-ca = "{9810C5F8-C061-4D02-AD98-049452A5DC76}"
 it = "{2F78D54B-CE1D-4607-AA5B-D52114BDEBDB}"
-cs = "{781C904C-8768-4271-AA69-1A2CFA248002}"
-sk = "{A1D39E12-FF85-4619-BC69-001C55AD5B35}"
-en-GB = "{DD0CE074-E875-4428-991B-A9B3734701F9}"
-da = "{92CA37C8-B2E6-403F-932C-1A33E48BCD7E}"
-sv = "{942C29ED-A013-436E-861C-28271FD60AAE}"
+ja = "{01C118C0-57AB-4745-8D4C-5A34E6677E8D}"
+ko = "{B0DEE1A7-88FC-423B-AA1F-F51D94D02996}"
+nl = "{7FE69A49-6825-47E0-8179-72336E7B4250}"
 no = "{0EF3EE40-3690-472E-A693-5C9AE4FA7D5A}"
 pl = "{2A7F7A26-EF8B-4990-8836-688508886215}"
-de = "{5014304D-99B3-4451-8EB3-97D34658E4E7}"
+pt = "{2C127D50-B7E4-46C3-A845-CF6684481024}"
 pt-BR = "{55837A64-5B73-4CDC-8950-AF56E09A7961}"
+ru = "{8B523028-4AAC-4607-9711-667AA6C37D45}"
+sk = "{A1D39E12-FF85-4619-BC69-001C55AD5B35}"
+sv = "{942C29ED-A013-436E-861C-28271FD60AAE}"
 th = "{2EEACF3C-C38E-4043-8B4D-33A461083348}"
-et = "{956362F1-C89B-4008-B15F-968BD4023F3F}"
-ja = "{01C118C0-57AB-4745-8D4C-5A34E6677E8D}"
-ko = "{B0DEE1A7-88FC-423B-AA1F-F51D94D02996}"
+tr = "{467D9E65-2614-4D19-B40F-0B12FE6E472F}"
 zh-CN = "{0C596167-BA94-4D5A-B63B-6566FE06259A}"
 zh-TW = "{C31C87A1-5918-4178-8696-DDD36EDAEE99}"
-tr = "{467D9E65-2614-4D19-B40F-0B12FE6E472F}"
-hi = "{61B2E7EA-DC12-4A51-B152-2B95A4FC2ABF}"
-ar = "{FF72555B-A96D-49F8-8998-9359E9F9F7E1}"
-he = "{F59C6731-12DA-4A46-BE6D-30934E7CD763}"
 multiwestern = "{FA30E08E-DD61-4E47-B3D6-51B2814CA881}"
 multiasia = "{222033CB-A588-4302-9942-311F160B63B1}"
 
diff --git 
a/instsetoo_native/inc_ooohelppack/windows/msi_templates/codes_ooodev.txt 
b/instsetoo_native/inc_ooohelppack/windows/msi_templates/codes_ooodev.txt
index 477c091..3f5b6e9 100644
--- a/instsetoo_native/inc_ooohelppack/windows/msi_templates/codes_ooodev.txt
+++ b/instsetoo_native/inc_ooohelppack/windows/msi_templates/codes_ooodev.txt
@@ -17,36 +17,36 @@
 #
 
 [PRODUCTCODE]
-en-US = "{0FA6115B-EB2C-4878-AE77-A6BB9BD95DE3}"
-pt = "{5908E447-DD83-466C-989A-4DD73EEB9E1C}"
-ru = "{A2FA035D-6AD1-4A42-8C94-514862DDF9F1}"
+ar = "{11EDE09B-CE84-4042-B40D-09F3A9CF7484}"
+ca = "{A398A8FC-7E6B-45D0-9869-63D67B38AEEE}"
+cs = "{2288EAF3-AC96-4EE5-BEFB-1384DC1C4703}"
+da = "{DBF68601-B962-4B0F-8791-E91225E6AF4E}"
+de = "{5A5DE00E-D6F0-426E-A510-AFCD45564AFB}"
 el = "{ED03F985-453B-4C05-9D4F-5A5DABC5E383}"
-nl = "{3F832B47-935F-45D2-870F-59CBC55EBAF5}"
-fr = "{C96C5113-0A94-4D78-8B56-63335845A6DB}"
+en-GB = "{4840BF58-E8E1-4625-9F65-D7A6B26438C7}"
+en-US = "{0FA6115B-EB2C-4878-AE77-A6BB9BD95DE3}"
 es = "{00393DC6-C022-4013-85D6-7421431A1BBC}"
+et = "{5A742EFB-07B8-42AB-A451-60BBE2461102}"
 fi = "{B2414CEC-4AF1-4943-88F8-C5011A860483}"
+fr = "{C96C5113-0A94-4D78-8B56-63335845A6DB}"
+he 

[Libreoffice-commits] core.git: include/xmloff xmloff/source

[Noel Grandin]

 include/xmloff/xmlnumfe.hxx  |2 +-
 xmloff/source/core/xmlexp.cxx|4 +---
 xmloff/source/style/xmlnumfe.cxx |   14 --
 3 files changed, 10 insertions(+), 10 deletions(-)

New commits:
commit 9734a6e1c3930c29aa3c7b80cb896d57c2bebe31
Author: Noel Grandin 
Date:   Sun Jan 29 12:28:45 2017 +0200

GetWasUsed can return by value, no need to be a special snowflake

Change-Id: I4ef22fa49ee883ff0bddb49d1711e8521905502f
Reviewed-on: https://gerrit.libreoffice.org/33658
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/xmloff/xmlnumfe.hxx b/include/xmloff/xmlnumfe.hxx
index 905a6e3..b4792a8 100644
--- a/include/xmloff/xmlnumfe.hxx
+++ b/include/xmloff/xmlnumfe.hxx
@@ -114,7 +114,7 @@ public:
 // get the style name that was generated for a key
 OUString GetStyleName( sal_uInt32 nKey );
 
-void GetWasUsed(css::uno::Sequence& rWasUsed);
+css::uno::Sequence GetWasUsed();
 void SetWasUsed(const css::uno::Sequence& rWasUsed);
 
 
diff --git a/xmloff/source/core/xmlexp.cxx b/xmloff/source/core/xmlexp.cxx
index cd8a9c4..077cb4f 100644
--- a/xmloff/source/core/xmlexp.cxx
+++ b/xmloff/source/core/xmlexp.cxx
@@ -557,9 +557,7 @@ SvXMLExport::~SvXMLExport()
 OUString sWrittenNumberFormats(XML_WRITTENNUMBERSTYLES);
 if 
(xPropertySetInfo->hasPropertyByName(sWrittenNumberFormats))
 {
-uno::Sequence aWasUsed;
-mpNumExport->GetWasUsed(aWasUsed);
-mxExportInfo->setPropertyValue(sWrittenNumberFormats, 
Any(aWasUsed));
+mxExportInfo->setPropertyValue(sWrittenNumberFormats, 
Any(mpNumExport->GetWasUsed()));
 }
 }
 }
diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx
index bb5db1b..07e4ac2 100644
--- a/xmloff/source/style/xmlnumfe.cxx
+++ b/xmloff/source/style/xmlnumfe.cxx
@@ -106,7 +106,7 @@ public:
 boolGetFirstUsed(sal_uInt32& nKey);
 boolGetNextUsed(sal_uInt32& nKey);
 
-void GetWasUsed(uno::Sequence& rWasUsed);
+uno::Sequence GetWasUsed();
 void SetWasUsed(const uno::Sequence& rWasUsed);
 };
 
@@ -182,10 +182,10 @@ bool SvXMLNumUsedList_Impl::GetNextUsed(sal_uInt32& nKey)
 return bRet;
 }
 
-void SvXMLNumUsedList_Impl::GetWasUsed(uno::Sequence& rWasUsed)
+uno::Sequence SvXMLNumUsedList_Impl::GetWasUsed()
 {
-rWasUsed.realloc(nWasUsedCount);
-sal_Int32* pWasUsed = rWasUsed.getArray();
+uno::Sequence ret(nWasUsedCount);
+sal_Int32* pWasUsed = ret.getArray();
 if (pWasUsed)
 {
 SvXMLuInt32Set::const_iterator aItr = aWasUsed.begin();
@@ -196,6 +196,7 @@ void 
SvXMLNumUsedList_Impl::GetWasUsed(uno::Sequence& rWasUsed)
 ++pWasUsed;
 }
 }
+return ret;
 }
 
 void SvXMLNumUsedList_Impl::SetWasUsed(const uno::Sequence& 
rWasUsed)
@@ -1889,10 +1890,11 @@ void SvXMLNumFmtExport::SetUsed( sal_uInt32 nKey )
 }
 }
 
-void SvXMLNumFmtExport::GetWasUsed(uno::Sequence& rWasUsed)
+uno::Sequence SvXMLNumFmtExport::GetWasUsed()
 {
 if (pUsedList)
-pUsedList->GetWasUsed(rWasUsed);
+return pUsedList->GetWasUsed();
+return uno::Sequence();
 }
 
 void SvXMLNumFmtExport::SetWasUsed(const uno::Sequence& rWasUsed)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104315] Creating a table of contents with a whitespace between Entry and Tab stop causes the last character of the entry to be removed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104315

Aron Budea  changed:

   What|Removed |Added

   Assignee|wolff-ohlenb...@t-online.de |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104693] make screenshot produces upside-down back-to-front screenshot texts on macOS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104693

--- Comment #2 from Commit Notification 
 ---
Thorsten Behrens committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8145a80868aeb2d81abdeb2918942911c6d128f4

tdf#104693: screenshot: fix mirrored mac screenshots

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104693] make screenshot produces upside-down back-to-front screenshot texts on macOS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104693

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/quartz

[Thorsten Behrens]

 vcl/inc/quartz/salbmp.h |2 +-
 vcl/quartz/salbmp.cxx   |   10 +-
 vcl/quartz/salgdicommon.cxx |2 +-
 3 files changed, 11 insertions(+), 3 deletions(-)

New commits:
commit 8145a80868aeb2d81abdeb2918942911c6d128f4
Author: Thorsten Behrens 
Date:   Sat Dec 31 18:01:14 2016 +0100

tdf#104693: screenshot: fix mirrored mac screenshots

Change-Id: Ie13689d7e15bf8dee6f21e6f5e7d75c9e53e931b
Reviewed-on: https://gerrit.libreoffice.org/32543
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/vcl/inc/quartz/salbmp.h b/vcl/inc/quartz/salbmp.h
index ae384c9..5fe1294 100644
--- a/vcl/inc/quartz/salbmp.h
+++ b/vcl/inc/quartz/salbmp.h
@@ -88,7 +88,7 @@ private:
sal_uInt16 nSrcBits, sal_uInt32 
nSrcBytesPerRow, const BitmapPalette& rSrcPalette, sal_uInt8* pSrcData );
 
 public:
-boolCreate( CGLayerRef xLayer, int nBitCount, int nX, int nY, 
int nWidth, int nHeight );
+boolCreate( CGLayerRef xLayer, int nBitCount, int nX, int nY, 
int nWidth, int nHeight, bool bFlipped );
 
 public:
 CGImageRef  CreateWithMask( const QuartzSalBitmap& rMask, int nX, int 
nY, int nWidth, int nHeight ) const;
diff --git a/vcl/quartz/salbmp.cxx b/vcl/quartz/salbmp.cxx
index dc9b683..014dd34 100644
--- a/vcl/quartz/salbmp.cxx
+++ b/vcl/quartz/salbmp.cxx
@@ -107,7 +107,7 @@ QuartzSalBitmap::~QuartzSalBitmap()
 }
 
 bool QuartzSalBitmap::Create( CGLayerRef xLayer, int nBitmapBits,
-int nX, int nY, int nWidth, int nHeight )
+int nX, int nY, int nWidth, int nHeight, bool bFlipped )
 {
 SAL_WARN_IF( !xLayer, "vcl", "QuartzSalBitmap::Create() from non-layered 
context" );
 
@@ -146,6 +146,14 @@ bool QuartzSalBitmap::Create( CGLayerRef xLayer, int 
nBitmapBits,
 if(mxGraphicContext) // remove warning
 {
 SAL_INFO("vcl.cg", "CGContextDrawLayerAtPoint(" << mxGraphicContext << 
"," << aSrcPoint << "," << xLayer << ")" );
+if( bFlipped )
+{
+SAL_INFO( "vcl.cg", "CGContextTranslateCTM(" << mxGraphicContext 
<< ",0," << mnHeight << ")" );
+CGContextTranslateCTM( mxGraphicContext, 0, +mnHeight );
+SAL_INFO( "vcl.cg", "CGContextScaleCTM(" << mxGraphicContext << 
",+1,-1)" );
+CGContextScaleCTM( mxGraphicContext, +1, -1 );
+}
+
 CGContextDrawLayerAtPoint( mxGraphicContext, aSrcPoint, xLayer );
 }
 return true;
diff --git a/vcl/quartz/salgdicommon.cxx b/vcl/quartz/salgdicommon.cxx
index e06..0d213da 100644
--- a/vcl/quartz/salgdicommon.cxx
+++ b/vcl/quartz/salgdicommon.cxx
@@ -1448,7 +1448,7 @@ SalBitmap* AquaSalGraphics::getBitmap( long  nX, long  
nY, long  nDX, long  nDY
 ApplyXorContext();
 
 QuartzSalBitmap* pBitmap = new QuartzSalBitmap;
-if( !pBitmap->Create( mxLayer, mnBitmapDepth, nX, nY, nDX, nDY) )
+if( !pBitmap->Create( mxLayer, mnBitmapDepth, nX, nY, nDX, nDY, 
IsFlipped()) )
 {
 delete pBitmap;
 pBitmap = nullptr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: kit/ForKit.cpp

[Ashod Nakashian]

 kit/ForKit.cpp |   16 
 1 file changed, 12 insertions(+), 4 deletions(-)

New commits:
commit 93858c5b9e7c61c33ac3c45710a351bf22f481d9
Author: Ashod Nakashian 
Date:   Sun Jan 29 20:19:23 2017 -0500

wsd: forkit removes jails after reaping dead children

Change-Id: Ia4b8dd85b41fa59ececbed85e35616fee6a02254
Reviewed-on: https://gerrit.libreoffice.org/33678
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/kit/ForKit.cpp b/kit/ForKit.cpp
index ba3d548..b6383a8 100644
--- a/kit/ForKit.cpp
+++ b/kit/ForKit.cpp
@@ -182,21 +182,29 @@ static bool haveCorrectCapabilities()
 /// Check if some previously forked kids have died.
 static void cleanupChildren()
 {
+std::vector jails;
 Process::PID exitedChildPid;
 int status;
 while ((exitedChildPid = waitpid(-1, , WUNTRACED | WNOHANG)) > 0)
 {
-if (childJails.find(exitedChildPid) != childJails.end())
+const auto it = childJails.find(exitedChildPid);
+if (it != childJails.end())
 {
-LOG_INF("Child " << exitedChildPid << " has exited, removing its 
jail '" << childJails[exitedChildPid] << "'");
-FileUtil::removeFile(childJails[exitedChildPid], true);
-childJails.erase(exitedChildPid);
+LOG_INF("Child " << exitedChildPid << " has exited, removing its 
jail '" << it->second << "'.");
+jails.emplace_back(it->second);
+childJails.erase(it);
 }
 else
 {
 LOG_ERR("Unknown child " << exitedChildPid << " has exited");
 }
 }
+
+// Now delete the jails.
+for (const auto& path : jails)
+{
+FileUtil::removeFile(path, true);
+}
 }
 
 static int createLibreOfficeKit(const std::string& childRoot,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/Admin.cpp wsd/AdminModel.cpp wsd/AdminModel.hpp

[Ashod Nakashian]

 wsd/Admin.cpp  |2 +-
 wsd/AdminModel.cpp |   15 +--
 wsd/AdminModel.hpp |2 +-
 3 files changed, 15 insertions(+), 4 deletions(-)

New commits:
commit cc3285e92365e6cfdf07732e575cff0c7848748f
Author: Ashod Nakashian 
Date:   Mon Jan 30 00:01:49 2017 -0500

wsd: log memory stat duration and averages

Change-Id: I8c84053c52c6725d2bda2e75313c52520e4bae6e
Reviewed-on: https://gerrit.libreoffice.org/33679
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/Admin.cpp b/wsd/Admin.cpp
index 6cfe993..333011f 100644
--- a/wsd/Admin.cpp
+++ b/wsd/Admin.cpp
@@ -328,7 +328,7 @@ void MemoryStats::run()
 {
 std::unique_lock modelLock(_admin->getLock());
 AdminModel& model = _admin->getModel();
-const auto totalMem = model.getTotalMemoryUsage();
+const auto totalMem = model.getKitsMemoryUsage();
 
 if (totalMem != _lastTotalMemory)
 {
diff --git a/wsd/AdminModel.cpp b/wsd/AdminModel.cpp
index 5f61175..5055d90 100644
--- a/wsd/AdminModel.cpp
+++ b/wsd/AdminModel.cpp
@@ -129,17 +129,28 @@ std::string AdminModel::query(const std::string& command)
 }
 
 /// Returns memory consumed by all active loolkit processes
-unsigned AdminModel::getTotalMemoryUsage()
+unsigned AdminModel::getKitsMemoryUsage()
 {
+Poco::Timestamp ts;
 unsigned totalMem = 0;
+unsigned docs = 0;
 for (const auto& it : _documents)
 {
 if (!it.second.isExpired())
 {
-totalMem += Util::getMemoryUsage(it.second.getPid());
+const auto bytes = Util::getMemoryUsage(it.second.getPid());
+if (bytes > 0)
+{
+totalMem += bytes;
+++docs;
+}
 }
 }
 
+LOG_INF("Got total Kits memory of " << totalMem << " bytes in " << 
ts.elapsed()/1001. << " ms for " <<
+docs << " docs, avg: " << static_cast(totalMem) / docs << 
" bytes / doc in " <<
+ts.elapsed() / 1000. / docs << " ms per doc.");
+
 return totalMem;
 }
 
diff --git a/wsd/AdminModel.hpp b/wsd/AdminModel.hpp
index 1dce29c..02cd78a 100644
--- a/wsd/AdminModel.hpp
+++ b/wsd/AdminModel.hpp
@@ -146,7 +146,7 @@ public:
 std::string query(const std::string& command);
 
 /// Returns memory consumed by all active loolkit processes
-unsigned getTotalMemoryUsage();
+unsigned getKitsMemoryUsage();
 
 void subscribe(int sessionId, std::shared_ptr& ws);
 void subscribe(int sessionId, const std::string& command);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/FileUtil.cpp common/FileUtil.hpp

[Ashod Nakashian]

 common/FileUtil.cpp |   39 +++
 common/FileUtil.hpp |   12 +---
 2 files changed, 40 insertions(+), 11 deletions(-)

New commits:
commit 0d4d506ea39d43beeccff54935b72485cb3fd545
Author: Ashod Nakashian 
Date:   Mon Jan 30 00:04:10 2017 -0500

wsd: faster jail directory cleanup

Around 1.5x faster than Poco,
which first enumerates files into
a container, then iterates over
them and stats before unlinking.

Here we enumerate and unlink in
a single pass.

Change-Id: I79d1c0f1b5ec557ccc4f0e2ec7a0609051d8d212
Reviewed-on: https://gerrit.libreoffice.org/33680
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/FileUtil.cpp b/common/FileUtil.cpp
index 8973d72..078379b 100644
--- a/common/FileUtil.cpp
+++ b/common/FileUtil.cpp
@@ -10,6 +10,7 @@
 #include "FileUtil.hpp"
 #include "config.h"
 
+#include 
 #include 
 #include 
 
@@ -114,6 +115,44 @@ namespace FileUtil
 }
 }
 
+static int nftw_cb(const char *fpath, const struct stat*, int type, struct 
FTW*)
+{
+if (type == FTW_DP)
+{
+rmdir(fpath);
+}
+else if (type == FTW_F || type == FTW_SL)
+{
+unlink(fpath);
+}
+
+// Always continue even when things go wrong.
+return 0;
+}
+
+void removeFile(const std::string& path, const bool recursive)
+{
+try
+{
+struct stat sb;
+if (!recursive || stat(path.c_str(), ) == -1 || 
S_ISREG(sb.st_mode))
+{
+// Non-recursive directories, and files.
+Poco::File(path).remove(recursive);
+}
+else
+{
+// Directories only.
+nftw(path.c_str(), nftw_cb, 128, FTW_DEPTH | FTW_PHYS);
+}
+}
+catch (const std::exception&)
+{
+// Already removed or we don't care about failures.
+}
+}
+
+
 } // namespace FileUtil
 
 namespace
diff --git a/common/FileUtil.hpp b/common/FileUtil.hpp
index c8e7a3f..0a172b9 100644
--- a/common/FileUtil.hpp
+++ b/common/FileUtil.hpp
@@ -63,17 +63,7 @@ namespace FileUtil
 /// Supresses exception when the file is already removed.
 /// This can happen when there is a race (unavoidable) or when
 /// we don't care to check before we remove (when no race exists).
-inline void removeFile(const std::string& path, const bool recursive = 
false)
-{
-try
-{
-Poco::File(path).remove(recursive);
-}
-catch (const std::exception&)
-{
-// Already removed or we don't care about failures.
-}
-}
+void removeFile(const std::string& path, const bool recursive = false);
 
 inline void removeFile(const Poco::Path& path, const bool recursive = 
false)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Ashod Nakashian]

 loleaflet/src/core/Socket.js |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 65be8a3e562f44267d4824c0f6813993bb288c1f
Author: Ashod Nakashian 
Date:   Mon Jan 30 00:07:29 2017 -0500

loleaflet: 50 docs or more is considered prod deployment

Change-Id: Ib36fdc43a7c94dc63ec9e31fe21eea475913c8d5
Reviewed-on: https://gerrit.libreoffice.org/33681
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index e42e951..245fa56 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -380,8 +380,8 @@ L.Socket = L.Class.extend({
this._map._fatal = true;
this._map._active = false; // Practically 
disconnected.
 
-   // Servers configured for more than 50 
documents are not demo/development.
-   if (parseInt(command.params[0]) > 50) {
+   // Servers configured for 50 documents are not 
demo/development.
+   if (parseInt(command.params[0]) >= 50) {
textMsg = 
errorMessages.limitreachedprod;
textMsg = textMsg.replace(/%0/g, 
command.params[0]);
textMsg = textMsg.replace(/%1/g, 
command.params[1]);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: starmath/inc

[Takeshi Abe]

 starmath/inc/rect.hxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 11a979cb8a750f2820a0d7947a47e830a1a0b335
Author: Takeshi Abe 
Date:   Fri Jan 27 23:36:54 2017 +0900

starmath: Make some functions private, instead of protected

Change-Id: Ic1192a2fca86833e9efd954c7625fb4f84f46b7c
Reviewed-on: https://gerrit.libreoffice.org/33618
Reviewed-by: Takeshi Abe 
Tested-by: Takeshi Abe 

diff --git a/starmath/inc/rect.hxx b/starmath/inc/rect.hxx
index 12cae33..4270465 100644
--- a/starmath/inc/rect.hxx
+++ b/starmath/inc/rect.hxx
@@ -106,7 +106,6 @@ class SmRect
 boolbHasBaseline,
 bHasAlignInfo;
 
-protected:
 inline  void CopyMBL(const SmRect& rRect);
 void CopyAlignInfo(const SmRect& rRect);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105601] CALC menu for DATA: discrepancies between scalc menu and help guides

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105601

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||vstuart.fo...@utsa.edu
 Blocks||92825
 Ever confirmed|0   |1
   Severity|normal  |minor


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=92825
[Bug 92825] [META] Update help for all menu changes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92825] [META] Update help for all menu changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92825

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||105601


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105601
[Bug 105601] CALC menu for DATA: discrepancies between scalc menu and help
guides
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105588] SVG exported from Impress or Draw cannot be correctly inserted as an image into another document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105588

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||regression

--- Comment #4 from V Stuart Foote  ---
(In reply to Regina Henschel from comment #3)
> Search for attribute "visibility" in the svg file. It has the wrong value
> "hidden". Exchange for example
> 
> with
> 
> 
> Then the import should work.
> 
> Please report back, whether such repaired svg will import in your case too.

Yes. If I edit the SVG in text editor (VI) and set the 
object's  to  the SVG inserts
into Draw/Impress and Writer cleanly.

Checked a 5.1.6.2 export to SVG, the  is not set.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

error in build step

[김광연]

An error ocurred in build step like:
 
error: problems opening map file 
/home/onting/libreoffice/workdir/CustomTarget/odk/docs/idl/ref/servicecom_1_1sun_1_1star_1_1view_1_1OfficeDocumentView__coll__graph.map
 for inclusion in the docs!
If you installed Graphviz/dot after a previous failing run, 
try deleting the output directory and rerun doxygen.
error: problems opening map file 
/home/onting/libreoffice/workdir/CustomTarget/odk/docs/idl/ref/structcom_1_1sun_1_1star_1_1view_1_1PrintableStateEvent__inherit__graph.map
 for inclusion in the docs!
If you installed Graphviz/dot after a previous failing run, 
try deleting the output directory and rerun doxygen.
error: problems opening map file 
/home/onting/libreoffice/workdir/CustomTarget/odk/docs/idl/ref/structcom_1_1sun_1_1star_1_1view_1_1PrintableStateEvent__coll__graph.map
 for inclusion in the docs!
If you installed Graphviz/dot after a previous failing run, 
try deleting the output directory and rerun doxygen.
error: problems opening map file 
/home/onting/libreoffice/workdir/CustomTarget/odk/docs/idl/ref/servicecom_1_1sun_1_1star_1_1view_1_1PrinterDescriptor__coll__graph.map
 for inclusion in the docs!
If you installed Graphviz/dot after a previous failing run, 
try deleting the output directory and rerun doxygen.
error: problems opening map file 
/home/onting/libreoffice/workdir/CustomTarget/odk/docs/idl/ref/structcom_1_1sun_1_1star_1_1view_1_1PrintJobEvent__inherit__graph.map
 for inclusion in the docs!
If you installed Graphviz/dot after a previous failing run, 
try deleting the output directory and rerun doxygen.
error: problems opening map file 
/home/onting/libreoffice/workdir/CustomTarget/odk/docs/idl/ref/structcom_1_1sun_1_1star_1_1view_1_1PrintJobEvent__coll__graph.map
 for inclusion in the docs! 
It seems like to need to fix. 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: test/httpwserror.cpp

[Ashod Nakashian]

 test/httpwserror.cpp |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 016a85b643004a82b54b579bfa3e1aefab256dd3
Author: Ashod Nakashian 
Date:   Sun Jan 29 16:36:31 2017 -0500

wsd: allow testing higher MAX_DOCUMENTS and MAX_CONNECTIONS

Change-Id: I678af51871c2b145ce91c1646315a00ea1ac60fa
Reviewed-on: https://gerrit.libreoffice.org/33676
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwserror.cpp b/test/httpwserror.cpp
index 6c9c123..f805fd7 100644
--- a/test/httpwserror.cpp
+++ b/test/httpwserror.cpp
@@ -117,7 +117,7 @@ void HTTPWSError::testMaxDocuments()
 static_assert(MAX_DOCUMENTS >= 2, "MAX_DOCUMENTS must be at least 2");
 const auto testname = "maxDocuments ";
 
-if (MAX_DOCUMENTS > 50)
+if (MAX_DOCUMENTS > 200)
 {
 std::cerr << "Skipping " << testname << "test since MAX_DOCUMENTS (" 
<< MAX_DOCUMENTS
   << ") is too high to test. Set to a more sensible number, 
ideally a dozen or so." << std::endl;
@@ -168,7 +168,7 @@ void HTTPWSError::testMaxConnections()
 static_assert(MAX_CONNECTIONS >= 3, "MAX_CONNECTIONS must be at least 3");
 const auto testname = "maxConnections ";
 
-if (MAX_CONNECTIONS > 100)
+if (MAX_CONNECTIONS > 300)
 {
 std::cerr << "Skipping " << testname << "test since MAX_CONNECTION (" 
<< MAX_CONNECTIONS
   << ") is too high to test. Set to a more sensible number, 
ideally a dozen or so." << std::endl;
@@ -223,7 +223,7 @@ void HTTPWSError::testMaxViews()
 static_assert(MAX_CONNECTIONS >= 3, "MAX_CONNECTIONS must be at least 3");
 const auto testname = "maxViews ";
 
-if (MAX_CONNECTIONS > 300)
+if (MAX_CONNECTIONS > 200)
 {
 std::cerr << "Skipping " << testname << "test since MAX_CONNECTION (" 
<< MAX_CONNECTIONS
   << ") is too high to test. Set to a more sensible number, 
ideally a dozen or so." << std::endl;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/httpwserror.cpp

[Ashod Nakashian]

 test/httpwserror.cpp |   53 +++
 1 file changed, 53 insertions(+)

New commits:
commit c2d8e7bb4c088b760e5bf1bc1f639e9f7ed95541
Author: Ashod Nakashian 
Date:   Sun Jan 29 16:35:44 2017 -0500

wsd: unittest max views

Change-Id: I832e2d3e004001c271089382c5e1241b07572eb7
Reviewed-on: https://gerrit.libreoffice.org/33675
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwserror.cpp b/test/httpwserror.cpp
index 91a783b..6c9c123 100644
--- a/test/httpwserror.cpp
+++ b/test/httpwserror.cpp
@@ -39,12 +39,14 @@ class HTTPWSError : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testBadDocLoadFail);
 CPPUNIT_TEST(testMaxDocuments);
 CPPUNIT_TEST(testMaxConnections);
+CPPUNIT_TEST(testMaxViews);
 
 CPPUNIT_TEST_SUITE_END();
 
 void testBadDocLoadFail();
 void testMaxDocuments();
 void testMaxConnections();
+void testMaxViews();
 
 public:
 HTTPWSError()
@@ -216,6 +218,57 @@ void HTTPWSError::testMaxConnections()
 }
 }
 
+void HTTPWSError::testMaxViews()
+{
+static_assert(MAX_CONNECTIONS >= 3, "MAX_CONNECTIONS must be at least 3");
+const auto testname = "maxViews ";
+
+if (MAX_CONNECTIONS > 300)
+{
+std::cerr << "Skipping " << testname << "test since MAX_CONNECTION (" 
<< MAX_CONNECTIONS
+  << ") is too high to test. Set to a more sensible number, 
ideally a dozen or so." << std::endl;
+return;
+}
+
+try
+{
+std::cerr << "Opening max number of views: " << MAX_CONNECTIONS << 
std::endl;
+
+// Load a document.
+std::string docPath;
+std::string docURL;
+
+getDocumentPathAndURL("empty.odt", docPath, docURL, testname);
+Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
docURL);
+auto socket = loadDocAndGetSocket(_uri, docURL, testname);
+std::cerr << "Opened view #1 of " << MAX_CONNECTIONS << std::endl;
+
+std::vector views;
+for (int it = 1; it < MAX_CONNECTIONS; ++it)
+{
+views.emplace_back(loadDocAndGetSocket(_uri, docURL, testname));
+std::cerr << "Opened view #" << (it+1) << " of " << 
MAX_CONNECTIONS << std::endl;
+}
+
+std::cerr << "Opening one more connection beyond the limit." << 
std::endl;
+
+// try to connect MAX_CONNECTIONS + 1
+std::unique_ptr 
session(createSession(_uri));
+auto socketN = std::make_shared(*session, request, 
_response);
+
+// Send load request, which will fail.
+sendTextFrame(socketN, "load url=" + docURL, testname);
+
+std::string message;
+const auto statusCode = getErrorCode(socketN, message, testname);
+
CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::WS_POLICY_VIOLATION),
 statusCode);
+}
+catch (const Poco::Exception& exc)
+{
+CPPUNIT_FAIL(exc.displayText());
+}
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(HTTPWSError);
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/MessageQueue.cpp kit/Kit.cpp test/httpwserror.cpp

[Ashod Nakashian]

 common/MessageQueue.cpp |6 --
 kit/Kit.cpp |3 ++-
 test/httpwserror.cpp|4 ++--
 3 files changed, 8 insertions(+), 5 deletions(-)

New commits:
commit 1ba7c0209af2c02620e7c7ae25994160d2e3b812
Author: Ashod Nakashian 
Date:   Sun Jan 29 16:29:18 2017 -0500

wsd: cosmetics

Change-Id: I58a9e579e228d7b4a1e1b5686988aeff8da9922f
Reviewed-on: https://gerrit.libreoffice.org/33674
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/MessageQueue.cpp b/common/MessageQueue.cpp
index 5bf489d..65a51a2 100644
--- a/common/MessageQueue.cpp
+++ b/common/MessageQueue.cpp
@@ -80,10 +80,12 @@ void TileQueue::put_impl(const Payload& value)
 }
 else if (firstToken == "callback")
 {
-std::string newMsg = removeCallbackDuplicate(msg);
+const std::string newMsg = removeCallbackDuplicate(msg);
 
 if (newMsg.empty())
+{
 MessageQueue::put_impl(value);
+}
 else
 {
 MessageQueue::put_impl(Payload(newMsg.data(), newMsg.data() + 
newMsg.size()));
@@ -341,7 +343,7 @@ std::string TileQueue::removeCallbackDuplicate(const 
std::string& callbackMsg)
 callbackType == "26" || // the view cell cursor has moved
 callbackType == "28")   // the view cursor visibility has changed
 {
-bool isViewCallback = (callbackType == "24" || callbackType == "26" || 
callbackType == "28");
+const bool isViewCallback = (callbackType == "24" || callbackType == 
"26" || callbackType == "28");
 
 std::string viewId;
 if (isViewCallback)
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 4401a6c..e093d0b 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -1050,7 +1050,7 @@ private:
 // and create an array of JSON objects containing id and username
 Array::Ptr viewInfoArray = new Array();
 int arrayIndex = 0;
-for (auto& viewId: viewIds)
+for (const auto& viewId : viewIds)
 {
 Object::Ptr viewInfoObj = new Object();
 viewInfoObj->set("id", viewId);
@@ -1069,6 +1069,7 @@ private:
 color = viewColorsMap[viewInfoMap[viewId].username];
 }
 }
+
 viewInfoObj->set("color", color);
 
 viewInfoArray->set(arrayIndex++, viewInfoObj);
diff --git a/test/httpwserror.cpp b/test/httpwserror.cpp
index bd31291..91a783b 100644
--- a/test/httpwserror.cpp
+++ b/test/httpwserror.cpp
@@ -184,7 +184,7 @@ void HTTPWSError::testMaxConnections()
 getDocumentPathAndURL("empty.odt", docPath, docURL, testname);
 Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
docURL);
 auto socket = loadDocAndGetSocket(_uri, docURL, testname);
-std::cerr << "Opened connect #1 of " << MAX_CONNECTIONS << std::endl;
+std::cerr << "Opened connection #1 of " << MAX_CONNECTIONS << 
std::endl;
 
 std::vector views;
 for (int it = 1; it < MAX_CONNECTIONS; ++it)
@@ -192,7 +192,7 @@ void HTTPWSError::testMaxConnections()
 std::unique_ptr 
session(createSession(_uri));
 auto ws = std::make_shared(*session, request, 
_response);
 views.emplace_back(ws);
-std::cerr << "Opened connect #" << (it+1) << " of " << 
MAX_CONNECTIONS << std::endl;
+std::cerr << "Opened connection #" << (it+1) << " of " << 
MAX_CONNECTIONS << std::endl;
 }
 
 std::cerr << "Opening one more connection beyond the limit." << 
std::endl;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/Admin.cpp wsd/Admin.hpp

[Ashod Nakashian]

 wsd/Admin.cpp |   16 
 wsd/Admin.hpp |8 ++--
 2 files changed, 14 insertions(+), 10 deletions(-)

New commits:
commit 292400eeed5393a60345955835dbcc1306a82fde
Author: Ashod Nakashian 
Date:   Sun Jan 29 14:18:55 2017 -0500

wsd: reuse the timer-based memory stats for admin requests

Change-Id: I3778458043174fb5489617d022445205daf91532
Reviewed-on: https://gerrit.libreoffice.org/33673
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/Admin.cpp b/wsd/Admin.cpp
index 7a38723..6cfe993 100644
--- a/wsd/Admin.cpp
+++ b/wsd/Admin.cpp
@@ -117,7 +117,7 @@ bool AdminRequestHandler::adminCommandHandler(const 
std::vector& payload)
 }
 else if (tokens[0] == "total_mem")
 {
-const auto totalMem = _admin->getTotalMemoryUsage(model);
+const auto totalMem = _admin->getTotalMemoryUsage();
 sendTextFrame("total_mem " + std::to_string(totalMem));
 }
 else if (tokens[0] == "kill" && tokens.count() == 2)
@@ -290,8 +290,8 @@ Admin::Admin() :
 {
 Log::info("Admin ctor.");
 
-_memStatsTask = new MemoryStats(this);
-_memStatsTimer.schedule(_memStatsTask, _memStatsTaskInterval, 
_memStatsTaskInterval);
+_memStatsTask.reset(new MemoryStats(this));
+_memStatsTimer.schedule(_memStatsTask.get(), _memStatsTaskInterval, 
_memStatsTaskInterval);
 
 _cpuStatsTask = new CpuStats(this);
 _cpuStatsTimer.schedule(_cpuStatsTask, _cpuStatsTaskInterval, 
_cpuStatsTaskInterval);
@@ -328,7 +328,7 @@ void MemoryStats::run()
 {
 std::unique_lock modelLock(_admin->getLock());
 AdminModel& model = _admin->getModel();
-const auto totalMem = _admin->getTotalMemoryUsage(model);
+const auto totalMem = model.getTotalMemoryUsage();
 
 if (totalMem != _lastTotalMemory)
 {
@@ -350,8 +350,8 @@ void Admin::rescheduleMemTimer(unsigned interval)
 {
 _memStatsTask->cancel();
 _memStatsTaskInterval = interval;
-_memStatsTask = new MemoryStats(this);
-_memStatsTimer.schedule(_memStatsTask, _memStatsTaskInterval, 
_memStatsTaskInterval);
+_memStatsTask.reset(new MemoryStats(this));
+_memStatsTimer.schedule(_memStatsTask.get(), _memStatsTaskInterval, 
_memStatsTaskInterval);
 Log::info("Memory stats interval changed - New interval: " + 
std::to_string(interval));
 }
 
@@ -364,10 +364,10 @@ void Admin::rescheduleCpuTimer(unsigned interval)
 Log::info("CPU stats interval changed - New interval: " + 
std::to_string(interval));
 }
 
-unsigned Admin::getTotalMemoryUsage(AdminModel& model)
+unsigned Admin::getTotalMemoryUsage()
 {
 unsigned totalMem = Util::getMemoryUsage(_forKitPid);
-totalMem += model.getTotalMemoryUsage();
+totalMem += _memStatsTask->getLastTotalMemory();
 totalMem += Util::getMemoryUsage(Poco::Process::id());
 
 return totalMem;
diff --git a/wsd/Admin.hpp b/wsd/Admin.hpp
index 52f0bd8..8da6fb8 100644
--- a/wsd/Admin.hpp
+++ b/wsd/Admin.hpp
@@ -48,6 +48,8 @@ private:
 bool _isAuthenticated;
 };
 
+class MemoryStats;
+
 /// An admin command processor.
 class Admin
 {
@@ -60,7 +62,7 @@ public:
 return admin;
 }
 
-unsigned getTotalMemoryUsage(AdminModel&);
+unsigned getTotalMemoryUsage();
 
 /// Update the Admin Model.
 void update(const std::string& message);
@@ -105,7 +107,7 @@ private:
 int _forKitPid;
 
 Poco::Util::Timer _memStatsTimer;
-Poco::Util::TimerTask::Ptr _memStatsTask;
+std::unique_ptr _memStatsTask;
 unsigned _memStatsTaskInterval = 5000;
 
 Poco::Util::Timer _cpuStatsTimer;
@@ -129,6 +131,8 @@ public:
 Log::debug("Memory stat dtor");
 }
 
+long getLastTotalMemory() { return _lastTotalMemory; }
+
 void run() override;
 
 private:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101664] Formatting : appearance of the drop caps disappears after closing a document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101664

--- Comment #32 from Leandro Martín Drudi  ---
(In reply to ThierryT from comment #29)
> I download the test file "test-de-lettrine.odt" on my computer.
> I opened it and found no drop caps in the file.
> I put a drop caps on the second paragraph. Save the file on my computer.
> Close it and reopen it.
> The drop caps still exist in the file.
> 
> I use:
> Version: 5.3.0.2 (x64)
> Build ID: 5ad7b2889021c491af62f7930a4b1cb631392f16
> Threads CPU : 4; Version de l'OS :Windows 6.29; UI Render : par défaut;
> Moteur de mise en page : nouveau; 
> Locale : fr-FR (fr_FR); Calc: group

That's true! Then the problem is presented in the styles. The manual format is
saved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: test/countloolkits.hpp

[Ashod Nakashian]

 test/countloolkits.hpp |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 9a8fe7054adebb22575f1452825f9843e953d9e3
Author: Ashod Nakashian 
Date:   Sun Jan 29 14:04:54 2017 -0500

wsd: more time to count lool processes

In unittests we need to count the
number of lool processes. This can
take a long time depending on how many
they are and if they are exiting or
new ones being created.

New logic is to reset the timeout
when the numbers are changing until
it settles on either the expected
(when we return), or some other value.

Change-Id: Ia8fcc7ef60586ebec6d8a280174b4dd2eae0ccc4
Reviewed-on: https://gerrit.libreoffice.org/33672
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/countloolkits.hpp b/test/countloolkits.hpp
index a652bfd..d38ac82 100644
--- a/test/countloolkits.hpp
+++ b/test/countloolkits.hpp
@@ -100,7 +100,13 @@ static int countLoolKitProcesses(const int expected)
 // Give polls in the lool processes time to time out etc
 std::this_thread::sleep_for(std::chrono::milliseconds(sleepMs));
 
-count = getLoolKitProcessCount();
+const auto newCount = getLoolKitProcessCount();
+if (count != newCount)
+{
+// Allow more time until the number settles.
+i = 0;
+count = newCount;
+}
 }
 
 std::cerr << std::endl;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: configure.ac

[Ashod Nakashian]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 78fdcb903af7aaf75d57f22fba9059dfa46cad45
Author: Ashod Nakashian 
Date:   Sat Jan 28 19:14:57 2017 -0500

wsd: correct configuring MAX_DOCUMENTS

Change-Id: I14ffd990cdfb0206d93de01f42fc99efda4e6e8f
Reviewed-on: https://gerrit.libreoffice.org/33671
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/configure.ac b/configure.ac
index b029d53..f65b8e6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -146,7 +146,7 @@ 
AC_DEFINE_UNQUOTED([MAX_CONNECTIONS],[$MAX_CONNECTIONS],[Limit the maximum numbe
 AC_SUBST(MAX_CONNECTIONS)
 
 MAX_DOCUMENTS=10
-AS_IF([test -n "$with_max_documents" -a "$with_max_documents" -gt "0" -a 
"$with_max_documents" -lt "$MAX_CONNECTIONS"],
+AS_IF([test -n "$with_max_documents" -a "$with_max_documents" -gt "0"],
   [MAX_DOCUMENTS="$with_max_documents"])
 AS_IF([test "$MAX_DOCUMENTS" -gt "$MAX_CONNECTIONS"],
   [MAX_DOCUMENTS="$MAX_CONNECTIONS"])
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/dist loleaflet/src

[Ashod Nakashian]

 loleaflet/dist/errormessages.js |1 +
 loleaflet/src/core/Socket.js|   21 -
 2 files changed, 17 insertions(+), 5 deletions(-)

New commits:
commit 4dc6b574a02b0598b2e0c042c8b21e4815016e98
Author: Ashod Nakashian 
Date:   Sat Jan 28 18:36:17 2017 -0500

wsd: show a different limit message for non-dev builds

For now we assume configurations of more than 50
documents are not for dev or demo. This is because
loading 50 documents will require a reasonably
sized server and is beyond the default of 10.

Change-Id: I099206d7d35a88102c1834ea9015b85810a3f190
Reviewed-on: https://gerrit.libreoffice.org/33670
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loleaflet/dist/errormessages.js b/loleaflet/dist/errormessages.js
index 329fa55..d1eccac 100644
--- a/loleaflet/dist/errormessages.js
+++ b/loleaflet/dist/errormessages.js
@@ -1,6 +1,7 @@
 exports.diskfull = _('No disk space left on server, please contact the server 
administrator to continue.');
 exports.emptyhosturl = _('The host URL is empty. The loolwsd server is 
probably misconfigured, please contact the administrator.');
 exports.limitreached = _('This development build is limited to %0 documents, 
and %1 connections - to avoid the impression that it is suitable for deployment 
in large enterprises. To find out more about deploying and scaling %2 check 
out: %3.');
+exports.limitreachedprod = _('This service is limited to %0 documents, and %1 
connections total by the admin. This limit has been reached. Please try again 
later.');
 exports.serviceunavailable = _('Service is unavailable. Please try again later 
and report to your administrator if the issue persists.');
 exports.unauthorized = _('Unauthorized WOPI host. Please try again later and 
report to your administrator if the issue persists.');
 exports.wrongwopisrc = _('Wrong WOPISrc, usage: WOPISrc=valid encoded URI, or 
file_path, usage: file_path=/path/to/doc/');
diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index 32ed572..e42e951 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -378,14 +378,25 @@ L.Socket = L.Class.extend({
textMsg = textMsg.substring(6);
if (command.errorKind === 'limitreached') {
this._map._fatal = true;
-   textMsg = errorMessages.limitreached;
-   textMsg = textMsg.replace(/%0/g, 
command.params[0]);
-   textMsg = textMsg.replace(/%1/g, 
command.params[1]);
-   textMsg = textMsg.replace(/%2/g, (typeof 
brandProductName !== 'undefined' ? brandProductName : 'LibreOffice Online'));
-   textMsg = textMsg.replace(/%3/g, (typeof 
brandProductFAQURL !== 'undefined' ? brandProductFAQURL : 
'https://wiki.documentfoundation.org/Development/LibreOffice_Online'));
+   this._map._active = false; // Practically 
disconnected.
+
+   // Servers configured for more than 50 
documents are not demo/development.
+   if (parseInt(command.params[0]) > 50) {
+   textMsg = 
errorMessages.limitreachedprod;
+   textMsg = textMsg.replace(/%0/g, 
command.params[0]);
+   textMsg = textMsg.replace(/%1/g, 
command.params[1]);
+   }
+   else {
+   textMsg = errorMessages.limitreached;
+   textMsg = textMsg.replace(/%0/g, 
command.params[0]);
+   textMsg = textMsg.replace(/%1/g, 
command.params[1]);
+   textMsg = textMsg.replace(/%2/g, 
(typeof brandProductName !== 'undefined' ? brandProductName : 'LibreOffice 
Online'));
+   textMsg = textMsg.replace(/%3/g, 
(typeof brandProductFAQURL !== 'undefined' ? brandProductFAQURL : 
'https://wiki.documentfoundation.org/Development/LibreOffice_Online'));
+   }
}
else if (command.errorKind === 'serviceunavailable') {
this._map._fatal = true;
+   this._map._active = false; // Practically 
disconnected.
textMsg = errorMessages.serviceunavailable;
}
this._map.fire('error', {msg: textMsg});
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: 2 commits - bundled/include wsd/LOOLWSD.cpp wsd/LOOLWSD.hpp

[Ashod Nakashian]

 bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h |   31 
 wsd/LOOLWSD.cpp  |   36 +--
 wsd/LOOLWSD.hpp  |1 
 3 files changed, 58 insertions(+), 10 deletions(-)

New commits:
commit 2c77fe54d4f3a770564d9e2e2e1e92e8fd7e5263
Author: Ashod Nakashian 
Date:   Fri Jan 27 23:52:58 2017 -0500

wsd: update LibreOffice Kit header

Change-Id: I792bcd6aa28de0d0916e3676b76ea87994cd685f
Reviewed-on: https://gerrit.libreoffice.org/33668
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h 
b/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h
index d2ccc0f..8a59b4c 100644
--- a/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h
+++ b/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h
@@ -69,6 +69,11 @@ typedef enum
  * LOK_CALLBACK_INVALIDATE_TILES payload.
  */
 LOK_FEATURE_PART_IN_INVALIDATION_CALLBACK = (1ULL << 2),
+
+/**
+ * Turn off tile rendering for annotations
+ */
+LOK_FEATURE_NO_TILED_ANNOTATIONS = (1ULL << 3)
 }
 LibreOfficeKitOptionalFeatures;
 
@@ -462,6 +467,32 @@ typedef enum
  * - 'action' is 'Modify'.
  */
 LOK_CALLBACK_REDLINE_TABLE_ENTRY_MODIFIED = 31,
+
+/**
+ * There is some change in comments in the document
+ *
+ * The payload example:
+ * {
+ * "comment": {
+ * "action": "Add",
+ * "id": "11",
+ * "parent": "4",
+ * "author": "Unknown Author",
+ * "text": "",
+ * "dateTime": "2016-08-18T13:13:00",
+ * "anchorPos": "4529, 3906",
+ * "textRange": "1418, 3906, 3111, 919"
+ * }
+ * }
+ *
+ * The format is the same as an entry of
+ * lok::Document::getCommandValues('.uno:ViewAnnotations'), extra
+ * fields:
+ *
+ * - 'action' can be 'Add', 'Remove' or 'Modify' depending on whether
+ *comment has been added, removed or modified.
+ */
+LOK_CALLBACK_COMMENT = 32
 }
 LibreOfficeKitCallbackType;
 
commit e342c87dbf7b5ea2611b950a88f1f98f39ce5353
Author: Ashod Nakashian 
Date:   Sat Jan 28 17:25:14 2017 -0500

wsd: account for transient file connections

The connection limit MAX_CONNECTIONS
is for document WS connections, which
doesn't take into account the other
resources (.js, .css, etc.) that clients
request. These transient files are as
many as 10 per client. While they
are being requested, other clients
should not be blocked due to reaching
the limit.

We now take into account these connections
and allow at least half as many clients
as the limit to connect simultaneously
without blockage.

Change-Id: I42fd27b992457bcf765a7a85382e6d7caad4bc97
Reviewed-on: https://gerrit.libreoffice.org/33669
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 72dc826..8964c80 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1862,9 +1862,14 @@ void LOOLWSD::initialize(Application& self)
 ChildRoot = getPathFromConfig("child_root_path");
 ServerName = config().getString("server_name");
 FileServerRoot = getPathFromConfig("file_server_root_path");
-NumPreSpawnedChildren = getConfigValue(conf, 
"num_prespawn_children", 1);
+NumPreSpawnedChildren = getConfigValue(conf, "num_prespawn_children", 
1);
+if (NumPreSpawnedChildren < 1)
+{
+LOG_WRN("Invalid num_prespawn_children in config (" << 
NumPreSpawnedChildren << "). Resetting to 1.");
+NumPreSpawnedChildren = 1;
+}
 
-const auto maxConcurrency = getConfigValue(conf, 
"per_document.max_concurrency", 4);
+const auto maxConcurrency = getConfigValue(conf, 
"per_document.max_concurrency", 4);
 if (maxConcurrency > 0)
 {
 setenv("MAX_CONCURRENCY", std::to_string(maxConcurrency).c_str(), 1);
@@ -2285,20 +2290,32 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 throw IncompatibleOptionsException("port");
 
 // Configure the Server.
-// Note: TCPServer internally uses a ThreadPool to
-// dispatch connections (the default if not given).
-// The capacity of the ThreadPool is increased here to
-// match MAX_CONNECTIONS. The pool must have sufficient available
-// threads to dispatch new connections, otherwise will deadlock.
+// Note: TCPServer internally uses a ThreadPool to dispatch connections
+// (the default if not given). The capacity of the ThreadPool is increased
+// here in proportion to MAX_CONNECTIONS. Each client requests ~10
+// resources (.js, .css, etc) beyond the main one, which are transient.
+// The pool must have sufficient 

[Libreoffice-commits] online.git: test/TileCacheTests.cpp

[Ashod Nakashian]

 test/TileCacheTests.cpp |   44 +++-
 1 file changed, 35 insertions(+), 9 deletions(-)

New commits:
commit 3816b0c8eb4da05bbd21c520fdaa4c5694f48ff7
Author: Ashod Nakashian 
Date:   Thu Jan 26 10:06:31 2017 -0500

wsd: faster and more informative tile tests

Change-Id: Ifcd179600ca1b019f43a86eaf0fd11a5d8a6177a
Reviewed-on: https://gerrit.libreoffice.org/33667
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index c0611a8..59dadfa 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -258,6 +258,9 @@ void TileCacheTests::testCancelTiles()
 {
 std::cerr << "cancelTiles try #" << i << std::endl;
 
+// Wait to clear previous sessions.
+countLoolKitProcesses(InitialLoolKitCount);
+
 auto socket = loadDocAndGetSocket("setclientpart.ods", _uri, testName);
 
 // Request a huge tile, and cancel immediately.
@@ -269,9 +272,14 @@ void TileCacheTests::testCancelTiles()
 {
 break;
 }
-else if (i == repeat)
+else
 {
-CPPUNIT_ASSERT_MESSAGE("Did not expect getting message [" + res + 
"].", res.empty());
+if (i == repeat)
+{
+CPPUNIT_ASSERT_MESSAGE("Did not expect getting message [" + 
res + "].", res.empty());
+}
+
+std::cerr << "Unexpected: [" << res << "]" << std::endl;
 }
 }
 }
@@ -288,6 +296,9 @@ void TileCacheTests::testCancelTilesMultiView()
 {
 std::cerr << "cancelTilesMultiView try #" << j << std::endl;
 
+// Wait to clear previous sessions.
+countLoolKitProcesses(InitialLoolKitCount);
+
 // Request a huge tile, and cancel immediately.
 auto socket1 = loadDocAndGetSocket(_uri, documentURL, 
"cancelTilesMultiView-1 ");
 auto socket2 = loadDocAndGetSocket(_uri, documentURL, 
"cancelTilesMultiView-2 ", true);
@@ -296,10 +307,16 @@ void TileCacheTests::testCancelTilesMultiView()
 sendTextFrame(socket2, "tilecombine part=0 width=256 height=256 
tileposx=0,3840,7680,0 tileposy=0,0,0,22520 tilewidth=3840 tileheight=3840", 
"cancelTilesMultiView-2 ");
 
 sendTextFrame(socket1, "canceltiles");
-const auto res1 = getResponseString(socket1, "tile:", 
"cancelTilesMultiView-1 ", 1000);
-if (!res1.empty() && j == repeat)
+const auto res1 = getResponseString(socket1, "tile:", 
"cancelTilesMultiView-1 ", 500);
+if (!res1.empty())
 {
-CPPUNIT_ASSERT_MESSAGE("Did not expect getting message [" + res1 + 
"].", res1.empty());
+if (j == repeat)
+{
+CPPUNIT_ASSERT_MESSAGE("Did not expect getting message [" + 
res1 + "].", res1.empty());
+}
+
+std::cerr << "Unexpected: [" << res1 << "]" << std::endl;
+continue;
 }
 
 for (auto i = 0; i < 4; ++i)
@@ -311,10 +328,16 @@ void TileCacheTests::testCancelTilesMultiView()
 // Though in practice we get the rendering result from socket1's 
request and ours.
 // This happens because we currently always send back tiles even if 
they are of old version
 // because we want to be responsive, since we've rendered them anyway.
-const auto res2 = getResponseString(socket2, "tile:", 
"cancelTilesMultiView-2 ", 1000);
-if (!res2.empty() && j == repeat)
+const auto res2 = getResponseString(socket2, "tile:", 
"cancelTilesMultiView-2 ", 500);
+if (!res2.empty())
 {
-CPPUNIT_ASSERT_MESSAGE("Did not expect getting message [" + res2 + 
"].", res2.empty());
+if (j == repeat)
+{
+CPPUNIT_ASSERT_MESSAGE("Did not expect getting message [" + 
res2 + "].", res1.empty());
+}
+
+std::cerr << "Unexpected: [" << res2 << "]" << std::endl;
+continue;
 }
 
 if (res1.empty() && res2.empty())
@@ -334,6 +357,9 @@ void TileCacheTests::testDisconnectMultiView()
 {
 std::cerr << "cancelTilesMultiView try #" << j << std::endl;
 
+// Wait to clear previous sessions.
+countLoolKitProcesses(InitialLoolKitCount);
+
 // Request a huge tile, and cancel immediately.
 auto socket1 = loadDocAndGetSocket(_uri, documentURL, 
"cancelTilesMultiView-1 ");
 auto socket2 = loadDocAndGetSocket(_uri, documentURL, 
"cancelTilesMultiView-2 ", true);
@@ -349,7 +375,7 @@ void TileCacheTests::testDisconnectMultiView()
 }
 
 // Should never get more than 4 tiles on socket2.
-const auto res2 = getResponseString(socket2, "tile:", 
"cancelTilesMultiView-2 ", 1000);
+const auto res2 = getResponseString(socket2, "tile:", 
"cancelTilesMultiView-2 ", 500);
 }
 }
 

[Libreoffice-commits] core.git: sc/source

[Rosemary Sebastian]

 sc/source/filter/xcl97/XclExpChangeTrack.cxx |   13 +++--
 sc/source/filter/xcl97/xcl97rec.cxx  |   15 ---
 2 files changed, 15 insertions(+), 13 deletions(-)

New commits:
commit c6dd735afb2e1b3837c4f8c5659f52fafab4c56f
Author: Rosemary Sebastian 
Date:   Sun Jan 29 23:08:01 2017 +0530

replace namespace url strings with function calls

Change-Id: I3c0ca35c6f6acdd0f00a2aff4c9ef49d110cc1a2
Reviewed-on: https://gerrit.libreoffice.org/33664
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/filter/xcl97/XclExpChangeTrack.cxx 
b/sc/source/filter/xcl97/XclExpChangeTrack.cxx
index 9ba10de..b1d7ce6 100644
--- a/sc/source/filter/xcl97/XclExpChangeTrack.cxx
+++ b/sc/source/filter/xcl97/XclExpChangeTrack.cxx
@@ -26,6 +26,7 @@
 #include "document.hxx"
 #include "editutil.hxx"
 
+#include 
 #include 
 #include 
 #include 
@@ -377,8 +378,8 @@ void XclExpXmlChTrHeaders::SaveXml( XclExpXmlStream& rStrm )
 pHeaders->write("<")->writeId(XML_headers);
 
 rStrm.WriteAttributes(
-XML_xmlns,  
"http://schemas.openxmlformats.org/spreadsheetml/2006/main;,
-FSNS(XML_xmlns, XML_r), 
"http://schemas.openxmlformats.org/officeDocument/2006/relationships;,
+XML_xmlns,  
XclXmlUtils::ToOString(rStrm.getNamespaceURL(OOX_NS(xls))).getStr(),
+FSNS(XML_xmlns, XML_r), 
XclXmlUtils::ToOString(rStrm.getNamespaceURL(OOX_NS(officeRel))).getStr(),
 XML_guid,   lcl_GuidToOString(maGUID).getStr(),
 XML_lastGuid,   nullptr,   // OOXTODO
 XML_shared, nullptr,   // OOXTODO
@@ -470,8 +471,8 @@ void XclExpXmlChTrHeader::SaveXml( XclExpXmlStream& rStrm )
 pRevLogStrm->write("<")->writeId(XML_revisions);
 
 rStrm.WriteAttributes(
-XML_xmlns,  
"http://schemas.openxmlformats.org/spreadsheetml/2006/main;,
-FSNS(XML_xmlns, XML_r), 
"http://schemas.openxmlformats.org/officeDocument/2006/relationships;,
+XML_xmlns,  
XclXmlUtils::ToOString(rStrm.getNamespaceURL(OOX_NS(xls))).getStr(),
+FSNS(XML_xmlns, XML_r), 
XclXmlUtils::ToOString(rStrm.getNamespaceURL(OOX_NS(officeRel))).getStr(),
 FSEND);
 
 pRevLogStrm->write(">");
@@ -1645,8 +1646,8 @@ static void lcl_WriteUserNamesXml( XclExpXmlStream& 
rWorkbookStrm )
 
"application/vnd.openxmlformats-officedocument.spreadsheetml.userNames+xml",
 CREATE_OFFICEDOC_RELATION_TYPE("usernames"));
 pUserNames->startElement( XML_users,
-XML_xmlns,  
"http://schemas.openxmlformats.org/spreadsheetml/2006/main;,
-FSNS( XML_xmlns, XML_r ),   
"http://schemas.openxmlformats.org/officeDocument/2006/relationships;,
+XML_xmlns,  
XclXmlUtils::ToOString(rWorkbookStrm.getNamespaceURL(OOX_NS(xls))).getStr(),
+FSNS( XML_xmlns, XML_r ),   
XclXmlUtils::ToOString(rWorkbookStrm.getNamespaceURL(OOX_NS(officeRel))).getStr(),
 XML_count,  "0",
 FSEND );
 // OOXTODO: XML_userinfo elements for each user editing the file
diff --git a/sc/source/filter/xcl97/xcl97rec.cxx 
b/sc/source/filter/xcl97/xcl97rec.cxx
index 3c94c05..4d1c3c0 100644
--- a/sc/source/filter/xcl97/xcl97rec.cxx
+++ b/sc/source/filter/xcl97/xcl97rec.cxx
@@ -73,6 +73,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -260,9 +261,9 @@ void SaveDrawingMLObjects( XclExpObjList& rList, 
XclExpXmlStream& rStrm, sal_Int
 
 rStrm.PushStream( pDrawing );
 pDrawing->startElement( FSNS( XML_xdr, XML_wsDr ),
-FSNS( XML_xmlns, XML_xdr ), 
"http://schemas.openxmlformats.org/drawingml/2006/spreadsheetDrawing;,
-FSNS( XML_xmlns, XML_a ),   
"http://schemas.openxmlformats.org/drawingml/2006/main;,
-FSNS( XML_xmlns, XML_r ),   
"http://schemas.openxmlformats.org/officeDocument/2006/relationships;,
+FSNS( XML_xmlns, XML_xdr ), 
XclXmlUtils::ToOString(rStrm.getNamespaceURL(OOX_NS(dmlSpreadDr))).getStr(),
+FSNS( XML_xmlns, XML_a ),   
XclXmlUtils::ToOString(rStrm.getNamespaceURL(OOX_NS(dml))).getStr(),
+FSNS( XML_xmlns, XML_r ),   
XclXmlUtils::ToOString(rStrm.getNamespaceURL(OOX_NS(officeRel))).getStr(),
 FSEND );
 
 for (it = aList.begin(), itEnd = aList.end(); it != itEnd; ++it)
@@ -294,10 +295,10 @@ void SaveVmlObjects( XclExpObjList& rList, 
XclExpXmlStream& rStrm, sal_Int32& nV
 
 rStrm.PushStream( pVmlDrawing );
 pVmlDrawing->startElement( XML_xml,
-FSNS( XML_xmlns, XML_v ),   "urn:schemas-microsoft-com:vml",
-FSNS( XML_xmlns, XML_o ),   
"urn:schemas-microsoft-com:office:office",
-FSNS( XML_xmlns, XML_x ),   
"urn:schemas-microsoft-com:office:excel",
-FSNS( XML_xmlns, XML_w10 ), 

[Libreoffice-bugs] [Bug 105603] LibreOffice writes an invalid attribute "sub-view-size" in ODF 1.2 strict from pptx file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105603

Dennis Roczek  changed:

   What|Removed |Added

   Keywords||filter:odp
 CC||dennisroc...@libreoffice.or
   ||g

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105603] New: LibreOffice writes an invalid attribute "sub-view-size" in ODF 1.2 strict from pptx file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105603

Bug ID: 105603
   Summary: LibreOffice writes an invalid attribute
"sub-view-size" in ODF 1.2 strict from pptx file
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 130757
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130757=edit
Bézier curve as custom shape, created with PowerPoint 2010

Open the attached pptx-file. Set LibreOffice to save to strict ODF 1.2. Save
the file as *.odp. Unpack the file and examine the element
 in content.xml.
It has an attribute "sub-view-size". Such attribute does not exist in ODF 1.2.

If you save to 'ODF 1.2 extended', then the namespace drawooo is used.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101664] Formatting : appearance of the drop caps disappears after closing a document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101664

--- Comment #31 from richard_g  ---
Tested on 5.3.0.3 x86 version : 

Version: 5.3.0.3 (x86)
Build ID: 7074905676c47b82bbcfbea1aeefc84afe1c50e1
Threads CPU : 2; Version de l'OS :Windows 6.0; UI Render : par défaut; Moteur
de mise en page : nouveau; 
Locale : fr-FR (fr_FR); Calc: group


The problem is still here ! Drop caps are unchecked when Opening a document
saved with Drop Caps checked !

It seems that x86 and x64 versions have not the same behavior !

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105588] SVG exported from Impress or Draw cannot be correctly inserted as an image into another document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105588

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #3 from Regina Henschel  ---
Search for attribute "visibility" in the svg file. It has the wrong value
"hidden". Exchange for example

with


Then the import should work.

Please report back, whether such repaired svg will import in your case too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101664] Formatting : appearance of the drop caps disappears after closing a document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101664

--- Comment #30 from richard_g  ---
In response to comment 25.

To be verified: is the problem solved also in the 5.3.0.2 x86 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105602] Extended help does not work in GtkToolButton items if the property " action_name" is set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105602

--- Comment #1 from Gabor Kelemen  ---
Created attachment 130754
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130754=edit
Screenshot of the problem in the Spelling and Grammar dialog, help debug mode

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105602] New: Extended help does not work in GtkToolButton items if the property " action_name" is set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105602

Bug ID: 105602
   Summary: Extended help does not work in GtkToolButton items if
the property "action_name" is set
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com

Created attachment 130753
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130753=edit
Screenshot of the problem in Calc side pane, help debug mode

I noticed that since the Writer[1] and Calc[2] Navigator side pane conversion
to .ui format the extended help stopped working on the tool buttons at the top
of these side panes.

The help content was correctly updated with bookmark and ahelp ids after the
conversion, so I continued looking for other explanations.

I think the problem is that these items have the action_name property set,
which overrides the default "modules/swriter/ui/navigatorpanel/something" style
help id to just the value in the action_name. I wonder if this is intentional?

Now I think one way to go could be to modify the help ids in helpcontent, but
the problem with this approach is that the short command names are not unique
between help files - for example we have a "dragmode" command in Writer, Calc
and Impress and they mean different things by looking at the help.

A better ways would be to somehow preserve the default style help ids.


This problem is not specific to the Navigator side panes, I see this happening
in the Spelling and Grammar dialog[3] and in the Templates dialog[4] too.

[1]
https://cgit.freedesktop.org/libreoffice/core/commit/?id=33603a582bdd173a8e85c78bb0e8ef82874b8e59
[2]
https://cgit.freedesktop.org/libreoffice/core/commit/?id=141a4ac1d21121a4e46470c797c6fce741151fee
[3]
https://cgit.freedesktop.org/libreoffice/core/tree/cui/uiconfig/ui/spellingdialog.ui#n382
[4]
https://cgit.freedesktop.org/libreoffice/core/tree/sfx2/uiconfig/ui/templatedlg.ui#n309

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105601] CALC menu for DATA: discrepancies between scalc menu and help guides

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105601

--- Comment #2 from gmarco  ---
Created attachment 130752
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130752=edit
screen for online help

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105601] CALC menu for DATA: discrepancies between scalc menu and help guides

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105601

--- Comment #1 from gmarco  ---
Created attachment 130751
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130751=edit
screen for local help

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105601] New: CALC menu for DATA: discrepancies between scalc menu and help guides

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105601

Bug ID: 105601
   Summary: CALC menu for DATA: discrepancies between scalc menu
and help guides
   Product: LibreOffice
   Version: 5.2.3.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gmmell...@inwind.it

Created attachment 130750
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130750=edit
screen for menu

The DATA menu in SCALC is a lot different from what we can see looking at both
local and online helps.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source

[Caolán McNamara]

 filter/source/graphicfilter/ipict/ipict.cxx |7 ---
 1 file changed, 7 deletions(-)

New commits:
commit e4f7e197f73bee4f9546528271f63a36d9ea0c89
Author: Caolán McNamara 
Date:   Sun Jan 29 21:22:36 2017 +

we don't need read access, only write

Change-Id: If9720a402ce360fd691a4ce83f267e2d19e19652

diff --git a/filter/source/graphicfilter/ipict/ipict.cxx 
b/filter/source/graphicfilter/ipict/ipict.cxx
index d948d50..aa4af80 100644
--- a/filter/source/graphicfilter/ipict/ipict.cxx
+++ b/filter/source/graphicfilter/ipict/ipict.cxx
@@ -304,8 +304,6 @@ public:
 {   \
 if ( pAcc ) \
 Bitmap::ReleaseAccess( pAcc );  \
-if ( pReadAcc ) \
-Bitmap::ReleaseAccess( pReadAcc );  \
 return 0x;  \
 }
 
@@ -705,7 +703,6 @@ sal_uLong PictReader::ReadPixMapEtc( Bitmap , bool 
bBaseAddr, bool bColo
 {
 Bitmap  aBitmap;
 BitmapWriteAccess*  pAcc = nullptr;
-BitmapReadAccess*   pReadAcc = nullptr;
 sal_uInt16  nColTabSize;
 sal_uInt16  nRowBytes, nBndX, nBndY, nWidth, nHeight, 
nPackType,
 nPixelSize, nCmpCount, nCmpSize;
@@ -1018,8 +1015,6 @@ sal_uLong PictReader::ReadPixMapEtc( Bitmap , 
bool bBaseAddr, bool bColo
 size_t  nCount;
 sal_uLong   nSrcBitsPos;
 BitmapColor aBitmapColor;
-if ( ( pReadAcc = aBitmap.AcquireReadAccess() ) == nullptr )
-BITMAPERROR;
 if ( nRowBytes != 4*nWidth )
 BITMAPERROR;
 
@@ -1126,8 +1121,6 @@ sal_uLong PictReader::ReadPixMapEtc( Bitmap , 
bool bBaseAddr, bool bColo
 }
 else
 BITMAPERROR;
-if ( pReadAcc )
-Bitmap::ReleaseAccess( pReadAcc );
 Bitmap::ReleaseAccess( pAcc );
 rBitmap = aBitmap;
 return nDataSize;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - writerperfect/CppunitTest_writerperfect_import.mk writerperfect/inc writerperfect/Module_writerperfect.mk writerperfect/qa writerperfect/source

[David Tardon]

 writerperfect/CppunitTest_writerperfect_import.mk|   40 ++
 writerperfect/Module_writerperfect.mk|1 
 writerperfect/inc/DirectoryStream.hxx|3 
 writerperfect/qa/unit/DirectoryStreamTest.cxx|   38 --
 writerperfect/qa/unit/ImportTest.cxx |  118 +++
 writerperfect/qa/unit/WpftFilterFixture.cxx  |4 
 writerperfect/qa/unit/WpftFilterFixture.hxx  |5 
 writerperfect/qa/unit/WpftLoader.hxx |2 
 writerperfect/qa/unit/data/import/SOLVE.FM3  |binary
 writerperfect/qa/unit/data/import/SOLVE.WK3  |binary
 writerperfect/source/common/DirectoryStream.cxx  |   38 ++
 writerperfect/source/impress/KeynoteImportFilter.cxx |   32 ++---
 12 files changed, 224 insertions(+), 57 deletions(-)

New commits:
commit a48c22e1bfc2019a6c2a35caaa09d2319b783078
Author: David Tardon 
Date:   Thu Jan 12 21:03:21 2017 +0100

add test for handling .wk3 format file

Change-Id: Id6fd1f979902e286009d16f9d8ea551df3940859

diff --git a/writerperfect/CppunitTest_writerperfect_import.mk 
b/writerperfect/CppunitTest_writerperfect_import.mk
new file mode 100644
index 000..152d26f
--- /dev/null
+++ b/writerperfect/CppunitTest_writerperfect_import.mk
@@ -0,0 +1,40 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_CppunitTest_CppunitTest,writerperfect_import))
+
+$(eval $(call gb_CppunitTest_add_defs,writerperfect_import,\
+   -DTEST_DIR=\"writerperfect/qa/unit/data/import\" \
+))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,writerperfect_import))
+
+$(eval $(call gb_CppunitTest_use_libraries,writerperfect_import,\
+   comphelper \
+   cppu \
+   sal \
+   test \
+   unotest \
+   utl \
+   wpftqahelper \
+   $(gb_UWINAPI) \
+))
+
+$(eval $(call gb_CppunitTest_use_ure,writerperfect_import))
+$(eval $(call gb_CppunitTest_use_vcl,writerperfect_import))
+
+$(eval $(call gb_CppunitTest_use_rdb,writerperfect_import,services))
+
+$(eval $(call gb_CppunitTest_use_configuration,writerperfect_import))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,writerperfect_import,\
+   writerperfect/qa/unit/ImportTest \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/writerperfect/Module_writerperfect.mk 
b/writerperfect/Module_writerperfect.mk
index eda54bb6..3c6168e 100644
--- a/writerperfect/Module_writerperfect.mk
+++ b/writerperfect/Module_writerperfect.mk
@@ -39,6 +39,7 @@ $(eval $(call gb_Module_add_check_targets,writerperfect,\
 $(eval $(call gb_Module_add_slowcheck_targets,writerperfect,\
CppunitTest_writerperfect_calc \
CppunitTest_writerperfect_draw \
+   CppunitTest_writerperfect_import \
CppunitTest_writerperfect_impress \
CppunitTest_writerperfect_writer \
Library_wpftqahelper \
diff --git a/writerperfect/qa/unit/ImportTest.cxx 
b/writerperfect/qa/unit/ImportTest.cxx
new file mode 100644
index 000..9275c6c
--- /dev/null
+++ b/writerperfect/qa/unit/ImportTest.cxx
@@ -0,0 +1,118 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#include "WpftFilterFixture.hxx"
+#include "WpftLoader.hxx"
+
+namespace
+{
+
+namespace beans = css::beans;
+namespace container = css::container;
+namespace document = css::document;
+namespace lang = css::lang;
+namespace sheet = css::sheet;
+namespace table = css::table;
+namespace uno = css::uno;
+
+using uno::UNO_QUERY;
+
+using writerperfect::test::WpftLoader;
+
+class ImportTest : public writerperfect::test::WpftFilterFixture
+{
+public:
+virtual void setUp() override;
+
+void testWK3WithFM3();
+
+CPPUNIT_TEST_SUITE(ImportTest);
+CPPUNIT_TEST(testWK3WithFM3);
+CPPUNIT_TEST_SUITE_END();
+
+private:
+WpftLoader createCalcLoader(const rtl::OUString ) const;
+
+WpftLoader createLoader(const rtl::OUString , const rtl::OUString 
) const;
+
+rtl::OUString makeUrl(const rtl::OUString ) const;
+
+private:
+uno::Reference m_xFilterFactory;
+};
+
+void ImportTest::setUp()
+{
+writerperfect::test::WpftFilterFixture::setUp();
+
+m_xFilterFactory.set(
+
m_xFactory->createInstanceWithContext("com.sun.star.document.FilterFactory", 
m_xContext),
+UNO_QUERY);
+assert(m_xFilterFactory.is());
+}
+
+void 

[Libreoffice-bugs] [Bug 101664] Formatting : appearance of the drop caps disappears after closing a document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101664

--- Comment #29 from ThierryT  ---
I download the test file "test-de-lettrine.odt" on my computer.
I opened it and found no drop caps in the file.
I put a drop caps on the second paragraph. Save the file on my computer.
Close it and reopen it.
The drop caps still exist in the file.

I use:
Version: 5.3.0.2 (x64)
Build ID: 5ad7b2889021c491af62f7930a4b1cb631392f16
Threads CPU : 4; Version de l'OS :Windows 6.29; UI Render : par défaut; Moteur
de mise en page : nouveau; 
Locale : fr-FR (fr_FR); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #24 from Heiko Tietze  ---
(In reply to poma from comment #23)
> - PPI (aka DPI): 200

Sounds like a WONTFIX. We would need to make the dialog larger for those
unusual resolutions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84837

--- Comment #7 from Gülşah Köse  ---
(In reply to Yousuf Philips (jay) from comment #6)

> CCing Gulsah and Maxim for their input on how easy it might be acheived.

Hi, I'm working on #103258 now. It's about to complete. After that i'm going to
send a patch for this. Thanks for letting me know.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105594] Missing background-color for the button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105594

--- Comment #5 from Julien Nabet  ---
(In reply to Ysabeau from comment #4)
> (In reply to Julien Nabet from comment #3)
> > On pc Debian x86-64 with master sources updated yesterday or with LO Debian
> > package 5.2.4, I don't reproduce this.
> > 
> > For the test, could you rename your LO directory profile?(see
> > https://wiki.documentfoundation.org/UserProfile#Windows)
> 
> It appears in the 5.3 pre-release as you can see on the picture...

Yes I saw it. I just put it for the record. You'll notice that I haven't put
this bugtracker to RESOLVED and since I got no question, I haven't put it
either to NEEDINFO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105594] Missing background-color for the button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105594

--- Comment #4 from Ysabeau  ---
(In reply to Julien Nabet from comment #3)
> On pc Debian x86-64 with master sources updated yesterday or with LO Debian
> package 5.2.4, I don't reproduce this.
> 
> For the test, could you rename your LO directory profile?(see
> https://wiki.documentfoundation.org/UserProfile#Windows)

It appears in the 5.3 pre-release as you can see on the picture...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105598] Can't write in LibreOffice native command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105598

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
Would it be possible you attach an example file by using this link
https://bugs.documentfoundation.org/attachment.cgi?bugid=105598=enter ?
(have in mind that any attachment is automatically public, so remove any
confidential/private part from it)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105597] Create distance in table name

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105597

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #2 from Julien Nabet  ---
It seems spaces aren't allowed for table name.

see http://opengrok.libreoffice.org/xref/core/sw/source/ui/app/app.src#657
"The name of the table must not contain spaces"
You can have this message if you insert a table then select it, property and
try to validate a new name which includes a space.

Now why it wouldn't be allowed, I don't know.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105594] Missing background-color for the button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105594

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #3 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated yesterday or with LO Debian
package 5.2.4, I don't reproduce this.

For the test, could you rename your LO directory profile?(see
https://wiki.documentfoundation.org/UserProfile#Windows)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76219] HANG i#84870: WW8: large objects in russian text may cause loop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=76219

--- Comment #22 from Mike Kaganski  ---
(In reply to Xisco Faulí from comment #21)

Unfortunately, that's not that straightforward.
A document with layout problem that starts opening after some layout processing
change doesn't necessarily mean that the change has fixed this document's
problem. It may be just that this change has only moved the problematic point,
say, away from page break towards middle of a page (where it doesn't cause
infinite loop). And the problem is still there, but doesn't show itself.

I don't claim that all these bugs aren't duplicates; but I just wanted to say
that I wouldn't be surprised if there are two or three different problems here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #23 from poma  ---
Created attachment 130749
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130749=edit
LO 5.3.0.3 - Boutons Rechercher

UI language French,
dialog "Rechercher & remplacer" (en. "Find & Replace"),
text "Rechercher le précédant" (en. "Find Previous") of the label within the
button "backsearch",
and text "Rechercher le suivant" (en. "Find Next") of the label within the
button "search",
need more horizontal space.

The relevant settings are:
- Font size: 12
- PPI (aka DPI): 200
- Desktop enviroment: Xfce
- Desktop theme: Darkgrey
- VCL UI interfaces: GTK+ 3

Tested with:
libreoffice --version
LibreOffice 5.3.0.3 30(Build:3)
patched with:
"tdf#105371, tdf#99456 Alignment in find & replace dialog"
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=8e96cc8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #22 from poma  ---
Heiko, thank you for the welcome.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105339] Disable table column selection in the border margin and extend the area for selecting table row

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105339

--- Comment #5 from Telesto  ---
Created attachment 130748
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130748=edit
Screencast

Small screencast

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 105339] Disable table column selection in the border margin and extend the area for selecting table row

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105339

--- Comment #5 from Telesto  ---
Created attachment 130748
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130748=edit
Screencast

Small screencast

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105600] New: editing: selection via navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105600

Bug ID: 105600
   Summary: editing: selection via navigator
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: consciencia...@gmail.com

This enhancement is closely related to (Bug 63967, Bug 42787) and I presume
that the central planning for solving them would be shared.

I would like to be able to select a whole section of my document (for, say,
direct formatting, language selection, word count) via the NAVIGATOR.

I preferred to frame it as enhancement, although when trying to select a whole
set of pages where there are footnotes, they sometimes interfere. Therefore
selecting in NAVIGATOR would be very clean Ux enhancement.





Bug 63967 - Ability to Quickly Get Word Count of Sections Using Navigator 

Bug 42787 - Functionality request for Writer: Add deleting of Sections using
the Delete function inside of the Navigator

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105599] New: it should be possible to export hidden text to pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105599

Bug ID: 105599
   Summary: it should be possible to export hidden text to pdf
   Product: LibreOffice
   Version: 5.2.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bordfe...@web.de

I want to export a writer document containing hidden text to pdf. Is there a
possibility to do this? If not, would it be possible to add an option "Export
hidden text" to the "PDF Options"-dialogue?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93445] [l10n, Russian] All CDFs for discrete distributions should be marked “in Western tradition”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93445

--- Comment #5 from Mike Kaganski  ---
Now (in 5.3.0.3) that param is "Интегральная. При C=0 вычисляет функцию
вероятности, при C=1 — функцию распределения".

I am not sure that this is proper place to discuss the Russian translation; it
is actually done in forumooo.ru.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105598] New: Can't write in LibreOffice native command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105598

Bug ID: 105598
   Summary: Can't write in LibreOffice native command
   Product: LibreOffice
   Version: 5.3.0.2 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ebbe...@googlemail.com

I just tried to change from an old version of OpenOffice (4.1.3) to the new
LibreOffice. When I try to store a new or existing file in native LibreOffice
format or Microsoft xml it is not possible. I always end up with 'error during
save operation general error! Maybe it is not exact because I receive it in
German. 'Fehler beim Speichern des Dokumentes test: Allgemeiner Fehler.
Allgemeiner Ein-/Ausgabefehler'. This happens with writer as well as calc.
Storing the file in .txt format is successful. so it should not be a
permesssion problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: minutes of ESC call ...

[Tommy]

Michael Meeks wrote:



> 


* Release Engineering update (Christian)
+ 5.2.5 release status
+ announced today





https://wiki.documentfoundation.org/Releases/5.2.5/RC1

this page is still empty.
the list of fixed bugs has not been published yet.
Tommy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 105487] Screen readers have trouble reading tables that span multiple pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105487

Alex ARNAUD  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||alexarn...@hypra.fr
 Ever confirmed|0   |1

--- Comment #2 from Alex ARNAUD  ---
Dear all,

I can reproduce the issue with LibreOffice 5.2.4 (GTK2) on Debian 8.7 with Orca
master.

Best regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105594] Missing background-color for the button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105594

--- Comment #1 from Julien Nabet  ---
*** Bug 105596 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105594] Missing background-color for the button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105594

--- Comment #2 from Julien Nabet  ---
*** Bug 105595 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105596] Missing background-color for the button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105596

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Julien Nabet  ---


*** This bug has been marked as a duplicate of bug 105594 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105595] Missing background-color for the button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105595

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Julien Nabet  ---


*** This bug has been marked as a duplicate of bug 105594 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105586] Do not remove end point of closed Bézier =?UTF-8?Q?=20curve?=, if start point = end point

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105586

Jacques Guilleron  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||guillero...@aol.com
 Ever confirmed|0   |1

--- Comment #1 from Jacques Guilleron  ---
Hi Regina,

I found your indications by opening the file with Notepad++.
Nothing displays in playing mode with
LO 5.2.4.2 (x64) Build ID: 3d5603e1122f0f102b62521720ab13a38a4e0eb0
Threads CPU : 2; Version de l'OS :Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
under Windows 7 home.

Same missing with
LO 3.6.1.2 (Build ID: e29a214)

Area is displayed with
LO 3.5.3.2 Version ID : 235ab8a-3802056-4a8fed3-2d66ea8-e241b80
but the stroke is still missing.
Opening the curve allows displaying the stroke in playing mode. 

Jacques

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105597] Create distance in table name

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105597

--- Comment #1 from Pourrabi  ---
Created attachment 130747
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130747=edit
Video Copy

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105597] New: Create distance in table name

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105597

Bug ID: 105597
   Summary: Create distance in table name
   Product: LibreOffice
   Version: 5.3.0.0.beta2
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: moderndl...@gmail.com

In the naming of table in insert table window, space button for create distance
don't work

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103100

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||105333


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105333
[Bug 105333] UX: A table can't be cut and paste fully (the source table stays
behind)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: bin/gbuild-to-ide osx/jantest osx/janTestLib

[jan Iversen]

 bin/gbuild-to-ide|  209 ++-
 osx/janTestLib/janTestLib.h  |   13 ++
 osx/janTestLib/janTestLib.m  |   13 ++
 osx/jantest/LibMain.cpp  |   15 +++
 osx/jantest/UnittestMain.cpp |   15 +++
 5 files changed, 167 insertions(+), 98 deletions(-)

New commits:
commit 05ce36d2e2bada48ee97d6a7c45e3bcf71dff29a
Author: jan Iversen 
Date:   Sun Jan 29 17:10:36 2017 +0100

gbuild-to-ide xcode, added targets in menu

First step in removing make as builder.

Change-Id: I445627df5610a7d0b8bfbabddb66f1273e021b1a

diff --git a/bin/gbuild-to-ide b/bin/gbuild-to-ide
index 4596222..42ba3b1 100755
--- a/bin/gbuild-to-ide
+++ b/bin/gbuild-to-ide
@@ -437,11 +437,18 @@ class XcodeIntegrationGenerator(IdeIntegrationGenerator):
 def __init__(self, gbuildparser, ide):
 IdeIntegrationGenerator.__init__(self, gbuildparser, ide)
 
-counter = 16777216
+typeCounter = {'PBXProject'   : 00,
+   'PBXGroup' : 10,
+   'PBXFileReference' : 20,
+   'PBXNativeTarget'  : 30,
+   'XCConfigurationList'  : 40,
+   'PBXSourcesBuildPhase' : 50,
+   'XCBuildConfiguration' : 60,
+   'PBXBuildFile' : 70}
 
 def emit(self):
-rootId = 'X001'
-mainGroupId = 'X002'
+mainGroupId, mainGroup = self.generate_PBXGroup(None)
+rootId = self.generate_id('PBXProject')
 self.rootObj = {'attributes': {'LastUpgradeCheck': '0820',
'ORGANIZATIONNAME': 'LibreOffice',
'TargetAttributes': {}},
@@ -455,7 +462,6 @@ class XcodeIntegrationGenerator(IdeIntegrationGenerator):
 'projectRoot': '',
 'buildConfigurationList': '',
 'targets': []}
-mainGroup = {'isa': 'PBXGroup', 'children': [], 'sourceTree': 
''}
 pbxproj = {'archiveVersion': 1,
'classes': {},
'objectVersion': 46,
@@ -465,27 +471,28 @@ class XcodeIntegrationGenerator(IdeIntegrationGenerator):
 for module in self.gbuildparser.modules:
 if module == 'include':
 continue
-sourceId, sourceObj = self.define_pbxgroup('Sources')
-includeId, includeObj = self.define_pbxgroup('Headers')
-moduleId, moduleObj = self.define_pbxgroup(module)
+moduleId, moduleObj = self.generate_PBXGroup(module)
+sourceId, sourceObj = self.generate_PBXGroup('Sources')
+includeId, includeObj = self.generate_PBXGroup('Headers')
+targetId, targetObj = self.generate_PBXGroup('Targets')
 
-moduleObj['children'] = [sourceId, includeId]
+moduleObj['children'] = [sourceId, includeId, targetId]
 pbxproj['objects'].update({sourceId:  sourceObj,
includeId: includeObj,
-   moduleId: moduleObj})
+   moduleId: moduleObj,
+   targetId: targetObj})
 mainGroup['children'].append(moduleId)
 
 for i in self.gbuildparser.modules[module]['headers']:
-ref = self.generate_id()
+ref = self.generate_id('PBXFileReference')
 pbxproj['objects'][ref] = 
self.generate_PBXFileReference(module, i)
 includeObj['children'].append(ref)
 for i in self.gbuildparser.modules[module]['sources']:
-ref = self.generate_id()
+ref = self.generate_id('PBXFileReference')
 pbxproj['objects'][ref] = 
self.generate_PBXFileReference(module, i)
 sourceObj['children'].append(ref)
-
 for target in self.gbuildparser.modules[module]['targets']:
-pbxproj['objects'].update(self.generate_project(target, 
module, sourceObj['children']))
+pbxproj['objects'].update(self.generate_target(target, module, 
targetObj, sourceObj['children']))
 
 xcodeprojdir = './osx/libreoffice.xcodeproj'
 try:
@@ -496,13 +503,6 @@ class XcodeIntegrationGenerator(IdeIntegrationGenerator):
 f.write('// !$*UTF8*$!\n')
 self.write_object(pbxproj, f, 0)
 
-def define_pbxgroup(self, name):
-return self.generate_id(), {'isa': 'PBXGroup', 'children': [], 'name': 
name, 'sourceTree': ''}
-
-def generate_id(self):
-XcodeIntegrationGenerator.counter += 1
-return str('X%07x' % XcodeIntegrationGenerator.counter)
-
 def indent(self, file, level):
 if level != 0:
 for i in range(0, level):
@@ -535,7 +535,34 @@ class XcodeIntegrationGenerator(IdeIntegrationGenerator):