[Libreoffice-commits] core.git: helpcontent2

[Adolfo Jayme Barrientos]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cba153ca03ce201948e7d18438abd6f33054ad5e
Author: Adolfo Jayme Barrientos 
Date:   Wed Mar 22 23:54:03 2017 -0600

Updated core
Project: help  b67d9744ba73792377b249fd008848125696a769

Partially revert e40264511 for unwanted terminology change

Change-Id: I820d8a200d881bf900b03b922eabf49c416dd83d

diff --git a/helpcontent2 b/helpcontent2
index 0df6af74a2f1..b67d9744ba73 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 0df6af74a2f1fb791d27ca316e206661bf74b2c5
+Subproject commit b67d9744ba73792377b249fd008848125696a769
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Adolfo Jayme Barrientos]

 source/text/swriter/01/05060700.xhp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit b67d9744ba73792377b249fd008848125696a769
Author: Adolfo Jayme Barrientos 
Date:   Wed Mar 22 23:54:03 2017 -0600

Partially revert e40264511 for unwanted terminology change

Change-Id: I820d8a200d881bf900b03b922eabf49c416dd83d

diff --git a/source/text/swriter/01/05060700.xhp 
b/source/text/swriter/01/05060700.xhp
index f20949a57..83999f50c 100644
--- a/source/text/swriter/01/05060700.xhp
+++ b/source/text/swriter/01/05060700.xhp
@@ -119,10 +119,10 @@
 
 
 
-Trigger Link
+Trigger Hyperlink
 
 
-link that is assigned to the object is clicked
+hyperlink that is assigned to the object is clicked
 
 
 x
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #34 from Mike Kaganski  ---
... as well as author of DCM Direct Colour Management - Gerhard Weydt.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #33 from Mike Kaganski  ---
AltSearch author (Tomáš Bílek) has been sent an email.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #32 from Mike Kaganski  ---
(In reply to Katarina Behrens (CIB) from comment #26)
> So I wonder if we can coordinate the activity somewhere, which extensions
> are fixed or at the least their author(s) are notified and which are still
> missing 
> ...
> I've seen TexMath has a ticket (and possibly also a fix already), anyone
> else?

Typography extension developer (Lazlo Nemeth) is notified and answered that
he'll look at this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99839] German localization of "page count": Seitenanzahl instead of Seitenzahl

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99839

Kü  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 Whiteboard||target:5.2.7 target:5.3.2

--- Comment #7 from Kü  ---
Thanks for reporting this misspelling.

I changed in Pootle for 5.2 and 5.3.

I will be corrected in 5.2.7 and 5.3.2 releses.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106653] RTL Arabic justified text has some gaps between characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106653

--- Comment #10 from Munzir Taha  ---
Created attachment 132087
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132087=edit
reproduceable without marks (screenshot)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106653] RTL Arabic justified text has some gaps between characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106653

--- Comment #9 from Munzir Taha  ---
Created attachment 132086
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132086=edit
reproduceable without marks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106653] RTL Arabic justified text has some gaps between characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106653

--- Comment #8 from Munzir Taha  ---
@Khaled: you mentioned that
> the gap there should be a kashida but it moves to the wrong direction
> due to the presence of combining mark on the right of it

However, I can reproduce it with no marks on the right of it. Attached is an
example file and a screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105041] Wrong German translation of "Entire Document"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105041

Kü  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 Whiteboard||target:5.2.7 target:5.3.2

--- Comment #3 from Kü  ---
Thanks for reporting this misspelling.

I changed in Pootle for 5.2 and 5.3.

I will be corrected in 5.2.7 and 5.3.2 releses.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106714] New: In Mailmerge Filter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106714

Bug ID: 106714
   Summary: In Mailmerge Filter
   Product: LibreOffice
   Version: unspecified
  Hardware: Other
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hans.r...@gmx.de

Created attachment 132085
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132085=edit
shows the filter dialoge

In writer I doing a mailmerge using the mailmerge assistent. Select the ods
file and the appropiate sheet. When I click on "filter" a wide small window
shows up with 3 lines and the headings "fieldname" (Feldname in German) and
"value". No possibility to select a database field. That wasn't in a very early
version, but goes on like this since a few years. Hopefully we can solve this
problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105042] Wrong German translation for styles "Table Contents" and " Table Heading"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105042

Kü  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 Whiteboard||target:5.2.7 target:5.3.2

--- Comment #3 from Kü  ---
Thanks for reporting this misspelling.

I changed in Pootle for 5.2 and 5.3.

I will be corrected in 5.2.7 and 5.3.2 releses.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: starmath/inc starmath/source

[Takeshi Abe]

 starmath/inc/parse.hxx|6 ++---
 starmath/source/parse.cxx |   53 --
 2 files changed, 22 insertions(+), 37 deletions(-)

New commits:
commit faeda4e29e0be16050dd919a62ecf69a4ffdf2f8
Author: Takeshi Abe 
Date:   Thu Mar 23 12:10:46 2017 +0900

starmath: Make DoProduct()/DoSum()/DoRelation() return SmNode

to reduce an excessive number of stack operations.

Change-Id: Ia4ef08dce76d318c56bf7d112f686e13d1b2660e
Reviewed-on: https://gerrit.libreoffice.org/35551
Tested-by: Jenkins 
Reviewed-by: Takeshi Abe 

diff --git a/starmath/inc/parse.hxx b/starmath/inc/parse.hxx
index d158c3995151..8872b8edac9a 100644
--- a/starmath/inc/parse.hxx
+++ b/starmath/inc/parse.hxx
@@ -64,9 +64,9 @@ class SmParser
 SmTableNode *DoTable();
 voidDoLine();
 SmNode *DoExpression();
-voidDoRelation();
-voidDoSum();
-voidDoProduct();
+SmNode *DoRelation();
+SmNode *DoSum();
+SmNode *DoProduct();
 SmNode *DoSubSup(TG nActiveGroup, SmNode *pGivenNode);
 SmNode *DoOpSubSup();
 SmNode *DoPower();
diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx
index 14ab62aad504..07383f3e359e 100644
--- a/starmath/source/parse.cxx
+++ b/starmath/source/parse.cxx
@@ -1037,15 +1037,9 @@ SmNode *SmParser::DoExpression()
 }
 
 SmNodeArray  RelationArray;
-
-DoRelation();
-RelationArray.push_back(popOrZero(m_aNodeStack));
-
+RelationArray.push_back(DoRelation());
 while (m_aCurToken.nLevel >= 4)
-{
-DoRelation();
-RelationArray.push_back(popOrZero(m_aNodeStack));
-}
+RelationArray.push_back(DoRelation());
 
 if (RelationArray.size() > 1)
 {
@@ -1061,41 +1055,35 @@ SmNode *SmParser::DoExpression()
 }
 }
 
-void SmParser::DoRelation()
+SmNode *SmParser::DoRelation()
 {
-DoSum();
+SmNode *pFirst = DoSum();
 while (TokenInGroup(TG::Relation))
 {
 std::unique_ptr pSNode(new SmBinHorNode(m_aCurToken));
-SmNode *pFirst = popOrZero(m_aNodeStack);
-
 SmNode *pSecond = DoOpSubSup();
-
-DoSum();
-
-pSNode->SetSubNodes(pFirst, pSecond, popOrZero(m_aNodeStack));
-m_aNodeStack.push_front(std::move(pSNode));
+SmNode *pThird = DoSum();
+pSNode->SetSubNodes(pFirst, pSecond, pThird);
+pFirst = pSNode.release();
 }
+return pFirst;
 }
 
-void SmParser::DoSum()
+SmNode *SmParser::DoSum()
 {
-DoProduct();
+SmNode *pFirst = DoProduct();
 while (TokenInGroup(TG::Sum))
 {
 std::unique_ptr pSNode(new SmBinHorNode(m_aCurToken));
-SmNode *pFirst = popOrZero(m_aNodeStack);
-
 SmNode *pSecond = DoOpSubSup();
-
-DoProduct();
-
-pSNode->SetSubNodes(pFirst, pSecond, popOrZero(m_aNodeStack));
-m_aNodeStack.push_front(std::move(pSNode));
+SmNode *pThird = DoProduct();
+pSNode->SetSubNodes(pFirst, pSecond, pThird);
+pFirst = pSNode.release();
 }
+return pFirst;
 }
 
-void SmParser::DoProduct()
+SmNode *SmParser::DoProduct()
 {
 SmNode *pFirst = DoPower();
 
@@ -1165,7 +1153,7 @@ void SmParser::DoProduct()
 }
 pFirst = pSNode;
 }
-m_aNodeStack.emplace_front(pFirst);
+return pFirst;
 }
 
 SmNode *SmParser::DoSubSup(TG nActiveGroup, SmNode *pGivenNode)
@@ -1197,7 +1185,7 @@ SmNode *SmParser::DoSubSup(TG nActiveGroup, SmNode 
*pGivenNode)
 if (eType == TFROM  ||  eType == TTO)
 {
 // parse limits in old 4.0 and 5.0 style
-DoRelation();
+m_aNodeStack.emplace_front(DoRelation());
 }
 else
 m_aNodeStack.emplace_front(DoTerm(true));
@@ -2072,11 +2060,8 @@ SmTableNode *SmParser::DoBinom()
 
 NextToken();
 
-DoSum();
-DoSum();
-
-SmNode *pSecond = popOrZero(m_aNodeStack);
-SmNode *pFirst = popOrZero(m_aNodeStack);
+SmNode *pFirst = DoSum();
+SmNode *pSecond = DoSum();
 pSNode->SetSubNodes(pFirst, pSecond);
 return pSNode.release();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Henry Castro]

 loleaflet/src/layer/AnnotationManager.js |3 ++-
 loleaflet/src/layer/tile/ImpressTileLayer.js |2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit a759a01c7de89b387943ad4173c9b72cd30581d9
Author: Henry Castro 
Date:   Wed Mar 22 22:32:31 2017 -0400

loleaflet: ensure visible element before getting bounds

Change-Id: Iae66d8d52f4d97b61d861586e5a008c18d15e39d

diff --git a/loleaflet/src/layer/AnnotationManager.js 
b/loleaflet/src/layer/AnnotationManager.js
index c882b9a0..ba539491 100644
--- a/loleaflet/src/layer/AnnotationManager.js
+++ b/loleaflet/src/layer/AnnotationManager.js
@@ -129,6 +129,7 @@ L.AnnotationManager = L.Class.extend({
if (this._selected.annotation) {
point = L.point(topRight.x, 
this._map._docLayer._twipsToPixels(this._selected.annotation._data.anchorPos.min).y);

this._selected.annotation.setLatLng(this._map.unproject(point));
+   this._selected.annotation.show();
bounds = this._selected.annotation.getBounds();
bounds.extend(bounds.min.subtract([0, 
this.options.marginY]));
bounds.extend(bounds.getBottomLeft().add([0, 
this.options.marginY]));
@@ -143,6 +144,7 @@ L.AnnotationManager = L.Class.extend({
point = L.point(topRight.x, 
this._map._docLayer._twipsToPixels(annotation._data.anchorPos.min).y);
latlng = this._map.unproject(point);
annotation.setLatLng(latlng);
+   annotation.show();
bounds = annotation.getBounds();
foundBounds = null;
for (var itBounds in layouts) {
@@ -180,7 +182,6 @@ L.AnnotationManager = L.Class.extend({
}
 
annotation.setLatLng(latlng);
-   annotation.show();
}
},
 
diff --git a/loleaflet/src/layer/tile/ImpressTileLayer.js 
b/loleaflet/src/layer/tile/ImpressTileLayer.js
index 1390216e..552e4ddf 100644
--- a/loleaflet/src/layer/tile/ImpressTileLayer.js
+++ b/loleaflet/src/layer/tile/ImpressTileLayer.js
@@ -126,9 +126,9 @@ L.ImpressTileLayer = L.TileLayer.extend({
annotation = annotations[index];
if (index >= this._topAnnotation) {
annotation.setLatLng(bounds ? 
this._map.layerPointToLatLng(bounds.getBottomLeft()) : 
this._map.layerPointToLatLng(topRight));
+   annotation.show();
bounds = annotation.getBounds();
bounds.extend(L.point(bounds.max.x, 
bounds.max.y + this.options.marginY));
-   annotation.show();
} else {
annotation.hide();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106713] New: Views in Impress Remote

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106713

Bug ID: 106713
   Summary: Views in Impress Remote
   Product: Impress Remote
   Version: 2.2.3
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: micahmun...@outlook.com

Description:
Hi,
I love using Impress Remote.  It allows me to control my powerpoint at church
from the stage and allows me to view my current slide. However, it would be
nice if the remote app itself will allow me to view both my current slide and
the next slide at the same time.  It is very important for me sometimes to be
able to have an idea of what is coming in my next slide.  I am not sure if this
feature already exists but I couldn't find any setting which would allow me to
do this.

I will greatly appreciate it if this feature could be added to the Impress
remote app for both iOS and Android with the ability to resize the slides for
proper viewing.

Actual Results:  
Can either view current slides and notes or only the current slide.

Expected Results:
In addition to the other views available, I would like to view both the current
and next slide.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:52.0) Gecko/20100101
Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106681] Feature Request: Ability to assign character styles to toolbar buttons...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106681

--- Comment #11 from LibreTraining  ---
The ability to assign styles to toolbar buttons is a very useful feature.
I started watching this feature request because this is a feature I could use
yesterday.

Let me see if I understand this WONTFIX “logic” ...
A feature which will help knowledgable advanced users is not a priority 
because ignorant beginner users use what is in front of them.



To an advanced user the Formatting toolbar is nearly useless.
I turn it off.
The ONLY thing on that toolbar which is useful is the style drop-down.
Everything else is going to be in the styles.
To a knowledgable user the Formatting toolbar is a waste of screen real estate.

Same with the Standard (Single Mode) toolbar – 15 of those tools are useless to
anyone properly using styles. So more than half the tools are a waste of space.

So what is an advanced user to do? 
Create their own toolbars. 
Actually useful toolbars.

How about an Ebook toolbar with all the proper styles required to create an
ebook?
That would help even ignorant beginners get started in the right direction.

How about a Long Document toolbar with all the needed styles and tools right
there?
Instead of scattered all over buried in menus.

The ability to assign styles to toolbar buttons is a very useful feature.


Word also has a feature where styles can be made the only formatting option. 
The author can select the allowed styles, and then turn-off everything else. 
The direct formatting tools are all greyed-out, and not available.
A quick way to break the direct formatting habit.
No more receiving Word-salad documents.


Style drop-down selectors are also very useful.

Word has a style drop-down which you can include in the Quick Access bar.
You can turn-off the ribbon and still easily access your styles.

The Quick Styles gallery on the ribbon is basically a bunch of styles buttons.
Little style buttons which actually have a little preview of the style in them.
Style buttons. Good idea.

You can also add the Quick Styles gallery to the Quick Access bar.
You can have two styles tools on the Quick Access bar and turn-off the ribbon
and menus.

The Adobe InDesign toolbar includes both paragraph and character style
drop-down selectors, and it is easy to switch back and forth between them.


Given the current stated goal of enabling LibeOffice users to have-it-your-way
it would seem to make sense to give them the tools to do so.


The ability to assign styles to toolbar buttons is a very useful feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 106681] Feature Request: Ability to assign character styles to toolbar buttons...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106681

--- Comment #11 from LibreTraining  ---
The ability to assign styles to toolbar buttons is a very useful feature.
I started watching this feature request because this is a feature I could use
yesterday.

Let me see if I understand this WONTFIX “logic” ...
A feature which will help knowledgable advanced users is not a priority 
because ignorant beginner users use what is in front of them.



To an advanced user the Formatting toolbar is nearly useless.
I turn it off.
The ONLY thing on that toolbar which is useful is the style drop-down.
Everything else is going to be in the styles.
To a knowledgable user the Formatting toolbar is a waste of screen real estate.

Same with the Standard (Single Mode) toolbar – 15 of those tools are useless to
anyone properly using styles. So more than half the tools are a waste of space.

So what is an advanced user to do? 
Create their own toolbars. 
Actually useful toolbars.

How about an Ebook toolbar with all the proper styles required to create an
ebook?
That would help even ignorant beginners get started in the right direction.

How about a Long Document toolbar with all the needed styles and tools right
there?
Instead of scattered all over buried in menus.

The ability to assign styles to toolbar buttons is a very useful feature.


Word also has a feature where styles can be made the only formatting option. 
The author can select the allowed styles, and then turn-off everything else. 
The direct formatting tools are all greyed-out, and not available.
A quick way to break the direct formatting habit.
No more receiving Word-salad documents.


Style drop-down selectors are also very useful.

Word has a style drop-down which you can include in the Quick Access bar.
You can turn-off the ribbon and still easily access your styles.

The Quick Styles gallery on the ribbon is basically a bunch of styles buttons.
Little style buttons which actually have a little preview of the style in them.
Style buttons. Good idea.

You can also add the Quick Styles gallery to the Quick Access bar.
You can have two styles tools on the Quick Access bar and turn-off the ribbon
and menus.

The Adobe InDesign toolbar includes both paragraph and character style
drop-down selectors, and it is easy to switch back and forth between them.


Given the current stated goal of enabling LibeOffice users to have-it-your-way
it would seem to make sense to give them the tools to do so.


The ability to assign styles to toolbar buttons is a very useful feature.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] online.git: loleaflet/src

[Henry Castro]

 loleaflet/src/layer/AnnotationManager.js |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f3700400e68a7e33c45b1a2d483d6fff53a1f920
Author: Henry Castro 
Date:   Wed Mar 22 21:21:41 2017 -0400

loleaflet: fix the selection of the annotation object

Change-Id: I1bf6b669b768057b7b9943654db79b2966ca3ec3

diff --git a/loleaflet/src/layer/AnnotationManager.js 
b/loleaflet/src/layer/AnnotationManager.js
index 8933f6e5..c882b9a0 100644
--- a/loleaflet/src/layer/AnnotationManager.js
+++ b/loleaflet/src/layer/AnnotationManager.js
@@ -94,7 +94,7 @@ L.AnnotationManager = L.Class.extend({
 
select: function (obj) {
var annotation = obj instanceof L.Annotation ? obj : 
this.getItem(obj);
-   if (!this._selected.annotation || 
this._selected.annotation._data.id !== annotation._data.id) {
+   if (annotation) {
this._selected.annotation = annotation;
this.update();
}
@@ -103,8 +103,8 @@ L.AnnotationManager = L.Class.extend({
update: function () {
var topRight = 
this._map.project(this._map.options.maxBounds.getNorthEast());
var point, rectangles;
-   this.layout();
if (this._selected.annotation) {
+   this.layout();
point = 
this._map._docLayer._twipsToPixels(this._selected.annotation._data.anchorPos.min);
this._map._docLayer._selections.clearLayers();
rectangles = 
L.PolyUtil.rectanglesToPolygons(L.LOUtil.stringToRectangles(this._selected.annotation._data.textRange),
 this._map._docLayer);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Henry Castro]

 loleaflet/src/layer/AnnotationManager.js|   23 +++
 loleaflet/src/layer/tile/TileLayer.js   |6 ++
 loleaflet/src/layer/tile/WriterTileLayer.js |4 
 3 files changed, 33 insertions(+)

New commits:
commit 0107e0e0d9ebfa9a622a3aefc5541ad90485b154
Author: Henry Castro 
Date:   Wed Mar 22 21:11:53 2017 -0400

loleaflet: handle annotation reply for writer documents

Change-Id: Iff95919d6f413b025ddb386150f458b9ecf2ce88

diff --git a/loleaflet/src/layer/AnnotationManager.js 
b/loleaflet/src/layer/AnnotationManager.js
index a21bf121..8933f6e5 100644
--- a/loleaflet/src/layer/AnnotationManager.js
+++ b/loleaflet/src/layer/AnnotationManager.js
@@ -14,6 +14,7 @@ L.AnnotationManager = L.Class.extend({
this._selected = {};
this._map.on('AnnotationCancel', this._onAnnotationCancel, 
this);
this._map.on('AnnotationClick', this._onAnnotationClick, this);
+   this._map.on('AnnotationReply', this._onAnnotationReply, this);
this._map.on('AnnotationSave', this._onAnnotationSave, this);
},
 
@@ -204,6 +205,12 @@ L.AnnotationManager = L.Class.extend({
annotation.focus();
},
 
+   reply: function (annotation) {
+   annotation.reply();
+   this.select(annotation);
+   annotation.focus();
+   },
+
remove: function (id) {
var comment = {
Id: {
@@ -301,6 +308,22 @@ L.AnnotationManager = L.Class.extend({
this.select(e.annotation);
},
 
+   _onAnnotationReply: function (e) {
+   var comment = {
+   Id: {
+   type: 'string',
+   value: e.annotation._data.id
+   },
+   Text: {
+   type: 'string',
+   value: e.annotation._data.reply
+   }
+   };
+   this._map.sendUnoCommand('.uno:ReplyComment', comment);
+   this.unselect();
+   this._map.focus();
+   },
+
_onAnnotationSave: function (e) {
var comment;
if (e.annotation._data.id === 'new') {
diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 7c0d282f..89031dd6 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -184,6 +184,12 @@ L.TileLayer = L.GridLayer.extend({

that.onAnnotationModify.call(that, options.$trigger.get(0).annotation);
}
},
+   reply: {
+   name:_('Reply'),
+   callback: function (key, options) {
+   
that.onAnnotationReply.call(that, options.$trigger.get(0).annotation);
+   }
+   },
remove: {
name: _('Remove'),
callback: function (key, options) {
diff --git a/loleaflet/src/layer/tile/WriterTileLayer.js 
b/loleaflet/src/layer/tile/WriterTileLayer.js
index 7be1d873..b13c6df1 100644
--- a/loleaflet/src/layer/tile/WriterTileLayer.js
+++ b/loleaflet/src/layer/tile/WriterTileLayer.js
@@ -28,6 +28,10 @@ L.WriterTileLayer = L.TileLayer.extend({
this._annotations.remove(id);
},
 
+   onAnnotationReply: function (annotation) {
+   this._annotations.reply(annotation);
+   },
+
onChangeAccept: function(id) {
this._annotations.acceptChange(id);
},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Henry Castro]

 loleaflet/src/layer/marker/Annotation.js |  120 ---
 1 file changed, 79 insertions(+), 41 deletions(-)

New commits:
commit e30bcdfcd8a498b30304b424c7347d6425379489
Author: Henry Castro 
Date:   Wed Mar 22 21:07:48 2017 -0400

loleaflet: add reply property to the annotation object

Change-Id: I58323dd35380e9cadf25661f85f38e080bbff026

diff --git a/loleaflet/src/layer/marker/Annotation.js 
b/loleaflet/src/layer/marker/Annotation.js
index 277a1d9d..364921a0 100644
--- a/loleaflet/src/layer/marker/Annotation.js
+++ b/loleaflet/src/layer/marker/Annotation.js
@@ -59,74 +59,104 @@ L.Annotation = L.Layer.extend({
show: function () {
this._container.style.visibility = '';
this._contentNode.style.display = '';
-   this._editNode.style.display = 'none';
+   this._nodeModify.style.display = 'none';
+   this._nodeReply.style.display = 'none';
},
 
hide: function () {
this._container.style.visibility = 'hidden';
-   this._editNode.style.display = 'none';
+   this._contentNode.style.display = 'none';
+   this._nodeModify.style.display = 'none';
+   this._nodeReply.style.display = 'none';
},
 
edit: function () {
this._container.style.visibility = '';
this._contentNode.style.display = 'none';
-   this._editNode.style.display = '';
+   this._nodeModify.style.display = '';
+   this._nodeReply.style.display = 'none';
+   return this;
+   },
+
+   reply: function () {
+   this._container.style.visibility = '';
+   this._contentNode.style.display = '';
+   this._nodeModify.style.display = 'none';
+   this._nodeReply.style.display = '';
return this;
},
 
isEdit: function () {
-   return this._editNode && this._editNode.style.display !== 
'none';
+   return (this._nodeModify && this._nodeModify.style.display !== 
'none') ||
+  (this._nodeReply && this._nodeReply.style.display !== 
'none');
},
 
focus: function () {
-   this._editText.focus();
+   this._nodeModifyText.focus();
+   this._nodeReplyText.focus();
+   },
+
+   _createButton: function(container, value, handler) {
+   var button = L.DomUtil.create('input', 'loleaflet-controls', 
container);
+   button.type = 'button';
+   button.value = value;
+   L.DomEvent.on(button, 'click', handler, this);
},
 
_initLayout: function () {
+   var buttons,
+   tagTd = 'td',
+   tagDiv = 'div',
+   empty = '',
+   click = 'click',
+   tagTextArea = 'textarea',
+   cancel = _('Cancel'),
+   classTextArea = 'loleaflet-annotation-textarea',
+   classEdit = 'loleaflet-annotation-edit';
var container = this._container =
-   L.DomUtil.create('div', 'loleaflet-annotation');
+   L.DomUtil.create(tagDiv, 'loleaflet-annotation');
var wrapper = this._wrapper =
-   L.DomUtil.create('div', 
'loleaflet-annotation-content-wrapper', container);
-   this._tableAuthor = L.DomUtil.create('table', 
'loleaflet-annotation-table', wrapper);
-   var tbody = L.DomUtil.create('tbody', '', this._tableAuthor);
-   var tr = L.DomUtil.create('tr', '', tbody);
-   var tdImg = L.DomUtil.create('td', 'loleaflet-annotation-img', 
tr);
-   var tdAuthor = L.DomUtil.create('td', 
'loleaflet-annotation-author', tr);
-   var tdMenu = L.DomUtil.create('td', '', tr);
-   var imgAuthor = L.DomUtil.create('img', '', tdImg);
+   L.DomUtil.create(tagDiv, 
'loleaflet-annotation-content-wrapper', container);
+   this._author = L.DomUtil.create('table', 
'loleaflet-annotation-table', wrapper);
+   var tbody = L.DomUtil.create('tbody', empty, this._author);
+   var tr = L.DomUtil.create('tr', empty, tbody);
+   var tdImg = L.DomUtil.create(tagTd, 'loleaflet-annotation-img', 
tr);
+   var tdAuthor = L.DomUtil.create(tagTd, 
'loleaflet-annotation-author', tr);
+   var tdMenu = L.DomUtil.create(tagTd, empty, tr);
+   var imgAuthor = L.DomUtil.create('img', empty, tdImg);
imgAuthor.setAttribute('src', L.Icon.Default.imagePath + 
'/user.png');
imgAuthor.setAttribute('width', this.options.imgSize.x);
imgAuthor.setAttribute('height', this.options.imgSize.y);
-   L.DomUtil.create('div', 

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6710

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106710] Access2base Are you missing parentheses?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106710

Aron Budea  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
   Hardware|x86 (IA32)  |All
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6529
 Resolution|DUPLICATE   |---
 Ever confirmed|0   |1
 OS|Windows (All)   |All

--- Comment #2 from Aron Budea  ---
Access2Base is in LibreOffice repo, this is a good opportunity to fix the
missing parentheses. Reopening.

Eg.
http://opengrok.libreoffice.org/xref/core/wizards/source/access2base/Trace.xba

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106681] Feature Request: Ability to assign character styles to toolbar buttons...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106681

--- Comment #10 from vermontp...@gmail.com ---
Just tried applying icons. I used the stock "Default", "Italics", and "Bold"
Icons offered by LO. However, they're not showing up in the toolbar, only text.
The Icons option is chosen. Also tried "Icons & Text" option. 

Possibly a bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106681] Feature Request: Ability to assign character styles to toolbar buttons...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106681

--- Comment #9 from vermontp...@gmail.com ---
Update. It works:



http://openoffice.org/2001/toolbar;
xmlns:xlink="http://www.w3.org/1999/xlink; toolbar:uiname="Styles">
 
 
 
 


I initially tried to edit the custom toolbar while it was blank. That didn't
work because syntax was missing (and I wouldn't know enough to recognize it). I
then tried adding the Styles button before adding my own lines. Adding the
Styles button via LO's customize option apparently reconfigured the xml file so
that I could edit it successfully. (?) I'm guessing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 106681] Feature Request: Ability to assign character styles to toolbar buttons...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106681

--- Comment #9 from vermontp...@gmail.com ---
Update. It works:



http://openoffice.org/2001/toolbar;
xmlns:xlink="http://www.w3.org/1999/xlink; toolbar:uiname="Styles">
 
 
 
 


I initially tried to edit the custom toolbar while it was blank. That didn't
work because syntax was missing (and I wouldn't know enough to recognize it). I
then tried adding the Styles button before adding my own lines. Adding the
Styles button via LO's customize option apparently reconfigured the xml file so
that I could edit it successfully. (?) I'm guessing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 106681] Feature Request: Ability to assign character styles to toolbar buttons...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106681

--- Comment #8 from vermontp...@gmail.com ---
Thanks for the Howto. Am using Mint/Ubuntu 16.04 with LO 5.3.1.2

Some differences in Linux:

The location of the config file for the user's custom toolbar is:

home//.config/libreoffice/4/user/config/soffice.cfg/modules/swriter/toolbar

The location of the menubar.xml file is:

usr/lib/libreoffice/share/config/soffice.cfg/modules/swriter/menubar

I edited my Styles toolbar thusly:



http://openoffice.org/2001/toolbar;
xmlns:xlink="http://www.w3.org/1999/xlink; toolbar:uiname="Styles"/>



In Linux, '&' apparently needs to be ''. So, your example:



Should appear as the following in Linux:



All that said, all I get in LO is an empty toolbar. There's probably some other
nicety that's missing as concerns Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106710] Access2base Are you missing parentheses?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106710

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Xisco Faulí  ---
Hello,
Yes, it's a duplicated of bug 106529 and it should be fixed in LibreOffice
5.3.3.
Thanks for reporting.

*** This bug has been marked as a duplicate of bug 106529 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Xisco Faulí  changed:

   What|Removed |Added

 CC||jorojma...@gmail.com

--- Comment #31 from Xisco Faulí  ---
*** Bug 106710 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svx/source

[Caolán McNamara]

 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx |9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

New commits:
commit 1670cc25bc2771e87f7956a4b0dd634abaa4128b
Author: Caolán McNamara 
Date:   Wed Mar 22 21:03:15 2017 +

ofz: stack-overflow with infinite parse recursion

Change-Id: I4973875797446e146cbda6db84958c9e4962aa8b
Reviewed-on: https://gerrit.libreoffice.org/35545
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx 
b/svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx
index 45f1d786f3d3..fbded8d9e32b 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx
@@ -178,17 +178,24 @@ class EquationExpression : public ExpressionNode
 {
 sal_Int32   mnIndex;
 const EnhancedCustomShape2d&mrCustoShape;
+mutable boolmbGettingValueGuard;
 
 public:
 
 EquationExpression( const EnhancedCustomShape2d& rCustoShape, sal_Int32 
nIndex )
 : mnIndex   ( nIndex )
 , mrCustoShape( rCustoShape )
+, mbGettingValueGuard(false)
 {
 }
 virtual double operator()() const override
 {
-return mrCustoShape.GetEquationValueAsDouble( mnIndex );
+if (mbGettingValueGuard)
+throw ParseError("Loop in Expression");
+mbGettingValueGuard = true;
+double fRet = mrCustoShape.GetEquationValueAsDouble(mnIndex);
+mbGettingValueGuard = false;
+return fRet;
 }
 virtual bool isConstant() const override
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #30 from Katarina Behrens (CIB)  ---

> Conclusion 2: it is a problem that the Macro editor silently refuses to
> edit, rather than giving some positive indication that editing is not
> permitted. It could have the UI say "Read-only". It could put up an error
> alert. It could have a different background colour.

This is a long-standing issue -- if the macro is read-only, there's no
indication whatsoever (e.g. this yellow-ish "This document is read-only" info
bar normal documents have) that this is the case. I'm sure it is already filed
somewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106710] Access2base Are you missing parentheses?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106710

jorojma...@gmail.com changed:

   What|Removed |Added

Summary|38/5000 Access2base Are you |Access2base Are you missing
   |missing parentheses?|parentheses?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106549] Libreoffice 5.3.1 basic no start access2base (error property)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106549

--- Comment #3 from jorojma...@gmail.com ---
Created attachment 132084
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132084=edit
Activating API access2base

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-0' - loolwsd.spec.in

[Andras Timar]

 loolwsd.spec.in |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d791ee053c146d0a60f75b57e294c9a122729366
Author: Andras Timar 
Date:   Mon Mar 20 19:32:28 2017 +0100

Poco was updated in SUSE repos

Change-Id: I6406adf979e82ab9d5a907ae31cadff458cc67f3
(cherry picked from commit a3bb506c9d42126ffcddb97df5c03f02f27944a3)

diff --git a/loolwsd.spec.in b/loolwsd.spec.in
index 0853c6f3..c0e0dee1 100644
--- a/loolwsd.spec.in
+++ b/loolwsd.spec.in
@@ -41,7 +41,7 @@ Requires:   atk avahi-glib avahi-libs bzip2-libs cairo 
cups-libs dbus-glib d
 # loolwsd dependencies
 Requires(post): libcap-progs
 Requires:   libcap2 libopenssl1_0_0 libpng12-0 libpcre1 libz1 
%{?systemd_requires} %{fillup_prereq}
-Requires:   libPocoCrypto45 >= 1.7.5 libPocoFoundation45 >= 1.7.5 
libPocoJSON45 >= 1.7.5 libPocoNet45 >= 1.7.5 libPocoNetSSL45 >= 1.7.5 
libPocoUtil45 >= 1.7.5 libPocoXML45 >= 1.7.5
+Requires:   libPocoCrypto48 >= 1.7.8 libPocoFoundation48 >= 1.7.8 
libPocoJSON48 >= 1.7.8 libPocoNet48 >= 1.7.8 libPocoNetSSL48 >= 1.7.8 
libPocoUtil48 >= 1.7.8 libPocoXML48 >= 1.7.8
 # Collabora Office dependencies (unfortunately Collabora Office RPM packages 
does not have real dependencies)
 Requires:   Mesa-libEGL1 Mesa-libGL1 Mesa-libglapi0 cups-libs dbus-1-glib 
fontconfig libatk-1_0-0 libavahi-client3 libavahi-common3 libavahi-glib1 
libbz2-1 libcairo2 libcom_err2 libdbus-1-3 libdrm2 libexpat1 libfreetype6 
libgbm1 libgio-2_0-0 libglib-2_0-0 libgmodule-2_0-0 libgobject-2_0-0 
libgraphite2-3 libgthread-2_0-0 libgtk-2_0-0 libharfbuzz0 libkeyutils1 liblzma5 
libpixman-1-0 libpng16-16 libuuid1 libxml2 libffi4 libgbm1 libICE6 libselinux1 
libSM6 libwayland-client0 libwayland-server0 libX11-6 libX11-xcb1 libXau6 
libxcb1 libxcb-dri2-0 libxcb-dri3-0 libxcb-glx0 libxcb-present0 libxcb-render0 
libxcb-shm0 libxcb-sync1 libxcb-xfixes0 libXdamage1 libXext6 libXfixes3 
libXrender1 libxshmfence1 libXxf86vm1
 %endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 50421] UI: "Check for Updates" menu leads to an unusable dialog ( shows "%PERCENT%")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=50421

--- Comment #50 from Christian Schroeder  ---
It was suggested to me that I delete my LO profile the next time I installed an
update. The last time I installed an update --- I don't remember between which
versions --- I uninstalled the old version AND deleted my profile. I then
installed the newer LO version, and I haven't seen this bug since. It may well
be that this bug is solved but that it persists for some users through some
quirk in the profile. I wonder also if it isn't a problem that exists as a
result of another bug, but that the correlation hasn't been definitively
established. If the latter is the case, then if the root problem is fixed, one
will never know definitively that the offshoot is fixed, too. 

These are just my thoughts. I agree that it is unsatisfying that this bug
should continue to rear its head, regardless of cause.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106712] New: missing possibilities in FORMAT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106712

Bug ID: 106712
   Summary: missing possibilities in FORMAT
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: aslt126...@gmail.com

Description:
missing possibilities in FORMAT > TEXT > modifier la casse : mising miniscules
& MAJUSCULES
only 3 possibilities : casse de tete - chaque mot - basculer.

Actual Results:  
FORMAT > TEXT > modifier la casse

Expected Results:
nothing : missing possibilities


Reproducible: Always

User Profile Reset: No

Additional Info:
[Information automatically included from LibreOffice]
Locale: fr
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no
Builds ID: LibreOffice 5.2.6.2


User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:52.0) Gecko/20100101 Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106711] New: Can you add "Optimize Scanned PDF" features to LibreOffice Draw?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106711

Bug ID: 106711
   Summary: Can you add "Optimize Scanned PDF" features to
LibreOffice Draw?
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yousifjka...@yahoo.com

Adobe acrobat pro has functions to optimize scanned PDF:

- deskew
- descreen
- remove background
- enhance clarity of text

& each of these could be switched ON or OFF & some of them have grades in
efficacy (medium, sever)

Is there a chance to implement such functions in LibreOffice Draw ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106710] 38/5000 Access2base Are you missing parentheses?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106710

jorojma...@gmail.com changed:

   What|Removed |Added

   Hardware|All |x86 (IA32)
 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106710] New: 38/5000 Access2base Are you missing parentheses?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106710

Bug ID: 106710
   Summary: 38/5000 Access2base Are you missing parentheses?
   Product: LibreOffice
   Version: 5.3.2.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jorojma...@gmail.com

Created attachment 132083
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132083=edit
Indicates where the parentheses are missing

API Access2base 
Are you missing parentheses?  

Attached file with images

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: pipe accept problem

[Chris Sherlock]

Hello Shoaib,

Can you redirect the output to a file and give us a link to pastebin with the 
output?

From what I can see, you are using Windows - could you also tell us what 
version you are running there?

Chris

Sent from my iPhone

> On 20 Mar 2017, at 6:35 am, shoaibnoor95  wrote:
> 
>  
> Can anyone tell me how to overcome from this error 
> Best Regards:
> Shoaib
> 
> 
> 
> --
> View this message in context: 
> http://nabble.documentfoundation.org/pipe-accept-problem-tp4210569.html
> Sent from the Dev mailing list archive at Nabble.com.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: oox/source

[Caolán McNamara]

 oox/source/ole/olehelper.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit a271321ab7d66eab007f998237e7fb09dd5c9bf7
Author: Caolán McNamara 
Date:   Wed Mar 22 21:14:55 2017 +

crashtesting: these should be opened readonly

Change-Id: I99f6e06955d05688aba95a6f1246078b3ecd7772

diff --git a/oox/source/ole/olehelper.cxx b/oox/source/ole/olehelper.cxx
index b32e69620283..cfc7966eb892 100644
--- a/oox/source/ole/olehelper.cxx
+++ b/oox/source/ole/olehelper.cxx
@@ -518,13 +518,13 @@ bool MSConvertOCXControls::ReadOCXStorage( 
tools::SvRef& xOleStg,
 {
 if ( xOleStg.is() )
 {
-tools::SvRef pNameStream = xOleStg->OpenSotStream( 
"\3OCXNAME");
+tools::SvRef pNameStream = 
xOleStg->OpenSotStream("\3OCXNAME", StreamMode::READ);
 BinaryXInputStream aNameStream( Reference< XInputStream >( new 
utl::OSeekableInputStreamWrapper( *pNameStream ) ), true );
 
-tools::SvRef pContents = xOleStg->OpenSotStream( 
"contents");
+tools::SvRef pContents = 
xOleStg->OpenSotStream("contents", StreamMode::READ);
 BinaryXInputStream aInStrm(  Reference< XInputStream >( new 
utl::OSeekableInputStreamWrapper( *pContents ) ), true );
 
-tools::SvRef pClsStrm = 
xOleStg->OpenSotStream("\1CompObj");
+tools::SvRef pClsStrm = 
xOleStg->OpenSotStream("\1CompObj", StreamMode::READ);
 BinaryXInputStream aClsStrm( Reference< XInputStream >( new 
utl::OSeekableInputStreamWrapper(*pClsStrm ) ), true );
 aClsStrm.skip(12);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106709] New: Please add ability to add/delete/edit/ manage outline of PDF.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106709

Bug ID: 106709
   Summary: Please add ability to add/delete/edit/manage outline
of PDF.
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yousifjka...@yahoo.com

Currently LibreOffice Draw has no such abilities. Please can you add these
abilities?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: help need to add path

[Chris Sherlock]

Can you pastebin the build log? Funny error to be getting...

What user are you running the build as? Have you setup permissions in a 
particular way for that user?

Chris

Sent from my iPhone

> On 18 Mar 2017, at 10:33 pm, Shoaib Noor  wrote:
> 
> I am building libre office but the build gets failed due to this error kindly 
> help me 
> regards
> Shoaib
> 
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Calc unit tests

[Markus Mohrhard]

Hey Winfried,

On Wed, Mar 22, 2017 at 2:02 PM, Winfried Donkers <
w.donk...@dci-electronics.nl> wrote:

> Hi Markus,
>
>
>
> I'm working on fixes for Calc functions (LEGACY.)CHITEST and CHISQ.TEST
> that came forward when Raal compared results between Calc and Excel.
>
> When compiling my changes I came across unit test functions in
> sc/qa/unit/ucalc_formula.cxx, as these failed because of my changes. They
> tested the current behaviour, not the ODFF1.2 specs.
>
> I wonder if you have ideas about these tests now Raal has made test
> documents for almost all Calc functions? Can they be deleted, at least the
> CHITEST-test function, or do you intend to keep both unit tests (in which
> case I shall fix that test too)?
>

We still plan to have some tests in ucalc_formula.cxx. They have the
advantage of being more precise (they point directly to a failing
statement) and are much faster to execute. However such a test should only
be added in case of a fixed bug or a problem that is not easily covered in
the formula tests.

It is not unexpected that some of them are written against the
implementation instead of the specification. The best solution is to adapt
them while fixing the implementation. Actually I would consider them doing
there job if they start to fail when you update the implementation. While a
failing unit test normally means something broke you always need to
evaluate the failure and assess whether it might not be an expected failure
based on the new implementation.

So for now I suppose the best way forward is to just adapt the existing
tests to conform to your improved implementation.

Regards,
Markus


>
>
> Winfried
>
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 106708] New: LibreOffice Draw has no eraser to erase original contents of PDF ! Please add eraser !

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106708

Bug ID: 106708
   Summary: LibreOffice Draw has no eraser to erase original
contents of PDF ! Please add eraser !
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yousifjka...@yahoo.com

Hi. Currently LibreOffice Draw has no eraser enable user to erase original
contents of PDF, like - but not limited to - scanned PDF.

Please can you add this important feature? 

It is very important that use of such eraser should not result in increase size
of PDF or lower down resolution of PDF at saving (exportation).

Eraser should be available in 2 shaps: circular & square.

Also, it should leave no trace for the erased content (so called "secure
reduction").

Best.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106707] Misalignment Problem in English Power Point if set LibreOffice at Arabic language

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106707

--- Comment #1 from yousifjka...@yahoo.com ---
Created attachment 132082
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132082=edit
example

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106707] New: Misalignment Problem in English Power Point if set LibreOffice at Arabic language

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106707

Bug ID: 106707
   Summary: Misalignment Problem in English Power Point if set
LibreOffice at Arabic language
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yousifjka...@yahoo.com

Hi. I'm on Fedora Linux 24 X64 Cinnamon edition. I used LibreOffice to create
power point document in English language. I set it's contents on left to right
alignment. Problem is that just closing power point then re-opening it, it's
alignment will changed automatically into right to left !! What ever I tried to
realign it's content with left to right, it will return right to left just
after closing document (after saving changes) & reopening it !! I have to
realign it with left to right each time I open it !!


I set LibreOffice language as following:

- Arabic UI
- UAE default locale
- Right to left is default document direction (BUT I ALREADY CHANGED IT TO LEFT
TO RIGHT JUST BEFORE ENTERING POWER POINT CONTENTS though I did not change
default setting)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106698] Certain buttons only appear/disabled in active window' s sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106698

Maxim Monastirsky  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 CC||momonas...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Maxim Monastirsky  ---
Some more observation:

- In Writer, if the cursor is in a text box or a table, there will be changes
in the paragraph sidebar panel. (This one can be reproduced with 4.2.0.4 too.)

- In Calc, if the cursor is in a text box, the Style sidebar panel will appear.

- In Writer with notebookbar enabled, if the cursor is in a table, the
notebookbar will turn blank.

All this stops after commenting the ContextChangeBroadcaster::Deactivate method
[1]. Obviously the various sidebar/notebookbar panels were not prepared to
handle this vcl::EnumContext::Context::Default notification. IMHO the
usefulness of considering a "window lose focus" event as an application context
change is questionable, as well as the vcl::EnumContext::Context::Default
purpose in a whole.

[1]
http://opengrok.libreoffice.org/xref/core/sfx2/source/sidebar/ContextChangeBroadcaster.cxx#54

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - include/vcl vcl/inc vcl/source vcl/unx

[Maxim Monastirsky]

 include/vcl/menu.hxx   |1 
 vcl/inc/salmenu.hxx|2 -
 vcl/inc/unx/gtk/gtksalmenu.hxx |1 
 vcl/source/window/menu.cxx |   14 +++---
 vcl/unx/gtk/gtksalframe.cxx|1 
 vcl/unx/gtk/gtksalmenu.cxx |   57 +++--
 vcl/unx/gtk3/gtk3gtkframe.cxx  |1 
 7 files changed, 58 insertions(+), 19 deletions(-)

New commits:
commit 13714d994471a5d53b673d97e4fcf56b5dc3d057
Author: Maxim Monastirsky 
Date:   Tue Aug 30 21:38:37 2016 +0300

Implement disabling of Menubar under Unity

This is a combination of 5 commits:

* gtk3: Implement menubar hiding

* tdf#106271 Cannot disable Menubar under Unity

* Destroy menu widget when enabling Unity integration

* Don't use SetDisplayable when enabling Unity mode

* Keep menubar hidden after Unity registrar activated

Change-Id: I3c5e17100622cd8d22c4348cf90a76233dd0fd4c
Reviewed-on: https://gerrit.libreoffice.org/35206
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/include/vcl/menu.hxx b/include/vcl/menu.hxx
index 92d4b4e30bff..8c1b94788791 100644
--- a/include/vcl/menu.hxx
+++ b/include/vcl/menu.hxx
@@ -483,6 +483,7 @@ public:
 // if the menubar is unattached an empty rectangle is returned
 Rectangle GetMenuBarButtonRectPixel( sal_uInt16 nId );
 void RemoveMenuBarButton( sal_uInt16 nId );
+void LayoutChanged();
 };
 
 inline MenuBar& MenuBar::operator=( const MenuBar& rMenu )
diff --git a/vcl/inc/salmenu.hxx b/vcl/inc/salmenu.hxx
index a792356ab92e..3c23fc022b73 100644
--- a/vcl/inc/salmenu.hxx
+++ b/vcl/inc/salmenu.hxx
@@ -63,7 +63,7 @@ public:
 
 virtual bool VisibleMenuBar() = 0;  // must return true to actually 
DISPLAY native menu bars
 // otherwise only menu messages 
are processed (eg, OLE on Windows)
-
+virtual void ShowMenuBar( bool ) {}
 virtual void InsertItem( SalMenuItem* pSalMenuItem, unsigned nPos ) = 0;
 virtual void RemoveItem( unsigned nPos ) = 0;
 virtual void SetSubMenu( SalMenuItem* pSalMenuItem, SalMenu* pSubMenu, 
unsigned nPos ) = 0;
diff --git a/vcl/inc/unx/gtk/gtksalmenu.hxx b/vcl/inc/unx/gtk/gtksalmenu.hxx
index 08b4113cd5a7..6c417c3736dd 100644
--- a/vcl/inc/unx/gtk/gtksalmenu.hxx
+++ b/vcl/inc/unx/gtk/gtksalmenu.hxx
@@ -110,6 +110,7 @@ public:
 static void Activate(const gchar* pMenuCommand);
 static void Deactivate(const gchar* pMenuCommand);
 voidEnableUnity(bool bEnable);
+virtual voidShowMenuBar( bool bVisible ) override;
 boolPrepUpdate();
 virtual voidUpdate() override;  // Update this menu only.
 // Update full menu hierarchy from this menu.
diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index d7f6b0875fff..24743fb2723a 100644
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -2481,14 +2481,22 @@ void MenuBar::ShowButtons( bool bClose, bool bFloat, 
bool bHide )
 }
 }
 
+void MenuBar::LayoutChanged()
+{
+MenuBarWindow* pMenuWin = getMenuBarWindow();
+if (pMenuWin)
+pMenuWin->LayoutChanged();
+}
+
 void MenuBar::SetDisplayable( bool bDisplayable )
 {
 if( bDisplayable != mbDisplayable )
 {
+if ( ImplGetSalMenu() )
+ImplGetSalMenu()->ShowMenuBar( bDisplayable );
+
 mbDisplayable = bDisplayable;
-MenuBarWindow* pMenuWin = getMenuBarWindow();
-if (pMenuWin)
-pMenuWin->LayoutChanged();
+LayoutChanged();
 }
 }
 
diff --git a/vcl/unx/gtk/gtksalframe.cxx b/vcl/unx/gtk/gtksalframe.cxx
index 9fd351825da8..b56c899ed431 100644
--- a/vcl/unx/gtk/gtksalframe.cxx
+++ b/vcl/unx/gtk/gtksalframe.cxx
@@ -705,7 +705,6 @@ void on_registrar_available( GDBusConnection * 
/*connection*/,
 {
 GtkSalMenu* pGtkSalMenu = static_cast(pSalMenu);
 pGtkSalMenu->EnableUnity(true);
-pGtkSalMenu->UpdateFull();
 }
 }
 
diff --git a/vcl/unx/gtk/gtksalmenu.cxx b/vcl/unx/gtk/gtksalmenu.cxx
index 75cab1cab1cd..3aee9dd796a3 100644
--- a/vcl/unx/gtk/gtksalmenu.cxx
+++ b/vcl/unx/gtk/gtksalmenu.cxx
@@ -484,11 +484,7 @@ GtkSalMenu::~GtkSalMenu()
 
 bool GtkSalMenu::VisibleMenuBar()
 {
-#if GTK_CHECK_VERSION(3,0,0)
-return mbMenuBar;
-#else
-return mbMenuBar && bUnityMode;
-#endif
+return mbMenuBar && (bUnityMode || mpMenuBarContainerWidget);
 }
 
 void GtkSalMenu::InsertItem( SalMenuItem* pSalMenuItem, unsigned nPos )
@@ -539,7 +535,9 @@ void GtkSalMenu::ShowCloseButton(bool bShow)
 {
 #if GTK_CHECK_VERSION(3,0,0)
 assert(mbMenuBar);
-MenuBar *pVclMenuBar = static_cast(mpVCLMenu);
+if (!mpMenuBarContainerWidget)
+return;
+
 if (!bShow)
 {
 if (mpCloseButton)
@@ -547,6 +545,7 @@ void 

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #29 from Jim DeLaHunt  ---
OK, I've done a careful check. I think JBF may have been correct. However, I
think this may be a different Extensions Manager bug.

Procedure 1:
Install Typography toolbar extension, for All Users
Restart Libreoffice
Create new Writer document with "text123679"
Change text to Linux Libertine G font.
View... Toolbars... Typography... Make toolbar visible in window.
Select text.
Click "Oldstyle figures" button in Typography toolbar.
BASIC Syntax error occurs.
My Macros & Dialogs.typo appears.
"typo" is listed under "My Macro & Dialogs" not under "LibreOffice Macros &
Dialogs"
Line of sub prg, with syntax error, indicated by orange arrow.
Result 1: Not able to edit the contents of the macro.

Procedure 2:
Install Typography toolbar extension, click button "Only for me"
Then same as Procedure 1.
Result 1: Yes, able to edit the contents of the macro.

Test system:
LibreOffice 5.3.1.2, Mac OS X El Capitan 10.11.6, Typography toolbar extension
1.1.

Conclusion 1: Jean-Baptiste Faure (from comment #24) is correct, the Macro
Editor does not permit editing macros installed for All Users. My problem
editing is not evidence of a connection to the syntax error or the macro editor
state after a syntax error.

Conclusion 2: it is a problem that the Macro editor silently refuses to edit,
rather than giving some positive indication that editing is not permitted. It
could have the UI say "Read-only". It could put up an error alert. It could
have a different background colour.

Conclusion 3: it is strange to me that the typo macro, when installed for "All
Users", appears under "My Macros & Dialogs". I would expect it to appear under
"LibreOffice Macros & Dialogs".

I will look into filing Conclusions 2 and 3 as an Extensions Manager or Macro
Editor bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106649] Android: change icons from material to breeze SVG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106649

rishu_ku...@live.com changed:

   What|Removed |Added

   Assignee|rishu_ku...@live.com|libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106649] Android: change icons from material to breeze SVG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106649

rishu_ku...@live.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rishu_ku...@live.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/source

[Caolán McNamara]

 sd/source/filter/ppt/pptin.cxx |   12 ++--
 1 file changed, 10 insertions(+), 2 deletions(-)

New commits:
commit be630d7bd9298c1447983af99959aa7de2d6e2a1
Author: Caolán McNamara 
Date:   Wed Mar 22 17:23:14 2017 +

catch structured storage exceptions during testing

Change-Id: Ibce297f85ebcf5ebde1a9e81afef9b0c41ebeb1a

diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx
index 4e3ca127c265..3b2589384909 100644
--- a/sd/source/filter/ppt/pptin.cxx
+++ b/sd/source/filter/ppt/pptin.cxx
@@ -2759,9 +2759,17 @@ extern "C" SAL_DLLPUBLIC_EXPORT sal_Bool SAL_CALL 
ImportPPT(
 
 extern "C" SAL_DLLPUBLIC_EXPORT bool SAL_CALL TestImportPPT(SvStream )
 {
-tools::SvRef xStorage(new SotStorage(rStream));
-if (xStorage->GetError())
+tools::SvRef xStorage;
+try
+{
+xStorage = tools::SvRef(new SotStorage(rStream));
+if (xStorage->GetError())
+return false;
+}
+catch (...)
+{
 return false;
+}
 
 tools::SvRef xDocStream(xStorage->OpenSotStream( 
"PowerPoint Document", StreamMode::STD_READ));
 if ( !xDocStream.is() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: idlc/source

[Stephan Bergmann]

 idlc/source/scanner.l |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit cb2a1cb37035a634a3e30bd81480ca311bf11eba
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:59:42 2017 +0100

Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)

Change-Id: I9d3cf6363e1caf66a9d4cc3a1560c93e17038c2d

diff --git a/idlc/source/scanner.l b/idlc/source/scanner.l
index f1484bc0bab9..d455c14cbaf5 100644
--- a/idlc/source/scanner.l
+++ b/idlc/source/scanner.l
@@ -29,6 +29,8 @@
 #include 
 #include 
 
+#include 
+
 #include 
 #include 
 #include 
@@ -212,7 +214,7 @@ static void parseLineAndFile(sal_Char* pBuf)
return;
 
/* Find line number */
-   for (r++; *r == ' ' || *r == '\t' || isalpha(*r); r++) ;
+   for (r++; *r == ' ' || *r == '\t' || 
rtl::isAsciiAlpha(static_cast(*r)); r++) ;
h = r;
for (; *r != '\0' && *r != ' ' && *r != '\t'; r++) ;
*r++ = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: soltools/cpp soltools/mkdepend

[Stephan Bergmann]

 soltools/cpp/_unix.c |2 +-
 soltools/mkdepend/cppsetup.c |2 +-
 soltools/mkdepend/ifparser.c |   14 +++---
 soltools/mkdepend/parse.c|4 ++--
 4 files changed, 11 insertions(+), 11 deletions(-)

New commits:
commit 97a6bf07012f5a55d16f28c3bb3d039a09f8d700
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:58:37 2017 +0100

Fix passing plain char into ctype.h is* functions

Change-Id: I4de56462e1fe5bba3035fec691feda91be88b434

diff --git a/soltools/cpp/_unix.c b/soltools/cpp/_unix.c
index 1010e3084eb6..274ee5acaf3a 100644
--- a/soltools/cpp/_unix.c
+++ b/soltools/cpp/_unix.c
@@ -149,7 +149,7 @@ void
 case 'w':
 dp = [n + 1];
 n += (int)strlen(dp);
-while (isspace(*dp)) dp++;
+while (isspace((unsigned char)*dp)) dp++;
 
 for (i = NINCLUDE - 1; i >= 0; i--)
 {
diff --git a/soltools/mkdepend/cppsetup.c b/soltools/mkdepend/cppsetup.c
index 708e75dc099e..750142af9ddf 100644
--- a/soltools/mkdepend/cppsetup.c
+++ b/soltools/mkdepend/cppsetup.c
@@ -174,7 +174,7 @@ my_eval_defined (IfParser *ip, const char *var, size_t len)
 return 0;
 }
 
-#define isvarfirstletter(ccc) (isalpha(ccc) || (ccc) == '_')
+#define isvarfirstletter(ccc) (isalpha((unsigned char)(ccc)) || (ccc) == '_')
 
 static int
 my_eval_variable (IfParser *ip, const char *var, size_t len)
diff --git a/soltools/mkdepend/ifparser.c b/soltools/mkdepend/ifparser.c
index 274a72a7fce8..8777e795f18e 100644
--- a/soltools/mkdepend/ifparser.c
+++ b/soltools/mkdepend/ifparser.c
@@ -69,8 +69,8 @@
 
 #define DO(val) if (!(val)) return NULL
 #define CALLFUNC(ggg,fff) (*((ggg)->funcs.fff))
-#define SKIPSPACE(ccc) while (isspace(*ccc)) ccc++
-#define isvarfirstletter(ccc) (isalpha(ccc) || (ccc) == '_')
+#define SKIPSPACE(ccc) while (isspace((unsigned char)*ccc)) ccc++
+#define isvarfirstletter(ccc) (isalpha((unsigned char)(ccc)) || (ccc) == '_')
 
 
 static const char *
@@ -83,7 +83,7 @@ parse_variable (IfParser *g, const char *cp, const char 
**varp)
 
 *varp = cp;
 /* EMPTY */
-for (cp++; isalnum(*cp) || *cp == '_'; cp++) ;
+for (cp++; isalnum((unsigned char)*cp) || *cp == '_'; cp++) ;
 return cp;
 }
 
@@ -93,7 +93,7 @@ parse_number (IfParser *g, const char *cp, int *valp)
 {
 SKIPSPACE (cp);
 
-if (!isdigit(*cp))
+if (!isdigit((unsigned char)*cp))
 return CALLFUNC(g, handle_error) (g, cp, "number");
 
 #ifdef _WIN32
@@ -104,7 +104,7 @@ parse_number (IfParser *g, const char *cp, int *valp)
 #else
 *valp = atoi (cp);
 /* EMPTY */
-for (cp++; isdigit(*cp); cp++) ;
+for (cp++; isdigit((unsigned char)*cp); cp++) ;
 #endif
 return cp;
 }
@@ -155,7 +155,7 @@ parse_value (IfParser *g, const char *cp, int *valp)
 return cp + 1;
 
   case 'd':
-if (strncmp (cp, "defined", 7) == 0 && !isalnum(cp[7])) {
+if (strncmp (cp, "defined", 7) == 0 && !isalnum((unsigned char)cp[7])) 
{
 int paren = 0;
 size_t len;
 
@@ -176,7 +176,7 @@ parse_value (IfParser *g, const char *cp, int *valp)
 /* fall out */
 }
 
-if (isdigit(*cp)) {
+if (isdigit((unsigned char)*cp)) {
   DO (cp = parse_number (g, cp, valp));
 } else if (!isvarfirstletter(*cp))
   return CALLFUNC(g, handle_error) (g, cp, "variable or number");
diff --git a/soltools/mkdepend/parse.c b/soltools/mkdepend/parse.c
index 250a6a66a702..41ae113e9ff0 100644
--- a/soltools/mkdepend/parse.c
+++ b/soltools/mkdepend/parse.c
@@ -293,7 +293,7 @@ int deftype (char *line, struct filepointer *filep, struct 
inclist *file_red, st
 /*
  * separate the name of a single symbol.
  */
-while (isalnum(*p) || *p == '_')
+while (isalnum((unsigned char)*p) || *p == '_')
 *line++ = *p++;
 *line = '\0';
 break;
@@ -385,7 +385,7 @@ void define( char *def, struct symhash **symbols )
 
 /* Separate symbol name and its value */
 val = def;
-while (isalnum(*val) || *val == '_')
+while (isalnum((unsigned char)*val) || *val == '_')
 val++;
 if (*val)
 *val++ = '\0';
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: solenv/bin

[Stephan Bergmann]

 solenv/bin/concat-deps.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit cea11039b29cffa0c8045ead30ddfc4859595c7e
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:56:57 2017 +0100

Fix passing plain char into ctype.h is* functions

Change-Id: I3d1fd585ba7f0bd8f6d074f0d2b86a20fa366072

diff --git a/solenv/bin/concat-deps.c b/solenv/bin/concat-deps.c
index 14425441cd6d..32e4f10ee4e0 100644
--- a/solenv/bin/concat-deps.c
+++ b/solenv/bin/concat-deps.c
@@ -795,7 +795,8 @@ static inline void print_fullpaths(char* line)
 end = token;
 /* hard to believe that in this day and age drive letters still exist 
*/
 if (*end && (':' == *(end+1)) &&
-(('\\' == *(end+2)) || ('/' == *(end+2))) && isalpha(*end))
+(('\\' == *(end+2)) || ('/' == *(end+2))) &&
+isalpha((unsigned char)*end))
 {
 end = end + 3; /* only one cross, err drive letter per filename */
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: rsc/source

[Stephan Bergmann]

 rsc/source/rscpp/cpp2.c |2 +-
 rsc/source/rscpp/cpp3.c |8 
 2 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit cb643b44ca9469b9bbea97c5c0c0c911fc8ba058
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:55:48 2017 +0100

Fix passing plain char into ctype.h is* functions

Change-Id: Ifa1098a12a9d3d28a4d272ac8f4ab72d9a92282b

diff --git a/rsc/source/rscpp/cpp2.c b/rsc/source/rscpp/cpp2.c
index 2cbc90d9d439..e55dc384018f 100644
--- a/rsc/source/rscpp/cpp2.c
+++ b/rsc/source/rscpp/cpp2.c
@@ -166,7 +166,7 @@ int control(int counter)
  * We subtract 1 as we want the number of the next line.
  */
 line = atoi(work) - 1;  /* Reset line number*/
-for (tp = work; isdigit(*tp) || type[(int)*tp] == SPA; tp++)
+for (tp = work; isdigit((unsigned char)*tp) || type[(int)*tp] == SPA; 
tp++)
 ;   /* Skip over digits */
 if (*tp != EOS) /* Got a filename, so:  */
 {
diff --git a/rsc/source/rscpp/cpp3.c b/rsc/source/rscpp/cpp3.c
index bd2e2cc262d2..078be477d815 100644
--- a/rsc/source/rscpp/cpp3.c
+++ b/rsc/source/rscpp/cpp3.c
@@ -174,7 +174,7 @@ int dooptions(int argc, char** argv)
 else
 {
 c = *ap++;  /* Option byte  */
-if (islower(c)) /* Normalize case   */
+if (islower((unsigned char)c)) /* Normalize case   
*/
 c = toupper(c);
 switch (c)  /* Command character*/
 {
@@ -224,13 +224,13 @@ int dooptions(int argc, char** argv)
 }
 while (sizp->bits != endtest && *ap != EOS)
 {
-if (!isdigit(*ap))  /* Skip to next digit   */
+if (!isdigit((unsigned char)*ap))  /* Skip to next 
digit   */
 {
 ap++;
 continue;
 }
 size = 0;   /* Compile the value*/
-while (isdigit(*ap))
+while (isdigit((unsigned char)*ap))
 {
 size *= 10;
 size += (*ap++ - '0');
@@ -254,7 +254,7 @@ int dooptions(int argc, char** argv)
 
 #if OSL_DEBUG_LEVEL > 1
 case 'X':   /* Debug*/
-debug = (isdigit(*ap)) ? atoi(ap) : 1;
+debug = (isdigit((unsigned char)*ap)) ? atoi(ap) : 1;
 #if (HOST == SYS_UNIX)
 signal(SIGINT, (void (*)(int)) abort); /* Trap "interrupt" */
 #endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: rsc/source

[Stephan Bergmann]

 rsc/source/parser/rsclex.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 971be75c58889b03bf69b31d3721081c39d53a35
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:53:07 2017 +0100

Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)

(was inadvertently missing from previous commit)

Change-Id: Ia047ff8c21a50c5afe6fb2e6ff885be725b55bd3

diff --git a/rsc/source/parser/rsclex.cxx b/rsc/source/parser/rsclex.cxx
index cbe2f0eded4d..e03aa09444d5 100644
--- a/rsc/source/parser/rsclex.cxx
+++ b/rsc/source/parser/rsclex.cxx
@@ -223,7 +223,8 @@ int MakeToken( YYSTYPE * pTokenVal )
 AtomnHashId;
 OStringBuffer aBuf( 256 );
 
-while( isalnum (c) || (c == '_') || (c == '-') || (c == ':'))
+while( rtl::isAsciiAlphanumeric (static_cast(c))
+   || (c == '_') || (c == '-') || (c == ':'))
 {
 aBuf.append( sal_Char(c) );
 c = pFI->GetFastChar();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104244] EDITING: current cell not indicated in Calc (Ubuntu)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104244

--- Comment #16 from Hamid  ---
Relax. Biz as usual not here no more. Real problems real attitude. Else there
are plenty out there called normals. But don't get this post wrong. Apologies,
that was my two cents, thought it might help a free soul. Stay bright, abiding.
Bugs will go!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: connectivity/source

[Stephan Bergmann]

 connectivity/source/commontools/CommonTools.cxx  |5 +++--
 connectivity/source/commontools/dbconversion.cxx |3 ++-
 2 files changed, 5 insertions(+), 3 deletions(-)

New commits:
commit a6eecdbc6e8277386f8bc8a4e970332acf780981
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:45:12 2017 +0100

Use rtl::isAscii* instead of ctype.h is* with sal_Unicode arg

Change-Id: I5e82b7f96c28ae89642bde603b941573820891c5

diff --git a/connectivity/source/commontools/CommonTools.cxx 
b/connectivity/source/commontools/CommonTools.cxx
index 30f8538ca906..9846d0fbc56e 100644
--- a/connectivity/source/commontools/CommonTools.cxx
+++ b/connectivity/source/commontools/CommonTools.cxx
@@ -34,6 +34,7 @@
 #if HAVE_FEATURE_JAVA
 #include 
 #endif
+#include 
 #include 
 #include 
 
@@ -183,7 +184,7 @@ bool isValidSQLName(const OUString& rName,const OUString& 
_rSpecials)
 // Test for correct naming (in SQL sense)
 // This is important for table names for example
 const sal_Unicode* pStr = rName.getStr();
-if (*pStr > 127 || isdigit(*pStr))
+if (*pStr > 127 || rtl::isAsciiDigit(*pStr))
 return false;
 
 for (; *pStr; ++pStr )
@@ -214,7 +215,7 @@ OUString convertName2SQLName(const OUString& rName,const 
OUString& _rSpecials)
 OUString aNewName(rName);
 const sal_Unicode* pStr = rName.getStr();
 sal_Int32 nLength = rName.getLength();
-bool bValid(*pStr < 128 && !isdigit(*pStr));
+bool bValid(*pStr < 128 && !rtl::isAsciiDigit(*pStr));
 for (sal_Int32 i=0; bValid && i < nLength; ++pStr,++i )
 if(!isCharOk(*pStr,_rSpecials))
 {
diff --git a/connectivity/source/commontools/dbconversion.cxx 
b/connectivity/source/commontools/dbconversion.cxx
index 763eb6c8ba46..5be258a7e698 100644
--- a/connectivity/source/commontools/dbconversion.cxx
+++ b/connectivity/source/commontools/dbconversion.cxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -415,7 +416,7 @@ namespace dbtools
 {
 const sal_Unicode *p = _sSQLString.getStr() + nSeparation;
 const sal_Unicode *const begin = p;
-while (isspace(*p)) { ++p; }
+while (rtl::isAsciiWhiteSpace(*p)) { ++p; }
 nSeparation += p - begin;
 aTime = toTime( _sSQLString.copy( nSeparation ) );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - cui/source filter/source

[Stephan Bergmann]

 cui/source/dialogs/about.cxx  |3 +--
 filter/source/t602/t602filter.cxx |4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

New commits:
commit f512cf5b1bf9e80cb430c1f06fbb7d86feb19ca3
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:44:16 2017 +0100

Use rtl::isAscii* instead of ctype.h is* with sal_Unicode arg

Change-Id: Ifcc531df2b780e446dd4c2cccf74fa902ab4a259

diff --git a/cui/source/dialogs/about.cxx b/cui/source/dialogs/about.cxx
index d1c5986572d3..72a21d78c51c 100644
--- a/cui/source/dialogs/about.cxx
+++ b/cui/source/dialogs/about.cxx
@@ -49,7 +49,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #if HAVE_FEATURE_OPENCL
 #include 
@@ -297,7 +296,7 @@ bool AboutDialog::IsStringValidGitHash(const OUString& hash)
 {
 for (int i = 0; i < hash.getLength(); i++)
 {
-if (!std::isxdigit(hash[i]))
+if (!rtl::isAsciiHexDigit(hash[i]))
 {
 return false;
 }
commit dccbd373c9517a917c9d2be5d5abd6640948059a
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:43:43 2017 +0100

Use rtl::isAscii* instead of ctype.h is*

Change-Id: I3fc3db1cc2de49ebe5492fc7dae26b71aece3c6b

diff --git a/filter/source/t602/t602filter.cxx 
b/filter/source/t602/t602filter.cxx
index 03f8beddaf4f..20398237294d 100644
--- a/filter/source/t602/t602filter.cxx
+++ b/filter/source/t602/t602filter.cxx
@@ -678,7 +678,7 @@ tnode T602ImportFilter::PointCmd602(unsigned char *ch)
 *ch = Readchar602();
 if (!*ch) return tnode::EEND;
 if (*ch=='\n') return tnode::EOL;
-if (!isalpha(*ch)) return (*ch<32) ? tnode::SETCH : tnode::WRITE;
+if (!rtl::isAsciiAlpha(*ch)) return (*ch<32) ? tnode::SETCH : tnode::WRITE;
 
 // warning: uChar -> char
 pcmd[1] = (char) rtl::toAsciiUpperCase(*ch); inschr(*ch);
@@ -749,7 +749,7 @@ void T602ImportFilter::Read602()
 case tnode::POCMD: inschr('.');
 ch = Readchar602();
 if(ch == 0) node = tnode::EEND;
-else if(isalpha(ch)) node = PointCmd602();
+else if(rtl::isAsciiAlpha(ch)) node = PointCmd602();
 else if(ch <32) node=tnode::SETCH;
 else node = tnode::WRITE;
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: forms/source

[Stephan Bergmann]

 forms/source/component/DatabaseForm.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 93360085da04841fc7f48980acb37a26d6c5a174
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:42:31 2017 +0100

Use rtl::isAscii* instead of ctype.h is* with sal_Unicode arg

Change-Id: I2bc0cff65b1bacc041106406cd98c632eafeec51

diff --git a/forms/source/component/DatabaseForm.cxx 
b/forms/source/component/DatabaseForm.cxx
index 40707db7f974..a98e62422f0e 100644
--- a/forms/source/component/DatabaseForm.cxx
+++ b/forms/source/component/DatabaseForm.cxx
@@ -901,7 +901,8 @@ void ODatabaseForm::Encode( OUString& rString )
 nCharCode = rString[nCurPos];
 
 // Handle chars, which are not an alphanumeric character and character 
codes > 127
-if( (!isalnum(nCharCode) && nCharCode != ' ') || nCharCode > 127 )
+if( (!rtl::isAsciiAlphanumeric(nCharCode) && nCharCode != ' ')
+|| nCharCode > 127 )
 {
 switch( nCharCode )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Stephan Bergmann]

 sw/source/core/doc/doccomp.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 1df029d45f068180f3cb97027bb4f7a2ba4b2eec
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:33:43 2017 +0100

Use rtl::isAscii* instead of ctype.h is* with sal_Unicode arg

Change-Id: I18d600bf21573bbc47ffcd105afeb652fd74392b

diff --git a/sw/source/core/doc/doccomp.cxx b/sw/source/core/doc/doccomp.cxx
index a72486b53383..a5d12ff82288 100644
--- a/sw/source/core/doc/doccomp.cxx
+++ b/sw/source/core/doc/doccomp.cxx
@@ -2320,8 +2320,8 @@ void WordArrayComparator::CalcPositions( int *pPos, const 
SwTextNode *pTextNd,
 for (int i = 0; i <= pTextNd->GetText().getLength(); ++i)
 {
 if (i == 0 || i == pTextNd->GetText().getLength()
-|| !isalnum( pTextNd->GetText()[ i - 1 ])
-|| !isalnum( pTextNd->GetText()[ i ]))
+|| !rtl::isAsciiAlphanumeric( pTextNd->GetText()[ i - 1 ])
+|| !rtl::isAsciiAlphanumeric( pTextNd->GetText()[ i ]))
 { // Begin new word
 nCnt++;
 pPos[ nCnt ] = i;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcompiler/source

[Stephan Bergmann]

 helpcompiler/source/HelpLinker.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit e665ecfc32fc8be96d8b2318c881da288b007c52
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:41:44 2017 +0100

Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)

Change-Id: If8085dc00db196eb51b6f14b4f4bac7c37dab249

diff --git a/helpcompiler/source/HelpLinker.cxx 
b/helpcompiler/source/HelpLinker.cxx
index b06295fdf22c..285241ae18c4 100644
--- a/helpcompiler/source/HelpLinker.cxx
+++ b/helpcompiler/source/HelpLinker.cxx
@@ -212,9 +212,11 @@ namespace URLEncoder
 std::string result;
 for (char c : rIn)
 {
-if (isalnum (c) || strchr (good, c))
+if (rtl::isAsciiAlphanumeric (static_cast(c))
+|| strchr (good, c))
+{
 result += c;
-else {
+} else {
 result += '%';
 result += hex[static_cast(c) >> 4];
 result += hex[c & 0xf];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: jvmfwk/plugins

[Stephan Bergmann]

 jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx |   15 ++-
 1 file changed, 10 insertions(+), 5 deletions(-)

New commits:
commit 25ecb6f627852bc23ec8395ef24d8e90467d5758
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:40:55 2017 +0100

Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)

Change-Id: I18f9a2ad4506edc76b74dde229f2fd296bffed88

diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx
index b4ad7019d449..290faed43ab6 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx
@@ -23,6 +23,7 @@
 #include "osl/thread.h"
 #include "osl/process.h"
 #include "osl/security.hxx"
+#include 
 #include 
 #include 
 #include "diagnostics.h"
@@ -77,7 +78,7 @@ bool SunVersion::init(const char *szVersion)
 //char must me a number 0 - 999 and no leading
 while (true)
 {
-if (pCur < pEnd && isdigit(*pCur))
+if (pCur < pEnd && rtl::isAsciiDigit(static_cast(*pCur)))
 {
 if (pCur < pEnd)
 pCur ++;
@@ -94,7 +95,8 @@ bool SunVersion::init(const char *szVersion)
 (nPart < 2 && *pCur == '.') )
 && (
 //prevent 1.4.0. 1.4.0-
-pCur + 1 != pEnd || isdigit(*(pCur))) )
+pCur + 1 != pEnd
+|| rtl::isAsciiDigit(static_cast(*pCur))) )
 {
 int len = pCur - pLast;
 if (len >= 127)
@@ -113,7 +115,9 @@ bool SunVersion::init(const char *szVersion)
 
 //check next character
 if (! ( (pCur < pEnd)
-&& ( (nPart < 3) && isdigit(*pCur
+&& ( (nPart < 3)
+ && rtl::isAsciiDigit(
+ static_cast(*pCur)
 return false;
 }
 else
@@ -133,7 +137,7 @@ bool SunVersion::init(const char *szVersion)
 {
 if (pCur <= pEnd)
 {
-if ( ! isdigit(*pCur))
+if ( ! rtl::isAsciiDigit(static_cast(*pCur)))
 {
 //1.8.0_102-, 1.8.0_01a,
 size_t len = pCur - pLast;
@@ -184,7 +188,8 @@ bool SunVersion::init(const char *szVersion)
   if (m_preRelease == Rel_FreeBSD)
   {
   pCur++; //eliminate 'p'
-  if (pCur < pEnd && isdigit(*pCur))
+  if (pCur < pEnd
+  && rtl::isAsciiDigit(static_cast(*pCur)))
   pCur ++;
   int len = pCur - pLast -1; //eliminate 'p'
   if (len >= 127)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: i18nutil/source

[Stephan Bergmann]

 i18nutil/source/utility/unicode.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 73a644f438ffe436776bad708231a7dd73dd49e0
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:39:28 2017 +0100

Use rtl::isAscii* instead of ctype.h is* with sal_Unicode arg

Change-Id: I6eba985f41b78160d2377b2cd4c27ec85ade33df

diff --git a/i18nutil/source/utility/unicode.cxx 
b/i18nutil/source/utility/unicode.cxx
index 5d8a70aa4d77..53fb973ca400 100644
--- a/i18nutil/source/utility/unicode.cxx
+++ b/i18nutil/source/utility/unicode.cxx
@@ -1153,7 +1153,7 @@ bool ToggleUnicodeCodepoint::AllowMoreInput(sal_Unicode 
uChar)
 else if( maInput.indexOf("U+") == 8 )
 mbAllowMoreChars = false;
 // a hex character. Add to string.
-else if( isxdigit(uChar) )
+else if( rtl::isAsciiHexDigit(uChar) )
 {
 mbIsHexString = true;
 maInput.insertUtf32(0, uChar);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: rsc/source

[Stephan Bergmann]

 rsc/source/parser/rsclex.cxx  |   13 +++--
 rsc/source/tools/rscchar.cxx  |4 ++--
 rsc/source/tools/rsctools.cxx |9 +++--
 3 files changed, 16 insertions(+), 10 deletions(-)

New commits:
commit eedb6435f863b9377197a65ffd75ebec98007ebe
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:38:23 2017 +0100

Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)

Change-Id: Ibb854c389683656f2570ff330ce44c27aef0e70f

diff --git a/rsc/source/parser/rsclex.cxx b/rsc/source/parser/rsclex.cxx
index b7446db38a26..cbe2f0eded4d 100644
--- a/rsc/source/parser/rsclex.cxx
+++ b/rsc/source/parser/rsclex.cxx
@@ -34,6 +34,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 
@@ -82,9 +83,9 @@ sal_uInt32 GetNumber()
 
 if( nLog == 16 )
 {
-while( isxdigit( c ) )
+while( rtl::isAsciiHexDigit( static_cast(c) ) )
 {
-if( isdigit( c ) )
+if( rtl::isAsciiDigit( static_cast(c) ) )
 l = l * nLog + (c - '0');
 else
 l = l * nLog + (toupper( c ) - 'A' + 10 );
@@ -94,7 +95,7 @@ sal_uInt32 GetNumber()
 }
 else
 {
-while( isdigit( c ) || 'x' == c )
+while( rtl::isAsciiDigit( static_cast(c) ) || 'x' == c )
 {
 l = l * nLog + (c - '0');
 c = pFI->GetFastChar();
@@ -116,7 +117,7 @@ int MakeToken( YYSTYPE * pTokenVal )
 
 while( true ) // ignore comments and space characters
 {
-while( isspace( c ) )
+while( rtl::isAsciiWhiteSpace( static_cast(c) ) )
 c = pFI->GetFastChar();
 
 if( '/' == c )
@@ -211,13 +212,13 @@ int MakeToken( YYSTYPE * pTokenVal )
 pTokenVal->string = const_cast(pStringContainer->putString( 
aBuf.getStr() ));
 return STRING;
 }
-if (isdigit (c))
+if (rtl::isAsciiDigit (static_cast(c)))
 {
 pTokenVal->value = GetNumber();
 return NUMBER;
 }
 
-if( isalpha (c) || (c == '_') )
+if( rtl::isAsciiAlpha (static_cast(c)) || (c == '_') )
 {
 AtomnHashId;
 OStringBuffer aBuf( 256 );
diff --git a/rsc/source/tools/rscchar.cxx b/rsc/source/tools/rscchar.cxx
index 463622671766..fb5411407b54 100644
--- a/rsc/source/tools/rscchar.cxx
+++ b/rsc/source/tools/rscchar.cxx
@@ -106,9 +106,9 @@ char * RscChar::MakeUTF8( char * pStr, sal_uInt16 
nTextEncoding )
 sal_uInt16  nChar = 0;
 int  i = 0;
 ++pStr;
-while( isxdigit( *pStr ) && i != 2 )
+while( rtl::isAsciiHexDigit( static_cast(*pStr) ) && i != 2 )
 {
-if( isdigit( *pStr ) )
+if( rtl::isAsciiDigit( static_cast(*pStr) ) )
 nChar = nChar * 16 + (sal_uInt8)*pStr - 
(sal_uInt8)'0';
 else if( rtl::isAsciiUpperCase( 
static_cast(*pStr) ) )
 nChar = nChar * 16 + (sal_uInt8)*pStr - 
(sal_uInt8)'A' +10;
diff --git a/rsc/source/tools/rsctools.cxx b/rsc/source/tools/rsctools.cxx
index e043f451c3c1..c5780c9b0548 100644
--- a/rsc/source/tools/rsctools.cxx
+++ b/rsc/source/tools/rsctools.cxx
@@ -31,6 +31,7 @@
 
 #include 
 #include 
+#include 
 #include 
 
 /* case insensitive compare of two strings up to a given length */
@@ -93,7 +94,8 @@ char * ResponseFile( RscPtrPtr * ppCmd, char ** ppArgv, 
sal_uInt32 nArgc )
 nItems = fread( [ 0 ], 1, sizeof( char ), fFile );
 while( nItems )
 {
-if( !isspace( szBuffer[ 0 ] ) )
+if( !rtl::isAsciiWhiteSpace(
+static_cast(szBuffer[ 0 ]) ) )
 {
 /*
  *  #i27914# double ticks '"' now have a duplicate 
function:
@@ -102,7 +104,10 @@ char * ResponseFile( RscPtrPtr * ppCmd, char ** ppArgv, 
sal_uInt32 nArgc )
  *  argument no two !
  */
 unsigned int n = 0;
-while( nItems && (!isspace( szBuffer[ n ] ) || bInQuotes) 
&&
+while( nItems &&
+   (!rtl::isAsciiWhiteSpace(
+   static_cast(szBuffer[ n ]) ) ||
+bInQuotes) &&
n +1 < sizeof( szBuffer )  )
 {
 n++;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sal/cppunittester

[Stephan Bergmann]

 sal/cppunittester/cppunittester.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit fd70d8ee8925f7c7931f3db772516927c05b0fcb
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:37:00 2017 +0100

Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)

Change-Id: I93eeb586310cb1896b067b7c665e1fdee92d47b4

diff --git a/sal/cppunittester/cppunittester.cxx 
b/sal/cppunittester/cppunittester.cxx
index d08d5c0b1f26..11078c7cf74b 100644
--- a/sal/cppunittester/cppunittester.cxx
+++ b/sal/cppunittester/cppunittester.cxx
@@ -34,6 +34,7 @@
 #include "osl/module.h"
 #include "osl/module.hxx"
 #include "osl/thread.h"
+#include "rtl/character.hxx"
 #include "rtl/process.h"
 #include "rtl/string.h"
 #include "rtl/string.hxx"
@@ -127,7 +128,7 @@ public:
 int len = strlen(tn.get());
 for(int i = 0; i < len; i++)
 {
-if(!isalnum(tn[i]))
+if(!rtl::isAsciiAlphanumeric(static_cast(tn[i])))
 {
 tn[i] = '_';
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Stephan Bergmann]

 sc/source/filter/lotus/op.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d213e5a0a5a03ac5793228cd1b30f4d347e61168
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:36:34 2017 +0100

Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)

Change-Id: Ia3cc11ed882bf7e58c008f68af4340336c82b119

diff --git a/sc/source/filter/lotus/op.cxx b/sc/source/filter/lotus/op.cxx
index 0ce8d660ad59..4e91b98c77ff 100644
--- a/sc/source/filter/lotus/op.cxx
+++ b/sc/source/filter/lotus/op.cxx
@@ -212,7 +212,7 @@ void OP_NamedRange(LotusContext& rContext, SvStream& r, 
sal_uInt16 /*n*/)
 static_cast (nColEnd), static_cast (nRowEnd) 
);
 
 sal_Char cBuf[sizeof(cPuffer)+1];
-if( isdigit( *cPuffer ) )
+if( rtl::isAsciiDigit( static_cast(*cPuffer) ) )
 {  // first char in name is a number -> prepend 'A'
 cBuf[0] = 'A';
 strcpy( cBuf + 1, cPuffer );   // #100211# - checked
@@ -251,7 +251,7 @@ void OP_SymphNamedRange(LotusContext& rContext, SvStream& 
r, sal_uInt16 /*n*/)
 static_cast (nColEnd), static_cast (nRowEnd) 
);
 
 sal_Char cBuf[sizeof(cPuffer)+1];
-if( isdigit( *cPuffer ) )
+if( rtl::isAsciiDigit( static_cast(*cPuffer) ) )
 {  // first char in name is a number -> prepend 'A'
 cBuf[0] = 'A';
 strcpy( cBuf + 1, cPuffer );   // #100211# - checked
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: shell/source

[Stephan Bergmann]

 shell/source/win32/shlxthandler/util/iso8601_converter.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 065a124407ff4262d183e5c8eda98e10df832fbc
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:35:59 2017 +0100

Use rtl::isAscii* instead of ctype.h is* with wchar_t arg

Change-Id: I48bee0474fc4fe8be454c1e8819d8f192c9f9216

diff --git a/shell/source/win32/shlxthandler/util/iso8601_converter.cxx 
b/shell/source/win32/shlxthandler/util/iso8601_converter.cxx
index d8c6ddcf6bad..495ab470b358 100644
--- a/shell/source/win32/shlxthandler/util/iso8601_converter.cxx
+++ b/shell/source/win32/shlxthandler/util/iso8601_converter.cxx
@@ -27,6 +27,7 @@
 #include 
 #include 
 
+#include 
 
 /* Converts ISO 8601 conform date/time
represenation to the representation
@@ -120,7 +121,7 @@ std::wstring iso8601_duration_to_local_duration(const 
std::wstring& iso8601durat
 
 for (/**/; iter != iter_end; ++iter)
 {
-if (isdigit(*iter))
+if (rtl::isAsciiDigit(*iter)) // wchar_t is unsigned under MSVC
 {
 num += *iter;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svl/source

[Stephan Bergmann]

 svl/source/numbers/zforfind.cxx |   15 ---
 svl/source/numbers/zforfind.hxx |2 --
 2 files changed, 4 insertions(+), 13 deletions(-)

New commits:
commit 26dea94b01d196a146767af8b76fba41697e8150
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:34:35 2017 +0100

Use rtl::isAscii* instead of ctype.h is* with sal_Unicode arg

Change-Id: I744f774e6e43866f1c6ef9ff8de2d9f2e183f0be

diff --git a/svl/source/numbers/zforfind.cxx b/svl/source/numbers/zforfind.cxx
index e04272a847b8..c550d205247c 100644
--- a/svl/source/numbers/zforfind.cxx
+++ b/svl/source/numbers/zforfind.cxx
@@ -140,13 +140,6 @@ void ImpSvNumberInputScan::Reset()
 }
 }
 
-
-// static
-inline bool ImpSvNumberInputScan::MyIsdigit( sal_Unicode c )
-{
-return c < 128 && isdigit( (unsigned char) c );
-}
-
 // native number transliteration if necessary
 void TransformInput( SvNumberFormatter* pFormatter, OUString& rStr )
 {
@@ -246,7 +239,7 @@ bool ImpSvNumberInputScan::NextNumberStringSymbol( const 
sal_Unicode*& pStr,
 switch (eState)
 {
 case SsStart:
-if ( MyIsdigit( cToken ) )
+if ( rtl::isAsciiDigit( cToken ) )
 {
 eState = SsGetValue;
 isNumber = true;
@@ -258,7 +251,7 @@ bool ImpSvNumberInputScan::NextNumberStringSymbol( const 
sal_Unicode*& pStr,
 nChars++;
 break;
 case SsGetValue:
-if ( MyIsdigit( cToken ) )
+if ( rtl::isAsciiDigit( cToken ) )
 {
 nChars++;
 }
@@ -269,7 +262,7 @@ bool ImpSvNumberInputScan::NextNumberStringSymbol( const 
sal_Unicode*& pStr,
 }
 break;
 case SsGetString:
-if ( !MyIsdigit( cToken ) )
+if ( !rtl::isAsciiDigit( cToken ) )
 {
 nChars++;
 }
@@ -332,7 +325,7 @@ bool ImpSvNumberInputScan::SkipThousands( const 
sal_Unicode*& pStr,
 }
 break;
 case SsGetValue:
-if ( MyIsdigit( cToken ) )
+if ( rtl::isAsciiDigit( cToken ) )
 {
 sBuff.append(cToken);
 nCounter++;
diff --git a/svl/source/numbers/zforfind.hxx b/svl/source/numbers/zforfind.hxx
index 351283bdef04..cedda8c7d73d 100644
--- a/svl/source/numbers/zforfind.hxx
+++ b/svl/source/numbers/zforfind.hxx
@@ -371,8 +371,6 @@ private:
 bool IsNumberFormatMain( const OUString& rString,
  const SvNumberformat* pFormat);// number 
format to match against
 
-static inline bool MyIsdigit( sal_Unicode c );
-
 /** Whether input matches locale dependent date acceptance pattern.
 
 @param nStartPatternAt
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: tools/source

[Stephan Bergmann]

 tools/source/ref/globname.cxx |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit bd556163d9fa3a01a285a818a01712cff55f5c69
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:32:40 2017 +0100

Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)

Change-Id: I83576b55ca421abfe056eb7b66f8f74782100a09

diff --git a/tools/source/ref/globname.cxx b/tools/source/ref/globname.cxx
index d6395b79a33a..28042a78f4b8 100644
--- a/tools/source/ref/globname.cxx
+++ b/tools/source/ref/globname.cxx
@@ -184,8 +184,8 @@ bool SvGlobalName::MakeId( const OUString & rIdStr )
 int i = 0;
 for( i = 0; i < 8; i++ )
 {
-if( isxdigit( *pStr ) )
-if( isdigit( *pStr ) )
+if( rtl::isAsciiHexDigit( static_cast(*pStr) ) )
+if( rtl::isAsciiDigit( static_cast(*pStr) ) )
 nFirst = nFirst * 16 + (*pStr - '0');
 else
 nFirst = nFirst * 16 + (rtl::toAsciiUpperCase( 
static_cast(*pStr) ) - 'A' + 10 );
@@ -198,8 +198,8 @@ bool SvGlobalName::MakeId( const OUString & rIdStr )
 pStr++;
 for( i = 0; i < 4; i++ )
 {
-if( isxdigit( *pStr ) )
-if( isdigit( *pStr ) )
+if( rtl::isAsciiHexDigit( static_cast(*pStr) ) )
+if( rtl::isAsciiDigit( static_cast(*pStr) ) )
 nSec = nSec * 16 + (*pStr - '0');
 else
 nSec = nSec * 16 + (sal_uInt16)(rtl::toAsciiUpperCase( 
static_cast(*pStr) ) - 'A' + 10 );
@@ -212,8 +212,8 @@ bool SvGlobalName::MakeId( const OUString & rIdStr )
 pStr++;
 for( i = 0; i < 4; i++ )
 {
-if( isxdigit( *pStr ) )
-if( isdigit( *pStr ) )
+if( rtl::isAsciiHexDigit( static_cast(*pStr) ) )
+if( rtl::isAsciiDigit( static_cast(*pStr) ) )
 nThird = nThird * 16 + (*pStr - '0');
 else
 nThird = nThird * 16 + (sal_uInt16)(rtl::toAsciiUpperCase( 
static_cast(*pStr) ) - 'A' + 10 );
@@ -227,8 +227,8 @@ bool SvGlobalName::MakeId( const OUString & rIdStr )
 pStr++;
 for( i = 0; i < 16; i++ )
 {
-if( isxdigit( *pStr ) )
-if( isdigit( *pStr ) )
+if( rtl::isAsciiHexDigit( static_cast(*pStr) ) )
+if( rtl::isAsciiDigit( static_cast(*pStr) ) )
 szRemain[i/2] = szRemain[i/2] * 16 + (*pStr - '0');
 else
 szRemain[i/2] = szRemain[i/2] * 16 + 
(sal_Int8)(rtl::toAsciiUpperCase( static_cast(*pStr) ) - 'A' + 
10 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Stephan Bergmann]

 vcl/source/filter/ipdf/pdfdocument.cxx |   22 +-
 vcl/source/filter/ixbm/xbmread.cxx |7 +--
 vcl/source/gdi/pdfwriter_impl.cxx  |2 +-
 3 files changed, 19 insertions(+), 12 deletions(-)

New commits:
commit 2595ad876024d6df4249dcdac39501d2fdf9e0c9
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:32:12 2017 +0100

Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)

Change-Id: I10c0433d314808cb1c51c3bde4f826bce7c8a97b

diff --git a/vcl/source/filter/ipdf/pdfdocument.cxx 
b/vcl/source/filter/ipdf/pdfdocument.cxx
index fe60765ed5eb..72996ecd652c 100644
--- a/vcl/source/filter/ipdf/pdfdocument.cxx
+++ b/vcl/source/filter/ipdf/pdfdocument.cxx
@@ -19,6 +19,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -994,7 +995,7 @@ bool PDFDocument::Tokenize(SvStream& rStream, TokenizeMode 
eMode, std::vector< s
 }
 default:
 {
-if (isdigit(ch) || ch == '-')
+if (rtl::isAsciiDigit(static_cast(ch)) || ch == '-')
 {
 // Numbering object: an integer or a real.
 auto pNumberElement = new PDFNumberElement();
@@ -1015,7 +1016,7 @@ bool PDFDocument::Tokenize(SvStream& rStream, 
TokenizeMode eMode, std::vector< s
 m_pXRefStream = it->second;
 }
 }
-else if (isalpha(ch))
+else if (rtl::isAsciiAlpha(static_cast(ch)))
 {
 // Possible keyword, like "obj".
 rStream.SeekRel(-1);
@@ -1166,7 +1167,7 @@ bool PDFDocument::Tokenize(SvStream& rStream, 
TokenizeMode eMode, std::vector< s
 }
 else
 {
-if (!isspace(ch))
+if (!rtl::isAsciiWhiteSpace(static_cast(ch)))
 {
 SAL_WARN("vcl.filter", "PDFDocument::Tokenize: unexpected 
character: " << ch << " at byte position " << rStream.Tell());
 return false;
@@ -1261,7 +1262,7 @@ OString PDFDocument::ReadKeyword(SvStream& rStream)
 rStream.ReadChar(ch);
 if (rStream.IsEof())
 return OString();
-while (isalpha(ch))
+while (rtl::isAsciiAlpha(static_cast(ch)))
 {
 aBuf.append(ch);
 rStream.ReadChar(ch);
@@ -1682,7 +1683,7 @@ void PDFDocument::SkipWhitespace(SvStream& rStream)
 if (rStream.IsEof())
 break;
 
-if (!isspace(ch))
+if (!rtl::isAsciiWhiteSpace(static_cast(ch)))
 {
 rStream.SeekRel(-1);
 return;
@@ -1833,7 +1834,7 @@ std::vector 
PDFDocument::GetSignatureWidgets()
 int PDFDocument::AsHex(char ch)
 {
 int nRet = 0;
-if (isdigit(ch))
+if (rtl::isAsciiDigit(static_cast(ch)))
 nRet = ch - '0';
 else
 {
@@ -1921,14 +1922,16 @@ bool PDFNumberElement::Read(SvStream& rStream)
 {
 return false;
 }
-if (!isdigit(ch) && ch != '-' && ch != '.')
+if (!rtl::isAsciiDigit(static_cast(ch)) && ch != '-'
+&& ch != '.')
 {
 rStream.SeekRel(-1);
 return false;
 }
 while (!rStream.IsEof())
 {
-if (!isdigit(ch) && ch != '-' && ch != '.')
+if (!rtl::isAsciiDigit(static_cast(ch)) && ch != '-'
+&& ch != '.')
 {
 rStream.SeekRel(-1);
 m_nLength = rStream.Tell() - m_nOffset;
@@ -2780,7 +2783,8 @@ bool PDFNameElement::Read(SvStream& rStream)
 rStream.ReadChar(ch);
 while (!rStream.IsEof())
 {
-if (isspace(ch) || ch == '/' || ch == '[' || ch == ']' || ch == '<' || 
ch == '>' || ch == '(')
+if (rtl::isAsciiWhiteSpace(static_cast(ch)) || ch == '/'
+|| ch == '[' || ch == ']' || ch == '<' || ch == '>' || ch == '(')
 {
 rStream.SeekRel(-1);
 m_aValue = aBuf.makeStringAndClear();
diff --git a/vcl/source/filter/ixbm/xbmread.cxx 
b/vcl/source/filter/ixbm/xbmread.cxx
index d3d21c4229c7..b0dd915c5b41 100644
--- a/vcl/source/filter/ixbm/xbmread.cxx
+++ b/vcl/source/filter/ixbm/xbmread.cxx
@@ -17,8 +17,11 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include 
+#include 
+
 #include 
+#include 
+
 #include "xbmread.hxx"
 
 enum XBMFormat
@@ -223,7 +226,7 @@ bool XBMReader::ParseData( SvStream* pInStm, const OString& 
aLastLine, XBMFormat
 const unsigned char cChar = aToken[n];
 const short nTable = pHexTable[ cChar ];
 
-if( isxdigit( cChar ) || !nTable )
+if( rtl::isAsciiHexDigit( cChar ) || !nTable )
 {
 nValue = ( nValue << 4 ) + nTable;
 nDigits++;
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 160829fa9566..ef7a11140b5e 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ 

[Libreoffice-commits] core.git: include/rtl writerfilter/source

[Stephan Bergmann]

 include/rtl/character.hxx |   23 ++
 writerfilter/source/rtftok/rtfdispatchdestination.cxx |   12 +++--
 writerfilter/source/rtftok/rtftokenizer.cxx   |   10 +++
 3 files changed, 37 insertions(+), 8 deletions(-)

New commits:
commit f5c93d4149e7ae967e98dbce72528a04a204ca95
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:31:00 2017 +0100

Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)

and add rtl::isAsciiWhiteSpace

Change-Id: Iac71975f718b9360ea9dc94485c069c5e7cb91c7

diff --git a/include/rtl/character.hxx b/include/rtl/character.hxx
index 4ccc632afb4a..b83121a4a6d4 100644
--- a/include/rtl/character.hxx
+++ b/include/rtl/character.hxx
@@ -239,6 +239,29 @@ template inline bool isAsciiOctalDigit(T code)
 { return isAsciiOctalDigit(sal_uInt32(code)); }
 #endif
 
+/** Check for ASCII white space character.
+
+@param code  A Unicode code point.
+
+@return  True if code is an ASCII white space character as defined by C for
+isspace in the "C" locale (ASCII ' ', '\f', '\n', '\r', '\t' '\v').
+
+@since LibreOffice 5.4
+*/
+inline bool isAsciiWhiteSpace(sal_uInt32 code)
+{
+assert(isUnicodeCodePoint(code));
+return code == ' ' || code == '\f' || code == '\n' || code == '\r'
+|| code == '\t' || code == '\v';
+}
+
+#if defined LIBO_INTERNAL_ONLY
+bool isAsciiWhiteSpace(char) = delete;
+bool isAsciiWhiteSpace(signed char) = delete;
+template inline bool isAsciiWhiteSpace(T code)
+{ return isAsciiWhiteSpace(sal_uInt32(code)); }
+#endif
+
 /** Convert a character, if ASCII, to upper case.
 
 @param code  A Unicode code point.
diff --git a/writerfilter/source/rtftok/rtfdispatchdestination.cxx 
b/writerfilter/source/rtftok/rtfdispatchdestination.cxx
index 0c44e25b4dd2..3863309b3601 100644
--- a/writerfilter/source/rtftok/rtfdispatchdestination.cxx
+++ b/writerfilter/source/rtftok/rtfdispatchdestination.cxx
@@ -13,6 +13,7 @@
 #include 
 
 #include 
+#include 
 #include 
 
 #include 
@@ -71,11 +72,16 @@ RTFError RTFDocumentImpl::dispatchDestination(RTFKeyword 
nKeyword)
 Strm().ReadChar(ch);
 if ('\\' == ch)
 bInKeyword = true;
-if (!bInKeyword  && isalnum(ch))
+if (!bInKeyword
+&& rtl::isAsciiAlphanumeric(static_cast(ch)))
 aBuf.append(ch);
-else if (bInKeyword && isspace(ch))
+else if (bInKeyword
+ && rtl::isAsciiWhiteSpace(
+ static_cast(ch)))
 bInKeyword = false;
-if (!aBuf.isEmpty() && !isalnum(ch))
+if (!aBuf.isEmpty()
+&& !rtl::isAsciiAlphanumeric(
+static_cast(ch)))
 bFoundCode = true;
 }
 
diff --git a/writerfilter/source/rtftok/rtftokenizer.cxx 
b/writerfilter/source/rtftok/rtftokenizer.cxx
index fd0fd2f9d44e..91b41eb5242e 100644
--- a/writerfilter/source/rtftok/rtftokenizer.cxx
+++ b/writerfilter/source/rtftok/rtftokenizer.cxx
@@ -166,7 +166,7 @@ RTFError RTFTokenizer::resolveParse()
 int RTFTokenizer::asHex(char ch)
 {
 int ret = 0;
-if (isdigit(ch))
+if (rtl::isAsciiDigit(static_cast(ch)))
 ret = ch - '0';
 else
 {
@@ -203,7 +203,7 @@ RTFError RTFTokenizer::resolveKeyword()
 if (Strm().IsEof())
 return RTFError::UNEXPECTED_EOF;
 
-if (!isalpha(ch))
+if (!rtl::isAsciiAlpha(static_cast(ch)))
 {
 aBuf.append(ch);
 OString aKeyword = aBuf.makeStringAndClear();
@@ -211,7 +211,7 @@ RTFError RTFTokenizer::resolveKeyword()
 // without doing any SeekRel()
 return dispatchKeyword(aKeyword, bParam, nParam);
 }
-while (isalpha(ch))
+while (rtl::isAsciiAlpha(static_cast(ch)))
 {
 aBuf.append(ch);
 Strm().ReadChar(ch);
@@ -234,13 +234,13 @@ RTFError RTFTokenizer::resolveKeyword()
 if (Strm().IsEof())
 return RTFError::UNEXPECTED_EOF;
 }
-if (isdigit(ch))
+if (rtl::isAsciiDigit(static_cast(ch)))
 {
 OStringBuffer aParameter;
 
 // we have a parameter
 bParam = true;
-while (isdigit(ch))
+while (rtl::isAsciiDigit(static_cast(ch)))
 {
 aParameter.append(ch);
 Strm().ReadChar(ch);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmloff/source

[Stephan Bergmann]

 xmloff/source/meta/xmlmetai.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit e6297cf05d943f8dee51dd995e9b8ff039cc9cd1
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:28:18 2017 +0100

Use rtl::isAscii* instead of ctype.h is* with sal_Unicode arg

Change-Id: Ieb4bda18ea6ee8d957bb9b9f584e12eb24091513

diff --git a/xmloff/source/meta/xmlmetai.cxx b/xmloff/source/meta/xmlmetai.cxx
index 82e2d8e4c979..18b1560ead8c 100644
--- a/xmloff/source/meta/xmlmetai.cxx
+++ b/xmloff/source/meta/xmlmetai.cxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -274,7 +275,7 @@ void SvXMLMetaDocumentContext::setBuildId(OUString const& 
i_rBuildId, const uno:
 OUStringBuffer sNumber;
 for (sal_Int32 i = 0; i < rest.getLength(); ++i)
 {
-if (isdigit(rest[i]))
+if (rtl::isAsciiDigit(rest[i]))
 {
 sNumber.append(rest[i]);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmlsecurity/source

[Stephan Bergmann]

 xmlsecurity/source/pdfio/pdfdocument.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 9df97a7d65a68699f5ee90c2541bd7c8a2df95d9
Author: Stephan Bergmann 
Date:   Wed Mar 22 21:26:34 2017 +0100

Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)

Change-Id: I0b478dfa25a54595ba0dcee1ca3ec0291ee94ef5

diff --git a/xmlsecurity/source/pdfio/pdfdocument.cxx 
b/xmlsecurity/source/pdfio/pdfdocument.cxx
index 78d41c94e097..5420196df7d8 100644
--- a/xmlsecurity/source/pdfio/pdfdocument.cxx
+++ b/xmlsecurity/source/pdfio/pdfdocument.cxx
@@ -19,6 +19,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -131,7 +132,7 @@ bad_data:
 do
 {
 PRUint32 decimal = 0;
-while (len > 0 && isdigit(*from))
+while (len > 0 && rtl::isAsciiDigit(static_cast(*from)))
 {
 PRUint32 addend = (*from++ - '0');
 --len;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106706] New: Presentation with linked videos crashes Impress when loading.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106706

Bug ID: 106706
   Summary: Presentation with linked videos crashes Impress when
loading.
   Product: LibreOffice
   Version: 5.3.2.1 rc
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rhodyr...@gmail.com

I have a presentation with a linked video (mp4 file) on two of the slides. I
have been creating new versions of the presentation for a series of 20 classes.
For the first 19 classes the presentation with the videos has worked just fine.
During this time I have been updating LibreOffice to the most current version
as new updates became available. With the most recent update, the presentation
will no longer load. I was able to load the presentation into LibreOffice
4.2.4.2 on another PC. I saved it in PPTX format which broke the link to the
videos. I was then able to load the presentation on the PC with LibreOffice
5.3.1.2 and save it in ODP format. I can save and load this presentation with
LibreOffice 5.3.1.2 without the linked videos. If I try to insert a video where
it belongs on the slide, Impress starts the process but then just stops and all
I can do is terminate LibreOffice with the Windows Task Manager. During the
time I have been working on this presentation I did notice a higher frequency
of program crashes starting with version 5.2. Hope you can get this fixed since
I have many similar presentations with linked videos.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104244] EDITING: current cell not indicated in Calc (Ubuntu)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104244

--- Comment #15 from rastakvajana...@gmail.com ---
I have the same problem. Active cell is not bordered. Reinstalling driver (sudo
apt-get install xserver-xorg-video-intel) did not help. Enabling OpenGl helped
to highlitght the active cell, but destroyed other things...

One more thing - when reinstalling driver, I got this:

jd@jd-OptiPlex-780:~$ sudo apt-get install xserver-xorg-video-intel
Reading package lists... Done
Building dependency tree   
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 xserver-xorg-video-intel : Depends: xserver-xorg-core (>= 2:1.17.99.902)
E: Unable to correct problems, you have held broken packages.

Any help? I am a newbie and no expert and this my first report ever, so I am
sorry if my post is not in a manner it should be...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106620] Glued lines are not perfectly aligned

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106620

Martin Marmsoler  changed:

   What|Removed |Added

Version|unspecified |5.3.1.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106621] Additional glue points in group are not visible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106621

Martin Marmsoler  changed:

   What|Removed |Added

Version|unspecified |5.4.0.0.alpha0+ Master

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106705] FILEOPEN: DOC: Bullets incorrectly highlighted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106705

--- Comment #2 from Xisco Faulí  ---
Created attachment 132081
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132081=edit
MSO 2010

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106705] FILEOPEN: DOC: Bullets incorrectly highlighted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106705

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||filter:doc, regression
 Status|UNCONFIRMED |NEW
 CC||caol...@redhat.com,
   ||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Caolán McNamara 2014-09-23 19:35:50 (GMT)
committer   Caolán McNamara 2014-09-24 09:04:48
(GMT)
commit  705a8c226aee3e68db492083b7cf8b704335328b (patch)
treec701b3a13f48f6d5a4c226bcf4f67e1e91a41049
parent  6332c643016ce4c4d254c8429a5eceae6664bf5c (diff)

Bisected with bibisect-44max.

Adding Cc: to Caolán McNamara

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106705] New: FILEOPEN: DOC: Bullets incorrectly highlighted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106705

Bug ID: 106705
   Summary: FILEOPEN: DOC: Bullets incorrectly highlighted
   Product: LibreOffice
   Version: 4.4 all versions
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 132080
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132080=edit
sample

Steps to reproduce:
1. Open attached document
2. Check bullets in first page

Observed behaviour: all bullets are hightlighted

Reproduced in

Version: 5.4.0.0.alpha0+
Build ID: 4ba483beccc99d336d0e0bec47b5fd6823b16c16
CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #28 from Jim DeLaHunt  ---
(In reply to Jean-Baptiste Faure from comment #24)
> (In reply to Jim DeLaHunt from comment #23)
> > By the way, after bug 106687 occurred I noticed that I was not able to edit
> > the failing macro in my macro editor. I'm not sure this is part of this bug
> > or not. 
> 
> I disagree: I had the same problem with the Altsearch extension and the
> Basic editor was opened with the offended code allowing me to fix the bug
> for myself

JBF, thank you for your report.

Let me be clear, on my system (LO 5.3.1.2 on Mac OS X 10.11 El Capitan), LO
opened the Basic editor, had an orange arrow pointing to the line with the
error, but did not let me make any changes to the code.  The Macro editor was
read-only for me.

JBF, what LO version and OS are you using?  Maybe I am seeing a problem limited
to the Mac build of LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106704] New: Automatic points at connected lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106704

Bug ID: 106704
   Summary: Automatic points at connected lines
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: martin.marmso...@gmail.com

Created attachment 132079
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132079=edit
Crossing Points feature

Hello,

in LO there is no possibility to connect two lines together at a specific
point, just somewhere where a glue is (and if two lines are overlapped it looks
like there is one thicker line). As workaround you can create a point and
connect two line to this point, but the center of the point is not aligned to
the grid so it look not very well.

So a nice feature would be also to connect two lines  together without adding a
point between them (it should create the point it self). See attached file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: ios/experimental

[jan Iversen]

 ios/experimental/LibreOfficeLight/LibreOfficeLight/FileManagerController.swift 
|   12 +
 ios/experimental/LibreOfficeLight/LibreOfficeLight/en.lproj/Main.storyboard
|   66 +-
 2 files changed, 43 insertions(+), 35 deletions(-)

New commits:
commit 7a46166beb714a3357f7fb04111ba98f6325065f
Author: jan Iversen 
Date:   Fri Mar 17 12:37:31 2017 +0100

iOS LibreOfficeLight Document as root

changed DocumentView to be root view
FileManagerView is started from DocumentView

Change-Id: I43d2a2fab3ff37983c242bce15bdb94c8cc7d4be
Reviewed-on: https://gerrit.libreoffice.org/35536
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git 
a/ios/experimental/LibreOfficeLight/LibreOfficeLight/FileManagerController.swift
 
b/ios/experimental/LibreOfficeLight/LibreOfficeLight/FileManagerController.swift
index 94f4106edf1a..2fee4804b4f2 100755
--- 
a/ios/experimental/LibreOfficeLight/LibreOfficeLight/FileManagerController.swift
+++ 
b/ios/experimental/LibreOfficeLight/LibreOfficeLight/FileManagerController.swift
@@ -199,11 +199,13 @@ class FileManagerController : UITableViewController, 
actionsControlDelegate
 // Last stop before displaying popover
 override func prepare(for segue: UIStoryboardSegue, sender: Any?)
 {
-let vc = segue.destination as! FileManagerActions
-vc.delegate = self
-vc.inFileSelect = (selectedRow != nil)
-vc.inSubDirectory = fileData.isSubDirectory()
-vc.useCloud = fileData.iCloudEnabled()
+if segue.identifier == "doShowFileManagerActions" {
+let vc = segue.destination as! FileManagerActions
+vc.delegate = self
+vc.inFileSelect = (selectedRow != nil)
+vc.inSubDirectory = fileData.isSubDirectory()
+vc.useCloud = fileData.iCloudEnabled()
+}
 }
 
 
diff --git 
a/ios/experimental/LibreOfficeLight/LibreOfficeLight/en.lproj/Main.storyboard 
b/ios/experimental/LibreOfficeLight/LibreOfficeLight/en.lproj/Main.storyboard
index d7589a64ea2d..06935c3708d6 100755
--- 
a/ios/experimental/LibreOfficeLight/LibreOfficeLight/en.lproj/Main.storyboard
+++ 
b/ios/experimental/LibreOfficeLight/LibreOfficeLight/en.lproj/Main.storyboard
@@ -31,13 +31,20 @@
 
 
 
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 
 
 
@@ -118,7 +125,7 @@
 
 
 
-
+
 
 
 
@@ -320,8 +327,8 @@
 
 
 
-
-
+
+
 
 
 
@@ -509,6 +516,15 @@
 
 
 
+
+
+
+
+
+
+
+
+
 
 
 
@@ -520,7 +536,7 @@
 
 
 
-
+
 
 
 
@@ -538,7 +554,7 @@
 
 
 
-
+
 
 
 
@@ -556,7 +572,7 @@
 
 
 

[Libreoffice-bugs] [Bug 106687] (Typography Extension v1.1) Pressing "Oldstyle figures" button in Typography Toolbar gives "Basic Syntax error. Expected: )."

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106687

--- Comment #5 from Jim DeLaHunt  ---
> I am sure that you need to put closing parenthesis not at the end of the 
> expression, but rather ... after cstr(refine(id, i) and before &.

Thank you for this suggestion. 

> TDF doesn't develop [the Typography toolbar extension], so its Bugzilla
> is not a place to track an external project's bug state.

Fair enough. I had recently read something which suggested tracking Extension
bugs in this Bugzilla. But now I read
https://wiki.documentfoundation.org/QA/BugReport/Extensions , which says
clearly that this Bugzilla does not track Extensions from outside Document
Foundation.

For the Typography extension, I can see an email address, but no link to a bug
tracker. It's a pity that the Extensions register doesn't collect contact
information for extension developers and for their bug tracking services, and
pass it on to Extension users.  But that's another issue.

Given this, I withdraw my suggestion, and thank you for your help.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106366] "Open" for document in use doesn't give "Edit document" button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106366

Timur  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106690] FILEOPEN: DOCX: Spacing between bullets is incorrect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106690

--- Comment #2 from Xisco Faulí  ---
Created attachment 132078
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132078=edit
sample2

Another document affected by the same commit in page 2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: starmath/inc starmath/source

[Takeshi Abe]

 starmath/inc/parse.hxx|2 +-
 starmath/source/parse.cxx |   35 +++
 2 files changed, 16 insertions(+), 21 deletions(-)

New commits:
commit a69632cc1fdc931adcab4751607f3dd79b8cf771
Author: Takeshi Abe 
Date:   Thu Mar 23 00:16:57 2017 +0900

starmath: Make SmParser::DoPower() return SmNode

instead of pushing it to the stack.

Change-Id: I7b1640e1b3f835c06726941adfe6d212853f3af6
Reviewed-on: https://gerrit.libreoffice.org/35537
Tested-by: Jenkins 
Reviewed-by: Takeshi Abe 

diff --git a/starmath/inc/parse.hxx b/starmath/inc/parse.hxx
index 6c3e7dbe7a78..d158c3995151 100644
--- a/starmath/inc/parse.hxx
+++ b/starmath/inc/parse.hxx
@@ -69,7 +69,7 @@ class SmParser
 voidDoProduct();
 SmNode *DoSubSup(TG nActiveGroup, SmNode *pGivenNode);
 SmNode *DoOpSubSup();
-voidDoPower();
+SmNode *DoPower();
 SmBlankNode *DoBlank();
 SmNode *DoTerm(bool bGroupNumberIdent);
 SmNode *DoEscape();
diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx
index 9a147f48ee37..14ab62aad504 100644
--- a/starmath/source/parse.cxx
+++ b/starmath/source/parse.cxx
@@ -1097,12 +1097,11 @@ void SmParser::DoSum()
 
 void SmParser::DoProduct()
 {
-DoPower();
+SmNode *pFirst = DoPower();
 
 while (TokenInGroup(TG::Product))
 {   SmStructureNode *pSNode;
-SmNode *pFirst = popOrZero(m_aNodeStack),
-   *pOper;
+SmNode *pOper;
 bool bSwitchArgs = false;
 
 SmTokenType eType = m_aCurToken.eType;
@@ -1153,19 +1152,20 @@ void SmParser::DoProduct()
 pOper = DoOpSubSup();
 }
 
-DoPower();
+SmNode *pArg = DoPower();
 
 if (bSwitchArgs)
 {
 //! vgl siehe SmBinDiagonalNode::Arrange
-pSNode->SetSubNodes(pFirst, popOrZero(m_aNodeStack), pOper);
+pSNode->SetSubNodes(pFirst, pArg, pOper);
 }
 else
 {
-pSNode->SetSubNodes(pFirst, pOper, popOrZero(m_aNodeStack));
+pSNode->SetSubNodes(pFirst, pOper, pArg);
 }
-m_aNodeStack.push_front(std::unique_ptr(pSNode));
+pFirst = pSNode;
 }
+m_aNodeStack.emplace_front(pFirst);
 }
 
 SmNode *SmParser::DoSubSup(TG nActiveGroup, SmNode *pGivenNode)
@@ -1240,15 +1240,14 @@ SmNode *SmParser::DoOpSubSup()
 return pNode.release();
 }
 
-void SmParser::DoPower()
+SmNode *SmParser::DoPower()
 {
 // get body for sub- supscripts on top of stack
 SmNode *pNode = DoTerm(false);
 
 if (m_aCurToken.nGroup == TG::Power)
-m_aNodeStack.emplace_front(DoSubSup(TG::Power, pNode));
-else
-m_aNodeStack.emplace_front(pNode);
+return DoSubSup(TG::Power, pNode);
+return pNode;
 }
 
 SmBlankNode *SmParser::DoBlank()
@@ -1481,9 +1480,7 @@ SmNode *SmParser::DoTerm(bool bGroupNumberIdent)
||  TokenInGroup(TG::FontAttr))
 aStack.push((bIsAttr) ? DoAttribut() : DoFontAttribut());
 
-DoPower();
-
-SmNode *pFirstNode = popOrZero(m_aNodeStack);
+SmNode *pFirstNode = DoPower();
 while (!aStack.empty())
 {
 SmStructureNode *pNode = aStack.top();
@@ -1549,9 +1546,9 @@ SmOperNode *SmParser::DoOperator()
 pOperator = DoSubSup(m_aCurToken.nGroup, pOperator);
 
 // get argument
-DoPower();
+SmNode *pArg = DoPower();
 
-pSNode->SetSubNodes(pOperator, popOrZero(m_aNodeStack));
+pSNode->SetSubNodes(pOperator, pArg);
 return pSNode.release();
 }
 
@@ -1631,8 +1628,7 @@ SmStructureNode *SmParser::DoUnOper()
 
 case TNROOT :
 NextToken();
-DoPower();
-pExtra = popOrZero(m_aNodeStack);
+pExtra = DoPower();
 break;
 
 case TUOPER :
@@ -1657,8 +1653,7 @@ SmStructureNode *SmParser::DoUnOper()
 }
 
 // get argument
-DoPower();
-pArg = popOrZero(m_aNodeStack);
+pArg = DoPower();
 
 if (eType == TABS)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106703] New: Poor Performance on Mac OSX 10.12.3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106703

Bug ID: 106703
   Summary: Poor Performance on Mac OSX 10.12.3
   Product: LibreOffice
   Version: 5.3.1.2 release
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: c.kay...@gmx.de

Description:
It takes a very long time for LibreOffice to open or to save a document. When
you print a document, it takes a boring time till LibreOffice works again...
I switched over to latest OpenOffice 4.3.1 that works well...


Reproducible: Always

User Profile Reset: Yes

Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/602.4.8
(KHTML, like Gecko) Version/10.0.3 Safari/602.4.8

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svx svx/source

[Marco Cecchetti]

 include/svx/sdrpaintwindow.hxx   |   14 ++---
 svx/source/svdraw/sdrpaintwindow.cxx |   36 +--
 2 files changed, 25 insertions(+), 25 deletions(-)

New commits:
commit b396bc042dad1d553ebf51897ef012c08c41a86a
Author: Marco Cecchetti 
Date:   Sun Jan 1 12:43:45 2017 +0100

Calc: safer life cycle handling for OutputDevice in  SdrPaintWindow

Change-Id: I5469332c4ef98bce8cd9c2caff5bf61dbf102b23
Reviewed-on: https://gerrit.libreoffice.org/33220
Tested-by: Jenkins 
Reviewed-by: Jan Holesovsky 

diff --git a/include/svx/sdrpaintwindow.hxx b/include/svx/sdrpaintwindow.hxx
index 25c51c52563b..bcb0b0a8c843 100644
--- a/include/svx/sdrpaintwindow.hxx
+++ b/include/svx/sdrpaintwindow.hxx
@@ -46,7 +46,7 @@ PaintTransparentChildren(vcl::Window & rWindow, Rectangle 
const& rPixelRect);
 class SdrPreRenderDevice
 {
 // The original OutputDevice
-OutputDevice&  mrOutputDevice;
+VclPtr   mpOutputDevice;
 
 // The VirtualDevice for PreRendering
 VclPtr  mpPreRenderDevice;
@@ -65,7 +65,7 @@ class SVX_DLLPUBLIC SdrPaintWindow
 {
 private:
 // the OutputDevice this window represents
-OutputDevice&   mrOutputDevice;
+VclPtrmpOutputDevice;
 
 /// In case mrOutputDevice is a buffer for a vcl::Window, this is the 
window.
 VclPtr mpWindow;
@@ -95,7 +95,7 @@ public:
 
 // data read accesses
 SdrPaintView& GetPaintView() const { return mrPaintView; }
-OutputDevice& GetOutputDevice() const { return mrOutputDevice; }
+OutputDevice& GetOutputDevice() const { return *mpOutputDevice.get(); }
 vcl::Window* GetWindow() const { return mpWindow; }
 
 // OVERLAYMANAGER
@@ -108,13 +108,13 @@ public:
 Rectangle GetVisibleArea() const;
 
 // Is OutDev a printer?
-bool OutputToPrinter() const { return (OUTDEV_PRINTER == 
mrOutputDevice.GetOutDevType()); }
+bool OutputToPrinter() const { return (OUTDEV_PRINTER == 
mpOutputDevice->GetOutDevType()); }
 
 // Is OutDev a window?
-bool OutputToWindow() const { return (OUTDEV_WINDOW == 
mrOutputDevice.GetOutDevType()); }
+bool OutputToWindow() const { return (OUTDEV_WINDOW == 
mpOutputDevice->GetOutDevType()); }
 
 // Is OutDev a VirtualDevice?
-bool OutputToVirtualDevice() const { return (OUTDEV_VIRDEV == 
mrOutputDevice.GetOutDevType()); }
+bool OutputToVirtualDevice() const { return (OUTDEV_VIRDEV == 
mpOutputDevice->GetOutDevType()); }
 
 // Is OutDev a recording MetaFile?
 bool OutputToRecordingMetaFile() const;
@@ -134,7 +134,7 @@ public:
 void setTemporaryTarget(bool bNew) { mbTemporaryTarget = bNew; }
 
 // #i72889# get target output device, take into account output buffering
-OutputDevice& GetTargetOutputDevice() { if(mpPreRenderDevice) return 
mpPreRenderDevice->GetPreRenderDevice(); else return mrOutputDevice; }
+OutputDevice& GetTargetOutputDevice() { if(mpPreRenderDevice) return 
mpPreRenderDevice->GetPreRenderDevice(); else return *mpOutputDevice.get(); }
 };
 
 // typedefs for a list of SdrPaintWindows
diff --git a/svx/source/svdraw/sdrpaintwindow.cxx 
b/svx/source/svdraw/sdrpaintwindow.cxx
index a83954a6fef1..8105a65ce05a 100644
--- a/svx/source/svdraw/sdrpaintwindow.cxx
+++ b/svx/source/svdraw/sdrpaintwindow.cxx
@@ -108,7 +108,7 @@ void CandidateMgr::PaintTransparentChildren(vcl::Window & 
rWindow, Rectangle con
 }
 
 SdrPreRenderDevice::SdrPreRenderDevice(OutputDevice& rOriginal)
-:   mrOutputDevice(rOriginal),
+:   mpOutputDevice(),
 mpPreRenderDevice(VclPtr::Create())
 {
 }
@@ -121,33 +121,33 @@ SdrPreRenderDevice::~SdrPreRenderDevice()
 void SdrPreRenderDevice::PreparePreRenderDevice()
 {
 // compare size of mpPreRenderDevice with size of visible area
-if(mpPreRenderDevice->GetOutputSizePixel() != 
mrOutputDevice.GetOutputSizePixel())
+if(mpPreRenderDevice->GetOutputSizePixel() != 
mpOutputDevice->GetOutputSizePixel())
 {
-
mpPreRenderDevice->SetOutputSizePixel(mrOutputDevice.GetOutputSizePixel());
+
mpPreRenderDevice->SetOutputSizePixel(mpOutputDevice->GetOutputSizePixel());
 }
 
 // Also compare the MapModes for zoom/scroll changes
-if(mpPreRenderDevice->GetMapMode() != mrOutputDevice.GetMapMode())
+if(mpPreRenderDevice->GetMapMode() != mpOutputDevice->GetMapMode())
 {
-mpPreRenderDevice->SetMapMode(mrOutputDevice.GetMapMode());
+mpPreRenderDevice->SetMapMode(mpOutputDevice->GetMapMode());
 }
 
 // #i29186#
-mpPreRenderDevice->SetDrawMode(mrOutputDevice.GetDrawMode());
-mpPreRenderDevice->SetSettings(mrOutputDevice.GetSettings());
+mpPreRenderDevice->SetDrawMode(mpOutputDevice->GetDrawMode());
+mpPreRenderDevice->SetSettings(mpOutputDevice->GetSettings());
 }
 
 void SdrPreRenderDevice::OutputPreRenderDevice(const 

[Libreoffice-commits] core.git: solenv/bin

[Norbert Thiebaud]

 solenv/bin/macosx-codesign-app-bundle |   47 ++
 1 file changed, 37 insertions(+), 10 deletions(-)

New commits:
commit a332bb9a6cc19f0c212892b3f304583338b0a094
Author: Norbert Thiebaud 
Date:   Sat Mar 18 09:43:47 2017 -0500

codesigning script for macosx compained about double signing

Release build of 5.3.2.1 failed in codesign
apparently LibreOfficePython.framework was being signed more than
once, which cause codesign to fail and due to a recent
patch to harden the codesign wrapper, the build itself to fail

This does not address why some part are signed multiple time
but merely tell codesign to ignore the issue and just sign

This also fix a bash un-initialize variable warning and
capture output of codesign in case of error to be able to diagnose
things.

Change-Id: Ibd6752702feb2bdf5163ac30ed7a3fd9c86f961c
Reviewed-on: https://gerrit.libreoffice.org/35407
Tested-by: Jenkins 
Reviewed-by: Norbert Thiebaud 

diff --git a/solenv/bin/macosx-codesign-app-bundle 
b/solenv/bin/macosx-codesign-app-bundle
index 39d87246a92f..f5ccff1475f1 100755
--- a/solenv/bin/macosx-codesign-app-bundle
+++ b/solenv/bin/macosx-codesign-app-bundle
@@ -26,7 +26,7 @@ for V in \
 done
 
 APP_BUNDLE="$1"
-
+entitlements=
 if test -n "$ENABLE_MACOSX_SANDBOX"; then
 # In a sandboxed build executables need the entitlements
 entitlements="--entitlements $BUILDDIR/lo.xcent"
@@ -48,7 +48,11 @@ fi
 find -d "$APP_BUNDLE" \( -name '*.jnilib' \) ! -type l |
 while read file; do
 id=`echo ${file#${APP_BUNDLE}/Contents/} | sed -e 's,/,.,g'`
-codesign --verbose --identifier=$MACOSX_BUNDLE_IDENTIFIER.$id --sign 
"$MACOSX_CODESIGNING_IDENTITY" "$file" || exit 1
+codesign --verbose --force --identifier=$MACOSX_BUNDLE_IDENTIFIER.$id 
--sign "$MACOSX_CODESIGNING_IDENTITY" "$file" > "/tmp/codesign_$(basename 
"$file").log" 2>&1
+if [ "$?" != "0" ] ; then
+   exit 1
+fi
+rm "/tmp/codesign_$(basename "$file").log"
 done
 
 # Sign dylibs
@@ -63,7 +67,11 @@ find "$APP_BUNDLE" \( -name '*.dylib' -or -name '*.dylib.*' 
-or -name '*.so' \
 $other_files \) ! -type l |
 while read file; do
 id=`echo ${file#${APP_BUNDLE}/Contents/} | sed -e 's,/,.,g'`
-codesign --verbose --identifier=$MACOSX_BUNDLE_IDENTIFIER.$id --sign 
"$MACOSX_CODESIGNING_IDENTITY" "$file" || exit 1
+codesign --verbose --force --identifier=$MACOSX_BUNDLE_IDENTIFIER.$id 
--sign "$MACOSX_CODESIGNING_IDENTITY" "$file" > "/tmp/codesign_$(basename 
"$file").log" 2>&1
+if [ "$?" != "0" ] ; then
+   exit 1
+fi
+rm "/tmp/codesign_$(basename "$file").log"
 done
 
 # Sign included bundles. First .app ones (i.e. the Python.app inside
@@ -75,7 +83,11 @@ while read app; do
 fn=${fn%.*}
 # Assume the app has a XML (and not binary) Info.plist
 id=`grep -A 1 'CFBundleIdentifier' $app/Contents/Info.plist | 
tail -1 | sed -e 's,.*,,' -e 's,.*,,'`
-codesign --verbose --identifier=$id --sign "$MACOSX_CODESIGNING_IDENTITY" 
$entitlements "$app" || exit 1
+codesign --verbose --force --identifier=$id --sign 
"$MACOSX_CODESIGNING_IDENTITY" $entitlements "$app" > "/tmp/codesign_${fn}.log" 
2>&1
+if [ "$?" != "0" ] ; then
+   exit 1
+fi
+rm "/tmp/codesign_${fn}.log"
 done
 
 # Then .framework ones. Again, be generic just for kicks.
@@ -88,8 +100,12 @@ while read framework; do
 if test ! -L "$version" -a -d "$version"; then
# Assume the framework has a XML (and not binary) Info.plist
id=`grep -A 1 'CFBundleIdentifier' 
$version/Resources/Info.plist | tail -1 | sed -e 's,.*,,' -e 
's,.*,,'`
-codesign --verbose --identifier=$id --sign 
"$MACOSX_CODESIGNING_IDENTITY" "$version" || exit 1
-fi
+codesign --verbose --force --identifier=$id --sign 
"$MACOSX_CODESIGNING_IDENTITY" "$version" > "/tmp/codesign_${fn}.log" 2>&1
+   if [ "$?" != "0" ] ; then
+   exit 1
+   fi
+   rm "/tmp/codesign_${fn}.log"
+   fi
 done
 done
 
@@ -97,7 +113,11 @@ done
 
 find "$APP_BUNDLE" -name '*.mdimporter' -type d |
 while read bundle; do
-codesign --verbose --prefix=$MACOSX_BUNDLE_IDENTIFIER. --sign 
"$MACOSX_CODESIGNING_IDENTITY" "$bundle" || exit 1
+codesign --verbose --force --prefix=$MACOSX_BUNDLE_IDENTIFIER. --sign 
"$MACOSX_CODESIGNING_IDENTITY" "$bundle" > "/tmp/codesign_$(basename 
"${bundle}").log" 2>&1
+if [ "$?" != "0" ] ; then
+   exit 1
+fi
+rm "/tmp/codesign_$(basename "${bundle}").log"
 done
 
 # Sign executables
@@ -109,7 +129,11 @@ while read file; do
;;
*)
id=`echo ${file#${APP_BUNDLE}/Contents/} | sed -e 's,/,.,g'`
-   codesign --force --verbose 
--identifier=$MACOSX_BUNDLE_IDENTIFIER.$id --sign 
"$MACOSX_CODESIGNING_IDENTITY" $entitlements "$file" || exit 1
+   

[Libreoffice-bugs] [Bug 106695] German translation mistake "Text Absatz" instead of " Textabsatz"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106695

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Xisco Faulí  ---
Closing as RESOLVED WORKSFORME as per comment 1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106702] FILESAVE: PDF: Only first page's background is exported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106702

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected,
   ||bibisectRequest, regression
 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Regression introduced in range
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=5381db92dea6c2e11af49a48fa0b72af666f3f32..76ec54e8c9f3580450bca85236a4f5af0c328588

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106702] New: FILESAVE: PDF: Only first page's background is exported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106702

Bug ID: 106702
   Summary: FILESAVE: PDF: Only first page's background is
exported
   Product: LibreOffice
   Version: 5.3.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps to reproduce:
1. Open attachment 76212 from bug 62052
2. Export to PDF

Observed behaviour: Only the first page's background is exported.


Reproduced in

Version: 5.4.0.0.alpha0+
Build ID: 4ba483beccc99d336d0e0bec47b5fd6823b16c16
CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/new-vcl-scheduler' - 78 commits - avmedia/source basctl/source basic/source bridges/source cli_ure/source comphelper/source compilerplugins/clang config

[Jan-Marek Glogowski]

Rebased ref, commits from common ancestor:
commit bb385ccd0ae85073e8af44064ca474adfb7fb80a
Author: Jan-Marek Glogowski 
Date:   Wed Sep 14 18:17:18 2016 +0200

Don't poll busy documents via idle task

Creates a very busy idle-loop, for non-task work like mail merge.

Change-Id: If7be82e4675008f23e6f4f6be5c40df40a231a8b

diff --git a/sw/source/core/doc/DocumentTimerManager.cxx 
b/sw/source/core/doc/DocumentTimerManager.cxx
index 83ce6fe2dce9..4a9855570bd6 100644
--- a/sw/source/core/doc/DocumentTimerManager.cxx
+++ b/sw/source/core/doc/DocumentTimerManager.cxx
@@ -40,44 +40,44 @@ namespace sw
 DocumentTimerManager::DocumentTimerManager( SwDoc& i_rSwdoc ) : m_rDoc( 
i_rSwdoc ),
 
mbStartIdleTimer( false ),
 
mIdleBlockCount( 0 ),
-
maIdle("DocumentTimerManagerIdleTimer")
+maDocIdle( 
i_rSwdoc )
 {
-maIdle.SetPriority( TaskPriority::LOWEST );
-maIdle.SetInvokeHandler( LINK( this, DocumentTimerManager, DoIdleJobs) );
-maIdle.SetDebugName( "sw::DocumentTimerManager maIdle" );
+maDocIdle.SetPriority( TaskPriority::LOWEST );
+maDocIdle.SetInvokeHandler( LINK( this, DocumentTimerManager, DoIdleJobs) 
);
+maDocIdle.SetDebugName( "sw::DocumentTimerManager maDocIdle" );
 }
 
 void DocumentTimerManager::StartIdling()
 {
 mbStartIdleTimer = true;
 if( !mIdleBlockCount )
-maIdle.Start();
+maDocIdle.Start();
 }
 
 void DocumentTimerManager::StopIdling()
 {
 mbStartIdleTimer = false;
-maIdle.Stop();
+maDocIdle.Stop();
 }
 
 void DocumentTimerManager::BlockIdling()
 {
-maIdle.Stop();
+maDocIdle.Stop();
 ++mIdleBlockCount;
 }
 
 void DocumentTimerManager::UnblockIdling()
 {
 --mIdleBlockCount;
-if( !mIdleBlockCount && mbStartIdleTimer && !maIdle.IsActive() )
-maIdle.Start();
+if( !mIdleBlockCount && mbStartIdleTimer && !maDocIdle.IsActive() )
+maDocIdle.Start();
 }
 
 void DocumentTimerManager::StartBackgroundJobs()
 {
 // Trigger DoIdleJobs(), asynchronously.
-if (!maIdle.IsActive()) //fdo#73165 if the timer is already running don't 
restart from 0
-maIdle.Start();
+if (!maDocIdle.IsActive()) //fdo#73165 if the timer is already running 
don't restart from 0
+maDocIdle.Start();
 }
 
 IMPL_LINK( DocumentTimerManager, DoIdleJobs, Timer*, pIdle, void )
@@ -96,10 +96,7 @@ IMPL_LINK( DocumentTimerManager, DoIdleJobs, Timer*, pIdle, 
void )
 for(SwViewShell& rSh : pShell->GetRingContainer())
 {
 if( rSh.ActionPend() )
-{
-pIdle->Start();
 return;
-}
 }
 
 if( pTmpRoot->IsNeedGrammarCheck() )
@@ -119,9 +116,7 @@ IMPL_LINK( DocumentTimerManager, DoIdleJobs, Timer*, pIdle, 
void )
 if ((*pLayIter)->IsIdleFormat())
 {
 (*pLayIter)->GetCurrShell()->LayoutIdle();
-
 // Defer the remaining work.
-pIdle->Start();
 return;
 }
 }
@@ -135,11 +130,8 @@ IMPL_LINK( DocumentTimerManager, DoIdleJobs, Timer*, 
pIdle, void )
 /* && !pStartSh->GetViewOptions()->IsFieldName()*/ )
 {
 if ( 
m_rDoc.getIDocumentFieldsAccess().GetUpdateFields().IsInUpdateFields() ||
- m_rDoc.getIDocumentFieldsAccess().IsExpFieldsLocked() )
-{
-pIdle->Start();
+  m_rDoc.getIDocumentFieldsAccess().IsExpFieldsLocked() )
 return;
-}
 
 //  Action brackets!
 
m_rDoc.getIDocumentFieldsAccess().GetUpdateFields().SetInUpdateFields( true );
@@ -167,6 +159,7 @@ IMPL_LINK( DocumentTimerManager, DoIdleJobs, Timer*, pIdle, 
void )
 if( pModLogFile && 1 != (long)pModLogFile )
 delete pModLogFile, static_cast(pModLogFile) = 1;
 #endif
+pIdle->Stop();
 }
 
 DocumentTimerManager::~DocumentTimerManager() {}
diff --git a/sw/source/core/inc/DocumentTimerManager.hxx 
b/sw/source/core/inc/DocumentTimerManager.hxx
index da4b9e4b30fd..698762ab087e 100644
--- a/sw/source/core/inc/DocumentTimerManager.hxx
+++ b/sw/source/core/inc/DocumentTimerManager.hxx
@@ -21,8 +21,8 @@
 #define INCLUDED_SW_SOURCE_CORE_INC_DOCUMENTTIMERMANAGER_HXX
 
 #include 
+#include 
 
-#include 
 #include 
 #include 
 
@@ -47,7 +47,6 @@ public:
 
 void StartBackgroundJobs() override;
 
-// Our own 'IdleTimer' calls the following method
 DECL_LINK( DoIdleJobs, Timer *, void );
 
 virtual ~DocumentTimerManager() override;
@@ -61,7 +60,7 @@ private:
 
 bool mbStartIdleTimer; //< idle timer mode start/stop
 sal_Int32 mIdleBlockCount;
-Idle  maIdle;
+SwDocIdle maDocIdle;
 };
 
 }
commit 

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
Bug 103182 depends on bug 106645, which changed state.

Bug 106645 Summary: [GTK3] libreoffice scrollbar with gtk3 is too wide.
https://bugs.documentfoundation.org/show_bug.cgi?id=106645

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] Pre-released 5.3.2.1, no Win x64 available.

[m.a.riosv]

Hi,

there is pre-release build LibreOffice_5.3.2.1_Win_x86.msi  2017-03-19
03:03, but not for Win_x64.

Regards.
Miguel Ángel



--
View this message in context: 
http://nabble.documentfoundation.org/Pre-released-5-3-2-1-no-Win-x64-available-tp4210807.html
Sent from the QA mailing list archive at Nabble.com.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-commits] core.git: 2 commits - vcl/unx

[Caolán McNamara]

 vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx |  453 --
 1 file changed, 429 insertions(+), 24 deletions(-)

New commits:
commit 9b7c35b4b7fd5a5347a3602f110d78e1019a54e9
Author: Caolán McNamara 
Date:   Wed Mar 22 16:17:14 2017 +

Related: tdf#106645 make gtk3 scrollbar themes with arrows work

properly, e.g. breeze-dark has arrows

Change-Id: Ic59c0de3fb385adc2f8fddc605edd7498230d5fb

diff --git a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx 
b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
index 8ae88ac9ac75..731f5a83b8a8 100644
--- a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
@@ -456,8 +456,6 @@ void GtkSalGraphics::PaintScrollbar(GtkStyleContext 
*context,
 RectanglearrowRect;
 gintslider_width = 0;
 gintstepper_size = 0;
-gintstepper_spacing = 0;
-ginttrough_border = 0;
 
 // make controlvalue rectangles relative to area
 thumbRect.Move( -rControlRectangle.Left(), -rControlRectangle.Top() );
@@ -480,6 +478,10 @@ void GtkSalGraphics::PaintScrollbar(GtkStyleContext 
*context,
 QuerySize(mpHScrollbarTroughStyle, aSize);
 QuerySize(mpHScrollbarSliderStyle, aSize);
 slider_side = aSize.Height();
+gtk_style_context_get(mpHScrollbarButtonStyle,
+  
gtk_style_context_get_state(mpHScrollbarButtonStyle),
+  "min-height", _width,
+  "min-width", _size, nullptr);
 }
 else
 {
@@ -488,15 +490,12 @@ void GtkSalGraphics::PaintScrollbar(GtkStyleContext 
*context,
 QuerySize(mpVScrollbarTroughStyle, aSize);
 QuerySize(mpVScrollbarSliderStyle, aSize);
 slider_side = aSize.Width();
+gtk_style_context_get(mpVScrollbarButtonStyle,
+  
gtk_style_context_get_state(mpVScrollbarButtonStyle),
+  "min-width", _width,
+  "min-height", _size, nullptr);
 }
 
-// Grab some button style attributes
-gtk_style_context_get_style( context,
- "slider_width", _width,
- "stepper_size", _size,
- "trough_border", _border,
- "stepper_spacing", _spacing, 
nullptr );
-
 gboolean has_forward;
 gboolean has_forward2;
 gboolean has_backward;
@@ -522,22 +521,22 @@ void GtkSalGraphics::PaintScrollbar(GtkStyleContext 
*context,
 
 if ( has_backward )
 {
-button12BoundRect.Move( stepper_size - trough_border,
+button12BoundRect.Move( stepper_size,
 (scrollbarRect.GetHeight() - 
slider_width) / 2 );
 }
 
-button11BoundRect.Move( trough_border, (scrollbarRect.GetHeight() 
- slider_width) / 2 );
+button11BoundRect.Move( 0, (scrollbarRect.GetHeight() - 
slider_width) / 2 );
 button11BoundRect.SetSize( Size( stepper_size, slider_width ) );
 button12BoundRect.SetSize( Size( stepper_size, slider_width ) );
 
 if ( has_backward2 )
 {
-button22BoundRect.Move( stepper_size+(trough_border+1)/2, 
(scrollbarRect.GetHeight() - slider_width) / 2 );
-button21BoundRect.Move( (trough_border+1)/2, 
(scrollbarRect.GetHeight() - slider_width) / 2 );
+button22BoundRect.Move( stepper_size, 
(scrollbarRect.GetHeight() - slider_width) / 2 );
+button21BoundRect.Move( 0, (scrollbarRect.GetHeight() - 
slider_width) / 2 );
 }
 else
 {
-button22BoundRect.Move( (trough_border+1)/2, 
(scrollbarRect.GetHeight() - slider_width) / 2 );
+button22BoundRect.Move( 0, (scrollbarRect.GetHeight() - 
slider_width) / 2 );
 }
 
 button21BoundRect.SetSize( Size( stepper_size, slider_width ) );
@@ -558,20 +557,20 @@ void GtkSalGraphics::PaintScrollbar(GtkStyleContext 
*context,
 if ( has_backward )
 {
 button12BoundRect.Move( (scrollbarRect.GetWidth() - 
slider_width) / 2,
-stepper_size + trough_border );
+stepper_size );
 }
-button11BoundRect.Move( (scrollbarRect.GetWidth() - slider_width) 
/ 2, trough_border );
+button11BoundRect.Move( (scrollbarRect.GetWidth() - slider_width) 
/ 2, 0 );
 button11BoundRect.SetSize( Size( slider_width, stepper_size ) );
 button12BoundRect.SetSize( Size( slider_width, stepper_size ) );
 
 if ( has_backward2 )
 {
-

[Libreoffice-bugs] [Bug 106686] Restart the numbering footnotes at the beginning of each chapter but there is no option to add chapter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106686

Monika Siwek  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---
 Ever confirmed|0   |1

--- Comment #2 from Monika Siwek  ---
Hello,
I don't want to reset page numbering, but I want to reset footnotes numbering.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs