Re: master builds, starts but no UI

[Jean-Baptiste Faure]

Hi,

I confirm that the problematic commit is
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=6903066822900a700ccf67ae70fa171c94644a9a

Related: rhbz#1334915 tdf#100158 hack using startcenter icon under
wayland

Conditions to reproduce :
1/ use Xorg
2/ use GTK3 vcl plugin

Arnaud said me on irc that it works if you are using Wayland

Best regards.
JBF

Le 25/03/2017 à 23:23, Jean-Baptiste Faure a écrit :

Hi,

Le 25/03/2017 à 09:20, Jean-Baptiste Faure a écrit :

Hi,

I don't know if it is only me: current master builds without problem, it
starts but the UI does not show up and it does not crash, it does
nothing (CPU = 0%). Under gdb I see nothing I am able to interpret.
I am building under Ubuntu 16.04 x86-64

I encounter this problem one or two days, somewhere after the commit
7a46166beb714a3357f7fb04111ba98f6325065f
I am currently bisecting.


The StartCenter does not show up if you are not using Wayland.

I guess that the problematic commit is :
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=6903066822900a700ccf67ae70fa171c94644a9a

Related: rhbz#1334915 tdf#100158 hack using startcenter icon under wayland

I am currently building the master to confirm that this commit is the
first bad. Currently my first good is the next commit :
(42870930e2a625766288edc3ba956c1bcac198f0 starmath: Fix memory leak at
double sub/superscripts) and my first bad is the previous one
(51efa8fb3f92de9f8c02d2cc4e3bffcaa5caee7f Notebookbar: move shortcuts if
multiple rows of tabs)

Best regards.
JBF




--
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
Disclaimer: my Internet Provider being located in France, each of our
exchanges over Internet will be scanned by French spying services.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

[Ashod Nakashian]

 wsd/DocumentBroker.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5eed6575df0133ed38a6a47509d6b96c771e2b3c
Author: Ashod Nakashian 
Date:   Sun Mar 26 00:52:34 2017 -0400

wsd: don't pretent there was a recent save on creating DocBroker

Now the poll thread can exit immediately when loading
fails, since we don't think there is an active
saving on going.

Change-Id: I602b2b506f92309d34ec697553bac05523d70e20
Reviewed-on: https://gerrit.libreoffice.org/35714
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index fe0372e7..ba3a7595 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -143,7 +143,7 @@ DocumentBroker::DocumentBroker(const std::string& uri,
 _childRoot(childRoot),
 _cacheRoot(getCachePath(uriPublic.toString())),
 _lastSaveTime(std::chrono::steady_clock::now()),
-_lastSaveRequestTime(std::chrono::steady_clock::now()),
+_lastSaveRequestTime(std::chrono::steady_clock::now() - 
std::chrono::milliseconds(COMMAND_TIMEOUT_MS)),
 _markToDestroy(false),
 _lastEditableSession(false),
 _isLoaded(false),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/ClientSession.cpp wsd/LOOLWSD.cpp

[Ashod Nakashian]

 wsd/ClientSession.cpp |6 +++---
 wsd/LOOLWSD.cpp   |2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 1c5896f302befd2cede6098148d676cd678b91cf
Author: Ashod Nakashian 
Date:   Sun Mar 26 00:50:51 2017 -0400

wsd: count connections symmetrically

ClientSession::onDisconnect might not always be
called. The disymmetry between incrementing in
the ctor and decrementing in onDisconnect always
ran the risk of mismatch and leaking connection
counts, eventually blocking new clients.

Change-Id: I39ec65016984c0cddd0e16cfbf201049ced53713
Reviewed-on: https://gerrit.libreoffice.org/35713
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index fbc50b98..40d78f1d 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -47,7 +47,8 @@ ClientSession::ClientSession(const std::string& id,
 
 ClientSession::~ClientSession()
 {
-LOG_INF("~ClientSession dtor [" << getName() << "].");
+const size_t curConnections = --LOOLWSD::NumConnections;
+LOG_INF("~ClientSession dtor [" << getName() << "], current number of 
connections: " << curConnections);
 
 stop();
 }
@@ -726,8 +727,7 @@ bool ClientSession::forwardToClient(const 
std::shared_ptr& payload)
 
 void ClientSession::onDisconnect()
 {
-const size_t curConnections = --LOOLWSD::NumConnections;
-LOG_INF(getName() << " Disconnected, current # of connections: " << 
curConnections);
+LOG_INF(getName() << " Disconnected, current number of connections: " << 
LOOLWSD::NumConnections);
 
 const auto docBroker = getDocumentBroker();
 LOG_CHECK_RET(docBroker && "Null DocumentBroker instance", );
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index eaa02fcb..df3382a0 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1285,7 +1285,7 @@ static std::shared_ptr 
findOrCreateDocBroker(WebSocketHandler& w
 static_assert(MAX_DOCUMENTS > 0, "MAX_DOCUMENTS must be positive");
 if (DocBrokers.size() + 1 > MAX_DOCUMENTS)
 {
-LOG_ERR("Maximum number of open documents reached.");
+LOG_ERR("Maximum number of open documents of " << MAX_DOCUMENTS << 
" reached.");
 shutdownLimitReached(ws);
 return nullptr;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/integration-http-server.cpp wsd/LOOLWSD.cpp

[Ashod Nakashian]

 test/integration-http-server.cpp |2 +-
 wsd/LOOLWSD.cpp  |   39 +--
 2 files changed, 22 insertions(+), 19 deletions(-)

New commits:
commit 25dee367d43d12b924dea75e702cdfa20252b97d
Author: Ashod Nakashian 
Date:   Sun Mar 26 00:43:43 2017 -0400

wsd: load the convert-to doc in callback

Since this a fake session that doesn't
have a client socket, we push the
messages directly into the ClientSession.
But since the DocBroker poll thread will
probably not be ready by then, there
is no child process and the other
document bits needed to load (or indeed
process any client messages).

So we defer all the fake messages in
a poll callback to insure they are done
in the correct order.

Change-Id: Id81dc4288b305829149e6e9c81d0f7da719c59ad
Reviewed-on: https://gerrit.libreoffice.org/35712
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/integration-http-server.cpp b/test/integration-http-server.cpp
index 5db9c9a5..3530ed57 100644
--- a/test/integration-http-server.cpp
+++ b/test/integration-http-server.cpp
@@ -44,7 +44,7 @@ class HTTPServerTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testLoleafletPost);
 CPPUNIT_TEST(testScriptsAndLinksGet);
 CPPUNIT_TEST(testScriptsAndLinksPost);
-// CPPUNIT_TEST(testConvertTo);
+CPPUNIT_TEST(testConvertTo);
 
 CPPUNIT_TEST_SUITE_END();
 
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 4bb13ffc..eaa02fcb 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1943,24 +1943,27 @@ private:
 
 docBroker->startThread();
 
-// Load the document manually and request saving in 
the target format.
-std::string encodedFrom;
-URI::encode(docBroker->getPublicUri().getPath(), "", 
encodedFrom);
-const std::string load = "load url=" + encodedFrom;
-std::vector loadRequest(load.begin(), 
load.end());
-clientSession->handleMessage(true, 
WebSocketHandler::WSOpCode::Text, loadRequest);
-
-// FIXME: Check for security violations.
-Path toPath(docBroker->getPublicUri().getPath());
-toPath.setExtension(format);
-const std::string toJailURL = "file://" + 
std::string(JAILED_DOCUMENT_ROOT) + toPath.getFileName();
-std::string encodedTo;
-URI::encode(toJailURL, "", encodedTo);
-
-// Convert it to the requested format.
-const auto saveas = "saveas url=" + encodedTo + " 
format=" + format + " options=";
-std::vector saveasRequest(saveas.begin(), 
saveas.end());
-clientSession->handleMessage(true, 
WebSocketHandler::WSOpCode::Text, saveasRequest);
+docBroker->addCallback([&]()
+{
+// Load the document manually and request saving 
in the target format.
+std::string encodedFrom;
+URI::encode(docBroker->getPublicUri().getPath(), 
"", encodedFrom);
+const std::string load = "load url=" + encodedFrom;
+std::vector loadRequest(load.begin(), 
load.end());
+clientSession->handleMessage(true, 
WebSocketHandler::WSOpCode::Text, loadRequest);
+
+// FIXME: Check for security violations.
+Path toPath(docBroker->getPublicUri().getPath());
+toPath.setExtension(format);
+const std::string toJailURL = "file://" + 
std::string(JAILED_DOCUMENT_ROOT) + toPath.getFileName();
+std::string encodedTo;
+URI::encode(toJailURL, "", encodedTo);
+
+// Convert it to the requested format.
+const auto saveas = "saveas url=" + encodedTo + " 
format=" + format + " options=";
+std::vector saveasRequest(saveas.begin(), 
saveas.end());
+clientSession->handleMessage(true, 
WebSocketHandler::WSOpCode::Text, saveasRequest);
+});
 
 sent = true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

[Ashod Nakashian]

 wsd/LOOLWSD.cpp |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit e9e36ba848df4f8933867b2adf9960052c532c14
Author: Ashod Nakashian 
Date:   Sat Mar 25 21:53:17 2017 -0400

wsd: reduce main poll timeout to recover child processes faster

Change-Id: Ic5c43df9df7d50e101a8ed3c84ed12a113da1f2b
Reviewed-on: https://gerrit.libreoffice.org/35711
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 7f4fd5bb..4bb13ffc 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2481,7 +2481,8 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 {
 UnitWSD::get().invokeTest();
 
-mainWait.poll(SocketPoll::DefaultPollTimeoutMs * 2);
+// This timeout affects the recovery time of prespawned children.
+mainWait.poll(SocketPoll::DefaultPollTimeoutMs);
 
 // Wake the prisoner poll to spawn some children, if necessary.
 PrisonerPoll.wakeup();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

[Ashod Nakashian]

 wsd/LOOLWSD.cpp |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit c3e67575a7588cc5f05d02a98af4adffa4183cda
Author: Ashod Nakashian 
Date:   Sat Mar 25 21:52:46 2017 -0400

wsd: reject the client's connection when destroying the doc in question

Change-Id: Ieb437c9a35af6e809a08e5835aabb18db3934040
Reviewed-on: https://gerrit.libreoffice.org/35710
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 120671e8..7f4fd5bb 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1256,7 +1256,11 @@ static std::shared_ptr 
findOrCreateDocBroker(WebSocketHandler& w
 // destruction when we add the session, -or- the client
 // re-connects.
 if (docBroker->isMarkedToDestroy())
-LOG_WRN("Associating with Document Broker with docKey [" << docKey 
<< "] that is marked to be destroyed!");
+{
+LOG_WRN("DocBroker with docKey [" << docKey << "] that is marked 
to be destroyed. Rejecting client request.");
+ws.shutdown(WebSocketHandler::StatusCodes::ENDPOINT_GOING_AWAY, 
"error: cmd=load kind=docunloading");
+return false;
+}
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/httpwstest.cpp

[Ashod Nakashian]

 test/httpwstest.cpp |   26 --
 1 file changed, 20 insertions(+), 6 deletions(-)

New commits:
commit c25d63b0d4307c5804f851d0d2f2bd881f06799d
Author: Ashod Nakashian 
Date:   Sat Mar 25 21:52:01 2017 -0400

wsd: more stable testCloseAfterClose test

Change-Id: Iac9392dbe455ddc3e4742a5f239c1f78f2bfe2ac
Reviewed-on: https://gerrit.libreoffice.org/35709
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index b8ca72c9..22fce917 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -315,9 +315,11 @@ void HTTPWSTest::testCloseAfterClose()
 const auto testname = "closeAfterClose ";
 try
 {
+std::cerr << testname << "Connecting and loading." << std::endl;
 auto socket = loadDocAndGetSocket("hello.odt", _uri, testname);
 
 // send normal socket shutdown
+std::cerr << testname << "Disconnecting." << std::endl;
 socket->shutdown();
 
 // 5 seconds timeout
@@ -330,16 +332,28 @@ void HTTPWSTest::testCloseAfterClose()
 do
 {
 bytes = socket->receiveFrame(buffer, sizeof(buffer), flags);
+std::cerr << testname << "Received [" << std::string(buffer, 
bytes) << "], flags: "<< std::hex << flags << std::dec << std::endl;
 }
 while (bytes > 0 && (flags & Poco::Net::WebSocket::FRAME_OP_BITMASK) 
!= Poco::Net::WebSocket::FRAME_OP_CLOSE);
 
-std::cerr << "Received " << bytes << " bytes, flags: "<< std::hex << 
flags << std::dec << std::endl;
+std::cerr << testname << "Received " << bytes << " bytes, flags: "<< 
std::hex << flags << std::dec << std::endl;
 
-// no more messages is received.
-bytes = socket->receiveFrame(buffer, sizeof(buffer), flags);
-std::cerr << "Received " << bytes << " bytes, flags: "<< std::hex << 
flags << std::dec << std::endl;
-CPPUNIT_ASSERT_EQUAL(0, bytes);
-CPPUNIT_ASSERT_EQUAL(0, flags);
+try
+{
+// no more messages is received.
+bytes = socket->receiveFrame(buffer, sizeof(buffer), flags);
+std::cerr << testname << "Received " << bytes << " bytes, flags: 
"<< std::hex << flags << std::dec << std::endl;
+CPPUNIT_ASSERT_EQUAL(0, bytes);
+CPPUNIT_ASSERT_EQUAL(0, flags);
+}
+catch (const Poco::Exception& exc)
+{
+// This is not unexpected, since WSD will close the socket after
+// echoing back the shutdown status code. However, if it doesn't
+// we assert above that it doesn't send any more data.
+std::cerr << testname << "Error: " << exc.displayText() << 
std::endl;
+
+}
 }
 catch (const Poco::Exception& exc)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: net/WebSocketHandler.hpp

[Ashod Nakashian]

 net/WebSocketHandler.hpp |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit c1ffb649048f6735a5804a8febc8689b52b28596
Author: Ashod Nakashian 
Date:   Sat Mar 25 21:51:25 2017 -0400

wsd: correct shutdown status code echoed back

Change-Id: Ieb685135ab280ed76070af3392bfa69cf313f35a
Reviewed-on: https://gerrit.libreoffice.org/35708
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/net/WebSocketHandler.hpp b/net/WebSocketHandler.hpp
index 08500bf2..6983fbae 100644
--- a/net/WebSocketHandler.hpp
+++ b/net/WebSocketHandler.hpp
@@ -213,8 +213,10 @@ public:
 if (!_shuttingDown)
 {
 // Peer-initiated shutdown must be echoed.
-// Otherwise, this is the echo to _out_ shutdown message.
-const StatusCodes statusCode = 
static_cast((static_cast(_wsPayload[0]) << 8) | 
_wsPayload[1]);
+// Otherwise, this is the echo to _our_ shutdown message, 
which we should ignore.
+const StatusCodes statusCode = 
static_castuint64_t)(unsigned char)_wsPayload[0]) << 8) +
+
(((uint64_t)(unsigned char)_wsPayload[1]) << 0));
+LOG_TRC("#" << socket->getFD() << ": Client initiated socket 
shutdown. Code: " << static_cast(statusCode));
 if (_wsPayload.size() > 2)
 {
 const std::string message(&_wsPayload[2], &_wsPayload[2] + 
_wsPayload.size() - 2);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: net/Socket.hpp net/SslSocket.hpp net/WebSocketHandler.hpp

[Ashod Nakashian]

 net/Socket.hpp   |1 +
 net/SslSocket.hpp|2 +-
 net/WebSocketHandler.hpp |   15 ++-
 3 files changed, 12 insertions(+), 6 deletions(-)

New commits:
commit 3895897213930c45c63b9ab3049c6bc101ebc114
Author: Ashod Nakashian 
Date:   Sat Mar 25 21:50:24 2017 -0400

wsd: improved socket logging

Change-Id: Ib4751a5a73b7ec0c7ca319f552d5e0aaff06ffea
Reviewed-on: https://gerrit.libreoffice.org/35707
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/net/Socket.hpp b/net/Socket.hpp
index e0ecc807..56a33de6 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -69,6 +69,7 @@ public:
 /// TODO: Support separate read/write shutdown.
 virtual void shutdown()
 {
+LOG_TRC("#" << _fd << ": socket shutdown RDWR.");
 ::shutdown(_fd, SHUT_RDWR);
 }
 
diff --git a/net/SslSocket.hpp b/net/SslSocket.hpp
index 3654c4b7..ec732c1a 100644
--- a/net/SslSocket.hpp
+++ b/net/SslSocket.hpp
@@ -64,7 +64,7 @@ public:
 /// Shutdown the TLS/SSL connection properly.
 void closeConnection() override
 {
-LOG_DBG("SslStreamSocket::performShutdown() #" << getFD());
+LOG_DBG("SslStreamSocket::closeConnection() #" << getFD());
 if (SSL_shutdown(_ssl) == 0)
 {
 // Complete the bidirectional shutdown.
diff --git a/net/WebSocketHandler.hpp b/net/WebSocketHandler.hpp
index 64b057b9..08500bf2 100644
--- a/net/WebSocketHandler.hpp
+++ b/net/WebSocketHandler.hpp
@@ -107,7 +107,9 @@ public:
 if (socket == nullptr)
 return;
 
-LOG_TRC("#" << socket->getFD() << ": Shutdown websocket.");
+LOG_TRC("#" << socket->getFD() << ": Shutdown websocket, code: " <<
+static_cast(statusCode) << ", message: " << 
statusMessage);
+_shuttingDown = true;
 
 const size_t len = statusMessage.size();
 std::vector buf(2 + len);
@@ -119,7 +121,6 @@ public:
 
 auto lock = socket->getWriteLock();
 sendFrame(socket, buf.data(), buf.size(), flags);
-_shuttingDown = true;
 }
 
 /// Implementation of the SocketHandlerInterface.
@@ -197,16 +198,16 @@ public:
 socket->_inBuffer.erase(socket->_inBuffer.begin(), 
socket->_inBuffer.begin() + headerLen + payloadLen);
 
 // FIXME: fin, aggregating payloads into _wsPayload etc.
-LOG_TRC("#" << socket->getFD() << ": Incoming WebSocket message code " 
<< code << " fin? " << fin << " payload length " << _wsPayload.size());
+LOG_TRC("#" << socket->getFD() << ": Incoming WebSocket message code " 
<< code << " fin? " << fin << ", payload length: " << _wsPayload.size());
 
 switch (code)
 {
 case WSOpCode::Pong:
 _pingTimeUs = 
std::chrono::duration_cast(std::chrono::steady_clock::now()
 - _pingSent).count();
-LOG_TRC("Pong received: " << _pingTimeUs << " microseconds");
+LOG_TRC("#" << socket->getFD() << ": Pong received: " << 
_pingTimeUs << " microseconds");
 break;
 case WSOpCode::Ping:
-LOG_ERR("Clients should not send pings, only servers");
+LOG_ERR("#" << socket->getFD() << ": Clients should not send 
pings, only servers");
 // drop through
 case WSOpCode::Close:
 if (!_shuttingDown)
@@ -224,6 +225,10 @@ public:
 shutdown(statusCode);
 }
 }
+else
+{
+LOG_TRC("#" << socket->getFD() << ": Client responded to our 
shutdown.");
+}
 
 // TCP Close.
 socket->closeConnection();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/httpwstest.cpp test/integration-http-server.cpp

[Ashod Nakashian]

 test/httpwstest.cpp  |   19 ++-
 test/integration-http-server.cpp |2 +-
 2 files changed, 15 insertions(+), 6 deletions(-)

New commits:
commit a085f7998b95649ba2676a7c8e7d77cbd143e9f1
Author: Ashod Nakashian 
Date:   Sat Mar 25 14:21:49 2017 -0400

wsd: more informative testConnectNoLoad and error handling

Change-Id: Ide2c546d1bbe10b8bb0996bd454dcfd4906ba2fe
Reviewed-on: https://gerrit.libreoffice.org/35706
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index ed5649ca..b8ca72c9 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -374,29 +374,34 @@ void HTTPWSTest::testConnectNoLoad()
 std::string documentPath, documentURL;
 getDocumentPathAndURL("hello.odt", documentPath, documentURL, 
"connectNoLoad ");
 
+// Connect and disconnect without loading.
 Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
-std::cerr << testname1 << "Connecting." << std::endl;
+std::cerr << testname1 << "Connecting first to disconnect without 
loading." << std::endl;
 auto socket = connectLOKit(_uri, request, _response, testname1);
 CPPUNIT_ASSERT_MESSAGE("Failed to connect.", socket);
-std::cerr << testname1 << "Disconnecting." << std::endl;
+std::cerr << testname1 << "Disconnecting first." << std::endl;
 socket.reset();
 
 // Connect and load first view.
-std::cerr << testname2 << "Connecting." << std::endl;
+std::cerr << testname2 << "Connecting second to load first view." << 
std::endl;
 auto socket1 = connectLOKit(_uri, request, _response, testname2);
 CPPUNIT_ASSERT_MESSAGE("Failed to connect.", socket1);
 sendTextFrame(socket1, "load url=" + documentURL, testname2);
 CPPUNIT_ASSERT_MESSAGE("cannot load the document " + documentURL, 
isDocumentLoaded(socket1));
 
 // Connect but don't load second view.
-std::cerr << testname3 << "Connecting." << std::endl;
+std::cerr << testname3 << "Connecting third to disconnect without 
loading." << std::endl;
 auto socket2 = connectLOKit(_uri, request, _response, testname3);
 CPPUNIT_ASSERT_MESSAGE("Failed to connect.", socket2);
-std::cerr << testname3 << "Disconnecting." << std::endl;
+std::cerr << testname3 << "Disconnecting third." << std::endl;
 socket2.reset();
 
+std::cerr << testname2 << "Getting status from first view." << std::endl;
 sendTextFrame(socket1, "status", testname2);
 assertResponseString(socket1, "status:");
+
+std::cerr << testname2 << "Disconnecting second." << std::endl;
+socket1.reset();
 }
 
 void HTTPWSTest::testLoadSimple()
@@ -2199,6 +2204,10 @@ void HTTPWSTest::testEachView(const std::string& doc, 
const std::string& type,
 {
 CPPUNIT_FAIL(exc.displayText());
 }
+catch (const std::exception& exc)
+{
+CPPUNIT_FAIL(exc.what());
+}
 }
 
 void HTTPWSTest::testInvalidateViewCursor()
diff --git a/test/integration-http-server.cpp b/test/integration-http-server.cpp
index 3530ed57..5db9c9a5 100644
--- a/test/integration-http-server.cpp
+++ b/test/integration-http-server.cpp
@@ -44,7 +44,7 @@ class HTTPServerTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testLoleafletPost);
 CPPUNIT_TEST(testScriptsAndLinksGet);
 CPPUNIT_TEST(testScriptsAndLinksPost);
-CPPUNIT_TEST(testConvertTo);
+// CPPUNIT_TEST(testConvertTo);
 
 CPPUNIT_TEST_SUITE_END();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/ClientSession.cpp wsd/ClientSession.hpp wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp

[Ashod Nakashian]

 wsd/ClientSession.cpp  |2 -
 wsd/ClientSession.hpp  |1 
 wsd/DocumentBroker.cpp |   62 ++---
 wsd/DocumentBroker.hpp |   15 ---
 4 files changed, 15 insertions(+), 65 deletions(-)

New commits:
commit d3a8106cda570fb8881139dc4347e02247036664
Author: Ashod Nakashian 
Date:   Sat Mar 25 14:19:17 2017 -0400

wsd: remove NewSessions

Sessions are now added to the DocBroker
_sessions map and loaded from the poll
thread first before processing their
messages.

Since messages are not read from the
sockets outside of the poll thread,
there is no reason to queue them
at all. The only exception is when
messages are passed directly
to ClientSession during convert-to
requests. That will be handled
separately (for now convert-to test
fails).

Change-Id: I798166b9e45b5707a33d31137e01a32ce63630b1
Reviewed-on: https://gerrit.libreoffice.org/35705
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 73e4cb5b..fbc50b98 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -38,6 +38,7 @@ ClientSession::ClientSession(const std::string& id,
 _uriPublic(uriPublic),
 _isReadOnly(readOnly),
 _isDocumentOwner(false),
+_isLoaded(false),
 _stop(false)
 {
 const size_t curConnections = ++LOOLWSD::NumConnections;
@@ -632,7 +633,6 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 }
 else if (tokens[0] == "status:")
 {
-_isLoaded = true;
 docBroker->setLoaded();
 
 // Forward the status response to the client.
diff --git a/wsd/ClientSession.hpp b/wsd/ClientSession.hpp
index 19aee2af..c027f4b3 100644
--- a/wsd/ClientSession.hpp
+++ b/wsd/ClientSession.hpp
@@ -37,6 +37,7 @@ public:
 
 /// Returns true if a document is loaded (i.e. we got status message).
 bool isLoaded() const { return _isLoaded; }
+void setLoaded() { _isLoaded = true; }
 
 const std::string getUserId() const { return _userId; }
 void setUserId(const std::string& userId) { _userId = userId; }
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index eb204b8d..fe0372e7 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -211,41 +211,20 @@ void DocumentBroker::pollThread()
 // Main polling loop goodness.
 while (!_stop && !TerminationFlag && !ShutdownRequestFlag)
 {
-while (true)
+// First, load new sessions.
+for (const auto& pair : _sessions)
 {
-std::unique_lock lock(_mutex);
-if (_newSessions.empty())
-break;
-
-NewSession& newSession = _newSessions.front();
 try
 {
-addSession(newSession._session);
-
-// now send the queued messages
-for (std::string message : newSession._messages)
-{
-// provide the jailed document path to the 'load' message
-assert(!_uriJailed.empty());
-std::vector tokens = 
LOOLProtocol::tokenize(message);
-if (tokens.size() > 1 && tokens[1] == "load")
-{
-// The json options must come last.
-message = tokens[0] + ' ' + tokens[1] + ' ' + 
tokens[2];
-message += " jail=" + _uriJailed.toString() + ' ';
-message += Poco::cat(std::string(" "), tokens.begin() 
+ 3, tokens.end());
-}
-
-LOG_DBG("Sending a queued message: " + message);
-_childProcess->sendTextFrame(message);
-}
+auto& session = pair.second;
+if (!session->isLoaded())
+addSession(session);
 }
 catch (const std::exception& exc)
 {
 LOG_ERR("Error while adding new session to doc [" << _docKey 
<< "]: " << exc.what());
+//TODO: Send failure to client and remove session.
 }
-
-_newSessions.pop_front();
 }
 
 _poll->poll(SocketPoll::DefaultPollTimeoutMs);
@@ -740,10 +719,10 @@ size_t 
DocumentBroker::queueSession(std::shared_ptr& session)
 {
 Util::assertIsLocked(_mutex);
 
-_newSessions.push_back(NewSession(session));
+_sessions.emplace(session->getId(), session);
 _poll->wakeup();
 
-return _sessions.size() + _newSessions.size();
+return _sessions.size();
 }
 
 size_t DocumentBroker::addSession(const std::shared_ptr& 
session)
@@ -778,12 +757,9 @@ size_t DocumentBroker::addSession(const 
std::shared_ptr& session)
 _markToDestroy = false;
 _stop = false;
 
-const auto id = session->getId();
-if (!_sessions.emplace(id, session).second)
-{
-LOG_WRN("Docum

[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

[Ashod Nakashian]

 wsd/DocumentBroker.cpp |   11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

New commits:
commit bd00aa405727ae193c6ae762ce0efd9b580043ae
Author: Ashod Nakashian 
Date:   Sat Mar 25 13:57:08 2017 -0400

wsd: assert isCorrectThread

Change-Id: I90bfa9ba6b47e657db28a3680fa8a13ef2553a6e
Reviewed-on: https://gerrit.libreoffice.org/35703
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 2f7ab961..2f542b14 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -302,7 +302,7 @@ DocumentBroker::~DocumentBroker()
 
 bool DocumentBroker::load(const std::shared_ptr& session, const 
std::string& jailId)
 {
-Util::assertIsLocked(_mutex);
+assert(isCorrectThread());
 
 const std::string sessionId = session->getId();
 
@@ -519,7 +519,7 @@ bool DocumentBroker::saveToStorage(const std::string& 
sessionId,
 bool DocumentBroker::saveToStorageInternal(const std::string& sessionId,
bool success, const std::string& 
result)
 {
-assert(_poll->isCorrectThread());
+assert(isCorrectThread());
 
 // If save requested, but core didn't save because document was unmodified
 // notify the waiting thread, if any.
@@ -745,7 +745,7 @@ size_t 
DocumentBroker::queueSession(std::shared_ptr& session)
 
 size_t DocumentBroker::addSession(const std::shared_ptr& 
session)
 {
-Util::assertIsLocked(_mutex);
+assert(isCorrectThread());
 
 try
 {
@@ -948,6 +948,7 @@ void DocumentBroker::invalidateTiles(const std::string& 
tiles)
 void DocumentBroker::handleTileRequest(TileDesc& tile,
const std::shared_ptr& 
session)
 {
+assert(isCorrectThread());
 std::unique_lock lock(_mutex);
 
 tile.setVersion(++_tileVersion);
@@ -1213,6 +1214,8 @@ bool DocumentBroker::forwardToChild(const std::string& 
viewId, const std::string
 
 bool DocumentBroker::forwardToClient(const std::shared_ptr& payload)
 {
+assert(isCorrectThread());
+
 const std::string& msg = payload->abbr();
 const std::string& prefix = payload->forwardToken();
 LOG_TRC("Forwarding payload to [" << prefix << "]: " << msg);
@@ -1224,8 +1227,6 @@ bool DocumentBroker::forwardToClient(const 
std::shared_ptr& payload)
 const auto& data = payload->data().data();
 const auto& size = payload->size();
 
-// std::unique_lock lock(_mutex);
-
 if (sid == "all")
 {
 // Broadcast to all.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

[Ashod Nakashian]

 wsd/DocumentBroker.cpp |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit a190084b43d6e4b2bedb3ddcfa6376db1f5b161c
Author: Ashod Nakashian 
Date:   Sat Mar 25 13:57:47 2017 -0400

wsd: log document loading stats only the first time

Since these numbers are against the thread start time,
they aren't useful for loading subsequent views.

Change-Id: Ib5cf580282841e5b2dbb71c7db4a1868f7eb29e1
Reviewed-on: https://gerrit.libreoffice.org/35704
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 2f542b14..eb204b8d 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -617,10 +617,13 @@ bool DocumentBroker::saveToStorageInternal(const 
std::string& sessionId,
 
 void DocumentBroker::setLoaded()
 {
-_isLoaded = true;
-_loadDuration = std::chrono::duration_cast(
-std::chrono::steady_clock::now() - _threadStart);
-LOG_TRC("Document loaded in " << _loadDuration.count() << "ms");
+if (!_isLoaded)
+{
+_isLoaded = true;
+_loadDuration = std::chrono::duration_cast(
+std::chrono::steady_clock::now() - 
_threadStart);
+LOG_TRC("Document loaded in " << _loadDuration.count() << "ms");
+}
 }
 
 bool DocumentBroker::autoSave(const bool force)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp

[Ashod Nakashian]

 wsd/DocumentBroker.cpp |5 ++---
 wsd/DocumentBroker.hpp |4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)

New commits:
commit a57b9e6917c6d1a80eb4d800d63dfde7f40f79f2
Author: Ashod Nakashian 
Date:   Sat Mar 25 13:56:17 2017 -0400

wsd: const correctness

Change-Id: I2bba04ccba9fd97e10ecc56f7db1f62a66a8f5f0
Reviewed-on: https://gerrit.libreoffice.org/35702
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index d3934d1b..2f7ab961 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -300,7 +300,7 @@ DocumentBroker::~DocumentBroker()
 _childProcess.reset();
 }
 
-bool DocumentBroker::load(std::shared_ptr& session, const 
std::string& jailId)
+bool DocumentBroker::load(const std::shared_ptr& session, const 
std::string& jailId)
 {
 Util::assertIsLocked(_mutex);
 
@@ -743,7 +743,7 @@ size_t 
DocumentBroker::queueSession(std::shared_ptr& session)
 return _sessions.size() + _newSessions.size();
 }
 
-size_t DocumentBroker::addSession(std::shared_ptr& session)
+size_t DocumentBroker::addSession(const std::shared_ptr& 
session)
 {
 Util::assertIsLocked(_mutex);
 
@@ -864,7 +864,6 @@ size_t DocumentBroker::removeSessionInternal(const 
std::string& id)
 return _sessions.size();
 }
 
-
 void DocumentBroker::addCallback(SocketPoll::CallbackFn fn)
 {
 _poll->addCallback(fn);
diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp
index 526f873d..13acb9bb 100644
--- a/wsd/DocumentBroker.hpp
+++ b/wsd/DocumentBroker.hpp
@@ -225,7 +225,7 @@ public:
 void startThread();
 
 /// Loads a document from the public URI into the jail.
-bool load(std::shared_ptr& session, const std::string& 
jailId);
+bool load(const std::shared_ptr& session, const 
std::string& jailId);
 bool isLoaded() const { return _isLoaded; }
 void setLoaded();
 
@@ -354,7 +354,7 @@ private:
 bool forwardToClient(const std::shared_ptr& payload);
 
 /// Add a new session. Returns the new number of sessions.
-size_t addSession(std::shared_ptr& session);
+size_t addSession(const std::shared_ptr& session);
 
 /// The thread function that all of the I/O for all sessions
 /// associated with this document.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: RepositoryExternal.mk

[Thorsten Behrens]

 RepositoryExternal.mk |4 
 1 file changed, 4 insertions(+)

New commits:
commit a4034d56813b6716ae93d455204079cdd2ff9f6f
Author: Thorsten Behrens 
Date:   Sun Mar 26 05:57:10 2017 +0200

Package gpgme only for Linux currently

Change-Id: Ie7323c59f0183c8e132127694e9e865de494c7a3

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index ed00ea4a9dac..c7671a336466 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -3412,6 +3412,8 @@ $(call gb_LinkTarget_use_package,$(1),gpgme)
 
 endef
 
+ifeq ($(OS),LINUX)
+
 $(eval $(call gb_Helper_register_packages_for_install,ooo,\
gpgme \
libassuan \
@@ -3420,6 +3422,8 @@ $(eval $(call 
gb_Helper_register_packages_for_install,ooo,\
 
 endif
 
+endif
+
 ifeq ($(ENABLE_GLTF),TRUE)
 
 ifneq ($(SYSTEM_LIBGLTF),TRUE)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: uitest/calc_tests

[Markus Mohrhard]

 uitest/calc_tests/autofilter.py |   27 +++
 1 file changed, 11 insertions(+), 16 deletions(-)

New commits:
commit aaea953b6e43ca5672b104308042419899a52c72
Author: Markus Mohrhard 
Date:   Sun Mar 26 01:13:34 2017 +0100

uitest: add demo showing how to use auto filter popup

Change-Id: Id42c2856e4eee03dae374ea36d6dcba16419c70e
Reviewed-on: https://gerrit.libreoffice.org/35700
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/uitest/calc_tests/autofilter.py b/uitest/calc_tests/autofilter.py
index fc5c1c897ef9..431043b02f03 100644
--- a/uitest/calc_tests/autofilter.py
+++ b/uitest/calc_tests/autofilter.py
@@ -31,23 +31,18 @@ class AutofilterTest(UITestCase):
 doc = self.ui_test.load_file(get_url_for_data_file("autofilter.ods"))
 
 xGridWin = self.xUITest.getTopFocusWindow().getChild("grid_window")
-xGridWin.executeAction("LAUNCH", mkPropertyValues({"AUTOFILTER": "", 
"COL": "1", "ROW": "1"}))
+xGridWin.executeAction("LAUNCH", mkPropertyValues({"AUTOFILTER": "", 
"COL": "0", "ROW": "0"}))
+
+xFloatWindow = self.xUITest.getFloatWindow()
+xCheckListMenu = xFloatWindow.getChild("check_list_menu")
+
+xTreeList = xCheckListMenu.getChild("check_list_box")
+xFirstEntry = xTreeList.getChild("0")
+
+xFirstEntry.executeAction("CLICK", tuple())
 
-time.sleep(3)
-
-print(xGridWin.getChildren())
-xCheckListMenu = xGridWin.getChild("check_list_menu")
-print("temp")
-print(xCheckListMenu)
-print(dir(xCheckListMenu))
-print("temp")
-
-json_string = xCheckListMenu.getHierarchy()
-print(json_string)
-json_content = json.loads(json_string)
-print(json_content)
-print(json.dumps(json_content, indent=4))
-time.sleep(10)
+xOkBtn = xFloatWindow.getChild("ok")
+xOkBtn.executeAction("CLICK", tuple())
 
 self.ui_test.close_doc()
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: uitest/calc_tests

[Markus Mohrhard]

 uitest/calc_tests/autofilter.py |   24 
 1 file changed, 24 insertions(+)

New commits:
commit b3ebb8942115ef0d3fa3840f2056eac9a3bbe23a
Author: Markus Mohrhard 
Date:   Sun Mar 26 01:19:00 2017 +0100

uitest: add demo showing how to interact with autofilter popup

Change-Id: Icda3c00a3a8c593a8f3129662c7688be000e3c7e
Reviewed-on: https://gerrit.libreoffice.org/35694
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/uitest/calc_tests/autofilter.py b/uitest/calc_tests/autofilter.py
index 82a2023fea75..fc5c1c897ef9 100644
--- a/uitest/calc_tests/autofilter.py
+++ b/uitest/calc_tests/autofilter.py
@@ -27,4 +27,28 @@ class AutofilterTest(UITestCase):
 
 self.ui_test.close_doc()
 
+def test_hierarchy(self):
+doc = self.ui_test.load_file(get_url_for_data_file("autofilter.ods"))
+
+xGridWin = self.xUITest.getTopFocusWindow().getChild("grid_window")
+xGridWin.executeAction("LAUNCH", mkPropertyValues({"AUTOFILTER": "", 
"COL": "1", "ROW": "1"}))
+
+time.sleep(3)
+
+print(xGridWin.getChildren())
+xCheckListMenu = xGridWin.getChild("check_list_menu")
+print("temp")
+print(xCheckListMenu)
+print(dir(xCheckListMenu))
+print("temp")
+
+json_string = xCheckListMenu.getHierarchy()
+print(json_string)
+json_content = json.loads(json_string)
+print(json_content)
+print(json.dumps(json_content, indent=4))
+time.sleep(10)
+
+self.ui_test.close_doc()
+
 # vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svtools/source

[Markus Mohrhard]

 svtools/source/uitest/uiobject.cxx |9 +
 1 file changed, 9 insertions(+)

New commits:
commit f71208f49599cd13529447a0b3e2e27baeae2128
Author: Markus Mohrhard 
Date:   Sun Mar 26 00:21:32 2017 +0100

uitest: allow to change state of checkbox in treelist

Change-Id: If76ab528dfd835ea7718e153a943d182ecc4ce0a
Reviewed-on: https://gerrit.libreoffice.org/35698
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/svtools/source/uitest/uiobject.cxx 
b/svtools/source/uitest/uiobject.cxx
index aed862b0acbe..9dfc37c15f0a 100644
--- a/svtools/source/uitest/uiobject.cxx
+++ b/svtools/source/uitest/uiobject.cxx
@@ -116,6 +116,15 @@ void TreeListEntryUIObject::execute(const OUString& 
rAction, const StringMap& /*
 {
 mxTreeList->Expand(mpEntry);
 }
+else if (rAction == "CLICK")
+{
+if (!isCheckBoxList(mxTreeList))
+return;
+SvButtonState eState = mxTreeList->GetCheckButtonState(mpEntry);
+eState = eState == SvButtonState::Checked ? SvButtonState::Unchecked : 
SvButtonState::Checked;
+mxTreeList->SetCheckButtonState(mpEntry, eState);
+mxTreeList->CheckButtonHdl();
+}
 }
 
 std::unique_ptr TreeListEntryUIObject::get_child(const OUString& rID)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - sc/source svtools/source

[Markus Mohrhard]

 sc/source/ui/cctrl/checklistmenu.cxx |4 
 sc/source/ui/inc/checklistmenu.hxx   |1 +
 svtools/source/uitest/uiobject.cxx   |   10 ++
 3 files changed, 15 insertions(+)

New commits:
commit bc054e18712eb1a560ef27d0f2b0a62fc47bf962
Author: Markus Mohrhard 
Date:   Sun Mar 26 00:20:29 2017 +0100

uitest: add more IDs to autofilter elements

Change-Id: I6b22409403cf9ab39c9a120c712976316bf3a22a
Reviewed-on: https://gerrit.libreoffice.org/35696
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/source/ui/cctrl/checklistmenu.cxx 
b/sc/source/ui/cctrl/checklistmenu.cxx
index 3b882f7e998f..ce637818191c 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -906,6 +906,9 @@ ScCheckListMenuWindow::ScCheckListMenuWindow(vcl::Window* 
pParent, ScDocument* p
 maChecks->SetTabStopsContainer( &maTabStops );
 
 set_id("check_list_menu");
+maChkToggleAll->set_id("toggle_all");
+maBtnSelectSingle->set_id("select_current");
+maBtnUnselectSingle->set_id("unselect_current");
 }
 
 ScCheckListMenuWindow::~ScCheckListMenuWindow()
@@ -1610,6 +1613,7 @@ ScCheckListBox::ScCheckListBox( vcl::Window* pParent )
 :  SvTreeListBox( pParent, 0 ), mpCheckButton( nullptr ), 
mbSeenMouseButtonDown( false )
 {
 Init();
+set_id("check_list_box");
 }
 
 SvTreeListEntry* ScCheckListBox::FindEntry( SvTreeListEntry* pParent, const 
OUString& sNode )
diff --git a/sc/source/ui/inc/checklistmenu.hxx 
b/sc/source/ui/inc/checklistmenu.hxx
index 1723c9b0863b..f2e208ad4f6b 100644
--- a/sc/source/ui/inc/checklistmenu.hxx
+++ b/sc/source/ui/inc/checklistmenu.hxx
@@ -257,6 +257,7 @@ public:
 : Edit(pParent)
 , mpTabStops(nullptr)
 {
+set_id("search_edit");
 }
 
 virtual void MouseButtonDown( const MouseEvent& rMEvt ) override;
commit 3df98c595f1b9c4bd0705578a15252a4d194293c
Author: Markus Mohrhard 
Date:   Sun Mar 26 00:21:04 2017 +0100

uitest: add info whether a tree list box contains check boxes

Change-Id: Id214928de2e74ac7ec707eaf2276e4e808b630a4
Reviewed-on: https://gerrit.libreoffice.org/35697
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/svtools/source/uitest/uiobject.cxx 
b/svtools/source/uitest/uiobject.cxx
index 94da23aa6a54..aed862b0acbe 100644
--- a/svtools/source/uitest/uiobject.cxx
+++ b/svtools/source/uitest/uiobject.cxx
@@ -18,6 +18,15 @@ TreeListUIObject::TreeListUIObject(VclPtr 
xTreeList):
 {
 }
 
+namespace {
+
+bool isCheckBoxList(VclPtr xTreeList)
+{
+return (xTreeList->GetTreeFlags() & SvTreeFlags::CHKBTN) == 
SvTreeFlags::CHKBTN;
+}
+
+}
+
 StringMap TreeListUIObject::get_state()
 {
 StringMap aMap = WindowUIObject::get_state();
@@ -26,6 +35,7 @@ StringMap TreeListUIObject::get_state()
 aMap["VisibleCount"] = OUString::number(mxTreeList->GetVisibleCount());
 aMap["Children"] = OUString::number(mxTreeList->GetChildCount(nullptr));
 aMap["LevelChildren"] = 
OUString::number(mxTreeList->GetLevelChildCount(nullptr));
+aMap["CheckBoxList"] = OUString::boolean(isCheckBoxList(mxTreeList));
 return aMap;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Markus Mohrhard]

 vcl/source/uitest/uiobject.cxx |   21 +++--
 1 file changed, 15 insertions(+), 6 deletions(-)

New commits:
commit 013e5bacc65710f9412de2287749a84e469056a0
Author: Markus Mohrhard 
Date:   Sun Mar 26 01:20:10 2017 +0100

uitest: handle float windows better in the hierarchy dump

Change-Id: Ic49ac5774116bf9d8af980ecc0d99b0056fc8bed
Reviewed-on: https://gerrit.libreoffice.org/35695
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/vcl/source/uitest/uiobject.cxx b/vcl/source/uitest/uiobject.cxx
index 3dabf7a0e56f..24fac7a4dd31 100644
--- a/vcl/source/uitest/uiobject.cxx
+++ b/vcl/source/uitest/uiobject.cxx
@@ -93,16 +93,25 @@ bool isDialogWindow(vcl::Window* pWindow)
 return false;
 }
 
-vcl::Window* get_dialog_parent(vcl::Window* pWindow)
+bool isTopWindow(vcl::Window* pWindow)
 {
-if (isDialogWindow(pWindow))
+WindowType eType = pWindow->GetType();
+if (eType == WindowType::FLOATINGWINDOW)
+return true;
+
+return false;
+}
+
+vcl::Window* get_top_parent(vcl::Window* pWindow)
+{
+if (isDialogWindow(pWindow) || isTopWindow(pWindow))
 return pWindow;
 
 vcl::Window* pParent = pWindow->GetParent();
 if (!pParent)
 return pWindow;
 
-return get_dialog_parent(pParent);
+return get_top_parent(pParent);
 }
 
 std::vector generate_key_events_from_text(const OUString& rStr)
@@ -409,7 +418,7 @@ void addChildren(vcl::Window* pParent, std::set& 
rChildren)
 
 std::unique_ptr WindowUIObject::get_child(const OUString& rID)
 {
-vcl::Window* pDialogParent = get_dialog_parent(mxWindow.get());
+vcl::Window* pDialogParent = get_top_parent(mxWindow.get());
 vcl::Window* pWindow = findChild(pDialogParent, rID);
 
 if (!pWindow)
@@ -421,7 +430,7 @@ std::unique_ptr WindowUIObject::get_child(const 
OUString& rID)
 
 std::set WindowUIObject::get_children() const
 {
-vcl::Window* pDialogParent = get_dialog_parent(mxWindow.get());
+vcl::Window* pDialogParent = get_top_parent(mxWindow.get());
 std::set aChildren;
 aChildren.insert(pDialogParent->get_id());
 addChildren(pDialogParent, aChildren);
@@ -473,7 +482,7 @@ OUString WindowUIObject::dumpState() const
 
 OUString WindowUIObject::dumpHierarchy() const
 {
-vcl::Window* pDialogParent = get_dialog_parent(mxWindow.get());
+vcl::Window* pDialogParent = get_top_parent(mxWindow.get());
 std::unique_ptr pParentWrapper =
 pDialogParent->GetUITestFactory()(pDialogParent);
 return pParentWrapper->dumpState();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/vcl offapi/com vcl/source

[Markus Mohrhard]

 include/vcl/uitest/uitest.hxx   |2 ++
 offapi/com/sun/star/ui/test/XUITest.idl |2 ++
 vcl/source/uitest/uitest.cxx|   12 
 vcl/source/uitest/uno/uitest_uno.cxx|9 +
 4 files changed, 25 insertions(+)

New commits:
commit 3c979a362b59b87dee62c85403c3c1f28f59f951
Author: Markus Mohrhard 
Date:   Sun Mar 26 00:24:10 2017 +0100

uitest: provide a way to select a floating window, e.g. popup menu

Change-Id: Ice418b974c59c7d8c773b81a82f0a06c84547f10
Reviewed-on: https://gerrit.libreoffice.org/35699
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/include/vcl/uitest/uitest.hxx b/include/vcl/uitest/uitest.hxx
index 53a049069a14..1674ad2fd50f 100644
--- a/include/vcl/uitest/uitest.hxx
+++ b/include/vcl/uitest/uitest.hxx
@@ -24,6 +24,8 @@ public:
 static void executeDialog(const OUString& rCommand);
 
 static std::unique_ptr getFocusTopWindow();
+
+static std::unique_ptr getFloatWindow();
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/offapi/com/sun/star/ui/test/XUITest.idl 
b/offapi/com/sun/star/ui/test/XUITest.idl
index 89da44c7d6e7..55f234164296 100644
--- a/offapi/com/sun/star/ui/test/XUITest.idl
+++ b/offapi/com/sun/star/ui/test/XUITest.idl
@@ -21,6 +21,8 @@ interface XUITest
 void executeDialog([in] string command);
 
 XUIObject getTopFocusWindow();
+
+XUIObject getFloatWindow();
 };
 
 }; }; }; }; };
diff --git a/vcl/source/uitest/uitest.cxx b/vcl/source/uitest/uitest.cxx
index 413201843ced..3b19a9acc49c 100644
--- a/vcl/source/uitest/uitest.cxx
+++ b/vcl/source/uitest/uitest.cxx
@@ -49,4 +49,16 @@ std::unique_ptr UITest::getFocusTopWindow()
 return rWinData.mpFirstFrame->GetUITestFactory()(rWinData.mpFirstFrame);
 }
 
+std::unique_ptr UITest::getFloatWindow()
+{
+ImplSVData* pSVData = ImplGetSVData();
+ImplSVWinData& rWinData = pSVData->maWinData;
+
+VclPtr pFloatWin = rWinData.mpFirstFloat;
+if (pFloatWin)
+return pFloatWin->GetUITestFactory()(pFloatWin);
+
+return nullptr;
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/uitest/uno/uitest_uno.cxx 
b/vcl/source/uitest/uno/uitest_uno.cxx
index c5a15a4f52ee..1d874c32c7d1 100644
--- a/vcl/source/uitest/uno/uitest_uno.cxx
+++ b/vcl/source/uitest/uno/uitest_uno.cxx
@@ -44,6 +44,8 @@ public:
 
 css::uno::Reference SAL_CALL getTopFocusWindow() 
override;
 
+css::uno::Reference SAL_CALL getFloatWindow() 
override;
+
 OUString SAL_CALL getImplementationName() override;
 
 sal_Bool SAL_CALL supportsService(OUString const & ServiceName) override;
@@ -76,6 +78,13 @@ css::uno::Reference SAL_CALL 
UITestUnoObj::getTopFocus
 return new UIObjectUnoObj(std::move(pObj));
 }
 
+css::uno::Reference SAL_CALL 
UITestUnoObj::getFloatWindow()
+{
+SolarMutexGuard aGuard;
+std::unique_ptr pObj = UITest::getFloatWindow();
+return new UIObjectUnoObj(std::move(pObj));
+}
+
 OUString SAL_CALL UITestUnoObj::getImplementationName()
 {
 return OUString("org.libreoffice.uitest.UITest");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: uitest/calc_tests

[Markus Mohrhard]

 uitest/calc_tests/autofilter.py   |   30 ++
 uitest/calc_tests/data/autofilter.ods |binary
 2 files changed, 30 insertions(+)

New commits:
commit 8d65a2076ee9e76ce2301762fd147cea7091aae4
Author: Markus Mohrhard 
Date:   Sat Mar 25 04:10:24 2017 +0100

uitest: add initial autofilter test

Change-Id: I06029afbf9be93054ef932f8c37a56b929c3e436
Reviewed-on: https://gerrit.libreoffice.org/35693
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/uitest/calc_tests/autofilter.py b/uitest/calc_tests/autofilter.py
new file mode 100644
index ..82a2023fea75
--- /dev/null
+++ b/uitest/calc_tests/autofilter.py
@@ -0,0 +1,30 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+from uitest.path import get_srcdir_url
+
+from libreoffice.uno.propertyvalue import mkPropertyValues
+
+import time
+
+def get_url_for_data_file(file_name):
+return get_srcdir_url() + "/uitest/calc_tests/data/" + file_name
+
+class AutofilterTest(UITestCase):
+
+def test_launch_autofilter(self):
+doc = self.ui_test.load_file(get_url_for_data_file("autofilter.ods"))
+
+xGridWin = self.xUITest.getTopFocusWindow().getChild("grid_window")
+xGridWin.executeAction("LAUNCH", mkPropertyValues({"AUTOFILTER": "", 
"COL": "1", "ROW": "1"}))
+
+time.sleep(1)
+
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/uitest/calc_tests/data/autofilter.ods 
b/uitest/calc_tests/data/autofilter.ods
new file mode 100644
index ..a03dba608076
Binary files /dev/null and b/uitest/calc_tests/data/autofilter.ods differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Markus Mohrhard]

 sc/source/ui/uitest/uiobject.cxx |   23 +++
 1 file changed, 23 insertions(+)

New commits:
commit a25033fabdf1fccd1b201941cb3b921e2cce81bd
Author: Markus Mohrhard 
Date:   Sat Mar 25 04:02:28 2017 +0100

uitest: add ability to open autofilter dialog

Change-Id: If03b2699975756ab650488abe032aefa8880a6b4
Reviewed-on: https://gerrit.libreoffice.org/35692
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/source/ui/uitest/uiobject.cxx b/sc/source/ui/uitest/uiobject.cxx
index 0db6744ed9c3..96f07bc35743 100644
--- a/sc/source/ui/uitest/uiobject.cxx
+++ b/sc/source/ui/uitest/uiobject.cxx
@@ -172,6 +172,29 @@ void ScGridWinUIObject::execute(const OUString& rAction,
 else
 SAL_WARN("sc.uitest", "can't activate the current selection");
 }
+else if (rAction == "LAUNCH")
+{
+auto itr = rParameters.find("AUTOFILTER");
+if (itr != rParameters.end())
+{
+auto itrCol = rParameters.find("COL");
+if (itrCol == rParameters.end())
+{
+SAL_WARN("sc.uitest", "missing COL parameter");
+return;
+}
+
+auto itrRow = rParameters.find("ROW");
+if (itrRow == rParameters.end())
+{
+SAL_WARN("sc.uitest", "missing ROW parameter");
+return;
+}
+SCROW nRow = itrRow->second.toUInt32();
+SCCOL nCol = itrCol->second.toUInt32();
+mxGridWindow->LaunchAutoFilterMenu(nCol, nRow);
+}
+}
 else
 {
 WindowUIObject::execute(rAction, rParameters);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Markus Mohrhard]

 sc/source/ui/cctrl/checklistmenu.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 03c434e5acf8a2288679776076c3fe7718dfb569
Author: Markus Mohrhard 
Date:   Sat Mar 25 03:29:43 2017 +0100

uitest: add id to autofilter popup

Change-Id: Icf3b731c18333d97aa43535e31df73bc2dbfba42
Reviewed-on: https://gerrit.libreoffice.org/35691
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/ui/cctrl/checklistmenu.cxx 
b/sc/source/ui/cctrl/checklistmenu.cxx
index 3879d79f5fd3..3b882f7e998f 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -904,6 +904,8 @@ ScCheckListMenuWindow::ScCheckListMenuWindow(vcl::Window* 
pParent, ScDocument* p
 
 maEdSearch->SetTabStopsContainer( &maTabStops );
 maChecks->SetTabStopsContainer( &maTabStops );
+
+set_id("check_list_menu");
 }
 
 ScCheckListMenuWindow::~ScCheckListMenuWindow()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Markus Mohrhard]

 vcl/source/uitest/uiobject.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit b9af0c2964a75be1d59884f4aef1fa5a04f85336
Author: Markus Mohrhard 
Date:   Sun Mar 26 01:15:37 2017 +0100

uitest: allow to find ourself with an ID

Change-Id: I5418aba05acd53f00c8d60a7ac7005c83a04e5a4
Reviewed-on: https://gerrit.libreoffice.org/35701
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/vcl/source/uitest/uiobject.cxx b/vcl/source/uitest/uiobject.cxx
index b192f898c620..3dabf7a0e56f 100644
--- a/vcl/source/uitest/uiobject.cxx
+++ b/vcl/source/uitest/uiobject.cxx
@@ -364,6 +364,9 @@ vcl::Window* findChild(vcl::Window* pParent, const 
OUString& rID)
 if (!pParent)
 return nullptr;
 
+if (pParent->get_id() == rID)
+return pParent;
+
 size_t nCount = pParent->GetChildCount();
 for (size_t i = 0; i < nCount; ++i)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: uitest/uitest

[Markus Mohrhard]

 uitest/uitest/bisecting.py |   16 
 1 file changed, 16 insertions(+)

New commits:
commit 646be83e93fc2e68fc419cf6893bd1d1c1322bf7
Author: Markus Mohrhard 
Date:   Sun Mar 26 01:50:01 2017 +0100

uitest: add a decorator to document required revision

This is the first step in allowing easy bisecting with the UI testing
framework. We now also need a script that can execute tests and a way to
get the revision information back into the bisecting script.

Change-Id: If59db62ba25162ae69360d5b8ae769a6d179c16c

diff --git a/uitest/uitest/bisecting.py b/uitest/uitest/bisecting.py
new file mode 100644
index ..7d2f074411df
--- /dev/null
+++ b/uitest/uitest/bisecting.py
@@ -0,0 +1,16 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from functools import wraps
+
+def requires(revision):
+def decorator(f):
+f.requires = revision
+return f
+return decorator
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: RepositoryExternal.mk solenv/bin

[Thorsten Behrens]

 RepositoryExternal.mk   |2 +-
 solenv/bin/modules/installer/control.pm |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 8724bcff1e4c9e666125927659db747b483401c3
Author: Thorsten Behrens 
Date:   Sun Mar 26 04:01:02 2017 +0200

Fix gpgme packaging

Change-Id: I26ef55b8a7a210f9d86becd4f0aa10c2598681fd

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 75897bc7799e..ed00ea4a9dac 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -3413,7 +3413,7 @@ $(call gb_LinkTarget_use_package,$(1),gpgme)
 endef
 
 $(eval $(call gb_Helper_register_packages_for_install,ooo,\
-   gpgmepp \
+   gpgme \
libassuan \
libgpg-error \
 ))
diff --git a/solenv/bin/modules/installer/control.pm 
b/solenv/bin/modules/installer/control.pm
index 7670535715ea..decf519eb881 100644
--- a/solenv/bin/modules/installer/control.pm
+++ b/solenv/bin/modules/installer/control.pm
@@ -325,7 +325,7 @@ sub check_logfile
 $compareline =~ s/Error\.html//g;   # removing all occurrences of 
"Error.html"
 $compareline =~ s/error\.py//g; # removing all occurrences of 
"error.py"
 $compareline =~ s/error\.cpython\-3.(\.opt\-.|)\.py[co]//g;  # 
removing all occurrences of "error-cpython"
-$compareline =~ s/libgpg-error-0.dll//g;
+$compareline =~ s/libgpg-error//g;
 $compareline =~ s/Error-xref\.html//g;
 
 if ( $compareline =~ /\bError\b/i )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: drawinglayer/source

[Markus Mohrhard]

 drawinglayer/source/animation/animationtiming.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 49f8917cd4c10685645128768a2dc63043a7b398
Author: Markus Mohrhard 
Date:   Sun Mar 26 03:25:58 2017 +0200

fix loplugin:loopvartoosmall

Change-Id: I4fa577920565840edd5b37c673e5c8eb42da7ed7

diff --git a/drawinglayer/source/animation/animationtiming.cxx 
b/drawinglayer/source/animation/animationtiming.cxx
index 683c5f5b830c..44210b9567c6 100644
--- a/drawinglayer/source/animation/animationtiming.cxx
+++ b/drawinglayer/source/animation/animationtiming.cxx
@@ -161,14 +161,14 @@ namespace drawinglayer
 
 sal_uInt32 AnimationEntryList::impGetIndexAtTime(double fTime, double 
&rfAddedTime) const
 {
-sal_uInt32 nIndex(0L);
+size_t nIndex(0L);
 
 while(nIndex < maEntries.size() && 
basegfx::fTools::lessOrEqual(rfAddedTime + maEntries[nIndex]->getDuration(), 
fTime))
 {
 rfAddedTime += maEntries[nIndex++]->getDuration();
 }
 
-return nIndex;
+return sal_uInt32(nIndex);
 }
 
 AnimationEntryList::AnimationEntryList()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/source

[Bjoern Michaelsen]

 chart2/source/controller/main/ChartController.cxx |9 +
 1 file changed, 1 insertion(+), 8 deletions(-)

New commits:
commit 83c1a3235d8d803872e1d57a292d3cdc48dae928
Author: Bjoern Michaelsen 
Date:   Fri Mar 24 12:34:06 2017 +0100

Remove obsolete code

now that the ChartController doesnt own the VCL window anymore.

Change-Id: I2fefa73181a61b2a7828b36e70480b59aa7838f4
Reviewed-on: https://gerrit.libreoffice.org/35640
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 

diff --git a/chart2/source/controller/main/ChartController.cxx 
b/chart2/source/controller/main/ChartController.cxx
index 0f879f60259e..3d163b791e1a 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -441,17 +441,10 @@ void SAL_CALL ChartController::attachFrame(
 pParent = VCLUnoHelper::GetWindow( xContainerWindow ).get();
 }
 
-auto pChartWindow(GetChartWindow());
-if(pChartWindow)
-{
-//@todo delete ...
-pChartWindow->clear();
-m_apDropTargetHelper.reset();
-}
 {
 // calls to VCL
 SolarMutexGuard aSolarGuard;
-pChartWindow = 
VclPtr::Create(this,pParent,pParent?pParent->GetStyle():0);
+auto pChartWindow = 
VclPtr::Create(this,pParent,pParent?pParent->GetStyle():0);
 pChartWindow->SetBackground();//no Background
 m_xViewWindow.set( pChartWindow->GetComponentInterface(), 
uno::UNO_QUERY );
 pChartWindow->Show();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

José Peixoto license statement

[José Peixoto]

All of my past & future contributions to LibreOffice may be licensed under
the MPLv2/LGPLv3+ dual license.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: filter/source

[Caolán McNamara]

 filter/source/msfilter/svdfppt.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 26262de4d508891d08a97dc280f00b28afcd8c7b
Author: Caolán McNamara 
Date:   Sat Mar 25 21:07:57 2017 +

ofz#942 fix leak

Change-Id: I52f69e9dc4c47764c1b3773b1c41b2f04807703e

diff --git a/filter/source/msfilter/svdfppt.cxx 
b/filter/source/msfilter/svdfppt.cxx
index b7e76ca57d6d..38c27e407a72 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -7597,13 +7597,14 @@ SdrObject* SdrPowerPointImport::CreateTable( SdrObject* 
pGroup, sal_uInt32* pTab
 aColumns.insert( aSnapRect.Left() );
 }
 }
-sdr::table::SdrTableObj* pTable = new sdr::table::SdrTableObj( pSdrModel );
-pTable->uno_lock();
-Reference< XTable > xTable( pTable->getTable() );
 
 if (aRows.empty())
 return pRet;
 
+sdr::table::SdrTableObj* pTable = new sdr::table::SdrTableObj( pSdrModel );
+pTable->uno_lock();
+Reference< XTable > xTable( pTable->getTable() );
+
 try
 {
 CreateTableRows( xTable->getRows(), aRows, 
pGroup->GetSnapRect().Bottom() );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: master builds, starts but no UI

[Jean-Baptiste Faure]

Hi,

Le 25/03/2017 à 09:20, Jean-Baptiste Faure a écrit :

Hi,

I don't know if it is only me: current master builds without problem, it
starts but the UI does not show up and it does not crash, it does
nothing (CPU = 0%). Under gdb I see nothing I am able to interpret.
I am building under Ubuntu 16.04 x86-64

I encounter this problem one or two days, somewhere after the commit
7a46166beb714a3357f7fb04111ba98f6325065f
I am currently bisecting.


The StartCenter does not show up if you are not using Wayland.

I guess that the problematic commit is :
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=6903066822900a700ccf67ae70fa171c94644a9a
Related: rhbz#1334915 tdf#100158 hack using startcenter icon under wayland

I am currently building the master to confirm that this commit is the 
first bad. Currently my first good is the next commit :
(42870930e2a625766288edc3ba956c1bcac198f0 starmath: Fix memory leak at 
double sub/superscripts) and my first bad is the previous one 
(51efa8fb3f92de9f8c02d2cc4e3bffcaa5caee7f Notebookbar: move shortcuts if 
multiple rows of tabs)


Best regards.
JBF

--
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
Disclaimer: my Internet Provider being located in France, each of our
exchanges over Internet will be scanned by French spying services.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - odk/docs

[Matthias Seidel]

 odk/docs/images/bg_table.png |binary
 odk/docs/sdk_styles.css  |   39 ++-
 2 files changed, 18 insertions(+), 21 deletions(-)

New commits:
commit 548f330f31bc238e041e4bfb7b413b8ea641d6ad
Author: Matthias Seidel 
Date:   Sat Mar 25 20:29:11 2017 +

Changed color of table head

diff --git a/odk/docs/images/bg_table.png b/odk/docs/images/bg_table.png
index 1cb4c1e92940..756c3b91bd20 100644
Binary files a/odk/docs/images/bg_table.png and b/odk/docs/images/bg_table.png 
differ
diff --git a/odk/docs/sdk_styles.css b/odk/docs/sdk_styles.css
index c258b0a8919f..c291840caa95 100644
--- a/odk/docs/sdk_styles.css
+++ b/odk/docs/sdk_styles.css
@@ -32,8 +32,8 @@ a:hover { color: #107EC0; text-decoration: underline; }
   font-family: Arial, Helvetica, sans-serif; }
 
 .note { font-size: 20px;
-font-weight: bold;
-   font-style: italic; 
+   font-weight: bold;
+   font-style: italic;
text-align: center; }
 
 .table1 { width: 100%;
@@ -52,56 +52,55 @@ a:hover { color: #107EC0; text-decoration: underline; }
  padding: 0; }
 
 .table4 { width: 100%;
- border-width: 1px; 
+ border-width: 1px;
  border-style: solid;
  border-color: #55;
- border-spacing: 0; 
+ border-spacing: 0;
  border-collapse: collapse; }
 
-.cell15 { width: 15%; 
- border-width: 1px; 
+.cell15 { width: 15%;
+ border-width: 1px;
  border-style: solid;
  border-color: #55;
  border-spacing: 0;
- border-collapse: collapse; 
+ border-collapse: collapse;
  padding: 4px; }
 
-.cell20 { width: 20%; 
- border-width: 1px; 
+.cell20 { width: 20%;
+ border-width: 1px;
  border-style: solid;
  border-color: #55;
  border-spacing: 0;
- border-collapse: collapse; 
+ border-collapse: collapse;
  padding: 4px; }
 
 .cell80 { width: 80%;
- border-width: 1px; 
+ border-width: 1px;
  border-style: solid;
  border-color: #55;
  border-spacing: 0;
  border-collapse: collapse;
  padding: 4px; }
 
-.cell85 { width: 85%; 
- border-width: 1px; 
+.cell85 { width: 85%;
+ border-width: 1px;
  border-style: solid;
  border-color: #55;
  border-spacing: 0;
- border-collapse: collapse; 
+ border-collapse: collapse;
  padding: 4px; }
 
 .nothing1 { width: 20px;
-  height: 1px; }
+   height: 1px; }
 
 .nothing8 { width: 20px;
height: 8px; }
 
 .nothing10 { width: 20px;
-   height: 10px; }
+height: 10px; }
 
 .nothing30 { width: 20px;
-   height: 30px; }
-
+height: 30px; }
 
 .appicon { width: 32px;
   height: 32px;
@@ -110,7 +109,6 @@ a:hover { color: #107EC0; text-decoration: underline; }
 .line { width: 100%;
 height: 1px; }
 
-
 .arrow { width: 16px;
 height: 13px; }
 
@@ -127,7 +125,7 @@ a:hover { color: #107EC0; text-decoration: underline; }
  font-weight: bold; }
 
 .thead { font-weight: bold;
- background-color: #CC; }
+ background-color: #89B3CD; }
 
 .navigate { border: 0; }
 
@@ -143,4 +141,3 @@ a:hover { color: #107EC0; text-decoration: underline; }
 
 .centertext { padding-left:20px; padding-top:3px; padding-bottom:5px; 
text-align:left; font-size: 12px; line-height:10pt; }
 .apachelogo { float: right; text-align: left; padding-bottom: 12px; 
padding-right: 8px; padding-left: 5px; width: 188px; height: 76px; }
-
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Adolfo Jayme Barrientos]

 source/text/shared/00/0003.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6be791160b0f09944f9bdbf56dc47273b44be708
Author: Adolfo Jayme Barrientos 
Date:   Sat Mar 25 15:35:42 2017 -0600

Use double prime character (U+2033) for inches

Change-Id: I107f94b795dd5150ed8029d7ac284f52bf0aa4c7

diff --git a/source/text/shared/00/0003.xhp 
b/source/text/shared/00/0003.xhp
index a901df17f..02d9cfbf8 100644
--- a/source/text/shared/00/0003.xhp
+++ b/source/text/shared/00/0003.xhp
@@ -67,7 +67,7 @@
 
 
 
-in or "
+in or 
″
 
 
 Inch
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Adolfo Jayme Barrientos]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a73f5a4223199a79c073f383b2968964eac36939
Author: Adolfo Jayme Barrientos 
Date:   Sat Mar 25 15:35:42 2017 -0600

Updated core
Project: help  6be791160b0f09944f9bdbf56dc47273b44be708

Use double prime character (U+2033) for inches

Change-Id: I107f94b795dd5150ed8029d7ac284f52bf0aa4c7

diff --git a/helpcontent2 b/helpcontent2
index b67d9744ba73..6be791160b0f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit b67d9744ba73792377b249fd008848125696a769
+Subproject commit 6be791160b0f09944f9bdbf56dc47273b44be708
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - df/c1786af2d6249558cc91d84a82a7a2772abb12

[Caolán McNamara]

 df/c1786af2d6249558cc91d84a82a7a2772abb12 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 54fb088ee7de079045d47dce57265299d4f79cef
Author: Caolán McNamara 
Date:   Sat Mar 25 20:52:09 2017 +

Notes added by 'git notes add'

diff --git a/df/c1786af2d6249558cc91d84a82a7a2772abb12 
b/df/c1786af2d6249558cc91d84a82a7a2772abb12
new file mode 100644
index ..765aa51f1f80
--- /dev/null
+++ b/df/c1786af2d6249558cc91d84a82a7a2772abb12
@@ -0,0 +1 @@
+prefer: ff0ad0493ee1729c726587f667761b04101d774c
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 13/abe86bb10ee68c302e9b27dba4a438a6c98168

[Caolán McNamara]

 13/abe86bb10ee68c302e9b27dba4a438a6c98168 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 8c3ff277d7e077d73d21f41ab76a5d8bbd9e8702
Author: Caolán McNamara 
Date:   Sat Mar 25 20:49:52 2017 +

Notes added by 'git notes add'

diff --git a/13/abe86bb10ee68c302e9b27dba4a438a6c98168 
b/13/abe86bb10ee68c302e9b27dba4a438a6c98168
new file mode 100644
index ..4acd5055836b
--- /dev/null
+++ b/13/abe86bb10ee68c302e9b27dba4a438a6c98168
@@ -0,0 +1 @@
+prefer: 0764292c5dcb7daa62e9adeb1ac9af1dbe14066f
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 86/2d03382236c006ccf21e710cbcb8f65eaf4317

[Caolán McNamara]

 86/2d03382236c006ccf21e710cbcb8f65eaf4317 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 333bdf68ad6308a35b47b5ceb0ee4228f1df0d4d
Author: Caolán McNamara 
Date:   Sat Mar 25 20:43:15 2017 +

Notes added by 'git notes add'

diff --git a/86/2d03382236c006ccf21e710cbcb8f65eaf4317 
b/86/2d03382236c006ccf21e710cbcb8f65eaf4317
new file mode 100644
index ..783121c6b0aa
--- /dev/null
+++ b/86/2d03382236c006ccf21e710cbcb8f65eaf4317
@@ -0,0 +1 @@
+prefer: bfc71eb03e2bc6f26d53f70b32f9a8937086808b
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 15/325f02503e3e47201a21fc9da3881fde3fab3f

[Caolán McNamara]

 15/325f02503e3e47201a21fc9da3881fde3fab3f |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 3293a644ea8c59f247d9acea24038cf64eadb636
Author: Caolán McNamara 
Date:   Sat Mar 25 20:42:03 2017 +

Notes added by 'git notes add'

diff --git a/15/325f02503e3e47201a21fc9da3881fde3fab3f 
b/15/325f02503e3e47201a21fc9da3881fde3fab3f
new file mode 100644
index ..8ebbe55237b1
--- /dev/null
+++ b/15/325f02503e3e47201a21fc9da3881fde3fab3f
@@ -0,0 +1 @@
+ignore: obsolete
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 40/6374cce33a9b0c06546b2490a33b4e6b183390

[Caolán McNamara]

 40/6374cce33a9b0c06546b2490a33b4e6b183390 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 2ee56048f09334cb0b70accd9a094814812b6388
Author: Caolán McNamara 
Date:   Sat Mar 25 20:36:16 2017 +

Notes added by 'git notes add'

diff --git a/40/6374cce33a9b0c06546b2490a33b4e6b183390 
b/40/6374cce33a9b0c06546b2490a33b4e6b183390
new file mode 100644
index ..8e5c182e7789
--- /dev/null
+++ b/40/6374cce33a9b0c06546b2490a33b4e6b183390
@@ -0,0 +1 @@
+ignore: aoo
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dev-tools.git: vim_scripts/.ycm_extra_conf.py

[Markus Mohrhard]

 vim_scripts/.ycm_extra_conf.py |  123 +
 1 file changed, 123 insertions(+)

New commits:
commit 27cb24a38aa9550f5b6011464c38717eb45c1924
Author: Markus Mohrhard 
Date:   Sun Jan 1 19:21:15 2017 +0100

add example .ycm_extra_conf.py script for youcompleteme

Change-Id: I6a08963def7a86024c64ded0f94b201b7a43afd9

diff --git a/vim_scripts/.ycm_extra_conf.py b/vim_scripts/.ycm_extra_conf.py
new file mode 100644
index 000..4600a86
--- /dev/null
+++ b/vim_scripts/.ycm_extra_conf.py
@@ -0,0 +1,123 @@
+# This is free and unencumbered software released into the public domain.
+#
+# Anyone is free to copy, modify, publish, use, compile, sell, or
+# distribute this software, either in source code form or as a compiled
+# binary, for any purpose, commercial or non-commercial, and by any
+# means.
+#
+# In jurisdictions that recognize copyright laws, the author or authors
+# of this software dedicate any and all copyright interest in the
+# software to the public domain. We make this dedication for the benefit
+# of the public at large and to the detriment of our heirs and
+# successors. We intend this dedication to be an overt act of
+# relinquishment in perpetuity of all present and future rights to this
+# software under copyright law.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+# IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR
+# OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+# OTHER DEALINGS IN THE SOFTWARE.
+#
+# For more information, please refer to 
+
+import os
+import ycm_core
+
+# These are the compilation flags that will be used in case there's no
+# compilation database set (by default, one is not set).
+# CHANGE THIS LIST OF FLAGS. YES, THIS IS THE DROID YOU HAVE BEEN LOOKING FOR.
+flags = [
+]
+
+
+# Set this to the absolute path to the folder (NOT the file!) containing the
+# compile_commands.json file to use that instead of 'flags'. See here for
+# more details: http://clang.llvm.org/docs/JSONCompilationDatabase.html
+#
+def DirectoryOfThisScript():
+  return os.path.dirname( os.path.abspath( __file__ ) )
+
+compilation_database_folder = DirectoryOfThisScript()
+
+if os.path.exists( compilation_database_folder ):
+  database = ycm_core.CompilationDatabase( compilation_database_folder )
+else:
+  database = None
+
+SOURCE_EXTENSIONS = [ '.cpp', '.cxx', '.cc', '.c', '.m', '.mm' ]
+
+def MakeRelativePathsInFlagsAbsolute( flags, working_directory ):
+  if not working_directory:
+return list( flags )
+  new_flags = []
+  make_next_absolute = False
+  path_flags = [ '-isystem', '-I', '-iquote', '--sysroot=' ]
+  for flag in flags:
+new_flag = flag
+
+if make_next_absolute:
+  make_next_absolute = False
+  if not flag.startswith( '/' ):
+new_flag = os.path.join( working_directory, flag )
+
+for path_flag in path_flags:
+  if flag == path_flag:
+make_next_absolute = True
+break
+
+  if flag.startswith( path_flag ):
+path = flag[ len( path_flag ): ]
+new_flag = path_flag + os.path.join( working_directory, path )
+break
+
+if new_flag:
+  new_flags.append( new_flag )
+  return new_flags
+
+
+def IsHeaderFile( filename ):
+  extension = os.path.splitext( filename )[ 1 ]
+  return extension in [ '.h', '.hxx', '.hpp', '.hh' ]
+
+
+def GetCompilationInfoForFile( filename ):
+  # The compilation_commands.json file generated by CMake does not have entries
+  # for header files. So we do our best by asking the db for flags for a
+  # corresponding source file, if any. If one exists, the flags for that file
+  # should be good enough.
+  if IsHeaderFile( filename ):
+basename = os.path.splitext( filename )[ 0 ]
+for extension in SOURCE_EXTENSIONS:
+  replacement_file = basename + extension
+  if os.path.exists( replacement_file ):
+compilation_info = database.GetCompilationInfoForFile(
+  replacement_file )
+if compilation_info.compiler_flags_:
+  return compilation_info
+return None
+  return database.GetCompilationInfoForFile( filename )
+
+
+def FlagsForFile( filename, **kwargs ):
+  if database:
+# Bear in mind that compilation_info.compiler_flags_ does NOT return a
+# python list, but a "list-like" StringVec object
+compilation_info = GetCompilationInfoForFile( filename )
+if not compilation_info:
+  return None
+
+final_flags = MakeRelativePathsInFlagsAbsolute(
+  compilation_info.compiler_flags_,
+  compilation_info.compiler_working_dir_ )
+
+  else:
+relative_to = DirectoryOfThisScript()
+final_flags = MakeRelativePathsInFlagsAbsolute( flags, relative_to )
+
+  return {
+'f

[Libreoffice-commits] core.git: chart2/qa

[Andrea Gelmini]

 chart2/qa/extras/chart2dump/data/simple_chart.ods|binary
 chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt |2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 13d4d1cae3d3dbf90774bd68e35e8cee05cf16c9
Author: Andrea Gelmini 
Date:   Sat Mar 25 16:43:17 2017 +0100

Fix typos

To re-integrate the fixes in revert commit
ab92c84dfe600f320f37b6126cab11385a6fbdd1
we have also to update the binary ods,
to avoid break of "make check".

Change-Id: Ic044d43c6c3c3d9fc3e003c282fac4ba888a0115
Reviewed-on: https://gerrit.libreoffice.org/35685
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/chart2/qa/extras/chart2dump/data/simple_chart.ods 
b/chart2/qa/extras/chart2dump/data/simple_chart.ods
index 93c3c1d1a70d..f65584d12aca 100755
Binary files a/chart2/qa/extras/chart2dump/data/simple_chart.ods and 
b/chart2/qa/extras/chart2dump/data/simple_chart.ods differ
diff --git 
a/chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt 
b/chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt
index e955f80571ad..28a125d7a5ed 100755
--- a/chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt
+++ b/chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt
@@ -1,5 +1,5 @@
 // sChartTitle
-Annaul Revenue
+Annual Revenue
 // sChartType
 com.sun.star.chart2.ColumnChartType
 // sXAxisTitle
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: scaddins/source scripting/source sc/source sd/qa

[Andrea Gelmini]

 sc/source/ui/app/inputwin.cxx  |2 +-
 sc/source/ui/dbgui/pfiltdlg.cxx|2 +-
 sc/source/ui/dialogs/searchresults.cxx |2 +-
 sc/source/ui/src/scfuncs.src   |2 +-
 sc/source/ui/unoobj/docuno.cxx |2 +-
 sc/source/ui/unoobj/shapeuno.cxx   |2 +-
 sc/source/ui/vba/vbarange.cxx  |4 ++--
 sc/source/ui/vba/vbavalidation.cxx |2 +-
 sc/source/ui/vba/vbaworksheets.cxx |2 +-
 sc/source/ui/view/output.cxx   |4 ++--
 sc/source/ui/view/output2.cxx  |4 ++--
 sc/source/ui/view/preview.cxx  |2 +-
 sc/source/ui/view/tabcont.cxx  |2 +-
 scaddins/source/datefunc/datefunc.cxx  |2 +-
 scaddins/source/pricing/black_scholes.cxx  |2 +-
 scripting/source/protocolhandler/scripthandler.cxx |2 +-
 sd/qa/unit/dialogs-test.cxx|4 ++--
 17 files changed, 21 insertions(+), 21 deletions(-)

New commits:
commit 5a72da3d979d88442ea5b7f1f54ba9811173ec64
Author: Andrea Gelmini 
Date:   Fri Mar 24 12:46:41 2017 +0100

Fix typos

Change-Id: I4e1a613fc99b931e84a1955695364e1d25e25e5c
Reviewed-on: https://gerrit.libreoffice.org/35642
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx
index 433f5f61c01d..f9e03970f103 100644
--- a/sc/source/ui/app/inputwin.cxx
+++ b/sc/source/ui/app/inputwin.cxx
@@ -950,7 +950,7 @@ void ScInputBarGroup::TriggerToolboxLayout()
 xLayoutManager->lock();
 DataChangedEvent aFakeUpdate( DataChangedEventType::SETTINGS, 
nullptr,  AllSettingsFlags::STYLE );
 
-// this basically will trigger the reposititioning of the
+// this basically will trigger the repositioning of the
 // items in the toolbar from ImplFormat ( which is controlled by
 // mnWinHeight ) which in turn is updated in ImplCalcItem which is
 // controlled by mbCalc. Additionally the ImplFormat above is
diff --git a/sc/source/ui/dbgui/pfiltdlg.cxx b/sc/source/ui/dbgui/pfiltdlg.cxx
index 98d1d6b8debf..e0f0e9ec3b06 100644
--- a/sc/source/ui/dbgui/pfiltdlg.cxx
+++ b/sc/source/ui/dbgui/pfiltdlg.cxx
@@ -546,7 +546,7 @@ IMPL_LINK( ScPivotFilterDlg, ValModifyHdl, Edit&, rEd, void 
)
 if ( &rEd == m_pEdVal2 ) pLb = m_pLbCond2;
 else if ( &rEd == m_pEdVal3 ) pLb = m_pLbCond3;
 
-// if ond of the special values "empty"/"non-empty" was chosen only the
+// if cond of the special values "empty"/"non-empty" was chosen only the
 // =-operand makes sense:
 
 if ( aStrEmpty.equals(aStrVal) || aStrNotEmpty.equals(aStrVal) )
diff --git a/sc/source/ui/dialogs/searchresults.cxx 
b/sc/source/ui/dialogs/searchresults.cxx
index 0cffca7e4c58..897c8ecae6c5 100644
--- a/sc/source/ui/dialogs/searchresults.cxx
+++ b/sc/source/ui/dialogs/searchresults.cxx
@@ -120,7 +120,7 @@ void SearchResultsDlg::FillResults( ScDocument* pDoc, const 
ScRangeList &rMatche
 {
 for (size_t i = 0, n = nMatchMax; i < n; ++i)
 {
-/* TODO: a CellNotes iterator would come handy and migt speed
+/* TODO: a CellNotes iterator would come handy and might speed
  * things up a little, though we only loop through the
  * search/replace result positions here. */
 ScRange aRange( *rMatchedRanges[i] );
diff --git a/sc/source/ui/src/scfuncs.src b/sc/source/ui/src/scfuncs.src
index 05422b62a4b9..2584abe3105f 100644
--- a/sc/source/ui/src/scfuncs.src
+++ b/sc/source/ui/src/scfuncs.src
@@ -2341,7 +2341,7 @@ StringArray 
SC_OPCODE_MEDIAN+RID_SC_FUNC_DESCRIPTIONS_START
 < "Number 1, number 2, ... are 1 to 30 numerical arguments which 
portray a sample." ; >;
 };
 };
- // -=*# Resource for function PERCENTIL #*=-
+ // -=*# Resource for function PERCENTILE #*=-
 StringArray SC_OPCODE_PERCENTILE+RID_SC_FUNC_DESCRIPTIONS_START
 {
 ItemList [ en-US ] =
diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index e794ea8c4bc8..4f43c9d77244 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -4072,7 +4072,7 @@ ScAnnotationsObj::~ScAnnotationsObj()
 
 void ScAnnotationsObj::Notify( SfxBroadcaster&, const SfxHint& rHint )
 {
-//! adjust nTab when updatig references!!!
+//! adjust nTab when updating references!!!
 
 if ( rHint.GetId() == SfxHintId::Dying )
 {
diff --git a/sc/source/ui/unoobj/shapeuno.cxx b/sc/source/ui/unoobj/shapeuno.cxx
index f53ad8d6708d..8c08a3aad1db 100644
--- a/sc/source/ui/unoobj/shapeuno.cxx
+++ b/sc/source/ui/unoobj/shapeuno.cxx
@@ -414,7 +414,7 @@ void SAL_CALL ScShapeObj::setPropertyValue(const OUString& 
aPropertyName, const
 ScDrawObjData aAnchor;
   

[Libreoffice-commits] core.git: include/ucbhelper include/unotools include/vbahelper include/vcl

[Andrea Gelmini]

 include/ucbhelper/cancelcommandexecution.hxx |2 +-
 include/ucbhelper/providerhelper.hxx |2 +-
 include/unotools/configvaluecontainer.hxx|2 +-
 include/vbahelper/vbaeventshelperbase.hxx|2 +-
 include/vcl/graphictools.hxx |2 +-
 include/vcl/help.hxx |2 +-
 include/vcl/menu.hxx |2 +-
 include/vcl/pdfwriter.hxx|2 +-
 include/vcl/prntypes.hxx |2 +-
 include/vcl/splitwin.hxx |2 +-
 include/vcl/svapp.hxx|2 +-
 include/vcl/texteng.hxx  |2 +-
 include/vcl/vclptr.hxx   |2 +-
 13 files changed, 13 insertions(+), 13 deletions(-)

New commits:
commit feeb8ccfe1aff373e158b64f76e35da1a4e295c0
Author: Andrea Gelmini 
Date:   Fri Mar 24 11:44:02 2017 +0100

Fix typos

Change-Id: Ia8bd59be341b0731198d48df974b60ecb04e289c
Reviewed-on: https://gerrit.libreoffice.org/35635
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/include/ucbhelper/cancelcommandexecution.hxx 
b/include/ucbhelper/cancelcommandexecution.hxx
index 381d63c27645..eeb8b5ba7c2e 100644
--- a/include/ucbhelper/cancelcommandexecution.hxx
+++ b/include/ucbhelper/cancelcommandexecution.hxx
@@ -71,7 +71,7 @@ UCBHELPER_DLLPUBLIC void cancelCommandExecution( const 
css::uno::Any & rExceptio
 
 @param eError is an IO error code.
 
-@param rArgs is a sequeence containing the arguments to pass along with
+@param rArgs is a sequence containing the arguments to pass along with
the exception. Each IO error code can be combined with one or
more additional arguments. Refer to 
com/sun/star/ucb/IOErroprCode.idl
for details.
diff --git a/include/ucbhelper/providerhelper.hxx 
b/include/ucbhelper/providerhelper.hxx
index 8bff1126862f..287eca580a52 100644
--- a/include/ucbhelper/providerhelper.hxx
+++ b/include/ucbhelper/providerhelper.hxx
@@ -112,7 +112,7 @@ protected:
   * This method registers a newly created content instance with the
   * content provider. It should be called directly after creating a new
   * content instance. The provider can reuse a registered instance upon
-  * subsedent requests for content instances with an idententifier
+  * subsequent requests for content instances with an identifier
   * of a registered instance.
   * Note that the provider does not hold a hard reference on the
   * registered instance. If last external reference is gone, the provider
diff --git a/include/unotools/configvaluecontainer.hxx 
b/include/unotools/configvaluecontainer.hxx
index e2243c108891..267474fce863 100644
--- a/include/unotools/configvaluecontainer.hxx
+++ b/include/unotools/configvaluecontainer.hxx
@@ -67,7 +67,7 @@ namespace utl
 specifies the service factory which should be used to access 
the configuration
 @param _rAccessSafety
 As this class is intended to manipulate objects it does not 
hold itself (see the various
-registerXXX methods), it needs to guard these access for muti 
threading safety.
+registerXXX methods), it needs to guard these access for multi 
threading safety.
 The mutex given here is locked whenever such an access occurs.
 @param _pConfigLocation
 is an ASCII string describing the configurations node path
diff --git a/include/vbahelper/vbaeventshelperbase.hxx 
b/include/vbahelper/vbaeventshelperbase.hxx
index 774111269569..81379c33eb2c 100644
--- a/include/vbahelper/vbaeventshelperbase.hxx
+++ b/include/vbahelper/vbaeventshelperbase.hxx
@@ -130,7 +130,7 @@ protected:
 };
 typedef ::std::deque< EventQueueEntry > EventQueue;
 
-/** Derived classes do additional prpeparations and return whether the
+/** Derived classes do additional preparations and return whether the
 event handler has to be called.
 
 @throws css::uno::RuntimeException
diff --git a/include/vcl/graphictools.hxx b/include/vcl/graphictools.hxx
index 42d81ff9484f..6979e97e78e0 100644
--- a/include/vcl/graphictools.hxx
+++ b/include/vcl/graphictools.hxx
@@ -239,7 +239,7 @@ public:
 {
 /// horizontal parallel lines, one unit apart
 hatchSingle=0,
-/// horizontal and verticall orthogonally crossing lines, one unit 
apart
+/// horizontal and vertical orthogonally crossing lines, one unit apart
 hatchDouble,
 /// three crossing lines, like HatchType::hatchDouble, but
 /// with an additional diagonal line, rising to the upper
diff --git a/include/vcl/help.hxx b/include/vcl/help.hxx
index bd56413aca3b..f89de301aaed 100644
--- a/include/vcl/help.hxx
+++ b/include/vcl/help.hxx
@@ -41,7 +41,7 @@ enum class QuickHelpFlags
 Bottom= 0x0020,
 NoAutoPos = Left | Center | Right | Top | VCenter |

[Libreoffice-commits] core.git: drawinglayer/source dtrans/source

[Andrea Gelmini]

 drawinglayer/source/attribute/linestartendattribute.cxx  |2 +-
 drawinglayer/source/geometry/viewinformation3d.cxx   |2 +-
 drawinglayer/source/primitive2d/primitivetools2d.cxx |2 +-
 drawinglayer/source/primitive2d/textdecoratedprimitive2d.cxx |2 +-
 drawinglayer/source/primitive2d/wrongspellprimitive2d.cxx|2 +-
 drawinglayer/source/primitive3d/hatchtextureprimitive3d.cxx  |2 +-
 drawinglayer/source/primitive3d/sdrextrudelathetools3d.cxx   |2 +-
 drawinglayer/source/processor2d/helperwrongspellrenderer.hxx |2 +-
 drawinglayer/source/processor2d/vclhelperbufferdevice.hxx|2 +-
 drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx   |2 +-
 drawinglayer/source/processor3d/zbufferprocessor3d.cxx   |2 +-
 dtrans/source/win32/clipb/WinClipbImpl.cxx   |2 +-
 dtrans/source/win32/clipb/WinClipboard.hxx   |2 +-
 dtrans/source/win32/dnd/source.cxx   |2 +-
 dtrans/source/win32/dtobj/XTDataObject.cxx   |4 ++--
 15 files changed, 16 insertions(+), 16 deletions(-)

New commits:
commit ddc1429bf34bff7457849fbd6ff6cc96b87bfbba
Author: Andrea Gelmini 
Date:   Fri Mar 24 14:43:46 2017 +0100

Fix typos

Change-Id: I85214642167d9c7876fd0fdc2cb7cf8e85765614
Reviewed-on: https://gerrit.libreoffice.org/35627
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/drawinglayer/source/attribute/linestartendattribute.cxx 
b/drawinglayer/source/attribute/linestartendattribute.cxx
index c156d2a66659..1c0c91c5fd5b 100644
--- a/drawinglayer/source/attribute/linestartendattribute.cxx
+++ b/drawinglayer/source/attribute/linestartendattribute.cxx
@@ -34,7 +34,7 @@ namespace drawinglayer
 double  mfWidth;// 
absolute line StartEndGeometry base width
 basegfx::B2DPolyPolygon maPolyPolygon;  // 
the StartEndGeometry PolyPolygon
 
-boolmbCentered : 1; // 
use centered to ineStart/End point?
+boolmbCentered : 1; // 
use centered to lineStart/End point?
 
 ImpLineStartEndAttribute(
 double fWidth,
diff --git a/drawinglayer/source/geometry/viewinformation3d.cxx 
b/drawinglayer/source/geometry/viewinformation3d.cxx
index 1e6693c0e517..ab16e6125d46 100644
--- a/drawinglayer/source/geometry/viewinformation3d.cxx
+++ b/drawinglayer/source/geometry/viewinformation3d.cxx
@@ -120,7 +120,7 @@ namespace drawinglayer
 return OUString("Time");
 }
 
-// a central PropertyValue parsing method to allow transportatin of
+// a central PropertyValue parsing method to allow transportation 
of
 // all ViewParameters using UNO API
 void impInterpretPropertyValues(const uno::Sequence< 
beans::PropertyValue >& rViewParameters)
 {
diff --git a/drawinglayer/source/primitive2d/primitivetools2d.cxx 
b/drawinglayer/source/primitive2d/primitivetools2d.cxx
index e98daad763bf..6507e9384f7e 100644
--- a/drawinglayer/source/primitive2d/primitivetools2d.cxx
+++ b/drawinglayer/source/primitive2d/primitivetools2d.cxx
@@ -121,7 +121,7 @@ namespace drawinglayer
 {
 ::osl::MutexGuard aGuard( m_aMutex );
 
-// get the current ViewTransfromation
+// get the current ViewTransformation
 const basegfx::B2DHomMatrix& rViewTransformation = 
rViewInformation.getViewTransformation();
 
 if(!getBuffered2DDecomposition().empty() && rViewTransformation != 
getViewTransformation())
diff --git a/drawinglayer/source/primitive2d/textdecoratedprimitive2d.cxx 
b/drawinglayer/source/primitive2d/textdecoratedprimitive2d.cxx
index c97e37c7aae1..4d2abbfe5d3c 100644
--- a/drawinglayer/source/primitive2d/textdecoratedprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/textdecoratedprimitive2d.cxx
@@ -375,7 +375,7 @@ namespace drawinglayer
 basegfx::B2DRange TextDecoratedPortionPrimitive2D::getB2DRange(const 
geometry::ViewInformation2D& rViewInformation) const
 {
 // check if this needs to be a TextDecoratedPortionPrimitive2D or
-// if a TextSimplePortionPrimitive2D would be suficcient
+// if a TextSimplePortionPrimitive2D would be sufficient
 if (TEXT_LINE_NONE != getFontOverline()
  || TEXT_LINE_NONE != getFontUnderline()
  || TEXT_STRIKEOUT_NONE != getTextStrikeout()
diff --git a/drawinglayer/source/primitive2d/wrongspellprimitive2d.cxx 
b/drawinglayer/source/primitive2d/wrongspellprimitive2d.cxx
index f0e780264b36..cbb29d08f42b 100644
--- a/drawinglayer/source/primitive2d/wrongspellprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/wrongspellprimitive2d.cxx
@@ -52,7 +52,7 @@ namespace drawinglayer
 const do

[Libreoffice-commits] core.git: svx/inc svx/source

[Andrea Gelmini]

 svx/inc/sdr/contact/viewcontactofgraphic.hxx|2 +-
 svx/inc/sdr/properties/attributeproperties.hxx  |2 +-
 svx/source/accessibility/AccessibleControlShape.cxx |2 +-
 svx/source/customshapes/EnhancedCustomShapeGeometry.cxx |2 +-
 svx/source/dialog/dlgctl3d.cxx  |2 +-
 svx/source/dialog/docrecovery.cxx   |2 +-
 svx/source/dialog/fntctrl.cxx   |2 +-
 svx/source/dialog/framelink.cxx |2 +-
 svx/source/engine3d/view3d.cxx  |2 +-
 svx/source/fmcomp/fmgridcl.cxx  |2 +-
 svx/source/fmcomp/fmgridif.cxx  |4 ++--
 svx/source/form/fmshell.cxx |2 +-
 svx/source/sdr/contact/viewcontactofvirtobj.cxx |2 +-
 svx/source/sdr/contact/viewobjectcontact.cxx|2 +-
 svx/source/sdr/overlay/overlaymanagerbuffered.cxx   |2 +-
 svx/source/svdraw/svdograf.cxx  |2 +-
 svx/source/unodraw/UnoGraphicExporter.cxx   |2 +-
 17 files changed, 18 insertions(+), 18 deletions(-)

New commits:
commit 98f18df02357523a1c2c52efd36171f9328ab6d4
Author: Andrea Gelmini 
Date:   Fri Mar 24 12:52:52 2017 +0100

Fix typos

Change-Id: I77cf7fe3a57c031877facf5252b5a900526db48b
Reviewed-on: https://gerrit.libreoffice.org/35646
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/svx/inc/sdr/contact/viewcontactofgraphic.hxx 
b/svx/inc/sdr/contact/viewcontactofgraphic.hxx
index a64d392cdcdf..eee418387bd6 100644
--- a/svx/inc/sdr/contact/viewcontactofgraphic.hxx
+++ b/svx/inc/sdr/contact/viewcontactofgraphic.hxx
@@ -65,7 +65,7 @@ namespace sdr
 // #i102380#
 void flushGraphicObjects();
 
-// helpers for viusualisation state
+// helpers for visualisation state
 bool visualisationUsesPresObj() const;
 bool visualisationUsesDraft() const;
 
diff --git a/svx/inc/sdr/properties/attributeproperties.hxx 
b/svx/inc/sdr/properties/attributeproperties.hxx
index 87ec2975b8ae..b60794c05904 100644
--- a/svx/inc/sdr/properties/attributeproperties.hxx
+++ b/svx/inc/sdr/properties/attributeproperties.hxx
@@ -38,7 +38,7 @@ namespace sdr
 void ImpRemoveStyleSheet();
 
 protected:
-// the SytleSheet of this object
+// the StyleSheet of this object
 SfxStyleSheet*  mpStyleSheet;
 
 // create a new itemset
diff --git a/svx/source/accessibility/AccessibleControlShape.cxx 
b/svx/source/accessibility/AccessibleControlShape.cxx
index c79a01a149c1..8a48a98faa6c 100644
--- a/svx/source/accessibility/AccessibleControlShape.cxx
+++ b/svx/source/accessibility/AccessibleControlShape.cxx
@@ -169,7 +169,7 @@ void AccessibleControlShape::Init()
 // way future-proof - as soon as an inner context appears which 
implements an additional interface,
 // we would need to adjust our implementation to support this new 
interface, too. Bad idea.
 
-// The usual solution for such a problem is aggregation. Aggregation 
means using UNO's own meachnisms
+// The usual solution for such a problem is aggregation. Aggregation 
means using UNO's own mechanism
 // for merging an inner with an outer component, and get a component 
which behaves as it is exactly one.
 // This is what XAggregation is for. Unfortunately, aggregation 
requires _exact_ control over the ref count
 // of the inner object, which we do not have at all.
diff --git a/svx/source/customshapes/EnhancedCustomShapeGeometry.cxx 
b/svx/source/customshapes/EnhancedCustomShapeGeometry.cxx
index 9608dc454fed..c2f8109af231 100644
--- a/svx/source/customshapes/EnhancedCustomShapeGeometry.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeGeometry.cxx
@@ -6743,7 +6743,7 @@ static const SvxMSDffCalculationData 
mso_sptTextArchCurveCalc[] =
 };
 static const sal_uInt16 mso_sptTextArchUpCurveSegm[] =
 {
-0xA504, 0x8000  // clockwíse arc
+0xA504, 0x8000  // clockwise arc
 };
 static const SvxMSDffHandle mso_sptTextArchUpCurveHandle[] =
 {
diff --git a/svx/source/dialog/dlgctl3d.cxx b/svx/source/dialog/dlgctl3d.cxx
index cd103ce9850e..80249e75f8eb 100644
--- a/svx/source/dialog/dlgctl3d.cxx
+++ b/svx/source/dialog/dlgctl3d.cxx
@@ -614,7 +614,7 @@ void Svx3DLightControl::Tracking( const TrackingEvent& 
rTEvt )
 }
 else
 {
-// intercation start, save values
+// interaction start, save values
 GetPosition(mfSaveActionStartHor, mfSaveActionStartVer);
 }
 
diff --git a/svx/source/dialog/docrecovery.cxx 
b/svx/source/dialog/docrecovery.cxx
index e76dbcfeb8f8..7d48d705438d 100644
--- a/svx/source/dialog/docrecovery.cxx
+++ b/svx/s

[Libreoffice-commits] core.git: sc/inc sc/qa sc/source

[Andrea Gelmini]

 sc/inc/markdata.hxx   |2 +-
 sc/qa/unit/subsequent_filters-test.cxx|4 ++--
 sc/qa/unit/ucalc_formula.cxx  |2 +-
 sc/qa/unit/ucalc_sort.cxx |2 +-
 sc/source/core/data/dociter.cxx   |2 +-
 sc/source/core/data/documen3.cxx  |2 +-
 sc/source/core/data/formulacell.cxx   |2 +-
 sc/source/core/data/table2.cxx|2 +-
 sc/source/core/opencl/op_spreadsheet.cxx  |2 +-
 sc/source/core/tool/chartpos.cxx  |2 +-
 sc/source/core/tool/formulaopt.cxx|2 +-
 sc/source/core/tool/interpr3.cxx  |2 +-
 sc/source/core/tool/interpr5.cxx  |2 +-
 sc/source/core/tool/interpr8.cxx  |4 ++--
 sc/source/filter/excel/xichart.cxx|2 +-
 sc/source/filter/excel/xihelper.cxx   |2 +-
 sc/source/filter/inc/scflt.hxx|2 +-
 sc/source/filter/inc/xiescher.hxx |2 +-
 sc/source/filter/oox/pivotcachebuffer.cxx |2 +-
 sc/source/filter/xml/pivotsource.hxx  |2 +-
 20 files changed, 22 insertions(+), 22 deletions(-)

New commits:
commit ad4104090de1cb07fb82bb40c736271103e4ed69
Author: Andrea Gelmini 
Date:   Fri Mar 24 12:45:11 2017 +0100

Fix typos

Change-Id: Ia17fe891f8a681ada69639ca579ebf6d6d781759
Reviewed-on: https://gerrit.libreoffice.org/35641
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/sc/inc/markdata.hxx b/sc/inc/markdata.hxx
index d11173c301fd..2f182eeb9426 100644
--- a/sc/inc/markdata.hxx
+++ b/sc/inc/markdata.hxx
@@ -142,7 +142,7 @@ public:
 voidInsertTab( SCTAB nTab );
 voidDeleteTab( SCTAB nTab );
 
-// Generate envelopes if mutimarked and fills the passed ScRange object 
with
+// Generate envelopes if multimarked and fills the passed ScRange object 
with
 // the smallest range that includes the marked area plus its envelopes.
 voidGetSelectionCover( ScRange& rRange );
 // Get top, bottom, left and right envelopes
diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index 81bb3dc719d0..29a8802bf1e0 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -668,7 +668,7 @@ void ScFiltersTest::testCachedFormulaResultsODS()
 //we want to me sure that volatile functions are always recalculated
 //regardless of cached results.  if you update the ods file, you must
 //update the values here.
-//if NOW() is recacluated, then it should never equal sTodayCache
+//if NOW() is recalcuated, then it should never equal sTodayCache
 OUString sTodayCache("01/25/13 01:06 PM");
 OUString sTodayRecalc(rDoc.GetString(0,0,1));
 
@@ -1012,7 +1012,7 @@ struct Border
 SvxBorderLineStyle tStyle;
 SvxBorderLineStyle rStyle;
 SvxBorderLineStyle bStyle;
-// that's a monstrum
+// that's a monster
 Border(sal_Int16 col, sal_Int32 r, sal_Int32 lW, sal_Int32 tW, sal_Int32 
rW, sal_Int32 bW, sal_uInt16 lOutW, sal_uInt16 lInW,
 sal_uInt16 lDist, sal_uInt16 tOutW, sal_uInt16 tInW, sal_uInt16 tDist, 
sal_uInt16 rOutW, sal_uInt16 rInW, sal_uInt16 rDist,
 sal_uInt16 bOutW, sal_uInt16 bInW, sal_uInt16 bDist, sal_Int16 lSt, 
sal_Int16 tSt, sal_Int16 rSt, sal_Int16 bSt):
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index c7f47709eca1..a10f552933e6 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -187,7 +187,7 @@ void Test::testFormulaCreateStringFromTokens()
 
 sc::TokenStringContext aCxt(m_pDoc, formula::FormulaGrammar::GRAM_ENGLISH);
 
-// Artificially add external refererence data after the context object is
+// Artificially add external reference data after the context object is
 // initialized.
 aCxt.maExternalFileNames.push_back("file:///path/to/fake.file");
 std::vector aExtTabNames;
diff --git a/sc/qa/unit/ucalc_sort.cxx b/sc/qa/unit/ucalc_sort.cxx
index 7a071c37269f..719ea1ab6a52 100644
--- a/sc/qa/unit/ucalc_sort.cxx
+++ b/sc/qa/unit/ucalc_sort.cxx
@@ -398,7 +398,7 @@ void Test::testSortWithFormulaRefs()
 for (SCROW i = 1; i <= 4; ++i)
 m_pDoc->SetString( 0, i, 0, OUString::createFromAscii(aTextData[i-1]) 
);
 
-// Insert forumulas in A1:A6 on the 2nd sheet.
+// Insert formulas in A1:A6 on the 2nd sheet.
 for (size_t i = 0; i < SAL_N_ELEMENTS(aFormulaData); ++i)
 m_pDoc->SetString( 0, i, 1, OUString::createFromAscii(aFormulaData[i]) 
);
 
diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx
index a223b48a52cd..c0d534d25073 100644
--- a/sc/source/core/data/dociter.cxx
+++ b/sc/source/core/data/dociter.cxx
@@ -2076,7 +2076,7 @@ bool ScHorizontalCellIterator::SkipInvalidInRow()
 }
 else
 {
-debugiter("advanced column %d to block starting row %d, 
retying\n",
+ 

[Libreoffice-commits] core.git: dbaccess/source

[Andrea Gelmini]

 dbaccess/source/core/dataaccess/databasecontext.cxx  |2 +-
 dbaccess/source/core/dataaccess/datasource.hxx   |2 +-
 dbaccess/source/ext/macromigration/migrationengine.cxx   |2 +-
 dbaccess/source/ui/app/AppController.hxx |2 +-
 dbaccess/source/ui/browser/brwctrlr.cxx  |2 +-
 dbaccess/source/ui/control/dbtreelistbox.cxx |2 +-
 dbaccess/source/ui/dlg/tablespage.hxx|2 +-
 dbaccess/source/ui/inc/defaultobjectnamecheck.hxx|2 +-
 dbaccess/source/ui/inc/querycontainerwindow.hxx  |2 +-
 dbaccess/source/ui/querydesign/QueryTableView.cxx|4 ++--
 dbaccess/source/ui/querydesign/TableWindow.cxx   |2 +-
 dbaccess/source/ui/relationdesign/RelationController.cxx |2 +-
 dbaccess/source/ui/tabledesign/TEditControl.cxx  |2 +-
 13 files changed, 14 insertions(+), 14 deletions(-)

New commits:
commit 3c8efc29d6c0fd3c8d819cc38c2fa0c4385cbfb6
Author: Andrea Gelmini 
Date:   Sat Mar 25 09:41:15 2017 +0100

Fix typos

Change-Id: If350d22ed9365fa8924dc049f23d7f5cd92b9872
Reviewed-on: https://gerrit.libreoffice.org/35625
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/dbaccess/source/core/dataaccess/databasecontext.cxx 
b/dbaccess/source/core/dataaccess/databasecontext.cxx
index 99e4668a7706..6bf904125df9 100644
--- a/dbaccess/source/core/dataaccess/databasecontext.cxx
+++ b/dbaccess/source/core/dataaccess/databasecontext.cxx
@@ -652,7 +652,7 @@ Any ODatabaseContext::getByName(const OUString& _rName)
 throw;
 }
 catch (const Exception&)
-{   // exceptions other than the speciafied ones -> wrap
+{   // exceptions other than the specified ones -> wrap
 Any aError = ::cppu::getCaughtException();
 throw WrappedTargetException(_rName, *this, aError );
 }
diff --git a/dbaccess/source/core/dataaccess/datasource.hxx 
b/dbaccess/source/core/dataaccess/datasource.hxx
index 8fa26c50cce1..b508c599b2b3 100644
--- a/dbaccess/source/core/dataaccess/datasource.hxx
+++ b/dbaccess/source/core/dataaccess/datasource.hxx
@@ -100,7 +100,7 @@ public:
 
 Normally, this name is passed at time of creation of the 
ODatabaseModelImpl instance,
 but if a newly created data source is registered, then it must be 
possible to propagate
-the new trgistration name.
+the new registration name.
 */
 static void setName(
 const css::uno::Reference< css::sdb::XDocumentDataSource >& 
_rxDocument,
diff --git a/dbaccess/source/ext/macromigration/migrationengine.cxx 
b/dbaccess/source/ext/macromigration/migrationengine.cxx
index def0bf7274f0..1bd5d908b475 100644
--- a/dbaccess/source/ext/macromigration/migrationengine.cxx
+++ b/dbaccess/source/ext/macromigration/migrationengine.cxx
@@ -1161,7 +1161,7 @@ namespace dbmm
 // "too many" invalid characters, or the name composed with the 
base name was already used.
 // (The latter is valid, since there can be multiple sub documents 
with the same base name,
 // in different levels in the hierarchy.)
-// In this case, just use the umambiguous sub document number.
+// In this case, just use the unambiguous sub document number.
 return sPrefix + OUString::number( _rDocument.nNumber ) + "_" + 
_rSourceLibName;
 }
 }
diff --git a/dbaccess/source/ui/app/AppController.hxx 
b/dbaccess/source/ui/app/AppController.hxx
index 24dbc9c7e749..81323fd6e5e9 100644
--- a/dbaccess/source/ui/app/AppController.hxx
+++ b/dbaccess/source/ui/app/AppController.hxx
@@ -272,7 +272,7 @@ namespace dbaui
 */
 void addContainerListener(const css::uno::Reference< 
css::container::XNameAccess>& _xCollection);
 
-/** opens a uno dialog withthe currently selected data source as 
initialize argument
+/** opens a uno dialog with the currently selected data source as 
initialize argument
 @param  _sServiceName
 The service name of the dialog to be executed.
 */
diff --git a/dbaccess/source/ui/browser/brwctrlr.cxx 
b/dbaccess/source/ui/browser/brwctrlr.cxx
index 1c26dc89d13d..e891ab85c1d0 100644
--- a/dbaccess/source/ui/browser/brwctrlr.cxx
+++ b/dbaccess/source/ui/browser/brwctrlr.cxx
@@ -2403,7 +2403,7 @@ IMPL_LINK(SbaXDataBrowserController, OnCanceledNotFound, 
FmFoundRecordInformatio
 
 try
 {
-// let the grid snyc its display with the cursor
+// let the grid sync its display with the cursor
 Reference< XPropertySet >  xModelSet(getControlModel(), UNO_QUERY);
 OSL_ENSURE(xModelSet.is(), 
"SbaXDataBrowserController::OnCanceledNotFound : no model set ?!");
 Any aOld = xModelSet->getPropertyValue("DisplayIsSynchron");
diff --git a/dbaccess/source/ui/control/dbtreelistbox.cxx 
b/dbaccess/source/ui/control/dbtreelistbox.cxx
index 1eac063f9dc3..dc6537b4c3c6 100644
--- a/dbacce

[Libreoffice-commits] core.git: desktop/qa desktop/source desktop/test

[Andrea Gelmini]

 desktop/qa/desktop_lib/test_desktop_lib.cxx   |4 
++--
 desktop/source/app/dispatchwatcher.hxx|2 +-
 desktop/source/app/officeipcthread.cxx|2 +-
 desktop/source/deployment/inc/lockfile.hxx|2 +-
 desktop/source/deployment/manager/dp_activepackages.hxx   |2 +-
 desktop/source/deployment/manager/dp_extensionmanager.cxx |2 +-
 desktop/source/deployment/manager/dp_manager.cxx  |2 +-
 desktop/source/deployment/misc/dp_misc.cxx|2 +-
 desktop/source/deployment/misc/dp_ucb.cxx |2 +-
 desktop/source/deployment/registry/configuration/dp_configuration.cxx |2 +-
 desktop/source/deployment/registry/package/dp_package.cxx |2 +-
 desktop/source/deployment/registry/script/dp_script.cxx   |2 +-
 desktop/source/deployment/registry/sfwk/dp_sfwk.cxx   |2 +-
 desktop/source/lib/init.cxx   |4 
++--
 desktop/source/pkgchk/unopkg/unopkg_app.cxx   |2 +-
 desktop/test/deployment/update/license/readme.txt |2 +-
 desktop/test/deployment/update/wrong_url/readme.txt   |2 +-
 17 files changed, 19 insertions(+), 19 deletions(-)

New commits:
commit b93201ffc6ab4908e25bbfbf4337354c09b5c07a
Author: Andrea Gelmini 
Date:   Fri Mar 24 10:40:07 2017 +0100

Fix typos

Change-Id: I4b2eac5c999771b10e65fedebdab1d4ef435b367
Reviewed-on: https://gerrit.libreoffice.org/35626
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 
Tested-by: Jenkins 

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index bbf8ac91afc7..aac2b3ad078b 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -459,7 +459,7 @@ void DesktopLOKTest::testPaintTile()
 int nTileWidth = 1000;
 int nTileHeight = 3000;
 
-// This used to crash: painTile() implementation did not handle
+// This used to crash: paintTile() implementation did not handle
 // nCanvasWidth != nCanvasHeight correctly, as usually both are just always
 // 256.
 pDocument->pClass->paintTile(pDocument, aBuffer.data(), nCanvasWidth, 
nCanvasHeight, nTilePosX, nTilePosY, nTileWidth, nTileHeight);
@@ -1362,7 +1362,7 @@ void DesktopLOKTest::testNotificationCompression()
 handler->queue(LOK_CALLBACK_MOUSE_POINTER, "text"); // Should be dropped.
 handler->queue(LOK_CALLBACK_TEXT_SELECTION_START, "15, 25, 15, 10"); // 
Superseded.
 handler->queue(LOK_CALLBACK_TEXT_SELECTION_END, "15, 25, 15, 10"); // 
Superseded.
-handler->queue(LOK_CALLBACK_TEXT_SELECTION, "15, 25, 15, 10"); // 
Superseedd.
+handler->queue(LOK_CALLBACK_TEXT_SELECTION, "15, 25, 15, 10"); // 
Superseded.
 handler->queue(LOK_CALLBACK_TEXT_SELECTION_START, "15, 25, 15, 10"); // 
Should be dropped.
 handler->queue(LOK_CALLBACK_TEXT_SELECTION_END, "15, 25, 15, 10"); // 
Should be dropped.
 handler->queue(LOK_CALLBACK_TEXT_SELECTION, ""); // 7
diff --git a/desktop/source/app/dispatchwatcher.hxx 
b/desktop/source/app/dispatchwatcher.hxx
index 45f66201c83b..b8a70c08e33b 100644
--- a/desktop/source/app/dispatchwatcher.hxx
+++ b/desktop/source/app/dispatchwatcher.hxx
@@ -34,7 +34,7 @@ namespace desktop
 /*
 Class for controls dispatching of command URL through office command line. 
There
 are "dangerous" command URLs, that can result in a running office without 
UI. To prevent
-this situation the implementation surveille all dispatches and looks for 
an open task if
+this situation the implementation monitors all dispatches and looks for an 
open task if
 there is arose a problem. If there is none the office will be shutdown to 
prevent a
 running office without UI.
 */
diff --git a/desktop/source/app/officeipcthread.cxx 
b/desktop/source/app/officeipcthread.cxx
index d431e299f10a..f48260507dca 100644
--- a/desktop/source/app/officeipcthread.cxx
+++ b/desktop/source/app/officeipcthread.cxx
@@ -1198,7 +1198,7 @@ void PipeIpcThread::execute()
 // we might have decided to shutdown while we were sleeping
 if (!RequestHandler::pGlobal.is()) return;
 
-// only lock the mutex when processing starts, othewise we 
deadlock when the office goes
+// only lock the mutex when processing starts, otherwise we 
deadlock when the office goes
 // down during wait
 osl::ClearableMutexGuard aGuard( RequestHandler::GetMutex() );
 
diff --git a/desktop/source/deployment/inc/lockfile.hxx 
b/desktop/source/deployment/inc/lockfile.hxx
index f3f1da28d07a..68dbb8ee0df2 100644
--- a/desktop/source/deployment/inc/lockfile.hxx
+++ b/desktop/source/deployment/inc/lockfile.hxx
@@ -19,7 +19,7 

[Libreoffice-commits] core.git: sw/source sysui/desktop

[Andrea Gelmini]

 sw/source/core/swg/SwXMLTextBlocks1.cxx  |2 +-
 sw/source/core/text/blink.cxx|2 +-
 sw/source/core/text/itrform2.cxx |4 ++--
 sw/source/core/text/pormulti.cxx |2 +-
 sw/source/core/text/txtfly.cxx   |2 +-
 sw/source/core/text/txtfrm.cxx   |2 +-
 sw/source/core/text/widorp.cxx   |2 +-
 sw/source/core/txtnode/ndhints.cxx   |2 +-
 sw/source/core/undo/rolbck.cxx   |2 +-
 sw/source/core/unocore/unodraw.cxx   |2 +-
 sw/source/core/unocore/unosett.cxx   |2 +-
 sw/source/core/unocore/unostyle.cxx  |2 +-
 sw/source/filter/html/css1atr.cxx|2 +-
 sw/source/filter/html/htmlatr.cxx|2 +-
 sw/source/filter/html/htmlfldw.cxx   |2 +-
 sw/source/filter/html/htmltab.cxx|6 +++---
 sw/source/filter/inc/msfilter.hxx|2 +-
 sw/source/filter/ww8/docxattributeoutput.cxx |2 +-
 sw/source/filter/ww8/wrtw8nds.cxx|2 +-
 sw/source/filter/ww8/ww8graf.cxx |4 ++--
 sw/source/filter/ww8/ww8par.cxx  |2 +-
 sw/source/filter/ww8/ww8par3.cxx |2 +-
 sw/source/filter/ww8/ww8par5.cxx |2 +-
 sw/source/filter/ww8/ww8scan.hxx |2 +-
 sw/source/filter/ww8/ww8toolbar.cxx  |2 +-
 sw/source/filter/xml/xmltbli.cxx |2 +-
 sw/source/ui/fldui/fldui.src |2 +-
 sw/source/ui/vba/vbainformationhelper.cxx|2 +-
 sw/source/ui/vba/vbaselection.cxx|4 ++--
 sw/source/uibase/app/docstyle.cxx|4 ++--
 sw/source/uibase/dbui/README |2 +-
 sw/source/uibase/docvw/edtwin.cxx|2 +-
 sw/source/uibase/inc/edtwin.hxx  |2 +-
 sw/source/uibase/inc/prcntfld.hxx|2 +-
 sw/source/uibase/wrtsh/navmgr.cxx|2 +-
 sw/source/uibase/wrtsh/wrtsh1.cxx|2 +-
 sw/source/uibase/wrtsh/wrtsh4.cxx|2 +-
 sysui/desktop/freedesktop/freedesktop-menus.spec |2 +-
 38 files changed, 44 insertions(+), 44 deletions(-)

New commits:
commit ea0b508025ebe074e25d0250d0ce5e5444ea6a76
Author: Andrea Gelmini 
Date:   Sat Mar 25 09:51:46 2017 +0100

Fix typos

Change-Id: I52604902247e7d8565476fafe98211fff32c5543
Reviewed-on: https://gerrit.libreoffice.org/35658
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/sw/source/core/swg/SwXMLTextBlocks1.cxx 
b/sw/source/core/swg/SwXMLTextBlocks1.cxx
index 7dc7aa32ed19..74dcad77e6cc 100644
--- a/sw/source/core/swg/SwXMLTextBlocks1.cxx
+++ b/sw/source/core/swg/SwXMLTextBlocks1.cxx
@@ -215,7 +215,7 @@ sal_uLong SwXMLTextBlocks::GetMacroTable( sal_uInt16 nIdx,
 sFilterComponent, aFilterArguments, xContext),
 UNO_QUERY );
 OSL_ENSURE( xFilter.is(),
-"can't instantiate atevents filter");
+"can't instantiate atevent filter");
 if ( xFilter.is() )
 {
 // connect parser and filter
diff --git a/sw/source/core/text/blink.cxx b/sw/source/core/text/blink.cxx
index 74fff44c60e9..5602fd1024de 100644
--- a/sw/source/core/text/blink.cxx
+++ b/sw/source/core/text/blink.cxx
@@ -32,7 +32,7 @@
 /**
  * pBlink points to the instance where blinking portions need to register.
  * If necessary, it needs to be created by SwBlink.
- * They are then triggered rhythimcally for a repaint. They can query
+ * They are then triggered rhythmically for a repaint. They can query
  * for being visible or invisible with IsVisible().
  */
 SwBlink *pBlink = nullptr;
diff --git a/sw/source/core/text/itrform2.cxx b/sw/source/core/text/itrform2.cxx
index 22604422d285..1e4f6929b7c7 100644
--- a/sw/source/core/text/itrform2.cxx
+++ b/sw/source/core/text/itrform2.cxx
@@ -185,7 +185,7 @@ SwLinePortion *SwTextFormatter::Underflow( SwTextFormatInfo 
&rInf )
 {
 // pPrev will be the last portion before pUnderflow,
 // which still has a real width.
-// Exception: SoftHyphPortions must not be forgotten, of course!
+// Exception: SoftHyphPortion must not be forgotten, of course!
 // Although they don't have a width.
 SwLinePortion *pTmpPrev = pPor;
 while( pPor && pPor != pUnderflow )
@@ -1638,7 +1638,7 @@ sal_Int32 SwTextFormatter::FormatLine(const sal_Int32 
nStartPos)
 flyStarts.clear();
 }
 else
-// Special case: We do not allow an optimitation of the repaint
+// Special case: we do not allow an optimization of the repaint
 // area, but during formatting the repaint offset is set to indicate
 // a maximum value for the offs

[Libreoffice-commits] core.git: compilerplugins/clang solenv/CompilerTest_compilerplugins_clang.mk svtools/source svx/source sw/source

[Stephan Bergmann]

 compilerplugins/clang/loopvartoosmall.cxx  |  239 ++---
 compilerplugins/clang/test/loopvartoosmall.cxx |   24 ++
 solenv/CompilerTest_compilerplugins_clang.mk   |1 
 svtools/source/brwbox/brwbox2.cxx  |4 
 svx/source/fmcomp/gridctrl.cxx |2 
 sw/source/core/frmedt/fetab.cxx|2 
 sw/source/core/text/itrpaint.cxx   |2 
 sw/source/filter/ww8/ww8par6.cxx   |2 
 sw/source/filter/ww8/ww8scan.cxx   |2 
 9 files changed, 207 insertions(+), 71 deletions(-)

New commits:
commit 2258f33a5fd95a5e25f5bb232994ab147d09bfb9
Author: Stephan Bergmann 
Date:   Sat Mar 25 10:55:44 2017 +0100

Make loplugin:loopvartoosmall find more suspicious cases

...where the "controlling expression" of any sort of loop contains a sub-
expression of the form

  var < val

where the type of var is smaller than that of val.  Theoretically, this 
could
turn up lots of false positives, but practically it didn't run into any.  
Most
findings have been cleaned up over the last weeks.  There's just a handful
remaining places that are hard to clean up, so I flagged them here with
(deliberately awkward) sal::static_int_cast for later clean-up.

Change-Id: I0f735d46dda15b9b336150095df65cf247e9d6d3
Reviewed-on: https://gerrit.libreoffice.org/35682
Reviewed-by: Stephan Bergmann 
Tested-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/loopvartoosmall.cxx 
b/compilerplugins/clang/loopvartoosmall.cxx
index aaa664827298..eb4cb96d592d 100644
--- a/compilerplugins/clang/loopvartoosmall.cxx
+++ b/compilerplugins/clang/loopvartoosmall.cxx
@@ -7,11 +7,13 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#include 
-#include 
+#include 
+#include 
+#include 
+#include 
 
 #include "plugin.hxx"
-#include "clang/AST/CXXInheritance.h"
+//#include "clang/AST/CXXInheritance.h"
 
 // Idea from bubli. Check that the index variable in a for loop is able to 
cover the range
 // revealed by the terminating condition.
@@ -30,86 +32,195 @@ public:
 TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
 }
 
-bool VisitForStmt( const ForStmt* stmt );
+bool VisitForStmt( const ForStmt* stmt ) {
+checkExpr(stmt->getCond());
+return true;
+}
+
+bool VisitWhileStmt(WhileStmt const * stmt) {
+checkExpr(stmt->getCond());
+return true;
+}
+
+bool VisitDoStmt(DoStmt const * stmt) {
+checkExpr(stmt->getCond());
+return true;
+}
 
 private:
-StringRef getFilename(SourceLocation loc);
+unsigned getIntValueWidth(QualType type) const;
+
+void checkSubExpr(Expr const * expr, bool positive);
+
+void checkExpr(Expr const * expr);
+
+struct Comparison {
+BinaryOperator const * op;
+unsigned rhsWidth;
+};
 
+struct Comparisons {
+std::list comparisons;
+unsigned lhsWidth;
+};
+
+std::map comparisons_;
 };
 
-StringRef LoopVarTooSmall::getFilename(SourceLocation loc)
-{
-SourceLocation spellingLocation = 
compiler.getSourceManager().getSpellingLoc(loc);
-StringRef name { compiler.getSourceManager().getFilename(spellingLocation) 
};
-return name;
+unsigned LoopVarTooSmall::getIntValueWidth(QualType type) const {
+if (auto const et = type->getAs()) {
+auto const ed = et->getDecl();
+if (!ed->isFixed()) {
+unsigned pos = ed->getNumPositiveBits();
+unsigned neg = ed->getNumNegativeBits();
+return neg == 0 ? std::max(pos, 1U) : std::max(pos + 1, neg);
+}
+}
+return compiler.getASTContext().getIntWidth(type);
 }
 
-bool LoopVarTooSmall::VisitForStmt( const ForStmt* stmt )
-{
-if (ignoreLocation( stmt ))
-return true;
-// ignore sal/ module for now
-StringRef aFileName = getFilename(stmt->getLocStart());
-if (aFileName.startswith(SRCDIR "/sal/")) {
-return true;
+void LoopVarTooSmall::checkSubExpr(Expr const * expr, bool positive) {
+auto const e = expr->IgnoreParenImpCasts();
+if (auto const uo = dyn_cast(e)) {
+if (uo->getOpcode() == UO_LNot) {
+checkSubExpr(uo->getSubExpr(), !positive);
+}
+return;
 }
-
-const Stmt* initStmt = stmt->getInit();
-if (!initStmt || !isa(initStmt))
-return true;
-const DeclStmt* declStmt = dyn_cast(initStmt);
-if (!declStmt->getDeclGroup().isSingleDecl())
-return true;
-const Decl* decl = declStmt->getSingleDecl();
-if (!decl || !isa(decl))
-return true;
-const VarDecl* varDecl = dyn_cast(decl);
-QualType qt = varDecl->getType();
-if (!qt->isIntegralType(compiler.getASTContext()))
-return true;
-uint64_t qt1BitWidth = compiler.getASTContext().getTypeSize(qt);
-
-if (!stmt->getCond() || !isa(stmt->getCond()))
-return true;
-const Bin

[Libreoffice-commits] core.git: compilerplugins/clang solenv/CompilerTest_compilerplugins_clang.mk

[Stephan Bergmann]

 compilerplugins/clang/redundantinline.cxx  |  127 +
 compilerplugins/clang/test/redundantinline.cxx |   14 ++
 compilerplugins/clang/test/redundantinline.hxx |   79 +++
 solenv/CompilerTest_compilerplugins_clang.mk   |1 
 4 files changed, 221 insertions(+)

New commits:
commit 5d8e6901ec14edd9da10d9dee63b2ef2ab058692
Author: Stephan Bergmann 
Date:   Sat Mar 25 10:47:34 2017 +0100

Add loplugin:redundantinline

...after it had recently been run with 
6cb9e6dad798ec59f055aebe84a9c4a21e4be40d
"Remove redundant 'inline' keyword"

Change-Id: I7f3ee2ff1c32988dcff7245c64b50fe20b0a5e79
Reviewed-on: https://gerrit.libreoffice.org/35681
Reviewed-by: Stephan Bergmann 
Tested-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/redundantinline.cxx 
b/compilerplugins/clang/redundantinline.cxx
new file mode 100644
index ..88c870d75465
--- /dev/null
+++ b/compilerplugins/clang/redundantinline.cxx
@@ -0,0 +1,127 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+
+#include "plugin.hxx"
+
+namespace {
+
+class Visitor:
+public RecursiveASTVisitor, public loplugin::RewritePlugin
+{
+public:
+explicit Visitor(InstantiationData const & data): RewritePlugin(data) {}
+
+void run() override {
+if (compiler.getLangOpts().CPlusPlus) {
+TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
+}
+}
+
+bool VisitFunctionDecl(FunctionDecl const * decl) {
+if (ignoreLocation(decl) || !decl->isInlineSpecified()
+|| !(decl->doesThisDeclarationHaveABody()
+ || decl->isExplicitlyDefaulted())
+|| !(decl->getLexicalDeclContext()->isRecord()
+ || decl->isConstexpr()))
+{
+return true;
+}
+auto l1 = unwindToQObject(decl->getLocStart());
+if (l1.isValid() && l1 == unwindToQObject(decl->getLocEnd())) {
+return true;
+}
+SourceLocation inlineLoc;
+unsigned n;
+auto end = Lexer::getLocForEndOfToken(
+compiler.getSourceManager().getExpansionLoc(decl->getLocEnd()), 0,
+compiler.getSourceManager(), compiler.getLangOpts());
+assert(end.isValid());
+for (auto loc = compiler.getSourceManager().getExpansionLoc(
+ decl->getLocStart());
+ loc != end; loc = loc.getLocWithOffset(std::max(n, 1)))
+{
+n = Lexer::MeasureTokenLength(
+loc, compiler.getSourceManager(), compiler.getLangOpts());
+StringRef s(compiler.getSourceManager().getCharacterData(loc), n);
+//TODO: see compilerplugins/clang/override.cxx:
+if (s.startswith("\\\n")) {
+s = s.drop_front(2);
+}
+if (s == "inline") {
+if (!compiler.getSourceManager().isMacroArgExpansion(loc)) {
+inlineLoc = loc;
+}
+break;
+} else if (s == "#") {
+// Hard to pick the right 'inline' in code like
+//
+//   #if 1
+// static
+//   #else
+// inline
+//   #endif
+//   inline void f() {}
+//
+// so just give up once a preprocessing directive is seen:
+break;
+}
+}
+if (rewriter != nullptr && inlineLoc.isValid()) {
+for (auto loc = inlineLoc.getLocWithOffset(
+ std::max(n, 1));;)
+{
+assert(loc != end);
+unsigned n2 = Lexer::MeasureTokenLength(
+loc, compiler.getSourceManager(), compiler.getLangOpts());
+StringRef s(
+compiler.getSourceManager().getCharacterData(loc), n2);
+//TODO: see compilerplugins/clang/override.cxx:
+if (s.startswith("\\\n")) {
+s = s.drop_front(2);
+}
+if (!s.empty()) {
+break;
+}
+n2 = std::max(n2, 1);
+n += n2;
+loc = loc.getLocWithOffset(n2);
+}
+if (removeText(inlineLoc, n, RewriteOptions(RemoveLineIfEmpty))) {
+return true;
+}
+}
+report(
+DiagnosticsEngine::Warning,
+"function definition redundantly declared 'inline'",
+inlineLoc.isValid() ? inlineLoc : decl->getLocStart())
+<< decl->getSource

[Libreoffice-commits] core.git: configure.ac connectivity/source cppuhelper/source cpputools/source cui/source

[Andrea Gelmini]

 configure.ac   |2 +-
 connectivity/source/commontools/parameters.cxx |2 +-
 connectivity/source/drivers/firebird/Connection.hxx|2 +-
 connectivity/source/drivers/firebird/Tables.cxx|2 +-
 connectivity/source/drivers/hsqldb/HTable.cxx  |2 +-
 connectivity/source/drivers/kab/KDEInit.cxx|2 +-
 connectivity/source/drivers/postgresql/pq_databasemetadata.cxx |2 +-
 connectivity/source/inc/ado/ADatabaseMetaData.hxx  |2 +-
 connectivity/source/inc/file/FNumericFunctions.hxx |2 +-
 cppuhelper/source/exc_thrower.cxx  |2 +-
 cpputools/source/unoexe/unoexe.cxx |2 +-
 cui/source/options/optgenrl.cxx|2 +-
 cui/source/tabpages/tphatch.cxx|2 +-
 cui/source/tabpages/tptrans.cxx|2 +-
 14 files changed, 14 insertions(+), 14 deletions(-)

New commits:
commit 7668d4e616dd37d3b335c43db897b64a7349047b
Author: Andrea Gelmini 
Date:   Fri Mar 24 08:53:41 2017 +0100

Fix typos

Change-Id: I56e429ff1b8ee55ccb8df16002b509770762172c
Reviewed-on: https://gerrit.libreoffice.org/35618
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/configure.ac b/configure.ac
index 60ea0ead62b4..12ab4421f004 100644
--- a/configure.ac
+++ b/configure.ac
@@ -332,7 +332,7 @@ AC_SUBST(ENABLE_LTO)
 
 AC_ARG_ENABLE(fuzz-options,
 AS_HELP_STRING([--enable-fuzz-options],
-[Randomly enable or disable each of those configury options
+[Randomly enable or disable each of those configurable options
  that are supposed to be freely selectable without interdependencies,
  or where bad interaction from interdependencies is automatically 
avoided.])
 )
diff --git a/connectivity/source/commontools/parameters.cxx 
b/connectivity/source/commontools/parameters.cxx
index 2db8bb4e12a0..70e1883ff41f 100644
--- a/connectivity/source/commontools/parameters.cxx
+++ b/connectivity/source/commontools/parameters.cxx
@@ -250,7 +250,7 @@ namespace dbtools
 return;
 
 // we may need to strip any links which are invalid, so here go the 
containers
-// for temporarirly holding the new pairs
+// for temporarily holding the new pairs
 std::vector< OUString > aStrippedMasterFields;
 std::vector< OUString > aStrippedDetailFields;
 
diff --git a/connectivity/source/drivers/firebird/Connection.hxx 
b/connectivity/source/drivers/firebird/Connection.hxx
index 5e5c321d3646..43bccf9ab8f8 100644
--- a/connectivity/source/drivers/firebird/Connection.hxx
+++ b/connectivity/source/drivers/firebird/Connection.hxx
@@ -162,7 +162,7 @@ namespace connectivity
 /**
  * Creates a new transaction with the desired parameters, if
  * necessary discarding an existing transaction. This has to be 
done
- * anytime we change the transaction isolation, or autocommiting.
+ * anytime we change the transaction isolation, or autocommitting.
  *
  * @throws css::sdbc::SQLException
  */
diff --git a/connectivity/source/drivers/firebird/Tables.cxx 
b/connectivity/source/drivers/firebird/Tables.cxx
index bc21f08dac56..48313c60805b 100644
--- a/connectivity/source/drivers/firebird/Tables.cxx
+++ b/connectivity/source/drivers/firebird/Tables.cxx
@@ -98,7 +98,7 @@ OUString Tables::createStandardColumnPart(const Reference< 
XPropertySet >& xColP
 aSql.append(" ");
 aSql.append(sAutoIncrementValue);
 }
-// AutoIncrementive "IDENTITY" is implizit "NOT NULL"
+// AutoIncrement "IDENTITY" is implicitly "NOT NULL"
 else 
if(::comphelper::getINT32(xColProp->getPropertyValue(rPropMap.getNameByIndex(PROPERTY_ID_ISNULLABLE)))
 == ColumnValue::NO_NULLS)
 aSql.append(" NOT NULL");
 
diff --git a/connectivity/source/drivers/hsqldb/HTable.cxx 
b/connectivity/source/drivers/hsqldb/HTable.cxx
index af99e0e5b467..6ce97cd11b5e 100644
--- a/connectivity/source/drivers/hsqldb/HTable.cxx
+++ b/connectivity/source/drivers/hsqldb/HTable.cxx
@@ -183,7 +183,7 @@ void SAL_CALL OHSQLTable::alterColumnByName( const 
OUString& colName, const Refe
 xProp->getPropertyValue(rProp.getNameByIndex(PROPERTY_ID_TYPENAME))
 >>= sOldTypeName;
 
descriptor->getPropertyValue(rProp.getNameByIndex(PROPERTY_ID_TYPENAME))>>= 
sNewTypeName;
 
-// and precsions and scale
+// and precision and scale
 xProp->getPropertyValue(rProp.getNameByIndex(PROPERTY_ID_PRECISION))   
 >>= nOldPrec;
 
descriptor->getPropertyValue(rProp.getNameByIndex(PROPERTY_ID_PRECISION))>>= 
nNewPrec;
 xProp->getPropertyValue(rProp.getNameByIndex(PROPERTY_ID_SCALE))   
 >>= nOldScale;
diff --git a/connectivity/source/drivers/

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

[Andrea Gelmini]

 sw/inc/dbmgr.hxx  |2 +-
 sw/inc/doc.hxx|2 +-
 sw/inc/editsh.hxx |4 ++--
 sw/inc/expfld.hxx |2 +-
 sw/inc/swtypes.hxx|2 +-
 sw/inc/unochart.hxx   |2 +-
 sw/qa/core/uwriter.cxx|2 +-
 sw/qa/extras/mailmerge/mailmerge.cxx  |2 +-
 sw/qa/extras/ooxmlexport/ooxmlexport3.cxx |2 +-
 sw/qa/extras/rtfimport/rtfimport.cxx  |2 +-
 sw/qa/extras/uiwriter/uiwriter.cxx|2 +-
 sw/qa/python/check_table.py   |2 +-
 sw/source/core/access/accportions.cxx |2 +-
 sw/source/core/access/acctextframe.hxx|2 +-
 sw/source/core/crsr/crsrsh.cxx|6 +++---
 sw/source/core/doc/docdesc.cxx|2 +-
 sw/source/core/doc/docfmt.cxx |4 ++--
 sw/source/core/doc/htmltbl.cxx|2 +-
 sw/source/core/docnode/nodes.cxx  |2 +-
 sw/source/core/edit/edsect.cxx|2 +-
 sw/source/core/inc/SwGrammarMarkUp.hxx|2 +-
 sw/source/core/inc/frminf.hxx |2 +-
 sw/source/core/inc/rootfrm.hxx|2 +-
 sw/source/core/inc/scriptinfo.hxx |2 +-
 sw/source/core/layout/atrfrm.cxx  |2 +-
 sw/source/core/layout/frmtool.cxx |2 +-
 sw/source/core/layout/pagechg.cxx |2 +-
 sw/source/core/layout/sectfrm.cxx |4 ++--
 sw/source/core/layout/tabfrm.cxx  |4 ++--
 sw/source/core/layout/wsfrm.cxx   |2 +-
 30 files changed, 36 insertions(+), 36 deletions(-)

New commits:
commit 402aa305b7e37c3d3e1432613f59c905933a97cd
Author: Andrea Gelmini 
Date:   Fri Mar 24 17:06:02 2017 +0100

Fix typos

Change-Id: Ia87318cb323d403cdff947da0b70e0d2aabaacd4
Reviewed-on: https://gerrit.libreoffice.org/35657
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/sw/inc/dbmgr.hxx b/sw/inc/dbmgr.hxx
index e97d400267e6..3cf00ef249a9 100644
--- a/sw/inc/dbmgr.hxx
+++ b/sw/inc/dbmgr.hxx
@@ -166,7 +166,7 @@ struct SwMergeDescriptor
 /**
  * Basename incl. the path for the generated files.
  *
- * The final filename will be created by concating a number to prevent
+ * The final filename will be created by concatenating a number to prevent
  * overwriting an existing file and the extension based on the filter
  * settings.
  */
diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index cf7b340bcda4..6fc96f312452 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -344,7 +344,7 @@ private:
 sal_Int32   mReferenceCount;
 
 bool mbDtor  : 1;/**< TRUE: is in SwDoc DTOR.
-   and unfortunately temorarily 
also in
+   and unfortunately temporarily 
also in
SwSwgReader::InLayout() when 
flawed
frames need deletion. */
 bool mbCopyIsMove: 1;//< TRUE: Copy is a hidden Move.
diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx
index 762389448461..d706e823c607 100644
--- a/sw/inc/editsh.hxx
+++ b/sw/inc/editsh.hxx
@@ -284,7 +284,7 @@ public:
 void ResetAttr( const std::set &attrs = 
std::set(), SwPaM* pCursor = nullptr );
 void GCAttr();
 
-/// @return the scripttpye of the selection.
+/// @return the scripttype of the selection.
 SvtScriptType GetScriptType() const;
 
 /// @return the language at current cursor position.
@@ -863,7 +863,7 @@ public:
 bool IsMoveLeftMargin( bool bRight, bool bModulus = true ) const;
 void MoveLeftMargin( bool bRight, bool bModulus = true );
 
-/// Query NumberFormater from document.
+/// Query NumberFormatter from document.
   SvNumberFormatter* GetNumberFormatter();
 const SvNumberFormatter* GetNumberFormatter() const
 {   return const_cast(this)->GetNumberFormatter();  }
diff --git a/sw/inc/expfld.hxx b/sw/inc/expfld.hxx
index 51cf4f6f1c75..11629562e8ea 100644
--- a/sw/inc/expfld.hxx
+++ b/sw/inc/expfld.hxx
@@ -359,7 +359,7 @@ public:
 voidPushCursor();
 voidPopCursor();
 
-/** Put all that are new into SortLst for updating. @return true if not 
empty.
+/** Put all that are new into SortList for updating. @return true if not 
empty.
  (For Glossary: only update its input-fields).
  Compare TmpLst with current fields. */
 boolBuildSortLst();
diff --git a/sw/inc/swtypes.hxx b/sw/inc/swtypes.hxx
index 33ba955f3743..0e986947c28f 100644
--- a/sw/inc/swtypes.hxx
+++ b/sw/inc/swtypes.hxx
@@ -133,7 +133,7 @@ const short lOutlineMinTextDistance = 216; // 0.15 inch = 
0.38 cm
 // fields before INIT_FLDTYPES.
 #define INIT_SEQ_FLDTYPES   4
 
-// The former Rendevouz-IDs live on:
+// The former Rendezvous-IDs live on:
 // There are IDs for the anchors (SwForma

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 4 commits - bean/com bridges/source filter/source javaunohelper/com jurt/com l10ntools/java

[Damjan Jovanovic]

 bean/com/sun/star/beans/JavaWindowPeerFake.java  | 
   2 
 bean/com/sun/star/beans/LocalOfficeWindow.java   | 
   4 -
 bean/com/sun/star/comp/beans/LocalOfficeWindow.java  | 
   8 +-
 bean/com/sun/star/comp/beans/OOoBean.java| 
   4 -
 bridges/source/jni_uno/java/com/sun/star/bridges/jni_uno/JNI_proxy.java  | 
   6 -
 filter/source/xsltfilter/com/sun/star/comp/xsltfilter/XSLTransformer.java| 
   2 
 javaunohelper/com/sun/star/lib/uno/helper/PropertySet.java   | 
  38 +-
 javaunohelper/com/sun/star/lib/uno/helper/PropertySetMixin.java  | 
   6 -
 javaunohelper/com/sun/star/lib/uno/helper/UnoUrl.java| 
   2 
 jurt/com/sun/star/lib/uno/bridges/java_remote/ProxyFactory.java  | 
   2 
 jurt/com/sun/star/lib/uno/protocols/urp/Unmarshal.java   | 
  14 +--
 jurt/com/sun/star/lib/uno/protocols/urp/urp.java | 
  10 +-
 jurt/com/sun/star/uno/AnyConverter.java  | 
  30 +++
 l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/SDFReader.java   | 
   4 -
 l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/XLIFFReader.java | 
   4 -
 15 files changed, 68 insertions(+), 68 deletions(-)

New commits:
commit 15325f02503e3e47201a21fc9da3881fde3fab3f
Author: Damjan Jovanovic 
Date:   Sat Mar 25 15:10:09 2017 +

Java boxing optimization and cleanups for l10ntools.

Patch by: me

diff --git 
a/l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/SDFReader.java 
b/l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/SDFReader.java
index 94ee4ad03ee2..07ac35aa02fb 100644
--- a/l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/SDFReader.java
+++ b/l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/SDFReader.java
@@ -618,11 +618,11 @@ public class SDFReader extends DataReader {
 for (int i = 0; i < line.length(); i++) {
 c = line.charAt(i);
 if (c < 30 && c != 9) {
-return (new Character(c)).toString();
+return Character.toString(c);
 }
 
 }
 return line;
 
 }
-}
\ No newline at end of file
+}
diff --git 
a/l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/XLIFFReader.java 
b/l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/XLIFFReader.java
index ad9bac6b4b4d..7e9d6a54b92a 100644
--- 
a/l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/XLIFFReader.java
+++ 
b/l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/XLIFFReader.java
@@ -449,9 +449,9 @@ public class XLIFFReader extends DefaultHandler {
 //TODO arraycopy might not be nessessary
 System.arraycopy((String[]) DataStore.get(id), 0, data, 0,
 data.length);
-int help = (new 
Integer(data[FOUND_PARTS_COUNTER_IDX])).intValue(); //found one more part
+int help = 
(Integer.valueOf(data[FOUND_PARTS_COUNTER_IDX])).intValue(); //found one more 
part
 help++; // refresh the actual found parts
-data[FOUND_PARTS_COUNTER_IDX] = (new 
Integer(help)).toString(); // belonging to this information
+data[FOUND_PARTS_COUNTER_IDX] = Integer.toString(help); // 
belonging to this information
 
 DataStore.remove(attrs.getValue("id")); // TODO this can be 
deleted?
 } else {
commit 862d03382236c006ccf21e710cbcb8f65eaf4317
Author: Damjan Jovanovic 
Date:   Sat Mar 25 15:07:15 2017 +

Use more efficient Java boxing in main/filter.

Patch by: me

diff --git 
a/filter/source/xsltfilter/com/sun/star/comp/xsltfilter/XSLTransformer.java 
b/filter/source/xsltfilter/com/sun/star/comp/xsltfilter/XSLTransformer.java
index d9f25568e252..22dbb3d743a3 100644
--- a/filter/source/xsltfilter/com/sun/star/comp/xsltfilter/XSLTransformer.java
+++ b/filter/source/xsltfilter/com/sun/star/comp/xsltfilter/XSLTransformer.java
@@ -293,7 +293,7 @@ public class XSLTransformer
 debug("TransformerFactory is '" + 
tfactory.getClass().getName() + "'");
 // some external saxons (Debian, Ubuntu, ...) have this 
disabled
 // per default
-tfactory.setAttribute(FeatureKeys.ALLOW_EXTERNAL_FUNCTIONS, 
new Boolean(true));
+tfactory.setAttribute(FeatureKeys.ALLOW_EXTERNAL_FUNCTIONS, 
true);
 xsltTemplate = tfactory.newTemplates(new 
StreamSource(stylesheeturl));
 
 // store the transformation into the cache
commit 13abe86bb10ee68c302e9b27dba4a438a6c98168
Author: Damjan Jovanovic 
Date:   Sat Mar 25 15:04:26 2017 +

Use more efficient Java boxing for basic types in main/bean.

Patch by: me

diff --git a/bean/com/sun/star/beans/Ja

[Libreoffice-commits] core.git: winaccessibility/source wizards/com wizards/source writerfilter/inc writerfilter/source writerperfect/source

[Andrea Gelmini]

 winaccessibility/source/UAccCOM/MAccessible.cxx |2 +-
 wizards/com/sun/star/wizards/agenda/AgendaDocument.py   |4 ++--
 wizards/com/sun/star/wizards/agenda/TemplateConsts.py   |2 +-
 wizards/com/sun/star/wizards/agenda/TopicsControl.py|2 +-
 wizards/com/sun/star/wizards/form/DataEntrySetter.java  |2 +-
 wizards/com/sun/star/wizards/ui/event/DataAware.py  |2 +-
 wizards/source/access2base/Application.xba  |4 ++--
 wizards/source/access2base/Recordset.xba|4 ++--
 wizards/source/access2base/Utils.xba|4 ++--
 wizards/source/depot/Lang_fr.xba|4 ++--
 wizards/source/euro/Protect.xba |2 +-
 wizards/source/importwizard/FilesModul.xba  |2 +-
 writerfilter/inc/dmapper/resourcemodel.hxx  |2 +-
 writerfilter/source/dmapper/GraphicImport.cxx   |2 +-
 writerfilter/source/rtftok/rtfcharsets.cxx  |2 +-
 writerfilter/source/rtftok/rtfcontrolwords.hxx  |4 ++--
 writerperfect/source/writer/WordPerfectImportFilter.cxx |6 +++---
 17 files changed, 25 insertions(+), 25 deletions(-)

New commits:
commit 370c65e709eb074c9982c56a2400cf945641ffaf
Author: Andrea Gelmini 
Date:   Fri Mar 24 15:37:27 2017 +0100

Fix typos

Change-Id: I80b6d080aa31ff8b9d043b983993f4d26d8dc87c
Reviewed-on: https://gerrit.libreoffice.org/35662
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/winaccessibility/source/UAccCOM/MAccessible.cxx 
b/winaccessibility/source/UAccCOM/MAccessible.cxx
index 9b82e5857840..744215440788 100644
--- a/winaccessibility/source/UAccCOM/MAccessible.cxx
+++ b/winaccessibility/source/UAccCOM/MAccessible.cxx
@@ -2172,7 +2172,7 @@ HRESULT CMAccessible::SelectChild(XAccessible* pItem)
 }
 
 /**
-* Deselect one XAccessible item, for accSelect implimentation
+* Deselect one XAccessible item, for accSelect implementation
 * @parampItem, the item should be deselected.
 * @return  S_OK if successful.
 */
diff --git a/wizards/com/sun/star/wizards/agenda/AgendaDocument.py 
b/wizards/com/sun/star/wizards/agenda/AgendaDocument.py
index 42b0751799d7..a980e60d4959 100644
--- a/wizards/com/sun/star/wizards/agenda/AgendaDocument.py
+++ b/wizards/com/sun/star/wizards/agenda/AgendaDocument.py
@@ -63,7 +63,7 @@ No column merge is allowed.
 One compulsory Heading row.
 
 To let the template be flexible, we use a kind of "detection": we look where
-the items are read the design of each table, reaplying it after writing the
+the items are read the design of each table, re-applying it after writing the
 table.self.xTextDocument
 
 A note about threads:
@@ -700,7 +700,7 @@ class ItemsTable(object):
 This class handles the preview of the topics table.
 You can call it the controller of the topics table.
 It differs from ItemsTable in that it has no data model -
-the update is done programttically.
+the update is done programmatically.
 
 The decision to make this class a class by its own
 was done out of logic reasons and not design/functionality reasons,
diff --git a/wizards/com/sun/star/wizards/agenda/TemplateConsts.py 
b/wizards/com/sun/star/wizards/agenda/TemplateConsts.py
index eb0d0b02e531..15acff1aa08a 100644
--- a/wizards/com/sun/star/wizards/agenda/TemplateConsts.py
+++ b/wizards/com/sun/star/wizards/agenda/TemplateConsts.py
@@ -37,7 +37,7 @@ class TemplateConsts:
 '''
 SECTION_MINUTES_ALL = "MINUTES_ALL"
 '''
-the name of the child nimutes section.
+the name of the child minutes section.
 This section will be duplicated for each topic.
 '''
 SECTION_MINUTES = "MINUTES"
diff --git a/wizards/com/sun/star/wizards/agenda/TopicsControl.py 
b/wizards/com/sun/star/wizards/agenda/TopicsControl.py
index 149faba9c840..cc42aa95552a 100644
--- a/wizards/com/sun/star/wizards/agenda/TopicsControl.py
+++ b/wizards/com/sun/star/wizards/agenda/TopicsControl.py
@@ -57,7 +57,7 @@ This control relays on the ControlScroller control which uses 
the following
 Data model:
 1. It uses a vector, whose members are arrays of PropertyValue.
 2. Each array represents a row.
-(Note: the Name and Value memebrs of the PropertyValue object are being used)
+(Note: the Name and Value members of the PropertyValue object are being used)
 3. Each property Value represents a value
 for a single control with the following rules:
 3. a. the Value of the property is used for as value
diff --git a/wizards/com/sun/star/wizards/form/DataEntrySetter.java 
b/wizards/com/sun/star/wizards/form/DataEntrySetter.java
index f653bf322a46..8bebe54f859e 100644
--- a/wizards/com/sun/star/wizards/form/DataEntrySetter.java
+++ b/wizards/com/sun/star/wizards/form/DataEntrySetter.java
@@ -45,7 +45,7 @@ public class DataEntrySetter
 String sDisplayAllData = 
CurUnoDialog.m_oResource.getResText(UIConsts.RID_FORM + 46);
 String sNoModification = 
CurUnoDialog.m_oResource.getResText(UIConsts

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - wizards/source

[Jean-Pierre Ledure]

 wizards/source/access2base/Application.xba |2 +-
 wizards/source/access2base/Database.xba|2 +-
 wizards/source/access2base/Event.xba   |2 +-
 wizards/source/access2base/Recordset.xba   |1 +
 wizards/source/access2base/Trace.xba   |2 +-
 wizards/source/access2base/Utils.xba   |2 +-
 6 files changed, 6 insertions(+), 5 deletions(-)

New commits:
commit a403671af80be1e1563eea013d155e6a0635f0f0
Author: Jean-Pierre Ledure 
Date:   Sat Mar 25 11:54:27 2017 +0100

Access2Base Missing parentheses - tdf#106710

Due to more severe Basic interpreter on final parentheses
missing parentheses were revealed

Change-Id: I84ead9ba4957ae20ed094d7ae42df436fd1f88f2
Reviewed-on: https://gerrit.libreoffice.org/35683
Reviewed-by: Mike Kaganski 
Tested-by: Mike Kaganski 

diff --git a/wizards/source/access2base/Application.xba 
b/wizards/source/access2base/Application.xba
index 19a872007f9f..783fca73541e 100644
--- a/wizards/source/access2base/Application.xba
+++ b/wizards/source/access2base/Application.xba
@@ -915,7 +915,7 @@ Dim sOutput As String, l As Long, lLength As Long
If Len(pvString) > 0 Then
For l = 1 To Len(pvString)
If lLength > 0 And Len(sOutput) > lLength Then 
Exit For
-   sOutput = sOutput & Utils._UTF8Encode(Mid(pvString, 
l, 1)
+   sOutput = sOutput & Utils._UTF8Encode(Mid(pvString, 
l, 1))
Next l
End If
 
diff --git a/wizards/source/access2base/Database.xba 
b/wizards/source/access2base/Database.xba
index 72445e0f3407..63ad4e5a3431 100644
--- a/wizards/source/access2base/Database.xba
+++ b/wizards/source/access2base/Database.xba
@@ -1442,7 +1442,7 @@ Dim i As Integer, l As Long
lNextPattern = InStr(lCurrentChar, psString, 
vPatterns(i), 1)   '  Text (not case-sensitive) string comparison
If lNextPattern > 0 And lNextPattern < lPattern 
Then
lPattern = lNextPattern
-   sPattern = Mid(psString, lPattern, 
Len(vPatterns(i))
+   sPattern = Mid(psString, lPattern, 
Len(vPatterns(i)))
End If
Next i
'  Up to the next pattern or to the end of the string, 
UTF8-encode each character
diff --git a/wizards/source/access2base/Event.xba 
b/wizards/source/access2base/Event.xba
index de6aa2a6e4c6..7688668b2afd 100644
--- a/wizards/source/access2base/Event.xba
+++ b/wizards/source/access2base/Event.xba
@@ -254,7 +254,7 @@ Const cstDatabaseForm = 
"com.sun.star.comp.forms.ODatabaseForm"
Set oObject = poEvent.Source
_EventSource = oObject
sArray = Split(Utils._getUNOTypeName(poEvent), ".")
-   _EventType = UCase(sArray(UBound(sArray))
+   _EventType = UCase(sArray(UBound(sArray)))
If Utils._hasUNOProperty(poEvent, "EventName") Then 
_EventName = poEvent.EventName
 
Select Case _EventType
diff --git a/wizards/source/access2base/Recordset.xba 
b/wizards/source/access2base/Recordset.xba
index 0f7be5b01827..c4ba6ce77f82 100644
--- a/wizards/source/access2base/Recordset.xba
+++ b/wizards/source/access2base/Recordset.xba
@@ -1120,6 +1120,7 @@ Private Function _PropertiesList() As Variant
 
_PropertiesList = Array("AbsolutePosition", "BOF", 
"Bookmarkable", "Bookmark", "EditMode" _
, "EOF", "Filter", 
"LastModified", "Name", "ObjectType" , 
"RecordCount" _
+   )
 
 End Function   '  _PropertiesList
 
diff --git a/wizards/source/access2base/Trace.xba 
b/wizards/source/access2base/Trace.xba
index fdc08d4d623c..601b711fdf33 100644
--- a/wizards/source/access2base/Trace.xba
+++ b/wizards/source/access2base/Trace.xba
@@ -182,7 +182,7 @@ Public Sub TraceLevel(ByVal Optional psTraceLevel As String)
Case psTraceLevel = ""
:   psTraceLevel = "ERROR"
Case Utils._InList(UCase(psTraceLevel), Array( _
TRACEDEBUG, TRACEINFO, TRACEWARNING, TRACEERRORS, 
TRACEFATAL, TRACEABORT _
-   )
+   ))
Case Else   
:   Goto Exit_Sub
End Select
_A2B_.MinimalTraceLevel = _TraceLevel(psTraceLevel)
diff --git a/wizards/source/access2base/Utils.xba 
b/wizards/source/access2base/Utils.xba
index c2b6172b2484..da9e57f7ab73 100644
--- a/wizards/source/access2base/Utils.xba
+++ b/wizards/source/access2base/Utils.xba
@@ -831,7 +831,7 @@ Const cstDot = "."
 Dim sName As String
 
If InStr(psName, ".") > 0 Then
-   sName = Join(Split(psName, cstDot), cstSquareClose & cstDot 
& cstSquareOpen
+   sName = Join(Split(psName, cstDot), cstSquareClose & cstDot 
& cstSquareOpen)
_Surround = cstSquareOpen & sName & cstSquareClo

[Libreoffice-commits] core.git: RepositoryExternal.mk

[Thorsten Behrens]

 RepositoryExternal.mk |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit cc71c6adfd811e50d2dc92ee60eae2c709019574
Author: Thorsten Behrens 
Date:   Sat Mar 25 01:28:07 2017 +0100

gpg4libre: actually package the gpgme libs

Change-Id: Ibcfc7946210d64450e8d0ce3b53461c6270cc473
Reviewed-on: https://gerrit.libreoffice.org/35674
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 57b9a217dd6e..75897bc7799e 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -3412,6 +3412,12 @@ $(call gb_LinkTarget_use_package,$(1),gpgme)
 
 endef
 
+$(eval $(call gb_Helper_register_packages_for_install,ooo,\
+   gpgmepp \
+   libassuan \
+   libgpg-error \
+))
+
 endif
 
 ifeq ($(ENABLE_GLTF),TRUE)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmerge/source xmloff/inc xmloff/README xmloff/source xmlscript/source xmlsecurity/inc xmlsecurity/source

[Andrea Gelmini]

 xmerge/source/xmerge/java/org/openoffice/xmerge/merger/Iterator.java |2 +-
 xmloff/README|2 +-
 xmloff/inc/txtfldi.hxx   |2 +-
 xmloff/inc/txtvfldi.hxx  |2 +-
 xmloff/source/core/DomBuilderContext.cxx |2 +-
 xmloff/source/text/XMLIndexTabStopEntryContext.cxx   |2 +-
 xmloff/source/text/txtflde.cxx   |2 +-
 xmloff/source/text/txtprmap.cxx  |2 +-
 xmloff/source/xforms/xformsexport.cxx|2 +-
 xmlscript/source/xmldlg_imexp/xmldlg_import.cxx  |4 
++--
 xmlsecurity/inc/sigstruct.hxx|2 +-
 xmlsecurity/inc/xmlsignaturehelper.hxx   |2 +-
 xmlsecurity/source/dialogs/certificatechooser.cxx|2 +-
 xmlsecurity/source/helper/xsecsign.cxx   |2 +-
 xmlsecurity/source/xmlsec/nss/ciphercontext.cxx  |2 +-
 xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx  |2 +-
 16 files changed, 17 insertions(+), 17 deletions(-)

New commits:
commit 74117f95972a0ef690401815d5e5ff7759ceb8af
Author: Andrea Gelmini 
Date:   Fri Mar 24 15:38:38 2017 +0100

Fix typos

Change-Id: I901ff35ad2e0aa43a421f0996865130514a819bc
Reviewed-on: https://gerrit.libreoffice.org/35663
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git 
a/xmerge/source/xmerge/java/org/openoffice/xmerge/merger/Iterator.java 
b/xmerge/source/xmerge/java/org/openoffice/xmerge/merger/Iterator.java
index 33db7cd3e956..c53988076bbb 100644
--- a/xmerge/source/xmerge/java/org/openoffice/xmerge/merger/Iterator.java
+++ b/xmerge/source/xmerge/java/org/openoffice/xmerge/merger/Iterator.java
@@ -78,7 +78,7 @@ public interface Iterator {
  * refresh the content.
  *
  * It is used mainly for {@code Iterator} objects which take a snapshot
- * instead of dynamically tranversing the tree.  The current position will
+ * instead of dynamically traversing the tree.  The current position will
  * be set to the beginning.
  */
 void refresh();
diff --git a/xmloff/README b/xmloff/README
index f6015fcf902c..74659c78f6f3 100644
--- a/xmloff/README
+++ b/xmloff/README
@@ -21,7 +21,7 @@ with the default being the latest ODF version with 
"extensions", which
 means it may contain elements and attributes that are only in drafts of
 the specification or are not yet submitted for specification.  Documents
 produced in the other (non-extended) ODF modes are supposed to be
-strictly conforming to the respecive specification, i.e., only markup
+strictly conforming to the respective specification, i.e., only markup
 defined by the ODF specification is allowed.
 
 There is another library "xof" built from the source/transform directory,
diff --git a/xmloff/inc/txtfldi.hxx b/xmloff/inc/txtfldi.hxx
index ed154c72ffe0..1aa9c5ac3761 100644
--- a/xmloff/inc/txtfldi.hxx
+++ b/xmloff/inc/txtfldi.hxx
@@ -169,7 +169,7 @@ protected:
  const OUString& sServiceName);
 
 /// force an update of the field's value
-/// call update on optional XUptadeable interface; (disable Fixed property)
+/// call update on optional XUpdatable interface; (disable Fixed property)
 static void ForceUpdate(
 const css::uno::Reference< css::beans::XPropertySet> & rPropertySet);
 };
diff --git a/xmloff/inc/txtvfldi.hxx b/xmloff/inc/txtvfldi.hxx
index b5e1d6dcae86..437657b5442b 100644
--- a/xmloff/inc/txtvfldi.hxx
+++ b/xmloff/inc/txtvfldi.hxx
@@ -230,7 +230,7 @@ protected:
 
 
 /**
- * uperclass for variable/user-set, var/user-input, and sequence fields
+ * upperclass for variable/user-set, var/user-input, and sequence fields
  * inds field master of appropriate type and attaches field to it.
  */
 class XMLSetVarFieldImportContext : public XMLVarFieldImportContext
diff --git a/xmloff/source/core/DomBuilderContext.cxx 
b/xmloff/source/core/DomBuilderContext.cxx
index 4a835187fb43..ca8cbbed6314 100644
--- a/xmloff/source/core/DomBuilderContext.cxx
+++ b/xmloff/source/core/DomBuilderContext.cxx
@@ -164,7 +164,7 @@ void DomBuilderContext::Characters( const OUString& 
rCharacters )
 SAL_WARN_IF( !mxNode.is(), "xmloff", "empty XNode not allowed" );
 
 // TODO: I assume adjacent text nodes should be joined, to preserve
-// processinf model? (I.e., if the SAX parser breaks a string into 2
+// processing model? (I.e., if the SAX parser breaks a string into 2
 // Characters(..) calls, the DOM model would still see only one child.)
 
 // create text node and append to parent
diff --git a/xmloff/source/text/XMLIndexTabStopEntryContext.cxx 
b/xmloff/source/text/XMLIndexTabStopEntryContext.cxx
index 12d

[Libreoffice-commits] core.git: udkapi/com UnoControls/source

[Andrea Gelmini]

 UnoControls/source/controls/progressmonitor.cxx   |2 +-
 udkapi/com/sun/star/reflection/TypeDescriptionManager.idl |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit e9b628760e2606769d7cc7fa2993729b796628d3
Author: Andrea Gelmini 
Date:   Fri Mar 24 15:35:35 2017 +0100

Fix typos

Change-Id: I6455332160bb232cddf816e9f6dafa3ce68331a0
Reviewed-on: https://gerrit.libreoffice.org/35661
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/UnoControls/source/controls/progressmonitor.cxx 
b/UnoControls/source/controls/progressmonitor.cxx
index 06a7d404d90b..1eda7f784fbf 100644
--- a/UnoControls/source/controls/progressmonitor.cxx
+++ b/UnoControls/source/controls/progressmonitor.cxx
@@ -206,7 +206,7 @@ void SAL_CALL ProgressMonitor::addText(
 // Safe impossible cases
 // Check valid call of this method.
 DBG_ASSERT ( impl_debug_checkParameter ( rTopic, rText, bbeforeProgress )  
 , "ProgressMonitor::addText()\nCall without valid parameters!\n");
-DBG_ASSERT ( !(impl_searchTopic ( rTopic, bbeforeProgress ) != nullptr )   
, "ProgresMonitor::addText()\nThe text already exist.\n");
+DBG_ASSERT ( !(impl_searchTopic ( rTopic, bbeforeProgress ) != nullptr )   
, "ProgressMonitor::addText()\nThe text already exist.\n");
 
 // Do nothing (in Release), if topic already exist.
 if ( impl_searchTopic ( rTopic, bbeforeProgress ) != nullptr )
diff --git a/udkapi/com/sun/star/reflection/TypeDescriptionManager.idl 
b/udkapi/com/sun/star/reflection/TypeDescriptionManager.idl
index 90fc63bf2b59..e81fe0b78050 100644
--- a/udkapi/com/sun/star/reflection/TypeDescriptionManager.idl
+++ b/udkapi/com/sun/star/reflection/TypeDescriptionManager.idl
@@ -73,7 +73,7 @@ published service TypeDescriptionManager
 
 
 Even though the name of this interface suggests that the used type
-names are hierarchical, this doesn't need to be the case.  (For 
example, consider
+names are hierarchical, this doesn't need to be the case. (For 
example, consider
 the names of instantiated polymorphic struct types, like
 "Struct".)
 */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vbahelper/source vcl/inc vcl/README vcl/source vcl/unx vcl/win

[Andrea Gelmini]

 vbahelper/source/vbahelper/vbashapes.cxx |2 +-
 vcl/README   |2 +-
 vcl/inc/opengl/PackedTextureAtlas.hxx|2 +-
 vcl/inc/regband.hxx  |2 +-
 vcl/inc/svdata.hxx   |2 +-
 vcl/inc/unx/fontmanager.hxx  |2 +-
 vcl/inc/win/winlayout.hxx|2 +-
 vcl/source/app/session.cxx   |2 +-
 vcl/source/filter/graphicfilter2.cxx |2 +-
 vcl/source/filter/jpeg/jpegc.cxx |2 +-
 vcl/source/filter/sgfbram.hxx|2 +-
 vcl/source/filter/sgvtext.cxx|2 +-
 vcl/source/filter/wmf/winmtf.cxx |2 +-
 vcl/source/font/fontcache.cxx|2 +-
 vcl/source/gdi/gdimetafiletools.cxx  |2 +-
 vcl/source/gdi/metaact.cxx   |2 +-
 vcl/source/gdi/pdfwriter_impl2.cxx   |2 +-
 vcl/source/gdi/pngread.cxx   |2 +-
 vcl/source/gdi/region.cxx|2 +-
 vcl/source/gdi/sallayout.cxx |2 +-
 vcl/source/outdev/text.cxx   |4 ++--
 vcl/source/uitest/uiobject.cxx   |2 +-
 vcl/source/window/dockmgr.cxx|2 +-
 vcl/unx/generic/app/saldisp.cxx  |2 +-
 vcl/unx/generic/print/common_gfx.cxx |2 +-
 vcl/unx/generic/print/genpspgraphics.cxx |2 +-
 vcl/unx/generic/printer/ppdparser.cxx|2 +-
 vcl/unx/gtk/gtksalmenu.cxx   |2 +-
 vcl/unx/gtk3/gtk3gtkframe.cxx|2 +-
 vcl/unx/gtk3/gtk3gtkinst.cxx |2 +-
 vcl/unx/kde4/KDESalGraphics.cxx  |2 +-
 vcl/win/gdi/gdiimpl.hxx  |2 +-
 vcl/win/window/salframe.cxx  |4 ++--
 33 files changed, 35 insertions(+), 35 deletions(-)

New commits:
commit 4c45268adf61a460e6c89f4536fd0ec37775676d
Author: Andrea Gelmini 
Date:   Fri Mar 24 15:31:29 2017 +0100

Fix typos

Change-Id: I623135cd4c76dd6569f4ee521f97dee41de4cb1e
Reviewed-on: https://gerrit.libreoffice.org/35660
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/vbahelper/source/vbahelper/vbashapes.cxx 
b/vbahelper/source/vbahelper/vbashapes.cxx
index dd840240efd8..3e2acc39dfae 100644
--- a/vbahelper/source/vbahelper/vbashapes.cxx
+++ b/vbahelper/source/vbahelper/vbashapes.cxx
@@ -292,7 +292,7 @@ ScVbaShapes::AddEllipse(sal_Int32 startX, sal_Int32 startY, 
sal_Int32 nLineWidth
 return uno::makeAny( uno::Reference< msforms::XShape > ( pScVbaShape ) );
 }
 
-//helpeapi calc
+//helperapi calc
 uno::Any SAL_CALL
 ScVbaShapes::AddLine( sal_Int32 StartX, sal_Int32 StartY, sal_Int32 endX, 
sal_Int32 endY )
 {
diff --git a/vcl/README b/vcl/README
index c7c1f9e079ad..2bf842087541 100644
--- a/vcl/README
+++ b/vcl/README
@@ -59,7 +59,7 @@ How the platform abstraction works
  API for platform backends
+ It is a factory for:
  SalFrames, SalVirtualDevices, SalPrinters,
- Timers, the SolarMutexe, Drag&Drop and other
+ Timers, the SolarMutex, Drag&Drop and other
  objects, as well as the primary event loop wrapper.
 
 Note: references to "SV" in the code mean StarView, which was a
diff --git a/vcl/inc/opengl/PackedTextureAtlas.hxx 
b/vcl/inc/opengl/PackedTextureAtlas.hxx
index 4d9015f33572..a7417fca8b8b 100644
--- a/vcl/inc/opengl/PackedTextureAtlas.hxx
+++ b/vcl/inc/opengl/PackedTextureAtlas.hxx
@@ -19,7 +19,7 @@ struct PackedTexture;
  * Pack texutres into one texutre atlas.
  *
  * This is based on algorithm described in [1] and is an
- * addaptation of "texture atlas generator" from [2].
+ * adaptation of "texture atlas generator" from [2].
  *
  * [1]: http://www.blackpawn.com/texts/lightmaps/
  * [2]: https://github.com/lukaszdk/texture-atlas-generator
diff --git a/vcl/inc/regband.hxx b/vcl/inc/regband.hxx
index 7c1785e98365..e81b1e127fc9 100644
--- a/vcl/inc/regband.hxx
+++ b/vcl/inc/regband.hxx
@@ -25,7 +25,7 @@
 class ImplRegionBand
 
 This class handles one y-band of the region. In this band may contain one
-or more seprarations in x-direction. The y-Band do not contain any
+or more separations in x-direction. The y-Band do not contain any
 separation after creation.
 
 The separations are modified with basic clipping functions like Union and
diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx
index d1b8a6c6fe2c..f14ee66eeeba 100644
--- a/vcl/inc/svdata.hxx
+++ b/vcl/inc/svdata.hxx
@@ -172,7 +172,7 @@ struct ImplSVGDIData
 ImplPrnQueueList*   mpPrinterQueueList = nullptr;   // List of all 
printer queue
 PhysicalFontCollection* mpScreenFontList = nullptr; // Screen-Font-List
 ImplFontCache*  mpScreenFontCache = nullptr;// 
Screen-Font-Cache
-ImplDirectFontSubstitution* mpDirectFontSubst = nullptr; // 
Font-Substitutons defined in Tools->Options->Fonts
+ImplDirectFontSubstitution* mpDirectFontSubst = nullptr; // 
Font-Substitutions defined in Tools->Options->Fonts
 Graphic

[Libreoffice-commits] core.git: testtools/qa toolkit/qa toolkit/README toolkit/source toolkit/test tools/source ucb/qa ucb/source udkapi/com unotools/qa unotools/source unoxml/source

[Andrea Gelmini]

 testtools/qa/cli/readme.txt   |2 +-
 toolkit/README|2 +-
 toolkit/qa/complex/toolkit/Assert.java|2 +-
 toolkit/qa/complex/toolkit/GridControl.java   |2 +-
 toolkit/source/awt/animatedimagespeer.cxx |2 +-
 toolkit/test/accessibility/NodeMap.java   |2 +-
 tools/source/fsys/urlobj.cxx  |2 +-
 tools/source/generic/poly.cxx |6 +++---
 ucb/qa/complex/tdoc/_XTypeProvider.java   |2 +-
 ucb/source/core/ucbcmds.cxx   |2 +-
 ucb/source/ucp/file/filtask.cxx   |2 +-
 ucb/source/ucp/tdoc/tdoc_provider.cxx |2 +-
 ucb/source/ucp/webdav-neon/ContentProperties.cxx  |2 +-
 ucb/source/ucp/webdav-neon/NeonSession.cxx|4 ++--
 ucb/source/ucp/webdav-neon/webdavcontent.cxx  |6 +++---
 ucb/source/ucp/webdav/ContentProperties.cxx   |2 +-
 ucb/source/ucp/webdav/webdavcontent.cxx   |2 +-
 udkapi/com/sun/star/reflection/TypeDescriptionManager.idl |2 +-
 unotools/qa/unit/testGetEnglishSearchName.cxx |2 +-
 unotools/source/config/configitem.cxx |2 +-
 unotools/source/ucbhelper/ucblockbytes.cxx|4 ++--
 unoxml/source/dom/attr.cxx|2 +-
 22 files changed, 28 insertions(+), 28 deletions(-)

New commits:
commit f7eb8ae9d9cce3e493105da98cc4ace9c56a3062
Author: Andrea Gelmini 
Date:   Fri Mar 24 15:28:34 2017 +0100

Fix typos

Change-Id: Ieea40e1b7282267157810f9f58ca083e68ae6715
Reviewed-on: https://gerrit.libreoffice.org/35659
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/testtools/qa/cli/readme.txt b/testtools/qa/cli/readme.txt
index 88ad4bd30b12..34531936ab99 100644
--- a/testtools/qa/cli/readme.txt
+++ b/testtools/qa/cli/readme.txt
@@ -21,6 +21,6 @@ However, if for some reason an assembly remains in the GAC 
than it is used no ma
 what.
 
 
-The qa test simply executes the cli_bridgetest_inprocess.exe. All console 
output is descarded.
+The qa test simply executes the cli_bridgetest_inprocess.exe. All console 
output is discarded.
 When the test fails one should directly run that executable. Then one may see 
the cause
 of the failure in the console.
diff --git a/toolkit/README b/toolkit/README
index e320108de058..ea40b4d26590 100644
--- a/toolkit/README
+++ b/toolkit/README
@@ -4,7 +4,7 @@ or Java.
 
 Note that the "awt" here has no relation to the Java awt, as far as I know. It
 might be inspired by it API-wise, perhaps. (If you know differently, feel free
-to improve this REDAME file.)
+to improve this README file.)
 
 Note that toolkit/ is itself not really a toolkit, it is at root a
 reasonably simple wrapper of vcl/ - if you came here looking for a
diff --git a/toolkit/qa/complex/toolkit/Assert.java 
b/toolkit/qa/complex/toolkit/Assert.java
index eb6ec44dce1e..f7988270a8e3 100644
--- a/toolkit/qa/complex/toolkit/Assert.java
+++ b/toolkit/qa/complex/toolkit/Assert.java
@@ -87,7 +87,7 @@ public class Assert
  * retrieves a method, given by name and parameter signature, from the 
given class
  *
  * The method does somewhat more than simply calling {@link 
Class#getMethod}. In particular, it recognizes
- * primitiive parameter types, and attempts to find a method taking the 
given primitive type, instead of the
+ * primitive parameter types, and attempts to find a method taking the 
given primitive type, instead of the
  * type represented by the parameter class.
  *
  * For instance, if you have a method foo( int ), {@link 
Class#getMethod} would not return this
diff --git a/toolkit/qa/complex/toolkit/GridControl.java 
b/toolkit/qa/complex/toolkit/GridControl.java
index ab836cc4a057..e76fe9fab55a 100644
--- a/toolkit/qa/complex/toolkit/GridControl.java
+++ b/toolkit/qa/complex/toolkit/GridControl.java
@@ -232,7 +232,7 @@ public class GridControl
 impl_assertColumnModelConsistency();
 List< ContainerEvent > events = 
listener.assertExclusiveInsertionEvents();
 listener.reset();
-assertEquals( "wrong number of events fired by setDefaulColumns", 
defaultColumnsCount, events.size() );
+assertEquals( "wrong number of events fired by setDefaultColumns", 
defaultColumnsCount, events.size() );
 for ( int i=0; i
-// 4th Production (misscounted slashes):
+// 4th Production (miscounted slashes):
 //"//" *path ["#" *UCS4]
 //  becomes
 //"file:///" *path ["#" *UCS4]
diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index 9d546499f3ee..eba86e6f40b6 100644
--- a/tools/source/generic/poly.cxx
+++ 

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann]

 compilerplugins/clang/redundantcast.cxx |   25 +++--
 1 file changed, 23 insertions(+), 2 deletions(-)

New commits:
commit 3c7652203cc381e5c8c06d42130ca3bae5576fd2
Author: Stephan Bergmann 
Date:   Sat Mar 25 10:46:00 2017 +0100

Teach loplugin:redundantcast about C-style casts in macro bodies

Change-Id: Ic1fbc8dd16c4d78772fc11a9c2ce09f056e36c79
Reviewed-on: https://gerrit.libreoffice.org/35680
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/redundantcast.cxx 
b/compilerplugins/clang/redundantcast.cxx
index c18e1cf5be0e..17e3bac33ca7 100644
--- a/compilerplugins/clang/redundantcast.cxx
+++ b/compilerplugins/clang/redundantcast.cxx
@@ -306,9 +306,30 @@ bool RedundantCast::VisitCStyleCastExpr(CStyleCastExpr 
const * expr) {
 << t1 << t2 << expr->getSourceRange();
 return true;
 }
-if (loplugin::TypeCheck(t1).Typedef() && loplugin::TypeCheck(t2).Typedef() 
&& t1 == t2
-&& 
!compiler.getSourceManager().isMacroBodyExpansion(expr->getLocStart()))
+if (loplugin::TypeCheck(t1).Typedef() && loplugin::TypeCheck(t2).Typedef() 
&& t1 == t2)
 {
+// Ignore FD_ISSET expanding to "...(SOCKET)(fd)..." in some Microsoft
+// winsock2.h (TODO: improve heuristic of determining that the whole
+// expr is part of a single macro body expansion):
+auto l1 = expr->getLocStart();
+while (compiler.getSourceManager().isMacroArgExpansion(l1)) {
+l1 = compiler.getSourceManager().getImmediateMacroCallerLoc(l1);
+}
+auto l2 = expr->getExprLoc();
+while (compiler.getSourceManager().isMacroArgExpansion(l2)) {
+l2 = compiler.getSourceManager().getImmediateMacroCallerLoc(l2);
+}
+auto l3 = expr->getLocEnd();
+while (compiler.getSourceManager().isMacroArgExpansion(l3)) {
+l3 = compiler.getSourceManager().getImmediateMacroCallerLoc(l3);
+}
+if (compiler.getSourceManager().isMacroBodyExpansion(l1)
+&& compiler.getSourceManager().isMacroBodyExpansion(l2)
+&& compiler.getSourceManager().isMacroBodyExpansion(l3)
+&& ignoreLocation(compiler.getSourceManager().getSpellingLoc(l2)))
+{
+return true;
+}
 report(
 DiagnosticsEngine::Warning,
 "redundant cstyle typedef cast from %0 to %1", expr->getExprLoc())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/tools include/vcl

[Stephan Bergmann]

 include/tools/colordata.hxx |   12 +---
 include/vcl/salgtype.hxx|6 +-
 2 files changed, 14 insertions(+), 4 deletions(-)

New commits:
commit f175ded3aef01cf598a1838cf93b8b3f37b6933c
Author: Stephan Bergmann 
Date:   Sat Mar 25 10:38:47 2017 +0100

Replace some macros with constexpr functions

...in preparation of teaching loplugin:redundantcast about C-style casts in
macro bodies.

TRGB_COLORDATA contained a curious cast to sal_Int32 (instead of sal_uInt32 
aka
ColorData), but for one that affected (by accident?) only the fist term of 
the
... | ... | ... | ... expression (so the ultimate expression was of type
sal_uInt32), and for another before a83698b980424be214829b3ee7cdbf8d2a778755
"tools: split out color macros into own header" there were two different
definitions of TRGB_COLORDATA, and only one casted to sal_Int32 (the other 
to
ColorData).

Change-Id: I5bfffe5614d0424202268ef7adaf6a0da61ec30a
Reviewed-on: https://gerrit.libreoffice.org/35679
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/include/tools/colordata.hxx b/include/tools/colordata.hxx
index 1d0fb42b4e39..c303957411df 100644
--- a/include/tools/colordata.hxx
+++ b/include/tools/colordata.hxx
@@ -24,10 +24,16 @@
 // Color types
 typedef sal_uInt32 ColorData;
 
-#define TRGB_COLORDATA(TRANSPARENCE,RED,GREEN,BLUE) \
-
((sal_Int32)(((sal_uInt32)((sal_uInt8)(BLUE|(((sal_uInt32)((sal_uInt8)(GREEN)))<<8)|(((sal_uInt32)((sal_uInt8)(RED)))<<16)|(((sal_uInt32)((sal_uInt8)(TRANSPARENCE)))<<24))
+constexpr ColorData TRGB_COLORDATA(
+sal_uInt8 TRANSPARENCE, sal_uInt8 RED, sal_uInt8 GREEN, sal_uInt8 BLUE)
+{
+return sal_uInt32(BLUE) | (sal_uInt32(GREEN) << 8) | (sal_uInt32(RED) << 
16)
+| (sal_uInt32(TRANSPARENCE) << 24);
+}
 
-#define RGB_COLORDATA( r,g,b )  
((ColorData)(((sal_uInt32)((sal_uInt8)(b|(((sal_uInt32)((sal_uInt8)(g)))<<8)|(((sal_uInt32)((sal_uInt8)(r)))<<16))
+constexpr ColorData RGB_COLORDATA(sal_uInt8 r, sal_uInt8 g, sal_uInt8 b) {
+return sal_uInt32(b) | (sal_uInt32(g) << 8) | (sal_uInt32(r) << 16);
+}
 
 #define COLORDATA_RED( n )  ((sal_uInt8)((n)>>16))
 #define COLORDATA_GREEN( n )((sal_uInt8)(((sal_uInt16)(n)) >> 8))
diff --git a/include/vcl/salgtype.hxx b/include/vcl/salgtype.hxx
index b9eb6ae74dcb..df708b4fe196 100644
--- a/include/vcl/salgtype.hxx
+++ b/include/vcl/salgtype.hxx
@@ -33,7 +33,11 @@ enum class DeviceFormat {
 };
 
 typedef sal_uInt32 SalColor;
-#define MAKE_SALCOLOR( r, g, b )
((SalColor)(((sal_uInt32)((sal_uInt8)(b|(((sal_uInt32)((sal_uInt8)(g)))<<8)|(((sal_uInt32)((sal_uInt8)(r)))<<16))
+
+constexpr SalColor MAKE_SALCOLOR(sal_uInt8 r, sal_uInt8 g, sal_uInt8 b) {
+return sal_uInt32(b) | (sal_uInt32(g) << 8) | (sal_uInt32(r) << 16);
+}
+
 #define SALCOLOR_RED( n )   ((sal_uInt8)((n)>>16))
 #define SALCOLOR_GREEN( n ) ((sal_uInt8)(((sal_uInt16)(n)) >> 8))
 #define SALCOLOR_BLUE( n )  ((sal_uInt8)(n))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/oox oox/source sd/source sw/source

[Stephan Bergmann]

 include/oox/export/utils.hxx |2 
 oox/source/export/chartexport.cxx|   62 +++
 oox/source/export/drawingml.cxx  |  106 +--
 oox/source/export/shapes.cxx |   60 +++
 sd/source/filter/eppt/pptx-epptooxml.cxx |   42 +-
 sw/source/filter/ww8/docxattributeoutput.cxx |   10 +-
 sw/source/filter/ww8/docxsdrexport.cxx   |   10 +-
 7 files changed, 145 insertions(+), 147 deletions(-)

New commits:
commit 4b788a12380518e31a9064d5839f4880d3f36874
Author: Stephan Bergmann 
Date:   Sat Mar 25 10:33:14 2017 +0100

There should be no need to distinguish between I32S and I64S

...after 64b993e046f23baaacaff1572b7d2a816588b5ef "finish deprecation of
O(U)String::valueOf()" replaced OString::valueOf with OString::number in 
their
bodies.  (Change done in preparation of teaching loplugin:redundantcast 
about
C-style casts in macro bodies.)

Change-Id: Ifbb4725c496eed18a926fbabeaf4691ac98d9c5e
Reviewed-on: https://gerrit.libreoffice.org/35678
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/include/oox/export/utils.hxx b/include/oox/export/utils.hxx
index 599e45ee55f8..8e5b814dd908 100644
--- a/include/oox/export/utils.hxx
+++ b/include/oox/export/utils.hxx
@@ -24,8 +24,6 @@
 #include 
 #include 
 
-#define I32S(x) OString::number( (sal_Int32) x ).getStr()
-#define I64S(x) OString::number( (sal_Int64) x ).getStr()
 #define IS(x) OString::number( x ).getStr()
 #define BS(x) (x ? "1":"0")
 #define USS(x) OUStringToOString( x, RTL_TEXTENCODING_UTF8 ).getStr()
diff --git a/oox/source/export/chartexport.cxx 
b/oox/source/export/chartexport.cxx
index bddb3c3a2f7a..2de77698daa4 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -527,7 +527,7 @@ void ChartExport::WriteChartObj( const Reference< XShape >& 
xShape, sal_Int32 nC
 sal_Int32 nID = GetChartID();
 
 pFS->singleElementNS( mnXmlNamespace, XML_cNvPr,
-  XML_id, I32S( nID ),
+  XML_id, IS( nID ),
   XML_name,   USS( sName ),
   FSEND );
 
@@ -1562,7 +1562,7 @@ void ChartExport::exportBarChart( const Reference< 
chart2::XChartType >& xChartT
 {
 sal_Int32 nGapWidth = aBarPositionSequence[0];
 pFS->singleElement( FSNS( XML_c, XML_gapWidth ),
-XML_val, I32S( nGapWidth ),
+XML_val, IS( nGapWidth ),
 FSEND );
 }
 }
@@ -1604,7 +1604,7 @@ void ChartExport::exportBarChart( const Reference< 
chart2::XChartType >& xChartT
 {
 sal_Int32 nOverlap = aBarPositionSequence[0];
 pFS->singleElement( FSNS( XML_c, XML_overlap ),
-XML_val, I32S( nOverlap ),
+XML_val, IS( nOverlap ),
 FSEND );
 }
 }
@@ -1649,7 +1649,7 @@ void ChartExport::exportDoughnutChart( const Reference< 
chart2::XChartType >& xC
 //FIXME: holeSize
 sal_Int32 nHoleSize = 50;
 pFS->singleElement( FSNS( XML_c, XML_holeSize ),
-XML_val, I32S( nHoleSize ),
+XML_val, IS( nHoleSize ),
 FSEND );
 
 pFS->endElement( FSNS( XML_c, XML_doughnutChart ) );
@@ -1901,7 +1901,7 @@ void ChartExport::exportUpDownBars( const Reference< 
chart2::XChartType >& xChar
 // TODO: gapWidth
 sal_Int32 nGapWidth = 150;
 pFS->singleElement( FSNS( XML_c, XML_gapWidth ),
-XML_val, I32S( nGapWidth ),
+XML_val, IS( nGapWidth ),
 FSEND );
 
 Reference< beans::XPropertySet > xChartPropSet = 
xChartPropProvider->getUpBar();
@@ -2056,10 +2056,10 @@ void ChartExport::exportSeries( const 
Reference& xChartType,
 
 // TODO: idx and order
 pFS->singleElement( FSNS( XML_c, XML_idx ),
-XML_val, I32S(mnSeriesCount),
+XML_val, IS(mnSeriesCount),
 FSEND );
 pFS->singleElement( FSNS( XML_c, XML_order ),
-XML_val, I32S(mnSeriesCount++),
+XML_val, IS(mnSeriesCount++),
 FSEND );
 
 // export label
@@ -2106,7 +2106,7 @@ void ChartExport::exportSeries( const 
Reference& xChartType,
 sal_Int32 nOffset = 0;
 mAny >>= nOffset;
 pFS->singleElement( FSNS( XML_c, XML_explosion 
),
-XML_val, I32S( nOffset ),
+XML_val, IS( nOffset ),
 FSEND );
 }
 break;
@@ -2238,10 +2238,10 @@ void ChartExport::exportCandleStickSeries(
 // TODO: idx 

[Libreoffice-commits] core.git: filter/source

[Stephan Bergmann]

 filter/source/msfilter/eschesdo.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0f9b0f471249910787c4da111363efc57bf316d9
Author: Stephan Bergmann 
Date:   Sat Mar 25 10:30:17 2017 +0100

loplugin:redundantcast

Change-Id: I7f20df3b568f9c33a66726202952dbf4232132c6
Reviewed-on: https://gerrit.libreoffice.org/35677
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/filter/source/msfilter/eschesdo.cxx 
b/filter/source/msfilter/eschesdo.cxx
index 79b8e01a48b5..95bd490582af 100644
--- a/filter/source/msfilter/eschesdo.cxx
+++ b/filter/source/msfilter/eschesdo.cxx
@@ -146,7 +146,7 @@ void ImplEESdrWriter::ImplFlipBoundingBox( ImplEESdrObject& 
rObj, EscherProperty
 nShapeType = nType; \
 nShapeID = mpEscherEx->GenerateShapeId();   \
 rObj.SetShapeId( nShapeID );\
-mpEscherEx->AddShape( (sal_uInt32)nType, (sal_uInt32)nFlags, nShapeID );   
 \
+mpEscherEx->AddShape( (sal_uInt32)nType, nFlags, nShapeID );\
 rSolverContainer.AddShape( rObj.GetShapeRef(), nShapeID );  \
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Stephan Bergmann]

 sc/source/ui/pagedlg/tptable.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7c5f01fcd8659d2c94f7d92beb261cb225787b0e
Author: Stephan Bergmann 
Date:   Sat Mar 25 10:29:33 2017 +0100

loplugin:redundantcast

Change-Id: I61676e74413942ff5bde9ae8d376269a651bf93a
Reviewed-on: https://gerrit.libreoffice.org/35676
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/sc/source/ui/pagedlg/tptable.cxx b/sc/source/ui/pagedlg/tptable.cxx
index fb1ad78ad644..5b3dbff4a43d 100644
--- a/sc/source/ui/pagedlg/tptable.cxx
+++ b/sc/source/ui/pagedlg/tptable.cxx
@@ -70,7 +70,7 @@ static bool lcl_PutBoolItem( sal_uInt16nWhich,
 
 #define WAS_DEFAULT(w,s)(SfxItemState::DEFAULT==(s).GetItemState((w)))
 #define GET_BOOL(sid,set)   static_cast((set).Get(GetWhich((sid.GetValue()
-#define GET_USHORT(sid,set) (sal_uInt16)static_cast((set).Get(GetWhich((sid.GetValue()
+#define GET_USHORT(sid,set) static_cast((set).Get(GetWhich((sid.GetValue()
 #define GET_SHOW(sid,set)   ( ScVObjMode( static_cast((set).Get(GetWhich((sid.GetValue() ) \
   == VOBJ_MODE_SHOW )
 // List box entries "Scaling mode"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: o3tl/qa odk/examples odk/source offapi/com officecfg/README onlineupdate/source oox/inc oox/README oox/source package/source pyuno/source

[Andrea Gelmini]

 o3tl/qa/test-lru_map.cxx   
 |2 +-
 odk/examples/DevelopersGuide/Charts/SelectionChangeListener.java   
 |2 +-
 
odk/examples/DevelopersGuide/Components/Thumbs/org/openoffice/comp/test/Thumbs.java
 |2 +-
 odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OnewayExecutor.java  
 |2 +-
 odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusView.java  
 |2 +-
 
odk/examples/DevelopersGuide/ProfUNO/InterprocessConn/ConnectionAwareClient.java
|2 +-
 odk/examples/DevelopersGuide/UCB/ResourceManager.java  
 |2 +-
 odk/examples/OLE/activex/SOActiveX.cpp 
 |2 +-
 odk/examples/java/NotesAccess/Makefile 
 |2 +-
 odk/examples/java/ToDo/ToDo.java   
 |2 +-
 odk/source/com/sun/star/lib/loader/InstallationFinder.java 
 |2 +-
 offapi/com/sun/star/form/runtime/XFeatureInvalidation.idl  
 |2 +-
 offapi/com/sun/star/frame/FeatureStateEvent.idl
 |2 +-
 offapi/com/sun/star/util/XURLTransformer.idl   
 |2 +-
 officecfg/README   
 |6 +++---
 onlineupdate/source/libmar/verify/cryptox.h
 |2 +-
 onlineupdate/source/update/common/updatehelper.cxx 
 |2 +-
 oox/README 
 |2 +-
 oox/inc/drawingml/chart/plotareamodel.hxx  
 |2 +-
 oox/source/export/chartexport.cxx  
 |2 +-
 oox/source/export/drawingml.cxx
 |2 +-
 oox/source/ole/axcontrol.cxx   
 |2 +-
 package/source/zippackage/ZipPackage.cxx   
 |2 +-
 pyuno/source/module/unohelper.py   
 |2 +-
 24 files changed, 26 insertions(+), 26 deletions(-)

New commits:
commit 095438e52ccff8eaf12af6b3e3eb5f8c00792416
Author: Andrea Gelmini 
Date:   Fri Mar 24 15:17:01 2017 +0100

Fix typos

Change-Id: I14dca0d55c09187690dc1d94936c40b890ca5cea
Reviewed-on: https://gerrit.libreoffice.org/35637
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/o3tl/qa/test-lru_map.cxx b/o3tl/qa/test-lru_map.cxx
index b985966f43d2..37fc8a4f6788 100644
--- a/o3tl/qa/test-lru_map.cxx
+++ b/o3tl/qa/test-lru_map.cxx
@@ -89,7 +89,7 @@ void lru_map_test::testReplaceValue()
 CPPUNIT_ASSERT_EQUAL(4, lru.find(1)->second);
 CPPUNIT_ASSERT_EQUAL(200, lru.find(2)->second);
 
-// check if insert with same key, moves the entry back of the lru queu
+// check if insert with same key, moves the entry back of the lru queue
 
 // inserting new entry with key that already exists
 lru.insert(std::make_pair(1, 6));
diff --git a/odk/examples/DevelopersGuide/Charts/SelectionChangeListener.java 
b/odk/examples/DevelopersGuide/Charts/SelectionChangeListener.java
index 6fc0da170d48..e9ba0581c09e 100644
--- a/odk/examples/DevelopersGuide/Charts/SelectionChangeListener.java
+++ b/odk/examples/DevelopersGuide/Charts/SelectionChangeListener.java
@@ -208,7 +208,7 @@ public class SelectionChangeListener implements 
XSelectionChangeListener {
 
 int button = com.sun.star.awt.MessageBoxButtons.BUTTONS_OK;
 XMessageBoxFactory aMBF = 
UnoRuntime.queryInterface(XMessageBoxFactory.class, aToolKit);
-XMessageBox xMB = aMBF.createMessageBox(aWinPeer, 
MessageBoxType.INFOBOX, button, "Event-Notify", "Listener was called, selcetion 
has changed");
+XMessageBox xMB = aMBF.createMessageBox(aWinPeer, 
MessageBoxType.INFOBOX, button, "Event-Notify", "Listener was called, selection 
has changed");
 xMB.execute();
 }
 }
diff --git 
a/odk/examples/DevelopersGuide/Components/Thumbs/org/openoffice/comp/test/Thumbs.java
 
b/odk/examples/DevelopersGuide/Components/Thumbs/org/openoffice/comp/test/Thumbs.java
index 18feea570728..a43c4da87a97 100644
--- 
a/odk/examples/DevelopersGuide/Components/Thumbs/org/openoffice/comp/test/Thumbs.java
+++ 
b/odk/examples/DevelopersGuide/Components/Thumbs/org/openoffice/comp/test/Thumbs.java
@@ -60,7 +60,7 @@ public class Thumbs {
 System.out.println("ImageShrink component successfully 
instantiated");
 
 java.io.File f = new java.io.File(".");
-System.out.println("set SourceDrectory ...");
+System.out.println("set SourceDirectory...");
 xImageShrinkFilter.setSourceDirectory(f.getCanonical

[Libreoffice-commits] core.git: solenv/bin solenv/doc solenv/gbuild starmath/inc starmath/source stoc/source svl/source svtools/source

[Andrea Gelmini]

 solenv/bin/concat-deps.c   |6 +++---
 solenv/doc/gbuild/solenv/gbuild/gbuild.mk  |4 ++--
 solenv/gbuild/gbuild.mk|4 ++--
 starmath/inc/cursor.hxx|2 +-
 starmath/source/cursor.cxx |2 +-
 starmath/source/mathmlimport.cxx   |2 +-
 starmath/source/mathtype.cxx   |2 +-
 stoc/source/implementationregistration/implreg.cxx |2 +-
 stoc/source/security/access_controller.cxx |2 +-
 svl/source/items/poolio.cxx|2 +-
 svl/source/notify/lstner.cxx   |2 +-
 svl/source/numbers/zformat.cxx |2 +-
 svtools/source/control/ruler.cxx   |2 +-
 svtools/source/misc/templatefoldercache.cxx|2 +-
 svtools/source/table/defaultinputhandler.cxx   |2 +-
 svtools/source/table/tablecontrol_impl.cxx |4 ++--
 16 files changed, 21 insertions(+), 21 deletions(-)

New commits:
commit 25e0872da600c65a08c73c335f0e1ef21b2f00f5
Author: Andrea Gelmini 
Date:   Fri Mar 24 12:52:02 2017 +0100

Fix typos

Change-Id: I4eda687db6ad8d41e6a28430c76b288510da605d
Reviewed-on: https://gerrit.libreoffice.org/35645
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/solenv/bin/concat-deps.c b/solenv/bin/concat-deps.c
index 32e4f10ee4e0..88144465eda7 100644
--- a/solenv/bin/concat-deps.c
+++ b/solenv/bin/concat-deps.c
@@ -263,7 +263,7 @@ void* data;
 }
 else
 {
-/* re-used old freed element by chopipng the head of the free list */
+/* re-used old freed element by chopping the head of the free list */
 pool->head_free = *(void**)data;
 }
 
@@ -389,9 +389,9 @@ static unsigned int hash_compute( struct hash* hash, const 
char* key, int length
  * but we mask the undefined stuff if any, so we are still good, thanks
  * to alignment of memory allocation and tail-memory management overhead
  * we always can read 3 bytes past the official end without triggering
- * a segfault -- if you find a platform/compiler couple for which that 
postulat
+ * a segfault -- if you find a platform/compiler couple for which that 
postulate
  * is false, then you just need to over-allocate by 2 more bytes in 
file_load()
- * file_load already over-allocate by 1 to sitck a \0 at the end of the 
buffer.
+ * file_load already over-allocate by 1 to stick a \0 at the end of the 
buffer.
  */
 switch(length)
 {
diff --git a/solenv/doc/gbuild/solenv/gbuild/gbuild.mk 
b/solenv/doc/gbuild/solenv/gbuild/gbuild.mk
index 9cdb064a974c..55ef76cdc05f 100644
--- a/solenv/doc/gbuild/solenv/gbuild/gbuild.mk
+++ b/solenv/doc/gbuild/solenv/gbuild/gbuild.mk
@@ -70,11 +70,11 @@ namespace gb
 static const List CPUDEFS;
 /// default c++ compilation compiler flags
 static const List CXXFLAGS;
-/// platform- and compilerin dependent default defines
+/// platform- and compiler independent default defines
 static const List GLOBALDEFS;
 /// default objective c++ compilation compiler flags
 static const List OBJCXXFLAGS;
-/// platfomspecific default defines
+/// platformspecific default defines
 static const List OSDEFS;
 /// ?
 static const Path SDKDIR;
diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk
index 05f1bd21e256..46d0761e7316 100644
--- a/solenv/gbuild/gbuild.mk
+++ b/solenv/gbuild/gbuild.mk
@@ -256,11 +256,11 @@ $(eval $(call gb_Deliver_init))
 # TODO: to what extent is the following still true?
 # It is important to include them in the right order as that is
 # -- at least in part -- defining precedence. This is not an issue in the
-# WORKDIR as there are no nameing collisions there, but INSTDIR is a mess
+# WORKDIR as there are no naming collisions there, but INSTDIR is a mess
 # and precedence is important there. This is also platform dependent.
 #
 # This is less of an issue with GNU Make versions > 3.82 which matches for
-# shortest stem instead of first match. However, upon intoduction this version
+# shortest stem instead of first match. However, upon introduction this version
 # is not available everywhere by default.
 
 include $(foreach class, \
diff --git a/starmath/inc/cursor.hxx b/starmath/inc/cursor.hxx
index 9be0b244e1d2..39502ff9dfc5 100644
--- a/starmath/inc/cursor.hxx
+++ b/starmath/inc/cursor.hxx
@@ -184,7 +184,7 @@ public:
  *
  * This method is used for implementing backspace and delete.
  * If one of these causes a complex selection, e.g. a node with
- * subnodes or similar, this should not be deleted imidiately.
+ * subnodes or similar, this should not be deleted immediately.
  */
 bool HasComplexSelection();
 
diff --git a/starmath/source/cursor.cxx b/starmath/source/cursor.cxx
index 4560d40e221c..86c345d28935 100644
--- a/starmath/source/cursor.cxx
+++ b/s

Re: LODev 5.4.0 TB62 x86 test build for Windows XP

[Dennis Roczek]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hi *,

BTW: I just tested the build yesterday night with the computer at my
dad's home (which is still used as fax, music machine, and with a
cashier software) and LibreOffice installs fine, and works like a charm.
(importing PDF, opening DOC, creating a new Calc sheet)

This machine has nearly all visual studio distributables installed and
works since ages with this configuration. (nearly no programs installed;
still getting security patches through the "POS"-bit in the registry)

Regards,
Dennis Roczek

On 24.03.2017 18:40, V Stuart Foote wrote:
> @Cloph, *
> 
> The TB62 test build for Windows XP
> 
> Version: 5.4.0.0.alpha0+
> Build ID: 3d53ec9b2d1c4514adf90ea68915f20ce4d5bc81
> CPU threads: 1; OS: Windows 5.1; UI render: default; 
> Locale: en-US (en_US); Calc: group
> 
> with
> 
> https://cgit.freedesktop.org/libreoffice/core/commit/?id=c4c40632f1de6
f64f0f903943d76d5c3cad0fc22
> 
> Installs and runs cleanly on a Windows XP sp3 VM on VMWare Workstation
.
> 
> Looking at a verbose MS Intaller log nothing jumps out as a problem.
> 
> The VS 2015 SP3 components are installed to the Windows System32 direc
tory
> and registered.
> 
> vcruntime140.dll
> msvcp140.dll
> concrt140.dll
> vccorlib140.dll
> 
> A cursory run through the UI and found no problems--although font qual
ity on
> screen is a little coarse. The CURL based check for updates runs--no i
dea if
> the Breakbad mini-dump uploads will turn. But baring any thing really 
major,
> we may be able to continue to support XP for the 5.4 release.
> 
> Have the verbose install log if anyone is interested.
> 
> 
> 
> --
> View this message in context: http://nabble.documentfoundation.org/LOD
ev-5-4-0-TB62-x86-test-build-for-Windows-XP-tp4210986.html
> Sent from the Dev mailing list archive at Nabble.com.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
> 
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCAAGBQJY1lyDAAoJEM4+Qf3OKrbZu3wP/0Elmu19PTqdFLYH5BJTOsjW
kQJa5htcJT2wlN10dWL76OpYEMMT/eQ/rdeJCjG8k1rm01gvMnEUgTeXSnrhMLtT
iv8dOUjIvXjmSaRGm1VF8/uX2m/0xkt9xqdyhvPgN+65qKYTvpmZM11az7qg8kn+
ccwg7nuRxFFHaiGNeQbzA3P7ayEqeGWonmix5abjmSEW2c/i2eACQK8MVGHjaz3A
V0ZwCbE9Y65kZHd4ZuevNISRSbNRBRkZymvQ/lb6iBqM7bMIGD2eM2NcaCK9pqou
+LzcsUiZMLhyR3m/KeU91+zgCthcg55PaTXBQyQ2cfE3NqyLoOwmgQlsOT7Qhe3x
+yc2zofkrBgSRZKRbqCdp829MQ8bHPI+q93+jxIkYgWu6w8fbyY1JowdHwUeZOif
y+ZFdw14YRrVhAcrBPbe4emTvd2WHxuNlLw0cI/e29ExK66NI1GUYMwsrcObrdUQ
MkDcQMuoecsHykAIU5MxAaodhm7qqTSGIhlsTrkykodhbvSo/BpS2izujNWmyoLb
B0eQtHAYGOrWn9YPejphzx/9iRr0RZaTCNYKKgpjipiSlQpb/PzDp8NVLq0mU/ex
jHAyqVEv2lfoPMe/adqLtjvLcMevhYWeTm8GPPOIzpGHld3DkZfzQb1fcqfDvDrj
ih6guc45sBpO0Gonr+Er
=ryQp
-END PGP SIGNATURE-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: master builds, starts but no UI

[julien2412]

Confirming too with master sources updated yesterday on x86-64 with Debian +
gtk3
With gtk, no pb with UI.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/master-builds-starts-but-no-UI-tp4211020p4211029.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: qadevOOo/runner qadevOOo/tests

[Andrea Gelmini]

 qadevOOo/runner/helper/APIDescGetter.java   |2 +-
 qadevOOo/runner/helper/ConfigHelper.java|2 +-
 qadevOOo/runner/lib/TestParameters.java |2 +-
 qadevOOo/runner/share/LogWriter.java|2 +-
 qadevOOo/runner/util/PropertyName.java  |2 +-
 qadevOOo/runner/util/utils.java |4 ++--
 qadevOOo/tests/java/ifc/accessibility/_XAccessibleEditableText.java |2 +-
 qadevOOo/tests/java/ifc/awt/_XUserInputInterception.java|2 +-
 qadevOOo/tests/java/ifc/container/_XNameAccess.java |2 +-
 qadevOOo/tests/java/ifc/drawing/_XShapeCombiner.java|2 +-
 qadevOOo/tests/java/ifc/form/_XReset.java   |2 +-
 qadevOOo/tests/java/ifc/form/_XSubmit.java  |2 +-
 qadevOOo/tests/java/ifc/frame/_XController.java |2 +-
 qadevOOo/tests/java/ifc/frame/_XFrame.java  |2 +-
 qadevOOo/tests/java/ifc/frame/_XModuleManager.java  |2 +-
 qadevOOo/tests/java/ifc/i18n/_XExtendedIndexEntrySupplier.java  |2 +-
 qadevOOo/tests/java/ifc/io/_XActiveDataControl.java |2 +-
 qadevOOo/tests/java/ifc/io/_XDataInputStream.java   |2 +-
 qadevOOo/tests/java/ifc/sdb/_XRowSetApproveBroadcaster.java |2 +-
 qadevOOo/tests/java/ifc/style/_ParagraphProperties.java |2 +-
 qadevOOo/tests/java/ifc/style/_XStyle.java  |2 +-
 qadevOOo/tests/java/ifc/text/_TextGraphicObject.java|2 +-
 qadevOOo/tests/java/ifc/text/_XTextTableCursor.java |2 +-
 qadevOOo/tests/java/ifc/util/_XURLTransformer.java  |2 +-
 qadevOOo/tests/java/mod/_forms/GenericModelTest.java|2 +-
 qadevOOo/tests/java/mod/_forms/ODatabaseForm.java   |2 +-
 qadevOOo/tests/java/mod/_sc/ScTabViewObj.java   |2 +-
 qadevOOo/tests/java/mod/_sw/SwXMailMerge.java   |2 +-
 qadevOOo/tests/java/mod/_sw/SwXNumberingRules.java  |2 +-
 qadevOOo/tests/java/mod/_toolkit/AccessibleComboBox.java|4 ++--
 30 files changed, 32 insertions(+), 32 deletions(-)

New commits:
commit 7f56e58148602f75b7b5f1860dc65c4620d0
Author: Andrea Gelmini 
Date:   Fri Mar 24 11:47:56 2017 +0100

Fix typos

Change-Id: I72bec7ec76fbbbfee9d5185ac1a358659f0d06b5
Reviewed-on: https://gerrit.libreoffice.org/35638
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/qadevOOo/runner/helper/APIDescGetter.java 
b/qadevOOo/runner/helper/APIDescGetter.java
index 0de81db1779b..67520b9822fd 100644
--- a/qadevOOo/runner/helper/APIDescGetter.java
+++ b/qadevOOo/runner/helper/APIDescGetter.java
@@ -166,7 +166,7 @@ public class APIDescGetter extends DescGetter
 }
 else
 {
-//look the scenarion like this? :
+//look the scenario like this? :
 // sw.SwXBodyText,sw.SwXTextCursor
 ArrayList subs = getSubObjects(job);
 DescEntry[] entries = new DescEntry[subs.size()];
diff --git a/qadevOOo/runner/helper/ConfigHelper.java 
b/qadevOOo/runner/helper/ConfigHelper.java
index 2adadaf2e146..07772eb8f4f5 100644
--- a/qadevOOo/runner/helper/ConfigHelper.java
+++ b/qadevOOo/runner/helper/ConfigHelper.java
@@ -263,7 +263,7 @@ public class ConfigHelper
 XNameContainer.class,xGroup);
 } catch(com.sun.star.container.NoSuchElementException ex) {
  throw new com.sun.star.uno.Exception(ex,
-"could not get extensilbe group '"+extGroup+
+"could not get extensible group '"+extGroup+
 "' from group '"+ group +
 "' from set '"+ setName +"'");
 }
diff --git a/qadevOOo/runner/lib/TestParameters.java 
b/qadevOOo/runner/lib/TestParameters.java
index b5d033b6ad48..04467a9c85a9 100644
--- a/qadevOOo/runner/lib/TestParameters.java
+++ b/qadevOOo/runner/lib/TestParameters.java
@@ -203,4 +203,4 @@ public class TestParameters extends HashMap {
 return "unorc";
 }
 
-}// finish class TestParamenters
+}// finish class TestParameters
diff --git a/qadevOOo/runner/share/LogWriter.java 
b/qadevOOo/runner/share/LogWriter.java
index 0da81654eae8..44d4a2b7dc36 100644
--- a/qadevOOo/runner/share/LogWriter.java
+++ b/qadevOOo/runner/share/LogWriter.java
@@ -43,7 +43,7 @@ public interface LogWriter {
 /**
  * Set a Watcher to the LogWriter
  * This is useful if a test starts a new office instance by itself. In 
this cases
- * the LogWritter could retrigger the Watcher
+ * the LogWriter could retrigger the Watcher
  * @see share.Watcher
  * @param watcher

[Libreoffice-commits] core.git: sdext/source sd/source

[Andrea Gelmini]

 sd/source/core/EffectMigration.cxx  |2 +-
 sd/source/core/drawdoc4.cxx |2 +-
 sd/source/filter/eppt/pptexanimations.cxx   |2 +-
 sd/source/filter/html/pubdlg.cxx|2 +-
 sd/source/filter/ppt/pptin.cxx  |2 +-
 sd/source/ui/func/futext.cxx|2 +-
 sd/source/ui/remotecontrol/AvahiNetworkService.cxx  |2 +-
 sd/source/ui/sidebar/DocumentHelper.cxx |2 +-
 sd/source/ui/slidesorter/cache/SlsBitmapCache.hxx   |2 +-
 sd/source/ui/slidesorter/inc/cache/SlsPageCache.hxx |2 +-
 sd/source/ui/view/sdwindow.cxx  |2 +-
 sdext/source/pdfimport/tree/writertreevisiting.cxx  |4 ++--
 sdext/source/presenter/PresenterNotesView.hxx   |2 +-
 13 files changed, 14 insertions(+), 14 deletions(-)

New commits:
commit b958eae8eb4387a469802aa0b9ff1ebf63151f7f
Author: Andrea Gelmini 
Date:   Fri Mar 24 12:48:16 2017 +0100

Fix typos

Change-Id: I35d4a7648566105b176eb39f6a1db44ca91d4f4c
Reviewed-on: https://gerrit.libreoffice.org/35643
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/sd/source/core/EffectMigration.cxx 
b/sd/source/core/EffectMigration.cxx
index 6efe7124df66..47f4a2c43574 100644
--- a/sd/source/core/EffectMigration.cxx
+++ b/sd/source/core/EffectMigration.cxx
@@ -1358,7 +1358,7 @@ void createVisibilityOnOffNode(Reference< XTimeContainer 
>& rxParentContainer, S
 // work) animations will not work in slideshow
 void EffectMigration::CreateAnimatedGroup(SdrObjGroup& rGroupObj, SdPage& 
rPage)
 {
-// aw080 will give a vector immeditately
+// aw080 will give a vector immediately
 SdrObjListIter aIter(rGroupObj);
 
 if(aIter.Count())
diff --git a/sd/source/core/drawdoc4.cxx b/sd/source/core/drawdoc4.cxx
index d3b07489413b..adfaba482e30 100644
--- a/sd/source/core/drawdoc4.cxx
+++ b/sd/source/core/drawdoc4.cxx
@@ -286,7 +286,7 @@ void SdDrawDocument::CreateLayoutTemplates()
 pISet->Put(makeSdrShadowXDistItem(200));// 3 mm shadow distance
 pISet->Put(makeSdrShadowYDistItem(200));
 
-// Object without fillung
+// Object without filling
 aName = SD_RESSTR(STR_POOLSHEET_OBJWITHOUTFILL);
 pSheet = &(pSSPool->Make(aName, SD_STYLE_FAMILY_GRAPHICS, nMask));
 pSheet->SetParent(aStdName);
diff --git a/sd/source/filter/eppt/pptexanimations.cxx 
b/sd/source/filter/eppt/pptexanimations.cxx
index 30bb1a7276c4..c9e94b96a484 100644
--- a/sd/source/filter/eppt/pptexanimations.cxx
+++ b/sd/source/filter/eppt/pptexanimations.cxx
@@ -1298,7 +1298,7 @@ void AnimationExporter::exportAnimEvent( SvStream& rStrm, 
const Reference< XAnim
 else
 {
 aAny = xNode->getBegin();
-if ( nFlags & 0x10 )// replace ON_NEXT with 
IDEFINITE
+if ( nFlags & 0x10 )// replace ON_NEXT with 
INDEFINITE
 {
 if ( ( aAny >>= aEvent ) && ( aEvent.Trigger == 
EventTrigger::ON_NEXT ) )
 {
diff --git a/sd/source/filter/html/pubdlg.cxx b/sd/source/filter/html/pubdlg.cxx
index 8b11448790e3..1b33d23c632e 100644
--- a/sd/source/filter/html/pubdlg.cxx
+++ b/sd/source/filter/html/pubdlg.cxx
@@ -996,7 +996,7 @@ IMPL_LINK_NOARG(SdPublishingDlg, DesignDeleteHdl, Button*, 
void)
 UpdatePage();
 }
 
-// Clickhandler for the other servertypess
+// Clickhandler for the other servertypes
 IMPL_LINK( SdPublishingDlg, WebServerHdl, Button *, pButton, void )
 {
 bool bASP = pButton == pPage2_ASP;
diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx
index 3b2589384909..be6fd0f9ed18 100644
--- a/sd/source/filter/ppt/pptin.cxx
+++ b/sd/source/filter/ppt/pptin.cxx
@@ -655,7 +655,7 @@ bool ImplSdPPTImport::Import()
 nOutlinerInstance = TSS_Type::Subtitle;
 }
 
-// titelstylesheet
+// titlestylesheet
 pSheet = pPage->GetStyleSheetForPresObj( PRESOBJ_TITLE 
);
 if ( pSheet )
 {
diff --git a/sd/source/ui/func/futext.cxx b/sd/source/ui/func/futext.cxx
index 9b7bbb1558d2..3ff37ad8d469 100644
--- a/sd/source/ui/func/futext.cxx
+++ b/sd/source/ui/func/futext.cxx
@@ -318,7 +318,7 @@ bool FuText::MouseButtonDown(const MouseEvent& rMEvt)
  ( eHit == SdrHitKind::UnmarkedObject && bFirstObjCreated 
&&
!bPermanent ) )
 {
-// Handle, hit marked or umarked object
+// Handle, hit marked or unmarked object
 if (eHit == SdrHitKind::TextEditObj)
 {
 /* hit text of unmarked object:
diff --git a/sd/source/ui/remotecontrol/AvahiNetworkService.cxx 
b/sd/source/ui/remotecontrol/AvahiN

[Libreoffice-commits] core.git: reportbuilder/java reportdesign/source rsc/source sal/osl sal/qa sal/textenc sax/qa sax/source sax/test

[Andrea Gelmini]

 
reportbuilder/java/org/libreoffice/report/pentaho/layoutprocessor/FixedTextLayoutController.java
 |2 +-
 reportdesign/source/core/api/ReportDefinition.cxx  
  |2 +-
 reportdesign/source/ui/inc/GeometryHandler.hxx 
  |2 +-
 rsc/source/rscpp/cpp3.c
  |2 +-
 sal/osl/unx/security.cxx   
  |2 +-
 sal/osl/w32/profile.cxx
  |2 +-
 sal/qa/osl/process/osl_Thread.cxx  
  |6 +++---
 sal/qa/rtl/ostring/rtl_OString2.cxx
  |2 +-
 sal/textenc/convertsimple.cxx  
  |2 +-
 sal/textenc/tcvtutf7.cxx   
  |2 +-
 sax/qa/cppunit/attributes.cxx  
  |2 +-
 sax/qa/data/defaultns.xml  
  |4 ++--
 sax/source/fastparser/fastparser.cxx   
  |4 ++--
 sax/source/tools/fastattribs.cxx   
  |2 +-
 sax/test/sax/testwriter.cxx
  |2 +-
 15 files changed, 19 insertions(+), 19 deletions(-)

New commits:
commit 2e9fe260149911a8a906e059a6025892af8e9a64
Author: Andrea Gelmini 
Date:   Fri Mar 24 11:48:58 2017 +0100

Fix typos

Change-Id: I5fc62060e7d01c6b492a0e91323f753cc676bf71
Reviewed-on: https://gerrit.libreoffice.org/35639
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git 
a/reportbuilder/java/org/libreoffice/report/pentaho/layoutprocessor/FixedTextLayoutController.java
 
b/reportbuilder/java/org/libreoffice/report/pentaho/layoutprocessor/FixedTextLayoutController.java
index bcc725783ba7..3f9631792c05 100644
--- 
a/reportbuilder/java/org/libreoffice/report/pentaho/layoutprocessor/FixedTextLayoutController.java
+++ 
b/reportbuilder/java/org/libreoffice/report/pentaho/layoutprocessor/FixedTextLayoutController.java
@@ -33,7 +33,7 @@ import 
org.jfree.report.flow.layoutprocessor.LayoutControllerFactory;
 import org.jfree.report.structure.Section;
 
 /**
- * Processes a fixed-text element of the OpenOffice reporting specificiation.
+ * Processes a fixed-text element of the OpenOffice reporting specification.
  * The element itself contains a single paragraph which contains the content.
  * After checking, whether this element should be printed, this layout
  * controller simply delegates the dirty work to a suitable handler.
diff --git a/reportdesign/source/core/api/ReportDefinition.cxx 
b/reportdesign/source/core/api/ReportDefinition.cxx
index 95b6ad2dde64..f536a1268a40 100644
--- a/reportdesign/source/core/api/ReportDefinition.cxx
+++ b/reportdesign/source/core/api/ReportDefinition.cxx
@@ -1497,7 +1497,7 @@ bool OReportDefinition::WriteThroughComponent(
 return false;
 
 uno::Reference 
xStreamProp(xOutputStream,uno::UNO_QUERY);
-OSL_ENSURE(xStreamProp.is(),"No valid preoperty set for the output 
stream!");
+OSL_ENSURE(xStreamProp.is(),"No valid property set for the output 
stream!");
 
 uno::Reference xSeek(xStreamProp,uno::UNO_QUERY);
 if ( xSeek.is() )
diff --git a/reportdesign/source/ui/inc/GeometryHandler.hxx 
b/reportdesign/source/ui/inc/GeometryHandler.hxx
index d277cc402c24..3bf7d026f2e9 100644
--- a/reportdesign/source/ui/inc/GeometryHandler.hxx
+++ b/reportdesign/source/ui/inc/GeometryHandler.hxx
@@ -210,7 +210,7 @@ namespace rptui
 */
 void loadDefaultFunctions();
 
-/** creates a default functionof the _sFunction for the data field 
_sDataField
+/** creates a default function of the _sFunction for the data field 
_sDataField
 *   The new function will only be created if it didn't exist.
 *
 * \param _aGuardWill be cleared, when a new function was 
created.
diff --git a/rsc/source/rscpp/cpp3.c b/rsc/source/rscpp/cpp3.c
index 078be477d815..6e6f87aa59a8 100644
--- a/rsc/source/rscpp/cpp3.c
+++ b/rsc/source/rscpp/cpp3.c
@@ -209,7 +209,7 @@ int dooptions(int argc, char** argv)
 AddInclude( ap );   /* BP, 11.09.91 */
 break;
 
-case 'N':   /* No predefineds   */
+case 'N':   /* No predefined*/
 nflag++;/* Repeat to undefine   */
 break;  /* __LINE__, etc.   */
 
diff --git a/sal/osl/

[Libreoffice-commits] core.git: javaunohelper/com javaunohelper/test jurt/com l10ntools/inc l10ntools/source libreofficekit/README libreofficekit/source lingucomponent/source linguistic/source linguis

[Andrea Gelmini]

 javaunohelper/com/sun/star/comp/helper/ComponentContext.java|  
  2 +-
 javaunohelper/test/com/sun/star/lib/uno/helper/InterfaceContainer_Test.java |  
  4 ++--
 jurt/com/sun/star/comp/loader/JavaLoader.java   |  
  4 ++--
 l10ntools/inc/common.hxx|  
  2 +-
 l10ntools/source/export.cxx |  
  2 +-
 l10ntools/source/xmlparse.cxx   |  
  2 +-
 libreofficekit/README   |  
  2 +-
 libreofficekit/source/gtk/tilebuffer.hxx|  
  2 +-
 lingucomponent/source/hyphenator/hyphen/hyphenimp.cxx   |  
  2 +-
 linguistic/source/lngsvcmgr.cxx |  
  2 +-
 linguistic/workben/sspellimp.cxx|  
  2 +-
 lotuswordpro/source/filter/lwpfribmark.cxx  |  
  2 +-
 lotuswordpro/source/filter/lwpoleobject.cxx |  
  2 +-
 lotuswordpro/source/filter/lwpsilverbullet.cxx  |  
  2 +-
 lotuswordpro/source/filter/lwptoc.cxx   |  
  2 +-
 lotuswordpro/source/filter/xfilter/xfbgimage.hxx|  
  2 +-
 lotuswordpro/source/filter/xfilter/xffont.hxx   |  
  2 +-
 lotuswordpro/source/filter/xfilter/xfpoint.hxx  |  
  2 +-
 mysqlc/README   |  
  2 +-
 19 files changed, 21 insertions(+), 21 deletions(-)

New commits:
commit 98ef3edb8a5d1a13963101d41abb2a8dd8a806dd
Author: Andrea Gelmini 
Date:   Fri Mar 24 11:45:16 2017 +0100

Fix typos

Change-Id: Id5811d092917c872715559f4508d01e4173d090c
Reviewed-on: https://gerrit.libreoffice.org/35636
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/javaunohelper/com/sun/star/comp/helper/ComponentContext.java 
b/javaunohelper/com/sun/star/comp/helper/ComponentContext.java
index 67579f95bae8..b280f80cbeaf 100644
--- a/javaunohelper/com/sun/star/comp/helper/ComponentContext.java
+++ b/javaunohelper/com/sun/star/comp/helper/ComponentContext.java
@@ -236,7 +236,7 @@ public class ComponentContext implements XComponentContext, 
XComponent
 m_eventListener.clear();
 
 XComponent tdmgr = null;
-// dispose values, then service manager, then typdescription manager
+// dispose values, then service manager, then typedescription manager
 for (Map.Entry entry : m_table.entrySet())
 {
 String name = entry.getKey();
diff --git 
a/javaunohelper/test/com/sun/star/lib/uno/helper/InterfaceContainer_Test.java 
b/javaunohelper/test/com/sun/star/lib/uno/helper/InterfaceContainer_Test.java
index d9488114d420..a406b84d457e 100644
--- 
a/javaunohelper/test/com/sun/star/lib/uno/helper/InterfaceContainer_Test.java
+++ 
b/javaunohelper/test/com/sun/star/lib/uno/helper/InterfaceContainer_Test.java
@@ -461,7 +461,7 @@ public class InterfaceContainer_Test
 
 @Test public void ListIterator_next() throws Exception
 {
-logger.log(Level.INFO, "Testing InterfaceContainer.listIerator, 
ListIterator.next()");
+logger.log(Level.INFO, "Testing InterfaceContainer.listIterator, 
ListIterator.next()");
 InterfaceContainer cont= new InterfaceContainer();
 
 cont.addAll(list1);
@@ -658,4 +658,4 @@ public class InterfaceContainer_Test
 assertEquals(obj2.nDisposingCalled, 1);
 assertEquals(obj3.nDisposingCalled, 1);
 }
-}
\ No newline at end of file
+}
diff --git a/jurt/com/sun/star/comp/loader/JavaLoader.java 
b/jurt/com/sun/star/comp/loader/JavaLoader.java
index 6ab67b960ddd..6c5b4cc97023 100644
--- a/jurt/com/sun/star/comp/loader/JavaLoader.java
+++ b/jurt/com/sun/star/comp/loader/JavaLoader.java
@@ -160,7 +160,7 @@ public class JavaLoader implements XImplementationLoader,
  * new com.sun.star.lang.XMultiServiceFactory should be set at
  * the loader.
  *
- * @param   args - the first parameter (args[0]) specifices the 
ServiceManager.
+ * @param   args - the first parameter (args[0]) specifies the 
ServiceManager.
  * @see com.sun.star.lang.XInitialization
  * @see com.sun.star.comp.servicemanager.ServiceManager
  */
@@ -415,7 +415,7 @@ public class JavaLoader implements XImplementationLoader,
  * Registers the JavaLoader at the registry.
  *
  * @param  regKey   root key under which the JavaLoader 
should be registered.
- * @return true if registration succseeded - otherwise false.
+ * @return true if registration succeeded - otherwise false.
  */
 public static boolean writeRegistryServiceInfo(XRegistryKey regKey) {
 boolean result = false;
diff --git a/

[Libreoffice-commits] core.git: include/jvmfwk include/o3tl include/oox include/osl include/registry include/rtl include/sal include/sfx2

[Andrea Gelmini]

 include/jvmfwk/framework.hxx|4 ++--
 include/o3tl/any.hxx|2 +-
 include/o3tl/strong_int.hxx |4 ++--
 include/oox/dump/dumperbase.hxx |2 +-
 include/osl/file.h  |6 +++---
 include/osl/security_decl.hxx   |2 +-
 include/osl/socket.h|2 +-
 include/osl/socket_decl.hxx |4 ++--
 include/registry/registry.hxx   |2 +-
 include/registry/types.hxx  |2 +-
 include/rtl/bootstrap.h |2 +-
 include/rtl/byteseq.h   |4 ++--
 include/rtl/locale.h|2 +-
 include/sal/types.h |4 ++--
 include/sfx2/childwin.hxx   |2 +-
 include/sfx2/docmacromode.hxx   |2 +-
 include/sfx2/shell.hxx  |2 +-
 include/sfx2/thumbnailview.hxx  |2 +-
 18 files changed, 25 insertions(+), 25 deletions(-)

New commits:
commit 86781bcfc8f12df980af5c86c2f9e75067f02abc
Author: Andrea Gelmini 
Date:   Fri Mar 24 11:42:19 2017 +0100

Fix typos

Change-Id: I998e9b2ad8ebdcc983239192cb61f6689e378ad9
Reviewed-on: https://gerrit.libreoffice.org/35633
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/include/jvmfwk/framework.hxx b/include/jvmfwk/framework.hxx
index b2d550e28c3a..8f3a3a0022b9 100644
--- a/include/jvmfwk/framework.hxx
+++ b/include/jvmfwk/framework.hxx
@@ -293,7 +293,7 @@ struct JavaInfoGuard {
the second argument which is compared with the first.
@return
true - both object represent the same JRE.
-   false - the objects represend different JREs
+   false - the objects represent different JREs
  */
 JVMFWK_DLLPUBLIC bool jfw_areEqualJavaInfo(
 JavaInfo const * pInfoA,JavaInfo const * pInfoB);
@@ -328,7 +328,7 @@ JVMFWK_DLLPUBLIC javaFrameworkError 
jfw_isVMRunning(sal_Bool *bRunning);
 JREs can be provided by different vendors.
 The function obtains information about JRE installations and checks if
 there is one among them that supports
-a set of features (currently only accessibilty is possible). If none was
+a set of features (currently only accessibility is possible). If none was
 found then it also uses a list of paths, which have been registered
 by jfw_addJRELocation
 to find JREs. Found JREs are examined in the same way.
diff --git a/include/o3tl/any.hxx b/include/o3tl/any.hxx
index 92627bdc7315..85fd28106419 100644
--- a/include/o3tl/any.hxx
+++ b/include/o3tl/any.hxx
@@ -98,7 +98,7 @@ template inline boost::optional 
tryGetConverted(
 /** Try to access the value of a specific type stored in an Any.
 
 In trying to obtain a value, the same set of conversions as supported by
-">>=" are considere.
+">>=" are considered.
 
 The returned object is a proxy.  Proxies can be either positive or 
negative.
 Each proxy can be contextually converted to bool, yielding true iff the
diff --git a/include/o3tl/strong_int.hxx b/include/o3tl/strong_int.hxx
index 690fefa9032a..30322b3efe6a 100644
--- a/include/o3tl/strong_int.hxx
+++ b/include/o3tl/strong_int.hxx
@@ -33,8 +33,8 @@ namespace o3tl
 ///   typedef o3tl::strong_int MyInt;
 ///
 /// \param UNDERLYING_TYPE the underlying scalar type
-/// \param PHANTOM_TYPEa type tag, used to distinguish this instantion of 
the template
-///from other instantiantions with the same 
UNDERLYING_TYPE.
+/// \param PHANTOM_TYPEa type tag, used to distinguish this instantiation 
of the template
+///from other instantiations with the same 
UNDERLYING_TYPE.
 ///
 template 
 struct strong_int
diff --git a/include/oox/dump/dumperbase.hxx b/include/oox/dump/dumperbase.hxx
index 048ea78fb88b..1343b533038d 100644
--- a/include/oox/dump/dumperbase.hxx
+++ b/include/oox/dump/dumperbase.hxx
@@ -498,7 +498,7 @@ typedef std::shared_ptr< NameListBase > NameListRef;
 
 /** Base class of all classes providing names for specific values (name lists).
 
-The idea is to provide a unique interfase for all different methods to
+The idea is to provide a unique interface for all different methods to
 write specific names for any values. This can be enumerations (dedicated
 names for a subset of values), or names for bits in bit fields. Classes
 derived from this base class implement the specific behaviour for the
diff --git a/include/osl/file.h b/include/osl/file.h
index 5773f503fc0a..9404ffa53dbf 100644
--- a/include/osl/file.h
+++ b/include/osl/file.h
@@ -34,7 +34,7 @@ extern "C" {
 
 Main goals and usage hints
 
-The main intentention of this interface is to provide an universal portable and
+The main intention of this interface is to provide an universal portable and
 high performance access to file system issues on any operating system.
 
 There are a few main goals:
@@ -571,7 +571,7 @@ struct _oslVolumeInfo {
 sal_uInt64  uFreeSpace;
 /** Maximum length of file name of a single item */
 sal_uInt32  uMaxNameLength;
-/** Maximum length of a full quallified path in system not

[Libreoffice-commits] core.git: include/svtools include/svx include/tools

[Andrea Gelmini]

 include/svtools/fmtfield.hxx  |4 ++--
 include/svtools/ivctrl.hxx|4 ++--
 include/svtools/parhtml.hxx   |2 +-
 include/svtools/table/tablesort.hxx   |2 +-
 include/svx/dialcontrol.hxx   |2 +-
 include/svx/fmsearch.hxx  |2 +-
 include/svx/sdr/overlay/overlayobject.hxx |2 +-
 include/svx/sdrpaintwindow.hxx|2 +-
 include/svx/shapepropertynotifier.hxx |2 +-
 include/svx/svddrgv.hxx   |2 +-
 include/svx/svdmrkv.hxx   |2 +-
 include/tools/pstm.hxx|2 +-
 12 files changed, 14 insertions(+), 14 deletions(-)

New commits:
commit 1735654408f5bcc912f039a2f9263adb48edf9c1
Author: Andrea Gelmini 
Date:   Fri Mar 24 11:43:29 2017 +0100

Fix typos

Change-Id: Ib8bec97be916d5ea70ae9fb9dc83771b6fec1845
Reviewed-on: https://gerrit.libreoffice.org/35634
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/include/svtools/fmtfield.hxx b/include/svtools/fmtfield.hxx
index f59389c2de35..680c611999ba 100644
--- a/include/svtools/fmtfield.hxx
+++ b/include/svtools/fmtfield.hxx
@@ -205,7 +205,7 @@ public:
 /** enables handling of not-a-number value.
 
 When this is set to  (the default), then invalid inputs (i.e. 
text which cannot be
-intepreted, according to the current formatting) will be handled as if 
the default value
+interpreted, according to the current formatting) will be handled as 
if the default value
 has been entered. GetValue the will return this default value.
 
 When set to , then GetValue will return NaN (not a number, see 
isNan)
@@ -230,7 +230,7 @@ protected:
 void impl_Modify(bool makeValueDirty = true);
 virtual void Modify() override;
 
-// Override CheckTextfor input-time checks
+// Override CheckText for input-time checks
 virtual bool CheckText(const OUString&) const { return true; }
 
 // any aspect of the current format has changed
diff --git a/include/svtools/ivctrl.hxx b/include/svtools/ivctrl.hxx
index ea7116e64b0b..5f3083ce363f 100644
--- a/include/svtools/ivctrl.hxx
+++ b/include/svtools/ivctrl.hxx
@@ -153,7 +153,7 @@ public:
 WB_SMALL_ICON   // Text right to the icon, position does not mind
 WB_DETAILS  // Text right to the icon, limited positioning
 WB_BORDER
-WB_NOHIDESELECTION  // Draw selection inaktively, if not focused.
+WB_NOHIDESELECTION  // Draw selection inactively, if not focused.
 WB_NOHSCROLL
 WB_NOVSCROLL
 WB_NOSELECTION
@@ -262,7 +262,7 @@ public:
 voidSetCursor( SvxIconChoiceCtrlEntry* pEntry );
 SvxIconChoiceCtrlEntry* GetCursor() const;
 
-// Re-calculation of cached view-data and invalidatiopn of those in the 
view
+// Re-calculation of cached view-data and invalidation of those in the view
 voidInvalidateEntry( SvxIconChoiceCtrlEntry* pEntry );
 
 // Entry is selectd, if the BoundRect is selected
diff --git a/include/svtools/parhtml.hxx b/include/svtools/parhtml.hxx
index 55c9227f075d..ddb65c2abd7c 100644
--- a/include/svtools/parhtml.hxx
+++ b/include/svtools/parhtml.hxx
@@ -256,7 +256,7 @@ public:
 
 // remove a comment around the content of 

Re: master builds, starts but no UI

[Thorsten Wagner]

Hi all,

confirming on Debian 4.9.13. Build is without errors - no GUI, but no crash 
when running.

brgds

Thorsten

> On 25.03.2017, at 09:20, Jean-Baptiste Faure  wrote:
> 
> Hi,
> 
> I don't know if it is only me: current master builds without problem, it 
> starts but the UI does not show up and it does not crash, it does nothing 
> (CPU = 0%). Under gdb I see nothing I am able to interpret.
> I am building under Ubuntu 16.04 x86-64
> 
> I encounter this problem one or two days, somewhere after the commit 
> 7a46166beb714a3357f7fb04111ba98f6325065f
> I am currently bisecting.
> 
> Does somebody confirm ?
> 
> Best regards
> JBF
> -- 
> Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
> Disclaimer: my Internet Provider being located in France, each of our
> exchanges over Internet will be scanned by French spying services.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: editeng/source embeddedobj/source embeddedobj/test embedserv/source extensions/source extensions/test

[Andrea Gelmini]

 editeng/source/misc/hangulhanja.cxx   |2 +-
 editeng/source/outliner/outliner.cxx  |2 +-
 editeng/source/rtf/rtfitem.cxx|2 +-
 editeng/source/uno/unoedhlp.cxx   |2 +-
 embeddedobj/source/msole/olepersist.cxx   |2 +-
 embeddedobj/test/Container1/EmbedContApp.java |2 +-
 embedserv/source/inc/intercept.hxx|2 +-
 extensions/source/abpilot/datasourcehandling.hxx  |2 +-
 extensions/source/activex/SOActiveX.cxx   |2 +-
 extensions/source/config/ldap/ldapuserprofilebe.hxx   |4 ++--
 extensions/source/ole/oleobjw.cxx |8 
 extensions/source/ole/oleobjw.hxx |2 +-
 extensions/source/ole/unoconversionutilities.hxx  |2 +-
 extensions/source/ole/unoobjw.cxx |2 +-
 extensions/source/propctrlr/propcontroller.cxx|2 +-
 extensions/test/ole/unoTocomCalls/XCallback_Impl/Callback.cpp |2 +-
 16 files changed, 20 insertions(+), 20 deletions(-)

New commits:
commit 55cc79f33f8e4f95f7d56576949db1fb42bf913f
Author: Andrea Gelmini 
Date:   Fri Mar 24 11:36:55 2017 +0100

Fix typos

Change-Id: Ic823a46019138b8bbcacd7b52b48d7d7ead2fde2
Reviewed-on: https://gerrit.libreoffice.org/35629
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/editeng/source/misc/hangulhanja.cxx 
b/editeng/source/misc/hangulhanja.cxx
index 7611fe509172..b2ee5df9b8f3 100644
--- a/editeng/source/misc/hangulhanja.cxx
+++ b/editeng/source/misc/hangulhanja.cxx
@@ -88,7 +88,7 @@ namespace editeng
 // (and likely a 
specialised dialog) or if it is to run
 // automatically without 
any user interaction.
 // True for Hangul / Hanja 
conversion
-// False for Chinese 
simlified / traditional conversion
+// False for Chinese 
simplified / traditional conversion
 
 HangulHanjaConversion*  m_pAntiImpl;// our "anti-impl" 
instance
 
diff --git a/editeng/source/outliner/outliner.cxx 
b/editeng/source/outliner/outliner.cxx
index ec6e5caa83b8..014ece747009 100644
--- a/editeng/source/outliner/outliner.cxx
+++ b/editeng/source/outliner/outliner.cxx
@@ -2102,7 +2102,7 @@ NonOverflowingText *Outliner::GetNonOverflowingText() 
const
 const sal_Int32 nEndPos = pEditEngine->GetTextLen(nEndPara);
 
 if (nLen == 0) {
-// XXX: What happens inside this case might be dependent on the 
joining paragraps or not-thingy
+// XXX: What happens inside this case might be dependent on the 
joining paragraph or not-thingy
 // Overflowing paragraph is empty or first line overflowing: it's 
not "Non-Overflowing" text then
 sal_Int32 nParaLen = 
GetText(GetParagraph(nOverflowingPara-1)).getLength();
 aOverflowingTextSelection =
diff --git a/editeng/source/rtf/rtfitem.cxx b/editeng/source/rtf/rtfitem.cxx
index 584fc1ddcbdc..7c7e6f1ab833 100644
--- a/editeng/source/rtf/rtfitem.cxx
+++ b/editeng/source/rtf/rtfitem.cxx
@@ -1866,7 +1866,7 @@ void SvxRTFParser::SetDefault( int nToken, int nValue )
 sal_uInt16 nTabCount = (SVX_TAB_DEFDIST * 13 ) / 
sal_uInt16(nValue);
 /*
  cmc, make sure we have at least one, or all hell breaks loose in
- everybodies exporters, #i8247#
+ everybody exporters, #i8247#
 */
 if (nTabCount < 1)
 nTabCount = 1;
diff --git a/editeng/source/uno/unoedhlp.cxx b/editeng/source/uno/unoedhlp.cxx
index 7d72e8c27f06..54839155d4c4 100644
--- a/editeng/source/uno/unoedhlp.cxx
+++ b/editeng/source/uno/unoedhlp.cxx
@@ -198,7 +198,7 @@ bool SvxEditSourceHelper::GetAttributeRun( sal_Int32& 
nStartIndex, sal_Int32& nE
 }
 }
 }
-//need find closest index behind nIndex in the following paragrphs
+//need find closest index behind nIndex in the following paragraphs
 if ( aEndPos.nIndex == nCrrntParaLen )
 {
 SfxItemSet aCrrntSet = rEE.GetAttribs( nPara, nCrrntParaLen-1, 
nCrrntParaLen, GetAttribsFlags::CHARATTRIBS );
diff --git a/embeddedobj/source/msole/olepersist.cxx 
b/embeddedobj/source/msole/olepersist.cxx
index 82fb981c5afc..2c0779f288d2 100644
--- a/embeddedobj/source/msole/olepersist.cxx
+++ b/embeddedobj/source/msole/olepersist.cxx
@@ -1338,7 +1338,7 @@ void SAL_CALL OleEmbeddedObject::setPersistentEntry(
 if ( m_bFromClipboard )
 {
 // the object should be initialized from clipboard
-// inpossibili

[Libreoffice-commits] core.git: i18npool/source i18nutil/README idlc/source include/apple_remote include/basegfx include/canvas include/comphelper include/connectivity include/cppu include/dbaccess in

[Andrea Gelmini]

 i18npool/source/collator/gencoll_rule.cxx   |2 +-
 i18nutil/README |2 +-
 idlc/source/options.cxx |2 +-
 include/apple_remote/RemoteControl.h|2 +-
 include/basegfx/polygon/b2dpolygon.hxx  |2 +-
 include/canvas/canvastools.hxx  |2 +-
 include/comphelper/interaction.hxx  |2 +-
 include/comphelper/listenernotification.hxx |2 +-
 include/connectivity/dbexception.hxx|2 +-
 include/connectivity/sqlerror.hxx   |2 +-
 include/cppu/macros.hxx |2 +-
 include/dbaccess/ToolBoxHelper.hxx  |2 +-
 include/drawinglayer/primitive2d/baseprimitive2d.hxx|2 +-
 include/drawinglayer/primitive2d/controlprimitive2d.hxx |2 +-
 include/drawinglayer/primitive2d/textprimitive2d.hxx|2 +-
 include/drawinglayer/primitive2d/unifiedtransparenceprimitive2d.hxx |2 +-
 include/drawinglayer/processor2d/linegeometryextractor2d.hxx|2 +-
 include/editeng/flditem.hxx |2 +-
 include/editeng/hangulhanja.hxx |2 +-
 include/editeng/svxrtf.hxx  |2 +-
 20 files changed, 20 insertions(+), 20 deletions(-)

New commits:
commit ee495c299b3d70b7a7099c51c6badf35a23f9a96
Author: Andrea Gelmini 
Date:   Fri Mar 24 11:41:08 2017 +0100

Fix typos

Change-Id: I389542e18fcf71011f22919743b5280779f449fd
Reviewed-on: https://gerrit.libreoffice.org/35632
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/i18npool/source/collator/gencoll_rule.cxx 
b/i18npool/source/collator/gencoll_rule.cxx
index 897d47fd8a69..7ca3e935e5f2 100644
--- a/i18npool/source/collator/gencoll_rule.cxx
+++ b/i18npool/source/collator/gencoll_rule.cxx
@@ -128,7 +128,7 @@ SAL_IMPLEMENT_MAIN_WITH_ARGS(argc, argv)
 printf("Could not get rule data from collator\n");
 }
 } else {
-printf("\nRule parsering error\n");
+printf("\nRule parsing error\n");
 }
 
 delete coll;
diff --git a/i18nutil/README b/i18nutil/README
index 1eceb18bb776..2f93fe54cedf 100644
--- a/i18nutil/README
+++ b/i18nutil/README
@@ -1,4 +1,4 @@
-i18nutil is internalization related utilities
+i18nutil is internationalization related utilities
 
 It comprises of honest c++ code which you just link to directly, while i18npool
 tends to consist of code you interact with via uno.
diff --git a/idlc/source/options.cxx b/idlc/source/options.cxx
index 794f7929ad33..be907232ca1b 100644
--- a/idlc/source/options.cxx
+++ b/idlc/source/options.cxx
@@ -194,7 +194,7 @@ bool Options::setOption(char const * option, std::string 
const & rArg)
 }
 
 #ifdef _WIN32
-/* Helper functiopn to convert windows paths including spaces, brackets etc. 
into
+/* Helper function to convert windows paths including spaces, brackets etc. 
into
a windows short Url. The ucpp preprocessor has problems with such paths and 
returns
with error.
 */
diff --git a/include/apple_remote/RemoteControl.h 
b/include/apple_remote/RemoteControl.h
index 10dfdaccfa4c..0b943920e6ee 100644
--- a/include/apple_remote/RemoteControl.h
+++ b/include/apple_remote/RemoteControl.h
@@ -35,7 +35,7 @@
 
 #include 
 
-// notifaction names that are being used to signal that an application wants to
+// notification names that are being used to signal that an application wants 
to
 // have access to the remote control device or if the application has finished
 // using the remote control device
 extern NSString* REQUEST_FOR_REMOTE_CONTROL_NOTIFCATION;
diff --git a/include/basegfx/polygon/b2dpolygon.hxx 
b/include/basegfx/polygon/b2dpolygon.hxx
index b4a44e042372..c32d8251002e 100644
--- a/include/basegfx/polygon/b2dpolygon.hxx
+++ b/include/basegfx/polygon/b2dpolygon.hxx
@@ -136,7 +136,7 @@ namespace basegfx
 usually pretty usable for processing purposes. There is no 
parameter
 passing here ATM but it may be changed on demand. If needed, a TYPE
 and PARAMETER (both defaulted) may be added to allow for switching
-between the different kinds of subdivisiond and passing them one
+between the different kinds of subdivisioned and passing them one
 parameter.
 
 The lifetime of the buffered subdivision is based on polygon 
changes.
diff --git a/include/canvas/canvastools.hxx b/include/canvas/canvastools.hxx
index df97d3f78232..a16da1871c79 100644
--- a/include/canvas/canvastools.hxx
+++ b/include/canvas/canvastools.hxx
@@ -313,7 +313,7 @@ namespace canvas
 
 @param i_rxC

[Libreoffice-commits] core.git: filter/source forms/source fpicker/source

[Andrea Gelmini]

 filter/source/graphicfilter/etiff/etiff.cxx |2 +-
 filter/source/graphicfilter/ipict/ipict.cxx |2 +-
 filter/source/graphicfilter/ipict/shape.cxx |2 +-
 filter/source/msfilter/dffpropset.cxx   |2 +-
 filter/source/msfilter/svdfppt.cxx  |8 
 filter/source/msfilter/util.cxx |4 ++--
 forms/source/component/FormattedFieldWrapper.cxx|2 +-
 forms/source/misc/InterfaceContainer.cxx|4 ++--
 forms/source/runtime/formoperations.hxx |2 +-
 forms/source/xforms/binding.cxx |2 +-
 forms/source/xforms/binding.hxx |2 +-
 forms/source/xforms/submission.cxx  |2 +-
 fpicker/source/office/OfficeFilePicker.cxx  |2 +-
 fpicker/source/office/commonpicker.hxx  |2 +-
 fpicker/source/win32/filepicker/VistaFilePicker.hxx |2 +-
 fpicker/source/win32/filepicker/VistaFilePickerEventHandler.hxx |2 +-
 fpicker/source/win32/filepicker/VistaFilePickerImpl.cxx |8 
 17 files changed, 25 insertions(+), 25 deletions(-)

New commits:
commit e4af83972e6be8b94772e46741500225ac166774
Author: Andrea Gelmini 
Date:   Fri Mar 24 11:38:26 2017 +0100

Fix typos

Change-Id: Ifb779b6c96a009e6c770a8017bb2e2031a288f5f
Reviewed-on: https://gerrit.libreoffice.org/35630
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/filter/source/graphicfilter/etiff/etiff.cxx 
b/filter/source/graphicfilter/etiff/etiff.cxx
index 43b6730c5b3b..01520ae90949 100644
--- a/filter/source/graphicfilter/etiff/etiff.cxx
+++ b/filter/source/graphicfilter/etiff/etiff.cxx
@@ -253,7 +253,7 @@ bool TIFFWriter::ImplWriteHeader( bool bMultiPage )
 
 // (OFS8) TIFF image file directory (IFD)
 mnCurrentTagCountPos = m_rOStm.Tell();
-m_rOStm.WriteUInt16( 0 );   // the number of tagentrys is 
to insert later
+m_rOStm.WriteUInt16( 0 );   // the number of tangents to 
insert later
 
 sal_uInt32 nSubFileFlags = 0;
 if ( bMultiPage )
diff --git a/filter/source/graphicfilter/ipict/ipict.cxx 
b/filter/source/graphicfilter/ipict/ipict.cxx
index dd5024df94e1..bcdbc3caa867 100644
--- a/filter/source/graphicfilter/ipict/ipict.cxx
+++ b/filter/source/graphicfilter/ipict/ipict.cxx
@@ -1231,7 +1231,7 @@ void PictReader::ReadHeader()
   if (st < 2) { confidence[st] = --actualConfid; continue; }
   IsVersion2 = false; return;
 }
-if (sBuf[0] != 0x00) continue; // unrecovable error
+if (sBuf[0] != 0x00) continue; // unrecoverable error
 int numZero = 0;
 do
   {
diff --git a/filter/source/graphicfilter/ipict/shape.cxx 
b/filter/source/graphicfilter/ipict/shape.cxx
index 99b8719ad623..5aba327f869d 100644
--- a/filter/source/graphicfilter/ipict/shape.cxx
+++ b/filter/source/graphicfilter/ipict/shape.cxx
@@ -122,7 +122,7 @@ namespace PictReaderShape {
   }
 
   //  draws a rectangle 
-  /* Note(checkme): contradically with the QuickDraw's reference 3-23, it 
seems better to consider
+  /* Note(checkme): contradictally with the QuickDraw's reference 3-23, it 
seems better to consider
  that the frame/content of a rectangle appears inside the given rectangle. 
Does a conversion
  appear between the pascal functions and the data stored in the file ? */
   void drawRectangle(VirtualDevice *dev, bool drawFrame, Rectangle const 
&orig, Size const &pSize) {
diff --git a/filter/source/msfilter/dffpropset.cxx 
b/filter/source/msfilter/dffpropset.cxx
index 214eb4808e88..5490fee57366 100644
--- a/filter/source/msfilter/dffpropset.cxx
+++ b/filter/source/msfilter/dffpropset.cxx
@@ -1160,7 +1160,7 @@ void DffPropSet::ReadPropSet( SvStream& rIn, bool 
bSetUninitializedOnly )
 // normally nContent is the complete size of the complex 
property,
 // but this is not always true for IMsoArrays ( what the hell 
is a IMsoArray ? )
 
-// I love special threatments :-(
+// I love special treatments :-(
 if ( ( nRecType == DFF_Prop_pVertices ) || ( nRecType == 
DFF_Prop_pSegmentInfo )
 || ( nRecType == DFF_Prop_fillShadeColors ) || ( nRecType 
== DFF_Prop_lineDashStyle )
 || ( nRecType == DFF_Prop_pWrapPolygonVertices ) || ( 
nRecType == DFF_Prop_connectorPoints )
diff --git a/filter/source/msfilter/svdfppt.cxx 
b/filter/source/msfilter/svdfppt.cxx
index cac4f5b44066..b7e76ca57d6d 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -277,7 +277,7 @@ SvStream& ReadPptDocumentAtom(SvStream& rIn, 
PptDocumentAtom& rAto

[Libreoffice-commits] core.git: framework/inc framework/qa framework/source

[Andrea Gelmini]

 framework/inc/jobs/configaccess.hxx|2 +-
 framework/inc/threadhelp/gate.hxx  |2 +-
 framework/inc/threadhelp/transactionbase.hxx   |2 +-
 framework/qa/complex/XTitle/CheckXTitle.java   |2 +-
 framework/qa/complex/framework/autosave/AutoSave.java  |2 +-
 framework/qa/complex/framework/autosave/Protocol.java  |2 +-
 framework/source/dispatch/mailtodispatcher.cxx |2 +-
 framework/source/dispatch/servicehandler.cxx   |2 +-
 framework/source/fwe/classes/addonsoptions.cxx |2 +-
 framework/source/fwe/helper/undomanagerhelper.cxx  |2 +-
 framework/source/inc/accelerators/acceleratorcache.hxx |2 +-
 framework/source/inc/accelerators/presethandler.hxx|2 +-
 framework/source/inc/loadenv/loadenv.hxx   |4 ++--
 framework/source/jobs/job.cxx  |2 +-
 framework/source/services/autorecovery.cxx |2 +-
 framework/source/services/frame.cxx|4 ++--
 framework/source/uielement/menubarmanager.cxx  |2 +-
 17 files changed, 19 insertions(+), 19 deletions(-)

New commits:
commit 74d67cffec4eea0a575869513158b050e42ec983
Author: Andrea Gelmini 
Date:   Fri Mar 24 11:39:28 2017 +0100

Fix typos

Change-Id: I63ae7dbd7edf66aa5542f7d41f1bfd8ac04fc5e8
Reviewed-on: https://gerrit.libreoffice.org/35631
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/framework/inc/jobs/configaccess.hxx 
b/framework/inc/jobs/configaccess.hxx
index 116d563758c8..b705b910d652 100644
--- a/framework/inc/jobs/configaccess.hxx
+++ b/framework/inc/jobs/configaccess.hxx
@@ -33,7 +33,7 @@ namespace framework{
 /**
 @short  implements a simple configuration access
 @descr  Sometimes it's better to have direct config access
-instead of using soecialize config items of the svtools
+instead of using specialized config items of the svtools
 project. This class can wrapp such configuration access.
  */
 class FWI_DLLPUBLIC ConfigAccess final
diff --git a/framework/inc/threadhelp/gate.hxx 
b/framework/inc/threadhelp/gate.hxx
index b09ba7257c32..eb538501b230 100644
--- a/framework/inc/threadhelp/gate.hxx
+++ b/framework/inc/threadhelp/gate.hxx
@@ -70,7 +70,7 @@ class Gate
 Gate(const Gate&) = delete;
 
/*-
 @short  copy-assignment
-@descr  Forbid copy assiging
+@descr  Forbid copy assigning
 
*//*-*/
 Gate& operator=(const Gate&) = delete;
 
diff --git a/framework/inc/threadhelp/transactionbase.hxx 
b/framework/inc/threadhelp/transactionbase.hxx
index ada6202fa584..9d57129a5c82 100644
--- a/framework/inc/threadhelp/transactionbase.hxx
+++ b/framework/inc/threadhelp/transactionbase.hxx
@@ -25,7 +25,7 @@
 namespace framework{
 
 
/*-
-@short  make it possible to instanciate a transacion manager as 
first member!
+@short  make it possible to instanciate a transaction manager as 
first member!
 @descr  If you use a transaction manager as a member of your class 
and wish to use it earlier then other ones
 you should have a look on this implementation. You must 
use it as the first base class
 of your implementation - because base classes are 
initialized by his order and before your
diff --git a/framework/qa/complex/XTitle/CheckXTitle.java 
b/framework/qa/complex/XTitle/CheckXTitle.java
index fce575c5101a..875ccd90a93a 100644
--- a/framework/qa/complex/XTitle/CheckXTitle.java
+++ b/framework/qa/complex/XTitle/CheckXTitle.java
@@ -200,7 +200,7 @@ public class CheckXTitle
 xDisProv = null;
 }
 
-/** @short sets frame title and checks for infinite recusion
+/** @short sets frame title and checks for infinite recursion
 
 @descr sets frame title. then cycles through default and
print preview. then closes the window and checks
diff --git a/framework/qa/complex/framework/autosave/AutoSave.java 
b/framework/qa/complex/framework/autosave/AutoSave.java
index e27724e4dfa3..c6e7549d0eb2 100644
--- a/framework/qa/complex/framework/autosave/AutoSave.java
+++ b/framework/qa/complex/framework/autosave/AutoSave.java
@@ -375,7 +375,7 @@ public class AutoSave
  *  @descr  First we simulate an UI save by dispatching the right URL
  *  to the document and at the same time we try to trigger an 
AutoSave
  *  from another thread. So these operations should be started at 
the same time.
- *  It should not crash. The AutoSave request must be postphoned.

[Libreoffice-commits] core.git: canvas/source chart2/qa chart2/source comphelper/qa compilerplugins/clang

[Andrea Gelmini]

 canvas/source/cairo/cairo_canvashelper.cxx |2 +-
 canvas/source/vcl/windowoutdevholder.hxx   |2 +-
 chart2/qa/extras/chart2dump/chart2dump.cxx |4 ++--
 chart2/source/controller/main/ChartController_Window.cxx   |2 +-
 chart2/source/inc/DiagramHelper.hxx|2 +-
 chart2/source/tools/CachedDataSequence.cxx |2 +-
 chart2/source/view/axes/ScaleAutomatism.cxx|2 +-
 chart2/source/view/charttypes/BarChart.cxx |2 +-
 chart2/source/view/inc/VSeriesPlotter.hxx  |2 +-
 comphelper/qa/complex/comphelper/SequenceOutputStreamUnitTest.java |2 +-
 compilerplugins/clang/passstuffbyref.cxx   |2 +-
 compilerplugins/clang/plugin.hxx   |2 +-
 compilerplugins/clang/sfxpoolitem.cxx  |2 +-
 compilerplugins/clang/unreffun.cxx |2 +-
 compilerplugins/clang/unusedmethods.py |2 +-
 15 files changed, 16 insertions(+), 16 deletions(-)

New commits:
commit 5262883672208ac17b58ec197a1f984d99403b7d
Author: Andrea Gelmini 
Date:   Sat Mar 25 09:32:57 2017 +0100

Fix typos

Change-Id: If92860597a44ee79b513d255ce3f21112485a97e
Reviewed-on: https://gerrit.libreoffice.org/35617
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/canvas/source/cairo/cairo_canvashelper.cxx 
b/canvas/source/cairo/cairo_canvashelper.cxx
index 2bfd634694e2..a27f69ba1085 100644
--- a/canvas/source/cairo/cairo_canvashelper.cxx
+++ b/canvas/source/cairo/cairo_canvashelper.cxx
@@ -276,7 +276,7 @@ namespace cairocanvas
 useStates( viewState, renderState, true );
 
 cairo_move_to( mpCairo.get(), aBezierSegment.Px + 0.5, 
aBezierSegment.Py + 0.5 );
-// tdf#99165 correction of control poinits not needed here, only 
hairlines drawn
+// tdf#99165 correction of control points not needed here, only 
hairlines drawn
 // (see cairo_set_line_width above)
 cairo_curve_to( mpCairo.get(),
 aBezierSegment.C1x + 0.5, aBezierSegment.C1y + 0.5,
diff --git a/canvas/source/vcl/windowoutdevholder.hxx 
b/canvas/source/vcl/windowoutdevholder.hxx
index 9c51ed1a33ce..83f5e65e6a5c 100644
--- a/canvas/source/vcl/windowoutdevholder.hxx
+++ b/canvas/source/vcl/windowoutdevholder.hxx
@@ -41,7 +41,7 @@ namespace vclcanvas
 virtual const OutputDevice& getOutDev() const override { return 
mrOutputWindow; }
 
 // TODO(Q2): Lifetime issue. Though WindowGraphicDeviceBase
-// now listenes to the window component, I still consider
+// now listens to the window component, I still consider
 // holding a naked reference unsafe here (especially as we
 // pass it around via getOutDev). This _only_ works reliably,
 // if disposing the SpriteCanvas correctly disposes all
diff --git a/chart2/qa/extras/chart2dump/chart2dump.cxx 
b/chart2/qa/extras/chart2dump/chart2dump.cxx
index cd9f004fa66d..7fc78e2f76a4 100755
--- a/chart2/qa/extras/chart2dump/chart2dump.cxx
+++ b/chart2/qa/extras/chart2dump/chart2dump.cxx
@@ -199,9 +199,9 @@ protected:
 
 bool readAndCheckTransformation(const drawing::HomogenMatrix3& rTransform, 
const OUString& sCheck, const double fEPS, OUString& rExpectedTranform)
 {
-rExpectedTranform = readExpected(sCheck); // Reference transfromation 
string
+rExpectedTranform = readExpected(sCheck); // Reference transformation 
string
 
-// Covnert string back to a transformation;
+// Convert string back to a transformation;
 drawing::HomogenMatrix3 aExpectedTransform;
 aExpectedTransform.Line1.Column1 = rExpectedTranform.getToken(0, 
';').toDouble();
 aExpectedTransform.Line1.Column2 = rExpectedTranform.getToken(1, 
';').toDouble();
diff --git a/chart2/source/controller/main/ChartController_Window.cxx 
b/chart2/source/controller/main/ChartController_Window.cxx
index b48f2d04716d..dd08a7ef99c1 100644
--- a/chart2/source/controller/main/ChartController_Window.cxx
+++ b/chart2/source/controller/main/ChartController_Window.cxx
@@ -1286,7 +1286,7 @@ bool ChartController::execute_KeyInput( const KeyEvent& 
rKEvt )
 ObjectType eObjectType = ObjectIdentifier::getObjectType( 
m_aSelection.getSelectedCID() );
 if( ! bReturn )
 {
-// Natvigation (Tab/F3/Home/End)
+// Navigation (Tab/F3/Home/End)
 uno::Reference< XChartDocument > xChartDoc( getModel(), uno::UNO_QUERY 
);
 ObjectKeyNavigation aObjNav( m_aSelection.getSelectedOID(), xChartDoc, 
ExplicitValueProvider::getExplicitValueProvider( m_xChartView ));
 awt::KeyEvent aKeyEvent( ::svt::AcceleratorExecute::st_VCLKey2AWTKey( 
aKeyCode ));
diff --git a/chart2/s

[Libreoffice-commits] core.git: wizards/source

[Jean-Pierre Ledure]

 wizards/source/access2base/Application.xba |2 +-
 wizards/source/access2base/Database.xba|2 +-
 wizards/source/access2base/Event.xba   |2 +-
 wizards/source/access2base/Recordset.xba   |1 +
 wizards/source/access2base/Trace.xba   |2 +-
 wizards/source/access2base/Utils.xba   |2 +-
 6 files changed, 6 insertions(+), 5 deletions(-)

New commits:
commit 72a2f615c37aada0d5ab8791f1fa9a71772b50f6
Author: Jean-Pierre Ledure 
Date:   Sat Mar 25 09:29:02 2017 +0100

Access2Base Missing parentheses - Bug #106710

Due to more severe Basic interpreter on final parentheses
missing parentheses were revealed

Change-Id: I779b5e3d299fb9c56ecd807d28a780cc3ab9a1b5

diff --git a/wizards/source/access2base/Application.xba 
b/wizards/source/access2base/Application.xba
index 46cb24afac2d..a972b3ca6bab 100644
--- a/wizards/source/access2base/Application.xba
+++ b/wizards/source/access2base/Application.xba
@@ -1069,7 +1069,7 @@ Dim sOutput As String, l As Long, lLength As Long
If Len(pvString) > 0 Then
For l = 1 To Len(pvString)
If lLength > 0 And Len(sOutput) > lLength Then 
Exit For
-   sOutput = sOutput & Utils._UTF8Encode(Mid(pvString, 
l, 1)
+   sOutput = sOutput & Utils._UTF8Encode(Mid(pvString, 
l, 1))
Next l
End If
 
diff --git a/wizards/source/access2base/Database.xba 
b/wizards/source/access2base/Database.xba
index 20129c17357d..dd5be2877283 100644
--- a/wizards/source/access2base/Database.xba
+++ b/wizards/source/access2base/Database.xba
@@ -1446,7 +1446,7 @@ Dim i As Integer, l As Long
lNextPattern = InStr(lCurrentChar, psString, 
vPatterns(i), 1)   '  Text (not case-sensitive) string comparison
If lNextPattern > 0 And lNextPattern < lPattern 
Then
lPattern = lNextPattern
-   sPattern = Mid(psString, lPattern, 
Len(vPatterns(i))
+   sPattern = Mid(psString, lPattern, 
Len(vPatterns(i)))
End If
Next i
'  Up to the next pattern or to the end of the string, 
UTF8-encode each character
diff --git a/wizards/source/access2base/Event.xba 
b/wizards/source/access2base/Event.xba
index 32ec17cc3937..1e858d914284 100644
--- a/wizards/source/access2base/Event.xba
+++ b/wizards/source/access2base/Event.xba
@@ -254,7 +254,7 @@ Const cstDatabaseForm = 
"com.sun.star.comp.forms.ODatabaseForm"
Set oObject = poEvent.Source
_EventSource = oObject
sArray = Split(Utils._getUNOTypeName(poEvent), ".")
-   _EventType = UCase(sArray(UBound(sArray))
+   _EventType = UCase(sArray(UBound(sArray)))
If Utils._hasUNOProperty(poEvent, "EventName") Then 
_EventName = poEvent.EventName
 
Select Case _EventType
diff --git a/wizards/source/access2base/Recordset.xba 
b/wizards/source/access2base/Recordset.xba
index 0bc968fd4c8e..b3b611359618 100644
--- a/wizards/source/access2base/Recordset.xba
+++ b/wizards/source/access2base/Recordset.xba
@@ -1124,6 +1124,7 @@ Private Function _PropertiesList() As Variant
 
_PropertiesList = Array("AbsolutePosition", "BOF", 
"Bookmarkable", "Bookmark", "EditMode" _
, "EOF", "Filter", 
"LastModified", "Name", "ObjectType" , 
"RecordCount" _
+   )
 
 End Function   '  _PropertiesList
 
diff --git a/wizards/source/access2base/Trace.xba 
b/wizards/source/access2base/Trace.xba
index fdc08d4d623c..601b711fdf33 100644
--- a/wizards/source/access2base/Trace.xba
+++ b/wizards/source/access2base/Trace.xba
@@ -182,7 +182,7 @@ Public Sub TraceLevel(ByVal Optional psTraceLevel As String)
Case psTraceLevel = ""
:   psTraceLevel = "ERROR"
Case Utils._InList(UCase(psTraceLevel), Array( _
TRACEDEBUG, TRACEINFO, TRACEWARNING, TRACEERRORS, 
TRACEFATAL, TRACEABORT _
-   )
+   ))
Case Else   
:   Goto Exit_Sub
End Select
_A2B_.MinimalTraceLevel = _TraceLevel(psTraceLevel)
diff --git a/wizards/source/access2base/Utils.xba 
b/wizards/source/access2base/Utils.xba
index ac99e5aae0e3..1d7cd1dcc970 100644
--- a/wizards/source/access2base/Utils.xba
+++ b/wizards/source/access2base/Utils.xba
@@ -1059,7 +1059,7 @@ Const cstDot = "."
 Dim sName As String
 
If InStr(psName, ".") > 0 Then
-   sName = Join(Split(psName, cstDot), cstSquareClose & cstDot 
& cstSquareOpen
+   sName = Join(Split(psName, cstDot), cstSquareClose & cstDot 
& cstSquareOpen)
_Surround = cstSquareOpen & sName & cstSquareClose
ElseIf InStr(psName, " ") > 0 Then
_Surround = cstSquareOpen & psName & cstSquareClo

master builds, starts but no UI

[Jean-Baptiste Faure]

Hi,

I don't know if it is only me: current master builds without problem, it 
starts but the UI does not show up and it does not crash, it does 
nothing (CPU = 0%). Under gdb I see nothing I am able to interpret.

I am building under Ubuntu 16.04 x86-64

I encounter this problem one or two days, somewhere after the commit 
7a46166beb714a3357f7fb04111ba98f6325065f

I am currently bisecting.

Does somebody confirm ?

Best regards
JBF
--
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
Disclaimer: my Internet Provider being located in France, each of our
exchanges over Internet will be scanned by French spying services.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice