[Libreoffice-bugs] [Bug 107068] PIVOT CHARTS: add "arrow" symbol to filter buttons to show they're drop down lists
https://bugs.documentfoundation.org/show_bug.cgi?id=107068 Adolfo Jaymechanged: What|Removed |Added Attachment #132449|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97631] cell with =24/ 2 formatted as date causes saved file to violate specification
https://bugs.documentfoundation.org/show_bug.cgi?id=97631 Aron Budeachanged: What|Removed |Added Resolution|FIXED |NOTABUG --- Comment #10 from Aron Budea --- Let me adjust status to NOTABUG, as on LibreOffice's side this was not a bug in the first place. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103596] Support OpenType Font Variation based text layout
https://bugs.documentfoundation.org/show_bug.cgi?id=103596 --- Comment #9 from Volga--- The following resources also useful for test. https://github.com/TypeNetwork/fb-Decovar https://github.com/TypeNetwork/fb-Amstelvar https://github.com/googlei18n/noto-fonts/tree/master/alpha/from-pipeline/unhinted/variable-ttf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: test/httpcrashtest.cpp test/httpwserror.cpp test/run_unit.sh.in wsd/LOOLWSD.cpp
test/httpcrashtest.cpp |2 +- test/httpwserror.cpp |2 +- test/run_unit.sh.in|1 - wsd/LOOLWSD.cpp|3 ++- 4 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 9c14446c88b2b00077132a37be48351d48e0eda1 Author: Ashod NakashianDate: Mon Apr 17 00:39:56 2017 -0400 wsd: re-enable a couple more tests that are stable Change-Id: I01bc96ce7bde7cac10d0b4d023b0d5dd774ed058 Reviewed-on: https://gerrit.libreoffice.org/36602 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/test/httpcrashtest.cpp b/test/httpcrashtest.cpp index deeed990..b6230d5a 100644 --- a/test/httpcrashtest.cpp +++ b/test/httpcrashtest.cpp @@ -56,7 +56,7 @@ class HTTPCrashTest : public CPPUNIT_NS::TestFixture CPPUNIT_TEST_SUITE(HTTPCrashTest); CPPUNIT_TEST(testBarren); -// FIXME CPPUNIT_TEST(testCrashKit); +CPPUNIT_TEST(testCrashKit); CPPUNIT_TEST(testRecoverAfterKitCrash); CPPUNIT_TEST(testCrashForkit); diff --git a/test/httpwserror.cpp b/test/httpwserror.cpp index a0663f63..7af7aa5a 100644 --- a/test/httpwserror.cpp +++ b/test/httpwserror.cpp @@ -40,7 +40,7 @@ class HTTPWSError : public CPPUNIT_NS::TestFixture CPPUNIT_TEST_SUITE(HTTPWSError); CPPUNIT_TEST(testBadDocLoadFail); -// FIXME CPPUNIT_TEST(testMaxDocuments); +CPPUNIT_TEST(testMaxDocuments); CPPUNIT_TEST(testMaxConnections); CPPUNIT_TEST(testMaxViews); diff --git a/test/run_unit.sh.in b/test/run_unit.sh.in index 32d7ba2d..4ac7fb30 100755 --- a/test/run_unit.sh.in +++ b/test/run_unit.sh.in @@ -82,7 +82,6 @@ if test "z$tst" == "z"; then --o:admin_console.username=admin --o:admin_console.password=admin \ > "$tst_log" 2>&1 & echo " executing test" - sleep 5 # allow for wsd to startup oldpath=`pwd` cd "${abs_top_builddir}/test" diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp index 21b046e5..c432a862 100644 --- a/wsd/LOOLWSD.cpp +++ b/wsd/LOOLWSD.cpp @@ -1664,7 +1664,8 @@ private: { // TODO: Send back failure. // NOTE: Check _wsState to choose between HTTP response or WebSocket (app-level) error. -LOG_ERR("#" << socket->getFD() << " Exception while processing incoming request: [" << LOOLProtocol::getAbbreviatedMessage(in) << "]"); +LOG_ERR("#" << socket->getFD() << " Exception while processing incoming request: [" << +LOOLProtocol::getAbbreviatedMessage(in) << "]: " << exc.what()); } return socketOwnership; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp
wsd/LOOLWSD.cpp |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit 6023fdc3c70a2d2aad2c98c8e739f19d7a630e8b Author: Ashod NakashianDate: Sun Apr 16 23:47:46 2017 -0400 wsd: take DocBrokers lock before broadcasting diskfull Change-Id: I4f7cccb1112c17091d1039441af4c84d5d13d059 Reviewed-on: https://gerrit.libreoffice.org/36601 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp index e3619b6e..21b046e5 100644 --- a/wsd/LOOLWSD.cpp +++ b/wsd/LOOLWSD.cpp @@ -209,7 +209,7 @@ inline void shutdownLimitReached(WebSocketHandler& ws) /// connected to any document. void alertAllUsersInternal(const std::string& msg) { -Util::assertIsLocked(DocBrokersMutex); +std::lock_guard docBrokersLock(DocBrokersMutex); LOG_INF("Alerting all users: [" << msg << "]"); @@ -2574,8 +2574,6 @@ void alertAllUsers(const std::string& cmd, const std::string& kind) void alertAllUsers(const std::string& msg) { -std::lock_guard docBrokersLock(DocBrokersMutex); - alertAllUsersInternal(msg); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: test/helpers.hpp test/httpwserror.cpp test/TileCacheTests.cpp
test/TileCacheTests.cpp |4 test/helpers.hpp| 21 ++--- test/httpwserror.cpp|3 +++ 3 files changed, 9 insertions(+), 19 deletions(-) New commits: commit 0feea0e80e5da95baa6554ad660df676613443fd Author: Ashod NakashianDate: Sun Apr 16 23:31:03 2017 -0400 wsd: include cleanup in test Change-Id: Ie54aabc74e8980f3131a66f3610c1dcdd9f668ff Reviewed-on: https://gerrit.libreoffice.org/36600 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp index 128f559d..227f7adb 100644 --- a/test/TileCacheTests.cpp +++ b/test/TileCacheTests.cpp @@ -9,6 +9,10 @@ #include "config.h" +#include +#include +#include + #include #include "Common.hpp" diff --git a/test/helpers.hpp b/test/helpers.hpp index ce6aef98..70bf6e4c 100644 --- a/test/helpers.hpp +++ b/test/helpers.hpp @@ -10,41 +10,24 @@ #ifndef INCLUDED_TEST_HELPERS_HPP #define INCLUDED_TEST_HELPERS_HPP -#include -#include -#include -#include -#include -#include +#include #include -#include -#include -#include -#include -#include -#include #include #include #include #include -#include #include -#include -#include #include #include -#include #include -#include #include + #include #include #include "common/FileUtil.hpp" -#include #include -#include #include #ifndef TDOC diff --git a/test/httpwserror.cpp b/test/httpwserror.cpp index ff417f25..a0663f63 100644 --- a/test/httpwserror.cpp +++ b/test/httpwserror.cpp @@ -12,11 +12,14 @@ #include #include +#include #include #include #include #include +#include #include +#include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: wsd/ClientSession.cpp
wsd/ClientSession.cpp |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 651e462ef0ef89cabf61863be9e766caa5f11d59 Author: Ashod NakashianDate: Sun Apr 16 22:58:34 2017 -0400 wsd: logs Change-Id: I43f8e3732c6948c8214b21a506cb2e5ba56bd2ad Reviewed-on: https://gerrit.libreoffice.org/36599 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp index d1140668..414f8b94 100644 --- a/wsd/ClientSession.cpp +++ b/wsd/ClientSession.cpp @@ -60,7 +60,7 @@ SocketHandlerInterface::SocketOwnership ClientSession::handleIncomingMessage() bool ClientSession::_handleInput(const char *buffer, int length) { -LOG_TRC(getName() << ": handling [" << getAbbreviatedMessage(buffer, length) << "]."); +LOG_TRC(getName() << ": handling incoming [" << getAbbreviatedMessage(buffer, length) << "]."); const std::string firstLine = getFirstLine(buffer, length); const auto tokens = LOOLProtocol::tokenize(firstLine.data(), firstLine.size()); @@ -486,7 +486,7 @@ bool ClientSession::handleKitToClientMessage(const char* buffer, const int lengt { const auto payload = std::make_shared(buffer, length, Message::Dir::Out); -LOG_TRC(getName() + ": handling [" << payload->abbr() << "]."); +LOG_TRC(getName() + ": handling kit-to-client [" << payload->abbr() << "]."); const std::string& firstLine = payload->firstLine(); const auto docBroker = _docBroker.lock(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107204] Writer treats Old Hungarian text as left-to-right script instead of right-to-left
https://bugs.documentfoundation.org/show_bug.cgi?id=107204 Adolfo Jaymechanged: What|Removed |Added Component|LibreOffice |Writer Summary|unicode 8.0 compatibility |Writer treats Old Hungarian |problem |text as left-to-right ||script instead of ||right-to-left -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Parts.js | 11 --- loleaflet/src/layer/tile/CalcTileLayer.js|2 +- loleaflet/src/layer/tile/ImpressTileLayer.js |2 +- 3 files changed, 10 insertions(+), 5 deletions(-) New commits: commit 624380089e193870bc8b1fb37fd19800a3377a2a Author: Ashod NakashianDate: Sun Apr 16 22:56:26 2017 -0400 loleaflet: don't send setclientpart when the server sets part Client now sends setclientpart only when it wants to change the current part number, but not when it is updating the current part when it receives setpart from the server. When switching parts (either by the keyboard or mouse) LoKit sends a notification of the current part and invalidates tiles. As a reaction to that the client cancels its tiles and requests new tiles for the new part. In addition, it sends setclientpart back with the new part number. This works fine, except when the client switches between parts quickly (as when randomly pressing page-up and page-down quickly in impress), by the time LoKit receives the second request the client would have reacted to switching the first by sending setclientpart for the first. This will result in a resonance back and forth ad infinitum (or when the client goes inactive). The client shouldn't echo back the part number which the LoKit has told it (it should only send it to explicitly set it itself). But the server should be smart enough to remove duplicate setpart notifications from the client queue. This reduces the chances of an ocillation like that to happen. Change-Id: Ia8a1bb25e427ab910129340ce599e3743983463b Reviewed-on: https://gerrit.libreoffice.org/36598 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loleaflet/src/control/Parts.js b/loleaflet/src/control/Parts.js index a7e4fd5b..1071db03 100644 --- a/loleaflet/src/control/Parts.js +++ b/loleaflet/src/control/Parts.js @@ -2,7 +2,7 @@ * Document parts switching handler */ L.Map.include({ - setPart: function (part) { + setPart: function (part, external) { var docLayer = this._docLayer; docLayer._prevSelectedPart = docLayer._selectedPart; if (part === 'prev') { @@ -30,7 +30,12 @@ L.Map.include({ parts: docLayer._parts, docType: docLayer._docType }); - this._socket.sendMessage('setclientpart part=' + docLayer._selectedPart); + + // If this wasn't triggered from the server, + // then notify the server of the change. + if (!external) { + this._socket.sendMessage('setclientpart part=' + docLayer._selectedPart); + } docLayer.eachView(docLayer._viewCursors, docLayer._onUpdateViewCursor, docLayer); docLayer.eachView(docLayer._cellViewCursors, docLayer._onUpdateCellViewCursor, docLayer); docLayer.eachView(docLayer._graphicViewMarkers, docLayer._onUpdateGraphicViewSelection, docLayer); @@ -260,7 +265,7 @@ L.Map.include({ }; this._socket.sendMessage('uno .uno:Name ' + JSON.stringify(command)); - this.setPart(this._docLayer, nPos); + this.setPart(this._docLayer); } }, diff --git a/loleaflet/src/layer/tile/CalcTileLayer.js b/loleaflet/src/layer/tile/CalcTileLayer.js index 9fba31fc..d0e300bf 100644 --- a/loleaflet/src/layer/tile/CalcTileLayer.js +++ b/loleaflet/src/layer/tile/CalcTileLayer.js @@ -334,7 +334,7 @@ L.CalcTileLayer = L.TileLayer.extend({ _onSetPartMsg: function (textMsg) { var part = parseInt(textMsg.match(/\d+/g)[0]); if (part !== this._selectedPart) { - this._map.setPart(part); + this._map.setPart(part, true); this._map.fire('setpart', {selectedPart: this._selectedPart}); // TODO: test it! this._map.fire('updaterowcolumnheaders'); diff --git a/loleaflet/src/layer/tile/ImpressTileLayer.js b/loleaflet/src/layer/tile/ImpressTileLayer.js index 09015cbf..09f8707f 100644 --- a/loleaflet/src/layer/tile/ImpressTileLayer.js +++ b/loleaflet/src/layer/tile/ImpressTileLayer.js @@ -343,7 +343,7 @@ L.ImpressTileLayer = L.TileLayer.extend({ _onSetPartMsg: function (textMsg) { var part = parseInt(textMsg.match(/\d+/g)[0]); if (part !== this._selectedPart) { - this._map.setPart(part); + this._map.setPart(part, true); this._map.fire('setpart', {selectedPart: this._selectedPart}); } },
[Libreoffice-commits] online.git: wsd/SenderQueue.hpp
wsd/SenderQueue.hpp |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) New commits: commit 9234dc4dc256bfb7a4a3e3680de4dfaaa451ed47 Author: Ashod NakashianDate: Sun Apr 16 20:50:15 2017 -0400 wsd: drop duplicate setpart before sending to clients When switching parts (either by the keyboard or mouse) LoKit sends a notification of the current part and invalidates tiles. As a reaction to that the client cancels its tiles and requests new tiles for the new part. Since the response to setpart is a large number of tile cancellation and new requests, the cost of setpart is significant (esp. with large number of clients). To avoid that, we de-duplicate setpart entries from the client queues so there would be only at most one setpart (the last) queued to be sent to the client. This minimizes the unnecessary noise when the part changes faster than the server and/or network can keep up. Change-Id: I87578004203acc63d43e6d398ca04e37f766d9ba Reviewed-on: https://gerrit.libreoffice.org/36597 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/wsd/SenderQueue.hpp b/wsd/SenderQueue.hpp index 41445ac9..98059e49 100644 --- a/wsd/SenderQueue.hpp +++ b/wsd/SenderQueue.hpp @@ -104,12 +104,11 @@ private: }); if (pos != _queue.end()) -{ _queue.erase(pos); -} } else if (command == "statusindicatorsetvalue:" || - command == "invalidatecursor:") + command == "invalidatecursor:" || + command == "setpart:") { // Remove previous identical enties of this command, // if any, and use most recent (incoming). @@ -120,9 +119,7 @@ private: }); if (pos != _queue.end()) -{ _queue.erase(pos); -} } else if (command == "invalidateviewcursor:") { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/core/Socket.js | 31 +++ 1 file changed, 31 insertions(+) New commits: commit 5479788e52f52c1a039ad72d1f78bfb0c310ce50 Author: Ashod NakashianDate: Sun Apr 16 15:00:53 2017 -0400 loleaflet: reconnect when load fails due to unloading Retry up to 10 times with a delay of 1 second in between. Also, show the user a message (after first reconnection fails) that the document is unloading to try again (but of course we auto-retry anyway). Change-Id: I616d7643f146a6d5b7ccda7bb2aa567e3a9efe47 Reviewed-on: https://gerrit.libreoffice.org/36596 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js index 6edafeb8..31b4ca86 100644 --- a/loleaflet/src/core/Socket.js +++ b/loleaflet/src/core/Socket.js @@ -6,6 +6,7 @@ /* global _ vex $ errorMessages */ L.Socket = L.Class.extend({ ProtocolVersionNumber: '0.1', + ReconnectCount: 0, getParameterValue: function (s) { var i = s.indexOf('='); @@ -360,6 +361,26 @@ L.Socket = L.Class.extend({ } else if (errorKind.startsWith('faileddocloading')) { this._map._fatal = true; this._map.fire('error', {msg: errorMessages.faileddocloading}); + } else if (errorKind.startsWith('docunloading')) { + // The document is unloading. Have to wait a bit. + this._map._active = false; + if (vex.dialogID <= 0 && this.ReconnectCount > 0) { + this._map.fire('error', {msg: _('The document is currently unloading. Please try again.'), cmd: 'socket', kind: 'closed', id: 4}); + } + + if (this.ReconnectCount++ >= 10) { + clearTimeout(vex.timer); + return; // Give up. + } + + map = this._map; + vex.timer = setInterval(function() { + try { + // Activate and cancel timer and dialogs. + map._activate(); + } catch (error) { + } + }, 1000); } if (passwordNeeded) { @@ -420,6 +441,16 @@ L.Socket = L.Class.extend({ else if (textMsg.startsWith('statusindicator:')) { //FIXME: We should get statusindicator when saving too, no? this._map.showBusy(_('Connecting...'), false); + if (textMsg.startsWith('statusindicator: ready')) { + // We're connected: cancel timer and dialog. + this.ReconnectCount = 0; + clearTimeout(vex.timer); + if (vex.dialogID > 0) { + var id = vex.dialogID; + vex.dialogID = -1; + vex.close(id); + } + } } else if (!textMsg.startsWith('tile:') && !textMsg.startsWith('renderfont:')) { // log the tile msg separately as we need the tile coordinates ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/map/Map.js |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 28d15220e6087c0ed9564e19575db6bfa4fd6885 Author: Ashod NakashianDate: Sun Apr 16 19:47:12 2017 -0400 loleaflet: don't reference uninitialized docLayer Change-Id: I0ea169474f17aa541f678c7474a6903b85129101 Reviewed-on: https://gerrit.libreoffice.org/36595 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js index 8d153a67..c76d4393 100644 --- a/loleaflet/src/map/Map.js +++ b/loleaflet/src/map/Map.js @@ -781,7 +781,9 @@ L.Map = L.Evented.extend({ console.debug('sending useractive'); this._socket.sendMessage('useractive'); this._active = true; - this._docLayer._onMessage('invalidatetiles: EMPTY', null); + if (this._doclayer) { + this._docLayer._onMessage('invalidatetiles: EMPTY', null); + } if (vex.dialogID > 0) { var id = vex.dialogID; vex.dialogID = -1; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107219] Instructions on how to print a range of pages incorrectly use a dash instead of hyphen
https://bugs.documentfoundation.org/show_bug.cgi?id=107219 Gérard Talbotchanged: What|Removed |Added URL||http://documentation.libreo ||ffice.org/assets/Uploads/Do ||cumentation/en/GS5.2/HTML/G ||S5210-PrintExportEmail.html ||#__RefHeading__8519_1712854 ||287 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107219] Instructions on how to print a range of pages incorrectly use a dash instead of hyphen
https://bugs.documentfoundation.org/show_bug.cgi?id=107219 --- Comment #3 from Gérard Talbot--- Exact spot in the documentation online: http://documentation.libreoffice.org/assets/Uploads/Documentation/en/GS5.2/HTML/GS5210-PrintExportEmail.html#__RefHeading__8519_1712854287 - - - - - - Webpage of ODT documents for downloads have been found here: Latest Getting Started Guide: Version 5.2; Download Individual chapters, chapter 10: 1.4Mega-bytes http://documentation.libreoffice.org/en/english-documentation/getting-started-guide/ LibreOffice 5.2 Getting Started User Guide: 20.4Mega-Bytes https://www.libreoffice.org/get-help/documentation/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/core/Socket.js |4 1 file changed, 4 insertions(+) New commits: commit 5e3fc10eee5dead114857f8c32d437caa97d03c9 Author: Ashod NakashianDate: Sun Apr 16 19:45:22 2017 -0400 loleaflet: log socket activity Change-Id: I763ac09fcd5eef700b331b4d8016db3d30e1ef9a Reviewed-on: https://gerrit.libreoffice.org/36594 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js index c2ef985b..6edafeb8 100644 --- a/loleaflet/src/core/Socket.js +++ b/loleaflet/src/core/Socket.js @@ -15,6 +15,7 @@ L.Socket = L.Class.extend({ }, initialize: function (map) { + console.debug('socket.initialize:'); this._map = map; try { if (map.options.permission) { @@ -108,6 +109,7 @@ L.Socket = L.Class.extend({ }, _onSocketOpen: function () { + console.debug('_onSocketOpen:'); // Always send the protocol version number. // TODO: Move the version number somewhere sensible. this._doSend('loolclient ' + this.ProtocolVersionNumber); @@ -524,11 +526,13 @@ L.Socket = L.Class.extend({ }, _onSocketError: function () { + console.debug('_onSocketError:'); this._map.hideBusy(); // Let onclose (_onSocketClose) report errors. }, _onSocketClose: function (e) { + console.debug('_onSocketClose:'); var isActive = this._map._active; this._map.hideBusy(); this._map._active = false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: net/WebSocketHandler.hpp wsd/LOOLWSD.cpp
net/WebSocketHandler.hpp |2 +- wsd/LOOLWSD.cpp |1 + 2 files changed, 2 insertions(+), 1 deletion(-) New commits: commit 1262378301011fe799d06869b62814d89992a538 Author: Ashod NakashianDate: Sun Apr 16 19:45:54 2017 -0400 wsd: send document unloading error as WS message Without an explicit WS message, the client does not get this message and the handler is not invoked at all. Change-Id: I71e210a9958965cff35dd4d0f1d99985429b82f4 Reviewed-on: https://gerrit.libreoffice.org/36593 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/net/WebSocketHandler.hpp b/net/WebSocketHandler.hpp index 85cad811..c6d69883 100644 --- a/net/WebSocketHandler.hpp +++ b/net/WebSocketHandler.hpp @@ -269,7 +269,7 @@ public: int getPollEvents(std::chrono::steady_clock::time_point now, int & timeoutMaxMs) override { -int timeSincePingMs = +const int timeSincePingMs = std::chrono::duration_cast(now - _pingSent).count(); timeoutMaxMs = std::min(timeoutMaxMs, PingFrequencyMs - timeSincePingMs); return POLLIN; diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp index 5112e9ae..e3619b6e 100644 --- a/wsd/LOOLWSD.cpp +++ b/wsd/LOOLWSD.cpp @@ -1241,6 +1241,7 @@ static std::shared_ptr findOrCreateDocBroker(WebSocketHandler& w if (docBroker->isMarkedToDestroy()) { LOG_WRN("DocBroker with docKey [" << docKey << "] that is marked to be destroyed. Rejecting client request."); +ws.sendMessage("error: cmd=load kind=docunloading"); ws.shutdown(WebSocketHandler::StatusCodes::ENDPOINT_GOING_AWAY, "error: cmd=load kind=docunloading"); return nullptr; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107219] Instructions on how to print a range of pages incorrectly use a dash instead of hyphen
https://bugs.documentfoundation.org/show_bug.cgi?id=107219 --- Comment #2 from Gérard Talbot--- > Expected results > - - - - - - - - - > There should be a hyphen inside "1-4". The documentation in that range of > pages example should be using a dash character. Duh!! Expected results - - - - - - - - - There should be a hyphen inside "1-4". The documentation in that range of pages example should be using *_an hyphen_* character. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107192] How to print a few non-contiguous pages from a multi-pages document
https://bugs.documentfoundation.org/show_bug.cgi?id=107192 --- Comment #8 from Gérard Talbot--- > Range require an hyphen > "-" (but the helpfile is actually using another character, not an hyphen) > I verified this very carefully with a real document and a printer connected > and there is an error in that document. There is a dash (em dash or figure > dash) inside "1–4" while there is an hyphen inside "1-4". LibreOffice Writer > will not accept a dash but will accept the hyphen. When I inputted 1–4 in > the input text box, the miniature page on its lefthand side indicated > "Aucune page" that you can translate into "No page". > (...) > This issue, I think, should be in a bug report by > itself. I have filed bug 107219 for this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107219] Instructions on how to print a range of pages incorrectly use a dash instead of hyphen
https://bugs.documentfoundation.org/show_bug.cgi?id=107219 --- Comment #1 from Gérard Talbot--- The screenshot ( attachment 132625 ) is quite revealing. The extended tip uses an hyphen while there is a dash inside the Pages input text control and the miniature on its lefthand side states "Aucune page" meaning that NO page is actually being selected to be printed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107219] New: Instructions on how to print a range of pages incorrectly use a dash instead of hyphen
https://bugs.documentfoundation.org/show_bug.cgi?id=107219 Bug ID: 107219 Summary: Instructions on how to print a range of pages incorrectly use a dash instead of hyphen Product: LibreOffice Version: 5.3.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: va...@gtalbot.org CC: olivier.hal...@documentfoundation.org Created attachment 132625 --> https://bugs.documentfoundation.org/attachment.cgi?id=132625=edit Screenshot of print dialog window when using a dash This bug report is a followup of bug 107192 comment 3, comment 5 and comment 7. Steps to reproduce: Download the "LibreOffice 5.2 Getting Started" document (20.4Mega-bytes)from http://documentation.libreoffice.org/assets/Uploads/Documentation/en/GS5.2/GS52-GettingStartedLO.odt or its chapter 10 (1.4Mega-bytes) from http://documentation.libreoffice.org/assets/Uploads/Documentation/en/GS5.2/ODT/GS5210-PrintExportEmail.odt Then go to "Controlling printing" page 293, then "Selecting pages/sheets/slides to print" section, "Printing a range of pages:" subsection. or to page 7, "Selecting pages/sheets/slides to print" in subsubsection "Writer" The text states exactly the following: " b) Enter the sequence numbers of the pages to print (for example, 1–4 or 1,3,7,11). " There is a dash between the 1 and 4 when there should be an hyphen between the 1 and 4. If you try to print a range of pages with a dash, you will not be able to print; you will not succeed. Actual results - - - - - - - - There is a dash inside "1–4". The documentation in that range of pages example is using a dash character. Expected results - - - - - - - - - There should be a hyphen inside "1-4". The documentation in that range of pages example should be using a dash character. I even went as far as trying to print a range of pages using "1–4" with a real document and a printer connected and I did not print anything. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107192] How to print a few non-contiguous pages from a multi-pages document
https://bugs.documentfoundation.org/show_bug.cgi?id=107192 --- Comment #7 from Gérard Talbot--- (In reply to Gérard Talbot from comment #3) > I went to > > https://www.libreoffice.org/get-help/documentation/ > > and then downloaded the document GS52-GettingStartedLO.odt (21 Mega-Bytes) > and this is what they say (in chapter 10, section Controlling printing, page > 293, subsection Selecting pages/sheets/slides to print in Writer) Also http://documentation.libreoffice.org/assets/Uploads/Documentation/en/GS5.2/ODT/GS5210-PrintExportEmail.odt if you want to view, download chapter 10 only. > " > Printing a range of pages: > 1) Choose File > Print from the Menu bar, or press Ctrl+P. > 2) On the Print dialog, select the range of pages to print. > a) In the Range and copies section of the General page, select the Pages > option. > b) Enter the sequence numbers of the pages to print (for example, 1–4 or > 1,3,7,11). > " I verified this very carefully with a real document and a printer connected and there is an error in that document. There is a dash (em dash or figure dash) inside "1–4" while there is an hyphen inside "1-4". LibreOffice Writer will not accept a dash but will accept the hyphen. When I inputted 1–4 in the input text box, the miniature page on its lefthand side indicated "Aucune page" that you can translate into "No page". Later in that same document, same chapter, in the Impress and Draw subsection, we can read this: " Printing a range of slides: 1) Choose File > Print from the Menu bar, or press Ctrl+P. 2) Select the slides to print. a) In the Range and copies section of the Print dialog, select the Slides option. b) Enter the slide numbers to print (for example 1-4 or 1,3,7,11). " and now, we see an hyphen! This issue, I think, should be in a bug report by itself. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89690] Can not find and replace text in a hyperlink without losing links
https://bugs.documentfoundation.org/show_bug.cgi?id=89690 --- Comment #3 from Reuben--- Still occuring Version: 5.2.6.2 Build ID: 1:5.2.6-2 CPU Threads: 4; OS Version: Linux 4.9; UI Render: default; VCL: kde4; Locale: en-AU (en_AU.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107100] [DISPLAY] Track changes rendering issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107100 Aron Budeachanged: What|Removed |Added Keywords||regression Status|UNCONFIRMED |NEW CC||ba...@caesar.elte.hu, ||hcas...@collabora.com Ever confirmed|0 |1 --- Comment #2 from Aron Budea --- Thanks for the bug report, Olivier. Indeed, only pieces texts that have comments assigned to should be highlighted, texts with associated changes shouldn't (same as in LibreOffice). This is probably a regression from the following commit: https://cgit.freedesktop.org/libreoffice/online/commit/?id=9c4fbdd7c51fb1eef545af265075a05d8372c8a4 Henry, could you please take a look? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 12 commits - filter/source
filter/source/svg/presentation_engine.js | 795 +-- 1 file changed, 236 insertions(+), 559 deletions(-) New commits: commit 44b14e8c7c485d8a3bb99d9484ac63273988b633 Author: Thorsten BehrensDate: Mon Apr 17 04:23:31 2017 +0200 svg filter: fix SweepWipePath.perform (found by eslint no-undef) Change-Id: I98d64618d28a06a04ce4e191be6ed90bc9af07bb diff --git a/filter/source/svg/presentation_engine.js b/filter/source/svg/presentation_engine.js index 01c49ef551b2..55b0221c7563 100644 --- a/filter/source/svg/presentation_engine.js +++ b/filter/source/svg/presentation_engine.js @@ -9922,14 +9922,14 @@ SweepWipePath.prototype.perform = function( nT ) { if(!this.bSingle && !this.bOppositeVertical) nT /= 2.0; -var aBasePath = PinWheelWipePath.calcCenteredClock( nT + 0.25, 1.0 ); +var poly = PinWheelWipePath.calcCenteredClock( nT + 0.25, 1.0 ); var aTransform; if(this.bCenter) { aTransform = SVGIdentityMatrix.translate(0.5, 0.0); -aBasePath.matrixTransform(aTransform); +poly.matrixTransform(aTransform); } -var res = aBasePath; +var res = poly; if(!this.bSingle) { if(this.bOppositeVertical) { commit 36e421ce36b77e3d35daeea35d998bcf4223dd08 Author: Thorsten Behrens Date: Mon Apr 17 04:17:20 2017 +0200 svg filter: fix eslint no-redeclare Change-Id: I8435d991c582d2b3102d3a42984bb773fddae87c diff --git a/filter/source/svg/presentation_engine.js b/filter/source/svg/presentation_engine.js index a5b4fe510f78..01c49ef551b2 100644 --- a/filter/source/svg/presentation_engine.js +++ b/filter/source/svg/presentation_engine.js @@ -1584,33 +1584,49 @@ function configureDetectionTools() this._skipOptionalSpaces(); return new SVGPathSegClosePath(owningPathSegList); case SVGPathSeg.PATHSEG_CURVETO_CUBIC_REL: -var points = {x1: this._parseNumber(), y1: this._parseNumber(), x2: this._parseNumber(), y2: this._parseNumber(), x: this._parseNumber(), y: this._parseNumber()}; +{ +const points = {x1: this._parseNumber(), y1: this._parseNumber(), x2: this._parseNumber(), y2: this._parseNumber(), x: this._parseNumber(), y: this._parseNumber()}; return new SVGPathSegCurvetoCubicRel(owningPathSegList, points.x, points.y, points.x1, points.y1, points.x2, points.y2); +} case SVGPathSeg.PATHSEG_CURVETO_CUBIC_ABS: -var points = {x1: this._parseNumber(), y1: this._parseNumber(), x2: this._parseNumber(), y2: this._parseNumber(), x: this._parseNumber(), y: this._parseNumber()}; +{ +const points = {x1: this._parseNumber(), y1: this._parseNumber(), x2: this._parseNumber(), y2: this._parseNumber(), x: this._parseNumber(), y: this._parseNumber()}; return new SVGPathSegCurvetoCubicAbs(owningPathSegList, points.x, points.y, points.x1, points.y1, points.x2, points.y2); +} case SVGPathSeg.PATHSEG_CURVETO_CUBIC_SMOOTH_REL: -var points = {x2: this._parseNumber(), y2: this._parseNumber(), x: this._parseNumber(), y: this._parseNumber()}; +{ +const points = {x2: this._parseNumber(), y2: this._parseNumber(), x: this._parseNumber(), y: this._parseNumber()}; return new SVGPathSegCurvetoCubicSmoothRel(owningPathSegList, points.x, points.y, points.x2, points.y2); +} case SVGPathSeg.PATHSEG_CURVETO_CUBIC_SMOOTH_ABS: -var points = {x2: this._parseNumber(), y2: this._parseNumber(), x: this._parseNumber(), y: this._parseNumber()}; +{ +const points = {x2: this._parseNumber(), y2: this._parseNumber(), x: this._parseNumber(), y: this._parseNumber()}; return new SVGPathSegCurvetoCubicSmoothAbs(owningPathSegList, points.x, points.y, points.x2, points.y2); +} case SVGPathSeg.PATHSEG_CURVETO_QUADRATIC_REL: -var points = {x1: this._parseNumber(), y1: this._parseNumber(), x: this._parseNumber(), y: this._parseNumber()}; +{ +const points = {x1: this._parseNumber(), y1: this._parseNumber(), x: this._parseNumber(), y: this._parseNumber()}; return new SVGPathSegCurvetoQuadraticRel(owningPathSegList, points.x, points.y, points.x1, points.y1); +} case SVGPathSeg.PATHSEG_CURVETO_QUADRATIC_ABS: -var points = {x1: this._parseNumber(), y1: this._parseNumber(), x: this._parseNumber(), y: this._parseNumber()}; +
[Libreoffice-bugs] [Bug 107192] How to print a few non-contiguous pages from a multi-pages document
https://bugs.documentfoundation.org/show_bug.cgi?id=107192 --- Comment #6 from Gérard Talbot--- > If you select the option "pages", set the cursor into the field and press > Ctrl+F1, you will *not* get the extended tip if info-balloon > (Tools/Options.../LibreOffice/General/Help/Info-balloon) is unchecked. I did more research and Shift+F1 will indeed display extended tip even if (Tools/Options.../LibreOffice/General/Help/Extended Tip) is unchecked: https://help.libreoffice.org/Common/Turning_Extended_Tips_On_and_Off - - - - - - - Regina, this must be your webpage: https://wiki.documentfoundation.org/User:Regina/HelpAuthoringDashboard -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107193] How to increase text size of local help files
https://bugs.documentfoundation.org/show_bug.cgi?id=107193 --- Comment #5 from Gérard Talbot--- > how is such user supposed to increase font size, text size in > LibreOffice applications (...) or b) from within the > menu? >From the menu bar, Display/Zoom will do this in LibreOffice applications. But this is still not possible from the Help window, for local helpfiles. The zoom factor that an user [re-]sets for a document in Writer has no effect, no impact at all on the zoom factor being applied to the Help Window (F1). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107204] unicode 8.0 compatibility problem
https://bugs.documentfoundation.org/show_bug.cgi?id=107204 --- Comment #2 from Kovács Viktor--- I am sorry, linux have required font with that unicode range. Later I will attach that kind of font, I promiss. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source
svx/source/dialog/crashreportdlg.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit cb56b36dacd63cb9ee133cd90ee798db592ae0fc Author: Markus MohrhardDate: Mon Apr 17 00:29:14 2017 +0200 make it possible to show crashreport error message This will allow us to show a warning that a specific version is not supported anymore and that people should update. Change-Id: Ie7f4e4c49efa9ed91725bf3a0512663b3b14178c Reviewed-on: https://gerrit.libreoffice.org/36589 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/svx/source/dialog/crashreportdlg.cxx b/svx/source/dialog/crashreportdlg.cxx index ed56b67678af..a2f00c5821dd 100644 --- a/svx/source/dialog/crashreportdlg.cxx +++ b/svx/source/dialog/crashreportdlg.cxx @@ -92,7 +92,9 @@ IMPL_LINK(CrashReportDialog, BtnHdl, Button*, pBtn, void) mpEditPostUpload->SetText(aProcessedMessage.replaceAll("~", "_")); } else -mpEditPostUpload->SetText("Error!"); +{ +mpEditPostUpload->SetText(aCrashID); +} mpBtnClose->Show(); mpFtBugReport->Show(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: desktop/source
desktop/source/app/crashreport.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8948d436572fcff6a7298872a33ca4b6fa2f8b61 Author: Markus MohrhardDate: Mon Apr 17 00:47:56 2017 +0200 submit crash reports using https Change-Id: I98e0af47f984d5327e23bfee6d4a27052b848699 Reviewed-on: https://gerrit.libreoffice.org/36591 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/desktop/source/app/crashreport.cxx b/desktop/source/app/crashreport.cxx index a12249da9096..373793f94470 100644 --- a/desktop/source/app/crashreport.cxx +++ b/desktop/source/app/crashreport.cxx @@ -75,7 +75,7 @@ void CrashReporter::writeCommonInfo() minidump_file << "ProductName=LibreOffice\n"; minidump_file << "Version=" LIBO_VERSION_DOTTED "\n"; minidump_file << "BuildID=" << utl::Bootstrap::getBuildIdData("") << "\n"; -minidump_file << "URL=http://crashreport.libreoffice.org/submit/\n;; +minidump_file << "URL=https://crashreport.libreoffice.org/submit/\n;; for (auto& keyValue : maKeyValues) { writeToStream(minidump_file, keyValue.first, keyValue.second); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: filter/source
filter/source/svg/presentation_engine.js | 256 --- 1 file changed, 232 insertions(+), 24 deletions(-) New commits: commit dd239283664e79337d385a63a18eb676d8688314 Author: Rohan KumarDate: Mon Mar 27 01:44:11 2017 +0530 tdf#51358 Add Support for ParallelSnakesWipe transition in SVG Export Ported the class ParallelSnakesWipePath Change-Id: Ife99723792d3d3614c7fff6bcf6abaf199568075 Reviewed-on: https://gerrit.libreoffice.org/35723 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/filter/source/svg/presentation_engine.js b/filter/source/svg/presentation_engine.js index 93facf847290..c705af7c2c98 100644 --- a/filter/source/svg/presentation_engine.js +++ b/filter/source/svg/presentation_engine.js @@ -4588,6 +4588,22 @@ function flipOnYAxis( aPath ) return aPolyPath; } +/** flipOnXAxis + * Flips the SVG Path element along x-axis + * + * @param aPath + * An object of type SVGPathElement to be flipped + */ +function flipOnXAxis( aPath ) +{ +var aPolyPath = aPath.cloneNode(true); +var aTransform = document.documentElement.createSVGMatrix(); +aTransform.d = -1; +aTransform.f = 1; +aPolyPath.matrixTransform(aTransform); +return aPolyPath; +} + /** SVGPathElement.matrixTransform * Apply the transformation defined by the passed matrix to the referenced * svg element. @@ -5164,29 +5180,30 @@ aTransitionClassOutMap = ['invalid', 'clip polypolygon', 'special']; */ // Transition Types -BARWIPE_TRANSITION = 1; -BOXWIPE_TRANSITION = 2; -FOURBOXWIPE_TRANSITION = 3; -ELLIPSEWIPE_TRANSITION = 4; // 17 -CLOCKWIPE_TRANSITION= 5; // 22 -PINWHEELWIPE_TRANSITION = 6; // 23 -PUSHWIPE_TRANSITION = 7; // 35 -SLIDEWIPE_TRANSITION= 8; // 36 -FADE_TRANSITION = 9; // 37 -RANDOMBARWIPE_TRANSITION= 10; // 38 -CHECKERBOARDWIPE_TRANSITION = 11; // 39 -DISSOLVE_TRANSITION = 12; // 40 -SNAKEWIPE_TRANSITION= 13; // 30 -IRISWIPE_TRANSITION = 14; // 12 -BARNDOORWIPE_TRANSITION = 15; // 4 -VEEWIPE_TRANSITION = 16; // 8 -ZIGZAGWIPE_TRANSITION = 17; // 10 -BARNZIGZAGWIPE_TRANSITION = 18; // 11 -FANWIPE_TRANSITION = 19; // 25 -SINGLESWEEPWIPE_TRANSITION = 20; // 24 -WATERFALLWIPE_TRANSITION= 21; // 34 -SPIRALWIPE_TRANSITION = 22; // 31 -MISCDIAGONALWIPE_TRANSITION = 23; // 7 +BARWIPE_TRANSITION = 1; +BOXWIPE_TRANSITION = 2; +FOURBOXWIPE_TRANSITION = 3; +ELLIPSEWIPE_TRANSITION = 4; // 17 +CLOCKWIPE_TRANSITION= 5; // 22 +PINWHEELWIPE_TRANSITION = 6; // 23 +PUSHWIPE_TRANSITION = 7; // 35 +SLIDEWIPE_TRANSITION= 8; // 36 +FADE_TRANSITION = 9; // 37 +RANDOMBARWIPE_TRANSITION= 10; // 38 +CHECKERBOARDWIPE_TRANSITION = 11; // 39 +DISSOLVE_TRANSITION = 12; // 40 +SNAKEWIPE_TRANSITION= 13; // 30 +PARALLELSNAKESWIPE_TRANSITION = 14; // 32 +IRISWIPE_TRANSITION = 15; // 12 +BARNDOORWIPE_TRANSITION = 16; // 4 +VEEWIPE_TRANSITION = 17; // 8 +ZIGZAGWIPE_TRANSITION = 18; // 10 +BARNZIGZAGWIPE_TRANSITION = 19; // 11 +FANWIPE_TRANSITION = 20; // 25 +SINGLESWEEPWIPE_TRANSITION = 21; // 24 +WATERFALLWIPE_TRANSITION= 22; // 34 +SPIRALWIPE_TRANSITION = 23; // 31 +MISCDIAGONALWIPE_TRANSITION = 24; // 7 aTransitionTypeInMap = { 'barWipe' : BARWIPE_TRANSITION, @@ -5206,6 +5223,7 @@ aTransitionTypeInMap = { 'dissolve' : DISSOLVE_TRANSITION, 'singleSweepWipe' : SINGLESWEEPWIPE_TRANSITION, 'snakeWipe' : SNAKEWIPE_TRANSITION, +'parallelSnakesWipe': PARALLELSNAKESWIPE_TRANSITION, 'spiralWipe': SPIRALWIPE_TRANSITION, 'irisWipe' : IRISWIPE_TRANSITION, 'veeWipe' : VEEWIPE_TRANSITION, @@ -5297,6 +5315,16 @@ BOTTOMRIGHTCOUNTERCLOCKWISE_TRANS_SUBTYPE = 73; // 75 BOTTOMLEFTCOUNTERCLOCKWISE_TRANS_SUBTYPE= 74; // 76 DOUBLEBARNDOOR_TRANS_SUBTYPE= 75; // 17 DOUBLEDIAMOND_TRANS_SUBTYPE = 76; // 18 +VERTICALTOPSAME_TRANS_SUBTYPE = 77; // 77 +VERTICALBOTTOMSAME_TRANS_SUBTYPE= 78; // 78 +VERTICALTOPLEFTOPPOSITE_TRANS_SUBTYPE = 79; // 79 +VERTICALBOTTOMLEFTOPPOSITE_TRANS_SUBTYPE= 80; // 80 +HORIZONTALLEFTSAME_TRANS_SUBTYPE= 81; // 81 +HORIZONTALRIGHTSAME_TRANS_SUBTYPE = 82; // 82 +HORIZONTALTOPLEFTOPPOSITE_TRANS_SUBTYPE = 83; // 83 +HORIZONTALTOPRIGHTOPPOSITE_TRANS_SUBTYPE= 84; // 84 +DIAGONALBOTTOMLEFTOPPOSITE_TRANS_SUBTYPE= 85; // 85 +DIAGONALTOPLEFTOPPOSITE_TRANS_SUBTYPE = 86; // 86 aTransitionSubtypeInMap = { 'default' : DEFAULT_TRANS_SUBTYPE, @@ -5375,7 +5403,17 @@
[Libreoffice-commits] core.git: filter/source
filter/source/svg/presentation_engine.js | 70 +-- 1 file changed, 67 insertions(+), 3 deletions(-) New commits: commit 0badc8447f3c608a8807df511f78799f827ccd2b Author: Rohan KumarDate: Wed Mar 15 19:30:42 2017 +0530 tdf#51358 Added Support for DoubleDiamondWipePath in Impress SVG Export Ported the class DoubleDiamondWipe Change-Id: Ic4432018278c7b3567996bc9463b0f8fc96ebbec Reviewed-on: https://gerrit.libreoffice.org/35225 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/filter/source/svg/presentation_engine.js b/filter/source/svg/presentation_engine.js index 0d4700bae119..93facf847290 100644 --- a/filter/source/svg/presentation_engine.js +++ b/filter/source/svg/presentation_engine.js @@ -5186,6 +5186,7 @@ FANWIPE_TRANSITION = 19; // 25 SINGLESWEEPWIPE_TRANSITION = 20; // 24 WATERFALLWIPE_TRANSITION= 21; // 34 SPIRALWIPE_TRANSITION = 22; // 31 +MISCDIAGONALWIPE_TRANSITION = 23; // 7 aTransitionTypeInMap = { 'barWipe' : BARWIPE_TRANSITION, @@ -5195,6 +5196,7 @@ aTransitionTypeInMap = { 'ellipseWipe' : ELLIPSEWIPE_TRANSITION, 'clockWipe' : CLOCKWIPE_TRANSITION, 'pinWheelWipe' : PINWHEELWIPE_TRANSITION, +'miscDiagonalWipe' : MISCDIAGONALWIPE_TRANSITION, 'pushWipe' : PUSHWIPE_TRANSITION, 'slideWipe' : SLIDEWIPE_TRANSITION, 'fade' : FADE_TRANSITION, @@ -5293,6 +5295,8 @@ TOPLEFTCOUNTERCLOCKWISE_TRANS_SUBTYPE = 71; // 73 TOPRIGHTCOUNTERCLOCKWISE_TRANS_SUBTYPE = 72; // 74 BOTTOMRIGHTCOUNTERCLOCKWISE_TRANS_SUBTYPE = 73; // 75 BOTTOMLEFTCOUNTERCLOCKWISE_TRANS_SUBTYPE= 74; // 76 +DOUBLEBARNDOOR_TRANS_SUBTYPE= 75; // 17 +DOUBLEDIAMOND_TRANS_SUBTYPE = 76; // 18 aTransitionSubtypeInMap = { 'default' : DEFAULT_TRANS_SUBTYPE, @@ -5369,8 +5373,10 @@ aTransitionSubtypeInMap = { 'verticalLeft' : VERTICALLEFT_TRANS_SUBTYPE, 'verticalRight' : VERTICALRIGHT_TRANS_SUBTYPE, 'horizontalLeft': HORIZONTALLEFT_TRANS_SUBTYPE, -'horizontalRight' : HORIZONTALRIGHT_TRANS_SUBTYPE -} +'horizontalRight' : HORIZONTALRIGHT_TRANS_SUBTYPE, +'doubleBarnDoor': DOUBLEBARNDOOR_TRANS_SUBTYPE, +'doubleDiamond' : DOUBLEDIAMOND_TRANS_SUBTYPE +}; // Transition Modes TRANSITION_MODE_IN = 1; @@ -5607,6 +5613,28 @@ aTransitionInfoTable[BARNDOORWIPE_TRANSITION][DIAGONALTOPLEFT_TRANS_SUBTYPE] = 'scaleIsotropically': false }; +aTransitionInfoTable[MISCDIAGONALWIPE_TRANSITION] = {}; +aTransitionInfoTable[MISCDIAGONALWIPE_TRANSITION][DOUBLEBARNDOOR_TRANS_SUBTYPE] = +{ +'class' : TRANSITION_CLIP_POLYPOLYGON, +'rotationAngle': 45.0, +'scaleX': Math.SQRT2, +'scaleY': Math.SQRT2, +'reverseMethod': REVERSEMETHOD_IGNORE, +'outInvertsSweep': true, +'scaleIsotropically': false +}; +aTransitionInfoTable[MISCDIAGONALWIPE_TRANSITION][DOUBLEDIAMOND_TRANS_SUBTYPE] = +{ +'class' : TRANSITION_CLIP_POLYPOLYGON, +'rotationAngle': 0.0, +'scaleX': 1, +'scaleY': 1, +'reverseMethod': REVERSEMETHOD_IGNORE, +'outInvertsSweep': true, +'scaleIsotropically': false +}; + aTransitionInfoTable[IRISWIPE_TRANSITION] = {}; aTransitionInfoTable[IRISWIPE_TRANSITION][RECTANGLE_TRANS_SUBTYPE] = { @@ -9837,7 +9865,7 @@ function createClipPolyPolygon( nType, nSubtype ) return null; } case BARNDOORWIPE_TRANSITION: -return new BarnDoorWipePath(true); +return new BarnDoorWipePath(false); case SINGLESWEEPWIPE_TRANSITION: return new SweepWipePath( // center @@ -9856,6 +9884,13 @@ function createClipPolyPolygon( nType, nSubtype ) return new WaterfallWipePath(128, // flipOnYAxis nSubtype == VERTICALRIGHT_TRANS_SUBTYPE || nSubtype == HORIZONTALLEFT_TRANS_SUBTYPE); +case MISCDIAGONALWIPE_TRANSITION: +switch(nSubtype) { +case DOUBLEBARNDOOR_TRANS_SUBTYPE: +return new BarnDoorWipePath(true /* Doubled */); +case DOUBLEDIAMOND_TRANS_SUBTYPE: +return new DoubleDiamondWipePath(); +} case DISSOLVE_TRANSITION: return new RandomWipePath( 16 * 16, false /* dissolve */ ); case VEEWIPE_TRANSITION: @@ -10329,6 +10364,35 @@ WaterfallWipePath.prototype.perform = function( nT ) { return this.bFlipOnYAxis ? flipOnYAxis(poly) : poly; } +/** Class DoubleDiamondWipePath + * + */ +function DoubleDiamondWipePath() { } + +DoubleDiamondWipePath.prototype.perform = function( nT ) { +var a =
[Libreoffice-commits] core.git: filter/source
filter/source/svg/presentation_engine.js | 305 --- 1 file changed, 237 insertions(+), 68 deletions(-) New commits: commit dc5253d97c6e733746943fae462600f07772d35b Author: Rohan KumarDate: Mon Mar 13 20:12:36 2017 +0530 tdf#51358 Add support for SpiralWipe transition in svg export Ported the class SpiralWipePath Change-Id: I3f24c3e32fb2994db0edb48e6c2bd017337c208a Reviewed-on: https://gerrit.libreoffice.org/35139 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/filter/source/svg/presentation_engine.js b/filter/source/svg/presentation_engine.js index fbdc222e0013..0d4700bae119 100644 --- a/filter/source/svg/presentation_engine.js +++ b/filter/source/svg/presentation_engine.js @@ -5185,6 +5185,7 @@ BARNZIGZAGWIPE_TRANSITION = 18; // 11 FANWIPE_TRANSITION = 19; // 25 SINGLESWEEPWIPE_TRANSITION = 20; // 24 WATERFALLWIPE_TRANSITION= 21; // 34 +SPIRALWIPE_TRANSITION = 22; // 31 aTransitionTypeInMap = { 'barWipe' : BARWIPE_TRANSITION, @@ -5203,6 +5204,7 @@ aTransitionTypeInMap = { 'dissolve' : DISSOLVE_TRANSITION, 'singleSweepWipe' : SINGLESWEEPWIPE_TRANSITION, 'snakeWipe' : SNAKEWIPE_TRANSITION, +'spiralWipe': SPIRALWIPE_TRANSITION, 'irisWipe' : IRISWIPE_TRANSITION, 'veeWipe' : VEEWIPE_TRANSITION, 'zigZagWipe': ZIGZAGWIPE_TRANSITION, @@ -5283,76 +5285,92 @@ VERTICALLEFT_TRANS_SUBTYPE = 63; // 93 VERTICALRIGHT_TRANS_SUBTYPE = 64; // 94 HORIZONTALLEFT_TRANS_SUBTYPE= 65; // 95 HORIZONTALRIGHT_TRANS_SUBTYPE = 66; // 96 +TOPLEFTCLOCKWISE_TRANS_SUBTYPE = 67; // 69 +TOPRIGHTCLOCKWISE_TRANS_SUBTYPE = 68; // 70 +BOTTOMRIGHTCLOCKWISE_TRANS_SUBTYPE = 69; // 71 +BOTTOMLEFTCLOCKWISE_TRANS_SUBTYPE = 70; // 72 +TOPLEFTCOUNTERCLOCKWISE_TRANS_SUBTYPE = 71; // 73 +TOPRIGHTCOUNTERCLOCKWISE_TRANS_SUBTYPE = 72; // 74 +BOTTOMRIGHTCOUNTERCLOCKWISE_TRANS_SUBTYPE = 73; // 75 +BOTTOMLEFTCOUNTERCLOCKWISE_TRANS_SUBTYPE= 74; // 76 aTransitionSubtypeInMap = { -'default' : DEFAULT_TRANS_SUBTYPE, -'leftToRight' : LEFTTORIGHT_TRANS_SUBTYPE, -'topToBottom' : TOPTOBOTTOM_TRANS_SUBTYPE, -'cornersIn' : CORNERSIN_TRANS_SUBTYPE, -'cornersOut': CORNERSOUT_TRANS_SUBTYPE, -'vertical' : VERTICAL_TRANS_SUBTYPE, -'centerTop' : CENTERTOP_TRANS_SUBTYPE, -'centerRight' : CENTERRIGHT_TRANS_SUBTYPE, -'top' : TOP_TRANS_SUBTYPE, -'right' : RIGHT_TRANS_SUBTYPE, -'bottom': BOTTOM_TRANS_SUBTYPE, -'left' : LEFT_TRANS_SUBTYPE, -'horizontal': HORIZONTAL_TRANS_SUBTYPE, -'down' : DOWN_TRANS_SUBTYPE, -'circle': CIRCLE_TRANS_SUBTYPE, -'clockwiseTwelve' : CLOCKWISETWELVE_TRANS_SUBTYPE, -'clockwiseThree': CLOCKWISETHREE_TRANS_SUBTYPE, -'clockwiseSix' : CLOCKWISESIX_TRANS_SUBTYPE, -'clockwiseNine' : CLOCKWISENINE_TRANS_SUBTYPE, -'clockwiseRight': CLOCKWISERIGHT_TRANS_SUBTYPE, -'clockwiseTop' : CLOCKWISETOP_TRANS_SUBTYPE, -'clockwiseBottom' : CLOCKWISEBOTTOM_TRANS_SUBTYPE, -'clockwiseLeft' : CLOCKWISELEFT_TRANS_SUBTYPE, -'clockwiseTopLeft' : CLOCKWISETOPLEFT_TRANS_SUBTYPE, -'counterClockwiseBottomLeft' : COUNTERCLOCKWISEBOTTOMLEFT_TRANS_SUBTYPE, -'clockwiseBottomRight' : CLOCKWISEBOTTOMRIGHT_TRANS_SUBTYPE, -'counterClockwiseTopRight' : COUNTERCLOCKWISETOPRIGHT_TRANS_SUBTYPE, -'twoBladeVertical' : TWOBLADEVERTICAL_TRANS_SUBTYPE, -'twoBladeHorizontal': TWOBLADEHORIZONTAL_TRANS_SUBTYPE, -'fourBlade' : FOURBLADE_TRANS_SUBTYPE, -'fromLeft' : FROMLEFT_TRANS_SUBTYPE, -'fromTop' : FROMTOP_TRANS_SUBTYPE, -'fromRight' : FROMRIGHT_TRANS_SUBTYPE, -'fromBottom': FROMBOTTOM_TRANS_SUBTYPE, -'crossfade' : CROSSFADE_TRANS_SUBTYPE, -'fadeToColor' : FADETOCOLOR_TRANS_SUBTYPE, -'fadeFromColor' : FADEFROMCOLOR_TRANS_SUBTYPE, -'fadeOverColor' : FADEOVERCOLOR_TRANS_SUBTYPE, -'threeBlade': THREEBLADE_TRANS_SUBTYPE, -'eightBlade': EIGHTBLADE_TRANS_SUBTYPE, -'oneBlade' : ONEBLADE_TRANS_SUBTYPE, -'across': ACROSS_TRANS_SUBTYPE, -'topLeftVertical' : TOPLEFTVERTICAL_TRANS_SUBTYPE, -'topLeftHorizontal' : TOPLEFTHORIZONTAL_TRANS_SUBTYPE, -'topLeftDiagonal' : TOPLEFTDIAGONAL_TRANS_SUBTYPE, -'topRightDiagonal' : TOPRIGHTDIAGONAL_TRANS_SUBTYPE, -'bottomRightDiagonal': BOTTOMRIGHTDIAGONAL_TRANS_SUBTYPE, -'bottomLeftDiagonal': BOTTOMLEFTDIAGONAL_TRANS_SUBTYPE, -'rectangle' : RECTANGLE_TRANS_SUBTYPE, -'diamond'
[Libreoffice-bugs] [Bug 107218] New: Notebookbar buttons dont function after exiting slide show
https://bugs.documentfoundation.org/show_bug.cgi?id=107218 Bug ID: 107218 Summary: Notebookbar buttons dont function after exiting slide show Product: LibreOffice Version: 5.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com Blocks: 102062, 103610 Steps: 1) Open Impress 2) Slide Show > Start from First Slide 3) Exit the slide show 4) Attempt to click any of the buttons on the Slide Show tab and none will work 5) Click on the slide canvas 6) Now the buttons work Version: 5.4.0.0.alpha0+ Build ID: 04edc5c796c1b96e5228d0c1fcf73bcf52465b66 CPU threads: 2; OS: Linux 3.19; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-04-15_03:25:45 Locale: en-US (en_US.UTF-8); Calc: group Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102062 [Bug 102062] [META] Notebookbar: bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=103610 [Bug 103610] [META] Slide show bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103610] [META] Slide show bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103610 Yousuf Philips (jay)changed: What|Removed |Added Depends on||107218 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107218 [Bug 107218] Notebookbar buttons dont function after exiting slide show -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102062] [META] Notebookbar: bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102062 Yousuf Philips (jay)changed: What|Removed |Added Depends on||107218 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107218 [Bug 107218] Notebookbar buttons dont function after exiting slide show -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107193] How to increase text size of local help files
https://bugs.documentfoundation.org/show_bug.cgi?id=107193 --- Comment #4 from Gérard Talbot--- > What if the user does not have, does not use a mouse with a rolling wheel? > Then how is such user supposed to increase font size, text size in > LibreOffice applications a) with the keyboard only or b) from within the > menu? I am aware of the zoom display bar on the righthand side of the status > bar of several LibreOffice applications. In the past, I have use a wireless mouse: you need batteries to operate a wireless mouse. Most computer mouses in sale in computer shops are now (unfortunately) wireless. But the thing is: batteries never last more than 6 months. So, let's say your batteries get weak and now your mouse no longer responds, no longer operates. Then what? This really and actually happened to me. I remember I was able to work with the keyboard only in a minority of situations on the web but not in a majority of situations on the web. This lead me to change my purchase habits: I now only and always buy a mouse with a wire so that I never depend on, rely on batteries for my mouse to work. Accessibility is just thinking about a wider range of possible situations and possible contexts from the user's point of view and still be able to perform tasks successfully. What if that LibreOffice user does not have a mouse with a wheel? What if that LibreOffice user has a mouse with a wheel but, on some important day for that user, his mouse batteries go too weak: will (s)he be still able to complete his tasks with only the keyboard? or with only the LO interface? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: configure.ac
configure.ac |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 8927eaf0571bc8a178c0e4d820160cb1dc7b40ab Author: Katarina BehrensDate: Thu Apr 13 22:39:37 2017 +0200 Strip trailing '/' from LO_PATH, if there's any symlink() with path/with/trailing/slash/ and thus creating chroot fails with ENOENT in totally opaque way Change-Id: I5cd5213d8b6bfc50ea11cf8586b2a7b7f334631d Reviewed-on: https://gerrit.libreoffice.org/36536 Reviewed-by: Thorsten Behrens Tested-by: Thorsten Behrens diff --git a/configure.ac b/configure.ac index 74d56bd9..1a9e16a8 100644 --- a/configure.ac +++ b/configure.ac @@ -172,7 +172,8 @@ SYSTEMPLATE_PATH=not-set have_lo_path=false AC_MSG_CHECKING([whether to run tests against a LibreOffice]) if test -n "$with_lo_path"; then - LO_PATH="$with_lo_path" + # strip trailing '/' from LO_PATH, 'ln -s' with such path will otherwise fail + LO_PATH="${with_lo_path%/}" version_file="$with_lo_path/program/versionrc" if test -f $version_file; then JAILS_PATH="\${abs_top_builddir}/jails" ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 94587] [META] ODF specification features missing or incorrectly imported
https://bugs.documentfoundation.org/show_bug.cgi?id=94587 Yousuf Philips (jay)changed: What|Removed |Added Depends on||107217 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107217 [Bug 107217] Line and area filling of media -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107217] New: Line and area filling of media
https://bugs.documentfoundation.org/show_bug.cgi?id=107217 Bug ID: 107217 Summary: Line and area filling of media Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com CC: momonas...@gmail.com, rb.hensc...@t-online.de, t...@libreoffice.org Blocks: 94587 In Writer, the Drawing Object Properties toolbar appears when selecting an embedded audio or video and allows you to modify the objects line and fill properties, though they do not show in the document and arent saved in ODF. In Impress, line and fill properties can be modified of media in Format > Line and Format > Area, but similar to Writer, they do not show in the presentation or are saved in ODF. So the question i'd like to ask is whether this is a bug that should be fixed, as these properties are possible to be set in ms office. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=94587 [Bug 94587] [META] ODF specification features missing or incorrectly imported -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103610] [META] Slide show bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103610 Yousuf Philips (jay)changed: What|Removed |Added Depends on||107216 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107216 [Bug 107216] Line border of animated image doesnt appear in slide show -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107216] New: Line border of animated image doesnt appear in slide show
https://bugs.documentfoundation.org/show_bug.cgi?id=107216 Bug ID: 107216 Summary: Line border of animated image doesnt appear in slide show Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com Blocks: 103610 Created attachment 132624 --> https://bugs.documentfoundation.org/attachment.cgi?id=132624=edit sample Steps: 1) Open attached doc 2) Notice that image has a green border around it 3) Start slide show and animated image doesnt have a border around it Version: 5.4.0.0.alpha0+ Build ID: 04edc5c796c1b96e5228d0c1fcf73bcf52465b66 CPU threads: 2; OS: Linux 3.19; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-04-15_03:25:45 Locale: en-US (en_US.UTF-8); Calc: group Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103610 [Bug 103610] [META] Slide show bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107192] How to print a few non-contiguous pages from a multi-pages document
https://bugs.documentfoundation.org/show_bug.cgi?id=107192 --- Comment #5 from Gérard Talbot--- > Range require an hyphen "-" (but the helpfile is actually using another > character, not an hyphen) Hyphen is U+002D () https://en.wikipedia.org/wiki/Hyphen-minus http://www.fileformat.info/info/unicode/char/002D/index.htm but the helpfile seems to be using a figure dash U+2012 () http://www.fileformat.info/info/unicode/char/2012/index.htm or even an em dash U+2014 () http://www.fileformat.info/info/unicode/char/2014/index.htm Sorry if I seem to be nitpicking here but this is exactly the kind of small (even imperceptible) detail (grain of sand) that create a failure and can actually make user experience bad. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/syswin.hxx |3 ++- vcl/source/window/syswin.cxx |3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit dd0824c92a349b720919857637258489e347a7a5 Author: James RaykowskiDate: Sun Apr 16 10:05:20 2017 -0800 tdf#89329 Use std::unique_ptr for ImplData in vcl/syswin Change-Id: I5cf16991bba0cec80c7fbaf32f4529e4f022201b Reviewed-on: https://gerrit.libreoffice.org/36590 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/include/vcl/syswin.hxx b/include/vcl/syswin.hxx index ac7a0d765c26..65e040172615 100644 --- a/include/vcl/syswin.hxx +++ b/include/vcl/syswin.hxx @@ -27,6 +27,7 @@ #include #include #include +#include class ModalDialog; class MenuBar; @@ -163,7 +164,7 @@ private: boolmbIsCalculatingInitialLayoutSize; MenuBarMode mnMenuBarMode; sal_uInt16 mnIcon; -ImplData* mpImplData; +std::unique_ptr mpImplData; IdlemaLayoutIdle; OUStringmaNotebookBarUIFile; protected: diff --git a/vcl/source/window/syswin.cxx b/vcl/source/window/syswin.cxx index 6656f122ecd3..8d7460c4f9cf 100644 --- a/vcl/source/window/syswin.cxx +++ b/vcl/source/window/syswin.cxx @@ -101,8 +101,7 @@ SystemWindow::~SystemWindow() void SystemWindow::dispose() { maLayoutIdle.Stop(); -delete mpImplData; -mpImplData = nullptr; +mpImplData.reset(); // Hack to make sure code called from base ~Window does not interpret this // as a SystemWindow (which it no longer is by then): ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 89329] convert pImpl pointers to use std::unique_ptr
https://bugs.documentfoundation.org/show_bug.cgi?id=89329 --- Comment #137 from Commit Notification--- James Raykowski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=dd0824c92a349b720919857637258489e347a7a5 tdf#89329 Use std::unique_ptr for ImplData in vcl/syswin It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107214] History Master: block recent files from appearing
https://bugs.documentfoundation.org/show_bug.cgi?id=107214 m.a.riosvchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |NOTOURBUG --- Comment #1 from m.a.riosv --- Sorry but that link is not a LibreOffice site, so It can't be our bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107192] How to print a few non-contiguous pages from a multi-pages document
https://bugs.documentfoundation.org/show_bug.cgi?id=107192 --- Comment #4 from Gérard Talbot--- Created attachment 132623 --> https://bugs.documentfoundation.org/attachment.cgi?id=132623=edit Small screenshot of 2-5,7,11 example > I would add a screen shot similar to 1370030148857273.png but > considerably smaller where we would see 2-5,7,11 in the input text control. 12.4 Kilo-bytes, 373px wide by 201px tall -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - hwpfilter/source
hwpfilter/source/hpara.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e66fbb58daa94fe1d2aa83f0be5fcdac3e21b259 Author: Caolán McNamaraDate: Sun Apr 16 14:25:25 2017 +0100 coverity#1405158 Wrong sizeof argument Change-Id: Ie6b7fc3d2b7d1ac709501698e55aabc72215b187 (cherry picked from commit b17177c63a4eac55dcdaa3006abec05ab71ca1b4) Reviewed-on: https://gerrit.libreoffice.org/36579 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/hwpfilter/source/hpara.cxx b/hwpfilter/source/hpara.cxx index 3149d65acf0a..cce909ead16e 100644 --- a/hwpfilter/source/hpara.cxx +++ b/hwpfilter/source/hpara.cxx @@ -78,7 +78,7 @@ HWPPara::HWPPara() , cshape(new CharShape) , linfo(nullptr) { -memset(cshape.get(), 0, sizeof(cshape)); +memset(cshape.get(), 0, sizeof(CharShape)); memset(, 0, sizeof(pshape)); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - hwpfilter/source
hwpfilter/source/hpara.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ee85316249902aa19f4426acae546ee79a083b07 Author: Caolán McNamaraDate: Sun Apr 16 14:25:25 2017 +0100 coverity#1405158 Wrong sizeof argument Change-Id: Ie6b7fc3d2b7d1ac709501698e55aabc72215b187 (cherry picked from commit b17177c63a4eac55dcdaa3006abec05ab71ca1b4) Reviewed-on: https://gerrit.libreoffice.org/36578 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/hwpfilter/source/hpara.cxx b/hwpfilter/source/hpara.cxx index 3149d65acf0a..cce909ead16e 100644 --- a/hwpfilter/source/hpara.cxx +++ b/hwpfilter/source/hpara.cxx @@ -78,7 +78,7 @@ HWPPara::HWPPara() , cshape(new CharShape) , linfo(nullptr) { -memset(cshape.get(), 0, sizeof(cshape)); +memset(cshape.get(), 0, sizeof(CharShape)); memset(, 0, sizeof(pshape)); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107126] Crash on changing page type in document (editing) with many footnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=107126 mattchanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #9 from matt --- I have supplied the document that consistently crashes it to Xisco Faulí privately. As I do not have the current debug version easily accessed now, I hope that you can generate your own using that document fairly easily. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107213] EDITING: On cell format box/ sidebar - Indent value not editable for right align.
https://bugs.documentfoundation.org/show_bug.cgi?id=107213 --- Comment #2 from m.a.riosv--- Sorry, but if you use the toolbar/sidebar button to indent after right aling it works and a value for indent is show. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107193] How to increase text size of local help files
https://bugs.documentfoundation.org/show_bug.cgi?id=107193 --- Comment #3 from Gérard Talbot--- Another thing. This is just a comment. The initial text size of the local help files was small, much too small for me. I would not have had this problem if the initial text size of the local help files had been initially bigger or just reasonable. This, I think, should be investigated; maybe I should file another bug report on this. There is nothing more frustrating about a software than to encounter a problem, and then when trying to find a solution with the local helpfiles, the user is just unable to *just read* the helpfiles because text is too small. - - - - - What if the user does not have, does not use a mouse with a rolling wheel? Then how is such user supposed to increase font size, text size in LibreOffice applications a) with the keyboard only or b) from within the menu? I am aware of the zoom display bar on the righthand side of the status bar of several LibreOffice applications. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107192] How to print a few non-contiguous pages from a multi-pages document
https://bugs.documentfoundation.org/show_bug.cgi?id=107192 --- Comment #3 from Gérard Talbot--- I went to https://www.libreoffice.org/get-help/documentation/ and then downloaded the document GS52-GettingStartedLO.odt (21 Mega-Bytes) and this is what they say (in chapter 10, section Controlling printing, page 293, subsection Selecting pages/sheets/slides to print in Writer) " Printing a range of pages: 1) Choose File > Print from the Menu bar, or press Ctrl+P. 2) On the Print dialog, select the range of pages to print. a) In the Range and copies section of the General page, select the Pages option. b) Enter the sequence numbers of the pages to print (for example, 1–4 or 1,3,7,11). " I think that quoted text could be a bit improved. Range require an hyphen "-" (but the helpfile is actually using another character, not an hyphen) and non-contiguous pages require a comma (or semicolon?). And pages to print can define both a range and a list of contiguous pages. " Printing a range of pages: 1) Choose File > Print from the Menu bar, or press Ctrl+P. 2) On the Print dialog, select the range of pages to print. a) In the Range and copies section of the General page, select the Pages option. b) If you want to print a range of pages, then use a hyphen ("-") between the first and last. For example, 2-5 will print only pages 2, 3, 4 and 5 only. If you want to print a list of non-contiguous pages, then use a comma (",") to separate each pages. For example, 7,11 will print only pages 7 and 11. If you want to print a range a pages and a list of non-contiguous pages, then combine both. For example, 2-5,7,11 will print only pages 2, 3, 4, 5, 7 and 11. " and I would add a screen shot similar to 1370030148857273.png but considerably smaller where we would see 2-5,7,11 in the input text control. Also, I think the helpfiles everywhere should mention that both comma and semicolon can be used to separate sub-sequence of pages. Otherwise, one of the 2 should be dropped. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Localization issues related to telling users to update after submitting a crash report
Hey, so I have been looking into the crashreporter and we are still seeing a lot of crash reports for old versions. As we need to be able to deprecate the support for older builds at some point we need a way to notify users that reports for these versions are ignored and that they should use a newer version. An example for this would be reports for all 5.2.x with x < 6 that are still responsible for a huge part of the reports with 5.2.4 still around 50% of the reports. Doing this is theoretical trivial and I already have some patches that support this feature in future versions (sadly the 5.2.x versions have no way to show the string from the server). My problem is now whether we need to provide a localized version of this string. The string would come from the server which currently has no translation support. In theory we know the localization of the soffice instance that has submitted the crash report but I'd like avoid adding many localized strings to the crash reporter. Are there any objections against showing the generic update request instead of a localized one when someone uses an old version? If there are no objections I would implement this and try to get the necessary changes in 5.4 and 5.3.3. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 107070] Writer misses spelling errors when text is selected from " bottom up."
https://bugs.documentfoundation.org/show_bug.cgi?id=107070 --- Comment #1 from Sebastien edouard--- I did get the same mistake. Spellcheck does not find az as mispelled word. Version 5.3.2 windows 10 64bit -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107011] Flow of text in a cell behave strangely in print/PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=107011 --- Comment #2 from Sebastien edouard--- could not reproduce bug. No text overlay Version 5.3.2 Windows 10 64bit -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107215] REPORTBUILDER: Page headers & footers are not visible in report documents
https://bugs.documentfoundation.org/show_bug.cgi?id=107215 branestawmchanged: What|Removed |Added CC||jr87...@gmx.com --- Comment #1 from branestawm --- Created attachment 132622 --> https://bugs.documentfoundation.org/attachment.cgi?id=132622=edit Base database which demonstrates invisible page header & footer in text reports -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107215] New: REPORTBUILDER: Page headers & footers are not visible in report documents
https://bugs.documentfoundation.org/show_bug.cgi?id=107215 Bug ID: 107215 Summary: REPORTBUILDER: Page headers & footers are not visible in report documents Product: LibreOffice Version: 5.2.6.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jr87...@gmx.com Description: After upgrade from LO v5.1.3 to v5.2.6.2 Build 20m0(Build:2) on OpenSuse 13.2, release supplied by SUSE, page headers & footers are not visible in report documents. Page headers & footers are created but they are not visible in the report document. You need to edit each report document, to set Format -> Page -> Header/Footer -> Autofit height, whereupon the headers & footers appear. Steps to Reproduce: 1.Create text report for Writer in Report Builder, from simple query on built-in or other database. Put some text in report page header and/or footer. 2.Execute report. Actual Results: 1.No page header/footer shown in report document 2.Edit report document, to set Format -> Page -> Header/Footer -> Autofit height, to make page header & footer visible. Expected Results: 1.Page header/footer shown in report document without editing. Reproducible: Always User Profile Reset: No Additional Info: headertest.odb attached which demonstrates this issue. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107127] Notebookbar: Make it easy to create toggle buttons to unhide hidden tabs and groups
https://bugs.documentfoundation.org/show_bug.cgi?id=107127 --- Comment #6 from andreas_k--- > What makes more sense and what i'd support is to have devs create an easy > means for glade designers to create toggle buttons (GtkToggleButton) that > could reference a hidden tab or group and the button would unhide it when > clicked. @Maxim, @Szymon: Would this be something simple to create? way better. That's exactly what desingers need when they have available less space. That's exact what I need jay. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107127] Notebookbar: Make it easy to create toggle buttons to unhide hidden tabs and groups
https://bugs.documentfoundation.org/show_bug.cgi?id=107127 Yousuf Philips (jay)changed: What|Removed |Added Status|NEEDINFO|NEW CC||momonas...@gmail.com, ||szymon.k...@collabora.com Summary|insert draw context- for|Notebookbar: Make it easy |notebookbar instead of open |to create toggle buttons to |the toolbar |unhide hidden tabs and ||groups --- Comment #5 from Yousuf Philips (jay) --- context-Draw is shown while inserting a shape or when selecting a shape, so having it appear when clicking .uno:insertDraw doesnt make sense. Changing .uno:insertDraw to show a hidden Draw group filled with buttons to insert shapes rather than showing the Drawing toolbar makes some sense, but i would be against this change. What makes more sense and what i'd support is to have devs create an easy means for glade designers to create toggle buttons (GtkToggleButton) that could reference a hidden tab or group and the button would unhide it when clicked. @Maxim, @Szymon: Would this be something simple to create? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107201] EDITING: Selecting few table rows and the the paragraph below it at once isn' t possible
https://bugs.documentfoundation.org/show_bug.cgi?id=107201 Sebastien edouardchanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Sebastien edouard --- Tried it and text can not be selected. Normally we should be able to copy table along with text. This is possible in other program. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107214] New: History Master: block recent files from appearing
https://bugs.documentfoundation.org/show_bug.cgi?id=107214 Bug ID: 107214 Summary: History Master: block recent files from appearing Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: moebiu...@yahoo.com Description: History Master is no longer available on this link: http://extensions.openoffice.org/en/download/4963 Actual Results: N/A Expected Results: N/A Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107213] EDITING: On cell format box/ sidebar - Indent value not editable for right align.
https://bugs.documentfoundation.org/show_bug.cgi?id=107213 Sebastien edouardchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Sebastien edouard --- It is simply because changing the indent value will move it to the right by the distance you set. Center will put the element in the center and right will simply indent it to the right corner and you cant indent the text because there is no more space. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107192] How to print a few non-contiguous pages from a multi-pages document
https://bugs.documentfoundation.org/show_bug.cgi?id=107192 --- Comment #2 from Gérard Talbot--- > If you select the option "pages", set the cursor into the field and press > Ctrl+F1, you get the extended tip: > > To print a range of pages, use a format like 3-6. To print single pages, use > a format like 7;9;11. You can print a combination of page ranges and single > pages, by using a format like 3-6;8;10;12. Regina, If you select the option "pages", set the cursor into the field and press Ctrl+F1, you will *not* get the extended tip if info-balloon (Tools/Options.../LibreOffice/General/Help/Info-balloon) is unchecked. Additionally, if info-balloon is unchecked, then hovering the mouse over the info-balloon label (and its checkbox) will not reveal, will not disclose the contextual help text about how useful/helpful this info-balloon can be (maybe this should be a bug by itself). I do get the extended help, contextual help if/when I have info-balloon checked and when my mouse cursor hovers over the pages input text box (without Ctrl+F1). Regarding info-balloon, the local help files state: "Pour afficher un infoballon, appuyez sur Maj+F1 et pointez vers un bouton ou une commande." which I can translate to: "To display an info-balloon, press Shift+F1 and point to a button or command." No mention of Ctrl+F1. I just tried Shift+F1 and it works: the cursor changes from a white arrow into a white arrow with a question mark ("?") on its righthand side and a contextual, extended help text is displayed when hovering text labels and/or form controls. Please note that ";" (semicolon) is used in the extended tip while I successfully use "," (comma). > That is HID: hid/.HelpID:vcl:PrintDialog:PageRange:Edit > > Cursor in field and Ctrl+F1 is the usual way to get the extended tip of a > field. I did not know of Ctrl+F1. I never thought of using Ctrl+F1. - - - - - - - Regina, Just to be clear... my bug report is not formally looking for answers or assistance,... although I appreciate your Ctrl+F1 feedback. I am for tuning, updating or adding current local help files (via F1) if some useful explanation is missing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/ucalc_sort.cxx |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) New commits: commit 0497facb723d90fae6cade86d9075ddfc18f83b9 Author: keremDate: Thu Apr 13 00:36:23 2017 +0300 tdf#90290 use custom asserter in ucalc_sort.cxx Change-Id: I61e1d5c75f5ec13291633368859441bb85732317 Reviewed-on: https://gerrit.libreoffice.org/36494 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/sc/qa/unit/ucalc_sort.cxx b/sc/qa/unit/ucalc_sort.cxx index 719ea1ab6a52..b057f64f2b0d 100644 --- a/sc/qa/unit/ucalc_sort.cxx +++ b/sc/qa/unit/ucalc_sort.cxx @@ -1141,8 +1141,7 @@ void Test::testSortRefUpdate4_Impl() { for (SCCOL nCol=0; nCol < 4; ++nCol) { -if (!checkFormula(*m_pDoc, ScAddress(nCol,nRow+1,0), aCheck[nRow][nCol])) -CPPUNIT_FAIL(OString("Wrong formula in " + OString('A'+nCol) + OString::number(nRow+2) + ".").getStr()); +ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(nCol,nRow+1,0), aCheck[nRow][nCol], OString("Wrong formula in " + OString('A'+nCol) + OString::number(nRow+2) + ".").getStr()); } } @@ -1213,8 +1212,7 @@ void Test::testSortRefUpdate4_Impl() { for (SCCOL nCol=0; nCol < 4; ++nCol) { -if (!checkFormula(*m_pDoc, ScAddress(nCol,nRow+1,0), aCheck[nRow][nCol])) -CPPUNIT_FAIL(OString("Wrong formula in " + OString('A'+nCol) + OString::number(nRow+2) + ".").getStr()); +ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(nCol,nRow+1,0), aCheck[nRow][nCol], OString("Wrong formula in " + OString('A'+nCol) + OString::number(nRow+2) + ".").getStr()); } } } @@ -1307,8 +1305,7 @@ void Test::testSortRefUpdate5() }; for (SCROW nRow=0; nRow < static_cast(SAL_N_ELEMENTS(aFormulaCheck)); ++nRow) { -if (!checkFormula(*m_pDoc, ScAddress(1,nRow+1,0), aFormulaCheck[nRow])) -CPPUNIT_FAIL(OString("Wrong formula in B" + OString::number(nRow+2) + ".").getStr()); +ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(1,nRow+1,0), aFormulaCheck[nRow], OString("Wrong formula in B" + OString::number(nRow+2) + ".").getStr()); } // Undo and check the result. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107210] problematic pdf export of calc documents on Windows 7
https://bugs.documentfoundation.org/show_bug.cgi?id=107210 m.a.riosvchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #2 from m.a.riosv --- I can't reproduce on Version: 5.3.2.2 (x64) Build ID: 6cd4f1ef626f15116896b1d8e1398b56da0d0ee1 CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine: new; Locale: es-ES (es_ES); Calc: group Please try resetting the user profile, sometimes solves strange issues. https://wiki.documentfoundation.org/UserProfile Usually it's enough renaming/deleting the file "user/registrymodifications.xcu", it affects all the options in Menu/Tools/Options, and the files "user/basic/dialog.xlc" and "scrip.xlc" are overwritten, additionally custom colors in "user/config/standard.soc" are lost. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
James Raykowski license statement
All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 107213] EDITING: On cell format box/ sidebar - Indent value not editable for right align.
https://bugs.documentfoundation.org/show_bug.cgi?id=107213 m.a.riosvchanged: What|Removed |Added OS|All |Windows (All) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107213] EDITING: On cell format box/ sidebar - Indent value not editable for right align.
https://bugs.documentfoundation.org/show_bug.cgi?id=107213 m.a.riosvchanged: What|Removed |Added Summary|EDITING: On cell format box |EDITING: On cell format |- Align tab - Indent value |box/sidebar - Indent value |not editable for right |not editable for right |align. |align. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107213] New: EDITING: On cell format box - Align tab - Indent value not editable for right align.
https://bugs.documentfoundation.org/show_bug.cgi?id=107213 Bug ID: 107213 Summary: EDITING: On cell format box - Align tab - Indent value not editable for right align. Product: LibreOffice Version: 5.3.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: miguelange...@libreoffice.org Description: On cell format box [Ctrl+1]- Align tab - Indent value not editable for right align, but it is for left align. Steps to Reproduce: 1.Open a new spreadsheet. 2.Ctrl+1 3.Choose align tab. 4.Select left align for Horizontal, indent value is editable. 5.Select right align for Horizontal, indent value is not editable. 6.It works with the toolbar. 7.On side bar buttons work but the some issue for edit the value, available for left but not for right align. Actual Results: . Expected Results: Value for right indent editable like it is for left align. Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107212] New: Drawing Object Properties toolbar shouldnt be enabled when drawing a textbox
https://bugs.documentfoundation.org/show_bug.cgi?id=107212 Bug ID: 107212 Summary: Drawing Object Properties toolbar shouldnt be enabled when drawing a textbox Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com Blocks: 81475, 102062 Steps: 1) Open Writer 2) Insert > Textbox or click the insert textbox button in the Standard or Drawing toolbar 3) Notice that the Formatting toolbar has changed to the Drawing Object Properties toolbar, though nothing changed in the toolbar will change the appearance of the drawn textbox 4) Once the textbox is drawn, the toolbar is switched for the Text Object toolbar Version: 5.4.0.0.alpha0+ Build ID: 04edc5c796c1b96e5228d0c1fcf73bcf52465b66 CPU threads: 2; OS: Linux 3.19; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-04-15_03:25:45 Locale: en-US (en_US.UTF-8); Calc: group Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=81475 [Bug 81475] [META] Enhancing Writer's standard and formatting toolbars https://bugs.documentfoundation.org/show_bug.cgi?id=102062 [Bug 102062] [META] Notebookbar: bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81475] [META] Enhancing Writer's standard and formatting toolbars
https://bugs.documentfoundation.org/show_bug.cgi?id=81475 Yousuf Philips (jay)changed: What|Removed |Added Depends on||107212 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107212 [Bug 107212] Drawing Object Properties toolbar shouldnt be enabled when drawing a textbox -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102062] [META] Notebookbar: bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102062 Yousuf Philips (jay)changed: What|Removed |Added Depends on||107212 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107212 [Bug 107212] Drawing Object Properties toolbar shouldnt be enabled when drawing a textbox -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107211] Index underlines lines
https://bugs.documentfoundation.org/show_bug.cgi?id=107211 Marco A.G.Pintochanged: What|Removed |Added CC||marcoagpinto@mail.telepac.p ||t --- Comment #1 from Marco A.G.Pinto --- Created attachment 132621 --> https://bugs.documentfoundation.org/attachment.cgi?id=132621=edit the index page -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107211] New: Index underlines lines
https://bugs.documentfoundation.org/show_bug.cgi?id=107211 Bug ID: 107211 Summary: Index underlines lines Product: LibreOffice Version: 5.3.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: marcoagpi...@mail.telepac.pt I printed part of a document to PDF (both LO pdf and CutePDFWriter) and noticed that the index gets the lines underlined which looks very ugly. I have included the index page. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1ad1a536345ed2fa2fc6dd97ea6986d313e1a0d6 Author: Caolán McNamaraDate: Sun Apr 16 21:49:57 2017 +0100 Cppunit->cppunit change accidentially I presume by e81a35e1a86b6492a68f52ae53c41ee624981ee8 Change-Id: I5a52d6e33708b03fcbcd74b0134710ab32a9618d diff --git a/configure.ac b/configure.ac index 1e52d32e7029..f1ff14131c0e 100644 --- a/configure.ac +++ b/configure.ac @@ -7945,7 +7945,7 @@ dnl === dnl Check for system cppunit dnl === if test "$cross_compiling" != "yes"; then -libo_CHECK_SYSTEM_MODULE([Cppunit],[CPPUNIT],[cppunit >= 1.14.0]) +libo_CHECK_SYSTEM_MODULE([cppunit],[CPPUNIT],[cppunit >= 1.14.0]) fi dnl === ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/uitest/uiobject.cxx | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) New commits: commit 2951fea8236f7455e5dde36b5e799c1e1448cf40 Author: Markus MohrhardDate: Tue Mar 7 11:49:39 2017 +0100 uitest: escape the " for the json string conversion Change-Id: I989b8add4bba0b10dedb126e5014be59879ed898 Reviewed-on: https://gerrit.libreoffice.org/36585 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/vcl/source/uitest/uiobject.cxx b/vcl/source/uitest/uiobject.cxx index 24fac7a4dd31..74d75b7a2fad 100644 --- a/vcl/source/uitest/uiobject.cxx +++ b/vcl/source/uitest/uiobject.cxx @@ -442,6 +442,15 @@ OUString WindowUIObject::get_name() const return OUString("WindowUIObject"); } +namespace { + +OUString escape(const OUString& rStr) +{ +return rStr.replaceAll("\"", "\\\""); +} + +} + OUString WindowUIObject::dumpState() const { OUStringBuffer aStateString = "{\"name\":\"" + mxWindow->get_id() + "\""; @@ -449,7 +458,7 @@ OUString WindowUIObject::dumpState() const StringMap aState = const_cast (this)->get_state(); for (auto itr = aState.begin(), itrEnd = aState.end(); itr != itrEnd; ++itr) { -OUString property = ",\"" + itr->first + "\":\"" + itr->second + "\""; +OUString property = ",\"" + itr->first + "\":\"" + escape(itr->second) + "\""; aStateString.append(property); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107127] insert draw context- for notebookbar instead of open the toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=107127 --- Comment #4 from andreas_k--- you are right Jay, the context-drawgraphic setting is already there so I don't need a context-drawgraphic setting. What I need is to show the context-draw menu when click on .uno:insertDraw because I can't switch to the draw tab at contextual toolbars (without tabs) So I need an button that I can switch to context-draw layout not only switch to it when select a drawing also for the first time I'd like to start drawing I have to come somehow to the context- menu. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107210] problematic pdf export of calc documents on Windows 7
https://bugs.documentfoundation.org/show_bug.cgi?id=107210 --- Comment #1 from Roeland--- Created attachment 132620 --> https://bugs.documentfoundation.org/attachment.cgi?id=132620=edit the outcome I get when exporting to pdf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107206] form control List Box drop down does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=107206 Xisco Faulíchanged: What|Removed |Added Keywords||bibisected, bisected Status|UNCONFIRMED |NEW CC||mrcek...@gmail.com, ||xiscofa...@libreoffice.org Hardware|x86 (IA32) |All Ever confirmed|0 |1 OS|Windows (All) |All --- Comment #1 from Xisco Faulí --- Regression introduced by: author Marco Cecchetti 2014-11-05 19:15:32 (GMT) committer Marco Cecchetti 2014-11-05 19:21:43 (GMT) commit 967a386bccb15b99915a1e878e42450fbe9a2d0e (patch) tree7ed8cae5a3a1967b0661a0bec579d79bc5035d14 parent a9a9718bb1f64318429562ecdaa3d3763d9e2f4a (diff) Fix for SUSE L3 bug 624546 (freedesktop 83733) Adding Cc: to Marco Cecchetti -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107210] New: problematic pdf export of calc documents on Windows 7
https://bugs.documentfoundation.org/show_bug.cgi?id=107210 Bug ID: 107210 Summary: problematic pdf export of calc documents on Windows 7 Product: LibreOffice Version: 5.3.0.3 release Hardware: All OS: other Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: roelandb...@hotmail.com Created attachment 132619 --> https://bugs.documentfoundation.org/attachment.cgi?id=132619=edit test file Since installing 5.3 I experience problems when exporting an ods file to pdf on my Windows 7 machine. The text disappears an I get no readable results. I tested some files om my windows 10 machine, and I can't reproduce the problem over there. I asked a question about this on ask (https://ask.libreoffice.org/en/question/92804/pdf-export-problem/) as well. I attached a test file and the result I get on my Win 7 machine. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107209] Text layout error; text lines overlap randomly in long " complicated" documents
https://bugs.documentfoundation.org/show_bug.cgi?id=107209 --- Comment #2 from y3kcjd5--- Created attachment 132618 --> https://bugs.documentfoundation.org/attachment.cgi?id=132618=edit PDF of example document as rendered by version 5.3.2.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107209] Text layout error; text lines overlap randomly in long " complicated" documents
https://bugs.documentfoundation.org/show_bug.cgi?id=107209 --- Comment #1 from y3kcjd5--- Created attachment 132617 --> https://bugs.documentfoundation.org/attachment.cgi?id=132617=edit Example document with broken text layout -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107209] New: Text layout error; text lines overlap randomly in long " complicated" documents
https://bugs.documentfoundation.org/show_bug.cgi?id=107209 Bug ID: 107209 Summary: Text layout error; text lines overlap randomly in long "complicated" documents Product: LibreOffice Version: 5.3.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hastra...@gmail.com Description: I'm not sure what the exact conditions for this are, but some combination of resized images, vertical text, page dividers, and possibly furigana (i.e. stuff which requires lots of precise width tracking) results in some lines of text being displayed in incorrect locations (see attachment documents). It's possible to poke at the problem areas by editing in the vicinity (e.g. deleting and re-entering paragraph breaks) but it's like trying to smooth out bedsheets; straighten out wrinkles in one spot and they probably pop up elsewhere nearby. Also, even if you manage to get rid of the display error, if you haven't actually changed the text contents (e.g. re-entering paragraph breaks), the problem will return on a save/reload. The attachment's I'm adding now are accurate for version 5.3.2, but I saw the location of the 'wrinkles' change in updating from 5.1.2 so if your view of the .odt doesn't match the .pdf, just scan through the whole document; they're probably in there somewhere. Steps to Reproduce: 1. Enter lots of different content with weird zoom values or widths 2. Add lots of text 3. Scan through the document Actual Results: See pdf (page 22, center division, left-ish side). Expected Results: Text should align nicely. Reproducible: Sometimes User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107127] insert draw context- for notebookbar instead of open the toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=107127 Yousuf Philips (jay)changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107127] insert draw context- for notebookbar instead of open the toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=107127 Yousuf Philips (jay)changed: What|Removed |Added CC||tietze.he...@gmail.com --- Comment #3 from Yousuf Philips (jay) --- I'm confused andreas, as we have context-Draw for dealing with draw shape properties, or are you referring to something else. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78326] Can't delete a table in Impress/Draw if cells are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=78326 Aron Budeachanged: What|Removed |Added OS|Linux (All) |All --- Comment #9 from Aron Budea --- Affects Windows builds as well, setting OS to All. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107188] Pivot Table menus Translations in french
https://bugs.documentfoundation.org/show_bug.cgi?id=107188 Jean-Baptiste Faurechanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Jean-Baptiste Faure --- Fixed in LO 5.3 and master: "Pivot Table" translated in "Table dynamique" in the Insert menu. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107208] New: Blue warning dialog 'document is in read-only mode ' stays behind after clicking Edit Document with a DOC file
https://bugs.documentfoundation.org/show_bug.cgi?id=107208 Bug ID: 107208 Summary: Blue warning dialog 'document is in read-only mode 'stays behind after clicking Edit Document with a DOC file Product: LibreOffice Version: 5.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: trivial Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Blue warning dialog 'document is in read-only mode' stays behind after clicking Edit Document with a DOC file. The file can be edited. No issue with odt and docx Steps to Reproduce: 1. Open attached file. 2. Click Edit Document Actual Results: Blue warning dialog 'document is in read-only mode' stay's behind after clicking Edit Document Expected Results: The dialog should disappear Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 5.4.0.0.alpha0+ CPU threads: 4; OS: Windows 6.19; UI render: GL; TinderBox: Win-x86@42, Branch:master, Time: 2017-04-05_23:32:27 Locale: nl-NL (nl_NL); Calc: CL but not in Versie: 5.3.0.3 Build ID: 7074905676c47b82bbcfbea1aeefc84afe1c50e1 CPU Threads: 4; Versie besturingssysteem:Windows 6.2; UI Render: standaard; Layout-Engine: nieuw; Locale: nl-NL (nl_NL); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107208] Blue warning dialog 'document is in read-only mode ' stays behind after clicking Edit Document with a DOC file
https://bugs.documentfoundation.org/show_bug.cgi?id=107208 --- Comment #1 from Telesto--- Created attachment 132616 --> https://bugs.documentfoundation.org/attachment.cgi?id=132616=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sal/inc
sal/inc/pch/precompiled_sal.hxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 31abe9e44df092a557a34537f6b4ffa48d12edc4 Author: Markus MohrhardDate: Sun Apr 16 19:39:37 2017 +0200 try to fix werror + pch build on linux This should fix RandomConfig tb run #396 Change-Id: Idd7984e3c4225b08db50b2451112135aaf2e1890 Reviewed-on: https://gerrit.libreoffice.org/36584 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/sal/inc/pch/precompiled_sal.hxx b/sal/inc/pch/precompiled_sal.hxx index 8699e20ce1e1..06a35d546a4b 100644 --- a/sal/inc/pch/precompiled_sal.hxx +++ b/sal/inc/pch/precompiled_sal.hxx @@ -20,9 +20,11 @@ ./bin/update_pch_bisect ./sal/inc/pch/precompiled_sal.hxx "make sal.build" --find-conflicts */ +#if defined(_WIN32) #if !defined _CRT_RAND_S #define _CRT_RAND_S #endif +#endif #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107189] Notebookbar: CPU core hits 100% when in print preview mode
https://bugs.documentfoundation.org/show_bug.cgi?id=107189 Yousuf Philips (jay)changed: What|Removed |Added CC||eszka...@gmail.com --- Comment #4 from Yousuf Philips (jay) --- @Buovjaga: Thanks for the callgrind. @Syzmon: Any time to fix this performance issue? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107165] OOO_EXIT_POST_STARTUP=1 crashes or hangs
https://bugs.documentfoundation.org/show_bug.cgi?id=107165 --- Comment #6 from Terrence Enger--- No, this has never worked for me. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107072] PIVOT CHARTS: Crash when there are no column fields in source table
https://bugs.documentfoundation.org/show_bug.cgi?id=107072 Julien Nabetchanged: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #5 from Julien Nabet --- Created attachment 132615 --> https://bugs.documentfoundation.org/attachment.cgi?id=132615=edit bt with debug symbols On pc Debian x86-64 with master sources updated today, I could reproduce this. I attached bt + debug symbols and other traces before the crash. I noticed that m_aLabels is filled only in case sheet::DataPilotFieldOrientation_COLUMN case -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Telestochanged: What|Removed |Added Depends on||106929 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106929 [Bug 106929] Can not edit interior table border style more than once (without un/re-selecting) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106929] Can not edit interior table border style more than once ( without un/re-selecting)
https://bugs.documentfoundation.org/show_bug.cgi?id=106929 Telestochanged: What|Removed |Added Keywords||bibisectRequest, regression Status|UNCONFIRMED |NEW CC||tele...@surfxs.nl Version|5.2.2.2 release |4.2.0.4 release Blocks||103100 Ever confirmed|0 |1 --- Comment #4 from Telesto --- Confirming with: Version: 5.4.0.0.alpha0+ CPU threads: 4; OS: Windows 6.19; UI render: GL; TinderBox: Win-x86@42, Branch:master, Time: 2017-04-05_23:32:27 Locale: nl-NL (nl_NL); Calc: CL and with Versie: 4.4.6.3 Build ID: e8938fd3328e95dcf59dd64e7facd2c7d67c704d Locale: nl_NL and with Versie: 4.2.0.4 Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71 but not with: Versie: 4.1.0.4 Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106482] DISPLAY: MEMO field not showing all the content
https://bugs.documentfoundation.org/show_bug.cgi?id=106482 Terrence Engerchanged: What|Removed |Added Status|NEEDINFO|NEW CC||lo_b...@iseries-guru.com Version|5.2.5.1 release |4.2 all versions See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=79 ||026 Summary|Text field not saving all |DISPLAY: MEMO field not |the content |showing all the content --- Comment #4 from Terrence Enger --- I see the problem as far back as Version: 4.2.0.0.alpha1+ Build ID: fc8f44e... . I am setting version to "4.2 all versions". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79026] Content of memo fields in MS Access tables get truncated in LibreOffice Base
https://bugs.documentfoundation.org/show_bug.cgi?id=79026 Terrence Engerchanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||6482 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106482] Text field not saving all the content
https://bugs.documentfoundation.org/show_bug.cgi?id=106482 --- Comment #3 from Terrence Enger--- Created attachment 132614 --> https://bugs.documentfoundation.org/attachment.cgi?id=132614=edit smaller example .odb Short version: I think that the problem is just the display of MEMO fields. In the attached embedded_HSQLDB.odb, Table1 includes fields f1 : MEMO f2 : VARCHAR f3 : CHARACTER (fixed) As the column widths in data view are adjusted to be narrower than the stored data, the program always truncates f1 at a space or hyphen. The result looks neat, hiding the fact of the truncated display. Fields f2 and f3 are less neat, even truncating the display in the middle of a letter. The truncation is obvious to the viewer. I am setting status NEW and adjusting the summary according to what I have observed. I am setting see-also bug 79026. It differs from the present bug in ... (*) different backend (*) update, not just display (*) form rather than data view -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100366] [META] Improve table handling in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=100366 Aron Budeachanged: What|Removed |Added Depends on||78326 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=78326 [Bug 78326] Can't delete a table in Impress/Draw if cells are selected -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78326] Can't delete a table in Impress/Draw if cells are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=78326 Aron Budeachanged: What|Removed |Added Keywords|bibisectRequest, regression | CC||ba...@caesar.elte.hu Version|4.2.3.3 release |Inherited From OOo Blocks||100366 Summary|Sometimes can't delete a|Can't delete a table in |table in Impress/Draw |Impress/Draw if cells are ||selected --- Comment #8 from Aron Budea --- The underlying issue is that the table can't be deleted if the table cells are selected. This bug is already there in v3.3.0 / Ubuntu 16.04. What changed between 4.0.0.3 and 4.1.0.4 is that table cells are selected after the table is inserted. I'm not sure that change is intended or if that should be treated as a regression as well, I'm adding the details as information below (if it's a bug, open a new bug report on it): 02bb77b2f877fc23b622a3d1c239d697512fb811 is the first bad commit commit 02bb77b2f877fc23b622a3d1c239d697512fb811 Author: Matthew Francis Date: Fri Sep 18 10:29:02 2015 +0800 source-hash-a00b62422e5499e842d0b3b6302ba79f3d808c27 commit a00b62422e5499e842d0b3b6302ba79f3d808c27 Author: Gokul AuthorDate: Sat Feb 2 15:29:56 2013 +0300 Commit: Ahmad Harthi CommitDate: Sat Feb 9 11:28:05 2013 + Fixes fdo#46186, The Table Remains in the defined writing mode. The table in impress is drawn under the rectangular are, on Selecting the table it was only selecting the rectangular area and not the cells inside, Making the layout to be as RTL which was mirroring the table. But, We need the table to be in RTL Writing mode and not mirroring the table. Now on applying my patch, If table is selected, it will select the entire cells inside which is the actual table and the functionality works fine. Change-Id: I9d6bdde5019322488be66fa89a6488d348b2cf44 Reviewed-on: https://gerrit.libreoffice.org/1964 Reviewed-by: Ahmad Harthi Tested-by: Ahmad Harthi Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Improve table handling in Draw -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs