date:20170419

[Libreoffice-commits] core.git: sal/osl

2017-04-19 Thread Stephan Bergmann

 sal/osl/unx/system.hxx |2 +-
 sal/osl/unx/thread.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 5733eeb43dc34b1bffc9eb14af3de976a4202bd0
Author: Stephan Bergmann 
Date:   Thu Apr 20 07:58:10 2017 +0200

Avoid loplugin:redundantcast on macOS

Change-Id: I5e9f2552f83e72d1f6eb1a12df19c0fdfa012e31

diff --git a/sal/osl/unx/system.hxx b/sal/osl/unx/system.hxx
index 9fd4a640f830..78d49c403ddf 100644
--- a/sal/osl/unx/system.hxx
+++ b/sal/osl/unx/system.hxx
@@ -274,7 +274,7 @@ int macxp_resolveAlias(char *path, int buflen);
 #if defined MACOSX
 #define PTHREAD_VALUE(t) reinterpret_cast(t)
 #else
-#define PTHREAD_VALUE(t) (t)
+#define PTHREAD_VALUE(t) ((unsigned long) (t))
 #endif
 
 #ifndef PTHREAD_NONE
diff --git a/sal/osl/unx/thread.cxx b/sal/osl/unx/thread.cxx
index 80d8cbb51b45..34bf38cde607 100644
--- a/sal/osl/unx/thread.cxx
+++ b/sal/osl/unx/thread.cxx
@@ -552,7 +552,7 @@ void SAL_CALL osl_setThreadName(char const * name) {
 /* osl_getThreadIdentifier @@@ see TODO @@@ */
 /*/
 
-#define HASHID(x) ((unsigned long)PTHREAD_VALUE(x) % HashSize)
+#define HASHID(x) (PTHREAD_VALUE(x) % HashSize)
 
 struct HashEntry
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107283] No shortcut icon in toolbar for Selection of just table boxes to move or resize.

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107283

--- Comment #2 from er.lovenishg...@gmail.com  ---
got it, have to press Alt + Shift to move with precision.

Now, only needed keyboard shortcut is for resizing the table and box and image.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102019] [META] Dialog bugs and enhancements

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102019

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||106323


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106323
[Bug 106323] tab layout in dialogues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106323] tab layout in dialogues

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106323

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||102019


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102019
[Bug 102019] [META] Dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103184] [META] UI theming bugs and enhancements

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103184

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||106323


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106323
[Bug 106323] tab layout in dialogues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106323] tab layout in dialogues

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106323

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl,
   ||philip...@hotmail.com,
   ||tietze.he...@gmail.com,
   ||vstuart.fo...@utsa.edu
 Blocks||103184

--- Comment #5 from Yousuf Philips (jay)  ---
As the look of dialog tabs are defined by a users OS theme, nothing can be done
here other than telling a user to change their theme.

So from my point of view this is WONTFIX.

@Stuart, @Cor, @Heiko: whats your take?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103184
[Bug 103184] [META] UI theming bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 106781] Addition of a style-focused formatting toolbar

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106781

--- Comment #19 from Yousuf Philips (jay)  ---
I've submitted a patch, so it can get into a daily build and people can really
test it out and give feedback. https://gerrit.libreoffice.org/36717

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 106781] Addition of a style-focused formatting toolbar

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106781

--- Comment #19 from Yousuf Philips (jay)  ---
I've submitted a patch, so it can get into a daily build and people can really
test it out and give feedback. https://gerrit.libreoffice.org/36717

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svx/source

2017-04-19 Thread Johnny_M

 svx/source/form/formcontroller.cxx |4 ++--
 svx/source/inc/clonelist.hxx   |2 +-
 svx/source/inc/fmprop.hrc  |4 ++--
 svx/source/inc/fmshimp.hxx |4 ++--
 4 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 091a92cedd02dd486076a76f1cddde026f359d0c
Author: Johnny_M 
Date:   Tue Apr 18 21:15:21 2017 +0200

Translate German comments (leftovers in svx/source/inc/, etc.)

Translated leftovers in:
- svx/source/inc/ which slipped through on the commit
324adfcc2c3aa5d3590a38fadca2af7cd9125b47 (and a correction of "ist" to 
"list"
in an unrelated comment)

- svx/source/form/formcontroller.cxx which slipped through on the commit
ea8f69e4a8ca8c3912aacb9838d7c5bb20b47f46

Change-Id: Ida5b3d0e685558bc2d8facba02fa80ae9e92eab3
Reviewed-on: https://gerrit.libreoffice.org/36648
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/svx/source/form/formcontroller.cxx 
b/svx/source/form/formcontroller.cxx
index 294556981ef8..c4fe9e40a723 100644
--- a/svx/source/form/formcontroller.cxx
+++ b/svx/source/form/formcontroller.cxx
@@ -1456,7 +1456,7 @@ void SAL_CALL FormController::textChanged(const 
TextEvent& e)
 if ( m_aFilterRows.empty() )
 appendEmptyDisjunctiveTerm();
 
-// Suchen der aktuellen Row
+// find the current row
 if ( ( (size_t)m_nCurrentFilterPosition >= m_aFilterRows.size() ) || ( 
m_nCurrentFilterPosition < 0 ) )
 {
 OSL_ENSURE( false, "FormController::textChanged: 
m_nCurrentFilterPosition is wrong!" );
@@ -2872,7 +2872,7 @@ void SAL_CALL FormController::elementRemoved(const 
ContainerEvent& evt)
 if (xModel.is() && m_xModelAsIndex == xModel->getParent())
 {
 removeControl(xControl);
-// TabOrder nicht neu berechnen, da das intern schon funktionieren 
muss!
+// Do not recalculate TabOrder, because it must already work 
internally!
 }
 // are we in filtermode and a XModeSelector has inserted an element
 else if (m_bFiltering && Reference< XModeSelector > (evt.Source, 
UNO_QUERY).is())
diff --git a/svx/source/inc/clonelist.hxx b/svx/source/inc/clonelist.hxx
index 5d2efc9023dc..18e9bb54c801 100644
--- a/svx/source/inc/clonelist.hxx
+++ b/svx/source/inc/clonelist.hxx
@@ -26,7 +26,7 @@
 class SdrObject;
 
 // #i13033#
-// New mechanism to hold a ist of all original and cloned objects for later
+// New mechanism to hold a list of all original and cloned objects for later
 // re-creating the connections for contained connectors
 class CloneList
 {
diff --git a/svx/source/inc/fmprop.hrc b/svx/source/inc/fmprop.hrc
index 42b6e0aa0b64..2c5733cbab92 100644
--- a/svx/source/inc/fmprop.hrc
+++ b/svx/source/inc/fmprop.hrc
@@ -19,8 +19,8 @@
 #ifndef INCLUDED_SVX_SOURCE_INC_FMPROP_HRC
 #define INCLUDED_SVX_SOURCE_INC_FMPROP_HRC
 
-// PropertyId's, welche eine Zuordnung zu einen PropertyName haben, das 
koennten
-// auch in Zukunft WhichIds sein -> Itemset
+// PropertyIds, which have an assignment to a PropertyName, could continue
+// to be WhichIds in the future -> Itemset
 #define FM_ATTR_START   0
 
 #define FM_ATTR_FILTER  ( FM_ATTR_START + 1 )
diff --git a/svx/source/inc/fmshimp.hxx b/svx/source/inc/fmshimp.hxx
index da68ae054257..f548561badcd 100644
--- a/svx/source/inc/fmshimp.hxx
+++ b/svx/source/inc/fmshimp.hxx
@@ -182,7 +182,7 @@ class SVX_DLLPUBLIC FmXFormShell   : public 
FmXFormShell_BASE
 ::osl::Mutexm_aInvalidationSafety;
 // secure the access to all our slot invalidation related members
 
-css::form::NavigationBarMode   m_eNavigate;// Art der 
Navigation
+css::form::NavigationBarMode   m_eNavigate;// kind of 
navigation
 
 // since I want to mark an SdrObject when searching for the treatment 
of the "found",
 // I get all relevant objects before yanking up of the search dialog
@@ -348,7 +348,7 @@ protected:
 SAL_DLLPRIVATE boolimpl_checkDisposed() const;
 
 public:
-// methode fuer nicht designmode (alive mode)
+// method for non design mode (alive mode)
 SAL_DLLPRIVATE void setActiveController( const css::uno::Reference< 
css::form::runtime::XFormController>& _xController, bool _bNoSaveOldContent = 
false );
 SAL_DLLPRIVATE const css::uno::Reference< 
css::form::runtime::XFormController>& getActiveController() const {return 
m_xActiveController;}
 SAL_DLLPRIVATE const css::uno::Reference< 
css::form::runtime::XFormController>& getActiveInternalController() const { 
return m_xActiveController == m_xExternalViewController ? 
m_xExtViewTriggerController : m_xActiveController; }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107283] No shortcut icon in toolbar for Selection of just table boxes to move or resize.

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107283

er.lovenishg...@gmail.com  changed:

   What|Removed |Added

Summary|No shortcut or mouse|No shortcut icon in toolbar
   |pointer or icon in toolbar  |for Selection of just table
   |for Selection of just table |boxes to move or resize.
   |boxes to move or resize |
   |instead of text also.   |

--- Comment #1 from er.lovenishg...@gmail.com  ---
I got it, have to press Alt button while clicking on table border.

Now just want to know keyboard shortcut to resize to table and move the table,
because mouse does not give accuracy in small changes and have to zoom for
accuracy.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107283] New: No shortcut or mouse pointer or icon in toolbar for Selection of just table boxes to move or resize instead of text also.

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107283

Bug ID: 107283
   Summary: No shortcut or mouse pointer or icon in toolbar for
Selection of just table boxes to move or resize
instead of text also.
   Product: LibreOffice
   Version: 5.3.2.2 release
  Hardware: x86 (IA32)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: er.lovenishg...@gmail.com

Created attachment 132705
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132705=edit
wanted to select just table border for moving.

In LIbreOffice Draw.

I created table with multiple columns.
Now when, i want click on the border of table, then not only the border but the
whole table with text got selected. 

Have to click outside table box and click on table border again to hope that
this time only table border will be selected.

Until now, cant find out exactly where should i have to click on table to
select just the border not the whole table with texts.

could not find any shortcut key or toolbar button or mouse specific changed
icon on specific location on table, where i could easily select just the table
borders to move resize.

LibreOffice Draw must be capable to work with tables. Please don't suggest to
create table in Spreadsheet and copy paste in Draw or writer. Because when the
spreadsheet is zoomed then the whole table and text also zoomed in unwanted way
like an image file, so the original fonts setting of spreadsheet table gets
lost.

Also, when in LibreOffice Draw, i copy paste any image inside table box, and
image as send to background, then there is NO WAY I COULD FOUND TO AGAIN SELECT
THAT IMAGE. I have to move the whole table to side and then the image is could
be selected again.

Also, I Could not find, shortcut keys to resize the selected image or table
instead of manually dragging using mouse.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107166] Text is invisible, both in UI and in editor

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107166

V Stuart Foote  changed:

   What|Removed |Added

   Priority|medium  |high
 Status|UNCONFIRMED |NEW
  Component|UI  |graphics stack
 Ever confirmed|0   |1

--- Comment #7 from V Stuart Foote  ---
I can not reporduce on Windows 8.1 or Windows 10, but NEW given dupe bug 107271

This seems to only affect Windows 7 sp1 (7601) builds with 5.3.2.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107166] Text is invisible, both in UI and in editor

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107166

V Stuart Foote  changed:

   What|Removed |Added

 CC||j...@cspv.hu

--- Comment #6 from V Stuart Foote  ---
*** Bug 107271 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107271] after install fonts disappear ( text is rendered as blank spaces)

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107271

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---
please post a screen clip to duplicate bug 107166

*** This bug has been marked as a duplicate of bug 107166 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: helpcontent2

2017-04-19 Thread Adolfo Jayme Barrientos

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 100e00fd3273536ebff130cfddc5da2b1fe609b1
Author: Adolfo Jayme Barrientos 
Date:   Thu Apr 20 00:14:21 2017 -0500

Updated core
Project: help  9ed1958ba7f75bb4184f09d79814849d06313d72

I donât think Macs have Control keysâ¦

Change-Id: I808fd2b09a4b61b726f090d2f0c214d3ee842d04

diff --git a/helpcontent2 b/helpcontent2
index 97354651b002..9ed1958ba7f7 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 97354651b0025098b2a5da10cfdff3171f4af531
+Subproject commit 9ed1958ba7f75bb4184f09d79814849d06313d72
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

2017-04-19 Thread Adolfo Jayme Barrientos

 source/text/shared/04/0101.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9ed1958ba7f75bb4184f09d79814849d06313d72
Author: Adolfo Jayme Barrientos 
Date:   Thu Apr 20 00:14:21 2017 -0500

I donât think Macs have Control keysâ¦

Change-Id: I808fd2b09a4b61b726f090d2f0c214d3ee842d04

diff --git a/source/text/shared/04/0101.xhp 
b/source/text/shared/04/0101.xhp
index 12e379b22..e21c42acf 100644
--- a/source/text/shared/04/0101.xhp
+++ b/source/text/shared/04/0101.xhp
@@ -488,7 +488,7 @@
  
  
 
-   ControlCtrl+M
+   CommandCtrl+M
 
 
Removes direct formatting from selected text or 
objects (as in Format - Clear Direct Formatting)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 82248] Other: Changing or resetting shortcuts doesn't work

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=82248

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||103238


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103238
[Bug 103238] [META] Customize dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103238

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||82248


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=82248
[Bug 82248] Other: Changing or resetting shortcuts doesn't work
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: 2 commits - test/httpwstest.cpp wsd/DocumentBroker.cpp

2017-04-19 Thread Ashod Nakashian

 test/httpwstest.cpp|   70 +
 wsd/DocumentBroker.cpp |   19 ++---
 2 files changed, 79 insertions(+), 10 deletions(-)

New commits:
commit 876e4098357df8319bf6c721aca359cb94be9fb7
Author: Ashod Nakashian 
Date:   Thu Apr 20 00:13:32 2017 -0400

wsd: unittest for correctly saving in presence of passive clients

Passive clients that don't load the document can
be disruptive as they are not useful for saving
the document, so we need to ignore them and
use reliable sessions.

Change-Id: I162ec00823ba5af776fcb55f6d58149f2a56d7bb
Reviewed-on: https://gerrit.libreoffice.org/36712
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 78d717fb..917a41dd 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -70,6 +70,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testReload);
 CPPUNIT_TEST(testGetTextSelection);
 CPPUNIT_TEST(testSaveOnDisconnect);
+CPPUNIT_TEST(testSavePassiveOnDisconnect);
 CPPUNIT_TEST(testReloadWhileDisconnecting);
 CPPUNIT_TEST(testExcelLoad);
 CPPUNIT_TEST(testPaste);
@@ -123,6 +124,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 void testReload();
 void testGetTextSelection();
 void testSaveOnDisconnect();
+void testSavePassiveOnDisconnect();
 void testReloadWhileDisconnecting();
 void testExcelLoad();
 void testPaste();
@@ -711,6 +713,74 @@ void HTTPWSTest::testSaveOnDisconnect()
 }
 }
 
+void HTTPWSTest::testSavePassiveOnDisconnect()
+{
+const auto testname = "saveOnPassiveDisconnect ";
+
+const auto text = helpers::genRandomString(40);
+std::cerr << "Test string: [" << text << "]." << std::endl;
+
+std::string documentPath, documentURL;
+getDocumentPathAndURL("hello.odt", documentPath, documentURL, testname);
+
+int kitcount = -1;
+try
+{
+auto socket = loadDocAndGetSocket(_uri, documentURL, testname);
+
+Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
+auto socket2 = connectLOKit(_uri, request, _response);
+
+sendTextFrame(socket, "uno .uno:SelectAll", testname);
+sendTextFrame(socket, "uno .uno:Delete", testname);
+sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\n" + 
text, testname);
+
+// Check if the document contains the pasted text.
+sendTextFrame(socket, "uno .uno:SelectAll", testname);
+sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8", testname);
+const auto selection = assertResponseString(socket, 
"textselectioncontent:", testname);
+CPPUNIT_ASSERT_EQUAL("textselectioncontent: " + text, selection);
+
+// Closing connection too fast might not flush buffers.
+// Often nothing more than the SelectAll reaches the server before
+// the socket is closed, when the doc is not even modified yet.
+getResponseMessage(socket, "statechanged", testname);
+
+kitcount = getLoolKitProcessCount();
+
+// Shutdown abruptly.
+std::cerr << "Closing connection after pasting." << std::endl;
+socket->shutdown(); // Should trigger saving.
+socket2->shutdown();
+}
+catch (const Poco::Exception& exc)
+{
+CPPUNIT_FAIL(exc.displayText());
+}
+
+// Allow time to save and destroy before we connect again.
+testNoExtraLoolKitsLeft();
+std::cerr << "Loading again." << std::endl;
+try
+{
+// Load the same document and check that the last changes (pasted 
text) is saved.
+auto socket = loadDocAndGetSocket(_uri, documentURL, testname);
+
+// Should have no new instances.
+CPPUNIT_ASSERT_EQUAL(kitcount, countLoolKitProcesses(kitcount));
+
+// Check if the document contains the pasted text.
+sendTextFrame(socket, "uno .uno:SelectAll", testname);
+sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8", testname);
+const auto selection = assertResponseString(socket, 
"textselectioncontent:", testname);
+CPPUNIT_ASSERT_EQUAL("textselectioncontent: " + text, selection);
+}
+catch (const Poco::Exception& exc)
+{
+CPPUNIT_FAIL(exc.displayText());
+}
+}
+
 void HTTPWSTest::testReloadWhileDisconnecting()
 {
 const auto testname = "reloadWhileDisconnecting ";
commit 2a0253b76be3e329af55d0ab80157544eea2253e
Author: Ashod Nakashian 
Date:   Thu Apr 20 00:10:30 2017 -0400

wsd: stop the DocBroker when saving session is last

When a session is disconnecting and we use it to save
(because the other sessions are not viable for saving),
then we need to correctly detect if by the time
saving is done there are no other

[Libreoffice-commits] online.git: wsd/ClientSession.cpp wsd/ClientSession.hpp wsd/DocumentBroker.cpp

2017-04-19 Thread Ashod Nakashian

 wsd/ClientSession.cpp  |4 +++-
 wsd/ClientSession.hpp  |   10 +-
 wsd/DocumentBroker.cpp |1 +
 3 files changed, 13 insertions(+), 2 deletions(-)

New commits:
commit f326a058d41f6a0cc334f8458d98ca68cc40f189
Author: Ashod Nakashian 
Date:   Thu Apr 20 00:08:13 2017 -0400

wsd: rely only on loaded sessions for saving

If a session is not loaded, it might never
do so. We should skip them when deciding
whether to save using a disconnecting
session or rely on another.

This is to avoid failing to save when
the remaining sessions never really load
the document at all, and are therefore useless.

Change-Id: I4e7127e12960a31e9f66e835bb63fb2347390711
Reviewed-on: https://gerrit.libreoffice.org/36710
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 414f8b94..8be60603 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -37,7 +37,8 @@ ClientSession::ClientSession(const std::string& id,
 _docBroker(docBroker),
 _uriPublic(uriPublic),
 _isDocumentOwner(false),
-_isAttached(false)
+_isAttached(false),
+_isLoaded(false)
 {
 const size_t curConnections = ++LOOLWSD::NumConnections;
 LOG_INF("ClientSession ctor [" << getName() << "], current number of 
connections: " << curConnections);
@@ -631,6 +632,7 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 }
 else if (tokens[0] == "status:")
 {
+setLoaded();
 docBroker->setLoaded();
 
 // Forward the status response to the client.
diff --git a/wsd/ClientSession.hpp b/wsd/ClientSession.hpp
index 396f45c9..81c55c70 100644
--- a/wsd/ClientSession.hpp
+++ b/wsd/ClientSession.hpp
@@ -34,10 +34,14 @@ public:
 
 void setReadOnly() override;
 
-/// Returns true if a document is loaded (i.e. we got status message).
+/// Returns true if this session is added to a DocBroker.
 bool isAttached() const { return _isAttached; }
 void setAttached() { _isAttached = true; }
 
+/// Returns true if this session has loaded a view (i.e. we got status 
message).
+bool isLoaded() const { return _isLoaded; }
+void setLoaded() { _isLoaded = true; }
+
 const std::string getUserId() const { return _userId; }
 const std::string getUserName() const {return _userName; }
 void setUserId(const std::string& userId) { _userId = userId; }
@@ -140,8 +144,12 @@ private:
 /// The socket to which the converted (saveas) doc is sent.
 std::shared_ptr _saveAsSocket;
 
+/// If we are added to a DocBroker.
 bool _isAttached;
 
+/// If we have loaded a view.
+bool _isLoaded;
+
 /// Wopi FileInfo object
 std::unique_ptr _wopiFileInfo;
 
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 31ab6598..bb76ea33 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -1218,6 +1218,7 @@ void DocumentBroker::destroyIfLastEditor(const 
std::string& id)
 for (const auto& it : _sessions)
 {
 if (it.second->getId() != id &&
+it.second->isLoaded() &&
 !it.second->isReadOnly())
 {
 // Found another editable.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107238] VBA macro recorded in Excel behaves differently in Calc

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107238

Markus Mohrhard  changed:

   What|Removed |Added

  Component|BASIC   |Calc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107238] VBA macro recorded in Excel behaves differently in Calc

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107238

Markus Mohrhard  changed:

   What|Removed |Added

   Keywords||difficultyInteresting,
   ||easyHack, skillCpp,
   ||skillDebug
 CC||markus.mohrhard@googlemail.
   ||com

--- Comment #2 from Markus Mohrhard  ---
Let's make this an easy hack.

The issue is in the criteria detection in ScVbaRange which does not handle
string arrays and as a result tries to filter for "".

The code for this is in sc/source/ui/vba/vbarange.cxx:4508 and following which
currently only handles numeric and string values but would need to be extended
to handle css::uno::Sequence as well.

This task is to add the support and check how to transport the information
through the UNO API to the internal data structures.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: test/test.cpp

2017-04-19 Thread Ashod Nakashian

 test/test.cpp |   28 +---
 1 file changed, 17 insertions(+), 11 deletions(-)

New commits:
commit bc0323731674d84aeea7b8487b4333e43a7a21e6
Author: Ashod Nakashian 
Date:   Thu Apr 20 00:06:28 2017 -0400

wsd: fix verbose test output

Change-Id: I089c31555a90c99c89745529c6df6552fd0bd7f9
Reviewed-on: https://gerrit.libreoffice.org/36709
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/test.cpp b/test/test.cpp
index fc0a6dfb..4d6fc505 100644
--- a/test/test.cpp
+++ b/test/test.cpp
@@ -58,9 +58,8 @@ bool filterTests(CPPUNIT_NS::TestRunner& runner, 
CPPUNIT_NS::Test* testRegistry,
 
 int main(int argc, char** argv)
 {
-const char* loglevel = "error";
-if (argc > 0 && std::string("--verbose") == argv[0])
-loglevel = "trace";
+const bool verbose = (argc > 1 && std::string("--verbose") == argv[1]);
+const char* loglevel = verbose ? "trace" : "error";
 
 Log::initialize("tst", loglevel, true, false, {});
 
@@ -96,17 +95,24 @@ int main(int argc, char** argv)
 }
 }
 
-// redirect std::cerr temporarily
-std::stringstream errorBuffer;
-std::streambuf* oldCerr = std::cerr.rdbuf(errorBuffer.rdbuf());
+if (!verbose)
+{
+// redirect std::cerr temporarily
+std::stringstream errorBuffer;
+std::streambuf* oldCerr = std::cerr.rdbuf(errorBuffer.rdbuf());
 
-runner.run(controller);
+runner.run(controller);
 
-std::cerr.rdbuf(oldCerr);
+std::cerr.rdbuf(oldCerr);
 
-// output the errors we got during the testing
-if (!result.wasSuccessful())
-std::cerr << errorBuffer.str() << std::endl;
+// output the errors we got during the testing
+if (!result.wasSuccessful())
+std::cerr << errorBuffer.str() << std::endl;
+}
+else
+{
+runner.run(controller);
+}
 
 CPPUNIT_NS::CompilerOutputter outputter(, std::cerr);
 outputter.setNoWrap();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sc/source sc/uiconfig

2017-04-19 Thread Caolán McNamara

 sc/source/ui/condformat/condformatdlgentry.cxx |   22 +++---
 sc/source/ui/inc/condformatdlgentry.hxx|2 ++
 sc/uiconfig/scalc/ui/conditionalentry.ui   |   14 ++
 3 files changed, 27 insertions(+), 11 deletions(-)

New commits:
commit 4e40cf62a142813a2ffa0a64148c84c1b4e60be9
Author: CaolÃ¡n McNamara 
Date:   Thu Mar 30 10:16:41 2017 +0100

Resolves: tdf#106838 icon set not visible in conditional formatting

Change-Id: Ibafaa487d39a69bc7c5c150361368614c0d9e004
(cherry picked from commit 1c2dd8dc14effe739bd826cf4fe77145d5b751bc)
Reviewed-on: https://gerrit.libreoffice.org/35899
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/ui/condformat/condformatdlgentry.cxx 
b/sc/source/ui/condformat/condformatdlgentry.cxx
index f4273992e9f4..6ecfeb7a71df 100644
--- a/sc/source/ui/condformat/condformatdlgentry.cxx
+++ b/sc/source/ui/condformat/condformatdlgentry.cxx
@@ -1399,11 +1399,15 @@ 
ScIconSetFrmtDataEntry::ScIconSetFrmtDataEntry(vcl::Window* pParent, ScIconSetTy
 
 Size ScIconSetFrmtDataEntry::calculateRequisition() const
 {
+if (!maGrid) //during dispose
+return Size();
 return getLayoutRequisition(*maGrid);
 }
 
 void ScIconSetFrmtDataEntry::setAllocation(const Size )
 {
+if (!maGrid) //during dispose
+return;
 setLayoutPosSize(*maGrid, Point(0, 0), rAllocation);
 }
 
@@ -1471,6 +1475,7 @@ ScIconSetFrmtEntry::ScIconSetFrmtEntry(vcl::Window* 
pParent, ScDocument* pDoc, c
 {
 get(maLbColorFormat, "colorformat");
 get(maLbIconSetType, "iconsettype");
+get(maIconParent, "iconparent");
 
 Init();
 maLbColorFormat->SetSelectHdl( LINK( pParent, ScCondFormatList, 
ColFormatTypeHdl ) );
@@ -1485,12 +1490,9 @@ ScIconSetFrmtEntry::ScIconSetFrmtEntry(vcl::Window* 
pParent, ScDocument* pDoc, c
 for (size_t i = 0, n = pIconSetFormatData->m_Entries.size();
 i < n; ++i)
 {
-maEntries.push_back( VclPtr::Create(
-this, eType, pDoc, i, pIconSetFormatData->m_Entries[i].get()));
-Size aSize(maEntries[0]->get_preferred_size());
-Point aPos(0, LogicToPixel(Size(0, 35), 
MapMode(MapUnit::MapAppFont)).getHeight());
-aPos.Y() += aSize.Height() * i * 1.2;
-maEntries[i]->SetPosSizePixel(aPos, aSize);
+maEntries.push_back(VclPtr::Create(
+maIconParent, eType, pDoc, i, 
pIconSetFormatData->m_Entries[i].get()));
+maEntries[i]->set_grid_top_attach(i);
 }
 maEntries[0]->SetFirstEntry();
 }
@@ -1508,6 +1510,7 @@ void ScIconSetFrmtEntry::dispose()
 for (auto it = maEntries.begin(); it != maEntries.end(); ++it)
 it->disposeAndClear();
 maEntries.clear();
+maIconParent.clear();
 maLbColorFormat.clear();
 maLbIconSetType.clear();
 ScCondFrmtEntry::dispose();
@@ -1535,11 +1538,8 @@ IMPL_LINK_NOARG( ScIconSetFrmtEntry, IconSetTypeHdl, 
ListBox&, void )
 
 for(size_t i = 0; i < nElements; ++i)
 {
-maEntries.push_back( VclPtr::Create( this, 
static_cast(nPos), mpDoc, i ) );
-Size aSize(maEntries[0]->get_preferred_size());
-Point aPos(0, LogicToPixel(Size(0, 35), 
MapMode(MapUnit::MapAppFont)).getHeight());
-aPos.Y() += aSize.Height() * i * 1.2;
-maEntries[i]->SetPosSizePixel(aPos, aSize);
+
maEntries.push_back(VclPtr::Create(maIconParent, 
static_cast(nPos), mpDoc, i));
+maEntries[i]->set_grid_top_attach(i);
 maEntries[i]->Show();
 }
 maEntries[0]->SetFirstEntry();
diff --git a/sc/source/ui/inc/condformatdlgentry.hxx 
b/sc/source/ui/inc/condformatdlgentry.hxx
index f7d446ff474b..642e6ceae019 100644
--- a/sc/source/ui/inc/condformatdlgentry.hxx
+++ b/sc/source/ui/inc/condformatdlgentry.hxx
@@ -297,6 +297,8 @@ class ScIconSetFrmtEntry : public ScCondFrmtEntry
 // icon set ui elements
 VclPtr maLbIconSetType;
 
+VclPtr maIconParent;
+
 typedef std::vector 
ScIconSetFrmtDataEntriesType;
 ScIconSetFrmtDataEntriesType maEntries;
 
diff --git a/sc/uiconfig/scalc/ui/conditionalentry.ui 
b/sc/uiconfig/scalc/ui/conditionalentry.ui
index c5803074e635..88ec9b39069a 100644
--- a/sc/uiconfig/scalc/ui/conditionalentry.ui
+++ b/sc/uiconfig/scalc/ui/conditionalentry.ui
@@ -410,6 +410,20 @@
   
 
 
+  
+True
+False
+
+  
+
+  
+  
+0
+7
+3
+  
+
+
   
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/source

2017-04-19 Thread Michael Meeks

 vcl/source/window/window.cxx |   10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

New commits:
commit 92edd724dd7f1ca85787480f046d48f9f27c51b8
Author: Michael Meeks 
Date:   Wed Apr 19 01:19:59 2017 +0100

vcl: protect Window from exceptions during construction.

Probable fix for:

http://crashreport.libreoffice.org/stats/crash_details/f69188bd-0fdd-4b74-9ec6-35b544cba0c9

Change-Id: I6442451785867f0fc2daf84776118b092d4d6a18
Reviewed-on: https://gerrit.libreoffice.org/36653
Tested-by: Jenkins 
Reviewed-by: Michael Meeks 
(cherry picked from commit 6827da5052bfe975a3b34af8dfa8af75d41e904c)
Reviewed-on: https://gerrit.libreoffice.org/36674
Reviewed-by: Markus Mohrhard 

diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 50e7435eeb53..72c2a5d832e5 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -526,6 +526,7 @@ void Window::dispose()
 }
 
 delete mpWindowImpl->mpWinData;
+mpWindowImpl->mpWinData = nullptr;
 
 // remove BorderWindow or Frame window data
 mpWindowImpl->mpBorderWindow.disposeAndClear();
@@ -552,11 +553,16 @@ void Window::dispose()
 SAL_WARN("vcl", "Window " << this << " marked as frame window, 
"
  "is missing from list of " << nWindows << " frames");
 }
-mpWindowImpl->mpFrame->SetCallback( nullptr, nullptr );
-pSVData->mpDefInst->DestroyFrame( mpWindowImpl->mpFrame );
+if (mpWindowImpl->mpFrame) // otherwise exception during init
+{
+mpWindowImpl->mpFrame->SetCallback( nullptr, nullptr );
+pSVData->mpDefInst->DestroyFrame( mpWindowImpl->mpFrame );
+}
 assert (mpWindowImpl->mpFrameData->mnFocusId == nullptr);
 assert (mpWindowImpl->mpFrameData->mnMouseMoveId == nullptr);
+
 delete mpWindowImpl->mpFrameData;
+mpWindowImpl->mpFrameData = nullptr;
 }
 
 // should be the last statements
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - vcl/source

2017-04-19 Thread Michael Meeks

 vcl/source/window/window.cxx |   10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

New commits:
commit 3430b5610b9740a592d9c2ca0634ddd04e1e3ca1
Author: Michael Meeks 
Date:   Wed Apr 19 01:19:59 2017 +0100

vcl: protect Window from exceptions during construction.

Probable fix for:

http://crashreport.libreoffice.org/stats/crash_details/f69188bd-0fdd-4b74-9ec6-35b544cba0c9

Change-Id: I6442451785867f0fc2daf84776118b092d4d6a18
Reviewed-on: https://gerrit.libreoffice.org/36653
Tested-by: Jenkins 
Reviewed-by: Michael Meeks 
(cherry picked from commit 6827da5052bfe975a3b34af8dfa8af75d41e904c)
Reviewed-on: https://gerrit.libreoffice.org/36675
Reviewed-by: Markus Mohrhard 

diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 722486cc490f..2cd6307b2829 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -530,6 +530,7 @@ void Window::dispose()
 }
 
 delete mpWindowImpl->mpWinData;
+mpWindowImpl->mpWinData = nullptr;
 
 // remove BorderWindow or Frame window data
 mpWindowImpl->mpBorderWindow.disposeAndClear();
@@ -556,11 +557,16 @@ void Window::dispose()
 SAL_WARN("vcl", "Window " << this << " marked as frame window, 
"
  "is missing from list of " << nWindows << " frames");
 }
-mpWindowImpl->mpFrame->SetCallback( nullptr, nullptr );
-pSVData->mpDefInst->DestroyFrame( mpWindowImpl->mpFrame );
+if (mpWindowImpl->mpFrame) // otherwise exception during init
+{
+mpWindowImpl->mpFrame->SetCallback( nullptr, nullptr );
+pSVData->mpDefInst->DestroyFrame( mpWindowImpl->mpFrame );
+}
 assert (mpWindowImpl->mpFrameData->mnFocusId == nullptr);
 assert (mpWindowImpl->mpFrameData->mnMouseMoveId == nullptr);
+
 delete mpWindowImpl->mpFrameData;
+mpWindowImpl->mpFrameData = nullptr;
 }
 
 // should be the last statements
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107236] Crash in: com::sun::star::uno::Reference::iquery(com::sun::star::uno::XInterface *)

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107236

harry.br...@hwbrucepe.com changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #4 from harry.br...@hwbrucepe.com ---
Correct.  Writer now opens the document with no problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107280] [META] Issues related to the shared code between Impress and Draw

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107280

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||107282


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107282
[Bug 107282] Deleted customized shortcuts still working
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98259

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||107282


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107282
[Bug 107282] Deleted customized shortcuts still working
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103238

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||107282


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107282
[Bug 107282] Deleted customized shortcuts still working
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107282] New: Deleted customized shortcuts still working

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107282

Bug ID: 107282
   Summary: Deleted customized shortcuts still working
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Blocks: 98259, 103238, 107280

Steps:
1) Open Impress
2) Tools > Customize > Keyboard
3) Set Ctrl + A for Insert > Insert Slide Directly
4) Test that shortcut works in Impress
5) Reopen Tools > Customize > Keyboard and clear shortcut with the Delete
button
6) Notice that shortcut still works

Version: 5.4.0.0.alpha0+
Build ID: 04edc5c796c1b96e5228d0c1fcf73bcf52465b66
CPU threads: 2; OS: Linux 3.19; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2017-04-15_03:25:45
Locale: en-US (en_US.UTF-8); Calc: group


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103238
[Bug 103238] [META] Customize dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107280
[Bug 107280] [META] Issues related to the shared code between Impress and Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107280] [META] Issues related to the shared code between Impress and Draw

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107280

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl,
   ||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98259

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||107281


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107281
[Bug 107281] Customized shortcuts set in Impress are working in Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107281] New: Customized shortcuts set in Impress are working in Draw

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107281

Bug ID: 107281
   Summary: Customized shortcuts set in Impress are working in
Draw
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Blocks: 98259, 103238, 107280

Steps:
1) Open Impress
2) Tools > Customize > Keyboard
3) Set Ctrl + A for Insert > Insert Slide Directly
4) Test that shortcut works in Impress
5) Open Draw
6) Notice that shortcut works here as well
7) Tools > Customize > Keyboard
8) Notice that Ctrl + A isnt set in Draw

Version: 5.4.0.0.alpha0+
Build ID: 04edc5c796c1b96e5228d0c1fcf73bcf52465b66
CPU threads: 2; OS: Linux 3.19; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2017-04-15_03:25:45
Locale: en-US (en_US.UTF-8); Calc: group


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103238
[Bug 103238] [META] Customize dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107280
[Bug 107280] [META] Issues related to the shared code between Impress and Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103238

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||107281


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107281
[Bug 107281] Customized shortcuts set in Impress are working in Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107280] [META] Issues related to the shared code between Impress and Draw

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107280

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||107281


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107281
[Bug 107281] Customized shortcuts set in Impress are working in Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84258] Impress and Draw sharing code causing problems with icons and menus

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=84258

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||107280


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107280
[Bug 107280] [META] Issues related to the shared code between Impress and Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84257] Menus, dialogs and sidebar having the word 'page' rather than 'slide'

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=84257

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||107280


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107280
[Bug 107280] [META] Issues related to the shared code between Impress and Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107279] Alias UNO commands not appearing in functions list

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107279

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||107280


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107280
[Bug 107280] [META] Issues related to the shared code between Impress and Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84208] Menus having the word 'slide' rather than 'page'

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=84208

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||107280


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107280
[Bug 107280] [META] Issues related to the shared code between Impress and Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107280] New: [META] Issues related to the shared code between Impress and Draw

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107280

Bug ID: 107280
   Summary: [META] Issues related to the shared code between
Impress and Draw
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Depends on: 84257, 107279, 84208, 84258


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=84208
[Bug 84208] Menus having the word 'slide' rather than 'page'
https://bugs.documentfoundation.org/show_bug.cgi?id=84257
[Bug 84257] Menus, dialogs and sidebar having the word 'page' rather than
'slide'
https://bugs.documentfoundation.org/show_bug.cgi?id=84258
[Bug 84258] Impress and Draw sharing code causing problems with icons and menus
https://bugs.documentfoundation.org/show_bug.cgi?id=107279
[Bug 107279] Alias UNO commands not appearing in functions list
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98259

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||82248, 35030


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=35030
[Bug 35030] Customize Keyboard Reset button doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=82248
[Bug 82248] Other: Changing or resetting shortcuts doesn't work
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82248] Other: Changing or resetting shortcuts doesn't work

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=82248

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||98259


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35030] Customize Keyboard Reset button doesn't work

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=35030

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||98259


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107279] Alias UNO commands not appearing in functions list

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107279

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||103238


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103238
[Bug 103238] [META] Customize dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103238

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||107279


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107279
[Bug 107279] Alias UNO commands not appearing in functions list
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107279] New: Alias UNO commands not appearing in functions list

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107279

Bug ID: 107279
   Summary: Alias UNO commands not appearing in functions list
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
CC: momonas...@gmail.com

Maxim introduced the ability to create duplicate UNO commands in bug 84258, but
these newly created UNO commands arent available in the functions list in Tools
> Customize. So the newly created 'New Slide' command (.uno:InsertSlide) isnt
available in the Insert category, but the original 'New Page' command
(.uno:InsertPage) is.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84258] Impress and Draw sharing code causing problems with icons and menus

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=84258

Yousuf Philips (jay)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||7279

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107278] New: admin console: Introduce new charts for system / CPU load

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107278

Bug ID: 107278
   Summary: admin console: Introduce new charts for system / CPU
load
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pran...@collabora.co.uk

While at it, it might be good to do some beautification of the only existing
chart as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

2017-04-19 Thread Henry Castro

 loleaflet/src/layer/AnnotationManager.js |3 ++-
 loleaflet/src/layer/marker/Annotation.js |   13 -
 loleaflet/src/layer/tile/CalcTileLayer.js|3 ++-
 loleaflet/src/layer/tile/ImpressTileLayer.js |2 +-
 4 files changed, 13 insertions(+), 8 deletions(-)

New commits:
commit b142e0ba48fbee0f7b7a7d0b0ce32693b8224c4b
Author: Henry Castro 
Date:   Wed Apr 19 21:11:28 2017 -0400

loleaflet: add option no menu when insert new annotation

Change-Id: I0950c743f9443f85674fb087c44c8fe942bcc322

diff --git a/loleaflet/src/layer/AnnotationManager.js 
b/loleaflet/src/layer/AnnotationManager.js
index 54f3496b..05ad8416 100644
--- a/loleaflet/src/layer/AnnotationManager.js
+++ b/loleaflet/src/layer/AnnotationManager.js
@@ -365,7 +365,8 @@ L.AnnotationManager = L.Class.extend({
},
 
add: function (comment) {
-   var annotation = 
L.annotation(this._map.options.maxBounds.getSouthEast(), 
comment).addTo(this._map);
+   var annotation = 
L.annotation(this._map.options.maxBounds.getSouthEast(), comment,
+   comment.id === 'new' ? {noMenu: true} : 
{}).addTo(this._map);
if (comment.parent && comment.parent > '0') {
var parentIdx = this.getIndexOf(comment.parent);
this._items.splice(parentIdx + 1, 0, annotation);
diff --git a/loleaflet/src/layer/marker/Annotation.js 
b/loleaflet/src/layer/marker/Annotation.js
index 97b2d8e9..abed0b01 100644
--- a/loleaflet/src/layer/marker/Annotation.js
+++ b/loleaflet/src/layer/marker/Annotation.js
@@ -6,7 +6,8 @@ L.Annotation = L.Layer.extend({
options: {
minWidth: 160,
maxHeight: 50,
-   imgSize: L.point([32, 32])
+   imgSize: L.point([32, 32]),
+   noMenu: false
},
 
initialize: function (latlng, data, options) {
@@ -167,10 +168,12 @@ L.Annotation = L.Layer.extend({
}, this);
}
 
-   var tdMenu = L.DomUtil.create(tagTd, 
'loleaflet-annotation-menubar', tr);
-   var divMenu = L.DomUtil.create(tagDiv, this._data.trackchange ? 
'loleaflet-annotation-menu-redline' : 'loleaflet-annotation-menu', tdMenu);
-   divMenu.title = _('Open menu');
-   divMenu.annotation = this;
+   if (this.options.noMenu !== true) {
+   var tdMenu = L.DomUtil.create(tagTd, 
'loleaflet-annotation-menubar', tr);
+   var divMenu = L.DomUtil.create(tagDiv, 
this._data.trackchange ? 'loleaflet-annotation-menu-redline' : 
'loleaflet-annotation-menu', tdMenu);
+   divMenu.title = _('Open menu');
+   divMenu.annotation = this;
+   }
if (this._data.trackchange) {
this._captionNode = L.DomUtil.create(tagDiv, 
'loleaflet-annotation-caption', wrapper);
this._captionText = L.DomUtil.create(tagDiv, empty, 
this._captionNode);
diff --git a/loleaflet/src/layer/tile/CalcTileLayer.js 
b/loleaflet/src/layer/tile/CalcTileLayer.js
index d0e300bf..80c009d4 100644
--- a/loleaflet/src/layer/tile/CalcTileLayer.js
+++ b/loleaflet/src/layer/tile/CalcTileLayer.js
@@ -32,7 +32,8 @@ L.CalcTileLayer = L.TileLayer.extend({
},
 
createAnnotation: function (comment) {
-   var annotation = 
L.divOverlay(comment.cellPos).bindAnnotation(L.annotation(L.latLng(0, 0), 
comment));
+   var annotation = 
L.divOverlay(comment.cellPos).bindAnnotation(L.annotation(L.latLng(0, 0),
+   comment, comment.id === 'new' ? {noMenu: true} : {}));
annotation.mark = L.marker(comment.cellPos.getNorthEast(), {
draggable: false,
clickable: false,
diff --git a/loleaflet/src/layer/tile/ImpressTileLayer.js 
b/loleaflet/src/layer/tile/ImpressTileLayer.js
index 09f8707f..859ef679 100644
--- a/loleaflet/src/layer/tile/ImpressTileLayer.js
+++ b/loleaflet/src/layer/tile/ImpressTileLayer.js
@@ -6,7 +6,7 @@
 L.ImpressTileLayer = L.TileLayer.extend({
 
newAnnotation: function (comment) {
-   var annotation = L.annotation(this._map.getCenter(), 
comment).addTo(this._map);
+   var annotation = L.annotation(this._map.getCenter(), comment, 
{noMenu: true}).addTo(this._map);
annotation.edit();
annotation.focus();
},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107255] Merging cells where only one is not empty should be done without confirmation

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107255

--- Comment #4 from Aron Budea  ---
What seems to be tricky here is that checking if a block is empty is
straightforward, but checking if it contains at most one cell with data (or
getting the number of empty cells in a block), not so much.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loleaflet/dist

2017-04-19 Thread Aron Budea

 loleaflet/dist/toolbar/toolbar.js |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 5367bbb3cc2423bb84006bca72156c51a7115c69
Author: Aron Budea 
Date:   Fri Apr 14 22:58:45 2017 +0200

Show font/highlight color on toolbar in IE 11 as well

.repeat is not supported.

Change-Id: I4f9d75f851f73e4cc626ca6f0a13aa1877308e70
Reviewed-on: https://gerrit.libreoffice.org/36553
Reviewed-by: Henry Castro 
Tested-by: Henry Castro 
Reviewed-on: https://gerrit.libreoffice.org/36707
Reviewed-by: Aron Budea 
Tested-by: Aron Budea 

diff --git a/loleaflet/dist/toolbar/toolbar.js 
b/loleaflet/dist/toolbar/toolbar.js
index 63e3fd82..d2b2374f 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -1115,7 +1115,7 @@ map.on('commandstatechanged', function (e) {
else {
 
color = color.toString(16);
-   color = '#' + '0'.repeat(6 - color.length) + color;
+   color = '#' + Array(7 - color.length).join('0') + color;
}
div = L.DomUtil.get('fontcolorindicator');
if (div) {
@@ -1130,7 +1130,7 @@ map.on('commandstatechanged', function (e) {
}
else {
color = color.toString(16);
-   color = '#' + '0'.repeat(6 - color.length) + color;
+   color = '#' + Array(7 - color.length).join('0') + color;
}
div = L.DomUtil.get('backcolorindicator');
if (div) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/dist

2017-04-19 Thread Aron Budea

 loleaflet/dist/toolbar/toolbar.js |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 33a562515bb1ce425caea4ea9383ddff2a34af2e
Author: Aron Budea 
Date:   Fri Apr 14 22:58:45 2017 +0200

Show font/highlight color on toolbar in IE 11 as well

.repeat is not supported.

Change-Id: I4f9d75f851f73e4cc626ca6f0a13aa1877308e70
Reviewed-on: https://gerrit.libreoffice.org/36553
Reviewed-by: Henry Castro 
Tested-by: Henry Castro 

diff --git a/loleaflet/dist/toolbar/toolbar.js 
b/loleaflet/dist/toolbar/toolbar.js
index e986a78e..6e596511 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -1130,7 +1130,7 @@ map.on('commandstatechanged', function (e) {
else {
 
color = color.toString(16);
-   color = '#' + '0'.repeat(6 - color.length) + color;
+   color = '#' + Array(7 - color.length).join('0') + color;
}
div = L.DomUtil.get('fontcolorindicator');
if (div) {
@@ -1145,7 +1145,7 @@ map.on('commandstatechanged', function (e) {
}
else {
color = color.toString(16);
-   color = '#' + '0'.repeat(6 - color.length) + color;
+   color = '#' + Array(7 - color.length).join('0') + color;
}
div = L.DomUtil.get('backcolorindicator');
if (div) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2017-04-19 Thread Henry Castro

 loleaflet/src/control/Control.ContextMenu.js |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 30f8254e88050993dc8a8ad329c083384641468b
Author: Henry Castro 
Date:   Wed Apr 19 20:14:00 2017 -0400

loleaflet: remove unnecessary spreadsheet context menu items

It is replaced by interactive client side annotations

Change-Id: Ib21926bea1cf125c82b9254c536d70ec94d95f91

diff --git a/loleaflet/src/control/Control.ContextMenu.js 
b/loleaflet/src/control/Control.ContextMenu.js
index 4961f892..70f726f9 100644
--- a/loleaflet/src/control/Control.ContextMenu.js
+++ b/loleaflet/src/control/Control.ContextMenu.js
@@ -35,9 +35,7 @@ L.Control.ContextMenu = L.Control.extend({
   'UpdateCurIndex','RemoveTableOf',
   'ReplyComment', 'DeleteComment', 
'DeleteAuthor', 'DeleteAllNotes'],
 
-   spreadsheet: ['MergeCells', 'SplitCells',
- 'InsertAnnotation', 
'EditAnnotation', 'DeleteNote', 'ShowNote', 'HideNote',
- 'RecalcPivotTable'],
+   spreadsheet: ['MergeCells', 'SplitCells', 
'RecalcPivotTable'],
 
presentation: [],
drawing: []
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107276] renaming sheet causes chart data ranges referencing sheet to change to Data Table - unrecoverable

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107276

--- Comment #2 from Rich  ---
Created attachment 132704
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132704=edit
see comment

This is not as striat forward as I first thought. In the file I am attaching,
renaming the first sheet or the second sheet doesn't seem to cause a problem.
Both seem to need renamed and then not all charts that I expect would chage do
not. Seems like a different one each time.
Not all charts on the following file have been redone yet. 
This is the actual file: "Fund & Sector Comparison 2017.ods"
There are four charts to look at that I rebuilt. They were all altered with the
initial failure along with others. Yet in recreating the problem, they all do
not fail, and a differnt one each time. I am having difficulty isolating a
specific sequence that causes the same chart to fail each time.
The charts to look at to varify they are correct before renaming the sheets
are: On the second sheet named "Fund Comparison 2016", two charts. On the far
right below the data entry is "YTD Comparison 2017-1" "Primary Funds & Indexes"
below that chart is a chart titled "YTD Comparison 2017-1" "Secondary Funds &
Indexes"
The other two charts are on the sheet named "YTD Comparison" On the right is a
Chart titled "Year to Date Comparison 2017-1" "Primary Funds, Indexes &
Sectors". Below it is a chart titled "Year to Date Comparison 2017-1"
"Secondary Funds, Indexes & Sectors"
With all four charts select the chart and right click to see menu. You shoud
see "Data Ranges"
Then change the names on the first two sheets from "Sector Tracter 2016" and
"Fund Comparison 2016" to  "Sector Tracter 2017" and "Fund Comparison 2017"
Now reselect the four charts above to see if they all show "Data Ranges" or if
one or more has changed to "Data Table"
If you don't see something easily, I am thinking that instead of repairing the
charts in this file I may go to my January backup or create a new file copying
only the data and reenter forulas and charts. There may be some residual
problem from my initial failure that I am not seeing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34438] [feature request, FORMATTING] group selection does not work with raster images

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34438

--- Comment #21 from stragu  ---
Created attachment 132703
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132703=edit
odt for testing multiselect

Document for testing this bug:

- try dragging a select box around all three elements; or
- try adding the picture and a shape to the same selection by using the
shift+click combination.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34438] [feature request, FORMATTING] group selection does not work with raster images

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34438

--- Comment #20 from stragu  ---
Confirmed in following version and config:

Version: 5.2.5.1
Build ID: 1:5.2.5~rc1-0ubuntu1~trusty0
CPU Threads: 2; OS Version: Linux 3.13; UI Render: default; VCL: gtk2; 
Locale: en-GB (en_GB.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34438] [feature request, FORMATTING] group selection does not work with raster images

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34438

stragu  changed:

   What|Removed |Added

Summary|feature request FORMATTING  |[feature request,
   |group not works with raster |FORMATTING] group selection
   |images  |does not work with raster
   ||images

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106323] tab layout in dialogues

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106323

--- Comment #4 from andreas_k  ---
Idea one
- add vertical padding/margin
- define a minimum width
- all tabbs width is the dialog width

Idea two
- move the tabs to the left as a sidebar
- you can group the entries in groups and subgroups
- better for widescreen
- a lot of work

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106323] tab layout in dialogues

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106323

andreas_k  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106474] Paste into Calc Spreadsheet gives AppHang

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106474

Mike Palmer  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from Mike Palmer  ---
I can duplicate this problem every time. 
1) Select and copy a block of many rows and columns of data in a spreadsheet.
2) In another spreadsheet, select column A and Paste.
LibreOffice hangs.

The reason it hangs is because of the replication feature of LibreOffice Calc.
When you select an area in the target spreadsheet that is larger than the block
of rows and columns being pasted, LibreOffice Calc replicates the source block
as many times as needed to fill the target block.

If you select column A row 1 the problem does not occur. But since you selected
column A and column A has 1,048,576 rows, the paste operation is repeated a
million times, which on some computers may take a couple of days to complete.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107277] Needed Menubar, Toolbar icons discussion

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107277

andreas_k  changed:

   What|Removed |Added

 CC||kain...@gmail.com

--- Comment #1 from andreas_k  ---
Created attachment 132702
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132702=edit
missing icons for the toolbar

Missing icon for the actions
- findbar (open the find toolbar when click on it)
- pagedialog (all dialog actions in the format setting has an icon so why not
pagedialog. in addition I use this action in the uploaded screenshot
- update all (icon is available and I use the action, so I need an icon for it)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107277] New: Needed Menubar, Toolbar icons discussion

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107277

Bug ID: 107277
   Summary: Needed Menubar, Toolbar icons discussion
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kain...@gmail.com

as I need for each request a bug report. this is the generic bug report for
missing icons.

Some actions are missing icons there are some reason for this
1. no icon is available
2. no icon is needed, because the action wasn't used in a toolbar

so I'd like to discuss here if 1 or 2 isn't correct any more.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107163] Page layout: text grid: Glyphs are not centered in their fields

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107163

--- Comment #6 from Kozuschek  ---
It happens with all fonts. The ones delivered with MacOS and the ones delivered
with LibreOffice ("Linux Libertine", etc).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107272] Characters don't fit into text grid with vertical writing.

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107272

--- Comment #4 from Khaled Hosny  ---
Mark, are you using internal HarfBuzz or system one, if the later wjat is the
version do you have?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107185] Furigana (ruby) text appears too far from base text, often closer to preceding/following line

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107185

--- Comment #3 from y3kcjd5  ---
Created attachment 132701
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132701=edit
PDF of demonstration document

Unfortunately the font file alone seems too big to upload as well. Windows 7
users Should get the FangSong and KaiTi fonts with the OS, so hopefully someone
can reproduce this. I'm attaching a PDF showing what I see as well. Note the
position of the stress marks (suspended to the right of "ミろる") as compared to
the furigana (suspended to the right of "こば")

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107185] Furigana (ruby) text appears too far from base text, often closer to preceding/following line

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107185

--- Comment #2 from y3kcjd5  ---
Created attachment 132700
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132700=edit
Document demonstrating furigana and stress mark position

I'm using version 5.3.2.2, Windows 7 64 bit. I recently upgraded from 5.1.2 in
an attempt to solve this and it DID get better, but it's still an issue. I'm
aware that some fonts include inordinate amounts of whitespace in their
specifications, but I know that this is not the issue because stress marks can
be rendered correctly where I'd expect the furigana to go. I've generated a
document demonstrating this, though the font (KaiTi) was too large to embed.
I'll see if I can attach it separately.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34438] feature request FORMATTING group not works with raster images

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34438

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #19 from Regina Henschel  ---
Shift + Click does not work for selecting an image (or picture or bitmap)
together with shapes or other images, because an image in Writer is no drawing
object. So you can not make multiple selection with images.
[Added some more description to make it easier in search to find this bug.]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107276] renaming sheet causes chart data ranges referencing sheet to change to Data Table - unrecoverable

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107276

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
I can't reproduce.
Version: 5.2.6.2
Build ID: a3100ed2409ebf1c212f5048fbe377c281438fdc
CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; 
Locale: es-ES (es_ES); Calc: group

Version: 5.3.2.2 (x64)
Build ID: 6cd4f1ef626f15116896b1d8e1398b56da0d0ee1
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; Layout Engine: new; 
Locale: es-ES (es_ES); Calc: group

Version: 5.4.0.0.alpha0+
Build ID: 2f5baab8498ce1303dded8aa7e16adbf80341c39
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-04-17_23:43:54
Locale: es-ES (es_ES); Calc: CL

Please could you attache a sample file where to reproduce the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34442] FORMATTING: Ability to select multiple raster images at once

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34442

Regina Henschel  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||rb.hensc...@t-online.de
 Blocks|34438   |
 Resolution|--- |DUPLICATE

--- Comment #11 from Regina Henschel  ---
The underlying reason is same as in bug 34438, so let us only use one bug.

*** This bug has been marked as a duplicate of bug 34438 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=34438
[Bug 34438] feature request FORMATTING group not works with raster images
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34438] feature request FORMATTING group not works with raster images

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34438

Regina Henschel  changed:

   What|Removed |Added

 Depends on|34442   |

--- Comment #18 from Regina Henschel  ---
*** Bug 34442 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=34442
[Bug 34442] FORMATTING: Ability to select multiple raster images at once
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34438] feature request FORMATTING group not works with raster images

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34438

Regina Henschel  changed:

   What|Removed |Added

 CC||male...@gmail.com

--- Comment #17 from Regina Henschel  ---
*** Bug 49625 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 49625] No multiselect of images is possible

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=49625

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
Bug 37960 was only about selecting two shapes. This one is about selecting
multiple images (or bitmap or picture or graphic or how you like to name it).

*** This bug has been marked as a duplicate of bug 34438 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34438] feature request FORMATTING group not works with raster images

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34438

Regina Henschel  changed:

   What|Removed |Added

 CC||stephane.guil...@member.fsf
   ||.org

--- Comment #16 from Regina Henschel  ---
*** Bug 96129 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96129] Shift click to select multiple pictures does not work

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96129

Regina Henschel  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||rb.hensc...@t-online.de
 Resolution|--- |DUPLICATE

--- Comment #4 from Regina Henschel  ---
The underlying problem is, that images in Writer are no drawing objects. Bug
34438 is the oldest and a comprehensive one of all the duplicates.

*** This bug has been marked as a duplicate of bug 34438 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107211] Table of Contents hyperlink character style "Default" or " Default Style" not imported

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107211

Michael Stahl  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||ke...@collabora.com,
   ||mst...@redhat.com
Version|5.3.2.2 release |4.0.0.3 release
Summary|Table of Contents hyperlink |Table of Contents hyperlink
   |character style reset to|character style "Default"
   |None on save and reload |or "Default Style" not
   ||imported
 Whiteboard||odf

--- Comment #10 from Michael Stahl  ---
4.0.6 is bad
3.6.7 is good

bibisect range
b6c016da23d309b4ac7d154bc33a22397974ed73..d85fd8a85501547d5bb87822d2589a07aed7f2d6

regression from:

commit 783d13a9276931e274a90b9b53de2c92dc8c055e
Author: Jan Holesovsky 
AuthorDate: Tue Nov 20 12:03:18 2012 +0100

Rename style called "Default" to "Default Style" + First Cap Some Others
too.

Change-Id: I71b74ceabfdaced541529143d15d020ac17d2e26

 sw/source/ui/utlui/poolfmt.src | 38 +++---
 1 file changed, 19 insertions(+), 19 deletions(-)


... ah, the values text:style-name="Default_20_Style" and
text:style-name="Default"  (as written by LO < 4.0) are lost on import, while
e.g."Emphasis"  works fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79990] EDITING: multiple graphic objects cannot be selected with ' shift'

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=79990

Regina Henschel  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED
 CC||rb.hensc...@t-online.de

--- Comment #8 from Regina Henschel  ---
Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107185] Furigana (ruby) text appears too far from base text, often closer to preceding/following line

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107185

--- Comment #1 from madmalkav  ---
Can you confirm which version of LO are you using, OS, etcetera? Similar issues
have been solved recently in some other bugs ( #55469 , #103730)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45240] EDITING Selection draw objects

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=45240

Regina Henschel  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED
 CC||rb.hensc...@t-online.de

--- Comment #3 from Regina Henschel  ---
Fixed

*** This bug has been marked as a duplicate of bug 37960 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42167] Multiple graphic selection fails when there is an inserted picture.

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=42167

Regina Henschel  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED
 CC||rb.hensc...@t-online.de

--- Comment #5 from Regina Henschel  ---
Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 41135] EDITING: Selection of multiple objects impossible

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=41135

Regina Henschel  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED
 CC||rb.hensc...@t-online.de

--- Comment #7 from Regina Henschel  ---
Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 33807] [EDITING]Multiple selection with shift key doesn' t work if there is a picture in the document

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=33807

Regina Henschel  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED
 CC||rb.hensc...@t-online.de

--- Comment #5 from Regina Henschel  ---
Fixed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107270] Dialogs are not showing, being gray-ish, not able to save, navigate menus, ...

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107270

--- Comment #5 from anonimou...@hotmail.com ---
Hi,
there we go:
Versão: 5.2.1.2
ID de compilação: 1:5.2.1~rc2-0ubuntu1~trusty0
Threads da CPU:8; Versão do SO: Linux 4.4; Realizador da interface: padrão; 
Local: pt-BR (pt_BR.UTF-8); Calc: group

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/po

2017-04-19 Thread Adolfo Jayme Barrientos

 loleaflet/po/styles/es.po |  152 +++---
 1 file changed, 76 insertions(+), 76 deletions(-)

New commits:
commit 566c3adee9b4438eec28ef01b399e58579100483
Author: Adolfo Jayme Barrientos 
Date:   Wed Apr 19 16:16:08 2017 -0500

Update Spanish translation (styles, synched from core)

Change-Id: I0262fb34860d23d149cc1127982160815d1d831e

diff --git a/loleaflet/po/styles/es.po b/loleaflet/po/styles/es.po
index 3b7e2377..8045d246 100644
--- a/loleaflet/po/styles/es.po
+++ b/loleaflet/po/styles/es.po
@@ -37,7 +37,7 @@ msgctxt ""
 "STR_STYLENAME_HEADLINE\n"
 "string.text"
 msgid "Heading"
-msgstr "Encabezado"
+msgstr "TÃtulo"
 
 
 #: globstr.src
@@ -47,7 +47,7 @@ msgctxt ""
 "STR_STYLENAME_HEADLINE1\n"
 "string.text"
 msgid "Heading1"
-msgstr "Encabezado1"
+msgstr "TÃtulo1"
 
 
 #: globstr.src
@@ -272,7 +272,7 @@ msgctxt ""
 "STR_POOLCHR_HTML_KEYBOARD\n"
 "string.text"
 msgid "User Entry"
-msgstr "Entrada del usuario"
+msgstr "Entrada de usuario"
 
 
 #: poolfmt.src
@@ -434,7 +434,7 @@ msgctxt ""
 "STR_POOLCOLL_HEADLINE_BASE\n"
 "string.text"
 msgid "Heading"
-msgstr "Encabezado"
+msgstr "TÃtulo"
 
 
 #: poolfmt.src
@@ -479,7 +479,7 @@ msgctxt ""
 "STR_POOLCOLL_HEADLINE1\n"
 "string.text"
 msgid "Heading 1"
-msgstr "Encabezado 1"
+msgstr "TÃtulo 1"
 
 
 #: poolfmt.src
@@ -488,7 +488,7 @@ msgctxt ""
 "STR_POOLCOLL_HEADLINE2\n"
 "string.text"
 msgid "Heading 2"
-msgstr "Encabezado 2"
+msgstr "TÃtulo 2"
 
 
 #: poolfmt.src
@@ -497,7 +497,7 @@ msgctxt ""
 "STR_POOLCOLL_HEADLINE3\n"
 "string.text"
 msgid "Heading 3"
-msgstr "Encabezado 3"
+msgstr "TÃtulo 3"
 
 
 #: poolfmt.src
@@ -506,7 +506,7 @@ msgctxt ""
 "STR_POOLCOLL_HEADLINE4\n"
 "string.text"
 msgid "Heading 4"
-msgstr "Encabezado 4"
+msgstr "TÃtulo 4"
 
 
 #: poolfmt.src
@@ -515,7 +515,7 @@ msgctxt ""
 "STR_POOLCOLL_HEADLINE5\n"
 "string.text"
 msgid "Heading 5"
-msgstr "Encabezado 5"
+msgstr "TÃtulo 5"
 
 
 #: poolfmt.src
@@ -524,7 +524,7 @@ msgctxt ""
 "STR_POOLCOLL_HEADLINE6\n"
 "string.text"
 msgid "Heading 6"
-msgstr "Encabezado 6"
+msgstr "TÃtulo 6"
 
 
 #: poolfmt.src
@@ -533,7 +533,7 @@ msgctxt ""
 "STR_POOLCOLL_HEADLINE7\n"
 "string.text"
 msgid "Heading 7"
-msgstr "Encabezado 7"
+msgstr "TÃtulo 7"
 
 
 #: poolfmt.src
@@ -542,7 +542,7 @@ msgctxt ""
 "STR_POOLCOLL_HEADLINE8\n"
 "string.text"
 msgid "Heading 8"
-msgstr "Encabezado 8"
+msgstr "TÃtulo 8"
 
 
 #: poolfmt.src
@@ -551,7 +551,7 @@ msgctxt ""
 "STR_POOLCOLL_HEADLINE9\n"
 "string.text"
 msgid "Heading 9"
-msgstr "Encabezado 9"
+msgstr "TÃtulo 9"
 
 
 #: poolfmt.src
@@ -560,7 +560,7 @@ msgctxt ""
 "STR_POOLCOLL_HEADLINE10\n"
 "string.text"
 msgid "Heading 10"
-msgstr "Encabezado 10"
+msgstr "TÃtulo 10"
 
 
 #: poolfmt.src
@@ -749,7 +749,7 @@ msgctxt ""
 "STR_POOLCOLL_BUL_LEVEL1S\n"
 "string.text"
 msgid "List 1 Start"
-msgstr "EnumeraciÃ³n 1 inicio"
+msgstr "Lista 1 inicio"
 
 
 #: poolfmt.src
@@ -767,7 +767,7 @@ msgctxt ""
 "STR_POOLCOLL_BUL_LEVEL1E\n"
 "string.text"
 msgid "List 1 End"
-msgstr "EnumeraciÃ³n 1 fin"
+msgstr "Lista 1 fin"
 
 
 #: poolfmt.src
@@ -776,7 +776,7 @@ msgctxt ""
 "STR_POOLCOLL_BUL_NONUM1\n"
 "string.text"
 msgid "List 1 Cont."
-msgstr "EnumeraciÃ³n 1 continuaciÃ³n"
+msgstr "Lista 1 continuaciÃ³n"
 
 
 #: poolfmt.src
@@ -785,7 +785,7 @@ msgctxt ""
 "STR_POOLCOLL_BUL_LEVEL2S\n"
 "string.text"
 msgid "List 2 Start"
-msgstr "EnumeraciÃ³n 2 inicio"
+msgstr "Lista 2 inicio"
 
 
 #: poolfmt.src
@@ -803,7 +803,7 @@ msgctxt ""
 "STR_POOLCOLL_BUL_LEVEL2E\n"
 "string.text"
 msgid "List 2 End"
-msgstr "EnumeraciÃ³n 2 fin"
+msgstr "Lista 2 fin"
 
 
 #: poolfmt.src
@@ -812,7 +812,7 @@ msgctxt ""
 "STR_POOLCOLL_BUL_NONUM2\n"
 "string.text"
 msgid "List 2 Cont."
-msgstr "EnumeraciÃ³n 2 continuaciÃ³n"
+msgstr "Lista 2 continuaciÃ³n"
 
 
 #: poolfmt.src
@@ -821,7 +821,7 @@ msgctxt ""
 "STR_POOLCOLL_BUL_LEVEL3S\n"
 "string.text"
 msgid "List 3 Start"
-msgstr "EnumeraciÃ³n 3 inicio"
+msgstr "Lista 3 inicio"
 
 
 #: poolfmt.src
@@ -839,7 +839,7 @@ msgctxt ""
 "STR_POOLCOLL_BUL_LEVEL3E\n"
 "string.text"
 msgid "List 3 End"
-msgstr "EnumeraciÃ³n 3 fin"
+msgstr "Lista 3 fin"
 
 
 #: poolfmt.src
@@ -848,7 +848,7 @@ msgctxt ""
 "STR_POOLCOLL_BUL_NONUM3\n"
 "string.text"
 msgid "List 3 Cont."
-msgstr "EnumeraciÃ³n 3 continuaciÃ³n"
+msgstr "Lista 3 continuaciÃ³n"
 
 
 #: poolfmt.src
@@ -857,7 +857,7 @@ msgctxt ""
 "STR_POOLCOLL_BUL_LEVEL4S\n"
 "string.text"
 msgid "List 4 Start"
-msgstr "EnumeraciÃ³n 4 inicio"
+msgstr "Lista 4 inicio"
 
 
 #: poolfmt.src
@@ -875,7 +875,7 @@ msgctxt ""
 "STR_POOLCOLL_BUL_LEVEL4E\n"
 "string.text"
 msgid "List 4 End"
-msgstr "EnumeraciÃ³n 4 fin"
+msgstr "Lista 4 fin"
 
 
 #: poolfmt.src
@@ -884,7 +884,7 @@ msgctxt ""
 "STR_POOLCOLL_BUL_NONUM4\n"
 "string.text"
 msgid "List 4 Cont."
-msgstr "EnumeraciÃ³n 4 continuaciÃ³n"
+msgstr "Lista 4 continuaciÃ³n"
 
 
 #: poolfmt.src
@@ -893,7 +893,7 @@ msgctxt ""
 "STR_POOLCOLL_BUL_LEVEL5S\n"
 "string.text"
 msgid "List 5 Start"
-msgstr

[Libreoffice-bugs] [Bug 68604] FILESAVE: last comment change with cursor within box not saved in .docx using "save " toolbar button (see Comment 41 and Comment 44)

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=68604

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:docx
 CC||ba...@caesar.elte.hu
 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107209] Text layout error; text lines overlap randomly in long " complicated" documents

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107209

--- Comment #8 from y3kcjd5  ---
This is rather strange, did the second example show up as using Meiryo as its
font or did your system make a substitution again? Comparing the 4 pdfs we've
produced, they all look quite different from each other. 

I'm using Windows 7 64bit

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78049] IDE: Printing basic code on Linux does not work

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=78049

--- Comment #9 from oas...@yahoo.com ---
LibreOffice 5.2.6.2
Ubuntu 16.04

Prints to file and printer both printing border and heading, but no contents.

Print preview shows basic code correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/qa

2017-04-19 Thread Tomaž Vajngerl

 chart2/qa/extras/PivotChartTest.cxx |  134 ++--
 1 file changed, 130 insertions(+), 4 deletions(-)

New commits:
commit d11746a8f4dfa443a404add08ff8bfe51590c607
Author: TomaÅ¾ Vajngerl 
Date:   Mon Apr 17 17:59:51 2017 +0200

pivotcharts: test pivot table fields

Change-Id: I384bf36a79adccdccdecb836b122958ce925c376
Reviewed-on: https://gerrit.libreoffice.org/36628
Tested-by: Jenkins 
Reviewed-by: TomaÅ¾ Vajngerl 

diff --git a/chart2/qa/extras/PivotChartTest.cxx 
b/chart2/qa/extras/PivotChartTest.cxx
index 8729e5b30185..fae7137fc0dc 100644
--- a/chart2/qa/extras/PivotChartTest.cxx
+++ b/chart2/qa/extras/PivotChartTest.cxx
@@ -22,6 +22,8 @@
 #include 
 #include 
 
+#include 
+
 #include 
 
 #include 
@@ -36,12 +38,14 @@ public:
 void testChangePivotTable();
 void testPivotChartWithOneColumnField();
 void testPivotChartWithOneRowField();
+void testPivotTableDataProvider_PivotTableFields();
 
 CPPUNIT_TEST_SUITE(PivotChartTest);
 CPPUNIT_TEST(testRoundtrip);
 CPPUNIT_TEST(testChangePivotTable);
 CPPUNIT_TEST(testPivotChartWithOneColumnField);
 CPPUNIT_TEST(testPivotChartWithOneRowField);
+CPPUNIT_TEST(testPivotTableDataProvider_PivotTableFields);
 CPPUNIT_TEST_SUITE_END();
 };
 
@@ -52,11 +56,11 @@ void 
lclModifyOrientation(uno::Reference const & xD
   OUString const & sFieldName,
   sheet::DataPilotFieldOrientation eOrientation)
 {
-uno::Reference 
xPilotIndexAccess(xDescriptor->getDataPilotFields(), UNO_QUERY_THROW);
-sal_Int32 nCount = xPilotIndexAccess->getCount();
+uno::Reference 
xIndexAccess(xDescriptor->getDataPilotFields(), UNO_QUERY_THROW);
+sal_Int32 nCount = xIndexAccess->getCount();
 for (sal_Int32 i = 0; i < nCount; ++i)
 {
-uno::Reference 
xNamed(xPilotIndexAccess->getByIndex(i), UNO_QUERY_THROW);
+uno::Reference xNamed(xIndexAccess->getByIndex(i), 
UNO_QUERY_THROW);
 OUString aName = xNamed->getName();
 uno::Reference xPropSet(xNamed, UNO_QUERY_THROW);
 if (aName == sFieldName)
@@ -80,6 +84,18 @@ void 
lclModifyFunction(uno::Reference const & xDesc
 }
 }
 
+void lclModifyColumnGrandTotal(uno::Reference 
const & xDataPilotDescriptor, bool bTotal)
+{
+uno::Reference xProperties(xDataPilotDescriptor, 
uno::UNO_QUERY_THROW);
+xProperties->setPropertyValue("ColumnGrand", uno::makeAny(bTotal));
+}
+
+void lclModifyRowGrandTotal(uno::Reference const 
& xDataPilotDescriptor, bool bTotal)
+{
+uno::Reference xProperties(xDataPilotDescriptor, 
uno::UNO_QUERY_THROW);
+xProperties->setPropertyValue("RowGrand", uno::makeAny(bTotal));
+}
+
 void lclCheckSequence(std::vector const & reference,
   uno::Sequence const & values,
   double delta)
@@ -399,7 +415,6 @@ void PivotChartTest::testChangePivotTable()
 
 // Enable column totals and check the data is still unchanged
 {
-uno::Reference 
xDataPilotDescriptor(xDataPilotTable, uno::UNO_QUERY_THROW);
 uno::Reference xProperties(xDataPilotTable, 
uno::UNO_QUERY_THROW);
 xProperties->setPropertyValue("ColumnGrand", uno::makeAny(true));
 }
@@ -584,6 +599,117 @@ void PivotChartTest::testPivotChartWithOneRowField()
 }
 }
 
+void PivotChartTest::testPivotTableDataProvider_PivotTableFields()
+{
+// SETUP DATA and PIVOT TABLE
+
+if (!mxComponent.is())
+mxComponent = loadFromDesktop("private:factory/scalc");
+
+uno::Reference xSheetDoc(mxComponent, 
uno::UNO_QUERY_THROW);
+
+sal_Int32 nSheetIndex = 0;
+OUString sPivotTableName("DataPilotTable");
+
+table::CellRangeAddress sCellRangeAdress = lclCreateTestData(xSheetDoc);
+
+uno::Reference xDataPilotTables;
+xDataPilotTables = lclGetDataPilotTables(nSheetIndex, xSheetDoc);
+
+uno::Reference xDataPilotDescriptor;
+xDataPilotDescriptor = xDataPilotTables->createDataPilotDescriptor();
+xDataPilotDescriptor->setSourceRange(sCellRangeAdress);
+
+lclModifyOrientation(xDataPilotDescriptor, "City", 
sheet::DataPilotFieldOrientation_ROW);
+lclModifyOrientation(xDataPilotDescriptor, "Country", 
sheet::DataPilotFieldOrientation_COLUMN);
+lclModifyOrientation(xDataPilotDescriptor, "Type", 
sheet::DataPilotFieldOrientation_COLUMN);
+lclModifyOrientation(xDataPilotDescriptor, "Sales T1", 
sheet::DataPilotFieldOrientation_DATA);
+lclModifyFunction(xDataPilotDescriptor, "Sales T1", 
sheet::GeneralFunction_SUM);
+lclModifyOrientation(xDataPilotDescriptor, "Sales T2", 
sheet::DataPilotFieldOrientation_DATA);
+lclModifyFunction(xDataPilotDescriptor, "Sales T2", 
sheet::GeneralFunction_SUM);
+
+lclModifyColumnGrandTotal(xDataPilotDescriptor, true);
+lclModifyRowGrandTotal(xDataPilotDescriptor, true);
+
+xDataPilotTables->insertNewByName(sPivotTableName,

[Libreoffice-bugs] [Bug 65675] LibreOffice 4.2 most annoying bugs

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=65675
Bug 65675 depends on bug 37960, which changed state.

Bug 37960 Summary: Shift click to select multiple drawings does not work if 
picture there[Summary in Comment # 30]
https://bugs.documentfoundation.org/show_bug.cgi?id=37960

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 65675] LibreOffice 4.2 most annoying bugs

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=65675
Bug 65675 depends on bug 37960, which changed state.

Bug 37960 Summary: Shift click to select multiple drawings does not work if 
picture there[Summary in Comment # 30]
https://bugs.documentfoundation.org/show_bug.cgi?id=37960

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 107202] Link template to document (visible in document properties)

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107202

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |NOTABUG

--- Comment #1 from Jean-Baptiste Faure  ---
There is not a default template by default in LibreOffice. Default styles are
hard coded and default fonts are defined in the user options.
However you can define a default template if you want. See the template manager
and the help to know how to define a particular template as the default
template for a given module of LibreOffice.

So, closing as NotABug. Feel free to reopen if you disagree. In such a case,
please explain your point as clearly as possible.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 65675] LibreOffice 4.2 most annoying bugs

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=65675
Bug 65675 depends on bug 37960, which changed state.

Bug 37960 Summary: Shift click to select multiple drawings does not work if 
picture there[Summary in Comment # 30]
https://bugs.documentfoundation.org/show_bug.cgi?id=37960

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 34438] feature request FORMATTING group not works with raster images

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34438

--- Comment #15 from Norbert X  ---
Bug is not fixed. 
Still unable to group images.

Version: 5.1.6.2
Build ID: 1:5.1.6~rc2-0ubuntu1~xenial1
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34442] FORMATTING: Ability to select multiple raster images at once

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34442

--- Comment #10 from Norbert X  ---
Bug is not fixed. 
Still unable to select both image and drawing object with +Click.


Version: 5.1.6.2
Build ID: 1:5.1.6~rc2-0ubuntu1~xenial1
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61561] EDITING: senseless limitation for Placement values in duplicate function (Shft+F3)

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=61561

Laurent BP  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=77
   ||816

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107207] Applications or files don't open after a while ( and computer has slept ?)

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107207

Jean-Baptiste Faure  changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77816] Draw - Duplicate Function - Does not take fractional angles

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=77816

Laurent BP  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=61
   ||561

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source

2017-04-19 Thread Katarina Behrens

 cui/source/tabpages/tparea.cxx   |2 --
 cui/source/tabpages/tpgradnt.cxx |9 +++--
 cui/source/tabpages/tphatch.cxx  |9 +++--
 3 files changed, 6 insertions(+), 14 deletions(-)

New commits:
commit ec1a44969e5252afa24417011be7a0995e6282eb
Author: Katarina Behrens 
Date:   Wed Apr 19 15:13:06 2017 +0200

This doesn't have to be member variable, it is used just once

and then forgotten again

Change-Id: Id94639415bd1679b67d5d3094dee8b8f8f3d3167
Reviewed-on: https://gerrit.libreoffice.org/36690
Tested-by: Jenkins 
Reviewed-by: Katarina Behrens 

diff --git a/cui/source/tabpages/tparea.cxx b/cui/source/tabpages/tparea.cxx
index f8b392ae92fb..10e50cfd932b 100644
--- a/cui/source/tabpages/tparea.cxx
+++ b/cui/source/tabpages/tparea.cxx
@@ -416,7 +416,6 @@ void SvxAreaTabPage::CreatePage( sal_Int32 nId, SfxTabPage* 
pTab )
 {
 static_cast(pTab)->SetColorList( m_pColorList );
 static_cast(pTab)->SetGradientList( 
m_pGradientList );
-static_cast(pTab)->SetPos( _nPos );
 static_cast(pTab)->SetGrdChgd( 
m_pnGradientListState );
 static_cast(pTab)->SetColorChgd( 
m_pnColorListState );
 static_cast(pTab)->Construct();
@@ -428,7 +427,6 @@ void SvxAreaTabPage::CreatePage( sal_Int32 nId, SfxTabPage* 
pTab )
 {
 static_cast(pTab)->SetColorList( m_pColorList );
 static_cast(pTab)->SetHatchingList( m_pHatchingList 
);
-static_cast(pTab)->SetPos(_nPos);
 static_cast(pTab)->SetHtchChgd( 
m_pnHatchingListState );
 static_cast(pTab)->SetColorChgd( m_pnColorListState 
);
 static_cast(pTab)->Construct();
diff --git a/cui/source/tabpages/tpgradnt.cxx b/cui/source/tabpages/tpgradnt.cxx
index c1cc8ada0c8f..2f6350d97bc2 100644
--- a/cui/source/tabpages/tpgradnt.cxx
+++ b/cui/source/tabpages/tpgradnt.cxx
@@ -58,7 +58,6 @@ SvxGradientTabPage::SvxGradientTabPage
 
 m_pnGradientListState ( nullptr ),
 m_pnColorListState( nullptr ),
-m_pPos( nullptr ),
 
 m_aXFStyleItem( drawing::FillStyle_GRADIENT ),
 m_aXGradientItem  ( OUString(), XGradient( COL_BLACK, COL_WHITE ) ),
@@ -201,16 +200,14 @@ void SvxGradientTabPage::ActivatePage( const SfxItemSet& 
rSet )
 else
 aString += aURL.getBase();
 
-*m_pPos = SearchGradientList( ( _cast( rSet.Get(XATTR_FILLGRADIENT) ) )->GetName() );
-if ( *m_pPos != LISTBOX_ENTRY_NOTFOUND )
+sal_Int32 nPos = SearchGradientList( ( _cast( rSet.Get(XATTR_FILLGRADIENT) ) )->GetName() );
+if ( nPos != LISTBOX_ENTRY_NOTFOUND )
 {
-sal_uInt16 nId = m_pGradientLB->GetItemId( static_cast( 
*m_pPos ) );
+sal_uInt16 nId = m_pGradientLB->GetItemId( static_cast( 
nPos ) );
 m_pGradientLB->SelectItem( nId );
 }
 // colors could have been deleted
 ChangeGradientHdl_Impl();
-
-*m_pPos = LISTBOX_ENTRY_NOTFOUND;
 }
 }
 
diff --git a/cui/source/tabpages/tphatch.cxx b/cui/source/tabpages/tphatch.cxx
index a6e61d264537..ae39e0e6a01c 100644
--- a/cui/source/tabpages/tphatch.cxx
+++ b/cui/source/tabpages/tphatch.cxx
@@ -58,7 +58,6 @@ SvxHatchTabPage::SvxHatchTabPage
 m_rOutAttrs   ( rInAttrs ),
 m_pnHatchingListState ( nullptr ),
 m_pnColorListState( nullptr ),
-m_pPos( nullptr ),
 
 m_aXFStyleItem( drawing::FillStyle_HATCH ),
 m_aXHatchItem ( OUString(), XHatch() ),
@@ -188,16 +187,14 @@ void SvxHatchTabPage::ActivatePage( const SfxItemSet& 
rSet )
 else
 aString += aURL.getBase();
 
-*m_pPos = SearchHatchList( ( _cast( 
rSet.Get(XATTR_FILLHATCH)) )->GetName() );
-if( *m_pPos != LISTBOX_ENTRY_NOTFOUND )
+sal_Int32 nPos = SearchHatchList( ( _cast( rSet.Get(XATTR_FILLHATCH)) )->GetName() );
+if( nPos != LISTBOX_ENTRY_NOTFOUND )
 {
-sal_uInt16 nId = m_pHatchLB->GetItemId( static_cast( 
*m_pPos ) );
+sal_uInt16 nId = m_pHatchLB->GetItemId( static_cast( nPos 
) );
 m_pHatchLB->SelectItem( nId );
 }
 // colors could have been deleted
 ChangeHatchHdl_Impl();
-
-*m_pPos = LISTBOX_ENTRY_NOTFOUND;
 }
 
 XFillBackgroundItem aBckItem( static_cast(rSet.Get(XATTR_FILLBACKGROUND)));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 65675] LibreOffice 4.2 most annoying bugs

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=65675
Bug 65675 depends on bug 37960, which changed state.

Bug 37960 Summary: Shift click to select multiple drawings does not work if 
picture there[Summary in Comment # 30]
https://bugs.documentfoundation.org/show_bug.cgi?id=37960

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107209] Text layout error; text lines overlap randomly in long " complicated" documents

2017-04-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107209

--- Comment #7 from Jean-Baptiste Faure  ---
Created attachment 132699
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132699=edit
pdf version of 2nd example from LO 5.3.4.0.0+

Here is my pdf export of your second example. I do not see any overlapping.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

1 2 3 4 >

1 - 100 of 378 matches

Mail list logo