[Libreoffice-qa] 2 last master builds was not start on Windows XP 64-bit

[ape]

master
2017-04-26_22.29.37_LibreOfficeDev_5.4.0.0.alpha0_Win_x86_en-US_de_ar_ja_ru_qtz.msi;
master
2017-04-28_00.28.06_LibreOfficeDev_5.4.0.0.alpha0_Win_x86_en-US_de_ar_ja_ru_qtz.msi
does not start on Windows XP 64-bit Edition. A message is displayed on the
screen:

soffice.bin - Entry Point Not Found
--
The procedure entry point GetUserDefaultLocaleName could not be located in
the dynamic link library KERNEL32.dll.




--
View this message in context: 
http://nabble.documentfoundation.org/2-last-master-builds-was-not-start-on-Windows-XP-64-bit-tp4213420.html
Sent from the QA mailing list archive at Nabble.com.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 106379] EDITING: Column copy and paste freezes with 100% CPU loop in soffice.bin

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106379

Buovjaga  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48381] Pasting a formula in a full column appears to hang Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=48381

Buovjaga  changed:

   What|Removed |Added

 CC||srbrodd...@yahoo.co.uk

--- Comment #8 from Buovjaga  ---
*** Bug 106474 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106474] Paste into Calc Spreadsheet gives AppHang

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106474

Buovjaga  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Buovjaga  ---
(In reply to brodders from comment #4)
> I found my very own version of this... and didn't wait a couple of days to
> find out if paste worked.
> 
> Will say Yes, this is the bug.

Ok, then let's close as duplicate of a certain general bug.

*** This bug has been marked as a duplicate of bug 48381 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107298] Snap option "When creating or moving objects" is mis-labeled in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107298

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #6 from Buovjaga  ---
I tend to agree with Mike. "Snap Position" as it functions in LibO is
completely alien terminology to me, a person with extensive experience with 2D
and 2D graphics software.

After testing I can say the correct terminology is "Constrain" instead of
"Snap" and "Position" does not really fit there. I think the title should be
"Constrain Transformations" and the checkbox titles can stay as they are.
Mike: do you agree with my proposal?

Here is the help page: https://help.libreoffice.org/Common/Grid_2#Snap_position

I'm going to go ahead and set to NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107155] Kerning is not used when characters have different colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107155

--- Comment #11 from Buovjaga  ---
No, he said he didn't know it worked on Windows. Now that we have unified text
rendering across platforms, we have unifiedly broken kerning.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83108] Not enough randomness when converting to PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83108

--- Comment #23 from Buovjaga  ---
(In reply to hyper_ch from comment #22)
> KDE5? Tool is not updated for KDE5 context menu paths yet...

Ok, let me know when you update it or provide a command line repro path.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107487] Unicode ExtB+ chars do not use fallback font correctly in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107487

--- Comment #8 from Volga  ---
In regedit.exe I created a new item path under the following paths, remaned
"HanaMinA":

\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows
NT\CurrentVersion\LanguagePack\SurrogateFallback\
\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows
NT\CurrentVersion\LanguagePack\SurrogateFallback\

Then I add a item "Plane2", the value is HanaMinB. I try them on LO Writer,
they seems works with HanaMinA font, but characters are still wrongly placed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107487] Unicode ExtB+ chars do not use fallback font correctly in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107487

--- Comment #7 from Volga  ---
64-bit version of Windows has additional resistry paths with the same purpose:

\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows
NT\CurrentVersion\LanguagePack\SurrogateFallback\MingLiU
\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows
NT\CurrentVersion\LanguagePack\SurrogateFallback\MingLiU-HKSCS
\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows
NT\CurrentVersion\LanguagePack\SurrogateFallback\PMingLiU
\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows
NT\CurrentVersion\LanguagePack\SurrogateFallback\SimSun

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107487] Unicode ExtB+ chars do not use fallback font correctly in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107487

Volga  changed:

   What|Removed |Added

Crash report or||107488
crash signature||

--- Comment #6 from Volga  ---
Windows Registry have the following registry paths for Unicode Plane 2 fallback
fonts that you can see them in regedit.exe:

\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows
NT\CurrentVersion\LanguagePack\SurrogateFallback\MingLiU
\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows
NT\CurrentVersion\LanguagePack\SurrogateFallback\MingLiU_HKSCS
\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows
NT\CurrentVersion\LanguagePack\SurrogateFallback\PMingLiU
\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows
NT\CurrentVersion\LanguagePack\SurrogateFallback\SimSun

All these paths have an item named "Plane2" to indicate which fallback fonts
used to render the text respectively. According to their items, this
relationship can be list as below:

Plane 1   | Plane 2 fallback
-
MingLiU   | MingLiU-ExtB
MingLiU_HKSCS | MingLiU_HKSCS-ExtB
PMingLiU  | PMingLiU-ExtB
SimSun| SimSun-ExtB

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102946] [META] Styles bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102946

Volga  changed:

   What|Removed |Added

 Depends on||103596


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103596
[Bug 103596] Support OpenType Font Variation based text layout
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103596] Support OpenType Font Variation based text layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103596

Volga  changed:

   What|Removed |Added

 Blocks||102946


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102946
[Bug 102946] [META] Styles bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106045] [META] Vertical text direction issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106045

Volga  changed:

   What|Removed |Added

 Depends on||107488


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107488
[Bug 107488] 新細明體-ExtB does not display chars vertically in Writer
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107488] 新細明體-ExtB does not display chars vertically in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107488

Volga  changed:

   What|Removed |Added

 Blocks||106045, 103342


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103342
[Bug 103342] [META] Font substitution bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106045
[Bug 106045] [META] Vertical text direction issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103342] [META] Font substitution bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103342

Volga  changed:

   What|Removed |Added

 Depends on||107488


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107488
[Bug 107488] 新細明體-ExtB does not display chars vertically in Writer
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103342] [META] Font substitution bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103342

Volga  changed:

   What|Removed |Added

 Depends on||107487


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107487
[Bug 107487] Unicode ExtB+ chars do not use fallback font correctly in Writer
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83066] [META] Tracking bug for CJK issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83066

Volga  changed:

   What|Removed |Added

 Depends on||107487


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107487
[Bug 107487] Unicode ExtB+ chars do not use fallback font correctly in Writer
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107487] Unicode ExtB+ chars do not use fallback font correctly in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107487

Volga  changed:

   What|Removed |Added

 Blocks||83066, 103342


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83066
[Bug 83066] [META] Tracking bug for CJK issues
https://bugs.documentfoundation.org/show_bug.cgi?id=103342
[Bug 103342] [META] Font substitution bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83734] EDITING: Cropped image gets distorted when Compress Graphic is used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83734

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=34
   ||133

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34133] Add ability to automatically compress and resize images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34133

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=83
   ||734

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Moving away from tools module

[Bjoern Michaelsen]

Hi,

On Fri, Apr 28, 2017 at 08:36:19AM +1000, Chris Sherlock wrote:
> Thoughts?

tools is the "this really need to die" module. The only place anything from
there should ever move to is oblivion.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-ux-advise] [Bug 106534] Color set/ palette for charts missing since reorganization of color palettes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106534

Thomas Lendo  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #6 from Thomas Lendo  ---
Adding keyword needsUXEval because user should be able to reuse the chart
default colors, so this is a UX and design issue.

Idea: A chart color palette should be introduced. Or another idea to handle
that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 106534] Color set/ palette for charts missing since reorganization of color palettes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106534

Thomas Lendo  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #6 from Thomas Lendo  ---
Adding keyword needsUXEval because user should be able to reuse the chart
default colors, so this is a UX and design issue.

Idea: A chart color palette should be introduced. Or another idea to handle
that?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 105841] "First name" in user data is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105841

Thomas Lendo  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 104771] Graphics unit is not displayed correctly in the converted file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104771

--- Comment #8 from Bartosz  ---
Created attachment 132922
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132922=edit
Image extracted from document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34133] Add ability to automatically compress and resize images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34133

Thomas Lendo  changed:

   What|Removed |Added

 CC||thomas.le...@gmail.com

--- Comment #35 from Thomas Lendo  ---
If you consider to implement this feature, please have also bug 83734 "EDITING:
Cropped image gets distorted when Compress Graphic is used" in mind. Such a bug
should be fixed before the compression feature is used by more people than now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Moving away from tools module

[Chris Sherlock]

Hi all,

As I'm researching my book on the guts of LibreOffice, I notice that tools 
predates the SAL. In fact it's a bit of a hodge-lodge of files, many of which 
look like they should probably migrated into other modules.

I cleaned up ErrorHandler, but I thought I'd ask about the other headers here:

- b3dtrans.hxx - I'm assuming the b3d bit means basegfx 3D transformations. 
I've submitted https://gerrit.libreoffice.org/#/c/37030/ to move it into 
basegfx but unfortunately it's failing o Windows and I don't currently have a 
working system to determine why the linker is erroring out.

- bigint.hxx and fract.hxx - seems to be more appropriate to the sal module, 
possibly the RTL? Great to get thoughts of others on this one

- color.hxx and colordata.hxx - should that migrate to basegfx also?

- gen.hxx - includes Pair (shouldn't that be deprecated to std::pair?), Point, 
Size, Range, Selection and Rectangle
- poly.hxx - polygons
- line.hxx - lines

gen.hxx, lines.hxx and poly.hxx all are drawing primitives, wouldn't these be 
better off in basegfx?

- config.hxx - where would this go? I was thinking the RTL, but it also seems 
like something the VLC might do...

- contr.hxx - seems better suited in the svx module...

- cpuid.hxx - checks for SSE2 support, surely something for the SAL?

- time.hxx, date.hxx, datetime.hxx and datetimeutils.hxx - these all seem to be 
better suited to the SAL, and actually should we consider moving to chrono?

- debug.hxx and diagnose_ex.hxx - seems more suited to the RTL...

-extendApplicationEnvironment - seems to be a candidate for the OSL...

- fldunit.hxx and fontenum.hxx - both seems to be more appropriate in the VCL

There are quite a few headers, but as you can see most look to be more 
appropriately moved to another module. This would help streamline our module 
dependencies...

Thoughts?

Chris


Sent from my iPhone___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/oox oox/source sd/source sw/source

[Stephan Bergmann]

 include/oox/export/utils.hxx |6 +
 oox/source/export/chartexport.cxx|   62 +++
 oox/source/export/drawingml.cxx  |  106 +--
 oox/source/export/shapes.cxx |   60 +++
 sd/source/filter/eppt/pptx-epptooxml.cxx |   42 +-
 sw/source/filter/ww8/docxattributeoutput.cxx |   10 +-
 sw/source/filter/ww8/docxsdrexport.cxx   |   10 +-
 7 files changed, 151 insertions(+), 145 deletions(-)

New commits:
commit 74ccd02eda2d6325a27266fd935aba29b3d75020
Author: Stephan Bergmann 
Date:   Thu Apr 27 21:49:58 2017 +0200

tdf#107020: Reintroduce uses of I32S, I64S

...that had been removed with 4b788a12380518e31a9064d5839f4880d3f36874 
"There
should be no need to distinguish between I32S and I64S" (which this commit
effectively reverts).  I had erroneously assumed that the arguments to I32S 
and
I64S would only be of (signed) integer types, and that it would be 
irrelevant
that they are truncated to sal_Int32 resp. sal_Int64.  However, at least
oox/source/export/drawingml.cxx called I32S with double values (for which 
there
is an OUString::number overload too), so the resulting strings could be 
rather
different.

Change-Id: Ib3887269fad0764740bc9ed3be91f67696a23b55
Reviewed-on: https://gerrit.libreoffice.org/37040
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/include/oox/export/utils.hxx b/include/oox/export/utils.hxx
index 8e5b814dd908..50e488ec2d6e 100644
--- a/include/oox/export/utils.hxx
+++ b/include/oox/export/utils.hxx
@@ -24,6 +24,12 @@
 #include 
 #include 
 
+namespace {
+inline OString I32S_(sal_Int32 x) { return OString::number(x); }
+inline OString I64S_(sal_Int64 x) { return OString::number(x); }
+}
+#define I32S(x) I32S_(x).getStr()
+#define I64S(x) I64S_(x).getStr()
 #define IS(x) OString::number( x ).getStr()
 #define BS(x) (x ? "1":"0")
 #define USS(x) OUStringToOString( x, RTL_TEXTENCODING_UTF8 ).getStr()
diff --git a/oox/source/export/chartexport.cxx 
b/oox/source/export/chartexport.cxx
index 1a970a1f877a..329a5e8aadef 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -527,7 +527,7 @@ void ChartExport::WriteChartObj( const Reference< XShape >& 
xShape, sal_Int32 nC
 sal_Int32 nID = GetChartID();
 
 pFS->singleElementNS( mnXmlNamespace, XML_cNvPr,
-  XML_id, IS( nID ),
+  XML_id, I32S( nID ),
   XML_name,   USS( sName ),
   FSEND );
 
@@ -1562,7 +1562,7 @@ void ChartExport::exportBarChart( const Reference< 
chart2::XChartType >& xChartT
 {
 sal_Int32 nGapWidth = aBarPositionSequence[0];
 pFS->singleElement( FSNS( XML_c, XML_gapWidth ),
-XML_val, IS( nGapWidth ),
+XML_val, I32S( nGapWidth ),
 FSEND );
 }
 }
@@ -1604,7 +1604,7 @@ void ChartExport::exportBarChart( const Reference< 
chart2::XChartType >& xChartT
 {
 sal_Int32 nOverlap = aBarPositionSequence[0];
 pFS->singleElement( FSNS( XML_c, XML_overlap ),
-XML_val, IS( nOverlap ),
+XML_val, I32S( nOverlap ),
 FSEND );
 }
 }
@@ -1649,7 +1649,7 @@ void ChartExport::exportDoughnutChart( const Reference< 
chart2::XChartType >& xC
 //FIXME: holeSize
 sal_Int32 nHoleSize = 50;
 pFS->singleElement( FSNS( XML_c, XML_holeSize ),
-XML_val, IS( nHoleSize ),
+XML_val, I32S( nHoleSize ),
 FSEND );
 
 pFS->endElement( FSNS( XML_c, XML_doughnutChart ) );
@@ -1901,7 +1901,7 @@ void ChartExport::exportUpDownBars( const Reference< 
chart2::XChartType >& xChar
 // TODO: gapWidth
 sal_Int32 nGapWidth = 150;
 pFS->singleElement( FSNS( XML_c, XML_gapWidth ),
-XML_val, IS( nGapWidth ),
+XML_val, I32S( nGapWidth ),
 FSEND );
 
 Reference< beans::XPropertySet > xChartPropSet = 
xChartPropProvider->getUpBar();
@@ -2056,10 +2056,10 @@ void ChartExport::exportSeries( const 
Reference& xChartType,
 
 // TODO: idx and order
 pFS->singleElement( FSNS( XML_c, XML_idx ),
-XML_val, IS(mnSeriesCount),
+XML_val, I32S(mnSeriesCount),
 FSEND );
 pFS->singleElement( FSNS( XML_c, XML_order ),
-XML_val, IS(mnSeriesCount++),
+XML_val, I32S(mnSeriesCount++),
 FSEND );
 
 // export label
@@ -2106,7 +2106,7 @@ void ChartExport::exportSeries( const 
Reference& xChartType,
 sal_Int32 nOffset = 0;
  

[Libreoffice-bugs] [Bug 106474] Paste into Calc Spreadsheet gives AppHang

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106474

--- Comment #4 from brodders  ---
I found my very own version of this... and didn't wait a couple of days to find
out if paste worked.

Will say Yes, this is the bug.

Seen this in LO / OO since 2010 in various forms (takes ages to paste)

:)
brodders

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: bitmap resources are disconnected from .src/.res now

[Chris Sherlock]

> On 27 Apr 2017, at 11:40 pm, Caolán McNamara  wrote:
> 
> tl;dr: To use a theme png in C++, add #define NAME "path/to/png" to a
> .hlst and use BitmapEx foo(NAME)

Brilliant news, that really is great work Caolon! 

Chris
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 105942] Hang when trying to save with password protection a .docx which contains an image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105942

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105942] Hang when trying to save with password protection a .docx which contains an image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105942

--- Comment #6 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f8fdc6417b4d023b7c75485754a0ab1b164a69d6

tdf#105942 Don't hang when file is protected and compressed

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Google Summer of Code 2017 - Some help needed

[Till Kamppeter]

Hi,

as Caolán McNamara told me after presenting my problem on the 
#libreoffice-dev channel on FreeNode (see log below) I am posting it here:


I am Till Kamppeter, leader of the OpenPrinting project and I am also 
the packager of the printing stack in Ubuntu.


In the Google Summer of Code 2017 a big project of OpenPrinting will be 
work on the print dialog. What we especially want to do is:


- Common backends to all print dialogs (GTK, Qt, LibreOffice, ...):
   - Backend for local CUPS queues
   - Backend for IPP network printers
   - Backend for Google Cloud Print printers
   - In the future: Backends for new, upcoming print technologies (for
 example a cloud printing service based on PWG standards.
- Create a decent, feature-complete Qt print dialog which supports
  above-mentioned backends, for Qt upstream.
- Create patches for the current GTK print dialog to take the new
  backends, so that distros do not have to wait for these backends
  until the new GTK dialog gets released in 2 years.
- Create patches for the LibreOffice print dialog to take trhe new
  backends.

This way we want to assure that users get access to all printers and all 
print options from any desktop application, and that also if current 
print technologies (like CUPS) get changes or if new technologies will 
appear in the future. In such a case one only would need to modify or 
add a backend.


All this is meant to be contributed to the appropriate upstream projects 
so that all Linux distributions will get improved by this.


I will mentor a student who will patch the LibreOffice print dialog to 
take the backends. This will not change the appearance and GUI of the 
dialog, but only the method to obtain printer and options lists and to 
send off print jobs.


As talked about on the IRC LO allows also switching to the GTK dialog 
and there will also be a new GTK dialog which will get launched in 
around two years.


The backend idea comes already from the new GTK dialog and we want to 
get it to life as soon as possible.


It is told that it is difficult to do Spreadsheet printing with the 
usual print dialogs and therefore it could be better for LO to stay with 
its own dialog.


So what I would like to know is the following:

- Would it be a good idea to modify the inner workings (not the GUI) of 
the LibreOffice print dialog to talk to the printing 
system(s)/printer(s) through a modular backend so that easily new peint 
technologies can be added or changes for the existing ones being supplied?


- Or is it no problem for Spreadsheet printing to use the current and/or 
the future GTK print dialog so that it is a better approach to let LO 
default to the GTK dialog?


- Would someone of you help me to mentor the student who will modify the 
LO dialog and also help me and the student to get started with 
contributing to LO?


Thanks a lot already in advance.

   Till

--



 Hi, I am Till Kamppeter from OpenPrinting (also Ubuntu 
packager for printing stack).

* JohnW71 has quit (Quit: Leaving)
 I am doing a project of improving the print dialogs in this 
year's Google Summer of Code.
 LibreOffice (core) Thorsten.Behrens * sw/source/core/undo/ 
(unattr.cxx unfmco.cxx): tdf#88555: band-aid fix, using GetPos/find 
instead of Contains
 The intention is to have common backends for all dialogs 
(GTK, Qt, LibreOffice), one for CUPS queues, one for IPP printers, one 
for Google Cloud Print ...
 This way one can easily apply changes in CUPS or add new print 
technologies and services.
 One student is supposed to do the needed modifications on LO's print 
dialog.
 I would need someone who helps me mentoring him and to help to get the 
result upstream into LO.

 tkamppeter: who's gsoc project is that ?
 The mentoring org is the Linux Foundation where 
OpenPrinting is a part of. I am org admin for the LF.
 And the main part of OpenPrinting's GSoC activity this year is the 
work on the print dialogs, we have 6 students on that.
 tkamppeter: FWIW, if you use tools->options->advanced and 
toggle on "experimental features", then tools options->general will 
offer the option to turn off "use LibreOffice Dialog" for printing, in 
which case the gtk print dialog will stumble to life
 there was a time when I wrote some class of a "if the gtk 
dialog had this that and this" it would make life a lot easier to use, 
then there was talk of a new gtk print dialog and then it never happened
 Yes, I know this tric, and probably it can turn standard 
when GTK's new dialog comes to life.
 anyhow, late here. I suggest mailing our dev list and I can try 
and dig out what I wrote the last time
 GTK/GNOME is working on a new dialog currently, landing in 
more or less two years.
 erAck: oy... it's a regression from some alg commits where he 
hooked up the application undo managers in 
SdrObjEditView::SdrBeginTextEdit() ... this looks quite scary, calc has 
it implemented too apparently

 yeah, well, hmm, two year eh?
 This new dialog has a 

[Libreoffice-commits] core.git: package/source

[Xisco Fauli]

 package/source/zippackage/ZipPackageStream.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f8fdc6417b4d023b7c75485754a0ab1b164a69d6
Author: Xisco Fauli 
Date:   Wed Apr 19 11:38:59 2017 +0200

tdf#105942 Don't hang when file is protected and compressed

Change-Id: I762e6e6d457ea3f5a1f1fd706268b832a71ee550
Reviewed-on: https://gerrit.libreoffice.org/36672
Tested-by: Jenkins 
Reviewed-by: Xisco Faulí 

diff --git a/package/source/zippackage/ZipPackageStream.cxx 
b/package/source/zippackage/ZipPackageStream.cxx
index 15477a3a2099..14637f9f18ca 100644
--- a/package/source/zippackage/ZipPackageStream.cxx
+++ b/package/source/zippackage/ZipPackageStream.cxx
@@ -784,7 +784,7 @@ bool ZipPackageStream::saveChild(
 uno::Reference< io::XSeekable > xSeek(xStream, uno::UNO_QUERY);
 // It's not worth to deflate jpegs to save ~1% in a slow process
 // Unfortunately, does not work for streams protected by password
-if (xSeek.is() && msMediaType.endsWith("/jpeg") && !m_bToBeEncrypted)
+if (xSeek.is() && msMediaType.endsWith("/jpeg") && !m_bToBeEncrypted 
&& !m_bToBeCompressed)
 {
 ImplSetStoredData(*pTempEntry, xStream);
 xSeek->seek(0);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105841] "First name" in user data is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105841

V Stuart Foote  changed:

   What|Removed |Added

 CC||sberg...@redhat.com,
   ||t...@iki.fi

--- Comment #3 from V Stuart Foote  ---
@Tor, this is for you to quash or revert... personally I see no reason to
revert status quo to return a split First Last, but guess compliance with an
ODF 1.2 field as Regina points out would be justification.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: i18npool/source

[Eike Rathke]

 i18npool/source/localedata/data/sort-formats-by-formatindex.awk |   82 
++
 1 file changed, 82 insertions(+)

New commits:
commit fcd0ee644de8e96a350e5d37030875df651dfdc9
Author: Eike Rathke 
Date:   Thu Apr 27 23:33:06 2017 +0200

Sort FormatElement and their children by formatindex value

Change-Id: Ifa5b4a74de864b2eea982a166f90095344f812ea

diff --git a/i18npool/source/localedata/data/sort-formats-by-formatindex.awk 
b/i18npool/source/localedata/data/sort-formats-by-formatindex.awk
new file mode 100755
index ..ffd84e4d517e
--- /dev/null
+++ b/i18npool/source/localedata/data/sort-formats-by-formatindex.awk
@@ -0,0 +1,82 @@
+#!/usr/bin/gawk -f
+# -*- Mode: awk; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+# Usage: gawk -f sort-formats-by-formatindex.awk ll_CC.xml
+#
+# Sort the LC_FORMAT child elements FormatElement and their children by
+# formatindex="..." value for easier comparison between locales.
+# Output goes to stdout.
+
+BEGIN {
+file = ""
+}
+
+file != FILENAME {
+file = FILENAME
+informats = 0
+currformat = 0
+delete formats
+}
+
+/]/ {
+if (!/\/>/)
+informats = 1
+print
+next
+}
+
+informats && /<\/LC_FORMAT>/ {
+PROCINFO["sorted_in"] = "@ind_num_asc"
+for (f in formats)
+{
+if (isarray(formats[f]))
+{
+for (i in formats[f])
+print formats[f][i]
+}
+else
+{
+# Something unhandled, adapt code.
+print "XXX error: " formats[f]
+}
+}
+informats = 0
+}
+
+{
+if (!informats)
+{
+print
+next
+}
+}
+
+/]/ {
+print
+next
+}
+
+# Associate any element or comment with the current FormatElement.
+{
+formats[currformat][++child] = $0
+}
+
+END {
+}
+
+# vim:set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Windows Metafile) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103859
Bug 103859 depends on bug 102321, which changed state.

Bug 102321 Summary: [FILEOPEN] Rectangle shown instead of EMF+image
https://bugs.documentfoundation.org/show_bug.cgi?id=102321

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107495] New: UX: An explicitly enabled frame/ table toolbar is always closing after existing a table/frame

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107495

Bug ID: 107495
   Summary: UX: An explicitly enabled frame/table toolbar is
always closing after existing a table/frame
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
The table toolbar can be accessed by creating a table (context dependent) and
by enabling the toolbar in Menu -> View -> Table. I personally prefer a steady
toolbar, instead of which switches on and off. However the explicitly enabled
table toolbar will still automatically close after exiting a table.

There is no solution for this. I can create a new toolbar with the same table
functionality which stay's behind, but I can't delete the table toolbar
completely.

The frame toolbar behaves the same way

Steps to Reproduce:
1. Open a Writer document
2. Enable table toolbar: View -> Toolbar -> Table
3. Add a table (CTRL+F12)
4. Click below the table -> Toolbar disappears


Actual Results:  
The table toolbar is context depend even when it's explicitly enabled

Expected Results:
If the table toolbar is explicitly enabled, it should stay enabled


Reproducible: Always

User Profile Reset: No

Additional Info:
Found in:
Version: 5.4.0.0.alpha0+
Build ID: 597a2f5d5bd37443262b0775b8439bc3502aef1b
CPU threads: 4; OS: Windows 6.2; UI render: default; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-04-26_22:29:37
Locale: nl-NL (nl_NL); Calc: CL

and in
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4


User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101
Firefox/45.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95941] Writer crashes while deleting paragraphs spanning over multiple pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95941

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #7 from Xisco Faulí  ---
(In reply to Michael Stahl from comment #6)
> on Linux, i fail to reproduce any crash when deleting stuff
> at random from the document.
> 
> this is on current master with bugs from comment #4 and comment #5 fixed.
> 
> it's quite likely that the crash here was the same as comment #4 / bug
> 107398,
> as that was caused by deleting something and then repagination
> creating an invalid empty footnote container frame.
> 
> the crash in comment #3 also could be caused by that.
> 
> so i guess unless somebody comes up with reproduction steps for a
> crash on current master (or 5.3 once fixes are backported) we can close this.

I agree with you.
Let's close it as RESOLVED WORKSFORME for the time being.
Please, feel free to reopen it if you can still reproduce the crash with daily
builds created from today on.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107494] CRASH: LibreOffice crashes while deleting the header containing an image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107494

--- Comment #2 from Xisco Faulí  ---
I can reproduce it back to 5f658dc87794036182aa1f8586d82c5ee997cd8b but I'm not
sure whether this commit introduced the crash or not

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107494] CRASH: LibreOffice crashes while deleting the header containing an image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107494

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
I can't reproduce it in debug mode neither

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106902] Decimal separator should be a point and not a comma in Spanish ( El Salvador) locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106902

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
   Hardware|x86-64 (AMD64)  |All
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |
 OS|Linux (All) |All

--- Comment #4 from Eike Rathke  ---
Pending review https://gerrit.libreoffice.org/37044 for 5-3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107033] After import of docx the length of Footnote Separator Line is 0%

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107033

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107494] New: CRASH: LibreOffice crashes while deleting the header containing an image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107494

Bug ID: 107494
   Summary: CRASH: LibreOffice crashes while deleting the header
containing an image
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps to reproduce:
1. Open a new writer document
2. Insert a header
3. Insert an image to the header
4. Delete the header

CRASH!

Surprisingly it doesn't crash with official releases for me...

Reproduced in

Version: 5.4.0.0.alpha0+
Build ID: 7c11fe076005ed4e28f04f14990b7011a03a4517
CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107464] Crash when spell checking text in draw objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107464

--- Comment #11 from Regina Henschel  ---
@Xisco: I use the build from
http://dev-builds.libreoffice.org/daily/master/Win-x86@62-TDF/ including the
en-US and de helppack. I see neither ca nor en-GB dictionary in that build. Do
you have an own build? If yes, please try one from TDF.

I use the 32-bit version. You too?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sc/source

[Caolán McNamara]

 sc/source/ui/formdlg/dwfunctr.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit f7f57148258ef407caa3ac81c108f6076caf9b2d
Author: Caolán McNamara 
Date:   Thu Apr 27 15:55:40 2017 +0100

Resolves: tdf#107241 don't let floating function description grow infinitely

Change-Id: Ief87c15c637d725d25416b64739fb3f5f07cded4
(cherry picked from commit e33447a24c6800bbd34ea1463ee823737bf555cd)
Reviewed-on: https://gerrit.libreoffice.org/37036
Reviewed-by: Eike Rathke 
Tested-by: Jenkins 

diff --git a/sc/source/ui/formdlg/dwfunctr.cxx 
b/sc/source/ui/formdlg/dwfunctr.cxx
index 51ddbff61f48..25d2814ed66c 100644
--- a/sc/source/ui/formdlg/dwfunctr.cxx
+++ b/sc/source/ui/formdlg/dwfunctr.cxx
@@ -58,6 +58,7 @@ ScFunctionWin::ScFunctionWin(vcl::Window* pParent, const 
css::uno::Referenceset_height_request(10 * aFuncList->GetTextHeight());
 get(aInsertButton, "insert");
 get(aFiFuncDesc, "funcdesc");
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106902] Decimal separator should be a point and not a comma in Spanish ( El Salvador) locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106902

--- Comment #3 from Commit Notification 
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4b605466a2304efd2b247595fe74ddf7c6d5a77d

Resolves: tdf#106902 swap [es-SV] decimal and group separator

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106902] Decimal separator should be a point and not a comma in Spanish ( El Salvador) locale

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106902

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107464] Crash when spell checking text in draw objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107464

--- Comment #10 from Xisco Faulí  ---
I can't reproduce it with the attached document neither.
I use es, ca and en-GB as built languages

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107473] multi-tabs dialogs don't show selectede highlighted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107473

Paolo Benvenuto  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107473] multi-tabs dialogs don't show selectede highlighted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107473

--- Comment #2 from Paolo Benvenuto  ---
Created attachment 132921
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132921=edit
requested screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107473] multi-tabs dialogs don't show selectede highlighted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107473

--- Comment #3 from Paolo Benvenuto  ---
xubuntu linux

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: i18npool/source

[Eike Rathke]

 i18npool/source/localedata/data/es_SV.xml |  170 +-
 1 file changed, 168 insertions(+), 2 deletions(-)

New commits:
commit 4b605466a2304efd2b247595fe74ddf7c6d5a77d
Author: Eike Rathke 
Date:   Thu Apr 27 22:42:11 2017 +0200

Resolves: tdf#106902 swap [es-SV] decimal and group separator

Made copying and adjusting LC_FORMAT and child elements from es-BO 
necessary,
some difference was in all existing es_* codes so no ref=... possible.

Change-Id: I114bed5348ebcaa646a749753cb542752aff58f0

diff --git a/i18npool/source/localedata/data/es_SV.xml 
b/i18npool/source/localedata/data/es_SV.xml
index 232684d00820..472e754cf007 100644
--- a/i18npool/source/localedata/data/es_SV.xml
+++ b/i18npool/source/localedata/data/es_SV.xml
@@ -28,8 +28,174 @@
   El Salvador
 
   
-  
-  
+  
+
+  /
+  ,
+  .
+  :
+  .
+  ;
+   
+   de 
+   de 
+   
+
+
+  ‘
+  ’
+  “
+  ”
+
+AM
+PM
+metric
+  
+  
+D/M
+
+  Estandar
+
+
+  0
+
+
+  0.00
+
+
+  #,##0
+
+
+  #,##0.00
+
+
+  #,###.00
+
+
+  0.00E+000
+
+
+  0.00E+00
+
+
+  ##0.00E+00
+
+
+  0" "%
+
+
+  0.00" "%
+
+
+  [CURRENCY] #,##0.00;-[CURRENCY] #,##0.00
+
+
+  [CURRENCY] #,##0.00;-[CURRENCY] #,##0.00
+
+
+  [CURRENCY] #,##0.00;[RED]-[CURRENCY] #,##0.00
+
+
+  [CURRENCY] #,##0.00;[RED]-[CURRENCY] #,##0.00
+
+
+  #,##0.00 CCC
+
+
+  [CURRENCY] #,##0.--;[RED]-[CURRENCY] #,##0.--
+
+
+  D/MM/AA
+
+
+  D "de"  "de" 
+
+
+  DD/MM/AA
+
+
+  DD/MM/
+
+
+  D "de" MMM "de" AA
+
+
+  D "de" MMM "de" 
+
+
+  D. MMM. 
+
+
+  D "de"  "de" 
+
+
+  D.  
+
+
+  NN D "de" MMM "de" AA
+
+
+  NN DD/MMM AA
+
+
+  NN D "de"  "de" 
+
+
+  D "de"  "de" 
+
+
+  MM-DD
+
+
+  AA-MM-DD
+
+
+  -MM-DD
+  ISO 8601
+
+
+  MM/AA
+
+
+  DD/MMM
+
+
+  
+
+
+  QQ AA
+
+
+  WW
+
+
+  HH:MM
+
+
+  HH:MM:SS
+
+
+  HH:MM AM/PM
+
+
+  HH:MM:SS AM/PM
+
+
+  [HH]:MM:SS
+
+
+  MM:SS.00
+
+
+  [HH]:MM:SS.00
+
+
+  DD/MM/AA HH:MM
+
+
+  DD/MM/ HH:MM:SS
+
+  
   
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107298] Snap option "When creating or moving objects" is mis-labeled in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107298

--- Comment #5 from Mike  ---
I honestly can't believe what I'm reading. And your analogy makes no sense. Let
me ask you two questions:

(1) When you want a rectangle but you get a square, and then you look for the
option to turn that feature off, please tell me what WORDS you would be looking
for among the Options. What words do you associate with that behavior?

(2) How do you do define snapping? I define it as forcing a point or line to
some other place. When this "snap" option is enabled, _nothing_ is forced
anywhere. How does that linguistically make sense to you?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107492] : OutOfBound error when cells are deleted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107492

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 CC||markus.mohrhard@googlemail.
   ||com,
   ||xiscofa...@libreoffice.org
Version|5.3.2.2 release |5.3.0.0.alpha0+
 Ever confirmed|0   |1
 OS|Windows (All)   |All

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Markus Mohrhard 2016-09-30
23:31:09 (GMT)
committer   Markus Mohrhard    
2016-10-01 02:06:23 (GMT)
commit  5f658dc87794036182aa1f8586d82c5ee997cd8b (patch)
tree163168c022de64266238818c339f9d3e96ceea57
parent  cf4ff92144726a91508fcaf4be21170eac5cb99a (diff)
tdf#101910, mark ScRangeList updated when DeleteArea was used

Bisected with bibisect-linux-64-5.3

Adding Cc: to Markus Mohrhard

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #17 from Commit Notification 
 ---
Thorsten Behrens committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1df637bde32c484b681ecdfebf56fdca03db7fc1

tdf#88555: band-aid fix, using GetPos/find instead of Contains

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103885] Particular OGG video can't be played in GTK2/GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103885

Yousuf Philips (jay)  changed:

   What|Removed |Added

Summary|Ogg video can't be played   |Particular OGG video can't
   |in GTK2/GTK3|be played in GTK2/GTK3

--- Comment #4 from Yousuf Philips (jay)  ---
So i tested the file in VLC and Totem and it played fine. So there must be some
issue with that particular ogg video file as the ogg video file i converted
with ffmpeg for testing all codecs on various OSes works fine.

https://drive.google.com/open?id=0B6qJrVIa0SAldE0tZG81UHFsWVk

https://wiki.documentfoundation.org/Media_Support/Linux/Video_Tests#Video:_4.3.5-ubuntu

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105841] "First name" in user data is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105841

Regina Henschel  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|RESOLVED|UNCONFIRMED
 CC||rb.hensc...@t-online.de
 Resolution|NOTABUG |---

--- Comment #2 from Regina Henschel  ---
I reopen it, because I thing removing the "first name" field is an error.

There is a further complain on the German Ask site, read
https://ask.libreoffice.org/de/question/93363/5303-benutzerdaten-wieder-umstellen-auf-vor-und-nachname/.
The version 5.3 is still "fresh" and likely not often used enterprises. I fear,
that there will be more complains, when the 5.3 versions comes to enterprises. 

There are further problems in addition:

Removing the field from UI does not erases it from file format. The  associated
element  exists in ODF (see
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#element-text_sender-firstname).
It is against interoperability to leave it empty and merge this information
into another field.

The service com::sun::star::text::textfield::ExtendedUser has a constant group
com::sun::star::text::UserDataPart with value FIRSTNAME. It is published API
and should not be changed. Existing macros might not work as intended, if the
content of this field is empty.

The variable user_firstname can be used in conditions to hide parts of the
text. Such documents no longer work.


I cannot find a request to remove the field or a discussion about the topic. I
personally see no considerable reason to remove the "first name" field. I
therefore set keyword needsUXEval.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Thorsten Behrens]

 sw/source/core/undo/unattr.cxx |   22 +++---
 sw/source/core/undo/unfmco.cxx |2 +-
 2 files changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 1df637bde32c484b681ecdfebf56fdca03db7fc1
Author: Thorsten Behrens 
Date:   Thu Apr 27 18:07:54 2017 +0200

tdf#88555: band-aid fix, using GetPos/find instead of Contains

to find out whether given format still exists.

GetPos was replaced by Contains on multiple places in commit
98436c4b53639d86f261ac630c46d32e3c7b8e28 but sometimes after
series of undos/redos, vtable of some items in those format arrays
becomes corrupt and it makes dynamic_cast (as used by Contains)
fail and Writer falls flat on its face.

This is just a workaround, no idea about the root cause.

Change-Id: I1e02fd932dbac741687c15900841b9b7c778e2d4
Reviewed-on: https://gerrit.libreoffice.org/37038
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/sw/source/core/undo/unattr.cxx b/sw/source/core/undo/unattr.cxx
index d97b3953ced9..9805ed309dd9 100644
--- a/sw/source/core/undo/unattr.cxx
+++ b/sw/source/core/undo/unattr.cxx
@@ -200,21 +200,21 @@ bool SwUndoFormatAttr::IsFormatInDoc( SwDoc* pDoc )
 {
 // search for the Format in the Document; if it does not exist any more,
 // the attribute is not restored!
-bool bFound = false;
+size_t nPos = SIZE_MAX;
 switch ( m_nFormatWhich )
 {
 case RES_TXTFMTCOLL:
 case RES_CONDTXTFMTCOLL:
-bFound = pDoc->GetTextFormatColls()->Contains( m_pFormat );
+nPos = pDoc->GetTextFormatColls()->GetPos( m_pFormat );
 break;
 
 case RES_GRFFMTCOLL:
-bFound = pDoc->GetGrfFormatColls()->Contains(
+nPos = pDoc->GetGrfFormatColls()->GetPos(
 static_cast(m_pFormat) );
 break;
 
 case RES_CHRFMT:
-bFound = pDoc->GetCharFormats()->Contains( m_pFormat );
+nPos = pDoc->GetCharFormats()->GetPos( m_pFormat );
 break;
 
 case RES_FRMFMT:
@@ -225,14 +225,14 @@ bool SwUndoFormatAttr::IsFormatInDoc( SwDoc* pDoc )
 {
 m_pFormat =
 
static_cast(pNd)->GetTable().GetFrameFormat();
-bFound = true;
+nPos = 0;
 break;
 }
 else if ( pNd->IsSectionNode() )
 {
 m_pFormat =
 
static_cast(pNd)->GetSection().GetFormat();
-bFound = true;
+nPos = 0;
 break;
 }
 else if ( pNd->IsStartNode() && (SwTableBoxStartNode ==
@@ -246,7 +246,7 @@ bool SwUndoFormatAttr::IsFormatInDoc( SwDoc* pDoc )
 if ( pBox )
 {
 m_pFormat = pBox->GetFrameFormat();
-bFound = true;
+nPos = 0;
 break;
 }
 }
@@ -255,13 +255,13 @@ bool SwUndoFormatAttr::IsFormatInDoc( SwDoc* pDoc )
 SAL_FALLTHROUGH;
 case RES_DRAWFRMFMT:
 case RES_FLYFRMFMT:
-if (pDoc->GetSpzFrameFormats()->Contains( m_pFormat )
-|| pDoc->GetFrameFormats()->Contains( m_pFormat ))
-bFound = true;
+if ( ( pDoc->GetSpzFrameFormats()->find( 
static_cast(m_pFormat) ) != pDoc->GetSpzFrameFormats()->end() )
+|| ( pDoc->GetFrameFormats()->find( 
static_cast( m_pFormat ) ) != pDoc->GetFrameFormats()->end() ) )
+nPos = 0;
 break;
 }
 
-if ( !bFound )
+if ( nPos == SIZE_MAX )
 {
 // Format does not exist; reset
 m_pFormat = nullptr;
diff --git a/sw/source/core/undo/unfmco.cxx b/sw/source/core/undo/unfmco.cxx
index bc506d79c794..aa55ba045ca0 100644
--- a/sw/source/core/undo/unfmco.cxx
+++ b/sw/source/core/undo/unfmco.cxx
@@ -73,7 +73,7 @@ void SwUndoFormatColl::DoSetFormatColl(SwDoc & rDoc, SwPaM & 
rPaM)
 // this array.
 
 // does the format still exist?
-if( 
rDoc.GetTextFormatColls()->Contains(static_cast(pFormatColl))
 )
+if( SIZE_MAX != 
rDoc.GetTextFormatColls()->GetPos(static_cast(pFormatColl)) )
 {
 rDoc.SetTextFormatColl(rPaM, 
static_cast(pFormatColl), mbReset,
mbResetListAttrs);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107298] Snap option "When creating or moving objects" is mis-labeled in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107298

--- Comment #4 from Heiko Tietze  ---
Cannot imagine a user who misunderstands this text. Wouldn't "When rotating" in
the same dialog means that the sun revolves around the earth, following this
reasoning? However, despite the "What's this" feature (which isn't working in
the options dialog) a tooltip could help to clarify the text at many occasions.
Adds a lot of work for the l10n team, though.

Voting for WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39468] translate German comments, removing redundant ones

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39468

--- Comment #288 from Commit Notification 
 ---
dennisroczek committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=91a1342aa2930268006614680ec439c6ebecdedb

tdf#39468 cleanup source code comments

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: comphelper/source connectivity/source cppuhelper/source sfx2/source svtools/source svx/source sw/source ucb/source vcl/source

[dennisroczek]

 comphelper/source/property/opropertybag.cxx  |3 -
 connectivity/source/commontools/parameters.cxx   |5 +-
 connectivity/source/drivers/mysql/YCatalog.cxx   |1 
 connectivity/source/parse/sqliterator.cxx|   23 ++---
 cppuhelper/source/factory.cxx|3 -
 sfx2/source/appl/app.cxx |3 -
 svtools/source/uno/genericunodialog.cxx  |5 +-
 svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx |   26 ---
 sw/source/core/doc/DocumentDeviceManager.cxx |3 -
 ucb/source/ucp/tdoc/tdoc_docmgr.cxx  |   18 ++
 vcl/source/control/group.cxx |3 -
 11 files changed, 32 insertions(+), 61 deletions(-)

New commits:
commit 91a1342aa2930268006614680ec439c6ebecdedb
Author: dennisroczek 
Date:   Sat Apr 1 15:26:28 2017 +

tdf#39468 cleanup source code comments

* translate German source code comments
* remove ascii art
* remove bogus source Code comments
* remove old StarOffice/Sun internal bug tracker references

Change-Id: I443bf2fdba3780c411d69809111daf3aa3a48451
Reviewed-on: https://gerrit.libreoffice.org/36005
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/comphelper/source/property/opropertybag.cxx 
b/comphelper/source/property/opropertybag.cxx
index a2e4abdc7a14..4fbdb8bfe96e 100644
--- a/comphelper/source/property/opropertybag.cxx
+++ b/comphelper/source/property/opropertybag.cxx
@@ -524,8 +524,7 @@ namespace comphelper
 // (Note that this probably would belong into the base class. However, 
this would mean we would need
 // to check all existent usages of the base class, where MAYBEDEFAULT 
is *not* set, but
 // a default is nonetheless supplied/used. This is hard to accomplish 
reliably, in the
-// current phase.
-// #i78593# / 2007-07-07 / frank.schoenh...@sun.com
+// current phase. #i78593#
 
 ::cppu::IPropertyArrayHelper& rPropInfo = getInfoHelper();
 sal_Int16 nAttributes(0);
diff --git a/connectivity/source/commontools/parameters.cxx 
b/connectivity/source/commontools/parameters.cxx
index 70e1883ff41f..4f0caca3b4de 100644
--- a/connectivity/source/commontools/parameters.cxx
+++ b/connectivity/source/commontools/parameters.cxx
@@ -265,9 +265,8 @@ namespace dbtools
 if ( pMasterFields->isEmpty() || pDetailFields->isEmpty() )
 continue;
 
-// if not even the master part of the relationship exists in the 
parent , the
-// link is invalid as a whole
-// #i63674# / 2006-03-28 / frank.schoenh...@sun.com
+// if not even the master part of the relationship exists in the 
parent, the
+// link is invalid as a whole #i63674#
 if ( !_rxParentColumns->hasByName( *pMasterFields ) )
 {
 bNeedExchangeLinks = true;
diff --git a/connectivity/source/drivers/mysql/YCatalog.cxx 
b/connectivity/source/drivers/mysql/YCatalog.cxx
index 38f0b24e211b..eb755309fd41 100644
--- a/connectivity/source/drivers/mysql/YCatalog.cxx
+++ b/connectivity/source/drivers/mysql/YCatalog.cxx
@@ -74,7 +74,6 @@ void OMySQLCatalog::refreshViews()
 // let's simply assume the server is new enough to support views. Current 
drivers
 // as of this writing might not return the proper information in 
getTableTypes, so
 // don't rely on it.
-// during #73245# / 2007-10-26 / frank.schoenh...@sun.com
 bool bSupportsViews = true;
 
 TStringVector aVector;
diff --git a/connectivity/source/parse/sqliterator.cxx 
b/connectivity/source/parse/sqliterator.cxx
index 341c30c26298..959e0ca4733b 100644
--- a/connectivity/source/parse/sqliterator.cxx
+++ b/connectivity/source/parse/sqliterator.cxx
@@ -334,8 +334,7 @@ void OSQLParseTreeIterator::impl_getQueryParameterColumns( 
const OSQLTable& _rQu
 
 OSQLParseTreeIterator aSubQueryIterator( *this, m_rParser, 
pSubQueryNode.get() );
 aSubQueryIterator.impl_traverse( TraversalParts::Parameters | 
TraversalParts::SelectColumns );
-// SelectColumns might also contain parameters
-// #i77635# - 2007-07-23 / frank.schoenh...@sun.com
+// SelectColumns might also contain parameters #i77635#
 pSubQueryParameterColumns = aSubQueryIterator.getParameters();
 aSubQueryIterator.dispose();
 
@@ -574,13 +573,13 @@ const OSQLParseNode* OSQLParseTreeIterator::getTableNode( 
OSQLTables& _rTables,
 if ( SQL_ISRULE( pQueryExpression, select_statement ) )
 {
 getSelect_statement( *m_pImpl->m_pSubTables, 
pQueryExpression );
-// LEM TODO: now, we need to setup a OSQLTable from 
pQueryExpression in some way
-  

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sc/source

[Eike Rathke]

 sc/source/ui/view/viewfun4.cxx |   12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

New commits:
commit ac15df592ea7acac7399c99f64539cab556d2fab
Author: Eike Rathke 
Date:   Wed Apr 19 11:14:42 2017 +0200

Resolves: tdf#102525 handle array/matrix formula in cycle cell reference 
types

(cherry picked from commit 6c73ca4671958cb066beecade5661e124c497e25)

 Conflicts:
sc/source/ui/view/viewfun4.cxx

keep the leading '=' equal character, tdf#102525 follow-up

So to feed it to the compiler again in case it's a "==" force-always 
formula,
which theoretically would also be valid in matrix mode.

(cherry picked from commit c15f497b9a3463c7eeca1e8cc2c6f46ca293b9af)

e694e12a3bc4581469b7ad9cc06a2a664d6f

Change-Id: Ib2443d5bda0c9b1268835f08e4931d5dec2d7f1b
Reviewed-on: https://gerrit.libreoffice.org/36669
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/ui/view/viewfun4.cxx b/sc/source/ui/view/viewfun4.cxx
index 614e2d98caba..c8ff808cc534 100644
--- a/sc/source/ui/view/viewfun4.cxx
+++ b/sc/source/ui/view/viewfun4.cxx
@@ -248,9 +248,19 @@ void ScViewFunc::DoRefConversion()
 continue;
 
 ScFormulaCell* pCell = aIter.getFormulaCell();
+sal_uInt8 eMatrixMode = pCell->GetMatrixFlag();
+if (eMatrixMode == MM_REFERENCE)
+continue;
+
 OUString aOld;
 pCell->GetFormula(aOld);
 sal_Int32 nLen = aOld.getLength();
+if (eMatrixMode == MM_FORMULA)
+{
+assert(nLen >= 2 && aOld[0] == '{' && aOld[nLen-1] == '}');
+nLen -= 2;
+aOld = aOld.copy( 1, nLen);
+}
 ScRefFinder aFinder( aOld, aIter.GetPos(), pDoc, 
pDoc->GetAddressConvention() );
 aFinder.ToggleRel( 0, nLen );
 if (aFinder.GetFound())
@@ -262,7 +272,7 @@ void ScViewFunc::DoRefConversion()
 std::unique_ptr 
pArr(aComp.CompileString(aNew));
 ScFormulaCell* pNewCell =
 new ScFormulaCell(
-pDoc, aPos, *pArr, 
formula::FormulaGrammar::GRAM_DEFAULT, MM_NONE);
+pDoc, aPos, *pArr, 
formula::FormulaGrammar::GRAM_DEFAULT, eMatrixMode);
 
 pDoc->SetFormulaCell(aPos, pNewCell);
 bOk = true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/source

[Michael Stahl]

 sw/source/core/layout/flowfrm.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 27bbee974eaf59f722c115c9717faa8c74b9d815
Author: Michael Stahl 
Date:   Wed Apr 26 17:10:09 2017 +0200

tdf#107398 sw: do not leave empty footnote container in layout

... when applying loop control in SwFlowFrame::MoveBwd().

The SwFootnoteContFrame is newly created in MoveBwd(), line 2062:
pNewUpper = m_rThis.GetLeaf( MAKEPAGE_FTN, false );

If it stays empty, that is not a valid layout so delete it again.

Since the idle/timer refactoring in VCL the invalid layout stays
until the document is closed; presumably before LO 5.0 the timer
based layout would reformat things again.

(regression from af41b7f91f22052d49654d41ae9916d6981db3f6)

Change-Id: I841f42b465f8123f9246f1fa70d1417ffdd57700
(cherry picked from commit e15b8997f0d2e54fa7b8345063755616d0b100b9)
Reviewed-on: https://gerrit.libreoffice.org/37008
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/core/layout/flowfrm.cxx 
b/sw/source/core/layout/flowfrm.cxx
index 29e1300a4a98..7ab8e85c7119 100644
--- a/sw/source/core/layout/flowfrm.cxx
+++ b/sw/source/core/layout/flowfrm.cxx
@@ -2404,6 +2404,12 @@ bool SwFlowFrame::MoveBwd( bool  )
  ( pNextNewUpper == m_rThis.GetUpper() ||
pNextNewUpper->GetType() != m_rThis.GetUpper()->GetType() ) )
 {
+// tdf#107398 do not leave empty footnote container around
+if (!pNewUpper->Lower() && pNewUpper->IsFootnoteContFrame())
+{
+pNewUpper->Cut();
+SwFrame::DestroyFrame(pNewUpper);
+}
 pNewUpper = nullptr;
 OSL_FAIL( " - layout loop control for 
layout action  applied!" );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/source

[Michael Stahl]

 sw/source/core/crsr/crsrsh.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit adc0b3b214323d7588cadd17f2b4faafeb5e4e80
Author: Michael Stahl 
Date:   Wed Apr 26 14:51:40 2017 +0200

tdf#107427 sw: fix crash when deleting header with selected table

Restore resetting of the table cursor point position in
SwCursorShell::ParkCursor(), which somehow prevents the crash.

(regression from efc5995170f2ffe98374acb16a4f851bede6842d)

Change-Id: Ia7ec2967c84cfcffe1718e9604d6b8506c3839a4
(cherry picked from commit b2fdb61446bc072ae1b6db380a584a87a1173f11)
Reviewed-on: https://gerrit.libreoffice.org/37007
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index 274a501f4856..aa158ceeb1e1 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -2567,6 +2567,8 @@ void SwCursorShell::ParkPams( SwPaM* pDelRg, 
SwShellCursor** ppDelRing )
 }
 else
 {
+pTmpDel->GetPoint()->nContent.Assign(nullptr, 0);
+pTmpDel->GetPoint()->nNode = 0;
 pTmpDel->DeleteMark();
 }
 pTmpDel = nullptr;
@@ -2627,6 +2629,8 @@ void SwCursorShell::ParkCursor( const SwNodeIndex  )
 SwNode* pTableNd = 
pTCursor->GetPoint()->nNode.GetNode().FindTableNode();
 if ( pTableNd )
 {
+pTCursor->GetPoint()->nContent.Assign(nullptr, 0);
+pTCursor->GetPoint()->nNode = 0;
 pTCursor->DeleteMark();
 pSh->m_pCurrentCursor->GetPoint()->nNode = *pTableNd;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/source

[Michael Stahl]

 sw/source/core/access/accframe.cxx |1 +
 sw/source/core/access/accmap.cxx   |5 -
 2 files changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 19850d847745adca4e9a2506673cc104933489dd
Author: Michael Stahl 
Date:   Fri Apr 21 23:50:23 2017 +0200

sw: fix a11y crash on double Dispose

When testing with the bugdoc for tdf#107126, it happend that upon
applying a page style, SwAccessibleContext::Dispose() was called twice,
and that's not supposed to happen (and crashes, too, at least inside
an assertion).

There was an Action that queued up a bunch of events, but the Action did
not complete formatting the document, so right after that during Paint
more formatting happened and then the FireEvents() called Dispose()
and InvalidatePosOrSize() called it again.  Guess we shouldn't generate
events for objects that we know are disposed due to not being visible.

(cherry picked from commit c99f72bebdce6d294eb47e070fa1397a98ba2087)

fix the build
(cherry picked from commit 42b40ede8c496aad1021e68a72523af4f57e89f6)

sw: let's check GetFrame() instead, it's already public
(cherry picked from commit 3b83ef0d24347a39a925996c5d2958fcdc2473d7)

Change-Id: I5a0f04c0f32ee5e949b552f7a373c10ceee5c279
Reviewed-on: https://gerrit.libreoffice.org/37005
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/core/access/accframe.cxx 
b/sw/source/core/access/accframe.cxx
index b4beb8c5d77d..8f8a09953995 100644
--- a/sw/source/core/access/accframe.cxx
+++ b/sw/source/core/access/accframe.cxx
@@ -418,6 +418,7 @@ SwAccessibleFrame::SwAccessibleFrame( const SwRect& 
rVisArea,
 mbIsInPagePreview( bIsPagePreview ),
 bIsAccDocUse( false )
 {
+assert(mpFrame);
 }
 
 SwAccessibleFrame::~SwAccessibleFrame()
diff --git a/sw/source/core/access/accmap.cxx b/sw/source/core/access/accmap.cxx
index 114e7f17b4a8..0faee74144b7 100644
--- a/sw/source/core/access/accmap.cxx
+++ b/sw/source/core/access/accmap.cxx
@@ -2401,7 +2401,10 @@ void SwAccessibleMap::InvalidatePosOrSize( const SwFrame 
*pFrame,
 else
 {
 FireEvents();
-xAccImpl->InvalidatePosOrSize( rOldBox );
+if (xAccImpl->GetFrame()) // not if disposed by FireEvents()
+{
+xAccImpl->InvalidatePosOrSize(rOldBox);
+}
 }
 }
 else if( xParentAccImpl.is() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/source

[Michael Stahl]

 sw/source/core/layout/calcmove.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 0ae68775afc6227afb881e28c1b2045b3030ad53
Author: Michael Stahl 
Date:   Fri Apr 21 22:44:14 2017 +0200

tdf#107126 sw: fix layout crash with section in footnote

SwContentFrame::WouldFit_() contains a hack to temporarily reparent a
SwTextFrame.  In the bugdoc, there is a SwTextFrame below a
SwSectionFrame below a SwFootnoteFrame.  The reparenting ignores the
SwSectionFrame so the result is a SwTextFrame below SwFootnoteFrame, but
it still has its mbInfSct set, hence crashes with a null pointer.

If the SwTextFrame is permanently moved later on, in
SwFlowFrame::MoveBwd() line 2450 a new SwSectionFrame is created.

Change-Id: I45a7ab793b4459e551bd11b7fb83dedc58a6c8da
(cherry picked from commit 4d43f9e9dda5edeeb6e4b99487b5b6a1fae4bd56)
Reviewed-on: https://gerrit.libreoffice.org/37004
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/core/layout/calcmove.cxx 
b/sw/source/core/layout/calcmove.cxx
index c7ebf84ae900..baa4e0577190 100644
--- a/sw/source/core/layout/calcmove.cxx
+++ b/sw/source/core/layout/calcmove.cxx
@@ -1868,6 +1868,11 @@ bool SwContentFrame::WouldFit_( SwTwips nSpace,
 SwFrame *pOldNext = pTmpFrame->GetNext();
 pTmpFrame->RemoveFromLayout();
 pTmpFrame->InsertBefore( pNewUpper, nullptr );
+// tdf#107126 for a section in a footnote, we have only inserted
+// the SwTextFrame but no SwSectionFrame - reset mbInfSct flag
+// to avoid crashing (but perhaps we should create a temp
+// SwSectionFrame here because WidowsAndOrphans checks for that?)
+pTmpFrame->InvalidateInfFlags();
 if ( pFrame->IsTextFrame() &&
  ( bTstMove ||
static_cast(pFrame)->HasFollow() ||
@@ -1885,6 +1890,7 @@ bool SwContentFrame::WouldFit_( SwTwips nSpace,
 
 pTmpFrame->RemoveFromLayout();
 pTmpFrame->InsertBefore( pUp, pOldNext );
+pTmpFrame->InvalidateInfFlags(); // restore flags
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - download.lst external/nss

[Michael Stahl]

 download.lst |3 +-
 external/nss/ExternalProject_nss.mk  |1 
 external/nss/UnpackedTarball_nss.mk  |1 
 external/nss/nss-ios.patch   |4 +-
 external/nss/nss-more-static.patch   |   34 -
 external/nss/nss.patch   |   47 ++-
 external/nss/nss.utf8bom.patch.1 |9 --
 external/nss/nss.windowbuild.patch.0 |   20 +++---
 external/nss/nss_macosx.patch|   19 +-
 external/nss/ubsan-alignment.patch.0 |   40 -
 external/nss/ubsan.patch.0   |   11 
 11 files changed, 53 insertions(+), 136 deletions(-)

New commits:
commit fd957eadfa1a042ceccc4083c275fcc43dfea458
Author: Michael Stahl 
Date:   Thu Apr 20 22:19:45 2017 +0200

nss: upgrade to release 3.29.5

- fixes CVE-2017-5461 and CVE-2017-5462
- drop ubsan-alignment.patch.0, there is apparently now some
  NO_SANITIZE_ALIGNMENT macro upstream to get this effect
- drop some hunks to prevent hard-coding CC/CCC vars, upstream now
  respects environment vars (but doesn't quote them...)
- drop first hunk of ubsan.patch.0, fixed upstream
- drop hunk for gtest-internal.h, header looks much newer anyway

Change-Id: I5c484c02c1235e185af1ef5166b069303d3378e1
Reviewed-on: https://gerrit.libreoffice.org/36756
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 
(cherry picked from commit 0cdf41419af854acccee0f819d4add7e8cafb7dc)
Reviewed-on: https://gerrit.libreoffice.org/36795
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/download.lst b/download.lst
index 34534afa428f..abb0fdb60778 100644
--- a/download.lst
+++ b/download.lst
@@ -111,7 +111,8 @@ export MWAW_TARBALL := 
libmwaw-0.3.$(MWAW_VERSION_MICRO).tar.bz2
 export MYSQLCPPCONN_TARBALL := 
7239a4430efd4d0189c4f24df67f08e5-mysql-connector-c++-1.1.4.tar.gz
 export MYTHES_TARBALL := a8c2c5b8f09e7ede322d5c602ff6a4b6-mythes-1.2.4.tar.gz
 export NEON_TARBALL := 231adebe5c2f78fded3e3df6e958878e-neon-0.30.1.tar.gz
-export NSS_TARBALL := 
0e3eee39402386cf16fd7aaa7399ebef-nss-3.27-with-nspr-4.13.tar.gz
+export NSS_MD5SUM := e55ee06b22687df68fafc6a30c0554b2
+export NSS_TARBALL := nss-3.29.5-with-nspr-4.13.1.tar.gz
 export ODFGEN_MD5SUM := 32572ea48d9021bbd6fa317ddb697abc
 export ODFGEN_VERSION_MICRO := 6
 export ODFGEN_TARBALL := libodfgen-0.1.$(ODFGEN_VERSION_MICRO).tar.bz2
diff --git a/external/nss/ExternalProject_nss.mk 
b/external/nss/ExternalProject_nss.mk
index 07cc472b9fb2..b7bdf4b26ac9 100644
--- a/external/nss/ExternalProject_nss.mk
+++ b/external/nss/ExternalProject_nss.mk
@@ -77,6 +77,7 @@ $(call gb_ExternalProject_get_state_target,nss,build): $(call 
gb_ExternalProject
$(MAKE) -j1 AR="$(AR)" \
RANLIB="$(RANLIB)" \
NMEDIT="$(NM)edit" \
+   CCC="$(CXX)" \
$(if 
$(CROSS_COMPILING),NSPR_CONFIGURE_OPTS="--build=$(BUILD_PLATFORM) 
--host=$(HOST_PLATFORM)") \
nss_build_all \
&& rm -f $(call 
gb_UnpackedTarball_get_dir,nss)/dist/out/lib/*.a \
diff --git a/external/nss/UnpackedTarball_nss.mk 
b/external/nss/UnpackedTarball_nss.mk
index a0ac57173fd1..4a90853f543a 100644
--- a/external/nss/UnpackedTarball_nss.mk
+++ b/external/nss/UnpackedTarball_nss.mk
@@ -44,7 +44,6 @@ ifeq ($(COM_IS_CLANG),TRUE)
 ifneq ($(filter -fsanitize=%,$(CC)),)
 $(eval $(call gb_UnpackedTarball_add_patches,nss,\
external/nss/asan.patch.1 \
-   external/nss/ubsan-alignment.patch.0 \
 ))
 endif
 endif
diff --git a/external/nss/nss-ios.patch b/external/nss/nss-ios.patch
index d4107d77f954..9d4af2c724e9 100644
--- a/external/nss/nss-ios.patch
+++ b/external/nss/nss-ios.patch
@@ -52,8 +52,8 @@
 --- a/a/nss/coreconf/Darwin.mk
 +++ a/a/nss/coreconf/Darwin.mk
 @@ -124,7 +124,7 @@
- # May override this with -bundle to create a loadable module.
- DSO_LDOPTS= -dynamiclib $(DARWIN_DYLIB_VERSIONS) -install_name 
@__OOO/$(notdir $@) 
-headerpad_max_install_names
+DSO_LDOPTS += --coverage
+ endif
  
 -MKSHLIB   = $(CC) $(DSO_LDOPTS) $(DARWIN_SDK_SHLIBFLAGS)
 +MKSHLIB   = touch $@; echo
diff --git a/external/nss/nss-more-static.patch 
b/external/nss/nss-more-static.patch
index 6b06a4e4a226..26948f0be24c 100644
--- a/external/nss/nss-more-static.patch
+++ b/external/nss/nss-more-static.patch
@@ -9,30 +9,30 @@
  /*  determine if hybrid platform, then actually load the DSO. */
  static PRStatus
 @@ -136,9 +136,9 @@
- return PR_FAILURE;
-   }
+ return PR_FAILURE;
+ }
  
--  handle = loader_LoadLibrary(name);
--  if (handle) {
--PRFuncPtr address = PR_FindFunctionSymbol(handle, 

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/source

[Michael Stahl]

 sw/source/core/layout/atrfrm.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2951a80e79fdc71b231eeadf2231c265307cabe9
Author: Michael Stahl 
Date:   Thu Apr 27 15:03:21 2017 +0200

sw: fix always-true condition in lcl_DelHFFormat ...

... that prevents headers from being deleted if they have a client.

(regression from d4267231754c1e6b03c7723a6fecc46750e7c780)

Change-Id: I71f52f8806e59c97b81aa14144c700c14c5527b0
(cherry picked from commit 99777c5a15df2d92bb8a9ddb6329fc3df1b2b8bf)
Reviewed-on: https://gerrit.libreoffice.org/37031
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/core/layout/atrfrm.cxx b/sw/source/core/layout/atrfrm.cxx
index 1a9168d257ee..a436e9bad595 100644
--- a/sw/source/core/layout/atrfrm.cxx
+++ b/sw/source/core/layout/atrfrm.cxx
@@ -118,7 +118,7 @@ static void lcl_DelHFFormat( SwClient *pToRemove, 
SwFrameFormat *pFormat )
 // It's suboptimal if the format is deleted beforehand.
 SwIterator aIter(*pFormat);
 for(SwClient* pLast = aIter.First(); bDel && pLast; pLast = 
aIter.Next())
-if(dynamic_cast( pLast ) ==  nullptr || 
!SwXHeadFootText::IsXHeadFootText(pLast))
+if (dynamic_cast(pLast) == nullptr && 
!SwXHeadFootText::IsXHeadFootText(pLast))
 bDel = false;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: rsc/source solenv/gbuild

[Caolán McNamara]

 rsc/source/parser/erscerr.cxx |1 -
 rsc/source/rsc/rsc.cxx|   10 +-
 solenv/gbuild/AllLangResTarget.mk |   13 ++---
 solenv/gbuild/Helper.mk   |1 -
 solenv/gbuild/TargetLocations.mk  |1 -
 5 files changed, 3 insertions(+), 23 deletions(-)

New commits:
commit bfc54ba3d2ac7f7ff40f8b3e95a6bd9b74bcd0c5
Author: Caolán McNamara 
Date:   Thu Apr 27 14:43:08 2017 +0100

cut top layer of detecting used bitmap resources in .src/.res files

Change-Id: I476ff9f55c264983419d5410035c1dfe6e07d5a3
Reviewed-on: https://gerrit.libreoffice.org/37035
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/rsc/source/parser/erscerr.cxx b/rsc/source/parser/erscerr.cxx
index ce67dfd9c60b..a6dcb46cf227 100644
--- a/rsc/source/parser/erscerr.cxx
+++ b/rsc/source/parser/erscerr.cxx
@@ -151,7 +151,6 @@ void RscError::WriteError( const ERRTYPE& rError, const 
char * pMessage )
 StdLstOut( "-fs= Name of the .res file.\n" );
 StdLstOut( "-lip=additional search path for system 
dependent files\n" );
 StdLstOut( "-fp= Renaming of the .srs file.\n" );
-StdLstOut( "-oil= Output directory for image list 
files\n" );
 StdLstOut( "-sub= replace  by  in image list 
files\n" );
 StdLstOut( "-BIGENDIANFormat of number values.\n" );
 StdLstOut( "-LITTLEENDIAN Format of number values.\n" );
diff --git a/rsc/source/rsc/rsc.cxx b/rsc/source/rsc/rsc.cxx
index d1f19b7b103f..e736e618f8af 100644
--- a/rsc/source/rsc/rsc.cxx
+++ b/rsc/source/rsc/rsc.cxx
@@ -197,10 +197,6 @@ RscCmdLine::RscCmdLine( int argc, char ** argv, RscError * 
pEH )
 aOutputSrs = (*ppStr) + 4;
 bOutputSrsIsSet = true;
 }
-else if( !rsc_strnicmp( (*ppStr) + 1, "oil=", 4 ) )
-{
-aILDir = (*ppStr) + 5;
-}
 else if( !rsc_stricmp( (*ppStr) + 1, "NoSysResTest" ) )
 { // don't check Bitmap, Pointers, Icons
 nCommands |= CommandFlags::NoSysResTest;
@@ -588,11 +584,7 @@ ERRTYPE RscCompiler::Link()
 
 aRcTmp = lcl_getTempFile(sTempDirUrl);
 
-OUString sOilDirUrl;
-if(!pCL->aILDir.isEmpty())
-sOilDirUrl = lcl_getAbsoluteUrl(sPwdUrl, pCL->aILDir);
-else
-sOilDirUrl = sTempDirUrl;
+OUString sOilDirUrl = sTempDirUrl;
 
 aSysListTmp = lcl_getTempFile(sOilDirUrl);
 
diff --git a/solenv/gbuild/AllLangResTarget.mk 
b/solenv/gbuild/AllLangResTarget.mk
index d31b10b23b3a..9da53605297e 100644
--- a/solenv/gbuild/AllLangResTarget.mk
+++ b/solenv/gbuild/AllLangResTarget.mk
@@ -244,15 +244,13 @@ $(call gb_ResTarget_get_clean_target,%) :
$(call gb_Helper_abbreviate_dirs,\
rm -f \
$(call gb_ResTarget_get_target,$*) \
-   $(call gb_ResTarget_get_install_target,$*) \
-   $(call gb_ResTarget_get_imagelist_target,$*))
+   $(call gb_ResTarget_get_install_target,$*)
 
 $(call gb_ResTarget_get_target,%) : $(gb_Helper_MISCDUMMY) \
$(gb_ResTarget_RSCDEPS)
$(call gb_Output_announce,$*,$(true),RES,2)
$(call gb_Helper_abbreviate_dirs,\
-   mkdir -p $(dir $@) \
-   $(dir $(call gb_ResTarget_get_imagelist_target,$*)) && \
+   mkdir -p $(dir $@) && \
RESPONSEFILE=`$(gb_MKTEMP)` && \
echo "-r -p \
-lg$(LANGUAGE) \
@@ -265,7 +263,6 @@ $(call gb_ResTarget_get_target,%) : $(gb_Helper_MISCDUMMY) \
-lip=$(gb_ResTarget_DEFIMAGESLOCATION)res \
-subMODULE=$(gb_ResTarget_DEFIMAGESLOCATION) \
-subGLOBALRES=$(gb_ResTarget_DEFIMAGESLOCATION)res \
-   -oil=$(dir $(call 
gb_ResTarget_get_imagelist_target,$*)) \
$(filter-out $(gb_Helper_MISCDUMMY) 
$(gb_ResTarget_RSCDEPS),$^)" \
> $${RESPONSEFILE} && \
$(gb_ResTarget_RSCCOMMAND) @$${RESPONSEFILE} && \
@@ -277,7 +274,6 @@ $(call gb_ResTarget_get_target,$(1)) : LIBRARY = $(2)
 $(call gb_ResTarget_get_target,$(1)) : LANGUAGE = $(3)
 $(call gb_ResTarget_get_target,$(1)) : RESLOCATION = $(2)
 $(call gb_AllLangResTarget_get_clean_target,$(2)) : $(call 
gb_ResTarget_get_clean_target,$(1))
-$(call gb_ResTarget_get_imagelist_target,$(1)) : $(call 
gb_ResTarget_get_target,$(1))
 
 endef
 
@@ -365,9 +361,4 @@ $(foreach lang,$(gb_AllLangResTarget_LANGS),\
 
 endef
 
-define gb_AllLangResTarget_get_imagelists
-$(foreach lang,$(gb_AllLangResTarget_LANGS),\
-$(call gb_ResTarget_get_imagelist_target,$(1)$(lang)))
-endef
-
 # vim: set noet sw=4: 
diff --git a/solenv/gbuild/Helper.mk 

[Libreoffice-commits] core.git: scaddins/AllLangResTarget_analysis.mk scaddins/source

[Caolán McNamara]

 scaddins/AllLangResTarget_analysis.mk  |4 
 scaddins/source/analysis/analysis.cxx  |   12 
 scaddins/source/analysis/analysis.hrc  |  104 --
 scaddins/source/analysis/analysis_deffuncnames.src |  931 -
 scaddins/source/analysis/analysishelper.cxx|  627 +-
 scaddins/source/analysis/analysishelper.hxx|6 
 6 files changed, 618 insertions(+), 1066 deletions(-)

New commits:
commit 11aef9734973dfcacc124205c51e14923c5579fb
Author: Caolán McNamara 
Date:   Thu Apr 27 14:01:55 2017 +0100

can move these nonlocalized strings into source

if u8 is suported everywhere

Change-Id: I0448db49e6f2e5c6cd6806b8da072ba672b6d95a
Reviewed-on: https://gerrit.libreoffice.org/37029
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/scaddins/AllLangResTarget_analysis.mk 
b/scaddins/AllLangResTarget_analysis.mk
index eb5ea75c7dfc..874e96fdad7a 100644
--- a/scaddins/AllLangResTarget_analysis.mk
+++ b/scaddins/AllLangResTarget_analysis.mk
@@ -35,8 +35,4 @@ $(eval $(call gb_SrsTarget_add_files,scaddins/analysis,\
 scaddins/source/analysis/analysis_funcnames.src \
 ))
 
-$(eval $(call gb_SrsTarget_add_nonlocalizable_files,scaddins/analysis,\
-scaddins/source/analysis/analysis_deffuncnames.src \
-))
-
 # vim: set noet sw=4 ts=4:
diff --git a/scaddins/source/analysis/analysis.cxx 
b/scaddins/source/analysis/analysis.cxx
index 8c41ba1f7f01..f038be52597a 100644
--- a/scaddins/source/analysis/analysis.cxx
+++ b/scaddins/source/analysis/analysis.cxx
@@ -92,16 +92,8 @@ void AnalysisAddIn::InitData()
 pResMgr = ResMgr::CreateResMgr("analysis", LanguageTag(aFuncLoc));
 
 delete pFD;
-
-if( pResMgr )
-{
-pFD = new FuncDataList;
-InitFuncDataList( *pFD, *pResMgr );
-}
-else
-{
-pFD = nullptr;
-}
+pFD = new FuncDataList;
+InitFuncDataList(*pFD);
 
 delete pDefLocales;
 pDefLocales = nullptr;
diff --git a/scaddins/source/analysis/analysis.hrc 
b/scaddins/source/analysis/analysis.hrc
index ac29f830d931..75d4bfe28363 100644
--- a/scaddins/source/analysis/analysis.hrc
+++ b/scaddins/source/analysis/analysis.hrc
@@ -229,110 +229,6 @@
 #define ANALYSIS_FUNCNAME_Imsech(ANALYSIS_FUNCNAME_START+99)
 #define ANALYSIS_FUNCNAME_Imcsch(ANALYSIS_FUNCNAME_START+100)
 
-#define ANALYSIS_DEFFUNCNAME_START  (ANALYSIS_RESOURCE_START+3000)
-
-#define ANALYSIS_DEFFUNCNAME_Workday(ANALYSIS_DEFFUNCNAME_START)
-#define ANALYSIS_DEFFUNCNAME_Yearfrac   (ANALYSIS_DEFFUNCNAME_START+1)
-#define ANALYSIS_DEFFUNCNAME_Edate  (ANALYSIS_DEFFUNCNAME_START+2)
-#define ANALYSIS_DEFFUNCNAME_Weeknum(ANALYSIS_DEFFUNCNAME_START+3)
-#define ANALYSIS_DEFFUNCNAME_Eomonth(ANALYSIS_DEFFUNCNAME_START+4)
-#define ANALYSIS_DEFFUNCNAME_Networkdays(ANALYSIS_DEFFUNCNAME_START+5)
-#define ANALYSIS_DEFFUNCNAME_Iseven (ANALYSIS_DEFFUNCNAME_START+6)
-#define ANALYSIS_DEFFUNCNAME_Isodd  (ANALYSIS_DEFFUNCNAME_START+7)
-#define ANALYSIS_DEFFUNCNAME_Multinomial(ANALYSIS_DEFFUNCNAME_START+8)
-#define ANALYSIS_DEFFUNCNAME_Seriessum  (ANALYSIS_DEFFUNCNAME_START+9)
-#define ANALYSIS_DEFFUNCNAME_Quotient   (ANALYSIS_DEFFUNCNAME_START+10)
-#define ANALYSIS_DEFFUNCNAME_Mround (ANALYSIS_DEFFUNCNAME_START+11)
-#define ANALYSIS_DEFFUNCNAME_Sqrtpi (ANALYSIS_DEFFUNCNAME_START+12)
-#define ANALYSIS_DEFFUNCNAME_Randbetween(ANALYSIS_DEFFUNCNAME_START+13)
-#define ANALYSIS_DEFFUNCNAME_Gcd(ANALYSIS_DEFFUNCNAME_START+14)
-#define ANALYSIS_DEFFUNCNAME_Lcm(ANALYSIS_DEFFUNCNAME_START+15)
-#define ANALYSIS_DEFFUNCNAME_Besseli(ANALYSIS_DEFFUNCNAME_START+16)
-#define ANALYSIS_DEFFUNCNAME_Besselj(ANALYSIS_DEFFUNCNAME_START+17)
-#define ANALYSIS_DEFFUNCNAME_Besselk(ANALYSIS_DEFFUNCNAME_START+18)
-#define ANALYSIS_DEFFUNCNAME_Bessely(ANALYSIS_DEFFUNCNAME_START+19)
-#define ANALYSIS_DEFFUNCNAME_Bin2Oct(ANALYSIS_DEFFUNCNAME_START+20)
-#define ANALYSIS_DEFFUNCNAME_Bin2Dec(ANALYSIS_DEFFUNCNAME_START+21)
-#define ANALYSIS_DEFFUNCNAME_Bin2Hex(ANALYSIS_DEFFUNCNAME_START+22)
-#define ANALYSIS_DEFFUNCNAME_Oct2Bin(ANALYSIS_DEFFUNCNAME_START+23)
-#define ANALYSIS_DEFFUNCNAME_Oct2Dec(ANALYSIS_DEFFUNCNAME_START+24)
-#define ANALYSIS_DEFFUNCNAME_Oct2Hex(ANALYSIS_DEFFUNCNAME_START+25)
-#define ANALYSIS_DEFFUNCNAME_Dec2Bin(ANALYSIS_DEFFUNCNAME_START+26)
-#define ANALYSIS_DEFFUNCNAME_Dec2Hex(ANALYSIS_DEFFUNCNAME_START+27)
-#define ANALYSIS_DEFFUNCNAME_Dec2Oct(ANALYSIS_DEFFUNCNAME_START+28)
-#define ANALYSIS_DEFFUNCNAME_Hex2Bin(ANALYSIS_DEFFUNCNAME_START+29)
-#define ANALYSIS_DEFFUNCNAME_Hex2Dec(ANALYSIS_DEFFUNCNAME_START+30)
-#define ANALYSIS_DEFFUNCNAME_Hex2Oct(ANALYSIS_DEFFUNCNAME_START+31)

[Libreoffice-bugs] [Bug 39468] translate German comments, removing redundant ones

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39468

--- Comment #287 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f92790d5e654a5a213e6e2190131d1c2852e8129

tdf#39468 Translate German comments in sw

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Jens Carl]

 sw/source/filter/html/htmldrawreader.cxx |   84 +++
 sw/source/filter/html/htmlfly.cxx|9 +--
 sw/source/filter/html/htmltab.cxx|4 -
 3 files changed, 47 insertions(+), 50 deletions(-)

New commits:
commit f92790d5e654a5a213e6e2190131d1c2852e8129
Author: Jens Carl 
Date:   Tue Apr 25 07:04:03 2017 +

tdf#39468 Translate German comments in sw

Translate German comments and terms in sw/

Change-Id: Ie33ad4496f9aeb5c06612241779fba627a5d2876
Reviewed-on: https://gerrit.libreoffice.org/36926
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/sw/source/filter/html/htmldrawreader.cxx 
b/sw/source/filter/html/htmldrawreader.cxx
index cc689bcda2c4..f2800093088c 100644
--- a/sw/source/filter/html/htmldrawreader.cxx
+++ b/sw/source/filter/html/htmldrawreader.cxx
@@ -98,11 +98,11 @@ void SwHTMLParser::InsertDrawObject( SdrObject* pNewDrawObj,
 nUpperSpace = nLowerSpace = (sal_uInt16)aTwipSpc.Height();
 }
 
-// linken/rechten Rand setzen
+// set left/right border
 const SfxPoolItem *pItem;
 if( SfxItemState::SET==rCSS1ItemSet.GetItemState( RES_LR_SPACE, true, 
 ) )
 {
-// Ggf. den Erstzeilen-Einzug noch plaetten
+// maybe flatten the first line indentation
 const SvxLRSpaceItem *pLRItem = static_cast(pItem);
 SvxLRSpaceItem aLRItem( *pLRItem );
 aLRItem.SetTextFirstLineOfst( 0 );
@@ -126,10 +126,10 @@ void SwHTMLParser::InsertDrawObject( SdrObject* 
pNewDrawObj,
 aFrameSet.Put( aLRItem );
 }
 
-// oberen/unteren Rand setzen
+// set top/bottom border
 if( SfxItemState::SET==rCSS1ItemSet.GetItemState( RES_UL_SPACE, true, 
 ) )
 {
-// Ggf. den Erstzeilen-Einzug noch plaetten
+// maybe flatten the first line indentation
 const SvxULSpaceItem *pULItem = static_cast(pItem);
 if( rCSS1PropInfo.m_bTopMargin )
 {
@@ -316,7 +316,7 @@ void SwHTMLParser::NewMarquee( HTMLTable *pCurTable )
 break;
 
 case HtmlOptionId::WIDTH:
-// erstmal nur als Pixelwerte merken!
+// first only save as pixel value!
 nWidth = rOption.GetNumber();
 bPrcWidth = rOption.GetString().indexOf('%') != -1;
 if( bPrcWidth && nWidth>100 )
@@ -324,19 +324,19 @@ void SwHTMLParser::NewMarquee( HTMLTable *pCurTable )
 break;
 
 case HtmlOptionId::HEIGHT:
-// erstmal nur als Pixelwerte merken!
+// first only save as pixel value!
 nHeight = rOption.GetNumber();
 if( rOption.GetString().indexOf('%') != -1 )
 nHeight = 0;
 break;
 
 case HtmlOptionId::HSPACE:
-// erstmal nur als Pixelwerte merken!
+// first only save as pixel value!
 aSpace.Height() = rOption.GetNumber();
 break;
 
 case HtmlOptionId::VSPACE:
-// erstmal nur als Pixelwerte merken!
+// first only save as pixel value!
 aSpace.Width() = rOption.GetNumber();
 break;
 
@@ -351,7 +351,7 @@ void SwHTMLParser::NewMarquee( HTMLTable *pCurTable )
 }
 }
 
-// Ein DrawTextobj anlegen
+// create a DrawTextobj
 // #i52858# - method name changed
 SwDrawModel* pModel = 
m_xDoc->getIDocumentDrawModelAccess().GetOrCreateDrawModel();
 SdrPage* pPg = pModel->GetPage( 0 );
@@ -365,11 +365,11 @@ void SwHTMLParser::NewMarquee( HTMLTable *pCurTable )
 if( !aId.isEmpty() )
 InsertBookmark( aId );
 
-// (Nur) Alternate leueft per Default von links nach rechts
+// (only) Alternate runs from left to right as default
 if( SdrTextAniKind::Alternate==eAniKind && !bDirection )
 eAniDir = SdrTextAniDirection::Right;
 
-// die fuer das Scrollen benoetigten Attribute umsetzen
+// re set the attributes needed for scrolling
 sal_uInt16 aWhichMap[7] =   { XATTR_FILL_FIRST,   XATTR_FILL_LAST,
   SDRATTR_MISC_FIRST, SDRATTR_MISC_LAST,
   EE_CHAR_START,  EE_CHAR_END,
@@ -384,21 +384,21 @@ void SwHTMLParser::NewMarquee( HTMLTable *pCurTable )
 aItemSet.Put( SdrTextAniAmountItem( nAmount ) );
 if( SdrTextAniKind::Alternate==eAniKind )
 {
-// (Nur) Alternate startet und stoppt per default Inside
+// (only) Alternate starts and ends Inside as default
 aItemSet.Put( SdrTextAniStartInsideItem(true) );
 aItemSet.Put( SdrTextAniStopInsideItem(true) );
 if( SdrTextAniDirection::Left==eAniDir )
 aItemSet.Put( SdrTextHorzAdjustItem(SDRTEXTHORZADJUST_RIGHT) );
 }
 
-// die Default-Farbe (aus der Standard-Vorlage) setzen, damit ueberhaupt
-// eine sinnvolle Farbe 

[Libreoffice-bugs] [Bug 107155] Kerning is not used when characters have different colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107155

--- Comment #10 from mor...@elysium.pl ---
Well, I do not want to be rude, but this is kinda strange to me. Apparently it
WORKED in LO 5.2 and got BROKEN in LO 5.3, and you are saying that it is an old
bug (like from 4 year ago)? I'm even sure it worked as expected in 2013 (at
least in Windows) - whichever LO release was at that time - because I have a
screenshot of my test document dated June 19, 2013 and everything is okay (that
means the kerning is applied between characters of different colors). You may
have a look at it -
https://boardgamegeek.com/image/1697334/m-knox?size=original

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/qa writerfilter/source

[Miklos Vajna]

 sw/qa/extras/ooxmlexport/data/tdf107104.docx  |binary
 sw/qa/extras/ooxmlexport/ooxmlexport6.cxx |4 +++-
 sw/qa/extras/ooxmlexport/ooxmlexport9.cxx |7 +++
 sw/qa/extras/ooxmlimport/ooxmlimport.cxx  |4 ++--
 writerfilter/source/dmapper/GraphicImport.cxx |6 ++
 5 files changed, 18 insertions(+), 3 deletions(-)

New commits:
commit 7d3baea4a726d6c0cf6cb0d6a8b2c83cef4f580d
Author: Miklos Vajna 
Date:   Tue Apr 25 09:25:34 2017 +0200

tdf#107104 DOCX drawingML import: fix invisible arrow shape

This is the drawingML equivalent of commit
3d9ebded1358395ed81db7a63629b046aec2aeac (Misc improvements for docx VML
import, 2010-10-06), which made sure that shapes are never invisible
just because they have zero height or width.

For this particular bugdoc the Word-produced WW8 equivalent width is 20
twips, but let's be consistent with the VML import and just round up to
1 mm100.

Also fix two existing tests that wanted to test something else, but
implicitly asserted that some shapes indeed have zero width/height.

(cherry picked from commit e6e5a68f52f4e06b73f0ece3a3886f3bfc30f56d)

Change-Id: I9600424520d0a3deecc711b44622eccc041a59da
Reviewed-on: https://gerrit.libreoffice.org/36953
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf107104.docx 
b/sw/qa/extras/ooxmlexport/data/tdf107104.docx
new file mode 100644
index ..2f8c87d8d3d5
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf107104.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
index 80f28f09875a..2891b3ff162f 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
@@ -909,7 +909,9 @@ DECLARE_OOXMLEXPORT_TEST(testExtentValue, "fdo74605.docx")
 xmlDocPtr pXmlDoc = parseExport();
 if (!pXmlDoc)
 return;
-assertXPath(pXmlDoc, 
"/w:document/w:body/w:p[2]/w:r[1]/mc:AlternateContent[1]/mc:Choice[1]/w:drawing[1]/wp:anchor[1]/wp:extent","cx","0");
+sal_Int32 nX = getXPath(pXmlDoc, 
"/w:document/w:body/w:p[2]/w:r[1]/mc:AlternateContent[1]/mc:Choice[1]/w:drawing[1]/wp:anchor[1]/wp:extent",
 "cx").toInt32();
+// This was negative.
+CPPUNIT_ASSERT(nX >= 0);
 }
 
 // part of tdf#93676, word gives the frame in the exported .docx a huge height,
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
index 99695f570cc7..9e00e77da235 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
@@ -243,6 +243,13 @@ DECLARE_OOXMLEXPORT_TEST(testTdf103931, "tdf103931.docx")
 CPPUNIT_ASSERT_EQUAL(static_cast(3), xTextSections->getCount());
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf107104, "tdf107104.docx")
+{
+CPPUNIT_ASSERT(getShape(1)->getSize().Width > 0);
+// This failed: the second arrow was invisible because it had zero height.
+CPPUNIT_ASSERT(getShape(2)->getSize().Width > 0);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 65ca9029923c..989d5fb34f34 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -1215,8 +1215,8 @@ DECLARE_OOXMLIMPORT_TEST(testTdf96674, "tdf96674.docx")
 uno::Reference xShape(getShape(1), uno::UNO_QUERY);
 CPPUNIT_ASSERT(xShape.is());
 awt::Size aActualSize(xShape->getSize());
-// This was 3493: the vertical line was horizontal.
-CPPUNIT_ASSERT_EQUAL(static_cast(0), aActualSize.Width);
+// Width was 3493: the vertical line was horizontal.
+CPPUNIT_ASSERT(aActualSize.Width < aActualSize.Height);
 CPPUNIT_ASSERT(aActualSize.Height > 0);
 }
 
diff --git a/writerfilter/source/dmapper/GraphicImport.cxx 
b/writerfilter/source/dmapper/GraphicImport.cxx
index f9458182505f..991b1461ed8d 100644
--- a/writerfilter/source/dmapper/GraphicImport.cxx
+++ b/writerfilter/source/dmapper/GraphicImport.cxx
@@ -543,6 +543,12 @@ void GraphicImport::lcl_attribute(Id nName, Value& rValue)
 case NS_ooxml::LN_CT_PositiveSize2D_cy:
 {
 sal_Int32 nDim = oox::drawingml::convertEmuToHmm(nIntValue);
+// drawingML equivalent of oox::vml::ShapeType::getAbsRectangle():
+// make sure a shape isn't hidden implicitly just because it has
+// zero height or width.
+if (nDim == 0)
+nDim = 1;
+
 if( nName == NS_ooxml::LN_CT_PositiveSize2D_cx )
 m_pImpl->setXSize(nDim);
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-bugs] [Bug 102497] File conversion results garbled on windows and "parser error: document is empty" on centos command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102497

Adolfo Jayme  changed:

   What|Removed |Added

  Component|LibreOffice |Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107476] FILEOPEN: Incorrect textbox position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107476

--- Comment #5 from Justin L  ---
Comment 2: 2nd_quarter-2010(1).docx: Although the horizontal line (a border
line connected to heading 4 style) appears to be better placed, the address
itself is worse (not centered because it is now wrapping around the picture
because it is one line too close now. I'd probably blame most of this text
height problem on the use of MS Trebuchant font. [Current master is the better
rendering if you compare tab positions. I don't think the textbox position
itself ever changes - only the text above it.]

Comment 3: Virkamatka_anomus(1).doc: The header contains lots of spurious tabs
with paragraph style puv-Date defining the tabstop at 6.3in. Using Word2013 to
saveas .docx (to remove the password protection) results in a two-page document
with a large header - similar to how it appears in LibreOffice. [hard to fully
evaluate a locked document]

Comment 4: Zurb Mozilla SOW #6.docx: Payment title inside the table - in MSWord
some extra words are hidden because a 2.5in tabstop pushes them beyond the end
of the cell (hiding "Due Date" and another "Payment"). [very badly designed
document still doesn't look the same in master, hard to say what is more
correct.]

In all of these documents, some aspect just happens to look better with the
first patch as a side effect.  None of these intentionally use a
left-tab-over-margin.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107447] Terms of 2 Formatting Marks are different to the Unicode Terms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107447

--- Comment #3 from Khaled Hosny  ---
This very bug is even an evidence about this confusion since “No-width optional
break” is actually “zero-width space” not “zero-width non-joiner”. Actually I’m
not even sure, I need to check the source code…

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61444] No kerning between letters of different colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=61444

Buovjaga  changed:

   What|Removed |Added

 CC||mor...@elysium.pl

--- Comment #18 from Buovjaga  ---
*** Bug 107155 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107155] Kerning is not used when characters have different colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107155

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #9 from Buovjaga  ---
Ok, sorry, I assumed it was due to the changes in 5.3.. closing.

*** This bug has been marked as a duplicate of bug 61444 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107447] Terms of 2 Formatting Marks are different to the Unicode Terms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107447

Khaled Hosny  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WONTFIX |---
 Ever confirmed|0   |1

--- Comment #2 from Khaled Hosny  ---
I disagree. I find our terms confusing, and every time I have to look it up to
find what Unicode character this is going to insert. I actually never seen
these terms used outside of OOo/LibreOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102345] [META] Formatting marks (aka Non-printing characters) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102345
Bug 102345 depends on bug 107447, which changed state.

Bug 107447 Summary: Terms of 2 Formatting Marks are different to the Unicode 
Terms
https://bugs.documentfoundation.org/show_bug.cgi?id=107447

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WONTFIX |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107298] Snap option "When creating or moving objects" is mis-labeled in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107298

--- Comment #3 from Buovjaga  ---
(In reply to Mike from comment #2)
> You misunderstand the issue. 
> 
> The feature is not the problem. The problem is about wording; it's about
> what the feature is labeled in Options. It must be re-labeled.

I don't misunderstand it. That's why I added our docs and design leads to the
CC.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107155] Kerning is not used when characters have different colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107155

--- Comment #8 from Khaled Hosny  ---
AFAIK, this has always been broken, see bug 61444. I didn’t even know it worked
on Windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107298] Snap option "When creating or moving objects" is mis-labeled in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107298

--- Comment #2 from Mike  ---
You misunderstand the issue. 

The feature is not the problem. The problem is about wording; it's about what
the feature is labeled in Options. It must be re-labeled.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107298] Snap option "When creating or moving objects" is mis-labeled in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107298

Buovjaga  changed:

   What|Removed |Added

 CC||olivier.hallot@documentfoun
   ||dation.org,
   ||tietze.he...@gmail.com,
   ||todven...@suomi24.fi

--- Comment #1 from Buovjaga  ---
Found in: Tools - options - LibO Draw - Grid

You can negate the effect by pressing Shift key.

Information can be found by searching for snap position in the Draw guide
http://documentation.libreoffice.org/en/english-documentation/draw/

Adding Olivier and Heiko for further thoughts.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107493] Red arrow for hidden text isn't partly hidden itself

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107493

--- Comment #1 from Telesto  ---
Created attachment 132920
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132920=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107493] New: Red arrow for hidden text isn't partly hidden itself

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107493

Bug ID: 107493
   Summary: Red arrow for hidden text isn't partly hidden itself
   Product: LibreOffice
   Version: 4.4.6.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
The red arrow indicating 'hidden text' is in certain circumstances partly
hidden itself

Steps to Reproduce:
1. Open attached file

Actual Results:  
Red arrow is cut off

Expected Results:
Arrow should be fully visible


Reproducible: Always

User Profile Reset: No

Additional Info:
Version: 5.4.0.0.alpha0+
Build ID: 597a2f5d5bd37443262b0775b8439bc3502aef1b
CPU threads: 4; OS: Windows 6.2; UI render: default; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-04-26_22:29:37
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101
Firefox/45.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107020] MS Word cannot open round-tripped docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107020

Stephan Bergmann  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |sberg...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107292] Deleted tracked changes text mixed on filesave in attached ODT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107292

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Reproduced.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: f69424ff90f83136027df3063d4c8ddafdf79faa
CPU threads: 8; OS: Linux 4.10; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on April 25th 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107492] New: : OutOfBound error when cells are deleted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107492

Bug ID: 107492
   Summary: : OutOfBound error when cells are deleted
   Product: LibreOffice
   Version: 5.3.2.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: denismod-l...@yahoo.com.br

Created attachment 132919
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132919=edit
File with VBA macro that removes duplicated records

A macro Wrote in VBAModule removes duplicated records in worksheets. When Cells
are deleted in loop, their references are missed and cause outofbound error in
second deletion.
It works in LO_5.1.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107285] table border presets toobar clears other borders rather than leaving them alone

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107285

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Did you try unticking the "Merge adjacent line styles" check box?
Not really sure, what we have to test here as there are no exact steps.. If you
want something to happen, please create more detailed steps.

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'private/mmeeks/admin-nonblock' - 0 commits -

[Unknown]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'private/mmeeks/delaysocket' - 0 commits -

[Unknown]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107283] No shortcut icon in toolbar for Selection of just table boxes to move or resize.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107283

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #3 from Buovjaga  ---
Position and size (F4) is not enough for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107464] Crash when spell checking text in draw objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107464

--- Comment #9 from Regina Henschel  ---
(In reply to Xisco Faulí from comment #7)
> Sorry, I had a local commit. my build was updated tonight over night. ID:
> 597a2f5d5bd37443262b0775b8439bc3502aef1b. Still, I can't reproduce it

Which language packs do you have installed? I have installed en-US and de in
all tested cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107281] Customized shortcuts set in Impress are working in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107281

Buovjaga  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #1 from Buovjaga  ---
Repro.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: f69424ff90f83136027df3063d4c8ddafdf79faa
CPU threads: 8; OS: Linux 4.10; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on April 25th 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: wsd/Storage.cpp

[Michael Meeks]

 wsd/Storage.cpp |   26 ++
 1 file changed, 26 insertions(+)

New commits:
commit 68b844eb5c3b980355300897fcdf18838d9af7dc
Author: Michael Meeks 
Date:   Thu Apr 27 18:47:35 2017 +0100

Initialize Poco's SSL-ness; the WOPI Storage code still uses it.

diff --git a/wsd/Storage.cpp b/wsd/Storage.cpp
index a125c1d7..f0f525eb 100644
--- a/wsd/Storage.cpp
+++ b/wsd/Storage.cpp
@@ -31,6 +31,12 @@
 #include 
 #include 
 
+// For residual Poco SSL usage.
+#include 
+#include 
+#include 
+#include 
+
 #include "Auth.hpp"
 #include "Common.hpp"
 #include "Exceptions.hpp"
@@ -98,6 +104,24 @@ void StorageBase::initialize()
 }
 }
 }
+
+#if ENABLE_SSL
+// FIXME: should use our own SSL socket implementation here.
+Poco::Crypto::initializeCrypto();
+Poco::Net::initializeSSL();
+
+// Init client
+Poco::Net::Context::Params sslClientParams;
+
+// TODO: Be more strict and setup SSL key/certs for remove server and us
+sslClientParams.verificationMode = Poco::Net::Context::VERIFY_NONE;
+
+Poco::SharedPtr 
consoleClientHandler = new Poco::Net::KeyConsoleHandler(false);
+Poco::SharedPtr 
invalidClientCertHandler = new Poco::Net::AcceptCertificateHandler(false);
+
+Poco::Net::Context::Ptr sslClientContext = new 
Poco::Net::Context(Poco::Net::Context::CLIENT_USE, sslClientParams);
+Poco::Net::SSLManager::instance().initializeClient(consoleClientHandler, 
invalidClientCertHandler, sslClientContext);
+#endif
 }
 
 bool isLocalhost(const std::string& targetHost)
@@ -283,6 +307,8 @@ namespace {
 inline
 Poco::Net::HTTPClientSession* getHTTPClientSession(const Poco::URI& uri)
 {
+// FIXME: if we're configured for http - we can still use an https:// wopi
+// host surely; of course - the converse is not true / sensible.
 return (LOOLWSD::isSSLEnabled() || LOOLWSD::isSSLTermination())
 ? new Poco::Net::HTTPSClientSession(uri.getHost(), uri.getPort(),
 
Poco::Net::SSLManager::instance().defaultClientContext())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 82164] FILEOPEN: Table of Contents has wrong style (MS Word ODT)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82164

--- Comment #10 from Regina Henschel  ---
Created attachment 132918
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132918=edit
Screenshot of TextMaker 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs