[Libreoffice-commits] core.git: canvas/source chart2/qa chart2/source

2017-06-19 Thread Noel Grandin
 canvas/source/vcl/spritehelper.cxx   |   55 +++-
 chart2/qa/extras/PivotChartTest.cxx  |   40 ++---
 chart2/qa/extras/chart2export.cxx|2 
 chart2/source/controller/dialogs/dlg_ShapeParagraph.cxx  |2 
 chart2/source/controller/dialogs/tp_DataSource.cxx   |4 
 chart2/source/controller/drawinglayer/DrawViewWrapper.cxx|7 -
 chart2/source/controller/main/ChartController_Properties.cxx |5 
 chart2/source/controller/main/ChartDropTargetHelper.cxx  |   74 +--
 chart2/source/controller/main/ChartFrameloader.cxx   |3 
 chart2/source/controller/main/ControllerCommandDispatch.cxx  |6 
 chart2/source/controller/main/DrawCommandDispatch.cxx|4 
 chart2/source/controller/main/ObjectHierarchy.cxx|3 
 chart2/source/controller/sidebar/Chart2PanelFactory.cxx  |3 
 chart2/source/controller/sidebar/ChartElementsPanel.cxx  |3 
 chart2/source/model/filter/XMLFilter.cxx |7 -
 chart2/source/model/main/ChartModel.cxx  |   22 ---
 chart2/source/model/template/ChartTypeTemplate.cxx   |3 
 chart2/source/model/template/PieChartTypeTemplate.cxx|7 -
 chart2/source/tools/AxisHelper.cxx   |3 
 chart2/source/tools/DiagramHelper.cxx|9 -
 chart2/source/tools/InternalDataProvider.cxx |3 
 chart2/source/tools/NumberFormatterWrapper.cxx   |3 
 chart2/source/tools/RangeHighlighter.cxx |6 
 chart2/source/tools/TitleHelper.cxx  |3 
 chart2/source/view/axes/VAxisProperties.cxx  |5 
 chart2/source/view/axes/VPolarAngleAxis.cxx  |7 -
 chart2/source/view/axes/VPolarGrid.cxx   |2 
 chart2/source/view/charttypes/BubbleChart.cxx|5 
 chart2/source/view/charttypes/CandleStickChart.cxx   |3 
 chart2/source/view/charttypes/NetChart.cxx   |2 
 chart2/source/view/charttypes/PieChart.cxx   |3 
 chart2/source/view/main/ChartView.cxx|   12 -
 chart2/source/view/main/OpenglShapeFactory.cxx   |   14 --
 chart2/source/view/main/ShapeFactory.cxx |   30 +---
 chart2/source/view/main/VDataSeries.cxx  |6 
 chart2/source/view/main/VLegend.cxx  |3 
 36 files changed, 141 insertions(+), 228 deletions(-)

New commits:
commit 19f3b88c1ee2ab546a92c28f155f4d65e0c464df
Author: Noel Grandin 
Date:   Mon Jun 19 16:03:21 2017 +0200

loplugin:oncevar chart2

Change-Id: I2dd0939db440b5357225395e88680dd0b0fdbf43
Reviewed-on: https://gerrit.libreoffice.org/38970
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/canvas/source/vcl/spritehelper.cxx 
b/canvas/source/vcl/spritehelper.cxx
index ee70b21425aa..d45adc84cd87 100644
--- a/canvas/source/vcl/spritehelper.cxx
+++ b/canvas/source/vcl/spritehelper.cxx
@@ -226,10 +226,6 @@ namespace vclcanvas
 // scales.
 if( !!(*maContent) )
 {
-// when true, fast path for slide transition has
-// already redrawn the sprite.
-bool bSpriteRedrawn( false );
-
 rTargetSurface.Push( PushFlags::CLIPREGION );
 
 // apply clip (if any)
@@ -260,35 +256,32 @@ namespace vclcanvas
 }
 }
 
-if( !bSpriteRedrawn )
+if( ::rtl::math::approxEqual(fAlpha, 1.0) )
 {
-if( ::rtl::math::approxEqual(fAlpha, 1.0) )
-{
-// no alpha modulation -> just copy to output
-if( maContent->IsTransparent() )
-rTargetSurface.DrawBitmapEx( aOutPos, aOutputSize, 
*maContent );
-else
-rTargetSurface.DrawBitmap( aOutPos, aOutputSize, 
maContent->GetBitmap() );
-}
+// no alpha modulation -> just copy to output
+if( maContent->IsTransparent() )
+rTargetSurface.DrawBitmapEx( aOutPos, aOutputSize, 
*maContent );
 else
-{
-// TODO(P3): Switch to OutputDevice::DrawTransparent()
-// here
-
-// draw semi-transparent
-sal_uInt8 nColor( static_cast( 
::basegfx::fround( 255.0*(1.0 - fAlpha) + .5) ) );
-AlphaMask aAlpha( maContent->GetSizePixel(),
-   );
-
-// mask out fully transparent areas

[Libreoffice-commits] core.git: compilerplugins/clang

2017-06-19 Thread Noel Grandin
 compilerplugins/clang/oncevar.cxx   |  288 
 compilerplugins/clang/store/oncevar.cxx |  166 --
 compilerplugins/clang/test/oncevar.cxx  |   54 ++
 3 files changed, 342 insertions(+), 166 deletions(-)

New commits:
commit 9c2b43e86fbb7612a58f6e55bc429f674977d6dd
Author: Noel Grandin 
Date:   Mon Jun 19 16:00:16 2017 +0200

improve oncevar loplugin

we look for any kind of scalar variable now that deserves to be inlined,
and we check for variables that cannot be inlined because they are being
passed by reference, or modified, or have their address taken

Change-Id: Ia744a180e91d1516140a1555d4514f6fa4de1c0b
Reviewed-on: https://gerrit.libreoffice.org/38966
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/oncevar.cxx 
b/compilerplugins/clang/oncevar.cxx
new file mode 100644
index ..d6c73e32b84b
--- /dev/null
+++ b/compilerplugins/clang/oncevar.cxx
@@ -0,0 +1,288 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include "plugin.hxx"
+#include "check.hxx"
+#include "clang/AST/CXXInheritance.h"
+
+// Original idea from tml.
+// Look for variables that are (a) initialised from zero or one constants. (b) 
only used in one spot.
+// In which case, we might as well inline it.
+
+namespace
+{
+
+bool startsWith(const std::string& rStr, const char* pSubStr) {
+return rStr.compare(0, strlen(pSubStr), pSubStr) == 0;
+}
+
+class OnceVar:
+public RecursiveASTVisitor, public loplugin::Plugin
+{
+public:
+explicit OnceVar(InstantiationData const & data): Plugin(data) {}
+
+virtual void run() override {
+// ignore some files with problematic macros
+std::string fn( compiler.getSourceManager().getFileEntryForID(
+
compiler.getSourceManager().getMainFileID())->getName() );
+normalizeDotDotInFilePath(fn);
+// platform-specific stuff
+if (fn == SRCDIR "/sal/osl/unx/thread.cxx"
+|| fn == SRCDIR "/sot/source/base/formats.cxx"
+|| fn == SRCDIR "/svl/source/config/languageoptions.cxx"
+|| fn == SRCDIR "/sfx2/source/appl/appdde.cxx"
+|| fn == SRCDIR "/configmgr/source/components.cxx"
+|| fn == SRCDIR "/embeddedobj/source/msole/oleembed.cxx")
+ return;
+// some of this is necessary
+if (startsWith( fn, SRCDIR "/sal/qa/"))
+ return;
+if (startsWith( fn, SRCDIR "/comphelper/qa/"))
+ return;
+// TODO need to check calls via function pointer
+if (fn == SRCDIR 
"/i18npool/source/textconversion/textconversion_zh.cxx"
+|| fn == SRCDIR "/i18npool/source/localedata/localedata.cxx")
+ return;
+// debugging stuff
+if (fn == SRCDIR "/sc/source/core/data/dpcache.cxx"
+|| fn == SRCDIR "/sw/source/core/layout/dbg_lay.cxx"
+|| fn == SRCDIR "/sw/source/core/layout/ftnfrm.cxx")
+ return;
+// TODO taking local reference to variable
+if (fn == SRCDIR "/sc/source/filter/excel/xechart.cxx")
+ return;
+TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
+
+for (auto const & varDecl : maVarDeclSet)
+{
+if (maVarDeclToIgnoreSet.find(varDecl) != 
maVarDeclToIgnoreSet.end())
+continue;
+int noUses = 0;
+auto it = maVarUsesMap.find(varDecl);
+if (it != maVarUsesMap.end())
+noUses = it->second;
+if (noUses > 1)
+continue;
+report(DiagnosticsEngine::Warning,
+   "var used only once, should be inlined or declared const",
+   varDecl->getLocation())
+<< varDecl->getSourceRange();
+if (it != maVarUsesMap.end())
+report(DiagnosticsEngine::Note,
+   "used here",
+   maVarUseSourceRangeMap[varDecl].getBegin())
+<< maVarUseSourceRangeMap[varDecl];
+}
+}
+
+bool VisitDeclRefExpr( const DeclRefExpr* );
+bool VisitVarDecl( const VarDecl* );
+
+private:
+StringRef getFilename(SourceLocation loc);
+
+std::unordered_set maVarDeclSet;
+std::unordered_set maVarDeclToIgnoreSet;
+std::unordered_map maVarUsesMap;
+std::unordered_map maVarUseSourceRangeMap;
+};
+
+StringRef OnceVar::getFilename(SourceLocation loc)
+{
+SourceLocation spellingLocation = 

[Libreoffice-commits] core.git: accessibility/source basctl/source basic/source

2017-06-19 Thread Noel Grandin
 accessibility/source/extended/accessiblelistbox.cxx  |   18 --
 accessibility/source/standard/vclxaccessiblecheckbox.cxx |3 --
 basctl/source/basicide/baside2.cxx   |3 --
 basctl/source/basicide/baside2b.cxx  |2 -
 basctl/source/basicide/baside3.cxx   |6 +---
 basctl/source/basicide/basides1.cxx  |6 +---
 basctl/source/basicide/scriptdocument.cxx|9 ++-
 basctl/source/dlged/dlgedobj.cxx |4 ---
 basic/source/classes/sb.cxx  |6 +---
 basic/source/classes/sbunoobj.cxx|7 +
 basic/source/classes/sbxmod.cxx  |8 ++
 basic/source/comp/dim.cxx|3 --
 basic/source/comp/exprtree.cxx   |6 +---
 basic/source/runtime/iosys.cxx   |3 --
 basic/source/runtime/methods.cxx |6 +---
 basic/source/runtime/methods1.cxx|   11 +++-
 basic/source/runtime/runtime.cxx |6 +---
 basic/source/sbx/sbxcurr.cxx |6 ++--
 basic/source/sbx/sbxvalue.cxx|6 +---
 basic/source/uno/namecont.cxx|   19 +--
 basic/source/uno/scriptcont.cxx  |   13 +++---
 21 files changed, 47 insertions(+), 104 deletions(-)

New commits:
commit 6ee9f2c188290ba8a8bc6d435f645b31a05783ea
Author: Noel Grandin 
Date:   Mon Jun 19 16:02:12 2017 +0200

loplugin:oncevar accessibility..basic

Change-Id: I8fb41b658ef0f6ad1774ea897eace3dc9bb12de6
Reviewed-on: https://gerrit.libreoffice.org/38969
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/accessibility/source/extended/accessiblelistbox.cxx 
b/accessibility/source/extended/accessiblelistbox.cxx
index dd96005ee3dd..a79c7a67d4d6 100644
--- a/accessibility/source/extended/accessiblelistbox.cxx
+++ b/accessibility/source/extended/accessiblelistbox.cxx
@@ -120,23 +120,7 @@ namespace accessibility
 case VclEventId::ListboxTreeFocus:
 {
 VclPtr pBox = getListBox();
-bool bNeedFocus = false;
-if (pBox)
-{
-vcl::Window* pParent = 
static_cast(pBox)->GetParent();
-if (pParent && pParent->GetType() == 
WindowType::FLOATINGWINDOW)
-{
-// MT: ImplGetAppSVData shouldn't be exported from 
VCL.
-// In which scenario is this needed?
-// If needed, we need to find an other solution
-/*
-  ImplSVData* pSVData = ImplGetAppSVData();
-  if (pSVData && pSVData->maWinData.mpFirstFloat 
== (FloatingWindow*)pParent)
-  bNeedFocus = true;
-*/
-}
-}
-if( pBox && (pBox->HasFocus() || bNeedFocus) )
+if( pBox && pBox->HasFocus() )
 {
 uno::Any aNewValue;
 SvTreeListEntry* pEntry = static_cast< 
SvTreeListEntry* >( rVclWindowEvent.GetData() );
diff --git a/accessibility/source/standard/vclxaccessiblecheckbox.cxx 
b/accessibility/source/standard/vclxaccessiblecheckbox.cxx
index c0c9ce262929..5e4adfc6d6c4 100644
--- a/accessibility/source/standard/vclxaccessiblecheckbox.cxx
+++ b/accessibility/source/standard/vclxaccessiblecheckbox.cxx
@@ -191,7 +191,6 @@ sal_Bool VCLXAccessibleCheckBox::doAccessibleAction ( 
sal_Int32 nIndex )
 VCLXCheckBox* pVCLXCheckBox = static_cast< VCLXCheckBox* >( 
GetVCLXWindow() );
 if ( pCheckBox && pVCLXCheckBox )
 {
-sal_Int32 nValueMin = (sal_Int32) 0;
 sal_Int32 nValueMax = (sal_Int32) 1;
 
 if ( pCheckBox->IsTriStateEnabled() )
@@ -202,7 +201,7 @@ sal_Bool VCLXAccessibleCheckBox::doAccessibleAction ( 
sal_Int32 nIndex )
 ++nValue;
 
 if ( nValue > nValueMax )
-nValue = nValueMin;
+nValue = 0;
 
 pVCLXCheckBox->setState( (sal_Int16) nValue );
 }
diff --git a/basctl/source/basicide/baside2.cxx 
b/basctl/source/basicide/baside2.cxx
index b18a1bb6b664..9219cde9e7cf 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -810,7 +810,6 @@ sal_Int32 ModulWindow::FormatAndPrint( Printer* pPrinter, 
sal_Int32 nPrintPage )
 {
 nLineHeight = 1;
 }
-sal_Int32 nParaSpace = 10;
 
 Size aPaperSz = pPrinter->GetOutputSize();
 aPaperSz.Width() -= 

[Libreoffice-commits] core.git: compilerplugins/clang solenv/CompilerTest_compilerplugins_clang.mk

2017-06-19 Thread Noel Grandin
 compilerplugins/clang/plugin.cxx |5 +
 compilerplugins/clang/plugin.hxx |2 
 compilerplugins/clang/pluginhandler.cxx  |   16 --
 compilerplugins/clang/pluginhandler.hxx  |2 
 compilerplugins/clang/test/unusedfields.cxx  |   28 ++
 compilerplugins/clang/unusedfields.cxx   |   70 ---
 solenv/CompilerTest_compilerplugins_clang.mk |1 
 7 files changed, 102 insertions(+), 22 deletions(-)

New commits:
commit 3b60f59bc55824e247f6e751a9c8f5d253665f0b
Author: Noel Grandin 
Date:   Mon Jun 19 13:44:14 2017 +0200

loplugin:unusedfields fix false positive

When the field in question is read from inside a constructor
initializer.

In the process, create some needed infrastructure in the plugin classes.

Change-Id: I2f440efa6912801a236727c9fe3180404616958c
Reviewed-on: https://gerrit.libreoffice.org/38960
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/plugin.cxx b/compilerplugins/clang/plugin.cxx
index 3ec612ef..ea646d29da89 100644
--- a/compilerplugins/clang/plugin.cxx
+++ b/compilerplugins/clang/plugin.cxx
@@ -265,6 +265,11 @@ SourceLocation Plugin::locationAfterToken( SourceLocation 
location )
 return Lexer::getLocForEndOfToken( location, 0, 
compiler.getSourceManager(), compiler.getLangOpts());
 }
 
+bool Plugin::isUnitTestMode()
+{
+return PluginHandler::isUnitTestMode();
+}
+
 RewritePlugin::RewritePlugin( const InstantiationData& data )
 : Plugin( data )
 , rewriter( data.rewriter )
diff --git a/compilerplugins/clang/plugin.hxx b/compilerplugins/clang/plugin.hxx
index 413b2ab7cefb..5651b2ff02ca 100644
--- a/compilerplugins/clang/plugin.hxx
+++ b/compilerplugins/clang/plugin.hxx
@@ -78,6 +78,8 @@ class Plugin
 bool isInUnoIncludeFile(const FunctionDecl*) const;
 
 static void normalizeDotDotInFilePath(std::string&);
+
+static bool isUnitTestMode();
 private:
 static void registerPlugin( Plugin* (*create)( const 
InstantiationData& ), const char* optionName, bool isPPCallback, bool byDefault 
);
 template< typename T > static Plugin* createHelper( const 
InstantiationData& data );
diff --git a/compilerplugins/clang/pluginhandler.cxx 
b/compilerplugins/clang/pluginhandler.cxx
index ad043e87e58d..7c42d14f3056 100644
--- a/compilerplugins/clang/pluginhandler.cxx
+++ b/compilerplugins/clang/pluginhandler.cxx
@@ -56,13 +56,13 @@ const int MAX_PLUGINS = 100;
 static PluginData plugins[ MAX_PLUGINS ];
 static int pluginCount = 0;
 static bool bPluginObjectsCreated = false;
+static bool unitTestMode = false;
 
 PluginHandler::PluginHandler( CompilerInstance& compiler, const vector< string 
>& args )
 : compiler( compiler )
 , rewriter( compiler.getSourceManager(), compiler.getLangOpts())
 , scope( "mainfile" )
 , warningsAsErrors( false )
-, unitTestMode( false )
 {
 set< string > rewriters;
 for( string const & arg : args )
@@ -89,6 +89,11 @@ PluginHandler::~PluginHandler()
 }
 }
 
+bool PluginHandler::isUnitTestMode()
+{
+return unitTestMode;
+}
+
 void PluginHandler::handleOption( const string& option )
 {
 if( option.substr( 0, 6 ) == "scope=" )
@@ -121,10 +126,13 @@ void PluginHandler::createPlugins( set< string > 
rewriters )
  i < pluginCount;
  ++i )
 {
-if( rewriters.erase( plugins[i].optionName ) != 0 )
-plugins[ i ].object = plugins[ i ].create( 
Plugin::InstantiationData { plugins[ i ].optionName, *this, compiler,  
} );
+const char* name = plugins[i].optionName;
+if( rewriters.erase( name ) != 0 )
+plugins[ i ].object = plugins[ i ].create( 
Plugin::InstantiationData { name, *this, compiler,  } );
 else if( plugins[ i ].byDefault )
-plugins[ i ].object = plugins[ i ].create( 
Plugin::InstantiationData { plugins[ i ].optionName, *this, compiler, NULL } );
+plugins[ i ].object = plugins[ i ].create( 
Plugin::InstantiationData { name, *this, compiler, NULL } );
+else if( unitTestMode && strcmp(name, "unusedmethodsremove") != 0 && 
strcmp(name, "unusedfieldsremove") != 0)
+plugins[ i ].object = plugins[ i ].create( 
Plugin::InstantiationData { name, *this, compiler, NULL } );
 }
 for( auto r: rewriters )
 report( DiagnosticsEngine::Fatal, "unknown plugin tool %0" ) << r;
diff --git a/compilerplugins/clang/pluginhandler.hxx 
b/compilerplugins/clang/pluginhandler.hxx
index a2cc136f5751..222cb258e80f 100644
--- a/compilerplugins/clang/pluginhandler.hxx
+++ b/compilerplugins/clang/pluginhandler.hxx
@@ -37,6 +37,7 @@ class PluginHandler
 DiagnosticBuilder report( DiagnosticsEngine::Level level, const char * 
plugin, StringRef message,
 CompilerInstance& compiler, 

[Libreoffice-commits] core.git: writerfilter/source

2017-06-19 Thread Noel Grandin
 writerfilter/source/dmapper/DomainMapper.cxx|6 
 writerfilter/source/dmapper/DomainMapper_Impl.cxx   |9 +-
 writerfilter/source/dmapper/DomainMapper_Impl.hxx   |8 -
 writerfilter/source/dmapper/FontTable.cxx   |6 ++--
 writerfilter/source/dmapper/FontTable.hxx   |2 -
 writerfilter/source/dmapper/GraphicImport.cxx   |3 --
 writerfilter/source/dmapper/NumberingManager.cxx|   12 ++--
 writerfilter/source/dmapper/NumberingManager.hxx|8 -
 writerfilter/source/dmapper/OLEHandler.cxx  |4 --
 writerfilter/source/dmapper/OLEHandler.hxx  |2 -
 writerfilter/source/dmapper/PropertyMap.cxx |9 --
 writerfilter/source/dmapper/PropertyMap.hxx |   27 ---
 writerfilter/source/dmapper/SettingsTable.cxx   |9 --
 writerfilter/source/dmapper/StyleSheetTable.cxx |   28 ++--
 writerfilter/source/dmapper/StyleSheetTable.hxx |7 -
 writerfilter/source/dmapper/TrackChangesHandler.cxx |4 --
 writerfilter/source/ooxml/OOXMLDocumentImpl.cxx |4 --
 writerfilter/source/ooxml/OOXMLDocumentImpl.hxx |1 
 18 files changed, 17 insertions(+), 132 deletions(-)

New commits:
commit 42ab759336cd4a4cbcc5be66de33d05b7fc46be4
Author: Noel Grandin 
Date:   Thu Jun 15 12:03:06 2017 +0200

loplugin:unusedfields in writerfilter

Change-Id: I2f74dee5c05420275aae57485b8d81f60fff2d5d
Reviewed-on: https://gerrit.libreoffice.org/38823
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 7161b1fe6ace..67bd4648e42f 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -85,7 +85,6 @@ namespace dmapper{
 
 struct
 {
-sal_Int32 code;
 sal_Int32 h;
 bool  orient;
 sal_Int32 w;
@@ -567,7 +566,6 @@ void DomainMapper::lcl_attribute(Id nName, Value & val)
 break;
 
 case NS_ooxml::LN_CT_PageSz_code:
-CT_PageSz.code = nIntValue;
 break;
 case NS_ooxml::LN_CT_PageSz_h:
 {
@@ -895,7 +893,6 @@ void DomainMapper::lcl_attribute(Id nName, Value & val)
 pSectionContext->SetLnnMod( nIntValue );
 break;
 case NS_ooxml::LN_CT_LineNumber_start:
-aSettings.nStartValue = nIntValue; // todo: has to be set 
at (each) first paragraph
 OSL_ENSURE(pSectionContext, "SectionContext unavailable!");
 if( pSectionContext )
 pSectionContext->SetLnnMin( nIntValue );
@@ -1947,7 +1944,6 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const 
PropertyMapPtr& rContext )
 {
 resolveSprmProps(*this, rSprm);
 LineNumberSettings aSettings = m_pImpl->GetLineNumberSettings();
-aSettings.bIsOn = true;
 m_pImpl->SetLineNumberSettings( aSettings );
 //apply settings at XLineNumberingProperties
 try
@@ -1986,7 +1982,6 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const 
PropertyMapPtr& rContext )
 }
 break;
 case NS_ooxml::LN_EG_SectPrContents_pgSz:
-CT_PageSz.code = 0;
 {
 PaperInfo aLetter(PAPER_LETTER);
 CT_PageSz.w = aLetter.getWidth();
@@ -2000,7 +1995,6 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const 
PropertyMapPtr& rContext )
 pSectionContext->Insert( PROP_HEIGHT, uno::makeAny( CT_PageSz.h ) 
);
 pSectionContext->Insert( PROP_IS_LANDSCAPE, uno::makeAny( 
CT_PageSz.orient ));
 pSectionContext->Insert( PROP_WIDTH, uno::makeAny( CT_PageSz.w ) );
-pSectionContext->SetLandscape( CT_PageSz.orient );
 }
 break;
 
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index c58bdaf94143..9e2737322922 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -198,7 +198,6 @@ DomainMapper_Impl::DomainMapper_Impl(
 m_bStartedTOC(false),
 m_bStartIndex(false),
 m_bStartBibliography(false),
-m_bTOCPageRef(false),
 m_bStartGenericField(false),
 m_bTextInserted(false),
 m_pLastSectionContext( ),
@@ -3718,7 +3717,6 @@ void DomainMapper_Impl::CloseFieldCommand()
 }
 if (m_bStartTOC && (aIt->second.eFieldId == FIELD_PAGEREF) )
 {
-m_bTOCPageRef = true;
 bCreateField = false;
 }
 
@@ -5006,7 +5004,7 @@ void DomainMapper_Impl::SetPageMarginTwip( PageMarElement 
eElement, sal_Int32 nV
 case PAGE_MAR_LEFT   : m_aPageMargins.left= nValue; break;
 case 

[Libreoffice-bugs] [Bug 48722] Add Realistic [soft-edge/fuzzy/Gaussian-blur] Shadows for Objects

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=48722

--- Comment #9 from Derek Keats  ---
I'd love to see this too, especially in Draw which is otherwise an awesome
drawing application. I end up having to do the shadow in Gimp, which takes
extra time. It would be wonderful to be able to do blurred shadows directly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 48344] Windows shell 'OpenDocument Text' template uses A4 page size rather than locale default

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=48344

Joel Madero  changed:

   What|Removed |Added

 CC||jmadero@gmail.com

--- Comment #17 from Joel Madero  ---
FWIW the project has NEVER had a policy of "stale = close." It's a bad policy
that has hurt projects in the past. Our community has always thrived on leaving
valid requests/bugs open, even if in the end the bug will never be fixed or the
enhancement will never be implemented.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source

2017-06-19 Thread Tor Lillqvist
 sc/source/core/data/column2.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 13ab6b5c16f8b1504cc7c36a8e1213950a51eefa
Author: Tor Lillqvist 
Date:   Tue Jun 20 07:34:27 2017 +0300

Avoid "this member function can be declared static [loplugin:staticmethods]"

Change-Id: If8e0810c4998b2d56609a0c9fe10ce061d1a6347

diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index 890e319e3d22..506e59006253 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -1559,6 +1559,8 @@ void ScColumn::CellStorageModified()
 while (itAttr != maCellTextAttrs.end() && itAttr->type != 
sc::element_type_empty)
 ++itAttr;
 }
+#else
+(void) this; // Avoid "this member function can be declared static 
[loplugin:staticmethods]"
 #endif
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 108404] Calc changes the font attributes of selected text in unpredictable ways

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108404

Buovjaga  changed:

   What|Removed |Added

 Attachment #134136|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

2017-06-19 Thread Ashod Nakashian
 wsd/LOOLWSD.cpp |   10 +++---
 1 file changed, 3 insertions(+), 7 deletions(-)

New commits:
commit bc067c7b299ed1299b7fb4546444abf403cb6c5b
Author: Ashod Nakashian 
Date:   Mon Jun 19 22:47:30 2017 -0400

wsd: always prespawn children when creating forkit

Also, no need for the DocBrokerMutex to be locked
in createForkit.

Change-Id: I651c50c8b5518f7b0ee0d8b15c413fc070e30443
Reviewed-on: https://gerrit.libreoffice.org/38993
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 6a62d9d9..eecc6d27 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1163,6 +1163,8 @@ bool LOOLWSD::createForKit()
 #else
 LOG_INF("Creating new forkit process.");
 
+std::unique_lock newChildrenLock(NewChildrenMutex);
+
 Process::Args args;
 args.push_back("--losubpath=" + std::string(LO_JAIL_SUBPATH));
 args.push_back("--systemplate=" + SysTemplate);
@@ -1195,10 +1197,6 @@ bool LOOLWSD::createForKit()
 args.push_back("--nocaps");
 }
 
-// If we're recovering forkit, don't allow processing new requests.
-std::unique_lock docBrokersLock(DocBrokersMutex);
-std::unique_lock newChildrenLock(NewChildrenMutex);
-
 // Always reap first, in case we haven't done so yet.
 if (ForKitProcId != -1)
 {
@@ -1236,6 +1234,7 @@ bool LOOLWSD::createForKit()
 Admin::instance().setForKitPid(ForKitProcId);
 Admin::instance().setForKitWritePipe(ForKitWritePipe);
 
+rebalanceChildren(LOOLWSD::NumPreSpawnedChildren - 1);
 return ForKitProcId != -1;
 #endif
 }
@@ -2558,9 +2557,6 @@ int LOOLWSD::innerMain()
 }
 #endif
 
-// Prefork initial children
-prespawnChildren();
-
 // Start the server.
 srv.start(ClientPortNumber);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

2017-06-19 Thread Ashod Nakashian
 wsd/LOOLWSD.cpp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c28992758d1db7f23b477178d93c2b84e9f48c06
Author: Ashod Nakashian 
Date:   Mon Jun 19 22:15:59 2017 -0400

wsd: avoid deadlock when restoring forkit

LOOLWSD::checkAndRestoreForKit() eventually takes
NewChildrenLock, which is also taken in getNewChild_Blocks().

Luckily, we can defer that to the Prisoner poll, which we do.

Change-Id: Ib65c0be08870d1c4c68efd72192dac2e73c79f7c
Reviewed-on: https://gerrit.libreoffice.org/38992
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 989ff496..6a62d9d9 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -401,9 +401,9 @@ std::shared_ptr getNewChild_Blocks()
 ++numPreSpawn; // Replace the one we'll dispatch just now.
 if (rebalanceChildren(numPreSpawn) < 0)
 {
-LOG_DBG("getNewChild: rebalancing of children failed. Checking and 
restoring forkit.");
+LOG_DBG("getNewChild: rebalancing of children failed. Scheduling 
housekeeping to recover.");
 
-LOOLWSD::checkAndRestoreForKit();
+LOOLWSD::doHousekeeping();
 
 // Let the caller retry after a while.
 return nullptr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

2017-06-19 Thread Ashod Nakashian
 wsd/DocumentBroker.cpp |   14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

New commits:
commit 7ae37aff0d2d6a337551b8b5a3d9daadc93d128c
Author: Ashod Nakashian 
Date:   Mon Jun 19 21:53:58 2017 -0400

wsd: fix access-after-free error

Valgrind spotted one case, and the other is possible but
not common it seems.

Change-Id: Id5e41145f597c3564263adb25b7b765db1c90bf7
Reviewed-on: https://gerrit.libreoffice.org/38991
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 240c1d40..ff5e2b61 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -949,9 +949,8 @@ size_t DocumentBroker::removeSessionInternal(const 
std::string& id)
 
 const auto readonly = (it->second ? it->second->isReadOnly() : 
false);
 
-//FIXME: We might be called from the session we are removing,
-//FIXME: and if this is the last/only reference, we destroy it.
-//FIXME: Should flag and remove from the poll thread.
+// Remove. The caller must have a reference to the session
+// in question, lest we destroy from underneith them.
 _sessions.erase(it);
 
 const auto count = _sessions.size();
@@ -1355,7 +1354,9 @@ bool DocumentBroker::forwardToClient(const 
std::shared_ptr& payload)
 if (sid == "all")
 {
 // Broadcast to all.
-for (const auto& pair : _sessions)
+// Events could cause the removal of sessions.
+std::map 
sessions(_sessions);
+for (const auto& pair : sessions)
 {
 pair.second->handleKitToClientMessage(data, size);
 }
@@ -1365,7 +1366,10 @@ bool DocumentBroker::forwardToClient(const 
std::shared_ptr& payload)
 const auto it = _sessions.find(sid);
 if (it != _sessions.end())
 {
-return it->second->handleKitToClientMessage(data, size);
+// Take a ref as the session could be removed from _sessions
+// if it's the save confirmation keeping a stopped session 
alive.
+std::shared_ptr session = it->second;
+return session->handleKitToClientMessage(data, size);
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 107039] Crash on Close after acknowledging save changes - mutex issue

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107039

--- Comment #17 from Matt  ---
See soffice.procmon.log. 

I cannot deciper what is happening between 10:53:19 (when I hit the red x to
close base) and 10:53:28.

At that point it seems that every 10 seconds, soffice.bin is writing or trying
to write to file database.odb.lck. It just keeps doing that forever.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107039] Crash on Close after acknowledging save changes - mutex issue

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107039

--- Comment #16 from Matt  ---
Created attachment 134149
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134149=edit
Relevant procmon output

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108643] Strange placeholders appear for charts after loading

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108643

--- Comment #2 from Aron Budea  ---
Note an additional detail:
Since the mentioned commit, when the charts are finally displayed after
scrolling around, the document becomes modified and the save confirmation
dialog appears upon closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107039] Crash on Close after acknowledging save changes - mutex issue

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107039

--- Comment #15 from Matt  ---
Tested version
/daily/master/Win-x86_64@42/2017-06-19_02.13.03
libo-master64~2017-06-19_02.13.03_LibreOfficeDev_6.0.0.0.alpha0_Win_x64.msi 
By the way, this took an exceedingly long time to download.

aka Version: 6.0.0.0.alpha0+ (x64)

Build ID: 493407c470e7051a801e2a0ad8253f7b87c4434f
CPU threads: 8; OS: Windows 6.1; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-06-19_02:13:03
Locale: en-US (en_US); Calc: CL

The bug happens in this version too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108643] Strange placeholders appear for charts after loading

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108643

--- Comment #1 from Aron Budea  ---
Created attachment 134148
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134148=edit
Screenshot with placeholders

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108643] New: Strange placeholders appear for charts after loading

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108643

Bug ID: 108643
   Summary: Strange placeholders appear for charts after loading
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu
CC: azeemmys...@gmail.com, michael.me...@collabora.com

Created attachment 134147
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134147=edit
Document with charts

Open the attached document that contain many charts.
Scroll through it quickly right after it finished loading.

=> Strange placeholder images appear in place of charts (see screenshot, the
quicker the scrolling the worse it looks).
After scrolling back and forth the placeholders are replaced with the charts
themselves (happens almost right away in this document, but can take a while in
more complex ones).

Reproduced with LO 5.4beta2, 5.3.0.3 / Windows 7. Not reproduced with 5.2.0.4.
=> regression

Bibisecting using repo bibisect-win32-5.3 pointed to the commit referenced
below. Adding Cc: to Mohammed Abdul Azeem and Michael Meeks. Please take a look
sometimes.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5678bc99fb685fe09191e8419a1121e565f97f80
author  Mohammed Abdul Azeem 2016-09-25
05:36:32 (GMT)
committer   Noel Grandin  2016-09-25
13:22:51 (GMT)

"tdf#101935 and tdf#102201: This fixes both the bugs."

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 107996] FORMATTING: Watermark feature in page style dialog

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107996

Yousuf Philips (jay)  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |philip...@hotmail.com
   |.freedesktop.org|

--- Comment #7 from Yousuf Philips (jay)  ---
Yes it will be implemented in the Page style dialog once all the work in the
dialog has been completed, as discussed with Syzmon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 107996] FORMATTING: Watermark feature in page style dialog

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107996

Yousuf Philips (jay)  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |philip...@hotmail.com
   |.freedesktop.org|

--- Comment #7 from Yousuf Philips (jay)  ---
Yes it will be implemented in the Page style dialog once all the work in the
dialog has been completed, as discussed with Syzmon.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/uiconfig

2017-06-19 Thread Yousuf Philips
 sw/uiconfig/swriter/menubar/menubar.xml |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 60442414758cf5895143c8b6a8211797037ec3c8
Author: Yousuf Philips 
Date:   Tue Jun 20 05:24:02 2017 +0400

fix messup of 6ef59d7ace7e4db52caea601a384ed016365bcaf

Change-Id: Iddbe19638796564f5d443f6376b95ad7d69ecf0e
Reviewed-on: https://gerrit.libreoffice.org/38989
Reviewed-by: Yousuf Philips 
Tested-by: Yousuf Philips 

diff --git a/sw/uiconfig/swriter/menubar/menubar.xml 
b/sw/uiconfig/swriter/menubar/menubar.xml
index 94056a65d2e2..8579a78cd43f 100644
--- a/sw/uiconfig/swriter/menubar/menubar.xml
+++ b/sw/uiconfig/swriter/menubar/menubar.xml
@@ -694,7 +694,7 @@
   
   
   
-  104845
+  
   
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/uiconfig

2017-06-19 Thread Yousuf Philips
 sw/uiconfig/swriter/menubar/menubar.xml |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 6ef59d7ace7e4db52caea601a384ed016365bcaf
Author: Yousuf Philips 
Date:   Tue Jun 20 05:15:53 2017 +0400

tdf#91781 Move watermark from insert to format menu

Change-Id: I747562462accc49e7f3dc851e1ebb274e36b93d7
Reviewed-on: https://gerrit.libreoffice.org/38988
Reviewed-by: Yousuf Philips 
Tested-by: Yousuf Philips 

diff --git a/sw/uiconfig/swriter/menubar/menubar.xml 
b/sw/uiconfig/swriter/menubar/menubar.xml
index 1a6e46cc9d13..94056a65d2e2 100644
--- a/sw/uiconfig/swriter/menubar/menubar.xml
+++ b/sw/uiconfig/swriter/menubar/menubar.xml
@@ -267,7 +267,6 @@
 
   
   
-  
   
   
   
@@ -453,6 +452,7 @@
   
   
   
+  
   
   
   
@@ -694,7 +694,7 @@
   
   
   
-  
+  104845
   
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 104845] [META] DOC formula-related issues

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104845

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||39750


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=39750
[Bug 39750] [META] General Math formula editor improvements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104526] [META] DOCX formula-related issues

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104526

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||39750


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=39750
[Bug 39750] [META] General Math formula editor improvements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 39750] [META] General Math formula editor improvements

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=39750

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||104526, 104845


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104526
[Bug 104526] [META] DOCX formula-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104845
[Bug 104845] [META] DOC formula-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 61174] [META] Rework of Recent Documents List, options to prevent logging and to manage entries on the list

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61174

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||51618


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=51618
[Bug 51618] File open dialog doesn't open in folder of document previously
opened through Recent Documents list
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 102732] [META] File dialog bugs and enhancements

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102732

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||51618


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=51618
[Bug 51618] File open dialog doesn't open in folder of document previously
opened through Recent Documents list
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61174] [META] Rework of Recent Documents List, options to prevent logging and to manage entries on the list

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61174

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||51618


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=51618
[Bug 51618] File open dialog doesn't open in folder of document previously
opened through Recent Documents list
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51618] File open dialog doesn' t open in folder of document previously opened through Recent Documents list

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51618

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
 Blocks||61174, 102732
Summary|Add 'Copy path of open  |File open dialog doesn't
   |file' command to the menu   |open in folder of document
   |of Recent used documents|previously opened through
   ||Recent Documents list

--- Comment #8 from Yousuf Philips (jay)  ---
Personally i would be against this enhancement as i think the current behaviour
if fine as it opens back to the last path previously gone to in the file dialog
and i believe others may file a regression bug report to return back the
previous behaviour.

But if this is to be implemented, the simplest solution is that if a document
is opened through the Recent Documents list, that the document's path would be
used the next time the file open dialog is opened, just like we use the
currently opened document's path when opening the save as dialog.

UX-Team: Your thoughts?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=61174
[Bug 61174] [META] Rework of Recent Documents List, options to prevent logging
and to manage entries on the list
https://bugs.documentfoundation.org/show_bug.cgi?id=102732
[Bug 102732] [META] File dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108622] EDITING: Auto-correct while typing keeps trying access acor_und.dat and acor_en.dat

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108622

Aron Budea  changed:

   What|Removed |Added

   Keywords||perf
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Confirmed with LO 5.4beta2 / Windows 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108631] ENHANCEMENT: Optimization of the file-save strategy

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108631

Aron Budea  changed:

   What|Removed |Added

   Keywords||perf
 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #2 from Aron Budea  ---
Confirmed with LO 5.4beta2.
For me it's even more than 450 MB, something close to the ~580 MB of
content.xml.

I'm not touching severity, but I'd rather consider this a performance bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108642] FILEOPEN: document with a complex table structure takes double the time to open when the sidebar is enabled

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108642

Xisco Faulí  changed:

   What|Removed |Added

 OS|All |Linux (All)

--- Comment #2 from Xisco Faulí  ---
It seems to open in just a few seconds in

Versión: 5.3.3.2
Id. de compilación: 3d9a8b4b4e538a85e0782bd6c2d430bafe583448
Subproc. CPU: 1; SO: Windows 6.1; Repr. de IU: predet.; Motor de trazado:
HarfBuzz; 
Configuración regional: es-ES (es_ES); Calc: group

Thus, Linux only

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108361] Scrolling a complex table structure seems to be slower as before

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108361

--- Comment #5 from Xisco Faulí  ---
Nevermind, I've already reported it in bug 108642

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108642] FILEOPEN: document with a complex table structure takes double the time to open when the sidebar is enabled

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108642

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected, perf,
   ||regression, wantBacktrace
 Status|UNCONFIRMED |NEW
 CC||s.mehrbr...@gmail.com,
   ||xiscofa...@libreoffice.org
Version|5.3.3.2 release |4.4 all versions
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Samuel Mehrbrodt 2014-08-22 20:37:56
(GMT)
committer   Thomas Arnhold  2014-08-24 11:26:17
(GMT)
commit  b4558b508141af16d335f45a0f12bdd34521e944 (patch)
treef8479fe8131a0d1677100e2cc16c244e860189cb
parent  a75e0f8e4e5f0baa5805d01c5f8edc7b40fceb0f (diff)
fdo#73151 Make better use of the sidebar
The general idea is to encourage use of the sidebar instead of floating windows
(for Navigator, Styles and Gallery)

Changes:
* Show the sidebar by default in Writer & Impress
* Remove the Gallery floating window (Gallery now always opens in the sidebar)
* Remove all Gallery, Navigator and Styles links from the default
toolbar in Writer
  (since they have an icon in the sidebar and the sidebar is shown by default
now)
* When selecting "More" from the Styles dropdown, the Stylelist opens in the
sidebar instead of the floating window

Bisected with bibisect-44max

Adding Cc: to Samuel Mehrbrodt

In

Version: 4.4.0.0.alpha0+
Build ID: b4558b508141af16d335f45a0f12bdd34521e944

it takes

real4m17.950s
user4m11.596s
sys 0m0.400s

while in

Version: 4.4.0.0.alpha0+
Build ID: a75e0f8e4e5f0baa5805d01c5f8edc7b40fceb0f (Previous Commit )

it takes 

real1m47.564s
user1m39.744s
sys 0m0.444s

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108642] New: FILEOPEN: document with a complex table structure takes double the time to open when the sidebar is enabled

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108642

Bug ID: 108642
   Summary: FILEOPEN: document with a complex table structure
takes double the time to open when the sidebar is
enabled
   Product: LibreOffice
   Version: 5.3.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps to reproduce:
1. Open attachment 133874 from bug 108361

In

Version: 5.3.3.2
Build ID: 1:5.3.3~rc2-0ubuntu0.16.10.1~lo0
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Layout
Engine: new; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

without the sidebar it takes

real2m10.252s
user2m5.484s
sys 0m0.188s

while with the sidebar

real6m6.350s
user6m5.812s
sys 0m0.204s

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108637] Memory usage has increased for creating a document with lots of empty sheets

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108637

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
I think undo usage of memory has somerhinf to do with that, a lot of undo
issues have been solved along the time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108638] FORMATTING Text size is not scaled correctly according to the zoom factor

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108638

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
I'm not sure it's a bug, font proportions have not to be the aame of the screen
resolurion

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108641] Bibliography does not pick up added entries from the database

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108641

--- Comment #4 from Ben  ---
This is an issue since OpenOffice. I hope this gets resolved soon because I'm
running against a publication deadline.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 92419] delete referenced cell - raise error

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92419

--- Comment #14 from Ferdinand  ---
Hi 
I just want to recall the necessity to handle this problem as it is still not
addressed after 2 years in 5.3.3.2.

please will this feature be made available in 5.4 as suggested in comment 6?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 92419] delete referenced cell - raise error

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92419

--- Comment #14 from Ferdinand  ---
Hi 
I just want to recall the necessity to handle this problem as it is still not
addressed after 2 years in 5.3.3.2.

please will this feature be made available in 5.4 as suggested in comment 6?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108641] Bibliography does not pick up added entries from the database

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108641

--- Comment #3 from Ben  ---
Created attachment 134146
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134146=edit
Bibliography Edit Index

Year is specified but does not appear in Bibliography

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108641] Bibliography does not pick up added entries from the database

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108641

--- Comment #2 from Ben  ---
Created attachment 134145
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134145=edit
Bibliography database

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108555] Add line spacing feature to cell properties

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108555

--- Comment #5 from Eike Rathke  ---
Fwiw, you can also change the row height and under Format Cells Alignment
change Vertical to Distributed and activate "Wrap text automatically".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108641] Bibliography does not pick up added entries from the database

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108641

--- Comment #1 from Ben  ---
Created attachment 134144
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134144=edit
Bibliography entries do not get picked up from database

See highlights in screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108555] Add line spacing feature to cell properties

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108555

--- Comment #4 from Eike Rathke  ---
Yes. I see an interoperability nightmare.

If you really have that much text in a spreadsheet cell that you need
individual line spacing then better use a text box ie. rectangle shape, which
does support line spacing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108641] New: Bibliography does not pick up added entries from the database

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108641

Bug ID: 108641
   Summary: Bibliography does not pick up added entries from the
database
   Product: LibreOffice
   Version: 5.4.0.0.alpha1+
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bba...@gmail.com

After:
- Creating entities in the Bibliography data base
- Creating a bibliography
- Creating Bibliography entries in the document
- Running Update index, the Bibliography does not pick up entries from the
database. I have the impression that the first time I ran the Update index it
was ok but after adding new entries to the database it generated partial
results. See attachments.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


GSoC weekly update - Solving MABs for Android Viewer - Ximeng Zu

2017-06-19 Thread Ximeng Zu
Hello,

 

Last week I completed developing presentation mode for Android Viewer. It's
now under review. I also completed initial setup for adding Calc UI to
Android Viewer. Now the headers align with the main content of the document.
Next step is to make the headers update with user interaction.

 

Best,

Ximeng Zu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 104461] [META] DOCX frame-related issues

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104461

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||107656


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107656
[Bug 107656] [META] Frame bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107656] [META] Frame bugs and enhancements

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107656

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||104461


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104461
[Bug 104461] [META] DOCX frame-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108640] [META] Object meta bugs and enhancements

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108640

--- Comment #1 from Yousuf Philips (jay)  ---
Base meta bug for all object types including shapes, images, OLE, text boxes,
frames, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103152

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||108640


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108640
[Bug 108640] [META] Object meta bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108640] [META] Object meta bugs and enhancements

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108640

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl,
   ||vstuart.fo...@utsa.edu
 Depends on||103152
 Ever confirmed|0   |1


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
[Bug 103152] [META] Writer image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 100155] [META] Improve object selection and alignment

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100155

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||108640


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108640
[Bug 108640] [META] Object meta bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94722] [META] Object fill bugs and enhancements

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94722

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||108640


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108640
[Bug 108640] [META] Object meta bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 100155] [META] Improve object selection and alignment

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100155

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||108640


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108640
[Bug 108640] [META] Object meta bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 107810] [META] OLE/Embedded object bugs and enhancements

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107810

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||108640


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108640
[Bug 108640] [META] Object meta bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108640] New: [META] Object meta bugs and enhancements

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108640

Bug ID: 108640
   Summary: [META] Object meta bugs and enhancements
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Depends on: 94722, 100155, 107810


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=94722
[Bug 94722] [META] Object fill bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=100155
[Bug 100155] [META] Improve object selection and alignment
https://bugs.documentfoundation.org/show_bug.cgi?id=107810
[Bug 107810] [META] OLE/Embedded object bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 100155] [META] Improve object selection and alignment

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100155

Yousuf Philips (jay)  changed:

   What|Removed |Added

  Alias|Objects |Object-Selection-Alignment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 100155] [META] Improve object selection and alignment

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100155

Yousuf Philips (jay)  changed:

   What|Removed |Added

  Alias|Objects |Object-Selection-Alignment

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 103866] Formula Vertical Alignment issue

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103866

--- Comment #9 from Ben  ---
Created attachment 134143
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134143=edit
PDF document with mis-alignment issues

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103866] Formula Vertical Alignment issue

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103866

--- Comment #8 from Ben  ---
Created attachment 134142
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134142=edit
odt document with mis-alignment issues

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103866] Formula Vertical Alignment issue

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103866

Ben  changed:

   What|Removed |Added

Summary|Formula font change |Formula Vertical Alignment
   ||issue

--- Comment #7 from Ben  ---
Version: 5.4.0.0.alpha1 (x64)

More issues identified in the attached document. It also ripples over into the
PDF document (also attached) where you can see the alignment issues even
better.

I also created formulas in a completely new document with the same effect.

In the latest development version, when clicking on some formulas, the
mis-alignment issue seemed to be reduced a bit.

I hope this issue gets resolved soon. It has been around for many years and i'm
getting close to a publication deadline.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/inc sc/source

2017-06-19 Thread Eike Rathke
 sc/inc/column.hxx   |1 -
 sc/source/core/data/column.cxx  |3 ---
 sc/source/core/data/column2.cxx |2 --
 3 files changed, 6 deletions(-)

New commits:
commit 96a307be540fd609bed5b1a35dfe27d7e6652f21
Author: Eike Rathke 
Date:   Tue Jun 20 00:21:57 2017 +0200

Remove unused ScColumn::mbDirtyGroups

Change-Id: If8ed724ccec136653db5fcf43f9e74a82826add7

diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index e4700e9e6e48..68784b9bd932 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -142,7 +142,6 @@ class ScColumn
 
 ScAttrArray*  pAttrArray;
 ScDocument*   pDocument;
-bool mbDirtyGroups; /// formula groups are dirty.
 
 size_t mnBlkCountFormula;
 
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 9d68fbf8381b..b1acc841a0ca 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -91,7 +91,6 @@ ScColumn::ScColumn() :
 nTab( 0 ),
 pAttrArray( nullptr ),
 pDocument( nullptr ),
-mbDirtyGroups(true),
 mnBlkCountFormula(0)
 {
 maCells.resize(MAXROWCOUNT);
@@ -1911,8 +1910,6 @@ void ScColumn::SwapCol(ScColumn& rCol)
 pAttrArray->SetCol(nCol);
 rCol.pAttrArray->SetCol(rCol.nCol);
 
-std::swap(mbDirtyGroups, rCol.mbDirtyGroups);
-
 // Reset column positions in formula cells.
 resetColumnPosition(maCells, nCol);
 resetColumnPosition(rCol.maCells, rCol.nCol);
diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index 162fbcff9b95..890e319e3d22 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -1504,8 +1504,6 @@ void ScColumn::CellStorageModified()
 {
 // TODO: Update column's "last updated" timestamp here.
 
-mbDirtyGroups = true;
-
 #if DEBUG_COLUMN_STORAGE
 if (maCells.size() != MAXROWCOUNT)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 108361] Scrolling a complex table structure seems to be slower as before

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108361

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #4 from Xisco Faulí  ---
Hi Telesto,
have you reported the opening time in another bug as well? I see than in
version  4.3.0.0.alpha1+ it takes 1m50.886s while in master it takes 4m31.369s.
let me know whether you have reported, and I'll do it if not...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107528] Hebrew text partially garbled since some Hebrew fonts are rendered as other Hebrew fonts

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107528

--- Comment #13 from Eyal Rozenberg  ---
I would like to ask that the severity of this issue be increased. It becomes
nigh-impossible to edit many documents, as one can't simply change the fonts of
all text; numbering, footnote references, text with a combination of many
styles and fonts etc. requires painstaking corrections. What's more,
collaboration with people using Word becomes very difficult, again if not
impossible, since the typical Hebrew fonts used on Windows are among those that
are rendered as other fonts and garbled (e.g. David).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107528] Hebrew text partially garbled since some Hebrew fonts are rendered as other Hebrew fonts

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107528

Eyal Rozenberg  changed:

   What|Removed |Added

Summary|Hebrew fonts rendered as|Hebrew text partially
   |_other_ Hebrew fonts|garbled since some Hebrew
   ||fonts are rendered as other
   ||Hebrew fonts

--- Comment #12 from Eyal Rozenberg  ---
I want to stress

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 97395] FILEOPEN: Libre Office odb crashes when try to open tables

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=97395

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #25 from Xisco Faulí  ---
i can't reproduce the crash in

Versión: 5.3.3.2
Id. de compilación: 3d9a8b4b4e538a85e0782bd6c2d430bafe583448
Subproc. CPU: 1; SO: Windows 6.1; Repr. de IU: predet.; Motor de trazado:
HarfBuzz; 
Configuración regional: es-ES (es_ES); Calc: group

and table are seen when clicking on 'Tables'

Closing as RESOLVED WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108639] Mouse Selection is Broken-Limits range user can select

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108639

--- Comment #2 from Kevin  ---
note: I realized that having the mouse only select chunks of characters
delimited by spaces is a feature of many programs but that's not what's
happening here - it allows selection within the 3rd and 4th chunks, but not
within the 2nd chunk - whether the "select whole words" type of feature is in
force or not (I'm not sure if this feature is part of Calc) the behavior shown
here is inconsistent.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Changes to 'feature/cib_contract152'

2017-06-19 Thread Vasily Melenchuk
New branch 'feature/cib_contract152' available with the following commits:
commit 948597b55990da44c8d58851f63450ed11d4f7ca
Author: Vasily Melenchuk 
Date:   Thu May 25 13:44:52 2017 +0300

tdf#99680 modified clipping for PDF export

If clipping is requested, but no clipping region is defined,
clipping is ignored.

This squashes the following 3 commits:

Reviewed-on: https://gerrit.libreoffice.org/38021
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

Reviewed-on: https://gerrit.libreoffice.org/38403
Tested-by: Jenkins 
Reviewed-by: Miklos Vajna 

Reviewed-on: https://gerrit.libreoffice.org/38694
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/38825
Tested-by: Thorsten Behrens 
(cherry picked from commit f6726209329fefe9decca8fda8e136b8472a95a2)

Conflicts:
vcl/qa/cppunit/pdfexport/pdfexport.cxx
no pdf unit tests on -5-3, so dropping those pieces

Change-Id: I793c1de1f4f6b0203727c0ff6aa8adecc43ad413
d4565858b0135b3177044558db87a68ef828955b
102722140e216cb9ad29107aae3bdaa70472d471

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 108639] Mouse Selection is Broken-Limits range user can select

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108639

Kevin  changed:

   What|Removed |Added

 CC||timbacont...@gmail.com

--- Comment #1 from Kevin  ---
Created attachment 134141
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134141=edit
steps and demo for 108639

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108639] New: Mouse Selection is Broken-Limits range user can select

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108639

Bug ID: 108639
   Summary: Mouse Selection is Broken-Limits range user can select
   Product: LibreOffice
   Version: 5.3.3.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: timbacont...@gmail.com

Description:
clicking and dragging fails to work in some cases

Steps to Reproduce:
1. load attached spread - detailed steps are included in the .ODS file


Actual Results:  
you can't select certain ranges of characters within a cell using the mouse

Expected Results:
you should be able to select characters just as you do with Notepad or any
other program


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/58.0.3029.110 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108638] New: FORMATTING Text size is not scaled correctly according to the zoom factor

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108638

Bug ID: 108638
   Summary: FORMATTING Text size is not scaled correctly according
to the zoom factor
   Product: LibreOffice
   Version: 5.3.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stefan_lange...@t-online.de

Created attachment 134140
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134140=edit
spreadsheet to demonstrate the behavior

When the zoom factor to display a spreadsheet is changed, the text size (width
and height) of cell contents is not correctly scaled according the zoom factor.
This results in change of places where text is wrapped and/or the text doesn't
fit to cell size.

Steps to reproduce:
- open the attached spreadsheet document "Test_Text_Width_V2.ods"
- when document is opened, zoom factor is 100%, the contents in cell A1 fits to
the cell, text "This is a test example to demonstate the behavior." is wrapped
into 3 parts:

This is a test example
to demonstate the be-
havior. 

- change zoom factor by menu or by - / + in the right upper corner

Expected behavior: 
Text fits to the cell and places where text is wrapped remain unchanged also
when zoom factor is enlarged or decreased - how it is in Writer!

Actual behavior:
When zoom factor is enlarged or decreased, the text is wrapped on other places
and/or text doesn't fit to the correctly scaled (?) cell size (--> red arrow
appears).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104589] Whenever a Writer document gets restored from the taskbar around 300KB gets written (even when the document is empty or saved before)

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104589

Aron Budea  changed:

   What|Removed |Added

 Blocks||108636


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108636
[Bug 108636] [META] Extensive file accesses
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108636] [META] Extensive file accesses

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108636

Aron Budea  changed:

   What|Removed |Added

 Depends on||108622, 104589


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104589
[Bug 104589] Whenever a Writer document gets restored from the taskbar around
300KB gets written (even when the document is empty or saved before)
https://bugs.documentfoundation.org/show_bug.cgi?id=108622
[Bug 108622] EDITING: Auto-correct while typing keeps trying access
acor_und.dat and acor_en.dat
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108622] EDITING: Auto-correct while typing keeps trying access acor_und.dat and acor_en.dat

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108622

Aron Budea  changed:

   What|Removed |Added

 Blocks||108636


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108636
[Bug 108636] [META] Extensive file accesses
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94942] Corrupt dialog under 5.0.2.2 (Format -> Cells -> Border-> Width)

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94942

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #9 from Xisco Faulí  ---
I'll set this to WFM and add the whiteboard corruptProfile, which was just
suggested on the mailing list:
http://lists.freedesktop.org/archives/libreoffice-qa/2015-October/009104.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104742] [META] Network-involved bugs

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104742

Aron Budea  changed:

   What|Removed |Added

 Depends on||57765


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=57765
[Bug 57765] FILEOPEN via FTP from Server causes General Error
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 57765] FILEOPEN via FTP from Server causes General Error

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=57765

Aron Budea  changed:

   What|Removed |Added

 Blocks||104742


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104742
[Bug 104742] [META] Network-involved bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106923] Media player "View" disabled, videos too small in Slideshow

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106923

Xisco Faulí  changed:

   What|Removed |Added

Version|5.3.1.2 release |4.4 all versions

--- Comment #6 from Xisco Faulí  ---
Changing back to the earliest affected version

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106923] Media player "View" disabled, videos too small in Slideshow

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106923

Kara  changed:

   What|Removed |Added

Version|4.4 all versions|5.3.1.2 release

--- Comment #5 from Kara  ---
It stopped working since version 5; still not working in Version: 5.3.1.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108631] ENHANCEMENT: Optimization of the file-save strategy

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108631

Telesto  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: bridges/source

2017-06-19 Thread Stephan Bergmann
 bridges/source/cpp_uno/gcc3_macosx_x86-64/except.cxx |   20 +++
 1 file changed, 20 insertions(+)

New commits:
commit 7a9dd3d482deeeb3ed1d50074e56adbd3f928296
Author: Stephan Bergmann 
Date:   Mon Jun 19 21:48:12 2017 +0200

Hack to dynamically adapt to __cxa_exceptiom in LLVM 5.0 libcxxabi

Change-Id: Ibf6379425d312b2cc2c9d663a65d0e02209f74e4
Reviewed-on: https://gerrit.libreoffice.org/38981
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/bridges/source/cpp_uno/gcc3_macosx_x86-64/except.cxx 
b/bridges/source/cpp_uno/gcc3_macosx_x86-64/except.cxx
index 53fb3c8cabc0..1d1eeccd97ae 100644
--- a/bridges/source/cpp_uno/gcc3_macosx_x86-64/except.cxx
+++ b/bridges/source/cpp_uno/gcc3_macosx_x86-64/except.cxx
@@ -256,6 +256,26 @@ std::type_info * RTTI::getRTTI( 
typelib_CompoundTypeDescription *pTypeDescr )
 static void deleteException( void * pExc )
 {
 __cxa_exception const * header = static_cast<__cxa_exception const 
*>(pExc) - 1;
+// The libcxxabi commit
+// 
+// "[libcxxabi] Align unwindHeader on a double-word boundary" towards
+// LLVM 5.0 changed the size of __cxa_exception by adding
+//
+//   __attribute__((aligned))
+//
+// to the final member unwindHeader, on x86-64 effectively adding a hole of
+// size 8 in front of that member (changing its offset from 88 to 96,
+// sizeof(__cxa_exception) from 120 to 128, and alignof(__cxa_exception)
+// from 8 to 16); a hack to dynamically determine whether we run against a
+// new libcxxabi is to look at the exceptionDestructor member, which must
+// point to this function (the use of __cxa_exception in fillUnoException 
is
+// unaffected, as it only accesses members towards the start of the struct,
+// through a pointer known to actually point at the start):
+if (header->exceptionDestructor != ) {
+header = reinterpret_cast<__cxa_exception const *>(
+reinterpret_cast(header) - 8);
+assert(header->exceptionDestructor == );
+}
 typelib_TypeDescription * pTD = nullptr;
 OUString unoName( toUNOname( header->exceptionType->name() ) );
 ::typelib_typedescription_getByName( , unoName.pData );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 104296] VIEWING: Relatively slow scrolling in GDI mode if a simple GIF-file is embedded

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104296

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #5 from Xisco Faulí  ---
To me, in

Version: 6.0.0.0.alpha0+
Build ID: 08f6f9dded1b142b858c455da03319abac691655
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

GIF and JPG have a similar behaviour

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108041] Calc fails to correctly identify the font used in a cell and fails to obey format and font changes

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108041

--- Comment #17 from Kevin  ---
If you experiment with the file created entirely within 5.3.3.2 you can get all
sorts of interesting variations on the bug. For example:

1. Select only D15 and D16
2. change font size to 12 pt
result: It does indeed change all characters to 12 pt, but it removes all other
attributes like bold
3. repeat with only D13 selected
result: It behaves correctly, retaining all attributes other than size

CORE BUG: A character has a variety of attributes - font face, size, bold,
italic, underline, superscript, color. The user expectation is to be able to
deal with these attributes INDIVIDUALLY - e.g., to change the size WITHOUT
changing the other attributes. This is what the rest of the world thinks of
when they think of "styles". In any other suite of programs you can create a
style called "12 pt" that will change everything selected to 12 pt and do
NOTHING ELSE - whether the selection is a range of characters within a cell, or
a range of cells within the spreadsheet. In lieu of having working styles,
which Calc most certainly does not in spite of the fanfare surround the release
of this "feature", it's even more important that they user should be able
select multiple cells and use formatting toolbar to workaround the lack of
style functionality that has been present in Microsoft for decades.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106307] Wrong shape for numerals, based on locale and not the text language

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106307

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||xiscofa...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107039] Crash on Close after acknowledging save changes - mutex issue

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107039

--- Comment #14 from Matt  ---
Tested on 5.3.3.2 (x64), reproduced the same bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108636] [META] Extensive file accesses

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108636

Telesto  changed:

   What|Removed |Added

 Depends on||104696


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104696
[Bug 104696] LibO keeps searching for tool tips when hoovering over toolbars,
if a corresponding helppack is missing and disabling it isn't possible; see
comment 5
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104696] LibO keeps searching for tool tips when hoovering over toolbars, if a corresponding helppack is missing and disabling it isn't possible; see comment 5

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104696

Telesto  changed:

   What|Removed |Added

 Blocks||108636


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108636
[Bug 108636] [META] Extensive file accesses
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 48344] Windows shell 'OpenDocument Text' template uses A4 page size rather than locale default

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=48344

--- Comment #16 from Heiko Tietze  ---
(In reply to Cor Nouws from comment #15)
> So this issue is closed because it is not an easy hack and no comment from a
> developer showing interest or explaining that it is an easy hack.

Whether EH or not, no interest over years is an argument to close the ticket.
No problem if you want to reopen the ticket, but please have a second opinion
to do so (not the OP of course).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107039] Crash on Close after acknowledging save changes - mutex issue

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107039

--- Comment #13 from Xisco Faulí  ---
Could you please try to reproduce it with a master build from
http://dev-builds.libreoffice.org/daily/master/ ?
You can install it alongside the standard version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108041] Calc fails to correctly identify the font used in a cell and fails to obey format and font changes

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108041

--- Comment #20 from Kevin  ---
Created attachment 134139
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134139=edit
file for comment 19

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108041] Calc fails to correctly identify the font used in a cell and fails to obey format and font changes

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108041

--- Comment #19 from Kevin  ---
(In reply to Buovjaga from comment #14)

Here you go: 108041-with steps to create your own from scratch.ods - attached

This will allow you to reproduce the bug from absolute scratch on your own
system. The symptom reproduced with this scaled back version may cause you to
say "oh, well, it's trivial because there are many cases where it works
properly (for example selection the first 2 cells only)" - but this bug works
like a mushroom cloud once you start working with a spreadsheet. I'm currently
trying to show you one simple symptom with an absolute minimum of steps and
required complications. I'm almost certain that everything else stems from some
very simple flaw in the code, and that the whole problem of Calc and formatting
stems from the misunderstanding of what the word "style" means to your users.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107039] Crash on Close after acknowledging save changes - mutex issue

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107039

--- Comment #12 from Matt  ---
I am running 5.3.1.2 and I can reproduce it.

1.Open attached GarageDatabase2.odb. Recover if necessary.
2.Edit OtherMaintenanceForm. Delete something.
3.Save (click disk icon) and close the form edit window (File | Close).
4. Press red X in upper right of Base to close down. 
5. Answer appropriately to save changes (not sure why it asks me this...the
changes should be saved already since it is a database, but whatever).
6. Base hangs.
7. Changes are lost.

A couple of times it worked, but it still often reproduces the bug.

I'm running on Windows 7 Pro, NOT MAC.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108041] Calc fails to correctly identify the font used in a cell and fails to obey format and font changes

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108041

--- Comment #18 from Kevin  ---
Created attachment 134138
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134138=edit
bare bones steps with only calibri and courier new in virgin file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108041] Calc fails to correctly identify the font used in a cell and fails to obey format and font changes

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108041

--- Comment #16 from Kevin  ---
Created attachment 134137
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134137=edit
file created entirely within 5.3.3.2 - no prestige elite

I accidentally uploaded this to the wrong report earlier. This file is created
totally from scratch. Prestige Elite and Excel are not involved. All you have
to do is create new cells that use more than one font and mixed attributed like
superscript, bold, and grey font color. At a certain point you will lose the
ability to do a mass-change of all of the font sizes (or other attributes) of a
selection of more than one cell.

The ability to select a range of cells and change them all to 10 pt size is not
minor or trivial or an enhancement. It's a fundamental requirement of the
program. This is why I'm so horrified that you guys did all the work to add
what you ironically call "styles" without allowing a "style" than lets you
change only one class of attribute such as changing to 10 pt and NOT changing
anything else. So not only is "styles" a cruel joke, but the user can't even
manually select a range of cells and change the desired attribute with the
formatting toolbar - much less save time with "styles".

I have now been using this program full time for almost 2 months - 7 days a
week - no formulas, no math - just formatting. It is broken - not trivially
broken, not broken in a minor way, not broken in an "enhancement request" way -
it is fundamentally broken.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108404] Calc changes the font attributes of selected text in unpredictable ways

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108404

--- Comment #6 from Kevin  ---
Created attachment 134136
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134136=edit
reproduces bug from scratch in new document - no prestige elite ever used

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108041] Calc fails to correctly identify the font used in a cell and fails to obey format and font changes

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108041

--- Comment #15 from Kevin  ---
(In reply to Buovjaga from comment #14)

Did you try my new file?

I briefly experimented with substituting Prestige Elite for Courier New because
I thought it might work better for the b and # symbols, but I abandoned the
idea and have removed all instances of Prestige Elite from my document. Only a
small fraction of the cells ever had prestige elite applied to them. The cells
I copied to create the new attachment
(https://bugs.documentfoundation.org/attachment.cgi?id=134126) never had
Prestige Elite as far as I know.

I don't understand the approach to this bug. Why does the history of the
document matter. I would expect Calc to be able to open any .xlsx or .ods and
"cleanse" each cell of any strange headers or xml or whatever other kind of
coding and put them into the clean orderly format that Calc expects to see when
it creates its own document. The ability to open pre-existing Excel files
without corrupting them has got to be near the top of the list of requirements

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 46527] FILESAVE: Duplicate the File Types List under "Save as..." to "Export..."

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=46527

--- Comment #13 from famo  ---
(In reply to Cor Nouws from comment #12)
> (In reply to famo from comment #11)
> > (In reply to Cor Nouws from comment #10)
> > > So your wish is for e.g. xls file format, you want the option to save your
> > > active ods file as xls, but continue to work in the ods file.
> > > 
> > That's right! Same for csv and probably all of the "Save as" file types.
> 
> I agree with Jay & Heiko that it would be confusing, non functional for e.g.
> export as graphics.
> I even think the list of useful extensions, is shorter than the non-useful
> ones.
> 
I don't quite understand this part. PNG is already available under Export which
is fine and should stay there.
This issue is only about the options under Export.

> > > Looks as a reasonable request to me.
> > > 
> > My thoughts exactly!
> 
> But for the UI-design a merge/combination of both lists, as you suggest, is
> not the first I would think of.

Did I?
My wording is probably not the best, but I merely wanted e.g. xls and csv
available as option under Export.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106661] CTRL + mouse/scrollwheel zoom does not work in print preview

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106661

--- Comment #4 from Buovjaga  ---
Does not work in master (Win only).

Win 10
Version: 6.0.0.0.alpha0+ (x64)
Build ID: 2404a17e157273430d40ceaa1ab1275e7b50ba6e
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-06-16_23:41:27
Locale: fi-FI (fi_FI); Calc: group

Works in:
Version: 5.3.3.2 (x64)
Build ID: 3d9a8b4b4e538a85e0782bd6c2d430bafe583448
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine:
new; 
Locale: fi-FI (fi_FI); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 100925] When overwriting a cell, new content is displayed on top of the old content until finishing the edit

2017-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100925

--- Comment #50 from Bernhard Frauendienst 
 ---
Does this help, or is there any more useful information I can provide?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   >