GSoC Weekly Report 5 & 6 | Revamp the Customization Dialog - Muhammet Kara

[Muhammet Kara]

Hello world,

In the 5th and 6th weeks of GSoC, I have (mostly) completed the 
separation of subclasses of SvxConfigPage, created a util class to 
contain helper functions of these classes, and refactored a few of the 
contained functions.


This week, I'll work on creating a custom widget for the categories 
listbox which will be on the new dialog, then I'll start converting one 
of the existing tabs.


You may watch the progress on gerrit.[0]

Cheers,
Muhammet

[0] http://bit.ly/customize17gerrit

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/source

[Mohammed Abdul Azeem]

 sc/source/filter/xml/XMLTrackedChangesContext.cxx | 1071 +-
 sc/source/filter/xml/XMLTrackedChangesContext.hxx |5 
 2 files changed, 480 insertions(+), 596 deletions(-)

New commits:
commit 85ff2eafc692f6f0d33ac611600935a96058f20a
Author: Mohammed Abdul Azeem 
Date:   Thu Jul 13 23:32:46 2017 +0530

Moving legacy contexts to FastContexts:

ScXMLTrackedChangesContext
ScXMLChangeInfoContext
ScXMLBigRangeContext
ScXMLCellContentDeletionContext
ScXMLDependenceContext
ScXMLDependingsContext
ScXMLChangeDeletionContext
ScXMLDeletionsContext
ScXMLChangeCellContext
ScXMLPreviousContext
ScXMLContentChangeContext
ScXMLInsertionContext
ScXMLDeletionContext
ScXMLMovementContext
ScXMLRejectionContext

Change-Id: I13b657efa47bd037e9f83c39ba8fd0f6b7edba1c
Reviewed-on: https://gerrit.libreoffice.org/39927
Reviewed-by: Michael Meeks 
Tested-by: Jenkins 

diff --git a/sc/source/filter/xml/XMLTrackedChangesContext.cxx 
b/sc/source/filter/xml/XMLTrackedChangesContext.cxx
index 22fc26b133eb..ffe7085ee1f0 100644
--- a/sc/source/filter/xml/XMLTrackedChangesContext.cxx
+++ b/sc/source/filter/xml/XMLTrackedChangesContext.cxx
@@ -49,15 +49,15 @@ class ScXMLChangeInfoContext : public ScXMLImportContext
 sal_uInt32  nParagraphCount;
 
 public:
-ScXMLChangeInfoContext( ScXMLImport& rImport, sal_uInt16 nPrfx, const 
OUString& rLName,
-  const 
css::uno::Reference& xAttrList,
+ScXMLChangeInfoContext( ScXMLImport& rImport, sal_Int32 nElement,
+  const 
css::uno::Reference& xAttrList,
   ScXMLChangeTrackingImportHelper* 
pChangeTrackingImportHelper);
 
 virtual SvXMLImportContext *CreateChildContext( sal_uInt16 nPrefix,
 const OUString& rLocalName,
 const 
css::uno::Reference& xAttrList ) override;
 
-virtual void EndElement() override;
+virtual void SAL_CALL endFastElement( sal_Int32 nElement ) override;
 };
 
 class ScXMLBigRangeContext : public ScXMLImportContext
@@ -65,15 +65,12 @@ class ScXMLBigRangeContext : public ScXMLImportContext
 ScBigRange& rBigRange;
 
 public:
-ScXMLBigRangeContext( ScXMLImport& rImport, sal_uInt16 nPrfx, const 
OUString& rLName,
-  const 
css::uno::Reference& xAttrList,
+ScXMLBigRangeContext( ScXMLImport& rImport, sal_Int32 nElement,
+  const 
css::uno::Reference& xAttrList,
   ScBigRange& rBigRange);
 
-virtual SvXMLImportContext *CreateChildContext( sal_uInt16 nPrefix,
-const OUString& rLocalName,
-const 
css::uno::Reference& xAttrList ) override;
-
-virtual void EndElement() override;
+virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL 
createFastChildContext(
+sal_Int32 nElement, const css::uno::Reference< 
css::xml::sax::XFastAttributeList >& xAttrList ) override;
 };
 
 class ScXMLCellContentDeletionContext : public ScXMLImportContext
@@ -94,15 +91,14 @@ class ScXMLCellContentDeletionContext : public 
ScXMLImportContext
 ScMatrixModenMatrixFlag;
 
 public:
-ScXMLCellContentDeletionContext( ScXMLImport& rImport, sal_uInt16 nPrfx, 
const OUString& rLName,
-  const 
css::uno::Reference& xAttrList,
+ScXMLCellContentDeletionContext( ScXMLImport& rImport, sal_Int32 nElement,
+  const 
css::uno::Reference& xAttrList,
   ScXMLChangeTrackingImportHelper* 
pChangeTrackingImportHelper);
 
-virtual SvXMLImportContext *CreateChildContext( sal_uInt16 nPrefix,
-const OUString& rLocalName,
-const 
css::uno::Reference& xAttrList ) override;
+virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL 
createFastChildContext(
+sal_Int32 nElement, const css::uno::Reference< 
css::xml::sax::XFastAttributeList >& xAttrList ) override;
 
-virtual void EndElement() override;
+virtual void SAL_CALL endFastElement( sal_Int32 nElement ) override;
 };
 
 class ScXMLDependenceContext : public ScXMLImportContext
@@ -110,15 +106,12 @@ class ScXMLDependenceContext : public ScXMLImportContext
 ScXMLChangeTrackingImportHelper*pChangeTrackingImportHelper;
 
 public:
-ScXMLDependenceContext( ScXMLImport& rImport, sal_uInt16 nPrfx, const 
OUString& rLName,
-  const 
css::uno::Reference& 

[Libreoffice-bugs] [Bug 109107] Sidebar' s fontheight field is not updated by moving cursor in an Impress table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109107

Tamás Zolnai  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |zolnaitamas2...@gmail.com
   |desktop.org |
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/qa basic/source

[Takeshi Abe]

 basic/qa/cppunit/test_scanner.cxx |   38 ++
 basic/source/comp/scanner.cxx |2 +-
 2 files changed, 39 insertions(+), 1 deletion(-)

New commits:
commit b9bda1d7916c5474aab89116757fcb7e799458b2
Author: Takeshi Abe 
Date:   Thu Jul 13 19:07:36 2017 +0900

tdf#103104 Allow line-continuation followed by a dot in BASIC

as in VBA-compatibility mode.

Change-Id: If263183fc1fa5742235213a8617fdf412d2a245e
Reviewed-on: https://gerrit.libreoffice.org/39893
Tested-by: Jenkins 
Reviewed-by: Takeshi Abe 

diff --git a/basic/qa/cppunit/test_scanner.cxx 
b/basic/qa/cppunit/test_scanner.cxx
index 509a793f175a..1d6c7f37d4f2 100644
--- a/basic/qa/cppunit/test_scanner.cxx
+++ b/basic/qa/cppunit/test_scanner.cxx
@@ -28,6 +28,7 @@ namespace
 OUString text;
 double number;
 SbxDataType type;
+bool ws;
   };
 
   /**
@@ -46,6 +47,7 @@ namespace
 void testNumbers();
 void testDataType();
 void testHexOctal();
+void testTdf103104();
 
 // Adds code needed to register the test suite
 CPPUNIT_TEST_SUITE(ScannerTest);
@@ -61,6 +63,7 @@ namespace
 CPPUNIT_TEST(testNumbers);
 CPPUNIT_TEST(testDataType);
 CPPUNIT_TEST(testHexOctal);
+CPPUNIT_TEST(testTdf103104);
 
 // End of test suite definition
 CPPUNIT_TEST_SUITE_END();
@@ -87,6 +90,7 @@ namespace
   symbol.text = scanner.GetSym();
   symbol.number = scanner.GetDbl();
   symbol.type = scanner.GetType();
+  symbol.ws = scanner.WhiteSpace();
   symbols.push_back(symbol);
 }
 errors = scanner.GetErrors();
@@ -850,6 +854,40 @@ namespace
 CPPUNIT_ASSERT_EQUAL(cr, symbols[2].text);
   }
 
+  void ScannerTest::testTdf103104()
+  {
+const OUString source1("asdf _\n asdf");
+const OUString source2("asdf. _\n asdf");
+const OUString source3("asdf _\n .asdf");
+
+std::vector symbols;
+
+symbols = getSymbols(source1);
+CPPUNIT_ASSERT_EQUAL(size_t(3), symbols.size());
+CPPUNIT_ASSERT_EQUAL(asdf, symbols[0].text);
+CPPUNIT_ASSERT_EQUAL(asdf, symbols[1].text);
+CPPUNIT_ASSERT(symbols[1].ws);
+CPPUNIT_ASSERT_EQUAL(cr, symbols[2].text);
+
+symbols = getSymbols(source2);
+CPPUNIT_ASSERT_EQUAL(size_t(4), symbols.size());
+CPPUNIT_ASSERT_EQUAL(asdf, symbols[0].text);
+CPPUNIT_ASSERT_EQUAL(dot, symbols[1].text);
+CPPUNIT_ASSERT(!symbols[1].ws);
+CPPUNIT_ASSERT_EQUAL(asdf, symbols[2].text);
+CPPUNIT_ASSERT(symbols[2].ws);
+CPPUNIT_ASSERT_EQUAL(cr, symbols[3].text);
+
+symbols = getSymbols(source3);
+CPPUNIT_ASSERT_EQUAL(size_t(4), symbols.size());
+CPPUNIT_ASSERT_EQUAL(asdf, symbols[0].text);
+CPPUNIT_ASSERT_EQUAL(dot, symbols[1].text);
+CPPUNIT_ASSERT(!symbols[1].ws);
+CPPUNIT_ASSERT_EQUAL(asdf, symbols[2].text);
+CPPUNIT_ASSERT(!symbols[2].ws);
+CPPUNIT_ASSERT_EQUAL(cr, symbols[3].text);
+  }
+
   // Put the test suite in the registry
   CPPUNIT_TEST_SUITE_REGISTRATION(ScannerTest);
 } // namespace
diff --git a/basic/source/comp/scanner.cxx b/basic/source/comp/scanner.cxx
index 48072debbd15..0cf8ed49c6b3 100644
--- a/basic/source/comp/scanner.cxx
+++ b/basic/source/comp/scanner.cxx
@@ -626,7 +626,7 @@ eoln:
 {
 pLine = nullptr;
 bool bRes = NextSym();
-if( bVBASupportOn && aSym.startsWith(".") )
+if( aSym.startsWith(".") )
 {
 // object _
 //.Method
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 109102] RFE Allow to save embedded documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109102

Aron Budea  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|NEW |UNCONFIRMED
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Ever confirmed|1   |0
   Severity|normal  |enhancement

--- Comment #4 from Aron Budea  ---
I don't see the file name anywhere in the raw DOCX, so getting the file name
seems to be impossible.

And even Word doesn't allow saving the embedded document from the right-click
menu in the container file. While I can imagine it as a convenience feature, I
also assume people would normally want to see the embedded document before
saving it, they would rarely want to save it blindly, so maybe there isn't much
point in such a feature.

UX team, what's your opinion?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 109102] RFE Allow to save embedded documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109102

Aron Budea  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|NEW |UNCONFIRMED
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Ever confirmed|1   |0
   Severity|normal  |enhancement

--- Comment #4 from Aron Budea  ---
I don't see the file name anywhere in the raw DOCX, so getting the file name
seems to be impossible.

And even Word doesn't allow saving the embedded document from the right-click
menu in the container file. While I can imagine it as a convenience feature, I
also assume people would normally want to see the embedded document before
saving it, they would rarely want to save it blindly, so maybe there isn't much
point in such a feature.

UX team, what's your opinion?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

[Markus Mohrhard]

 vcl/source/uitest/uno/uiobject_uno.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a2e670df4efb219a1f92946d7a2887bdd0f88f5d
Author: Markus Mohrhard 
Date:   Fri Jul 14 01:52:54 2017 +0200

UI Test idle needs to run with highes priority

regression from 00aa0892e7385cd8395dd39814077958be42e720

Change-Id: I840391573ae52be6ba4a34b2a802b637578afa40

diff --git a/vcl/source/uitest/uno/uiobject_uno.cxx 
b/vcl/source/uitest/uno/uiobject_uno.cxx
index 108a215ef326..938161a3af03 100644
--- a/vcl/source/uitest/uno/uiobject_uno.cxx
+++ b/vcl/source/uitest/uno/uiobject_uno.cxx
@@ -119,7 +119,7 @@ void SAL_CALL UIObjectUnoObj::executeAction(const OUString& 
rAction, const css::
 mReady = false;
 auto aIdle = o3tl::make_unique();
 aIdle->SetDebugName("UI Test Idle Handler");
-aIdle->SetPriority(TaskPriority::DEFAULT);
+aIdle->SetPriority(TaskPriority::HIGHEST);
 
 std::function func = [this](){
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Aron Budea  changed:

   What|Removed |Added

 CC||consciencia...@gmail.com

--- Comment #23 from Aron Budea  ---
*** Bug 109109 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 109111] Word figures get damaged when .docx is opened with LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109111

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Attachment #134623|This is the figure most |Figure 6 as displayed in
description|damaged in the docx |Word

--- Comment #3 from Aron Budea  ---
Comment on attachment 134623
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134623
Figure 6 as displayed in Word

The issues seem quite varied to me, and I doubt all will be gone after fixing
figure 6, but I guess it's a step forward.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [PATCH feature/new-vcl-scheduler] noop commit: trigger test build for branch feature/new-vcl-s...

[Jan-Marek Glogowski]

Am 13. Juli 2017 21:08:29 MESZ schrieb Miklos Vajna :
>Hi Jan-Marek,
>
>Jenkins just failed in a vcl/scheduler assertion for me:
>
>https://ci.libreoffice.org/job/lo_gerrit/14865/Config=linux_clang_dbgutil_64/console
>
>It does not seem to be clang, I can reproduce the same with a local gcc
>build.
>
>I guess the relevant line is:
>
>cppunittester:
>/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/source/app/svapp.cxx:540:
>static void Scheduler::ProcessEventsToIdle(): Assertion `!bAnyIdle'
>failed.
>
>Do you have an idea what is the fix for this?

Nothing from my heart. The scheduler was asked to process all pending events, 
but for whatever reason there is still an idle event left (Idle).

My guess is that I broke something with my revert and my quick fix for the 
missing glib function. I just tested the VCL tests before pushing the fix and 
forgot about the more complex desktop tests.

Interestingly the tinderboxes seem to be fine - very strange. Since you can 
reproduce the problem, I would be interested in a SAL_LOG with vcl.scheduler, 
to see what is actually happening.

Does the test pass, if you use the gen or kde4 backend? Since my attempted fix 
was for Gtk, this would prove my suspicion about the origin of the unit test 
failure.

I won't be able to look into this before tomorrow.

Jan-Marek

>
>Thanks,
>
>Miklos

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Protect Ask against spam

[Florian Effenberger]

Hello,

Thorsten Behrens wrote on 2017-07-11 at 15:49:

My personal favorites would be to block a user automatically after
two of his posts have been deleted, or to block a user, after he had
made two posts within a short time (2 min e.g.).


Was that discussed at the ESC in the end? But it sounds like an easy
enough solution, to rate-limit spammers.


is this configurable in AskBot already (cc'ing Sophie on this, she knows 
quite some details about Ask) - if not, we need to fund implementation 
and I can check with Evgeny about the costs. Let me know, Sophie. :-)


Given the reports about spam I hear, it seems to make a lot of sense indeed.

Florian



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Protect Ask against spam

[Florian Effenberger]

Hello,

Sophie wrote on 2017-07-13 at 10:13:

Part is done already, user and IP are blocked and posts deleted. There


thanks!


is no possibility regarding the posts withing a short time.


Does AskBot support user blocking after x posts have been deleted, as 
Regina suggests? Or is blocking always manually?


Florian



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 108802] Crash in: SfxBindings::GetSlotPos(unsigned short, unsigned short) Editing.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108802

John Jackson  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #8 from John Jackson  ---
I tried uninstalling 5.3.4.2 and installing 5.3.3.2, and it still crashes.
However the macro has been assigned. I guess any time I want to add a macro
there'll be a crash. I won't be able to use Libre Office for new database
projects.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109111] Word figures get damaged when .docx is opened with LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109111

--- Comment #1 from Marco A.G.Pinto  ---
I have placed several figures as I believe that fixing the central bug, will
make them be all displayed correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109111] New: Word figures get damaged when .docx is opened with LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109111

Bug ID: 109111
   Summary: Word figures get damaged when .docx is opened with LO
   Product: LibreOffice
   Version: 5.3.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: marcoagpi...@mail.telepac.pt
CC: marcoagpi...@mail.telepac.pt
Blocks: 104442

Created attachment 134622
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134622=edit
sample/example

I wanted to report this before, but only now I found the time to make an
example .docx.

Please open the .docx with LO and the figures will appear damaged.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104442
[Bug 104442] [META] DOCX shape-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - svgio/inc svgio/source

[Caolán McNamara]

 svgio/inc/svgusenode.hxx  |2 ++
 svgio/source/svgreader/svgusenode.cxx |7 +--
 2 files changed, 7 insertions(+), 2 deletions(-)

New commits:
commit 2f64f2871d4e4091061d791db647de57ed390109
Author: Caolán McNamara 
Date:   Thu Jul 13 16:23:32 2017 +0100

Resolves: tdf#108903 avoid recurse to death

Change-Id: Iadde719a024c5fce97aa0f4c58947a5012639a84
Reviewed-on: https://gerrit.libreoffice.org/39921
Reviewed-by: Michael Stahl 
Tested-by: Jenkins 

diff --git a/svgio/inc/svgusenode.hxx b/svgio/inc/svgusenode.hxx
index a6eccaa05cd0..26c915b6ee2a 100644
--- a/svgio/inc/svgusenode.hxx
+++ b/svgio/inc/svgusenode.hxx
@@ -43,6 +43,8 @@ namespace svgio
 /// link to content. If maXLink is set, the node can be fetched
 // on demand
 OUString   maXLink;
+/// detect if maXLink causes a loop to ourself during decomposing
+mutable bool   mbDecomposingSvgNode;
 
 public:
 SvgUseNode(
diff --git a/svgio/source/svgreader/svgusenode.cxx 
b/svgio/source/svgreader/svgusenode.cxx
index 7495c2b1d5ad..7fdae9b3f68a 100644
--- a/svgio/source/svgreader/svgusenode.cxx
+++ b/svgio/source/svgreader/svgusenode.cxx
@@ -35,7 +35,8 @@ namespace svgio
 maY(),
 maWidth(),
 maHeight(),
-maXLink()
+maXLink(),
+mbDecomposingSvgNode(false)
 {
 }
 
@@ -143,7 +144,7 @@ namespace svgio
 // try to access link to content
 const SvgNode* pXLink = getDocument().findSvgNodeById(maXLink);
 
-if(pXLink && Display_none != pXLink->getDisplay())
+if (pXLink && Display_none != pXLink->getDisplay() && 
!mbDecomposingSvgNode)
 {
 // decompose children
 drawinglayer::primitive2d::Primitive2DContainer aNewTarget;
@@ -151,9 +152,11 @@ namespace svgio
 // todo: in case mpXLink is a SVGTokenSvg or SVGTokenSymbol the
 // SVG docs want the getWidth() and getHeight() from this node
 // to be valid for the subtree.
+mbDecomposingSvgNode = true;
 const_cast< SvgNode* >(pXLink)->setAlternativeParent(this);
 pXLink->decomposeSvgNode(aNewTarget, true);
 const_cast< SvgNode* >(pXLink)->setAlternativeParent();
+mbDecomposingSvgNode = false;
 
 if(!aNewTarget.empty())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - svgio/inc svgio/source

[Caolán McNamara]

 svgio/inc/svgusenode.hxx  |2 ++
 svgio/source/svgreader/svgusenode.cxx |7 +--
 2 files changed, 7 insertions(+), 2 deletions(-)

New commits:
commit e2075593e4d13b6e7c0b32b23912fdeed1ada6bf
Author: Caolán McNamara 
Date:   Thu Jul 13 16:23:32 2017 +0100

Resolves: tdf#108903 avoid recurse to death

Change-Id: Iadde719a024c5fce97aa0f4c58947a5012639a84
Reviewed-on: https://gerrit.libreoffice.org/39920
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/svgio/inc/svgusenode.hxx b/svgio/inc/svgusenode.hxx
index 05c0063699c5..7a438c11e960 100644
--- a/svgio/inc/svgusenode.hxx
+++ b/svgio/inc/svgusenode.hxx
@@ -45,6 +45,8 @@ namespace svgio
 /// link to content. If maXLink is set, the node can be fetched
 // on demand
 OUString   maXLink;
+/// detect if maXLink causes a loop to ourself during decomposing
+mutable bool   mbDecomposingSvgNode;
 
 public:
 SvgUseNode(
diff --git a/svgio/source/svgreader/svgusenode.cxx 
b/svgio/source/svgreader/svgusenode.cxx
index 104eb727bfed..86692d91c3d7 100644
--- a/svgio/source/svgreader/svgusenode.cxx
+++ b/svgio/source/svgreader/svgusenode.cxx
@@ -35,7 +35,8 @@ namespace svgio
 maY(),
 maWidth(),
 maHeight(),
-maXLink()
+maXLink(),
+mbDecomposingSvgNode(false)
 {
 }
 
@@ -142,7 +143,7 @@ namespace svgio
 // try to access link to content
 const SvgNode* pXLink = getDocument().findSvgNodeById(maXLink);
 
-if(pXLink && Display_none != pXLink->getDisplay())
+if (pXLink && Display_none != pXLink->getDisplay() && 
!mbDecomposingSvgNode)
 {
 // decompose children
 drawinglayer::primitive2d::Primitive2DContainer aNewTarget;
@@ -150,9 +151,11 @@ namespace svgio
 // todo: in case mpXLink is a SVGTokenSvg or SVGTokenSymbol the
 // SVG docs want the getWidth() and getHeight() from this node
 // to be valid for the subtree.
+mbDecomposingSvgNode = true;
 const_cast< SvgNode* >(pXLink)->setAlternativeParent(this);
 pXLink->decomposeSvgNode(aNewTarget, true);
 const_cast< SvgNode* >(pXLink)->setAlternativeParent();
+mbDecomposingSvgNode = false;
 
 if(!aNewTarget.empty())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc

[Tomaž Vajngerl]

 vcl/inc/win/winlayout.hxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 0686abc10aa729c8768b06249dbf7e57f4e56ae5
Author: Tomaž Vajngerl 
Date:   Thu Jul 13 13:30:20 2017 +0200

tdf#107166 BindDC doesn't handle 0 width/height rect consistently

When binding a GDI device context to D2D we need to provide a
rectangle where the surface will have effect. When we just need
some font information we need to bind the DC too, but we aren't
really interested what the rectangle is, so we just provided a
0,0,0,0 rectangle in that case. This sometimes fails with a
"out of memory" result and is dependent on the renderer.

Instead of 0,0,0,0 rectangle we rather define a 0,0,1,1 rectangle
which should never fail. This is not problematic as for actual
rendering we later rebind with an actual rectangle.

Change-Id: I79c7f0cf4d69f213370ed26a811a908ed16070ff
Reviewed-on: https://gerrit.libreoffice.org/39901
Reviewed-by: Michael Meeks 
Tested-by: Jenkins 

diff --git a/vcl/inc/win/winlayout.hxx b/vcl/inc/win/winlayout.hxx
index 9d2a40eba5be..128ff1f96a47 100644
--- a/vcl/inc/win/winlayout.hxx
+++ b/vcl/inc/win/winlayout.hxx
@@ -225,7 +225,10 @@ public:
 SalGraphics ,
 HDC hDC) override;
 
-bool BindDC(HDC hDC, tools::Rectangle const & rRect = tools::Rectangle(0, 
0, 0, 0)) {
+bool BindDC(HDC hDC, tools::Rectangle const & rRect = tools::Rectangle(0, 
0, 1, 1))
+{
+if (rRect.GetWidth() == 0 || rRect.GetHeight() == 0)
+return false;
 RECT const rc = { rRect.Left(), rRect.Top(), rRect.Right(), 
rRect.Bottom() };
 return SUCCEEDED(mpRT->BindDC(hDC, ));
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - vcl/inc vcl/win

[Tomaž Vajngerl]

 vcl/inc/win/winlayout.hxx |   14 
 vcl/win/gdi/winlayout.cxx |   74 --
 2 files changed, 85 insertions(+), 3 deletions(-)

New commits:
commit a3c9704f4c0cf2a0c6a4982bfb8124af63a506b0
Author: Tomaž Vajngerl 
Date:   Mon Jul 3 15:00:21 2017 +0200

tdf#106990 set cleartype setting / force to use GDI render mode

With this we read the system setting for cleartype and set it to
the render target we are using.

Additionally we set the GDI like rendering mode which forces that
the text is rendered similar as this was done with GDI.

Change-Id: If6fb72bc371accf50278c968c94e625aee3f0953
Reviewed-on: https://gerrit.libreoffice.org/39602
Tested-by: Jenkins 
Reviewed-by: Michael Meeks 

diff --git a/vcl/inc/win/winlayout.hxx b/vcl/inc/win/winlayout.hxx
index d733e185d59d..61ecfdf8c8d8 100644
--- a/vcl/inc/win/winlayout.hxx
+++ b/vcl/inc/win/winlayout.hxx
@@ -432,6 +432,13 @@ public:
 Point* pPos, int* pGetNextGlypInfo) override;
 };
 
+enum class D2DTextAntiAliasMode
+{
+Default,
+ClearType,
+AntiAliased,
+};
+
 class D2DWriteTextOutRenderer : public TextOutRenderer
 {
 typedef HRESULT(WINAPI *pD2D1CreateFactory_t)(D2D1_FACTORY_TYPE,
@@ -481,6 +488,11 @@ public:
 
 inline bool Ready() const { return mpGdiInterop && mpRT; }
 
+void applyTextAntiAliasMode();
+void setTextAntiAliasMode(D2DTextAntiAliasMode eMode)
+{
+meTextAntiAliasMode = eMode;
+}
 private:
 static void CleanupModules();
 
@@ -500,6 +512,8 @@ private:
 IDWriteFontFace * mpFontFace;
 float mlfEmHeight;
 HDC   mhDC;
+D2DTextAntiAliasMode meTextAntiAliasMode;
+IDWriteRenderingParams* mpRenderingParameters;
 };
 
 #endif // INCLUDED_VCL_INC_WIN_WINLAYOUT_HXX
diff --git a/vcl/win/gdi/winlayout.cxx b/vcl/win/gdi/winlayout.cxx
index 18c17b02abc2..5377a96af884 100644
--- a/vcl/win/gdi/winlayout.cxx
+++ b/vcl/win/gdi/winlayout.cxx
@@ -97,6 +97,8 @@ bool WinFontInstance::CacheGlyphToAtlas(bool 
bRealGlyphIndices, HDC hDC, HFONT h
 if (!pTxt)
 return false;
 
+pTxt->setTextAntiAliasMode(D2DTextAntiAliasMode::AntiAliased);
+
 if (!pTxt->BindFont(aHDC.get()))
 {
 SAL_WARN("vcl.gdi", "Binding of font failed. The font might not be 
supported by Direct Write.");
@@ -212,6 +214,7 @@ bool WinFontInstance::CacheGlyphToAtlas(bool 
bRealGlyphIndices, HDC hDC, HFONT h
 };
 
 pRT->BeginDraw();
+pTxt->applyTextAntiAliasMode();
 pRT->DrawGlyphRun(baseline, , pBrush);
 HRESULT hResult = pRT->EndDraw();
 
@@ -3154,6 +3157,47 @@ bool ExTextOutRenderer::operator ()(SalLayout const 
, HDC hDC,
 }
 return (pRectToErase && nGlyphs >= 1);
 }
+namespace
+{
+
+D2DTextAntiAliasMode lclGetSystemTextAntiAliasMode()
+{
+D2DTextAntiAliasMode eMode = D2DTextAntiAliasMode::Default;
+
+BOOL bFontSmoothing;
+if (!SystemParametersInfo(SPI_GETFONTSMOOTHING, 0, , 0))
+return eMode;
+
+if (bFontSmoothing)
+{
+UINT nType;
+if (!SystemParametersInfo(SPI_GETFONTSMOOTHINGTYPE, 0, , 0))
+return eMode;
+
+eMode = (nType == FE_FONTSMOOTHINGCLEARTYPE) ? 
D2DTextAntiAliasMode::ClearType
+ : 
D2DTextAntiAliasMode::AntiAliased;
+}
+
+return eMode;
+}
+
+IDWriteRenderingParams* lclSetRenderingMode(IDWriteFactory* pDWriteFactory, 
DWRITE_RENDERING_MODE eRenderingMode)
+{
+IDWriteRenderingParams* pDefaultParameters = nullptr;
+pDWriteFactory->CreateRenderingParams();
+
+IDWriteRenderingParams* pParameters = nullptr;
+pDWriteFactory->CreateCustomRenderingParams(
+pDefaultParameters->GetGamma(),
+pDefaultParameters->GetEnhancedContrast(),
+pDefaultParameters->GetClearTypeLevel(),
+pDefaultParameters->GetPixelGeometry(),
+eRenderingMode,
+);
+return pParameters;
+}
+
+} // end anonymous namespace
 
 D2DWriteTextOutRenderer::D2DWriteTextOutRenderer()
 : mpD2DFactory(nullptr),
@@ -3161,11 +3205,12 @@ D2DWriteTextOutRenderer::D2DWriteTextOutRenderer()
 mpGdiInterop(nullptr),
 mpRT(nullptr),
 mRTProps(D2D1::RenderTargetProperties(D2D1_RENDER_TARGET_TYPE_DEFAULT,
-D2D1::PixelFormat(DXGI_FORMAT_B8G8R8A8_UNORM, 
D2D1_ALPHA_MODE_PREMULTIPLIED),
-0, 0)),
+  
D2D1::PixelFormat(DXGI_FORMAT_B8G8R8A8_UNORM, D2D1_ALPHA_MODE_PREMULTIPLIED),
+  0, 0)),
 mpFontFace(nullptr),
 mlfEmHeight(0.0f),
-mhDC(nullptr)
+mhDC(nullptr),
+meTextAntiAliasMode(D2DTextAntiAliasMode::Default)
 {
 HRESULT hr = S_OK;
 hr = D2D1CreateFactory(D2D1_FACTORY_TYPE_SINGLE_THREADED, 
__uuidof(ID2D1Factory), nullptr, reinterpret_cast());
@@ -3175,6 +3220,8 @@ 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - vcl/inc

[Tomaž Vajngerl]

 vcl/inc/win/winlayout.hxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 1e13a4098887b225ddf47c14be98f3cd2c48dec4
Author: Tomaž Vajngerl 
Date:   Thu Jul 13 13:30:20 2017 +0200

tdf#107166 BindDC doesn't handle 0 width/height rect consistently

When binding a GDI device context to D2D we need to provide a
rectangle where the surface will have effect. When we just need
some font information we need to bind the DC too, but we aren't
really interested what the rectangle is, so we just provided a
0,0,0,0 rectangle in that case. This sometimes fails with a
"out of memory" result and is dependent on the renderer.

Instead of 0,0,0,0 rectangle we rather define a 0,0,1,1 rectangle
which should never fail. This is not problematic as for actual
rendering we later rebind with an actual rectangle.

Conflicts:
vcl/inc/win/winlayout.hxx

Change-Id: I79c7f0cf4d69f213370ed26a811a908ed16070ff

diff --git a/vcl/inc/win/winlayout.hxx b/vcl/inc/win/winlayout.hxx
index 8ceebeac3882..d733e185d59d 100644
--- a/vcl/inc/win/winlayout.hxx
+++ b/vcl/inc/win/winlayout.hxx
@@ -458,7 +458,10 @@ public:
 const Rectangle* pRectToErase,
 Point* pPos, int* pGetNextGlypInfo) override;
 
-inline bool BindDC(HDC hDC, Rectangle const & rRect = Rectangle(0, 0, 0, 
0)) {
+inline bool BindDC(HDC hDC, Rectangle const & rRect = Rectangle(0, 0, 1, 
1))
+{
+if (rRect.GetWidth() == 0 || rRect.GetHeight() == 0)
+return false;
 RECT const rc = { rRect.Left(), rRect.Top(), rRect.Right(), 
rRect.Bottom() };
 return SUCCEEDED(mpRT->BindDC(hDC, ));
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/cpu_intrinsics_support' - vcl/inc vcl/Library_vcl.mk vcl/source

[Tomaž Vajngerl]

 vcl/Library_vcl.mk   |   16 ++
 vcl/inc/ScanlineTools.hxx|   28 +++
 vcl/source/bitmap/ScanlineTools.cxx  |   30 
 vcl/source/bitmap/ScanlineToolsAVX2.cxx  |   64 ++
 vcl/source/bitmap/ScanlineToolsSSE2.cxx  |   76 +++
 vcl/source/bitmap/ScanlineToolsSSSE3.cxx |   61 
 6 files changed, 275 insertions(+)

New commits:
commit 81910410d22c060f9901b129697ea43a25cfbd99
Author: Tomaž Vajngerl 
Date:   Thu Jul 13 22:02:19 2017 +0200

scanline tools: convert RGBA <-> BGRA + vectorized fast paths

This adds a tool to convert a scanline from RGBA color channel
order to BGRA color channel order and back. It also includes the
vectorized fast path to accelerate it with SSE2 (~1.7x faster),
SSSE3 (~4x faster), AVX2 (~8x faster).

Change-Id: Ic427eed15d3cef40f9ad87220fb6b71770673c92

diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index a0113a2e85d4..93981505a600 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -411,6 +411,22 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/backendtest/outputdevice/rectangle \
 ))
 
+$(eval $(call gb_Library_add_cxxobjects,vcl,\
+vcl/source/bitmap/ScanlineTools, $(gb_LinkTarget_EXCEPTIONFLAGS) \
+))
+
+$(eval $(call gb_Library_add_cxxobjects,vcl,\
+vcl/source/bitmap/ScanlineToolsSSE2, $(gb_LinkTarget_EXCEPTIONFLAGS) 
$(INTRINSICS_CXXFLAGS)\
+))
+
+$(eval $(call gb_Library_add_cxxobjects,vcl,\
+vcl/source/bitmap/ScanlineToolsSSSE3, $(gb_LinkTarget_EXCEPTIONFLAGS) 
$(INTRINSICS_CXXFLAGS)\
+))
+
+$(eval $(call gb_Library_add_cxxobjects,vcl,\
+vcl/source/bitmap/ScanlineToolsAVX2, $(gb_LinkTarget_EXCEPTIONFLAGS) 
$(INTRINSICS_CXXFLAGS)\
+))
+
 $(eval $(call gb_Library_add_cobjects,vcl,\
 vcl/source/filter/jpeg/transupp \
 ))
diff --git a/vcl/inc/ScanlineTools.hxx b/vcl/inc/ScanlineTools.hxx
new file mode 100644
index ..898019903a15
--- /dev/null
+++ b/vcl/inc/ScanlineTools.hxx
@@ -0,0 +1,28 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#ifndef INCLUDED_VCL_INC_SCANLINETOOLS_HXX
+#define INCLUDED_VCL_INC_SCANLINETOOLS_HXX
+
+#include 
+
+namespace vcl {
+namespace scanline {
+
+bool VCL_DLLPUBLIC swapABCDtoCBAD(sal_uInt8* pSource, sal_uInt8* pDestination, 
sal_Int32 nScanlineSize);
+bool VCL_DLLPUBLIC swapABCDtoCBAD_SSE2(sal_uInt8* pSource, sal_uInt8* 
pDestination, sal_Int32 nScanlineSize);
+bool VCL_DLLPUBLIC swapABCDtoCBAD_SSSE3(sal_uInt8* pSource, sal_uInt8* 
pDestination, sal_Int32 nScanlineSize);
+bool VCL_DLLPUBLIC swapABCDtoCBAD_AVX2(sal_uInt8* pSource, sal_uInt8* 
pDestination, sal_Int32 nScanlineSize);
+
+}} // end vcl::scanline
+
+#endif // INCLUDED_VCL_INC_BITMAPSYMMETRYCHECK_HXX
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/bitmap/ScanlineTools.cxx 
b/vcl/source/bitmap/ScanlineTools.cxx
new file mode 100644
index ..ceefd0f2c30f
--- /dev/null
+++ b/vcl/source/bitmap/ScanlineTools.cxx
@@ -0,0 +1,30 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#include "ScanlineTools.hxx"
+
+namespace vcl {
+namespace scanline {
+
+bool swapABCDtoCBAD(sal_uInt8* pSource, sal_uInt8* pDestination, sal_Int32 
nScanlineSize)
+{
+for (sal_Int32 i = 0; i < nScanlineSize; i += 4, pSource += 4, 
pDestination += 4)
+{
+pDestination[0] = pSource[2];
+pDestination[1] = pSource[1];
+pDestination[2] = pSource[0];
+pDestination[3] = pSource[3];
+}
+return true;
+}
+
+}} // end vcl::scanline
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/bitmap/ScanlineToolsAVX2.cxx 
b/vcl/source/bitmap/ScanlineToolsAVX2.cxx
new file mode 100644
index ..1ef386f8256b
--- /dev/null
+++ b/vcl/source/bitmap/ScanlineToolsAVX2.cxx
@@ -0,0 +1,64 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#include "ScanlineTools.hxx"
+
+#include 
+
+#if defined(LO_AVX2_AVAILABLE)
+#include 
+#endif
+
+namespace vcl {
+namespace 

[Libreoffice-bugs] [Bug 109100] SIDEBAR: Margin controls in Slide/Page content panel

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109100

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Miklos Vajna]

 sw/source/core/layout/flowfrm.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 4908d6d6742e2f0700ea4ccd9d636d91ea281046
Author: Miklos Vajna 
Date:   Thu Jul 13 15:54:23 2017 +0200

tdf#108524 sw: allow frames in follow sect-in-tables in 
SwFlowFrame::MoveBwd()

The intention is to filter out text frames directly inside tables; since
tables in general reflow by moving all of the content to the first page,
then moving not fitting content to the next pages.  Section frames are
different, there we explicitly move content backwards, similarly to page
body frames.

Teach SwFlowFrame::MoveFwd() that a text frame inside a section-in-table
is the section situation, not the table situation, since what matters
here is the direct parent. To be on the safe side allow this for follow
section frames only.

This is necessary, but not enough to address the sub-problem described
in comment 12 of the bug. At least SwFrame::GetPrevSctLeaf() is invoked
to consider a precede section frame, though.

Change-Id: Ic88602cffefbbc81ecc90e3880be2a098f60fb04

diff --git a/sw/source/core/layout/flowfrm.cxx 
b/sw/source/core/layout/flowfrm.cxx
index aa11035d2a3c..d69501935d2c 100644
--- a/sw/source/core/layout/flowfrm.cxx
+++ b/sw/source/core/layout/flowfrm.cxx
@@ -2026,7 +2026,10 @@ bool SwFlowFrame::MoveBwd( bool  )
 {
 return false;
 }
-if ( pUpperFrame->IsColumnFrame() && pUpperFrame->IsInSct() )
+// If the text frame is a follow-section-in-table, that can move
+// backward as well.
+bool bIsFollowSection = pUpperFrame->IsSctFrame() && 
static_cast(pUpperFrame)->GetPrecede();
+if ( ( pUpperFrame->IsColumnFrame() && pUpperFrame->IsInSct() ) || 
bIsFollowSection )
 {
 break;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [PATCH feature/new-vcl-scheduler] noop commit: trigger test build for branch feature/new-vcl-s...

[Miklos Vajna]

Hi Jan-Marek,

Jenkins just failed in a vcl/scheduler assertion for me:

https://ci.libreoffice.org/job/lo_gerrit/14865/Config=linux_clang_dbgutil_64/console

It does not seem to be clang, I can reproduce the same with a local gcc
build.

I guess the relevant line is:

cppunittester: 
/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/source/app/svapp.cxx:540:
 static void Scheduler::ProcessEventsToIdle(): Assertion `!bAnyIdle' failed.

Do you have an idea what is the fix for this?

Thanks,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 109109] New: menu item "Insert > Page Number..." opens " Header and Footer"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109109

Bug ID: 109109
   Summary: menu item "Insert > Page Number..." opens "Header and
Footer"
   Product: LibreOffice
   Version: 5.3.4.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Keywords: difficultyBeginner
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: consciencia...@gmail.com

the menu item "Insert > Page Number..." 
wrongly opens "Header and Footer dialog", 
same as "Insert > Header and Footer..."

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: libreofficekit/Executable_gtktiledviewer.mk

[Pranav Kant]

 libreofficekit/Executable_gtktiledviewer.mk |   11 ---
 1 file changed, 4 insertions(+), 7 deletions(-)

New commits:
commit 9672a9293d0367c4a326a2628e35f7a56702779b
Author: Pranav Kant 
Date:   Thu Jul 13 19:36:22 2017 +0530

libreofficekit: Merge add_libs block into one

Change-Id: I0c4c2f3389cae243dbbfd16667d44d3ab8851860
Reviewed-on: https://gerrit.libreoffice.org/39914
Reviewed-by: pranavk 
Tested-by: pranavk 

diff --git a/libreofficekit/Executable_gtktiledviewer.mk 
b/libreofficekit/Executable_gtktiledviewer.mk
index f6e297b5dbfe..3d7ed665157d 100644
--- a/libreofficekit/Executable_gtktiledviewer.mk
+++ b/libreofficekit/Executable_gtktiledviewer.mk
@@ -24,13 +24,6 @@ $(eval $(call gb_Executable_add_cxxflags,gtktiledviewer,\
 
 $(eval $(call gb_Executable_add_libs,gtktiledviewer,\
 $(GTK3_LIBS) \
-))
-
-$(eval $(call gb_Executable_use_libraries,gtktiledviewer,\
-libreofficekitgtk \
-))
-
-$(eval $(call gb_Executable_add_libs,gtktiledviewer,\
 -lX11 \
 -lXext \
 -lXrender \
@@ -38,6 +31,10 @@ $(eval $(call gb_Executable_add_libs,gtktiledviewer,\
 -lICE \
 ))
 
+$(eval $(call gb_Executable_use_libraries,gtktiledviewer,\
+libreofficekitgtk \
+))
+
 ifeq ($(OS), $(filter LINUX %BSD SOLARIS, $(OS)))
 $(eval $(call gb_Executable_add_libs,gtktiledviewer,\
 -lm $(DLOPEN_LIBS) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 41044] User setting for default date format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=41044

ikjt  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 CC||ka...@goodtimes.fi
 Resolution|WORKSFORME  |---

--- Comment #15 from ikjt  ---
Marking as NEW (again).

As I understand it, this bug (as reported) is a request to implement a setting
for a default *display* format for dates. Unless I'm mistaken, such a feature
still does not exist.

Comment 12 refers to the date *input* pattern preference, which has nothing do
with the bug at hand. Thus, the bug was incorrectly marked as resolved.

Let me clarify the issue:

Currently, when a date is entered into a cell that doesn't have explicit
formatting applied, the date is formatted according to the current locale.
There are a few problems with this:

(1) There are countless of situations where a locale-dependent customary format
is simply not suitable and a standard format such as ISO 8601 is required. This
is a spreadsheet program after all.

(2) The locale-specific formats always seem to have two-digit years, which is
not what most people want, even if they are happy with the customary format per
se.

(3) Changing the locale affects a host of other things, too, such as the
parameter separators in formulas. For this reason, some users may prefer to
stick with the default locale even if it doesn't reflect their country or
working language.

The obvious way to fix this would be to provide a preference for a default
format string alongside the input acceptance patterns.

The two-digit year issue should be addressed separately. The current default
behavior is not good, regardless of whether there's a setting to override the
default format or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - external/expat

[Christian Lohmaier]

 external/expat/UnpackedTarball_expat.mk  |1 
 external/expat/expat.getrandom_detection.patch.1 |   40 +++
 2 files changed, 41 insertions(+)

New commits:
commit d336ac35a60c8cb86d36c9aa6057f4e494cbbd87
Author: Christian Lohmaier 
Date:   Thu Jul 13 15:23:32 2017 +0200

fix getrandom check in expat's configure

https://github.com/libexpat/libexpat/issues/52

fixes /usr/include/sys/random.h:37:22: error: expected ')'
misdetection of random.h feature, already fixed upstream:

https://github.com/libexpat/libexpat/commit/602e6c78ca750c082b72f8cdf4a38839b312959f

(cherry picked from commit f78ed1ec528604f6db9bdd2a07462c5e99e0ab99)

Change-Id: I65e4aebaa838d2931a60cb34806d87b88861c4d8
Reviewed-on: https://gerrit.libreoffice.org/39908
Reviewed-by: Christian Lohmaier 
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/external/expat/UnpackedTarball_expat.mk 
b/external/expat/UnpackedTarball_expat.mk
index 60e933d76090..5d803dcf303a 100644
--- a/external/expat/UnpackedTarball_expat.mk
+++ b/external/expat/UnpackedTarball_expat.mk
@@ -13,6 +13,7 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,expat,$(EXPAT_TARBALL)))
 
 $(eval $(call gb_UnpackedTarball_add_patches,expat,\
external/expat/expat-winapi.patch \
+   external/expat/expat.getrandom_detection.patch.1 \
 ))
 
 # This is a bit hackish.
diff --git a/external/expat/expat.getrandom_detection.patch.1 
b/external/expat/expat.getrandom_detection.patch.1
new file mode 100644
index ..eaf25df767dd
--- /dev/null
+++ b/external/expat/expat.getrandom_detection.patch.1
@@ -0,0 +1,40 @@
+https://github.com/libexpat/libexpat/issues/52
+
+fixes /usr/include/sys/random.h:37:22: error: expected ')'
+misdetection of random.h feature, already fixed upstream:
+https://github.com/libexpat/libexpat/commit/602e6c78ca750c082b72f8cdf4a38839b312959f
+
+diff -ur expat.org/configure expat/configure
+--- expat.org/configure2017-07-12 17:04:34.0 +0200
 expat/configure2017-07-12 17:05:59.0 +0200
+@@ -16341,7 +16341,7 @@
+   }
+ 
+ _ACEOF
+-if ac_fn_c_try_compile "$LINENO"; then :
++if ac_fn_c_try_link "$LINENO"; then :
+ 
+ 
+ $as_echo "#define HAVE_GETRANDOM 1" >>confdefs.h
+@@ -16386,7 +16386,8 @@
+ conftest$ac_exeext conftest.$ac_ext
+ 
+ fi
+-rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
++rm -f core conftest.err conftest.$ac_objext \
++conftest$ac_exeext conftest.$ac_ext
+ 
+ 
+ for ac_header in fcntl.h unistd.h
+diff -ur expat.org/configure.ac expat/configure.ac
+--- expat.org/configure.ac 2017-07-12 17:04:34.0 +0200
 expat/configure.ac 2017-07-12 17:05:31.0 +0200
+@@ -130,7 +130,7 @@
+ 
+ 
+ AC_MSG_CHECKING([for getrandom (Linux 3.17+, glibc 2.25+)])
+-AC_COMPILE_IFELSE([AC_LANG_SOURCE([
++AC_LINK_IFELSE([AC_LANG_SOURCE([
+   #include   /* for NULL */
+   #include 
+   int main() {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98799] MAILMERGE: Wizard: after in Step#3 selecting with " This document shall.." the Next/Finish button don't work any more

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98799

--- Comment #8 from Commit Notification 
 ---
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/help/commit/?id=5e623a924db3b7de6c39419f1a7b764a23de1b96

tdf#98799 tdf#102930 Document the logic of the MM wizard 3rd page

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98799] MAILMERGE: Wizard: after in Step#3 selecting with " This document shall.." the Next/Finish button don't work any more

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98799

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: 2 commits - source/text

[Gabor Kelemen]

 source/text/shared/guide/startcenter.xhp |   60 ---
 source/text/swriter/01/mailmerge03.xhp   |2 +
 2 files changed, 42 insertions(+), 20 deletions(-)

New commits:
commit 8f80dbc1121b3d95df2b2f74501a1657f5cecd5b
Author: Gabor Kelemen 
Date:   Sun Jun 18 17:51:01 2017 +0200

tdf#73229 Update Start Center page

Sync with current UI
Document all buttons and features

Change-Id: Id9c8354a408d499067c42ca06ced00841b56c134
Reviewed-on: https://gerrit.libreoffice.org/38931
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/source/text/shared/guide/startcenter.xhp 
b/source/text/shared/guide/startcenter.xhp
index e07b66ce3..9d9ad5442 100644
--- a/source/text/shared/guide/startcenter.xhp
+++ b/source/text/shared/guide/startcenter.xhp
@@ -31,58 +31,78 @@
   start center
 
 
-
 
-
-
+
 Start Center
 
 Welcome to %PRODUCTNAME.
Thank you for using the %PRODUCTNAME application help.
Press F1 whenever you need help using the %PRODUCTNAME 
software.
 You 
see the Start Center when no document is open in %PRODUCTNAME.
-  It is divided into two panes.  Click an icon on the left pane 
to open a new document or a file dialog.
+  It is divided into two panes.  Click a button on the left 
pane to open a new document or a file dialog.
 
+Open existing files
+  
+ 
+
+The Open File button presents a 
file open 
dialog.
+ 
+ 
+
+The Remote Files button presents a 
Remote files dialog 
to open files stored on remote servers.
+ 
+ 
+
+
+
+The Recent Files button shows 
thumbnails of the most recent documents you opened. Hover your mouse 
over the thumbnail to highlight the document, display a tip about the document 
location and display an icon on the top right to delete the thumbnail from the 
pane and from the recent files list.  Click on the thumbnail to open the 
document underneath.
+Press and 
hold the Recent Files dropdown button to open a menu where you can 
delete the list of recently opened documents.
+ 
+ 
+
+Click the Templates dropdown 
button to display all existing templates on the right side of the 
window.
+Press and 
hold the Templates dropdown button to open a menu where you can 
filter the existing templates by document type or open the Templates 
dialog.
+Right click 
on a template in the right pane to open a menu where you can either open the 
template to create a new document based on the template or edit the template 
itself.
+ 
+  
+Create:
 
 
 
 
 
 
-The document icons each open a new document of 
the specified type.
+The document buttons each open a new document 
of the specified type.
   
  
 
-   Text Document opens %PRODUCTNAME Writer
+   Writer Document opens %PRODUCTNAME Writer
  
  
 
-   Spreadsheet opens %PRODUCTNAME Calc
+   Calc Spreadsheet opens %PRODUCTNAME Calc
  
  
 
-   Presentation opens %PRODUCTNAME Impress
+   Impress Presentation opens %PRODUCTNAME Impress
  
  
 
-   Drawing opens %PRODUCTNAME Draw
+   Draw Drawing opens %PRODUCTNAME Draw
  
  
-
-   Database opens %PRODUCTNAME Base
+
+   Math Formula opens %PRODUCTNAME Math
  
  
-
-   Formula opens %PRODUCTNAME Math
+
+   Base Database opens %PRODUCTNAME Base
  
   
-
-The Templates icon opens 
the Templates dialog.
-The 
Templates icon opens the Templates dialog.
-
-The Open a Document icon 
presents a file open dialog.
-The 
Open a document icon presents a file open 
dialog.the four icons show a short explanation 
already
-The 
right pane contains thumbnails of the most recent documents you opened. Hover 
your mouse over the thumbnail to highlight the document, display a tip about 
the document location and display an icon on the top right to delete the 
thumbnail from the pane and from the recent files list.  Click on the thumbnail 
to open the document underneath.
+
+
+The Extensions button opens the https://extensions.libreoffice.org/;>https://extensions.libreoffice.org/
 page, where you can download templates and additional features for 
%PRODUCTNAME.
+
 Not 
every file type will display a thumbnail image of its content. Instead, you may 
see a large icon used by your computer for that filetype.

 
commit 5e623a924db3b7de6c39419f1a7b764a23de1b96
Author: Gabor Kelemen 
Date:   Wed Jun 7 22:57:40 2017 +0200

tdf#98799 tdf#102930 Document the logic of the MM wizard 3rd page

On the Insert Address Block 

[Libreoffice-commits] core.git: filter/source include/filter sw/source

[Noel Grandin]

 filter/source/msfilter/msdffimp.cxx  |   36 ++-
 include/filter/msfilter/msdffimp.hxx |8 ---
 sw/source/filter/ww8/ww8graf.cxx |   28 ---
 sw/source/filter/ww8/ww8par.cxx  |   13 +++-
 4 files changed, 29 insertions(+), 56 deletions(-)

New commits:
commit 61e8788d1b87fc57a9d015041f4e1ab44a86a1bd
Author: Noel Grandin 
Date:   Thu Jul 13 17:03:34 2017 +0200

convert pXRelTo/pYRelTo to boost::optional

seems wasteful to be allocating a single int for this

Change-Id: I8e1122fec8c8dc90805a38b677a1e08cd89a66ff
Reviewed-on: https://gerrit.libreoffice.org/39917
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index 6aef843a0c84..e64ec009f1c3 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -5055,15 +5055,11 @@ SdrObject* SvxMSDffManager::ProcessObj(SvStream& rSt,
 {
 case 0x038F: pImpRec->nXAlign = nUDData; break;
 case 0x0390:
-delete pImpRec->pXRelTo;
-pImpRec->pXRelTo = new sal_uInt32;
-*(pImpRec->pXRelTo) = nUDData;
+pImpRec->nXRelTo = nUDData;
 break;
 case 0x0391: pImpRec->nYAlign = nUDData; break;
 case 0x0392:
-delete pImpRec->pYRelTo;
-pImpRec->pYRelTo = new sal_uInt32;
-*(pImpRec->pYRelTo) = nUDData;
+pImpRec->nYRelTo = nUDData;
 break;
 case 0x03BF: pImpRec->nLayoutInTableCell = nUDData; break;
 case 0x0393:
@@ -5424,8 +5420,7 @@ SdrObject* SvxMSDffManager::ProcessObj(SvStream& rSt,
 
 if (SeekToContent(DFF_Prop_pWrapPolygonVertices, rSt))
 {
-delete pTextImpRec->pWrapPolygon;
-pTextImpRec->pWrapPolygon = nullptr;
+pTextImpRec->pWrapPolygon.reset();
 sal_uInt16 nNumElemVert(0), nNumElemMemVert(0), nElemSizeVert(0);
 rSt.ReadUInt16( nNumElemVert ).ReadUInt16( nNumElemMemVert 
).ReadUInt16( nElemSizeVert );
 bool bOk = false;
@@ -5435,7 +5430,7 @@ SdrObject* SvxMSDffManager::ProcessObj(SvStream& rSt,
 }
 if (bOk)
 {
-pTextImpRec->pWrapPolygon = new tools::Polygon(nNumElemVert);
+pTextImpRec->pWrapPolygon.reset(new 
tools::Polygon(nNumElemVert));
 for (sal_uInt16 i = 0; i < nNumElemVert; ++i)
 {
 sal_Int32 nX(0), nY(0);
@@ -7287,9 +7282,7 @@ SvxMSDffImportRec::SvxMSDffImportRec()
   pClientDataBuffer( nullptr ),
   nClientDataLen(0 ),
   nXAlign( 0 ), // position n cm from left
-  pXRelTo( nullptr ), //   relative to column
   nYAlign( 0 ), // position n cm below
-  pYRelTo( nullptr ), //   relative to paragraph
   nLayoutInTableCell( 0 ), // element is laid out in table cell
   nFlags( 0 ),
   nDxTextLeft( 144 ),
@@ -7325,9 +7318,9 @@ SvxMSDffImportRec::SvxMSDffImportRec()
 SvxMSDffImportRec::SvxMSDffImportRec(const SvxMSDffImportRec& rCopy)
 : pObj( rCopy.pObj ),
   nXAlign( rCopy.nXAlign ),
-  pXRelTo( nullptr ),
+  nXRelTo( rCopy.nXRelTo ),
   nYAlign( rCopy.nYAlign ),
-  pYRelTo( nullptr ),
+  nYRelTo( rCopy.nYRelTo ),
   nLayoutInTableCell( rCopy.nLayoutInTableCell ),
   nFlags( rCopy.nFlags ),
   nDxTextLeft( rCopy.nDxTextLeft),
@@ -7349,16 +7342,6 @@ SvxMSDffImportRec::SvxMSDffImportRec(const 
SvxMSDffImportRec& rCopy)
   relativeHorizontalWidth( rCopy.relativeHorizontalWidth ),
   isHorizontalRule( rCopy.isHorizontalRule )
 {
-if (rCopy.pXRelTo)
-{
-   pXRelTo = new sal_uInt32;
-   *pXRelTo = *(rCopy.pXRelTo);
-}
-if (rCopy.pYRelTo)
-{
-   pYRelTo = new sal_uInt32;
-   *pYRelTo = *(rCopy.pYRelTo);
-}
 eLineStyle   = rCopy.eLineStyle; // GPF-Bug #66227#
 eLineDashing = rCopy.eLineDashing;
 bDrawHell= rCopy.bDrawHell;
@@ -7390,16 +7373,11 @@ SvxMSDffImportRec::SvxMSDffImportRec(const 
SvxMSDffImportRec& rCopy)
 pClientDataBuffer = nullptr;
 
 if (rCopy.pWrapPolygon)
-pWrapPolygon = new tools::Polygon(*rCopy.pWrapPolygon);
-else
-pWrapPolygon = nullptr;
+pWrapPolygon.reset( new tools::Polygon(*rCopy.pWrapPolygon) );
 }
 
 SvxMSDffImportRec::~SvxMSDffImportRec()
 {
-delete pWrapPolygon;
-delete pXRelTo;
-delete pYRelTo;
 }
 
 void SvxMSDffManager::insertShapeId( sal_Int32 nShapeId, SdrObject* pShape )
diff --git a/include/filter/msfilter/msdffimp.hxx 
b/include/filter/msfilter/msdffimp.hxx
index 

[Libreoffice-commits] core.git: dbaccess/source

[Noel Grandin]

 dbaccess/source/ui/inc/TokenWriter.hxx  |1 
 dbaccess/source/ui/misc/RowSetDrop.cxx  |7 -
 dbaccess/source/ui/misc/TokenWriter.cxx |  131 ++--
 3 files changed, 63 insertions(+), 76 deletions(-)

New commits:
commit 0b6d0ac41afc72a0043e6ccdc6cdfd8648a5efdc
Author: Noel Grandin 
Date:   Thu Jul 13 15:46:11 2017 +0200

m_pRowMarker is unused

ever since commit 12191a4f30078bb81c39a74a994ba7b2b410adaf
"make loplugin constantparam smarter about string params"

Change-Id: Ifb8cfd8542596a826142547cd2dd90e2b5d682f8
Reviewed-on: https://gerrit.libreoffice.org/39910
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/dbaccess/source/ui/inc/TokenWriter.hxx 
b/dbaccess/source/ui/inc/TokenWriter.hxx
index fc779bcd3c6d..a9bb0effd649 100644
--- a/dbaccess/source/ui/inc/TokenWriter.hxx
+++ b/dbaccess/source/ui/inc/TokenWriter.hxx
@@ -77,7 +77,6 @@ namespace dbaui
 boolm_bNeedToReInitialize;
 
 ODatabaseExport*m_pReader;
-sal_Int32*  m_pRowMarker; // if set, then copy only these rows
 rtl_TextEncodingm_eDestEnc;
 boolm_bInInitialize;
 boolm_bCheckOnly;
diff --git a/dbaccess/source/ui/misc/RowSetDrop.cxx 
b/dbaccess/source/ui/misc/RowSetDrop.cxx
index 06beb6157fd7..10915243142d 100644
--- a/dbaccess/source/ui/misc/RowSetDrop.cxx
+++ b/dbaccess/source/ui/misc/RowSetDrop.cxx
@@ -140,11 +140,8 @@ bool ORowSetImportExport::Read()
 {
 --nRowCount;
 ++nCurrentRow;
-if(!m_pRowMarker || m_pRowMarker[nRowFilterIndex] == nCurrentRow)
-{
-++nRowFilterIndex;
-bContinue = insertNewRow();
-}
+++nRowFilterIndex;
+bContinue = insertNewRow();
 }
 }
 return true;
diff --git a/dbaccess/source/ui/misc/TokenWriter.cxx 
b/dbaccess/source/ui/misc/TokenWriter.cxx
index 842c57ea1c7e..83da3ae851a0 100644
--- a/dbaccess/source/ui/misc/TokenWriter.cxx
+++ b/dbaccess/source/ui/misc/TokenWriter.cxx
@@ -84,7 +84,6 @@ ODatabaseImportExport::ODatabaseImportExport(const 
svx::ODataAccessDescriptor& _
 ,m_nCommandType(CommandType::TABLE)
 ,m_bNeedToReInitialize(false)
 ,m_pReader(nullptr)
-,m_pRowMarker(nullptr)
 ,m_bInInitialize(false)
 ,m_bCheckOnly(false)
 {
@@ -106,7 +105,6 @@ ODatabaseImportExport::ODatabaseImportExport( const 
::dbtools::SharedConnection&
 ,m_nCommandType(css::sdb::CommandType::TABLE)
 ,m_bNeedToReInitialize(false)
 ,m_pReader(nullptr)
-,m_pRowMarker(nullptr)
 ,m_bInInitialize(false)
 ,m_bCheckOnly(false)
 {
@@ -129,7 +127,6 @@ ODatabaseImportExport::~ODatabaseImportExport()
 
 if(m_pReader)
 m_pReader->release();
-delete m_pRowMarker;
 }
 
 void ODatabaseImportExport::dispose()
@@ -513,64 +510,61 @@ bool ORTFImportExport::Write()
 
 void ORTFImportExport::appendRow(OString* pHorzChar,sal_Int32 
_nColumnCount,sal_Int32& k,sal_Int32& kk)
 {
-if(!m_pRowMarker || m_pRowMarker[kk] == k)
+++kk;
+m_pStream->WriteCharPtr( OOO_STRING_SVTOOLS_RTF_TROWD ).WriteCharPtr( 
OOO_STRING_SVTOOLS_RTF_TRGAPH );
+m_pStream->WriteInt32AsString(40);
+m_pStream->WriteCharPtr( SAL_NEWLINE_STRING );
+
+static char const aCell2[] = 
"\\clbrdrl\\brdrs\\brdrcf2\\clbrdrt\\brdrs\\brdrcf2\\clbrdrb\\brdrs\\brdrcf2\\clbrdrr\\brdrs\\brdrcf2\\clshdng1\\clcfpat1\\cellx";
+
+for ( sal_Int32 i=1; i<=_nColumnCount; ++i )
 {
-++kk;
-m_pStream->WriteCharPtr( OOO_STRING_SVTOOLS_RTF_TROWD ).WriteCharPtr( 
OOO_STRING_SVTOOLS_RTF_TRGAPH );
-m_pStream->WriteInt32AsString(40);
+m_pStream->WriteCharPtr( aCell2 );
+m_pStream->WriteInt32AsString(i*CELL_X);
 m_pStream->WriteCharPtr( SAL_NEWLINE_STRING );
+}
 
-static char const aCell2[] = 
"\\clbrdrl\\brdrs\\brdrcf2\\clbrdrt\\brdrs\\brdrcf2\\clbrdrb\\brdrs\\brdrcf2\\clbrdrr\\brdrs\\brdrcf2\\clshdng1\\clcfpat1\\cellx";
-
-for ( sal_Int32 i=1; i<=_nColumnCount; ++i )
-{
-m_pStream->WriteCharPtr( aCell2 );
-m_pStream->WriteInt32AsString(i*CELL_X);
-m_pStream->WriteCharPtr( SAL_NEWLINE_STRING );
-}
-
-const bool bBold= ( css::awt::FontWeight::BOLD == 
m_aFont.Weight );
-const bool bItalic  = ( css::awt::FontSlant_ITALIC == 
m_aFont.Slant );
-const bool bUnderline   = ( css::awt::FontUnderline::NONE  != 
m_aFont.Underline );
-const bool bStrikeout   = ( css::awt::FontStrikeout::NONE  != 
m_aFont.Strikeout );
-Reference< XRowSet > xRowSet(m_xRow,UNO_QUERY);
+const bool bBold= ( css::awt::FontWeight::BOLD == 
m_aFont.Weight );
+const bool bItalic  = ( css::awt::FontSlant_ITALIC == 
m_aFont.Slant );
+const 

[Libreoffice-commits] core.git: accessibility/source

[Arnaud Versini]

 accessibility/source/standard/vclxaccessibleedit.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a5f0c58cb4e3c23449f2b5f9319e28771a5a22fc
Author: Arnaud Versini 
Date:   Sun Jul 9 11:37:40 2017 +0200

Remove possible race condition in VCLXAccessibleEdit.

Change-Id: Id4738462b62d78fa48c937928a01b293cefdfabc
Reviewed-on: https://gerrit.libreoffice.org/39720
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/accessibility/source/standard/vclxaccessibleedit.cxx 
b/accessibility/source/standard/vclxaccessibleedit.cxx
index c508ce434afe..fb4aa77132ea 100644
--- a/accessibility/source/standard/vclxaccessibleedit.cxx
+++ b/accessibility/source/standard/vclxaccessibleedit.cxx
@@ -458,10 +458,10 @@ OUString VCLXAccessibleEdit::getTextRange( sal_Int32 
nStartIndex, sal_Int32 nEnd
 
 css::accessibility::TextSegment VCLXAccessibleEdit::getTextAtIndex( sal_Int32 
nIndex, sal_Int16 aTextType )
 {
+OExternalLockGuard aGuard( this );
 // Override general text component behavior: MultiLineEdit can have more 
text portions
 if ( aTextType == AccessibleTextType::ATTRIBUTE_RUN )
 {
-OExternalLockGuard aGuard( this );
 VclPtr pMulitLineEdit = GetAsDynamic< 
VclMultiLineEdit >();
 if ( pMulitLineEdit )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 109108] Menu bar missing but still active and all points where you click seem shifted down by that amount

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109108

--- Comment #2 from mabra...@gmail.com ---
Created attachment 134621
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134621=edit
screen capture after clicking on the save button

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109108] Menu bar missing but still active and all points where you click seem shifted down by that amount

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109108

--- Comment #1 from mabra...@gmail.com ---
Created attachment 134620
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134620=edit
window just after opening calc file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109108] New: Menu bar missing but still active and all points where you click seem shifted down by that amount

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109108

Bug ID: 109108
   Summary: Menu bar missing but still active and all points where
you click seem shifted down by that amount
   Product: LibreOffice
   Version: 5.3.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mabra...@gmail.com

Description:
I can not see the menu bar the first row of icons is there instead but if I
click on the 1st icon row I get the drop down menus to click on the icons (like
the save icon) I have to move the mouse pointer down about the space of the
menu bar to get the icon.  This cascades through the entire spreadsheet.  click
on A2 and A1 is active. etc. Writer also has this same issue with the missing
menu bzr.

Steps to Reproduce:
1.launch calc
2.menu bar missing but active
3.click on the top of the save icon and get a menu instead

Actual Results:  
no see menu bar

Expected Results:
see menu bar


Reproducible: Always

User Profile Reset: No

Additional Info:
see attached screen captures


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 OPR/46.0.2597.39

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109107] Sidebar' s fontheight field is not updated by moving cursor in an Impress table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109107

Tamás Zolnai  changed:

   What|Removed |Added

Summary|Sidebar's fontheight field  |Sidebar's fontheight field
   |is not about by moving  |is not updated by moving
   |cursor in an Impress table  |cursor in an Impress table

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109107] New: Sidebar' s fontheight field is not about by moving cursor in an Impress table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109107

Bug ID: 109107
   Summary: Sidebar's fontheight field is not about by moving
cursor in an Impress table
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: zolnaitamas2...@gmail.com

Description:
When I move the cursor in an Impress table with the arrow keys the sidebar is
not updated while the cursor is moved to a text with different font height.

Steps to Reproduce:
1. Open Impress
2. Create a table with at least to cells
3. Add some text to two cells of the table and set different fontheight to them
4. Move cursur between this two cells by arrow keys
5. Sidebar's fontheight field does not change it's value

Actual Results:  
Sidebar is not updated when the cursor is moved to a text part which has
different font height.

Expected Results:
Sidebar fontheight field should recognize the current font at the cursor.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/59.0.3071.115 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106959] In mail merge if the output document is saved as individual documents the second document is identical to the first one

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106959

--- Comment #4 from Timur  ---
Actually, I didn't reproduce on other example, but I did on yours. 
Before confirming the bug, it should be clear why exactly. 
So this generic title is not true.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107355] Slow spreadsheet redraw speed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107355

AnFr  changed:

   What|Removed |Added

 CC||andreas.frie...@elmos.com

--- Comment #7 from AnFr  ---
Created attachment 134619
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134619=edit
ODS test file for slow display speed

Hi,
the slow Display speed I've detected on bigger Tables. (s. example)

The easy Test is to press 'Strg + End' ('Strg + Ende' on German Keyboard) and
wait after the position is on display press 'Strg + Home' ('Strg + Pos1' on
German Keyboard).

Since LibreOffice 5.3 the display speed is much slower than on LibreOffice 5.2
and before.

The attached example document has one table of the size 100 columns and 2000
rows.

Regards,
AnFr

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106959] In mail merge if the output document is saved as individual documents the second document is identical to the first one

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106959

Timur  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106959] In mail merge if the output document is saved as individual documents the second document is identical to the first one

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106959

Timur  changed:

   What|Removed |Added

 CC||gti...@gmail.com

--- Comment #3 from Timur  ---
Didn't have time to test more, but not reproduced with a single test with
master 6.0+. 
Since you made really good bug report, please always also test with master. 
In Windows, you may get http://tdf.io/siguiexe to easily get and run "parallel"
LO in Windows (extract without installation).
If master also works for you, then it's WorksForMe.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109074] unable to bold the tamil fonts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109074

--- Comment #5 from tommy27  ---
thanks Jacques...
ஹலோ உலகம்  (which is Hello World in Tamil) can be correctly turn into bold
using LibO 4.3.4.2 under Win7 x64.

norepro for me

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109106] New: Please text language in auto correction instead of system language

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109106

Bug ID: 109106
   Summary: Please text language in auto correction instead of
system language
   Product: LibreOffice
   Version: 5.3.4.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eka1920-wi...@yahoo.de

My system is Czech but mostly I'm writing in German. When I want to add some
new abbreviation to the word list in Auto correct and don't change the language
to German before doing so the new data will be written to the Czech list. 

Would it be possible to automatically change the language in Auto correct to
the text language actually in use?

Many thanks in advance!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Interface similar to OpenOffice?

[jan]

Hi Peter,

There are no guarantees, but I wrote an extension based on UNO/Python
recently, using both documentation from OpenOffice and LibreOffice, so
they seem to still share large parts of their API.

So it is quite possible that it will work out of the box and just like
Heiko I would also suggest to give it a try.

Jan

Am 13.07.2017 um 12:32 schrieb Peter:
> A friendly hello to anybody,
> 
> I made an Interface to my Software to get data from Calc and write letters
> very easy with text modules. This Interface works with Open Office.
> 
> My question: Wil it work whith LibreOffice too? Or is it different?
> 
> Greeting from the North See
> 
> Peter
> 
> 
> 
> --
> View this message in context: 
> http://nabble.documentfoundation.org/Interface-similar-to-OpenOffice-tp4218096.html
> Sent from the Dev mailing list archive at Nabble.com.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
> 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/inc sc/source

[Markus Mohrhard]

 sc/inc/colorscale.hxx  |   18 -
 sc/source/core/data/colorscale.cxx |   65 ++---
 sc/source/filter/xml/xmlcondformat.cxx |   13 +-
 sc/source/filter/xml/xmlcondformat.hxx |1 
 4 files changed, 88 insertions(+), 9 deletions(-)

New commits:
commit 6ed7a3085216caf29f9066154fccc6ee2f1b953d
Author: Markus Mohrhard 
Date:   Thu Mar 16 22:43:43 2017 +0100

repaint whole range for range based cond formats, tdf#105696

The range based cond formats need to be repainted across the whole
range. This ensures that a change in condition which affects all cells
causes a repaint.

Change-Id: Ie6dd10088a1c11c1bafd1faa9c429a35a6469ff2
Reviewed-on: https://gerrit.libreoffice.org/35302
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 
(cherry picked from commit 49922897d68835ae4e5c850b3c55107157fe7548)
Reviewed-on: https://gerrit.libreoffice.org/39713
Reviewed-by: Eike Rathke 

diff --git a/sc/inc/colorscale.hxx b/sc/inc/colorscale.hxx
index 840b6824963d..ab94b22a34d3 100644
--- a/sc/inc/colorscale.hxx
+++ b/sc/inc/colorscale.hxx
@@ -49,6 +49,7 @@ private:
 std::unique_ptr mpCell;
 std::unique_ptr mpListener;
 ScColorScaleEntryType meType;
+ScConditionalFormat* mpFormat;
 
 public:
 ScColorScaleEntry(double nVal, const Color& rCol);
@@ -74,6 +75,8 @@ public:
 
 ScColorScaleEntryType GetType() const { return meType;}
 void SetType( ScColorScaleEntryType eType );
+
+void SetRepaintCallback(ScConditionalFormat* pParent);
 };
 
 namespace databar
@@ -97,7 +100,10 @@ struct SC_DLLPUBLIC ScDataBarFormatData
 meAxisPosition(databar::AUTOMATIC),
 mnMinLength(0),
 mnMaxLength(100),
-mbOnlyBar(false){}
+mbOnlyBar(false),
+mpUpperLimit(new ScColorScaleEntry()),
+mpLowerLimit(new ScColorScaleEntry())
+{}
 
 ScDataBarFormatData(const ScDataBarFormatData& r):
 maPositiveColor(r.maPositiveColor),
@@ -114,8 +120,12 @@ struct SC_DLLPUBLIC ScDataBarFormatData
 
 if(r.mpLowerLimit)
 mpLowerLimit.reset( new ScColorScaleEntry(*r.mpLowerLimit));
+else
+mpLowerLimit.reset(new ScColorScaleEntry());
 if(r.mpUpperLimit)
 mpUpperLimit.reset( new ScColorScaleEntry(*r.mpUpperLimit));
+else
+mpUpperLimit.reset(new ScColorScaleEntry());
 }
 
 /**
@@ -255,6 +265,8 @@ public:
 virtual ~ScColorScaleFormat() override;
 virtual ScColorFormat* Clone(ScDocument* pDoc) const override;
 
+virtual void SetParent(ScConditionalFormat* pParent) override;
+
 Color* GetColor(const ScAddress& rAddr) const;
 void AddEntry(ScColorScaleEntry* pEntry);
 
@@ -288,6 +300,8 @@ public:
 ScDataBarFormat(ScDocument* pDoc, const ScDataBarFormat& rFormat);
 virtual ScColorFormat* Clone(ScDocument* pDoc) const override;
 
+virtual void SetParent(ScConditionalFormat* pParent) override;
+
 ScDataBarInfo* GetDataBarInfo(const ScAddress& rAddr) const;
 
 void SetDataBarData( ScDataBarFormatData* pData );
@@ -348,6 +362,8 @@ public:
 
 virtual ScColorFormat* Clone(ScDocument* pDoc) const override;
 
+virtual void SetParent(ScConditionalFormat* pParent) override;
+
 ScIconSetInfo* GetIconSetInfo(const ScAddress& rAddr) const;
 
 void SetIconSetData( ScIconSetFormatData* pData );
diff --git a/sc/source/core/data/colorscale.cxx 
b/sc/source/core/data/colorscale.cxx
index cfa93309ec63..a3b1290a2652 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -156,21 +156,24 @@ bool ScFormulaListener::NeedsRepaint() const
 
 ScColorScaleEntry::ScColorScaleEntry():
 mnVal(0),
-meType(COLORSCALE_VALUE)
+meType(COLORSCALE_VALUE),
+mpFormat(nullptr)
 {
 }
 
 ScColorScaleEntry::ScColorScaleEntry(double nVal, const Color& rCol):
 mnVal(nVal),
 maColor(rCol),
-meType(COLORSCALE_VALUE)
+meType(COLORSCALE_VALUE),
+mpFormat(nullptr)
 {
 }
 
 ScColorScaleEntry::ScColorScaleEntry(const ScColorScaleEntry& rEntry):
 mnVal(rEntry.mnVal),
 maColor(rEntry.maColor),
-meType(rEntry.meType)
+meType(rEntry.meType),
+mpFormat(rEntry.mpFormat)
 {
 if(rEntry.mpCell)
 {
@@ -184,13 +187,16 @@ ScColorScaleEntry::ScColorScaleEntry(ScDocument* pDoc, 
const ScColorScaleEntry&
 mnVal(rEntry.mnVal),
 maColor(rEntry.maColor),
 mpCell(),
-meType(rEntry.meType)
+meType(rEntry.meType),
+mpFormat(rEntry.mpFormat)
 {
 if(rEntry.mpCell)
 {
 mpCell.reset(new ScFormulaCell(*rEntry.mpCell, 
*rEntry.mpCell->GetDocument(), rEntry.mpCell->aPos, 
ScCloneFlags::NoMakeAbsExternal));
 mpCell->StartListeningTo( pDoc );
 mpListener.reset(new ScFormulaListener(mpCell.get()));
+if (mpFormat)
+

[Libreoffice-bugs] [Bug 109074] unable to bold the tamil fonts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109074

--- Comment #4 from Jacques Guilleron  ---
Hi tommy27,

Mangal font is installed by LIbreOffice.
Latha is a font provided by Windows.
You could try also:
http://salrc.uchicago.edu/resources/fonts/available/tamil/

Next, Google Translate is useful to get a few words.

Jacques

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109105] New: Files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109105

Bug ID: 109105
   Summary: Files
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tayd...@virginmedia.com

On downloading the latest LibreOffice my files were said to be unobtainable
(except one) how do I get them back?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59262] LOCALHELP missing entry Dbtdata/cui/ui/numberingformatpage/ categorylb

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=59262

Gabor Kelemen  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #19 from Gabor Kelemen  ---
Now I'm being redirected from a current master build to

https://help.libreoffice.org/index.php?title=Common/Numbers_Format=en-US=UNIX=6.0#bm_id3153312

which is the correct page in the help wiki. 
I think it's now safe to say this is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97750] F1 takes you to the internet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97750

Gabor Kelemen  changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDINFO
   Assignee|kelem...@ubuntu.com |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #7 from Gabor Kelemen  ---
Unassigning, I was wrong in my last comment. The necessary ID is present in the
helpcontent:
http://opengrok.libreoffice.org/xref/help/source/text/scalc/main.xhp#32

Is this still an issue with a 5.4 build? I'm unable to reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svgio/source

[Caolán McNamara]

 svgio/source/svgreader/svgusenode.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5ef84bde43d7e1166bf296f86fb50e245f951f4f
Author: Caolán McNamara 
Date:   Thu Jul 13 16:52:46 2017 +0100

bah, wrong reset

Change-Id: Iaee7f4f038000c7009c9c74b822b7599559f09ca

diff --git a/svgio/source/svgreader/svgusenode.cxx 
b/svgio/source/svgreader/svgusenode.cxx
index bcde39f53e4a..86692d91c3d7 100644
--- a/svgio/source/svgreader/svgusenode.cxx
+++ b/svgio/source/svgreader/svgusenode.cxx
@@ -155,7 +155,7 @@ namespace svgio
 const_cast< SvgNode* >(pXLink)->setAlternativeParent(this);
 pXLink->decomposeSvgNode(aNewTarget, true);
 const_cast< SvgNode* >(pXLink)->setAlternativeParent();
-mbDecomposingSvgNode = true;
+mbDecomposingSvgNode = false;
 
 if(!aNewTarget.empty())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107625] Envelope dialog: Make dialog more a11y friendly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107625

--- Comment #11 from Szymon Kłos  ---
(In reply to Yousuf Philips (jay) from comment #8)
> 
> > - ctrl+tab in theses fields leave them, switching between tabs could be done
> > with ctrl+tab when the user keyboard focus is on an other item.
> 
> Not sure you can overwrite the default handling of ctrl+tab, but we'd have
> to ask a dev if its possible. @Maxim, @Szymon, @Bubli: Input please.

I think it is possible using IsMod1() to check if ctrl is used and KEY_TAB
code. It could be an easy hack :)

Useful links:
http://opengrok.libreoffice.org/xref/core/include/vcl/keycod.hxx#34
http://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/awt/KeyModifier.idl#37

Example of using key codes:
http://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/itemwin.cxx#419

Envelope dialog:
http://opengrok.libreoffice.org/xref/core/sw/source/ui/envelp/envlop1.cxx#192

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102998
Bug 102998 depends on bug 58808, which changed state.

Bug 58808 Summary: MAILMERGE: Wizard quits when Print Preview is shown
https://bugs.documentfoundation.org/show_bug.cgi?id=58808

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58808] MAILMERGE: Wizard quits when Print Preview is shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58808

Timur  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #5 from Timur  ---
>From LO 5.2 there are no more 8 steps in MMW. Strange it's not in
https://wiki.documentfoundation.org/ReleaseNotes/5.2. 
It's 5 steps now and 5th is Adjust Layout. 
So formally, no more "edit document" and "edit individual document" within the
wizard. 
We have MM toolbar now that stays on after MMW. 

Well, Print Preview turns off this MM toolbar, but it's easy to turn on. 
I can't say whether it's a bug but it would be another bug anyway. And it's not
MM only, some other toolbars are also turned off. 

So, I'll close this one as WFM. Od course, should you find it inappropriate,
please respond.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: hwpfilter/source

[Caolán McNamara]

 hwpfilter/source/hinfo.h   |5 ++---
 hwpfilter/source/hpara.cxx |2 +-
 hwpfilter/source/hwpreader.cxx |2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

New commits:
commit 8e63f09967ec91d29d385097e737efc6d02fa3a0
Author: Caolán McNamara 
Date:   Thu Jul 6 12:25:58 2017 +0100

ofz#2452 use shared_ptr for cshape

Change-Id: Icf576c08b3502ea3e24fa4b3685b55f794e844db
Reviewed-on: https://gerrit.libreoffice.org/39650
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/hwpfilter/source/hinfo.h b/hwpfilter/source/hinfo.h
index a381cc1dfb59..e9c17f8081bd 100644
--- a/hwpfilter/source/hinfo.h
+++ b/hwpfilter/source/hinfo.h
@@ -283,11 +283,10 @@ struct ParaShape
 unsigned char outline;
 unsigned char outline_continue;
 unsigned char reserved[2];
-CharShape *cshape;
- unsigned char pagebreak;
+std::shared_ptr cshape;
+unsigned char pagebreak;
 
 void  Read(HWPFile &);
-//  virtual ~ParaShape();
 };
 #endif // INCLUDED_HWPFILTER_SOURCE_HINFO_H
 
diff --git a/hwpfilter/source/hpara.cxx b/hwpfilter/source/hpara.cxx
index e31a8b8005ae..0534862c641a 100644
--- a/hwpfilter/source/hpara.cxx
+++ b/hwpfilter/source/hpara.cxx
@@ -108,7 +108,7 @@ bool HWPPara::Read(HWPFile & hwpf, unsigned char flag)
 if (nch && !reuse_shape)
 {
 pshape->Read(hwpf);
-pshape->cshape = cshape.get();
+pshape->cshape = cshape;
 pshape->pagebreak = etcflag;
 }
 
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 3c6e1543cec8..3f32c3b47c9b 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -1482,7 +1482,7 @@ void HwpReader::makePStyle(ParaShape * pshape)
 rstartEl("style:style", mxList.get());
 mxList->clear();
 parseParaShape(pshape);
-parseCharShape(pshape->cshape);
+parseCharShape(pshape->cshape.get());
 rstartEl("style:properties", mxList.get());
 mxList->clear();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/CppunitTest_sw_rtfexport2.mk sw/CppunitTest_sw_rtfexport3.mk sw/Module_sw.mk sw/qa

[Justin Luth]

 sw/CppunitTest_sw_rtfexport2.mk  |   60 
 sw/CppunitTest_sw_rtfexport3.mk  |   58 
 sw/Module_sw.mk  |2 
 sw/qa/extras/rtfexport/data/classification-no.rtf|1 
 sw/qa/extras/rtfexport/data/classification-yes.rtf   |   11 
 sw/qa/extras/rtfexport/data/hello.rtf|1 
 sw/qa/extras/rtfexport/data/tdf108949_footnoteCharFormat.odt |binary
 sw/qa/extras/rtfexport/rtfexport2.cxx| 1844 +++
 sw/qa/extras/rtfexport/rtfexport3.cxx|   40 
 sw/qa/extras/rtfimport/rtfimport.cxx | 1808 --
 10 files changed, 2039 insertions(+), 1786 deletions(-)

New commits:
commit 898522c8563a3e59b8de295ceb766cb8e2024ed5
Author: Justin Luth 
Date:   Tue Jul 11 20:09:14 2017 -0400

move round-tripables from rtfimport to new rtfexport2

This serves two purposes. It helps to prevent regressions
and it allows focusing on features that still don't export properly.

Also created rtfexport3 since the other two are already very full.

Change-Id: I7d580f575c1debe344275869fefcbba6e29cbad6
Reviewed-on: https://gerrit.libreoffice.org/39842
Tested-by: Jenkins 
Reviewed-by: Justin Luth 

diff --git a/sw/CppunitTest_sw_rtfexport2.mk b/sw/CppunitTest_sw_rtfexport2.mk
new file mode 100644
index ..3519afec5e7a
--- /dev/null
+++ b/sw/CppunitTest_sw_rtfexport2.mk
@@ -0,0 +1,60 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call gb_CppunitTest_CppunitTest,sw_rtfexport2))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,sw_rtfexport2, \
+sw/qa/extras/rtfexport/rtfexport2 \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,sw_rtfexport2, \
+comphelper \
+cppu \
+cppuhelper \
+i18nlangtag \
+sal \
+sfx \
+sw \
+test \
+unotest \
+utl \
+vcl \
+tl \
+))
+
+$(eval $(call gb_CppunitTest_use_externals,sw_rtfexport2,\
+boost_headers \
+libxml2 \
+))
+
+$(eval $(call gb_CppunitTest_set_include,sw_rtfexport2,\
+-I$(SRCDIR)/sw/inc \
+-I$(SRCDIR)/sw/source/core/inc \
+-I$(SRCDIR)/sw/qa/extras/inc \
+$$(INCLUDE) \
+))
+
+ifeq ($(OS),WNT)
+$(eval $(call gb_CppunitTest_add_cxxflags,sw_rtfexport2,\
+-bigobj \
+))
+endif
+
+$(eval $(call gb_CppunitTest_use_sdk_api,sw_rtfexport2))
+
+$(eval $(call gb_CppunitTest_use_ure,sw_rtfexport2))
+$(eval $(call gb_CppunitTest_use_vcl,sw_rtfexport2))
+
+$(eval $(call gb_CppunitTest_use_rdb,sw_rtfexport2,services))
+
+$(eval $(call gb_CppunitTest_use_configuration,sw_rtfexport2))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sw/CppunitTest_sw_rtfexport3.mk b/sw/CppunitTest_sw_rtfexport3.mk
new file mode 100644
index ..d0ebff13c4aa
--- /dev/null
+++ b/sw/CppunitTest_sw_rtfexport3.mk
@@ -0,0 +1,58 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call gb_CppunitTest_CppunitTest,sw_rtfexport3))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,sw_rtfexport3, \
+sw/qa/extras/rtfexport/rtfexport3 \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,sw_rtfexport3, \
+comphelper \
+cppu \
+cppuhelper \
+sal \
+sfx \
+sw \
+test \
+unotest \
+utl \
+tl \
+))
+
+$(eval $(call gb_CppunitTest_use_externals,sw_rtfexport3,\
+boost_headers \
+libxml2 \
+))
+
+$(eval $(call gb_CppunitTest_set_include,sw_rtfexport3,\
+-I$(SRCDIR)/sw/inc \
+-I$(SRCDIR)/sw/source/core/inc \
+-I$(SRCDIR)/sw/qa/extras/inc \
+$$(INCLUDE) \
+))
+
+ifeq ($(OS),WNT)
+$(eval $(call gb_CppunitTest_add_cxxflags,sw_rtfexport3,\
+-bigobj \
+))
+endif
+
+$(eval $(call gb_CppunitTest_use_sdk_api,sw_rtfexport3))
+
+$(eval $(call gb_CppunitTest_use_ure,sw_rtfexport3))
+$(eval $(call gb_CppunitTest_use_vcl,sw_rtfexport3))
+
+$(eval $(call gb_CppunitTest_use_rdb,sw_rtfexport3,services))
+
+$(eval $(call gb_CppunitTest_use_configuration,sw_rtfexport3))
+
+# vim: set noet sw=4 ts=4:
diff --git 

[Libreoffice-bugs] [Bug 109074] unable to bold the tamil fonts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109074

tommy27  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 CC||ba...@quipo.it
 Ever confirmed|1   |0

--- Comment #3 from tommy27  ---
how do I get Tamil fonts?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara]

 sw/source/filter/ww8/ww8scan.cxx |   15 +--
 1 file changed, 13 insertions(+), 2 deletions(-)

New commits:
commit 5a0b6f5ba8506de648ab72ef320445a49ba4c67d
Author: Caolán McNamara 
Date:   Mon Jun 26 13:21:49 2017 +0100

ofz#2392 restored props don't match saved props

Change-Id: Idb198f0121ac9c6b4083b157af07c5eb1cda66cb
Reviewed-on: https://gerrit.libreoffice.org/39265
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 2804d0a76625..1c6463df7b6c 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -5331,8 +5331,19 @@ void WW8PLCFxDesc::Restore( const WW8PLCFxSave1& rSave )
 pPLCFx->GetSprms();
 pPLCFx->SetDirty(false);
 aD.ReduceByOffset();
-pMemPos = aD.pMemPos + rSave.nPLCFxMemOfs;
-nSprmsLen = nOrigSprmsLen - rSave.nPLCFxMemOfs;
+
+if (nOrigSprmsLen > aD.nSprmsLen)
+{
+//two entries exist for the same offset, cut and run
+SAL_WARN("sw.ww8", "restored properties don't match saved 
properties, bailing out");
+nSprmsLen = 0;
+pMemPos = nullptr;
+}
+else
+{
+nSprmsLen = nOrigSprmsLen - rSave.nPLCFxMemOfs;
+pMemPos = aD.pMemPos + rSave.nPLCFxMemOfs;
+}
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108903] Crash after pasting text from webpage

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108903

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109099] Slow behavior in Calc after update to 5.3.4.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109099

Kjell  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Kjell  ---
I restarted in safe mode, and then I tried to open one of my files that has the
issue, and the problem is still there (I didn't see that I had to do anything
else than to restart in safe mode to reset the profile?).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source

[Caolán McNamara]

 filter/source/msfilter/svdfppt.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 5ac25ec1fd3b2537171e1e679f7e9e9a50c45f9c
Author: Caolán McNamara 
Date:   Wed Jun 21 09:16:33 2017 +0100

ofz#2332 fix dangling pCObj

Change-Id: Ifa62b1ce2aefa939cfceb2e110d126b785cb6e26
Reviewed-on: https://gerrit.libreoffice.org/39032
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/msfilter/svdfppt.cxx 
b/filter/source/msfilter/svdfppt.cxx
index 4325c0c92d8e..cb3fed6f6b00 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -2934,6 +2934,8 @@ void SdrPowerPointImport::ImportPage( SdrPage* pRet, 
const PptSlidePersistEntry*
 pPtr->pAObj = nullptr;
 if (pPtr->pBObj == rSlidePersist.pBObj)
 pPtr->pBObj = nullptr;
+if (pPtr->pCObj == rSlidePersist.pBObj)
+pPtr->pCObj = nullptr;
 }
 }
 SdrObject::Free(rSlidePersist.pBObj);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 46852] EDITING: "Change all" fails to change earlier misspellings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46852

--- Comment #13 from Luke Deller  ---
I can still reproduce the same behaviour:

Ubuntu 16.04
version 6.0.0.0.alpha0+ (built from git commit e333183d)

I did some investigation in a debugger, and found the problem:

at step 3: the spellcheck starting position (beginning of line 4) is recorded
in a bookmark (inside an XTextRange object)

at step 4: the word "frogg" at that position is deleted (before inserting the
correction "frog").  This causes the bookmark to be deleted because it is
referring to a deleted position.

at step 5: spellcheck from the beginning of the document to the starting
position is skipped because the spellcheck starting position has been lost

Notice that if line 4 starts with a correct word, e.g.
"happy frogg frogg"
then the problem does not occur, this is because the starting character of that
line is not deleted during the spellcheck corrections.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108903] Crash after pasting text from webpage

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108903

--- Comment #6 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=304b16c3bf6fba2fa28e723d1cb58157201b5c1f

Resolves: tdf#108903 avoid recurse to death

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108903] Crash after pasting text from webpage

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108903

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svgio/inc svgio/source

[Caolán McNamara]

 svgio/inc/svgusenode.hxx  |2 ++
 svgio/source/svgreader/svgusenode.cxx |7 +--
 2 files changed, 7 insertions(+), 2 deletions(-)

New commits:
commit 304b16c3bf6fba2fa28e723d1cb58157201b5c1f
Author: Caolán McNamara 
Date:   Thu Jul 13 16:23:32 2017 +0100

Resolves: tdf#108903 avoid recurse to death

Change-Id: Iadde719a024c5fce97aa0f4c58947a5012639a84
Reviewed-on: https://gerrit.libreoffice.org/39918
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/svgio/inc/svgusenode.hxx b/svgio/inc/svgusenode.hxx
index 05c0063699c5..7a438c11e960 100644
--- a/svgio/inc/svgusenode.hxx
+++ b/svgio/inc/svgusenode.hxx
@@ -45,6 +45,8 @@ namespace svgio
 /// link to content. If maXLink is set, the node can be fetched
 // on demand
 OUString   maXLink;
+/// detect if maXLink causes a loop to ourself during decomposing
+mutable bool   mbDecomposingSvgNode;
 
 public:
 SvgUseNode(
diff --git a/svgio/source/svgreader/svgusenode.cxx 
b/svgio/source/svgreader/svgusenode.cxx
index 104eb727bfed..bcde39f53e4a 100644
--- a/svgio/source/svgreader/svgusenode.cxx
+++ b/svgio/source/svgreader/svgusenode.cxx
@@ -35,7 +35,8 @@ namespace svgio
 maY(),
 maWidth(),
 maHeight(),
-maXLink()
+maXLink(),
+mbDecomposingSvgNode(false)
 {
 }
 
@@ -142,7 +143,7 @@ namespace svgio
 // try to access link to content
 const SvgNode* pXLink = getDocument().findSvgNodeById(maXLink);
 
-if(pXLink && Display_none != pXLink->getDisplay())
+if (pXLink && Display_none != pXLink->getDisplay() && 
!mbDecomposingSvgNode)
 {
 // decompose children
 drawinglayer::primitive2d::Primitive2DContainer aNewTarget;
@@ -150,9 +151,11 @@ namespace svgio
 // todo: in case mpXLink is a SVGTokenSvg or SVGTokenSymbol the
 // SVG docs want the getWidth() and getHeight() from this node
 // to be valid for the subtree.
+mbDecomposingSvgNode = true;
 const_cast< SvgNode* >(pXLink)->setAlternativeParent(this);
 pXLink->decomposeSvgNode(aNewTarget, true);
 const_cast< SvgNode* >(pXLink)->setAlternativeParent();
+mbDecomposingSvgNode = true;
 
 if(!aNewTarget.empty())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: embeddedobj/source sw/source

[Szymon Kłos]

 embeddedobj/source/msole/oleembed.cxx |6 +++---
 sw/source/core/unocore/unoframe.cxx   |   23 ++-
 2 files changed, 25 insertions(+), 4 deletions(-)

New commits:
commit d15d3d92a7297a57fafd9ed11c959bb8ec322b3a
Author: Szymon Kłos 
Date:   Wed Jul 12 12:17:03 2017 +0200

tdf#108545 editable DOC/XLS embeddings inside DOCX

Change-Id: Ia6cbe829f94b3f27e4ea633c02d6b1ec6e98e984
Reviewed-on: https://gerrit.libreoffice.org/39860
Tested-by: Jenkins 
Reviewed-by: Szymon Kłos 

diff --git a/embeddedobj/source/msole/oleembed.cxx 
b/embeddedobj/source/msole/oleembed.cxx
index 182d0a459548..b00cea109890 100644
--- a/embeddedobj/source/msole/oleembed.cxx
+++ b/embeddedobj/source/msole/oleembed.cxx
@@ -268,9 +268,9 @@ bool OleEmbeddedObject::TryToConvertToOOo( const 
uno::Reference< io::XStream >&
 xSeekable->seek( 0 );
 m_aFilterName = OwnView_Impl::GetFilterNameFromExtentionAndInStream( 
m_xFactory, OUString(), xStream->getInputStream() );
 
-// use the solution only for OOXML format currently
 if ( !m_aFilterName.isEmpty()
-  && ( m_aFilterName == "Calc MS Excel 2007 XML" || m_aFilterName == 
"Impress MS PowerPoint 2007 XML" || m_aFilterName == "MS Word 2007 XML" ) )
+  && ( m_aFilterName == "Calc MS Excel 2007 XML" || m_aFilterName == 
"Impress MS PowerPoint 2007 XML" || m_aFilterName == "MS Word 2007 XML"
+  || m_aFilterName == "MS Excel 97 Vorlage/Template" || 
m_aFilterName == "MS Word 97 Vorlage" ) )
 {
 uno::Reference< container::XNameAccess > xFilterFactory(
 
m_xFactory->createInstance("com.sun.star.document.FilterFactory"),
@@ -913,7 +913,7 @@ void SAL_CALL OleEmbeddedObject::doVerb( sal_Int32 nVerbID )
 m_bTriedConversion = true;
 if ( TryToConvertToOOo( m_xObjectStream ) )
 {
-changeState( embed::EmbedStates::UI_ACTIVE );
+changeState( embed::EmbedStates::ACTIVE );
 return;
 }
 }
diff --git a/sw/source/core/unocore/unoframe.cxx 
b/sw/source/core/unocore/unoframe.cxx
index e666726b06dc..162f9f7102be 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -2986,7 +2986,28 @@ void SwXFrame::attachToRange(const uno::Reference< 
text::XTextRange > & xTextRan
 pDoc->GetIDocumentUndoRedo().StartUndo(SwUndoId::INSERT, 
nullptr);
 
 SwFlyFrameFormat* pFrameFormat = nullptr;
-pFrameFormat = 
pDoc->getIDocumentContentOperations().InsertOLE( aPam, sStreamName, 
embed::Aspects::MSOLE_CONTENT, , nullptr );
+pFrameFormat = 
pDoc->getIDocumentContentOperations().InsertOLE( aPam, sStreamName, 
m_nDrawAspect, , nullptr );
+
+// store main document name to show in the title bar
+SwOLENode* pNd = nullptr;
+const SwNodeIndex* pIdx = 
pFrameFormat->GetContent().GetContentIdx();
+if( pIdx )
+{
+SwNodeIndex aIdx( *pIdx, 1 );
+SwNoTextNode* pNoText = aIdx.GetNode().GetNoTextNode();
+pNd = pNoText->GetOLENode();
+}
+if( pNd )
+{
+uno::Reference < embed::XEmbeddedObject > xObj = 
pNd->GetOLEObj().GetOleRef();
+if( xObj.is() )
+{
+uno::Reference< frame::XTitle > xModelTitle( 
pDoc->GetDocShell()->GetModel(), css::uno::UNO_QUERY );
+if( xModelTitle.is() )
+xObj->setContainerName( xModelTitle->getTitle() );
+}
+}
+
 pDoc->GetIDocumentUndoRedo().EndUndo(SwUndoId::INSERT, 
nullptr);
 pFrameFormat->Add(this);
 if(!m_sName.isEmpty())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 109097] mdds accelerating random lookups

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109097

--- Comment #4 from Markus Mohrhard  ---
(In reply to Aron Budea from comment #3)
> Created attachment 134615 [details]
> Callgrind trace
> 
> Here's a Callgrind output (well, the first of the 8 files). Unfortunately
> the spreadsheet involved cannot be shared.

Well, that one shows that the performance problem is in the matrix code where
we use index based access to get each value out of two matrices and insert into
a new one. We have existing code to do this with iterators which will improve
the performance of that code significantly.

At least from a quick look I don't see anything in this file that reflects the
ScColumn::GetCellValue problem Michael mentioned. Based on a quick reading 75%
of the import time is spend in 12 lcl_GetMinExtend calls with all the time
spend in inefficient iteration through the matrix.

Maybe you have a different document showing real problems but I doubt that this
one corresponds to the problems mentioned by Michael. This one is actually a
quite "easy" fix if you follow the existing ScMatrix performance hacks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109074] unable to bold the tamil fonts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109074

Jacques Guilleron  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||guillero...@aol.com
 Ever confirmed|0   |1

--- Comment #2 from Jacques Guilleron  ---
Hi karthikeyan g,

I don't reproduce using Mangal and Latha fonts under Windows 7.
Is Ctrl+B not working? Are you using a special keyboard?
Is it corrected when you
Restart in Safe Mode...
into Help menu?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107625] Envelope dialog: Make dialog more a11y friendly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107625

--- Comment #10 from Alex ARNAUD  ---
(In reply to Yousuf Philips (jay) from comment #8)
> (In reply to Alex ARNAUD from comment #7)
> > > So in other apps, when a user arrives at a multiline textbox that is to
> > > contain tab characters in it, how does navigation work there? I've checked
> > > some apps and some do not permit you to press tab in them (e.g.
> > > thunderbird's new contact dialog's other tab), while others do
> > > (qbittorrent's options dialog's bittorrent tab).
> > 
> > I propose this two behavior : 
> > - Disabling the usage of tab in theses fields
> 
> This would be the safest thing to do as long as the fields dont need the use
> of a tab character in them. @Regina, @Cor, @Heiko: Input please.
> 
> > - ctrl+tab in theses fields leave them, switching between tabs could be done
> > with ctrl+tab when the user keyboard focus is on an other item.
> 
> Not sure you can overwrite the default handling of ctrl+tab, but we'd have
> to ask a dev if its possible. @Maxim, @Szymon, @Bubli: Input please.

Any input ? It's a major issue for keyboard-only users as visual-impaired
people.

Best regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa sc/source

[Dennis Francis]

 sc/qa/unit/ucalc.hxx|4 +
 sc/qa/unit/ucalc_formula.cxx|  126 
 sc/source/core/data/formulacell.cxx |6 +
 3 files changed, 134 insertions(+), 2 deletions(-)

New commits:
commit 2caaf9bfe8d3f81517467daf36de0bd8ddd6b543
Author: Dennis Francis 
Date:   Thu Jul 13 11:35:41 2017 +0530

tdf#108758 : do not write to undo document when...

...updating references during a block move, for formula cells
that are in the target range of the move operation.

The fix is for formula cells that are not grouped. For the
grouped case, it was already doing correctly.

Added two unit tests in ucalc_formula.cxx for grouped formula
and non-grouped formula cases.

Change-Id: I9f4d988f5e154f56670bd1c0cc366ee6704fb858
Reviewed-on: https://gerrit.libreoffice.org/39883
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx
index 85efd25e7dc2..1a2ded57017f 100644
--- a/sc/qa/unit/ucalc.hxx
+++ b/sc/qa/unit/ucalc.hxx
@@ -152,6 +152,8 @@ public:
 void testFormulaRefUpdateMove();
 void testFormulaRefUpdateMoveUndo();
 void testFormulaRefUpdateMoveUndo2();
+void testFormulaRefUpdateMoveUndo3NonShared();
+void testFormulaRefUpdateMoveUndo3Shared();
 void testFormulaRefUpdateMoveToSheet();
 void testFormulaRefUpdateDeleteContent();
 void testFormulaRefUpdateDeleteAndShiftLeft();
@@ -566,6 +568,8 @@ public:
 CPPUNIT_TEST(testFormulaRefUpdateMove);
 CPPUNIT_TEST(testFormulaRefUpdateMoveUndo);
 CPPUNIT_TEST(testFormulaRefUpdateMoveUndo2);
+CPPUNIT_TEST(testFormulaRefUpdateMoveUndo3NonShared);
+CPPUNIT_TEST(testFormulaRefUpdateMoveUndo3Shared);
 CPPUNIT_TEST(testFormulaRefUpdateMoveToSheet);
 CPPUNIT_TEST(testFormulaRefUpdateDeleteContent);
 CPPUNIT_TEST(testFormulaRefUpdateDeleteAndShiftLeft);
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index 81e567fde3bb..407008dccd9c 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -2347,6 +2347,132 @@ void Test::testFormulaRefUpdateMoveUndo2()
 m_pDoc->DeleteTab(0);
 }
 
+void Test::testFormulaRefUpdateMoveUndo3NonShared()
+{
+m_pDoc->InsertTab(0, "Test");
+
+sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on.
+
+std::vector aData = {
+{ "10",   nullptr,  nullptr },
+{ "=A1",  nullptr,  nullptr },
+{ "=A2+A1",   nullptr,  nullptr },
+};
+
+ScRange aOutRange = insertRangeData(m_pDoc, ScAddress(0,0,0), aData);
+
+std::vector aCheckInitial = {
+{ "10", nullptr,  nullptr },
+{ "10", nullptr,  nullptr },
+{ "20", nullptr,  nullptr },
+};
+
+bool bGood = checkOutput(m_pDoc, aOutRange, aCheckInitial, "initial data");
+CPPUNIT_ASSERT(bGood);
+
+// Drag A2:A3 into C2:C3.
+ScDocFunc& rFunc = getDocShell().GetDocFunc();
+bool bMoved = rFunc.MoveBlock(ScRange(0,1,0,0,2,0), ScAddress(2,1,0), 
true, true, false, true);
+CPPUNIT_ASSERT(bMoved);
+
+std::vector aCheckAfter = {
+{ "10",nullptr, nullptr},
+{ nullptr, nullptr, "10" },
+{ nullptr, nullptr, "20" },
+};
+
+bGood = checkOutput(m_pDoc, aOutRange, aCheckAfter, "A2:A3 moved to 
C2:C3");
+CPPUNIT_ASSERT(bGood);
+
+// Undo the move.
+SfxUndoManager* pUndoMgr = m_pDoc->GetUndoManager();
+CPPUNIT_ASSERT(pUndoMgr);
+pUndoMgr->Undo();
+
+bGood = checkOutput(m_pDoc, aOutRange, aCheckInitial, "after undo");
+CPPUNIT_ASSERT(bGood);
+
+// Redo and check.
+pUndoMgr->Redo();
+
+bGood = checkOutput(m_pDoc, aOutRange, aCheckAfter, "after redo");
+CPPUNIT_ASSERT(bGood);
+
+m_pDoc->DeleteTab(0);
+}
+
+void Test::testFormulaRefUpdateMoveUndo3Shared()
+{
+m_pDoc->InsertTab(0, "Test");
+
+sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on.
+
+std::vector aData = {
+{ "10",   nullptr,  nullptr },
+{ "=A1",  nullptr,  nullptr },
+{ "=A2+$A$1", nullptr,  nullptr },
+{ "=A3+$A$1", nullptr,  nullptr },
+};
+
+ScRange aOutRange = insertRangeData(m_pDoc, ScAddress(0,0,0), aData);
+
+std::vector aCheckInitial = {
+{ "10", nullptr,  nullptr },
+{ "10", nullptr,  nullptr },
+{ "20", nullptr,  nullptr },
+{ "30", nullptr,  nullptr },
+};
+
+bool bGood = checkOutput(m_pDoc, aOutRange, aCheckInitial, "initial data");
+CPPUNIT_ASSERT(bGood);
+
+// A3:A4 should be grouped.
+const ScFormulaCell* pFC = m_pDoc->GetFormulaCell(ScAddress(0,2,0));
+CPPUNIT_ASSERT(pFC);
+CPPUNIT_ASSERT_EQUAL(SCROW(2), pFC->GetSharedLength());
+
+// Drag A2:A4 into C2:C4.
+ScDocFunc& rFunc = getDocShell().GetDocFunc();
+bool bMoved = 

[Libreoffice-bugs] [Bug 108903] Crash after pasting text from webpage

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108903

--- Comment #5 from Caolán McNamara  ---
seems to be a recursive loop in reading an svg in the html pasted in and
eventually we die from stack exhaustion

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: wizards/source

[Jean-Pierre Ledure]

 wizards/source/access2base/SubForm.xba |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 3cf9b747141bc5f74dc64cefbc5d5b2611ab0a4d
Author: Jean-Pierre Ledure 
Date:   Thu Jul 13 17:17:43 2017 +0200

Access2Base - RecordSource property of SubForm class

Use Command property i.o. ActiveCommand
because Command is additionally valid when form opened in Design mode

Change-Id: I0c9e545419ec99d444ac15b20466c838d53f738f

diff --git a/wizards/source/access2base/SubForm.xba 
b/wizards/source/access2base/SubForm.xba
index ac452412ad3d..bead65c95248 100644
--- a/wizards/source/access2base/SubForm.xba
+++ b/wizards/source/access2base/SubForm.xba
@@ -124,6 +124,11 @@ Public Function pName() As StringFor 
compatibility with  V0.9.0
 End Function pName (get)
 
 REM 
---
+Property Get ObjectType() As String
+   ObjectType = _PropertyGet(ObjectType)
+End Property ObjectType (get)
+
+REM 
---
 Property Get OnApproveCursorMove() As Variant
OnApproveCursorMove = _PropertyGet(OnApproveCursorMove)
 End Property OnApproveCursorMove (get)
@@ -259,11 +264,6 @@ Property Let OnUnloading(ByVal pvValue As Variant)
 End Property OnUnloading (set)
 
 REM 
---
-Property Get ObjectType() As String
-   ObjectType = _PropertyGet(ObjectType)
-End Property ObjectType (get)
-
-REM 
---
 Public Function OptionGroup(ByVal Optional pvGroupName As Variant) As Variant
  Return either an error or an object of type OPTIONGROUP based on its 
name
 
@@ -642,7 +642,7 @@ Dim oDatabase As Object, vBookmark As Variant, oObject As 
Object
End With
Set _PropertyGet = oObject
Case UCase(RecordSource)
-   _PropertyGet = DatabaseForm.ActiveCommand
+   _PropertyGet = DatabaseForm.Command
Case Else
Goto Trace_Error
End Select
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101258] [META] Bibliography bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101258

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||109041


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109041
[Bug 109041] Search to find Bibliography entries should be improved
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109041] Search to find Bibliography entries should be improved

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109041

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||tietze.he...@gmail.com
 Blocks||101258
 Ever confirmed|0   |1

--- Comment #1 from Heiko Tietze  ---
Sounds reasonable, and I cannot find a duplicate.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101258
[Bug 101258] [META] Bibliography bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109069] Button for images "Fit to Page"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109069

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||tietze.he...@gmail.com
 Resolution|--- |WONTFIX

--- Comment #5 from Heiko Tietze  ---
I agree with Timur and Dieter. Let's keep the UI clean (as best as possible).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109104] URLENCODE() funktion does not correctly encode newlines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109104

--- Comment #1 from spa...@online.de ---
Created attachment 134618
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134618=edit
Table with the URLENCODE fuction

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100864] Slide/Page pane: Close button not labelled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100864

--- Comment #2 from Alex ARNAUD  ---
Dear all,

@Jay: do you know if it is a complicated stuff ? Could you be able to resolved
the issue yourself ? Can I add the easyhack keyword ?

FYI, I can reproduce the issue on LibreOfficeDev 6.0.

Best regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109104] New: URLENCODE() funktion does not correctly encode newlines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109104

Bug ID: 109104
   Summary: URLENCODE() funktion does not correctly encode
newlines
   Product: LibreOffice
   Version: 5.0 all versions
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: spa...@online.de

if the string put through the URLENCODE function contains a newline, it will
convert it to "%A" not to "%0A". this results in an invalid char dependeding on
what letter comes next!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101912

Alex ARNAUD  changed:

   What|Removed |Added

 Depends on|100706  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100706
[Bug 100706] Cannot Stop Blinking Text Cursor in OS X
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100706] Cannot Stop Blinking Text Cursor in OS X

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100706

Alex ARNAUD  changed:

   What|Removed |Added

 Blocks|101912  |55571


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=55571
[Bug 55571] [META] ACCESSIBILITY: Tracking bug for issues related to the macOS
Accessibility API
https://bugs.documentfoundation.org/show_bug.cgi?id=101912
[Bug 101912] [META] Accessibility (a11y) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109103] New: Non-standard font color in About dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109103

Bug ID: 109103
   Summary: Non-standard font color in About dialog
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: easyHack
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tietze.he...@gmail.com

Created attachment 134617
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134617=edit
About box build with enable-kde4 on LXQt with Breeze Dark theme

The font color in the About dialog is not chosen from the system default.
That's not a problem for black on white themes but in case of inverted colors
the text is not readable. Please use always system default. If necessary
highlight parts with bold style or increase size.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Crash test update

[Crashtest VM]

New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/0a7fe0ab0b5b18cfbf1d9f7971d851fe00b6d36a/


exportCrashes.csv
Description: Binary data


importCrash.csv
Description: Binary data


validationErrors.csv
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 55571] [META] ACCESSIBILITY: Tracking bug for issues related to the macOS Accessibility API

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=55571

Alex ARNAUD  changed:

   What|Removed |Added

 Depends on||100706


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100706
[Bug 100706] Cannot Stop Blinking Text Cursor in OS X
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100086] Accessible events for selection of multiple cells on sheet are not correctly exposed to screen reader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100086

Alex ARNAUD  changed:

   What|Removed |Added

 CC||alexarn...@hypra.fr,
   ||jdi...@igalia.com,
   ||jean-philippe.mengual@libre
   ||office.org,
   ||rpoite...@hypra.fr

--- Comment #9 from Alex ARNAUD  ---
Dear all,

Joanie: Do we have the correct events emitted on GNU/Linux ?

Since the resolution of the bug 93825 we have "object:state-changed:selected"
events emitted but I'm not sure it is sufficient for Orca.

Best regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/unx

[Jan-Marek Glogowski]

 vcl/inc/unx/gtk/gtkinst.hxx  |4 ++--
 vcl/unx/gtk/gtkdata.cxx  |   12 +---
 vcl/unx/gtk/gtkinst.cxx  |   25 +
 vcl/unx/gtk3/gtk3gtkdata.cxx |   12 +---
 4 files changed, 29 insertions(+), 24 deletions(-)

New commits:
commit de0acf13b2dee2f7ad25de43f17acab73f1c7eac
Author: Jan-Marek Glogowski 
Date:   Thu Jul 13 16:05:56 2017 +0200

GTK+ convert to a single-shot timer

Simplified version of commit
  3e20ce802ee2ab49c4f2a98880f6e999657686bb

Since we're missing g_source_get_ready_time in our baseline, this
can't change the complex implementation, but still drops the timer
array and uses a single-shot timer, like all other backends.

Change-Id: I0641da8d0db71785c505957533a9069924808cd4

diff --git a/vcl/inc/unx/gtk/gtkinst.hxx b/vcl/inc/unx/gtk/gtkinst.hxx
index 4c86a3d62867..1585c778afac 100644
--- a/vcl/inc/unx/gtk/gtkinst.hxx
+++ b/vcl/inc/unx/gtk/gtkinst.hxx
@@ -233,12 +233,12 @@ public:
 const cairo_font_options_t* GetLastSeenCairoFontOptions();
void ResetLastSeenCairoFontOptions();
 
-voidRemoveTimer (SalTimer *pTimer);
+voidRemoveTimer ();
 
 std::shared_ptr const & getPrintWrapper() const;
 
 private:
-std::vector  m_aTimers;
+GtkSalTimer *m_pTimer;
 #if GTK_CHECK_VERSION(3,0,0)
 std::unordered_map< GdkAtom, css::uno::Reference > 
m_aClipboards;
 #endif
diff --git a/vcl/unx/gtk/gtkdata.cxx b/vcl/unx/gtk/gtkdata.cxx
index e5278f157698..6bb9f04e3bae 100644
--- a/vcl/unx/gtk/gtkdata.cxx
+++ b/vcl/unx/gtk/gtkdata.cxx
@@ -652,6 +652,10 @@ bool GtkData::ErrorTrapPop( bool bIgnoreError )
 return gdk_error_trap_pop () != 0;
 }
 
+#if !GLIB_CHECK_VERSION(2,32,0)
+#define G_SOURCE_REMOVE FALSE
+#endif
+
 extern "C" {
 
 struct SalGtkTimeoutSource {
@@ -732,7 +736,7 @@ extern "C" {
 if( pSVData->maSchedCtx.mpSalTimer )
 pSVData->maSchedCtx.mpSalTimer->CallCallback();
 
-return TRUE;
+return G_SOURCE_REMOVE;
 }
 
 static GSourceFuncs sal_gtk_timeout_funcs =
@@ -777,13 +781,13 @@ GtkSalTimer::GtkSalTimer()
 GtkSalTimer::~GtkSalTimer()
 {
 GtkInstance *pInstance = static_cast(GetSalData()->m_pInstance);
-pInstance->RemoveTimer( this );
+pInstance->RemoveTimer();
 Stop();
 }
 
 bool GtkSalTimer::Expired()
 {
-if( !m_pTimeout )
+if( !m_pTimeout || g_source_is_destroyed( _pTimeout->aParent ) )
 return false;
 
 gint nDummy = 0;
@@ -796,6 +800,8 @@ void GtkSalTimer::Start( sal_uLong nMS )
 {
 // glib is not 64bit safe in this regard.
 assert( nMS <= G_MAXINT );
+if ( nMS > G_MAXINT )
+nMS = G_MAXINT;
 m_nTimeoutMS = nMS; // for restarting
 Stop(); // FIXME: ideally re-use an existing m_pTimeout
 m_pTimeout = create_sal_gtk_timeout( this );
diff --git a/vcl/unx/gtk/gtkinst.cxx b/vcl/unx/gtk/gtkinst.cxx
index 034b634a0f79..db0aa9b783e4 100644
--- a/vcl/unx/gtk/gtkinst.cxx
+++ b/vcl/unx/gtk/gtkinst.cxx
@@ -156,6 +156,7 @@ GtkInstance::GtkInstance( SalYieldMutex* pMutex )
 #else
 : X11SalInstance( pMutex )
 #endif
+, m_pTimer(nullptr)
 , bNeedsInit(true)
 , m_pLastCairoFontOptions(nullptr)
 {
@@ -194,8 +195,7 @@ void GtkInstance::EnsureInit()
 
 GtkInstance::~GtkInstance()
 {
-while( !m_aTimers.empty() )
-delete *m_aTimers.begin();
+assert( nullptr == m_pTimer );
 DeInitAtkBridge();
 ResetLastSeenCairoFontOptions();
 }
@@ -397,18 +397,16 @@ void GtkInstance::DestroyMenuItem( SalMenuItem* ) 
   {}
 SalTimer* GtkInstance::CreateSalTimer()
 {
 EnsureInit();
-GtkSalTimer *pTimer = new GtkSalTimer();
-m_aTimers.push_back( pTimer );
-return pTimer;
+assert( nullptr == m_pTimer );
+if ( nullptr == m_pTimer )
+m_pTimer = new GtkSalTimer();
+return m_pTimer;
 }
 
-void GtkInstance::RemoveTimer (SalTimer *pTimer)
+void GtkInstance::RemoveTimer ()
 {
 EnsureInit();
-std::vector::iterator it;
-it = std::find( m_aTimers.begin(), m_aTimers.end(), pTimer );
-if( it != m_aTimers.end() )
-m_aTimers.erase( it );
+m_pTimer = nullptr;
 }
 
 bool GtkInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents, sal_uLong 
const nReleased)
@@ -422,12 +420,7 @@ bool GtkInstance::DoYield(bool bWait, bool 
bHandleAllCurrentEvents, sal_uLong co
 bool GtkInstance::IsTimerExpired()
 {
 EnsureInit();
-for( std::vector::iterator it = m_aTimers.begin();
- it != m_aTimers.end(); ++it )
-if( (*it)->Expired() )
-return true;
-
-return false;
+return (m_pTimer && m_pTimer->Expired());
 }
 
 bool GtkInstance::AnyInput( VclInputFlags nType )
diff --git a/vcl/unx/gtk3/gtk3gtkdata.cxx b/vcl/unx/gtk3/gtk3gtkdata.cxx
index 3e074489bfd5..ba56d5e6ec7f 100644
--- a/vcl/unx/gtk3/gtk3gtkdata.cxx
+++ b/vcl/unx/gtk3/gtk3gtkdata.cxx
@@ -614,6 +614,10 @@ bool 

[Libreoffice-commits] core.git: external/coinmp

[Stephan Bergmann]

 external/coinmp/ExternalProject_coinmp.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 268ce31604eb04d6ec49fe6054ed0e7162dca4f4
Author: Stephan Bergmann 
Date:   Thu Jul 13 17:00:20 2017 +0200

Pass verbose=true into external/coinmp

Change-Id: If8e0d3e7205737a1e15c563527d3845c7ae93dc1

diff --git a/external/coinmp/ExternalProject_coinmp.mk 
b/external/coinmp/ExternalProject_coinmp.mk
index ead6c6d1506c..db3b71a82b12 100644
--- a/external/coinmp/ExternalProject_coinmp.mk
+++ b/external/coinmp/ExternalProject_coinmp.mk
@@ -28,6 +28,7 @@ else
 $(call gb_ExternalProject_get_state_target,coinmp,build) :
+$(call gb_ExternalProject_run,build,\
./configure COIN_SKIP_PROJECTS="Data/Sample" \
+   $(if 
$(verbose),--disable-silent-rules,--enable-silent-rules) \
$(if $(CROSS_COMPILING),--build=$(BUILD_PLATFORM) 
--host=$(HOST_PLATFORM)) \
$(if $(DISABLE_DYNLOADING),--disable-shared) \
--disable-bzlib \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 109101] I can open LibreOffice5 Base, but when I try click on Tables Base crashes.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109101

--- Comment #2 from Alex Thurgood  ---
@Andy : check your kernel version and report back here, you might have fallen
victim to the following bug :

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1699772

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109099] Slow behavior in Calc after update to 5.3.4.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109099

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
Thank you for reporting the bug. To be certain the reported issue is not
related to corruption in the user profile, could you please reset your
Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and
re-test?

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the issue is still present

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109102] RFE Allow to save embedded documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109102

--- Comment #3 from Aron Budea  ---
Btw, bug 108545 is in the process of being fixed, you might want to check a
daily build.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107810] [META] OLE/Embedded object bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107810

Aron Budea  changed:

   What|Removed |Added

 Depends on||109102


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109102
[Bug 109102] RFE Allow to save embedded documents
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104520

Aron Budea  changed:

   What|Removed |Added

 Depends on||109102


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109102
[Bug 109102] RFE Allow to save embedded documents
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109102] RFE Allow to save embedded documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109102

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||8545
 Blocks||104520, 107810
 Ever confirmed|0   |1

--- Comment #2 from Aron Budea  ---
Indeed there's no option to save the embedded document currently.
Regarding comment 2, see bug 108545.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104520
[Bug 104520] [META] DOCX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=107810
[Bug 107810] [META] OLE/Embedded object bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106722] Crash in: ne_addr_resolve - using system credentials on a webdav share ( Kerberos protocol)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106722

--- Comment #3 from christian.rufe...@actelion.com ---
Similar here under a bit different circumstances:
Writer document contains an (invalid?) image URL. The users machine is
configured to use a network proxy to the internet (websense).
LO crashes inside ne_addr_resolve due to null pointer servername. See
attachment.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106722] Crash in: ne_addr_resolve - using system credentials on a webdav share ( Kerberos protocol)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106722

--- Comment #2 from christian.rufe...@actelion.com ---
Created attachment 134616
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134616=edit
Stack trace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109097] mdds accelerating random lookups

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109097

--- Comment #3 from Aron Budea  ---
Created attachment 134615
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134615=edit
Callgrind trace

Here's a Callgrind output (well, the first of the 8 files). Unfortunately the
spreadsheet involved cannot be shared.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: officecfg/registry vcl/unx

[Samuel Mehrbrodt]

 officecfg/registry/data/org/openoffice/Office/Common.xcu   |5 +
 officecfg/registry/schema/org/openoffice/Office/Common.xcs |   13 -
 vcl/unx/generic/fontmanager/fontconfig.cxx |9 +
 3 files changed, 26 insertions(+), 1 deletion(-)

New commits:
commit e8567ecd9d78a742cbab86498f7a31b22ee92ffa
Author: Samuel Mehrbrodt 
Date:   Thu Jul 13 09:06:53 2017 +0200

tdf#104883 Don't call InstallFontconfigResources if it's not available

We need to call it once because we have no other way to detect whether
it's working or not.
But if we receive an error the first time, we disable it from now on.

Change-Id: I67dba8b65660ff7e05bdf2ddc18b565550901cd1
Reviewed-on: https://gerrit.libreoffice.org/39885
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/officecfg/registry/data/org/openoffice/Office/Common.xcu 
b/officecfg/registry/data/org/openoffice/Office/Common.xcu
index 7e10c8932f33..eef41786feed 100644
--- a/officecfg/registry/data/org/openoffice/Office/Common.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Common.xcu
@@ -530,4 +530,9 @@
   
 
   
+  
+  
+true
+  
+  
 
diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index 6844e63e0b5c..bfcefe2ec38b 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -1272,7 +1272,7 @@
  /italic/, -strikeout- and _underline_ -->
 
   Specifies if text should be formatted in bold or underlined 
when
-  the corresponding characters are entered (*bold*, /italic/, 
-strikeout-, 
+  the corresponding characters are entered (*bold*, /italic/, 
-strikeout-,
   _underline_).
   Apply bold, italics, strikeout or underline
 
@@ -6701,5 +6701,16 @@
 true
   
 
+
+  
+Contains settings related to PackageKit (Unix only).
+  
+  
+
+   Specifies if missing font installation should be 
triggered.
+
+true
+  
+
   
 
diff --git a/vcl/unx/generic/fontmanager/fontconfig.cxx 
b/vcl/unx/generic/fontmanager/fontconfig.cxx
index 59bc5f365611..68d00eb0d6bf 100644
--- a/vcl/unx/generic/fontmanager/fontconfig.cxx
+++ b/vcl/unx/generic/fontmanager/fontconfig.cxx
@@ -32,6 +32,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace psp;
 
@@ -876,6 +877,9 @@ namespace
 #if ENABLE_GIO
 IMPL_LINK_NOARG(PrintFontManager, autoInstallFontLangSupport, Timer *, void)
 {
+if (!officecfg::Office::Common::PackageKit::EnableFontInstallation::get())
+return;
+
 guint xid = get_xid_for_dbus();
 
 if (!xid)
@@ -928,6 +932,11 @@ IMPL_LINK_NOARG(PrintFontManager, 
autoInstallFontLangSupport, Timer *, void)
 
 if (res == nullptr && error != nullptr)
 {
+// Disable this method from now on. It's simply not available on some 
systems
+// and leads to an error dialog being shown each tim theis is called 
tdf#104883
+std::shared_ptr batch( 
comphelper::ConfigurationChanges::create() );
+
officecfg::Office::Common::PackageKit::EnableFontInstallation::set(false, 
batch);
+batch->commit();
 g_debug("InstallFontconfigResources problem : %s", error->message);
 g_error_free(error);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100253] Complex draw diagram fails to open after 25 hours on 5.0.3.2 Linux, opens fine on 4.3.5.2 Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100253

--- Comment #11 from Gessel  ---
Thanks - i'll give it a try and post results by version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109101] I can open LibreOffice5 Base, but when I try click on Tables Base crashes.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109101

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Thank you for reporting the bug. To be certain the reported issue is not
related to corruption in the user profile, could you please reset your
Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and
re-test?

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the issue is still present

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109102] RFE Allow to save embedded documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109102

--- Comment #1 from Jan Vlug  ---
Some additional remarks:

There is a difference in the behaviour for an embedded .doc and an embedded
.docx document.

For the .doc:
Double clicking the icon opens the document in a new window.

For the .docx:
Double clicking the icon opens the document embedded in a small window. After
deselecting the embedded document, the icon disappears and is changed in a
icon-size preview window. Right clicking on this preview window gives a 'Save
Copy as' menu option. However, the suggested name of the document does not
correspond with the original name of the embedded document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs