[Libreoffice-bugs] [Bug 108566] [META] File loading and saving progress bar and related bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108566
Bug 108566 depends on bug 104650, which changed state.

Bug 104650 Summary: Progress bar is not removed after DOCX open error
https://bugs.documentfoundation.org/show_bug.cgi?id=104650

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92190

Telesto  changed:

   What|Removed |Added

 CC||arbo...@protonmail.com

--- Comment #104 from Telesto  ---
*** Bug 114298 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/source

[ekuiitr]

 sd/source/core/drawdoc3.cxx |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 6a68f46e8e931c3d4b095a9394d6c050ac9c49d2
Author: ekuiitr 
Date:   Tue Dec 5 21:44:23 2017 +0800

tdf#57950 replaced some O(U)StringBuffer::append() with operator+

Change-Id: Idd32e3f68787186c157ba7382cab39b0b974ac20
Reviewed-on: https://gerrit.libreoffice.org/45879
Tested-by: Jenkins 
Reviewed-by: Muhammet Kara 
Reviewed-by: Noel Grandin 

diff --git a/sd/source/core/drawdoc3.cxx b/sd/source/core/drawdoc3.cxx
index dfb48c863ffe..5aba6cf3f448 100644
--- a/sd/source/core/drawdoc3.cxx
+++ b/sd/source/core/drawdoc3.cxx
@@ -1444,9 +1444,7 @@ void SdDrawDocument::SetMasterPage(sal_uInt16 nSdPageNum,
 }
 else
 {
-OUStringBuffer aBuf(rLayoutName);
-aBuf.append(SD_LT_SEPARATOR).append(STR_LAYOUT_OUTLINE);
-OUString aSearchFor(aBuf.makeStringAndClear());
+OUString aSearchFor = rLayoutName + SD_LT_SEPARATOR 
STR_LAYOUT_OUTLINE;
 
 for (sal_uInt16 nMP = 0; nMP < pSourceDoc->GetMasterPageCount(); 
++nMP)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114298] some files formatted portrait always print landscape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114298

Telesto  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Telesto  ---
Fixed in LibreOffice 5.4.4 and 6.0. The prerelease of 5.4.4 can be downloaded
here: http://www.libreoffice.org/download/download/

*** This bug has been marked as a duplicate of bug 92190 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0 target:5.3.0   |target:5.2.0 target:5.3.0
   |target:6.0.0|target:6.0.0 target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #77 from Commit Notification 
 ---
ekuiitr committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6a68f46e8e931c3d4b095a9394d6c050ac9c49d2

tdf#57950 replaced some O(U)StringBuffer::append() with operator+

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111936] CHARTS: Bad display on data label in percent stacked chart

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111936

--- Comment #7 from fvroman  ---
Can someone can review the submitted patch https://gerrit.libreoffice.org/41424
so, hopefully, it can be merged

Thanks for your time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96302] Wrong field variables and selections shown in Fields dialog after creating a new document with the dialog still open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96302

--- Comment #16 from Julien Nabet  ---
Also: https://launchpad.net/~libreoffice/+archive/ubuntu/ppa

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/gpg4libre2' - comphelper/source

[Thorsten Behrens]

 comphelper/source/misc/storagehelper.cxx |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 420bfa047cf2418d00a2ece8f3bdf5121e6d4987
Author: Thorsten Behrens 
Date:   Thu Dec 7 08:42:28 2017 +0100

fixup clang errors

Change-Id: Ie5aa49ad70ee9cf95f67b38331f301b6c774d8c4

diff --git a/comphelper/source/misc/storagehelper.cxx 
b/comphelper/source/misc/storagehelper.cxx
index 6d83d693ba37..e81f1f7e3dac 100644
--- a/comphelper/source/misc/storagehelper.cxx
+++ b/comphelper/source/misc/storagehelper.cxx
@@ -525,10 +525,9 @@ uno::Sequence< beans::NamedValue > 
OStorageHelper::CreateGpgPackageEncryptionDat
 aEncryptionData[0].Value <<= aVector;
 
 aContainer[0].Name = "GpgInfos";
-aContainer[0].Value = makeAny(comphelper::containerToSequence(
-  aGpgEncryptions));
+aContainer[0].Value <<= comphelper::containerToSequence(aGpgEncryptions);
 aContainer[1].Name = "EncryptionKey";
-aContainer[1].Value = makeAny(aEncryptionData);
+aContainer[1].Value <<= aEncryptionData;
 
 return aContainer;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/source

[Julien Nabet]

 sc/source/ui/view/tabview3.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit b4e51cdaf859dfffee0561c51a72eb5c73ee23f4
Author: Julien Nabet 
Date:   Tue Dec 5 22:01:26 2017 +0100

tdf#114228: fix crash when deleting sheet in specific case

1. Create a brand new ods file
2. Select L12 (so cursor is obviously on sheet1 L12)
3. Create a brand new sheet (and cursor is on sheet2 A1)
4. Delete sheet2

It crashes with gtk3, see 
https://bugs.documentfoundation.org/attachment.cgi?id=138199
As indicated in 
https://bugs.documentfoundation.org/show_bug.cgi?id=114228#c5 the tab number
is wrong
Reporting cursor management later in ScTabView::SetTabNo prevents from the 
crash

Change-Id: Iea307267d2cdcf1c01f7e72f45b6a68aeef26fa1
Reviewed-on: https://gerrit.libreoffice.org/45976
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx
index 84c945552677..6e93f5f5756a 100644
--- a/sc/source/ui/view/tabview3.cxx
+++ b/sc/source/ui/view/tabview3.cxx
@@ -1817,8 +1817,6 @@ void ScTabView::SetTabNo( SCTAB nTab, bool bNew, bool 
bExtendSelection, bool bSa
 // UpdateShow before SetCursor, so that UpdateAutoFillMark finds the 
correct
 // window  (is called from SetCursor)
 UpdateShow();
-aViewData.ResetOldCursor();
-SetCursor( aViewData.GetCurX(), aViewData.GetCurY(), true );
 
 SfxBindings& rBindings = aViewData.GetBindings();
 ScMarkData& rMark = aViewData.GetMarkData();
@@ -1874,6 +1872,9 @@ void ScTabView::SetTabNo( SCTAB nTab, bool bNew, bool 
bExtendSelection, bool bSa
 UpdateVisibleRange();
 
 aViewData.GetViewShell()->WindowChanged();  // if the active 
window has changed
+aViewData.ResetOldCursor();
+SetCursor( aViewData.GetCurX(), aViewData.GetCurY(), true );
+
 if ( !bUnoRefDialog )
 aViewData.GetViewShell()->DisconnectAllClients();   // important 
for floating frames
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96302] Wrong field variables and selections shown in Fields dialog after creating a new document with the dialog still open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96302

--- Comment #15 from Buovjaga  ---
(In reply to Jan Skarvall from comment #14)
> I am using LibreOffice Writer 5.1.6.2 on Ubuntu 16.04 LTS. LO 6.0+ is not
> available on this Ubuntu version.

Thankfully you can free yourself from Ubuntu's version dictatorship by using
AppImages: http://libreoffice.soluzioniopen.com/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: xmlsecurity/qa

[Thorsten Behrens]

 xmlsecurity/qa/unit/signing/data/badDsigGPG.odt   |binary
 xmlsecurity/qa/unit/signing/data/badStreamGPG.odt |binary
 xmlsecurity/qa/unit/signing/data/goodGPG.odt  |binary
 xmlsecurity/qa/unit/signing/data/pubring.gpg  |binary
 xmlsecurity/qa/unit/signing/data/random_seed  |2 
 xmlsecurity/qa/unit/signing/data/secring.gpg  |binary
 xmlsecurity/qa/unit/signing/data/trustdb.gpg  |binary
 xmlsecurity/qa/unit/signing/data/untrustedGoodGPG.odt |binary
 xmlsecurity/qa/unit/signing/signing.cxx   |   91 +-
 9 files changed, 92 insertions(+), 1 deletion(-)

New commits:
commit 6da58b0e842b81669e5076c2c00dddf67a5616e1
Author: Thorsten Behrens 
Date:   Wed Dec 6 14:02:25 2017 +0100

gpg4libre: add unit tests for ODF signing feature

Since this requires a working gpg setup, limit to linux for the
moment. If you need to add signatures or redo them, run LibreOffice
from a shell with env var
GNUPGHOME=/xmlsecurity/qa/unit/signing/data/ set.

For editing keys, gpg2 also accepts a
--homedir=/xmlsecurity/qa/unit/signing/data/ option

Change-Id: I59e5b563098b19d05c8c2db32537241bc835fc80
Reviewed-on: https://gerrit.libreoffice.org/45950
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/xmlsecurity/qa/unit/signing/data/badDsigGPG.odt 
b/xmlsecurity/qa/unit/signing/data/badDsigGPG.odt
new file mode 100644
index ..032ddbf7a276
Binary files /dev/null and b/xmlsecurity/qa/unit/signing/data/badDsigGPG.odt 
differ
diff --git a/xmlsecurity/qa/unit/signing/data/badStreamGPG.odt 
b/xmlsecurity/qa/unit/signing/data/badStreamGPG.odt
new file mode 100644
index ..252ea26b00b1
Binary files /dev/null and b/xmlsecurity/qa/unit/signing/data/badStreamGPG.odt 
differ
diff --git a/xmlsecurity/qa/unit/signing/data/goodGPG.odt 
b/xmlsecurity/qa/unit/signing/data/goodGPG.odt
new file mode 100644
index ..a02af30169fe
Binary files /dev/null and b/xmlsecurity/qa/unit/signing/data/goodGPG.odt differ
diff --git a/xmlsecurity/qa/unit/signing/data/pubring.gpg 
b/xmlsecurity/qa/unit/signing/data/pubring.gpg
new file mode 100644
index ..40a8d53fb401
Binary files /dev/null and b/xmlsecurity/qa/unit/signing/data/pubring.gpg differ
diff --git a/xmlsecurity/qa/unit/signing/data/random_seed 
b/xmlsecurity/qa/unit/signing/data/random_seed
new file mode 100644
index ..8e68109a880e
--- /dev/null
+++ b/xmlsecurity/qa/unit/signing/data/random_seed
@@ -0,0 +1,2 @@
+°Á,A? ´   p£Ôj`\ÚGkV¿feTâ*ì;¼^hÌF֙¾3µ}‡²´iõÅsAØr¾‘9©B´h¡oWF€æÀ! 
!‹7(â;9µ±xÚ*L¯zY„¡8=ë#ç6æñÇï3ˆY&](^“浊4änZ?ålÿ.÷®ÔÓï؋}Öµ]¡5w6!Ç?ç¼l†ãÁ'%k©.^,IfÏVîVÏÓ
¥'_R!QºéUÝªiDöUZ" ¦ö°­Z°$R^Mf“Øç—àï )_~»‰ñûw‡oʇÃ6–c©3ž/ 
CÌñ÷Åù*‰EÅ;BzQ"MÛúÖ¶QCú-é×Òí¾¼'…Ý•y³$…ë_
ӛϟ!^s2zht¯LÇNÖ;¼©Íè¶\ûÁÅ«çÌ
0m冑øöG¼÷9õ‘M_­®“'ÕÆm‡(K·HÏ|‚ñôôŠ®Ìézš
ŸU;0žAz|ñ½°§8‘òX‡=aÙHºX>cÂ4&›Å6¢ãÜkñÓ/TìCä–Æýš¿sÈÀÊ_‘O`ä
 %M–{UDš çù¸–“{Ô;[cV9Ä]!ýf@—û(p˜^ÝÐ[ÿî‡híÌáyòöséTäëotf(«Ž"™Î(×qN²©—c¤r 
ÚÓ½aµÔÐܟµ
‡ۛ§õ·³*³?Œ>õYC6œøaŽ%'Ë]Ìi=g¯lR
+/R°?uÿâñâê7[ÄF(È
\ No newline at end of file
diff --git a/xmlsecurity/qa/unit/signing/data/secring.gpg 
b/xmlsecurity/qa/unit/signing/data/secring.gpg
new file mode 100644
index ..d98950c22ecd
Binary files /dev/null and b/xmlsecurity/qa/unit/signing/data/secring.gpg differ
diff --git a/xmlsecurity/qa/unit/signing/data/trustdb.gpg 
b/xmlsecurity/qa/unit/signing/data/trustdb.gpg
new file mode 100644
index ..c86bb02f3d79
Binary files /dev/null and b/xmlsecurity/qa/unit/signing/data/trustdb.gpg differ
diff --git a/xmlsecurity/qa/unit/signing/data/untrustedGoodGPG.odt 
b/xmlsecurity/qa/unit/signing/data/untrustedGoodGPG.odt
new file mode 100644
index ..e1b36d54417e
Binary files /dev/null and 
b/xmlsecurity/qa/unit/signing/data/untrustedGoodGPG.odt differ
diff --git a/xmlsecurity/qa/unit/signing/signing.cxx 
b/xmlsecurity/qa/unit/signing/signing.cxx
index 4d2419cf6e41..635993eb38b6 100644
--- a/xmlsecurity/qa/unit/signing/signing.cxx
+++ b/xmlsecurity/qa/unit/signing/signing.cxx
@@ -8,6 +8,7 @@
  */
 
 #include 
+#include 
 
 #include 
 
@@ -102,7 +103,18 @@ public:
 void testXAdESGood();
 /// Test importing of signature line images
 void testSignatureLineImages();
-
+#ifdef LINUX
+# if GPGME_HAVE_GPGME
+/// Test a typical ODF where all streams are GPG-signed.
+void testODFGoodGPG();
+/// Test a typical ODF where all streams are GPG-signed, but we don't 
trust the signature.
+void testODFUntrustedGoodGPG();
+/// Test a typical broken ODF signature where one stream is corrupted.
+void testODFBrokenStreamGPG();
+/// Test a typical broken ODF signature where the XML dsig hash is 
corrupted.
+void testODFBrokenDsigGPG();
+# endif
+#endif
 CPPUNIT_TEST_SUITE(SigningTest);

[Libreoffice-commits] core.git: 2 commits - extras/CustomTarget_glade.mk solenv/gbuild sysui/productlist.mk

[David Tardon]

 extras/CustomTarget_glade.mk |2 +-
 solenv/gbuild/AllLangMoTarget.mk |2 +-
 sysui/productlist.mk |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 8978fdf58a403aa62e04d47e65cd799740e6b909
Author: David Tardon 
Date:   Wed Dec 6 19:16:19 2017 +0100

fix variable name

Change-Id: Ie3eef59c934f5fe4146a911e4ee652457b94edd8

diff --git a/sysui/productlist.mk b/sysui/productlist.mk
index aa6fbd4a38d4..5d21a8e52b87 100644
--- a/sysui/productlist.mk
+++ b/sysui/productlist.mk
@@ -11,7 +11,7 @@ PRODUCTLIST := libreoffice libreofficedev
 PKGVERSION := $(LIBO_VERSION_MAJOR).$(LIBO_VERSION_MINOR).$(LIBO_VERSION_MICRO)
 PKGVERSIONSHORT := $(LIBO_VERSION_MAJOR).$(LIBO_VERSION_MINOR)
 PRODUCTNAME.libreoffice := LibreOffice
-PRODUCTNAME.libreofficeodev := LibreOfficeDev
+PRODUCTNAME.libreofficedev := LibreOfficeDev
 UNIXFILENAME.libreoffice := libreoffice$(PKGVERSIONSHORT)
 UNIXFILENAME.libreofficedev := libreofficedev$(PKGVERSIONSHORT)
 
commit 7cbedaa94f23a1f7676ff649ee6c19eb3a42dfb0
Author: David Tardon 
Date:   Tue Dec 5 09:27:10 2017 +0100

use 3-char announce id as elsewhere in gbuild

Change-Id: I2f8f1d6876e7305bec45038ada402aa423e59ad8

diff --git a/extras/CustomTarget_glade.mk b/extras/CustomTarget_glade.mk
index 8cb04dc5522a..fbd8c1606e2a 100644
--- a/extras/CustomTarget_glade.mk
+++ b/extras/CustomTarget_glade.mk
@@ -17,7 +17,7 @@ $(call 
gb_CustomTarget_get_workdir,extras/source/glade)/libreoffice-catalog.xml
 $(SRCDIR)/extras/source/glade/libreoffice-catalog.xml.in \
 $(SRCDIR)/extras/source/glade/makewidgetgroup.xslt \
 | $(call gb_ExternalExecutable_get_dependencies,xsltproc)
-   $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),XSLT,4)
+   $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),XSL,4)
$(call gb_Helper_abbreviate_dirs, \
mkdir -p $(dir $@) && \
$(call gb_ExternalExecutable_get_command,xsltproc) --nonet \
diff --git a/solenv/gbuild/AllLangMoTarget.mk b/solenv/gbuild/AllLangMoTarget.mk
index 64f6ce84d074..63789f768ec0 100644
--- a/solenv/gbuild/AllLangMoTarget.mk
+++ b/solenv/gbuild/AllLangMoTarget.mk
@@ -36,7 +36,7 @@ $(call gb_MoTarget_get_clean_target,%) :
 $(call gb_MoTarget_get_target,%) : \
$(gb_Helper_MISCDUMMY) \
$(call gb_ExternalExecutable_get_dependencies,python)
-   $(call gb_Output_announce,$*,$(true),MO,2)
+   $(call gb_Output_announce,$*,$(true),MO ,2)
$(call gb_Helper_abbreviate_dirs,\
mkdir -p $(dir $@) && \
if test -e 
$(gb_POLOCATION)/$(LANGUAGE)/$(POLOCATION)/messages.po; then \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: writerfilter/source

[tagezi]

 writerfilter/source/ooxml/OOXMLDocumentImpl.cxx |   25 +---
 1 file changed, 22 insertions(+), 3 deletions(-)

New commits:
commit 58e4b36ace484f2743a3b9919d830c175464b05d
Author: tagezi 
Date:   Wed Dec 6 21:23:37 2017 +0200

tdf#104650 Creating guard to reset status indicator

Change-Id: Ic1e79badedc031a588c0b07958002ad7c558ba82
Reviewed-on: https://gerrit.libreoffice.org/45987
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx 
b/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx
index 2223b2a6c61c..c23aa86b464a 100644
--- a/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx
+++ b/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx
@@ -417,8 +417,30 @@ void OOXMLDocumentImpl::resolveFooter(Stream & rStream,
  }
 }
 
+namespace {
+// Ensures that the indicator is reset after exiting OOXMLDocumentImpl::resolve
+class StatusIndicatorGuard{
+public:
+explicit 
StatusIndicatorGuard(css::uno::Reference& 
xStatusIndicator)
+:mxStatusIndicator(xStatusIndicator)
+{
+}
+
+~StatusIndicatorGuard()
+{
+if (mxStatusIndicator.is())
+mxStatusIndicator->end();
+}
+
+private:
+css::uno::Reference mxStatusIndicator;
+};
+}
+
 void OOXMLDocumentImpl::resolve(Stream & rStream)
 {
+StatusIndicatorGuard aStatusIndicatorGuard(mxStatusIndicator);
+
 if 
(utl::MediaDescriptor(maMediaDescriptor).getUnpackedValueOrDefault("ReadGlossaries",
 false))
 {
 resolveFastSubStream(rStream, OOXMLStream::GLOSSARY);
@@ -515,9 +537,6 @@ void OOXMLDocumentImpl::resolve(Stream & rStream)
 "OOXMLDocumentImpl::resolve(): non-UNO exception");
 }
 }
-
-if (mxStatusIndicator.is())
-mxStatusIndicator->end();
 }
 
 void OOXMLDocumentImpl::incrementProgress()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114295] Calc addition is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114295

XTR  changed:

   What|Removed |Added

 CC||x...@bk.ru

--- Comment #2 from XTR  ---
Does not repro with libreoffice 5.4.3.2 on windows x64 build
92a7159f7e4af62137622921e809f8546db437e5
even if manual set  Calculate > Limit decimals  to 3-8 digits
changed LO locale to English - no effect
may be system locale dependent..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114301] New: Adjust cells with hyperlinks in CALC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114301

Bug ID: 114301
   Summary: Adjust cells with hyperlinks in CALC
   Product: LibreOffice
   Version: 5.2.0.4 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ainhoa.cab...@gmail.com

Description:

When I insert a hyperlink in a cell and I want to adjust it to the size of the
cell, it does not do it like in excel. If I type the URL without hyperlink
format, if it is correct. But if it's a hyperlink, it does not adjust it. I
have asked in forums and they indicate to me that Excel feature, which if it
does without problems, is not compatible with CALC. Could you tell me if this
is true?
Thank you very much, greetings

Steps to Reproduce:
1.Insertar - Hiperenlace - Copiar el enlace
2.Formato Celdas - Alineación - Ajustar texto automáticamente
3.No sale toda la URL en la celda. 

Actual Results:  
No sale toda la URL en la celda. No se ve el texto completo

Expected Results:
Esperaba que saliera ajustada al ancho de la celda que yo le dé. Y que se
pudiera leer toda


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
En excel no hay problemas para hacerlo. Pero en calc no está esta función


User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/60.0.3112.90 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100735] Date format in the "Document in use" warning window is not localized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100735

Aron Budea  changed:

   What|Removed |Added

 Blocks||114300


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114300
[Bug 114300] [META] Bugs and enhancements involving lock files or file locking
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107443] FILEOPEN: "Open" in "Document in Use" dialog for non-default file format documents opens read-only

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107443

Aron Budea  changed:

   What|Removed |Added

 Blocks||114300


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114300
[Bug 114300] [META] Bugs and enhancements involving lock files or file locking
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108210] Can' t open file for editing if there is a lingering lock file from a different user

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108210

Aron Budea  changed:

   What|Removed |Added

 Blocks||114300


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114300
[Bug 114300] [META] Bugs and enhancements involving lock files or file locking
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63995] MSO XML documents are locked longer than expected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63995

Aron Budea  changed:

   What|Removed |Added

 Blocks||114300


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114300
[Bug 114300] [META] Bugs and enhancements involving lock files or file locking
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34171] Bad user name reporting when file is locked in mixed Calc / Excel environment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34171

Aron Budea  changed:

   What|Removed |Added

 Blocks||114300


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114300
[Bug 114300] [META] Bugs and enhancements involving lock files or file locking
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56544] FILEOPEN: Lock file is not created on samba share (via gvfs)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56544

Aron Budea  changed:

   What|Removed |Added

 Blocks||114300


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114300
[Bug 114300] [META] Bugs and enhancements involving lock files or file locking
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114300] [META] Bugs and enhancements involving lock files or file locking

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114300

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Depends on||100735, 107443, 34171,
   ||63995, 92817, 56544, 108210
Summary|[META] Bugs and |[META] Bugs and
   |enhancements involving lock |enhancements involving lock
   |files   |files or file locking
 Ever confirmed|0   |1


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=34171
[Bug 34171] Bad user name reporting when file is locked in mixed Calc / Excel
environment
https://bugs.documentfoundation.org/show_bug.cgi?id=56544
[Bug 56544] FILEOPEN: Lock file is not created on samba share (via gvfs)
https://bugs.documentfoundation.org/show_bug.cgi?id=63995
[Bug 63995] MSO XML documents are locked longer than expected
https://bugs.documentfoundation.org/show_bug.cgi?id=92817
[Bug 92817] misleading error on save with empty lock-file ...
https://bugs.documentfoundation.org/show_bug.cgi?id=100735
[Bug 100735] Date format in the "Document in use" warning window is not
localized
https://bugs.documentfoundation.org/show_bug.cgi?id=107443
[Bug 107443] FILEOPEN: "Open" in "Document in Use" dialog for non-default file
format documents opens read-only
https://bugs.documentfoundation.org/show_bug.cgi?id=108210
[Bug 108210] Can't open file for editing if there is a lingering lock file from
a different user
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109070] Configuration lock file warning fails to render and locks program start

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109070

Aron Budea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||ba...@caesar.elte.hu
 Resolution|--- |DUPLICATE

--- Comment #4 from Aron Budea  ---
The good news is that this bug is expected to be fixed with the next update,
5.4.4.

*** This bug has been marked as a duplicate of bug 114025 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114025] deadlock from lock dialog: Singleton vs. SolarMutex in framework

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114025

Aron Budea  changed:

   What|Removed |Added

 CC||maris.nart...@gmail.com

--- Comment #13 from Aron Budea  ---
*** Bug 109070 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104742] [META] Network-involved bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104742

Aron Budea  changed:

   What|Removed |Added

 Depends on||113024


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113024
[Bug 113024] Unable to open file in a read only mounted directory
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113024] Unable to open file in a read only mounted directory

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113024

Aron Budea  changed:

   What|Removed |Added

   Keywords||bibisectRequest
 CC||ba...@caesar.elte.hu
 Blocks||104742


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104742
[Bug 104742] [META] Network-involved bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35771] Printing issues on Mac OS X (Intel)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=35771

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=92
   ||190

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92190

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=35
   ||771

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114300] New: [META] Bugs and enhancements involving lock files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114300

Bug ID: 114300
   Summary: [META] Bugs and enhancements involving lock files
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108392] [META] Master slide bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108392

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Depends on||96708, 96206


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=96206
[Bug 96206] Copying slide which non-default master page contains text
duplicates that master
https://bugs.documentfoundation.org/show_bug.cgi?id=96708
[Bug 96708] Numerous errors that duplicate master when slide is copied and
pasted back
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114299] New: Notebookar not drawn (80%) after openning and closing Print Preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114299

Bug ID: 114299
   Summary: Notebookar not drawn (80%) after openning and closing
Print Preview
   Product: LibreOffice
   Version: 6.0.0.0.beta1
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lili...@gmail.com

Description:
In Writer (but also in Calc), Notebookbar is not shown completely (just maybe
80% of it). The only way to have it back is to switch between different
Notebookbar options or to reopen the program. 

Steps to Reproduce:
1. Open Writer
2. Open Print Preview
3. Exit Print  Preview

Actual Results:  
Notebookbar is not shown completely

Expected Results:
Notebookbar show be displayed just as before opening Print Preview


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/62.0.3202.94 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/source

[Noel Grandin]

 chart2/source/controller/inc/AccessibleBase.hxx  |2 +-
 chart2/source/controller/inc/AxisItemConverter.hxx   |6 +++---
 chart2/source/controller/inc/DataPointItemConverter.hxx  |2 +-
 chart2/source/controller/inc/GraphicPropertyItemConverter.hxx|2 +-
 chart2/source/controller/inc/LegendItemConverter.hxx |2 +-
 chart2/source/controller/inc/MultipleChartConverters.hxx |2 +-
 chart2/source/controller/inc/ObjectHierarchy.hxx |4 ++--
 chart2/source/controller/inc/RegressionEquationItemConverter.hxx |2 +-
 chart2/source/controller/inc/TextLabelItemConverter.hxx  |8 

 chart2/source/controller/inc/TitleItemConverter.hxx  |2 +-
 chart2/source/controller/main/ChartTransferable.hxx  |2 +-
 chart2/source/model/inc/BaseCoordinateSystem.hxx |2 +-
 chart2/source/model/inc/CartesianCoordinateSystem.hxx|2 +-
 chart2/source/model/inc/PolarCoordinateSystem.hxx|2 +-
 chart2/source/model/template/PieChartTypeTemplate.hxx|2 +-
 chart2/source/view/charttypes/AreaChart.hxx  |2 +-
 chart2/source/view/charttypes/BarChart.hxx   |2 +-
 chart2/source/view/charttypes/CandleStickChart.hxx   |2 +-
 chart2/source/view/charttypes/GL3DBarChart.cxx   |2 +-
 chart2/source/view/charttypes/PieChart.hxx   |2 +-
 chart2/source/view/inc/VDiagram.hxx  |2 +-
 chart2/source/view/inc/VSeriesPlotter.hxx|4 ++--
 22 files changed, 29 insertions(+), 29 deletions(-)

New commits:
commit 8169a0e5a10defde3e0f53137734fd06ffca85d7
Author: Noel Grandin 
Date:   Wed Dec 6 14:31:52 2017 +0200

loplugin:countusersofdefaultparams in chart2

Change-Id: Ibad415d2c539b2438e4939c2c23f32d84a5a677f
Reviewed-on: https://gerrit.libreoffice.org/45948
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/chart2/source/controller/inc/AccessibleBase.hxx 
b/chart2/source/controller/inc/AccessibleBase.hxx
index c881be5786b6..5055f7b009b5 100644
--- a/chart2/source/controller/inc/AccessibleBase.hxx
+++ b/chart2/source/controller/inc/AccessibleBase.hxx
@@ -101,7 +101,7 @@ public:
 
 AccessibleBase( const AccessibleElementInfo & rAccInfo,
 bool bMayHaveChildren,
-bool bAlwaysTransparent = false );
+bool bAlwaysTransparent );
 virtual ~AccessibleBase() override;
 
 protected:
diff --git a/chart2/source/controller/inc/AxisItemConverter.hxx 
b/chart2/source/controller/inc/AxisItemConverter.hxx
index 5f4ca5309ef7..ad742691ada5 100644
--- a/chart2/source/controller/inc/AxisItemConverter.hxx
+++ b/chart2/source/controller/inc/AxisItemConverter.hxx
@@ -39,9 +39,9 @@ public:
 const css::uno::Reference& rPropertySet,
 SfxItemPool& rItemPool, SdrModel& rDrawModel,
 const css::uno::Reference & xChartDoc,
-ExplicitScaleData const * pScale = nullptr,
-ExplicitIncrementData const * pIncrement = nullptr,
-const css::awt::Size* pRefSize = nullptr );
+ExplicitScaleData const * pScale,
+ExplicitIncrementData const * pIncrement,
+const css::awt::Size* pRefSize );
 
 virtual ~AxisItemConverter() override;
 
diff --git a/chart2/source/controller/inc/DataPointItemConverter.hxx 
b/chart2/source/controller/inc/DataPointItemConverter.hxx
index 1cf452b1c1a6..61b91abe8f68 100644
--- a/chart2/source/controller/inc/DataPointItemConverter.hxx
+++ b/chart2/source/controller/inc/DataPointItemConverter.hxx
@@ -44,7 +44,7 @@ public:
 SfxItemPool& rItemPool,
 SdrModel& rDrawModel,
 const css::uno::Reference& 
xNamedPropertyContainerFactory,
-GraphicObjectType eMapTo = GraphicObjectType::FilledDataPoint,
+GraphicObjectType eMapTo,
 const css::awt::Size* pRefSize = nullptr,
 bool bDataSeries = false,
 bool bUseSpecialFillColor = false,
diff --git a/chart2/source/controller/inc/GraphicPropertyItemConverter.hxx 
b/chart2/source/controller/inc/GraphicPropertyItemConverter.hxx
index ceeb5811dfe2..6f09b20c78d5 100644
--- a/chart2/source/controller/inc/GraphicPropertyItemConverter.hxx
+++ b/chart2/source/controller/inc/GraphicPropertyItemConverter.hxx
@@ -46,7 +46,7 @@ public:
 SfxItemPool& rItemPool,
 SdrModel& rDrawModel,
 const css::uno::Reference< css::lang::XMultiServiceFactory > & 
xNamedPropertyContainerFactory,
-GraphicObjectType eObjectType = GraphicObjectType::FilledDataPoint );
+GraphicObjectType eObjectType );
 virtual ~GraphicPropertyItemConverter() override;
 
 protected:
diff --git a/chart2/source/controller/inc/LegendItemConverter.hxx 

[Libreoffice-commits] core.git: forms/source include/svx include/test sc/inc sc/source sdext/source sd/source soltools/cpp svx/source test/source vcl/inc vcl/unx writerperfect/source

[Noel Grandin]

 forms/source/richtext/richtextengine.cxx   |2 
 forms/source/richtext/richtextengine.hxx   |2 
 include/svx/colorwindow.hxx|2 
 include/test/sheet/xmultipleoperation.hxx  |2 
 sc/inc/colorscale.hxx  |4 
 sc/inc/column.hxx  |2 
 sc/inc/compare.hxx |2 
 sc/inc/dptabres.hxx|2 
 sc/inc/dputil.hxx  |2 
 sc/inc/drwlayer.hxx|2 
 sc/inc/formulacell.hxx |4 
 sc/inc/tokenarray.hxx  |4 
 sc/source/core/data/colorscale.cxx |4 
 sc/source/core/data/column3.cxx|2 
 sc/source/core/data/dpdimsave.cxx  |2 
 sc/source/core/data/dptabres.cxx   |2 
 sc/source/core/data/dputil.cxx |2 
 sc/source/core/data/drwlayer.cxx   |2 
 sc/source/core/data/formulacell.cxx|6 -
 sc/source/core/tool/autoform.cxx   |2 
 sc/source/core/tool/compare.cxx|2 
 sc/source/core/tool/formulagroup.cxx   |2 
 sc/source/core/tool/interpr8.cxx   |   10 +-
 sc/source/core/tool/token.cxx  |4 
 sc/source/filter/excel/xepivotxml.cxx  |2 
 sc/source/filter/html/htmlpars.cxx |4 
 sc/source/filter/inc/htmlpars.hxx  |6 -
 sc/source/filter/xml/XMLChangeTrackingExportHelper.cxx |   12 +-
 sc/source/filter/xml/XMLChangeTrackingExportHelper.hxx |4 
 sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx |   14 +--
 sc/source/filter/xml/XMLChangeTrackingImportHelper.hxx |   14 +--
 sc/source/filter/xml/XMLStylesExportHelper.cxx |2 
 sc/source/filter/xml/XMLStylesExportHelper.hxx |2 
 sc/source/ui/docshell/docsh5.cxx   |2 
 sc/source/ui/inc/output.hxx|2 
 sc/source/ui/vba/vbarange.cxx  |2 
 sc/source/ui/vba/vbarange.hxx  |2 
 sc/source/ui/view/cellsh2.cxx  |2 
 sc/source/ui/view/gridwin.cxx  |4 
 sc/source/ui/view/gridwin_dbgutil.cxx  |2 
 sc/source/ui/view/output2.cxx  |   72 -
 sc/source/ui/view/reffact.cxx  |2 
 sd/source/ui/func/fupage.cxx   |2 
 sd/source/ui/inc/fupage.hxx|2 
 sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx  |4 
 sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx   |4 
 sdext/source/pdfimport/xpdfwrapper/pnghelper.hxx   |4 
 soltools/cpp/_tokens.c |4 
 soltools/cpp/cpp.h |2 
 svx/source/tbxctrls/tbcontrl.cxx   |2 
 test/source/sheet/xmultipleoperation.cxx   |2 
 vcl/inc/unx/wmadaptor.hxx  |2 
 vcl/unx/generic/app/wmadaptor.cxx  |2 
 writerperfect/source/writer/exp/xmlfmt.cxx |4 
 54 files changed, 127 insertions(+), 127 deletions(-)

New commits:
commit be354a2abd27548405caf97fdbc814b5a6b06995
Author: Noel Grandin 
Date:   Wed Dec 6 16:18:58 2017 +0200

loplugin:constparams

Change-Id: Ia322ecf8f80b28c58ec33d17ca9607401a92534b
Reviewed-on: https://gerrit.libreoffice.org/45959
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/forms/source/richtext/richtextengine.cxx 
b/forms/source/richtext/richtextengine.cxx
index 0f583441e832..740996b76a78 100644
--- a/forms/source/richtext/richtextengine.cxx
+++ b/forms/source/richtext/richtextengine.cxx
@@ -113,7 +113,7 @@ namespace frm
 }
 
 
-void RichTextEngine::revokeEngineStatusListener( IEngineStatusListener* 
_pListener )
+void RichTextEngine::revokeEngineStatusListener( IEngineStatusListener 
const * _pListener )
 {
 ::std::vector< IEngineStatusListener* >::iterator aPos = 
::std::find_if(
 m_aStatusListeners.begin(),
diff --git a/forms/source/richtext/richtextengine.hxx 
b/forms/source/richtext/richtextengine.hxx
index e71189907e4f..21175a4165be 100644
--- a/forms/source/richtext/richtextengine.hxx
+++ b/forms/source/richtext/richtextengine.hxx
@@ -53,7 +53,7 @@ namespace frm
 
 // for multiplexing the StatusChanged events of the edit engine
 void registerEngineStatusListener( IEngineStatusListener* _pListener );
-void 

[Libreoffice-commits] core.git: connectivity/source dbaccess/source include/connectivity

[Noel Grandin]

 connectivity/source/cpool/ZConnectionPool.cxx|2 +-
 connectivity/source/drivers/evoab2/NTable.hxx|6 +++---
 connectivity/source/drivers/evoab2/NTables.cxx   |1 +
 connectivity/source/drivers/firebird/Columns.cxx |3 ++-
 connectivity/source/inc/OColumn.hxx  |   11 +--
 connectivity/source/inc/component/CTable.hxx |6 +++---
 connectivity/source/inc/dbase/dindexnode.hxx |6 +++---
 connectivity/source/inc/file/FTable.hxx  |6 +++---
 connectivity/source/inc/file/fcode.hxx   |4 ++--
 connectivity/source/inc/hsqldb/HTable.hxx|8 
 connectivity/source/inc/mysql/YTable.hxx |8 
 dbaccess/source/core/api/OptimisticSet.cxx   |8 
 dbaccess/source/core/api/RowSetCache.cxx |   10 +-
 include/connectivity/FValue.hxx  |4 ++--
 include/connectivity/TColumnsHelper.hxx  |2 +-
 include/connectivity/dbexception.hxx |2 +-
 include/connectivity/dbtools.hxx |8 
 include/connectivity/sqlparse.hxx|2 +-
 18 files changed, 49 insertions(+), 48 deletions(-)

New commits:
commit e1755ac8c42ba4657881ecf7aa652a137abf3267
Author: Noel Grandin 
Date:   Tue Dec 5 11:47:52 2017 +0200

loplugin:countusersofdefaultparams in connectivity

Change-Id: Ia613257f2de1395c6629c1c37026ed48d4b927c8
Reviewed-on: https://gerrit.libreoffice.org/45854
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/connectivity/source/cpool/ZConnectionPool.cxx 
b/connectivity/source/cpool/ZConnectionPool.cxx
index d6d1c8f3ee13..ddb80da0c02c 100644
--- a/connectivity/source/cpool/ZConnectionPool.cxx
+++ b/connectivity/source/cpool/ZConnectionPool.cxx
@@ -82,7 +82,7 @@ struct TRemoveEventListenerFunctor
 OConnectionPool* m_pConnectionPool;
 bool m_bDispose;
 
-TRemoveEventListenerFunctor(OConnectionPool* _pConnectionPool,bool 
_bDispose = false)
+TRemoveEventListenerFunctor(OConnectionPool* _pConnectionPool, bool 
_bDispose)
 : m_pConnectionPool(_pConnectionPool)
 ,m_bDispose(_bDispose)
 {
diff --git a/connectivity/source/drivers/evoab2/NTable.hxx 
b/connectivity/source/drivers/evoab2/NTable.hxx
index c3e984ce78b6..eb1159847d20 100644
--- a/connectivity/source/drivers/evoab2/NTable.hxx
+++ b/connectivity/source/drivers/evoab2/NTable.hxx
@@ -38,9 +38,9 @@ namespace connectivity
 OEvoabConnection* _pConnection,
 const OUString& Name,
 const OUString& Type,
-const OUString& Description = OUString(),
-const OUString& SchemaName = OUString(),
-const OUString& CatalogName = OUString()
+const OUString& Description,
+const OUString& SchemaName,
+const OUString& CatalogName
 );
 
 OEvoabConnection* getConnection() { return m_pConnection;}
diff --git a/connectivity/source/drivers/evoab2/NTables.cxx 
b/connectivity/source/drivers/evoab2/NTables.cxx
index 652ac07030e1..7beaffdca6d6 100644
--- a/connectivity/source/drivers/evoab2/NTables.cxx
+++ b/connectivity/source/drivers/evoab2/NTables.cxx
@@ -63,6 +63,7 @@ ObjectType OEvoabTables::createObject(const OUString& aName)
 aName,
 xRow->getString(4),
 xRow->getString(5),
+"",
 "");
 xRet = pRet;
 }
diff --git a/connectivity/source/drivers/firebird/Columns.cxx 
b/connectivity/source/drivers/firebird/Columns.cxx
index d418026ce6c2..8089cab8c965 100644
--- a/connectivity/source/drivers/firebird/Columns.cxx
+++ b/connectivity/source/drivers/firebird/Columns.cxx
@@ -29,7 +29,8 @@ Columns::Columns(Table& rTable,
 OColumnsHelper(rTable,
true, // TODO: is this case sensitivity?
rMutex,
-   rVector)
+   rVector,
+   /*bUseHardRef*/true)
 {
 OColumnsHelper::setParent();
 }
diff --git a/connectivity/source/inc/OColumn.hxx 
b/connectivity/source/inc/OColumn.hxx
index fb087a859853..e0d86d7e9497 100644
--- a/connectivity/source/inc/OColumn.hxx
+++ b/connectivity/source/inc/OColumn.hxx
@@ -71,12 +71,11 @@ namespace connectivity
 
 OColumn(const OUString &_aTableName,
 const OUString &_aColumnName,
-
-sal_Int32   _aNullable=0,
-sal_Int32   _aColumnDisplaySize=0,
-sal_Int32   _aPrecision=0,
-sal_Int32   _aScale=0,
-sal_Int32   _aColumnType=0)
+sal_Int32   _aNullable,
+sal_Int32   _aColumnDisplaySize,
+sal_Int32   _aPrecision,
+sal_Int32 

[Libreoffice-bugs] [Bug 107220] Support 'rand' feature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107220

--- Comment #7 from Volga  ---
(In reply to Khaled Hosny from comment #5)
> If someone wants to work on this, all power to them. Otherwise the only font
> I know that uses the rand feature is a font I created myself to tests its
> support, so very low priority.
It’s also hard to investigate which commercial fonts including this feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106045] [META] Vertical text direction issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106045
Bug 106045 depends on bug 108300, which changed state.

Bug 108300 Summary: Several Letterlike Symbols do not upright in vertical layout
https://bugs.documentfoundation.org/show_bug.cgi?id=108300

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108300] Several Letterlike Symbols do not upright in vertical layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108300

Volga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114002] Unicode Hentaigana does not rotate in vertical layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114002

Volga  changed:

   What|Removed |Added

 CC||mark...@gmail.com

--- Comment #10 from Volga  ---
Still reproduce in
Version: 6.1.0.0.alpha0+ (x64)
Build ID: 1d8cb97fea57b81a1ab151b88c2180e646bd401b
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-12-07_02:07:17
Locale: zh-CN (zh_CN); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111444] Tangut chatacters do not rotate in vertical layout ( Tangut Yinchuan)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111444

--- Comment #8 from Volga  ---
Still reproduce in
Version: 6.1.0.0.alpha0+ (x64)
Build ID: 1d8cb97fea57b81a1ab151b88c2180e646bd401b
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-12-07_02:07:17
Locale: zh-CN (zh_CN); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108300] Several Letterlike Symbols do not upright in vertical layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108300

--- Comment #5 from Volga  ---
Fixed in bug 108302.

Version: 6.1.0.0.alpha0+ (x64)
Build ID: 1d8cb97fea57b81a1ab151b88c2180e646bd401b
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-12-07_02:07:17
Locale: zh-CN (zh_CN); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114298] New: some files formatted portrait always print landscape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114298

Bug ID: 114298
   Summary: some files formatted portrait always print landscape
   Product: LibreOffice
   Version: 5.3.7.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: arbo...@protonmail.com

Description:
Some--not all--files formatted to print in portrait mode will now only print in
landscape.  This happens with newly created files as well as old files.  I can
print them on an old version of LibreOffice--4.3.7.2--with no problems.  This
problem began with one of the 5.x.x.x releases.

After resetting everything the Format-Page-Page settings for Portrait were
WRONG. However, putting the correct sizes for Portrait DID NOT correct the
problem.

Steps to Reproduce:
1. load a .odt file that has been formatted to print in portrait mode
2. check to see if it prints correctly
 if the doc prints wrong check it on an older version of LibreOffice

Actual Results:  
Some of my documents print incorrectly.  But the same docs print OK in older
versions of LibreOffice.

Expected Results:
that documents formatted to print in portrait mode do just that.


Reproducible: Sometimes


User Profile Reset: Yes



Additional Info:
LibreOffice 5.3.7.2
Mac OS X 10.12.6
Lexmark E260dn - which has been working correctly for years.

Currently, all other printing (from other software) is fine.


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:57.0)
Gecko/20100101 Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 53095] VIEWING: Scroll really laggy when open big xls file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=53095

XTR  changed:

   What|Removed |Added

  Attachment #65089|0   |1
is obsolete||

--- Comment #12 from XTR  ---
Created attachment 138259
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138259=edit
repro document  multiple invisible graphic objects

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114018] Yi (Nuosu) characters does not rotate in vertical layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114018

Volga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Volga  ---
Fixed in bug 108302.

Version: 6.1.0.0.alpha0+ (x64)
Build ID: 1d8cb97fea57b81a1ab151b88c2180e646bd401b
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-12-07_02:07:17
Locale: zh-CN (zh_CN); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106045] [META] Vertical text direction issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106045
Bug 106045 depends on bug 114018, which changed state.

Bug 114018 Summary: Yi (Nuosu) characters does not rotate in vertical layout
https://bugs.documentfoundation.org/show_bug.cgi?id=114018

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 53095] VIEWING: Scroll really laggy when open big xls file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=53095

--- Comment #11 from XTR  ---
Did minimized version of repro file
There are mupliple (~5k) invisible graphic objects (text boxes), so may be this
bug related to other bugs about multiple graphic objects processing

Still repro with
LO  6.0.0.0.beta1 (x64)  97471ab4eb4db4c487195658631696bb3238656c  windows 7

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/test qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/qa test/Library_subsequenttest.mk test/source

[Jens Carl]

 include/test/sheet/xdatapilottablessupplier.hxx |   34 ++
 qadevOOo/Jar_OOoRunner.mk   |1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetObj.csv |1 
 qadevOOo/tests/java/ifc/sheet/_XDataPilotTablesSupplier.java|   50 
--
 sc/qa/extras/sctablesheetobj.cxx|7 +
 test/Library_subsequenttest.mk  |1 
 test/source/sheet/xdatapilottablessupplier.cxx  |   32 ++
 7 files changed, 73 insertions(+), 53 deletions(-)

New commits:
commit c7e5c7da98d40852d18bd7683e40c9679836ba49
Author: Jens Carl 
Date:   Wed Dec 6 22:48:01 2017 +

tdf#45904 Move _XDataPilotTablesSupplier Java test to C++

Change-Id: Iaea5b7abc0a289035c7a230c0034d2422cc4ae5f
Reviewed-on: https://gerrit.libreoffice.org/46001
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/include/test/sheet/xdatapilottablessupplier.hxx 
b/include/test/sheet/xdatapilottablessupplier.hxx
new file mode 100644
index ..ca1e623b3b96
--- /dev/null
+++ b/include/test/sheet/xdatapilottablessupplier.hxx
@@ -0,0 +1,34 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_TEST_SHEET_XDATAPILOTTABLESSUPPLIER_HXX
+#define INCLUDED_TEST_SHEET_XDATAPILOTTABLESSUPPLIER_HXX
+
+#include 
+#include 
+
+#include 
+
+namespace apitest
+{
+class OOO_DLLPUBLIC_TEST XDataPilotTablesSupplier
+{
+public:
+virtual css::uno::Reference init() = 0;
+
+void testGetDataPilotTables();
+
+protected:
+~XDataPilotTablesSupplier() {}
+};
+}
+
+#endif // INCLUDED_TEST_SHEET_XDATAPILOTTABLESSUPPLIER_HXX
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index 24dd5cd7f8a9..5751f1cb8ef9 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -598,7 +598,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
 qadevOOo/tests/java/ifc/sheet/_XDatabaseRanges \
 qadevOOo/tests/java/ifc/sheet/_XDataPilotField \
 qadevOOo/tests/java/ifc/sheet/_XDataPilotTables \
-qadevOOo/tests/java/ifc/sheet/_XDataPilotTablesSupplier \
 qadevOOo/tests/java/ifc/sheet/_XDDELink \
 qadevOOo/tests/java/ifc/sheet/_XDocumentAuditing \
 qadevOOo/tests/java/ifc/sheet/_XEnhancedMouseClickBroadcaster \
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetObj.csv
index 5356fe01fc80..48032b0f4309 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetObj.csv
@@ -231,7 +231,6 @@
 
"ScTableSheetObj";"com::sun::star::chart::XChartDataArray";"setRowDescriptions()"
 
"ScTableSheetObj";"com::sun::star::chart::XChartDataArray";"getColumnDescriptions()"
 
"ScTableSheetObj";"com::sun::star::chart::XChartDataArray";"setColumnDescriptions()"
-"ScTableSheetObj";"com::sun::star::sheet::XDataPilotTablesSupplier";"getDataPilotTables()"
 
"ScTableSheetObj";"com::sun::star::sheet::XCellFormatRangesSupplier";"getCellFormatRanges()"
 
"ScTableSheetObj";"com::sun::star::util::XModifyBroadcaster#optional";"addModifyListener()"
 
"ScTableSheetObj";"com::sun::star::util::XModifyBroadcaster#optional";"removeModifyListener()"
diff --git a/qadevOOo/tests/java/ifc/sheet/_XDataPilotTablesSupplier.java 
b/qadevOOo/tests/java/ifc/sheet/_XDataPilotTablesSupplier.java
deleted file mode 100644
index 312c3db253ac..
--- a/qadevOOo/tests/java/ifc/sheet/_XDataPilotTablesSupplier.java
+++ /dev/null
@@ -1,50 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-package ifc.sheet;
-
-import lib.MultiMethodTest;
-
-import com.sun.star.sheet.XDataPilotTables;

[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #89 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c7e5c7da98d40852d18bd7683e40c9679836ba49

tdf#45904 Move _XDataPilotTablesSupplier Java test to C++

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Association between ToC index object and its paragraph content

[Jens Tröger]

Hello,

While walking all paragraphs of a Writer document and visiting their text
content, I come across text portions (the Heading N) which have Bookmarks
whose name is something like “_Toc263250771”. However, when I walk the 
paragraphs and text portions that actually make up the ToC of the document
itself, I see no indication or reference to these bookmarks.

Likewise, when I get the ToC of the document I can find some information
about entries, where it’s anchored on the page, but no actual “unfolded”
content.

Question is also posted in the forum including some code snippets:

  https://forum.openoffice.org/en/forum/viewtopic.php?t=91448

Is there an association between the XDocumentIndex object (the ToC index
of the document) and the XTextContent objects (paragraphs that make the
actual ToC content) and how can I find it?

Thanks!
Jens

-- 
Jens Tröger
http://savage.light-speed.de/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: writerfilter/source

[Mike Kaganski]

 writerfilter/source/ooxml/OOXMLDocumentImpl.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit e5a3f12588e8e8eb80cc5af4e412fa2c83f0895e
Author: Mike Kaganski 
Date:   Wed Dec 6 15:14:43 2017 +0200

Check if we have status indicator

In other methods it's always checked, so presumably it might be absent.
In caller sites (like OOXMLFastContextHandler::endOfParagraph), it can't
(and shouldn't) be checked.

Change-Id: Ia2edf8b121cac15e6454bc6321d76517fcdf110f
Reviewed-on: https://gerrit.libreoffice.org/45951
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx 
b/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx
index 44552eee5e5f..2223b2a6c61c 100644
--- a/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx
+++ b/writerfilter/source/ooxml/OOXMLDocumentImpl.cxx
@@ -529,7 +529,8 @@ void OOXMLDocumentImpl::incrementProgress()
 if (mnProgressEndPos && mnProgressCurrentPos > (mnProgressLastPos + 
mnPercentSize) && mnProgressLastPos < mnProgressEndPos)
 {
 mnProgressLastPos = mnProgressCurrentPos;
-mxStatusIndicator->setValue(mnProgressLastPos);
+if (mxStatusIndicator.is())
+mxStatusIndicator->setValue(mnProgressLastPos);
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 109995] Unable to change textgrid color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109995

Kevin Suo  changed:

   What|Removed |Added

 CC||suokunl...@126.com

--- Comment #2 from Kevin Suo  ---
I do not reproduce with
Version: 6.1.0.0.alpha0+
Build ID：2392238e480ecc1d1a5e2e69789e79c10f142d6c
CPU 线程：4; 操作系统：Linux 4.13; UI 渲染：默认; VCL: gtk2; 
Locale: zh-CN (zh_CN.UTF-8); Calc: group threaded

and 
版本：5.4.4.1
Build ID：da790616461e15a10c95a80eb8ef8ee7b726c114
CPU 线程：4; 操作系统：Linux 4.13; UI 渲染：默认; VCL: gtk2; 
区域语言：zh-CN (zh_CN.UTF-8); Calc: group

Fedora 26.

Is it fixed somewhere?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108302] Dingbats fully rotated in vertical layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108302

Kevin Suo  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |mark...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106045] [META] Vertical text direction issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106045
Bug 106045 depends on bug 108302, which changed state.

Bug 108302 Summary: Dingbats fully rotated in vertical layout
https://bugs.documentfoundation.org/show_bug.cgi?id=108302

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108302] Dingbats fully rotated in vertical layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108302

Kevin Suo  changed:

   What|Removed |Added

 CC||suokunl...@126.com

--- Comment #8 from Kevin Suo  ---
Created attachment 138258
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138258=edit
Screenshot after the fix

This is how it looks like after the fix on master.

I am marking this as RESOLVED FIXED. Backport to libreoffice-6-0 is in
https://gerrit.libreoffice.org/#/c/45919/.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: oox/source sw/qa

[Justin Luth]

 oox/source/vml/vmlshapecontext.cxx|2 ++
 sw/qa/extras/ooxmlexport/ooxmlexport9.cxx |2 ++
 2 files changed, 4 insertions(+)

New commits:
commit 9644f506ae31f1cacd6ab4c24b2591179791eebd
Author: Justin Luth 
Date:   Mon Sep 18 15:57:51 2017 -0400

tdf#97648 ooxmlimport: horizontal lines have no margins

Change-Id: I170ab7a742f8e9d8029512592abda9fc54edda18
Reviewed-on: https://gerrit.libreoffice.org/42437
Tested-by: Jenkins 
Reviewed-by: Justin Luth 

diff --git a/oox/source/vml/vmlshapecontext.cxx 
b/oox/source/vml/vmlshapecontext.cxx
index 423ba1458053..8181c982780d 100644
--- a/oox/source/vml/vmlshapecontext.cxx
+++ b/oox/source/vml/vmlshapecontext.cxx
@@ -308,6 +308,8 @@ ShapeTypeContext::ShapeTypeContext(ContextHandler2Helper 
const & rParent,
 OUString hrpct = rAttribs.getString( O_TOKEN( hrpct ), "1000" );
 if( hrpct != "0" )
 mrTypeModel.maWidthPercent = OUString::number( hrpct.toInt32() );
+mrTypeModel.maWrapDistanceLeft = "0";
+mrTypeModel.maWrapDistanceRight = "0";
 }
 
 // stroke settings (may be overridden by v:stroke element later)
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
index 66eda44719f8..bbcaf277cb79 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
@@ -232,6 +232,8 @@ 
DECLARE_OOXMLEXPORT_TEST(testTdf97648_relativeWidth,"tdf97648_relativeWidth.docx
 CPPUNIT_ASSERT_DOUBLES_EQUAL( sal_Int32(8001), 
getShape(2)->getSize().Width, 10);
 CPPUNIT_ASSERT_DOUBLES_EQUAL( sal_Int32(4001), 
getShape(3)->getSize().Width, 10);
 CPPUNIT_ASSERT_DOUBLES_EQUAL( sal_Int32(1600), 
getShape(4)->getSize().Width, 10);
+
+CPPUNIT_ASSERT_EQUAL( sal_Int32(0), getProperty(getShape(1), 
"LeftMargin") );
 }
 
 
DECLARE_OOXMLEXPORT_TEST(testTdf104061_tableSectionColumns,"tdf104061_tableSectionColumns.docx")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'feature/gpg4libre2'

[Thorsten Behrens]

New branch 'feature/gpg4libre2' available with the following commits:
commit f0a8da9ab9143401072de7793613fd12a2e34fd9
Author: Thorsten Behrens 
Date:   Thu Dec 7 05:11:54 2017 +0100

fixup demo - now encrypting for real

Change-Id: I98571c269137a5de375de51b81700700e0dfb0e4

commit f0498d776b38a83c641271fbbe31900caa8a28e2
Author: Thorsten Behrens 
Date:   Thu Dec 7 05:11:15 2017 +0100

gpg4libre: multi-select encrypt cert, pass down params everywhere

Change-Id: I152b9d84c0e35be9e5193a9a6f67de9fb86133b0

commit fc9ce4928cd60166dec92e7f18ca90f910622646
Author: Thorsten Behrens 
Date:   Thu Dec 7 05:08:37 2017 +0100

fixup gpgmepp: build with proper debug flags

Change-Id: Ide3f6e9fa218bcd26deaadbbdbed0c8905e66db9

commit f217d3ef94724a84a87ef72db893c2b8380151e8
Author: Thorsten Behrens 
Date:   Thu Dec 7 02:25:11 2017 +0100

fixup manifest export

Change-Id: I9d7eb45c0b7c829769c5258ff3ccff28555691ae

commit c23564adaadf64c8f22c8d0e73977f18b53a09d5
Author: Thorsten Behrens 
Date:   Thu Dec 7 02:24:42 2017 +0100

fixup api change: setGpgProperties

Change-Id: I923a2c3d38c6d3d5aaa73ae10d08d8511eae7b4b

commit 98a11c6bd03f5e54a2d52221e74c23902266d65f
Author: Thorsten Behrens 
Date:   Thu Dec 7 01:36:04 2017 +0100

fixup Manifest keyinfo export

Change-Id: I669b02fd85b28eb33c89971146e5e712b507b7fa

commit c4ca4bde5c6a160b7a871a65919b71339486fa97
Author: Thorsten Behrens 
Date:   Wed Dec 6 15:20:54 2017 +0100

gpg4libre: add KDE4 fpicker gpg crypt chechbox

Change-Id: Iba8fb0e0ac732f36cd1d880884bde1121e6b1eab

commit e0ccaa6e95e3b880e5d694e9cf9c20da41875a3e
Author: Thorsten Behrens 
Date:   Wed Dec 6 14:02:25 2017 +0100

gpg4libre: add unit tests for ODF signing feature

Change-Id: I59e5b563098b19d05c8c2db32537241bc835fc80

commit 121eccad6442f5c112c87195fde12a0418027101
Author: Thorsten Behrens 
Date:   Wed Dec 6 12:29:43 2017 +0100

ZipPackageStream props - do we really need that?

Change-Id: I6979c1b9b4d25ae5592c6d46bfb2bc099860d770

commit 67aacf6864d809f3793f98602edb93c240184409
Author: Katarina Behrens 
Date:   Wed Nov 29 23:07:47 2017 +0100

Restore GPG SEInitializer service

user config now needs it to collect user's private GPG keys

Reviewed-on: https://gerrit.libreoffice.org/45562
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 1c58b047d117bb087abc571b74c06cdf7499b1a0)

Change-Id: Ia4ad4133b621160cf37281750cafa9f3c5c3c231

commit 57167fc1d22738e6da19be7ff48ed89856698a36
Author: Thorsten Behrens 
Date:   Mon Dec 4 02:22:09 2017 +0100

gpg4libre: add gtk fpicker gpg crypt chechbox

Change-Id: I27b494530a2b61eb37c4a9f7c3e1f9845f045e66

commit 1d9a1600c61c190dcd683542e0904416e34acf1a
Author: Thorsten Behrens 
Date:   Mon Dec 4 00:36:06 2017 +0100

fix build - circular deps of sax and comphelper

Change-Id: I9ab5e5b0565560681b2ffca95674820865bcb44c

commit bf35b7d2d2fad7a6df9ec68a6b304102b6bed370
Author: Thorsten Behrens 
Date:   Fri Nov 24 03:27:05 2017 +0100

gpg4libre: encryption on save demo

Change-Id: Ib2fd32cf2550f30bc0d84213ad05a4b95da093d1

commit 52cc01ca7ccd4c1d579c15fea82390b75127f418
Author: Thorsten Behrens 
Date:   Thu Nov 23 23:28:13 2017 +0100

gpg4libre: add gpg encrypt checbox to win32 filepicker

Change-Id: Ia6315e8b1f04228984afd2fbca3c059df9589497

commit 259567e5737081e6fb563fb29bade1ed7821cc71
Author: Thorsten Behrens 
Date:   Thu Nov 23 22:18:09 2017 +0100

gpg4libre: find keymanager executable on Windows

Change-Id: If93c06ad90d708b0fbaf476bda6fdb902bd77b1e

commit 5f065fd7a82bcf64ae042e25e37e45f6e5e6dee5
Author: Thorsten Behrens 
Date:   Sun Aug 20 03:43:20 2017 +0200

gpg4libre: pass down OpenPGP encryption info to package code

Change-Id: Ie67c9927efdad4a027b14ed6a37a188b85eaf077

commit b8f69604391cd16a77250af4b1d96fda65d44e44
Author: Thorsten Behrens 
Date:   Sun Aug 20 03:38:05 2017 +0200

gpg4libre: [API CHANGE] add storage helper for GPG encryption data

gpg4libre needs to pass down slightly different meta data
to package / zip storage.

Change-Id: Idba9ad7a821cb33070cf5e5a0f79ae55db99b276

commit eca7573be0dc04548e664b96d812d82c399f1808
Author: Thorsten Behrens 
Date:   Fri Aug 18 21:34:11 2017 +0200

gpg4libre: add manifest entries for gpg encryption

Change-Id: I71bd7e2c6c73d997fa1ed5bb36fdc2873daca10c

[Libreoffice-bugs] [Bug 107337] Crash in: FontList::ImplFind(rtl::OUString const &, unsigned __int64 *)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107337

--- Comment #10 from harry.br...@hwbrucepe.com ---
Have finally recovered the system.  I will download and install from the master
build.

Harry

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Changes to 'private/kohei/excel-2003-xml-orcus-filter'

[Kohei Yoshida]

New branch 'private/kohei/excel-2003-xml-orcus-filter' available with the 
following commits:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/excel-2003-xml-orcus-filter' - 0 commits -

[Unknown]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114297] New: [Notebookbar] [Groupedbar] Add connectors dropdown button to the interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114297

Bug ID: 114297
   Summary: [Notebookbar] [Groupedbar] Add connectors dropdown
button to the interface
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: diazbast...@openmailbox.org

Description:
Currently there is no way to add connectors easily from the interface or the
corresponding menu (full/compact).

Steps to Reproduce:
1. See in the drawing area
2. See in the draw menu
3. Add a flowchart shape and search in the new context available options

Actual Results:  
There is no way to add connectors

Expected Results:
A connectors dropdown button is available in the interface or in the Draw menu


Reproducible: Always


User Profile Reset: No



Additional Info:
Suggested solution: I would expect to see connectors dropdown button instead of
curve. I have no usage data to support me, but from experience I think that
connectors are a more used element (diagrams). Additionally the options
available in the curve dropdown button are already in the "draw" menu.

Note: The inclusion of the options "insert image" and "fontwork ..." in the
Draw menu is by design?


User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Julien Nabet]

 sw/source/core/table/swnewtable.cxx |   12 +++-
 1 file changed, 3 insertions(+), 9 deletions(-)

New commits:
commit 49d1ab032b87634116561b970dcc580be96f33f1
Author: Julien Nabet 
Date:   Wed Dec 6 22:26:30 2017 +0100

Use return iterator from erase in swnewtable (sw)

Change-Id: I748ebeeef41a102feb63c304d4fae64775a3c8e2
Reviewed-on: https://gerrit.libreoffice.org/45998
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/sw/source/core/table/swnewtable.cxx 
b/sw/source/core/table/swnewtable.cxx
index cc0a5fd403d0..03e84964a4ff 100644
--- a/sw/source/core/table/swnewtable.cxx
+++ b/sw/source/core/table/swnewtable.cxx
@@ -1269,9 +1269,7 @@ static void lcl_SophisticatedFillLineIndices( 
SwLineOffsetArray ,
 if( pCurr->first == aLnOfs.first )
 {   // These boxes can be removed because the last insertion
 // of rows will expand their row span above the needed value
-std::list< SwLineOffset >::iterator pDel = pCurr;
-++pCurr;
-aBoxes.erase( pDel );
+pCurr = aBoxes.erase(pCurr);
 }
 else
 {
@@ -1286,9 +1284,7 @@ static void lcl_SophisticatedFillLineIndices( 
SwLineOffsetArray ,
 if( pCurr->second >= nCnt )
 {   // if the row span is bigger than the split factor
 // this box is done
-std::list< SwLineOffset >::iterator pDel = pCurr;
-++pCurr;
-aBoxes.erase( pDel );
+pCurr = aBoxes.erase(pCurr);
 }
 else
 ++pCurr;
@@ -2146,9 +2142,7 @@ void SwTable::CheckConsistency() const
 "Wrong row span value" );
 if( nRowSp == -1 )
 {
-std::list< RowSpanCheck >::iterator aEraseIter = aIter;
-++aIter;
-aRowSpanCells.erase( aEraseIter );
+aIter = aRowSpanCells.erase(aIter);
 }
 else
 ++aIter;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114296] New: [Notebookbar] [Groupedbar] Insert Text Box button doesn' t work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114296

Bug ID: 114296
   Summary: [Notebookbar] [Groupedbar] Insert Text Box button
doesn't work
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: diazbast...@openmailbox.org

Description:
When you click on the button nothing happens.

Steps to Reproduce:
1. Go and click on the Insert Text Box button
2. Move the cursor to the slide

Actual Results:  
Nothing happens.

Expected Results:
A special cursor appears that allows you to select the location to insert a
text box.


Reproducible: Always


User Profile Reset: Yes



Additional Info:


User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

rtl_random_createPool explicit seeding with systemTime considered redundant?

[Thorsten Behrens]

Hi Stephan, dear fellow hackers,

there's a chunk of places in the code, where (cargo-culted?) a random
pool gets fed with current system time, presumably to seed it with
enough entropy:

TimeValue aTime;
osl_getSystemTime(  );
rtlRandomPool aRandomPool = rtl_random_createPool ();
rtl_random_addBytes ( aRandomPool, , 8 );

Then again, initPool() in sal/rtl/random.cxx already does the same, so
that really looks redundant?

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: lotuswordpro/source

[Thorsten Behrens]

 lotuswordpro/source/filter/lwplayout.cxx |   15 +++
 lotuswordpro/source/filter/lwplayout.hxx |1 -
 2 files changed, 3 insertions(+), 13 deletions(-)

New commits:
commit 1d8cb97fea57b81a1ab151b88c2180e646bd401b
Author: Thorsten Behrens 
Date:   Thu Dec 7 01:24:21 2017 +0100

Revert "ofz#4548 infinite regress in GetUsePrinterSettings"

This breaks a unit test:

filters-test.cxx:145:Assertion
Test name: (anonymous namespace)::LotusWordProTest::test
equality assertion failed
- Expected: 1
- Actual  : 0

This reverts commit d38674f3b5b6c97be5f8822f52301e29d677ed1e.

diff --git a/lotuswordpro/source/filter/lwplayout.cxx 
b/lotuswordpro/source/filter/lwplayout.cxx
index acd913cd8489..cdaa7ab7dfa3 100644
--- a/lotuswordpro/source/filter/lwplayout.cxx
+++ b/lotuswordpro/source/filter/lwplayout.cxx
@@ -81,7 +81,6 @@ LwpVirtualLayout::LwpVirtualLayout(LwpObjectHeader const 
, LwpSvStream* p
 , m_bGettingIsProtected(false)
 , m_bGettingMarginsValue(false)
 , m_bGettingExtMarginsValue(false)
-, m_bGettingUsePrinterSettings(false)
 , m_nAttributes(0)
 , m_nAttributes2(0)
 , m_nAttributes3(0)
@@ -1406,27 +1405,19 @@ XFBGImage* LwpMiddleLayout::GetXFBGImage()
 */
 bool LwpMiddleLayout::GetUsePrinterSettings()
 {
-if (m_bGettingUsePrinterSettings)
-throw std::runtime_error("recursion in layout");
-m_bGettingUsePrinterSettings = true;
-
-bool bRet = false;
-
 if(m_nOverrideFlag & OVER_SIZE)
 {
-bRet = (m_nAttributes3 & STYLE3_USEPRINTERSETTINGS) != 0;
+return (m_nAttributes3 & STYLE3_USEPRINTERSETTINGS) != 0;
 }
 else
 {
 rtl::Reference xBase(GetBasedOnStyle());
 if (LwpMiddleLayout* pLay = 
dynamic_cast(xBase.get()))
 {
-bRet = pLay->GetUsePrinterSettings();
+return pLay->GetUsePrinterSettings();
 }
 }
-
-m_bGettingMarginsValue = false;
-return bRet;
+return false;
 }
 
 //Check whether there are contents in the layout
diff --git a/lotuswordpro/source/filter/lwplayout.hxx 
b/lotuswordpro/source/filter/lwplayout.hxx
index cd84af5b380b..efff5f62fd07 100644
--- a/lotuswordpro/source/filter/lwplayout.hxx
+++ b/lotuswordpro/source/filter/lwplayout.hxx
@@ -226,7 +226,6 @@ protected:
 bool m_bGettingIsProtected;
 bool m_bGettingMarginsValue;
 bool m_bGettingExtMarginsValue;
-bool m_bGettingUsePrinterSettings;
 sal_uInt32 m_nAttributes;
 sal_uInt32 m_nAttributes2;
 sal_uInt32 m_nAttributes3;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114295] Calc addition is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114295

--- Comment #1 from MM  ---
This is normal, it's because the program rounds off the sum internally (15
numbers wide, int or float).
When using the option: options > LO Calc > Calculate > Limit decimals [] to
2 it should work for you. Maybe in previous versions it was set to this option,
but got changed somehow.
So not a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - sc/source

[Thorsten Behrens]

 sc/source/ui/docshell/docfunc.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 00b9d1f11baa4323c406bffbdb61a5b641d779fe
Author: Thorsten Behrens 
Date:   Thu Dec 7 00:06:36 2017 +0100

sc: don't crash on loading comments

Seems filters call ShowNote before a view is set or something.
Fixup for 2c50ad2a57c1b2313f39b8132ac5e80a45fd.

Change-Id: I9a69bf28b17cb16df7f1b1d06d9d3168da4a34b5
Reviewed-on: https://gerrit.libreoffice.org/46000
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 3809655e6d554dbc6c74b11597c540c4a62d4c09)
Reviewed-on: https://gerrit.libreoffice.org/46003

diff --git a/sc/source/ui/docshell/docfunc.cxx 
b/sc/source/ui/docshell/docfunc.cxx
index 4065a8ddb2cf..a00ec537c14b 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -1226,7 +1226,8 @@ bool ScDocFunc::ShowNote( const ScAddress& rPos, bool 
bShow )
 if (rDoc.IsStreamValid(rPos.Tab()))
 rDoc.SetStreamValid(rPos.Tab(), false);
 
-
ScDocShell::GetViewData()->GetScDrawView()->SyncForGrid(pNote->GetCaption());
+if (ScDocShell::GetViewData())
+
ScDocShell::GetViewData()->GetScDrawView()->SyncForGrid(pNote->GetCaption());
 rDocShell.SetDocumentModified();
 
 return true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Thorsten Behrens]

 sc/source/ui/docshell/docfunc.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 3809655e6d554dbc6c74b11597c540c4a62d4c09
Author: Thorsten Behrens 
Date:   Thu Dec 7 00:06:36 2017 +0100

sc: don't crash on loading comments

Seems filters call ShowNote before a view is set or something.
Fixup for 2c50ad2a57c1b2313f39b8132ac5e80a45fd.

Change-Id: I9a69bf28b17cb16df7f1b1d06d9d3168da4a34b5
Reviewed-on: https://gerrit.libreoffice.org/46000
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/sc/source/ui/docshell/docfunc.cxx 
b/sc/source/ui/docshell/docfunc.cxx
index 16b0a61aed51..939c54614d78 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -1216,7 +1216,8 @@ bool ScDocFunc::ShowNote( const ScAddress& rPos, bool 
bShow )
 
 ScTabView::OnLOKNoteStateChanged(pNote);
 
-
ScDocShell::GetViewData()->GetScDrawView()->SyncForGrid(pNote->GetCaption());
+if (ScDocShell::GetViewData())
+
ScDocShell::GetViewData()->GetScDrawView()->SyncForGrid(pNote->GetCaption());
 rDocShell.SetDocumentModified();
 
 return true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108302] Dingbats fully rotated in vertical layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108302

--- Comment #7 from Mark Hung  ---
(In reply to Volga from comment #6)
> Is it possible to backport to 5.4 branch?

I don't plan to do that. LibreOffice 6.0 is coming and 5.4 will become the
Stable one very soon. Less change will be better.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114221] Calc has changed the file password

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114221

--- Comment #9 from Aron Budea  ---
Created attachment 138257
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138257=edit
Sample XLS created in Excel (password: 1234)

Apparently it's easy to reproduce, here's a minimal sample created in Excel
2013, password is 1234, simply open, save and try to reopen.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114221] Calc has changed the file password

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114221

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||caol...@redhat.com
Version|5.3.7.2 release |5.3.0.3 release
 Ever confirmed|0   |1
 OS|Windows (All)   |All
   Severity|normal  |major

--- Comment #8 from Aron Budea  ---
Thanks for the sample, Francis!
Reproduced using 6.0beta1 & 5.3.0.3 / Windows 7. Assuming the bug isn't OS
dependent, unless claimed otherwise.
Also, it only occurs if you save the file, not when you do Save As.

The import of encryption was added with the commit referenced below. Caolán,
could you please check what is going wrong here?

https://cgit.freedesktop.org/libreoffice/core/commit/?id=1473ce030314027c01c98f513407ed0897328585
author  Caolán McNamara 2016-10-20 16:07:11
+0100
committer   Caolán McNamara 2016-10-21 11:16:11
+0100

implement CryptoAPI RC4+SHA1 encryption scheme for xls import

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114125] UI hangs / lockup when saving files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114125

--- Comment #3 from Colin Close  ---
See comment 40 on this bug for new information.
https://issues.openmandriva.org/show_bug.cgi?id=2259
The failing code has been isolated.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107765] CALC: Switching language during spell-check doesn' t change the text's language property

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107765

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Blocks||96000


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=96000
[Bug 96000] [META] Spelling and grammar checking bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96000] [META] Spelling and grammar checking bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96000

Aron Budea  changed:

   What|Removed |Added

 Depends on||107765


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107765
[Bug 107765] CALC: Switching language during spell-check doesn't change the
text's language property
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114293] [META] Address Book Data Source bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114293

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||113825


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113825
[Bug 113825] [META] Wizard bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113825] [META] Wizard bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113825

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||114293


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114293
[Bug 114293] [META] Address Book Data Source bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114295] New: Calc addition is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114295

Bug ID: 114295
   Summary: Calc addition is broken
   Product: LibreOffice
   Version: 5.4.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: documentfoundat...@nathanshearer.ca

Created attachment 138256
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138256=edit
screenshot of bad math

1) Create a new spreadsheet
2) In column A enter 751.19
3) In column B enter -700.1
4) In column C enter =A1+B2
5) resize column C to see the error

Does not exist in 5.1.1.3 on windows build
89f508ef3ecebd2cfb8e1def0f0ba9a803b88a6d
exists in libreoffice 5.4.2.2.0+ on gentoo x84
exists in libreoffice 5.2.3.3 on arm
exists in libreoffice 5.4.3.2 on windows x64 build
92a7159f7e4af62137622921e809f8546db437e5

This reminds me of the Pentium FDIV bug. This is just sad. At the very least a
spreadsheet application should be able to perform basic addition...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 55657] SLIDESHOW: Spin animation problem after document load

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=55657

Mike  changed:

   What|Removed |Added

 CC||bugzilla@mkr.email

--- Comment #5 from Mike  ---
I can confirm it for

Version: 6.1.0.0.alpha0+ (x64)
Build ID: 04982dc8f56e3a960b4d42b0ec57fc5cb8a01aa3
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-12-04_01:29:50
Locale: de-DE (de_DE); Calc: CL

Even if you fix it, if you save it and open it again, you'll see the issue
again.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114294] XLS file portrait format prints as landscape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114294

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #2 from Aron Budea  ---
Hopefully this is rather a duplicate of bug 92190, which means it's fixed, and
the fix will arrive with the next update, 5.4.4.

*** This bug has been marked as a duplicate of bug 92190 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92190

--- Comment #103 from Aron Budea  ---
*** Bug 114294 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114221] Calc has changed the file password

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114221

--- Comment #7 from francis-maryl...@wanadoo.fr ---
Please find 2 files attached :
 - The first one (CA2016 OK.xls) with password (6061)which is correct
 - The second one (CA2017 with bug.xls)wich is corrupted (Same initial password
6061)
Both files are similar, one for year 2016 and one for year 2017

With the first one and after having done a copy (as recommended by you), I can
reproduce the bug. Steps : I open the file with CALC, type the password, may do
any change in the file, save the file. Then when I try to open it again with
either CALC or EXCEL, I get the error "Password is incorrect. Impossible to
open the file"

I have no correct copy of the second one. It is impossible to open it with
either software. I get the same error message.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114271] Assertion failure when clicking on comment border in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114271

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: lotuswordpro/source

[Caolán McNamara]

 lotuswordpro/source/filter/lwplayout.cxx |   15 ---
 lotuswordpro/source/filter/lwplayout.hxx |1 +
 2 files changed, 13 insertions(+), 3 deletions(-)

New commits:
commit d38674f3b5b6c97be5f8822f52301e29d677ed1e
Author: Caolán McNamara 
Date:   Wed Dec 6 20:37:54 2017 +

ofz#4548 infinite regress in GetUsePrinterSettings

Change-Id: Iebd51c8724eebb942af45f3be24718a7a1278183
Reviewed-on: https://gerrit.libreoffice.org/45991
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/lotuswordpro/source/filter/lwplayout.cxx 
b/lotuswordpro/source/filter/lwplayout.cxx
index cdaa7ab7dfa3..acd913cd8489 100644
--- a/lotuswordpro/source/filter/lwplayout.cxx
+++ b/lotuswordpro/source/filter/lwplayout.cxx
@@ -81,6 +81,7 @@ LwpVirtualLayout::LwpVirtualLayout(LwpObjectHeader const 
, LwpSvStream* p
 , m_bGettingIsProtected(false)
 , m_bGettingMarginsValue(false)
 , m_bGettingExtMarginsValue(false)
+, m_bGettingUsePrinterSettings(false)
 , m_nAttributes(0)
 , m_nAttributes2(0)
 , m_nAttributes3(0)
@@ -1405,19 +1406,27 @@ XFBGImage* LwpMiddleLayout::GetXFBGImage()
 */
 bool LwpMiddleLayout::GetUsePrinterSettings()
 {
+if (m_bGettingUsePrinterSettings)
+throw std::runtime_error("recursion in layout");
+m_bGettingUsePrinterSettings = true;
+
+bool bRet = false;
+
 if(m_nOverrideFlag & OVER_SIZE)
 {
-return (m_nAttributes3 & STYLE3_USEPRINTERSETTINGS) != 0;
+bRet = (m_nAttributes3 & STYLE3_USEPRINTERSETTINGS) != 0;
 }
 else
 {
 rtl::Reference xBase(GetBasedOnStyle());
 if (LwpMiddleLayout* pLay = 
dynamic_cast(xBase.get()))
 {
-return pLay->GetUsePrinterSettings();
+bRet = pLay->GetUsePrinterSettings();
 }
 }
-return false;
+
+m_bGettingMarginsValue = false;
+return bRet;
 }
 
 //Check whether there are contents in the layout
diff --git a/lotuswordpro/source/filter/lwplayout.hxx 
b/lotuswordpro/source/filter/lwplayout.hxx
index efff5f62fd07..cd84af5b380b 100644
--- a/lotuswordpro/source/filter/lwplayout.hxx
+++ b/lotuswordpro/source/filter/lwplayout.hxx
@@ -226,6 +226,7 @@ protected:
 bool m_bGettingIsProtected;
 bool m_bGettingMarginsValue;
 bool m_bGettingExtMarginsValue;
+bool m_bGettingUsePrinterSettings;
 sal_uInt32 m_nAttributes;
 sal_uInt32 m_nAttributes2;
 sal_uInt32 m_nAttributes3;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114221] Calc has changed the file password

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114221

--- Comment #6 from francis-maryl...@wanadoo.fr ---
Created attachment 138255
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138255=edit
File with bug - Password not found

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114221] Calc has changed the file password

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114221

--- Comment #5 from francis-maryl...@wanadoo.fr ---
Created attachment 138254
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138254=edit
Similar file - No issue

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96302] Wrong field variables and selections shown in Fields dialog after creating a new document with the dialog still open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96302

--- Comment #14 from Jan Skarvall  ---
I just tried to follow the steps to reproduce, and the problem is still there.

I am using LibreOffice Writer 5.1.6.2 on Ubuntu 16.04 LTS. LO 6.0+ is not
available on this Ubuntu version.

I do not know if there is something that I am not understanding.

It seems that my description of the behaviour in step 6 does not match the
behaviour I see now. It seems not to be possible to have one Fields dialog open
per document. If I try to open a new one having the second document, the dialog
is closed instead. If I then select the second document and open the Fields
dialog, there is no v1 variable, and if I then select the first document, v1 is
shown and selected, selecting the second document and v1 is missing as it
should.

But if I follow the procedure, i.e. not try to open a second Fields dialog, v1
is shown and selected irrespective of which document is selected. Going on with
step 7-9 also results in the behavior I reported.

I also noted that the creation of the second document sometimes is very slow.

Also, when I move the Fields dialog, and then change selection of the two
documents back and forth, the Fields dialog may change position, but not in a
logical way, which could be that the position is specific for each open
document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114290] Editing Application crashes when clicking Drawing toolbar after fontwork added

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114290

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #2 from Xisco Faulí  ---
I can't reproduce it in

Version: 6.1.0.0.alpha0+
Build ID: 495ac1bc97f3deea8e13cb1a2b9f59d087873c3f
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: en-US (ca_ES.UTF-8@valencia); Calc: group threaded

nor in

Version: 6.0.0.0.alpha1+
Build ID: f94d98db1be8c27e470b39d4b16ed406db3aef87
CPU threads: 1; OS: Windows 6.1; UI render: default; 
Locale: es-ES (es_ES); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35771] Printing issues on Mac OS X (Intel)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=35771

Xisco Faulí  changed:

   What|Removed |Added

 CC||jimglar...@icloud.com

--- Comment #43 from Xisco Faulí  ---
*** Bug 114294 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114294] XLS file portrait format prints as landscape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114294

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Xisco Faulí  ---


*** This bug has been marked as a duplicate of bug 35771 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114292] I am running Libreoffice, Version: 5.4.3.2, and with sheet protection engaged, spreadsheet alway crashes on filesave or exit. Help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114292

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
I can't reproduce it in

Version: 5.4.3.2
Build ID: 1:5.4.3~rc2-0ubuntu0.17.04.1~lo1
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES-valencia (ca_ES.UTF-8@valencia); Calc: group

Unfortunately without clear steps to reproduce it, we cannot track down the
origin of the problem.
Please provide a clearer set of step-by-step instructions on how to reproduce
the problem.
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the steps are provided

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sal/osl

[Mike Kaganski]

 sal/osl/w32/security.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 5bb95b3d1aef2223fe8c608bf462f22fb7196c6c
Author: Mike Kaganski 
Date:   Wed Dec 6 15:36:19 2017 +0200

Function LookupAccountSidW takes number of characters, not bytes

Change-Id: Ie01feea2c5025f64a7888b85cb5de0c8f6c6f5c2
Reviewed-on: https://gerrit.libreoffice.org/45955
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/sal/osl/w32/security.cxx b/sal/osl/w32/security.cxx
index 120b5c98258d..77bce5d9bbbc 100644
--- a/sal/osl/w32/security.cxx
+++ b/sal/osl/w32/security.cxx
@@ -786,8 +786,8 @@ static bool SAL_CALL getUserNameImpl(oslSecurity Security, 
rtl_uString **strName
 sal_Unicode  UserName[128];
 sal_Unicode  DomainName[128];
 sal_Unicode  Name[257];
-DWORD nUserName   = sizeof(UserName);
-DWORD nDomainName = sizeof(DomainName);
+DWORD nUserName   = SAL_N_ELEMENTS(UserName);
+DWORD nDomainName = SAL_N_ELEMENTS(DomainName);
 SID_NAME_USE sUse;
 
 if (LookupAccountSidW(nullptr, 
reinterpret_cast(pInfoBuffer)->User.Sid,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 109312] [META] Paths options bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109312
Bug 109312 depends on bug 53901, which changed state.

Bug 53901 Summary: Create Extension which Enables Per Component Default Paths
https://bugs.documentfoundation.org/show_bug.cgi?id=53901

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 53901] Create Extension which Enables Per Component Default Paths

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=53901

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|NEW |RESOLVED
 CC|libreoffice-ux-advise@lists |
   |.freedesktop.org|
 Resolution|--- |WONTFIX

--- Comment #14 from Heiko Tietze  ---
We talked about this topic in the design meeting and agreed on WONTFIX. It's a
very special workflow and better realized with an extension (which makes this
request not a ticket on the LibO BZ).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 53901] Create Extension which Enables Per Component Default Paths

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=53901

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|NEW |RESOLVED
 CC|libreoffice-ux-advise@lists |
   |.freedesktop.org|
 Resolution|--- |WONTFIX

--- Comment #14 from Heiko Tietze  ---
We talked about this topic in the design meeting and agreed on WONTFIX. It's a
very special workflow and better realized with an extension (which makes this
request not a ticket on the LibO BZ).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114292] I am running Libreoffice, Version: 5.4.3.2, and with sheet protection engaged, spreadsheet alway crashes on filesave or exit. Help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114292

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I don't reproduce this.

Here the steps I tried:
1) Launch LO with a brand new file
2) Tools/Protect Sheet
=> a dialog appears
3) Just click button OK
4) File/save
5) a dialog box appears to ask filename
6) Let by default name and click ok
=> no crash

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103304] [META] Page dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103304
Bug 103304 depends on bug 69993, which changed state.

Bug 69993 Summary: PRINTING: Option "view zero values" does not affect the page 
style option "print zero values"
https://bugs.documentfoundation.org/show_bug.cgi?id=69993

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 69993] PRINTING: Option "view zero values" does not affect the page style option "print zero values"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=69993

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|NEW |RESOLVED
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
 Resolution|--- |WORKSFORME

--- Comment #14 from Heiko Tietze  ---
We discussed the topic in the design meeting. The visualization option in tools
> options is independent from the printing option under page > sheet, which
could be improved by taking what is configured globally for newly created
documents. But we expect to run into other trouble with this approach and
concluded to accept the current behavior.

Btw, meanwhile cell styles and conditional formatting has improved
significantly. Hiding zeros by white font color could be a good workaround.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 103309] [META] Print dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103309
Bug 103309 depends on bug 69993, which changed state.

Bug 69993 Summary: PRINTING: Option "view zero values" does not affect the page 
style option "print zero values"
https://bugs.documentfoundation.org/show_bug.cgi?id=69993

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 69993] PRINTING: Option "view zero values" does not affect the page style option "print zero values"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=69993

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|NEW |RESOLVED
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
 Resolution|--- |WORKSFORME

--- Comment #14 from Heiko Tietze  ---
We discussed the topic in the design meeting. The visualization option in tools
> options is independent from the printing option under page > sheet, which
could be improved by taking what is configured globally for newly created
documents. But we expect to run into other trouble with this approach and
concluded to accept the current behavior.

Btw, meanwhile cell styles and conditional formatting has improved
significantly. Hiding zeros by white font color could be a good workaround.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114294] New: XLS file portrait format prints as landscape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114294

Bug ID: 114294
   Summary: XLS file portrait format prints as landscape
   Product: LibreOffice
   Version: 5.3.7.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jimglar...@icloud.com

Created attachment 138253
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138253=edit
XLS spreadsheet prints as landscape format

Calc spreadsheet with portrait format saved as XLS file. File prints as
landscape format. LibreOffice version 5.2.7.2 prints portrait format correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113866] The option to print text in black, secretly also affects PDF export

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113866

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|

--- Comment #12 from Heiko Tietze  ---
tl;dr: Please clean-up the PDF export from printing options.

We discussed this question in the design meeting. The user expectation is to
export a document like it is shown (WYSIWYG), so the recommendation is to
neither adopt the print options not to duplicate those. That means a red font
is always exported in this color, even when print text in black is checked. If
the user wants black text in the exported pdf, the supposed way is to use a
tool/driver that supports print to pdf (available out of the box under
Windows).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs