date:20171222

[Libreoffice-commits] core.git: external/libepubgen

2017-12-22 Thread Miklos Vajna

 external/libepubgen/UnpackedTarball_libepubgen.mk |2 
 external/libepubgen/libepubgen-epub3.patch.1  |  169 ++
 2 files changed, 171 insertions(+)

New commits:
commit fe652ec259f7ca9e79810553ce6c884688963102
Author: Miklos Vajna 
Date:   Fri Dec 22 17:49:09 2017 +0100

EPUB export: fix invalid XHTML output for text boxes

 not allowed inside . Also fix two more similar validation
problems.

Change-Id: I7c326743b5e89a5a32609bdf312cb8caa203692e
Reviewed-on: https://gerrit.libreoffice.org/46983
Tested-by: Jenkins 
Reviewed-by: Miklos Vajna 

diff --git a/external/libepubgen/UnpackedTarball_libepubgen.mk 
b/external/libepubgen/UnpackedTarball_libepubgen.mk
index 14efadb337c0..47b21d7ee5d0 100644
--- a/external/libepubgen/UnpackedTarball_libepubgen.mk
+++ b/external/libepubgen/UnpackedTarball_libepubgen.mk
@@ -8,6 +8,8 @@
 #
 
 epubgen_patches :=
+# Backport of 
.
+epubgen_patches += libepubgen-epub3.patch.1
 
 ifeq ($(COM_IS_CLANG),TRUE)
 ifneq ($(filter -fsanitize=%,$(CC)),)
diff --git a/external/libepubgen/libepubgen-epub3.patch.1 
b/external/libepubgen/libepubgen-epub3.patch.1
new file mode 100644
index ..7ea3a365737f
--- /dev/null
+++ b/external/libepubgen/libepubgen-epub3.patch.1
@@ -0,0 +1,169 @@
+From 006848cb62225647c418d5143d4e88a9d73829da Mon Sep 17 00:00:00 2001
+From: Miklos Vajna 
+Date: Fri, 22 Dec 2017 16:33:52 +0100
+Subject: [PATCH] EPUBHTMLGenerator: avoid  inside  and/or 
+
+This is not allowed in XHTML, but we wrote that markup when a text frame
+was inside a span or a paragraph. The closest allowed markup in XHTML
+seems to be closing the span/paragraph before opening the text box and
+doing the opposite after the text box is closed.
+---
+ src/lib/EPUBHTMLGenerator.cpp  | 33 +
+ src/test/EPUBTextGeneratorTest.cpp |  4 +++-
+ 2 files changed, 36 insertions(+), 1 deletion(-)
+
+diff --git a/src/lib/EPUBHTMLGenerator.cpp b/src/lib/EPUBHTMLGenerator.cpp
+index 342213e..bc9c1b7 100644
+--- a/src/lib/EPUBHTMLGenerator.cpp
 b/src/lib/EPUBHTMLGenerator.cpp
+@@ -395,6 +395,8 @@ struct EPUBHTMLGeneratorImpl
+ , m_frameAnchorTypes()
+ , m_framePropertiesStack()
+ , m_linkPropertiesStack()
++, m_paragraphAttributesStack()
++, m_spanAttributesStack()
+ , m_stylesMethod(stylesMethod)
+ , m_layoutMethod(layoutMethod)
+ , m_actualSink()
+@@ -495,6 +497,8 @@ struct EPUBHTMLGeneratorImpl
+   std::stack m_framePropertiesStack;
+   /// This is used for links which don't have a href.
+   std::stack m_linkPropertiesStack;
++  std::stack m_paragraphAttributesStack;
++  std::stack m_spanAttributesStack;
+ 
+   EPUBStylesMethod m_stylesMethod;
+   EPUBLayoutMethod m_layoutMethod;
+@@ -683,6 +687,12 @@ void EPUBHTMLGenerator::openParagraph(const 
RVNGPropertyList )
+   }
+   m_impl->output(false).openElement("p", attrs);
+   m_impl->m_hasText = false;
++
++  librevenge::RVNGPropertyList::Iter i(attrs);
++  RVNGPropertyList paragraphAttributes;
++  for (i.rewind(); i.next();)
++paragraphAttributes.insert(i.key(), i()->clone());
++  m_impl->m_paragraphAttributesStack.push(paragraphAttributes);
+ }
+ 
+ void EPUBHTMLGenerator::closeParagraph()
+@@ -690,6 +700,9 @@ void EPUBHTMLGenerator::closeParagraph()
+   if (m_impl->m_ignore)
+ return;
+ 
++  if (!m_impl->m_paragraphAttributesStack.empty())
++m_impl->m_paragraphAttributesStack.pop();
++
+   if (!m_impl->m_hasText)
+ insertSpace();
+ 
+@@ -717,12 +730,22 @@ void EPUBHTMLGenerator::openSpan(const RVNGPropertyList 
)
+ break;
+   }
+   m_impl->output(false).openElement("span", attrs);
++
++  librevenge::RVNGPropertyList::Iter i(attrs);
++  RVNGPropertyList spanAttributes;
++  for (i.rewind(); i.next();)
++spanAttributes.insert(i.key(), i()->clone());
++  m_impl->m_spanAttributesStack.push(spanAttributes);
+ }
+ 
+ void EPUBHTMLGenerator::closeSpan()
+ {
+   if (m_impl->m_ignore)
+ return;
++
++  if (!m_impl->m_spanAttributesStack.empty())
++m_impl->m_spanAttributesStack.pop();
++
+   m_impl->output().closeElement("span");
+ }
+ 
+@@ -931,6 +954,11 @@ void EPUBHTMLGenerator::openTextBox(const 
RVNGPropertyList & /*propList*/)
+   if (m_impl->m_ignore)
+ return;
+ 
++  if (!m_impl->m_spanAttributesStack.empty())
++m_impl->output().closeElement("span");
++  if (!m_impl->m_paragraphAttributesStack.empty())
++m_impl->output().closeElement("p");
++
+   RVNGPropertyList attrs;
+ 
+   if (!m_impl->m_framePropertiesStack.empty())
+@@ -968,6 +996,11 @@ void EPUBHTMLGenerator::closeTextBox()
+   m_impl->output().insertEmptyElement("br", attrs);
+ }
+   }
++
++  if (!m_impl->m_paragraphAttributesStack.empty())
++m_impl->output(false).openElement("p", 
m_impl->m_paragraphAttributesStack.top());

[Libreoffice-bugs] [Bug 89566] SIDEBAR: Improving the navigator tab in Writer

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=89566

--- Comment #41 from Jim Raykowski  ---
Created attachment 138606
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138606=edit
navigator screenshot

Hi All,

Attached is a screenshot of what I have done for this. The first line follows
Jays second mockup minus the image labels. The second line is a rearrangement
of items presently available. The 'Navigate By' drop down and previous and next
arrows are the same uno controls used in the Findbar. The 'Go To page' edit
spin control is a new uno control created for use here. I committed it for
review a while back to granulate. 

If there is interest in what is here I will commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114639] File/Send crash at hovering

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114639

--- Comment #4 from Jan-Peter Rühmann  ---
Sorry the Initial Post was wrong, But I can´t edit my Entys here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114639] File/Send crash at hovering

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114639

--- Comment #3 from Jan-Peter Rühmann  ---
Open the File Menue
Place the Mouse over the Send Entry

All Windows of LibreOffice disapear including the Icon in the Systray.
I am using Kubuntu 16.04 LTS (32Bit) & Java 9

Thanks,

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114638] Wikimedia Settings crash

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114638

--- Comment #2 from Jan-Peter Rühmann  ---
As I´ve clearly written.

Open the Optionen Window Via the Extras Menue and Click on choose Internet and
click on Wikimedia.
Then all open LibreOffice Windows and the Icon in the Systray are vanishing.
There are no error messages.
I am using Kubuntu 16.04 LTS (32Bit) & Java 9

Thanks,

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basegfx/source compilerplugins/clang configmgr/source cppuhelper/source cppu/source include/basegfx include/sax include/tools include/xmlscript sax/source unotools/sour

2017-12-22 Thread Noel Grandin

 basegfx/source/polygon/b2dpolygontools.cxx|6 
 basegfx/source/polygon/b3dpolypolygontools.cxx|4 
 compilerplugins/clang/passstuffbyref.cxx  |  142 ++
 compilerplugins/clang/test/passstuffbyref.cxx |   51 +++
 configmgr/source/childaccess.cxx  |2 
 configmgr/source/childaccess.hxx  |2 
 configmgr/source/type.cxx |2 
 configmgr/source/type.hxx |2 
 cppu/source/threadpool/threadpool.cxx |2 
 cppu/source/threadpool/threadpool.hxx |2 
 cppuhelper/source/propertysetmixin.cxx|4 
 include/basegfx/polygon/b2dpolygontools.hxx   |6 
 include/basegfx/polygon/b3dpolypolygontools.hxx   |4 
 include/sax/fshelper.hxx  |2 
 include/tools/stream.hxx  |2 
 include/xmlscript/xml_helper.hxx  |2 
 sax/source/tools/fastserializer.cxx   |2 
 sax/source/tools/fastserializer.hxx   |2 
 sax/source/tools/fshelper.cxx |2 
 unotools/source/accessibility/accessiblerelationsethelper.cxx |4 
 unotools/source/config/eventcfg.cxx   |4 
 unotools/source/config/moduleoptions.cxx  |   12 
 unotools/source/ucbhelper/ucblockbytes.hxx|2 
 xmlscript/source/xml_helper/xml_element.cxx   |2 
 24 files changed, 176 insertions(+), 89 deletions(-)

New commits:
commit 2a1fb4401da16f6a18c0bd05fe4b460a3048f9b5
Author: Noel Grandin 
Date:   Fri Dec 22 14:23:16 2017 +0200

loplugin:passstuffbyref improved returns

improve the detection of stuff we can return by const &, instead of by
copying

Change-Id: I479ae89d0413125a8295cc3cddbc0017ed61ed69
Reviewed-on: https://gerrit.libreoffice.org/46915
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/basegfx/source/polygon/b2dpolygontools.cxx 
b/basegfx/source/polygon/b2dpolygontools.cxx
index 489b77af92aa..e0a4721505ba 100644
--- a/basegfx/source/polygon/b2dpolygontools.cxx
+++ b/basegfx/source/polygon/b2dpolygontools.cxx
@@ -1645,7 +1645,7 @@ namespace basegfx
 };
 }
 
-B2DPolygon createUnitPolygon()
+B2DPolygon const & createUnitPolygon()
 {
 return theUnitPolygon::get();
 }
@@ -1719,7 +1719,7 @@ namespace basegfx
 };
 }
 
-B2DPolygon createHalfUnitCircle()
+B2DPolygon const & createHalfUnitCircle()
 {
 return theUnitHalfCircle::get();
 }
@@ -1751,7 +1751,7 @@ namespace basegfx
 };
 }
 
-B2DPolygon createPolygonFromUnitCircle(sal_uInt32 nStartQuadrant)
+B2DPolygon const & createPolygonFromUnitCircle(sal_uInt32 
nStartQuadrant)
 {
 switch(nStartQuadrant % 4)
 {
diff --git a/basegfx/source/polygon/b3dpolypolygontools.cxx 
b/basegfx/source/polygon/b3dpolypolygontools.cxx
index d3ae28120e29..9c79bc14bc1f 100644
--- a/basegfx/source/polygon/b3dpolypolygontools.cxx
+++ b/basegfx/source/polygon/b3dpolypolygontools.cxx
@@ -100,7 +100,7 @@ namespace basegfx
 };
 }
 
-B3DPolyPolygon createUnitCubePolyPolygon()
+B3DPolyPolygon const & createUnitCubePolyPolygon()
 {
 return theUnitCubePolyPolygon::get();
 }
@@ -182,7 +182,7 @@ namespace basegfx
 };
 }
 
-B3DPolyPolygon createUnitCubeFillPolyPolygon()
+B3DPolyPolygon const & createUnitCubeFillPolyPolygon()
 {
 return theUnitCubeFillPolyPolygon::get();
 }
diff --git a/compilerplugins/clang/passstuffbyref.cxx 
b/compilerplugins/clang/passstuffbyref.cxx
index 8c522efb5dbe..5901a587594e 100644
--- a/compilerplugins/clang/passstuffbyref.cxx
+++ b/compilerplugins/clang/passstuffbyref.cxx
@@ -9,6 +9,7 @@
 
 #include 
 #include 
+#include 
 
 #include "check.hxx"
 #include "plugin.hxx"
@@ -211,7 +212,6 @@ static bool startswith(const std::string& rStr, const char* 
pSubStr) {
 }
 
 void PassStuffByRef::checkReturnValue(const FunctionDecl * functionDecl, const 
CXXMethodDecl * methodDecl) {
-
 if (methodDecl && (methodDecl->isVirtual() || 
methodDecl->hasAttr())) {
 return;
 }
@@ -233,6 +233,7 @@ void PassStuffByRef::checkReturnValue(const FunctionDecl * 
functionDecl, const C
 if (isInUnoIncludeFile(functionDecl)) {
 return;
 }
+
 loplugin::DeclCheck dc(functionDecl);
 // function is passed as parameter to another function
 if

[Libreoffice-commits] core.git: sc/inc sc/sdi sc/source

2017-12-22 Thread Noel Grandin

 sc/inc/sc.hrc|   23 ++
 sc/sdi/cellsh.sdi|9 +
 sc/sdi/docsh.sdi |4 
 sc/sdi/scalc.sdi |  349 +++
 sc/sdi/tabvwsh.sdi   |8 
 sc/source/ui/docshell/docsh4.cxx |   49 +
 sc/source/ui/view/cellsh.cxx |   52 +
 sc/source/ui/view/cellsh1.cxx|   12 +
 sc/source/ui/view/cellsh3.cxx|   18 ++
 sc/source/ui/view/tabvwsh3.cxx   |7 
 sc/source/ui/view/tabvwshh.cxx   |  161 +
 11 files changed, 690 insertions(+), 2 deletions(-)

New commits:
commit f90139cc60116c28140f1bfb1d88076d1591
Author: Noel Grandin 
Date:   Fri Dec 22 13:19:27 2017 +0200

Revert "unused SID commands in sc"

This reverts commit 9c4350441191ccfd6af3d73e13b4eb59af7ed6d1.

Eike Rathke:

Odd, I don't even remember what these slots were used for..
Ugh.. now I think I know.. (very) old recorded Basic macros used 
slot:number with the dispatcher instead of the .uno:... commands, so 
removing/renumbering slots may actually break those.

I'm not sure if we already deprecated the slot number thing in an earlier 
release or maybe it was already done back in OOo times, I simply don't 
remember. Must be at least 1.5 decades since slot numbers were replaced with 
.uno commands, but old recorded macros are still supported.

However, our qaDevOOo tests and some other tests (in Java) still use 
slot: notation, git grep 'slot:[0-9]'

I think best is to revert this change and abandon the other SID removals.

Change-Id: I091cf71dd38772dac7491afd6f28951b54510eaf
Reviewed-on: https://gerrit.libreoffice.org/46963
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/sc.hrc b/sc/inc/sc.hrc
index 91f29cbaadd4..ee3caa1d7e7c 100644
--- a/sc/inc/sc.hrc
+++ b/sc/inc/sc.hrc
@@ -194,6 +194,8 @@
 #define SID_CHART_NAME  (SC_MESSAGE_START + 26)
 #define SID_CHART_ADDSOURCE (SC_MESSAGE_START + 27)
 
+#define SID_AUTO_STYLE  (SC_MESSAGE_START + 28)
+
 #define FID_INPUTLINE_BLOCK (SC_MESSAGE_START + 29)
 
 #define SID_STATUS_SUM  (SC_MESSAGE_START + 30)
@@ -436,6 +438,7 @@
 #define DETECTIVE_END   (DETECTIVE_START+20)
 
 #define SID_API_SLOTS   (DETECTIVE_END)
+#define SID_INSERT_MATRIX   (SID_API_SLOTS+1)
 
 #define SID_DELETE_NOTE (SID_API_SLOTS+2)
 
@@ -491,6 +494,8 @@
 #define SID_SETINPUTMODE(SID_KEYFUNC_START + 31)
 #define SID_DELETE_CONTENTS (SID_KEYFUNC_START + 32)
 
+#define SID_MARKAREA(SID_KEYFUNC_START + 33)
+
 #define FID_FILL_AUTO   (SID_KEYFUNC_START + 35)
 #define SID_CANCEL  (SID_KEYFUNC_START + 36)
 
@@ -513,12 +518,20 @@
 
 #define SID_RANGE_ROW   (SID_NEW_SLOTS+20)
 #define SID_RANGE_COL   (SID_NEW_SLOTS+21)
+#define SID_RANGE_TABLE (SID_NEW_SLOTS+22)
+#define SID_RANGE_VALUE (SID_NEW_SLOTS+23)
+#define SID_RANGE_FORMULA   (SID_NEW_SLOTS+24)
+#define SID_RANGE_TEXTVALUE (SID_NEW_SLOTS+26)
+#define SID_TABLE_ACTIVATE  (SID_NEW_SLOTS+27)
 
 #define SID_DEFINE_PRINTAREA(SID_NEW_SLOTS+31)
 #define SID_DELETE_PRINTAREA(SID_NEW_SLOTS+32)
 #define SID_CHANGE_PRINTAREA(SID_NEW_SLOTS+33)
 #define SID_OPENDLG_EDIT_PRINTAREA  (SID_NEW_SLOTS+34)
 
+#define SID_OLE_ACTIVATE(SID_NEW_SLOTS+36)
+#define SID_OLE_DEACTIVATE  (SID_NEW_SLOTS+37)
+
 #define SID_TOGGLE_REL  (SID_NEW_SLOTS+38)
 #define SID_DATA_SELECT (SID_NEW_SLOTS+39)
 
@@ -530,8 +543,13 @@
 #define FID_REPLACE_ALL (SID_NEW_SLOTS+44)
 #define FID_SEARCH_COUNT(SID_NEW_SLOTS+45)
 
+#define SID_SC_SETTEXT  (SID_NEW_SLOTS+46)
+#define SID_RANGE_ADDRESS   (SID_NEW_SLOTS+47)
 #define SID_NUMBER_FORMAT   (SID_NEW_SLOTS+49)
 
+#define SID_OLE_SELECT  (SID_NEW_SLOTS+50)
+
+#define SID_RANGE_NOTETEXT  (SID_NEW_SLOTS+52)
 #define FID_INSERT_FILE (SID_NEW_SLOTS+53)
 
 #define FID_VALIDATION  (SID_NEW_SLOTS+54)
@@ -574,6 +592,11 @@
 #define FID_RESET_PRINTZOOM (SID_NEW_SLOTS+82)
 
 #define SID_TABLES_COUNT(SID_NEW_SLOTS+83)
+#define SID_ACTIVE_OBJ_NAME (SID_NEW_SLOTS+84)
+#define SID_OBJECT_LEFT (SID_NEW_SLOTS+85)
+#define SID_OBJECT_TOP  (SID_NEW_SLOTS+86)
+#define SID_OBJECT_WIDTH(SID_NEW_SLOTS+87)
+#define SID_OBJECT_HEIGHT   (SID_NEW_SLOTS+88)
 
 #define SID_DELETE_SCENARIO (SID_NEW_SLOTS+95)
 #define SID_EDIT_SCENARIO   (SID_NEW_SLOTS+96)
diff --git a/sc/sdi/cellsh.sdi b/sc/sdi/cellsh.sdi
index ece262c3e276..decb76cfc659 100644
--- a/sc/sdi/cellsh.sdi
+++ b/sc/sdi/cellsh.sdi
@@ -65,14 +65,23 @@ interface CellSelection
 // } database operations
 
 
+SID_RANGE_ADDRESS   [ StateMethod = GetState; ]
+
 SID_HYPERLINK_SETLINK   [ ExecMethod = ExecuteEdit; ]

[Libreoffice-bugs] [Bug 114082] Notebookbar: Hamburger icon button isnt well aligned

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114082

--- Comment #2 from Volga  ---
Still reproduce with

Version: 6.0.0.1 (x64) 
Build ID：d2bec56d7865f05a1003dc88449f2b0fdd85309a 
CPU 线程：4; 操作系统：Windows 10.0; UI 渲染：默认; 
区域语言：zh-CN (zh_CN); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104027] FILEOPEN: DOC: incorrect page break added to page 2

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104027

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4629

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103967] DOC import: Empty table cell has wrong font size

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103967

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4629

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106705] FILEOPEN: DOC: Bullets incorrectly highlighted

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106705

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4629

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87764] FILEOPEN: DOC - Section columns incorrectly imported around page columns

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87764

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4629

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114629] FILEOPEN: wrong DOC file rendering

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114629

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=87
   ||764,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3967,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4027,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6705

--- Comment #7 from Aron Budea  ---
The regression was introduced in two steps. First the table was moved to the
next page, as if it was preceded by a page break. This happened in the
following commit:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c5ed52b1cd6f22787c94bec035ceecf9e1da3271
author  Luboš Luňák  2014-07-21 10:56:52
+0200
committer   Luboš Luňák  2014-07-21 11:02:04
+0200

"ww8import create a pagedesc if continuous section changes margins
(bnc#875383)"


Next the text in the first paragraph turned into strange symbols. This happened
in the following commit:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=705a8c226aee3e68db492083b7cf8b704335328b
author  Caolán McNamara 2014-09-23 20:35:50
+0100
committer   Caolán McNamara 2014-09-24 10:04:48
+0100

"WW8PLCFMan::AdjustEnds deeply flawed concept wrt change tracking"

Adding other regressions that trace back to these commits in 'see also' field.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: minutes of ESC call ...

2017-12-22 Thread Tomaž Vajngerl

Hi,

On Fri, Dec 22, 2017 at 12:52 AM, Michael Meeks
 wrote:
>
> * Blurry icons (Heiko)
> + a PNG issue for hidpi screens.
> + why not use SVG icons instead ?
> + quikee wrote some code to render SVG icons (Kendy)
>+ need to look into what the state is

There are 2 issues currently:
- SVG import doesn't correctly interpret what should happen when
"height" and "width" aren't set but just "viewBox", so many SVG icons
aren't rendered correctly. I have a fix for that, but need to write a
test too.

- When using GTK3 we use the cairo HiDPI scaling instead of handling
that ourselves. The issue is that rendering bitmaps need to support
that too, which we don't. For example if we have an icon 24x24 px
which is rendered to 48x48 actual px from SVG (2x HiDPI scaling) must
still pretend to be 24x24 px and drawn to a 24x24 px area on a cairo
surface (cairo surface uses non-scaled size and just internally scales
them to 2x the size) . So our "Image" class must know something about
scaling to draw the icons correctly in this case. I have made a crude
POC and it worked, but not yet ready for production.

>+ adds some startup-time potentially.
>+ need to measure startup impact.

SVG icons are on demand rendered and then cached to PNG in profile
"cache" folder. So the rendering impact would only be for the first
time an icon is used, after that the impact is the same as using a PNG
icon - until the cache is cleared  (which is currently never - users
must do it themselves).

> + SVG renderer we have is not the fastest in the world (Thorsten)
>+ with some caching – in a good shape.
> + thought it was solved ? Just switching.
> => ask quikee what he recommends.

When those 2 bugs are solved, all we need to do is package the SVG
icons. At least breeze_svg icons work as they are very simple. Others
(elementary for example) could render wrongly, I didn't try it yet.
OTOH some Tango SVG icons did crash the renderer so currently we
always prefer PNG icon over SVG if both are present (like in Tango)
and the icon theme must be a pure SVG themes (with no PNG present in
the zip file) if SVG would be used.

Regards, Tomaž
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 109190] Auto Optimal View gives jarring experience

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=109190

David  changed:

   What|Removed |Added

 Status|NEEDINFO|REOPENED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109190] Auto Optimal View gives jarring experience

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=109190

--- Comment #4 from David  ---
Created attachment 138605
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138605=edit
an exmaple document in which jumping behaviour is observed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109190] Auto Optimal View gives jarring experience

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=109190

--- Comment #3 from David  ---
After getting flamed in a forum I didn't bother adding more info but this bug
still drives me crazy. I only use Draw but I use it daily. The same "optimal
view" bug has been present through all of the official releases since I
originally reported it. Since that time I have moved to a new laptop and
through several versions of xubuntu linux. I've started with clean profiles.
The same issue is still present. It is also present in the new version 6.0.0.1
version I tried today.

In the video I have attached I have a document. There are columns of numbers. I
want to play around with the font size in the leftmost column while visually
comparing it to the next one on the right. I have zoomed in at 280%. I click in
the column and CTRL+A to select all of the numbers. Then I just click on a
number again to deselect them. Then the view jumps to a completely illogical
place. It does it several times. 

This happens in almost every document at some point. It is very random. All I
want to do is have a way to turn off / disable the optimal view. I DON'T WANT
THE VIEW TO ASSUME IT KNOWS WHAT THE BEST VIEW IS FOR ME.

I've had enough of this weird behaviour so I decided to repost. Surely I am not
the only linux user experiencing this. PLEASE do not flame me or tell me this
is a feature. It is a BUG. PLEASE don't reply unless you have something
MEANINGFUL to contribute. After some of the rude behaviour I've experienced in
forums I fire right back.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109190] Auto Optimal View gives jarring experience

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=109190

--- Comment #2 from David  ---
Created attachment 138604
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138604=edit
video showing weird jumping view behaviour

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104834] When selecting the measurement text above the dimension line, text will be shown double

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104834

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

master build fails if --with-vendor option is set in autogen.input

2017-12-22 Thread Jean-Baptiste Faure


Hi,

I get the following error when building the master:


[build CXX] framework/source/fwe/classes/sfxhelperfunctions.cxx
/home/libo/master/svtools/source/misc/langhelp.cxx: In function ‘rtl::OUString 
getInstalledLocaleForSystemUILanguage(const 
com::sun::star::uno::Sequence&, bool)’:
/home/libo/master/svtools/source/misc/langhelp.cxx:128:47: error: unable to find string 
literal operator ‘operator""JBF_at_home’ with ‘const char [1]’, ‘long unsigned 
int’ arguments
 OUString sVendor(OOO_VENDOR);


I guess the problem is in the commit
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=1c7d3390022908cfbfd30f55e8c0c3b60a045da7
because no other recent commit changed  svtools/source/misc/langhelp.cxx

If I remove the option --with-vendor=JBF_at_home from my autogen.input 
file the compile error disappears.


Best regards.
JBF
--
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
Disclaimer: my Internet Provider being located in France, each of our
exchanges over Internet will be scanned by French spying services.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108226
Bug 108226 depends on bug 111790, which changed state.

Bug 111790 Summary: Shadow imported from a PPTX file is not overriden by the 
settings while saving back to PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=111790

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: oox/source sw/qa

2017-12-22 Thread martinb214

 oox/source/export/drawingml.cxx   |   83 +-
 sw/qa/extras/ooxmlexport/ooxmlexport7.cxx |6 +-
 2 files changed, 74 insertions(+), 15 deletions(-)

New commits:
commit 7f42b0f96a2798ae99aa65b84b0db3b2af2b282b
Author: martinb214 
Date:   Wed Dec 6 20:58:45 2017 +0100

tdf#111790: Shadow imported from a PPTX file is not overriden

by the settings while saving back to PPTX

Change-Id: I958f1987d0123bcf89ef37b13807f407781f3c15
Reviewed-on: https://gerrit.libreoffice.org/45989
Tested-by: Jenkins 
Reviewed-by: TamÃ¡s Zolnai 

diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 17fc99acbc7f..f0f9bee96125 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -3181,18 +3181,36 @@ void DrawingML::WriteShapeEffect( const OUString& 
sName, const Sequence< Propert
 }
 }
 
+sal_Int32 lcl_CalculateDist(const double dX, const double dY)
+{
+return static_cast< sal_Int32 >(sqrt(dX*dX + dY*dY) * 360);
+}
+
+sal_Int32 lcl_CalculateDir(const double dX, const double dY)
+{
+return (static_cast< sal_Int32 >(atan2(dY,dX) * 180 * 6 / M_PI) + 
2160) % 2160;
+}
+
 void DrawingML::WriteShapeEffects( const Reference< XPropertySet >& rXPropSet )
 {
 if( !GetProperty( rXPropSet, "InteropGrabBag" ) )
 return;
 
-Sequence< PropertyValue > aGrabBag, aEffects;
+Sequence< PropertyValue > aGrabBag, aEffects, aOuterShdwProps;
 mAny >>= aGrabBag;
 for( sal_Int32 i=0; i < aGrabBag.getLength(); ++i )
 {
 if( aGrabBag[i].Name == "EffectProperties" )
 {
 aGrabBag[i].Value >>= aEffects;
+for( sal_Int32 j=0; j < aEffects.getLength(); ++j )
+{
+if( aEffects[j].Name == "outerShdw" )
+{
+aEffects[j].Value >>= aOuterShdwProps;
+break;
+}
+}
 break;
 }
 }
@@ -3210,9 +3228,9 @@ void DrawingML::WriteShapeEffects( const Reference< 
XPropertySet >& rXPropSet )
 rXPropSet->getPropertyValue( "ShadowYDistance" ) >>= dY;
 
 aShadowAttribsGrabBag[0].Name = "dist";
-aShadowAttribsGrabBag[0].Value <<= static_cast< sal_Int32 
>(sqrt(dX*dX + dY*dY) * 360);
+aShadowAttribsGrabBag[0].Value <<= lcl_CalculateDist(dX, dY);
 aShadowAttribsGrabBag[1].Name = "dir";
-aShadowAttribsGrabBag[1].Value <<= (static_cast< sal_Int32 
>(atan2(dY,dX) * 180 * 6 / M_PI) + 2160) % 2160;
+aShadowAttribsGrabBag[1].Value <<= lcl_CalculateDir(dX, dY);;
 
 aShadowGrabBag[0].Name = "Attribs";
 aShadowGrabBag[0].Value <<= aShadowAttribsGrabBag;
@@ -3225,19 +3243,60 @@ void DrawingML::WriteShapeEffects( const Reference< 
XPropertySet >& rXPropSet )
 WriteShapeEffect( "outerShdw", aShadowGrabBag );
 mpFS->endElementNS(XML_a, XML_effectLst);
 }
-return;
 }
+else
+{
+for( sal_Int32 i=0; i < aOuterShdwProps.getLength(); ++i )
+{
+if( aOuterShdwProps[i].Name == "Attribs" )
+{
+Sequence< PropertyValue > aAttribsProps;
+aOuterShdwProps[i].Value >>= aAttribsProps;
 
-mpFS->startElementNS(XML_a, XML_effectLst, FSEND);
+double dX = +0.0, dY = +0.0;
+rXPropSet->getPropertyValue( "ShadowXDistance" ) >>= dX;
+rXPropSet->getPropertyValue( "ShadowYDistance" ) >>= dY;
 
-for( sal_Int32 i=0; i < aEffects.getLength(); ++i )
-{
-Sequence< PropertyValue > aEffectProps;
-aEffects[i].Value >>= aEffectProps;
-WriteShapeEffect( aEffects[i].Name, aEffectProps );
-}
+for( sal_Int32 j=0; j < aAttribsProps.getLength(); ++j )
+{
+if( aAttribsProps[j].Name == "dist" )
+{
+aAttribsProps[j].Value <<= lcl_CalculateDist(dX, dY);
+}
+else if( aAttribsProps[j].Name == "dir" )
+{
+aAttribsProps[j].Value <<= lcl_CalculateDir(dX, dY);
+}
+}
 
-mpFS->endElementNS(XML_a, XML_effectLst);
+aOuterShdwProps[i].Value <<= aAttribsProps;
+}
+else if( aOuterShdwProps[i].Name == "RgbClr" )
+{
+aOuterShdwProps[i].Value = rXPropSet->getPropertyValue( 
"ShadowColor" );
+}
+else if( aOuterShdwProps[i].Name == "RgbClrTransparency" )
+{
+aOuterShdwProps[i].Value = rXPropSet->getPropertyValue( 
"ShadowTransparence" );
+}
+}
+
+mpFS->startElementNS(XML_a, XML_effectLst, FSEND);
+for( sal_Int32 i=0; i < aEffects.getLength();

[Libreoffice-bugs] [Bug 114660] New: COUNTIFS FUNCTION documentation and correction not consistent

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114660

Bug ID: 114660
   Summary: COUNTIFS FUNCTION documentation and correction not
consistent
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: djone...@gmail.com
CC: olivier.hal...@documentfoundation.org

Description:
When I follow the suggested syntax, I get errors [including Err 507, which is
not even listed in the error messages.] Libre suggests corrections. These
suggested corrections DO NOT follow the suggested syntax, and they also produce
errors. There is a bad disconnect between the documented / suggested syntax and
whatever actual syntax Libre is looking for.

Actual Results:  
When I follow the suggested syntax, I get errors [including Err 507, which is
not even listed in the error messages.] Libre suggests corrections. These
suggested corrections DO NOT follow the suggested syntax, and they also produce
errors. There is a bad disconnect between the documented / suggested syntax and
whatever actual syntax Libre is looking for.

Expected Results:
noted above


Reproducible: Always


User Profile Reset: No



Additional Info:
1. Syntax as per the Help and syntax within Libre should be consistent. 2. When
Libre suggests an amendment to my attempt, that suggestion should be consistent
with the syntax as set out in help. A major discrepancy I note is that the Help
wants a ";" between parameters, whereas the suggested pollution that Libre
produces uses a "," between parameters.


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103134] Inconsistent character spacing across different fonts, suite versions and operating systems.

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103134

--- Comment #16 from mango wodzak  ---
I'm using v5.4.4 and experiencing similar problems cross platform with the
Trebuchet MS font. Spacing is different between Windows 10 and Windows 7 as
well as Ubuntu 17.10 which has the largest spacing..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: libreofficekit/Executable_tilebench.mk libreofficekit/Module_libreofficekit.mk libreofficekit/qa Repository.mk

2017-12-22 Thread Ashod Nakashian

 Repository.mk |2 
 libreofficekit/Executable_tilebench.mk|1 
 libreofficekit/Module_libreofficekit.mk   |5 +
 libreofficekit/qa/tilebench/tilebench.cxx |  102 --
 4 files changed, 74 insertions(+), 36 deletions(-)

New commits:
commit a692cdf779dc998f58ebf9e9f84f22edf7dbe421
Author: Ashod Nakashian 
Date:   Sun Nov 19 20:38:43 2017 -0500

LOK: tilebench improvements

* Arguments for max number of parts and tiles to render (optional).
  + Automatic estimation of maximum tiles to render based on max parts
for Writer docs, since there is only 1 part, this caps the number
of pages to render, similar to other doc types.
* Fixed rendering of Writer documents over and over (as many times as 
pages).
  + Writer has a single part, unlike other doc types.
  + No point in rendering the whole document in writer to a single tile,
since that's completely unrealistic and impractical (it takes
forever for large docs and artificially spikes the memory).
* Rendering starts at the current part and not the first.
  + This gives the spreadsheet of interest priority (if saved as visible).
* The tile size is now more realistic as we use the same dimensions
  as the Online client does.
* When rendering tiles at scale, we use the same dimensions as the
  Online client rather than splitting the width by 4, for realism.
* Rendering of tiles is done rows-first, rather than columns-first,
  which is similar to what the Online client does, which is more
  cache friendly, therefore more realistic.
* Enabled compiling of tilebench when GTK3 is disabled, which
  was erroneous, since tilebench doesn't have any dependency on GTK.
  + Now it's possible to compile with local Cairo/Pixman libs.

Reviewed-on: https://gerrit.libreoffice.org/44936
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 
(cherry picked from commit 7db98521548de9eab955ee25a5aacaaef42df323)

Change-Id: I6ad2e97f39572778dd7d0c12d14550841c1d6963
Reviewed-on: https://gerrit.libreoffice.org/46984
Tested-by: Jenkins 
Reviewed-by: Ashod Nakashian 

diff --git a/Repository.mk b/Repository.mk
index 29a6dbc05a3d..78ef396fa860 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -70,7 +70,7 @@ $(eval $(call gb_Helper_register_executables,NONE, \
 svptest \
 svpclient \
 pixelctl ) \
-   $(if $(and $(ENABLE_GTK3), $(filter LINUX %BSD SOLARIS,$(OS))), 
tilebench) \
+   $(if $(filter LINUX %BSD SOLARIS,$(OS)), tilebench) \
$(if $(filter LINUX MACOSX SOLARIS WNT %BSD,$(OS)),icontest \
outdevgrind) \
vcldemo \
diff --git a/libreofficekit/Executable_tilebench.mk 
b/libreofficekit/Executable_tilebench.mk
index 4da51d3ca686..9d8b2a134f99 100644
--- a/libreofficekit/Executable_tilebench.mk
+++ b/libreofficekit/Executable_tilebench.mk
@@ -15,7 +15,6 @@ $(eval $(call gb_Executable_set_include,tilebench,\
 ))
 
 $(eval $(call gb_Executable_use_libraries,tilebench,\
-libreofficekitgtk \
sal \
 ))
 
diff --git a/libreofficekit/Module_libreofficekit.mk 
b/libreofficekit/Module_libreofficekit.mk
index c74c0681328e..2d7519c46ca1 100644
--- a/libreofficekit/Module_libreofficekit.mk
+++ b/libreofficekit/Module_libreofficekit.mk
@@ -24,10 +24,13 @@ ifneq ($(ENABLE_GTK3),)
 $(eval $(call gb_Module_add_targets,libreofficekit,\
 Library_libreofficekitgtk \
 Executable_gtktiledviewer \
+))
+endif # ($(ENABLE_GTK3),)
+
+$(eval $(call gb_Module_add_targets,libreofficekit,\
 Executable_tilebench \
 Package_selectionhandles \
 ))
-endif # ($(ENABLE_GTK3),)
 
 endif
 
diff --git a/libreofficekit/qa/tilebench/tilebench.cxx 
b/libreofficekit/qa/tilebench/tilebench.cxx
index 686523211a3b..ed8d44c13789 100644
--- a/libreofficekit/qa/tilebench/tilebench.cxx
+++ b/libreofficekit/qa/tilebench/tilebench.cxx
@@ -10,10 +10,12 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
 
+#include 
 #include 
 #include 
 
@@ -21,7 +23,7 @@ using namespace lok;
 
 static int help()
 {
-fprintf( stderr, "Usage: tilebench  
[path to document]\n" );
+fprintf( stderr, "Usage: tilebench  
[path to document] [max parts|-1] [max tiles|-1]\n" );
 fprintf( stderr, "renders a selection of small tiles from the document, 
checksums them and times the process\n" );
 return 1;
 }
@@ -36,13 +38,17 @@ static double getTimeNow()
 
 int main( int argc, char* argv[] )
 {
+static const double origin = getTimeNow();
 struct TimeRecord {
 const char *mpName;
 double mfTime;
 
 TimeRecord() : mpName(nullptr), mfTime(getTimeNow()) { }
 explicit TimeRecord(const char *pName) :
-   mpName(pName ), mfTime(getTimeNow()) { }
+

[Libreoffice-bugs] [Bug 114655] [MacOS] Can't open Preferences : LibreOffice 6.0 RC1 crash every time.

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114655

--- Comment #4 from Claude <1claudechampa...@gmail.com> ---
(In reply to Xisco Faulí from comment #1)
> I can't reproduce it in
> 
> Version: 6.1.0.0.alpha0+
> Build ID: 6a312a4a3d642f0f9769df54c0ec25471c9916bd
> CPU threads: 8; OS: Mac OS X 10.12.6; UI render: default; 
> Locale: en-US (en_ES.UTF-8); Calc: group threaded

Well, not the same version of LibreOffice (6.0 RC1 here), and not the same
MacOS version (10.3.2 here.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114655] [MacOS] Can't open Preferences : LibreOffice 6.0 RC1 crash every time.

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114655

--- Comment #3 from Claude <1claudechampa...@gmail.com> ---
(In reply to Xisco Faulí from comment #2)
> To be certain the reported issue is not
> related to corruption in the user profile, could you please reset your
> Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and
> re-test?
> 
> I have set the bug's status to 'NEEDINFO'. Please change it back to
> 'UNCONFIRMED' if the issue is still present


I have deleted anything LibreOffice related everywhere on the Mac (High Sierra
10.3.2)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114659] New: Pasting cells between sheets uses absolute values ( not cross-sheet references)

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114659

Bug ID: 114659
   Summary: Pasting cells between sheets uses absolute values (not
cross-sheet references)
   Product: LibreOffice
   Version: 5.4.4.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: m...@samtuke.com

Description:
When copying and pasting cells which contain formulas between two sheets of the
same document, the values are inserted literally, instead of pasting the
formulas with references to the original sheet, as expected. By default,
references should be used instead of literal values.

Steps to Reproduce:
1. Create some calculations using formulas and cell references within sheet #1
2. Create sheet #2 in the same document and copy the cells from sheet #1
3. Double click the pasted cells and observe the values are literal numbers --
the formulas are gone

Actual Results:  
Formulas are lost and literal values are inserted

Expected Results:
Formulas are inserted, with automatically updated cell references pointing to
sheet #1 in the same document.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
Firefox/59.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89676] 4.4.x: Bundled templates are not localizable

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=89676

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89676] 4.4.x: Bundled templates are not localizable

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=89676

--- Comment #20 from Commit Notification 
 ---
Laurent BP committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=39d1022967297524b852b5c82e78d815cf908b3d

tdf#103317 tdf#89676 clean-up Impress templates

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: extras/source

2017-12-22 Thread Laurent BP

 extras/source/templates/presnt/Blue_Curve.otp  |binary
 extras/source/templates/presnt/Classy_Red.otp  |binary
 extras/source/templates/presnt/Forestbird.otp  |binary
 extras/source/templates/presnt/Lights.otp  |binary
 extras/source/templates/presnt/LushGreen.otp   |binary
 extras/source/templates/presnt/Nature_Illustration.otp |binary
 extras/source/templates/presnt/Piano.otp   |binary
 7 files changed

New commits:
commit 39d1022967297524b852b5c82e78d815cf908b3d
Author: Laurent BP 
Date:   Fri Dec 1 21:14:42 2017 +0100

tdf#103317 tdf#89676 clean-up Impress templates

Blue_Curve
   - Remove unused fonts
   - Restore preview in Notes Master
   - Remove Autofit to outline of slide 2
   - add Title in meta.xml

Classy_Red
   - Remove unused fonts
   - Restore width in Notes Master 1
   - add Title in meta.xml

Forestbird
   - Remove unused fonts
   - Restore preview in Notes Master
   - add Title in meta.xml

Lights
   - Remove unused fonts
   - Restore preview in Notes Master
   - add Title in meta.xml

Lushgreen
   - Remove unused fonts
   - Restore preview in Notes
   - Restore preview in Notes Master
   - add Title in meta.xml

Nature_Illustration
   - Remove unused fonts
   - add Title in meta.xml

Piano
   - Remove unused fonts
   - Restore preview in Notes Master
   - add Title in meta.xml

Change-Id: I7338332b6424161a7a11854b47dec6193b205b7c
Reviewed-on: https://gerrit.libreoffice.org/45697
Tested-by: Jenkins 
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/extras/source/templates/presnt/Blue_Curve.otp 
b/extras/source/templates/presnt/Blue_Curve.otp
index 3bf61ad23991..f87ab762a708 100644
Binary files a/extras/source/templates/presnt/Blue_Curve.otp and 
b/extras/source/templates/presnt/Blue_Curve.otp differ
diff --git a/extras/source/templates/presnt/Classy_Red.otp 
b/extras/source/templates/presnt/Classy_Red.otp
index 9753105b1dfd..62d090a953ca 100644
Binary files a/extras/source/templates/presnt/Classy_Red.otp and 
b/extras/source/templates/presnt/Classy_Red.otp differ
diff --git a/extras/source/templates/presnt/Forestbird.otp 
b/extras/source/templates/presnt/Forestbird.otp
index 8a609d5e2d4d..21b66215d26b 100644
Binary files a/extras/source/templates/presnt/Forestbird.otp and 
b/extras/source/templates/presnt/Forestbird.otp differ
diff --git a/extras/source/templates/presnt/Lights.otp 
b/extras/source/templates/presnt/Lights.otp
index 268236aad4f4..27a4d3fa7d76 100644
Binary files a/extras/source/templates/presnt/Lights.otp and 
b/extras/source/templates/presnt/Lights.otp differ
diff --git a/extras/source/templates/presnt/LushGreen.otp 
b/extras/source/templates/presnt/LushGreen.otp
index 7a69d13aa544..19b7e465cbe3 100644
Binary files a/extras/source/templates/presnt/LushGreen.otp and 
b/extras/source/templates/presnt/LushGreen.otp differ
diff --git a/extras/source/templates/presnt/Nature_Illustration.otp 
b/extras/source/templates/presnt/Nature_Illustration.otp
index 4a1b26f8286c..62682719c86f 100644
Binary files a/extras/source/templates/presnt/Nature_Illustration.otp and 
b/extras/source/templates/presnt/Nature_Illustration.otp differ
diff --git a/extras/source/templates/presnt/Piano.otp 
b/extras/source/templates/presnt/Piano.otp
index 92a66a712f0e..5ddba350bd46 100644
Binary files a/extras/source/templates/presnt/Piano.otp and 
b/extras/source/templates/presnt/Piano.otp differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: extras/source

2017-12-22 Thread Laurent BP

 extras/source/templates/presnt/Alizarin.otp|binary
 extras/source/templates/presnt/Beehive.otp |binary
 extras/source/templates/presnt/Blueprint_Plans.otp |binary
 extras/source/templates/presnt/BrightBlue.otp  |binary
 extras/source/templates/presnt/DNA.otp |binary
 extras/source/templates/presnt/Focus.otp   |binary
 extras/source/templates/presnt/Impress.otp |binary
 extras/source/templates/presnt/Inspiration.otp |binary
 extras/source/templates/presnt/Metropolis.otp  |binary
 extras/source/templates/presnt/Midnightblue.otp|binary
 extras/source/templates/presnt/Pencil.otp  |binary
 extras/source/templates/presnt/Portfolio.otp   |binary
 extras/source/templates/presnt/Progress.otp|binary
 extras/source/templates/presnt/Sunset.otp  |binary
 extras/source/templates/presnt/Vintage.otp |binary
 extras/source/templates/presnt/Vivid.otp   |binary
 16 files changed

New commits:
commit ebbcdd2416b02f2d796dc0dd24bc013be39575b3
Author: Laurent BP 
Date:   Thu Nov 30 22:12:35 2017 +0100

tdf#103317 tdf#107027 tdf#113795 Impress Templates

Improve Impress templates:
  - remove settings.xml, picture, colortable and configuration2 (update 
manifest.xml)
  - restore preview in Notes
  - restore preview in Notes Master
  - remove english language tag to date
  - remove user defined styles
  - remove errors detected by ODF Validator
 - styles.xml: set draw:fit-to-size at "false" instead of 
"shrink-to-fit" and add style:shrink-to-fit="true" (suggested by Regina)
 - change font-weight="250" to font-weight="200"
  - replace Open Sans font with Noto Sans Regular (Impress.otp and 
Vivid.otp)
  - replace Open Sans bold font with Noto Sans Bold (Impress.otp)
  - remove declaration of unused fonts
  - add Title in meta.xml (to get template name translated tdf#89676)

Change-Id: Ibab7ec8f4b3ad828cd85fc9d975acb8e87e7780e
Reviewed-on: https://gerrit.libreoffice.org/45623
Tested-by: Jenkins 
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 
Reviewed-by: Laurent BP 

diff --git a/extras/source/templates/presnt/Alizarin.otp 
b/extras/source/templates/presnt/Alizarin.otp
index 7688482936f1..fde3f26e8d52 100644
Binary files a/extras/source/templates/presnt/Alizarin.otp and 
b/extras/source/templates/presnt/Alizarin.otp differ
diff --git a/extras/source/templates/presnt/Beehive.otp 
b/extras/source/templates/presnt/Beehive.otp
index 4c63013c3b76..2ec454c219cc 100644
Binary files a/extras/source/templates/presnt/Beehive.otp and 
b/extras/source/templates/presnt/Beehive.otp differ
diff --git a/extras/source/templates/presnt/Blueprint_Plans.otp 
b/extras/source/templates/presnt/Blueprint_Plans.otp
index 4b71eaf60269..5956e9bf7ee4 100644
Binary files a/extras/source/templates/presnt/Blueprint_Plans.otp and 
b/extras/source/templates/presnt/Blueprint_Plans.otp differ
diff --git a/extras/source/templates/presnt/BrightBlue.otp 
b/extras/source/templates/presnt/BrightBlue.otp
index f1d187d26368..06d0aeb131af 100644
Binary files a/extras/source/templates/presnt/BrightBlue.otp and 
b/extras/source/templates/presnt/BrightBlue.otp differ
diff --git a/extras/source/templates/presnt/DNA.otp 
b/extras/source/templates/presnt/DNA.otp
index 212b6ae095e3..6b307f8ca971 100644
Binary files a/extras/source/templates/presnt/DNA.otp and 
b/extras/source/templates/presnt/DNA.otp differ
diff --git a/extras/source/templates/presnt/Focus.otp 
b/extras/source/templates/presnt/Focus.otp
index 953b6aa04180..6fb2a1eccc24 100644
Binary files a/extras/source/templates/presnt/Focus.otp and 
b/extras/source/templates/presnt/Focus.otp differ
diff --git a/extras/source/templates/presnt/Impress.otp 
b/extras/source/templates/presnt/Impress.otp
index ccd527332673..0db0be13cf7c 100644
Binary files a/extras/source/templates/presnt/Impress.otp and 
b/extras/source/templates/presnt/Impress.otp differ
diff --git a/extras/source/templates/presnt/Inspiration.otp 
b/extras/source/templates/presnt/Inspiration.otp
index 9e16fad83519..b18f272d4b98 100644
Binary files a/extras/source/templates/presnt/Inspiration.otp and 
b/extras/source/templates/presnt/Inspiration.otp differ
diff --git a/extras/source/templates/presnt/Metropolis.otp 
b/extras/source/templates/presnt/Metropolis.otp
index 93497a23c925..fc41a7522d60 100644
Binary files a/extras/source/templates/presnt/Metropolis.otp and 
b/extras/source/templates/presnt/Metropolis.otp differ
diff --git a/extras/source/templates/presnt/Midnightblue.otp 
b/extras/source/templates/presnt/Midnightblue.otp
index ca47b531002a..e9816e5ede08 100644
Binary files a/extras/source/templates/presnt/Midnightblue.otp and 
b/extras/source/templates/presnt/Midnightblue.otp differ
diff --git

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - icon-themes/breeze icon-themes/elementary icon-themes/elementary_svg

2017-12-22 Thread andreas kainz

 icon-themes/breeze/sd/res/displaymode_xx.svg  
|  687 --
 icon-themes/breeze/sw/res/sidebar/pageproppanel/column_L_copy_24x24.png   
|binary
 icon-themes/breeze/sw/res/sidebar/pageproppanel/documentsize_L_copy_24x24.png 
|binary
 icon-themes/breeze/sw/res/sidebar/pageproppanel/format_L_copy_24x24.png   
|binary
 icon-themes/breeze/sw/res/sidebar/pageproppanel/portraitcopy_24x24.png
|binary
 icon-themes/elementary/res/notebookbar.png
|binary
 icon-themes/elementary_svg/res/notebookbar.svg
|1 
 7 files changed, 1 insertion(+), 687 deletions(-)

New commits:
commit e16ef4a7d2f56a22dc05f8d05cf27d828d9d231b
Author: andreas kainz 
Date:   Thu Dec 21 00:43:24 2017 +0100

Elementary Breeze-icon theme fixes

Change-Id: Ieb154287f43e70dec747ecf4b5c7cd348883fe43
Reviewed-on: https://gerrit.libreoffice.org/46872
Tested-by: Jenkins 
Reviewed-by: andreas_kainz 
(cherry picked from commit 2c6d6c113177e25b9ae1674c1e8de0b3c8ae1327)
Reviewed-on: https://gerrit.libreoffice.org/46920

diff --git a/icon-themes/breeze/sd/res/displaymode_xx.svg 
b/icon-themes/breeze/sd/res/displaymode_xx.svg
deleted file mode 100644
index 577941fc6690..
--- a/icon-themes/breeze/sd/res/displaymode_xx.svg
+++ /dev/null
@@ -1,687 +0,0 @@
-
-
-
-http://purl.org/dc/elements/1.1/;
-   xmlns:cc="http://creativecommons.org/ns#;
-   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
-   xmlns:svg="http://www.w3.org/2000/svg;
-   xmlns="http://www.w3.org/2000/svg;
-   xmlns:xlink="http://www.w3.org/1999/xlink;
-   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
-   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape;
-   width="19.19mm"
-   height="15.24mm"
-   viewBox="0 0 67.98 53.99"
-   id="svg2"
-   version="1.1"
-   inkscape:version="0.91 r13725"
-   sodipodi:docname="displaymode_handoutmaster.svg">
-  
-
-  
-  
-
-
-  
-  
-
-
-  
-  
-
-
-  
-  
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-  
-  
-
-  
-  
-
-  
-image/svg+xml
-http://purl.org/dc/dcmitype/StillImage; />
-
-  
-
-  
-  
-
-
-
-
-
-
-
-
-
-
-  
-  
-  
-  
-  
-  
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-  
-
diff --git 
a/icon-themes/breeze/sw/res/sidebar/pageproppanel/column_L_copy_24x24.png 
b/icon-themes/breeze/sw/res/sidebar/pageproppanel/column_L_copy_24x24.png
new file mode 100644
index ..d18114641b3c
Binary files /dev/null and 
b/icon-themes/breeze/sw/res/sidebar/pageproppanel/column_L_copy_24x24.png differ
diff --git 
a/icon-themes/breeze/sw/res/sidebar/pageproppanel/documentsize_L_copy_24x24.png 
b/icon-themes/breeze/sw/res/sidebar/pageproppanel/documentsize_L_copy_24x24.png
new file mode 100644
index ..3867cb7a915b
Binary files /dev/null and 
b/icon-themes/breeze/sw/res/sidebar/pageproppanel/documentsize_L_copy_24x24.png 
differ
diff --git 
a/icon-themes/breeze/sw/res/sidebar/pageproppanel/format_L_copy_24x24.png 
b/icon-themes/breeze/sw/res/sidebar/pageproppanel/format_L_copy_24x24.png
new file mode 100644
index ..6484c117f43b
Binary files /dev/null and 
b/icon-themes/breeze/sw/res/sidebar/pageproppanel/format_L_copy_24x24.png differ
diff --git 
a/icon-themes/breeze/sw/res/sidebar/pageproppanel/portraitcopy_24x24.png 
b/icon-themes/breeze/sw/res/sidebar/pageproppanel/portraitcopy_24x24.png
new file mode 100644
index ..59373a888096
Binary files /dev/null and 
b/icon-themes/breeze/sw/res/sidebar/pageproppanel/portraitcopy_24x24.png differ
diff --git a/icon-themes/elementary/res/notebookbar.png 
b/icon-themes/elementary/res/notebookbar.png
new file mode 100644
index ..679485448fab
Binary files /dev/null and b/icon-themes/elementary/res/notebookbar.png differ
diff --git a/icon-themes/elementary_svg/res/notebookbar.svg 
b/icon-themes/elementary_svg/res/notebookbar.svg
new file mode 100644
index ..8d57888c7ca2
--- /dev/null
+++ b/icon-themes/elementary_svg/res/notebookbar.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108756] Alignment and spacing in format options for search and replace does not recognise non incremental numbers

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108756

--- Comment #8 from Antonio CASADO  ---
This bug is still present in LibreOffice 5.4.4 x64. What is more, now it seems
that it does not work at all. If you set any values in the "search and replace
menu option > format button > alignment and spacing", it does not find or
replace anything.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114658] New: MRI extensions are outdated and don't work in latest LO

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114658

Bug ID: 114658
   Summary: MRI extensions are outdated and don't work in latest
LO
   Product: LibreOffice
   Version: 5.3.7.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Extensions
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ghborrm...@gmail.com

The MRI extension site lists two versions: 1.1.2 and 1.1.4.  Neither one will
install in LO 5.3.7.2; each of these produces a different error.  Compatibility
is listed as up to 3.5, so this is no surprise.  The OpenOffice site has a
later version: 1.3.3, and this one does install.  However, the menu bar of MRI
is completely unusable; each menu item drops down so little that there is no
room for any menu subitems to be displayed.  I have successfully installed this
version into LO 5.1.6.1, and the menu items function as expected.  I am
surprised that a minor version change (from 5.1 to 5.3) would have any effect
on the behavior of so basic a component as a menu.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: dbaccess/source

2017-12-22 Thread Julien Nabet

 dbaccess/source/core/api/KeySet.cxx |   90 ++--
 1 file changed, 36 insertions(+), 54 deletions(-)

New commits:
commit df8623e7ed955e747006d9cb049f4a3e26e6ecca
Author: Julien Nabet 
Date:   Fri Dec 22 20:36:21 2017 +0100

Use for-range loops in dbaccess/KeySet (1st pass)

+ remove an unused var
+ fix a slight indent pb

Change-Id: Ie6e801c9d2b7ce6e7f5d352b2175fa9d7d6b9c7d
Reviewed-on: https://gerrit.libreoffice.org/46995
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/dbaccess/source/core/api/KeySet.cxx 
b/dbaccess/source/core/api/KeySet.cxx
index 2a8584cc6455..61b20adc8b4d 100644
--- a/dbaccess/source/core/api/KeySet.cxx
+++ b/dbaccess/source/core/api/KeySet.cxx
@@ -125,12 +125,9 @@ OKeySet::~OKeySet()
 {
 tryDispose(m_xSet);
 // m_xStatement is necessarily one of those
-const vStatements_t::const_iterator end(m_vStatements.end());
-for(vStatements_t::iterator i(m_vStatements.begin());
-i != end;
-++i)
+for (auto & statement : m_vStatements)
 {
-tryDispose(i->second);
+tryDispose(statement.second);
 }
 
 m_xComposer = nullptr;
@@ -343,10 +340,8 @@ void OKeySet::ensureStatement( )
 // of key & foreign columns?
 FilterColumnsNULL_t FilterColumnsNULL;
 FilterColumnsNULL.reserve(m_aKeyIter->second.first->get().size());
-connectivity::ORowVector< ORowSetValue >::Vector::const_iterator aIter = 
m_aKeyIter->second.first->get().begin();
-const connectivity::ORowVector< ORowSetValue >::Vector::const_iterator 
aEnd  = m_aKeyIter->second.first->get().end();
-for( ; aIter != aEnd; ++aIter )
-FilterColumnsNULL.push_back(aIter->isNull());
+for (auto const& elem : m_aKeyIter->second.first->get())
+FilterColumnsNULL.push_back(elem.isNull());
 vStatements_t::const_iterator 
pNewStatement(m_vStatements.find(FilterColumnsNULL));
 if(pNewStatement == m_vStatements.end())
 {
@@ -480,14 +475,12 @@ void OKeySet::updateRow(const ORowSetRow& _rInsertRow 
,const ORowSetRow& _rOrigi
 const sal_Int32 nOldLength = aSql.getLength();
 sal_Int32 i = 1;
 // here we build the condition part for the update statement
-SelectColumnsMetaData::const_iterator aIter = m_pColumnNames->begin();
-SelectColumnsMetaData::const_iterator aEnd = m_pColumnNames->end();
-for(;aIter != aEnd;++aIter,++i)
+for (auto const& columnName : *m_pColumnNames)
 {
-if ( m_pKeyColumnNames->find(aIter->first) != m_pKeyColumnNames->end() 
)
+if ( m_pKeyColumnNames->find(columnName.first) != 
m_pKeyColumnNames->end() )
 {
-sKeyCondition.append(::dbtools::quoteName( 
aQuote,aIter->second.sRealName));
-if((_rOriginalRow->get())[aIter->second.nPosition].isNull())
+sKeyCondition.append(::dbtools::quoteName( 
aQuote,columnName.second.sRealName));
+if((_rOriginalRow->get())[columnName.second.nPosition].isNull())
 sKeyCondition.append(sIsNull);
 else
 sKeyCondition.append(sParam);
@@ -495,29 +488,28 @@ void OKeySet::updateRow(const ORowSetRow& _rInsertRow 
,const ORowSetRow& _rOrigi
 }
 else
 {
-std::vector< Reference >::const_iterator aIndexEnd = 
aAllIndexColumns.end();
-for( std::vector< Reference >::const_iterator 
aIndexIter = aAllIndexColumns.begin();
-aIndexIter != aIndexEnd;++aIndexIter)
+for (auto const& indexColumn : aAllIndexColumns)
 {
-if((*aIndexIter)->hasByName(aIter->first))
+if(indexColumn->hasByName(columnName.first))
 {
-sIndexCondition.append(::dbtools::quoteName( 
aQuote,aIter->second.sRealName));
-
if((_rOriginalRow->get())[aIter->second.nPosition].isNull())
+sIndexCondition.append(::dbtools::quoteName( 
aQuote,columnName.second.sRealName));
+
if((_rOriginalRow->get())[columnName.second.nPosition].isNull())
 sIndexCondition.append(sIsNull);
 else
 {
 sIndexCondition.append(sParam);
-
aIndexColumnPositions.push_back(aIter->second.nPosition);
+
aIndexColumnPositions.push_back(columnName.second.nPosition);
 }
 sIndexCondition.append(aAnd);
 break;
 }
 }
 }
-if((_rInsertRow->get())[aIter->second.nPosition].isModified())
+if((_rInsertRow->get())[columnName.second.nPosition].isModified())
 {
-aSql.append(::dbtools::quoteName( aQuote,aIter->second.sRealName) 
+ aPara);
+aSql.append(::dbtools::quoteName( 
aQuote,columnName.second.sRealName) + aPara);
 }
+

[Libreoffice-bugs] [Bug 108770] [META] DOCX (OOXML) bullet and numbering list-related issues

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108770

Dieter Praas  changed:

   What|Removed |Added

 Depends on||114649


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114649
[Bug 114649] DOCX: Text Higlight problem with bulleted or numbered lists
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114649] DOCX: Text Higlight problem with bulleted or numbered lists

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114649

Dieter Praas  changed:

   What|Removed |Added

 Blocks||108770
Summary|Text Higlight problem with  |DOCX: Text Higlight problem
   |bulleted or numbered lists  |with bulleted or numbered
   ||lists

--- Comment #3 from Dieter Praas  ---
Why don't you use odt-format after you edited it the first time? Can you try
it? Does it solve your problem?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108770
[Bug 108770] [META] DOCX (OOXML) bullet and numbering list-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114657] FILESAVE: Chart Data Series lost on save (XLSX)

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114657

--- Comment #2 from Nathan Huebner  ---
Created attachment 138603
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138603=edit
XLSX after saving in LibreOffice as XLSX (breaks data series)

This is the XLSX file LibreOffice gave me after saving it. Opening the file
again in LibreOffice shows the Data Series is broken as well, even though
LibreOffice saved it.

So it saved it and became broken.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114657] FILESAVE: Chart Data Series lost on save (XLSX)

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114657

--- Comment #1 from Nathan Huebner  ---
Created attachment 138602
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138602=edit
XLSX with working chart (before saving from LO)

This is the XLSX file with the chart working in Excel and LibreOffice before it
is saved in LibreOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103816] Both margins in Frame > Formula style need to be zero.

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103816

Regina Henschel  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #14 from Regina Henschel  ---


*** This bug has been marked as a duplicate of bug 65067 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39750] [META] General Math formula editor improvements

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39750
Bug 39750 depends on bug 103816, which changed state.

Bug 103816 Summary: Both margins in Frame > Formula style need to be zero.
https://bugs.documentfoundation.org/show_bug.cgi?id=103816

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65067] change defaults to avoid unnecessary horizontal spacing around formulas

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=65067

Regina Henschel  changed:

   What|Removed |Added

 CC||pablo.j...@gmail.com

--- Comment #21 from Regina Henschel  ---
*** Bug 103816 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Telesto  changed:

   What|Removed |Added

 Whiteboard|target:6.0.0|

--- Comment #18 from Telesto  ---
Removing "target:6.0.0". The commit in question has been reverted.

The issue seems to be the most problematic on MacOS. The reports are still
coming in, but end up in general MacOS performance bug reports:
https://bugs.documentfoundation.org/show_bug.cgi?id=106154#c28
https://bugs.documentfoundation.org/show_bug.cgi?id=106703#c2

I priority bump would be nice (in my opinion). The source of the problem is
known (comment 16).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114657] New: FILESAVE: Chart Data Series lost on save (XLSX)

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114657

Bug ID: 114657
   Summary: FILESAVE: Chart Data Series lost on save (XLSX)
   Product: LibreOffice
   Version: 5.3.1.2 release
  Hardware: Other
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ndallas1...@gmail.com

Description:
LO Calc reads the chart correctly when first opening the XLSX file. But when
performing "Save As XLSX", the Data Series formula references are corrupted. 

If there is a workaround, do you have any alternative ways in writing out the
Data Series in a different way that may not become corrupted?

Steps to Reproduce:
1. Create an XLSX file using Microsoft Excel (2013+)

2. Create a chart using a Data Series to plot.

3. Assign the data series as similar:

  Name:=Sheet1!$A$1
  Categories:  =Sheet1!$B$1
  X-Values:=Sheet1!$A$2:$A$10
  Y-Values:=Sheet1!$B$2:$B$10

4. Save the XLSX file in Microsoft Excel.

5. Open the XLSX file in LibreOffice Calc.

6. Notice that the series look correct, the chart looks normal.

7. In LibreOffice, "Save As New XLSX file".

8. Close the XLSX file.

9. Open the "New XLSX file" in Microsoft Excel.

Actual Results:  
1. Open the XLSX File saved in Libre Office, into Microsoft Excel.

2. Click the Chart.

3. Click the Filter icon to the right.

4. Mouse over the Series label in the list.

5. Click the icon to the right of the label in Series.

6. Notice the Data Series References now look like the following:

Name:=sheet1 $A$1
Categories:  =sheet1 $B$1
X-Values:=sheet1 $A$2:$A$10
Y-Values:=sheet1 $B$2:$B$10


Expected Results:
The Data Series should remain unchanged.

  Name:=Sheet1!$A$1
  Categories:  =Sheet1!$B$1
  X-Values:=Sheet1!$A$2:$A$10
  Y-Values:=Sheet1!$B$2:$B$10



Reproducible: Always


User Profile Reset: Yes



Additional Info:
I can provide file attachments if that helps.

Here's the output for the latest version of LibreOffice. Please note that I
upgraded to LibreOffice 5.3.1, and the last version (2 months ago) had the same
problem.

Upgrading did not fix the issue.

** (soffice:13694): CRITICAL **: void g_lo_menu_insert_section(GLOMenu*, gint,
const gchar*, GMenuModel*): assertion 'G_IS_LO_MENU (menu)' failed

(soffice:13694): Gtk-CRITICAL **: gtk_menu_bar_new_from_model: assertion
'G_IS_MENU_MODEL (model)' failed

(soffice:13694): Gtk-CRITICAL **: gtk_widget_insert_action_group: assertion
'GTK_IS_WIDGET (widget)' failed

(soffice:13694): Gtk-CRITICAL **: gtk_widget_set_hexpand: assertion
'GTK_IS_WIDGET (widget)' failed

(soffice:13694): Gtk-CRITICAL **: gtk_grid_attach: assertion 'GTK_IS_WIDGET
(child)' failed

(soffice:13694): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(soffice:13694): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion
'G_TYPE_CHECK_INSTANCE (instance)' failed

(soffice:13694): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(soffice:13694): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion
'G_TYPE_CHECK_INSTANCE (instance)' failed

** (soffice:13694): CRITICAL **: void g_lo_menu_insert_section(GLOMenu*, gint,
const gchar*, GMenuModel*): assertion 'G_IS_LO_MENU (menu)' failed

(soffice:13694): Gtk-CRITICAL **: gtk_menu_bar_new_from_model: assertion
'G_IS_MENU_MODEL (model)' failed

(soffice:13694): Gtk-CRITICAL **: gtk_widget_insert_action_group: assertion
'GTK_IS_WIDGET (widget)' failed

(soffice:13694): Gtk-CRITICAL **: gtk_widget_set_hexpand: assertion
'GTK_IS_WIDGET (widget)' failed

(soffice:13694): Gtk-CRITICAL **: gtk_grid_attach: assertion 'GTK_IS_WIDGET
(child)' failed

(soffice:13694): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(soffice:13694): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion
'G_TYPE_CHECK_INSTANCE (instance)' failed

(soffice:13694): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(soffice:13694): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion
'G_TYPE_CHECK_INSTANCE (instance)' failed
[13843:13843:1222/214903.577207:ERROR:zygote_host_impl_linux.cc(88)] Running as
root without --no-sandbox is not supported. See https://crbug.com/638180.
[13853:13853:1222/214903.661560:ERROR:zygote_host_impl_linux.cc(88)] Running as
root without --no-sandbox is not supported. See https://crbug.com/638180.
/usr/bin/xdg-open: 771: /usr/bin/xdg-open: firefox: not found
/usr/bin/xdg-open: 771: /usr/bin/xdg-open: iceweasel: not found
/usr/bin/xdg-open: 771: /usr/bin/xdg-open: seamonkey: not found
/usr/bin/xdg-open: 771: /usr/bin/xdg-open: mozilla: not found
/usr/bin/xdg-open: 771: /usr/bin/xdg-open: epiphany: not found
/usr/bin/xdg-open: 771: /usr/bin/xdg-open: konqueror: not found
/usr/bin/xdg-open: 771: /usr/bin/xdg-open: chromium-browser: not found

[Libreoffice-bugs] [Bug 114493] In Math Formula the spacing around operators, numbers, identifiers etc should be adjustable

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114493

--- Comment #4 from Regina Henschel  ---
This is a valid request. Unfortunately type setting of formulas are not
strongly standardized. But the values in the operator dictionary are suitable
as default in LibreOffice. https://www.w3.org/TR/MathML3/appendixc.html.

There exists some bugs about spacing, e.g. 66279, 107379, 104194. But they are
not really duplicate. I think we should keep this issue for the spacing aspects
in StarMath and the related UI. Of cause import from and export to MathML has
to be implemented at the same time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/po

2017-12-22 Thread Andras Timar

 loleaflet/po/styles/ab.po  |2 
 loleaflet/po/styles/af.po  |  302 --
 loleaflet/po/styles/am.po  |  222 ---
 loleaflet/po/styles/an.po  |2 
 loleaflet/po/styles/ar.po  |  882 --
 loleaflet/po/styles/as.po  |  882 --
 loleaflet/po/styles/ast.po |  702 
 loleaflet/po/styles/be.po  |  394 -
 loleaflet/po/styles/bg.po  | 1054 -
 loleaflet/po/styles/bn-IN.po   |  798 
 loleaflet/po/styles/bn.po  |  374 -
 loleaflet/po/styles/bo.po  |  374 -
 loleaflet/po/styles/br.po  |  938 
 loleaflet/po/styles/brx.po |6 
 loleaflet/po/styles/bs.po  |  762 --
 loleaflet/po/styles/ca-valencia.po |  842 -
 loleaflet/po/styles/ca.po  |  842 -
 loleaflet/po/styles/cs.po  |  890 ---
 loleaflet/po/styles/cy.po  |  702 
 loleaflet/po/styles/da.po  |  754 --
 loleaflet/po/styles/de.po  |  838 -
 loleaflet/po/styles/dgo.po |  362 
 loleaflet/po/styles/dz.po  |  374 -
 loleaflet/po/styles/el.po  | 1050 
 loleaflet/po/styles/en-GB.po   |   14 
 loleaflet/po/styles/en-ZA.po   |2 
 loleaflet/po/styles/eo.po  |  994 --
 loleaflet/po/styles/es.po  |  882 --
 loleaflet/po/styles/et.po  |  958 -
 loleaflet/po/styles/eu.po  |  810 
 loleaflet/po/styles/fa.po  |   54 -
 loleaflet/po/styles/fi.po  |  794 ---
 loleaflet/po/styles/fr.po  |  786 ---
 loleaflet/po/styles/ga.po  |  730 -
 loleaflet/po/styles/gd.po  |  794 ---
 loleaflet/po/styles/gl.po  |  818 
 loleaflet/po/styles/gu.po  |  886 ---
 loleaflet/po/styles/gug.po |   54 -
 loleaflet/po/styles/he.po  |  482 
 loleaflet/po/styles/hi.po  |  882 --
 loleaflet/po/styles/hr.po  |  734 -
 loleaflet/po/styles/hu.po  |  758 --
 loleaflet/po/styles/id.po  |  654 --
 loleaflet/po/styles/is.po  |  802 
 loleaflet/po/styles/it.po  |  758 --
 loleaflet/po/styles/ja.po  |  914 
 loleaflet/po/styles/ka.po  |  326 ---
 loleaflet/po/styles/kk.po  | 1046 
 loleaflet/po/styles/kl.po  |2 
 loleaflet/po/styles/km.po  |  686 
 loleaflet/po/styles/kmr-Latn.po|  210 ---
 loleaflet/po/styles/kn.po  |  882 --
 loleaflet/po/styles/ko.po  |  686 
 loleaflet/po/styles/kok.po |  350 
 loleaflet/po/styles/ks.po  |6 
 loleaflet/po/styles/ky.po  |2 
 loleaflet/po/styles/lb.po  |   58 --
 loleaflet/po/styles/lo.po  |   10 
 loleaflet/po/styles/lt.po  |  450 ---
 loleaflet/po/styles/lv.po  |  938 
 loleaflet/po/styles/mai.po |   46 -
 loleaflet/po/styles/mk.po  |   50 -
 loleaflet/po/styles/ml.po  |  882 --
 loleaflet/po/styles/mn.po  |   50 -
 loleaflet/po/styles/mni.po |6 
 loleaflet/po/styles/mr.po  |  882 --
 loleaflet/po/styles/my.po  |  382 -
 loleaflet/po/styles/nb.po  |  766 --
 loleaflet/po/styles/ne.po  |   98 ---
 loleaflet/po/styles/nl.po  |  762 --
 loleaflet/po/styles/nn.po  |  766 --
 loleaflet/po/styles/nr.po  |  374 -
 loleaflet/po/styles/nso.po |  354 
 loleaflet/po/styles/oc.po  |  750 --
 loleaflet/po/styles/om.po  |  370 
 loleaflet/po/styles/or.po  |  878 --
 loleaflet/po/styles/pa-IN.po   |  386 -
 loleaflet/po/styles/pl.po  |  862 --
 loleaflet/po/styles/pt-BR.po   |  814

[Libreoffice-commits] online.git: loleaflet/dist loleaflet/po

2017-12-22 Thread Andras Timar

 loleaflet/dist/toolbar/toolbar.js  |1 +
 loleaflet/po/styles/am.po  |4 
 loleaflet/po/styles/ar.po  |4 
 loleaflet/po/styles/bg.po  |4 
 loleaflet/po/styles/br.po  |4 
 loleaflet/po/styles/ca-valencia.po |4 
 loleaflet/po/styles/ca.po  |4 
 loleaflet/po/styles/cs.po  |4 
 loleaflet/po/styles/cy.po  |4 
 loleaflet/po/styles/da.po  |4 
 loleaflet/po/styles/de.po  |4 
 loleaflet/po/styles/el.po  |4 
 loleaflet/po/styles/eo.po  |4 
 loleaflet/po/styles/es.po  |4 
 loleaflet/po/styles/et.po  |4 
 loleaflet/po/styles/eu.po  |4 
 loleaflet/po/styles/fi.po  |4 
 loleaflet/po/styles/fr.po  |4 
 loleaflet/po/styles/gd.po  |4 
 loleaflet/po/styles/gl.po  |4 
 loleaflet/po/styles/gug.po |4 
 loleaflet/po/styles/hr.po  |4 
 loleaflet/po/styles/hu.po  |4 
 loleaflet/po/styles/id.po  |4 
 loleaflet/po/styles/is.po  |4 
 loleaflet/po/styles/it.po  |4 
 loleaflet/po/styles/kk.po  |4 
 loleaflet/po/styles/lt.po  |4 
 loleaflet/po/styles/lv.po  |4 
 loleaflet/po/styles/nb.po  |4 
 loleaflet/po/styles/nl.po  |4 
 loleaflet/po/styles/nn.po  |4 
 loleaflet/po/styles/oc.po  |4 
 loleaflet/po/styles/pl.po  |4 
 loleaflet/po/styles/pt-BR.po   |4 
 loleaflet/po/styles/pt.po  |4 
 loleaflet/po/styles/ro.po  |4 
 loleaflet/po/styles/ru.po  |4 
 loleaflet/po/styles/sk.po  |4 
 loleaflet/po/styles/sl.po  |4 
 loleaflet/po/styles/sv.po  |4 
 loleaflet/po/styles/ta.po  |4 
 loleaflet/po/styles/tr.po  |4 
 loleaflet/po/styles/ug.po  |4 
 loleaflet/po/styles/uk.po  |4 
 loleaflet/po/styles/zh-CN.po   |4 
 loleaflet/po/styles/zh-TW.po   |4 
 47 files changed, 185 insertions(+)

New commits:
commit 8850fbda3a27ac62a60ed954cc780d47716ea797
Author: Andras Timar 
Date:   Thu Dec 21 22:27:10 2017 +0100

Add translations for ' of records found' in Calc status bar

Change-Id: I75184f43d5135851757f622410c99cc9dad34c11
Reviewed-on: https://gerrit.libreoffice.org/46934
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/loleaflet/dist/toolbar/toolbar.js 
b/loleaflet/dist/toolbar/toolbar.js
index bcee2626..575c730d 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -1279,6 +1279,7 @@ map.on('commandstatechanged', function (e) {
}
else if (commandName === '.uno:RowColSelCount') {
state = toLocalePattern('$1 rows, $2 columns selected', '(\\d+) 
rows, (\\d+) columns selected', state, '$1', '$2');
+   state = toLocalePattern('$1 of $2 records found', '(\\d+) of 
(\\d+) records found', state, '$1', '$2');
updateToolbarItem(statusbar, 'RowColSelCount', 
$('#RowColSelCount').html(state ? state : 
'').parent().html());
}
else if (commandName === '.uno:InsertMode') {
diff --git a/loleaflet/po/styles/am.po b/loleaflet/po/styles/am.po
index ea6443e2..8bf30283 100644
--- a/loleaflet/po/styles/am.po
+++ b/loleaflet/po/styles/am.po
@@ -2277,3 +2277,7 @@ msgstr "áá¨áá³áá (ááªá¸áµ)"
 #: resource.src
 msgid "None (Do not check spelling)"
 msgstr "ááá (áá°áá á á³áá)"
+
+#: globstr.src
+msgid "$1 of $2 records found"
+msgstr "$1 á¨ $2 áááá¦á½ á°ááá°áá"
diff --git a/loleaflet/po/styles/ar.po b/loleaflet/po/styles/ar.po
index 76eb7239..95dbb6b8 100644
--- a/loleaflet/po/styles/ar.po
+++ b/loleaflet/po/styles/ar.po
@@ -4326,3 +4326,7 @@ msgstr "Ø§ÙÙØ±ÙØ³ÙØ© (ÙÙØ±ÙØ´ÙÙØ³)"
 #: resource.src
 msgid "None (Do not check spelling)"
 msgstr "Ø¨ÙØ§ (ÙØ§ ØªØ¯ÙÙÙ Ø§ÙØ¥ÙÙØ§Ø¡)"
+
+#: globstr.src
+msgid "$1 of $2 records found"
+msgstr "ÙÙØ¬Ø¯ $1 ÙÙ Ø£ØµÙ $2 ÙÙ Ø§ÙØ³Ø¬ÙØ§Øª"
diff --git a/loleaflet/po/styles/bg.po b/loleaflet/po/styles/bg.po
index 29017d8d..dba6fd5a 100644
--- a/loleaflet/po/styles/bg.po
+++ b/loleaflet/po/styles/bg.po
@@ -4577,3 +4577,7 @@ msgstr "ÐÐ½Ð³Ð»Ð¸Ð¹ÑÐºÐ¸ (ÐÐ°Ð»Ð°Ð¹Ð·Ð¸Ñ)"
 #: resource.src
 msgid "None (Do not check spelling)"
 msgstr "ÐÑÐ¼Ð° (Ð±ÐµÐ· Ð¿ÑÐ¾Ð²ÐµÑÐºÐ° Ð½Ð° Ð¿ÑÐ°Ð²Ð¾Ð¿Ð¸ÑÐ°)"
+
+#: globstr.src
+msgid "$1 of $2 records found"
+msgstr "$1 Ð¾Ñ Ð½Ð°Ð¼ÐµÑÐµÐ½Ð¸ $2 Ð·Ð°Ð¿Ð¸ÑÐ°"
diff --git a/loleaflet/po/styles/br.po b/loleaflet/po/styles/br.po
index f691b75c..6bed4ab0 100644
--- a/loleaflet/po/styles/br.po
+++

[Libreoffice-commits] core.git: accessibility/source avmedia/Library_avmedia.mk avmedia/source basic/source chart2/Library_chartcore.mk chart2/source cui/source dbaccess/source editeng/source extensio

2017-12-22 Thread Jan Holesovsky

 accessibility/source/helper/accresmgr.cxx|3 -
 avmedia/Library_avmedia.mk   |1 
 avmedia/source/framework/mediamisc.cxx   |   33 
 avmedia/source/inc/mediamisc.hxx |7 ---
 basic/source/sbx/sbxscan.cxx |5 +-
 chart2/Library_chartcore.mk  |1 
 chart2/source/inc/ResourceManager.hxx|   38 ---
 chart2/source/tools/ResId.cxx|3 -
 chart2/source/tools/ResourceManager.cxx  |   34 -
 cui/source/factory/cuiresmgr.cxx |3 -
 dbaccess/source/core/resource/core_resource.cxx  |3 -
 editeng/source/editeng/eerdll.cxx|8 
 extensions/source/inc/componentmodule.cxx|3 -
 extensions/source/propctrlr/modulepcr.cxx|3 -
 extensions/source/scanner/sanedlg.cxx|3 -
 filter/source/pdf/impdialog.cxx  |9 
 filter/source/xsltdialog/xmlfiltersettingsdialog.cxx |3 -
 forms/source/resource/frm_resource.cxx   |3 -
 formula/source/core/resource/core_resource.cxx   |3 -
 fpicker/inc/fpsofficeResMgr.hxx  |3 -
 framework/source/fwe/classes/fwkresid.cxx|3 -
 include/basic/sbdef.hxx  |2 -
 include/editeng/eerdll.hxx   |1 
 include/svtools/svtresid.hxx |2 -
 include/svx/dialmgr.hxx  |2 -
 reportdesign/source/core/resource/core_resource.cxx  |3 -
 sccomp/source/solver/SolverComponent.cxx |3 -
 sccomp/source/solver/SwarmSolver.cxx |3 -
 sfx2/source/bastyp/sfxresid.cxx  |4 --
 svl/source/misc/getstringresource.cxx|3 -
 svtools/source/misc/svtresid.cxx |5 +-
 svx/source/dialog/dialmgr.cxx|5 +-
 vcl/source/app/settings.cxx  |6 +++
 writerperfect/Library_writerperfect.mk   |1 
 writerperfect/inc/WPFTResMgr.hxx |7 ---
 writerperfect/source/common/WPFTResMgr.cxx   |   11 -
 xmlsecurity/inc/resourcemanager.hxx  |4 --
 xmlsecurity/source/dialogs/resourcemanager.cxx   |6 ---
 38 files changed, 37 insertions(+), 203 deletions(-)

New commits:
commit 101a79cc4d13a1f566c1b97c1329813eb7c61bcf
Author: Jan Holesovsky 
Date:   Wed Dec 13 19:17:48 2017 +0100

lokdialog: Allow switching language of some of the ResMgr's.

This way, it is possible to have all the strings translated in dialogs even
when different users use different languages.  [It was already possible
to have different languages previously, but not everything in the dialog has
switched - like the buttons at the bottom of the dialogs etc.]

Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9
Reviewed-on: https://gerrit.libreoffice.org/46417
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 
Reviewed-on: https://gerrit.libreoffice.org/46979
Tested-by: Jenkins 

diff --git a/accessibility/source/helper/accresmgr.cxx 
b/accessibility/source/helper/accresmgr.cxx
index 7bf55e120737..37b8b9f56b33 100644
--- a/accessibility/source/helper/accresmgr.cxx
+++ b/accessibility/source/helper/accresmgr.cxx
@@ -22,8 +22,7 @@
 
 OUString AccResId(const char* pId)
 {
-static std::locale loc = Translate::Create("acc");
-return Translate::get(pId, loc);
+return Translate::get(pId, Translate::Create("acc"));
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/avmedia/Library_avmedia.mk b/avmedia/Library_avmedia.mk
index ff206228a0c5..1f4c5246b651 100644
--- a/avmedia/Library_avmedia.mk
+++ b/avmedia/Library_avmedia.mk
@@ -64,7 +64,6 @@ $(eval $(call gb_Library_add_exception_objects,avmedia,\
avmedia/source/framework/mediacontrol \
avmedia/source/framework/MediaControlBase \
avmedia/source/framework/mediaitem \
-   avmedia/source/framework/mediamisc \
avmedia/source/framework/mediaplayer \
avmedia/source/framework/mediatoolbox \
avmedia/source/framework/soundhandler \
diff --git a/avmedia/source/framework/mediamisc.cxx 
b/avmedia/source/framework/mediamisc.cxx
deleted file mode 100644
index a8d627266596..
--- a/avmedia/source/framework/mediamisc.cxx
+++ /dev/null
@@ -1,33 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain

[Libreoffice-bugs] [Bug 114656] RTL Expanded spacing affected by diacritical marks

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114656

Maxim Iorsh  changed:

   What|Removed |Added

 Attachment #138600|0   |1
is obsolete||

--- Comment #3 from Maxim Iorsh  ---
Created attachment 138601
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138601=edit
Bug screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114656] RTL Expanded spacing affected by diacritical marks

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114656

--- Comment #2 from Maxim Iorsh  ---
Created attachment 138600
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138600=edit
Bug screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114656] RTL Expanded spacing affected by diacritical marks

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114656

--- Comment #1 from Maxim Iorsh  ---
Created attachment 138599
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138599=edit
Demo ODT document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] dev-tools.git: 2 commits - esc-reporting/esc-analyze.py esc-reporting/esc-report.py

2017-12-22 Thread Shinnok

 esc-reporting/esc-analyze.py |4 ++--
 esc-reporting/esc-report.py  |2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit e5a33b0cbe16def49811444a2239acfb3ad618c6
Author: Shinnok 
Date:   Wed Dec 13 11:36:41 2017 +0100

Disable UI reports mailed directly to Heiko.

Change-Id: I1294290e90ab08a090ccfdbb89716f88c478e4b5
Reviewed-on: https://gerrit.libreoffice.org/46377
Reviewed-by: Heiko Tietze 
Tested-by: Heiko Tietze 

diff --git a/esc-reporting/esc-report.py b/esc-reporting/esc-report.py
index 028e133..b4b38b4 100755
--- a/esc-reporting/esc-report.py
+++ b/esc-reporting/esc-report.py
@@ -529,7 +529,7 @@ def report_ui():
   print('  {} made {} changes in 1 month, and {} changes in 1 
year'.format(
 top10list[i]['name'], top10list[i]['month'], 
top10list[i]['year']), file=fp)
 fp.close()
-return {'title': 'ESC UI report', 'mail': 'tietze.he...@gmail.com', 
'file': '/tmp/esc_ui_report.txt'}
+return None
 
 
 
commit 1346ed3572125857d9cf4e0d40e47f0f44c40972
Author: Shinnok 
Date:   Mon Dec 18 09:07:18 2017 +0100

Update mentor e-mail to mentor...@documentfoundation.org.

Change-Id: I93c80e21127e92cfe162bd07e4c8146759c8ceea
Reviewed-on: https://gerrit.libreoffice.org/46688
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/esc-reporting/esc-analyze.py b/esc-reporting/esc-analyze.py
index e0458d3..578e625 100755
--- a/esc-reporting/esc-analyze.py
+++ b/esc-reporting/esc-analyze.py
@@ -308,7 +308,7 @@ def analyze_mentoring():
   statList['people'][mail]['gerrit']['reviewName'] = '{} 
<{}>'.format(row['name'],row['email'])
   statList['people'][mail]['isCommitter'] = True
   statList['people'][mail]['isContributor'] = True
-x1 = statList['people']['ad...@shinnok.com']
+x1 = statList['people']['mentor...@documentfoundation.org']
 statNewDate = cfg['1yearDate']
 statOldDate = cfg['nowDate']
 for key, row in gerritData['patch'].items():
@@ -735,7 +735,7 @@ def analyze_reports():
   else:
 for comment in row['comments']:
   email = util_check_mail('', comment['creator'])
-  if not email == 'aniste...@gmail.com' and not email == 
'ad...@shinnok.com' and 'reviewName' in 
statList['people'][ownerEmail]['gerrit']:
+  if not email == 'aniste...@gmail.com' and not email == 
'mentor...@docmentfoundation.org' and 'reviewName' in 
statList['people'][ownerEmail]['gerrit']:
 reviewEmail = email
 break
 except Exception as e:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114656] New: RTL Expanded spacing affected by diacritical marks

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114656

Bug ID: 114656
   Summary: RTL Expanded spacing affected by diacritical marks
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: io...@users.sourceforge.net

Description:
The amount of expanded spacing between characters is affected by non-base
characters, such as diacritical marks

Steps to Reproduce:
1. Install David CLM font (available as fonts-hebrew package or at
culmus.sf.net)
2. Open the attached ODT file
3. Observe different spacing between the two lines of text

Actual Results:  
Line 1 is more expanded than line 2, despite having the same letters

Expected Results:
Line 1 should have the same total length as line 2


Reproducible: Always


User Profile Reset: No



Additional Info:
Looks like non-base characters (diacritical marks under the letters) affect the
spacing between characters, while in fact they should be ignored

Version: 5.1.6.2
Build ID: 1:5.1.6~rc2-0ubuntu1~xenial2
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
Locale: he-IL (en_US.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] dev-tools.git: esc-reporting/esc-analyze.py

2017-12-22 Thread Shinnok

 esc-reporting/esc-analyze.py |7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit c596332399de89fd561d39837b4fc0d1beac2d6f
Author: Shinnok 
Date:   Wed Dec 20 12:39:47 2017 +0100

Cleanup missing license reports in the daily mails.

By cross-referencing against licenseCompany.csv domain too.

Change-Id: I4060e63d0d121825e1ce0b2e3342bb4d3f7e0ccc
Reviewed-on: https://gerrit.libreoffice.org/46843
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/esc-reporting/esc-analyze.py b/esc-reporting/esc-analyze.py
index f3de599..e0458d3 100755
--- a/esc-reporting/esc-analyze.py
+++ b/esc-reporting/esc-analyze.py
@@ -608,6 +608,9 @@ def util_is_company_license(email):
 domain = line[:line.index(' ')]
   if email.endswith(domain):
 return True
+for domain in cfg['companies']:
+  if email.endswith(domain):
+return True
 return False
 
 def analyze_reports():
@@ -687,7 +690,9 @@ def analyze_reports():
   entry['email'] = ownerEmail
   entry['license'] = 'GERRIT NO LICENSE'
   statList['reportList']['missing_license'].append(entry)
-elif not statList['people'][ownerEmail]['licenseOK']:
+elif not statList['people'][ownerEmail]['licenseOK']\
+  and not util_is_company_license(ownerEmail):
+  print(ownerEmail)
   entry['license'] = 'GERRIT: ' + 
statList['people'][ownerEmail]['licenseText']
   statList['reportList']['missing_license'].append(entry)
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106154] Extremely slow basic operations on macOS

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106154

--- Comment #29 from Telesto  ---
(In reply to Rene Meessen from comment #28)
> I have been using Draw on Win 11 and just switched to a new Macbook Pro 13".
> Using 5.3.7.2 on the Mac
> 
> When I select an item and move the mouse nothing happens for two seconds
> then the item moves to the new position of the cursor.
> 
> It was a pleasure to work with on Win11 but its impossible to get any work
> done on the Mac.

Probably bug 105500. Something similar is happing in Impress (bug 106962).
Disabling the sidebar should speed up things. Or using a LibreOffice version
prior to LibO 5.1. 
https://downloadarchive.documentfoundation.org/libreoffice/old/

My personal preference is LibO 4.3.7.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39593] copy/paste code detector / fixing

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #34 from Commit Notification 
 ---
tagezi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5fe3117e1877fa0bfb55f1cf22cf9394b3f0795

tdf#39593 deduplicate code in ScCellShell

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2017-12-22 Thread tagezi

 sc/source/ui/view/cellsh1.cxx |   86 +-
 1 file changed, 28 insertions(+), 58 deletions(-)

New commits:
commit a5fe3117e1877fa0bfb55f1cf22cf9394b3f0795
Author: tagezi 
Date:   Fri Dec 22 01:05:13 2017 +0200

tdf#39593 deduplicate code in ScCellShell

Change-Id: I240715d73c5ae320a3dfab786b446e229083ff4b
Reviewed-on: https://gerrit.libreoffice.org/46941
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index 8f0063986168..89bda8c80c2e 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -107,6 +107,31 @@ using namespace ::com::sun::star;
 using namespace ::com::sun::star::beans;
 using namespace ::com::sun::star::uno;
 
+namespace{
+InsertDeleteFlags FlagsFromString(const OUString& rFlagsStr,
+InsertDeleteFlags nFlagsMask = InsertDeleteFlags::CONTENTS | 
InsertDeleteFlags::ATTRIB)
+{
+OUString aFlagsStr = rFlagsStr.toAsciiUpperCase();
+InsertDeleteFlags nFlags = InsertDeleteFlags::NONE;
+
+for (sal_Int32 i=0 ; i < aFlagsStr.getLength(); ++i)
+{
+switch (aFlagsStr[i])
+{
+case 'A': returnInsertDeleteFlags::ALL;
+case 'S': nFlags |= InsertDeleteFlags::STRING   & nFlagsMask; 
break;
+case 'V': nFlags |= InsertDeleteFlags::VALUE& nFlagsMask; 
break;
+case 'D': nFlags |= InsertDeleteFlags::DATETIME & nFlagsMask; 
break;
+case 'F': nFlags |= InsertDeleteFlags::FORMULA  & nFlagsMask; 
break;
+case 'N': nFlags |= InsertDeleteFlags::NOTE & nFlagsMask; 
break;
+case 'T': nFlags |= InsertDeleteFlags::ATTRIB   & nFlagsMask; 
break;
+case 'O': nFlags |= InsertDeleteFlags::OBJECTS  & nFlagsMask; 
break;
+}
+}
+return nFlags;
+}
+}
+
 void ScCellShell::ExecuteEdit( SfxRequest& rReq )
 {
 ScModule*   pScMod  = SC_MOD();
@@ -348,26 +373,7 @@ void ScCellShell::ExecuteEdit( SfxRequest& rReq )
 if( pReqArgs->HasItem( SID_DELETE,  ) )
 aFlags = static_cast(pItem)->GetValue();
 
-aFlags = aFlags.toAsciiUpperCase();
-boolbCont = true;
-
-for (sal_Int32 i=0 ; bCont && iHasItem( FID_FILL_TAB,  ) )
 aFlags = static_cast(pItem)->GetValue();
 
-aFlags = aFlags.toAsciiUpperCase();
-boolbCont = true;
-
-for (sal_Int32 i=0; bCont && i < aFlags.getLength(); ++i)
-{
-switch (aFlags[i])
-{
-case 'A': // all
-nFlags |= InsertDeleteFlags::ALL;
-bCont = false; // don't continue!
-break;
-case 'S': nFlags |= InsertDeleteFlags::STRING; 
break;
-case 'V': nFlags |= InsertDeleteFlags::VALUE; 
break;
-case 'D': nFlags |= InsertDeleteFlags::DATETIME; 
break;
-case 'F': nFlags |= InsertDeleteFlags::FORMULA; 
break;
-case 'N': nFlags |= InsertDeleteFlags::NOTE; break;
-case 'T': nFlags |= InsertDeleteFlags::ATTRIB; 
break;
-}
-}
+nFlags |= FlagsFromString(aFlags);
 }
 else
 {
@@ -1354,25 +1342,7 @@ void ScCellShell::ExecuteEdit( SfxRequest& rReq )
 if( pReqArgs->HasItem(

[Libreoffice-bugs] [Bug 114647] Presentation: multiple animated gifs consumes CPU causing hang

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114647

--- Comment #7 from Dwokfur  ---
(In reply to Telesto from comment #4)
> Thanks for the new bug report ;-)
> 
> Everything seems smooth to me with:
> Version: 6.1.0.0.alpha0+
> Build ID: ca1bcb40ea27492c0f3a452c4a318b540a9ff09c
> CPU threads: 4; OS: Windows 6.3; UI render: default; 
> TinderBox: Win-x86@42, Branch:master, Time: 2017-12-21_00:35:39
> Locale: nl-NL (nl_NL); Calc: CL
> 
> and with
> Versie: 6.0.0.1 (x64)
> Build ID: d2bec56d7865f05a1003dc88449f2b0fdd85309a
> CPU-threads: 4; Besturingssysteem: Windows 6.3; UI-render: standaard; 
> Locale: nl-NL (nl_NL); Calc: CL
> 
> with or without OpenGL
> 
> Please give 6.0 a try
> http://dev-builds.libreoffice.org/pre-releases/win/x86_64/LibreOffice_6.0.0.
> 1_Win_x64.msi

Hi Telesto,

I've installed 6.0.0.1 linked. The situation got better in a sense, that I can
navigate between slides, and may exit the presentation. But the presentation is
still sluggish and the responsiveness is lagging. Toggling OpenGL and hardware
acceleration doesn't have any effect on the symptoms. When running the software
in safe mode the symptoms stay exactly the same. Openoffice-4.x provides smooth
experience in comparison on the same machine. There is a difference, that OOo
swaps the two monitors and puts the presentation preview on the other.
I use only the default extensions, which includes Hungarian dictionary.
I can reproduce the problem on multiple Win 7 Enterprise 64bit machines at my
workplace (this particular has Q9400 with 8Gb of RAM) and on a laptop that has
i7-4900MQ and 32Gb of RAM, running Win 7 Pro 64bit.
Should I capture a video about what is happening or the description is enough?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114639] File/Send crash at hovering

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114639

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
Thank you for reporting the bug.
Unfortunately without clear steps to reproduce it, we cannot track down the
origin of the problem.
Please provide a clearer set of step-by-step instructions on how to reproduce
the problem.
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the steps are provided

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114638] Wikimedia Settings crash

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114638

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Thank you for reporting the bug.
Unfortunately without clear steps to reproduce it, we cannot track down the
origin of the problem.
Please provide a clearer set of step-by-step instructions on how to reproduce
the problem.
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the steps are provided

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114655] [MacOS] Can't open Preferences : LibreOffice 6.0 RC1 crash every time.

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114655

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
To be certain the reported issue is not
related to corruption in the user profile, could you please reset your
Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and
re-test?

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the issue is still present

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114649] Text Higlight problem with bulleted or numbered lists

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114649

--- Comment #2 from E.K  ---
all parts in docx format. I didn't convert it to the odt format. Opened in docx
format, edited and saved as docx.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114655] [MacOS] Can't open Preferences : LibreOffice 6.0 RC1 crash every time.

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114655

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
I can't reproduce it in

Version: 6.1.0.0.alpha0+
Build ID: 6a312a4a3d642f0f9769df54c0ec25471c9916bd
CPU threads: 8; OS: Mac OS X 10.12.6; UI render: default; 
Locale: en-US (en_ES.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106154] Extremely slow basic operations on macOS

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106154

Rene Meessen  changed:

   What|Removed |Added

Version|5.3.0.3 release |5.3.7.2 release

--- Comment #28 from Rene Meessen  ---
I have been using Draw on Win 11 and just switched to a new Macbook Pro 13".
Using 5.3.7.2 on the Mac

When I select an item and move the mouse nothing happens for two seconds then
the item moves to the new position of the cursor.

It was a pleasure to work with on Win11 but its impossible to get any work done
on the Mac.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - include/LibreOfficeKit libreofficekit/source

2017-12-22 Thread Pranav Kant

 include/LibreOfficeKit/LibreOfficeKitEnums.h |7 ++--
 libreofficekit/source/gtk/lokdocview.cxx |   39 +++
 2 files changed, 43 insertions(+), 3 deletions(-)

New commits:
commit 44ae26e0b9ac08493bf67419e2a6a01f221af26b
Author: Pranav Kant 
Date:   Thu Dec 21 13:20:26 2017 +0530

lokdocview: Handle INVALIDATE_HEADER cb

With this calc gtktiledviewer or any other lok client shouldn't crash
anymore when a new view is opened.

And while at it, update documentation of callbacks.

Change-Id: I436c3b424dd4e2e6b8c312b0d3ba43d7006e944b
(cherry picked from commit 71cd37fad9792038279969c82e0cb209df06f024)
Reviewed-on: https://gerrit.libreoffice.org/46950
Tested-by: Jenkins 
Reviewed-by: Miklos Vajna 

diff --git a/include/LibreOfficeKit/LibreOfficeKitEnums.h 
b/include/LibreOfficeKit/LibreOfficeKitEnums.h
index 451ed2c959c7..ea2fb798e984 100644
--- a/include/LibreOfficeKit/LibreOfficeKitEnums.h
+++ b/include/LibreOfficeKit/LibreOfficeKitEnums.h
@@ -498,11 +498,12 @@ typedef enum
  * The column/row header is no more valid because of a column/row insertion
  * or a similar event. Clients must query a new column/row header set.
  *
- * The payload says if we are invalidating a row or column header.
+ * The payload says if we are invalidating a row or column header. So,
+ * payload values can be: "row", "column", "all".
  */
 LOK_CALLBACK_INVALIDATE_HEADER = 33,
 /**
- * The text content of the address field in Calc.
+ * The text content of the address field in Calc. Eg: "A7"
  */
 LOK_CALLBACK_CELL_ADDRESS = 34,
 /**
@@ -521,7 +522,7 @@ typedef enum
  *
  * Here all aproperties are same as described in svxruler.
  */
-LOK_CALLBACK_RULER_UPDATE = 35,
+LOK_CALLBACK_RULER_UPDATE = 35
 }
 LibreOfficeKitCallbackType;
 
diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index 2735c77b9f75..ca47080c7618 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -277,6 +277,7 @@ enum
 PASSWORD_REQUIRED,
 COMMENT,
 RULER,
+INVALIDATE_HEADER,
 
 LAST_SIGNAL
 };
@@ -430,6 +431,8 @@ callbackTypeToString (int nType)
 return "LOK_CALLBACK_REDLINE_TABLE_SIZE_CHANGED";
 case LOK_CALLBACK_REDLINE_TABLE_ENTRY_MODIFIED:
 return "LOK_CALLBACK_REDLINE_TABLE_ENTRY_MODIFIED";
+case LOK_CALLBACK_INVALIDATE_HEADER:
+return "LOK_CALLBACK_INVALIDATE_HEADER";
 case LOK_CALLBACK_COMMENT:
 return "LOK_CALLBACK_COMMENT";
 case LOK_CALLBACK_RULER_UPDATE:
@@ -1426,6 +1429,9 @@ callback (gpointer pData)
 case LOK_CALLBACK_RULER_UPDATE:
 g_signal_emit(pCallback->m_pDocView, doc_view_signals[RULER], 0, 
pCallback->m_aPayload.c_str());
 break;
+case LOK_CALLBACK_INVALIDATE_HEADER:
+g_signal_emit(pCallback->m_pDocView, 
doc_view_signals[INVALIDATE_HEADER], 0, pCallback->m_aPayload.c_str());
+break;
 default:
 g_assert(false);
 break;
@@ -3213,6 +3219,22 @@ static void lok_doc_view_class_init (LOKDocViewClass* 
pClass)
  G_TYPE_NONE, 1,
  G_TYPE_STRING);
 
+/**
+ * The key ruler related properties on change are reported by this.
+ *
+ * The payload format is:
+ *
+ * {
+ *  "margin1": "...",
+ *  "margin2": "...",
+ *  "leftOffset": "...",
+ *  "pageOffset": "...",
+ *  "pageWidth": "...",
+ *  "unit": "..."
+ *  }
+ *
+ * Here all aproperties are same as described in svxruler.
+ */
 doc_view_signals[RULER] =
 g_signal_new("ruler",
  G_TYPE_FROM_CLASS(pGObjectClass),
@@ -3222,6 +3244,23 @@ static void lok_doc_view_class_init (LOKDocViewClass* 
pClass)
  g_cclosure_marshal_generic,
  G_TYPE_NONE, 1,
  G_TYPE_STRING);
+
+/**
+ * The column/row header is no more valid because of a column/row insertion
+ * or a similar event. Clients must query a new column/row header set.
+ *
+ * The payload says if we are invalidating a row or column header. So,
+ * payload values can be: "row", "column", "all".
+ */
+doc_view_signals[INVALIDATE_HEADER] =
+g_signal_new("invalidate-header",
+ G_TYPE_FROM_CLASS(pGObjectClass),
+ G_SIGNAL_RUN_FIRST,
+ 0,
+ nullptr, nullptr,
+ g_cclosure_marshal_generic,
+ G_TYPE_NONE, 1,
+ G_TYPE_STRING);
 }
 
 SAL_DLLPUBLIC_EXPORT GtkWidget*
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-bugs] [Bug 114641] Clicking Contents tab in Help crashes

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114641

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Xisco Faulí  ---


*** This bug has been marked as a duplicate of bug 114242 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114506] Fully collapsed state of sidebar persists across modules

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114506

--- Comment #2 from Chavdar  ---
CONFIRMED

Not sure if this is a bug or a feature, but it is confirmed.

Tested with version:
- 5.4.3.2 (x64)
- 6.0.0.0.beta2 (x64)
Windows 10 64
Locale: bg-BG (bg_BG)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114652] Calc unresponsiveness when copying partial text inside cell

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114652

Jacques Guilleron  changed:

   What|Removed |Added

 Resolution|NOTABUG |WORKSFORME

--- Comment #7 from Jacques Guilleron  ---
Ok. I change status to WORKSFORME.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66279] MathML export: use the operator dictionary

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=66279

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #11 from Regina Henschel  ---
The issue is not solved in Version: 6.1.0.0.alpha0+ (x64)
Build ID: d73857e7d7f6a5bf38c6a2f396832faabaef65e2
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2017-12-12_17:37:14
Locale: de-DE (de_DE); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114649] Text Higlight problem with bulleted or numbered lists

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114649

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter Praas  ---
> I had a docx file created in Windows/MicrosoftOffice
> I edited the document using LibreOffice 6.0.0.1 Writer on Ubuntu17.10(xorg).
> (No problem yet)
> I sent the document to a windows machine

It's not clear to me: Do you send it as docx or as odt?

> and edited it using LibreOffice
> 6.0.0.1 Writer. (Problem appears here as stated above)
> I send the document back to Ubuntu machine

It's not clear to me: Do you send it as docx or as odt?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64795] [FORMATTING] Add new feature of 'keep with previous paragraph' formatting option for Writer

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=64795

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Blocks||107642


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107642
[Bug 107642] [META] Paragraph dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107642] [META] Paragraph dialog bugs and enhancements

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107642

Dieter Praas  changed:

   What|Removed |Added

 Depends on||64795


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=64795
[Bug 64795] [FORMATTING] Add new feature of 'keep with previous paragraph'
formatting option for Writer
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114493] In Math Formula the spacing around operators, numbers, identifiers etc should be adjustable

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114493

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de
   Severity|normal  |enhancement

--- Comment #3 from Jean-Baptiste Faure  ---
Hi Regina,

I think you are the right person to evaluate this enhancement request :-)
What do you think ?

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114652] Calc unresponsiveness when copying partial text inside cell

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114652

--- Comment #6 from Hernan  ---
I strongly object that this was marked as NOTABUG just because you couldn't
reproduce it. 
You have WORKSFORME for that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114652] Calc unresponsiveness when copying partial text inside cell

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114652

--- Comment #5 from Chavdar  ---
Not reproduced

Tested with version:
- 5.4.3.2 (x64)
- 6.0.0.0.beta2 (x64)
Windows 10 64
Locale: bg-BG (bg_BG)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: external/firebird

2017-12-22 Thread Stephan Bergmann

 external/firebird/UnpackedTarball_firebird.mk |8 
 external/firebird/sanitizer.patch |   52 ++
 2 files changed, 60 insertions(+)

New commits:
commit 6a312a4a3d642f0f9769df54c0ec25471c9916bd
Author: Stephan Bergmann 
Date:   Fri Dec 22 07:58:47 2017 +0100

Prepare external/firebird for sanitizers

...so at least Clang -fsanitize=function on Linux works now.  The patch 
needs to
stop errors about undefined sanitizer symbols in DSOs (UNDEF_PLATFORM,
EXE_LINK_OPTIONS), and make resolution of RTTI symbols consistent in a 
process,
by exporting them from the various version map files and adding RTLD_GLOBAL 
to
dlopen.

Change-Id: I75779e55529b62a96a8943e3dee9119647aa91a7
Reviewed-on: https://gerrit.libreoffice.org/46947
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/external/firebird/UnpackedTarball_firebird.mk 
b/external/firebird/UnpackedTarball_firebird.mk
index 9c03f7c8755f..a055b6573696 100644
--- a/external/firebird/UnpackedTarball_firebird.mk
+++ b/external/firebird/UnpackedTarball_firebird.mk
@@ -46,4 +46,12 @@ $(eval $(call gb_UnpackedTarball_add_patches,firebird,\
 ))
 endif
 
+ifeq ($(COM_IS_CLANG),TRUE)
+ifneq ($(filter -fsanitize=%,$(CC)),)
+$(eval $(call gb_UnpackedTarball_add_patches,firebird, \
+external/firebird/sanitizer.patch \
+))
+endif
+endif
+
 # vim: set noet sw=4 ts=4:
diff --git a/external/firebird/sanitizer.patch 
b/external/firebird/sanitizer.patch
new file mode 100644
index ..cf3a54b266f8
--- /dev/null
+++ b/external/firebird/sanitizer.patch
@@ -0,0 +1,52 @@
+--- builds/posix/fbintl.vers
 builds/posix/fbintl.vers
+@@ -29,3 +29,4 @@
+ LD_lookup_texttype
+ LD_setup_attributes
+ LD_version
++_ZTI*
+--- builds/posix/fbplugin.vers
 builds/posix/fbplugin.vers
+@@ -26,3 +26,4 @@
+ #
+ 
+ firebird_plugin
++_ZTI*
+--- builds/posix/firebird.vers
 builds/posix/firebird.vers
+@@ -367,3 +367,4 @@
+ 
+ KEYWORD_stringIsAToken
+ KEYWORD_getTokens
++_ZTI*
+--- builds/posix/make.defaults
 builds/posix/make.defaults
+@@ -252,7 +252,7 @@
+ # LINKER OPTIONS
+ #
+ 
+-UNDEF_PLATFORM = -Wl,--no-undefined
++UNDEF_PLATFORM =
+ ifeq ($(TARGET),Debug)
+   UNDEF_FLAGS = $(UNDEF_PLATFORM)
+ endif
+@@ -291,7 +291,7 @@
+ LIB_LINK_MAPFILE= -Wl,--version-script,$(1)
+ FIREBIRD_LIBRARY_LINK= -L$(LIB) -lfbclient $(MATHLIB)
+ 
+-EXE_LINK_OPTIONS= $(LDFLAGS) $(THR_FLAGS) $(UNDEF_FLAGS) $(LIB_PATH_OPTS) 
$(LINK_EMPTY_SYMBOLS)
++EXE_LINK_OPTIONS= $(LDFLAGS) $(THR_FLAGS) $(UNDEF_FLAGS) $(LIB_PATH_OPTS)
+ LIB_LINK_OPTIONS= $(LDFLAGS) $(THR_FLAGS) -shared
+ 
+ FB_DAEMON = $(BIN)/firebird$(EXEC_EXT)
+--- src/common/os/posix/mod_loader.cpp
 src/common/os/posix/mod_loader.cpp
+@@ -88,7 +88,7 @@
+ 
+ ModuleLoader::Module* ModuleLoader::loadModule(const Firebird::PathName& 
modPath)
+ {
+-  void* module = dlopen(modPath.nullStr(), FB_RTLD_MODE);
++  void* module = dlopen(modPath.nullStr(), FB_RTLD_MODE | RTLD_GLOBAL);
+   if (module == NULL)
+   {
+ #ifdef DEV_BUILD
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114647] Presentation: multiple animated gifs consumes CPU causing hang

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114647

--- Comment #6 from Chavdar  ---
No system hang experienced.
Laptop specs: i5 2500 ghz, 8 gb of ram and SSDrive
Tested with version:
- 5.4.3.2 (x64)
- 6.0.0.0.beta2 (x64)
Windows 10 64
Locale: bg-BG (bg_BG)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: bin/find-unused-sid-commands.py starmath/inc starmath/sdi starmath/source

2017-12-22 Thread Noel Grandin

 bin/find-unused-sid-commands.py |4 --
 starmath/inc/starmath.hrc   |3 ++
 starmath/sdi/smath.sdi  |   56 
 starmath/sdi/smslots.sdi|   18 
 starmath/source/document.cxx|8 +
 starmath/source/view.cxx|5 +++
 6 files changed, 91 insertions(+), 3 deletions(-)

New commits:
commit 420a65c107551156e69578c432261dd6dc7b882b
Author: Noel Grandin 
Date:   Fri Dec 22 13:20:16 2017 +0200

Revert "unused SID command in starmath"

This reverts commit b9c6f2de8bdcdcb95fb4f0457ee2fd0e1c42eb5b.

Change-Id: Ice33baa738c025de72ceb11cf6746e017fb27484
Reviewed-on: https://gerrit.libreoffice.org/46964
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/bin/find-unused-sid-commands.py b/bin/find-unused-sid-commands.py
index c0e934b0b624..32f45e0f810a 100755
--- a/bin/find-unused-sid-commands.py
+++ b/bin/find-unused-sid-commands.py
@@ -42,12 +42,10 @@ for pair in commandSet:
 for line2 in txt2:
 foundLines = foundLines + line2
 if foundLines.find("ExecuteList") != -1: continue
-if foundLines.find("Dispatcher()->Execute") != -1: continue
+if foundLines.find("GetDispatcher()->Execute") != -1: continue
 if foundLines.find("ExecuteScenarioSlot") != -1: continue
 # TODO not sure about this, but let's tackle the easy ones first
 if foundLines.find("Invalidate(") != -1: continue
-if foundLines.find("SFX_IMPL_DOCKINGWINDOW_WITHID") != -1: continue
-
 
 # dump any lines that contain the SID, so we can eyeball the results
 print("remove: " + commandName)
diff --git a/starmath/inc/starmath.hrc b/starmath/inc/starmath.hrc
index 0a7c6d003278..bbe606badee7 100644
--- a/starmath/inc/starmath.hrc
+++ b/starmath/inc/starmath.hrc
@@ -49,6 +49,8 @@
 /** Command for inserting a math construction */
 #define SID_INSERTCOMMANDTEXT   (SID_SMA_START + 106)
 
+#define SID_LOADSYMBOLS (SID_SMA_START + 107)
+#define SID_SAVESYMBOLS (SID_SMA_START + 108)
 #define SID_MODIFYSTATUS(SID_SMA_START + 110)
 #define SID_TEXTSTATUS  (SID_SMA_START + 111)
 
@@ -62,6 +64,7 @@
 #define SID_PASTEOBJECT (SID_SMA_START + 118)
 #define SID_AUTOREDRAW  (SID_SMA_START + 119)
 
+#define SID_GETEDITTEXT (SID_SMA_START + 121)
 #define SID_CMDBOXWINDOW(SID_SMA_START + 122)
 #define SID_NO_RIGHT_SPACES (SID_SMA_START + 124)
 #define SID_SAVE_ONLY_USED_SYMBOLS  (SID_SMA_START + 125)
diff --git a/starmath/sdi/smath.sdi b/starmath/sdi/smath.sdi
index 761cae2c0b0d..0ee7306938ca 100644
--- a/starmath/sdi/smath.sdi
+++ b/starmath/sdi/smath.sdi
@@ -289,6 +289,25 @@ SfxVoidItem ImportMathMLClipboard 
SID_IMPORT_MATHML_CLIPBOARD
 GroupId = SfxGroupId::Insert;
 ]
 
+SfxVoidItem LoadSymbols SID_LOADSYMBOLS
+()
+[
+AutoUpdate = FALSE,
+FastCall = FALSE,
+ReadOnlyDoc = TRUE,
+Toggle = FALSE,
+Container = FALSE,
+RecordAbsolute = FALSE,
+RecordPerSet;
+Asynchron;
+
+AccelConfig = FALSE,
+MenuConfig = FALSE,
+ToolBoxConfig = FALSE,
+GroupId = SfxGroupId::Options;
+]
+
+
 SfxStringItem ModifyStatus SID_MODIFYSTATUS
 
 [
@@ -416,6 +435,43 @@ SfxBoolItem RedrawAutomatic SID_AUTO_REDRAW
 GroupId = SfxGroupId::View;
 ]
 
+
+SfxVoidItem SaveSymbols SID_SAVESYMBOLS
+()
+[
+AutoUpdate = FALSE,
+FastCall = FALSE,
+ReadOnlyDoc = TRUE,
+Toggle = FALSE,
+Container = FALSE,
+RecordAbsolute = FALSE,
+RecordPerSet;
+
+AccelConfig = FALSE,
+MenuConfig = FALSE,
+ToolBoxConfig = FALSE,
+GroupId = SfxGroupId::Options;
+]
+
+
+SfxVoidItem SetPaperSize SID_GETEDITTEXT
+()
+[
+AutoUpdate = FALSE,
+FastCall = FALSE,
+ReadOnlyDoc = TRUE,
+Toggle = FALSE,
+Container = FALSE,
+RecordAbsolute = FALSE,
+RecordPerSet;
+
+AccelConfig = FALSE,
+MenuConfig = FALSE,
+ToolBoxConfig = FALSE,
+GroupId = SfxGroupId::Math;
+]
+
+
 SfxVoidItem SymbolCatalogue SID_SYMBOLS_CATALOGUE
 ()
 [
diff --git a/starmath/sdi/smslots.sdi b/starmath/sdi/smslots.sdi
index d2e49127017c..3b0d5cfc6265 100644
--- a/starmath/sdi/smslots.sdi
+++ b/starmath/sdi/smslots.sdi
@@ -55,6 +55,18 @@ interface FormulaDocument
 ExecMethod = Execute ;
 StateMethod = GetState ;
 ]
+//idlpp no menu entry, so no texts
+SID_LOADSYMBOLS //idlpp ole : no , status : no
+[
+ExecMethod = Execute ;
+StateMethod = GetState ;
+]
+//idlpp no menu entry, so no texts
+SID_SAVESYMBOLS //idlpp ole : no , status : no
+[
+ExecMethod = Execute ;
+StateMethod = GetState ;
+]
 SID_FONT //idlpp ole : no , status : no
 [
 ExecMethod = Execute ;
@@ -245,6 +257,12 @@ interface FormulaView
 StateMethod = GetState ;
 ]
 //idlpp no menu entry, so no

[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102998
Bug 102998 depends on bug 112686, which changed state.

Bug 112686 Summary: MAILMERGE : impossible to edit individual record and then 
reuse for mail merge
https://bugs.documentfoundation.org/show_bug.cgi?id=112686

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112686] MAILMERGE : impossible to edit individual record and then reuse for mail merge

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112686

worms  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---

--- Comment #8 from worms  ---
Timur
in previous versions, with mailmerge, after the records was created, you could
modify one or several records and send modified and not modified  by mail
in current version, it's no more possible 
when you click on "send merge documents by mail", it will generate new merge
documents just before to send them 

Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - instsetoo_native/inc_ooolangpack

2017-12-22 Thread Matthias Seidel

 instsetoo_native/inc_ooolangpack/windows/msi_templates/Control.idt |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 10ccaeb500ba2d66e1af2995804a3fc2af122f31
Author: Matthias Seidel 
Date:   Fri Dec 22 17:27:02 2017 +

No wrap for dialog title

diff --git a/instsetoo_native/inc_ooolangpack/windows/msi_templates/Control.idt 
b/instsetoo_native/inc_ooolangpack/windows/msi_templates/Control.idt
index 9672d8107b9f..30c41040d785 100644
--- a/instsetoo_native/inc_ooolangpack/windows/msi_templates/Control.idt
+++ b/instsetoo_native/inc_ooolangpack/windows/msi_templates/Control.idt
@@ -305,8 +305,8 @@ SetupProgress   DlgDesc2Text21  23  
249 25  65538   OOO_CONTROL_235
 SetupProgress  DlgLine Line0   234 376 0   1   

 SetupProgress  DlgText Text59  51  275 30  65538   
OOO_CONTROL_236 
 SetupProgress  DlgText2Text59  51  275 30  65538   
OOO_CONTROL_237 
-SetupProgress  DlgTitleText13  6   257 25  65538   
OOO_CONTROL_238 
-SetupProgress  DlgTitle2   Text13  6   257 25  65538   
OOO_CONTROL_239 
+SetupProgress  DlgTitleText13  6   257 25  327682  
OOO_CONTROL_238 
+SetupProgress  DlgTitle2   Text13  6   257 25  327682  
OOO_CONTROL_239 
 SetupProgress  LbSec   Text172 139 32  12  2   
OOO_CONTROL_240 
 SetupProgress  LbStatusText59  85  70  12  3   
OOO_CONTROL_241 
 SetupProgress  NextPushButton  230 243 66  17  1   
OOO_CONTROL_242 Cancel  
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: config_host/config_langs.h.in config_host/config_vendor.h.in configure.ac cui/source desktop/source include/svl include/svtools officecfg/registry svl/source svtools/so

2017-12-22 Thread Caolán McNamara

 config_host/config_langs.h.in  |   10 
 config_host/config_vendor.h.in |   10 
 configure.ac   |4 
 cui/source/options/optgdlg.cxx |3 
 desktop/source/app/langselect.cxx  |3 
 include/svl/languageoptions.hxx|3 
 include/svtools/langhelp.hxx   |3 
 officecfg/registry/data/org/openoffice/Office/Common.xcu   |3 
 officecfg/registry/schema/org/openoffice/Office/Common.xcs |6 
 svl/source/config/languageoptions.cxx  |   33 ---
 svtools/source/misc/langhelp.cxx   |  131 -
 11 files changed, 168 insertions(+), 41 deletions(-)

New commits:
commit 1c7d3390022908cfbfd30f55e8c0c3b60a045da7
Author: CaolÃ¡n McNamara 
Date:   Wed Dec 20 16:02:18 2017 +

request installation of langpack via packagekit

if ui is set to track the locale automatically and the current locale
has no match in installed resources but has a match in the list of
languages that libreoffice was compiled to contain

so e.g. de_AT locale shouldn't trigger the installation of anything if
langpack-de is already installed and yue_HK shouldn't trigger install
of anything cause that not supported (at time of writing) for libreoffice

put Fedora/RHEL/Ubuntu naming schemes in here.

I moved the lang code from svl to svtools so I could use the restart dialog
to prompt to restart after the langpack is installed, but packagekit's 
blocking
mode seems to be no longer blocking and control returns immediately which 
is a
change since the last time I played with this stuff, so drop the restart 
thing
for now. The lack of a blocking modal also makes the "run this on idle when 
there's
a toplevel window up and running" a bit futile, but lets keep that for now 
anyway.

caolanm->rene: I know you'd disable this anyway, so Debian is left out, 
there's
also config key Office/Common/PackageKit/EnableLangpackInstallation to 
disable
this too.

Change-Id: Ice731be539850338ccdd8af87839e0b4d83f01e7
Reviewed-on: https://gerrit.libreoffice.org/46856
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/config_host/config_langs.h.in b/config_host/config_langs.h.in
new file mode 100644
index ..d60a5c168420
--- /dev/null
+++ b/config_host/config_langs.h.in
@@ -0,0 +1,10 @@
+/* Configuration of restriction on supported ui languages, by the
+ * --with-lang option.
+ */
+
+#ifndef CONFIG_LANGS_H
+#define CONFIG_LANGS_H
+
+#define WITH_LANG ""
+
+#endif
diff --git a/config_host/config_vendor.h.in b/config_host/config_vendor.h.in
new file mode 100644
index ..32602210c36b
--- /dev/null
+++ b/config_host/config_vendor.h.in
@@ -0,0 +1,10 @@
+/* Configuration of restriction on supported ui languages, by the
+ * --with-lang option.
+ */
+
+#ifndef CONFIG_VENDOR_H
+#define CONFIG_VENDOR_H
+
+#define OOO_VENDOR ""
+
+#endif
diff --git a/configure.ac b/configure.ac
index f3bd86698cda..f0eb940fbae2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -11710,6 +11710,7 @@ if test "$enable_release_build" = "" -o 
"$enable_release_build" = "no"; then
 ALL_LANGS=`echo $ALL_LANGS qtz`
 fi
 AC_SUBST(ALL_LANGS)
+AC_DEFINE_UNQUOTED(WITH_LANG,"$WITH_LANG")
 AC_SUBST(WITH_LANG)
 AC_SUBST(WITH_LANG_LIST)
 AC_SUBST(GIT_NEEDED_SUBMODULES)
@@ -11858,6 +11859,7 @@ else
 OOO_VENDOR="$with_vendor"
 AC_MSG_RESULT([$OOO_VENDOR])
 fi
+AC_DEFINE_UNQUOTED(OOO_VENDOR,"$OOO_VENDOR")
 AC_SUBST(OOO_VENDOR)
 
 if test "$_os" = "Android" ; then
@@ -12471,6 +12473,7 @@ AC_CONFIG_HEADERS([config_host/config_gio.h])
 AC_CONFIG_HEADERS([config_host/config_global.h])
 AC_CONFIG_HEADERS([config_host/config_gpgme.h])
 AC_CONFIG_HEADERS([config_host/config_java.h])
+AC_CONFIG_HEADERS([config_host/config_langs.h])
 AC_CONFIG_HEADERS([config_host/config_lgpl.h])
 AC_CONFIG_HEADERS([config_host/config_libcxx.h])
 AC_CONFIG_HEADERS([config_host/config_liblangtag.h])
@@ -12483,6 +12486,7 @@ AC_CONFIG_HEADERS([config_host/config_options.h])
 AC_CONFIG_HEADERS([config_host/config_options_calc.h])
 AC_CONFIG_HEADERS([config_host/config_test.h])
 AC_CONFIG_HEADERS([config_host/config_typesizes.h])
+AC_CONFIG_HEADERS([config_host/config_vendor.h])
 AC_CONFIG_HEADERS([config_host/config_vcl.h])
 AC_CONFIG_HEADERS([config_host/config_vclplug.h])
 AC_CONFIG_HEADERS([config_host/config_version.h])
diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx
index 1c90931c7afb..7965179fa72d 100644
--- a/cui/source/options/optgdlg.cxx
+++ b/cui/source/options/optgdlg.cxx
@@ -21,6 +21,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1122,7

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2017-12-22 Thread Caolán McNamara

 vcl/inc/unx/fontmanager.hxx |6 -
 vcl/unx/generic/fontmanager/fontconfig.cxx  |   88 +++-
 vcl/unx/generic/fontmanager/fontmanager.cxx |2 
 3 files changed, 12 insertions(+), 84 deletions(-)

New commits:
commit 91d361604781f92640c9727add1e08cde854037e
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 22 11:22:56 2017 +

use SyncDbusSessionHelper for font install requests

don't need to have two implementations here and
can reduce ifdef forest

Change-Id: I972159ece9cce417aefd5ec4acf5ba5d1d08317b
Reviewed-on: https://gerrit.libreoffice.org/46968
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/vcl/inc/unx/fontmanager.hxx b/vcl/inc/unx/fontmanager.hxx
index 962f3186fbfb..8b791722b4a8 100644
--- a/vcl/inc/unx/fontmanager.hxx
+++ b/vcl/inc/unx/fontmanager.hxx
@@ -192,14 +192,10 @@ class VCL_PLUGIN_PUBLIC PrintFontManager
 static void addFontconfigDir(const OString& rDirectory);
 
 std::set m_aPreviousLangSupportRequests;
-#if ENABLE_GIO
-std::vector m_aCurrentRequests;
-#endif
+std::vector m_aCurrentRequests;
 Timer m_aFontInstallerTimer;
 
-#if ENABLE_GIO
 DECL_LINK( autoInstallFontLangSupport, Timer*, void );
-#endif
 PrintFontManager();
 public:
 ~PrintFontManager();
diff --git a/vcl/unx/generic/fontmanager/fontconfig.cxx 
b/vcl/unx/generic/fontmanager/fontconfig.cxx
index 1cff42cd1f44..94c80cc6cf8f 100644
--- a/vcl/unx/generic/fontmanager/fontconfig.cxx
+++ b/vcl/unx/generic/fontmanager/fontconfig.cxx
@@ -20,6 +20,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -31,8 +32,8 @@
 #include 
 #include 
 #include 
-#include 
 #include 
+#include 
 
 using namespace psp;
 
@@ -40,10 +41,6 @@ using namespace psp;
 #include 
 #include 
 
-#if ENABLE_GIO
-#include 
-#endif
-
 #include 
 #include 
 
@@ -863,97 +860,36 @@ namespace
 return OStringToOUString(aBuf.makeStringAndClear(), 
RTL_TEXTENCODING_UTF8);
 }
 
-#if ENABLE_GIO
-guint get_xid_for_dbus()
+sal_uInt32 get_xid_for_dbus()
 {
-if (Application::IsHeadlessModeEnabled())
-return 0;
 const vcl::Window *pTopWindow = Application::GetActiveTopWindow();
 if (!pTopWindow)
 pTopWindow = Application::GetFirstTopLevelWindow();
 const SystemEnvData* pEnvData = pTopWindow ? 
pTopWindow->GetSystemData() : nullptr;
 return pEnvData ? GetDbusId(*pEnvData) : 0;
 }
-#endif
 }
 
-#if ENABLE_GIO
 IMPL_LINK_NOARG(PrintFontManager, autoInstallFontLangSupport, Timer *, void)
 {
-if (!officecfg::Office::Common::PackageKit::EnableFontInstallation::get())
-return;
-
-guint xid = get_xid_for_dbus();
-
-if (!xid)
-{
-SAL_WARN("vcl", "Could not retrieve X Window ID for DBUS");
-return;
-}
-
-
-GError *error = nullptr;
-/* get the DBUS session connection */
-GDBusConnection *session_connection = g_bus_get_sync(G_BUS_TYPE_SESSION, 
nullptr, );
-if (error != nullptr)
+try
 {
-g_debug ("DBUS cannot connect : %s", error->message);
-g_error_free (error);
-return;
-}
-
-/* get the proxy with gnome-session-manager */
-GDBusProxy *proxy = g_dbus_proxy_new_sync(session_connection,
-  G_DBUS_PROXY_FLAGS_NONE,
-  nullptr, // GDBusInterfaceInfo
-  "org.freedesktop.PackageKit",
-  "/org/freedesktop/PackageKit",
-  
"org.freedesktop.PackageKit.Modify",
-  nullptr, // GCancellable
-  );
-if (proxy == nullptr && error != nullptr)
-{
-g_debug("Could not get DBUS proxy: org.freedesktop.PackageKit: %s", 
error->message);
-g_error_free(error);
-return;
+using namespace org::freedesktop::PackageKit;
+css::uno::Reference 
xSyncDbusSessionHelper(SyncDbusSessionHelper::create(comphelper::getProcessComponentContext()));
+xSyncDbusSessionHelper->InstallFontconfigResources(get_xid_for_dbus(), 
comphelper::containerToSequence(m_aCurrentRequests), "hide-finished");
 }
-
-GVariantBuilder *builder = g_variant_builder_new (G_VARIANT_TYPE("as")); 
// 'as'=array of strings
-for (std::vector::const_iterator aI = m_aCurrentRequests.begin(); 
aI != m_aCurrentRequests.end(); ++aI)
-g_variant_builder_add (builder, "s", aI->getStr());
-
-GVariant *res = g_dbus_proxy_call_sync(proxy,
- "InstallFontconfigResources",
- // Create a new variant with the 
following types:
-

[Libreoffice-commits] core.git: sw/source

2017-12-22 Thread Caolán McNamara

 sw/source/ui/frmdlg/wrap.cxx   |   29 +++
 sw/source/ui/table/tabledlg.cxx|   71 ++---
 sw/source/uibase/inc/prcntfld.hxx  |4 +-
 sw/source/uibase/inc/wrap.hxx  |3 +
 sw/source/uibase/table/tablepg.hxx |7 ++-
 5 files changed, 92 insertions(+), 22 deletions(-)

New commits:
commit 12e788f1102d15df9af311c77df77d64263d22fc
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 22 10:35:31 2017 +

Resolves: tdf#114572 immediate update of value while typing unwanted

Revert "connect to modified instead of up/down/focus-lost"

This reverts commit 44bfe8fad4f7c263dc713a65fb2ab0e2f9afcf99

Revert "listening to modify is sufficient to get all changes"

This reverts commit 5c0bb1088a678d36309866c4eee43e58901f6b7b

we probably need to distinguish a modify vs update signal to
get what I wanted here. Back to the original mode for now.

Change-Id: I51ebfc96b3a06cf09905f4a311d526f23ce371f1
Reviewed-on: https://gerrit.libreoffice.org/46958
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sw/source/ui/frmdlg/wrap.cxx b/sw/source/ui/frmdlg/wrap.cxx
index 5a9db97e8cee..21f07d980816 100644
--- a/sw/source/ui/frmdlg/wrap.cxx
+++ b/sw/source/ui/frmdlg/wrap.cxx
@@ -90,11 +90,23 @@ SwWrapTabPage::SwWrapTabPage(vcl::Window *pParent, const 
SfxItemSet )
 
 SetExchangeSupport();
 
-Link aLk = LINK(this, SwWrapTabPage, RangeModifyHdl);
-m_pLeftMarginED->SetModifyHdl(aLk);
-m_pRightMarginED->SetModifyHdl(aLk);
-m_pTopMarginED->SetModifyHdl(aLk);
-m_pBottomMarginED->SetModifyHdl(aLk);
+Link aLk = LINK(this, SwWrapTabPage, RangeModifyHdl);
+Link aLk3 = LINK(this, SwWrapTabPage, RangeLoseFocusHdl);
+m_pLeftMarginED->SetUpHdl(aLk);
+m_pLeftMarginED->SetDownHdl(aLk);
+m_pLeftMarginED->SetLoseFocusHdl(aLk3);
+
+m_pRightMarginED->SetUpHdl(aLk);
+m_pRightMarginED->SetDownHdl(aLk);
+m_pRightMarginED->SetLoseFocusHdl(aLk3);
+
+m_pTopMarginED->SetUpHdl(aLk);
+m_pTopMarginED->SetDownHdl(aLk);
+m_pTopMarginED->SetLoseFocusHdl(aLk3);
+
+m_pBottomMarginED->SetUpHdl(aLk);
+m_pBottomMarginED->SetDownHdl(aLk);
+m_pBottomMarginED->SetLoseFocusHdl(aLk3);
 
 Link aLk2 = LINK(this, SwWrapTabPage, WrapTypeHdl);
 m_pNoWrapRB->SetClickHdl(aLk2);
@@ -552,7 +564,12 @@ DeactivateRC SwWrapTabPage::DeactivatePage(SfxItemSet* 
_pSet)
 return DeactivateRC::LeavePage;
 }
 
-IMPL_LINK( SwWrapTabPage, RangeModifyHdl, Edit&, rSpin, void )
+// range check
+IMPL_LINK( SwWrapTabPage, RangeLoseFocusHdl, Control&, rControl, void )
+{
+RangeModifyHdl( static_cast(rControl) );
+}
+IMPL_LINK( SwWrapTabPage, RangeModifyHdl, SpinField&, rSpin, void )
 {
 MetricField& rEdit = static_cast(rSpin);
 sal_Int64 nValue = rEdit.GetValue();
diff --git a/sw/source/ui/table/tabledlg.cxx b/sw/source/ui/table/tabledlg.cxx
index 366e42f01fed..60a181468fef 100644
--- a/sw/source/ui/table/tabledlg.cxx
+++ b/sw/source/ui/table/tabledlg.cxx
@@ -149,12 +149,25 @@ void  SwFormatTablePage::Init()
 m_pRightBtn->SetClickHdl( aLk2 );
 m_pCenterBtn->SetClickHdl( aLk2 );
 
-Link aLk = LINK(this, SwFormatTablePage, UpDownHdl);
-m_pTopMF->SetModifyHdl(aLk);
-m_pBottomMF->SetModifyHdl(aLk);
-m_aRightMF.SetModifyHdl(aLk);
-m_aLeftMF.SetModifyHdl(aLk);
-m_aWidthMF.SetModifyHdl(aLk);
+Link aLk = LINK( this, SwFormatTablePage, UpDownHdl );
+m_pTopMF->SetUpHdl( aLk );
+m_pBottomMF->SetUpHdl( aLk );
+m_aRightMF.SetUpHdl( aLk );
+m_aLeftMF.SetUpHdl( aLk );
+m_aWidthMF.SetUpHdl( aLk );
+
+m_pTopMF->SetDownHdl( aLk );
+m_pBottomMF->SetDownHdl( aLk );
+m_aRightMF.SetDownHdl( aLk );
+m_aLeftMF.SetDownHdl( aLk );
+m_aWidthMF.SetDownHdl( aLk );
+
+Link aLk3 = LINK( this, SwFormatTablePage, LoseFocusHdl );
+m_pTopMF->SetLoseFocusHdl( aLk3 );
+m_pBottomMF->SetLoseFocusHdl( aLk3 );
+m_aRightMF.SetLoseFocusHdl( aLk3 );
+m_aLeftMF.SetLoseFocusHdl( aLk3 );
+m_aWidthMF.SetLoseFocusHdl( aLk3 );
 
 m_pRelWidthCB->SetClickHdl(LINK( this, SwFormatTablePage, RelWidthClickHdl 
));
 }
@@ -275,7 +288,11 @@ void SwFormatTablePage::RightModify()
 }
 }
 
-IMPL_LINK( SwFormatTablePage, UpDownHdl, Edit&, rEdit, void )
+IMPL_LINK( SwFormatTablePage, LoseFocusHdl, Control&, rControl, void )
+{
+UpDownHdl(static_cast(rControl));
+}
+IMPL_LINK( SwFormatTablePage, UpDownHdl, SpinField&, rEdit, void )
 {
 if( m_aRightMF.get() == )
 RightModify();
@@ -578,6 +595,7 @@ void  SwFormatTablePage::Reset( const SfxItemSet* )
 m_aRightMF.SetMax( m_aRightMF.NormalizePercent( pTableData->GetSpace() ), 
FUNIT_TWIP );

[Libreoffice-commits] core.git: shell/source

2017-12-22 Thread Caolán McNamara

 shell/source/sessioninstall/SyncDbusSessionHelper.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 054dac27e0b33789bbb3ca444ae22ab4b157f998
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 22 11:01:14 2017 +

call g_variant_unref on return value

Change-Id: If8f0e443738060f51c8822783558ea14fb34b8ce
Reviewed-on: https://gerrit.libreoffice.org/46962
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/shell/source/sessioninstall/SyncDbusSessionHelper.cxx 
b/shell/source/sessioninstall/SyncDbusSessionHelper.cxx
index ce3cb8aefca0..4092d146f7c2 100644
--- a/shell/source/sessioninstall/SyncDbusSessionHelper.cxx
+++ b/shell/source/sessioninstall/SyncDbusSessionHelper.cxx
@@ -18,7 +18,7 @@ using namespace ::com::sun::star::uno;
 
 namespace
 {
-struct GVariantDeleter { void operator()(GVariant* pV) { 
g_variant_unref(pV); } };
+struct GVariantDeleter { void operator()(GVariant* pV) { if (pV) 
g_variant_unref(pV); } };
 struct GVariantBuilderDeleter { void operator()(GVariantBuilder* pVB) { 
g_variant_builder_unref(pVB); } };
 template  struct GObjectDeleter { void operator()(T* pO) { 
g_object_unref(pO); } };
 class GErrorWrapper
@@ -72,12 +72,12 @@ void request(
 std::shared_ptr proxy(
 lcl_GetPackageKitProxy("Modify"), GObjectDeleter());
 GErrorWrapper error;
-g_dbus_proxy_call_sync(
+std::shared_ptr result(g_dbus_proxy_call_sync(
 proxy.get(), method,
 g_variant_new(
 "(uass)", static_cast(xid), builder.get(),
 iactUtf8.getStr()),
-G_DBUS_CALL_FLAGS_NONE, -1, nullptr, ());
+G_DBUS_CALL_FLAGS_NONE, -1, nullptr, ()), 
GVariantDeleter());
 }
 
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: filter/source

2017-12-22 Thread Caolán McNamara

 filter/source/graphicfilter/icgm/actimpr.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit e39245e2c5000241078a557d3b49da254da7effd
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 22 09:18:30 2017 +

ofz#4715 Integer-overflow

Change-Id: I0ad24024db97e5e0aa9bed0d52f72f6fb6590513
Reviewed-on: https://gerrit.libreoffice.org/46954
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/filter/source/graphicfilter/icgm/actimpr.cxx 
b/filter/source/graphicfilter/icgm/actimpr.cxx
index 9a0762905bab..7c382906fe0c 100644
--- a/filter/source/graphicfilter/icgm/actimpr.cxx
+++ b/filter/source/graphicfilter/icgm/actimpr.cxx
@@ -20,6 +20,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -719,14 +720,14 @@ void CGMImpressOutAct::DrawText( awt::Point const & 
rTextPos, awt::Size const &
 {
 case TAV_HALF :
 {
-aTextPos.Y -= static_cast( ( 
mpCGM->pElement->nCharacterHeight * 1.5 ) / 2 );
+aTextPos.Y = o3tl::saturating_add(aTextPos.X, 
static_cast((mpCGM->pElement->nCharacterHeight * -1.5) / 2));
 }
 break;
 
 case TAV_BASE :
 case TAV_BOTTOM :
 case TAV_NORMAL :
-aTextPos.Y -= static_cast( 
mpCGM->pElement->nCharacterHeight * 1.5 );
+aTextPos.Y = o3tl::saturating_add(aTextPos.Y, 
static_cast(mpCGM->pElement->nCharacterHeight * -1.5));
 break;
 case TAV_TOP :
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114643] Writer: Formatting - keep paragraph with previous paragraph

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114643

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||rb.hensc...@t-online.de
 Resolution|--- |DUPLICATE

--- Comment #1 from Regina Henschel  ---
We need only one issue for this request.

*** This bug has been marked as a duplicate of bug 64795 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2017-12-22 Thread Caolán McNamara

 sc/source/ui/inc/undobase.hxx  |1 -
 sc/source/ui/inc/undocell.hxx  |2 --
 sc/source/ui/undo/undobase.cxx |4 
 sc/source/ui/undo/undocell.cxx |2 --
 4 files changed, 9 deletions(-)

New commits:
commit 5f4a49d7bc489b5e0b5ab1cd10f5c0bde7f5fee4
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 22 10:48:12 2017 +

can just use default dtors

Change-Id: I4f8974876df033f68f7207dfd66526e7af10a6b3
Reviewed-on: https://gerrit.libreoffice.org/46960
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sc/source/ui/inc/undobase.hxx b/sc/source/ui/inc/undobase.hxx
index 9ef3a08171b5..6fa0fbd7a9e2 100644
--- a/sc/source/ui/inc/undobase.hxx
+++ b/sc/source/ui/inc/undobase.hxx
@@ -43,7 +43,6 @@ public:
 typedef std::map DataSpansType;
 
 ScSimpleUndo( ScDocShell* pDocSh );
-virtual ~ScSimpleUndo() override;
 
 virtual boolMerge( SfxUndoAction *pNextAction ) override;
 /// See SfxUndoAction::GetViewShellId().
diff --git a/sc/source/ui/inc/undocell.hxx b/sc/source/ui/inc/undocell.hxx
index e1e45e2e1f46..cbdd78a7c4b9 100644
--- a/sc/source/ui/inc/undocell.hxx
+++ b/sc/source/ui/inc/undocell.hxx
@@ -96,8 +96,6 @@ public:
 ScDocShell* pNewDocShell, const ScAddress& rPos,
 ValuesType& rOldValues, const OUString& rNewStr, EditTextObject* pObj 
);
 
-virtual ~ScUndoEnterData() override;
-
 virtual voidUndo() override;
 virtual voidRedo() override;
 virtual voidRepeat(SfxRepeatTarget& rTarget) override;
diff --git a/sc/source/ui/undo/undobase.cxx b/sc/source/ui/undo/undobase.cxx
index e69a2c81397b..6198c87c7c7a 100644
--- a/sc/source/ui/undo/undobase.cxx
+++ b/sc/source/ui/undo/undobase.cxx
@@ -49,10 +49,6 @@ ViewShellId ScSimpleUndo::GetViewShellId() const
 return mnViewShellId;
 }
 
-ScSimpleUndo::~ScSimpleUndo()
-{
-}
-
 bool ScSimpleUndo::SetViewMarkData( const ScMarkData& rMarkData )
 {
 if ( IsPaintLocked() )
diff --git a/sc/source/ui/undo/undocell.cxx b/sc/source/ui/undo/undocell.cxx
index c93051a4aa49..13314009be56 100644
--- a/sc/source/ui/undo/undocell.cxx
+++ b/sc/source/ui/undo/undocell.cxx
@@ -177,8 +177,6 @@ ScUndoEnterData::ScUndoEnterData(
 SetChangeTrack();
 }
 
-ScUndoEnterData::~ScUndoEnterData() {}
-
 OUString ScUndoEnterData::GetComment() const
 {
 return ScGlobal::GetRscString( STR_UNDO_ENTERDATA ); // "Input"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 64795] [FORMATTING] Add new feature of 'keep with previous paragraph' formatting option for Writer

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=64795

Regina Henschel  changed:

   What|Removed |Added

 CC||mike.saps...@gmail.com

--- Comment #5 from Regina Henschel  ---
*** Bug 114643 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82632] Add bibisectRequest to Regressions

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=82632

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu,
   ||xiscofa...@libreoffice.org

--- Comment #4 from Aron Budea  ---
Xisco, is this relevant? I believe it's something you've been taking care of
using your BZ scripts.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114655] New: [MacOS] Can't open Preferences : LibreOffice 6.0 RC1 crash every time.

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114655

Bug ID: 114655
   Summary: [MacOS] Can't open Preferences : LibreOffice 6.0 RC1
crash every time.
   Product: LibreOffice
   Version: 6.0.0.1 rc
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 1claudechampa...@gmail.com

Description:
Like the title says. 

It did not happen with the beta 2 of LibreOffice 6

Steps to Reproduce:
1.Select Preferences
2.Click
3.Crash

Actual Results:  
Crash. 

Expected Results:
No crash!


Reproducible: Always


User Profile Reset: Yes



Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:57.0)
Gecko/20100101 Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102359] Table Format: Add option "Keep with previous paragraph"

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102359

Dieter Praas  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4643

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114643] Writer: Formatting - keep paragraph with previous paragraph

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114643

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2359

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114647] Presentation: multiple animated gifs consumes CPU causing hang

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114647

Jacques Guilleron  changed:

   What|Removed |Added

 CC||guillero...@aol.com

--- Comment #5 from Jacques Guilleron  ---
Hi Dwokfur, Telesto,

Same results as Telesto with
LO 5.0.6.3 Build ID: 490fc03b25318460cfc54456516ea2519c11d1aa
Locale : fr-FR (fr_FR)
and 
LO 5.0.0.1 Build ID: 9a0b23dd0ab9652e0965484934309f2d49a7758e
Locale : fr-FR (fr_FR)
with and without OpenGL.
under Windows 7.
also with
LO  6.0.0.0.beta1 Build ID: 97471ab4eb4db4c487195658631696bb3238656c
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
Since LO 5.3 release, you can experiment a "Resart in Safe Mode..." in Help
menu.
This allows you to see if some settings or extensions are involved in your
issue by restarting LO temporarily without this features.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114654] New: lode: help2man: can't get `--help' info from automake-1.14

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114654

Bug ID: 114654
   Summary: lode: help2man: can't get `--help' info from
automake-1.14
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: critical
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yuriko...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - sw/qa sw/source

2017-12-22 Thread Serge Krot

 sw/qa/extras/uiwriter/data/tdf113877_insert_numbered_list.odt |binary
 sw/qa/extras/uiwriter/uiwriter.cxx|   28 +++
 sw/source/filter/xml/xmlimp.cxx   |   85 ++
 3 files changed, 113 insertions(+)

New commits:
commit c59e028e5337d1511dbcc678a90ffdbe92a44521
Author: Serge Krot 
Date:   Fri Dec 22 12:56:40 2017 +0100

tdf#113877 Insert document: merge two list into one

When inserting a new document into current position we need to
concat to lists into one.

Added unit tests.

Change-Id: I10689256e0ffc5cf93722b1d45f09f610211b14a
Reviewed-on: https://gerrit.libreoffice.org/46991
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/sw/qa/extras/uiwriter/data/tdf113877_insert_numbered_list.odt 
b/sw/qa/extras/uiwriter/data/tdf113877_insert_numbered_list.odt
new file mode 100755
index ..db480edbebaf
Binary files /dev/null and 
b/sw/qa/extras/uiwriter/data/tdf113877_insert_numbered_list.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index afdd8aee20dc..39190dffc906 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -207,6 +207,7 @@ public:
 void testTdf105417();
 void testTdf112025();
 void testTdf114306();
+void testTdf113877();
 
 CPPUNIT_TEST_SUITE(SwUiWriterTest);
 CPPUNIT_TEST(testReplaceForward);
@@ -313,6 +314,7 @@ public:
 CPPUNIT_TEST(testTdf105417);
 CPPUNIT_TEST(testTdf112025);
 CPPUNIT_TEST(testTdf114306);
+CPPUNIT_TEST(testTdf113877);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -3812,6 +3814,32 @@ void SwUiWriterTest::testTdf114306()
 xmlXPathFreeObject(pXmlObj);
 }
 
+void SwUiWriterTest::testTdf113877()
+{
+load(DATA_DIRECTORY, "tdf113877_insert_numbered_list.odt");
+
+// set a page cursor into the end of the document
+uno::Reference xModel(mxComponent, uno::UNO_QUERY);
+uno::Reference 
xTextViewCursorSupplier(xModel->getCurrentController(), uno::UNO_QUERY);
+uno::Reference 
xCursor(xTextViewCursorSupplier->getViewCursor(), uno::UNO_QUERY);
+xCursor->jumpToEndOfPage();
+
+// insert the same document at current cursor position
+{
+const OUString insertFileid = 
m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"tdf113877_insert_numbered_list.odt";
+uno::Sequence 
aPropertyValues(comphelper::InitPropertySequence({ { "Name", 
uno::makeAny(insertFileid) } }));
+lcl_dispatchCommand(mxComponent, ".uno:InsertDoc", aPropertyValues);
+}
+
+// the initial list with 4 list items
+CPPUNIT_ASSERT_EQUAL(getProperty(getParagraph(1), "ListId"), 
getProperty(getParagraph(4), "ListId"));
+
+// the last of the first list, and the first of the inserted list
+CPPUNIT_ASSERT_EQUAL(getProperty(getParagraph(4), "ListId"), 
getProperty(getParagraph(5), "ListId"));
+CPPUNIT_ASSERT_EQUAL(getProperty(getParagraph(5), "ListId"), 
getProperty(getParagraph(6), "ListId"));
+CPPUNIT_ASSERT_EQUAL(getProperty(getParagraph(6), "ListId"), 
getProperty(getParagraph(7), "ListId"));
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(SwUiWriterTest);
 CPPUNIT_PLUGIN_IMPLEMENT();
 
diff --git a/sw/source/filter/xml/xmlimp.cxx b/sw/source/filter/xml/xmlimp.cxx
index 8ee58ceb6bfc..824d9aa6b488 100644
--- a/sw/source/filter/xml/xmlimp.cxx
+++ b/sw/source/filter/xml/xmlimp.cxx
@@ -843,6 +843,91 @@ void SwXMLImport::endDocument()
 pPaM->Move( fnMoveBackward );
 }
 }
+
+// tdf#113877
+// when we insert one document with list inside into another one 
with list at the insert position,
+// the resulting numbering in these lists are not consequent.
+//
+// Main document:
+//  1. One
+//  2. Two
+//  3. Three
+//  4.  <-- insert position
+//
+// Inserted document:
+//  1. One
+//  2. Two
+//  3. Three
+//  4.
+//
+// Expected result
+//  1. One
+//  2. Two
+//  3. Three
+//  4. One
+//  5. Two
+//  6. Three
+//  7.
+//
+if (IsInsertMode() && m_pSttNdIdx->GetIndex())
+{
+sal_uLong index = 1;
+
+// the last node of the main document where we have inserted a 
document
+SwNode * p1 = pDoc->GetNodes()[m_pSttNdIdx->GetIndex() + 0];
+
+// the first node of the inserted document
+SwNode * p2 = pDoc->GetNodes()[m_pSttNdIdx->GetIndex() + 
index];
+
+// the first node of the inserted document,
+// which will be used to detect if inside inserted document a

[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - chart2/inc chart2/source offapi/com offapi/UnoApi_offapi.mk sc/inc sc/source

2017-12-22 Thread Vasily Melenchuk

Rebased ref, commits from common ancestor:
commit 5a8c4244d33ad257d4cd81b40c612ff294015492
Author: Vasily Melenchuk 
Date:   Fri Nov 10 18:37:25 2017 +0300

tdf#113572: allow switching to data range in copypasted chart

- enable data range toolbar button for charts with internal
  data table and possiblilty to switch to data range
- show warning before destoying data table
- recreation of data provider

Conflicts:
chart2/inc/ChartModel.hxx
chart2/inc/strings.hrc
chart2/source/controller/main/ChartController.cxx
chart2/source/controller/main/ControllerCommandDispatch.cxx
sc/source/ui/unoobj/docuno.cxx

Change-Id: I46c703b579cd32405b02543aa5b9e3a74e4b36b6
Reviewed-on: https://gerrit.libreoffice.org/46981
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/chart2/inc/ChartModel.hxx b/chart2/inc/ChartModel.hxx
index b3caaad412c4..f254103e961f 100644
--- a/chart2/inc/ChartModel.hxx
+++ b/chart2/inc/ChartModel.hxx
@@ -579,6 +579,8 @@ public:
 void getNextTimePoint();
 void setTimeBasedRange(sal_Int32 nStart, sal_Int32 nEnd);
 
+void removeDataProviders();
+
 OpenGLWindow* getOpenGLWindow() { return mpOpenGLWindow;}
 
 private:
diff --git a/chart2/source/controller/dialogs/Strings.src 
b/chart2/source/controller/dialogs/Strings.src
index c9d18eb62391..96f7f5598b2a 100644
--- a/chart2/source/controller/dialogs/Strings.src
+++ b/chart2/source/controller/dialogs/Strings.src
@@ -34,6 +34,11 @@ String STR_DLG_STEPPED_LINE_PROPERTIES
 Text [ en-US ] = "Stepped Lines" ;
 };
 
+String STR_DLG_REMOVE_DATA_TABLE
+{
+Text [ en-US ] = "Do you want to delete data table and switch to data 
ranges?" ;
+};
+
 String STR_PAGE_CHARTTYPE
 {
 Text [ en-US ] = "Chart Type" ;
diff --git a/chart2/source/controller/main/ChartController.cxx 
b/chart2/source/controller/main/ChartController.cxx
index 8482c16a6513..f87f5c74f798 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -66,12 +66,14 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -1395,21 +1397,56 @@ void ChartController::executeDispatch_SourceData()
 //convert properties to ItemSet
 uno::Reference< XChartDocument >   xChartDoc( getModel(), uno::UNO_QUERY );
 OSL_ENSURE( xChartDoc.is(), "Invalid XChartDocument" );
-if( !xChartDoc.is())
+if( !xChartDoc.is() )
 return;
 
-UndoLiveUpdateGuard aUndoGuard = UndoLiveUpdateGuard(
-SCH_RESSTR(STR_ACTION_EDIT_DATA_RANGES), m_xUndoManager );
-if( xChartDoc.is())
+// If there is a data table we should ask user if we really want to 
destroy it
+// and switch to data ranges.
+ChartModel& rModel = dynamic_cast(*xChartDoc.get());
+if ( rModel.hasInternalDataProvider() )
 {
+// Check if we will able to create data provider later
+Reference< lang::XServiceInfo > xParentServiceInfo( 
rModel.getParent(), uno::UNO_QUERY );
+if ( !xParentServiceInfo.is() || 
!xParentServiceInfo->supportsService("com.sun.star.chart2.XDataProviderCreator")
 )
+return;
+
 SolarMutexGuard aSolarGuard;
-ScopedVclPtrInstance< ::chart::DataSourceDialog > aDlg( 
m_pChartWindow, xChartDoc, m_xCC );
-if( aDlg->Execute() == RET_OK )
+
+ScopedVclPtrInstance< MessageDialog > aQueryBox( m_pChartWindow, 
SchResId( STR_DLG_REMOVE_DATA_TABLE ), VCL_MESSAGE_QUESTION, 
VCL_BUTTONS_YES_NO);
+
+// If "No" then just return
+if (aQueryBox->Execute() == RET_NO)
+return;
+
+// Remove data table
+rModel.removeDataProviders();
+
+// Ask parent document to create new data provider
+css::uno::Reference< com::sun::star::chart2::XDataProviderCreator > 
xCreatorDoc(
+rModel.getParent(), uno::UNO_QUERY );
+OSL_ENSURE( xCreatorDoc.is(), "Invalid XDataProviderCreator" );
+
+if ( xCreatorDoc.is() )
 {
-impl_adaptDataSeriesAutoResize();
-aUndoGuard.commit();
+uno::Reference< data::XDataProvider > xDataProvider = 
xCreatorDoc->createDataProvider();
+OSL_ENSURE( xCreatorDoc.is(), "Data provider was not created" );
+if ( xDataProvider.is() )
+{
+rModel.attachDataProvider(xDataProvider);
+}
 }
 }
+
+UndoLiveUpdateGuard aUndoGuard(
+SchResId(STR_ACTION_EDIT_DATA_RANGES), m_xUndoManager);
+
+SolarMutexGuard aSolarGuard;
+ScopedVclPtrInstance< ::chart::DataSourceDialog > aDlg( m_pChartWindow, 
xChartDoc, m_xCC );
+if( aDlg->Execute() == RET_OK )
+{
+impl_adaptDataSeriesAutoResize();
+aUndoGuard.commit();
+}
 }
 
 void

[Libreoffice-bugs] [Bug 114652] Calc unresponsiveness when copying partial text inside cell

2017-12-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114652

Jacques Guilleron  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||guillero...@aol.com
 Resolution|--- |NOTABUG

--- Comment #4 from Jacques Guilleron  ---
Hi Herman, Telesto,

I don't reproduce with
LO 5.4.3.2 Build ID: 92a7159f7e4af62137622921e809f8546db437e5
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
I saw you have updated LO to 5.4.4.2 and do no longer see the issue.
I set status report to NotABug.
Next time you have this kind of issue, try first
Restart in Safe Mode... in Help menu.
This allows to see if some of your settings are involved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: extras/source sfx2/inc

2017-12-22 Thread Laurent BP

 extras/source/templates/officorr/Modern_business_letter_sans_serif.ott |binary
 extras/source/templates/officorr/Modern_business_letter_serif.ott  |binary
 extras/source/templates/offimisc/Businesscard-with-logo.ott|binary
 extras/source/templates/personal/CV.ott|binary
 extras/source/templates/personal/Resume1page.ott   |binary
 extras/source/templates/styles/Default.ott |binary
 extras/source/templates/styles/Modern.ott  |binary
 sfx2/inc/strings.hxx   |   12 
+-
 8 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit de14f0487118d8ea15db54d94c44d7bd28833c82
Author: Laurent BP 
Date:   Sat Dec 16 00:17:40 2017 +0100

tdf#114088 tdf#113795 Improve Writer templates

Main topic was to add Title in meta.xml to get names of templates localized
Additionnal improvements:
Businesscard-with-logo
  - set Title in meta.xml
  - remove configuration2 (update manifest.xml)
  - remove unused font
  - remove user defined styles
  - insert field Name instead of Name
  - remove language dependant information
  - links that need to be updated at the begining

Modern business letter serif
  - remove configuration2 and settings.xml (update manifest.xml)
  - remove language dependant information

Modern_business_letter_sans_serif
  - replace Open Sans font with Noto Sans
  - remove unused font
  - remove configuration2 and settings.xml (update manifest.xml)
  - remove language dependant information

CV
  - set Title in meta.xml
  - remove unused font
  - remove configuration2 and settings.xml (update manifest.xml)
  - remove language dependant information

Resume
  - remove unused font
  - remove configuration2 and settings.xml (update manifest.xml)
  - remove language dependant information
  - ODF validator does not accept 0in as first value of 
style:border-line-width-bottom, but seems valid in ODF 1.2

http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#property-style_border-line-width-bottom

Default
   - set Title in meta.xml
   - add thumbnail.png (update manifest.xml)
   - remove language dependant information

Modern
   - set Title in meta.xml
   - add thumbnail.png (update manifest.xml)
   - remove language dependant information

Synchronize Templates names in strings.hxx

Change-Id: I417c8398b0002a26e2f84d7efdaeddc0576f9a8c
Reviewed-on: https://gerrit.libreoffice.org/46580
Tested-by: Jenkins 
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git 
a/extras/source/templates/officorr/Modern_business_letter_sans_serif.ott 
b/extras/source/templates/officorr/Modern_business_letter_sans_serif.ott
index f8fbc40b6517..26571ee27137 100644
Binary files 
a/extras/source/templates/officorr/Modern_business_letter_sans_serif.ott and 
b/extras/source/templates/officorr/Modern_business_letter_sans_serif.ott differ
diff --git a/extras/source/templates/officorr/Modern_business_letter_serif.ott 
b/extras/source/templates/officorr/Modern_business_letter_serif.ott
index db218f304581..ce6819f02d68 100644
Binary files 
a/extras/source/templates/officorr/Modern_business_letter_serif.ott and 
b/extras/source/templates/officorr/Modern_business_letter_serif.ott differ
diff --git a/extras/source/templates/offimisc/Businesscard-with-logo.ott 
b/extras/source/templates/offimisc/Businesscard-with-logo.ott
index af3cd607b2b8..3ff8b3528980 100644
Binary files a/extras/source/templates/offimisc/Businesscard-with-logo.ott and 
b/extras/source/templates/offimisc/Businesscard-with-logo.ott differ
diff --git a/extras/source/templates/personal/CV.ott 
b/extras/source/templates/personal/CV.ott
index b622dc129837..203265be4c81 100644
Binary files a/extras/source/templates/personal/CV.ott and 
b/extras/source/templates/personal/CV.ott differ
diff --git a/extras/source/templates/personal/Resume1page.ott 
b/extras/source/templates/personal/Resume1page.ott
index 7e9240d5b52b..166d6045102b 100644
Binary files a/extras/source/templates/personal/Resume1page.ott and 
b/extras/source/templates/personal/Resume1page.ott differ
diff --git a/extras/source/templates/styles/Default.ott 
b/extras/source/templates/styles/Default.ott
index 29cdda6d1d26..a3519c22b37a 100644
Binary files a/extras/source/templates/styles/Default.ott and 
b/extras/source/templates/styles/Default.ott differ
diff --git a/extras/source/templates/styles/Modern.ott 
b/extras/source/templates/styles/Modern.ott
index 922e754c094f..450105994cb3 100644
Binary files a/extras/source/templates/styles/Modern.ott and 
b/extras/source/templates/styles/Modern.ott differ
diff

1 2 3 >

1 - 100 of 231 matches

Mail list logo