date:20171228

[Libreoffice-bugs] [Bug 114363] ToC Index update causes entries to duplicate if ToC created from Outline and Additional heading styles

2017-12-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114363

Timur  changed:

   What|Removed |Added

 Status|REOPENED|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #13 from Timur  ---
Please don't set wrong status yourself. Reopened is where fix doesn't work. 
This one is not confirmed, not only a behavior but a possible fix. You may wait
for a dev or UX to confirm, but cannot do it yourself.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114743] PRINT: angled text does not display

2017-12-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114743

--- Comment #2 from Xavier Van Wijmeersch  ---
can reproduce with

Version: 6.0.0.1.0+
Build ID: 203b913155812706e9be14c5fe2b8f543cc4fdc7
CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group

Version: 6.1.0.0.alpha0+
Build ID: 7f15b7ae482be5994c6803b982c13cbc036a734f
CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group threaded

but not with

Version: 5.4.5.0.0+
Build ID: a61f45499856aad9910d82af1312a163504c15c2
CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/inc sc/source

2017-12-28 Thread Jochen Nitschke

 sc/inc/queryparam.hxx  |6 +--
 sc/source/core/tool/queryparam.cxx |   58 +
 2 files changed, 24 insertions(+), 40 deletions(-)

New commits:
commit db8085636aec89205fdc944ec55ef11645705a97
Author: Jochen Nitschke 
Date:   Thu Dec 28 00:35:41 2017 +0100

simplify copy of ScQueryParam

define copy assignment for ScQueryParamBase and use
default copy implementations for other structs.

Change-Id: Ie384a4f9a3647e8492b4921055df0f2c6bff708e
Reviewed-on: https://gerrit.libreoffice.org/47141
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/queryparam.hxx b/sc/inc/queryparam.hxx
index 0c704789e004..cde359ec7a72 100644
--- a/sc/inc/queryparam.hxx
+++ b/sc/inc/queryparam.hxx
@@ -77,6 +77,7 @@ public:
 protected:
 ScQueryParamBase();
 ScQueryParamBase(const ScQueryParamBase& r);
+ScQueryParamBase& operator=(const ScQueryParamBase& r);
 
 EntriesType m_Entries;
 };
@@ -107,7 +108,6 @@ struct ScQueryParamTable
 SCTAB   nTab;
 
 ScQueryParamTable();
-ScQueryParamTable(const ScQueryParamTable& r);
 virtual ~ScQueryParamTable();
 };
 
@@ -134,11 +134,11 @@ struct SC_DLLPUBLIC ScQueryParam : public 
ScQueryParamBase, public ScQueryParamT
 SCROW   nDestRow;
 
 ScQueryParam();
-ScQueryParam( const ScQueryParam& r );
+ScQueryParam( const ScQueryParam& );
 ScQueryParam( const ScDBQueryParamInternal& r );
 virtual ~ScQueryParam() override;
 
-ScQueryParam&   operator=  ( const ScQueryParam& r );
+ScQueryParam&   operator=  ( const ScQueryParam& );
 booloperator== ( const ScQueryParam& rOther ) const;
 voidClear();
 voidClearDestParams();
diff --git a/sc/source/core/tool/queryparam.cxx 
b/sc/source/core/tool/queryparam.cxx
index 60bf01366886..269eb700bb83 100644
--- a/sc/source/core/tool/queryparam.cxx
+++ b/sc/source/core/tool/queryparam.cxx
@@ -87,6 +87,25 @@ ScQueryParamBase::ScQueryParamBase(const ScQueryParamBase& 
r) :
 }
 }
 
+ScQueryParamBase& ScQueryParamBase::operator=(const ScQueryParamBase& r)
+{
+eSearchType = r.eSearchType;
+bHasHeader  = r.bHasHeader;
+bByRow = r.bByRow;
+bInplace = r.bInplace;
+bCaseSens = r.bCaseSens;
+bDuplicate = r.bDuplicate;
+mbRangeLookup = r.mbRangeLookup;
+
+m_Entries.clear();
+for (auto const& it : r.m_Entries)
+{
+m_Entries.push_back(o3tl::make_unique(*it));
+}
+
+return *this;
+}
+
 ScQueryParamBase::~ScQueryParamBase()
 {
 }
@@ -283,11 +302,6 @@ ScQueryParamTable::ScQueryParamTable() :
 {
 }
 
-ScQueryParamTable::ScQueryParamTable(const ScQueryParamTable& r) :
-nCol1(r.nCol1),nRow1(r.nRow1),nCol2(r.nCol2),nRow2(r.nRow2),nTab(r.nTab)
-{
-}
-
 ScQueryParamTable::~ScQueryParamTable()
 {
 }
@@ -303,12 +317,7 @@ ScQueryParam::ScQueryParam() :
 Clear();
 }
 
-ScQueryParam::ScQueryParam( const ScQueryParam& r ) :
-ScQueryParamBase(r),
-ScQueryParamTable(r),
-bDestPers(r.bDestPers), nDestTab(r.nDestTab), nDestCol(r.nDestCol), 
nDestRow(r.nDestRow)
-{
-}
+ScQueryParam::ScQueryParam( const ScQueryParam& ) = default;
 
 ScQueryParam::ScQueryParam( const ScDBQueryParamInternal& r ) :
 ScQueryParamBase(r),
@@ -349,32 +358,7 @@ void ScQueryParam::ClearDestParams()
 nDestRow = 0;
 }
 
-ScQueryParam& ScQueryParam::operator=( const ScQueryParam& r )
-{
-nCol1   = r.nCol1;
-nRow1   = r.nRow1;
-nCol2   = r.nCol2;
-nRow2   = r.nRow2;
-nTab= r.nTab;
-nDestTab= r.nDestTab;
-nDestCol= r.nDestCol;
-nDestRow= r.nDestRow;
-bHasHeader  = r.bHasHeader;
-bInplace= r.bInplace;
-bCaseSens   = r.bCaseSens;
-eSearchType = r.eSearchType;
-bDuplicate  = r.bDuplicate;
-bByRow  = r.bByRow;
-bDestPers   = r.bDestPers;
-
-m_Entries.clear();
-for (auto const& it : r.m_Entries)
-{
-m_Entries.push_back(o3tl::make_unique(*it));
-}
-
-return *this;
-}
+ScQueryParam& ScQueryParam::operator=( const ScQueryParam& ) = default;
 
 bool ScQueryParam::operator==( const ScQueryParam& rOther ) const
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/svx sc/source svx/inc svx/source

2017-12-28 Thread Noel Grandin

 include/svx/ClassificationField.hxx   |2 +-
 include/svx/EnhancedCustomShapeFunctionParser.hxx |2 +-
 include/svx/colorbox.hxx  |6 +++---
 include/svx/dataaccessdescriptor.hxx  |2 +-
 include/svx/dlgctl3d.hxx  |2 +-
 include/svx/sdr/attribute/sdrformtextattribute.hxx|2 +-
 include/svx/sdrpagewindow.hxx |4 ++--
 include/svx/svdmrkv.hxx   |6 +++---
 include/svx/svdograf.hxx  |4 ++--
 include/svx/svdomedia.hxx |2 +-
 include/svx/svdoole2.hxx  |4 ++--
 include/svx/tbxcolorupdate.hxx|2 +-
 include/svx/unoshape.hxx  |2 +-
 include/svx/xit.hxx   |2 +-
 sc/source/ui/view/gridwin.cxx |2 +-
 svx/inc/galobj.hxx|2 +-
 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx |2 +-
 svx/source/dialog/dlgctl3d.cxx|2 +-
 svx/source/dialog/framelinkarray.cxx  |4 ++--
 svx/source/form/dataaccessdescriptor.cxx  |2 +-
 svx/source/gallery2/galobj.cxx|2 +-
 svx/source/sdr/attribute/sdrformtextattribute.cxx |2 +-
 svx/source/svdraw/sdrpagewindow.cxx   |4 ++--
 svx/source/svdraw/svdograf.cxx|2 +-
 svx/source/svdraw/svdomedia.cxx   |2 +-
 svx/source/svdraw/svdoole2.cxx|4 ++--
 svx/source/svdraw/svdotextdecomposition.cxx   |4 ++--
 svx/source/tbxctrls/tbcontrl.cxx  |2 +-
 svx/source/unodraw/unoshape.cxx   |2 +-
 29 files changed, 40 insertions(+), 40 deletions(-)

New commits:
commit e0eb09405b2f4d95532d37bc37054a51e5a0177b
Author: Noel Grandin 
Date:   Thu Dec 28 19:48:26 2017 +0200

loplugin:passstuffbyref improved return in svx

Change-Id: I33bdbd416709ce46afb3c17aeab0d2e19a68ab30
Reviewed-on: https://gerrit.libreoffice.org/47150
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/ClassificationField.hxx 
b/include/svx/ClassificationField.hxx
index 53989f868fc8..3eb4955dd1f1 100644
--- a/include/svx/ClassificationField.hxx
+++ b/include/svx/ClassificationField.hxx
@@ -44,7 +44,7 @@ public:
 }
 
 /// Returns the text to display, which is the Abbreviated Name, if 
provided, otherwise Name.
-OUString getDisplayText() const
+OUString const & getDisplayText() const
 {
 return !msAbbreviatedName.isEmpty() ? msAbbreviatedName : msName;
 }
diff --git a/include/svx/EnhancedCustomShapeFunctionParser.hxx 
b/include/svx/EnhancedCustomShapeFunctionParser.hxx
index 828a4ef4251b..bc1d97bd5879 100644
--- a/include/svx/EnhancedCustomShapeFunctionParser.hxx
+++ b/include/svx/EnhancedCustomShapeFunctionParser.hxx
@@ -233,7 +233,7 @@ public:
 @return the generated function object.
*/
 
-SVX_DLLPUBLIC static std::shared_ptr parseFunction( const 
OUString& rFunction, const EnhancedCustomShape2d& rCustoShape );
+SVX_DLLPUBLIC static std::shared_ptr const & 
parseFunction( const OUString& rFunction, const EnhancedCustomShape2d& 
rCustoShape );
 
 // this is a singleton
 FunctionParser() = delete;
diff --git a/include/svx/colorbox.hxx b/include/svx/colorbox.hxx
index f9655b28bc27..8ffbc12db77f 100644
--- a/include/svx/colorbox.hxx
+++ b/include/svx/colorbox.hxx
@@ -46,7 +46,7 @@ private:
 void Selected(const NamedColor& rNamedColor);
 void createColorWindow();
 void LockWidthRequest();
-VclPtr getColorWindow() const;
+VclPtr const & getColorWindow() const;
 public:
 SvxColorListBox(vcl::Window* pParent, WinBits nStyle = 0);
 virtual ~SvxColorListBox() override;
@@ -59,8 +59,8 @@ public:
 
 void SetSlotId(sal_uInt16 nSlotId, bool bShowNoneButton = false);
 
-Color GetSelectEntryColor() const { return m_aSelectedColor.first; }
-NamedColor GetSelectedEntry() const { return m_aSelectedColor; }
+Color const & GetSelectEntryColor() const { return m_aSelectedColor.first; 
}
+NamedColor const & GetSelectedEntry() const { return m_aSelectedColor; }
 
 void SelectEntry(const NamedColor& rColor);
 void SelectEntry(const Color& rColor);
diff --git a/include/svx/dataaccessdescriptor.hxx 
b/include/svx/dataaccessdescriptor.hxx
index 4a810a5950f2..e66e96513356 100644
--- a/include/svx/dataaccessdescriptor.hxx

[Libreoffice-commits] core.git: connectivity/source include/connectivity sdext/source ucb/source

2017-12-28 Thread Noel Grandin

 connectivity/source/commontools/RowFunctionParser.cxx |2 +-
 connectivity/source/commontools/TTableHelper.cxx  |   10 +-
 connectivity/source/commontools/statementcomposer.cxx |2 +-
 connectivity/source/inc/RowFunctionParser.hxx |2 +-
 include/connectivity/TTableHelper.hxx |   10 +-
 include/connectivity/statementcomposer.hxx|2 +-
 sdext/source/presenter/PresenterPaneBorderPainter.cxx |4 ++--
 ucb/source/cacher/cachedcontentresultset.cxx  |2 +-
 ucb/source/cacher/cachedcontentresultset.hxx  |2 +-
 ucb/source/core/providermap.hxx   |4 ++--
 ucb/source/ucp/webdav-neon/NeonSession.hxx|2 +-
 11 files changed, 21 insertions(+), 21 deletions(-)

New commits:
commit 31f71635a136daf36d554e0c20db9ae0d1686c23
Author: Noel Grandin 
Date:   Thu Dec 28 13:48:31 2017 +0200

loplugin:passstuffbyref improved return in ucb,connectivity

Change-Id: Ib2590648c9dced87693a58a506cb62d04e37b18d
Reviewed-on: https://gerrit.libreoffice.org/47149
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/connectivity/source/commontools/RowFunctionParser.cxx 
b/connectivity/source/commontools/RowFunctionParser.cxx
index 2b3fa75b324c..afdbac9c9a52 100644
--- a/connectivity/source/commontools/RowFunctionParser.cxx
+++ b/connectivity/source/commontools/RowFunctionParser.cxx
@@ -400,7 +400,7 @@ const ParserContextSharedPtr& getParserContext()
 
 }
 
-std::shared_ptr FunctionParser::parseFunction( const OUString& 
_sFunction)
+std::shared_ptr const & FunctionParser::parseFunction( const 
OUString& _sFunction)
 {
 // TODO(Q1): Check if a combination of the RTL_UNICODETOTEXT_FLAGS_*
 // gives better conversion robustness here (we might want to map space
diff --git a/connectivity/source/commontools/TTableHelper.cxx 
b/connectivity/source/commontools/TTableHelper.cxx
index a30a19985394..2124e3366b08 100644
--- a/connectivity/source/commontools/TTableHelper.cxx
+++ b/connectivity/source/commontools/TTableHelper.cxx
@@ -594,27 +594,27 @@ OUString OTableHelper::getTypeCreatePattern() const
 return OUString();
 }
 
-Reference< XConnection> OTableHelper::getConnection() const
+Reference< XConnection> const & OTableHelper::getConnection() const
 {
 return m_pImpl->m_xConnection;
 }
 
-Reference< css::sdb::tools::XTableRename>  
OTableHelper::getRenameService() const
+Reference< css::sdb::tools::XTableRename> const & 
OTableHelper::getRenameService() const
 {
 return m_pImpl->m_xRename;
 }
 
-Reference< css::sdb::tools::XTableAlteration>  OTableHelper::getAlterService() 
const
+Reference< css::sdb::tools::XTableAlteration> const & 
OTableHelper::getAlterService() const
 {
 return m_pImpl->m_xAlter;
 }
 
-Reference< css::sdb::tools::XKeyAlteration>  OTableHelper::getKeyService() 
const
+Reference< css::sdb::tools::XKeyAlteration> const & 
OTableHelper::getKeyService() const
 {
 return m_pImpl->m_xKeyAlter;
 }
 
-Reference< css::sdb::tools::XIndexAlteration>  OTableHelper::getIndexService() 
const
+Reference< css::sdb::tools::XIndexAlteration> const & 
OTableHelper::getIndexService() const
 {
 return m_pImpl->m_xIndexAlter;
 }
diff --git a/connectivity/source/commontools/statementcomposer.cxx 
b/connectivity/source/commontools/statementcomposer.cxx
index f72afe40f2c1..499e7f167e39 100644
--- a/connectivity/source/commontools/statementcomposer.cxx
+++ b/connectivity/source/commontools/statementcomposer.cxx
@@ -266,7 +266,7 @@ namespace dbtools
 }
 
 
-Reference< XSingleSelectQueryComposer > StatementComposer::getComposer()
+Reference< XSingleSelectQueryComposer > const & 
StatementComposer::getComposer()
 {
 lcl_ensureUpToDateComposer_nothrow( *m_pData );
 return m_pData->xComposer;
diff --git a/connectivity/source/inc/RowFunctionParser.hxx 
b/connectivity/source/inc/RowFunctionParser.hxx
index df2c7ba2bf4e..b338d34e2cfe 100644
--- a/connectivity/source/inc/RowFunctionParser.hxx
+++ b/connectivity/source/inc/RowFunctionParser.hxx
@@ -97,7 +97,7 @@ public:
 @return the generated function object.
*/
 
-static std::shared_ptr parseFunction( const OUString& 
_sFunction);
+static std::shared_ptr const & parseFunction( const 
OUString& _sFunction);
 
 private:
 // disabled constructor/destructor, since this is
diff --git a/include/connectivity/TTableHelper.hxx 
b/include/connectivity/TTableHelper.hxx
index aa462dd50fc3..54d941421860 100644
--- a/include/connectivity/TTableHelper.hxx
+++ b/include/connectivity/TTableHelper.hxx
@@ -136,7 +136,7 @@ namespace connectivity
 );
 
 virtual css::uno::Reference< css::sdbc::XDatabaseMetaData> 
getMetaData() const override;
-css::uno::Reference< css::sdbc::XConnection> getConnection() const;
+css::uno::Reference< css::sdbc::XConnection> const

[Libreoffice-bugs] [Bug 114746] New: Poor Asian fonts setting in default templates of Impress

2017-12-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114746

Bug ID: 114746
Summary: Poor Asian fonts setting in default templates of
Impress
Product: LibreOffice
Version: 6.0.0.1 rc
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: LibreOffice
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: pswo10...@gmail.com

Created attachment 138729
--> https://bugs.documentfoundation.org/attachment.cgi?id=138729=edit
The screenshot of the Font tab of the "Title" style in the first slide of the
Progress template

Tested in Daily build (2017-12-28_10.01.02) and Chinese (traditional) locale
(zh-tw).

The default templates of Impress provide poor default Asian fonts settings.
Let's take the "Progress" template for example.

How reproducible: always
Reproduce Steps:
1. Install Daily Build and set the locale to Chinese (traditional) in Tools >
Options > Language Settings > Language > Language Of "Locale setting" to
"Chinese (traditional)" and enable Default Languages for Documents "Asain:"
checkbox then seclect "Chinese (traditional)"
2. Press OK and restart
3. Open Impress and select any of the default templates, such as "Progress" for
example here.

Actual Result of the styles in the first slide of the Progress template:
In the Font tab of the "Title" style:
Western Text Font
Family: Liberation SansStyle: BoldSize: 75

Asian Text Font
Family: 思源宋體Style: RegularSize: 24

In the Font tab of the "Outline 1" style:
Western Text Font
Family: Liberation SansStyle: RegularSize: 36

Asian Text Font
Family: 思源宋體Style: RegularSize: 24

Expected result:
1. Sans-serif font families should mapped to any 黑體/方體/ゴシック (Hei/Fung/Gothic
typeface). In the case of zh-tw locale, it should map to the CJK_HEADING of
zh-tw locale defined in VCL.xcu.
2. Serif font families should map to any 明體/宋體/明朝體 (Ming/Sung/Mincho typeface).
In the case of zh-tw locale, it should map to the CJK_TEXT of zh-tw locale
defined in VCL.xcu.
3. The Asian Text Font "Style" and "Size" should be in coherent with Western
Text Font Style and Size. If it is Bold and 75 points for Western Text, it is
better to be the same for Asian Text.

Bottom line:
Mostly all the templates have the problems on Asian Text Font Family, Style and
Size. It is best to have a corresponding setting for each locale. If that
cannot be done, just use the same generic font family (matchmaking for Sans and
Serif fonts), the same style (Regular, Bold, etc.), and the same size.

PS. here is a brief view of the first candidate CJK font of zh-tw locale in
VCL.xcu:
CJK_HEADING: 思源黑體 (Source Han Sans)
CJK_TEXT: 思源宋體 (Source Han Serif)
CJK_PRESENTATION: 思源黑體 (Source Han Sans)
CJK_SPREADSHEET: 思源黑體 (Source Han Sans)

--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

1 2 3 >

1 - 100 of 238 matches

Mail list logo